blob: 1ede16c8bb4081e06fde4181466b7d7ecb130ddf [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002 * Copyright (c) 2016 Facebook
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +010017#include <linux/bpf_verifier.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070018#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
Thomas Grafebb676d2016-10-27 11:23:51 +020022#include <linux/stringify.h>
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -080023#include <linux/bsearch.h>
24#include <linux/sort.h>
Yonghong Songc195651e2018-04-28 22:28:08 -070025#include <linux/perf_event.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070026
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -070027#include "disasm.h"
28
Jakub Kicinski00176a32017-10-16 16:40:54 -070029static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
30#define BPF_PROG_TYPE(_id, _name) \
31 [_id] = & _name ## _verifier_ops,
32#define BPF_MAP_TYPE(_id, _ops)
33#include <linux/bpf_types.h>
34#undef BPF_PROG_TYPE
35#undef BPF_MAP_TYPE
36};
37
Alexei Starovoitov51580e72014-09-26 00:17:02 -070038/* bpf_check() is a static code analyzer that walks eBPF program
39 * instruction by instruction and updates register/stack state.
40 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
41 *
42 * The first pass is depth-first-search to check that the program is a DAG.
43 * It rejects the following programs:
44 * - larger than BPF_MAXINSNS insns
45 * - if loop is present (detected via back-edge)
46 * - unreachable insns exist (shouldn't be a forest. program = one function)
47 * - out of bounds or malformed jumps
48 * The second pass is all possible path descent from the 1st insn.
49 * Since it's analyzing all pathes through the program, the length of the
Gary Lineba38a92017-03-01 16:25:51 +080050 * analysis is limited to 64k insn, which may be hit even if total number of
Alexei Starovoitov51580e72014-09-26 00:17:02 -070051 * insn is less then 4K, but there are too many branches that change stack/regs.
52 * Number of 'branches to be analyzed' is limited to 1k
53 *
54 * On entry to each instruction, each register has a type, and the instruction
55 * changes the types of the registers depending on instruction semantics.
56 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
57 * copied to R1.
58 *
59 * All registers are 64-bit.
60 * R0 - return register
61 * R1-R5 argument passing registers
62 * R6-R9 callee saved registers
63 * R10 - frame pointer read-only
64 *
65 * At the start of BPF program the register R1 contains a pointer to bpf_context
66 * and has type PTR_TO_CTX.
67 *
68 * Verifier tracks arithmetic operations on pointers in case:
69 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
70 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
71 * 1st insn copies R10 (which has FRAME_PTR) type into R1
72 * and 2nd arithmetic instruction is pattern matched to recognize
73 * that it wants to construct a pointer to some element within stack.
74 * So after 2nd insn, the register R1 has type PTR_TO_STACK
75 * (and -20 constant is saved for further stack bounds checking).
76 * Meaning that this reg is a pointer to stack plus known immediate constant.
77 *
Edward Creef1174f72017-08-07 15:26:19 +010078 * Most of the time the registers have SCALAR_VALUE type, which
Alexei Starovoitov51580e72014-09-26 00:17:02 -070079 * means the register has some value, but it's not a valid pointer.
Edward Creef1174f72017-08-07 15:26:19 +010080 * (like pointer plus pointer becomes SCALAR_VALUE type)
Alexei Starovoitov51580e72014-09-26 00:17:02 -070081 *
82 * When verifier sees load or store instructions the type of base register
Edward Creef1174f72017-08-07 15:26:19 +010083 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK. These are three pointer
Alexei Starovoitov51580e72014-09-26 00:17:02 -070084 * types recognized by check_mem_access() function.
85 *
86 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
87 * and the range of [ptr, ptr + map's value_size) is accessible.
88 *
89 * registers used to pass values to function calls are checked against
90 * function argument constraints.
91 *
92 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
93 * It means that the register type passed to this function must be
94 * PTR_TO_STACK and it will be used inside the function as
95 * 'pointer to map element key'
96 *
97 * For example the argument constraints for bpf_map_lookup_elem():
98 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
99 * .arg1_type = ARG_CONST_MAP_PTR,
100 * .arg2_type = ARG_PTR_TO_MAP_KEY,
101 *
102 * ret_type says that this function returns 'pointer to map elem value or null'
103 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
104 * 2nd argument should be a pointer to stack, which will be used inside
105 * the helper function as a pointer to map element key.
106 *
107 * On the kernel side the helper function looks like:
108 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
109 * {
110 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
111 * void *key = (void *) (unsigned long) r2;
112 * void *value;
113 *
114 * here kernel can access 'key' and 'map' pointers safely, knowing that
115 * [key, key + map->key_size) bytes are valid and were initialized on
116 * the stack of eBPF program.
117 * }
118 *
119 * Corresponding eBPF program may look like:
120 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
121 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
122 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
123 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
124 * here verifier looks at prototype of map_lookup_elem() and sees:
125 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
126 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
127 *
128 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
129 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
130 * and were initialized prior to this call.
131 * If it's ok, then verifier allows this BPF_CALL insn and looks at
132 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
133 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
134 * returns ether pointer to map value or NULL.
135 *
136 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
137 * insn, the register holding that pointer in the true branch changes state to
138 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
139 * branch. See check_cond_jmp_op().
140 *
141 * After the call R0 is set to return type of the function and registers R1-R5
142 * are set to NOT_INIT to indicate that they are no longer readable.
143 */
144
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700145/* verifier_state + insn_idx are pushed to stack when branch is encountered */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100146struct bpf_verifier_stack_elem {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700147 /* verifer state is 'st'
148 * before processing instruction 'insn_idx'
149 * and after processing instruction 'prev_insn_idx'
150 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100151 struct bpf_verifier_state st;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700152 int insn_idx;
153 int prev_insn_idx;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100154 struct bpf_verifier_stack_elem *next;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700155};
156
Edward Cree8e17c1b2017-08-07 15:30:30 +0100157#define BPF_COMPLEXITY_LIMIT_INSNS 131072
Daniel Borkmann07016152016-04-05 22:33:17 +0200158#define BPF_COMPLEXITY_LIMIT_STACK 1024
159
Daniel Borkmannc93552c2018-05-24 02:32:53 +0200160#define BPF_MAP_PTR_UNPRIV 1UL
161#define BPF_MAP_PTR_POISON ((void *)((0xeB9FUL << 1) + \
162 POISON_POINTER_DELTA))
163#define BPF_MAP_PTR(X) ((struct bpf_map *)((X) & ~BPF_MAP_PTR_UNPRIV))
164
165static bool bpf_map_ptr_poisoned(const struct bpf_insn_aux_data *aux)
166{
167 return BPF_MAP_PTR(aux->map_state) == BPF_MAP_PTR_POISON;
168}
169
170static bool bpf_map_ptr_unpriv(const struct bpf_insn_aux_data *aux)
171{
172 return aux->map_state & BPF_MAP_PTR_UNPRIV;
173}
174
175static void bpf_map_ptr_store(struct bpf_insn_aux_data *aux,
176 const struct bpf_map *map, bool unpriv)
177{
178 BUILD_BUG_ON((unsigned long)BPF_MAP_PTR_POISON & BPF_MAP_PTR_UNPRIV);
179 unpriv |= bpf_map_ptr_unpriv(aux);
180 aux->map_state = (unsigned long)map |
181 (unpriv ? BPF_MAP_PTR_UNPRIV : 0UL);
182}
Martin KaFai Laufad73a12017-03-22 10:00:32 -0700183
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200184struct bpf_call_arg_meta {
185 struct bpf_map *map_ptr;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200186 bool raw_mode;
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200187 bool pkt_access;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200188 int regno;
189 int access_size;
Yonghong Song849fa502018-04-28 22:28:09 -0700190 s64 msize_smax_value;
191 u64 msize_umax_value;
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200192};
193
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700194static DEFINE_MUTEX(bpf_verifier_lock);
195
Martin KaFai Lau77d2e052018-03-24 11:44:23 -0700196void bpf_verifier_vlog(struct bpf_verifier_log *log, const char *fmt,
197 va_list args)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700198{
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700199 unsigned int n;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700200
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700201 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700202
203 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
204 "verifier log line truncated - local buffer too short\n");
205
206 n = min(log->len_total - log->len_used - 1, n);
207 log->kbuf[n] = '\0';
208
209 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
210 log->len_used += n;
211 else
212 log->ubuf = NULL;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700213}
Jiri Olsaabe08842018-03-23 11:41:28 +0100214
215/* log_level controls verbosity level of eBPF verifier.
216 * bpf_verifier_log_write() is used to dump the verification trace to the log,
217 * so the user can figure out what's wrong with the program
Quentin Monnet430e68d2018-01-10 12:26:06 +0000218 */
Jiri Olsaabe08842018-03-23 11:41:28 +0100219__printf(2, 3) void bpf_verifier_log_write(struct bpf_verifier_env *env,
220 const char *fmt, ...)
221{
222 va_list args;
223
Martin KaFai Lau77d2e052018-03-24 11:44:23 -0700224 if (!bpf_verifier_log_needed(&env->log))
225 return;
226
Jiri Olsaabe08842018-03-23 11:41:28 +0100227 va_start(args, fmt);
Martin KaFai Lau77d2e052018-03-24 11:44:23 -0700228 bpf_verifier_vlog(&env->log, fmt, args);
Jiri Olsaabe08842018-03-23 11:41:28 +0100229 va_end(args);
230}
231EXPORT_SYMBOL_GPL(bpf_verifier_log_write);
232
233__printf(2, 3) static void verbose(void *private_data, const char *fmt, ...)
234{
Martin KaFai Lau77d2e052018-03-24 11:44:23 -0700235 struct bpf_verifier_env *env = private_data;
Jiri Olsaabe08842018-03-23 11:41:28 +0100236 va_list args;
237
Martin KaFai Lau77d2e052018-03-24 11:44:23 -0700238 if (!bpf_verifier_log_needed(&env->log))
239 return;
240
Jiri Olsaabe08842018-03-23 11:41:28 +0100241 va_start(args, fmt);
Martin KaFai Lau77d2e052018-03-24 11:44:23 -0700242 bpf_verifier_vlog(&env->log, fmt, args);
Jiri Olsaabe08842018-03-23 11:41:28 +0100243 va_end(args);
244}
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700245
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200246static bool type_is_pkt_pointer(enum bpf_reg_type type)
247{
248 return type == PTR_TO_PACKET ||
249 type == PTR_TO_PACKET_META;
250}
251
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700252/* string representation of 'enum bpf_reg_type' */
253static const char * const reg_type_str[] = {
254 [NOT_INIT] = "?",
Edward Creef1174f72017-08-07 15:26:19 +0100255 [SCALAR_VALUE] = "inv",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700256 [PTR_TO_CTX] = "ctx",
257 [CONST_PTR_TO_MAP] = "map_ptr",
258 [PTR_TO_MAP_VALUE] = "map_value",
259 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700260 [PTR_TO_STACK] = "fp",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700261 [PTR_TO_PACKET] = "pkt",
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200262 [PTR_TO_PACKET_META] = "pkt_meta",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700263 [PTR_TO_PACKET_END] = "pkt_end",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700264};
265
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800266static void print_liveness(struct bpf_verifier_env *env,
267 enum bpf_reg_liveness live)
268{
269 if (live & (REG_LIVE_READ | REG_LIVE_WRITTEN))
270 verbose(env, "_");
271 if (live & REG_LIVE_READ)
272 verbose(env, "r");
273 if (live & REG_LIVE_WRITTEN)
274 verbose(env, "w");
275}
276
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800277static struct bpf_func_state *func(struct bpf_verifier_env *env,
278 const struct bpf_reg_state *reg)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700279{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800280 struct bpf_verifier_state *cur = env->cur_state;
281
282 return cur->frame[reg->frameno];
283}
284
285static void print_verifier_state(struct bpf_verifier_env *env,
286 const struct bpf_func_state *state)
287{
288 const struct bpf_reg_state *reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700289 enum bpf_reg_type t;
290 int i;
291
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800292 if (state->frameno)
293 verbose(env, " frame%d:", state->frameno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700294 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700295 reg = &state->regs[i];
296 t = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700297 if (t == NOT_INIT)
298 continue;
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800299 verbose(env, " R%d", i);
300 print_liveness(env, reg->live);
301 verbose(env, "=%s", reg_type_str[t]);
Edward Creef1174f72017-08-07 15:26:19 +0100302 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
303 tnum_is_const(reg->var_off)) {
304 /* reg->off should be 0 for SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700305 verbose(env, "%lld", reg->var_off.value + reg->off);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800306 if (t == PTR_TO_STACK)
307 verbose(env, ",call_%d", func(env, reg)->callsite);
Edward Creef1174f72017-08-07 15:26:19 +0100308 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700309 verbose(env, "(id=%d", reg->id);
Edward Creef1174f72017-08-07 15:26:19 +0100310 if (t != SCALAR_VALUE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700311 verbose(env, ",off=%d", reg->off);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200312 if (type_is_pkt_pointer(t))
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700313 verbose(env, ",r=%d", reg->range);
Edward Creef1174f72017-08-07 15:26:19 +0100314 else if (t == CONST_PTR_TO_MAP ||
315 t == PTR_TO_MAP_VALUE ||
316 t == PTR_TO_MAP_VALUE_OR_NULL)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700317 verbose(env, ",ks=%d,vs=%d",
Edward Creef1174f72017-08-07 15:26:19 +0100318 reg->map_ptr->key_size,
319 reg->map_ptr->value_size);
Edward Cree7d1238f2017-08-07 15:26:56 +0100320 if (tnum_is_const(reg->var_off)) {
321 /* Typically an immediate SCALAR_VALUE, but
322 * could be a pointer whose offset is too big
323 * for reg->off
324 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700325 verbose(env, ",imm=%llx", reg->var_off.value);
Edward Cree7d1238f2017-08-07 15:26:56 +0100326 } else {
327 if (reg->smin_value != reg->umin_value &&
328 reg->smin_value != S64_MIN)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700329 verbose(env, ",smin_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100330 (long long)reg->smin_value);
331 if (reg->smax_value != reg->umax_value &&
332 reg->smax_value != S64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700333 verbose(env, ",smax_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100334 (long long)reg->smax_value);
335 if (reg->umin_value != 0)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700336 verbose(env, ",umin_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100337 (unsigned long long)reg->umin_value);
338 if (reg->umax_value != U64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700339 verbose(env, ",umax_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100340 (unsigned long long)reg->umax_value);
341 if (!tnum_is_unknown(reg->var_off)) {
342 char tn_buf[48];
Edward Creef1174f72017-08-07 15:26:19 +0100343
Edward Cree7d1238f2017-08-07 15:26:56 +0100344 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700345 verbose(env, ",var_off=%s", tn_buf);
Edward Cree7d1238f2017-08-07 15:26:56 +0100346 }
Edward Creef1174f72017-08-07 15:26:19 +0100347 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700348 verbose(env, ")");
Edward Creef1174f72017-08-07 15:26:19 +0100349 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700350 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700351 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800352 if (state->stack[i].slot_type[0] == STACK_SPILL) {
353 verbose(env, " fp%d",
354 (-i - 1) * BPF_REG_SIZE);
355 print_liveness(env, state->stack[i].spilled_ptr.live);
356 verbose(env, "=%s",
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700357 reg_type_str[state->stack[i].spilled_ptr.type]);
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800358 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -0800359 if (state->stack[i].slot_type[0] == STACK_ZERO)
360 verbose(env, " fp%d=0", (-i - 1) * BPF_REG_SIZE);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700361 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700362 verbose(env, "\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700363}
364
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800365static int copy_stack_state(struct bpf_func_state *dst,
366 const struct bpf_func_state *src)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700367{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700368 if (!src->stack)
369 return 0;
370 if (WARN_ON_ONCE(dst->allocated_stack < src->allocated_stack)) {
371 /* internal bug, make state invalid to reject the program */
372 memset(dst, 0, sizeof(*dst));
373 return -EFAULT;
374 }
375 memcpy(dst->stack, src->stack,
376 sizeof(*src->stack) * (src->allocated_stack / BPF_REG_SIZE));
377 return 0;
378}
379
380/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
381 * make it consume minimal amount of memory. check_stack_write() access from
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800382 * the program calls into realloc_func_state() to grow the stack size.
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700383 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
384 * which this function copies over. It points to previous bpf_verifier_state
385 * which is never reallocated
386 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800387static int realloc_func_state(struct bpf_func_state *state, int size,
388 bool copy_old)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700389{
390 u32 old_size = state->allocated_stack;
391 struct bpf_stack_state *new_stack;
392 int slot = size / BPF_REG_SIZE;
393
394 if (size <= old_size || !size) {
395 if (copy_old)
396 return 0;
397 state->allocated_stack = slot * BPF_REG_SIZE;
398 if (!size && old_size) {
399 kfree(state->stack);
400 state->stack = NULL;
401 }
402 return 0;
403 }
404 new_stack = kmalloc_array(slot, sizeof(struct bpf_stack_state),
405 GFP_KERNEL);
406 if (!new_stack)
407 return -ENOMEM;
408 if (copy_old) {
409 if (state->stack)
410 memcpy(new_stack, state->stack,
411 sizeof(*new_stack) * (old_size / BPF_REG_SIZE));
412 memset(new_stack + old_size / BPF_REG_SIZE, 0,
413 sizeof(*new_stack) * (size - old_size) / BPF_REG_SIZE);
414 }
415 state->allocated_stack = slot * BPF_REG_SIZE;
416 kfree(state->stack);
417 state->stack = new_stack;
418 return 0;
419}
420
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800421static void free_func_state(struct bpf_func_state *state)
422{
Alexei Starovoitov58963512018-01-08 07:51:17 -0800423 if (!state)
424 return;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800425 kfree(state->stack);
426 kfree(state);
427}
428
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700429static void free_verifier_state(struct bpf_verifier_state *state,
430 bool free_self)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700431{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800432 int i;
433
434 for (i = 0; i <= state->curframe; i++) {
435 free_func_state(state->frame[i]);
436 state->frame[i] = NULL;
437 }
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700438 if (free_self)
439 kfree(state);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700440}
441
442/* copy verifier state from src to dst growing dst stack space
443 * when necessary to accommodate larger src stack
444 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800445static int copy_func_state(struct bpf_func_state *dst,
446 const struct bpf_func_state *src)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700447{
448 int err;
449
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800450 err = realloc_func_state(dst, src->allocated_stack, false);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700451 if (err)
452 return err;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800453 memcpy(dst, src, offsetof(struct bpf_func_state, allocated_stack));
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700454 return copy_stack_state(dst, src);
455}
456
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800457static int copy_verifier_state(struct bpf_verifier_state *dst_state,
458 const struct bpf_verifier_state *src)
459{
460 struct bpf_func_state *dst;
461 int i, err;
462
463 /* if dst has more stack frames then src frame, free them */
464 for (i = src->curframe + 1; i <= dst_state->curframe; i++) {
465 free_func_state(dst_state->frame[i]);
466 dst_state->frame[i] = NULL;
467 }
468 dst_state->curframe = src->curframe;
469 dst_state->parent = src->parent;
470 for (i = 0; i <= src->curframe; i++) {
471 dst = dst_state->frame[i];
472 if (!dst) {
473 dst = kzalloc(sizeof(*dst), GFP_KERNEL);
474 if (!dst)
475 return -ENOMEM;
476 dst_state->frame[i] = dst;
477 }
478 err = copy_func_state(dst, src->frame[i]);
479 if (err)
480 return err;
481 }
482 return 0;
483}
484
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700485static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
486 int *insn_idx)
487{
488 struct bpf_verifier_state *cur = env->cur_state;
489 struct bpf_verifier_stack_elem *elem, *head = env->head;
490 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700491
492 if (env->head == NULL)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700493 return -ENOENT;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700494
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700495 if (cur) {
496 err = copy_verifier_state(cur, &head->st);
497 if (err)
498 return err;
499 }
500 if (insn_idx)
501 *insn_idx = head->insn_idx;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700502 if (prev_insn_idx)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700503 *prev_insn_idx = head->prev_insn_idx;
504 elem = head->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700505 free_verifier_state(&head->st, false);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700506 kfree(head);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700507 env->head = elem;
508 env->stack_size--;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700509 return 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700510}
511
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100512static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
513 int insn_idx, int prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700514{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700515 struct bpf_verifier_state *cur = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100516 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700517 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700518
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700519 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700520 if (!elem)
521 goto err;
522
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700523 elem->insn_idx = insn_idx;
524 elem->prev_insn_idx = prev_insn_idx;
525 elem->next = env->head;
526 env->head = elem;
527 env->stack_size++;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700528 err = copy_verifier_state(&elem->st, cur);
529 if (err)
530 goto err;
Daniel Borkmann07016152016-04-05 22:33:17 +0200531 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700532 verbose(env, "BPF program is too complex\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700533 goto err;
534 }
535 return &elem->st;
536err:
Alexei Starovoitov58963512018-01-08 07:51:17 -0800537 free_verifier_state(env->cur_state, true);
538 env->cur_state = NULL;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700539 /* pop all elements and return */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700540 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700541 return NULL;
542}
543
544#define CALLER_SAVED_REGS 6
545static const int caller_saved[CALLER_SAVED_REGS] = {
546 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
547};
548
Edward Creef1174f72017-08-07 15:26:19 +0100549static void __mark_reg_not_init(struct bpf_reg_state *reg);
550
Edward Creeb03c9f92017-08-07 15:26:36 +0100551/* Mark the unknown part of a register (variable offset or scalar value) as
552 * known to have the value @imm.
553 */
554static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
555{
556 reg->id = 0;
557 reg->var_off = tnum_const(imm);
558 reg->smin_value = (s64)imm;
559 reg->smax_value = (s64)imm;
560 reg->umin_value = imm;
561 reg->umax_value = imm;
562}
563
Edward Creef1174f72017-08-07 15:26:19 +0100564/* Mark the 'variable offset' part of a register as zero. This should be
565 * used only on registers holding a pointer type.
566 */
567static void __mark_reg_known_zero(struct bpf_reg_state *reg)
568{
Edward Creeb03c9f92017-08-07 15:26:36 +0100569 __mark_reg_known(reg, 0);
Edward Creef1174f72017-08-07 15:26:19 +0100570}
571
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -0800572static void __mark_reg_const_zero(struct bpf_reg_state *reg)
573{
574 __mark_reg_known(reg, 0);
575 reg->off = 0;
576 reg->type = SCALAR_VALUE;
577}
578
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700579static void mark_reg_known_zero(struct bpf_verifier_env *env,
580 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100581{
582 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700583 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100584 /* Something bad happened, let's kill all regs */
585 for (regno = 0; regno < MAX_BPF_REG; regno++)
586 __mark_reg_not_init(regs + regno);
587 return;
588 }
589 __mark_reg_known_zero(regs + regno);
590}
591
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200592static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
593{
594 return type_is_pkt_pointer(reg->type);
595}
596
597static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
598{
599 return reg_is_pkt_pointer(reg) ||
600 reg->type == PTR_TO_PACKET_END;
601}
602
603/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
604static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
605 enum bpf_reg_type which)
606{
607 /* The register can already have a range from prior markings.
608 * This is fine as long as it hasn't been advanced from its
609 * origin.
610 */
611 return reg->type == which &&
612 reg->id == 0 &&
613 reg->off == 0 &&
614 tnum_equals_const(reg->var_off, 0);
615}
616
Edward Creeb03c9f92017-08-07 15:26:36 +0100617/* Attempts to improve min/max values based on var_off information */
618static void __update_reg_bounds(struct bpf_reg_state *reg)
619{
620 /* min signed is max(sign bit) | min(other bits) */
621 reg->smin_value = max_t(s64, reg->smin_value,
622 reg->var_off.value | (reg->var_off.mask & S64_MIN));
623 /* max signed is min(sign bit) | max(other bits) */
624 reg->smax_value = min_t(s64, reg->smax_value,
625 reg->var_off.value | (reg->var_off.mask & S64_MAX));
626 reg->umin_value = max(reg->umin_value, reg->var_off.value);
627 reg->umax_value = min(reg->umax_value,
628 reg->var_off.value | reg->var_off.mask);
629}
630
631/* Uses signed min/max values to inform unsigned, and vice-versa */
632static void __reg_deduce_bounds(struct bpf_reg_state *reg)
633{
634 /* Learn sign from signed bounds.
635 * If we cannot cross the sign boundary, then signed and unsigned bounds
636 * are the same, so combine. This works even in the negative case, e.g.
637 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
638 */
639 if (reg->smin_value >= 0 || reg->smax_value < 0) {
640 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
641 reg->umin_value);
642 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
643 reg->umax_value);
644 return;
645 }
646 /* Learn sign from unsigned bounds. Signed bounds cross the sign
647 * boundary, so we must be careful.
648 */
649 if ((s64)reg->umax_value >= 0) {
650 /* Positive. We can't learn anything from the smin, but smax
651 * is positive, hence safe.
652 */
653 reg->smin_value = reg->umin_value;
654 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
655 reg->umax_value);
656 } else if ((s64)reg->umin_value < 0) {
657 /* Negative. We can't learn anything from the smax, but smin
658 * is negative, hence safe.
659 */
660 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
661 reg->umin_value);
662 reg->smax_value = reg->umax_value;
663 }
664}
665
666/* Attempts to improve var_off based on unsigned min/max information */
667static void __reg_bound_offset(struct bpf_reg_state *reg)
668{
669 reg->var_off = tnum_intersect(reg->var_off,
670 tnum_range(reg->umin_value,
671 reg->umax_value));
672}
673
674/* Reset the min/max bounds of a register */
675static void __mark_reg_unbounded(struct bpf_reg_state *reg)
676{
677 reg->smin_value = S64_MIN;
678 reg->smax_value = S64_MAX;
679 reg->umin_value = 0;
680 reg->umax_value = U64_MAX;
681}
682
Edward Creef1174f72017-08-07 15:26:19 +0100683/* Mark a register as having a completely unknown (scalar) value. */
684static void __mark_reg_unknown(struct bpf_reg_state *reg)
685{
686 reg->type = SCALAR_VALUE;
687 reg->id = 0;
688 reg->off = 0;
689 reg->var_off = tnum_unknown;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800690 reg->frameno = 0;
Edward Creeb03c9f92017-08-07 15:26:36 +0100691 __mark_reg_unbounded(reg);
Edward Creef1174f72017-08-07 15:26:19 +0100692}
693
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700694static void mark_reg_unknown(struct bpf_verifier_env *env,
695 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100696{
697 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700698 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
Alexei Starovoitov19ceb412017-11-30 21:31:37 -0800699 /* Something bad happened, let's kill all regs except FP */
700 for (regno = 0; regno < BPF_REG_FP; regno++)
Edward Creef1174f72017-08-07 15:26:19 +0100701 __mark_reg_not_init(regs + regno);
702 return;
703 }
704 __mark_reg_unknown(regs + regno);
705}
706
707static void __mark_reg_not_init(struct bpf_reg_state *reg)
708{
709 __mark_reg_unknown(reg);
710 reg->type = NOT_INIT;
711}
712
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700713static void mark_reg_not_init(struct bpf_verifier_env *env,
714 struct bpf_reg_state *regs, u32 regno)
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200715{
Edward Creef1174f72017-08-07 15:26:19 +0100716 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700717 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
Alexei Starovoitov19ceb412017-11-30 21:31:37 -0800718 /* Something bad happened, let's kill all regs except FP */
719 for (regno = 0; regno < BPF_REG_FP; regno++)
Edward Creef1174f72017-08-07 15:26:19 +0100720 __mark_reg_not_init(regs + regno);
721 return;
722 }
723 __mark_reg_not_init(regs + regno);
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200724}
725
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700726static void init_reg_state(struct bpf_verifier_env *env,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800727 struct bpf_func_state *state)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700728{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800729 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700730 int i;
731
Edward Creedc503a82017-08-15 20:34:35 +0100732 for (i = 0; i < MAX_BPF_REG; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700733 mark_reg_not_init(env, regs, i);
Edward Creedc503a82017-08-15 20:34:35 +0100734 regs[i].live = REG_LIVE_NONE;
735 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700736
737 /* frame pointer */
Edward Creef1174f72017-08-07 15:26:19 +0100738 regs[BPF_REG_FP].type = PTR_TO_STACK;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700739 mark_reg_known_zero(env, regs, BPF_REG_FP);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800740 regs[BPF_REG_FP].frameno = state->frameno;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700741
742 /* 1st arg to a function */
743 regs[BPF_REG_1].type = PTR_TO_CTX;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700744 mark_reg_known_zero(env, regs, BPF_REG_1);
Daniel Borkmann6760bf22016-12-18 01:52:59 +0100745}
746
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800747#define BPF_MAIN_FUNC (-1)
748static void init_func_state(struct bpf_verifier_env *env,
749 struct bpf_func_state *state,
750 int callsite, int frameno, int subprogno)
751{
752 state->callsite = callsite;
753 state->frameno = frameno;
754 state->subprogno = subprogno;
755 init_reg_state(env, state);
756}
757
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700758enum reg_arg_type {
759 SRC_OP, /* register is used as source operand */
760 DST_OP, /* register is used as destination operand */
761 DST_OP_NO_MARK /* same as above, check only, don't mark */
762};
763
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800764static int cmp_subprogs(const void *a, const void *b)
765{
Jiong Wang9c8105b2018-05-02 16:17:18 -0400766 return ((struct bpf_subprog_info *)a)->start -
767 ((struct bpf_subprog_info *)b)->start;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800768}
769
770static int find_subprog(struct bpf_verifier_env *env, int off)
771{
Jiong Wang9c8105b2018-05-02 16:17:18 -0400772 struct bpf_subprog_info *p;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800773
Jiong Wang9c8105b2018-05-02 16:17:18 -0400774 p = bsearch(&off, env->subprog_info, env->subprog_cnt,
775 sizeof(env->subprog_info[0]), cmp_subprogs);
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800776 if (!p)
777 return -ENOENT;
Jiong Wang9c8105b2018-05-02 16:17:18 -0400778 return p - env->subprog_info;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800779
780}
781
782static int add_subprog(struct bpf_verifier_env *env, int off)
783{
784 int insn_cnt = env->prog->len;
785 int ret;
786
787 if (off >= insn_cnt || off < 0) {
788 verbose(env, "call to invalid destination\n");
789 return -EINVAL;
790 }
791 ret = find_subprog(env, off);
792 if (ret >= 0)
793 return 0;
Jiong Wang4cb3d992018-05-02 16:17:19 -0400794 if (env->subprog_cnt >= BPF_MAX_SUBPROGS) {
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800795 verbose(env, "too many subprograms\n");
796 return -E2BIG;
797 }
Jiong Wang9c8105b2018-05-02 16:17:18 -0400798 env->subprog_info[env->subprog_cnt++].start = off;
799 sort(env->subprog_info, env->subprog_cnt,
800 sizeof(env->subprog_info[0]), cmp_subprogs, NULL);
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800801 return 0;
802}
803
804static int check_subprogs(struct bpf_verifier_env *env)
805{
806 int i, ret, subprog_start, subprog_end, off, cur_subprog = 0;
Jiong Wang9c8105b2018-05-02 16:17:18 -0400807 struct bpf_subprog_info *subprog = env->subprog_info;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800808 struct bpf_insn *insn = env->prog->insnsi;
809 int insn_cnt = env->prog->len;
810
Jiong Wangf910cef2018-05-02 16:17:17 -0400811 /* Add entry function. */
812 ret = add_subprog(env, 0);
813 if (ret < 0)
814 return ret;
815
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800816 /* determine subprog starts. The end is one before the next starts */
817 for (i = 0; i < insn_cnt; i++) {
818 if (insn[i].code != (BPF_JMP | BPF_CALL))
819 continue;
820 if (insn[i].src_reg != BPF_PSEUDO_CALL)
821 continue;
822 if (!env->allow_ptr_leaks) {
823 verbose(env, "function calls to other bpf functions are allowed for root only\n");
824 return -EPERM;
825 }
826 if (bpf_prog_is_dev_bound(env->prog->aux)) {
Colin Ian Kinge90004d52017-12-18 14:03:12 +0000827 verbose(env, "function calls in offloaded programs are not supported yet\n");
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800828 return -EINVAL;
829 }
830 ret = add_subprog(env, i + insn[i].imm + 1);
831 if (ret < 0)
832 return ret;
833 }
834
Jiong Wang4cb3d992018-05-02 16:17:19 -0400835 /* Add a fake 'exit' subprog which could simplify subprog iteration
836 * logic. 'subprog_cnt' should not be increased.
837 */
838 subprog[env->subprog_cnt].start = insn_cnt;
839
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800840 if (env->log.level > 1)
841 for (i = 0; i < env->subprog_cnt; i++)
Jiong Wang9c8105b2018-05-02 16:17:18 -0400842 verbose(env, "func#%d @%d\n", i, subprog[i].start);
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800843
844 /* now check that all jumps are within the same subprog */
Jiong Wang4cb3d992018-05-02 16:17:19 -0400845 subprog_start = subprog[cur_subprog].start;
846 subprog_end = subprog[cur_subprog + 1].start;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800847 for (i = 0; i < insn_cnt; i++) {
848 u8 code = insn[i].code;
849
850 if (BPF_CLASS(code) != BPF_JMP)
851 goto next;
852 if (BPF_OP(code) == BPF_EXIT || BPF_OP(code) == BPF_CALL)
853 goto next;
854 off = i + insn[i].off + 1;
855 if (off < subprog_start || off >= subprog_end) {
856 verbose(env, "jump out of range from insn %d to %d\n", i, off);
857 return -EINVAL;
858 }
859next:
860 if (i == subprog_end - 1) {
861 /* to avoid fall-through from one subprog into another
862 * the last insn of the subprog should be either exit
863 * or unconditional jump back
864 */
865 if (code != (BPF_JMP | BPF_EXIT) &&
866 code != (BPF_JMP | BPF_JA)) {
867 verbose(env, "last insn is not an exit or jmp\n");
868 return -EINVAL;
869 }
870 subprog_start = subprog_end;
Jiong Wang4cb3d992018-05-02 16:17:19 -0400871 cur_subprog++;
872 if (cur_subprog < env->subprog_cnt)
Jiong Wang9c8105b2018-05-02 16:17:18 -0400873 subprog_end = subprog[cur_subprog + 1].start;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800874 }
875 }
876 return 0;
877}
878
Colin Ian Kingfa2d41a2017-12-18 17:47:07 +0000879static
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800880struct bpf_verifier_state *skip_callee(struct bpf_verifier_env *env,
881 const struct bpf_verifier_state *state,
882 struct bpf_verifier_state *parent,
883 u32 regno)
Edward Creedc503a82017-08-15 20:34:35 +0100884{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800885 struct bpf_verifier_state *tmp = NULL;
886
887 /* 'parent' could be a state of caller and
888 * 'state' could be a state of callee. In such case
889 * parent->curframe < state->curframe
890 * and it's ok for r1 - r5 registers
891 *
892 * 'parent' could be a callee's state after it bpf_exit-ed.
893 * In such case parent->curframe > state->curframe
894 * and it's ok for r0 only
895 */
896 if (parent->curframe == state->curframe ||
897 (parent->curframe < state->curframe &&
898 regno >= BPF_REG_1 && regno <= BPF_REG_5) ||
899 (parent->curframe > state->curframe &&
900 regno == BPF_REG_0))
901 return parent;
902
903 if (parent->curframe > state->curframe &&
904 regno >= BPF_REG_6) {
905 /* for callee saved regs we have to skip the whole chain
906 * of states that belong to callee and mark as LIVE_READ
907 * the registers before the call
908 */
909 tmp = parent;
910 while (tmp && tmp->curframe != state->curframe) {
911 tmp = tmp->parent;
912 }
913 if (!tmp)
914 goto bug;
915 parent = tmp;
916 } else {
917 goto bug;
918 }
919 return parent;
920bug:
921 verbose(env, "verifier bug regno %d tmp %p\n", regno, tmp);
922 verbose(env, "regno %d parent frame %d current frame %d\n",
923 regno, parent->curframe, state->curframe);
Colin Ian Kingfa2d41a2017-12-18 17:47:07 +0000924 return NULL;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800925}
926
927static int mark_reg_read(struct bpf_verifier_env *env,
928 const struct bpf_verifier_state *state,
929 struct bpf_verifier_state *parent,
930 u32 regno)
931{
932 bool writes = parent == state->parent; /* Observe write marks */
Edward Creedc503a82017-08-15 20:34:35 +0100933
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -0700934 if (regno == BPF_REG_FP)
935 /* We don't need to worry about FP liveness because it's read-only */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800936 return 0;
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -0700937
Edward Creedc503a82017-08-15 20:34:35 +0100938 while (parent) {
939 /* if read wasn't screened by an earlier write ... */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800940 if (writes && state->frame[state->curframe]->regs[regno].live & REG_LIVE_WRITTEN)
Edward Creedc503a82017-08-15 20:34:35 +0100941 break;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800942 parent = skip_callee(env, state, parent, regno);
943 if (!parent)
944 return -EFAULT;
Edward Creedc503a82017-08-15 20:34:35 +0100945 /* ... then we depend on parent's value */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800946 parent->frame[parent->curframe]->regs[regno].live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +0100947 state = parent;
948 parent = state->parent;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800949 writes = true;
Edward Creedc503a82017-08-15 20:34:35 +0100950 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800951 return 0;
Edward Creedc503a82017-08-15 20:34:35 +0100952}
953
954static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700955 enum reg_arg_type t)
956{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800957 struct bpf_verifier_state *vstate = env->cur_state;
958 struct bpf_func_state *state = vstate->frame[vstate->curframe];
959 struct bpf_reg_state *regs = state->regs;
Edward Creedc503a82017-08-15 20:34:35 +0100960
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700961 if (regno >= MAX_BPF_REG) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700962 verbose(env, "R%d is invalid\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700963 return -EINVAL;
964 }
965
966 if (t == SRC_OP) {
967 /* check whether register used as source operand can be read */
968 if (regs[regno].type == NOT_INIT) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700969 verbose(env, "R%d !read_ok\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700970 return -EACCES;
971 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800972 return mark_reg_read(env, vstate, vstate->parent, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700973 } else {
974 /* check whether register used as dest operand can be written to */
975 if (regno == BPF_REG_FP) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700976 verbose(env, "frame pointer is read only\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700977 return -EACCES;
978 }
Edward Creedc503a82017-08-15 20:34:35 +0100979 regs[regno].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700980 if (t == DST_OP)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700981 mark_reg_unknown(env, regs, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700982 }
983 return 0;
984}
985
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700986static bool is_spillable_regtype(enum bpf_reg_type type)
987{
988 switch (type) {
989 case PTR_TO_MAP_VALUE:
990 case PTR_TO_MAP_VALUE_OR_NULL:
991 case PTR_TO_STACK:
992 case PTR_TO_CTX:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700993 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200994 case PTR_TO_PACKET_META:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700995 case PTR_TO_PACKET_END:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700996 case CONST_PTR_TO_MAP:
997 return true;
998 default:
999 return false;
1000 }
1001}
1002
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001003/* Does this register contain a constant zero? */
1004static bool register_is_null(struct bpf_reg_state *reg)
1005{
1006 return reg->type == SCALAR_VALUE && tnum_equals_const(reg->var_off, 0);
1007}
1008
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001009/* check_stack_read/write functions track spill/fill of registers,
1010 * stack boundary and alignment are checked in check_mem_access()
1011 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001012static int check_stack_write(struct bpf_verifier_env *env,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001013 struct bpf_func_state *state, /* func where register points to */
Alexei Starovoitovaf86ca42018-05-15 09:27:05 -07001014 int off, int size, int value_regno, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001015{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001016 struct bpf_func_state *cur; /* state of the current function */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001017 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001018 enum bpf_reg_type type;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001019
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001020 err = realloc_func_state(state, round_up(slot + 1, BPF_REG_SIZE),
1021 true);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001022 if (err)
1023 return err;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001024 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
1025 * so it's aligned access and [off, off + size) are within stack limits
1026 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001027 if (!env->allow_ptr_leaks &&
1028 state->stack[spi].slot_type[0] == STACK_SPILL &&
1029 size != BPF_REG_SIZE) {
1030 verbose(env, "attempt to corrupt spilled pointer on stack\n");
1031 return -EACCES;
1032 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001033
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001034 cur = env->cur_state->frame[env->cur_state->curframe];
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001035 if (value_regno >= 0 &&
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001036 is_spillable_regtype((type = cur->regs[value_regno].type))) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001037
1038 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001039 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001040 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001041 return -EACCES;
1042 }
1043
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001044 if (state != cur && type == PTR_TO_STACK) {
1045 verbose(env, "cannot spill pointers to stack into stack frame of the caller\n");
1046 return -EINVAL;
1047 }
1048
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001049 /* save register state */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001050 state->stack[spi].spilled_ptr = cur->regs[value_regno];
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001051 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001052
Alexei Starovoitovaf86ca42018-05-15 09:27:05 -07001053 for (i = 0; i < BPF_REG_SIZE; i++) {
1054 if (state->stack[spi].slot_type[i] == STACK_MISC &&
1055 !env->allow_ptr_leaks) {
1056 int *poff = &env->insn_aux_data[insn_idx].sanitize_stack_off;
1057 int soff = (-spi - 1) * BPF_REG_SIZE;
1058
1059 /* detected reuse of integer stack slot with a pointer
1060 * which means either llvm is reusing stack slot or
1061 * an attacker is trying to exploit CVE-2018-3639
1062 * (speculative store bypass)
1063 * Have to sanitize that slot with preemptive
1064 * store of zero.
1065 */
1066 if (*poff && *poff != soff) {
1067 /* disallow programs where single insn stores
1068 * into two different stack slots, since verifier
1069 * cannot sanitize them
1070 */
1071 verbose(env,
1072 "insn %d cannot access two stack slots fp%d and fp%d",
1073 insn_idx, *poff, soff);
1074 return -EINVAL;
1075 }
1076 *poff = soff;
1077 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001078 state->stack[spi].slot_type[i] = STACK_SPILL;
Alexei Starovoitovaf86ca42018-05-15 09:27:05 -07001079 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001080 } else {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001081 u8 type = STACK_MISC;
1082
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001083 /* regular write of data into stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001084 state->stack[spi].spilled_ptr = (struct bpf_reg_state) {};
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001085
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001086 /* only mark the slot as written if all 8 bytes were written
1087 * otherwise read propagation may incorrectly stop too soon
1088 * when stack slots are partially written.
1089 * This heuristic means that read propagation will be
1090 * conservative, since it will add reg_live_read marks
1091 * to stack slots all the way to first state when programs
1092 * writes+reads less than 8 bytes
1093 */
1094 if (size == BPF_REG_SIZE)
1095 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
1096
1097 /* when we zero initialize stack slots mark them as such */
1098 if (value_regno >= 0 &&
1099 register_is_null(&cur->regs[value_regno]))
1100 type = STACK_ZERO;
1101
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001102 for (i = 0; i < size; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001103 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001104 type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001105 }
1106 return 0;
1107}
1108
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001109/* registers of every function are unique and mark_reg_read() propagates
1110 * the liveness in the following cases:
1111 * - from callee into caller for R1 - R5 that were used as arguments
1112 * - from caller into callee for R0 that used as result of the call
1113 * - from caller to the same caller skipping states of the callee for R6 - R9,
1114 * since R6 - R9 are callee saved by implicit function prologue and
1115 * caller's R6 != callee's R6, so when we propagate liveness up to
1116 * parent states we need to skip callee states for R6 - R9.
1117 *
1118 * stack slot marking is different, since stacks of caller and callee are
1119 * accessible in both (since caller can pass a pointer to caller's stack to
1120 * callee which can pass it to another function), hence mark_stack_slot_read()
1121 * has to propagate the stack liveness to all parent states at given frame number.
1122 * Consider code:
1123 * f1() {
1124 * ptr = fp - 8;
1125 * *ptr = ctx;
1126 * call f2 {
1127 * .. = *ptr;
1128 * }
1129 * .. = *ptr;
1130 * }
1131 * First *ptr is reading from f1's stack and mark_stack_slot_read() has
1132 * to mark liveness at the f1's frame and not f2's frame.
1133 * Second *ptr is also reading from f1's stack and mark_stack_slot_read() has
1134 * to propagate liveness to f2 states at f1's frame level and further into
1135 * f1 states at f1's frame level until write into that stack slot
1136 */
1137static void mark_stack_slot_read(struct bpf_verifier_env *env,
1138 const struct bpf_verifier_state *state,
1139 struct bpf_verifier_state *parent,
1140 int slot, int frameno)
Edward Creedc503a82017-08-15 20:34:35 +01001141{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001142 bool writes = parent == state->parent; /* Observe write marks */
Edward Creedc503a82017-08-15 20:34:35 +01001143
1144 while (parent) {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001145 if (parent->frame[frameno]->allocated_stack <= slot * BPF_REG_SIZE)
1146 /* since LIVE_WRITTEN mark is only done for full 8-byte
1147 * write the read marks are conservative and parent
1148 * state may not even have the stack allocated. In such case
1149 * end the propagation, since the loop reached beginning
1150 * of the function
1151 */
1152 break;
Edward Creedc503a82017-08-15 20:34:35 +01001153 /* if read wasn't screened by an earlier write ... */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001154 if (writes && state->frame[frameno]->stack[slot].spilled_ptr.live & REG_LIVE_WRITTEN)
Edward Creedc503a82017-08-15 20:34:35 +01001155 break;
1156 /* ... then we depend on parent's value */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001157 parent->frame[frameno]->stack[slot].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +01001158 state = parent;
1159 parent = state->parent;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001160 writes = true;
Edward Creedc503a82017-08-15 20:34:35 +01001161 }
1162}
1163
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001164static int check_stack_read(struct bpf_verifier_env *env,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001165 struct bpf_func_state *reg_state /* func where register points to */,
1166 int off, int size, int value_regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001167{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001168 struct bpf_verifier_state *vstate = env->cur_state;
1169 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001170 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
1171 u8 *stype;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001172
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001173 if (reg_state->allocated_stack <= slot) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001174 verbose(env, "invalid read from stack off %d+0 size %d\n",
1175 off, size);
1176 return -EACCES;
1177 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001178 stype = reg_state->stack[spi].slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001179
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001180 if (stype[0] == STACK_SPILL) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001181 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001182 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001183 return -EACCES;
1184 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001185 for (i = 1; i < BPF_REG_SIZE; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001186 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001187 verbose(env, "corrupted spill memory\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001188 return -EACCES;
1189 }
1190 }
1191
Edward Creedc503a82017-08-15 20:34:35 +01001192 if (value_regno >= 0) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001193 /* restore register state from stack */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001194 state->regs[value_regno] = reg_state->stack[spi].spilled_ptr;
Alexei Starovoitov2f18f622017-11-30 21:31:38 -08001195 /* mark reg as written since spilled pointer state likely
1196 * has its liveness marks cleared by is_state_visited()
1197 * which resets stack/reg liveness for state transitions
1198 */
1199 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
Edward Creedc503a82017-08-15 20:34:35 +01001200 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001201 mark_stack_slot_read(env, vstate, vstate->parent, spi,
1202 reg_state->frameno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001203 return 0;
1204 } else {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001205 int zeros = 0;
1206
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001207 for (i = 0; i < size; i++) {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001208 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_MISC)
1209 continue;
1210 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_ZERO) {
1211 zeros++;
1212 continue;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001213 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001214 verbose(env, "invalid read from stack off %d+%d size %d\n",
1215 off, i, size);
1216 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001217 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001218 mark_stack_slot_read(env, vstate, vstate->parent, spi,
1219 reg_state->frameno);
1220 if (value_regno >= 0) {
1221 if (zeros == size) {
1222 /* any size read into register is zero extended,
1223 * so the whole register == const_zero
1224 */
1225 __mark_reg_const_zero(&state->regs[value_regno]);
1226 } else {
1227 /* have read misc data from the stack */
1228 mark_reg_unknown(env, state->regs, value_regno);
1229 }
1230 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
1231 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001232 return 0;
1233 }
1234}
1235
1236/* check read/write into map element returned by bpf_map_lookup_elem() */
Edward Creef1174f72017-08-07 15:26:19 +01001237static int __check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001238 int size, bool zero_size_allowed)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001239{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001240 struct bpf_reg_state *regs = cur_regs(env);
1241 struct bpf_map *map = regs[regno].map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001242
Yonghong Song9fd29c02017-11-12 14:49:09 -08001243 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
1244 off + size > map->value_size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001245 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001246 map->value_size, off, size);
1247 return -EACCES;
1248 }
1249 return 0;
1250}
1251
Edward Creef1174f72017-08-07 15:26:19 +01001252/* check read/write into a map element with possible variable offset */
1253static int check_map_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001254 int off, int size, bool zero_size_allowed)
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001255{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001256 struct bpf_verifier_state *vstate = env->cur_state;
1257 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001258 struct bpf_reg_state *reg = &state->regs[regno];
1259 int err;
1260
Edward Creef1174f72017-08-07 15:26:19 +01001261 /* We may have adjusted the register to this map value, so we
1262 * need to try adding each of min_value and max_value to off
1263 * to make sure our theoretical access will be safe.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001264 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001265 if (env->log.level)
1266 print_verifier_state(env, state);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001267 /* The minimum value is only important with signed
1268 * comparisons where we can't assume the floor of a
1269 * value is 0. If we are using signed variables for our
1270 * index'es we need to make sure that whatever we use
1271 * will have a set floor within our range.
1272 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001273 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001274 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001275 regno);
1276 return -EACCES;
1277 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001278 err = __check_map_access(env, regno, reg->smin_value + off, size,
1279 zero_size_allowed);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001280 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001281 verbose(env, "R%d min value is outside of the array range\n",
1282 regno);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001283 return err;
1284 }
1285
Edward Creeb03c9f92017-08-07 15:26:36 +01001286 /* If we haven't set a max value then we need to bail since we can't be
1287 * sure we won't do bad things.
1288 * If reg->umax_value + off could overflow, treat that as unbounded too.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001289 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001290 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001291 verbose(env, "R%d unbounded memory access, make sure to bounds check any array access into a map\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001292 regno);
1293 return -EACCES;
1294 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001295 err = __check_map_access(env, regno, reg->umax_value + off, size,
1296 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001297 if (err)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001298 verbose(env, "R%d max value is outside of the array range\n",
1299 regno);
Edward Creef1174f72017-08-07 15:26:19 +01001300 return err;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001301}
1302
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001303#define MAX_PACKET_OFF 0xffff
1304
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001305static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001306 const struct bpf_call_arg_meta *meta,
1307 enum bpf_access_type t)
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001308{
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001309 switch (env->prog->type) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001310 case BPF_PROG_TYPE_LWT_IN:
1311 case BPF_PROG_TYPE_LWT_OUT:
Mathieu Xhonneux004d4b22018-05-20 14:58:16 +01001312 case BPF_PROG_TYPE_LWT_SEG6LOCAL:
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001313 /* dst_input() and dst_output() can't write for now */
1314 if (t == BPF_WRITE)
1315 return false;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +01001316 /* fallthrough */
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001317 case BPF_PROG_TYPE_SCHED_CLS:
1318 case BPF_PROG_TYPE_SCHED_ACT:
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001319 case BPF_PROG_TYPE_XDP:
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001320 case BPF_PROG_TYPE_LWT_XMIT:
John Fastabend8a31db52017-08-15 22:33:09 -07001321 case BPF_PROG_TYPE_SK_SKB:
John Fastabend4f738ad2018-03-18 12:57:10 -07001322 case BPF_PROG_TYPE_SK_MSG:
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001323 if (meta)
1324 return meta->pkt_access;
1325
1326 env->seen_direct_write = true;
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001327 return true;
1328 default:
1329 return false;
1330 }
1331}
1332
Edward Creef1174f72017-08-07 15:26:19 +01001333static int __check_packet_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001334 int off, int size, bool zero_size_allowed)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001335{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001336 struct bpf_reg_state *regs = cur_regs(env);
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001337 struct bpf_reg_state *reg = &regs[regno];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001338
Yonghong Song9fd29c02017-11-12 14:49:09 -08001339 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
1340 (u64)off + size > reg->range) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001341 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -07001342 off, size, regno, reg->id, reg->off, reg->range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001343 return -EACCES;
1344 }
1345 return 0;
1346}
1347
Edward Creef1174f72017-08-07 15:26:19 +01001348static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001349 int size, bool zero_size_allowed)
Edward Creef1174f72017-08-07 15:26:19 +01001350{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001351 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +01001352 struct bpf_reg_state *reg = &regs[regno];
1353 int err;
1354
1355 /* We may have added a variable offset to the packet pointer; but any
1356 * reg->range we have comes after that. We are only checking the fixed
1357 * offset.
1358 */
1359
1360 /* We don't allow negative numbers, because we aren't tracking enough
1361 * detail to prove they're safe.
1362 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001363 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001364 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Edward Creef1174f72017-08-07 15:26:19 +01001365 regno);
1366 return -EACCES;
1367 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001368 err = __check_packet_access(env, regno, off, size, zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001369 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001370 verbose(env, "R%d offset is outside of the packet\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +01001371 return err;
1372 }
1373 return err;
1374}
1375
1376/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
Yonghong Song31fd8582017-06-13 15:52:13 -07001377static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
Alexei Starovoitov19de99f2016-06-15 18:25:38 -07001378 enum bpf_access_type t, enum bpf_reg_type *reg_type)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001379{
Daniel Borkmannf96da092017-07-02 02:13:27 +02001380 struct bpf_insn_access_aux info = {
1381 .reg_type = *reg_type,
1382 };
Yonghong Song31fd8582017-06-13 15:52:13 -07001383
Jakub Kicinski4f9218a2017-10-16 16:40:55 -07001384 if (env->ops->is_valid_access &&
Andrey Ignatov5e43f892018-03-30 15:08:00 -07001385 env->ops->is_valid_access(off, size, t, env->prog, &info)) {
Daniel Borkmannf96da092017-07-02 02:13:27 +02001386 /* A non zero info.ctx_field_size indicates that this field is a
1387 * candidate for later verifier transformation to load the whole
1388 * field and then apply a mask when accessed with a narrower
1389 * access than actual ctx access size. A zero info.ctx_field_size
1390 * will only allow for whole field access and rejects any other
1391 * type of narrower access.
Yonghong Song31fd8582017-06-13 15:52:13 -07001392 */
Yonghong Song23994632017-06-22 15:07:39 -07001393 *reg_type = info.reg_type;
Yonghong Song31fd8582017-06-13 15:52:13 -07001394
Jakub Kicinski4f9218a2017-10-16 16:40:55 -07001395 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -07001396 /* remember the offset of last byte accessed in ctx */
1397 if (env->prog->aux->max_ctx_offset < off + size)
1398 env->prog->aux->max_ctx_offset = off + size;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001399 return 0;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -07001400 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001401
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001402 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001403 return -EACCES;
1404}
1405
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001406static bool __is_pointer_value(bool allow_ptr_leaks,
1407 const struct bpf_reg_state *reg)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001408{
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001409 if (allow_ptr_leaks)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001410 return false;
1411
Edward Creef1174f72017-08-07 15:26:19 +01001412 return reg->type != SCALAR_VALUE;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001413}
1414
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001415static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
1416{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001417 return __is_pointer_value(env->allow_ptr_leaks, cur_regs(env) + regno);
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001418}
1419
Daniel Borkmannf37a8cb2018-01-16 23:30:10 +01001420static bool is_ctx_reg(struct bpf_verifier_env *env, int regno)
1421{
1422 const struct bpf_reg_state *reg = cur_regs(env) + regno;
1423
1424 return reg->type == PTR_TO_CTX;
1425}
1426
Daniel Borkmannca369602018-02-23 22:29:05 +01001427static bool is_pkt_reg(struct bpf_verifier_env *env, int regno)
1428{
1429 const struct bpf_reg_state *reg = cur_regs(env) + regno;
1430
1431 return type_is_pkt_pointer(reg->type);
1432}
1433
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001434static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
1435 const struct bpf_reg_state *reg,
David S. Millerd1174412017-05-10 11:22:52 -07001436 int off, int size, bool strict)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001437{
Edward Creef1174f72017-08-07 15:26:19 +01001438 struct tnum reg_off;
David S. Millere07b98d2017-05-10 11:38:07 -07001439 int ip_align;
David S. Millerd1174412017-05-10 11:22:52 -07001440
1441 /* Byte size accesses are always allowed. */
1442 if (!strict || size == 1)
1443 return 0;
1444
David S. Millere4eda882017-05-22 12:27:07 -04001445 /* For platforms that do not have a Kconfig enabling
1446 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
1447 * NET_IP_ALIGN is universally set to '2'. And on platforms
1448 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
1449 * to this code only in strict mode where we want to emulate
1450 * the NET_IP_ALIGN==2 checking. Therefore use an
1451 * unconditional IP align value of '2'.
David S. Millere07b98d2017-05-10 11:38:07 -07001452 */
David S. Millere4eda882017-05-22 12:27:07 -04001453 ip_align = 2;
Edward Creef1174f72017-08-07 15:26:19 +01001454
1455 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
1456 if (!tnum_is_aligned(reg_off, size)) {
1457 char tn_buf[48];
1458
1459 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001460 verbose(env,
1461 "misaligned packet access off %d+%s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001462 ip_align, tn_buf, reg->off, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001463 return -EACCES;
1464 }
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001465
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001466 return 0;
1467}
1468
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001469static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
1470 const struct bpf_reg_state *reg,
Edward Creef1174f72017-08-07 15:26:19 +01001471 const char *pointer_desc,
1472 int off, int size, bool strict)
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001473{
Edward Creef1174f72017-08-07 15:26:19 +01001474 struct tnum reg_off;
1475
1476 /* Byte size accesses are always allowed. */
1477 if (!strict || size == 1)
1478 return 0;
1479
1480 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
1481 if (!tnum_is_aligned(reg_off, size)) {
1482 char tn_buf[48];
1483
1484 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001485 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001486 pointer_desc, tn_buf, reg->off, off, size);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001487 return -EACCES;
1488 }
1489
1490 return 0;
1491}
1492
David S. Millere07b98d2017-05-10 11:38:07 -07001493static int check_ptr_alignment(struct bpf_verifier_env *env,
Daniel Borkmannca369602018-02-23 22:29:05 +01001494 const struct bpf_reg_state *reg, int off,
1495 int size, bool strict_alignment_once)
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001496{
Daniel Borkmannca369602018-02-23 22:29:05 +01001497 bool strict = env->strict_alignment || strict_alignment_once;
Edward Creef1174f72017-08-07 15:26:19 +01001498 const char *pointer_desc = "";
David S. Millerd1174412017-05-10 11:22:52 -07001499
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001500 switch (reg->type) {
1501 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001502 case PTR_TO_PACKET_META:
1503 /* Special case, because of NET_IP_ALIGN. Given metadata sits
1504 * right in front, treat it the very same way.
1505 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001506 return check_pkt_ptr_alignment(env, reg, off, size, strict);
Edward Creef1174f72017-08-07 15:26:19 +01001507 case PTR_TO_MAP_VALUE:
1508 pointer_desc = "value ";
1509 break;
1510 case PTR_TO_CTX:
1511 pointer_desc = "context ";
1512 break;
1513 case PTR_TO_STACK:
1514 pointer_desc = "stack ";
Jann Horna5ec6ae2017-12-18 20:11:58 -08001515 /* The stack spill tracking logic in check_stack_write()
1516 * and check_stack_read() relies on stack accesses being
1517 * aligned.
1518 */
1519 strict = true;
Edward Creef1174f72017-08-07 15:26:19 +01001520 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001521 default:
Edward Creef1174f72017-08-07 15:26:19 +01001522 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001523 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001524 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
1525 strict);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001526}
1527
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001528static int update_stack_depth(struct bpf_verifier_env *env,
1529 const struct bpf_func_state *func,
1530 int off)
1531{
Jiong Wang9c8105b2018-05-02 16:17:18 -04001532 u16 stack = env->subprog_info[func->subprogno].stack_depth;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001533
1534 if (stack >= -off)
1535 return 0;
1536
1537 /* update known max for given subprogram */
Jiong Wang9c8105b2018-05-02 16:17:18 -04001538 env->subprog_info[func->subprogno].stack_depth = -off;
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001539 return 0;
1540}
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001541
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001542/* starting from main bpf function walk all instructions of the function
1543 * and recursively walk all callees that given function can call.
1544 * Ignore jump and exit insns.
1545 * Since recursion is prevented by check_cfg() this algorithm
1546 * only needs a local stack of MAX_CALL_FRAMES to remember callsites
1547 */
1548static int check_max_stack_depth(struct bpf_verifier_env *env)
1549{
Jiong Wang9c8105b2018-05-02 16:17:18 -04001550 int depth = 0, frame = 0, idx = 0, i = 0, subprog_end;
1551 struct bpf_subprog_info *subprog = env->subprog_info;
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001552 struct bpf_insn *insn = env->prog->insnsi;
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001553 int ret_insn[MAX_CALL_FRAMES];
1554 int ret_prog[MAX_CALL_FRAMES];
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001555
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001556process_func:
1557 /* round up to 32-bytes, since this is granularity
1558 * of interpreter stack size
1559 */
Jiong Wang9c8105b2018-05-02 16:17:18 -04001560 depth += round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001561 if (depth > MAX_BPF_STACK) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001562 verbose(env, "combined stack size of %d calls is %d. Too large\n",
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001563 frame + 1, depth);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001564 return -EACCES;
1565 }
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001566continue_func:
Jiong Wang4cb3d992018-05-02 16:17:19 -04001567 subprog_end = subprog[idx + 1].start;
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001568 for (; i < subprog_end; i++) {
1569 if (insn[i].code != (BPF_JMP | BPF_CALL))
1570 continue;
1571 if (insn[i].src_reg != BPF_PSEUDO_CALL)
1572 continue;
1573 /* remember insn and function to return to */
1574 ret_insn[frame] = i + 1;
Jiong Wang9c8105b2018-05-02 16:17:18 -04001575 ret_prog[frame] = idx;
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001576
1577 /* find the callee */
1578 i = i + insn[i].imm + 1;
Jiong Wang9c8105b2018-05-02 16:17:18 -04001579 idx = find_subprog(env, i);
1580 if (idx < 0) {
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001581 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
1582 i);
1583 return -EFAULT;
1584 }
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001585 frame++;
1586 if (frame >= MAX_CALL_FRAMES) {
1587 WARN_ONCE(1, "verifier bug. Call stack is too deep\n");
1588 return -EFAULT;
1589 }
1590 goto process_func;
1591 }
1592 /* end of for() loop means the last insn of the 'subprog'
1593 * was reached. Doesn't matter whether it was JA or EXIT
1594 */
1595 if (frame == 0)
1596 return 0;
Jiong Wang9c8105b2018-05-02 16:17:18 -04001597 depth -= round_up(max_t(u32, subprog[idx].stack_depth, 1), 32);
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001598 frame--;
1599 i = ret_insn[frame];
Jiong Wang9c8105b2018-05-02 16:17:18 -04001600 idx = ret_prog[frame];
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001601 goto continue_func;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001602}
1603
David S. Miller19d28fb2018-01-11 21:27:54 -05001604#ifndef CONFIG_BPF_JIT_ALWAYS_ON
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08001605static int get_callee_stack_depth(struct bpf_verifier_env *env,
1606 const struct bpf_insn *insn, int idx)
1607{
1608 int start = idx + insn->imm + 1, subprog;
1609
1610 subprog = find_subprog(env, start);
1611 if (subprog < 0) {
1612 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
1613 start);
1614 return -EFAULT;
1615 }
Jiong Wang9c8105b2018-05-02 16:17:18 -04001616 return env->subprog_info[subprog].stack_depth;
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08001617}
David S. Miller19d28fb2018-01-11 21:27:54 -05001618#endif
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08001619
Daniel Borkmann58990d12018-06-07 17:40:03 +02001620static int check_ctx_reg(struct bpf_verifier_env *env,
1621 const struct bpf_reg_state *reg, int regno)
1622{
1623 /* Access to ctx or passing it to a helper is only allowed in
1624 * its original, unmodified form.
1625 */
1626
1627 if (reg->off) {
1628 verbose(env, "dereference of modified ctx ptr R%d off=%d disallowed\n",
1629 regno, reg->off);
1630 return -EACCES;
1631 }
1632
1633 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
1634 char tn_buf[48];
1635
1636 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
1637 verbose(env, "variable ctx access var_off=%s disallowed\n", tn_buf);
1638 return -EACCES;
1639 }
1640
1641 return 0;
1642}
1643
Jann Horn0c17d1d2017-12-18 20:11:55 -08001644/* truncate register to smaller size (in bytes)
1645 * must be called with size < BPF_REG_SIZE
1646 */
1647static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
1648{
1649 u64 mask;
1650
1651 /* clear high bits in bit representation */
1652 reg->var_off = tnum_cast(reg->var_off, size);
1653
1654 /* fix arithmetic bounds */
1655 mask = ((u64)1 << (size * 8)) - 1;
1656 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
1657 reg->umin_value &= mask;
1658 reg->umax_value &= mask;
1659 } else {
1660 reg->umin_value = 0;
1661 reg->umax_value = mask;
1662 }
1663 reg->smin_value = reg->umin_value;
1664 reg->smax_value = reg->umax_value;
1665}
1666
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001667/* check whether memory at (regno + off) is accessible for t = (read | write)
1668 * if t==write, value_regno is a register which value is stored into memory
1669 * if t==read, value_regno is a register which will receive the value from memory
1670 * if t==write && value_regno==-1, some unknown value is stored into memory
1671 * if t==read && value_regno==-1, don't care what we read from memory
1672 */
Daniel Borkmannca369602018-02-23 22:29:05 +01001673static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno,
1674 int off, int bpf_size, enum bpf_access_type t,
1675 int value_regno, bool strict_alignment_once)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001676{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001677 struct bpf_reg_state *regs = cur_regs(env);
1678 struct bpf_reg_state *reg = regs + regno;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001679 struct bpf_func_state *state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001680 int size, err = 0;
1681
1682 size = bpf_size_to_bytes(bpf_size);
1683 if (size < 0)
1684 return size;
1685
Edward Creef1174f72017-08-07 15:26:19 +01001686 /* alignment checks will add in reg->off themselves */
Daniel Borkmannca369602018-02-23 22:29:05 +01001687 err = check_ptr_alignment(env, reg, off, size, strict_alignment_once);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001688 if (err)
1689 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001690
Edward Creef1174f72017-08-07 15:26:19 +01001691 /* for access checks, reg->off is just part of off */
1692 off += reg->off;
1693
1694 if (reg->type == PTR_TO_MAP_VALUE) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001695 if (t == BPF_WRITE && value_regno >= 0 &&
1696 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001697 verbose(env, "R%d leaks addr into map\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001698 return -EACCES;
1699 }
Josef Bacik48461132016-09-28 10:54:32 -04001700
Yonghong Song9fd29c02017-11-12 14:49:09 -08001701 err = check_map_access(env, regno, off, size, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001702 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001703 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001704
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001705 } else if (reg->type == PTR_TO_CTX) {
Edward Creef1174f72017-08-07 15:26:19 +01001706 enum bpf_reg_type reg_type = SCALAR_VALUE;
Alexei Starovoitov19de99f2016-06-15 18:25:38 -07001707
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001708 if (t == BPF_WRITE && value_regno >= 0 &&
1709 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001710 verbose(env, "R%d leaks addr into ctx\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001711 return -EACCES;
1712 }
Edward Creef1174f72017-08-07 15:26:19 +01001713
Daniel Borkmann58990d12018-06-07 17:40:03 +02001714 err = check_ctx_reg(env, reg, regno);
1715 if (err < 0)
1716 return err;
1717
Yonghong Song31fd8582017-06-13 15:52:13 -07001718 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001719 if (!err && t == BPF_READ && value_regno >= 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001720 /* ctx access returns either a scalar, or a
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001721 * PTR_TO_PACKET[_META,_END]. In the latter
1722 * case, we know the offset is zero.
Edward Creef1174f72017-08-07 15:26:19 +01001723 */
1724 if (reg_type == SCALAR_VALUE)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001725 mark_reg_unknown(env, regs, value_regno);
Edward Creef1174f72017-08-07 15:26:19 +01001726 else
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001727 mark_reg_known_zero(env, regs,
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001728 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001729 regs[value_regno].id = 0;
1730 regs[value_regno].off = 0;
1731 regs[value_regno].range = 0;
1732 regs[value_regno].type = reg_type;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001733 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001734
Edward Creef1174f72017-08-07 15:26:19 +01001735 } else if (reg->type == PTR_TO_STACK) {
1736 /* stack accesses must be at a fixed offset, so that we can
1737 * determine what type of data were returned.
1738 * See check_stack_read().
1739 */
1740 if (!tnum_is_const(reg->var_off)) {
1741 char tn_buf[48];
1742
1743 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001744 verbose(env, "variable stack access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001745 tn_buf, off, size);
1746 return -EACCES;
1747 }
1748 off += reg->var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001749 if (off >= 0 || off < -MAX_BPF_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001750 verbose(env, "invalid stack off=%d size=%d\n", off,
1751 size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001752 return -EACCES;
1753 }
Alexei Starovoitov87266792017-05-30 13:31:29 -07001754
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001755 state = func(env, reg);
1756 err = update_stack_depth(env, state, off);
1757 if (err)
1758 return err;
Alexei Starovoitov87266792017-05-30 13:31:29 -07001759
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001760 if (t == BPF_WRITE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001761 err = check_stack_write(env, state, off, size,
Alexei Starovoitovaf86ca42018-05-15 09:27:05 -07001762 value_regno, insn_idx);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001763 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001764 err = check_stack_read(env, state, off, size,
1765 value_regno);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001766 } else if (reg_is_pkt_pointer(reg)) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001767 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001768 verbose(env, "cannot write into packet\n");
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001769 return -EACCES;
1770 }
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001771 if (t == BPF_WRITE && value_regno >= 0 &&
1772 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001773 verbose(env, "R%d leaks addr into packet\n",
1774 value_regno);
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001775 return -EACCES;
1776 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001777 err = check_packet_access(env, regno, off, size, false);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001778 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001779 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001780 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001781 verbose(env, "R%d invalid mem access '%s'\n", regno,
1782 reg_type_str[reg->type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001783 return -EACCES;
1784 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001785
Edward Creef1174f72017-08-07 15:26:19 +01001786 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001787 regs[value_regno].type == SCALAR_VALUE) {
Edward Creef1174f72017-08-07 15:26:19 +01001788 /* b/h/w load zero-extends, mark upper bits as known 0 */
Jann Horn0c17d1d2017-12-18 20:11:55 -08001789 coerce_reg_to_size(&regs[value_regno], size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001790 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001791 return err;
1792}
1793
Yonghong Song31fd8582017-06-13 15:52:13 -07001794static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001795{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001796 int err;
1797
1798 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
1799 insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001800 verbose(env, "BPF_XADD uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001801 return -EINVAL;
1802 }
1803
1804 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001805 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001806 if (err)
1807 return err;
1808
1809 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001810 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001811 if (err)
1812 return err;
1813
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001814 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001815 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001816 return -EACCES;
1817 }
1818
Daniel Borkmannca369602018-02-23 22:29:05 +01001819 if (is_ctx_reg(env, insn->dst_reg) ||
1820 is_pkt_reg(env, insn->dst_reg)) {
1821 verbose(env, "BPF_XADD stores into R%d %s is not allowed\n",
1822 insn->dst_reg, is_ctx_reg(env, insn->dst_reg) ?
1823 "context" : "packet");
Daniel Borkmannf37a8cb2018-01-16 23:30:10 +01001824 return -EACCES;
1825 }
1826
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001827 /* check whether atomic_add can read the memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001828 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Daniel Borkmannca369602018-02-23 22:29:05 +01001829 BPF_SIZE(insn->code), BPF_READ, -1, true);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001830 if (err)
1831 return err;
1832
1833 /* check whether atomic_add can write into the same memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001834 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Daniel Borkmannca369602018-02-23 22:29:05 +01001835 BPF_SIZE(insn->code), BPF_WRITE, -1, true);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001836}
1837
1838/* when register 'regno' is passed into function that will read 'access_size'
1839 * bytes from that pointer, make sure that it's within stack boundary
Edward Creef1174f72017-08-07 15:26:19 +01001840 * and all elements of stack are initialized.
1841 * Unlike most pointer bounds-checking functions, this one doesn't take an
1842 * 'off' argument, so it has to add in reg->off itself.
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001843 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001844static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
Daniel Borkmann435faee12016-04-13 00:10:51 +02001845 int access_size, bool zero_size_allowed,
1846 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001847{
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001848 struct bpf_reg_state *reg = cur_regs(env) + regno;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001849 struct bpf_func_state *state = func(env, reg);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001850 int off, i, slot, spi;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001851
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001852 if (reg->type != PTR_TO_STACK) {
Edward Creef1174f72017-08-07 15:26:19 +01001853 /* Allow zero-byte read from NULL, regardless of pointer type */
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001854 if (zero_size_allowed && access_size == 0 &&
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001855 register_is_null(reg))
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001856 return 0;
1857
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001858 verbose(env, "R%d type=%s expected=%s\n", regno,
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001859 reg_type_str[reg->type],
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001860 reg_type_str[PTR_TO_STACK]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001861 return -EACCES;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001862 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001863
Edward Creef1174f72017-08-07 15:26:19 +01001864 /* Only allow fixed-offset stack reads */
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001865 if (!tnum_is_const(reg->var_off)) {
Edward Creef1174f72017-08-07 15:26:19 +01001866 char tn_buf[48];
1867
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001868 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001869 verbose(env, "invalid variable stack read R%d var_off=%s\n",
Edward Creef1174f72017-08-07 15:26:19 +01001870 regno, tn_buf);
Jann Hornea25f912017-12-18 20:11:57 -08001871 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01001872 }
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001873 off = reg->off + reg->var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001874 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
Yonghong Song9fd29c02017-11-12 14:49:09 -08001875 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001876 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001877 regno, off, access_size);
1878 return -EACCES;
1879 }
1880
Daniel Borkmann435faee12016-04-13 00:10:51 +02001881 if (meta && meta->raw_mode) {
1882 meta->access_size = access_size;
1883 meta->regno = regno;
1884 return 0;
1885 }
1886
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001887 for (i = 0; i < access_size; i++) {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001888 u8 *stype;
1889
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001890 slot = -(off + i) - 1;
1891 spi = slot / BPF_REG_SIZE;
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001892 if (state->allocated_stack <= slot)
1893 goto err;
1894 stype = &state->stack[spi].slot_type[slot % BPF_REG_SIZE];
1895 if (*stype == STACK_MISC)
1896 goto mark;
1897 if (*stype == STACK_ZERO) {
1898 /* helper can write anything into the stack */
1899 *stype = STACK_MISC;
1900 goto mark;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001901 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001902err:
1903 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
1904 off, i, access_size);
1905 return -EACCES;
1906mark:
1907 /* reading any byte out of 8-byte 'spill_slot' will cause
1908 * the whole slot to be marked as 'read'
1909 */
1910 mark_stack_slot_read(env, env->cur_state, env->cur_state->parent,
1911 spi, state->frameno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001912 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001913 return update_stack_depth(env, state, off);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001914}
1915
Gianluca Borello06c1c042017-01-09 10:19:49 -08001916static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
1917 int access_size, bool zero_size_allowed,
1918 struct bpf_call_arg_meta *meta)
1919{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001920 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Gianluca Borello06c1c042017-01-09 10:19:49 -08001921
Edward Creef1174f72017-08-07 15:26:19 +01001922 switch (reg->type) {
Gianluca Borello06c1c042017-01-09 10:19:49 -08001923 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001924 case PTR_TO_PACKET_META:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001925 return check_packet_access(env, regno, reg->off, access_size,
1926 zero_size_allowed);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001927 case PTR_TO_MAP_VALUE:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001928 return check_map_access(env, regno, reg->off, access_size,
1929 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001930 default: /* scalar_value|ptr_to_stack or invalid ptr */
Gianluca Borello06c1c042017-01-09 10:19:49 -08001931 return check_stack_boundary(env, regno, access_size,
1932 zero_size_allowed, meta);
1933 }
1934}
1935
Daniel Borkmann90133412018-01-20 01:24:29 +01001936static bool arg_type_is_mem_ptr(enum bpf_arg_type type)
1937{
1938 return type == ARG_PTR_TO_MEM ||
1939 type == ARG_PTR_TO_MEM_OR_NULL ||
1940 type == ARG_PTR_TO_UNINIT_MEM;
1941}
1942
1943static bool arg_type_is_mem_size(enum bpf_arg_type type)
1944{
1945 return type == ARG_CONST_SIZE ||
1946 type == ARG_CONST_SIZE_OR_ZERO;
1947}
1948
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001949static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001950 enum bpf_arg_type arg_type,
1951 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001952{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001953 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001954 enum bpf_reg_type expected_type, type = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001955 int err = 0;
1956
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001957 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001958 return 0;
1959
Edward Creedc503a82017-08-15 20:34:35 +01001960 err = check_reg_arg(env, regno, SRC_OP);
1961 if (err)
1962 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001963
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001964 if (arg_type == ARG_ANYTHING) {
1965 if (is_pointer_value(env, regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001966 verbose(env, "R%d leaks addr into helper function\n",
1967 regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001968 return -EACCES;
1969 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001970 return 0;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001971 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001972
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001973 if (type_is_pkt_pointer(type) &&
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001974 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001975 verbose(env, "helper access to the packet is not allowed\n");
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001976 return -EACCES;
1977 }
1978
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001979 if (arg_type == ARG_PTR_TO_MAP_KEY ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001980 arg_type == ARG_PTR_TO_MAP_VALUE) {
1981 expected_type = PTR_TO_STACK;
Paul Chaignond71962f2018-04-24 15:07:54 +02001982 if (!type_is_pkt_pointer(type) && type != PTR_TO_MAP_VALUE &&
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001983 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001984 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001985 } else if (arg_type == ARG_CONST_SIZE ||
1986 arg_type == ARG_CONST_SIZE_OR_ZERO) {
Edward Creef1174f72017-08-07 15:26:19 +01001987 expected_type = SCALAR_VALUE;
1988 if (type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001989 goto err_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001990 } else if (arg_type == ARG_CONST_MAP_PTR) {
1991 expected_type = CONST_PTR_TO_MAP;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001992 if (type != expected_type)
1993 goto err_type;
Alexei Starovoitov608cd712015-03-26 19:53:57 -07001994 } else if (arg_type == ARG_PTR_TO_CTX) {
1995 expected_type = PTR_TO_CTX;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001996 if (type != expected_type)
1997 goto err_type;
Daniel Borkmann58990d12018-06-07 17:40:03 +02001998 err = check_ctx_reg(env, reg, regno);
1999 if (err < 0)
2000 return err;
Daniel Borkmann90133412018-01-20 01:24:29 +01002001 } else if (arg_type_is_mem_ptr(arg_type)) {
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01002002 expected_type = PTR_TO_STACK;
2003 /* One exception here. In case function allows for NULL to be
Edward Creef1174f72017-08-07 15:26:19 +01002004 * passed in as argument, it's a SCALAR_VALUE type. Final test
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01002005 * happens during stack boundary checking.
2006 */
Alexei Starovoitov914cb782017-11-30 21:31:40 -08002007 if (register_is_null(reg) &&
Gianluca Borellodb1ac492017-11-22 18:32:53 +00002008 arg_type == ARG_PTR_TO_MEM_OR_NULL)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07002009 /* final test in check_stack_boundary() */;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002010 else if (!type_is_pkt_pointer(type) &&
2011 type != PTR_TO_MAP_VALUE &&
Edward Creef1174f72017-08-07 15:26:19 +01002012 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07002013 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002014 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002015 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002016 verbose(env, "unsupported arg_type %d\n", arg_type);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002017 return -EFAULT;
2018 }
2019
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002020 if (arg_type == ARG_CONST_MAP_PTR) {
2021 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002022 meta->map_ptr = reg->map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002023 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
2024 /* bpf_map_xxx(..., map_ptr, ..., key) call:
2025 * check that [key, key + map->key_size) are within
2026 * stack limits and initialized
2027 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002028 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002029 /* in function declaration map_ptr must come before
2030 * map_key, so that it's verified and known before
2031 * we have to check map_key here. Otherwise it means
2032 * that kernel subsystem misconfigured verifier
2033 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002034 verbose(env, "invalid map_ptr to access map->key\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002035 return -EACCES;
2036 }
Paul Chaignond71962f2018-04-24 15:07:54 +02002037 err = check_helper_mem_access(env, regno,
2038 meta->map_ptr->key_size, false,
2039 NULL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002040 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
2041 /* bpf_map_xxx(..., map_ptr, ..., value) call:
2042 * check [value, value + map->value_size) validity
2043 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002044 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002045 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002046 verbose(env, "invalid map_ptr to access map->value\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002047 return -EACCES;
2048 }
Paul Chaignond71962f2018-04-24 15:07:54 +02002049 err = check_helper_mem_access(env, regno,
2050 meta->map_ptr->value_size, false,
2051 NULL);
Daniel Borkmann90133412018-01-20 01:24:29 +01002052 } else if (arg_type_is_mem_size(arg_type)) {
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002053 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002054
Yonghong Song849fa502018-04-28 22:28:09 -07002055 /* remember the mem_size which may be used later
2056 * to refine return values.
2057 */
2058 meta->msize_smax_value = reg->smax_value;
2059 meta->msize_umax_value = reg->umax_value;
2060
Edward Creef1174f72017-08-07 15:26:19 +01002061 /* The register is SCALAR_VALUE; the access check
2062 * happens using its boundaries.
Gianluca Borello06c1c042017-01-09 10:19:49 -08002063 */
Edward Creef1174f72017-08-07 15:26:19 +01002064 if (!tnum_is_const(reg->var_off))
Gianluca Borello06c1c042017-01-09 10:19:49 -08002065 /* For unprivileged variable accesses, disable raw
2066 * mode so that the program is required to
2067 * initialize all the memory that the helper could
2068 * just partially fill up.
2069 */
2070 meta = NULL;
2071
Edward Creeb03c9f92017-08-07 15:26:36 +01002072 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002073 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
Edward Creef1174f72017-08-07 15:26:19 +01002074 regno);
2075 return -EACCES;
2076 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08002077
Edward Creeb03c9f92017-08-07 15:26:36 +01002078 if (reg->umin_value == 0) {
Edward Creef1174f72017-08-07 15:26:19 +01002079 err = check_helper_mem_access(env, regno - 1, 0,
2080 zero_size_allowed,
2081 meta);
Gianluca Borello06c1c042017-01-09 10:19:49 -08002082 if (err)
2083 return err;
Gianluca Borello06c1c042017-01-09 10:19:49 -08002084 }
Edward Creef1174f72017-08-07 15:26:19 +01002085
Edward Creeb03c9f92017-08-07 15:26:36 +01002086 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002087 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
Edward Creef1174f72017-08-07 15:26:19 +01002088 regno);
2089 return -EACCES;
2090 }
2091 err = check_helper_mem_access(env, regno - 1,
Edward Creeb03c9f92017-08-07 15:26:36 +01002092 reg->umax_value,
Edward Creef1174f72017-08-07 15:26:19 +01002093 zero_size_allowed, meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002094 }
2095
2096 return err;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07002097err_type:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002098 verbose(env, "R%d type=%s expected=%s\n", regno,
Alexei Starovoitov6841de82016-08-11 18:17:16 -07002099 reg_type_str[type], reg_type_str[expected_type]);
2100 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002101}
2102
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002103static int check_map_func_compatibility(struct bpf_verifier_env *env,
2104 struct bpf_map *map, int func_id)
Kaixu Xia35578d72015-08-06 07:02:35 +00002105{
Kaixu Xia35578d72015-08-06 07:02:35 +00002106 if (!map)
2107 return 0;
2108
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002109 /* We need a two way check, first is from map perspective ... */
2110 switch (map->map_type) {
2111 case BPF_MAP_TYPE_PROG_ARRAY:
2112 if (func_id != BPF_FUNC_tail_call)
2113 goto error;
2114 break;
2115 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
2116 if (func_id != BPF_FUNC_perf_event_read &&
Yonghong Song908432c2017-10-05 09:19:20 -07002117 func_id != BPF_FUNC_perf_event_output &&
2118 func_id != BPF_FUNC_perf_event_read_value)
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002119 goto error;
2120 break;
2121 case BPF_MAP_TYPE_STACK_TRACE:
2122 if (func_id != BPF_FUNC_get_stackid)
2123 goto error;
2124 break;
Martin KaFai Lau4ed8ec52016-06-30 10:28:43 -07002125 case BPF_MAP_TYPE_CGROUP_ARRAY:
David S. Miller60747ef2016-08-18 01:17:32 -04002126 if (func_id != BPF_FUNC_skb_under_cgroup &&
Sargun Dhillon60d20f92016-08-12 08:56:52 -07002127 func_id != BPF_FUNC_current_task_under_cgroup)
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07002128 goto error;
2129 break;
John Fastabend546ac1f2017-07-17 09:28:56 -07002130 /* devmap returns a pointer to a live net_device ifindex that we cannot
2131 * allow to be modified from bpf side. So do not allow lookup elements
2132 * for now.
2133 */
2134 case BPF_MAP_TYPE_DEVMAP:
John Fastabend2ddf71e2017-07-17 09:30:02 -07002135 if (func_id != BPF_FUNC_redirect_map)
John Fastabend546ac1f2017-07-17 09:28:56 -07002136 goto error;
2137 break;
Björn Töpelfbfc504a2018-05-02 13:01:28 +02002138 /* Restrict bpf side of cpumap and xskmap, open when use-cases
2139 * appear.
2140 */
Jesper Dangaard Brouer6710e112017-10-16 12:19:28 +02002141 case BPF_MAP_TYPE_CPUMAP:
Björn Töpelfbfc504a2018-05-02 13:01:28 +02002142 case BPF_MAP_TYPE_XSKMAP:
Jesper Dangaard Brouer6710e112017-10-16 12:19:28 +02002143 if (func_id != BPF_FUNC_redirect_map)
2144 goto error;
2145 break;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002146 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07002147 case BPF_MAP_TYPE_HASH_OF_MAPS:
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002148 if (func_id != BPF_FUNC_map_lookup_elem)
2149 goto error;
Martin KaFai Lau16a43622017-08-17 18:14:43 -07002150 break;
John Fastabend174a79f2017-08-15 22:32:47 -07002151 case BPF_MAP_TYPE_SOCKMAP:
2152 if (func_id != BPF_FUNC_sk_redirect_map &&
2153 func_id != BPF_FUNC_sock_map_update &&
John Fastabend4f738ad2018-03-18 12:57:10 -07002154 func_id != BPF_FUNC_map_delete_elem &&
2155 func_id != BPF_FUNC_msg_redirect_map)
John Fastabend174a79f2017-08-15 22:32:47 -07002156 goto error;
2157 break;
John Fastabend81110382018-05-14 10:00:17 -07002158 case BPF_MAP_TYPE_SOCKHASH:
2159 if (func_id != BPF_FUNC_sk_redirect_hash &&
2160 func_id != BPF_FUNC_sock_hash_update &&
2161 func_id != BPF_FUNC_map_delete_elem &&
2162 func_id != BPF_FUNC_msg_redirect_hash)
2163 goto error;
2164 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002165 default:
2166 break;
2167 }
2168
2169 /* ... and second from the function itself. */
2170 switch (func_id) {
2171 case BPF_FUNC_tail_call:
2172 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
2173 goto error;
Jiong Wangf910cef2018-05-02 16:17:17 -04002174 if (env->subprog_cnt > 1) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002175 verbose(env, "tail_calls are not allowed in programs with bpf-to-bpf calls\n");
2176 return -EINVAL;
2177 }
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002178 break;
2179 case BPF_FUNC_perf_event_read:
2180 case BPF_FUNC_perf_event_output:
Yonghong Song908432c2017-10-05 09:19:20 -07002181 case BPF_FUNC_perf_event_read_value:
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002182 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
2183 goto error;
2184 break;
2185 case BPF_FUNC_get_stackid:
2186 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
2187 goto error;
2188 break;
Sargun Dhillon60d20f92016-08-12 08:56:52 -07002189 case BPF_FUNC_current_task_under_cgroup:
Daniel Borkmann747ea552016-08-12 22:17:17 +02002190 case BPF_FUNC_skb_under_cgroup:
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07002191 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
2192 goto error;
2193 break;
John Fastabend97f91a72017-07-17 09:29:18 -07002194 case BPF_FUNC_redirect_map:
Jesper Dangaard Brouer9c270af2017-10-16 12:19:34 +02002195 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
Björn Töpelfbfc504a2018-05-02 13:01:28 +02002196 map->map_type != BPF_MAP_TYPE_CPUMAP &&
2197 map->map_type != BPF_MAP_TYPE_XSKMAP)
John Fastabend97f91a72017-07-17 09:29:18 -07002198 goto error;
2199 break;
John Fastabend174a79f2017-08-15 22:32:47 -07002200 case BPF_FUNC_sk_redirect_map:
John Fastabend4f738ad2018-03-18 12:57:10 -07002201 case BPF_FUNC_msg_redirect_map:
John Fastabend81110382018-05-14 10:00:17 -07002202 case BPF_FUNC_sock_map_update:
John Fastabend174a79f2017-08-15 22:32:47 -07002203 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
2204 goto error;
2205 break;
John Fastabend81110382018-05-14 10:00:17 -07002206 case BPF_FUNC_sk_redirect_hash:
2207 case BPF_FUNC_msg_redirect_hash:
2208 case BPF_FUNC_sock_hash_update:
2209 if (map->map_type != BPF_MAP_TYPE_SOCKHASH)
John Fastabend174a79f2017-08-15 22:32:47 -07002210 goto error;
2211 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002212 default:
2213 break;
Kaixu Xia35578d72015-08-06 07:02:35 +00002214 }
2215
2216 return 0;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002217error:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002218 verbose(env, "cannot pass map_type %d into func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02002219 map->map_type, func_id_name(func_id), func_id);
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002220 return -EINVAL;
Kaixu Xia35578d72015-08-06 07:02:35 +00002221}
2222
Daniel Borkmann90133412018-01-20 01:24:29 +01002223static bool check_raw_mode_ok(const struct bpf_func_proto *fn)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002224{
2225 int count = 0;
2226
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002227 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002228 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002229 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002230 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002231 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002232 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002233 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002234 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002235 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002236 count++;
2237
Daniel Borkmann90133412018-01-20 01:24:29 +01002238 /* We only support one arg being in raw mode at the moment,
2239 * which is sufficient for the helper functions we have
2240 * right now.
2241 */
2242 return count <= 1;
2243}
2244
2245static bool check_args_pair_invalid(enum bpf_arg_type arg_curr,
2246 enum bpf_arg_type arg_next)
2247{
2248 return (arg_type_is_mem_ptr(arg_curr) &&
2249 !arg_type_is_mem_size(arg_next)) ||
2250 (!arg_type_is_mem_ptr(arg_curr) &&
2251 arg_type_is_mem_size(arg_next));
2252}
2253
2254static bool check_arg_pair_ok(const struct bpf_func_proto *fn)
2255{
2256 /* bpf_xxx(..., buf, len) call will access 'len'
2257 * bytes from memory 'buf'. Both arg types need
2258 * to be paired, so make sure there's no buggy
2259 * helper function specification.
2260 */
2261 if (arg_type_is_mem_size(fn->arg1_type) ||
2262 arg_type_is_mem_ptr(fn->arg5_type) ||
2263 check_args_pair_invalid(fn->arg1_type, fn->arg2_type) ||
2264 check_args_pair_invalid(fn->arg2_type, fn->arg3_type) ||
2265 check_args_pair_invalid(fn->arg3_type, fn->arg4_type) ||
2266 check_args_pair_invalid(fn->arg4_type, fn->arg5_type))
2267 return false;
2268
2269 return true;
2270}
2271
2272static int check_func_proto(const struct bpf_func_proto *fn)
2273{
2274 return check_raw_mode_ok(fn) &&
2275 check_arg_pair_ok(fn) ? 0 : -EINVAL;
Daniel Borkmann435faee12016-04-13 00:10:51 +02002276}
2277
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002278/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
2279 * are now invalid, so turn them into unknown SCALAR_VALUE.
Edward Creef1174f72017-08-07 15:26:19 +01002280 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002281static void __clear_all_pkt_pointers(struct bpf_verifier_env *env,
2282 struct bpf_func_state *state)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002283{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002284 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002285 int i;
2286
2287 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002288 if (reg_is_pkt_pointer_any(&regs[i]))
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002289 mark_reg_unknown(env, regs, i);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002290
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002291 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2292 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002293 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002294 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002295 if (reg_is_pkt_pointer_any(reg))
2296 __mark_reg_unknown(reg);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002297 }
2298}
2299
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002300static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
2301{
2302 struct bpf_verifier_state *vstate = env->cur_state;
2303 int i;
2304
2305 for (i = 0; i <= vstate->curframe; i++)
2306 __clear_all_pkt_pointers(env, vstate->frame[i]);
2307}
2308
2309static int check_func_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
2310 int *insn_idx)
2311{
2312 struct bpf_verifier_state *state = env->cur_state;
2313 struct bpf_func_state *caller, *callee;
2314 int i, subprog, target_insn;
2315
Alexei Starovoitovaada9ce2017-12-25 13:15:42 -08002316 if (state->curframe + 1 >= MAX_CALL_FRAMES) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002317 verbose(env, "the call stack of %d frames is too deep\n",
Alexei Starovoitovaada9ce2017-12-25 13:15:42 -08002318 state->curframe + 2);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002319 return -E2BIG;
2320 }
2321
2322 target_insn = *insn_idx + insn->imm;
2323 subprog = find_subprog(env, target_insn + 1);
2324 if (subprog < 0) {
2325 verbose(env, "verifier bug. No program starts at insn %d\n",
2326 target_insn + 1);
2327 return -EFAULT;
2328 }
2329
2330 caller = state->frame[state->curframe];
2331 if (state->frame[state->curframe + 1]) {
2332 verbose(env, "verifier bug. Frame %d already allocated\n",
2333 state->curframe + 1);
2334 return -EFAULT;
2335 }
2336
2337 callee = kzalloc(sizeof(*callee), GFP_KERNEL);
2338 if (!callee)
2339 return -ENOMEM;
2340 state->frame[state->curframe + 1] = callee;
2341
2342 /* callee cannot access r0, r6 - r9 for reading and has to write
2343 * into its own stack before reading from it.
2344 * callee can read/write into caller's stack
2345 */
2346 init_func_state(env, callee,
2347 /* remember the callsite, it will be used by bpf_exit */
2348 *insn_idx /* callsite */,
2349 state->curframe + 1 /* frameno within this callchain */,
Jiong Wangf910cef2018-05-02 16:17:17 -04002350 subprog /* subprog number within this prog */);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002351
2352 /* copy r1 - r5 args that callee can access */
2353 for (i = BPF_REG_1; i <= BPF_REG_5; i++)
2354 callee->regs[i] = caller->regs[i];
2355
2356 /* after the call regsiters r0 - r5 were scratched */
2357 for (i = 0; i < CALLER_SAVED_REGS; i++) {
2358 mark_reg_not_init(env, caller->regs, caller_saved[i]);
2359 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
2360 }
2361
2362 /* only increment it after check_reg_arg() finished */
2363 state->curframe++;
2364
2365 /* and go analyze first insn of the callee */
2366 *insn_idx = target_insn;
2367
2368 if (env->log.level) {
2369 verbose(env, "caller:\n");
2370 print_verifier_state(env, caller);
2371 verbose(env, "callee:\n");
2372 print_verifier_state(env, callee);
2373 }
2374 return 0;
2375}
2376
2377static int prepare_func_exit(struct bpf_verifier_env *env, int *insn_idx)
2378{
2379 struct bpf_verifier_state *state = env->cur_state;
2380 struct bpf_func_state *caller, *callee;
2381 struct bpf_reg_state *r0;
2382
2383 callee = state->frame[state->curframe];
2384 r0 = &callee->regs[BPF_REG_0];
2385 if (r0->type == PTR_TO_STACK) {
2386 /* technically it's ok to return caller's stack pointer
2387 * (or caller's caller's pointer) back to the caller,
2388 * since these pointers are valid. Only current stack
2389 * pointer will be invalid as soon as function exits,
2390 * but let's be conservative
2391 */
2392 verbose(env, "cannot return stack pointer to the caller\n");
2393 return -EINVAL;
2394 }
2395
2396 state->curframe--;
2397 caller = state->frame[state->curframe];
2398 /* return to the caller whatever r0 had in the callee */
2399 caller->regs[BPF_REG_0] = *r0;
2400
2401 *insn_idx = callee->callsite + 1;
2402 if (env->log.level) {
2403 verbose(env, "returning from callee:\n");
2404 print_verifier_state(env, callee);
2405 verbose(env, "to caller at %d:\n", *insn_idx);
2406 print_verifier_state(env, caller);
2407 }
2408 /* clear everything in the callee */
2409 free_func_state(callee);
2410 state->frame[state->curframe + 1] = NULL;
2411 return 0;
2412}
2413
Yonghong Song849fa502018-04-28 22:28:09 -07002414static void do_refine_retval_range(struct bpf_reg_state *regs, int ret_type,
2415 int func_id,
2416 struct bpf_call_arg_meta *meta)
2417{
2418 struct bpf_reg_state *ret_reg = &regs[BPF_REG_0];
2419
2420 if (ret_type != RET_INTEGER ||
2421 (func_id != BPF_FUNC_get_stack &&
2422 func_id != BPF_FUNC_probe_read_str))
2423 return;
2424
2425 ret_reg->smax_value = meta->msize_smax_value;
2426 ret_reg->umax_value = meta->msize_umax_value;
2427 __reg_deduce_bounds(ret_reg);
2428 __reg_bound_offset(ret_reg);
2429}
2430
Daniel Borkmannc93552c2018-05-24 02:32:53 +02002431static int
2432record_func_map(struct bpf_verifier_env *env, struct bpf_call_arg_meta *meta,
2433 int func_id, int insn_idx)
2434{
2435 struct bpf_insn_aux_data *aux = &env->insn_aux_data[insn_idx];
2436
2437 if (func_id != BPF_FUNC_tail_call &&
Daniel Borkmann09772d92018-06-02 23:06:35 +02002438 func_id != BPF_FUNC_map_lookup_elem &&
2439 func_id != BPF_FUNC_map_update_elem &&
2440 func_id != BPF_FUNC_map_delete_elem)
Daniel Borkmannc93552c2018-05-24 02:32:53 +02002441 return 0;
Daniel Borkmann09772d92018-06-02 23:06:35 +02002442
Daniel Borkmannc93552c2018-05-24 02:32:53 +02002443 if (meta->map_ptr == NULL) {
2444 verbose(env, "kernel subsystem misconfigured verifier\n");
2445 return -EINVAL;
2446 }
2447
2448 if (!BPF_MAP_PTR(aux->map_state))
2449 bpf_map_ptr_store(aux, meta->map_ptr,
2450 meta->map_ptr->unpriv_array);
2451 else if (BPF_MAP_PTR(aux->map_state) != meta->map_ptr)
2452 bpf_map_ptr_store(aux, BPF_MAP_PTR_POISON,
2453 meta->map_ptr->unpriv_array);
2454 return 0;
2455}
2456
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002457static int check_helper_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002458{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002459 const struct bpf_func_proto *fn = NULL;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002460 struct bpf_reg_state *regs;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002461 struct bpf_call_arg_meta meta;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002462 bool changes_data;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002463 int i, err;
2464
2465 /* find function prototype */
2466 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002467 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
2468 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002469 return -EINVAL;
2470 }
2471
Jakub Kicinski00176a32017-10-16 16:40:54 -07002472 if (env->ops->get_func_proto)
Andrey Ignatov5e43f892018-03-30 15:08:00 -07002473 fn = env->ops->get_func_proto(func_id, env->prog);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002474 if (!fn) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002475 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
2476 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002477 return -EINVAL;
2478 }
2479
2480 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +01002481 if (!env->prog->gpl_compatible && fn->gpl_only) {
Daniel Borkmann3fe28672018-06-02 23:06:33 +02002482 verbose(env, "cannot call GPL-restricted function from non-GPL compatible program\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002483 return -EINVAL;
2484 }
2485
Daniel Borkmann04514d12017-12-14 21:07:25 +01002486 /* With LD_ABS/IND some JITs save/restore skb from r1. */
Martin KaFai Lau17bedab2016-12-07 15:53:11 -08002487 changes_data = bpf_helper_changes_pkt_data(fn->func);
Daniel Borkmann04514d12017-12-14 21:07:25 +01002488 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
2489 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
2490 func_id_name(func_id), func_id);
2491 return -EINVAL;
2492 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002493
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002494 memset(&meta, 0, sizeof(meta));
Daniel Borkmann36bbef52016-09-20 00:26:13 +02002495 meta.pkt_access = fn->pkt_access;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002496
Daniel Borkmann90133412018-01-20 01:24:29 +01002497 err = check_func_proto(fn);
Daniel Borkmann435faee12016-04-13 00:10:51 +02002498 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002499 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02002500 func_id_name(func_id), func_id);
Daniel Borkmann435faee12016-04-13 00:10:51 +02002501 return err;
2502 }
2503
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002504 /* check args */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002505 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002506 if (err)
2507 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002508 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002509 if (err)
2510 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002511 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002512 if (err)
2513 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002514 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002515 if (err)
2516 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002517 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002518 if (err)
2519 return err;
2520
Daniel Borkmannc93552c2018-05-24 02:32:53 +02002521 err = record_func_map(env, &meta, func_id, insn_idx);
2522 if (err)
2523 return err;
2524
Daniel Borkmann435faee12016-04-13 00:10:51 +02002525 /* Mark slots with STACK_MISC in case of raw mode, stack offset
2526 * is inferred from register state.
2527 */
2528 for (i = 0; i < meta.access_size; i++) {
Daniel Borkmannca369602018-02-23 22:29:05 +01002529 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B,
2530 BPF_WRITE, -1, false);
Daniel Borkmann435faee12016-04-13 00:10:51 +02002531 if (err)
2532 return err;
2533 }
2534
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002535 regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002536 /* reset caller saved regs */
Edward Creedc503a82017-08-15 20:34:35 +01002537 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002538 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01002539 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
2540 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002541
Edward Creedc503a82017-08-15 20:34:35 +01002542 /* update return register (already marked as written above) */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002543 if (fn->ret_type == RET_INTEGER) {
Edward Creef1174f72017-08-07 15:26:19 +01002544 /* sets type to SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002545 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002546 } else if (fn->ret_type == RET_VOID) {
2547 regs[BPF_REG_0].type = NOT_INIT;
Roman Gushchin3e6a4b32018-08-02 14:27:22 -07002548 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL ||
2549 fn->ret_type == RET_PTR_TO_MAP_VALUE) {
2550 if (fn->ret_type == RET_PTR_TO_MAP_VALUE)
2551 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE;
2552 else
2553 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
Edward Creef1174f72017-08-07 15:26:19 +01002554 /* There is no offset yet applied, variable or fixed */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002555 mark_reg_known_zero(env, regs, BPF_REG_0);
Edward Creef1174f72017-08-07 15:26:19 +01002556 regs[BPF_REG_0].off = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002557 /* remember map_ptr, so that check_map_access()
2558 * can check 'value_size' boundary of memory access
2559 * to map element returned from bpf_map_lookup_elem()
2560 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002561 if (meta.map_ptr == NULL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002562 verbose(env,
2563 "kernel subsystem misconfigured verifier\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002564 return -EINVAL;
2565 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002566 regs[BPF_REG_0].map_ptr = meta.map_ptr;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002567 regs[BPF_REG_0].id = ++env->id_gen;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002568 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002569 verbose(env, "unknown return type %d of func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02002570 fn->ret_type, func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002571 return -EINVAL;
2572 }
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07002573
Yonghong Song849fa502018-04-28 22:28:09 -07002574 do_refine_retval_range(regs, fn->ret_type, func_id, &meta);
2575
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002576 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
Kaixu Xia35578d72015-08-06 07:02:35 +00002577 if (err)
2578 return err;
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07002579
Yonghong Songc195651e2018-04-28 22:28:08 -07002580 if (func_id == BPF_FUNC_get_stack && !env->prog->has_callchain_buf) {
2581 const char *err_str;
2582
2583#ifdef CONFIG_PERF_EVENTS
2584 err = get_callchain_buffers(sysctl_perf_event_max_stack);
2585 err_str = "cannot get callchain buffer for func %s#%d\n";
2586#else
2587 err = -ENOTSUPP;
2588 err_str = "func %s#%d not supported without CONFIG_PERF_EVENTS\n";
2589#endif
2590 if (err) {
2591 verbose(env, err_str, func_id_name(func_id), func_id);
2592 return err;
2593 }
2594
2595 env->prog->has_callchain_buf = true;
2596 }
2597
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002598 if (changes_data)
2599 clear_all_pkt_pointers(env);
2600 return 0;
2601}
2602
Edward Creeb03c9f92017-08-07 15:26:36 +01002603static bool signed_add_overflows(s64 a, s64 b)
2604{
2605 /* Do the add in u64, where overflow is well-defined */
2606 s64 res = (s64)((u64)a + (u64)b);
2607
2608 if (b < 0)
2609 return res > a;
2610 return res < a;
2611}
2612
2613static bool signed_sub_overflows(s64 a, s64 b)
2614{
2615 /* Do the sub in u64, where overflow is well-defined */
2616 s64 res = (s64)((u64)a - (u64)b);
2617
2618 if (b < 0)
2619 return res < a;
2620 return res > a;
David S. Millerd1174412017-05-10 11:22:52 -07002621}
2622
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002623static bool check_reg_sane_offset(struct bpf_verifier_env *env,
2624 const struct bpf_reg_state *reg,
2625 enum bpf_reg_type type)
2626{
2627 bool known = tnum_is_const(reg->var_off);
2628 s64 val = reg->var_off.value;
2629 s64 smin = reg->smin_value;
2630
2631 if (known && (val >= BPF_MAX_VAR_OFF || val <= -BPF_MAX_VAR_OFF)) {
2632 verbose(env, "math between %s pointer and %lld is not allowed\n",
2633 reg_type_str[type], val);
2634 return false;
2635 }
2636
2637 if (reg->off >= BPF_MAX_VAR_OFF || reg->off <= -BPF_MAX_VAR_OFF) {
2638 verbose(env, "%s pointer offset %d is not allowed\n",
2639 reg_type_str[type], reg->off);
2640 return false;
2641 }
2642
2643 if (smin == S64_MIN) {
2644 verbose(env, "math between %s pointer and register with unbounded min value is not allowed\n",
2645 reg_type_str[type]);
2646 return false;
2647 }
2648
2649 if (smin >= BPF_MAX_VAR_OFF || smin <= -BPF_MAX_VAR_OFF) {
2650 verbose(env, "value %lld makes %s pointer be out of bounds\n",
2651 smin, reg_type_str[type]);
2652 return false;
2653 }
2654
2655 return true;
2656}
2657
Edward Creef1174f72017-08-07 15:26:19 +01002658/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
Edward Creef1174f72017-08-07 15:26:19 +01002659 * Caller should also handle BPF_MOV case separately.
2660 * If we return -EACCES, caller may want to try again treating pointer as a
2661 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
2662 */
2663static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
2664 struct bpf_insn *insn,
2665 const struct bpf_reg_state *ptr_reg,
2666 const struct bpf_reg_state *off_reg)
Josef Bacik48461132016-09-28 10:54:32 -04002667{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002668 struct bpf_verifier_state *vstate = env->cur_state;
2669 struct bpf_func_state *state = vstate->frame[vstate->curframe];
2670 struct bpf_reg_state *regs = state->regs, *dst_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002671 bool known = tnum_is_const(off_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002672 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
2673 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
2674 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
2675 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
Josef Bacik48461132016-09-28 10:54:32 -04002676 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01002677 u32 dst = insn->dst_reg;
Josef Bacik48461132016-09-28 10:54:32 -04002678
Edward Creef1174f72017-08-07 15:26:19 +01002679 dst_reg = &regs[dst];
Josef Bacik48461132016-09-28 10:54:32 -04002680
Daniel Borkmann6f161012018-01-18 01:15:21 +01002681 if ((known && (smin_val != smax_val || umin_val != umax_val)) ||
2682 smin_val > smax_val || umin_val > umax_val) {
2683 /* Taint dst register if offset had invalid bounds derived from
2684 * e.g. dead branches.
2685 */
2686 __mark_reg_unknown(dst_reg);
2687 return 0;
Josef Bacik48461132016-09-28 10:54:32 -04002688 }
2689
Edward Creef1174f72017-08-07 15:26:19 +01002690 if (BPF_CLASS(insn->code) != BPF_ALU64) {
2691 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002692 verbose(env,
2693 "R%d 32-bit pointer arithmetic prohibited\n",
2694 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002695 return -EACCES;
2696 }
David S. Millerd1174412017-05-10 11:22:52 -07002697
Edward Creef1174f72017-08-07 15:26:19 +01002698 if (ptr_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002699 verbose(env, "R%d pointer arithmetic on PTR_TO_MAP_VALUE_OR_NULL prohibited, null-check it first\n",
2700 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002701 return -EACCES;
2702 }
2703 if (ptr_reg->type == CONST_PTR_TO_MAP) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002704 verbose(env, "R%d pointer arithmetic on CONST_PTR_TO_MAP prohibited\n",
2705 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002706 return -EACCES;
2707 }
2708 if (ptr_reg->type == PTR_TO_PACKET_END) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002709 verbose(env, "R%d pointer arithmetic on PTR_TO_PACKET_END prohibited\n",
2710 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002711 return -EACCES;
2712 }
2713
2714 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
2715 * The id may be overwritten later if we create a new variable offset.
Josef Bacik48461132016-09-28 10:54:32 -04002716 */
Edward Creef1174f72017-08-07 15:26:19 +01002717 dst_reg->type = ptr_reg->type;
2718 dst_reg->id = ptr_reg->id;
Josef Bacikf23cc642016-11-14 15:45:36 -05002719
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002720 if (!check_reg_sane_offset(env, off_reg, ptr_reg->type) ||
2721 !check_reg_sane_offset(env, ptr_reg, ptr_reg->type))
2722 return -EINVAL;
2723
Josef Bacik48461132016-09-28 10:54:32 -04002724 switch (opcode) {
2725 case BPF_ADD:
Edward Creef1174f72017-08-07 15:26:19 +01002726 /* We can take a fixed offset as long as it doesn't overflow
2727 * the s32 'off' field
2728 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002729 if (known && (ptr_reg->off + smin_val ==
2730 (s64)(s32)(ptr_reg->off + smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01002731 /* pointer += K. Accumulate it into fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01002732 dst_reg->smin_value = smin_ptr;
2733 dst_reg->smax_value = smax_ptr;
2734 dst_reg->umin_value = umin_ptr;
2735 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01002736 dst_reg->var_off = ptr_reg->var_off;
Edward Creeb03c9f92017-08-07 15:26:36 +01002737 dst_reg->off = ptr_reg->off + smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01002738 dst_reg->range = ptr_reg->range;
2739 break;
2740 }
Edward Creef1174f72017-08-07 15:26:19 +01002741 /* A new variable offset is created. Note that off_reg->off
2742 * == 0, since it's a scalar.
2743 * dst_reg gets the pointer type and since some positive
2744 * integer value was added to the pointer, give it a new 'id'
2745 * if it's a PTR_TO_PACKET.
2746 * this creates a new 'base' pointer, off_reg (variable) gets
2747 * added into the variable offset, and we copy the fixed offset
2748 * from ptr_reg.
2749 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002750 if (signed_add_overflows(smin_ptr, smin_val) ||
2751 signed_add_overflows(smax_ptr, smax_val)) {
2752 dst_reg->smin_value = S64_MIN;
2753 dst_reg->smax_value = S64_MAX;
2754 } else {
2755 dst_reg->smin_value = smin_ptr + smin_val;
2756 dst_reg->smax_value = smax_ptr + smax_val;
2757 }
2758 if (umin_ptr + umin_val < umin_ptr ||
2759 umax_ptr + umax_val < umax_ptr) {
2760 dst_reg->umin_value = 0;
2761 dst_reg->umax_value = U64_MAX;
2762 } else {
2763 dst_reg->umin_value = umin_ptr + umin_val;
2764 dst_reg->umax_value = umax_ptr + umax_val;
2765 }
Edward Creef1174f72017-08-07 15:26:19 +01002766 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
2767 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002768 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01002769 dst_reg->id = ++env->id_gen;
2770 /* something was added to pkt_ptr, set range to zero */
2771 dst_reg->range = 0;
2772 }
Josef Bacik48461132016-09-28 10:54:32 -04002773 break;
2774 case BPF_SUB:
Edward Creef1174f72017-08-07 15:26:19 +01002775 if (dst_reg == off_reg) {
2776 /* scalar -= pointer. Creates an unknown scalar */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002777 verbose(env, "R%d tried to subtract pointer from scalar\n",
2778 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002779 return -EACCES;
2780 }
2781 /* We don't allow subtraction from FP, because (according to
2782 * test_verifier.c test "invalid fp arithmetic", JITs might not
2783 * be able to deal with it.
Edward Cree93057062017-07-21 14:37:34 +01002784 */
Edward Creef1174f72017-08-07 15:26:19 +01002785 if (ptr_reg->type == PTR_TO_STACK) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002786 verbose(env, "R%d subtraction from stack pointer prohibited\n",
2787 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002788 return -EACCES;
2789 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002790 if (known && (ptr_reg->off - smin_val ==
2791 (s64)(s32)(ptr_reg->off - smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01002792 /* pointer -= K. Subtract it from fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01002793 dst_reg->smin_value = smin_ptr;
2794 dst_reg->smax_value = smax_ptr;
2795 dst_reg->umin_value = umin_ptr;
2796 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01002797 dst_reg->var_off = ptr_reg->var_off;
2798 dst_reg->id = ptr_reg->id;
Edward Creeb03c9f92017-08-07 15:26:36 +01002799 dst_reg->off = ptr_reg->off - smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01002800 dst_reg->range = ptr_reg->range;
2801 break;
2802 }
Edward Creef1174f72017-08-07 15:26:19 +01002803 /* A new variable offset is created. If the subtrahend is known
2804 * nonnegative, then any reg->range we had before is still good.
2805 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002806 if (signed_sub_overflows(smin_ptr, smax_val) ||
2807 signed_sub_overflows(smax_ptr, smin_val)) {
2808 /* Overflow possible, we know nothing */
2809 dst_reg->smin_value = S64_MIN;
2810 dst_reg->smax_value = S64_MAX;
2811 } else {
2812 dst_reg->smin_value = smin_ptr - smax_val;
2813 dst_reg->smax_value = smax_ptr - smin_val;
2814 }
2815 if (umin_ptr < umax_val) {
2816 /* Overflow possible, we know nothing */
2817 dst_reg->umin_value = 0;
2818 dst_reg->umax_value = U64_MAX;
2819 } else {
2820 /* Cannot overflow (as long as bounds are consistent) */
2821 dst_reg->umin_value = umin_ptr - umax_val;
2822 dst_reg->umax_value = umax_ptr - umin_val;
2823 }
Edward Creef1174f72017-08-07 15:26:19 +01002824 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
2825 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002826 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01002827 dst_reg->id = ++env->id_gen;
2828 /* something was added to pkt_ptr, set range to zero */
Edward Creeb03c9f92017-08-07 15:26:36 +01002829 if (smin_val < 0)
Edward Creef1174f72017-08-07 15:26:19 +01002830 dst_reg->range = 0;
2831 }
2832 break;
2833 case BPF_AND:
2834 case BPF_OR:
2835 case BPF_XOR:
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002836 /* bitwise ops on pointers are troublesome, prohibit. */
2837 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
2838 dst, bpf_alu_string[opcode >> 4]);
Edward Creef1174f72017-08-07 15:26:19 +01002839 return -EACCES;
2840 default:
2841 /* other operators (e.g. MUL,LSH) produce non-pointer results */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002842 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
2843 dst, bpf_alu_string[opcode >> 4]);
Edward Creef1174f72017-08-07 15:26:19 +01002844 return -EACCES;
2845 }
2846
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002847 if (!check_reg_sane_offset(env, dst_reg, ptr_reg->type))
2848 return -EINVAL;
2849
Edward Creeb03c9f92017-08-07 15:26:36 +01002850 __update_reg_bounds(dst_reg);
2851 __reg_deduce_bounds(dst_reg);
2852 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002853 return 0;
2854}
2855
Jann Horn468f6ea2017-12-18 20:11:56 -08002856/* WARNING: This function does calculations on 64-bit values, but the actual
2857 * execution may occur on 32-bit values. Therefore, things like bitshifts
2858 * need extra checks in the 32-bit case.
2859 */
Edward Creef1174f72017-08-07 15:26:19 +01002860static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
2861 struct bpf_insn *insn,
2862 struct bpf_reg_state *dst_reg,
2863 struct bpf_reg_state src_reg)
2864{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002865 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +01002866 u8 opcode = BPF_OP(insn->code);
2867 bool src_known, dst_known;
Edward Creeb03c9f92017-08-07 15:26:36 +01002868 s64 smin_val, smax_val;
2869 u64 umin_val, umax_val;
Jann Horn468f6ea2017-12-18 20:11:56 -08002870 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
Edward Creef1174f72017-08-07 15:26:19 +01002871
Edward Creeb03c9f92017-08-07 15:26:36 +01002872 smin_val = src_reg.smin_value;
2873 smax_val = src_reg.smax_value;
2874 umin_val = src_reg.umin_value;
2875 umax_val = src_reg.umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002876 src_known = tnum_is_const(src_reg.var_off);
2877 dst_known = tnum_is_const(dst_reg->var_off);
2878
Daniel Borkmann6f161012018-01-18 01:15:21 +01002879 if ((src_known && (smin_val != smax_val || umin_val != umax_val)) ||
2880 smin_val > smax_val || umin_val > umax_val) {
2881 /* Taint dst register if offset had invalid bounds derived from
2882 * e.g. dead branches.
2883 */
2884 __mark_reg_unknown(dst_reg);
2885 return 0;
2886 }
2887
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002888 if (!src_known &&
2889 opcode != BPF_ADD && opcode != BPF_SUB && opcode != BPF_AND) {
2890 __mark_reg_unknown(dst_reg);
2891 return 0;
2892 }
2893
Edward Creef1174f72017-08-07 15:26:19 +01002894 switch (opcode) {
2895 case BPF_ADD:
Edward Creeb03c9f92017-08-07 15:26:36 +01002896 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
2897 signed_add_overflows(dst_reg->smax_value, smax_val)) {
2898 dst_reg->smin_value = S64_MIN;
2899 dst_reg->smax_value = S64_MAX;
2900 } else {
2901 dst_reg->smin_value += smin_val;
2902 dst_reg->smax_value += smax_val;
2903 }
2904 if (dst_reg->umin_value + umin_val < umin_val ||
2905 dst_reg->umax_value + umax_val < umax_val) {
2906 dst_reg->umin_value = 0;
2907 dst_reg->umax_value = U64_MAX;
2908 } else {
2909 dst_reg->umin_value += umin_val;
2910 dst_reg->umax_value += umax_val;
2911 }
Edward Creef1174f72017-08-07 15:26:19 +01002912 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
2913 break;
2914 case BPF_SUB:
Edward Creeb03c9f92017-08-07 15:26:36 +01002915 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
2916 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
2917 /* Overflow possible, we know nothing */
2918 dst_reg->smin_value = S64_MIN;
2919 dst_reg->smax_value = S64_MAX;
2920 } else {
2921 dst_reg->smin_value -= smax_val;
2922 dst_reg->smax_value -= smin_val;
2923 }
2924 if (dst_reg->umin_value < umax_val) {
2925 /* Overflow possible, we know nothing */
2926 dst_reg->umin_value = 0;
2927 dst_reg->umax_value = U64_MAX;
2928 } else {
2929 /* Cannot overflow (as long as bounds are consistent) */
2930 dst_reg->umin_value -= umax_val;
2931 dst_reg->umax_value -= umin_val;
2932 }
Edward Creef1174f72017-08-07 15:26:19 +01002933 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
Josef Bacik48461132016-09-28 10:54:32 -04002934 break;
2935 case BPF_MUL:
Edward Creeb03c9f92017-08-07 15:26:36 +01002936 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
2937 if (smin_val < 0 || dst_reg->smin_value < 0) {
Edward Creef1174f72017-08-07 15:26:19 +01002938 /* Ain't nobody got time to multiply that sign */
Edward Creeb03c9f92017-08-07 15:26:36 +01002939 __mark_reg_unbounded(dst_reg);
2940 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002941 break;
2942 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002943 /* Both values are positive, so we can work with unsigned and
2944 * copy the result to signed (unless it exceeds S64_MAX).
Edward Creef1174f72017-08-07 15:26:19 +01002945 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002946 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
2947 /* Potential overflow, we know nothing */
2948 __mark_reg_unbounded(dst_reg);
2949 /* (except what we can learn from the var_off) */
2950 __update_reg_bounds(dst_reg);
2951 break;
2952 }
2953 dst_reg->umin_value *= umin_val;
2954 dst_reg->umax_value *= umax_val;
2955 if (dst_reg->umax_value > S64_MAX) {
2956 /* Overflow possible, we know nothing */
2957 dst_reg->smin_value = S64_MIN;
2958 dst_reg->smax_value = S64_MAX;
2959 } else {
2960 dst_reg->smin_value = dst_reg->umin_value;
2961 dst_reg->smax_value = dst_reg->umax_value;
2962 }
Josef Bacik48461132016-09-28 10:54:32 -04002963 break;
2964 case BPF_AND:
Edward Creef1174f72017-08-07 15:26:19 +01002965 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002966 __mark_reg_known(dst_reg, dst_reg->var_off.value &
2967 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002968 break;
2969 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002970 /* We get our minimum from the var_off, since that's inherently
2971 * bitwise. Our maximum is the minimum of the operands' maxima.
Josef Bacikf23cc642016-11-14 15:45:36 -05002972 */
Edward Creef1174f72017-08-07 15:26:19 +01002973 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002974 dst_reg->umin_value = dst_reg->var_off.value;
2975 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
2976 if (dst_reg->smin_value < 0 || smin_val < 0) {
2977 /* Lose signed bounds when ANDing negative numbers,
2978 * ain't nobody got time for that.
2979 */
2980 dst_reg->smin_value = S64_MIN;
2981 dst_reg->smax_value = S64_MAX;
2982 } else {
2983 /* ANDing two positives gives a positive, so safe to
2984 * cast result into s64.
2985 */
2986 dst_reg->smin_value = dst_reg->umin_value;
2987 dst_reg->smax_value = dst_reg->umax_value;
2988 }
2989 /* We may learn something more from the var_off */
2990 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002991 break;
2992 case BPF_OR:
2993 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002994 __mark_reg_known(dst_reg, dst_reg->var_off.value |
2995 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002996 break;
2997 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002998 /* We get our maximum from the var_off, and our minimum is the
2999 * maximum of the operands' minima
Edward Creef1174f72017-08-07 15:26:19 +01003000 */
3001 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01003002 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
3003 dst_reg->umax_value = dst_reg->var_off.value |
3004 dst_reg->var_off.mask;
3005 if (dst_reg->smin_value < 0 || smin_val < 0) {
3006 /* Lose signed bounds when ORing negative numbers,
3007 * ain't nobody got time for that.
3008 */
3009 dst_reg->smin_value = S64_MIN;
3010 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01003011 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01003012 /* ORing two positives gives a positive, so safe to
3013 * cast result into s64.
3014 */
3015 dst_reg->smin_value = dst_reg->umin_value;
3016 dst_reg->smax_value = dst_reg->umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01003017 }
Edward Creeb03c9f92017-08-07 15:26:36 +01003018 /* We may learn something more from the var_off */
3019 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003020 break;
3021 case BPF_LSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08003022 if (umax_val >= insn_bitness) {
3023 /* Shifts greater than 31 or 63 are undefined.
3024 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01003025 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003026 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003027 break;
3028 }
Edward Creeb03c9f92017-08-07 15:26:36 +01003029 /* We lose all sign bit information (except what we can pick
3030 * up from var_off)
Josef Bacik48461132016-09-28 10:54:32 -04003031 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003032 dst_reg->smin_value = S64_MIN;
3033 dst_reg->smax_value = S64_MAX;
3034 /* If we might shift our top bit out, then we know nothing */
3035 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
3036 dst_reg->umin_value = 0;
3037 dst_reg->umax_value = U64_MAX;
David S. Millerd1174412017-05-10 11:22:52 -07003038 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01003039 dst_reg->umin_value <<= umin_val;
3040 dst_reg->umax_value <<= umax_val;
David S. Millerd1174412017-05-10 11:22:52 -07003041 }
Yonghong Songafbe1a52018-04-28 22:28:10 -07003042 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
Edward Creeb03c9f92017-08-07 15:26:36 +01003043 /* We may learn something more from the var_off */
3044 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003045 break;
3046 case BPF_RSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08003047 if (umax_val >= insn_bitness) {
3048 /* Shifts greater than 31 or 63 are undefined.
3049 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01003050 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003051 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003052 break;
3053 }
Edward Cree4374f252017-12-18 20:11:53 -08003054 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
3055 * be negative, then either:
3056 * 1) src_reg might be zero, so the sign bit of the result is
3057 * unknown, so we lose our signed bounds
3058 * 2) it's known negative, thus the unsigned bounds capture the
3059 * signed bounds
3060 * 3) the signed bounds cross zero, so they tell us nothing
3061 * about the result
3062 * If the value in dst_reg is known nonnegative, then again the
3063 * unsigned bounts capture the signed bounds.
3064 * Thus, in all cases it suffices to blow away our signed bounds
3065 * and rely on inferring new ones from the unsigned bounds and
3066 * var_off of the result.
3067 */
3068 dst_reg->smin_value = S64_MIN;
3069 dst_reg->smax_value = S64_MAX;
Yonghong Songafbe1a52018-04-28 22:28:10 -07003070 dst_reg->var_off = tnum_rshift(dst_reg->var_off, umin_val);
Edward Creeb03c9f92017-08-07 15:26:36 +01003071 dst_reg->umin_value >>= umax_val;
3072 dst_reg->umax_value >>= umin_val;
3073 /* We may learn something more from the var_off */
3074 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003075 break;
Yonghong Song9cbe1f5a2018-04-28 22:28:11 -07003076 case BPF_ARSH:
3077 if (umax_val >= insn_bitness) {
3078 /* Shifts greater than 31 or 63 are undefined.
3079 * This includes shifts by a negative number.
3080 */
3081 mark_reg_unknown(env, regs, insn->dst_reg);
3082 break;
3083 }
3084
3085 /* Upon reaching here, src_known is true and
3086 * umax_val is equal to umin_val.
3087 */
3088 dst_reg->smin_value >>= umin_val;
3089 dst_reg->smax_value >>= umin_val;
3090 dst_reg->var_off = tnum_arshift(dst_reg->var_off, umin_val);
3091
3092 /* blow away the dst_reg umin_value/umax_value and rely on
3093 * dst_reg var_off to refine the result.
3094 */
3095 dst_reg->umin_value = 0;
3096 dst_reg->umax_value = U64_MAX;
3097 __update_reg_bounds(dst_reg);
3098 break;
Josef Bacik48461132016-09-28 10:54:32 -04003099 default:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003100 mark_reg_unknown(env, regs, insn->dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003101 break;
3102 }
3103
Jann Horn468f6ea2017-12-18 20:11:56 -08003104 if (BPF_CLASS(insn->code) != BPF_ALU64) {
3105 /* 32-bit ALU ops are (32,32)->32 */
3106 coerce_reg_to_size(dst_reg, 4);
3107 coerce_reg_to_size(&src_reg, 4);
3108 }
3109
Edward Creeb03c9f92017-08-07 15:26:36 +01003110 __reg_deduce_bounds(dst_reg);
3111 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003112 return 0;
3113}
3114
3115/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
3116 * and var_off.
3117 */
3118static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
3119 struct bpf_insn *insn)
3120{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003121 struct bpf_verifier_state *vstate = env->cur_state;
3122 struct bpf_func_state *state = vstate->frame[vstate->curframe];
3123 struct bpf_reg_state *regs = state->regs, *dst_reg, *src_reg;
Edward Creef1174f72017-08-07 15:26:19 +01003124 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
3125 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01003126
3127 dst_reg = &regs[insn->dst_reg];
Edward Creef1174f72017-08-07 15:26:19 +01003128 src_reg = NULL;
3129 if (dst_reg->type != SCALAR_VALUE)
3130 ptr_reg = dst_reg;
3131 if (BPF_SRC(insn->code) == BPF_X) {
3132 src_reg = &regs[insn->src_reg];
Edward Creef1174f72017-08-07 15:26:19 +01003133 if (src_reg->type != SCALAR_VALUE) {
3134 if (dst_reg->type != SCALAR_VALUE) {
3135 /* Combining two pointers by any ALU op yields
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08003136 * an arbitrary scalar. Disallow all math except
3137 * pointer subtraction
Edward Creef1174f72017-08-07 15:26:19 +01003138 */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08003139 if (opcode == BPF_SUB){
3140 mark_reg_unknown(env, regs, insn->dst_reg);
3141 return 0;
Edward Creef1174f72017-08-07 15:26:19 +01003142 }
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08003143 verbose(env, "R%d pointer %s pointer prohibited\n",
3144 insn->dst_reg,
3145 bpf_alu_string[opcode >> 4]);
3146 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01003147 } else {
3148 /* scalar += pointer
3149 * This is legal, but we have to reverse our
3150 * src/dest handling in computing the range
3151 */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08003152 return adjust_ptr_min_max_vals(env, insn,
3153 src_reg, dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003154 }
3155 } else if (ptr_reg) {
3156 /* pointer += scalar */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08003157 return adjust_ptr_min_max_vals(env, insn,
3158 dst_reg, src_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003159 }
3160 } else {
3161 /* Pretend the src is a reg with a known value, since we only
3162 * need to be able to read from this state.
3163 */
3164 off_reg.type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01003165 __mark_reg_known(&off_reg, insn->imm);
Edward Creef1174f72017-08-07 15:26:19 +01003166 src_reg = &off_reg;
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08003167 if (ptr_reg) /* pointer += K */
3168 return adjust_ptr_min_max_vals(env, insn,
3169 ptr_reg, src_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003170 }
3171
3172 /* Got here implies adding two SCALAR_VALUEs */
3173 if (WARN_ON_ONCE(ptr_reg)) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003174 print_verifier_state(env, state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003175 verbose(env, "verifier internal error: unexpected ptr_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01003176 return -EINVAL;
3177 }
3178 if (WARN_ON(!src_reg)) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003179 print_verifier_state(env, state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003180 verbose(env, "verifier internal error: no src_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01003181 return -EINVAL;
3182 }
3183 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003184}
3185
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003186/* check validity of 32-bit and 64-bit arithmetic operations */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003187static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003188{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003189 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003190 u8 opcode = BPF_OP(insn->code);
3191 int err;
3192
3193 if (opcode == BPF_END || opcode == BPF_NEG) {
3194 if (opcode == BPF_NEG) {
3195 if (BPF_SRC(insn->code) != 0 ||
3196 insn->src_reg != BPF_REG_0 ||
3197 insn->off != 0 || insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003198 verbose(env, "BPF_NEG uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003199 return -EINVAL;
3200 }
3201 } else {
3202 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
Edward Creee67b8a62017-09-15 14:37:38 +01003203 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
3204 BPF_CLASS(insn->code) == BPF_ALU64) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003205 verbose(env, "BPF_END uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003206 return -EINVAL;
3207 }
3208 }
3209
3210 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003211 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003212 if (err)
3213 return err;
3214
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003215 if (is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003216 verbose(env, "R%d pointer arithmetic prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003217 insn->dst_reg);
3218 return -EACCES;
3219 }
3220
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003221 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01003222 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003223 if (err)
3224 return err;
3225
3226 } else if (opcode == BPF_MOV) {
3227
3228 if (BPF_SRC(insn->code) == BPF_X) {
3229 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003230 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003231 return -EINVAL;
3232 }
3233
3234 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003235 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003236 if (err)
3237 return err;
3238 } else {
3239 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003240 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003241 return -EINVAL;
3242 }
3243 }
3244
Arthur Fabrefbeb1602018-07-31 18:17:22 +01003245 /* check dest operand, mark as required later */
3246 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003247 if (err)
3248 return err;
3249
3250 if (BPF_SRC(insn->code) == BPF_X) {
3251 if (BPF_CLASS(insn->code) == BPF_ALU64) {
3252 /* case: R1 = R2
3253 * copy register state to dest reg
3254 */
3255 regs[insn->dst_reg] = regs[insn->src_reg];
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -07003256 regs[insn->dst_reg].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003257 } else {
Edward Creef1174f72017-08-07 15:26:19 +01003258 /* R1 = (u32) R2 */
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003259 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003260 verbose(env,
3261 "R%d partial copy of pointer\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003262 insn->src_reg);
3263 return -EACCES;
3264 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003265 mark_reg_unknown(env, regs, insn->dst_reg);
Jann Horn0c17d1d2017-12-18 20:11:55 -08003266 coerce_reg_to_size(&regs[insn->dst_reg], 4);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003267 }
3268 } else {
3269 /* case: R = imm
3270 * remember the value we stored into this reg
3271 */
Arthur Fabrefbeb1602018-07-31 18:17:22 +01003272 /* clear any state __mark_reg_known doesn't set */
3273 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003274 regs[insn->dst_reg].type = SCALAR_VALUE;
Jann Horn95a762e2017-12-18 20:11:54 -08003275 if (BPF_CLASS(insn->code) == BPF_ALU64) {
3276 __mark_reg_known(regs + insn->dst_reg,
3277 insn->imm);
3278 } else {
3279 __mark_reg_known(regs + insn->dst_reg,
3280 (u32)insn->imm);
3281 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003282 }
3283
3284 } else if (opcode > BPF_END) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003285 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003286 return -EINVAL;
3287
3288 } else { /* all other ALU ops: and, sub, xor, add, ... */
3289
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003290 if (BPF_SRC(insn->code) == BPF_X) {
3291 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003292 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003293 return -EINVAL;
3294 }
3295 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003296 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003297 if (err)
3298 return err;
3299 } else {
3300 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003301 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003302 return -EINVAL;
3303 }
3304 }
3305
3306 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003307 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003308 if (err)
3309 return err;
3310
3311 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
3312 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003313 verbose(env, "div by zero\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003314 return -EINVAL;
3315 }
3316
Daniel Borkmann7891a872018-01-10 20:04:37 +01003317 if (opcode == BPF_ARSH && BPF_CLASS(insn->code) != BPF_ALU64) {
3318 verbose(env, "BPF_ARSH not supported for 32 bit ALU\n");
3319 return -EINVAL;
3320 }
3321
Rabin Vincent229394e82016-01-12 20:17:08 +01003322 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
3323 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
3324 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
3325
3326 if (insn->imm < 0 || insn->imm >= size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003327 verbose(env, "invalid shift %d\n", insn->imm);
Rabin Vincent229394e82016-01-12 20:17:08 +01003328 return -EINVAL;
3329 }
3330 }
3331
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003332 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01003333 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003334 if (err)
3335 return err;
3336
Edward Creef1174f72017-08-07 15:26:19 +01003337 return adjust_reg_min_max_vals(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003338 }
3339
3340 return 0;
3341}
3342
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003343static void find_good_pkt_pointers(struct bpf_verifier_state *vstate,
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003344 struct bpf_reg_state *dst_reg,
David S. Millerf8ddadc2017-10-22 13:36:53 +01003345 enum bpf_reg_type type,
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003346 bool range_right_open)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003347{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003348 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003349 struct bpf_reg_state *regs = state->regs, *reg;
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003350 u16 new_range;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003351 int i, j;
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003352
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003353 if (dst_reg->off < 0 ||
3354 (dst_reg->off == 0 && range_right_open))
Edward Creef1174f72017-08-07 15:26:19 +01003355 /* This doesn't give us any range */
3356 return;
3357
Edward Creeb03c9f92017-08-07 15:26:36 +01003358 if (dst_reg->umax_value > MAX_PACKET_OFF ||
3359 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
Edward Creef1174f72017-08-07 15:26:19 +01003360 /* Risk of overflow. For instance, ptr + (1<<63) may be less
3361 * than pkt_end, but that's because it's also less than pkt.
3362 */
3363 return;
3364
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003365 new_range = dst_reg->off;
3366 if (range_right_open)
3367 new_range--;
3368
3369 /* Examples for register markings:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003370 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003371 * pkt_data in dst register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003372 *
3373 * r2 = r3;
3374 * r2 += 8;
3375 * if (r2 > pkt_end) goto <handle exception>
3376 * <access okay>
3377 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003378 * r2 = r3;
3379 * r2 += 8;
3380 * if (r2 < pkt_end) goto <access okay>
3381 * <handle exception>
3382 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003383 * Where:
3384 * r2 == dst_reg, pkt_end == src_reg
3385 * r2=pkt(id=n,off=8,r=0)
3386 * r3=pkt(id=n,off=0,r=0)
3387 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003388 * pkt_data in src register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003389 *
3390 * r2 = r3;
3391 * r2 += 8;
3392 * if (pkt_end >= r2) goto <access okay>
3393 * <handle exception>
3394 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003395 * r2 = r3;
3396 * r2 += 8;
3397 * if (pkt_end <= r2) goto <handle exception>
3398 * <access okay>
3399 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003400 * Where:
3401 * pkt_end == dst_reg, r2 == src_reg
3402 * r2=pkt(id=n,off=8,r=0)
3403 * r3=pkt(id=n,off=0,r=0)
3404 *
3405 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003406 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
3407 * and [r3, r3 + 8-1) respectively is safe to access depending on
3408 * the check.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003409 */
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003410
Edward Creef1174f72017-08-07 15:26:19 +01003411 /* If our ids match, then we must have the same max_value. And we
3412 * don't care about the other reg's fixed offset, since if it's too big
3413 * the range won't allow anything.
3414 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
3415 */
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003416 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003417 if (regs[i].type == type && regs[i].id == dst_reg->id)
Alexei Starovoitovb1977682017-03-24 15:57:33 -07003418 /* keep the maximum range already checked */
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003419 regs[i].range = max(regs[i].range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003420
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003421 for (j = 0; j <= vstate->curframe; j++) {
3422 state = vstate->frame[j];
3423 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
3424 if (state->stack[i].slot_type[0] != STACK_SPILL)
3425 continue;
3426 reg = &state->stack[i].spilled_ptr;
3427 if (reg->type == type && reg->id == dst_reg->id)
3428 reg->range = max(reg->range, new_range);
3429 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003430 }
3431}
3432
Josef Bacik48461132016-09-28 10:54:32 -04003433/* Adjusts the register min/max values in the case that the dst_reg is the
3434 * variable register that we are working on, and src_reg is a constant or we're
3435 * simply doing a BPF_K check.
Edward Creef1174f72017-08-07 15:26:19 +01003436 * In JEQ/JNE cases we also adjust the var_off values.
Josef Bacik48461132016-09-28 10:54:32 -04003437 */
3438static void reg_set_min_max(struct bpf_reg_state *true_reg,
3439 struct bpf_reg_state *false_reg, u64 val,
3440 u8 opcode)
3441{
Edward Creef1174f72017-08-07 15:26:19 +01003442 /* If the dst_reg is a pointer, we can't learn anything about its
3443 * variable offset from the compare (unless src_reg were a pointer into
3444 * the same object, but we don't bother with that.
3445 * Since false_reg and true_reg have the same type by construction, we
3446 * only need to check one of them for pointerness.
3447 */
3448 if (__is_pointer_value(false, false_reg))
3449 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02003450
Josef Bacik48461132016-09-28 10:54:32 -04003451 switch (opcode) {
3452 case BPF_JEQ:
3453 /* If this is false then we know nothing Jon Snow, but if it is
3454 * true then we know for sure.
3455 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003456 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003457 break;
3458 case BPF_JNE:
3459 /* If this is true we know nothing Jon Snow, but if it is false
3460 * we know the value for sure;
3461 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003462 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003463 break;
3464 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003465 false_reg->umax_value = min(false_reg->umax_value, val);
3466 true_reg->umin_value = max(true_reg->umin_value, val + 1);
3467 break;
Josef Bacik48461132016-09-28 10:54:32 -04003468 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003469 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
3470 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04003471 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003472 case BPF_JLT:
3473 false_reg->umin_value = max(false_reg->umin_value, val);
3474 true_reg->umax_value = min(true_reg->umax_value, val - 1);
3475 break;
3476 case BPF_JSLT:
3477 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
3478 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
3479 break;
Josef Bacik48461132016-09-28 10:54:32 -04003480 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003481 false_reg->umax_value = min(false_reg->umax_value, val - 1);
3482 true_reg->umin_value = max(true_reg->umin_value, val);
3483 break;
Josef Bacik48461132016-09-28 10:54:32 -04003484 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003485 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
3486 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04003487 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003488 case BPF_JLE:
3489 false_reg->umin_value = max(false_reg->umin_value, val + 1);
3490 true_reg->umax_value = min(true_reg->umax_value, val);
3491 break;
3492 case BPF_JSLE:
3493 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
3494 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
3495 break;
Josef Bacik48461132016-09-28 10:54:32 -04003496 default:
3497 break;
3498 }
3499
Edward Creeb03c9f92017-08-07 15:26:36 +01003500 __reg_deduce_bounds(false_reg);
3501 __reg_deduce_bounds(true_reg);
3502 /* We might have learned some bits from the bounds. */
3503 __reg_bound_offset(false_reg);
3504 __reg_bound_offset(true_reg);
3505 /* Intersecting with the old var_off might have improved our bounds
3506 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
3507 * then new var_off is (0; 0x7f...fc) which improves our umax.
3508 */
3509 __update_reg_bounds(false_reg);
3510 __update_reg_bounds(true_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003511}
3512
Edward Creef1174f72017-08-07 15:26:19 +01003513/* Same as above, but for the case that dst_reg holds a constant and src_reg is
3514 * the variable reg.
Josef Bacik48461132016-09-28 10:54:32 -04003515 */
3516static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
3517 struct bpf_reg_state *false_reg, u64 val,
3518 u8 opcode)
3519{
Edward Creef1174f72017-08-07 15:26:19 +01003520 if (__is_pointer_value(false, false_reg))
3521 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02003522
Josef Bacik48461132016-09-28 10:54:32 -04003523 switch (opcode) {
3524 case BPF_JEQ:
3525 /* If this is false then we know nothing Jon Snow, but if it is
3526 * true then we know for sure.
3527 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003528 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003529 break;
3530 case BPF_JNE:
3531 /* If this is true we know nothing Jon Snow, but if it is false
3532 * we know the value for sure;
3533 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003534 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003535 break;
3536 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003537 true_reg->umax_value = min(true_reg->umax_value, val - 1);
3538 false_reg->umin_value = max(false_reg->umin_value, val);
3539 break;
Josef Bacik48461132016-09-28 10:54:32 -04003540 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003541 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
3542 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04003543 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003544 case BPF_JLT:
3545 true_reg->umin_value = max(true_reg->umin_value, val + 1);
3546 false_reg->umax_value = min(false_reg->umax_value, val);
3547 break;
3548 case BPF_JSLT:
3549 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
3550 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
3551 break;
Josef Bacik48461132016-09-28 10:54:32 -04003552 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003553 true_reg->umax_value = min(true_reg->umax_value, val);
3554 false_reg->umin_value = max(false_reg->umin_value, val + 1);
3555 break;
Josef Bacik48461132016-09-28 10:54:32 -04003556 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003557 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
3558 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04003559 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003560 case BPF_JLE:
3561 true_reg->umin_value = max(true_reg->umin_value, val);
3562 false_reg->umax_value = min(false_reg->umax_value, val - 1);
3563 break;
3564 case BPF_JSLE:
3565 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
3566 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
3567 break;
Josef Bacik48461132016-09-28 10:54:32 -04003568 default:
3569 break;
3570 }
3571
Edward Creeb03c9f92017-08-07 15:26:36 +01003572 __reg_deduce_bounds(false_reg);
3573 __reg_deduce_bounds(true_reg);
3574 /* We might have learned some bits from the bounds. */
3575 __reg_bound_offset(false_reg);
3576 __reg_bound_offset(true_reg);
3577 /* Intersecting with the old var_off might have improved our bounds
3578 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
3579 * then new var_off is (0; 0x7f...fc) which improves our umax.
3580 */
3581 __update_reg_bounds(false_reg);
3582 __update_reg_bounds(true_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003583}
3584
3585/* Regs are known to be equal, so intersect their min/max/var_off */
3586static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
3587 struct bpf_reg_state *dst_reg)
3588{
Edward Creeb03c9f92017-08-07 15:26:36 +01003589 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
3590 dst_reg->umin_value);
3591 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
3592 dst_reg->umax_value);
3593 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
3594 dst_reg->smin_value);
3595 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
3596 dst_reg->smax_value);
Edward Creef1174f72017-08-07 15:26:19 +01003597 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
3598 dst_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01003599 /* We might have learned new bounds from the var_off. */
3600 __update_reg_bounds(src_reg);
3601 __update_reg_bounds(dst_reg);
3602 /* We might have learned something about the sign bit. */
3603 __reg_deduce_bounds(src_reg);
3604 __reg_deduce_bounds(dst_reg);
3605 /* We might have learned some bits from the bounds. */
3606 __reg_bound_offset(src_reg);
3607 __reg_bound_offset(dst_reg);
3608 /* Intersecting with the old var_off might have improved our bounds
3609 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
3610 * then new var_off is (0; 0x7f...fc) which improves our umax.
3611 */
3612 __update_reg_bounds(src_reg);
3613 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003614}
3615
3616static void reg_combine_min_max(struct bpf_reg_state *true_src,
3617 struct bpf_reg_state *true_dst,
3618 struct bpf_reg_state *false_src,
3619 struct bpf_reg_state *false_dst,
3620 u8 opcode)
3621{
3622 switch (opcode) {
3623 case BPF_JEQ:
3624 __reg_combine_min_max(true_src, true_dst);
3625 break;
3626 case BPF_JNE:
3627 __reg_combine_min_max(false_src, false_dst);
Edward Creeb03c9f92017-08-07 15:26:36 +01003628 break;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02003629 }
Josef Bacik48461132016-09-28 10:54:32 -04003630}
3631
Thomas Graf57a09bf2016-10-18 19:51:19 +02003632static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
Edward Creef1174f72017-08-07 15:26:19 +01003633 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02003634{
3635 struct bpf_reg_state *reg = &regs[regno];
3636
3637 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
Edward Creef1174f72017-08-07 15:26:19 +01003638 /* Old offset (both fixed and variable parts) should
3639 * have been known-zero, because we don't allow pointer
3640 * arithmetic on pointers that might be NULL.
3641 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003642 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
3643 !tnum_equals_const(reg->var_off, 0) ||
Edward Creef1174f72017-08-07 15:26:19 +01003644 reg->off)) {
Edward Creeb03c9f92017-08-07 15:26:36 +01003645 __mark_reg_known_zero(reg);
3646 reg->off = 0;
Edward Creef1174f72017-08-07 15:26:19 +01003647 }
3648 if (is_null) {
3649 reg->type = SCALAR_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07003650 } else if (reg->map_ptr->inner_map_meta) {
3651 reg->type = CONST_PTR_TO_MAP;
3652 reg->map_ptr = reg->map_ptr->inner_map_meta;
3653 } else {
Edward Creef1174f72017-08-07 15:26:19 +01003654 reg->type = PTR_TO_MAP_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07003655 }
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01003656 /* We don't need id from this point onwards anymore, thus we
3657 * should better reset it, so that state pruning has chances
3658 * to take effect.
3659 */
3660 reg->id = 0;
Thomas Graf57a09bf2016-10-18 19:51:19 +02003661 }
3662}
3663
3664/* The logic is similar to find_good_pkt_pointers(), both could eventually
3665 * be folded together at some point.
3666 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003667static void mark_map_regs(struct bpf_verifier_state *vstate, u32 regno,
Edward Creef1174f72017-08-07 15:26:19 +01003668 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02003669{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003670 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Thomas Graf57a09bf2016-10-18 19:51:19 +02003671 struct bpf_reg_state *regs = state->regs;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01003672 u32 id = regs[regno].id;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003673 int i, j;
Thomas Graf57a09bf2016-10-18 19:51:19 +02003674
3675 for (i = 0; i < MAX_BPF_REG; i++)
Edward Creef1174f72017-08-07 15:26:19 +01003676 mark_map_reg(regs, i, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02003677
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003678 for (j = 0; j <= vstate->curframe; j++) {
3679 state = vstate->frame[j];
3680 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
3681 if (state->stack[i].slot_type[0] != STACK_SPILL)
3682 continue;
3683 mark_map_reg(&state->stack[i].spilled_ptr, 0, id, is_null);
3684 }
Thomas Graf57a09bf2016-10-18 19:51:19 +02003685 }
3686}
3687
Daniel Borkmann5beca082017-11-01 23:58:10 +01003688static bool try_match_pkt_pointers(const struct bpf_insn *insn,
3689 struct bpf_reg_state *dst_reg,
3690 struct bpf_reg_state *src_reg,
3691 struct bpf_verifier_state *this_branch,
3692 struct bpf_verifier_state *other_branch)
3693{
3694 if (BPF_SRC(insn->code) != BPF_X)
3695 return false;
3696
3697 switch (BPF_OP(insn->code)) {
3698 case BPF_JGT:
3699 if ((dst_reg->type == PTR_TO_PACKET &&
3700 src_reg->type == PTR_TO_PACKET_END) ||
3701 (dst_reg->type == PTR_TO_PACKET_META &&
3702 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3703 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
3704 find_good_pkt_pointers(this_branch, dst_reg,
3705 dst_reg->type, false);
3706 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3707 src_reg->type == PTR_TO_PACKET) ||
3708 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3709 src_reg->type == PTR_TO_PACKET_META)) {
3710 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
3711 find_good_pkt_pointers(other_branch, src_reg,
3712 src_reg->type, true);
3713 } else {
3714 return false;
3715 }
3716 break;
3717 case BPF_JLT:
3718 if ((dst_reg->type == PTR_TO_PACKET &&
3719 src_reg->type == PTR_TO_PACKET_END) ||
3720 (dst_reg->type == PTR_TO_PACKET_META &&
3721 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3722 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
3723 find_good_pkt_pointers(other_branch, dst_reg,
3724 dst_reg->type, true);
3725 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3726 src_reg->type == PTR_TO_PACKET) ||
3727 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3728 src_reg->type == PTR_TO_PACKET_META)) {
3729 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
3730 find_good_pkt_pointers(this_branch, src_reg,
3731 src_reg->type, false);
3732 } else {
3733 return false;
3734 }
3735 break;
3736 case BPF_JGE:
3737 if ((dst_reg->type == PTR_TO_PACKET &&
3738 src_reg->type == PTR_TO_PACKET_END) ||
3739 (dst_reg->type == PTR_TO_PACKET_META &&
3740 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3741 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
3742 find_good_pkt_pointers(this_branch, dst_reg,
3743 dst_reg->type, true);
3744 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3745 src_reg->type == PTR_TO_PACKET) ||
3746 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3747 src_reg->type == PTR_TO_PACKET_META)) {
3748 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
3749 find_good_pkt_pointers(other_branch, src_reg,
3750 src_reg->type, false);
3751 } else {
3752 return false;
3753 }
3754 break;
3755 case BPF_JLE:
3756 if ((dst_reg->type == PTR_TO_PACKET &&
3757 src_reg->type == PTR_TO_PACKET_END) ||
3758 (dst_reg->type == PTR_TO_PACKET_META &&
3759 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3760 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
3761 find_good_pkt_pointers(other_branch, dst_reg,
3762 dst_reg->type, false);
3763 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3764 src_reg->type == PTR_TO_PACKET) ||
3765 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3766 src_reg->type == PTR_TO_PACKET_META)) {
3767 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
3768 find_good_pkt_pointers(this_branch, src_reg,
3769 src_reg->type, true);
3770 } else {
3771 return false;
3772 }
3773 break;
3774 default:
3775 return false;
3776 }
3777
3778 return true;
3779}
3780
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003781static int check_cond_jmp_op(struct bpf_verifier_env *env,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003782 struct bpf_insn *insn, int *insn_idx)
3783{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003784 struct bpf_verifier_state *this_branch = env->cur_state;
3785 struct bpf_verifier_state *other_branch;
3786 struct bpf_reg_state *regs = this_branch->frame[this_branch->curframe]->regs;
3787 struct bpf_reg_state *dst_reg, *other_branch_regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003788 u8 opcode = BPF_OP(insn->code);
3789 int err;
3790
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003791 if (opcode > BPF_JSLE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003792 verbose(env, "invalid BPF_JMP opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003793 return -EINVAL;
3794 }
3795
3796 if (BPF_SRC(insn->code) == BPF_X) {
3797 if (insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003798 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003799 return -EINVAL;
3800 }
3801
3802 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003803 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003804 if (err)
3805 return err;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003806
3807 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003808 verbose(env, "R%d pointer comparison prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003809 insn->src_reg);
3810 return -EACCES;
3811 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003812 } else {
3813 if (insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003814 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003815 return -EINVAL;
3816 }
3817 }
3818
3819 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003820 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003821 if (err)
3822 return err;
3823
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003824 dst_reg = &regs[insn->dst_reg];
3825
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003826 /* detect if R == 0 where R was initialized to zero earlier */
3827 if (BPF_SRC(insn->code) == BPF_K &&
3828 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
Edward Creef1174f72017-08-07 15:26:19 +01003829 dst_reg->type == SCALAR_VALUE &&
Alexei Starovoitov3bf15922017-11-30 21:31:39 -08003830 tnum_is_const(dst_reg->var_off)) {
3831 if ((opcode == BPF_JEQ && dst_reg->var_off.value == insn->imm) ||
3832 (opcode == BPF_JNE && dst_reg->var_off.value != insn->imm)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003833 /* if (imm == imm) goto pc+off;
3834 * only follow the goto, ignore fall-through
3835 */
3836 *insn_idx += insn->off;
3837 return 0;
3838 } else {
3839 /* if (imm != imm) goto pc+off;
3840 * only follow fall-through branch, since
3841 * that's where the program will go
3842 */
3843 return 0;
3844 }
3845 }
3846
3847 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
3848 if (!other_branch)
3849 return -EFAULT;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003850 other_branch_regs = other_branch->frame[other_branch->curframe]->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003851
Josef Bacik48461132016-09-28 10:54:32 -04003852 /* detect if we are comparing against a constant value so we can adjust
3853 * our min/max values for our dst register.
Edward Creef1174f72017-08-07 15:26:19 +01003854 * this is only legit if both are scalars (or pointers to the same
3855 * object, I suppose, but we don't support that right now), because
3856 * otherwise the different base pointers mean the offsets aren't
3857 * comparable.
Josef Bacik48461132016-09-28 10:54:32 -04003858 */
3859 if (BPF_SRC(insn->code) == BPF_X) {
Edward Creef1174f72017-08-07 15:26:19 +01003860 if (dst_reg->type == SCALAR_VALUE &&
3861 regs[insn->src_reg].type == SCALAR_VALUE) {
3862 if (tnum_is_const(regs[insn->src_reg].var_off))
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003863 reg_set_min_max(&other_branch_regs[insn->dst_reg],
Edward Creef1174f72017-08-07 15:26:19 +01003864 dst_reg, regs[insn->src_reg].var_off.value,
3865 opcode);
3866 else if (tnum_is_const(dst_reg->var_off))
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003867 reg_set_min_max_inv(&other_branch_regs[insn->src_reg],
Edward Creef1174f72017-08-07 15:26:19 +01003868 &regs[insn->src_reg],
3869 dst_reg->var_off.value, opcode);
3870 else if (opcode == BPF_JEQ || opcode == BPF_JNE)
3871 /* Comparing for equality, we can combine knowledge */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003872 reg_combine_min_max(&other_branch_regs[insn->src_reg],
3873 &other_branch_regs[insn->dst_reg],
Edward Creef1174f72017-08-07 15:26:19 +01003874 &regs[insn->src_reg],
3875 &regs[insn->dst_reg], opcode);
3876 }
3877 } else if (dst_reg->type == SCALAR_VALUE) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003878 reg_set_min_max(&other_branch_regs[insn->dst_reg],
Josef Bacik48461132016-09-28 10:54:32 -04003879 dst_reg, insn->imm, opcode);
3880 }
3881
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003882 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003883 if (BPF_SRC(insn->code) == BPF_K &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003884 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
3885 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Thomas Graf57a09bf2016-10-18 19:51:19 +02003886 /* Mark all identical map registers in each branch as either
3887 * safe or unknown depending R == 0 or R != 0 conditional.
3888 */
Edward Creef1174f72017-08-07 15:26:19 +01003889 mark_map_regs(this_branch, insn->dst_reg, opcode == BPF_JNE);
3890 mark_map_regs(other_branch, insn->dst_reg, opcode == BPF_JEQ);
Daniel Borkmann5beca082017-11-01 23:58:10 +01003891 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
3892 this_branch, other_branch) &&
3893 is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003894 verbose(env, "R%d pointer comparison prohibited\n",
3895 insn->dst_reg);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003896 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003897 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003898 if (env->log.level)
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003899 print_verifier_state(env, this_branch->frame[this_branch->curframe]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003900 return 0;
3901}
3902
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003903/* return the map pointer stored inside BPF_LD_IMM64 instruction */
3904static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
3905{
3906 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
3907
3908 return (struct bpf_map *) (unsigned long) imm64;
3909}
3910
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003911/* verify BPF_LD_IMM64 instruction */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003912static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003913{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003914 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003915 int err;
3916
3917 if (BPF_SIZE(insn->code) != BPF_DW) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003918 verbose(env, "invalid BPF_LD_IMM insn\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003919 return -EINVAL;
3920 }
3921 if (insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003922 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003923 return -EINVAL;
3924 }
3925
Edward Creedc503a82017-08-15 20:34:35 +01003926 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003927 if (err)
3928 return err;
3929
Jakub Kicinski6b173872016-09-21 11:43:59 +01003930 if (insn->src_reg == 0) {
Jakub Kicinski6b173872016-09-21 11:43:59 +01003931 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
3932
Edward Creef1174f72017-08-07 15:26:19 +01003933 regs[insn->dst_reg].type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01003934 __mark_reg_known(&regs[insn->dst_reg], imm);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003935 return 0;
Jakub Kicinski6b173872016-09-21 11:43:59 +01003936 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003937
3938 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
3939 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
3940
3941 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
3942 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
3943 return 0;
3944}
3945
Daniel Borkmann96be4322015-03-01 12:31:46 +01003946static bool may_access_skb(enum bpf_prog_type type)
3947{
3948 switch (type) {
3949 case BPF_PROG_TYPE_SOCKET_FILTER:
3950 case BPF_PROG_TYPE_SCHED_CLS:
Daniel Borkmann94caee8c2015-03-20 15:11:11 +01003951 case BPF_PROG_TYPE_SCHED_ACT:
Daniel Borkmann96be4322015-03-01 12:31:46 +01003952 return true;
3953 default:
3954 return false;
3955 }
3956}
3957
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003958/* verify safety of LD_ABS|LD_IND instructions:
3959 * - they can only appear in the programs where ctx == skb
3960 * - since they are wrappers of function calls, they scratch R1-R5 registers,
3961 * preserve R6-R9, and store return value into R0
3962 *
3963 * Implicit input:
3964 * ctx == skb == R6 == CTX
3965 *
3966 * Explicit input:
3967 * SRC == any register
3968 * IMM == 32-bit immediate
3969 *
3970 * Output:
3971 * R0 - 8/16/32-bit skb data converted to cpu endianness
3972 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003973static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003974{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003975 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003976 u8 mode = BPF_MODE(insn->code);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003977 int i, err;
3978
Daniel Borkmann24701ec2015-03-01 12:31:47 +01003979 if (!may_access_skb(env->prog->type)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003980 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003981 return -EINVAL;
3982 }
3983
Daniel Borkmanne0cea7c2018-05-04 01:08:14 +02003984 if (!env->ops->gen_ld_abs) {
3985 verbose(env, "bpf verifier is misconfigured\n");
3986 return -EINVAL;
3987 }
3988
Jiong Wangf910cef2018-05-02 16:17:17 -04003989 if (env->subprog_cnt > 1) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003990 /* when program has LD_ABS insn JITs and interpreter assume
3991 * that r1 == ctx == skb which is not the case for callees
3992 * that can have arbitrary arguments. It's problematic
3993 * for main prog as well since JITs would need to analyze
3994 * all functions in order to make proper register save/restore
3995 * decisions in the main prog. Hence disallow LD_ABS with calls
3996 */
3997 verbose(env, "BPF_LD_[ABS|IND] instructions cannot be mixed with bpf-to-bpf calls\n");
3998 return -EINVAL;
3999 }
4000
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004001 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
Alexei Starovoitovd82bccc2016-04-12 10:26:19 -07004002 BPF_SIZE(insn->code) == BPF_DW ||
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004003 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004004 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004005 return -EINVAL;
4006 }
4007
4008 /* check whether implicit source operand (register R6) is readable */
Edward Creedc503a82017-08-15 20:34:35 +01004009 err = check_reg_arg(env, BPF_REG_6, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004010 if (err)
4011 return err;
4012
4013 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004014 verbose(env,
4015 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004016 return -EINVAL;
4017 }
4018
4019 if (mode == BPF_IND) {
4020 /* check explicit source operand */
Edward Creedc503a82017-08-15 20:34:35 +01004021 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004022 if (err)
4023 return err;
4024 }
4025
4026 /* reset caller saved regs to unreadable */
Edward Creedc503a82017-08-15 20:34:35 +01004027 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004028 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01004029 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
4030 }
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004031
4032 /* mark destination R0 register as readable, since it contains
Edward Creedc503a82017-08-15 20:34:35 +01004033 * the value fetched from the packet.
4034 * Already marked as written above.
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004035 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004036 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004037 return 0;
4038}
4039
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004040static int check_return_code(struct bpf_verifier_env *env)
4041{
4042 struct bpf_reg_state *reg;
4043 struct tnum range = tnum_range(0, 1);
4044
4045 switch (env->prog->type) {
4046 case BPF_PROG_TYPE_CGROUP_SKB:
4047 case BPF_PROG_TYPE_CGROUP_SOCK:
Andrey Ignatov4fbac772018-03-30 15:08:02 -07004048 case BPF_PROG_TYPE_CGROUP_SOCK_ADDR:
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004049 case BPF_PROG_TYPE_SOCK_OPS:
Roman Gushchinebc614f2017-11-05 08:15:32 -05004050 case BPF_PROG_TYPE_CGROUP_DEVICE:
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004051 break;
4052 default:
4053 return 0;
4054 }
4055
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004056 reg = cur_regs(env) + BPF_REG_0;
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004057 if (reg->type != SCALAR_VALUE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004058 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004059 reg_type_str[reg->type]);
4060 return -EINVAL;
4061 }
4062
4063 if (!tnum_in(range, reg->var_off)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004064 verbose(env, "At program exit the register R0 ");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004065 if (!tnum_is_unknown(reg->var_off)) {
4066 char tn_buf[48];
4067
4068 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004069 verbose(env, "has value %s", tn_buf);
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004070 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004071 verbose(env, "has unknown scalar value");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004072 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004073 verbose(env, " should have been 0 or 1\n");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004074 return -EINVAL;
4075 }
4076 return 0;
4077}
4078
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004079/* non-recursive DFS pseudo code
4080 * 1 procedure DFS-iterative(G,v):
4081 * 2 label v as discovered
4082 * 3 let S be a stack
4083 * 4 S.push(v)
4084 * 5 while S is not empty
4085 * 6 t <- S.pop()
4086 * 7 if t is what we're looking for:
4087 * 8 return t
4088 * 9 for all edges e in G.adjacentEdges(t) do
4089 * 10 if edge e is already labelled
4090 * 11 continue with the next edge
4091 * 12 w <- G.adjacentVertex(t,e)
4092 * 13 if vertex w is not discovered and not explored
4093 * 14 label e as tree-edge
4094 * 15 label w as discovered
4095 * 16 S.push(w)
4096 * 17 continue at 5
4097 * 18 else if vertex w is discovered
4098 * 19 label e as back-edge
4099 * 20 else
4100 * 21 // vertex w is explored
4101 * 22 label e as forward- or cross-edge
4102 * 23 label t as explored
4103 * 24 S.pop()
4104 *
4105 * convention:
4106 * 0x10 - discovered
4107 * 0x11 - discovered and fall-through edge labelled
4108 * 0x12 - discovered and fall-through and branch edges labelled
4109 * 0x20 - explored
4110 */
4111
4112enum {
4113 DISCOVERED = 0x10,
4114 EXPLORED = 0x20,
4115 FALLTHROUGH = 1,
4116 BRANCH = 2,
4117};
4118
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004119#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004120
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004121static int *insn_stack; /* stack of insns to process */
4122static int cur_stack; /* current stack index */
4123static int *insn_state;
4124
4125/* t, w, e - match pseudo-code above:
4126 * t - index of current instruction
4127 * w - next instruction
4128 * e - edge
4129 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004130static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004131{
4132 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
4133 return 0;
4134
4135 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
4136 return 0;
4137
4138 if (w < 0 || w >= env->prog->len) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004139 verbose(env, "jump out of range from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004140 return -EINVAL;
4141 }
4142
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004143 if (e == BRANCH)
4144 /* mark branch target for state pruning */
4145 env->explored_states[w] = STATE_LIST_MARK;
4146
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004147 if (insn_state[w] == 0) {
4148 /* tree-edge */
4149 insn_state[t] = DISCOVERED | e;
4150 insn_state[w] = DISCOVERED;
4151 if (cur_stack >= env->prog->len)
4152 return -E2BIG;
4153 insn_stack[cur_stack++] = w;
4154 return 1;
4155 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004156 verbose(env, "back-edge from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004157 return -EINVAL;
4158 } else if (insn_state[w] == EXPLORED) {
4159 /* forward- or cross-edge */
4160 insn_state[t] = DISCOVERED | e;
4161 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004162 verbose(env, "insn state internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004163 return -EFAULT;
4164 }
4165 return 0;
4166}
4167
4168/* non-recursive depth-first-search to detect loops in BPF program
4169 * loop == back-edge in directed graph
4170 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004171static int check_cfg(struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004172{
4173 struct bpf_insn *insns = env->prog->insnsi;
4174 int insn_cnt = env->prog->len;
4175 int ret = 0;
4176 int i, t;
4177
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08004178 ret = check_subprogs(env);
4179 if (ret < 0)
4180 return ret;
4181
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004182 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
4183 if (!insn_state)
4184 return -ENOMEM;
4185
4186 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
4187 if (!insn_stack) {
4188 kfree(insn_state);
4189 return -ENOMEM;
4190 }
4191
4192 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
4193 insn_stack[0] = 0; /* 0 is the first instruction */
4194 cur_stack = 1;
4195
4196peek_stack:
4197 if (cur_stack == 0)
4198 goto check_state;
4199 t = insn_stack[cur_stack - 1];
4200
4201 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
4202 u8 opcode = BPF_OP(insns[t].code);
4203
4204 if (opcode == BPF_EXIT) {
4205 goto mark_explored;
4206 } else if (opcode == BPF_CALL) {
4207 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4208 if (ret == 1)
4209 goto peek_stack;
4210 else if (ret < 0)
4211 goto err_free;
Daniel Borkmann07016152016-04-05 22:33:17 +02004212 if (t + 1 < insn_cnt)
4213 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08004214 if (insns[t].src_reg == BPF_PSEUDO_CALL) {
4215 env->explored_states[t] = STATE_LIST_MARK;
4216 ret = push_insn(t, t + insns[t].imm + 1, BRANCH, env);
4217 if (ret == 1)
4218 goto peek_stack;
4219 else if (ret < 0)
4220 goto err_free;
4221 }
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004222 } else if (opcode == BPF_JA) {
4223 if (BPF_SRC(insns[t].code) != BPF_K) {
4224 ret = -EINVAL;
4225 goto err_free;
4226 }
4227 /* unconditional jump with single edge */
4228 ret = push_insn(t, t + insns[t].off + 1,
4229 FALLTHROUGH, env);
4230 if (ret == 1)
4231 goto peek_stack;
4232 else if (ret < 0)
4233 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004234 /* tell verifier to check for equivalent states
4235 * after every call and jump
4236 */
Alexei Starovoitovc3de6312015-04-14 15:57:13 -07004237 if (t + 1 < insn_cnt)
4238 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004239 } else {
4240 /* conditional jump with two edges */
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02004241 env->explored_states[t] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004242 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4243 if (ret == 1)
4244 goto peek_stack;
4245 else if (ret < 0)
4246 goto err_free;
4247
4248 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
4249 if (ret == 1)
4250 goto peek_stack;
4251 else if (ret < 0)
4252 goto err_free;
4253 }
4254 } else {
4255 /* all other non-branch instructions with single
4256 * fall-through edge
4257 */
4258 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4259 if (ret == 1)
4260 goto peek_stack;
4261 else if (ret < 0)
4262 goto err_free;
4263 }
4264
4265mark_explored:
4266 insn_state[t] = EXPLORED;
4267 if (cur_stack-- <= 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004268 verbose(env, "pop stack internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004269 ret = -EFAULT;
4270 goto err_free;
4271 }
4272 goto peek_stack;
4273
4274check_state:
4275 for (i = 0; i < insn_cnt; i++) {
4276 if (insn_state[i] != EXPLORED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004277 verbose(env, "unreachable insn %d\n", i);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004278 ret = -EINVAL;
4279 goto err_free;
4280 }
4281 }
4282 ret = 0; /* cfg looks good */
4283
4284err_free:
4285 kfree(insn_state);
4286 kfree(insn_stack);
4287 return ret;
4288}
4289
Edward Creef1174f72017-08-07 15:26:19 +01004290/* check %cur's range satisfies %old's */
4291static bool range_within(struct bpf_reg_state *old,
4292 struct bpf_reg_state *cur)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004293{
Edward Creeb03c9f92017-08-07 15:26:36 +01004294 return old->umin_value <= cur->umin_value &&
4295 old->umax_value >= cur->umax_value &&
4296 old->smin_value <= cur->smin_value &&
4297 old->smax_value >= cur->smax_value;
Edward Creef1174f72017-08-07 15:26:19 +01004298}
4299
4300/* Maximum number of register states that can exist at once */
4301#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
4302struct idpair {
4303 u32 old;
4304 u32 cur;
4305};
4306
4307/* If in the old state two registers had the same id, then they need to have
4308 * the same id in the new state as well. But that id could be different from
4309 * the old state, so we need to track the mapping from old to new ids.
4310 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
4311 * regs with old id 5 must also have new id 9 for the new state to be safe. But
4312 * regs with a different old id could still have new id 9, we don't care about
4313 * that.
4314 * So we look through our idmap to see if this old id has been seen before. If
4315 * so, we require the new id to match; otherwise, we add the id pair to the map.
4316 */
4317static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
4318{
4319 unsigned int i;
4320
4321 for (i = 0; i < ID_MAP_SIZE; i++) {
4322 if (!idmap[i].old) {
4323 /* Reached an empty slot; haven't seen this id before */
4324 idmap[i].old = old_id;
4325 idmap[i].cur = cur_id;
4326 return true;
4327 }
4328 if (idmap[i].old == old_id)
4329 return idmap[i].cur == cur_id;
4330 }
4331 /* We ran out of idmap slots, which should be impossible */
4332 WARN_ON_ONCE(1);
4333 return false;
4334}
4335
4336/* Returns true if (rold safe implies rcur safe) */
Edward Cree1b688a12017-08-23 15:10:50 +01004337static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
4338 struct idpair *idmap)
Edward Creef1174f72017-08-07 15:26:19 +01004339{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004340 bool equal;
4341
Edward Creedc503a82017-08-15 20:34:35 +01004342 if (!(rold->live & REG_LIVE_READ))
4343 /* explored state didn't use this */
4344 return true;
4345
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004346 equal = memcmp(rold, rcur, offsetof(struct bpf_reg_state, frameno)) == 0;
4347
4348 if (rold->type == PTR_TO_STACK)
4349 /* two stack pointers are equal only if they're pointing to
4350 * the same stack frame, since fp-8 in foo != fp-8 in bar
4351 */
4352 return equal && rold->frameno == rcur->frameno;
4353
4354 if (equal)
Edward Creef1174f72017-08-07 15:26:19 +01004355 return true;
4356
4357 if (rold->type == NOT_INIT)
4358 /* explored state can't have used this */
4359 return true;
4360 if (rcur->type == NOT_INIT)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004361 return false;
Edward Creef1174f72017-08-07 15:26:19 +01004362 switch (rold->type) {
4363 case SCALAR_VALUE:
4364 if (rcur->type == SCALAR_VALUE) {
4365 /* new val must satisfy old val knowledge */
4366 return range_within(rold, rcur) &&
4367 tnum_in(rold->var_off, rcur->var_off);
4368 } else {
Jann Horn179d1c52017-12-18 20:11:59 -08004369 /* We're trying to use a pointer in place of a scalar.
4370 * Even if the scalar was unbounded, this could lead to
4371 * pointer leaks because scalars are allowed to leak
4372 * while pointers are not. We could make this safe in
4373 * special cases if root is calling us, but it's
4374 * probably not worth the hassle.
Edward Creef1174f72017-08-07 15:26:19 +01004375 */
Jann Horn179d1c52017-12-18 20:11:59 -08004376 return false;
Edward Creef1174f72017-08-07 15:26:19 +01004377 }
4378 case PTR_TO_MAP_VALUE:
Edward Cree1b688a12017-08-23 15:10:50 +01004379 /* If the new min/max/var_off satisfy the old ones and
4380 * everything else matches, we are OK.
4381 * We don't care about the 'id' value, because nothing
4382 * uses it for PTR_TO_MAP_VALUE (only for ..._OR_NULL)
4383 */
4384 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
4385 range_within(rold, rcur) &&
4386 tnum_in(rold->var_off, rcur->var_off);
Edward Creef1174f72017-08-07 15:26:19 +01004387 case PTR_TO_MAP_VALUE_OR_NULL:
4388 /* a PTR_TO_MAP_VALUE could be safe to use as a
4389 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
4390 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
4391 * checked, doing so could have affected others with the same
4392 * id, and we can't check for that because we lost the id when
4393 * we converted to a PTR_TO_MAP_VALUE.
4394 */
4395 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
4396 return false;
4397 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
4398 return false;
4399 /* Check our ids match any regs they're supposed to */
4400 return check_ids(rold->id, rcur->id, idmap);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02004401 case PTR_TO_PACKET_META:
Edward Creef1174f72017-08-07 15:26:19 +01004402 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02004403 if (rcur->type != rold->type)
Edward Creef1174f72017-08-07 15:26:19 +01004404 return false;
4405 /* We must have at least as much range as the old ptr
4406 * did, so that any accesses which were safe before are
4407 * still safe. This is true even if old range < old off,
4408 * since someone could have accessed through (ptr - k), or
4409 * even done ptr -= k in a register, to get a safe access.
4410 */
4411 if (rold->range > rcur->range)
4412 return false;
4413 /* If the offsets don't match, we can't trust our alignment;
4414 * nor can we be sure that we won't fall out of range.
4415 */
4416 if (rold->off != rcur->off)
4417 return false;
4418 /* id relations must be preserved */
4419 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
4420 return false;
4421 /* new val must satisfy old val knowledge */
4422 return range_within(rold, rcur) &&
4423 tnum_in(rold->var_off, rcur->var_off);
4424 case PTR_TO_CTX:
4425 case CONST_PTR_TO_MAP:
Edward Creef1174f72017-08-07 15:26:19 +01004426 case PTR_TO_PACKET_END:
4427 /* Only valid matches are exact, which memcmp() above
4428 * would have accepted
4429 */
4430 default:
4431 /* Don't know what's going on, just say it's not safe */
4432 return false;
4433 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004434
Edward Creef1174f72017-08-07 15:26:19 +01004435 /* Shouldn't get here; if we do, say it's not safe */
4436 WARN_ON_ONCE(1);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004437 return false;
4438}
4439
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004440static bool stacksafe(struct bpf_func_state *old,
4441 struct bpf_func_state *cur,
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004442 struct idpair *idmap)
4443{
4444 int i, spi;
4445
4446 /* if explored stack has more populated slots than current stack
4447 * such stacks are not equivalent
4448 */
4449 if (old->allocated_stack > cur->allocated_stack)
4450 return false;
4451
4452 /* walk slots of the explored stack and ignore any additional
4453 * slots in the current stack, since explored(safe) state
4454 * didn't use them
4455 */
4456 for (i = 0; i < old->allocated_stack; i++) {
4457 spi = i / BPF_REG_SIZE;
4458
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004459 if (!(old->stack[spi].spilled_ptr.live & REG_LIVE_READ))
4460 /* explored state didn't use this */
Gianluca Borellofd05e572017-12-23 10:09:55 +00004461 continue;
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004462
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004463 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
4464 continue;
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004465 /* if old state was safe with misc data in the stack
4466 * it will be safe with zero-initialized stack.
4467 * The opposite is not true
4468 */
4469 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_MISC &&
4470 cur->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_ZERO)
4471 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004472 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
4473 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
4474 /* Ex: old explored (safe) state has STACK_SPILL in
4475 * this stack slot, but current has has STACK_MISC ->
4476 * this verifier states are not equivalent,
4477 * return false to continue verification of this path
4478 */
4479 return false;
4480 if (i % BPF_REG_SIZE)
4481 continue;
4482 if (old->stack[spi].slot_type[0] != STACK_SPILL)
4483 continue;
4484 if (!regsafe(&old->stack[spi].spilled_ptr,
4485 &cur->stack[spi].spilled_ptr,
4486 idmap))
4487 /* when explored and current stack slot are both storing
4488 * spilled registers, check that stored pointers types
4489 * are the same as well.
4490 * Ex: explored safe path could have stored
4491 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
4492 * but current path has stored:
4493 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
4494 * such verifier states are not equivalent.
4495 * return false to continue verification of this path
4496 */
4497 return false;
4498 }
4499 return true;
4500}
4501
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004502/* compare two verifier states
4503 *
4504 * all states stored in state_list are known to be valid, since
4505 * verifier reached 'bpf_exit' instruction through them
4506 *
4507 * this function is called when verifier exploring different branches of
4508 * execution popped from the state stack. If it sees an old state that has
4509 * more strict register state and more strict stack state then this execution
4510 * branch doesn't need to be explored further, since verifier already
4511 * concluded that more strict state leads to valid finish.
4512 *
4513 * Therefore two states are equivalent if register state is more conservative
4514 * and explored stack state is more conservative than the current one.
4515 * Example:
4516 * explored current
4517 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
4518 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
4519 *
4520 * In other words if current stack state (one being explored) has more
4521 * valid slots than old one that already passed validation, it means
4522 * the verifier can stop exploring and conclude that current state is valid too
4523 *
4524 * Similarly with registers. If explored state has register type as invalid
4525 * whereas register type in current state is meaningful, it means that
4526 * the current state will reach 'bpf_exit' instruction safely
4527 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004528static bool func_states_equal(struct bpf_func_state *old,
4529 struct bpf_func_state *cur)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004530{
Edward Creef1174f72017-08-07 15:26:19 +01004531 struct idpair *idmap;
4532 bool ret = false;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004533 int i;
4534
Edward Creef1174f72017-08-07 15:26:19 +01004535 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
4536 /* If we failed to allocate the idmap, just say it's not safe */
4537 if (!idmap)
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07004538 return false;
Edward Creef1174f72017-08-07 15:26:19 +01004539
4540 for (i = 0; i < MAX_BPF_REG; i++) {
Edward Cree1b688a12017-08-23 15:10:50 +01004541 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
Edward Creef1174f72017-08-07 15:26:19 +01004542 goto out_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004543 }
4544
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004545 if (!stacksafe(old, cur, idmap))
4546 goto out_free;
Edward Creef1174f72017-08-07 15:26:19 +01004547 ret = true;
4548out_free:
4549 kfree(idmap);
4550 return ret;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004551}
4552
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004553static bool states_equal(struct bpf_verifier_env *env,
4554 struct bpf_verifier_state *old,
4555 struct bpf_verifier_state *cur)
Edward Creedc503a82017-08-15 20:34:35 +01004556{
Edward Creedc503a82017-08-15 20:34:35 +01004557 int i;
4558
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004559 if (old->curframe != cur->curframe)
4560 return false;
4561
4562 /* for states to be equal callsites have to be the same
4563 * and all frame states need to be equivalent
4564 */
4565 for (i = 0; i <= old->curframe; i++) {
4566 if (old->frame[i]->callsite != cur->frame[i]->callsite)
4567 return false;
4568 if (!func_states_equal(old->frame[i], cur->frame[i]))
4569 return false;
4570 }
4571 return true;
4572}
4573
4574/* A write screens off any subsequent reads; but write marks come from the
4575 * straight-line code between a state and its parent. When we arrive at an
4576 * equivalent state (jump target or such) we didn't arrive by the straight-line
4577 * code, so read marks in the state must propagate to the parent regardless
4578 * of the state's write marks. That's what 'parent == state->parent' comparison
4579 * in mark_reg_read() and mark_stack_slot_read() is for.
4580 */
4581static int propagate_liveness(struct bpf_verifier_env *env,
4582 const struct bpf_verifier_state *vstate,
4583 struct bpf_verifier_state *vparent)
4584{
4585 int i, frame, err = 0;
4586 struct bpf_func_state *state, *parent;
4587
4588 if (vparent->curframe != vstate->curframe) {
4589 WARN(1, "propagate_live: parent frame %d current frame %d\n",
4590 vparent->curframe, vstate->curframe);
4591 return -EFAULT;
4592 }
Edward Creedc503a82017-08-15 20:34:35 +01004593 /* Propagate read liveness of registers... */
4594 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
4595 /* We don't need to worry about FP liveness because it's read-only */
4596 for (i = 0; i < BPF_REG_FP; i++) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004597 if (vparent->frame[vparent->curframe]->regs[i].live & REG_LIVE_READ)
Edward Creedc503a82017-08-15 20:34:35 +01004598 continue;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004599 if (vstate->frame[vstate->curframe]->regs[i].live & REG_LIVE_READ) {
4600 err = mark_reg_read(env, vstate, vparent, i);
4601 if (err)
4602 return err;
Edward Creedc503a82017-08-15 20:34:35 +01004603 }
4604 }
Edward Creedc503a82017-08-15 20:34:35 +01004605
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004606 /* ... and stack slots */
4607 for (frame = 0; frame <= vstate->curframe; frame++) {
4608 state = vstate->frame[frame];
4609 parent = vparent->frame[frame];
4610 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
4611 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004612 if (parent->stack[i].spilled_ptr.live & REG_LIVE_READ)
4613 continue;
4614 if (state->stack[i].spilled_ptr.live & REG_LIVE_READ)
4615 mark_stack_slot_read(env, vstate, vparent, i, frame);
4616 }
Edward Creedc503a82017-08-15 20:34:35 +01004617 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004618 return err;
Edward Creedc503a82017-08-15 20:34:35 +01004619}
4620
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004621static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004622{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004623 struct bpf_verifier_state_list *new_sl;
4624 struct bpf_verifier_state_list *sl;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004625 struct bpf_verifier_state *cur = env->cur_state;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004626 int i, j, err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004627
4628 sl = env->explored_states[insn_idx];
4629 if (!sl)
4630 /* this 'insn_idx' instruction wasn't marked, so we will not
4631 * be doing state search here
4632 */
4633 return 0;
4634
4635 while (sl != STATE_LIST_MARK) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004636 if (states_equal(env, &sl->state, cur)) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004637 /* reached equivalent register/stack state,
Edward Creedc503a82017-08-15 20:34:35 +01004638 * prune the search.
4639 * Registers read by the continuation are read by us.
Edward Cree8e9cd9c2017-08-23 15:11:21 +01004640 * If we have any write marks in env->cur_state, they
4641 * will prevent corresponding reads in the continuation
4642 * from reaching our parent (an explored_state). Our
4643 * own state will get the read marks recorded, but
4644 * they'll be immediately forgotten as we're pruning
4645 * this state and will pop a new one.
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004646 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004647 err = propagate_liveness(env, &sl->state, cur);
4648 if (err)
4649 return err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004650 return 1;
Edward Creedc503a82017-08-15 20:34:35 +01004651 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004652 sl = sl->next;
4653 }
4654
4655 /* there were no equivalent states, remember current one.
4656 * technically the current state is not proven to be safe yet,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004657 * but it will either reach outer most bpf_exit (which means it's safe)
4658 * or it will be rejected. Since there are no loops, we won't be
4659 * seeing this tuple (frame[0].callsite, frame[1].callsite, .. insn_idx)
4660 * again on the way to bpf_exit
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004661 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004662 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004663 if (!new_sl)
4664 return -ENOMEM;
4665
4666 /* add new state to the head of linked list */
Alexei Starovoitov1969db42017-11-01 00:08:04 -07004667 err = copy_verifier_state(&new_sl->state, cur);
4668 if (err) {
4669 free_verifier_state(&new_sl->state, false);
4670 kfree(new_sl);
4671 return err;
4672 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004673 new_sl->next = env->explored_states[insn_idx];
4674 env->explored_states[insn_idx] = new_sl;
Edward Creedc503a82017-08-15 20:34:35 +01004675 /* connect new state to parentage chain */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004676 cur->parent = &new_sl->state;
Edward Cree8e9cd9c2017-08-23 15:11:21 +01004677 /* clear write marks in current state: the writes we did are not writes
4678 * our child did, so they don't screen off its reads from us.
4679 * (There are no read marks in current state, because reads always mark
4680 * their parent and current state never has children yet. Only
4681 * explored_states can get read marks.)
4682 */
Edward Creedc503a82017-08-15 20:34:35 +01004683 for (i = 0; i < BPF_REG_FP; i++)
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004684 cur->frame[cur->curframe]->regs[i].live = REG_LIVE_NONE;
4685
4686 /* all stack frames are accessible from callee, clear them all */
4687 for (j = 0; j <= cur->curframe; j++) {
4688 struct bpf_func_state *frame = cur->frame[j];
4689
4690 for (i = 0; i < frame->allocated_stack / BPF_REG_SIZE; i++)
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004691 frame->stack[i].spilled_ptr.live = REG_LIVE_NONE;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004692 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004693 return 0;
4694}
4695
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004696static int do_check(struct bpf_verifier_env *env)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004697{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004698 struct bpf_verifier_state *state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004699 struct bpf_insn *insns = env->prog->insnsi;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004700 struct bpf_reg_state *regs;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004701 int insn_cnt = env->prog->len, i;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004702 int insn_idx, prev_insn_idx = 0;
4703 int insn_processed = 0;
4704 bool do_print_state = false;
4705
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004706 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
4707 if (!state)
4708 return -ENOMEM;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004709 state->curframe = 0;
Edward Creedc503a82017-08-15 20:34:35 +01004710 state->parent = NULL;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004711 state->frame[0] = kzalloc(sizeof(struct bpf_func_state), GFP_KERNEL);
4712 if (!state->frame[0]) {
4713 kfree(state);
4714 return -ENOMEM;
4715 }
4716 env->cur_state = state;
4717 init_func_state(env, state->frame[0],
4718 BPF_MAIN_FUNC /* callsite */,
4719 0 /* frameno */,
4720 0 /* subprogno, zero == main subprog */);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004721 insn_idx = 0;
4722 for (;;) {
4723 struct bpf_insn *insn;
4724 u8 class;
4725 int err;
4726
4727 if (insn_idx >= insn_cnt) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004728 verbose(env, "invalid insn idx %d insn_cnt %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004729 insn_idx, insn_cnt);
4730 return -EFAULT;
4731 }
4732
4733 insn = &insns[insn_idx];
4734 class = BPF_CLASS(insn->code);
4735
Daniel Borkmann07016152016-04-05 22:33:17 +02004736 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004737 verbose(env,
4738 "BPF program is too large. Processed %d insn\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004739 insn_processed);
4740 return -E2BIG;
4741 }
4742
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004743 err = is_state_visited(env, insn_idx);
4744 if (err < 0)
4745 return err;
4746 if (err == 1) {
4747 /* found equivalent state, can prune the search */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004748 if (env->log.level) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004749 if (do_print_state)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004750 verbose(env, "\nfrom %d to %d: safe\n",
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004751 prev_insn_idx, insn_idx);
4752 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004753 verbose(env, "%d: safe\n", insn_idx);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004754 }
4755 goto process_bpf_exit;
4756 }
4757
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02004758 if (need_resched())
4759 cond_resched();
4760
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004761 if (env->log.level > 1 || (env->log.level && do_print_state)) {
4762 if (env->log.level > 1)
4763 verbose(env, "%d:", insn_idx);
David S. Millerc5fc9692017-05-10 11:25:17 -07004764 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004765 verbose(env, "\nfrom %d to %d:",
David S. Millerc5fc9692017-05-10 11:25:17 -07004766 prev_insn_idx, insn_idx);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004767 print_verifier_state(env, state->frame[state->curframe]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004768 do_print_state = false;
4769 }
4770
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004771 if (env->log.level) {
Daniel Borkmann7105e822017-12-20 13:42:57 +01004772 const struct bpf_insn_cbs cbs = {
4773 .cb_print = verbose,
Jiri Olsaabe08842018-03-23 11:41:28 +01004774 .private_data = env,
Daniel Borkmann7105e822017-12-20 13:42:57 +01004775 };
4776
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004777 verbose(env, "%d: ", insn_idx);
Jiri Olsaabe08842018-03-23 11:41:28 +01004778 print_bpf_insn(&cbs, insn, env->allow_ptr_leaks);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004779 }
4780
Jakub Kicinskicae19272017-12-27 18:39:05 -08004781 if (bpf_prog_is_dev_bound(env->prog->aux)) {
4782 err = bpf_prog_offload_verify_insn(env, insn_idx,
4783 prev_insn_idx);
4784 if (err)
4785 return err;
4786 }
Jakub Kicinski13a27df2016-09-21 11:43:58 +01004787
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004788 regs = cur_regs(env);
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004789 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004790 if (class == BPF_ALU || class == BPF_ALU64) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004791 err = check_alu_op(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004792 if (err)
4793 return err;
4794
4795 } else if (class == BPF_LDX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004796 enum bpf_reg_type *prev_src_type, src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004797
4798 /* check for reserved fields is already done */
4799
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004800 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01004801 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004802 if (err)
4803 return err;
4804
Edward Creedc503a82017-08-15 20:34:35 +01004805 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004806 if (err)
4807 return err;
4808
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07004809 src_reg_type = regs[insn->src_reg].type;
4810
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004811 /* check that memory (src_reg + off) is readable,
4812 * the state of dst_reg will be updated by this func
4813 */
Yonghong Song31fd8582017-06-13 15:52:13 -07004814 err = check_mem_access(env, insn_idx, insn->src_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004815 BPF_SIZE(insn->code), BPF_READ,
Daniel Borkmannca369602018-02-23 22:29:05 +01004816 insn->dst_reg, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004817 if (err)
4818 return err;
4819
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004820 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
4821
4822 if (*prev_src_type == NOT_INIT) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004823 /* saw a valid insn
4824 * dst_reg = *(u32 *)(src_reg + off)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004825 * save type to validate intersecting paths
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004826 */
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004827 *prev_src_type = src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004828
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004829 } else if (src_reg_type != *prev_src_type &&
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004830 (src_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004831 *prev_src_type == PTR_TO_CTX)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004832 /* ABuser program is trying to use the same insn
4833 * dst_reg = *(u32*) (src_reg + off)
4834 * with different pointer types:
4835 * src_reg == ctx in one branch and
4836 * src_reg == stack|map in some other branch.
4837 * Reject it.
4838 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004839 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004840 return -EINVAL;
4841 }
4842
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004843 } else if (class == BPF_STX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004844 enum bpf_reg_type *prev_dst_type, dst_reg_type;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004845
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004846 if (BPF_MODE(insn->code) == BPF_XADD) {
Yonghong Song31fd8582017-06-13 15:52:13 -07004847 err = check_xadd(env, insn_idx, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004848 if (err)
4849 return err;
4850 insn_idx++;
4851 continue;
4852 }
4853
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004854 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01004855 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004856 if (err)
4857 return err;
4858 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01004859 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004860 if (err)
4861 return err;
4862
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004863 dst_reg_type = regs[insn->dst_reg].type;
4864
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004865 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07004866 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004867 BPF_SIZE(insn->code), BPF_WRITE,
Daniel Borkmannca369602018-02-23 22:29:05 +01004868 insn->src_reg, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004869 if (err)
4870 return err;
4871
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004872 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
4873
4874 if (*prev_dst_type == NOT_INIT) {
4875 *prev_dst_type = dst_reg_type;
4876 } else if (dst_reg_type != *prev_dst_type &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004877 (dst_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004878 *prev_dst_type == PTR_TO_CTX)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004879 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004880 return -EINVAL;
4881 }
4882
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004883 } else if (class == BPF_ST) {
4884 if (BPF_MODE(insn->code) != BPF_MEM ||
4885 insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004886 verbose(env, "BPF_ST uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004887 return -EINVAL;
4888 }
4889 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01004890 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004891 if (err)
4892 return err;
4893
Daniel Borkmannf37a8cb2018-01-16 23:30:10 +01004894 if (is_ctx_reg(env, insn->dst_reg)) {
4895 verbose(env, "BPF_ST stores into R%d context is not allowed\n",
4896 insn->dst_reg);
4897 return -EACCES;
4898 }
4899
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004900 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07004901 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004902 BPF_SIZE(insn->code), BPF_WRITE,
Daniel Borkmannca369602018-02-23 22:29:05 +01004903 -1, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004904 if (err)
4905 return err;
4906
4907 } else if (class == BPF_JMP) {
4908 u8 opcode = BPF_OP(insn->code);
4909
4910 if (opcode == BPF_CALL) {
4911 if (BPF_SRC(insn->code) != BPF_K ||
4912 insn->off != 0 ||
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004913 (insn->src_reg != BPF_REG_0 &&
4914 insn->src_reg != BPF_PSEUDO_CALL) ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004915 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004916 verbose(env, "BPF_CALL uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004917 return -EINVAL;
4918 }
4919
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004920 if (insn->src_reg == BPF_PSEUDO_CALL)
4921 err = check_func_call(env, insn, &insn_idx);
4922 else
4923 err = check_helper_call(env, insn->imm, insn_idx);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004924 if (err)
4925 return err;
4926
4927 } else if (opcode == BPF_JA) {
4928 if (BPF_SRC(insn->code) != BPF_K ||
4929 insn->imm != 0 ||
4930 insn->src_reg != BPF_REG_0 ||
4931 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004932 verbose(env, "BPF_JA uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004933 return -EINVAL;
4934 }
4935
4936 insn_idx += insn->off + 1;
4937 continue;
4938
4939 } else if (opcode == BPF_EXIT) {
4940 if (BPF_SRC(insn->code) != BPF_K ||
4941 insn->imm != 0 ||
4942 insn->src_reg != BPF_REG_0 ||
4943 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004944 verbose(env, "BPF_EXIT uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004945 return -EINVAL;
4946 }
4947
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004948 if (state->curframe) {
4949 /* exit from nested function */
4950 prev_insn_idx = insn_idx;
4951 err = prepare_func_exit(env, &insn_idx);
4952 if (err)
4953 return err;
4954 do_print_state = true;
4955 continue;
4956 }
4957
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004958 /* eBPF calling convetion is such that R0 is used
4959 * to return the value from eBPF program.
4960 * Make sure that it's readable at this time
4961 * of bpf_exit, which means that program wrote
4962 * something into it earlier
4963 */
Edward Creedc503a82017-08-15 20:34:35 +01004964 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004965 if (err)
4966 return err;
4967
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004968 if (is_pointer_value(env, BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004969 verbose(env, "R0 leaks addr as return value\n");
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004970 return -EACCES;
4971 }
4972
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004973 err = check_return_code(env);
4974 if (err)
4975 return err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004976process_bpf_exit:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004977 err = pop_stack(env, &prev_insn_idx, &insn_idx);
4978 if (err < 0) {
4979 if (err != -ENOENT)
4980 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004981 break;
4982 } else {
4983 do_print_state = true;
4984 continue;
4985 }
4986 } else {
4987 err = check_cond_jmp_op(env, insn, &insn_idx);
4988 if (err)
4989 return err;
4990 }
4991 } else if (class == BPF_LD) {
4992 u8 mode = BPF_MODE(insn->code);
4993
4994 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004995 err = check_ld_abs(env, insn);
4996 if (err)
4997 return err;
4998
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004999 } else if (mode == BPF_IMM) {
5000 err = check_ld_imm(env, insn);
5001 if (err)
5002 return err;
5003
5004 insn_idx++;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005005 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07005006 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005007 verbose(env, "invalid BPF_LD mode\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07005008 return -EINVAL;
5009 }
5010 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005011 verbose(env, "unknown insn class %d\n", class);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07005012 return -EINVAL;
5013 }
5014
5015 insn_idx++;
5016 }
5017
Daniel Borkmann4bd95f42018-01-20 01:24:36 +01005018 verbose(env, "processed %d insns (limit %d), stack depth ",
5019 insn_processed, BPF_COMPLEXITY_LIMIT_INSNS);
Jiong Wangf910cef2018-05-02 16:17:17 -04005020 for (i = 0; i < env->subprog_cnt; i++) {
Jiong Wang9c8105b2018-05-02 16:17:18 -04005021 u32 depth = env->subprog_info[i].stack_depth;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08005022
5023 verbose(env, "%d", depth);
Jiong Wangf910cef2018-05-02 16:17:17 -04005024 if (i + 1 < env->subprog_cnt)
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08005025 verbose(env, "+");
5026 }
5027 verbose(env, "\n");
Jiong Wang9c8105b2018-05-02 16:17:18 -04005028 env->prog->aux->stack_depth = env->subprog_info[0].stack_depth;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07005029 return 0;
5030}
5031
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07005032static int check_map_prealloc(struct bpf_map *map)
5033{
5034 return (map->map_type != BPF_MAP_TYPE_HASH &&
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07005035 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
5036 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07005037 !(map->map_flags & BPF_F_NO_PREALLOC);
5038}
5039
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005040static int check_map_prog_compatibility(struct bpf_verifier_env *env,
5041 struct bpf_map *map,
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07005042 struct bpf_prog *prog)
5043
5044{
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07005045 /* Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use
5046 * preallocated hash maps, since doing memory allocation
5047 * in overflow_handler can crash depending on where nmi got
5048 * triggered.
5049 */
5050 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
5051 if (!check_map_prealloc(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005052 verbose(env, "perf_event programs can only use preallocated hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07005053 return -EINVAL;
5054 }
5055 if (map->inner_map_meta &&
5056 !check_map_prealloc(map->inner_map_meta)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005057 verbose(env, "perf_event programs can only use preallocated inner hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07005058 return -EINVAL;
5059 }
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07005060 }
Jakub Kicinskia3884572018-01-11 20:29:09 -08005061
5062 if ((bpf_prog_is_dev_bound(prog->aux) || bpf_map_is_dev_bound(map)) &&
Jakub Kicinski09728262018-07-17 10:53:23 -07005063 !bpf_offload_prog_map_match(prog, map)) {
Jakub Kicinskia3884572018-01-11 20:29:09 -08005064 verbose(env, "offload device mismatch between prog and map\n");
5065 return -EINVAL;
5066 }
5067
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07005068 return 0;
5069}
5070
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005071/* look for pseudo eBPF instructions that access map FDs and
5072 * replace them with actual map pointers
5073 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005074static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005075{
5076 struct bpf_insn *insn = env->prog->insnsi;
5077 int insn_cnt = env->prog->len;
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07005078 int i, j, err;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005079
Daniel Borkmannf1f77142017-01-13 23:38:15 +01005080 err = bpf_prog_calc_tag(env->prog);
Daniel Borkmannaafe6ae2016-12-18 01:52:57 +01005081 if (err)
5082 return err;
5083
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005084 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005085 if (BPF_CLASS(insn->code) == BPF_LDX &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005086 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005087 verbose(env, "BPF_LDX uses reserved fields\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005088 return -EINVAL;
5089 }
5090
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005091 if (BPF_CLASS(insn->code) == BPF_STX &&
5092 ((BPF_MODE(insn->code) != BPF_MEM &&
5093 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005094 verbose(env, "BPF_STX uses reserved fields\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005095 return -EINVAL;
5096 }
5097
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005098 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
5099 struct bpf_map *map;
5100 struct fd f;
5101
5102 if (i == insn_cnt - 1 || insn[1].code != 0 ||
5103 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
5104 insn[1].off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005105 verbose(env, "invalid bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005106 return -EINVAL;
5107 }
5108
5109 if (insn->src_reg == 0)
5110 /* valid generic load 64-bit imm */
5111 goto next_insn;
5112
5113 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005114 verbose(env,
5115 "unrecognized bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005116 return -EINVAL;
5117 }
5118
5119 f = fdget(insn->imm);
Daniel Borkmannc2101292015-10-29 14:58:07 +01005120 map = __bpf_map_get(f);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005121 if (IS_ERR(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005122 verbose(env, "fd %d is not pointing to valid bpf_map\n",
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005123 insn->imm);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005124 return PTR_ERR(map);
5125 }
5126
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005127 err = check_map_prog_compatibility(env, map, env->prog);
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07005128 if (err) {
5129 fdput(f);
5130 return err;
5131 }
5132
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005133 /* store map pointer inside BPF_LD_IMM64 instruction */
5134 insn[0].imm = (u32) (unsigned long) map;
5135 insn[1].imm = ((u64) (unsigned long) map) >> 32;
5136
5137 /* check whether we recorded this map already */
5138 for (j = 0; j < env->used_map_cnt; j++)
5139 if (env->used_maps[j] == map) {
5140 fdput(f);
5141 goto next_insn;
5142 }
5143
5144 if (env->used_map_cnt >= MAX_USED_MAPS) {
5145 fdput(f);
5146 return -E2BIG;
5147 }
5148
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005149 /* hold the map. If the program is rejected by verifier,
5150 * the map will be released by release_maps() or it
5151 * will be used by the valid program until it's unloaded
Jakub Kicinskiab7f5bf2018-05-03 18:37:17 -07005152 * and all maps are released in free_used_maps()
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005153 */
Alexei Starovoitov92117d82016-04-27 18:56:20 -07005154 map = bpf_map_inc(map, false);
5155 if (IS_ERR(map)) {
5156 fdput(f);
5157 return PTR_ERR(map);
5158 }
5159 env->used_maps[env->used_map_cnt++] = map;
5160
Roman Gushchinde9cbba2018-08-02 14:27:18 -07005161 if (map->map_type == BPF_MAP_TYPE_CGROUP_STORAGE &&
5162 bpf_cgroup_storage_assign(env->prog, map)) {
5163 verbose(env,
5164 "only one cgroup storage is allowed\n");
5165 fdput(f);
5166 return -EBUSY;
5167 }
5168
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005169 fdput(f);
5170next_insn:
5171 insn++;
5172 i++;
Daniel Borkmann5e581da2018-01-26 23:33:38 +01005173 continue;
5174 }
5175
5176 /* Basic sanity check before we invest more work here. */
5177 if (!bpf_opcode_in_insntable(insn->code)) {
5178 verbose(env, "unknown opcode %02x\n", insn->code);
5179 return -EINVAL;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005180 }
5181 }
5182
5183 /* now all pseudo BPF_LD_IMM64 instructions load valid
5184 * 'struct bpf_map *' into a register instead of user map_fd.
5185 * These pointers will be used later by verifier to validate map access.
5186 */
5187 return 0;
5188}
5189
5190/* drop refcnt of maps used by the rejected program */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005191static void release_maps(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005192{
5193 int i;
5194
Roman Gushchinde9cbba2018-08-02 14:27:18 -07005195 if (env->prog->aux->cgroup_storage)
5196 bpf_cgroup_storage_release(env->prog,
5197 env->prog->aux->cgroup_storage);
5198
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005199 for (i = 0; i < env->used_map_cnt; i++)
5200 bpf_map_put(env->used_maps[i]);
5201}
5202
5203/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005204static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005205{
5206 struct bpf_insn *insn = env->prog->insnsi;
5207 int insn_cnt = env->prog->len;
5208 int i;
5209
5210 for (i = 0; i < insn_cnt; i++, insn++)
5211 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
5212 insn->src_reg = 0;
5213}
5214
Alexei Starovoitov80419022017-03-15 18:26:41 -07005215/* single env->prog->insni[off] instruction was replaced with the range
5216 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
5217 * [0, off) and [off, end) to new locations, so the patched range stays zero
5218 */
5219static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
5220 u32 off, u32 cnt)
5221{
5222 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005223 int i;
Alexei Starovoitov80419022017-03-15 18:26:41 -07005224
5225 if (cnt == 1)
5226 return 0;
Kees Cookfad953c2018-06-12 14:27:37 -07005227 new_data = vzalloc(array_size(prog_len,
5228 sizeof(struct bpf_insn_aux_data)));
Alexei Starovoitov80419022017-03-15 18:26:41 -07005229 if (!new_data)
5230 return -ENOMEM;
5231 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
5232 memcpy(new_data + off + cnt - 1, old_data + off,
5233 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005234 for (i = off; i < off + cnt - 1; i++)
5235 new_data[i].seen = true;
Alexei Starovoitov80419022017-03-15 18:26:41 -07005236 env->insn_aux_data = new_data;
5237 vfree(old_data);
5238 return 0;
5239}
5240
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005241static void adjust_subprog_starts(struct bpf_verifier_env *env, u32 off, u32 len)
5242{
5243 int i;
5244
5245 if (len == 1)
5246 return;
Jiong Wang4cb3d992018-05-02 16:17:19 -04005247 /* NOTE: fake 'exit' subprog should be updated as well. */
5248 for (i = 0; i <= env->subprog_cnt; i++) {
Jiong Wang9c8105b2018-05-02 16:17:18 -04005249 if (env->subprog_info[i].start < off)
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005250 continue;
Jiong Wang9c8105b2018-05-02 16:17:18 -04005251 env->subprog_info[i].start += len - 1;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005252 }
5253}
5254
Alexei Starovoitov80419022017-03-15 18:26:41 -07005255static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
5256 const struct bpf_insn *patch, u32 len)
5257{
5258 struct bpf_prog *new_prog;
5259
5260 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
5261 if (!new_prog)
5262 return NULL;
5263 if (adjust_insn_aux_data(env, new_prog->len, off, len))
5264 return NULL;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005265 adjust_subprog_starts(env, off, len);
Alexei Starovoitov80419022017-03-15 18:26:41 -07005266 return new_prog;
5267}
5268
Daniel Borkmann2a5418a2018-01-26 23:33:37 +01005269/* The verifier does more data flow analysis than llvm and will not
5270 * explore branches that are dead at run time. Malicious programs can
5271 * have dead code too. Therefore replace all dead at-run-time code
5272 * with 'ja -1'.
5273 *
5274 * Just nops are not optimal, e.g. if they would sit at the end of the
5275 * program and through another bug we would manage to jump there, then
5276 * we'd execute beyond program memory otherwise. Returning exception
5277 * code also wouldn't work since we can have subprogs where the dead
5278 * code could be located.
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005279 */
5280static void sanitize_dead_code(struct bpf_verifier_env *env)
5281{
5282 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
Daniel Borkmann2a5418a2018-01-26 23:33:37 +01005283 struct bpf_insn trap = BPF_JMP_IMM(BPF_JA, 0, 0, -1);
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005284 struct bpf_insn *insn = env->prog->insnsi;
5285 const int insn_cnt = env->prog->len;
5286 int i;
5287
5288 for (i = 0; i < insn_cnt; i++) {
5289 if (aux_data[i].seen)
5290 continue;
Daniel Borkmann2a5418a2018-01-26 23:33:37 +01005291 memcpy(insn + i, &trap, sizeof(trap));
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005292 }
5293}
5294
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005295/* convert load instructions that access fields of 'struct __sk_buff'
5296 * into sequence of instructions that access fields of 'struct sk_buff'
5297 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005298static int convert_ctx_accesses(struct bpf_verifier_env *env)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005299{
Jakub Kicinski00176a32017-10-16 16:40:54 -07005300 const struct bpf_verifier_ops *ops = env->ops;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005301 int i, cnt, size, ctx_field_size, delta = 0;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005302 const int insn_cnt = env->prog->len;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005303 struct bpf_insn insn_buf[16], *insn;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005304 struct bpf_prog *new_prog;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005305 enum bpf_access_type type;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005306 bool is_narrower_load;
5307 u32 target_size;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005308
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005309 if (ops->gen_prologue) {
5310 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
5311 env->prog);
5312 if (cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005313 verbose(env, "bpf verifier is misconfigured\n");
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005314 return -EINVAL;
5315 } else if (cnt) {
Alexei Starovoitov80419022017-03-15 18:26:41 -07005316 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005317 if (!new_prog)
5318 return -ENOMEM;
Alexei Starovoitov80419022017-03-15 18:26:41 -07005319
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005320 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005321 delta += cnt - 1;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005322 }
5323 }
5324
Jakub Kicinski0d830032018-05-08 19:37:06 -07005325 if (!ops->convert_ctx_access || bpf_prog_is_dev_bound(env->prog->aux))
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005326 return 0;
5327
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005328 insn = env->prog->insnsi + delta;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005329
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005330 for (i = 0; i < insn_cnt; i++, insn++) {
Daniel Borkmann62c79892017-01-12 11:51:33 +01005331 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
5332 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
5333 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07005334 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005335 type = BPF_READ;
Daniel Borkmann62c79892017-01-12 11:51:33 +01005336 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
5337 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
5338 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07005339 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005340 type = BPF_WRITE;
5341 else
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005342 continue;
5343
Alexei Starovoitovaf86ca42018-05-15 09:27:05 -07005344 if (type == BPF_WRITE &&
5345 env->insn_aux_data[i + delta].sanitize_stack_off) {
5346 struct bpf_insn patch[] = {
5347 /* Sanitize suspicious stack slot with zero.
5348 * There are no memory dependencies for this store,
5349 * since it's only using frame pointer and immediate
5350 * constant of zero
5351 */
5352 BPF_ST_MEM(BPF_DW, BPF_REG_FP,
5353 env->insn_aux_data[i + delta].sanitize_stack_off,
5354 0),
5355 /* the original STX instruction will immediately
5356 * overwrite the same stack slot with appropriate value
5357 */
5358 *insn,
5359 };
5360
5361 cnt = ARRAY_SIZE(patch);
5362 new_prog = bpf_patch_insn_data(env, i + delta, patch, cnt);
5363 if (!new_prog)
5364 return -ENOMEM;
5365
5366 delta += cnt - 1;
5367 env->prog = new_prog;
5368 insn = new_prog->insnsi + i + delta;
5369 continue;
5370 }
5371
Alexei Starovoitov80419022017-03-15 18:26:41 -07005372 if (env->insn_aux_data[i + delta].ptr_type != PTR_TO_CTX)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005373 continue;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005374
Yonghong Song31fd8582017-06-13 15:52:13 -07005375 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005376 size = BPF_LDST_BYTES(insn);
Yonghong Song31fd8582017-06-13 15:52:13 -07005377
5378 /* If the read access is a narrower load of the field,
5379 * convert to a 4/8-byte load, to minimum program type specific
5380 * convert_ctx_access changes. If conversion is successful,
5381 * we will apply proper mask to the result.
5382 */
Daniel Borkmannf96da092017-07-02 02:13:27 +02005383 is_narrower_load = size < ctx_field_size;
Yonghong Song31fd8582017-06-13 15:52:13 -07005384 if (is_narrower_load) {
Daniel Borkmannbc231052018-06-02 23:06:39 +02005385 u32 size_default = bpf_ctx_off_adjust_machine(ctx_field_size);
Daniel Borkmannf96da092017-07-02 02:13:27 +02005386 u32 off = insn->off;
5387 u8 size_code;
Yonghong Song31fd8582017-06-13 15:52:13 -07005388
Daniel Borkmannf96da092017-07-02 02:13:27 +02005389 if (type == BPF_WRITE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005390 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
Daniel Borkmannf96da092017-07-02 02:13:27 +02005391 return -EINVAL;
5392 }
5393
5394 size_code = BPF_H;
Yonghong Song31fd8582017-06-13 15:52:13 -07005395 if (ctx_field_size == 4)
5396 size_code = BPF_W;
5397 else if (ctx_field_size == 8)
5398 size_code = BPF_DW;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005399
Daniel Borkmannbc231052018-06-02 23:06:39 +02005400 insn->off = off & ~(size_default - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07005401 insn->code = BPF_LDX | BPF_MEM | size_code;
5402 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02005403
5404 target_size = 0;
5405 cnt = ops->convert_ctx_access(type, insn, insn_buf, env->prog,
5406 &target_size);
5407 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
5408 (ctx_field_size && !target_size)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005409 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005410 return -EINVAL;
5411 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02005412
5413 if (is_narrower_load && size < target_size) {
Yonghong Song31fd8582017-06-13 15:52:13 -07005414 if (ctx_field_size <= 4)
5415 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02005416 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07005417 else
5418 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02005419 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07005420 }
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005421
Alexei Starovoitov80419022017-03-15 18:26:41 -07005422 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005423 if (!new_prog)
5424 return -ENOMEM;
5425
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005426 delta += cnt - 1;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005427
5428 /* keep walking new program and skip insns we just inserted */
5429 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005430 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005431 }
5432
5433 return 0;
5434}
5435
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005436static int jit_subprogs(struct bpf_verifier_env *env)
5437{
5438 struct bpf_prog *prog = env->prog, **func, *tmp;
5439 int i, j, subprog_start, subprog_end = 0, len, subprog;
Daniel Borkmann7105e822017-12-20 13:42:57 +01005440 struct bpf_insn *insn;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005441 void *old_bpf_func;
5442 int err = -ENOMEM;
5443
Jiong Wangf910cef2018-05-02 16:17:17 -04005444 if (env->subprog_cnt <= 1)
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005445 return 0;
5446
Daniel Borkmann7105e822017-12-20 13:42:57 +01005447 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005448 if (insn->code != (BPF_JMP | BPF_CALL) ||
5449 insn->src_reg != BPF_PSEUDO_CALL)
5450 continue;
Daniel Borkmannc7a89782018-07-12 21:44:28 +02005451 /* Upon error here we cannot fall back to interpreter but
5452 * need a hard reject of the program. Thus -EFAULT is
5453 * propagated in any case.
5454 */
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005455 subprog = find_subprog(env, i + insn->imm + 1);
5456 if (subprog < 0) {
5457 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
5458 i + insn->imm + 1);
5459 return -EFAULT;
5460 }
5461 /* temporarily remember subprog id inside insn instead of
5462 * aux_data, since next loop will split up all insns into funcs
5463 */
Jiong Wangf910cef2018-05-02 16:17:17 -04005464 insn->off = subprog;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005465 /* remember original imm in case JIT fails and fallback
5466 * to interpreter will be needed
5467 */
5468 env->insn_aux_data[i].call_imm = insn->imm;
5469 /* point imm to __bpf_call_base+1 from JITs point of view */
5470 insn->imm = 1;
5471 }
5472
Kees Cook6396bb22018-06-12 14:03:40 -07005473 func = kcalloc(env->subprog_cnt, sizeof(prog), GFP_KERNEL);
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005474 if (!func)
Daniel Borkmannc7a89782018-07-12 21:44:28 +02005475 goto out_undo_insn;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005476
Jiong Wangf910cef2018-05-02 16:17:17 -04005477 for (i = 0; i < env->subprog_cnt; i++) {
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005478 subprog_start = subprog_end;
Jiong Wang4cb3d992018-05-02 16:17:19 -04005479 subprog_end = env->subprog_info[i + 1].start;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005480
5481 len = subprog_end - subprog_start;
5482 func[i] = bpf_prog_alloc(bpf_prog_size(len), GFP_USER);
5483 if (!func[i])
5484 goto out_free;
5485 memcpy(func[i]->insnsi, &prog->insnsi[subprog_start],
5486 len * sizeof(struct bpf_insn));
Daniel Borkmann4f74d802017-12-20 13:42:56 +01005487 func[i]->type = prog->type;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005488 func[i]->len = len;
Daniel Borkmann4f74d802017-12-20 13:42:56 +01005489 if (bpf_prog_calc_tag(func[i]))
5490 goto out_free;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005491 func[i]->is_func = 1;
5492 /* Use bpf_prog_F_tag to indicate functions in stack traces.
5493 * Long term would need debug info to populate names
5494 */
5495 func[i]->aux->name[0] = 'F';
Jiong Wang9c8105b2018-05-02 16:17:18 -04005496 func[i]->aux->stack_depth = env->subprog_info[i].stack_depth;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005497 func[i]->jit_requested = 1;
5498 func[i] = bpf_int_jit_compile(func[i]);
5499 if (!func[i]->jited) {
5500 err = -ENOTSUPP;
5501 goto out_free;
5502 }
5503 cond_resched();
5504 }
5505 /* at this point all bpf functions were successfully JITed
5506 * now populate all bpf_calls with correct addresses and
5507 * run last pass of JIT
5508 */
Jiong Wangf910cef2018-05-02 16:17:17 -04005509 for (i = 0; i < env->subprog_cnt; i++) {
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005510 insn = func[i]->insnsi;
5511 for (j = 0; j < func[i]->len; j++, insn++) {
5512 if (insn->code != (BPF_JMP | BPF_CALL) ||
5513 insn->src_reg != BPF_PSEUDO_CALL)
5514 continue;
5515 subprog = insn->off;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005516 insn->imm = (u64 (*)(u64, u64, u64, u64, u64))
5517 func[subprog]->bpf_func -
5518 __bpf_call_base;
5519 }
Sandipan Das2162fed2018-05-24 12:26:45 +05305520
5521 /* we use the aux data to keep a list of the start addresses
5522 * of the JITed images for each function in the program
5523 *
5524 * for some architectures, such as powerpc64, the imm field
5525 * might not be large enough to hold the offset of the start
5526 * address of the callee's JITed image from __bpf_call_base
5527 *
5528 * in such cases, we can lookup the start address of a callee
5529 * by using its subprog id, available from the off field of
5530 * the call instruction, as an index for this list
5531 */
5532 func[i]->aux->func = func;
5533 func[i]->aux->func_cnt = env->subprog_cnt;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005534 }
Jiong Wangf910cef2018-05-02 16:17:17 -04005535 for (i = 0; i < env->subprog_cnt; i++) {
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005536 old_bpf_func = func[i]->bpf_func;
5537 tmp = bpf_int_jit_compile(func[i]);
5538 if (tmp != func[i] || func[i]->bpf_func != old_bpf_func) {
5539 verbose(env, "JIT doesn't support bpf-to-bpf calls\n");
Daniel Borkmannc7a89782018-07-12 21:44:28 +02005540 err = -ENOTSUPP;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005541 goto out_free;
5542 }
5543 cond_resched();
5544 }
5545
5546 /* finally lock prog and jit images for all functions and
5547 * populate kallsysm
5548 */
Jiong Wangf910cef2018-05-02 16:17:17 -04005549 for (i = 0; i < env->subprog_cnt; i++) {
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005550 bpf_prog_lock_ro(func[i]);
5551 bpf_prog_kallsyms_add(func[i]);
5552 }
Daniel Borkmann7105e822017-12-20 13:42:57 +01005553
5554 /* Last step: make now unused interpreter insns from main
5555 * prog consistent for later dump requests, so they can
5556 * later look the same as if they were interpreted only.
5557 */
5558 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
Daniel Borkmann7105e822017-12-20 13:42:57 +01005559 if (insn->code != (BPF_JMP | BPF_CALL) ||
5560 insn->src_reg != BPF_PSEUDO_CALL)
5561 continue;
5562 insn->off = env->insn_aux_data[i].call_imm;
5563 subprog = find_subprog(env, i + insn->off + 1);
Sandipan Dasdbecd732018-05-24 12:26:48 +05305564 insn->imm = subprog;
Daniel Borkmann7105e822017-12-20 13:42:57 +01005565 }
5566
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005567 prog->jited = 1;
5568 prog->bpf_func = func[0]->bpf_func;
5569 prog->aux->func = func;
Jiong Wangf910cef2018-05-02 16:17:17 -04005570 prog->aux->func_cnt = env->subprog_cnt;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005571 return 0;
5572out_free:
Jiong Wangf910cef2018-05-02 16:17:17 -04005573 for (i = 0; i < env->subprog_cnt; i++)
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005574 if (func[i])
5575 bpf_jit_free(func[i]);
5576 kfree(func);
Daniel Borkmannc7a89782018-07-12 21:44:28 +02005577out_undo_insn:
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005578 /* cleanup main prog to be interpreted */
5579 prog->jit_requested = 0;
5580 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
5581 if (insn->code != (BPF_JMP | BPF_CALL) ||
5582 insn->src_reg != BPF_PSEUDO_CALL)
5583 continue;
5584 insn->off = 0;
5585 insn->imm = env->insn_aux_data[i].call_imm;
5586 }
5587 return err;
5588}
5589
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005590static int fixup_call_args(struct bpf_verifier_env *env)
5591{
David S. Miller19d28fb2018-01-11 21:27:54 -05005592#ifndef CONFIG_BPF_JIT_ALWAYS_ON
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005593 struct bpf_prog *prog = env->prog;
5594 struct bpf_insn *insn = prog->insnsi;
5595 int i, depth;
David S. Miller19d28fb2018-01-11 21:27:54 -05005596#endif
5597 int err;
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005598
David S. Miller19d28fb2018-01-11 21:27:54 -05005599 err = 0;
5600 if (env->prog->jit_requested) {
5601 err = jit_subprogs(env);
5602 if (err == 0)
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005603 return 0;
Daniel Borkmannc7a89782018-07-12 21:44:28 +02005604 if (err == -EFAULT)
5605 return err;
David S. Miller19d28fb2018-01-11 21:27:54 -05005606 }
5607#ifndef CONFIG_BPF_JIT_ALWAYS_ON
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005608 for (i = 0; i < prog->len; i++, insn++) {
5609 if (insn->code != (BPF_JMP | BPF_CALL) ||
5610 insn->src_reg != BPF_PSEUDO_CALL)
5611 continue;
5612 depth = get_callee_stack_depth(env, insn, i);
5613 if (depth < 0)
5614 return depth;
5615 bpf_patch_call_args(insn, depth);
5616 }
David S. Miller19d28fb2018-01-11 21:27:54 -05005617 err = 0;
5618#endif
5619 return err;
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005620}
5621
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005622/* fixup insn->imm field of bpf_call instructions
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005623 * and inline eligible helpers as explicit sequence of BPF instructions
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005624 *
5625 * this function is called after eBPF program passed verification
5626 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005627static int fixup_bpf_calls(struct bpf_verifier_env *env)
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005628{
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005629 struct bpf_prog *prog = env->prog;
5630 struct bpf_insn *insn = prog->insnsi;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005631 const struct bpf_func_proto *fn;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005632 const int insn_cnt = prog->len;
Daniel Borkmann09772d92018-06-02 23:06:35 +02005633 const struct bpf_map_ops *ops;
Daniel Borkmannc93552c2018-05-24 02:32:53 +02005634 struct bpf_insn_aux_data *aux;
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005635 struct bpf_insn insn_buf[16];
5636 struct bpf_prog *new_prog;
5637 struct bpf_map *map_ptr;
5638 int i, cnt, delta = 0;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005639
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005640 for (i = 0; i < insn_cnt; i++, insn++) {
Daniel Borkmannf6b1b3b2018-01-26 23:33:39 +01005641 if (insn->code == (BPF_ALU64 | BPF_MOD | BPF_X) ||
5642 insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
5643 insn->code == (BPF_ALU | BPF_MOD | BPF_X) ||
Alexei Starovoitov68fda452018-01-12 18:59:52 -08005644 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
Daniel Borkmannf6b1b3b2018-01-26 23:33:39 +01005645 bool is64 = BPF_CLASS(insn->code) == BPF_ALU64;
5646 struct bpf_insn mask_and_div[] = {
5647 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
5648 /* Rx div 0 -> 0 */
5649 BPF_JMP_IMM(BPF_JNE, insn->src_reg, 0, 2),
5650 BPF_ALU32_REG(BPF_XOR, insn->dst_reg, insn->dst_reg),
5651 BPF_JMP_IMM(BPF_JA, 0, 0, 1),
5652 *insn,
5653 };
5654 struct bpf_insn mask_and_mod[] = {
5655 BPF_MOV32_REG(insn->src_reg, insn->src_reg),
5656 /* Rx mod 0 -> Rx */
5657 BPF_JMP_IMM(BPF_JEQ, insn->src_reg, 0, 1),
5658 *insn,
5659 };
5660 struct bpf_insn *patchlet;
5661
5662 if (insn->code == (BPF_ALU64 | BPF_DIV | BPF_X) ||
5663 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
5664 patchlet = mask_and_div + (is64 ? 1 : 0);
5665 cnt = ARRAY_SIZE(mask_and_div) - (is64 ? 1 : 0);
5666 } else {
5667 patchlet = mask_and_mod + (is64 ? 1 : 0);
5668 cnt = ARRAY_SIZE(mask_and_mod) - (is64 ? 1 : 0);
5669 }
5670
5671 new_prog = bpf_patch_insn_data(env, i + delta, patchlet, cnt);
Alexei Starovoitov68fda452018-01-12 18:59:52 -08005672 if (!new_prog)
5673 return -ENOMEM;
5674
5675 delta += cnt - 1;
5676 env->prog = prog = new_prog;
5677 insn = new_prog->insnsi + i + delta;
5678 continue;
5679 }
5680
Daniel Borkmanne0cea7c2018-05-04 01:08:14 +02005681 if (BPF_CLASS(insn->code) == BPF_LD &&
5682 (BPF_MODE(insn->code) == BPF_ABS ||
5683 BPF_MODE(insn->code) == BPF_IND)) {
5684 cnt = env->ops->gen_ld_abs(insn, insn_buf);
5685 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
5686 verbose(env, "bpf verifier is misconfigured\n");
5687 return -EINVAL;
5688 }
5689
5690 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
5691 if (!new_prog)
5692 return -ENOMEM;
5693
5694 delta += cnt - 1;
5695 env->prog = prog = new_prog;
5696 insn = new_prog->insnsi + i + delta;
5697 continue;
5698 }
5699
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005700 if (insn->code != (BPF_JMP | BPF_CALL))
5701 continue;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005702 if (insn->src_reg == BPF_PSEUDO_CALL)
5703 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005704
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005705 if (insn->imm == BPF_FUNC_get_route_realm)
5706 prog->dst_needed = 1;
5707 if (insn->imm == BPF_FUNC_get_prandom_u32)
5708 bpf_user_rnd_init_once();
Josef Bacik9802d862017-12-11 11:36:48 -05005709 if (insn->imm == BPF_FUNC_override_return)
5710 prog->kprobe_override = 1;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005711 if (insn->imm == BPF_FUNC_tail_call) {
David S. Miller7b9f6da2017-04-20 10:35:33 -04005712 /* If we tail call into other programs, we
5713 * cannot make any assumptions since they can
5714 * be replaced dynamically during runtime in
5715 * the program array.
5716 */
5717 prog->cb_access = 1;
Alexei Starovoitov80a58d02017-05-30 13:31:30 -07005718 env->prog->aux->stack_depth = MAX_BPF_STACK;
David S. Miller7b9f6da2017-04-20 10:35:33 -04005719
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005720 /* mark bpf_tail_call as different opcode to avoid
5721 * conditional branch in the interpeter for every normal
5722 * call and to prevent accidental JITing by JIT compiler
5723 * that doesn't support bpf_tail_call yet
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005724 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005725 insn->imm = 0;
Alexei Starovoitov71189fa2017-05-30 13:31:27 -07005726 insn->code = BPF_JMP | BPF_TAIL_CALL;
Alexei Starovoitovb2157392018-01-07 17:33:02 -08005727
Daniel Borkmannc93552c2018-05-24 02:32:53 +02005728 aux = &env->insn_aux_data[i + delta];
5729 if (!bpf_map_ptr_unpriv(aux))
5730 continue;
5731
Alexei Starovoitovb2157392018-01-07 17:33:02 -08005732 /* instead of changing every JIT dealing with tail_call
5733 * emit two extra insns:
5734 * if (index >= max_entries) goto out;
5735 * index &= array->index_mask;
5736 * to avoid out-of-bounds cpu speculation
5737 */
Daniel Borkmannc93552c2018-05-24 02:32:53 +02005738 if (bpf_map_ptr_poisoned(aux)) {
Colin Ian King40950342018-01-10 09:20:54 +00005739 verbose(env, "tail_call abusing map_ptr\n");
Alexei Starovoitovb2157392018-01-07 17:33:02 -08005740 return -EINVAL;
5741 }
Daniel Borkmannc93552c2018-05-24 02:32:53 +02005742
5743 map_ptr = BPF_MAP_PTR(aux->map_state);
Alexei Starovoitovb2157392018-01-07 17:33:02 -08005744 insn_buf[0] = BPF_JMP_IMM(BPF_JGE, BPF_REG_3,
5745 map_ptr->max_entries, 2);
5746 insn_buf[1] = BPF_ALU32_IMM(BPF_AND, BPF_REG_3,
5747 container_of(map_ptr,
5748 struct bpf_array,
5749 map)->index_mask);
5750 insn_buf[2] = *insn;
5751 cnt = 3;
5752 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
5753 if (!new_prog)
5754 return -ENOMEM;
5755
5756 delta += cnt - 1;
5757 env->prog = prog = new_prog;
5758 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005759 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005760 }
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005761
Daniel Borkmann89c63072017-08-19 03:12:45 +02005762 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
Daniel Borkmann09772d92018-06-02 23:06:35 +02005763 * and other inlining handlers are currently limited to 64 bit
5764 * only.
Daniel Borkmann89c63072017-08-19 03:12:45 +02005765 */
Alexei Starovoitov60b58afc2017-12-14 17:55:14 -08005766 if (prog->jit_requested && BITS_PER_LONG == 64 &&
Daniel Borkmann09772d92018-06-02 23:06:35 +02005767 (insn->imm == BPF_FUNC_map_lookup_elem ||
5768 insn->imm == BPF_FUNC_map_update_elem ||
5769 insn->imm == BPF_FUNC_map_delete_elem)) {
Daniel Borkmannc93552c2018-05-24 02:32:53 +02005770 aux = &env->insn_aux_data[i + delta];
5771 if (bpf_map_ptr_poisoned(aux))
5772 goto patch_call_imm;
5773
5774 map_ptr = BPF_MAP_PTR(aux->map_state);
Daniel Borkmann09772d92018-06-02 23:06:35 +02005775 ops = map_ptr->ops;
5776 if (insn->imm == BPF_FUNC_map_lookup_elem &&
5777 ops->map_gen_lookup) {
5778 cnt = ops->map_gen_lookup(map_ptr, insn_buf);
5779 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
5780 verbose(env, "bpf verifier is misconfigured\n");
5781 return -EINVAL;
5782 }
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005783
Daniel Borkmann09772d92018-06-02 23:06:35 +02005784 new_prog = bpf_patch_insn_data(env, i + delta,
5785 insn_buf, cnt);
5786 if (!new_prog)
5787 return -ENOMEM;
5788
5789 delta += cnt - 1;
5790 env->prog = prog = new_prog;
5791 insn = new_prog->insnsi + i + delta;
5792 continue;
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005793 }
5794
Daniel Borkmann09772d92018-06-02 23:06:35 +02005795 BUILD_BUG_ON(!__same_type(ops->map_lookup_elem,
5796 (void *(*)(struct bpf_map *map, void *key))NULL));
5797 BUILD_BUG_ON(!__same_type(ops->map_delete_elem,
5798 (int (*)(struct bpf_map *map, void *key))NULL));
5799 BUILD_BUG_ON(!__same_type(ops->map_update_elem,
5800 (int (*)(struct bpf_map *map, void *key, void *value,
5801 u64 flags))NULL));
5802 switch (insn->imm) {
5803 case BPF_FUNC_map_lookup_elem:
5804 insn->imm = BPF_CAST_CALL(ops->map_lookup_elem) -
5805 __bpf_call_base;
5806 continue;
5807 case BPF_FUNC_map_update_elem:
5808 insn->imm = BPF_CAST_CALL(ops->map_update_elem) -
5809 __bpf_call_base;
5810 continue;
5811 case BPF_FUNC_map_delete_elem:
5812 insn->imm = BPF_CAST_CALL(ops->map_delete_elem) -
5813 __bpf_call_base;
5814 continue;
5815 }
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005816
Daniel Borkmann09772d92018-06-02 23:06:35 +02005817 goto patch_call_imm;
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005818 }
5819
Daniel Borkmann109980b2017-09-08 00:14:51 +02005820 if (insn->imm == BPF_FUNC_redirect_map) {
Daniel Borkmann7c300132017-09-20 00:44:21 +02005821 /* Note, we cannot use prog directly as imm as subsequent
5822 * rewrites would still change the prog pointer. The only
5823 * stable address we can use is aux, which also works with
5824 * prog clones during blinding.
5825 */
5826 u64 addr = (unsigned long)prog->aux;
Daniel Borkmann109980b2017-09-08 00:14:51 +02005827 struct bpf_insn r4_ld[] = {
5828 BPF_LD_IMM64(BPF_REG_4, addr),
5829 *insn,
5830 };
5831 cnt = ARRAY_SIZE(r4_ld);
5832
5833 new_prog = bpf_patch_insn_data(env, i + delta, r4_ld, cnt);
5834 if (!new_prog)
5835 return -ENOMEM;
5836
5837 delta += cnt - 1;
5838 env->prog = prog = new_prog;
5839 insn = new_prog->insnsi + i + delta;
5840 }
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005841patch_call_imm:
Andrey Ignatov5e43f892018-03-30 15:08:00 -07005842 fn = env->ops->get_func_proto(insn->imm, env->prog);
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005843 /* all functions that have prototype and verifier allowed
5844 * programs to call them, must be real in-kernel functions
5845 */
5846 if (!fn->func) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005847 verbose(env,
5848 "kernel subsystem misconfigured func %s#%d\n",
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005849 func_id_name(insn->imm), insn->imm);
5850 return -EFAULT;
5851 }
5852 insn->imm = fn->func - __bpf_call_base;
5853 }
5854
5855 return 0;
5856}
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005857
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005858static void free_states(struct bpf_verifier_env *env)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005859{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005860 struct bpf_verifier_state_list *sl, *sln;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005861 int i;
5862
5863 if (!env->explored_states)
5864 return;
5865
5866 for (i = 0; i < env->prog->len; i++) {
5867 sl = env->explored_states[i];
5868
5869 if (sl)
5870 while (sl != STATE_LIST_MARK) {
5871 sln = sl->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07005872 free_verifier_state(&sl->state, false);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005873 kfree(sl);
5874 sl = sln;
5875 }
5876 }
5877
5878 kfree(env->explored_states);
5879}
5880
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005881int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
Alexei Starovoitov51580e72014-09-26 00:17:02 -07005882{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005883 struct bpf_verifier_env *env;
Martin KaFai Laub9193c12018-03-24 11:44:22 -07005884 struct bpf_verifier_log *log;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07005885 int ret = -EINVAL;
5886
Arnd Bergmanneba0c922017-11-02 12:05:52 +01005887 /* no program is valid */
5888 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
5889 return -EINVAL;
5890
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005891 /* 'struct bpf_verifier_env' can be global, but since it's not small,
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005892 * allocate/free it every time bpf_check() is called
5893 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005894 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005895 if (!env)
5896 return -ENOMEM;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005897 log = &env->log;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005898
Kees Cookfad953c2018-06-12 14:27:37 -07005899 env->insn_aux_data =
5900 vzalloc(array_size(sizeof(struct bpf_insn_aux_data),
5901 (*prog)->len));
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005902 ret = -ENOMEM;
5903 if (!env->insn_aux_data)
5904 goto err_free_env;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005905 env->prog = *prog;
Jakub Kicinski00176a32017-10-16 16:40:54 -07005906 env->ops = bpf_verifier_ops[env->prog->type];
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005907
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005908 /* grab the mutex to protect few globals used by verifier */
5909 mutex_lock(&bpf_verifier_lock);
5910
5911 if (attr->log_level || attr->log_buf || attr->log_size) {
5912 /* user requested verbose verifier output
5913 * and supplied buffer to store the verification trace
5914 */
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07005915 log->level = attr->log_level;
5916 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
5917 log->len_total = attr->log_size;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005918
5919 ret = -EINVAL;
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07005920 /* log attributes have to be sane */
5921 if (log->len_total < 128 || log->len_total > UINT_MAX >> 8 ||
5922 !log->level || !log->ubuf)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005923 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005924 }
Daniel Borkmann1ad2f582017-05-25 01:05:05 +02005925
5926 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
5927 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
David S. Millere07b98d2017-05-10 11:38:07 -07005928 env->strict_alignment = true;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005929
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005930 ret = replace_map_fd_with_map_ptr(env);
5931 if (ret < 0)
5932 goto skip_full_check;
5933
Jakub Kicinskif4e3ec02018-05-03 18:37:11 -07005934 if (bpf_prog_is_dev_bound(env->prog->aux)) {
5935 ret = bpf_prog_offload_verifier_prep(env);
5936 if (ret)
5937 goto skip_full_check;
5938 }
5939
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005940 env->explored_states = kcalloc(env->prog->len,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005941 sizeof(struct bpf_verifier_state_list *),
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005942 GFP_USER);
5943 ret = -ENOMEM;
5944 if (!env->explored_states)
5945 goto skip_full_check;
5946
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005947 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
5948
Alexei Starovoitov475fb782014-09-26 00:17:05 -07005949 ret = check_cfg(env);
5950 if (ret < 0)
5951 goto skip_full_check;
5952
Alexei Starovoitov17a52672014-09-26 00:17:06 -07005953 ret = do_check(env);
Craig Gallek8c01c4f2017-11-02 11:18:01 -04005954 if (env->cur_state) {
5955 free_verifier_state(env->cur_state, true);
5956 env->cur_state = NULL;
5957 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005958
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005959skip_full_check:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07005960 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005961 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005962
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005963 if (ret == 0)
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005964 sanitize_dead_code(env);
5965
5966 if (ret == 0)
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08005967 ret = check_max_stack_depth(env);
5968
5969 if (ret == 0)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005970 /* program is valid, convert *(u32*)(ctx + off) accesses */
5971 ret = convert_ctx_accesses(env);
5972
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005973 if (ret == 0)
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005974 ret = fixup_bpf_calls(env);
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005975
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005976 if (ret == 0)
5977 ret = fixup_call_args(env);
5978
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005979 if (log->level && bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005980 ret = -ENOSPC;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005981 if (log->level && !log->ubuf) {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005982 ret = -EFAULT;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005983 goto err_release_maps;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005984 }
5985
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005986 if (ret == 0 && env->used_map_cnt) {
5987 /* if program passed verifier, update used_maps in bpf_prog_info */
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005988 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
5989 sizeof(env->used_maps[0]),
5990 GFP_KERNEL);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005991
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005992 if (!env->prog->aux->used_maps) {
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005993 ret = -ENOMEM;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005994 goto err_release_maps;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005995 }
5996
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005997 memcpy(env->prog->aux->used_maps, env->used_maps,
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005998 sizeof(env->used_maps[0]) * env->used_map_cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005999 env->prog->aux->used_map_cnt = env->used_map_cnt;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07006000
6001 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
6002 * bpf_ld_imm64 instructions
6003 */
6004 convert_pseudo_ld_imm64(env);
6005 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07006006
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07006007err_release_maps:
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07006008 if (!env->prog->aux->used_maps)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07006009 /* if we didn't copy map pointers into bpf_prog_info, release
Jakub Kicinskiab7f5bf2018-05-03 18:37:17 -07006010 * them now. Otherwise free_used_maps() will release them.
Alexei Starovoitov0246e642014-09-26 00:17:04 -07006011 */
6012 release_maps(env);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07006013 *prog = env->prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01006014err_unlock:
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07006015 mutex_unlock(&bpf_verifier_lock);
Jakub Kicinski3df126f2016-09-21 11:43:56 +01006016 vfree(env->insn_aux_data);
6017err_free_env:
6018 kfree(env);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07006019 return ret;
6020}