blob: 20eb04fd155e1eb39a060bfe8492535ff8f2433e [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002 * Copyright (c) 2016 Facebook
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +010017#include <linux/bpf_verifier.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070018#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
Thomas Grafebb676d2016-10-27 11:23:51 +020022#include <linux/stringify.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070023
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -070024#include "disasm.h"
25
Jakub Kicinski00176a32017-10-16 16:40:54 -070026static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
27#define BPF_PROG_TYPE(_id, _name) \
28 [_id] = & _name ## _verifier_ops,
29#define BPF_MAP_TYPE(_id, _ops)
30#include <linux/bpf_types.h>
31#undef BPF_PROG_TYPE
32#undef BPF_MAP_TYPE
33};
34
Alexei Starovoitov51580e72014-09-26 00:17:02 -070035/* bpf_check() is a static code analyzer that walks eBPF program
36 * instruction by instruction and updates register/stack state.
37 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
38 *
39 * The first pass is depth-first-search to check that the program is a DAG.
40 * It rejects the following programs:
41 * - larger than BPF_MAXINSNS insns
42 * - if loop is present (detected via back-edge)
43 * - unreachable insns exist (shouldn't be a forest. program = one function)
44 * - out of bounds or malformed jumps
45 * The second pass is all possible path descent from the 1st insn.
46 * Since it's analyzing all pathes through the program, the length of the
Gary Lineba38a92017-03-01 16:25:51 +080047 * analysis is limited to 64k insn, which may be hit even if total number of
Alexei Starovoitov51580e72014-09-26 00:17:02 -070048 * insn is less then 4K, but there are too many branches that change stack/regs.
49 * Number of 'branches to be analyzed' is limited to 1k
50 *
51 * On entry to each instruction, each register has a type, and the instruction
52 * changes the types of the registers depending on instruction semantics.
53 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
54 * copied to R1.
55 *
56 * All registers are 64-bit.
57 * R0 - return register
58 * R1-R5 argument passing registers
59 * R6-R9 callee saved registers
60 * R10 - frame pointer read-only
61 *
62 * At the start of BPF program the register R1 contains a pointer to bpf_context
63 * and has type PTR_TO_CTX.
64 *
65 * Verifier tracks arithmetic operations on pointers in case:
66 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
67 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
68 * 1st insn copies R10 (which has FRAME_PTR) type into R1
69 * and 2nd arithmetic instruction is pattern matched to recognize
70 * that it wants to construct a pointer to some element within stack.
71 * So after 2nd insn, the register R1 has type PTR_TO_STACK
72 * (and -20 constant is saved for further stack bounds checking).
73 * Meaning that this reg is a pointer to stack plus known immediate constant.
74 *
Edward Creef1174f72017-08-07 15:26:19 +010075 * Most of the time the registers have SCALAR_VALUE type, which
Alexei Starovoitov51580e72014-09-26 00:17:02 -070076 * means the register has some value, but it's not a valid pointer.
Edward Creef1174f72017-08-07 15:26:19 +010077 * (like pointer plus pointer becomes SCALAR_VALUE type)
Alexei Starovoitov51580e72014-09-26 00:17:02 -070078 *
79 * When verifier sees load or store instructions the type of base register
Edward Creef1174f72017-08-07 15:26:19 +010080 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK. These are three pointer
Alexei Starovoitov51580e72014-09-26 00:17:02 -070081 * types recognized by check_mem_access() function.
82 *
83 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
84 * and the range of [ptr, ptr + map's value_size) is accessible.
85 *
86 * registers used to pass values to function calls are checked against
87 * function argument constraints.
88 *
89 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
90 * It means that the register type passed to this function must be
91 * PTR_TO_STACK and it will be used inside the function as
92 * 'pointer to map element key'
93 *
94 * For example the argument constraints for bpf_map_lookup_elem():
95 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
96 * .arg1_type = ARG_CONST_MAP_PTR,
97 * .arg2_type = ARG_PTR_TO_MAP_KEY,
98 *
99 * ret_type says that this function returns 'pointer to map elem value or null'
100 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
101 * 2nd argument should be a pointer to stack, which will be used inside
102 * the helper function as a pointer to map element key.
103 *
104 * On the kernel side the helper function looks like:
105 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
106 * {
107 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
108 * void *key = (void *) (unsigned long) r2;
109 * void *value;
110 *
111 * here kernel can access 'key' and 'map' pointers safely, knowing that
112 * [key, key + map->key_size) bytes are valid and were initialized on
113 * the stack of eBPF program.
114 * }
115 *
116 * Corresponding eBPF program may look like:
117 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
118 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
119 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
120 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
121 * here verifier looks at prototype of map_lookup_elem() and sees:
122 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
123 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
124 *
125 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
126 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
127 * and were initialized prior to this call.
128 * If it's ok, then verifier allows this BPF_CALL insn and looks at
129 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
130 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
131 * returns ether pointer to map value or NULL.
132 *
133 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
134 * insn, the register holding that pointer in the true branch changes state to
135 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
136 * branch. See check_cond_jmp_op().
137 *
138 * After the call R0 is set to return type of the function and registers R1-R5
139 * are set to NOT_INIT to indicate that they are no longer readable.
140 */
141
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700142/* verifier_state + insn_idx are pushed to stack when branch is encountered */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100143struct bpf_verifier_stack_elem {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700144 /* verifer state is 'st'
145 * before processing instruction 'insn_idx'
146 * and after processing instruction 'prev_insn_idx'
147 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100148 struct bpf_verifier_state st;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700149 int insn_idx;
150 int prev_insn_idx;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100151 struct bpf_verifier_stack_elem *next;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700152};
153
Edward Cree8e17c1b2017-08-07 15:30:30 +0100154#define BPF_COMPLEXITY_LIMIT_INSNS 131072
Daniel Borkmann07016152016-04-05 22:33:17 +0200155#define BPF_COMPLEXITY_LIMIT_STACK 1024
156
Martin KaFai Laufad73a12017-03-22 10:00:32 -0700157#define BPF_MAP_PTR_POISON ((void *)0xeB9F + POISON_POINTER_DELTA)
158
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200159struct bpf_call_arg_meta {
160 struct bpf_map *map_ptr;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200161 bool raw_mode;
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200162 bool pkt_access;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200163 int regno;
164 int access_size;
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200165};
166
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700167static DEFINE_MUTEX(bpf_verifier_lock);
168
169/* log_level controls verbosity level of eBPF verifier.
170 * verbose() is used to dump the verification trace to the log, so the user
171 * can figure out what's wrong with the program
172 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700173static __printf(2, 3) void verbose(struct bpf_verifier_env *env,
174 const char *fmt, ...)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700175{
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700176 struct bpf_verifer_log *log = &env->log;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700177 unsigned int n;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700178 va_list args;
179
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700180 if (!log->level || !log->ubuf || bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700181 return;
182
183 va_start(args, fmt);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700184 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700185 va_end(args);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700186
187 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
188 "verifier log line truncated - local buffer too short\n");
189
190 n = min(log->len_total - log->len_used - 1, n);
191 log->kbuf[n] = '\0';
192
193 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
194 log->len_used += n;
195 else
196 log->ubuf = NULL;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700197}
198
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200199static bool type_is_pkt_pointer(enum bpf_reg_type type)
200{
201 return type == PTR_TO_PACKET ||
202 type == PTR_TO_PACKET_META;
203}
204
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700205/* string representation of 'enum bpf_reg_type' */
206static const char * const reg_type_str[] = {
207 [NOT_INIT] = "?",
Edward Creef1174f72017-08-07 15:26:19 +0100208 [SCALAR_VALUE] = "inv",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700209 [PTR_TO_CTX] = "ctx",
210 [CONST_PTR_TO_MAP] = "map_ptr",
211 [PTR_TO_MAP_VALUE] = "map_value",
212 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700213 [PTR_TO_STACK] = "fp",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700214 [PTR_TO_PACKET] = "pkt",
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200215 [PTR_TO_PACKET_META] = "pkt_meta",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700216 [PTR_TO_PACKET_END] = "pkt_end",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700217};
218
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700219static void print_verifier_state(struct bpf_verifier_env *env,
220 struct bpf_verifier_state *state)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700221{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100222 struct bpf_reg_state *reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700223 enum bpf_reg_type t;
224 int i;
225
226 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700227 reg = &state->regs[i];
228 t = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700229 if (t == NOT_INIT)
230 continue;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700231 verbose(env, " R%d=%s", i, reg_type_str[t]);
Edward Creef1174f72017-08-07 15:26:19 +0100232 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
233 tnum_is_const(reg->var_off)) {
234 /* reg->off should be 0 for SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700235 verbose(env, "%lld", reg->var_off.value + reg->off);
Edward Creef1174f72017-08-07 15:26:19 +0100236 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700237 verbose(env, "(id=%d", reg->id);
Edward Creef1174f72017-08-07 15:26:19 +0100238 if (t != SCALAR_VALUE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700239 verbose(env, ",off=%d", reg->off);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200240 if (type_is_pkt_pointer(t))
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700241 verbose(env, ",r=%d", reg->range);
Edward Creef1174f72017-08-07 15:26:19 +0100242 else if (t == CONST_PTR_TO_MAP ||
243 t == PTR_TO_MAP_VALUE ||
244 t == PTR_TO_MAP_VALUE_OR_NULL)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700245 verbose(env, ",ks=%d,vs=%d",
Edward Creef1174f72017-08-07 15:26:19 +0100246 reg->map_ptr->key_size,
247 reg->map_ptr->value_size);
Edward Cree7d1238f2017-08-07 15:26:56 +0100248 if (tnum_is_const(reg->var_off)) {
249 /* Typically an immediate SCALAR_VALUE, but
250 * could be a pointer whose offset is too big
251 * for reg->off
252 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700253 verbose(env, ",imm=%llx", reg->var_off.value);
Edward Cree7d1238f2017-08-07 15:26:56 +0100254 } else {
255 if (reg->smin_value != reg->umin_value &&
256 reg->smin_value != S64_MIN)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700257 verbose(env, ",smin_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100258 (long long)reg->smin_value);
259 if (reg->smax_value != reg->umax_value &&
260 reg->smax_value != S64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700261 verbose(env, ",smax_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100262 (long long)reg->smax_value);
263 if (reg->umin_value != 0)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700264 verbose(env, ",umin_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100265 (unsigned long long)reg->umin_value);
266 if (reg->umax_value != U64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700267 verbose(env, ",umax_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100268 (unsigned long long)reg->umax_value);
269 if (!tnum_is_unknown(reg->var_off)) {
270 char tn_buf[48];
Edward Creef1174f72017-08-07 15:26:19 +0100271
Edward Cree7d1238f2017-08-07 15:26:56 +0100272 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700273 verbose(env, ",var_off=%s", tn_buf);
Edward Cree7d1238f2017-08-07 15:26:56 +0100274 }
Edward Creef1174f72017-08-07 15:26:19 +0100275 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700276 verbose(env, ")");
Edward Creef1174f72017-08-07 15:26:19 +0100277 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700278 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700279 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
280 if (state->stack[i].slot_type[0] == STACK_SPILL)
281 verbose(env, " fp%d=%s",
282 -MAX_BPF_STACK + i * BPF_REG_SIZE,
283 reg_type_str[state->stack[i].spilled_ptr.type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700284 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700285 verbose(env, "\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700286}
287
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700288static int copy_stack_state(struct bpf_verifier_state *dst,
289 const struct bpf_verifier_state *src)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700290{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700291 if (!src->stack)
292 return 0;
293 if (WARN_ON_ONCE(dst->allocated_stack < src->allocated_stack)) {
294 /* internal bug, make state invalid to reject the program */
295 memset(dst, 0, sizeof(*dst));
296 return -EFAULT;
297 }
298 memcpy(dst->stack, src->stack,
299 sizeof(*src->stack) * (src->allocated_stack / BPF_REG_SIZE));
300 return 0;
301}
302
303/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
304 * make it consume minimal amount of memory. check_stack_write() access from
305 * the program calls into realloc_verifier_state() to grow the stack size.
306 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
307 * which this function copies over. It points to previous bpf_verifier_state
308 * which is never reallocated
309 */
310static int realloc_verifier_state(struct bpf_verifier_state *state, int size,
311 bool copy_old)
312{
313 u32 old_size = state->allocated_stack;
314 struct bpf_stack_state *new_stack;
315 int slot = size / BPF_REG_SIZE;
316
317 if (size <= old_size || !size) {
318 if (copy_old)
319 return 0;
320 state->allocated_stack = slot * BPF_REG_SIZE;
321 if (!size && old_size) {
322 kfree(state->stack);
323 state->stack = NULL;
324 }
325 return 0;
326 }
327 new_stack = kmalloc_array(slot, sizeof(struct bpf_stack_state),
328 GFP_KERNEL);
329 if (!new_stack)
330 return -ENOMEM;
331 if (copy_old) {
332 if (state->stack)
333 memcpy(new_stack, state->stack,
334 sizeof(*new_stack) * (old_size / BPF_REG_SIZE));
335 memset(new_stack + old_size / BPF_REG_SIZE, 0,
336 sizeof(*new_stack) * (size - old_size) / BPF_REG_SIZE);
337 }
338 state->allocated_stack = slot * BPF_REG_SIZE;
339 kfree(state->stack);
340 state->stack = new_stack;
341 return 0;
342}
343
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700344static void free_verifier_state(struct bpf_verifier_state *state,
345 bool free_self)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700346{
347 kfree(state->stack);
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700348 if (free_self)
349 kfree(state);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700350}
351
352/* copy verifier state from src to dst growing dst stack space
353 * when necessary to accommodate larger src stack
354 */
355static int copy_verifier_state(struct bpf_verifier_state *dst,
356 const struct bpf_verifier_state *src)
357{
358 int err;
359
360 err = realloc_verifier_state(dst, src->allocated_stack, false);
361 if (err)
362 return err;
363 memcpy(dst, src, offsetof(struct bpf_verifier_state, allocated_stack));
364 return copy_stack_state(dst, src);
365}
366
367static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
368 int *insn_idx)
369{
370 struct bpf_verifier_state *cur = env->cur_state;
371 struct bpf_verifier_stack_elem *elem, *head = env->head;
372 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700373
374 if (env->head == NULL)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700375 return -ENOENT;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700376
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700377 if (cur) {
378 err = copy_verifier_state(cur, &head->st);
379 if (err)
380 return err;
381 }
382 if (insn_idx)
383 *insn_idx = head->insn_idx;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700384 if (prev_insn_idx)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700385 *prev_insn_idx = head->prev_insn_idx;
386 elem = head->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700387 free_verifier_state(&head->st, false);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700388 kfree(head);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700389 env->head = elem;
390 env->stack_size--;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700391 return 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700392}
393
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100394static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
395 int insn_idx, int prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700396{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700397 struct bpf_verifier_state *cur = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100398 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700399 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700400
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700401 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700402 if (!elem)
403 goto err;
404
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700405 elem->insn_idx = insn_idx;
406 elem->prev_insn_idx = prev_insn_idx;
407 elem->next = env->head;
408 env->head = elem;
409 env->stack_size++;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700410 err = copy_verifier_state(&elem->st, cur);
411 if (err)
412 goto err;
Daniel Borkmann07016152016-04-05 22:33:17 +0200413 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700414 verbose(env, "BPF program is too complex\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700415 goto err;
416 }
417 return &elem->st;
418err:
419 /* pop all elements and return */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700420 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700421 return NULL;
422}
423
424#define CALLER_SAVED_REGS 6
425static const int caller_saved[CALLER_SAVED_REGS] = {
426 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
427};
428
Edward Creef1174f72017-08-07 15:26:19 +0100429static void __mark_reg_not_init(struct bpf_reg_state *reg);
430
Edward Creeb03c9f92017-08-07 15:26:36 +0100431/* Mark the unknown part of a register (variable offset or scalar value) as
432 * known to have the value @imm.
433 */
434static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
435{
436 reg->id = 0;
437 reg->var_off = tnum_const(imm);
438 reg->smin_value = (s64)imm;
439 reg->smax_value = (s64)imm;
440 reg->umin_value = imm;
441 reg->umax_value = imm;
442}
443
Edward Creef1174f72017-08-07 15:26:19 +0100444/* Mark the 'variable offset' part of a register as zero. This should be
445 * used only on registers holding a pointer type.
446 */
447static void __mark_reg_known_zero(struct bpf_reg_state *reg)
448{
Edward Creeb03c9f92017-08-07 15:26:36 +0100449 __mark_reg_known(reg, 0);
Edward Creef1174f72017-08-07 15:26:19 +0100450}
451
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700452static void mark_reg_known_zero(struct bpf_verifier_env *env,
453 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100454{
455 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700456 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100457 /* Something bad happened, let's kill all regs */
458 for (regno = 0; regno < MAX_BPF_REG; regno++)
459 __mark_reg_not_init(regs + regno);
460 return;
461 }
462 __mark_reg_known_zero(regs + regno);
463}
464
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200465static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
466{
467 return type_is_pkt_pointer(reg->type);
468}
469
470static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
471{
472 return reg_is_pkt_pointer(reg) ||
473 reg->type == PTR_TO_PACKET_END;
474}
475
476/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
477static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
478 enum bpf_reg_type which)
479{
480 /* The register can already have a range from prior markings.
481 * This is fine as long as it hasn't been advanced from its
482 * origin.
483 */
484 return reg->type == which &&
485 reg->id == 0 &&
486 reg->off == 0 &&
487 tnum_equals_const(reg->var_off, 0);
488}
489
Edward Creeb03c9f92017-08-07 15:26:36 +0100490/* Attempts to improve min/max values based on var_off information */
491static void __update_reg_bounds(struct bpf_reg_state *reg)
492{
493 /* min signed is max(sign bit) | min(other bits) */
494 reg->smin_value = max_t(s64, reg->smin_value,
495 reg->var_off.value | (reg->var_off.mask & S64_MIN));
496 /* max signed is min(sign bit) | max(other bits) */
497 reg->smax_value = min_t(s64, reg->smax_value,
498 reg->var_off.value | (reg->var_off.mask & S64_MAX));
499 reg->umin_value = max(reg->umin_value, reg->var_off.value);
500 reg->umax_value = min(reg->umax_value,
501 reg->var_off.value | reg->var_off.mask);
502}
503
504/* Uses signed min/max values to inform unsigned, and vice-versa */
505static void __reg_deduce_bounds(struct bpf_reg_state *reg)
506{
507 /* Learn sign from signed bounds.
508 * If we cannot cross the sign boundary, then signed and unsigned bounds
509 * are the same, so combine. This works even in the negative case, e.g.
510 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
511 */
512 if (reg->smin_value >= 0 || reg->smax_value < 0) {
513 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
514 reg->umin_value);
515 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
516 reg->umax_value);
517 return;
518 }
519 /* Learn sign from unsigned bounds. Signed bounds cross the sign
520 * boundary, so we must be careful.
521 */
522 if ((s64)reg->umax_value >= 0) {
523 /* Positive. We can't learn anything from the smin, but smax
524 * is positive, hence safe.
525 */
526 reg->smin_value = reg->umin_value;
527 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
528 reg->umax_value);
529 } else if ((s64)reg->umin_value < 0) {
530 /* Negative. We can't learn anything from the smax, but smin
531 * is negative, hence safe.
532 */
533 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
534 reg->umin_value);
535 reg->smax_value = reg->umax_value;
536 }
537}
538
539/* Attempts to improve var_off based on unsigned min/max information */
540static void __reg_bound_offset(struct bpf_reg_state *reg)
541{
542 reg->var_off = tnum_intersect(reg->var_off,
543 tnum_range(reg->umin_value,
544 reg->umax_value));
545}
546
547/* Reset the min/max bounds of a register */
548static void __mark_reg_unbounded(struct bpf_reg_state *reg)
549{
550 reg->smin_value = S64_MIN;
551 reg->smax_value = S64_MAX;
552 reg->umin_value = 0;
553 reg->umax_value = U64_MAX;
554}
555
Edward Creef1174f72017-08-07 15:26:19 +0100556/* Mark a register as having a completely unknown (scalar) value. */
557static void __mark_reg_unknown(struct bpf_reg_state *reg)
558{
559 reg->type = SCALAR_VALUE;
560 reg->id = 0;
561 reg->off = 0;
562 reg->var_off = tnum_unknown;
Edward Creeb03c9f92017-08-07 15:26:36 +0100563 __mark_reg_unbounded(reg);
Edward Creef1174f72017-08-07 15:26:19 +0100564}
565
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700566static void mark_reg_unknown(struct bpf_verifier_env *env,
567 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100568{
569 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700570 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100571 /* Something bad happened, let's kill all regs */
572 for (regno = 0; regno < MAX_BPF_REG; regno++)
573 __mark_reg_not_init(regs + regno);
574 return;
575 }
576 __mark_reg_unknown(regs + regno);
577}
578
579static void __mark_reg_not_init(struct bpf_reg_state *reg)
580{
581 __mark_reg_unknown(reg);
582 reg->type = NOT_INIT;
583}
584
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700585static void mark_reg_not_init(struct bpf_verifier_env *env,
586 struct bpf_reg_state *regs, u32 regno)
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200587{
Edward Creef1174f72017-08-07 15:26:19 +0100588 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700589 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100590 /* Something bad happened, let's kill all regs */
591 for (regno = 0; regno < MAX_BPF_REG; regno++)
592 __mark_reg_not_init(regs + regno);
593 return;
594 }
595 __mark_reg_not_init(regs + regno);
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200596}
597
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700598static void init_reg_state(struct bpf_verifier_env *env,
599 struct bpf_reg_state *regs)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700600{
601 int i;
602
Edward Creedc503a82017-08-15 20:34:35 +0100603 for (i = 0; i < MAX_BPF_REG; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700604 mark_reg_not_init(env, regs, i);
Edward Creedc503a82017-08-15 20:34:35 +0100605 regs[i].live = REG_LIVE_NONE;
606 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700607
608 /* frame pointer */
Edward Creef1174f72017-08-07 15:26:19 +0100609 regs[BPF_REG_FP].type = PTR_TO_STACK;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700610 mark_reg_known_zero(env, regs, BPF_REG_FP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700611
612 /* 1st arg to a function */
613 regs[BPF_REG_1].type = PTR_TO_CTX;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700614 mark_reg_known_zero(env, regs, BPF_REG_1);
Daniel Borkmann6760bf22016-12-18 01:52:59 +0100615}
616
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700617enum reg_arg_type {
618 SRC_OP, /* register is used as source operand */
619 DST_OP, /* register is used as destination operand */
620 DST_OP_NO_MARK /* same as above, check only, don't mark */
621};
622
Edward Creedc503a82017-08-15 20:34:35 +0100623static void mark_reg_read(const struct bpf_verifier_state *state, u32 regno)
624{
625 struct bpf_verifier_state *parent = state->parent;
626
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -0700627 if (regno == BPF_REG_FP)
628 /* We don't need to worry about FP liveness because it's read-only */
629 return;
630
Edward Creedc503a82017-08-15 20:34:35 +0100631 while (parent) {
632 /* if read wasn't screened by an earlier write ... */
633 if (state->regs[regno].live & REG_LIVE_WRITTEN)
634 break;
635 /* ... then we depend on parent's value */
636 parent->regs[regno].live |= REG_LIVE_READ;
637 state = parent;
638 parent = state->parent;
639 }
640}
641
642static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700643 enum reg_arg_type t)
644{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700645 struct bpf_reg_state *regs = env->cur_state->regs;
Edward Creedc503a82017-08-15 20:34:35 +0100646
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700647 if (regno >= MAX_BPF_REG) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700648 verbose(env, "R%d is invalid\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700649 return -EINVAL;
650 }
651
652 if (t == SRC_OP) {
653 /* check whether register used as source operand can be read */
654 if (regs[regno].type == NOT_INIT) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700655 verbose(env, "R%d !read_ok\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700656 return -EACCES;
657 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700658 mark_reg_read(env->cur_state, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700659 } else {
660 /* check whether register used as dest operand can be written to */
661 if (regno == BPF_REG_FP) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700662 verbose(env, "frame pointer is read only\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700663 return -EACCES;
664 }
Edward Creedc503a82017-08-15 20:34:35 +0100665 regs[regno].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700666 if (t == DST_OP)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700667 mark_reg_unknown(env, regs, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700668 }
669 return 0;
670}
671
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700672static bool is_spillable_regtype(enum bpf_reg_type type)
673{
674 switch (type) {
675 case PTR_TO_MAP_VALUE:
676 case PTR_TO_MAP_VALUE_OR_NULL:
677 case PTR_TO_STACK:
678 case PTR_TO_CTX:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700679 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200680 case PTR_TO_PACKET_META:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700681 case PTR_TO_PACKET_END:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700682 case CONST_PTR_TO_MAP:
683 return true;
684 default:
685 return false;
686 }
687}
688
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700689/* check_stack_read/write functions track spill/fill of registers,
690 * stack boundary and alignment are checked in check_mem_access()
691 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700692static int check_stack_write(struct bpf_verifier_env *env,
693 struct bpf_verifier_state *state, int off,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100694 int size, int value_regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700695{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700696 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
697
698 err = realloc_verifier_state(state, round_up(slot + 1, BPF_REG_SIZE),
699 true);
700 if (err)
701 return err;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700702 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
703 * so it's aligned access and [off, off + size) are within stack limits
704 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700705 if (!env->allow_ptr_leaks &&
706 state->stack[spi].slot_type[0] == STACK_SPILL &&
707 size != BPF_REG_SIZE) {
708 verbose(env, "attempt to corrupt spilled pointer on stack\n");
709 return -EACCES;
710 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700711
712 if (value_regno >= 0 &&
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700713 is_spillable_regtype(state->regs[value_regno].type)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700714
715 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700716 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700717 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700718 return -EACCES;
719 }
720
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700721 /* save register state */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700722 state->stack[spi].spilled_ptr = state->regs[value_regno];
723 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700724
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700725 for (i = 0; i < BPF_REG_SIZE; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700726 state->stack[spi].slot_type[i] = STACK_SPILL;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700727 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700728 /* regular write of data into stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700729 state->stack[spi].spilled_ptr = (struct bpf_reg_state) {};
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700730
731 for (i = 0; i < size; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700732 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
733 STACK_MISC;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700734 }
735 return 0;
736}
737
Edward Creedc503a82017-08-15 20:34:35 +0100738static void mark_stack_slot_read(const struct bpf_verifier_state *state, int slot)
739{
740 struct bpf_verifier_state *parent = state->parent;
741
742 while (parent) {
743 /* if read wasn't screened by an earlier write ... */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700744 if (state->stack[slot].spilled_ptr.live & REG_LIVE_WRITTEN)
Edward Creedc503a82017-08-15 20:34:35 +0100745 break;
746 /* ... then we depend on parent's value */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700747 parent->stack[slot].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +0100748 state = parent;
749 parent = state->parent;
750 }
751}
752
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700753static int check_stack_read(struct bpf_verifier_env *env,
754 struct bpf_verifier_state *state, int off, int size,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700755 int value_regno)
756{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700757 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
758 u8 *stype;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700759
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700760 if (state->allocated_stack <= slot) {
761 verbose(env, "invalid read from stack off %d+0 size %d\n",
762 off, size);
763 return -EACCES;
764 }
765 stype = state->stack[spi].slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700766
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700767 if (stype[0] == STACK_SPILL) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700768 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700769 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700770 return -EACCES;
771 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700772 for (i = 1; i < BPF_REG_SIZE; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700773 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700774 verbose(env, "corrupted spill memory\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700775 return -EACCES;
776 }
777 }
778
Edward Creedc503a82017-08-15 20:34:35 +0100779 if (value_regno >= 0) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700780 /* restore register state from stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700781 state->regs[value_regno] = state->stack[spi].spilled_ptr;
Edward Creedc503a82017-08-15 20:34:35 +0100782 mark_stack_slot_read(state, spi);
783 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700784 return 0;
785 } else {
786 for (i = 0; i < size; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700787 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_MISC) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700788 verbose(env, "invalid read from stack off %d+%d size %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700789 off, i, size);
790 return -EACCES;
791 }
792 }
793 if (value_regno >= 0)
794 /* have read misc data from the stack */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700795 mark_reg_unknown(env, state->regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700796 return 0;
797 }
798}
799
800/* check read/write into map element returned by bpf_map_lookup_elem() */
Edward Creef1174f72017-08-07 15:26:19 +0100801static int __check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800802 int size, bool zero_size_allowed)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700803{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700804 struct bpf_reg_state *regs = cur_regs(env);
805 struct bpf_map *map = regs[regno].map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700806
Yonghong Song9fd29c02017-11-12 14:49:09 -0800807 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
808 off + size > map->value_size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700809 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700810 map->value_size, off, size);
811 return -EACCES;
812 }
813 return 0;
814}
815
Edward Creef1174f72017-08-07 15:26:19 +0100816/* check read/write into a map element with possible variable offset */
817static int check_map_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800818 int off, int size, bool zero_size_allowed)
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800819{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700820 struct bpf_verifier_state *state = env->cur_state;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800821 struct bpf_reg_state *reg = &state->regs[regno];
822 int err;
823
Edward Creef1174f72017-08-07 15:26:19 +0100824 /* We may have adjusted the register to this map value, so we
825 * need to try adding each of min_value and max_value to off
826 * to make sure our theoretical access will be safe.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800827 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700828 if (env->log.level)
829 print_verifier_state(env, state);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800830 /* The minimum value is only important with signed
831 * comparisons where we can't assume the floor of a
832 * value is 0. If we are using signed variables for our
833 * index'es we need to make sure that whatever we use
834 * will have a set floor within our range.
835 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100836 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700837 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800838 regno);
839 return -EACCES;
840 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800841 err = __check_map_access(env, regno, reg->smin_value + off, size,
842 zero_size_allowed);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800843 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700844 verbose(env, "R%d min value is outside of the array range\n",
845 regno);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800846 return err;
847 }
848
Edward Creeb03c9f92017-08-07 15:26:36 +0100849 /* If we haven't set a max value then we need to bail since we can't be
850 * sure we won't do bad things.
851 * If reg->umax_value + off could overflow, treat that as unbounded too.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800852 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100853 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700854 verbose(env, "R%d unbounded memory access, make sure to bounds check any array access into a map\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800855 regno);
856 return -EACCES;
857 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800858 err = __check_map_access(env, regno, reg->umax_value + off, size,
859 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +0100860 if (err)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700861 verbose(env, "R%d max value is outside of the array range\n",
862 regno);
Edward Creef1174f72017-08-07 15:26:19 +0100863 return err;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800864}
865
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700866#define MAX_PACKET_OFF 0xffff
867
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100868static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100869 const struct bpf_call_arg_meta *meta,
870 enum bpf_access_type t)
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700871{
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200872 switch (env->prog->type) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100873 case BPF_PROG_TYPE_LWT_IN:
874 case BPF_PROG_TYPE_LWT_OUT:
875 /* dst_input() and dst_output() can't write for now */
876 if (t == BPF_WRITE)
877 return false;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +0100878 /* fallthrough */
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200879 case BPF_PROG_TYPE_SCHED_CLS:
880 case BPF_PROG_TYPE_SCHED_ACT:
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700881 case BPF_PROG_TYPE_XDP:
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100882 case BPF_PROG_TYPE_LWT_XMIT:
John Fastabend8a31db52017-08-15 22:33:09 -0700883 case BPF_PROG_TYPE_SK_SKB:
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200884 if (meta)
885 return meta->pkt_access;
886
887 env->seen_direct_write = true;
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700888 return true;
889 default:
890 return false;
891 }
892}
893
Edward Creef1174f72017-08-07 15:26:19 +0100894static int __check_packet_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800895 int off, int size, bool zero_size_allowed)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700896{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700897 struct bpf_reg_state *regs = cur_regs(env);
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100898 struct bpf_reg_state *reg = &regs[regno];
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700899
Yonghong Song9fd29c02017-11-12 14:49:09 -0800900 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
901 (u64)off + size > reg->range) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700902 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -0700903 off, size, regno, reg->id, reg->off, reg->range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700904 return -EACCES;
905 }
906 return 0;
907}
908
Edward Creef1174f72017-08-07 15:26:19 +0100909static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800910 int size, bool zero_size_allowed)
Edward Creef1174f72017-08-07 15:26:19 +0100911{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700912 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +0100913 struct bpf_reg_state *reg = &regs[regno];
914 int err;
915
916 /* We may have added a variable offset to the packet pointer; but any
917 * reg->range we have comes after that. We are only checking the fixed
918 * offset.
919 */
920
921 /* We don't allow negative numbers, because we aren't tracking enough
922 * detail to prove they're safe.
923 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100924 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700925 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Edward Creef1174f72017-08-07 15:26:19 +0100926 regno);
927 return -EACCES;
928 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800929 err = __check_packet_access(env, regno, off, size, zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +0100930 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700931 verbose(env, "R%d offset is outside of the packet\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100932 return err;
933 }
934 return err;
935}
936
937/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
Yonghong Song31fd8582017-06-13 15:52:13 -0700938static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700939 enum bpf_access_type t, enum bpf_reg_type *reg_type)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700940{
Daniel Borkmannf96da092017-07-02 02:13:27 +0200941 struct bpf_insn_access_aux info = {
942 .reg_type = *reg_type,
943 };
Yonghong Song31fd8582017-06-13 15:52:13 -0700944
Jakub Kicinski4f9218a2017-10-16 16:40:55 -0700945 if (env->ops->is_valid_access &&
946 env->ops->is_valid_access(off, size, t, &info)) {
Daniel Borkmannf96da092017-07-02 02:13:27 +0200947 /* A non zero info.ctx_field_size indicates that this field is a
948 * candidate for later verifier transformation to load the whole
949 * field and then apply a mask when accessed with a narrower
950 * access than actual ctx access size. A zero info.ctx_field_size
951 * will only allow for whole field access and rejects any other
952 * type of narrower access.
Yonghong Song31fd8582017-06-13 15:52:13 -0700953 */
Yonghong Song23994632017-06-22 15:07:39 -0700954 *reg_type = info.reg_type;
Yonghong Song31fd8582017-06-13 15:52:13 -0700955
Jakub Kicinski4f9218a2017-10-16 16:40:55 -0700956 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700957 /* remember the offset of last byte accessed in ctx */
958 if (env->prog->aux->max_ctx_offset < off + size)
959 env->prog->aux->max_ctx_offset = off + size;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700960 return 0;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700961 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700962
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700963 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700964 return -EACCES;
965}
966
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200967static bool __is_pointer_value(bool allow_ptr_leaks,
968 const struct bpf_reg_state *reg)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700969{
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200970 if (allow_ptr_leaks)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700971 return false;
972
Edward Creef1174f72017-08-07 15:26:19 +0100973 return reg->type != SCALAR_VALUE;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700974}
975
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200976static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
977{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700978 return __is_pointer_value(env->allow_ptr_leaks, cur_regs(env) + regno);
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200979}
980
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700981static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
982 const struct bpf_reg_state *reg,
David S. Millerd1174412017-05-10 11:22:52 -0700983 int off, int size, bool strict)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700984{
Edward Creef1174f72017-08-07 15:26:19 +0100985 struct tnum reg_off;
David S. Millere07b98d2017-05-10 11:38:07 -0700986 int ip_align;
David S. Millerd1174412017-05-10 11:22:52 -0700987
988 /* Byte size accesses are always allowed. */
989 if (!strict || size == 1)
990 return 0;
991
David S. Millere4eda882017-05-22 12:27:07 -0400992 /* For platforms that do not have a Kconfig enabling
993 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
994 * NET_IP_ALIGN is universally set to '2'. And on platforms
995 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
996 * to this code only in strict mode where we want to emulate
997 * the NET_IP_ALIGN==2 checking. Therefore use an
998 * unconditional IP align value of '2'.
David S. Millere07b98d2017-05-10 11:38:07 -0700999 */
David S. Millere4eda882017-05-22 12:27:07 -04001000 ip_align = 2;
Edward Creef1174f72017-08-07 15:26:19 +01001001
1002 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
1003 if (!tnum_is_aligned(reg_off, size)) {
1004 char tn_buf[48];
1005
1006 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001007 verbose(env,
1008 "misaligned packet access off %d+%s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001009 ip_align, tn_buf, reg->off, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001010 return -EACCES;
1011 }
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001012
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001013 return 0;
1014}
1015
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001016static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
1017 const struct bpf_reg_state *reg,
Edward Creef1174f72017-08-07 15:26:19 +01001018 const char *pointer_desc,
1019 int off, int size, bool strict)
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001020{
Edward Creef1174f72017-08-07 15:26:19 +01001021 struct tnum reg_off;
1022
1023 /* Byte size accesses are always allowed. */
1024 if (!strict || size == 1)
1025 return 0;
1026
1027 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
1028 if (!tnum_is_aligned(reg_off, size)) {
1029 char tn_buf[48];
1030
1031 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001032 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001033 pointer_desc, tn_buf, reg->off, off, size);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001034 return -EACCES;
1035 }
1036
1037 return 0;
1038}
1039
David S. Millere07b98d2017-05-10 11:38:07 -07001040static int check_ptr_alignment(struct bpf_verifier_env *env,
1041 const struct bpf_reg_state *reg,
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001042 int off, int size)
1043{
David S. Millere07b98d2017-05-10 11:38:07 -07001044 bool strict = env->strict_alignment;
Edward Creef1174f72017-08-07 15:26:19 +01001045 const char *pointer_desc = "";
David S. Millerd1174412017-05-10 11:22:52 -07001046
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001047 switch (reg->type) {
1048 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001049 case PTR_TO_PACKET_META:
1050 /* Special case, because of NET_IP_ALIGN. Given metadata sits
1051 * right in front, treat it the very same way.
1052 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001053 return check_pkt_ptr_alignment(env, reg, off, size, strict);
Edward Creef1174f72017-08-07 15:26:19 +01001054 case PTR_TO_MAP_VALUE:
1055 pointer_desc = "value ";
1056 break;
1057 case PTR_TO_CTX:
1058 pointer_desc = "context ";
1059 break;
1060 case PTR_TO_STACK:
1061 pointer_desc = "stack ";
Jann Horna5ec6ae2017-12-18 20:11:58 -08001062 /* The stack spill tracking logic in check_stack_write()
1063 * and check_stack_read() relies on stack accesses being
1064 * aligned.
1065 */
1066 strict = true;
Edward Creef1174f72017-08-07 15:26:19 +01001067 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001068 default:
Edward Creef1174f72017-08-07 15:26:19 +01001069 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001070 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001071 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
1072 strict);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001073}
1074
Jann Horn0c17d1d2017-12-18 20:11:55 -08001075/* truncate register to smaller size (in bytes)
1076 * must be called with size < BPF_REG_SIZE
1077 */
1078static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
1079{
1080 u64 mask;
1081
1082 /* clear high bits in bit representation */
1083 reg->var_off = tnum_cast(reg->var_off, size);
1084
1085 /* fix arithmetic bounds */
1086 mask = ((u64)1 << (size * 8)) - 1;
1087 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
1088 reg->umin_value &= mask;
1089 reg->umax_value &= mask;
1090 } else {
1091 reg->umin_value = 0;
1092 reg->umax_value = mask;
1093 }
1094 reg->smin_value = reg->umin_value;
1095 reg->smax_value = reg->umax_value;
1096}
1097
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001098/* check whether memory at (regno + off) is accessible for t = (read | write)
1099 * if t==write, value_regno is a register which value is stored into memory
1100 * if t==read, value_regno is a register which will receive the value from memory
1101 * if t==write && value_regno==-1, some unknown value is stored into memory
1102 * if t==read && value_regno==-1, don't care what we read from memory
1103 */
Yonghong Song31fd8582017-06-13 15:52:13 -07001104static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001105 int bpf_size, enum bpf_access_type t,
1106 int value_regno)
1107{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001108 struct bpf_verifier_state *state = env->cur_state;
1109 struct bpf_reg_state *regs = cur_regs(env);
1110 struct bpf_reg_state *reg = regs + regno;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001111 int size, err = 0;
1112
1113 size = bpf_size_to_bytes(bpf_size);
1114 if (size < 0)
1115 return size;
1116
Edward Creef1174f72017-08-07 15:26:19 +01001117 /* alignment checks will add in reg->off themselves */
David S. Millere07b98d2017-05-10 11:38:07 -07001118 err = check_ptr_alignment(env, reg, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001119 if (err)
1120 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001121
Edward Creef1174f72017-08-07 15:26:19 +01001122 /* for access checks, reg->off is just part of off */
1123 off += reg->off;
1124
1125 if (reg->type == PTR_TO_MAP_VALUE) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001126 if (t == BPF_WRITE && value_regno >= 0 &&
1127 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001128 verbose(env, "R%d leaks addr into map\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001129 return -EACCES;
1130 }
Josef Bacik48461132016-09-28 10:54:32 -04001131
Yonghong Song9fd29c02017-11-12 14:49:09 -08001132 err = check_map_access(env, regno, off, size, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001133 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001134 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001135
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001136 } else if (reg->type == PTR_TO_CTX) {
Edward Creef1174f72017-08-07 15:26:19 +01001137 enum bpf_reg_type reg_type = SCALAR_VALUE;
Alexei Starovoitov19de99f2016-06-15 18:25:38 -07001138
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001139 if (t == BPF_WRITE && value_regno >= 0 &&
1140 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001141 verbose(env, "R%d leaks addr into ctx\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001142 return -EACCES;
1143 }
Edward Creef1174f72017-08-07 15:26:19 +01001144 /* ctx accesses must be at a fixed offset, so that we can
1145 * determine what type of data were returned.
1146 */
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001147 if (reg->off) {
David S. Millerf8ddadc2017-10-22 13:36:53 +01001148 verbose(env,
1149 "dereference of modified ctx ptr R%d off=%d+%d, ctx+const is allowed, ctx+const+const is not\n",
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001150 regno, reg->off, off - reg->off);
1151 return -EACCES;
1152 }
1153 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
Edward Creef1174f72017-08-07 15:26:19 +01001154 char tn_buf[48];
1155
1156 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001157 verbose(env,
1158 "variable ctx access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001159 tn_buf, off, size);
1160 return -EACCES;
1161 }
Yonghong Song31fd8582017-06-13 15:52:13 -07001162 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001163 if (!err && t == BPF_READ && value_regno >= 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001164 /* ctx access returns either a scalar, or a
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001165 * PTR_TO_PACKET[_META,_END]. In the latter
1166 * case, we know the offset is zero.
Edward Creef1174f72017-08-07 15:26:19 +01001167 */
1168 if (reg_type == SCALAR_VALUE)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001169 mark_reg_unknown(env, regs, value_regno);
Edward Creef1174f72017-08-07 15:26:19 +01001170 else
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001171 mark_reg_known_zero(env, regs,
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001172 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001173 regs[value_regno].id = 0;
1174 regs[value_regno].off = 0;
1175 regs[value_regno].range = 0;
1176 regs[value_regno].type = reg_type;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001177 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001178
Edward Creef1174f72017-08-07 15:26:19 +01001179 } else if (reg->type == PTR_TO_STACK) {
1180 /* stack accesses must be at a fixed offset, so that we can
1181 * determine what type of data were returned.
1182 * See check_stack_read().
1183 */
1184 if (!tnum_is_const(reg->var_off)) {
1185 char tn_buf[48];
1186
1187 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001188 verbose(env, "variable stack access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001189 tn_buf, off, size);
1190 return -EACCES;
1191 }
1192 off += reg->var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001193 if (off >= 0 || off < -MAX_BPF_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001194 verbose(env, "invalid stack off=%d size=%d\n", off,
1195 size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001196 return -EACCES;
1197 }
Alexei Starovoitov87266792017-05-30 13:31:29 -07001198
1199 if (env->prog->aux->stack_depth < -off)
1200 env->prog->aux->stack_depth = -off;
1201
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001202 if (t == BPF_WRITE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001203 err = check_stack_write(env, state, off, size,
1204 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001205 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001206 err = check_stack_read(env, state, off, size,
1207 value_regno);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001208 } else if (reg_is_pkt_pointer(reg)) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001209 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001210 verbose(env, "cannot write into packet\n");
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001211 return -EACCES;
1212 }
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001213 if (t == BPF_WRITE && value_regno >= 0 &&
1214 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001215 verbose(env, "R%d leaks addr into packet\n",
1216 value_regno);
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001217 return -EACCES;
1218 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001219 err = check_packet_access(env, regno, off, size, false);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001220 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001221 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001222 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001223 verbose(env, "R%d invalid mem access '%s'\n", regno,
1224 reg_type_str[reg->type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001225 return -EACCES;
1226 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001227
Edward Creef1174f72017-08-07 15:26:19 +01001228 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001229 regs[value_regno].type == SCALAR_VALUE) {
Edward Creef1174f72017-08-07 15:26:19 +01001230 /* b/h/w load zero-extends, mark upper bits as known 0 */
Jann Horn0c17d1d2017-12-18 20:11:55 -08001231 coerce_reg_to_size(&regs[value_regno], size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001232 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001233 return err;
1234}
1235
Yonghong Song31fd8582017-06-13 15:52:13 -07001236static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001237{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001238 int err;
1239
1240 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
1241 insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001242 verbose(env, "BPF_XADD uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001243 return -EINVAL;
1244 }
1245
1246 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001247 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001248 if (err)
1249 return err;
1250
1251 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001252 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001253 if (err)
1254 return err;
1255
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001256 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001257 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001258 return -EACCES;
1259 }
1260
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001261 /* check whether atomic_add can read the memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001262 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001263 BPF_SIZE(insn->code), BPF_READ, -1);
1264 if (err)
1265 return err;
1266
1267 /* check whether atomic_add can write into the same memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001268 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001269 BPF_SIZE(insn->code), BPF_WRITE, -1);
1270}
1271
Edward Creef1174f72017-08-07 15:26:19 +01001272/* Does this register contain a constant zero? */
1273static bool register_is_null(struct bpf_reg_state reg)
1274{
1275 return reg.type == SCALAR_VALUE && tnum_equals_const(reg.var_off, 0);
1276}
1277
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001278/* when register 'regno' is passed into function that will read 'access_size'
1279 * bytes from that pointer, make sure that it's within stack boundary
Edward Creef1174f72017-08-07 15:26:19 +01001280 * and all elements of stack are initialized.
1281 * Unlike most pointer bounds-checking functions, this one doesn't take an
1282 * 'off' argument, so it has to add in reg->off itself.
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001283 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001284static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
Daniel Borkmann435faee12016-04-13 00:10:51 +02001285 int access_size, bool zero_size_allowed,
1286 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001287{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001288 struct bpf_verifier_state *state = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001289 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001290 int off, i, slot, spi;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001291
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001292 if (regs[regno].type != PTR_TO_STACK) {
Edward Creef1174f72017-08-07 15:26:19 +01001293 /* Allow zero-byte read from NULL, regardless of pointer type */
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001294 if (zero_size_allowed && access_size == 0 &&
Edward Creef1174f72017-08-07 15:26:19 +01001295 register_is_null(regs[regno]))
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001296 return 0;
1297
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001298 verbose(env, "R%d type=%s expected=%s\n", regno,
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001299 reg_type_str[regs[regno].type],
1300 reg_type_str[PTR_TO_STACK]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001301 return -EACCES;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001302 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001303
Edward Creef1174f72017-08-07 15:26:19 +01001304 /* Only allow fixed-offset stack reads */
1305 if (!tnum_is_const(regs[regno].var_off)) {
1306 char tn_buf[48];
1307
1308 tnum_strn(tn_buf, sizeof(tn_buf), regs[regno].var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001309 verbose(env, "invalid variable stack read R%d var_off=%s\n",
Edward Creef1174f72017-08-07 15:26:19 +01001310 regno, tn_buf);
Jann Hornea25f912017-12-18 20:11:57 -08001311 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01001312 }
1313 off = regs[regno].off + regs[regno].var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001314 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
Yonghong Song9fd29c02017-11-12 14:49:09 -08001315 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001316 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001317 regno, off, access_size);
1318 return -EACCES;
1319 }
1320
Alexei Starovoitov87266792017-05-30 13:31:29 -07001321 if (env->prog->aux->stack_depth < -off)
1322 env->prog->aux->stack_depth = -off;
1323
Daniel Borkmann435faee12016-04-13 00:10:51 +02001324 if (meta && meta->raw_mode) {
1325 meta->access_size = access_size;
1326 meta->regno = regno;
1327 return 0;
1328 }
1329
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001330 for (i = 0; i < access_size; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001331 slot = -(off + i) - 1;
1332 spi = slot / BPF_REG_SIZE;
1333 if (state->allocated_stack <= slot ||
1334 state->stack[spi].slot_type[slot % BPF_REG_SIZE] !=
1335 STACK_MISC) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001336 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001337 off, i, access_size);
1338 return -EACCES;
1339 }
1340 }
1341 return 0;
1342}
1343
Gianluca Borello06c1c042017-01-09 10:19:49 -08001344static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
1345 int access_size, bool zero_size_allowed,
1346 struct bpf_call_arg_meta *meta)
1347{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001348 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Gianluca Borello06c1c042017-01-09 10:19:49 -08001349
Edward Creef1174f72017-08-07 15:26:19 +01001350 switch (reg->type) {
Gianluca Borello06c1c042017-01-09 10:19:49 -08001351 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001352 case PTR_TO_PACKET_META:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001353 return check_packet_access(env, regno, reg->off, access_size,
1354 zero_size_allowed);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001355 case PTR_TO_MAP_VALUE:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001356 return check_map_access(env, regno, reg->off, access_size,
1357 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001358 default: /* scalar_value|ptr_to_stack or invalid ptr */
Gianluca Borello06c1c042017-01-09 10:19:49 -08001359 return check_stack_boundary(env, regno, access_size,
1360 zero_size_allowed, meta);
1361 }
1362}
1363
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001364static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001365 enum bpf_arg_type arg_type,
1366 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001367{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001368 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001369 enum bpf_reg_type expected_type, type = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001370 int err = 0;
1371
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001372 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001373 return 0;
1374
Edward Creedc503a82017-08-15 20:34:35 +01001375 err = check_reg_arg(env, regno, SRC_OP);
1376 if (err)
1377 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001378
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001379 if (arg_type == ARG_ANYTHING) {
1380 if (is_pointer_value(env, regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001381 verbose(env, "R%d leaks addr into helper function\n",
1382 regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001383 return -EACCES;
1384 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001385 return 0;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001386 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001387
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001388 if (type_is_pkt_pointer(type) &&
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001389 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001390 verbose(env, "helper access to the packet is not allowed\n");
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001391 return -EACCES;
1392 }
1393
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001394 if (arg_type == ARG_PTR_TO_MAP_KEY ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001395 arg_type == ARG_PTR_TO_MAP_VALUE) {
1396 expected_type = PTR_TO_STACK;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001397 if (!type_is_pkt_pointer(type) &&
1398 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001399 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001400 } else if (arg_type == ARG_CONST_SIZE ||
1401 arg_type == ARG_CONST_SIZE_OR_ZERO) {
Edward Creef1174f72017-08-07 15:26:19 +01001402 expected_type = SCALAR_VALUE;
1403 if (type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001404 goto err_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001405 } else if (arg_type == ARG_CONST_MAP_PTR) {
1406 expected_type = CONST_PTR_TO_MAP;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001407 if (type != expected_type)
1408 goto err_type;
Alexei Starovoitov608cd712015-03-26 19:53:57 -07001409 } else if (arg_type == ARG_PTR_TO_CTX) {
1410 expected_type = PTR_TO_CTX;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001411 if (type != expected_type)
1412 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001413 } else if (arg_type == ARG_PTR_TO_MEM ||
Gianluca Borellodb1ac492017-11-22 18:32:53 +00001414 arg_type == ARG_PTR_TO_MEM_OR_NULL ||
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001415 arg_type == ARG_PTR_TO_UNINIT_MEM) {
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001416 expected_type = PTR_TO_STACK;
1417 /* One exception here. In case function allows for NULL to be
Edward Creef1174f72017-08-07 15:26:19 +01001418 * passed in as argument, it's a SCALAR_VALUE type. Final test
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001419 * happens during stack boundary checking.
1420 */
Gianluca Borellodb1ac492017-11-22 18:32:53 +00001421 if (register_is_null(*reg) &&
1422 arg_type == ARG_PTR_TO_MEM_OR_NULL)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001423 /* final test in check_stack_boundary() */;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001424 else if (!type_is_pkt_pointer(type) &&
1425 type != PTR_TO_MAP_VALUE &&
Edward Creef1174f72017-08-07 15:26:19 +01001426 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001427 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001428 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001429 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001430 verbose(env, "unsupported arg_type %d\n", arg_type);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001431 return -EFAULT;
1432 }
1433
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001434 if (arg_type == ARG_CONST_MAP_PTR) {
1435 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001436 meta->map_ptr = reg->map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001437 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
1438 /* bpf_map_xxx(..., map_ptr, ..., key) call:
1439 * check that [key, key + map->key_size) are within
1440 * stack limits and initialized
1441 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001442 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001443 /* in function declaration map_ptr must come before
1444 * map_key, so that it's verified and known before
1445 * we have to check map_key here. Otherwise it means
1446 * that kernel subsystem misconfigured verifier
1447 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001448 verbose(env, "invalid map_ptr to access map->key\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001449 return -EACCES;
1450 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001451 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001452 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001453 meta->map_ptr->key_size,
1454 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001455 else
1456 err = check_stack_boundary(env, regno,
1457 meta->map_ptr->key_size,
1458 false, NULL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001459 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
1460 /* bpf_map_xxx(..., map_ptr, ..., value) call:
1461 * check [value, value + map->value_size) validity
1462 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001463 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001464 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001465 verbose(env, "invalid map_ptr to access map->value\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001466 return -EACCES;
1467 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001468 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001469 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001470 meta->map_ptr->value_size,
1471 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001472 else
1473 err = check_stack_boundary(env, regno,
1474 meta->map_ptr->value_size,
1475 false, NULL);
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001476 } else if (arg_type == ARG_CONST_SIZE ||
1477 arg_type == ARG_CONST_SIZE_OR_ZERO) {
1478 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001479
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001480 /* bpf_xxx(..., buf, len) call will access 'len' bytes
1481 * from stack pointer 'buf'. Check it
1482 * note: regno == len, regno - 1 == buf
1483 */
1484 if (regno == 0) {
1485 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001486 verbose(env,
1487 "ARG_CONST_SIZE cannot be first argument\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001488 return -EACCES;
1489 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001490
Edward Creef1174f72017-08-07 15:26:19 +01001491 /* The register is SCALAR_VALUE; the access check
1492 * happens using its boundaries.
Gianluca Borello06c1c042017-01-09 10:19:49 -08001493 */
Edward Creef1174f72017-08-07 15:26:19 +01001494
1495 if (!tnum_is_const(reg->var_off))
Gianluca Borello06c1c042017-01-09 10:19:49 -08001496 /* For unprivileged variable accesses, disable raw
1497 * mode so that the program is required to
1498 * initialize all the memory that the helper could
1499 * just partially fill up.
1500 */
1501 meta = NULL;
1502
Edward Creeb03c9f92017-08-07 15:26:36 +01001503 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001504 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
Edward Creef1174f72017-08-07 15:26:19 +01001505 regno);
1506 return -EACCES;
1507 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001508
Edward Creeb03c9f92017-08-07 15:26:36 +01001509 if (reg->umin_value == 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001510 err = check_helper_mem_access(env, regno - 1, 0,
1511 zero_size_allowed,
1512 meta);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001513 if (err)
1514 return err;
Gianluca Borello06c1c042017-01-09 10:19:49 -08001515 }
Edward Creef1174f72017-08-07 15:26:19 +01001516
Edward Creeb03c9f92017-08-07 15:26:36 +01001517 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001518 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
Edward Creef1174f72017-08-07 15:26:19 +01001519 regno);
1520 return -EACCES;
1521 }
1522 err = check_helper_mem_access(env, regno - 1,
Edward Creeb03c9f92017-08-07 15:26:36 +01001523 reg->umax_value,
Edward Creef1174f72017-08-07 15:26:19 +01001524 zero_size_allowed, meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001525 }
1526
1527 return err;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001528err_type:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001529 verbose(env, "R%d type=%s expected=%s\n", regno,
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001530 reg_type_str[type], reg_type_str[expected_type]);
1531 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001532}
1533
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001534static int check_map_func_compatibility(struct bpf_verifier_env *env,
1535 struct bpf_map *map, int func_id)
Kaixu Xia35578d72015-08-06 07:02:35 +00001536{
Kaixu Xia35578d72015-08-06 07:02:35 +00001537 if (!map)
1538 return 0;
1539
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001540 /* We need a two way check, first is from map perspective ... */
1541 switch (map->map_type) {
1542 case BPF_MAP_TYPE_PROG_ARRAY:
1543 if (func_id != BPF_FUNC_tail_call)
1544 goto error;
1545 break;
1546 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
1547 if (func_id != BPF_FUNC_perf_event_read &&
Yonghong Song908432c2017-10-05 09:19:20 -07001548 func_id != BPF_FUNC_perf_event_output &&
1549 func_id != BPF_FUNC_perf_event_read_value)
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001550 goto error;
1551 break;
1552 case BPF_MAP_TYPE_STACK_TRACE:
1553 if (func_id != BPF_FUNC_get_stackid)
1554 goto error;
1555 break;
Martin KaFai Lau4ed8ec52016-06-30 10:28:43 -07001556 case BPF_MAP_TYPE_CGROUP_ARRAY:
David S. Miller60747ef2016-08-18 01:17:32 -04001557 if (func_id != BPF_FUNC_skb_under_cgroup &&
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001558 func_id != BPF_FUNC_current_task_under_cgroup)
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001559 goto error;
1560 break;
John Fastabend546ac1f2017-07-17 09:28:56 -07001561 /* devmap returns a pointer to a live net_device ifindex that we cannot
1562 * allow to be modified from bpf side. So do not allow lookup elements
1563 * for now.
1564 */
1565 case BPF_MAP_TYPE_DEVMAP:
John Fastabend2ddf71e2017-07-17 09:30:02 -07001566 if (func_id != BPF_FUNC_redirect_map)
John Fastabend546ac1f2017-07-17 09:28:56 -07001567 goto error;
1568 break;
Jesper Dangaard Brouer6710e112017-10-16 12:19:28 +02001569 /* Restrict bpf side of cpumap, open when use-cases appear */
1570 case BPF_MAP_TYPE_CPUMAP:
1571 if (func_id != BPF_FUNC_redirect_map)
1572 goto error;
1573 break;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07001574 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07001575 case BPF_MAP_TYPE_HASH_OF_MAPS:
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07001576 if (func_id != BPF_FUNC_map_lookup_elem)
1577 goto error;
Martin KaFai Lau16a43622017-08-17 18:14:43 -07001578 break;
John Fastabend174a79f2017-08-15 22:32:47 -07001579 case BPF_MAP_TYPE_SOCKMAP:
1580 if (func_id != BPF_FUNC_sk_redirect_map &&
1581 func_id != BPF_FUNC_sock_map_update &&
1582 func_id != BPF_FUNC_map_delete_elem)
1583 goto error;
1584 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001585 default:
1586 break;
1587 }
1588
1589 /* ... and second from the function itself. */
1590 switch (func_id) {
1591 case BPF_FUNC_tail_call:
1592 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
1593 goto error;
1594 break;
1595 case BPF_FUNC_perf_event_read:
1596 case BPF_FUNC_perf_event_output:
Yonghong Song908432c2017-10-05 09:19:20 -07001597 case BPF_FUNC_perf_event_read_value:
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001598 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
1599 goto error;
1600 break;
1601 case BPF_FUNC_get_stackid:
1602 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
1603 goto error;
1604 break;
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001605 case BPF_FUNC_current_task_under_cgroup:
Daniel Borkmann747ea552016-08-12 22:17:17 +02001606 case BPF_FUNC_skb_under_cgroup:
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001607 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
1608 goto error;
1609 break;
John Fastabend97f91a72017-07-17 09:29:18 -07001610 case BPF_FUNC_redirect_map:
Jesper Dangaard Brouer9c270af2017-10-16 12:19:34 +02001611 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
1612 map->map_type != BPF_MAP_TYPE_CPUMAP)
John Fastabend97f91a72017-07-17 09:29:18 -07001613 goto error;
1614 break;
John Fastabend174a79f2017-08-15 22:32:47 -07001615 case BPF_FUNC_sk_redirect_map:
1616 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
1617 goto error;
1618 break;
1619 case BPF_FUNC_sock_map_update:
1620 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
1621 goto error;
1622 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001623 default:
1624 break;
Kaixu Xia35578d72015-08-06 07:02:35 +00001625 }
1626
1627 return 0;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001628error:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001629 verbose(env, "cannot pass map_type %d into func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001630 map->map_type, func_id_name(func_id), func_id);
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001631 return -EINVAL;
Kaixu Xia35578d72015-08-06 07:02:35 +00001632}
1633
Daniel Borkmann435faee12016-04-13 00:10:51 +02001634static int check_raw_mode(const struct bpf_func_proto *fn)
1635{
1636 int count = 0;
1637
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001638 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001639 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001640 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001641 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001642 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001643 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001644 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001645 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001646 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001647 count++;
1648
1649 return count > 1 ? -EINVAL : 0;
1650}
1651
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001652/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
1653 * are now invalid, so turn them into unknown SCALAR_VALUE.
Edward Creef1174f72017-08-07 15:26:19 +01001654 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001655static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001656{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001657 struct bpf_verifier_state *state = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001658 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001659 int i;
1660
1661 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001662 if (reg_is_pkt_pointer_any(&regs[i]))
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001663 mark_reg_unknown(env, regs, i);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001664
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001665 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
1666 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001667 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001668 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001669 if (reg_is_pkt_pointer_any(reg))
1670 __mark_reg_unknown(reg);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001671 }
1672}
1673
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07001674static int check_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001675{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001676 const struct bpf_func_proto *fn = NULL;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001677 struct bpf_reg_state *regs;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001678 struct bpf_call_arg_meta meta;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001679 bool changes_data;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001680 int i, err;
1681
1682 /* find function prototype */
1683 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001684 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
1685 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001686 return -EINVAL;
1687 }
1688
Jakub Kicinski00176a32017-10-16 16:40:54 -07001689 if (env->ops->get_func_proto)
1690 fn = env->ops->get_func_proto(func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001691
1692 if (!fn) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001693 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
1694 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001695 return -EINVAL;
1696 }
1697
1698 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +01001699 if (!env->prog->gpl_compatible && fn->gpl_only) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001700 verbose(env, "cannot call GPL only function from proprietary program\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001701 return -EINVAL;
1702 }
1703
Daniel Borkmann04514d12017-12-14 21:07:25 +01001704 /* With LD_ABS/IND some JITs save/restore skb from r1. */
Martin KaFai Lau17bedab2016-12-07 15:53:11 -08001705 changes_data = bpf_helper_changes_pkt_data(fn->func);
Daniel Borkmann04514d12017-12-14 21:07:25 +01001706 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
1707 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
1708 func_id_name(func_id), func_id);
1709 return -EINVAL;
1710 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001711
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001712 memset(&meta, 0, sizeof(meta));
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001713 meta.pkt_access = fn->pkt_access;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001714
Daniel Borkmann435faee12016-04-13 00:10:51 +02001715 /* We only support one arg being in raw mode at the moment, which
1716 * is sufficient for the helper functions we have right now.
1717 */
1718 err = check_raw_mode(fn);
1719 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001720 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001721 func_id_name(func_id), func_id);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001722 return err;
1723 }
1724
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001725 /* check args */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001726 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001727 if (err)
1728 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001729 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001730 if (err)
1731 return err;
Alexei Starovoitovb2157392018-01-07 17:33:02 -08001732 if (func_id == BPF_FUNC_tail_call) {
1733 if (meta.map_ptr == NULL) {
1734 verbose(env, "verifier bug\n");
1735 return -EINVAL;
1736 }
1737 env->insn_aux_data[insn_idx].map_ptr = meta.map_ptr;
1738 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001739 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001740 if (err)
1741 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001742 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001743 if (err)
1744 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001745 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001746 if (err)
1747 return err;
1748
Daniel Borkmann435faee12016-04-13 00:10:51 +02001749 /* Mark slots with STACK_MISC in case of raw mode, stack offset
1750 * is inferred from register state.
1751 */
1752 for (i = 0; i < meta.access_size; i++) {
Yonghong Song31fd8582017-06-13 15:52:13 -07001753 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B, BPF_WRITE, -1);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001754 if (err)
1755 return err;
1756 }
1757
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001758 regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001759 /* reset caller saved regs */
Edward Creedc503a82017-08-15 20:34:35 +01001760 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001761 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01001762 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
1763 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001764
Edward Creedc503a82017-08-15 20:34:35 +01001765 /* update return register (already marked as written above) */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001766 if (fn->ret_type == RET_INTEGER) {
Edward Creef1174f72017-08-07 15:26:19 +01001767 /* sets type to SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001768 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001769 } else if (fn->ret_type == RET_VOID) {
1770 regs[BPF_REG_0].type = NOT_INIT;
1771 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
Martin KaFai Laufad73a12017-03-22 10:00:32 -07001772 struct bpf_insn_aux_data *insn_aux;
1773
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001774 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
Edward Creef1174f72017-08-07 15:26:19 +01001775 /* There is no offset yet applied, variable or fixed */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001776 mark_reg_known_zero(env, regs, BPF_REG_0);
Edward Creef1174f72017-08-07 15:26:19 +01001777 regs[BPF_REG_0].off = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001778 /* remember map_ptr, so that check_map_access()
1779 * can check 'value_size' boundary of memory access
1780 * to map element returned from bpf_map_lookup_elem()
1781 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001782 if (meta.map_ptr == NULL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001783 verbose(env,
1784 "kernel subsystem misconfigured verifier\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001785 return -EINVAL;
1786 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001787 regs[BPF_REG_0].map_ptr = meta.map_ptr;
Thomas Graf57a09bf2016-10-18 19:51:19 +02001788 regs[BPF_REG_0].id = ++env->id_gen;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07001789 insn_aux = &env->insn_aux_data[insn_idx];
1790 if (!insn_aux->map_ptr)
1791 insn_aux->map_ptr = meta.map_ptr;
1792 else if (insn_aux->map_ptr != meta.map_ptr)
1793 insn_aux->map_ptr = BPF_MAP_PTR_POISON;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001794 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001795 verbose(env, "unknown return type %d of func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001796 fn->ret_type, func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001797 return -EINVAL;
1798 }
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001799
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001800 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
Kaixu Xia35578d72015-08-06 07:02:35 +00001801 if (err)
1802 return err;
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001803
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001804 if (changes_data)
1805 clear_all_pkt_pointers(env);
1806 return 0;
1807}
1808
Edward Creeb03c9f92017-08-07 15:26:36 +01001809static bool signed_add_overflows(s64 a, s64 b)
1810{
1811 /* Do the add in u64, where overflow is well-defined */
1812 s64 res = (s64)((u64)a + (u64)b);
1813
1814 if (b < 0)
1815 return res > a;
1816 return res < a;
1817}
1818
1819static bool signed_sub_overflows(s64 a, s64 b)
1820{
1821 /* Do the sub in u64, where overflow is well-defined */
1822 s64 res = (s64)((u64)a - (u64)b);
1823
1824 if (b < 0)
1825 return res < a;
1826 return res > a;
David S. Millerd1174412017-05-10 11:22:52 -07001827}
1828
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08001829static bool check_reg_sane_offset(struct bpf_verifier_env *env,
1830 const struct bpf_reg_state *reg,
1831 enum bpf_reg_type type)
1832{
1833 bool known = tnum_is_const(reg->var_off);
1834 s64 val = reg->var_off.value;
1835 s64 smin = reg->smin_value;
1836
1837 if (known && (val >= BPF_MAX_VAR_OFF || val <= -BPF_MAX_VAR_OFF)) {
1838 verbose(env, "math between %s pointer and %lld is not allowed\n",
1839 reg_type_str[type], val);
1840 return false;
1841 }
1842
1843 if (reg->off >= BPF_MAX_VAR_OFF || reg->off <= -BPF_MAX_VAR_OFF) {
1844 verbose(env, "%s pointer offset %d is not allowed\n",
1845 reg_type_str[type], reg->off);
1846 return false;
1847 }
1848
1849 if (smin == S64_MIN) {
1850 verbose(env, "math between %s pointer and register with unbounded min value is not allowed\n",
1851 reg_type_str[type]);
1852 return false;
1853 }
1854
1855 if (smin >= BPF_MAX_VAR_OFF || smin <= -BPF_MAX_VAR_OFF) {
1856 verbose(env, "value %lld makes %s pointer be out of bounds\n",
1857 smin, reg_type_str[type]);
1858 return false;
1859 }
1860
1861 return true;
1862}
1863
Edward Creef1174f72017-08-07 15:26:19 +01001864/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
Edward Creef1174f72017-08-07 15:26:19 +01001865 * Caller should also handle BPF_MOV case separately.
1866 * If we return -EACCES, caller may want to try again treating pointer as a
1867 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
1868 */
1869static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
1870 struct bpf_insn *insn,
1871 const struct bpf_reg_state *ptr_reg,
1872 const struct bpf_reg_state *off_reg)
Josef Bacik48461132016-09-28 10:54:32 -04001873{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001874 struct bpf_reg_state *regs = cur_regs(env), *dst_reg;
Edward Creef1174f72017-08-07 15:26:19 +01001875 bool known = tnum_is_const(off_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01001876 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
1877 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
1878 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
1879 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
Josef Bacik48461132016-09-28 10:54:32 -04001880 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01001881 u32 dst = insn->dst_reg;
Josef Bacik48461132016-09-28 10:54:32 -04001882
Edward Creef1174f72017-08-07 15:26:19 +01001883 dst_reg = &regs[dst];
Josef Bacik48461132016-09-28 10:54:32 -04001884
Edward Creeb03c9f92017-08-07 15:26:36 +01001885 if (WARN_ON_ONCE(known && (smin_val != smax_val))) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001886 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001887 verbose(env,
1888 "verifier internal error: known but bad sbounds\n");
Edward Creeb03c9f92017-08-07 15:26:36 +01001889 return -EINVAL;
1890 }
1891 if (WARN_ON_ONCE(known && (umin_val != umax_val))) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001892 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001893 verbose(env,
1894 "verifier internal error: known but bad ubounds\n");
Edward Creef1174f72017-08-07 15:26:19 +01001895 return -EINVAL;
Josef Bacik48461132016-09-28 10:54:32 -04001896 }
1897
Edward Creef1174f72017-08-07 15:26:19 +01001898 if (BPF_CLASS(insn->code) != BPF_ALU64) {
1899 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08001900 verbose(env,
1901 "R%d 32-bit pointer arithmetic prohibited\n",
1902 dst);
Edward Creef1174f72017-08-07 15:26:19 +01001903 return -EACCES;
1904 }
David S. Millerd1174412017-05-10 11:22:52 -07001905
Edward Creef1174f72017-08-07 15:26:19 +01001906 if (ptr_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08001907 verbose(env, "R%d pointer arithmetic on PTR_TO_MAP_VALUE_OR_NULL prohibited, null-check it first\n",
1908 dst);
Edward Creef1174f72017-08-07 15:26:19 +01001909 return -EACCES;
1910 }
1911 if (ptr_reg->type == CONST_PTR_TO_MAP) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08001912 verbose(env, "R%d pointer arithmetic on CONST_PTR_TO_MAP prohibited\n",
1913 dst);
Edward Creef1174f72017-08-07 15:26:19 +01001914 return -EACCES;
1915 }
1916 if (ptr_reg->type == PTR_TO_PACKET_END) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08001917 verbose(env, "R%d pointer arithmetic on PTR_TO_PACKET_END prohibited\n",
1918 dst);
Edward Creef1174f72017-08-07 15:26:19 +01001919 return -EACCES;
1920 }
1921
1922 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
1923 * The id may be overwritten later if we create a new variable offset.
Josef Bacik48461132016-09-28 10:54:32 -04001924 */
Edward Creef1174f72017-08-07 15:26:19 +01001925 dst_reg->type = ptr_reg->type;
1926 dst_reg->id = ptr_reg->id;
Josef Bacikf23cc642016-11-14 15:45:36 -05001927
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08001928 if (!check_reg_sane_offset(env, off_reg, ptr_reg->type) ||
1929 !check_reg_sane_offset(env, ptr_reg, ptr_reg->type))
1930 return -EINVAL;
1931
Josef Bacik48461132016-09-28 10:54:32 -04001932 switch (opcode) {
1933 case BPF_ADD:
Edward Creef1174f72017-08-07 15:26:19 +01001934 /* We can take a fixed offset as long as it doesn't overflow
1935 * the s32 'off' field
1936 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001937 if (known && (ptr_reg->off + smin_val ==
1938 (s64)(s32)(ptr_reg->off + smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01001939 /* pointer += K. Accumulate it into fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01001940 dst_reg->smin_value = smin_ptr;
1941 dst_reg->smax_value = smax_ptr;
1942 dst_reg->umin_value = umin_ptr;
1943 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01001944 dst_reg->var_off = ptr_reg->var_off;
Edward Creeb03c9f92017-08-07 15:26:36 +01001945 dst_reg->off = ptr_reg->off + smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01001946 dst_reg->range = ptr_reg->range;
1947 break;
1948 }
Edward Creef1174f72017-08-07 15:26:19 +01001949 /* A new variable offset is created. Note that off_reg->off
1950 * == 0, since it's a scalar.
1951 * dst_reg gets the pointer type and since some positive
1952 * integer value was added to the pointer, give it a new 'id'
1953 * if it's a PTR_TO_PACKET.
1954 * this creates a new 'base' pointer, off_reg (variable) gets
1955 * added into the variable offset, and we copy the fixed offset
1956 * from ptr_reg.
1957 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001958 if (signed_add_overflows(smin_ptr, smin_val) ||
1959 signed_add_overflows(smax_ptr, smax_val)) {
1960 dst_reg->smin_value = S64_MIN;
1961 dst_reg->smax_value = S64_MAX;
1962 } else {
1963 dst_reg->smin_value = smin_ptr + smin_val;
1964 dst_reg->smax_value = smax_ptr + smax_val;
1965 }
1966 if (umin_ptr + umin_val < umin_ptr ||
1967 umax_ptr + umax_val < umax_ptr) {
1968 dst_reg->umin_value = 0;
1969 dst_reg->umax_value = U64_MAX;
1970 } else {
1971 dst_reg->umin_value = umin_ptr + umin_val;
1972 dst_reg->umax_value = umax_ptr + umax_val;
1973 }
Edward Creef1174f72017-08-07 15:26:19 +01001974 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
1975 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001976 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01001977 dst_reg->id = ++env->id_gen;
1978 /* something was added to pkt_ptr, set range to zero */
1979 dst_reg->range = 0;
1980 }
Josef Bacik48461132016-09-28 10:54:32 -04001981 break;
1982 case BPF_SUB:
Edward Creef1174f72017-08-07 15:26:19 +01001983 if (dst_reg == off_reg) {
1984 /* scalar -= pointer. Creates an unknown scalar */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08001985 verbose(env, "R%d tried to subtract pointer from scalar\n",
1986 dst);
Edward Creef1174f72017-08-07 15:26:19 +01001987 return -EACCES;
1988 }
1989 /* We don't allow subtraction from FP, because (according to
1990 * test_verifier.c test "invalid fp arithmetic", JITs might not
1991 * be able to deal with it.
Edward Cree93057062017-07-21 14:37:34 +01001992 */
Edward Creef1174f72017-08-07 15:26:19 +01001993 if (ptr_reg->type == PTR_TO_STACK) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08001994 verbose(env, "R%d subtraction from stack pointer prohibited\n",
1995 dst);
Edward Creef1174f72017-08-07 15:26:19 +01001996 return -EACCES;
1997 }
Edward Creeb03c9f92017-08-07 15:26:36 +01001998 if (known && (ptr_reg->off - smin_val ==
1999 (s64)(s32)(ptr_reg->off - smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01002000 /* pointer -= K. Subtract it from fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01002001 dst_reg->smin_value = smin_ptr;
2002 dst_reg->smax_value = smax_ptr;
2003 dst_reg->umin_value = umin_ptr;
2004 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01002005 dst_reg->var_off = ptr_reg->var_off;
2006 dst_reg->id = ptr_reg->id;
Edward Creeb03c9f92017-08-07 15:26:36 +01002007 dst_reg->off = ptr_reg->off - smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01002008 dst_reg->range = ptr_reg->range;
2009 break;
2010 }
Edward Creef1174f72017-08-07 15:26:19 +01002011 /* A new variable offset is created. If the subtrahend is known
2012 * nonnegative, then any reg->range we had before is still good.
2013 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002014 if (signed_sub_overflows(smin_ptr, smax_val) ||
2015 signed_sub_overflows(smax_ptr, smin_val)) {
2016 /* Overflow possible, we know nothing */
2017 dst_reg->smin_value = S64_MIN;
2018 dst_reg->smax_value = S64_MAX;
2019 } else {
2020 dst_reg->smin_value = smin_ptr - smax_val;
2021 dst_reg->smax_value = smax_ptr - smin_val;
2022 }
2023 if (umin_ptr < umax_val) {
2024 /* Overflow possible, we know nothing */
2025 dst_reg->umin_value = 0;
2026 dst_reg->umax_value = U64_MAX;
2027 } else {
2028 /* Cannot overflow (as long as bounds are consistent) */
2029 dst_reg->umin_value = umin_ptr - umax_val;
2030 dst_reg->umax_value = umax_ptr - umin_val;
2031 }
Edward Creef1174f72017-08-07 15:26:19 +01002032 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
2033 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002034 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01002035 dst_reg->id = ++env->id_gen;
2036 /* something was added to pkt_ptr, set range to zero */
Edward Creeb03c9f92017-08-07 15:26:36 +01002037 if (smin_val < 0)
Edward Creef1174f72017-08-07 15:26:19 +01002038 dst_reg->range = 0;
2039 }
2040 break;
2041 case BPF_AND:
2042 case BPF_OR:
2043 case BPF_XOR:
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002044 /* bitwise ops on pointers are troublesome, prohibit. */
2045 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
2046 dst, bpf_alu_string[opcode >> 4]);
Edward Creef1174f72017-08-07 15:26:19 +01002047 return -EACCES;
2048 default:
2049 /* other operators (e.g. MUL,LSH) produce non-pointer results */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002050 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
2051 dst, bpf_alu_string[opcode >> 4]);
Edward Creef1174f72017-08-07 15:26:19 +01002052 return -EACCES;
2053 }
2054
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002055 if (!check_reg_sane_offset(env, dst_reg, ptr_reg->type))
2056 return -EINVAL;
2057
Edward Creeb03c9f92017-08-07 15:26:36 +01002058 __update_reg_bounds(dst_reg);
2059 __reg_deduce_bounds(dst_reg);
2060 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002061 return 0;
2062}
2063
Jann Horn468f6ea2017-12-18 20:11:56 -08002064/* WARNING: This function does calculations on 64-bit values, but the actual
2065 * execution may occur on 32-bit values. Therefore, things like bitshifts
2066 * need extra checks in the 32-bit case.
2067 */
Edward Creef1174f72017-08-07 15:26:19 +01002068static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
2069 struct bpf_insn *insn,
2070 struct bpf_reg_state *dst_reg,
2071 struct bpf_reg_state src_reg)
2072{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002073 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +01002074 u8 opcode = BPF_OP(insn->code);
2075 bool src_known, dst_known;
Edward Creeb03c9f92017-08-07 15:26:36 +01002076 s64 smin_val, smax_val;
2077 u64 umin_val, umax_val;
Jann Horn468f6ea2017-12-18 20:11:56 -08002078 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
Edward Creef1174f72017-08-07 15:26:19 +01002079
Edward Creeb03c9f92017-08-07 15:26:36 +01002080 smin_val = src_reg.smin_value;
2081 smax_val = src_reg.smax_value;
2082 umin_val = src_reg.umin_value;
2083 umax_val = src_reg.umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002084 src_known = tnum_is_const(src_reg.var_off);
2085 dst_known = tnum_is_const(dst_reg->var_off);
2086
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002087 if (!src_known &&
2088 opcode != BPF_ADD && opcode != BPF_SUB && opcode != BPF_AND) {
2089 __mark_reg_unknown(dst_reg);
2090 return 0;
2091 }
2092
Edward Creef1174f72017-08-07 15:26:19 +01002093 switch (opcode) {
2094 case BPF_ADD:
Edward Creeb03c9f92017-08-07 15:26:36 +01002095 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
2096 signed_add_overflows(dst_reg->smax_value, smax_val)) {
2097 dst_reg->smin_value = S64_MIN;
2098 dst_reg->smax_value = S64_MAX;
2099 } else {
2100 dst_reg->smin_value += smin_val;
2101 dst_reg->smax_value += smax_val;
2102 }
2103 if (dst_reg->umin_value + umin_val < umin_val ||
2104 dst_reg->umax_value + umax_val < umax_val) {
2105 dst_reg->umin_value = 0;
2106 dst_reg->umax_value = U64_MAX;
2107 } else {
2108 dst_reg->umin_value += umin_val;
2109 dst_reg->umax_value += umax_val;
2110 }
Edward Creef1174f72017-08-07 15:26:19 +01002111 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
2112 break;
2113 case BPF_SUB:
Edward Creeb03c9f92017-08-07 15:26:36 +01002114 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
2115 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
2116 /* Overflow possible, we know nothing */
2117 dst_reg->smin_value = S64_MIN;
2118 dst_reg->smax_value = S64_MAX;
2119 } else {
2120 dst_reg->smin_value -= smax_val;
2121 dst_reg->smax_value -= smin_val;
2122 }
2123 if (dst_reg->umin_value < umax_val) {
2124 /* Overflow possible, we know nothing */
2125 dst_reg->umin_value = 0;
2126 dst_reg->umax_value = U64_MAX;
2127 } else {
2128 /* Cannot overflow (as long as bounds are consistent) */
2129 dst_reg->umin_value -= umax_val;
2130 dst_reg->umax_value -= umin_val;
2131 }
Edward Creef1174f72017-08-07 15:26:19 +01002132 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
Josef Bacik48461132016-09-28 10:54:32 -04002133 break;
2134 case BPF_MUL:
Edward Creeb03c9f92017-08-07 15:26:36 +01002135 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
2136 if (smin_val < 0 || dst_reg->smin_value < 0) {
Edward Creef1174f72017-08-07 15:26:19 +01002137 /* Ain't nobody got time to multiply that sign */
Edward Creeb03c9f92017-08-07 15:26:36 +01002138 __mark_reg_unbounded(dst_reg);
2139 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002140 break;
2141 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002142 /* Both values are positive, so we can work with unsigned and
2143 * copy the result to signed (unless it exceeds S64_MAX).
Edward Creef1174f72017-08-07 15:26:19 +01002144 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002145 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
2146 /* Potential overflow, we know nothing */
2147 __mark_reg_unbounded(dst_reg);
2148 /* (except what we can learn from the var_off) */
2149 __update_reg_bounds(dst_reg);
2150 break;
2151 }
2152 dst_reg->umin_value *= umin_val;
2153 dst_reg->umax_value *= umax_val;
2154 if (dst_reg->umax_value > S64_MAX) {
2155 /* Overflow possible, we know nothing */
2156 dst_reg->smin_value = S64_MIN;
2157 dst_reg->smax_value = S64_MAX;
2158 } else {
2159 dst_reg->smin_value = dst_reg->umin_value;
2160 dst_reg->smax_value = dst_reg->umax_value;
2161 }
Josef Bacik48461132016-09-28 10:54:32 -04002162 break;
2163 case BPF_AND:
Edward Creef1174f72017-08-07 15:26:19 +01002164 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002165 __mark_reg_known(dst_reg, dst_reg->var_off.value &
2166 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002167 break;
2168 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002169 /* We get our minimum from the var_off, since that's inherently
2170 * bitwise. Our maximum is the minimum of the operands' maxima.
Josef Bacikf23cc642016-11-14 15:45:36 -05002171 */
Edward Creef1174f72017-08-07 15:26:19 +01002172 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002173 dst_reg->umin_value = dst_reg->var_off.value;
2174 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
2175 if (dst_reg->smin_value < 0 || smin_val < 0) {
2176 /* Lose signed bounds when ANDing negative numbers,
2177 * ain't nobody got time for that.
2178 */
2179 dst_reg->smin_value = S64_MIN;
2180 dst_reg->smax_value = S64_MAX;
2181 } else {
2182 /* ANDing two positives gives a positive, so safe to
2183 * cast result into s64.
2184 */
2185 dst_reg->smin_value = dst_reg->umin_value;
2186 dst_reg->smax_value = dst_reg->umax_value;
2187 }
2188 /* We may learn something more from the var_off */
2189 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002190 break;
2191 case BPF_OR:
2192 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002193 __mark_reg_known(dst_reg, dst_reg->var_off.value |
2194 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002195 break;
2196 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002197 /* We get our maximum from the var_off, and our minimum is the
2198 * maximum of the operands' minima
Edward Creef1174f72017-08-07 15:26:19 +01002199 */
2200 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002201 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
2202 dst_reg->umax_value = dst_reg->var_off.value |
2203 dst_reg->var_off.mask;
2204 if (dst_reg->smin_value < 0 || smin_val < 0) {
2205 /* Lose signed bounds when ORing negative numbers,
2206 * ain't nobody got time for that.
2207 */
2208 dst_reg->smin_value = S64_MIN;
2209 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002210 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002211 /* ORing two positives gives a positive, so safe to
2212 * cast result into s64.
2213 */
2214 dst_reg->smin_value = dst_reg->umin_value;
2215 dst_reg->smax_value = dst_reg->umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002216 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002217 /* We may learn something more from the var_off */
2218 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002219 break;
2220 case BPF_LSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002221 if (umax_val >= insn_bitness) {
2222 /* Shifts greater than 31 or 63 are undefined.
2223 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002224 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002225 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002226 break;
2227 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002228 /* We lose all sign bit information (except what we can pick
2229 * up from var_off)
Josef Bacik48461132016-09-28 10:54:32 -04002230 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002231 dst_reg->smin_value = S64_MIN;
2232 dst_reg->smax_value = S64_MAX;
2233 /* If we might shift our top bit out, then we know nothing */
2234 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
2235 dst_reg->umin_value = 0;
2236 dst_reg->umax_value = U64_MAX;
David S. Millerd1174412017-05-10 11:22:52 -07002237 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002238 dst_reg->umin_value <<= umin_val;
2239 dst_reg->umax_value <<= umax_val;
David S. Millerd1174412017-05-10 11:22:52 -07002240 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002241 if (src_known)
2242 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
2243 else
2244 dst_reg->var_off = tnum_lshift(tnum_unknown, umin_val);
2245 /* We may learn something more from the var_off */
2246 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002247 break;
2248 case BPF_RSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002249 if (umax_val >= insn_bitness) {
2250 /* Shifts greater than 31 or 63 are undefined.
2251 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002252 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002253 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002254 break;
2255 }
Edward Cree4374f252017-12-18 20:11:53 -08002256 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
2257 * be negative, then either:
2258 * 1) src_reg might be zero, so the sign bit of the result is
2259 * unknown, so we lose our signed bounds
2260 * 2) it's known negative, thus the unsigned bounds capture the
2261 * signed bounds
2262 * 3) the signed bounds cross zero, so they tell us nothing
2263 * about the result
2264 * If the value in dst_reg is known nonnegative, then again the
2265 * unsigned bounts capture the signed bounds.
2266 * Thus, in all cases it suffices to blow away our signed bounds
2267 * and rely on inferring new ones from the unsigned bounds and
2268 * var_off of the result.
2269 */
2270 dst_reg->smin_value = S64_MIN;
2271 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002272 if (src_known)
Edward Creeb03c9f92017-08-07 15:26:36 +01002273 dst_reg->var_off = tnum_rshift(dst_reg->var_off,
2274 umin_val);
Edward Creef1174f72017-08-07 15:26:19 +01002275 else
Edward Creeb03c9f92017-08-07 15:26:36 +01002276 dst_reg->var_off = tnum_rshift(tnum_unknown, umin_val);
2277 dst_reg->umin_value >>= umax_val;
2278 dst_reg->umax_value >>= umin_val;
2279 /* We may learn something more from the var_off */
2280 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002281 break;
2282 default:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002283 mark_reg_unknown(env, regs, insn->dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002284 break;
2285 }
2286
Jann Horn468f6ea2017-12-18 20:11:56 -08002287 if (BPF_CLASS(insn->code) != BPF_ALU64) {
2288 /* 32-bit ALU ops are (32,32)->32 */
2289 coerce_reg_to_size(dst_reg, 4);
2290 coerce_reg_to_size(&src_reg, 4);
2291 }
2292
Edward Creeb03c9f92017-08-07 15:26:36 +01002293 __reg_deduce_bounds(dst_reg);
2294 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002295 return 0;
2296}
2297
2298/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
2299 * and var_off.
2300 */
2301static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
2302 struct bpf_insn *insn)
2303{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002304 struct bpf_reg_state *regs = cur_regs(env), *dst_reg, *src_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002305 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
2306 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01002307
2308 dst_reg = &regs[insn->dst_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002309 src_reg = NULL;
2310 if (dst_reg->type != SCALAR_VALUE)
2311 ptr_reg = dst_reg;
2312 if (BPF_SRC(insn->code) == BPF_X) {
2313 src_reg = &regs[insn->src_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002314 if (src_reg->type != SCALAR_VALUE) {
2315 if (dst_reg->type != SCALAR_VALUE) {
2316 /* Combining two pointers by any ALU op yields
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002317 * an arbitrary scalar. Disallow all math except
2318 * pointer subtraction
Edward Creef1174f72017-08-07 15:26:19 +01002319 */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002320 if (opcode == BPF_SUB){
2321 mark_reg_unknown(env, regs, insn->dst_reg);
2322 return 0;
Edward Creef1174f72017-08-07 15:26:19 +01002323 }
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002324 verbose(env, "R%d pointer %s pointer prohibited\n",
2325 insn->dst_reg,
2326 bpf_alu_string[opcode >> 4]);
2327 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01002328 } else {
2329 /* scalar += pointer
2330 * This is legal, but we have to reverse our
2331 * src/dest handling in computing the range
2332 */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002333 return adjust_ptr_min_max_vals(env, insn,
2334 src_reg, dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002335 }
2336 } else if (ptr_reg) {
2337 /* pointer += scalar */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002338 return adjust_ptr_min_max_vals(env, insn,
2339 dst_reg, src_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002340 }
2341 } else {
2342 /* Pretend the src is a reg with a known value, since we only
2343 * need to be able to read from this state.
2344 */
2345 off_reg.type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01002346 __mark_reg_known(&off_reg, insn->imm);
Edward Creef1174f72017-08-07 15:26:19 +01002347 src_reg = &off_reg;
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002348 if (ptr_reg) /* pointer += K */
2349 return adjust_ptr_min_max_vals(env, insn,
2350 ptr_reg, src_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002351 }
2352
2353 /* Got here implies adding two SCALAR_VALUEs */
2354 if (WARN_ON_ONCE(ptr_reg)) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002355 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002356 verbose(env, "verifier internal error: unexpected ptr_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01002357 return -EINVAL;
2358 }
2359 if (WARN_ON(!src_reg)) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002360 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002361 verbose(env, "verifier internal error: no src_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01002362 return -EINVAL;
2363 }
2364 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002365}
2366
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002367/* check validity of 32-bit and 64-bit arithmetic operations */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002368static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002369{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002370 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002371 u8 opcode = BPF_OP(insn->code);
2372 int err;
2373
2374 if (opcode == BPF_END || opcode == BPF_NEG) {
2375 if (opcode == BPF_NEG) {
2376 if (BPF_SRC(insn->code) != 0 ||
2377 insn->src_reg != BPF_REG_0 ||
2378 insn->off != 0 || insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002379 verbose(env, "BPF_NEG uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002380 return -EINVAL;
2381 }
2382 } else {
2383 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
Edward Creee67b8a62017-09-15 14:37:38 +01002384 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
2385 BPF_CLASS(insn->code) == BPF_ALU64) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002386 verbose(env, "BPF_END uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002387 return -EINVAL;
2388 }
2389 }
2390
2391 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01002392 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002393 if (err)
2394 return err;
2395
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002396 if (is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002397 verbose(env, "R%d pointer arithmetic prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002398 insn->dst_reg);
2399 return -EACCES;
2400 }
2401
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002402 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002403 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002404 if (err)
2405 return err;
2406
2407 } else if (opcode == BPF_MOV) {
2408
2409 if (BPF_SRC(insn->code) == BPF_X) {
2410 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002411 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002412 return -EINVAL;
2413 }
2414
2415 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01002416 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002417 if (err)
2418 return err;
2419 } else {
2420 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002421 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002422 return -EINVAL;
2423 }
2424 }
2425
2426 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002427 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002428 if (err)
2429 return err;
2430
2431 if (BPF_SRC(insn->code) == BPF_X) {
2432 if (BPF_CLASS(insn->code) == BPF_ALU64) {
2433 /* case: R1 = R2
2434 * copy register state to dest reg
2435 */
2436 regs[insn->dst_reg] = regs[insn->src_reg];
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -07002437 regs[insn->dst_reg].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002438 } else {
Edward Creef1174f72017-08-07 15:26:19 +01002439 /* R1 = (u32) R2 */
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002440 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002441 verbose(env,
2442 "R%d partial copy of pointer\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002443 insn->src_reg);
2444 return -EACCES;
2445 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002446 mark_reg_unknown(env, regs, insn->dst_reg);
Jann Horn0c17d1d2017-12-18 20:11:55 -08002447 coerce_reg_to_size(&regs[insn->dst_reg], 4);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002448 }
2449 } else {
2450 /* case: R = imm
2451 * remember the value we stored into this reg
2452 */
Edward Creef1174f72017-08-07 15:26:19 +01002453 regs[insn->dst_reg].type = SCALAR_VALUE;
Jann Horn95a762e2017-12-18 20:11:54 -08002454 if (BPF_CLASS(insn->code) == BPF_ALU64) {
2455 __mark_reg_known(regs + insn->dst_reg,
2456 insn->imm);
2457 } else {
2458 __mark_reg_known(regs + insn->dst_reg,
2459 (u32)insn->imm);
2460 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002461 }
2462
2463 } else if (opcode > BPF_END) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002464 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002465 return -EINVAL;
2466
2467 } else { /* all other ALU ops: and, sub, xor, add, ... */
2468
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002469 if (BPF_SRC(insn->code) == BPF_X) {
2470 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002471 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002472 return -EINVAL;
2473 }
2474 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002475 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002476 if (err)
2477 return err;
2478 } else {
2479 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002480 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002481 return -EINVAL;
2482 }
2483 }
2484
2485 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002486 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002487 if (err)
2488 return err;
2489
2490 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
2491 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002492 verbose(env, "div by zero\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002493 return -EINVAL;
2494 }
2495
Daniel Borkmann7891a872018-01-10 20:04:37 +01002496 if (opcode == BPF_ARSH && BPF_CLASS(insn->code) != BPF_ALU64) {
2497 verbose(env, "BPF_ARSH not supported for 32 bit ALU\n");
2498 return -EINVAL;
2499 }
2500
Rabin Vincent229394e82016-01-12 20:17:08 +01002501 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
2502 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
2503 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
2504
2505 if (insn->imm < 0 || insn->imm >= size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002506 verbose(env, "invalid shift %d\n", insn->imm);
Rabin Vincent229394e82016-01-12 20:17:08 +01002507 return -EINVAL;
2508 }
2509 }
2510
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002511 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002512 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002513 if (err)
2514 return err;
2515
Edward Creef1174f72017-08-07 15:26:19 +01002516 return adjust_reg_min_max_vals(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002517 }
2518
2519 return 0;
2520}
2521
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002522static void find_good_pkt_pointers(struct bpf_verifier_state *state,
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002523 struct bpf_reg_state *dst_reg,
David S. Millerf8ddadc2017-10-22 13:36:53 +01002524 enum bpf_reg_type type,
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002525 bool range_right_open)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002526{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002527 struct bpf_reg_state *regs = state->regs, *reg;
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002528 u16 new_range;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002529 int i;
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002530
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002531 if (dst_reg->off < 0 ||
2532 (dst_reg->off == 0 && range_right_open))
Edward Creef1174f72017-08-07 15:26:19 +01002533 /* This doesn't give us any range */
2534 return;
2535
Edward Creeb03c9f92017-08-07 15:26:36 +01002536 if (dst_reg->umax_value > MAX_PACKET_OFF ||
2537 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
Edward Creef1174f72017-08-07 15:26:19 +01002538 /* Risk of overflow. For instance, ptr + (1<<63) may be less
2539 * than pkt_end, but that's because it's also less than pkt.
2540 */
2541 return;
2542
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002543 new_range = dst_reg->off;
2544 if (range_right_open)
2545 new_range--;
2546
2547 /* Examples for register markings:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002548 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002549 * pkt_data in dst register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002550 *
2551 * r2 = r3;
2552 * r2 += 8;
2553 * if (r2 > pkt_end) goto <handle exception>
2554 * <access okay>
2555 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002556 * r2 = r3;
2557 * r2 += 8;
2558 * if (r2 < pkt_end) goto <access okay>
2559 * <handle exception>
2560 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002561 * Where:
2562 * r2 == dst_reg, pkt_end == src_reg
2563 * r2=pkt(id=n,off=8,r=0)
2564 * r3=pkt(id=n,off=0,r=0)
2565 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002566 * pkt_data in src register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002567 *
2568 * r2 = r3;
2569 * r2 += 8;
2570 * if (pkt_end >= r2) goto <access okay>
2571 * <handle exception>
2572 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002573 * r2 = r3;
2574 * r2 += 8;
2575 * if (pkt_end <= r2) goto <handle exception>
2576 * <access okay>
2577 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002578 * Where:
2579 * pkt_end == dst_reg, r2 == src_reg
2580 * r2=pkt(id=n,off=8,r=0)
2581 * r3=pkt(id=n,off=0,r=0)
2582 *
2583 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002584 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
2585 * and [r3, r3 + 8-1) respectively is safe to access depending on
2586 * the check.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002587 */
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002588
Edward Creef1174f72017-08-07 15:26:19 +01002589 /* If our ids match, then we must have the same max_value. And we
2590 * don't care about the other reg's fixed offset, since if it's too big
2591 * the range won't allow anything.
2592 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
2593 */
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002594 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002595 if (regs[i].type == type && regs[i].id == dst_reg->id)
Alexei Starovoitovb1977682017-03-24 15:57:33 -07002596 /* keep the maximum range already checked */
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002597 regs[i].range = max(regs[i].range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002598
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002599 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2600 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002601 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002602 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002603 if (reg->type == type && reg->id == dst_reg->id)
Daniel Borkmannb06723d2017-11-01 23:58:09 +01002604 reg->range = max(reg->range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002605 }
2606}
2607
Josef Bacik48461132016-09-28 10:54:32 -04002608/* Adjusts the register min/max values in the case that the dst_reg is the
2609 * variable register that we are working on, and src_reg is a constant or we're
2610 * simply doing a BPF_K check.
Edward Creef1174f72017-08-07 15:26:19 +01002611 * In JEQ/JNE cases we also adjust the var_off values.
Josef Bacik48461132016-09-28 10:54:32 -04002612 */
2613static void reg_set_min_max(struct bpf_reg_state *true_reg,
2614 struct bpf_reg_state *false_reg, u64 val,
2615 u8 opcode)
2616{
Edward Creef1174f72017-08-07 15:26:19 +01002617 /* If the dst_reg is a pointer, we can't learn anything about its
2618 * variable offset from the compare (unless src_reg were a pointer into
2619 * the same object, but we don't bother with that.
2620 * Since false_reg and true_reg have the same type by construction, we
2621 * only need to check one of them for pointerness.
2622 */
2623 if (__is_pointer_value(false, false_reg))
2624 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002625
Josef Bacik48461132016-09-28 10:54:32 -04002626 switch (opcode) {
2627 case BPF_JEQ:
2628 /* If this is false then we know nothing Jon Snow, but if it is
2629 * true then we know for sure.
2630 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002631 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002632 break;
2633 case BPF_JNE:
2634 /* If this is true we know nothing Jon Snow, but if it is false
2635 * we know the value for sure;
2636 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002637 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002638 break;
2639 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002640 false_reg->umax_value = min(false_reg->umax_value, val);
2641 true_reg->umin_value = max(true_reg->umin_value, val + 1);
2642 break;
Josef Bacik48461132016-09-28 10:54:32 -04002643 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002644 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
2645 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04002646 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002647 case BPF_JLT:
2648 false_reg->umin_value = max(false_reg->umin_value, val);
2649 true_reg->umax_value = min(true_reg->umax_value, val - 1);
2650 break;
2651 case BPF_JSLT:
2652 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
2653 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
2654 break;
Josef Bacik48461132016-09-28 10:54:32 -04002655 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002656 false_reg->umax_value = min(false_reg->umax_value, val - 1);
2657 true_reg->umin_value = max(true_reg->umin_value, val);
2658 break;
Josef Bacik48461132016-09-28 10:54:32 -04002659 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002660 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
2661 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04002662 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002663 case BPF_JLE:
2664 false_reg->umin_value = max(false_reg->umin_value, val + 1);
2665 true_reg->umax_value = min(true_reg->umax_value, val);
2666 break;
2667 case BPF_JSLE:
2668 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
2669 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
2670 break;
Josef Bacik48461132016-09-28 10:54:32 -04002671 default:
2672 break;
2673 }
2674
Edward Creeb03c9f92017-08-07 15:26:36 +01002675 __reg_deduce_bounds(false_reg);
2676 __reg_deduce_bounds(true_reg);
2677 /* We might have learned some bits from the bounds. */
2678 __reg_bound_offset(false_reg);
2679 __reg_bound_offset(true_reg);
2680 /* Intersecting with the old var_off might have improved our bounds
2681 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2682 * then new var_off is (0; 0x7f...fc) which improves our umax.
2683 */
2684 __update_reg_bounds(false_reg);
2685 __update_reg_bounds(true_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002686}
2687
Edward Creef1174f72017-08-07 15:26:19 +01002688/* Same as above, but for the case that dst_reg holds a constant and src_reg is
2689 * the variable reg.
Josef Bacik48461132016-09-28 10:54:32 -04002690 */
2691static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
2692 struct bpf_reg_state *false_reg, u64 val,
2693 u8 opcode)
2694{
Edward Creef1174f72017-08-07 15:26:19 +01002695 if (__is_pointer_value(false, false_reg))
2696 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002697
Josef Bacik48461132016-09-28 10:54:32 -04002698 switch (opcode) {
2699 case BPF_JEQ:
2700 /* If this is false then we know nothing Jon Snow, but if it is
2701 * true then we know for sure.
2702 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002703 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002704 break;
2705 case BPF_JNE:
2706 /* If this is true we know nothing Jon Snow, but if it is false
2707 * we know the value for sure;
2708 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002709 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002710 break;
2711 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002712 true_reg->umax_value = min(true_reg->umax_value, val - 1);
2713 false_reg->umin_value = max(false_reg->umin_value, val);
2714 break;
Josef Bacik48461132016-09-28 10:54:32 -04002715 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002716 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
2717 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04002718 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002719 case BPF_JLT:
2720 true_reg->umin_value = max(true_reg->umin_value, val + 1);
2721 false_reg->umax_value = min(false_reg->umax_value, val);
2722 break;
2723 case BPF_JSLT:
2724 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
2725 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
2726 break;
Josef Bacik48461132016-09-28 10:54:32 -04002727 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002728 true_reg->umax_value = min(true_reg->umax_value, val);
2729 false_reg->umin_value = max(false_reg->umin_value, val + 1);
2730 break;
Josef Bacik48461132016-09-28 10:54:32 -04002731 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002732 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
2733 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04002734 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002735 case BPF_JLE:
2736 true_reg->umin_value = max(true_reg->umin_value, val);
2737 false_reg->umax_value = min(false_reg->umax_value, val - 1);
2738 break;
2739 case BPF_JSLE:
2740 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
2741 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
2742 break;
Josef Bacik48461132016-09-28 10:54:32 -04002743 default:
2744 break;
2745 }
2746
Edward Creeb03c9f92017-08-07 15:26:36 +01002747 __reg_deduce_bounds(false_reg);
2748 __reg_deduce_bounds(true_reg);
2749 /* We might have learned some bits from the bounds. */
2750 __reg_bound_offset(false_reg);
2751 __reg_bound_offset(true_reg);
2752 /* Intersecting with the old var_off might have improved our bounds
2753 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2754 * then new var_off is (0; 0x7f...fc) which improves our umax.
2755 */
2756 __update_reg_bounds(false_reg);
2757 __update_reg_bounds(true_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002758}
2759
2760/* Regs are known to be equal, so intersect their min/max/var_off */
2761static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
2762 struct bpf_reg_state *dst_reg)
2763{
Edward Creeb03c9f92017-08-07 15:26:36 +01002764 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
2765 dst_reg->umin_value);
2766 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
2767 dst_reg->umax_value);
2768 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
2769 dst_reg->smin_value);
2770 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
2771 dst_reg->smax_value);
Edward Creef1174f72017-08-07 15:26:19 +01002772 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
2773 dst_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002774 /* We might have learned new bounds from the var_off. */
2775 __update_reg_bounds(src_reg);
2776 __update_reg_bounds(dst_reg);
2777 /* We might have learned something about the sign bit. */
2778 __reg_deduce_bounds(src_reg);
2779 __reg_deduce_bounds(dst_reg);
2780 /* We might have learned some bits from the bounds. */
2781 __reg_bound_offset(src_reg);
2782 __reg_bound_offset(dst_reg);
2783 /* Intersecting with the old var_off might have improved our bounds
2784 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2785 * then new var_off is (0; 0x7f...fc) which improves our umax.
2786 */
2787 __update_reg_bounds(src_reg);
2788 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002789}
2790
2791static void reg_combine_min_max(struct bpf_reg_state *true_src,
2792 struct bpf_reg_state *true_dst,
2793 struct bpf_reg_state *false_src,
2794 struct bpf_reg_state *false_dst,
2795 u8 opcode)
2796{
2797 switch (opcode) {
2798 case BPF_JEQ:
2799 __reg_combine_min_max(true_src, true_dst);
2800 break;
2801 case BPF_JNE:
2802 __reg_combine_min_max(false_src, false_dst);
Edward Creeb03c9f92017-08-07 15:26:36 +01002803 break;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002804 }
Josef Bacik48461132016-09-28 10:54:32 -04002805}
2806
Thomas Graf57a09bf2016-10-18 19:51:19 +02002807static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
Edward Creef1174f72017-08-07 15:26:19 +01002808 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002809{
2810 struct bpf_reg_state *reg = &regs[regno];
2811
2812 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
Edward Creef1174f72017-08-07 15:26:19 +01002813 /* Old offset (both fixed and variable parts) should
2814 * have been known-zero, because we don't allow pointer
2815 * arithmetic on pointers that might be NULL.
2816 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002817 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
2818 !tnum_equals_const(reg->var_off, 0) ||
Edward Creef1174f72017-08-07 15:26:19 +01002819 reg->off)) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002820 __mark_reg_known_zero(reg);
2821 reg->off = 0;
Edward Creef1174f72017-08-07 15:26:19 +01002822 }
2823 if (is_null) {
2824 reg->type = SCALAR_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002825 } else if (reg->map_ptr->inner_map_meta) {
2826 reg->type = CONST_PTR_TO_MAP;
2827 reg->map_ptr = reg->map_ptr->inner_map_meta;
2828 } else {
Edward Creef1174f72017-08-07 15:26:19 +01002829 reg->type = PTR_TO_MAP_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002830 }
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002831 /* We don't need id from this point onwards anymore, thus we
2832 * should better reset it, so that state pruning has chances
2833 * to take effect.
2834 */
2835 reg->id = 0;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002836 }
2837}
2838
2839/* The logic is similar to find_good_pkt_pointers(), both could eventually
2840 * be folded together at some point.
2841 */
2842static void mark_map_regs(struct bpf_verifier_state *state, u32 regno,
Edward Creef1174f72017-08-07 15:26:19 +01002843 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002844{
2845 struct bpf_reg_state *regs = state->regs;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002846 u32 id = regs[regno].id;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002847 int i;
2848
2849 for (i = 0; i < MAX_BPF_REG; i++)
Edward Creef1174f72017-08-07 15:26:19 +01002850 mark_map_reg(regs, i, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002851
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002852 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2853 if (state->stack[i].slot_type[0] != STACK_SPILL)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002854 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002855 mark_map_reg(&state->stack[i].spilled_ptr, 0, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002856 }
2857}
2858
Daniel Borkmann5beca082017-11-01 23:58:10 +01002859static bool try_match_pkt_pointers(const struct bpf_insn *insn,
2860 struct bpf_reg_state *dst_reg,
2861 struct bpf_reg_state *src_reg,
2862 struct bpf_verifier_state *this_branch,
2863 struct bpf_verifier_state *other_branch)
2864{
2865 if (BPF_SRC(insn->code) != BPF_X)
2866 return false;
2867
2868 switch (BPF_OP(insn->code)) {
2869 case BPF_JGT:
2870 if ((dst_reg->type == PTR_TO_PACKET &&
2871 src_reg->type == PTR_TO_PACKET_END) ||
2872 (dst_reg->type == PTR_TO_PACKET_META &&
2873 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2874 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
2875 find_good_pkt_pointers(this_branch, dst_reg,
2876 dst_reg->type, false);
2877 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2878 src_reg->type == PTR_TO_PACKET) ||
2879 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2880 src_reg->type == PTR_TO_PACKET_META)) {
2881 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
2882 find_good_pkt_pointers(other_branch, src_reg,
2883 src_reg->type, true);
2884 } else {
2885 return false;
2886 }
2887 break;
2888 case BPF_JLT:
2889 if ((dst_reg->type == PTR_TO_PACKET &&
2890 src_reg->type == PTR_TO_PACKET_END) ||
2891 (dst_reg->type == PTR_TO_PACKET_META &&
2892 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2893 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
2894 find_good_pkt_pointers(other_branch, dst_reg,
2895 dst_reg->type, true);
2896 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2897 src_reg->type == PTR_TO_PACKET) ||
2898 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2899 src_reg->type == PTR_TO_PACKET_META)) {
2900 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
2901 find_good_pkt_pointers(this_branch, src_reg,
2902 src_reg->type, false);
2903 } else {
2904 return false;
2905 }
2906 break;
2907 case BPF_JGE:
2908 if ((dst_reg->type == PTR_TO_PACKET &&
2909 src_reg->type == PTR_TO_PACKET_END) ||
2910 (dst_reg->type == PTR_TO_PACKET_META &&
2911 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2912 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
2913 find_good_pkt_pointers(this_branch, dst_reg,
2914 dst_reg->type, true);
2915 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2916 src_reg->type == PTR_TO_PACKET) ||
2917 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2918 src_reg->type == PTR_TO_PACKET_META)) {
2919 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
2920 find_good_pkt_pointers(other_branch, src_reg,
2921 src_reg->type, false);
2922 } else {
2923 return false;
2924 }
2925 break;
2926 case BPF_JLE:
2927 if ((dst_reg->type == PTR_TO_PACKET &&
2928 src_reg->type == PTR_TO_PACKET_END) ||
2929 (dst_reg->type == PTR_TO_PACKET_META &&
2930 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2931 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
2932 find_good_pkt_pointers(other_branch, dst_reg,
2933 dst_reg->type, false);
2934 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2935 src_reg->type == PTR_TO_PACKET) ||
2936 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2937 src_reg->type == PTR_TO_PACKET_META)) {
2938 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
2939 find_good_pkt_pointers(this_branch, src_reg,
2940 src_reg->type, true);
2941 } else {
2942 return false;
2943 }
2944 break;
2945 default:
2946 return false;
2947 }
2948
2949 return true;
2950}
2951
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002952static int check_cond_jmp_op(struct bpf_verifier_env *env,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002953 struct bpf_insn *insn, int *insn_idx)
2954{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002955 struct bpf_verifier_state *other_branch, *this_branch = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002956 struct bpf_reg_state *regs = this_branch->regs, *dst_reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002957 u8 opcode = BPF_OP(insn->code);
2958 int err;
2959
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002960 if (opcode > BPF_JSLE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002961 verbose(env, "invalid BPF_JMP opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002962 return -EINVAL;
2963 }
2964
2965 if (BPF_SRC(insn->code) == BPF_X) {
2966 if (insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002967 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002968 return -EINVAL;
2969 }
2970
2971 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002972 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002973 if (err)
2974 return err;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002975
2976 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002977 verbose(env, "R%d pointer comparison prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002978 insn->src_reg);
2979 return -EACCES;
2980 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002981 } else {
2982 if (insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002983 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002984 return -EINVAL;
2985 }
2986 }
2987
2988 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002989 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002990 if (err)
2991 return err;
2992
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002993 dst_reg = &regs[insn->dst_reg];
2994
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002995 /* detect if R == 0 where R was initialized to zero earlier */
2996 if (BPF_SRC(insn->code) == BPF_K &&
2997 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
Edward Creef1174f72017-08-07 15:26:19 +01002998 dst_reg->type == SCALAR_VALUE &&
2999 tnum_equals_const(dst_reg->var_off, insn->imm)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003000 if (opcode == BPF_JEQ) {
3001 /* if (imm == imm) goto pc+off;
3002 * only follow the goto, ignore fall-through
3003 */
3004 *insn_idx += insn->off;
3005 return 0;
3006 } else {
3007 /* if (imm != imm) goto pc+off;
3008 * only follow fall-through branch, since
3009 * that's where the program will go
3010 */
3011 return 0;
3012 }
3013 }
3014
3015 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
3016 if (!other_branch)
3017 return -EFAULT;
3018
Josef Bacik48461132016-09-28 10:54:32 -04003019 /* detect if we are comparing against a constant value so we can adjust
3020 * our min/max values for our dst register.
Edward Creef1174f72017-08-07 15:26:19 +01003021 * this is only legit if both are scalars (or pointers to the same
3022 * object, I suppose, but we don't support that right now), because
3023 * otherwise the different base pointers mean the offsets aren't
3024 * comparable.
Josef Bacik48461132016-09-28 10:54:32 -04003025 */
3026 if (BPF_SRC(insn->code) == BPF_X) {
Edward Creef1174f72017-08-07 15:26:19 +01003027 if (dst_reg->type == SCALAR_VALUE &&
3028 regs[insn->src_reg].type == SCALAR_VALUE) {
3029 if (tnum_is_const(regs[insn->src_reg].var_off))
3030 reg_set_min_max(&other_branch->regs[insn->dst_reg],
3031 dst_reg, regs[insn->src_reg].var_off.value,
3032 opcode);
3033 else if (tnum_is_const(dst_reg->var_off))
3034 reg_set_min_max_inv(&other_branch->regs[insn->src_reg],
3035 &regs[insn->src_reg],
3036 dst_reg->var_off.value, opcode);
3037 else if (opcode == BPF_JEQ || opcode == BPF_JNE)
3038 /* Comparing for equality, we can combine knowledge */
3039 reg_combine_min_max(&other_branch->regs[insn->src_reg],
3040 &other_branch->regs[insn->dst_reg],
3041 &regs[insn->src_reg],
3042 &regs[insn->dst_reg], opcode);
3043 }
3044 } else if (dst_reg->type == SCALAR_VALUE) {
Josef Bacik48461132016-09-28 10:54:32 -04003045 reg_set_min_max(&other_branch->regs[insn->dst_reg],
3046 dst_reg, insn->imm, opcode);
3047 }
3048
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003049 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003050 if (BPF_SRC(insn->code) == BPF_K &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003051 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
3052 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Thomas Graf57a09bf2016-10-18 19:51:19 +02003053 /* Mark all identical map registers in each branch as either
3054 * safe or unknown depending R == 0 or R != 0 conditional.
3055 */
Edward Creef1174f72017-08-07 15:26:19 +01003056 mark_map_regs(this_branch, insn->dst_reg, opcode == BPF_JNE);
3057 mark_map_regs(other_branch, insn->dst_reg, opcode == BPF_JEQ);
Daniel Borkmann5beca082017-11-01 23:58:10 +01003058 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
3059 this_branch, other_branch) &&
3060 is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003061 verbose(env, "R%d pointer comparison prohibited\n",
3062 insn->dst_reg);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003063 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003064 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003065 if (env->log.level)
3066 print_verifier_state(env, this_branch);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003067 return 0;
3068}
3069
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003070/* return the map pointer stored inside BPF_LD_IMM64 instruction */
3071static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
3072{
3073 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
3074
3075 return (struct bpf_map *) (unsigned long) imm64;
3076}
3077
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003078/* verify BPF_LD_IMM64 instruction */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003079static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003080{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003081 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003082 int err;
3083
3084 if (BPF_SIZE(insn->code) != BPF_DW) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003085 verbose(env, "invalid BPF_LD_IMM insn\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003086 return -EINVAL;
3087 }
3088 if (insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003089 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003090 return -EINVAL;
3091 }
3092
Edward Creedc503a82017-08-15 20:34:35 +01003093 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003094 if (err)
3095 return err;
3096
Jakub Kicinski6b173872016-09-21 11:43:59 +01003097 if (insn->src_reg == 0) {
Jakub Kicinski6b173872016-09-21 11:43:59 +01003098 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
3099
Edward Creef1174f72017-08-07 15:26:19 +01003100 regs[insn->dst_reg].type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01003101 __mark_reg_known(&regs[insn->dst_reg], imm);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003102 return 0;
Jakub Kicinski6b173872016-09-21 11:43:59 +01003103 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003104
3105 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
3106 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
3107
3108 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
3109 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
3110 return 0;
3111}
3112
Daniel Borkmann96be4322015-03-01 12:31:46 +01003113static bool may_access_skb(enum bpf_prog_type type)
3114{
3115 switch (type) {
3116 case BPF_PROG_TYPE_SOCKET_FILTER:
3117 case BPF_PROG_TYPE_SCHED_CLS:
Daniel Borkmann94caee8c2015-03-20 15:11:11 +01003118 case BPF_PROG_TYPE_SCHED_ACT:
Daniel Borkmann96be4322015-03-01 12:31:46 +01003119 return true;
3120 default:
3121 return false;
3122 }
3123}
3124
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003125/* verify safety of LD_ABS|LD_IND instructions:
3126 * - they can only appear in the programs where ctx == skb
3127 * - since they are wrappers of function calls, they scratch R1-R5 registers,
3128 * preserve R6-R9, and store return value into R0
3129 *
3130 * Implicit input:
3131 * ctx == skb == R6 == CTX
3132 *
3133 * Explicit input:
3134 * SRC == any register
3135 * IMM == 32-bit immediate
3136 *
3137 * Output:
3138 * R0 - 8/16/32-bit skb data converted to cpu endianness
3139 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003140static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003141{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003142 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003143 u8 mode = BPF_MODE(insn->code);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003144 int i, err;
3145
Daniel Borkmann24701ec2015-03-01 12:31:47 +01003146 if (!may_access_skb(env->prog->type)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003147 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003148 return -EINVAL;
3149 }
3150
3151 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
Alexei Starovoitovd82bccc2016-04-12 10:26:19 -07003152 BPF_SIZE(insn->code) == BPF_DW ||
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003153 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003154 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003155 return -EINVAL;
3156 }
3157
3158 /* check whether implicit source operand (register R6) is readable */
Edward Creedc503a82017-08-15 20:34:35 +01003159 err = check_reg_arg(env, BPF_REG_6, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003160 if (err)
3161 return err;
3162
3163 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003164 verbose(env,
3165 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003166 return -EINVAL;
3167 }
3168
3169 if (mode == BPF_IND) {
3170 /* check explicit source operand */
Edward Creedc503a82017-08-15 20:34:35 +01003171 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003172 if (err)
3173 return err;
3174 }
3175
3176 /* reset caller saved regs to unreadable */
Edward Creedc503a82017-08-15 20:34:35 +01003177 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003178 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01003179 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
3180 }
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003181
3182 /* mark destination R0 register as readable, since it contains
Edward Creedc503a82017-08-15 20:34:35 +01003183 * the value fetched from the packet.
3184 * Already marked as written above.
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003185 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003186 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003187 return 0;
3188}
3189
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003190static int check_return_code(struct bpf_verifier_env *env)
3191{
3192 struct bpf_reg_state *reg;
3193 struct tnum range = tnum_range(0, 1);
3194
3195 switch (env->prog->type) {
3196 case BPF_PROG_TYPE_CGROUP_SKB:
3197 case BPF_PROG_TYPE_CGROUP_SOCK:
3198 case BPF_PROG_TYPE_SOCK_OPS:
Roman Gushchinebc614f2017-11-05 08:15:32 -05003199 case BPF_PROG_TYPE_CGROUP_DEVICE:
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003200 break;
3201 default:
3202 return 0;
3203 }
3204
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003205 reg = cur_regs(env) + BPF_REG_0;
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003206 if (reg->type != SCALAR_VALUE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003207 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003208 reg_type_str[reg->type]);
3209 return -EINVAL;
3210 }
3211
3212 if (!tnum_in(range, reg->var_off)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003213 verbose(env, "At program exit the register R0 ");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003214 if (!tnum_is_unknown(reg->var_off)) {
3215 char tn_buf[48];
3216
3217 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003218 verbose(env, "has value %s", tn_buf);
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003219 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003220 verbose(env, "has unknown scalar value");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003221 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003222 verbose(env, " should have been 0 or 1\n");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003223 return -EINVAL;
3224 }
3225 return 0;
3226}
3227
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003228/* non-recursive DFS pseudo code
3229 * 1 procedure DFS-iterative(G,v):
3230 * 2 label v as discovered
3231 * 3 let S be a stack
3232 * 4 S.push(v)
3233 * 5 while S is not empty
3234 * 6 t <- S.pop()
3235 * 7 if t is what we're looking for:
3236 * 8 return t
3237 * 9 for all edges e in G.adjacentEdges(t) do
3238 * 10 if edge e is already labelled
3239 * 11 continue with the next edge
3240 * 12 w <- G.adjacentVertex(t,e)
3241 * 13 if vertex w is not discovered and not explored
3242 * 14 label e as tree-edge
3243 * 15 label w as discovered
3244 * 16 S.push(w)
3245 * 17 continue at 5
3246 * 18 else if vertex w is discovered
3247 * 19 label e as back-edge
3248 * 20 else
3249 * 21 // vertex w is explored
3250 * 22 label e as forward- or cross-edge
3251 * 23 label t as explored
3252 * 24 S.pop()
3253 *
3254 * convention:
3255 * 0x10 - discovered
3256 * 0x11 - discovered and fall-through edge labelled
3257 * 0x12 - discovered and fall-through and branch edges labelled
3258 * 0x20 - explored
3259 */
3260
3261enum {
3262 DISCOVERED = 0x10,
3263 EXPLORED = 0x20,
3264 FALLTHROUGH = 1,
3265 BRANCH = 2,
3266};
3267
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003268#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003269
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003270static int *insn_stack; /* stack of insns to process */
3271static int cur_stack; /* current stack index */
3272static int *insn_state;
3273
3274/* t, w, e - match pseudo-code above:
3275 * t - index of current instruction
3276 * w - next instruction
3277 * e - edge
3278 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003279static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003280{
3281 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
3282 return 0;
3283
3284 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
3285 return 0;
3286
3287 if (w < 0 || w >= env->prog->len) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003288 verbose(env, "jump out of range from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003289 return -EINVAL;
3290 }
3291
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003292 if (e == BRANCH)
3293 /* mark branch target for state pruning */
3294 env->explored_states[w] = STATE_LIST_MARK;
3295
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003296 if (insn_state[w] == 0) {
3297 /* tree-edge */
3298 insn_state[t] = DISCOVERED | e;
3299 insn_state[w] = DISCOVERED;
3300 if (cur_stack >= env->prog->len)
3301 return -E2BIG;
3302 insn_stack[cur_stack++] = w;
3303 return 1;
3304 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003305 verbose(env, "back-edge from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003306 return -EINVAL;
3307 } else if (insn_state[w] == EXPLORED) {
3308 /* forward- or cross-edge */
3309 insn_state[t] = DISCOVERED | e;
3310 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003311 verbose(env, "insn state internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003312 return -EFAULT;
3313 }
3314 return 0;
3315}
3316
3317/* non-recursive depth-first-search to detect loops in BPF program
3318 * loop == back-edge in directed graph
3319 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003320static int check_cfg(struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003321{
3322 struct bpf_insn *insns = env->prog->insnsi;
3323 int insn_cnt = env->prog->len;
3324 int ret = 0;
3325 int i, t;
3326
3327 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
3328 if (!insn_state)
3329 return -ENOMEM;
3330
3331 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
3332 if (!insn_stack) {
3333 kfree(insn_state);
3334 return -ENOMEM;
3335 }
3336
3337 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
3338 insn_stack[0] = 0; /* 0 is the first instruction */
3339 cur_stack = 1;
3340
3341peek_stack:
3342 if (cur_stack == 0)
3343 goto check_state;
3344 t = insn_stack[cur_stack - 1];
3345
3346 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
3347 u8 opcode = BPF_OP(insns[t].code);
3348
3349 if (opcode == BPF_EXIT) {
3350 goto mark_explored;
3351 } else if (opcode == BPF_CALL) {
3352 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3353 if (ret == 1)
3354 goto peek_stack;
3355 else if (ret < 0)
3356 goto err_free;
Daniel Borkmann07016152016-04-05 22:33:17 +02003357 if (t + 1 < insn_cnt)
3358 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003359 } else if (opcode == BPF_JA) {
3360 if (BPF_SRC(insns[t].code) != BPF_K) {
3361 ret = -EINVAL;
3362 goto err_free;
3363 }
3364 /* unconditional jump with single edge */
3365 ret = push_insn(t, t + insns[t].off + 1,
3366 FALLTHROUGH, env);
3367 if (ret == 1)
3368 goto peek_stack;
3369 else if (ret < 0)
3370 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003371 /* tell verifier to check for equivalent states
3372 * after every call and jump
3373 */
Alexei Starovoitovc3de6312015-04-14 15:57:13 -07003374 if (t + 1 < insn_cnt)
3375 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003376 } else {
3377 /* conditional jump with two edges */
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02003378 env->explored_states[t] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003379 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3380 if (ret == 1)
3381 goto peek_stack;
3382 else if (ret < 0)
3383 goto err_free;
3384
3385 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
3386 if (ret == 1)
3387 goto peek_stack;
3388 else if (ret < 0)
3389 goto err_free;
3390 }
3391 } else {
3392 /* all other non-branch instructions with single
3393 * fall-through edge
3394 */
3395 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3396 if (ret == 1)
3397 goto peek_stack;
3398 else if (ret < 0)
3399 goto err_free;
3400 }
3401
3402mark_explored:
3403 insn_state[t] = EXPLORED;
3404 if (cur_stack-- <= 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003405 verbose(env, "pop stack internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003406 ret = -EFAULT;
3407 goto err_free;
3408 }
3409 goto peek_stack;
3410
3411check_state:
3412 for (i = 0; i < insn_cnt; i++) {
3413 if (insn_state[i] != EXPLORED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003414 verbose(env, "unreachable insn %d\n", i);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003415 ret = -EINVAL;
3416 goto err_free;
3417 }
3418 }
3419 ret = 0; /* cfg looks good */
3420
3421err_free:
3422 kfree(insn_state);
3423 kfree(insn_stack);
3424 return ret;
3425}
3426
Edward Creef1174f72017-08-07 15:26:19 +01003427/* check %cur's range satisfies %old's */
3428static bool range_within(struct bpf_reg_state *old,
3429 struct bpf_reg_state *cur)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003430{
Edward Creeb03c9f92017-08-07 15:26:36 +01003431 return old->umin_value <= cur->umin_value &&
3432 old->umax_value >= cur->umax_value &&
3433 old->smin_value <= cur->smin_value &&
3434 old->smax_value >= cur->smax_value;
Edward Creef1174f72017-08-07 15:26:19 +01003435}
3436
3437/* Maximum number of register states that can exist at once */
3438#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
3439struct idpair {
3440 u32 old;
3441 u32 cur;
3442};
3443
3444/* If in the old state two registers had the same id, then they need to have
3445 * the same id in the new state as well. But that id could be different from
3446 * the old state, so we need to track the mapping from old to new ids.
3447 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
3448 * regs with old id 5 must also have new id 9 for the new state to be safe. But
3449 * regs with a different old id could still have new id 9, we don't care about
3450 * that.
3451 * So we look through our idmap to see if this old id has been seen before. If
3452 * so, we require the new id to match; otherwise, we add the id pair to the map.
3453 */
3454static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
3455{
3456 unsigned int i;
3457
3458 for (i = 0; i < ID_MAP_SIZE; i++) {
3459 if (!idmap[i].old) {
3460 /* Reached an empty slot; haven't seen this id before */
3461 idmap[i].old = old_id;
3462 idmap[i].cur = cur_id;
3463 return true;
3464 }
3465 if (idmap[i].old == old_id)
3466 return idmap[i].cur == cur_id;
3467 }
3468 /* We ran out of idmap slots, which should be impossible */
3469 WARN_ON_ONCE(1);
3470 return false;
3471}
3472
3473/* Returns true if (rold safe implies rcur safe) */
Edward Cree1b688a12017-08-23 15:10:50 +01003474static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
3475 struct idpair *idmap)
Edward Creef1174f72017-08-07 15:26:19 +01003476{
Edward Creedc503a82017-08-15 20:34:35 +01003477 if (!(rold->live & REG_LIVE_READ))
3478 /* explored state didn't use this */
3479 return true;
3480
3481 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, live)) == 0)
Edward Creef1174f72017-08-07 15:26:19 +01003482 return true;
3483
3484 if (rold->type == NOT_INIT)
3485 /* explored state can't have used this */
3486 return true;
3487 if (rcur->type == NOT_INIT)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003488 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003489 switch (rold->type) {
3490 case SCALAR_VALUE:
3491 if (rcur->type == SCALAR_VALUE) {
3492 /* new val must satisfy old val knowledge */
3493 return range_within(rold, rcur) &&
3494 tnum_in(rold->var_off, rcur->var_off);
3495 } else {
Jann Horn179d1c52017-12-18 20:11:59 -08003496 /* We're trying to use a pointer in place of a scalar.
3497 * Even if the scalar was unbounded, this could lead to
3498 * pointer leaks because scalars are allowed to leak
3499 * while pointers are not. We could make this safe in
3500 * special cases if root is calling us, but it's
3501 * probably not worth the hassle.
Edward Creef1174f72017-08-07 15:26:19 +01003502 */
Jann Horn179d1c52017-12-18 20:11:59 -08003503 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003504 }
3505 case PTR_TO_MAP_VALUE:
Edward Cree1b688a12017-08-23 15:10:50 +01003506 /* If the new min/max/var_off satisfy the old ones and
3507 * everything else matches, we are OK.
3508 * We don't care about the 'id' value, because nothing
3509 * uses it for PTR_TO_MAP_VALUE (only for ..._OR_NULL)
3510 */
3511 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
3512 range_within(rold, rcur) &&
3513 tnum_in(rold->var_off, rcur->var_off);
Edward Creef1174f72017-08-07 15:26:19 +01003514 case PTR_TO_MAP_VALUE_OR_NULL:
3515 /* a PTR_TO_MAP_VALUE could be safe to use as a
3516 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
3517 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
3518 * checked, doing so could have affected others with the same
3519 * id, and we can't check for that because we lost the id when
3520 * we converted to a PTR_TO_MAP_VALUE.
3521 */
3522 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
3523 return false;
3524 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
3525 return false;
3526 /* Check our ids match any regs they're supposed to */
3527 return check_ids(rold->id, rcur->id, idmap);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003528 case PTR_TO_PACKET_META:
Edward Creef1174f72017-08-07 15:26:19 +01003529 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003530 if (rcur->type != rold->type)
Edward Creef1174f72017-08-07 15:26:19 +01003531 return false;
3532 /* We must have at least as much range as the old ptr
3533 * did, so that any accesses which were safe before are
3534 * still safe. This is true even if old range < old off,
3535 * since someone could have accessed through (ptr - k), or
3536 * even done ptr -= k in a register, to get a safe access.
3537 */
3538 if (rold->range > rcur->range)
3539 return false;
3540 /* If the offsets don't match, we can't trust our alignment;
3541 * nor can we be sure that we won't fall out of range.
3542 */
3543 if (rold->off != rcur->off)
3544 return false;
3545 /* id relations must be preserved */
3546 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
3547 return false;
3548 /* new val must satisfy old val knowledge */
3549 return range_within(rold, rcur) &&
3550 tnum_in(rold->var_off, rcur->var_off);
3551 case PTR_TO_CTX:
3552 case CONST_PTR_TO_MAP:
3553 case PTR_TO_STACK:
3554 case PTR_TO_PACKET_END:
3555 /* Only valid matches are exact, which memcmp() above
3556 * would have accepted
3557 */
3558 default:
3559 /* Don't know what's going on, just say it's not safe */
3560 return false;
3561 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003562
Edward Creef1174f72017-08-07 15:26:19 +01003563 /* Shouldn't get here; if we do, say it's not safe */
3564 WARN_ON_ONCE(1);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003565 return false;
3566}
3567
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003568static bool stacksafe(struct bpf_verifier_state *old,
3569 struct bpf_verifier_state *cur,
3570 struct idpair *idmap)
3571{
3572 int i, spi;
3573
3574 /* if explored stack has more populated slots than current stack
3575 * such stacks are not equivalent
3576 */
3577 if (old->allocated_stack > cur->allocated_stack)
3578 return false;
3579
3580 /* walk slots of the explored stack and ignore any additional
3581 * slots in the current stack, since explored(safe) state
3582 * didn't use them
3583 */
3584 for (i = 0; i < old->allocated_stack; i++) {
3585 spi = i / BPF_REG_SIZE;
3586
3587 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
3588 continue;
3589 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
3590 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
3591 /* Ex: old explored (safe) state has STACK_SPILL in
3592 * this stack slot, but current has has STACK_MISC ->
3593 * this verifier states are not equivalent,
3594 * return false to continue verification of this path
3595 */
3596 return false;
3597 if (i % BPF_REG_SIZE)
3598 continue;
3599 if (old->stack[spi].slot_type[0] != STACK_SPILL)
3600 continue;
3601 if (!regsafe(&old->stack[spi].spilled_ptr,
3602 &cur->stack[spi].spilled_ptr,
3603 idmap))
3604 /* when explored and current stack slot are both storing
3605 * spilled registers, check that stored pointers types
3606 * are the same as well.
3607 * Ex: explored safe path could have stored
3608 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
3609 * but current path has stored:
3610 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
3611 * such verifier states are not equivalent.
3612 * return false to continue verification of this path
3613 */
3614 return false;
3615 }
3616 return true;
3617}
3618
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003619/* compare two verifier states
3620 *
3621 * all states stored in state_list are known to be valid, since
3622 * verifier reached 'bpf_exit' instruction through them
3623 *
3624 * this function is called when verifier exploring different branches of
3625 * execution popped from the state stack. If it sees an old state that has
3626 * more strict register state and more strict stack state then this execution
3627 * branch doesn't need to be explored further, since verifier already
3628 * concluded that more strict state leads to valid finish.
3629 *
3630 * Therefore two states are equivalent if register state is more conservative
3631 * and explored stack state is more conservative than the current one.
3632 * Example:
3633 * explored current
3634 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
3635 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
3636 *
3637 * In other words if current stack state (one being explored) has more
3638 * valid slots than old one that already passed validation, it means
3639 * the verifier can stop exploring and conclude that current state is valid too
3640 *
3641 * Similarly with registers. If explored state has register type as invalid
3642 * whereas register type in current state is meaningful, it means that
3643 * the current state will reach 'bpf_exit' instruction safely
3644 */
Josef Bacik48461132016-09-28 10:54:32 -04003645static bool states_equal(struct bpf_verifier_env *env,
3646 struct bpf_verifier_state *old,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003647 struct bpf_verifier_state *cur)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003648{
Edward Creef1174f72017-08-07 15:26:19 +01003649 struct idpair *idmap;
3650 bool ret = false;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003651 int i;
3652
Edward Creef1174f72017-08-07 15:26:19 +01003653 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
3654 /* If we failed to allocate the idmap, just say it's not safe */
3655 if (!idmap)
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003656 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003657
3658 for (i = 0; i < MAX_BPF_REG; i++) {
Edward Cree1b688a12017-08-23 15:10:50 +01003659 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
Edward Creef1174f72017-08-07 15:26:19 +01003660 goto out_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003661 }
3662
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003663 if (!stacksafe(old, cur, idmap))
3664 goto out_free;
Edward Creef1174f72017-08-07 15:26:19 +01003665 ret = true;
3666out_free:
3667 kfree(idmap);
3668 return ret;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003669}
3670
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003671/* A write screens off any subsequent reads; but write marks come from the
3672 * straight-line code between a state and its parent. When we arrive at a
3673 * jump target (in the first iteration of the propagate_liveness() loop),
3674 * we didn't arrive by the straight-line code, so read marks in state must
3675 * propagate to parent regardless of state's write marks.
3676 */
Edward Creedc503a82017-08-15 20:34:35 +01003677static bool do_propagate_liveness(const struct bpf_verifier_state *state,
3678 struct bpf_verifier_state *parent)
3679{
Edward Cree63f45f82017-08-23 15:10:03 +01003680 bool writes = parent == state->parent; /* Observe write marks */
Edward Creedc503a82017-08-15 20:34:35 +01003681 bool touched = false; /* any changes made? */
3682 int i;
3683
3684 if (!parent)
3685 return touched;
3686 /* Propagate read liveness of registers... */
3687 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
3688 /* We don't need to worry about FP liveness because it's read-only */
3689 for (i = 0; i < BPF_REG_FP; i++) {
3690 if (parent->regs[i].live & REG_LIVE_READ)
3691 continue;
Edward Cree63f45f82017-08-23 15:10:03 +01003692 if (writes && (state->regs[i].live & REG_LIVE_WRITTEN))
3693 continue;
3694 if (state->regs[i].live & REG_LIVE_READ) {
Edward Creedc503a82017-08-15 20:34:35 +01003695 parent->regs[i].live |= REG_LIVE_READ;
3696 touched = true;
3697 }
3698 }
3699 /* ... and stack slots */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003700 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
3701 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
3702 if (parent->stack[i].slot_type[0] != STACK_SPILL)
Edward Creedc503a82017-08-15 20:34:35 +01003703 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003704 if (state->stack[i].slot_type[0] != STACK_SPILL)
Edward Creedc503a82017-08-15 20:34:35 +01003705 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003706 if (parent->stack[i].spilled_ptr.live & REG_LIVE_READ)
Edward Creedc503a82017-08-15 20:34:35 +01003707 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003708 if (writes &&
3709 (state->stack[i].spilled_ptr.live & REG_LIVE_WRITTEN))
Edward Cree63f45f82017-08-23 15:10:03 +01003710 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003711 if (state->stack[i].spilled_ptr.live & REG_LIVE_READ) {
3712 parent->stack[i].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +01003713 touched = true;
3714 }
3715 }
3716 return touched;
3717}
3718
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003719/* "parent" is "a state from which we reach the current state", but initially
3720 * it is not the state->parent (i.e. "the state whose straight-line code leads
3721 * to the current state"), instead it is the state that happened to arrive at
3722 * a (prunable) equivalent of the current state. See comment above
3723 * do_propagate_liveness() for consequences of this.
3724 * This function is just a more efficient way of calling mark_reg_read() or
3725 * mark_stack_slot_read() on each reg in "parent" that is read in "state",
3726 * though it requires that parent != state->parent in the call arguments.
3727 */
Edward Creedc503a82017-08-15 20:34:35 +01003728static void propagate_liveness(const struct bpf_verifier_state *state,
3729 struct bpf_verifier_state *parent)
3730{
3731 while (do_propagate_liveness(state, parent)) {
3732 /* Something changed, so we need to feed those changes onward */
3733 state = parent;
3734 parent = state->parent;
3735 }
3736}
3737
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003738static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003739{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003740 struct bpf_verifier_state_list *new_sl;
3741 struct bpf_verifier_state_list *sl;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003742 struct bpf_verifier_state *cur = env->cur_state;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07003743 int i, err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003744
3745 sl = env->explored_states[insn_idx];
3746 if (!sl)
3747 /* this 'insn_idx' instruction wasn't marked, so we will not
3748 * be doing state search here
3749 */
3750 return 0;
3751
3752 while (sl != STATE_LIST_MARK) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003753 if (states_equal(env, &sl->state, cur)) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003754 /* reached equivalent register/stack state,
Edward Creedc503a82017-08-15 20:34:35 +01003755 * prune the search.
3756 * Registers read by the continuation are read by us.
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003757 * If we have any write marks in env->cur_state, they
3758 * will prevent corresponding reads in the continuation
3759 * from reaching our parent (an explored_state). Our
3760 * own state will get the read marks recorded, but
3761 * they'll be immediately forgotten as we're pruning
3762 * this state and will pop a new one.
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003763 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003764 propagate_liveness(&sl->state, cur);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003765 return 1;
Edward Creedc503a82017-08-15 20:34:35 +01003766 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003767 sl = sl->next;
3768 }
3769
3770 /* there were no equivalent states, remember current one.
3771 * technically the current state is not proven to be safe yet,
3772 * but it will either reach bpf_exit (which means it's safe) or
3773 * it will be rejected. Since there are no loops, we won't be
3774 * seeing this 'insn_idx' instruction again on the way to bpf_exit
3775 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003776 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003777 if (!new_sl)
3778 return -ENOMEM;
3779
3780 /* add new state to the head of linked list */
Alexei Starovoitov1969db42017-11-01 00:08:04 -07003781 err = copy_verifier_state(&new_sl->state, cur);
3782 if (err) {
3783 free_verifier_state(&new_sl->state, false);
3784 kfree(new_sl);
3785 return err;
3786 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003787 new_sl->next = env->explored_states[insn_idx];
3788 env->explored_states[insn_idx] = new_sl;
Edward Creedc503a82017-08-15 20:34:35 +01003789 /* connect new state to parentage chain */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003790 cur->parent = &new_sl->state;
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003791 /* clear write marks in current state: the writes we did are not writes
3792 * our child did, so they don't screen off its reads from us.
3793 * (There are no read marks in current state, because reads always mark
3794 * their parent and current state never has children yet. Only
3795 * explored_states can get read marks.)
3796 */
Edward Creedc503a82017-08-15 20:34:35 +01003797 for (i = 0; i < BPF_REG_FP; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003798 cur->regs[i].live = REG_LIVE_NONE;
3799 for (i = 0; i < cur->allocated_stack / BPF_REG_SIZE; i++)
3800 if (cur->stack[i].slot_type[0] == STACK_SPILL)
3801 cur->stack[i].spilled_ptr.live = REG_LIVE_NONE;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003802 return 0;
3803}
3804
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003805static int ext_analyzer_insn_hook(struct bpf_verifier_env *env,
3806 int insn_idx, int prev_insn_idx)
3807{
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07003808 if (env->dev_ops && env->dev_ops->insn_hook)
3809 return env->dev_ops->insn_hook(env, insn_idx, prev_insn_idx);
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003810
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07003811 return 0;
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003812}
3813
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003814static int do_check(struct bpf_verifier_env *env)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003815{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003816 struct bpf_verifier_state *state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003817 struct bpf_insn *insns = env->prog->insnsi;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003818 struct bpf_reg_state *regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003819 int insn_cnt = env->prog->len;
3820 int insn_idx, prev_insn_idx = 0;
3821 int insn_processed = 0;
3822 bool do_print_state = false;
3823
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003824 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
3825 if (!state)
3826 return -ENOMEM;
3827 env->cur_state = state;
3828 init_reg_state(env, state->regs);
Edward Creedc503a82017-08-15 20:34:35 +01003829 state->parent = NULL;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003830 insn_idx = 0;
3831 for (;;) {
3832 struct bpf_insn *insn;
3833 u8 class;
3834 int err;
3835
3836 if (insn_idx >= insn_cnt) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003837 verbose(env, "invalid insn idx %d insn_cnt %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003838 insn_idx, insn_cnt);
3839 return -EFAULT;
3840 }
3841
3842 insn = &insns[insn_idx];
3843 class = BPF_CLASS(insn->code);
3844
Daniel Borkmann07016152016-04-05 22:33:17 +02003845 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003846 verbose(env,
3847 "BPF program is too large. Processed %d insn\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003848 insn_processed);
3849 return -E2BIG;
3850 }
3851
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003852 err = is_state_visited(env, insn_idx);
3853 if (err < 0)
3854 return err;
3855 if (err == 1) {
3856 /* found equivalent state, can prune the search */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003857 if (env->log.level) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003858 if (do_print_state)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003859 verbose(env, "\nfrom %d to %d: safe\n",
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003860 prev_insn_idx, insn_idx);
3861 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003862 verbose(env, "%d: safe\n", insn_idx);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003863 }
3864 goto process_bpf_exit;
3865 }
3866
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02003867 if (need_resched())
3868 cond_resched();
3869
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003870 if (env->log.level > 1 || (env->log.level && do_print_state)) {
3871 if (env->log.level > 1)
3872 verbose(env, "%d:", insn_idx);
David S. Millerc5fc9692017-05-10 11:25:17 -07003873 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003874 verbose(env, "\nfrom %d to %d:",
David S. Millerc5fc9692017-05-10 11:25:17 -07003875 prev_insn_idx, insn_idx);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003876 print_verifier_state(env, state);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003877 do_print_state = false;
3878 }
3879
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003880 if (env->log.level) {
3881 verbose(env, "%d: ", insn_idx);
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -07003882 print_bpf_insn(verbose, env, insn,
3883 env->allow_ptr_leaks);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003884 }
3885
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003886 err = ext_analyzer_insn_hook(env, insn_idx, prev_insn_idx);
3887 if (err)
3888 return err;
3889
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003890 regs = cur_regs(env);
Alexei Starovoitovc1311872017-11-22 16:42:05 -08003891 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003892 if (class == BPF_ALU || class == BPF_ALU64) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003893 err = check_alu_op(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003894 if (err)
3895 return err;
3896
3897 } else if (class == BPF_LDX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003898 enum bpf_reg_type *prev_src_type, src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003899
3900 /* check for reserved fields is already done */
3901
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003902 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003903 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003904 if (err)
3905 return err;
3906
Edward Creedc503a82017-08-15 20:34:35 +01003907 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003908 if (err)
3909 return err;
3910
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07003911 src_reg_type = regs[insn->src_reg].type;
3912
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003913 /* check that memory (src_reg + off) is readable,
3914 * the state of dst_reg will be updated by this func
3915 */
Yonghong Song31fd8582017-06-13 15:52:13 -07003916 err = check_mem_access(env, insn_idx, insn->src_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003917 BPF_SIZE(insn->code), BPF_READ,
3918 insn->dst_reg);
3919 if (err)
3920 return err;
3921
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003922 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
3923
3924 if (*prev_src_type == NOT_INIT) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003925 /* saw a valid insn
3926 * dst_reg = *(u32 *)(src_reg + off)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003927 * save type to validate intersecting paths
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003928 */
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003929 *prev_src_type = src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003930
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003931 } else if (src_reg_type != *prev_src_type &&
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003932 (src_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003933 *prev_src_type == PTR_TO_CTX)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003934 /* ABuser program is trying to use the same insn
3935 * dst_reg = *(u32*) (src_reg + off)
3936 * with different pointer types:
3937 * src_reg == ctx in one branch and
3938 * src_reg == stack|map in some other branch.
3939 * Reject it.
3940 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003941 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003942 return -EINVAL;
3943 }
3944
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003945 } else if (class == BPF_STX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003946 enum bpf_reg_type *prev_dst_type, dst_reg_type;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003947
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003948 if (BPF_MODE(insn->code) == BPF_XADD) {
Yonghong Song31fd8582017-06-13 15:52:13 -07003949 err = check_xadd(env, insn_idx, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003950 if (err)
3951 return err;
3952 insn_idx++;
3953 continue;
3954 }
3955
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003956 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003957 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003958 if (err)
3959 return err;
3960 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003961 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003962 if (err)
3963 return err;
3964
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003965 dst_reg_type = regs[insn->dst_reg].type;
3966
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003967 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07003968 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003969 BPF_SIZE(insn->code), BPF_WRITE,
3970 insn->src_reg);
3971 if (err)
3972 return err;
3973
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003974 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
3975
3976 if (*prev_dst_type == NOT_INIT) {
3977 *prev_dst_type = dst_reg_type;
3978 } else if (dst_reg_type != *prev_dst_type &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003979 (dst_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003980 *prev_dst_type == PTR_TO_CTX)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003981 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003982 return -EINVAL;
3983 }
3984
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003985 } else if (class == BPF_ST) {
3986 if (BPF_MODE(insn->code) != BPF_MEM ||
3987 insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003988 verbose(env, "BPF_ST uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003989 return -EINVAL;
3990 }
3991 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003992 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003993 if (err)
3994 return err;
3995
3996 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07003997 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003998 BPF_SIZE(insn->code), BPF_WRITE,
3999 -1);
4000 if (err)
4001 return err;
4002
4003 } else if (class == BPF_JMP) {
4004 u8 opcode = BPF_OP(insn->code);
4005
4006 if (opcode == BPF_CALL) {
4007 if (BPF_SRC(insn->code) != BPF_K ||
4008 insn->off != 0 ||
4009 insn->src_reg != BPF_REG_0 ||
4010 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004011 verbose(env, "BPF_CALL uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004012 return -EINVAL;
4013 }
4014
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004015 err = check_call(env, insn->imm, insn_idx);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004016 if (err)
4017 return err;
4018
4019 } else if (opcode == BPF_JA) {
4020 if (BPF_SRC(insn->code) != BPF_K ||
4021 insn->imm != 0 ||
4022 insn->src_reg != BPF_REG_0 ||
4023 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004024 verbose(env, "BPF_JA uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004025 return -EINVAL;
4026 }
4027
4028 insn_idx += insn->off + 1;
4029 continue;
4030
4031 } else if (opcode == BPF_EXIT) {
4032 if (BPF_SRC(insn->code) != BPF_K ||
4033 insn->imm != 0 ||
4034 insn->src_reg != BPF_REG_0 ||
4035 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004036 verbose(env, "BPF_EXIT uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004037 return -EINVAL;
4038 }
4039
4040 /* eBPF calling convetion is such that R0 is used
4041 * to return the value from eBPF program.
4042 * Make sure that it's readable at this time
4043 * of bpf_exit, which means that program wrote
4044 * something into it earlier
4045 */
Edward Creedc503a82017-08-15 20:34:35 +01004046 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004047 if (err)
4048 return err;
4049
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004050 if (is_pointer_value(env, BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004051 verbose(env, "R0 leaks addr as return value\n");
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004052 return -EACCES;
4053 }
4054
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004055 err = check_return_code(env);
4056 if (err)
4057 return err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004058process_bpf_exit:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004059 err = pop_stack(env, &prev_insn_idx, &insn_idx);
4060 if (err < 0) {
4061 if (err != -ENOENT)
4062 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004063 break;
4064 } else {
4065 do_print_state = true;
4066 continue;
4067 }
4068 } else {
4069 err = check_cond_jmp_op(env, insn, &insn_idx);
4070 if (err)
4071 return err;
4072 }
4073 } else if (class == BPF_LD) {
4074 u8 mode = BPF_MODE(insn->code);
4075
4076 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004077 err = check_ld_abs(env, insn);
4078 if (err)
4079 return err;
4080
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004081 } else if (mode == BPF_IMM) {
4082 err = check_ld_imm(env, insn);
4083 if (err)
4084 return err;
4085
4086 insn_idx++;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004087 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004088 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004089 verbose(env, "invalid BPF_LD mode\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004090 return -EINVAL;
4091 }
4092 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004093 verbose(env, "unknown insn class %d\n", class);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004094 return -EINVAL;
4095 }
4096
4097 insn_idx++;
4098 }
4099
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004100 verbose(env, "processed %d insns, stack depth %d\n", insn_processed,
4101 env->prog->aux->stack_depth);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004102 return 0;
4103}
4104
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004105static int check_map_prealloc(struct bpf_map *map)
4106{
4107 return (map->map_type != BPF_MAP_TYPE_HASH &&
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07004108 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
4109 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004110 !(map->map_flags & BPF_F_NO_PREALLOC);
4111}
4112
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004113static int check_map_prog_compatibility(struct bpf_verifier_env *env,
4114 struct bpf_map *map,
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004115 struct bpf_prog *prog)
4116
4117{
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004118 /* Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use
4119 * preallocated hash maps, since doing memory allocation
4120 * in overflow_handler can crash depending on where nmi got
4121 * triggered.
4122 */
4123 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
4124 if (!check_map_prealloc(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004125 verbose(env, "perf_event programs can only use preallocated hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004126 return -EINVAL;
4127 }
4128 if (map->inner_map_meta &&
4129 !check_map_prealloc(map->inner_map_meta)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004130 verbose(env, "perf_event programs can only use preallocated inner hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004131 return -EINVAL;
4132 }
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004133 }
4134 return 0;
4135}
4136
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004137/* look for pseudo eBPF instructions that access map FDs and
4138 * replace them with actual map pointers
4139 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004140static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004141{
4142 struct bpf_insn *insn = env->prog->insnsi;
4143 int insn_cnt = env->prog->len;
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004144 int i, j, err;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004145
Daniel Borkmannf1f77142017-01-13 23:38:15 +01004146 err = bpf_prog_calc_tag(env->prog);
Daniel Borkmannaafe6ae2016-12-18 01:52:57 +01004147 if (err)
4148 return err;
4149
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004150 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004151 if (BPF_CLASS(insn->code) == BPF_LDX &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004152 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004153 verbose(env, "BPF_LDX uses reserved fields\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004154 return -EINVAL;
4155 }
4156
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004157 if (BPF_CLASS(insn->code) == BPF_STX &&
4158 ((BPF_MODE(insn->code) != BPF_MEM &&
4159 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004160 verbose(env, "BPF_STX uses reserved fields\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004161 return -EINVAL;
4162 }
4163
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004164 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
4165 struct bpf_map *map;
4166 struct fd f;
4167
4168 if (i == insn_cnt - 1 || insn[1].code != 0 ||
4169 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
4170 insn[1].off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004171 verbose(env, "invalid bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004172 return -EINVAL;
4173 }
4174
4175 if (insn->src_reg == 0)
4176 /* valid generic load 64-bit imm */
4177 goto next_insn;
4178
4179 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004180 verbose(env,
4181 "unrecognized bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004182 return -EINVAL;
4183 }
4184
4185 f = fdget(insn->imm);
Daniel Borkmannc2101292015-10-29 14:58:07 +01004186 map = __bpf_map_get(f);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004187 if (IS_ERR(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004188 verbose(env, "fd %d is not pointing to valid bpf_map\n",
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004189 insn->imm);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004190 return PTR_ERR(map);
4191 }
4192
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004193 err = check_map_prog_compatibility(env, map, env->prog);
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004194 if (err) {
4195 fdput(f);
4196 return err;
4197 }
4198
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004199 /* store map pointer inside BPF_LD_IMM64 instruction */
4200 insn[0].imm = (u32) (unsigned long) map;
4201 insn[1].imm = ((u64) (unsigned long) map) >> 32;
4202
4203 /* check whether we recorded this map already */
4204 for (j = 0; j < env->used_map_cnt; j++)
4205 if (env->used_maps[j] == map) {
4206 fdput(f);
4207 goto next_insn;
4208 }
4209
4210 if (env->used_map_cnt >= MAX_USED_MAPS) {
4211 fdput(f);
4212 return -E2BIG;
4213 }
4214
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004215 /* hold the map. If the program is rejected by verifier,
4216 * the map will be released by release_maps() or it
4217 * will be used by the valid program until it's unloaded
4218 * and all maps are released in free_bpf_prog_info()
4219 */
Alexei Starovoitov92117d82016-04-27 18:56:20 -07004220 map = bpf_map_inc(map, false);
4221 if (IS_ERR(map)) {
4222 fdput(f);
4223 return PTR_ERR(map);
4224 }
4225 env->used_maps[env->used_map_cnt++] = map;
4226
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004227 fdput(f);
4228next_insn:
4229 insn++;
4230 i++;
4231 }
4232 }
4233
4234 /* now all pseudo BPF_LD_IMM64 instructions load valid
4235 * 'struct bpf_map *' into a register instead of user map_fd.
4236 * These pointers will be used later by verifier to validate map access.
4237 */
4238 return 0;
4239}
4240
4241/* drop refcnt of maps used by the rejected program */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004242static void release_maps(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004243{
4244 int i;
4245
4246 for (i = 0; i < env->used_map_cnt; i++)
4247 bpf_map_put(env->used_maps[i]);
4248}
4249
4250/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004251static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004252{
4253 struct bpf_insn *insn = env->prog->insnsi;
4254 int insn_cnt = env->prog->len;
4255 int i;
4256
4257 for (i = 0; i < insn_cnt; i++, insn++)
4258 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
4259 insn->src_reg = 0;
4260}
4261
Alexei Starovoitov80419022017-03-15 18:26:41 -07004262/* single env->prog->insni[off] instruction was replaced with the range
4263 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
4264 * [0, off) and [off, end) to new locations, so the patched range stays zero
4265 */
4266static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
4267 u32 off, u32 cnt)
4268{
4269 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004270 int i;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004271
4272 if (cnt == 1)
4273 return 0;
4274 new_data = vzalloc(sizeof(struct bpf_insn_aux_data) * prog_len);
4275 if (!new_data)
4276 return -ENOMEM;
4277 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
4278 memcpy(new_data + off + cnt - 1, old_data + off,
4279 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004280 for (i = off; i < off + cnt - 1; i++)
4281 new_data[i].seen = true;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004282 env->insn_aux_data = new_data;
4283 vfree(old_data);
4284 return 0;
4285}
4286
4287static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
4288 const struct bpf_insn *patch, u32 len)
4289{
4290 struct bpf_prog *new_prog;
4291
4292 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
4293 if (!new_prog)
4294 return NULL;
4295 if (adjust_insn_aux_data(env, new_prog->len, off, len))
4296 return NULL;
4297 return new_prog;
4298}
4299
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004300/* The verifier does more data flow analysis than llvm and will not explore
4301 * branches that are dead at run time. Malicious programs can have dead code
4302 * too. Therefore replace all dead at-run-time code with nops.
4303 */
4304static void sanitize_dead_code(struct bpf_verifier_env *env)
4305{
4306 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
4307 struct bpf_insn nop = BPF_MOV64_REG(BPF_REG_0, BPF_REG_0);
4308 struct bpf_insn *insn = env->prog->insnsi;
4309 const int insn_cnt = env->prog->len;
4310 int i;
4311
4312 for (i = 0; i < insn_cnt; i++) {
4313 if (aux_data[i].seen)
4314 continue;
4315 memcpy(insn + i, &nop, sizeof(nop));
4316 }
4317}
4318
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004319/* convert load instructions that access fields of 'struct __sk_buff'
4320 * into sequence of instructions that access fields of 'struct sk_buff'
4321 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004322static int convert_ctx_accesses(struct bpf_verifier_env *env)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004323{
Jakub Kicinski00176a32017-10-16 16:40:54 -07004324 const struct bpf_verifier_ops *ops = env->ops;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004325 int i, cnt, size, ctx_field_size, delta = 0;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004326 const int insn_cnt = env->prog->len;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004327 struct bpf_insn insn_buf[16], *insn;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004328 struct bpf_prog *new_prog;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004329 enum bpf_access_type type;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004330 bool is_narrower_load;
4331 u32 target_size;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004332
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004333 if (ops->gen_prologue) {
4334 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
4335 env->prog);
4336 if (cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004337 verbose(env, "bpf verifier is misconfigured\n");
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004338 return -EINVAL;
4339 } else if (cnt) {
Alexei Starovoitov80419022017-03-15 18:26:41 -07004340 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004341 if (!new_prog)
4342 return -ENOMEM;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004343
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004344 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004345 delta += cnt - 1;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004346 }
4347 }
4348
4349 if (!ops->convert_ctx_access)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004350 return 0;
4351
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004352 insn = env->prog->insnsi + delta;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004353
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004354 for (i = 0; i < insn_cnt; i++, insn++) {
Daniel Borkmann62c79892017-01-12 11:51:33 +01004355 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
4356 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
4357 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07004358 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004359 type = BPF_READ;
Daniel Borkmann62c79892017-01-12 11:51:33 +01004360 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
4361 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
4362 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07004363 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004364 type = BPF_WRITE;
4365 else
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004366 continue;
4367
Alexei Starovoitov80419022017-03-15 18:26:41 -07004368 if (env->insn_aux_data[i + delta].ptr_type != PTR_TO_CTX)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004369 continue;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004370
Yonghong Song31fd8582017-06-13 15:52:13 -07004371 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004372 size = BPF_LDST_BYTES(insn);
Yonghong Song31fd8582017-06-13 15:52:13 -07004373
4374 /* If the read access is a narrower load of the field,
4375 * convert to a 4/8-byte load, to minimum program type specific
4376 * convert_ctx_access changes. If conversion is successful,
4377 * we will apply proper mask to the result.
4378 */
Daniel Borkmannf96da092017-07-02 02:13:27 +02004379 is_narrower_load = size < ctx_field_size;
Yonghong Song31fd8582017-06-13 15:52:13 -07004380 if (is_narrower_load) {
Daniel Borkmannf96da092017-07-02 02:13:27 +02004381 u32 off = insn->off;
4382 u8 size_code;
Yonghong Song31fd8582017-06-13 15:52:13 -07004383
Daniel Borkmannf96da092017-07-02 02:13:27 +02004384 if (type == BPF_WRITE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004385 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
Daniel Borkmannf96da092017-07-02 02:13:27 +02004386 return -EINVAL;
4387 }
4388
4389 size_code = BPF_H;
Yonghong Song31fd8582017-06-13 15:52:13 -07004390 if (ctx_field_size == 4)
4391 size_code = BPF_W;
4392 else if (ctx_field_size == 8)
4393 size_code = BPF_DW;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004394
Yonghong Song31fd8582017-06-13 15:52:13 -07004395 insn->off = off & ~(ctx_field_size - 1);
4396 insn->code = BPF_LDX | BPF_MEM | size_code;
4397 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02004398
4399 target_size = 0;
4400 cnt = ops->convert_ctx_access(type, insn, insn_buf, env->prog,
4401 &target_size);
4402 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
4403 (ctx_field_size && !target_size)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004404 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004405 return -EINVAL;
4406 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02004407
4408 if (is_narrower_load && size < target_size) {
Yonghong Song31fd8582017-06-13 15:52:13 -07004409 if (ctx_field_size <= 4)
4410 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02004411 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07004412 else
4413 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02004414 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07004415 }
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004416
Alexei Starovoitov80419022017-03-15 18:26:41 -07004417 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004418 if (!new_prog)
4419 return -ENOMEM;
4420
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004421 delta += cnt - 1;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004422
4423 /* keep walking new program and skip insns we just inserted */
4424 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004425 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004426 }
4427
4428 return 0;
4429}
4430
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004431/* fixup insn->imm field of bpf_call instructions
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004432 * and inline eligible helpers as explicit sequence of BPF instructions
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004433 *
4434 * this function is called after eBPF program passed verification
4435 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004436static int fixup_bpf_calls(struct bpf_verifier_env *env)
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004437{
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004438 struct bpf_prog *prog = env->prog;
4439 struct bpf_insn *insn = prog->insnsi;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004440 const struct bpf_func_proto *fn;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004441 const int insn_cnt = prog->len;
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004442 struct bpf_insn insn_buf[16];
4443 struct bpf_prog *new_prog;
4444 struct bpf_map *map_ptr;
4445 int i, cnt, delta = 0;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004446
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004447 for (i = 0; i < insn_cnt; i++, insn++) {
4448 if (insn->code != (BPF_JMP | BPF_CALL))
4449 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004450
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004451 if (insn->imm == BPF_FUNC_get_route_realm)
4452 prog->dst_needed = 1;
4453 if (insn->imm == BPF_FUNC_get_prandom_u32)
4454 bpf_user_rnd_init_once();
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004455 if (insn->imm == BPF_FUNC_tail_call) {
David S. Miller7b9f6da2017-04-20 10:35:33 -04004456 /* If we tail call into other programs, we
4457 * cannot make any assumptions since they can
4458 * be replaced dynamically during runtime in
4459 * the program array.
4460 */
4461 prog->cb_access = 1;
Alexei Starovoitov80a58d02017-05-30 13:31:30 -07004462 env->prog->aux->stack_depth = MAX_BPF_STACK;
David S. Miller7b9f6da2017-04-20 10:35:33 -04004463
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004464 /* mark bpf_tail_call as different opcode to avoid
4465 * conditional branch in the interpeter for every normal
4466 * call and to prevent accidental JITing by JIT compiler
4467 * that doesn't support bpf_tail_call yet
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004468 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004469 insn->imm = 0;
Alexei Starovoitov71189fa2017-05-30 13:31:27 -07004470 insn->code = BPF_JMP | BPF_TAIL_CALL;
Alexei Starovoitovb2157392018-01-07 17:33:02 -08004471
4472 /* instead of changing every JIT dealing with tail_call
4473 * emit two extra insns:
4474 * if (index >= max_entries) goto out;
4475 * index &= array->index_mask;
4476 * to avoid out-of-bounds cpu speculation
4477 */
4478 map_ptr = env->insn_aux_data[i + delta].map_ptr;
4479 if (map_ptr == BPF_MAP_PTR_POISON) {
Colin Ian King40950342018-01-10 09:20:54 +00004480 verbose(env, "tail_call abusing map_ptr\n");
Alexei Starovoitovb2157392018-01-07 17:33:02 -08004481 return -EINVAL;
4482 }
4483 if (!map_ptr->unpriv_array)
4484 continue;
4485 insn_buf[0] = BPF_JMP_IMM(BPF_JGE, BPF_REG_3,
4486 map_ptr->max_entries, 2);
4487 insn_buf[1] = BPF_ALU32_IMM(BPF_AND, BPF_REG_3,
4488 container_of(map_ptr,
4489 struct bpf_array,
4490 map)->index_mask);
4491 insn_buf[2] = *insn;
4492 cnt = 3;
4493 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
4494 if (!new_prog)
4495 return -ENOMEM;
4496
4497 delta += cnt - 1;
4498 env->prog = prog = new_prog;
4499 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004500 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004501 }
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004502
Daniel Borkmann89c63072017-08-19 03:12:45 +02004503 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
4504 * handlers are currently limited to 64 bit only.
4505 */
4506 if (ebpf_jit_enabled() && BITS_PER_LONG == 64 &&
4507 insn->imm == BPF_FUNC_map_lookup_elem) {
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004508 map_ptr = env->insn_aux_data[i + delta].map_ptr;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07004509 if (map_ptr == BPF_MAP_PTR_POISON ||
4510 !map_ptr->ops->map_gen_lookup)
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004511 goto patch_call_imm;
4512
4513 cnt = map_ptr->ops->map_gen_lookup(map_ptr, insn_buf);
4514 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004515 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004516 return -EINVAL;
4517 }
4518
4519 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf,
4520 cnt);
4521 if (!new_prog)
4522 return -ENOMEM;
4523
4524 delta += cnt - 1;
4525
4526 /* keep walking new program and skip insns we just inserted */
4527 env->prog = prog = new_prog;
4528 insn = new_prog->insnsi + i + delta;
4529 continue;
4530 }
4531
Daniel Borkmann109980b2017-09-08 00:14:51 +02004532 if (insn->imm == BPF_FUNC_redirect_map) {
Daniel Borkmann7c300132017-09-20 00:44:21 +02004533 /* Note, we cannot use prog directly as imm as subsequent
4534 * rewrites would still change the prog pointer. The only
4535 * stable address we can use is aux, which also works with
4536 * prog clones during blinding.
4537 */
4538 u64 addr = (unsigned long)prog->aux;
Daniel Borkmann109980b2017-09-08 00:14:51 +02004539 struct bpf_insn r4_ld[] = {
4540 BPF_LD_IMM64(BPF_REG_4, addr),
4541 *insn,
4542 };
4543 cnt = ARRAY_SIZE(r4_ld);
4544
4545 new_prog = bpf_patch_insn_data(env, i + delta, r4_ld, cnt);
4546 if (!new_prog)
4547 return -ENOMEM;
4548
4549 delta += cnt - 1;
4550 env->prog = prog = new_prog;
4551 insn = new_prog->insnsi + i + delta;
4552 }
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004553patch_call_imm:
Jakub Kicinski00176a32017-10-16 16:40:54 -07004554 fn = env->ops->get_func_proto(insn->imm);
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004555 /* all functions that have prototype and verifier allowed
4556 * programs to call them, must be real in-kernel functions
4557 */
4558 if (!fn->func) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004559 verbose(env,
4560 "kernel subsystem misconfigured func %s#%d\n",
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004561 func_id_name(insn->imm), insn->imm);
4562 return -EFAULT;
4563 }
4564 insn->imm = fn->func - __bpf_call_base;
4565 }
4566
4567 return 0;
4568}
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004569
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004570static void free_states(struct bpf_verifier_env *env)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004571{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004572 struct bpf_verifier_state_list *sl, *sln;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004573 int i;
4574
4575 if (!env->explored_states)
4576 return;
4577
4578 for (i = 0; i < env->prog->len; i++) {
4579 sl = env->explored_states[i];
4580
4581 if (sl)
4582 while (sl != STATE_LIST_MARK) {
4583 sln = sl->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07004584 free_verifier_state(&sl->state, false);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004585 kfree(sl);
4586 sl = sln;
4587 }
4588 }
4589
4590 kfree(env->explored_states);
4591}
4592
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004593int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004594{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004595 struct bpf_verifier_env *env;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004596 struct bpf_verifer_log *log;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004597 int ret = -EINVAL;
4598
Arnd Bergmanneba0c922017-11-02 12:05:52 +01004599 /* no program is valid */
4600 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
4601 return -EINVAL;
4602
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004603 /* 'struct bpf_verifier_env' can be global, but since it's not small,
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004604 * allocate/free it every time bpf_check() is called
4605 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004606 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004607 if (!env)
4608 return -ENOMEM;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004609 log = &env->log;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004610
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004611 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
4612 (*prog)->len);
4613 ret = -ENOMEM;
4614 if (!env->insn_aux_data)
4615 goto err_free_env;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004616 env->prog = *prog;
Jakub Kicinski00176a32017-10-16 16:40:54 -07004617 env->ops = bpf_verifier_ops[env->prog->type];
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004618
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004619 /* grab the mutex to protect few globals used by verifier */
4620 mutex_lock(&bpf_verifier_lock);
4621
4622 if (attr->log_level || attr->log_buf || attr->log_size) {
4623 /* user requested verbose verifier output
4624 * and supplied buffer to store the verification trace
4625 */
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07004626 log->level = attr->log_level;
4627 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
4628 log->len_total = attr->log_size;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004629
4630 ret = -EINVAL;
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07004631 /* log attributes have to be sane */
4632 if (log->len_total < 128 || log->len_total > UINT_MAX >> 8 ||
4633 !log->level || !log->ubuf)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004634 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004635 }
Daniel Borkmann1ad2f582017-05-25 01:05:05 +02004636
4637 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
4638 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
David S. Millere07b98d2017-05-10 11:38:07 -07004639 env->strict_alignment = true;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004640
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07004641 if (env->prog->aux->offload) {
4642 ret = bpf_prog_offload_verifier_prep(env);
4643 if (ret)
4644 goto err_unlock;
4645 }
4646
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004647 ret = replace_map_fd_with_map_ptr(env);
4648 if (ret < 0)
4649 goto skip_full_check;
4650
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004651 env->explored_states = kcalloc(env->prog->len,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004652 sizeof(struct bpf_verifier_state_list *),
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004653 GFP_USER);
4654 ret = -ENOMEM;
4655 if (!env->explored_states)
4656 goto skip_full_check;
4657
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004658 ret = check_cfg(env);
4659 if (ret < 0)
4660 goto skip_full_check;
4661
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004662 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
4663
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004664 ret = do_check(env);
Craig Gallek8c01c4f2017-11-02 11:18:01 -04004665 if (env->cur_state) {
4666 free_verifier_state(env->cur_state, true);
4667 env->cur_state = NULL;
4668 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004669
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004670skip_full_check:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004671 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004672 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004673
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004674 if (ret == 0)
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004675 sanitize_dead_code(env);
4676
4677 if (ret == 0)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004678 /* program is valid, convert *(u32*)(ctx + off) accesses */
4679 ret = convert_ctx_accesses(env);
4680
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004681 if (ret == 0)
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004682 ret = fixup_bpf_calls(env);
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004683
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004684 if (log->level && bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004685 ret = -ENOSPC;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004686 if (log->level && !log->ubuf) {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004687 ret = -EFAULT;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004688 goto err_release_maps;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004689 }
4690
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004691 if (ret == 0 && env->used_map_cnt) {
4692 /* if program passed verifier, update used_maps in bpf_prog_info */
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004693 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
4694 sizeof(env->used_maps[0]),
4695 GFP_KERNEL);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004696
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004697 if (!env->prog->aux->used_maps) {
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004698 ret = -ENOMEM;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004699 goto err_release_maps;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004700 }
4701
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004702 memcpy(env->prog->aux->used_maps, env->used_maps,
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004703 sizeof(env->used_maps[0]) * env->used_map_cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004704 env->prog->aux->used_map_cnt = env->used_map_cnt;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004705
4706 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
4707 * bpf_ld_imm64 instructions
4708 */
4709 convert_pseudo_ld_imm64(env);
4710 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004711
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004712err_release_maps:
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004713 if (!env->prog->aux->used_maps)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004714 /* if we didn't copy map pointers into bpf_prog_info, release
4715 * them now. Otherwise free_bpf_prog_info() will release them.
4716 */
4717 release_maps(env);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004718 *prog = env->prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004719err_unlock:
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004720 mutex_unlock(&bpf_verifier_lock);
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004721 vfree(env->insn_aux_data);
4722err_free_env:
4723 kfree(env);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004724 return ret;
4725}