blob: 982bd9ec721ae5fa9af11ddb534e4b78aefcef2d [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002 * Copyright (c) 2016 Facebook
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +010017#include <linux/bpf_verifier.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070018#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
Thomas Grafebb676d2016-10-27 11:23:51 +020022#include <linux/stringify.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070023
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -070024#include "disasm.h"
25
Jakub Kicinski00176a32017-10-16 16:40:54 -070026static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
27#define BPF_PROG_TYPE(_id, _name) \
28 [_id] = & _name ## _verifier_ops,
29#define BPF_MAP_TYPE(_id, _ops)
30#include <linux/bpf_types.h>
31#undef BPF_PROG_TYPE
32#undef BPF_MAP_TYPE
33};
34
Alexei Starovoitov51580e72014-09-26 00:17:02 -070035/* bpf_check() is a static code analyzer that walks eBPF program
36 * instruction by instruction and updates register/stack state.
37 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
38 *
39 * The first pass is depth-first-search to check that the program is a DAG.
40 * It rejects the following programs:
41 * - larger than BPF_MAXINSNS insns
42 * - if loop is present (detected via back-edge)
43 * - unreachable insns exist (shouldn't be a forest. program = one function)
44 * - out of bounds or malformed jumps
45 * The second pass is all possible path descent from the 1st insn.
46 * Since it's analyzing all pathes through the program, the length of the
Gary Lineba38a92017-03-01 16:25:51 +080047 * analysis is limited to 64k insn, which may be hit even if total number of
Alexei Starovoitov51580e72014-09-26 00:17:02 -070048 * insn is less then 4K, but there are too many branches that change stack/regs.
49 * Number of 'branches to be analyzed' is limited to 1k
50 *
51 * On entry to each instruction, each register has a type, and the instruction
52 * changes the types of the registers depending on instruction semantics.
53 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
54 * copied to R1.
55 *
56 * All registers are 64-bit.
57 * R0 - return register
58 * R1-R5 argument passing registers
59 * R6-R9 callee saved registers
60 * R10 - frame pointer read-only
61 *
62 * At the start of BPF program the register R1 contains a pointer to bpf_context
63 * and has type PTR_TO_CTX.
64 *
65 * Verifier tracks arithmetic operations on pointers in case:
66 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
67 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
68 * 1st insn copies R10 (which has FRAME_PTR) type into R1
69 * and 2nd arithmetic instruction is pattern matched to recognize
70 * that it wants to construct a pointer to some element within stack.
71 * So after 2nd insn, the register R1 has type PTR_TO_STACK
72 * (and -20 constant is saved for further stack bounds checking).
73 * Meaning that this reg is a pointer to stack plus known immediate constant.
74 *
Edward Creef1174f72017-08-07 15:26:19 +010075 * Most of the time the registers have SCALAR_VALUE type, which
Alexei Starovoitov51580e72014-09-26 00:17:02 -070076 * means the register has some value, but it's not a valid pointer.
Edward Creef1174f72017-08-07 15:26:19 +010077 * (like pointer plus pointer becomes SCALAR_VALUE type)
Alexei Starovoitov51580e72014-09-26 00:17:02 -070078 *
79 * When verifier sees load or store instructions the type of base register
Edward Creef1174f72017-08-07 15:26:19 +010080 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK. These are three pointer
Alexei Starovoitov51580e72014-09-26 00:17:02 -070081 * types recognized by check_mem_access() function.
82 *
83 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
84 * and the range of [ptr, ptr + map's value_size) is accessible.
85 *
86 * registers used to pass values to function calls are checked against
87 * function argument constraints.
88 *
89 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
90 * It means that the register type passed to this function must be
91 * PTR_TO_STACK and it will be used inside the function as
92 * 'pointer to map element key'
93 *
94 * For example the argument constraints for bpf_map_lookup_elem():
95 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
96 * .arg1_type = ARG_CONST_MAP_PTR,
97 * .arg2_type = ARG_PTR_TO_MAP_KEY,
98 *
99 * ret_type says that this function returns 'pointer to map elem value or null'
100 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
101 * 2nd argument should be a pointer to stack, which will be used inside
102 * the helper function as a pointer to map element key.
103 *
104 * On the kernel side the helper function looks like:
105 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
106 * {
107 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
108 * void *key = (void *) (unsigned long) r2;
109 * void *value;
110 *
111 * here kernel can access 'key' and 'map' pointers safely, knowing that
112 * [key, key + map->key_size) bytes are valid and were initialized on
113 * the stack of eBPF program.
114 * }
115 *
116 * Corresponding eBPF program may look like:
117 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
118 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
119 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
120 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
121 * here verifier looks at prototype of map_lookup_elem() and sees:
122 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
123 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
124 *
125 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
126 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
127 * and were initialized prior to this call.
128 * If it's ok, then verifier allows this BPF_CALL insn and looks at
129 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
130 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
131 * returns ether pointer to map value or NULL.
132 *
133 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
134 * insn, the register holding that pointer in the true branch changes state to
135 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
136 * branch. See check_cond_jmp_op().
137 *
138 * After the call R0 is set to return type of the function and registers R1-R5
139 * are set to NOT_INIT to indicate that they are no longer readable.
140 */
141
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700142/* verifier_state + insn_idx are pushed to stack when branch is encountered */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100143struct bpf_verifier_stack_elem {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700144 /* verifer state is 'st'
145 * before processing instruction 'insn_idx'
146 * and after processing instruction 'prev_insn_idx'
147 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100148 struct bpf_verifier_state st;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700149 int insn_idx;
150 int prev_insn_idx;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100151 struct bpf_verifier_stack_elem *next;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700152};
153
Edward Cree8e17c1b2017-08-07 15:30:30 +0100154#define BPF_COMPLEXITY_LIMIT_INSNS 131072
Daniel Borkmann07016152016-04-05 22:33:17 +0200155#define BPF_COMPLEXITY_LIMIT_STACK 1024
156
Martin KaFai Laufad73a12017-03-22 10:00:32 -0700157#define BPF_MAP_PTR_POISON ((void *)0xeB9F + POISON_POINTER_DELTA)
158
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200159struct bpf_call_arg_meta {
160 struct bpf_map *map_ptr;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200161 bool raw_mode;
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200162 bool pkt_access;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200163 int regno;
164 int access_size;
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200165};
166
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700167static DEFINE_MUTEX(bpf_verifier_lock);
168
169/* log_level controls verbosity level of eBPF verifier.
170 * verbose() is used to dump the verification trace to the log, so the user
171 * can figure out what's wrong with the program
172 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700173static __printf(2, 3) void verbose(struct bpf_verifier_env *env,
174 const char *fmt, ...)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700175{
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700176 struct bpf_verifer_log *log = &env->log;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700177 unsigned int n;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700178 va_list args;
179
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700180 if (!log->level || !log->ubuf || bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700181 return;
182
183 va_start(args, fmt);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700184 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700185 va_end(args);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700186
187 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
188 "verifier log line truncated - local buffer too short\n");
189
190 n = min(log->len_total - log->len_used - 1, n);
191 log->kbuf[n] = '\0';
192
193 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
194 log->len_used += n;
195 else
196 log->ubuf = NULL;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700197}
198
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200199static bool type_is_pkt_pointer(enum bpf_reg_type type)
200{
201 return type == PTR_TO_PACKET ||
202 type == PTR_TO_PACKET_META;
203}
204
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700205/* string representation of 'enum bpf_reg_type' */
206static const char * const reg_type_str[] = {
207 [NOT_INIT] = "?",
Edward Creef1174f72017-08-07 15:26:19 +0100208 [SCALAR_VALUE] = "inv",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700209 [PTR_TO_CTX] = "ctx",
210 [CONST_PTR_TO_MAP] = "map_ptr",
211 [PTR_TO_MAP_VALUE] = "map_value",
212 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700213 [PTR_TO_STACK] = "fp",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700214 [PTR_TO_PACKET] = "pkt",
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200215 [PTR_TO_PACKET_META] = "pkt_meta",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700216 [PTR_TO_PACKET_END] = "pkt_end",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700217};
218
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700219static void print_verifier_state(struct bpf_verifier_env *env,
220 struct bpf_verifier_state *state)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700221{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100222 struct bpf_reg_state *reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700223 enum bpf_reg_type t;
224 int i;
225
226 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700227 reg = &state->regs[i];
228 t = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700229 if (t == NOT_INIT)
230 continue;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700231 verbose(env, " R%d=%s", i, reg_type_str[t]);
Edward Creef1174f72017-08-07 15:26:19 +0100232 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
233 tnum_is_const(reg->var_off)) {
234 /* reg->off should be 0 for SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700235 verbose(env, "%lld", reg->var_off.value + reg->off);
Edward Creef1174f72017-08-07 15:26:19 +0100236 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700237 verbose(env, "(id=%d", reg->id);
Edward Creef1174f72017-08-07 15:26:19 +0100238 if (t != SCALAR_VALUE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700239 verbose(env, ",off=%d", reg->off);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200240 if (type_is_pkt_pointer(t))
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700241 verbose(env, ",r=%d", reg->range);
Edward Creef1174f72017-08-07 15:26:19 +0100242 else if (t == CONST_PTR_TO_MAP ||
243 t == PTR_TO_MAP_VALUE ||
244 t == PTR_TO_MAP_VALUE_OR_NULL)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700245 verbose(env, ",ks=%d,vs=%d",
Edward Creef1174f72017-08-07 15:26:19 +0100246 reg->map_ptr->key_size,
247 reg->map_ptr->value_size);
Edward Cree7d1238f2017-08-07 15:26:56 +0100248 if (tnum_is_const(reg->var_off)) {
249 /* Typically an immediate SCALAR_VALUE, but
250 * could be a pointer whose offset is too big
251 * for reg->off
252 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700253 verbose(env, ",imm=%llx", reg->var_off.value);
Edward Cree7d1238f2017-08-07 15:26:56 +0100254 } else {
255 if (reg->smin_value != reg->umin_value &&
256 reg->smin_value != S64_MIN)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700257 verbose(env, ",smin_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100258 (long long)reg->smin_value);
259 if (reg->smax_value != reg->umax_value &&
260 reg->smax_value != S64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700261 verbose(env, ",smax_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100262 (long long)reg->smax_value);
263 if (reg->umin_value != 0)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700264 verbose(env, ",umin_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100265 (unsigned long long)reg->umin_value);
266 if (reg->umax_value != U64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700267 verbose(env, ",umax_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100268 (unsigned long long)reg->umax_value);
269 if (!tnum_is_unknown(reg->var_off)) {
270 char tn_buf[48];
Edward Creef1174f72017-08-07 15:26:19 +0100271
Edward Cree7d1238f2017-08-07 15:26:56 +0100272 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700273 verbose(env, ",var_off=%s", tn_buf);
Edward Cree7d1238f2017-08-07 15:26:56 +0100274 }
Edward Creef1174f72017-08-07 15:26:19 +0100275 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700276 verbose(env, ")");
Edward Creef1174f72017-08-07 15:26:19 +0100277 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700278 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700279 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
280 if (state->stack[i].slot_type[0] == STACK_SPILL)
281 verbose(env, " fp%d=%s",
282 -MAX_BPF_STACK + i * BPF_REG_SIZE,
283 reg_type_str[state->stack[i].spilled_ptr.type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700284 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700285 verbose(env, "\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700286}
287
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700288static int copy_stack_state(struct bpf_verifier_state *dst,
289 const struct bpf_verifier_state *src)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700290{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700291 if (!src->stack)
292 return 0;
293 if (WARN_ON_ONCE(dst->allocated_stack < src->allocated_stack)) {
294 /* internal bug, make state invalid to reject the program */
295 memset(dst, 0, sizeof(*dst));
296 return -EFAULT;
297 }
298 memcpy(dst->stack, src->stack,
299 sizeof(*src->stack) * (src->allocated_stack / BPF_REG_SIZE));
300 return 0;
301}
302
303/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
304 * make it consume minimal amount of memory. check_stack_write() access from
305 * the program calls into realloc_verifier_state() to grow the stack size.
306 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
307 * which this function copies over. It points to previous bpf_verifier_state
308 * which is never reallocated
309 */
310static int realloc_verifier_state(struct bpf_verifier_state *state, int size,
311 bool copy_old)
312{
313 u32 old_size = state->allocated_stack;
314 struct bpf_stack_state *new_stack;
315 int slot = size / BPF_REG_SIZE;
316
317 if (size <= old_size || !size) {
318 if (copy_old)
319 return 0;
320 state->allocated_stack = slot * BPF_REG_SIZE;
321 if (!size && old_size) {
322 kfree(state->stack);
323 state->stack = NULL;
324 }
325 return 0;
326 }
327 new_stack = kmalloc_array(slot, sizeof(struct bpf_stack_state),
328 GFP_KERNEL);
329 if (!new_stack)
330 return -ENOMEM;
331 if (copy_old) {
332 if (state->stack)
333 memcpy(new_stack, state->stack,
334 sizeof(*new_stack) * (old_size / BPF_REG_SIZE));
335 memset(new_stack + old_size / BPF_REG_SIZE, 0,
336 sizeof(*new_stack) * (size - old_size) / BPF_REG_SIZE);
337 }
338 state->allocated_stack = slot * BPF_REG_SIZE;
339 kfree(state->stack);
340 state->stack = new_stack;
341 return 0;
342}
343
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700344static void free_verifier_state(struct bpf_verifier_state *state,
345 bool free_self)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700346{
347 kfree(state->stack);
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700348 if (free_self)
349 kfree(state);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700350}
351
352/* copy verifier state from src to dst growing dst stack space
353 * when necessary to accommodate larger src stack
354 */
355static int copy_verifier_state(struct bpf_verifier_state *dst,
356 const struct bpf_verifier_state *src)
357{
358 int err;
359
360 err = realloc_verifier_state(dst, src->allocated_stack, false);
361 if (err)
362 return err;
363 memcpy(dst, src, offsetof(struct bpf_verifier_state, allocated_stack));
364 return copy_stack_state(dst, src);
365}
366
367static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
368 int *insn_idx)
369{
370 struct bpf_verifier_state *cur = env->cur_state;
371 struct bpf_verifier_stack_elem *elem, *head = env->head;
372 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700373
374 if (env->head == NULL)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700375 return -ENOENT;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700376
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700377 if (cur) {
378 err = copy_verifier_state(cur, &head->st);
379 if (err)
380 return err;
381 }
382 if (insn_idx)
383 *insn_idx = head->insn_idx;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700384 if (prev_insn_idx)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700385 *prev_insn_idx = head->prev_insn_idx;
386 elem = head->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700387 free_verifier_state(&head->st, false);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700388 kfree(head);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700389 env->head = elem;
390 env->stack_size--;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700391 return 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700392}
393
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100394static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
395 int insn_idx, int prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700396{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700397 struct bpf_verifier_state *cur = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100398 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700399 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700400
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700401 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700402 if (!elem)
403 goto err;
404
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700405 elem->insn_idx = insn_idx;
406 elem->prev_insn_idx = prev_insn_idx;
407 elem->next = env->head;
408 env->head = elem;
409 env->stack_size++;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700410 err = copy_verifier_state(&elem->st, cur);
411 if (err)
412 goto err;
Daniel Borkmann07016152016-04-05 22:33:17 +0200413 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700414 verbose(env, "BPF program is too complex\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700415 goto err;
416 }
417 return &elem->st;
418err:
419 /* pop all elements and return */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700420 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700421 return NULL;
422}
423
424#define CALLER_SAVED_REGS 6
425static const int caller_saved[CALLER_SAVED_REGS] = {
426 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
427};
428
Edward Creef1174f72017-08-07 15:26:19 +0100429static void __mark_reg_not_init(struct bpf_reg_state *reg);
430
Edward Creeb03c9f92017-08-07 15:26:36 +0100431/* Mark the unknown part of a register (variable offset or scalar value) as
432 * known to have the value @imm.
433 */
434static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
435{
436 reg->id = 0;
437 reg->var_off = tnum_const(imm);
438 reg->smin_value = (s64)imm;
439 reg->smax_value = (s64)imm;
440 reg->umin_value = imm;
441 reg->umax_value = imm;
442}
443
Edward Creef1174f72017-08-07 15:26:19 +0100444/* Mark the 'variable offset' part of a register as zero. This should be
445 * used only on registers holding a pointer type.
446 */
447static void __mark_reg_known_zero(struct bpf_reg_state *reg)
448{
Edward Creeb03c9f92017-08-07 15:26:36 +0100449 __mark_reg_known(reg, 0);
Edward Creef1174f72017-08-07 15:26:19 +0100450}
451
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700452static void mark_reg_known_zero(struct bpf_verifier_env *env,
453 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100454{
455 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700456 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100457 /* Something bad happened, let's kill all regs */
458 for (regno = 0; regno < MAX_BPF_REG; regno++)
459 __mark_reg_not_init(regs + regno);
460 return;
461 }
462 __mark_reg_known_zero(regs + regno);
463}
464
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200465static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
466{
467 return type_is_pkt_pointer(reg->type);
468}
469
470static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
471{
472 return reg_is_pkt_pointer(reg) ||
473 reg->type == PTR_TO_PACKET_END;
474}
475
476/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
477static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
478 enum bpf_reg_type which)
479{
480 /* The register can already have a range from prior markings.
481 * This is fine as long as it hasn't been advanced from its
482 * origin.
483 */
484 return reg->type == which &&
485 reg->id == 0 &&
486 reg->off == 0 &&
487 tnum_equals_const(reg->var_off, 0);
488}
489
Edward Creeb03c9f92017-08-07 15:26:36 +0100490/* Attempts to improve min/max values based on var_off information */
491static void __update_reg_bounds(struct bpf_reg_state *reg)
492{
493 /* min signed is max(sign bit) | min(other bits) */
494 reg->smin_value = max_t(s64, reg->smin_value,
495 reg->var_off.value | (reg->var_off.mask & S64_MIN));
496 /* max signed is min(sign bit) | max(other bits) */
497 reg->smax_value = min_t(s64, reg->smax_value,
498 reg->var_off.value | (reg->var_off.mask & S64_MAX));
499 reg->umin_value = max(reg->umin_value, reg->var_off.value);
500 reg->umax_value = min(reg->umax_value,
501 reg->var_off.value | reg->var_off.mask);
502}
503
504/* Uses signed min/max values to inform unsigned, and vice-versa */
505static void __reg_deduce_bounds(struct bpf_reg_state *reg)
506{
507 /* Learn sign from signed bounds.
508 * If we cannot cross the sign boundary, then signed and unsigned bounds
509 * are the same, so combine. This works even in the negative case, e.g.
510 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
511 */
512 if (reg->smin_value >= 0 || reg->smax_value < 0) {
513 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
514 reg->umin_value);
515 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
516 reg->umax_value);
517 return;
518 }
519 /* Learn sign from unsigned bounds. Signed bounds cross the sign
520 * boundary, so we must be careful.
521 */
522 if ((s64)reg->umax_value >= 0) {
523 /* Positive. We can't learn anything from the smin, but smax
524 * is positive, hence safe.
525 */
526 reg->smin_value = reg->umin_value;
527 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
528 reg->umax_value);
529 } else if ((s64)reg->umin_value < 0) {
530 /* Negative. We can't learn anything from the smax, but smin
531 * is negative, hence safe.
532 */
533 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
534 reg->umin_value);
535 reg->smax_value = reg->umax_value;
536 }
537}
538
539/* Attempts to improve var_off based on unsigned min/max information */
540static void __reg_bound_offset(struct bpf_reg_state *reg)
541{
542 reg->var_off = tnum_intersect(reg->var_off,
543 tnum_range(reg->umin_value,
544 reg->umax_value));
545}
546
547/* Reset the min/max bounds of a register */
548static void __mark_reg_unbounded(struct bpf_reg_state *reg)
549{
550 reg->smin_value = S64_MIN;
551 reg->smax_value = S64_MAX;
552 reg->umin_value = 0;
553 reg->umax_value = U64_MAX;
554}
555
Edward Creef1174f72017-08-07 15:26:19 +0100556/* Mark a register as having a completely unknown (scalar) value. */
557static void __mark_reg_unknown(struct bpf_reg_state *reg)
558{
559 reg->type = SCALAR_VALUE;
560 reg->id = 0;
561 reg->off = 0;
562 reg->var_off = tnum_unknown;
Edward Creeb03c9f92017-08-07 15:26:36 +0100563 __mark_reg_unbounded(reg);
Edward Creef1174f72017-08-07 15:26:19 +0100564}
565
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700566static void mark_reg_unknown(struct bpf_verifier_env *env,
567 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100568{
569 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700570 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100571 /* Something bad happened, let's kill all regs */
572 for (regno = 0; regno < MAX_BPF_REG; regno++)
573 __mark_reg_not_init(regs + regno);
574 return;
575 }
576 __mark_reg_unknown(regs + regno);
577}
578
579static void __mark_reg_not_init(struct bpf_reg_state *reg)
580{
581 __mark_reg_unknown(reg);
582 reg->type = NOT_INIT;
583}
584
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700585static void mark_reg_not_init(struct bpf_verifier_env *env,
586 struct bpf_reg_state *regs, u32 regno)
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200587{
Edward Creef1174f72017-08-07 15:26:19 +0100588 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700589 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100590 /* Something bad happened, let's kill all regs */
591 for (regno = 0; regno < MAX_BPF_REG; regno++)
592 __mark_reg_not_init(regs + regno);
593 return;
594 }
595 __mark_reg_not_init(regs + regno);
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200596}
597
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700598static void init_reg_state(struct bpf_verifier_env *env,
599 struct bpf_reg_state *regs)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700600{
601 int i;
602
Edward Creedc503a82017-08-15 20:34:35 +0100603 for (i = 0; i < MAX_BPF_REG; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700604 mark_reg_not_init(env, regs, i);
Edward Creedc503a82017-08-15 20:34:35 +0100605 regs[i].live = REG_LIVE_NONE;
606 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700607
608 /* frame pointer */
Edward Creef1174f72017-08-07 15:26:19 +0100609 regs[BPF_REG_FP].type = PTR_TO_STACK;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700610 mark_reg_known_zero(env, regs, BPF_REG_FP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700611
612 /* 1st arg to a function */
613 regs[BPF_REG_1].type = PTR_TO_CTX;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700614 mark_reg_known_zero(env, regs, BPF_REG_1);
Daniel Borkmann6760bf22016-12-18 01:52:59 +0100615}
616
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700617enum reg_arg_type {
618 SRC_OP, /* register is used as source operand */
619 DST_OP, /* register is used as destination operand */
620 DST_OP_NO_MARK /* same as above, check only, don't mark */
621};
622
Edward Creedc503a82017-08-15 20:34:35 +0100623static void mark_reg_read(const struct bpf_verifier_state *state, u32 regno)
624{
625 struct bpf_verifier_state *parent = state->parent;
626
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -0700627 if (regno == BPF_REG_FP)
628 /* We don't need to worry about FP liveness because it's read-only */
629 return;
630
Edward Creedc503a82017-08-15 20:34:35 +0100631 while (parent) {
632 /* if read wasn't screened by an earlier write ... */
633 if (state->regs[regno].live & REG_LIVE_WRITTEN)
634 break;
635 /* ... then we depend on parent's value */
636 parent->regs[regno].live |= REG_LIVE_READ;
637 state = parent;
638 parent = state->parent;
639 }
640}
641
642static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700643 enum reg_arg_type t)
644{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700645 struct bpf_reg_state *regs = env->cur_state->regs;
Edward Creedc503a82017-08-15 20:34:35 +0100646
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700647 if (regno >= MAX_BPF_REG) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700648 verbose(env, "R%d is invalid\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700649 return -EINVAL;
650 }
651
652 if (t == SRC_OP) {
653 /* check whether register used as source operand can be read */
654 if (regs[regno].type == NOT_INIT) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700655 verbose(env, "R%d !read_ok\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700656 return -EACCES;
657 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700658 mark_reg_read(env->cur_state, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700659 } else {
660 /* check whether register used as dest operand can be written to */
661 if (regno == BPF_REG_FP) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700662 verbose(env, "frame pointer is read only\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700663 return -EACCES;
664 }
Edward Creedc503a82017-08-15 20:34:35 +0100665 regs[regno].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700666 if (t == DST_OP)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700667 mark_reg_unknown(env, regs, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700668 }
669 return 0;
670}
671
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700672static bool is_spillable_regtype(enum bpf_reg_type type)
673{
674 switch (type) {
675 case PTR_TO_MAP_VALUE:
676 case PTR_TO_MAP_VALUE_OR_NULL:
677 case PTR_TO_STACK:
678 case PTR_TO_CTX:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700679 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200680 case PTR_TO_PACKET_META:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700681 case PTR_TO_PACKET_END:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700682 case CONST_PTR_TO_MAP:
683 return true;
684 default:
685 return false;
686 }
687}
688
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700689/* check_stack_read/write functions track spill/fill of registers,
690 * stack boundary and alignment are checked in check_mem_access()
691 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700692static int check_stack_write(struct bpf_verifier_env *env,
693 struct bpf_verifier_state *state, int off,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100694 int size, int value_regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700695{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700696 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
697
698 err = realloc_verifier_state(state, round_up(slot + 1, BPF_REG_SIZE),
699 true);
700 if (err)
701 return err;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700702 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
703 * so it's aligned access and [off, off + size) are within stack limits
704 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700705 if (!env->allow_ptr_leaks &&
706 state->stack[spi].slot_type[0] == STACK_SPILL &&
707 size != BPF_REG_SIZE) {
708 verbose(env, "attempt to corrupt spilled pointer on stack\n");
709 return -EACCES;
710 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700711
712 if (value_regno >= 0 &&
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700713 is_spillable_regtype(state->regs[value_regno].type)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700714
715 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700716 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700717 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700718 return -EACCES;
719 }
720
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700721 /* save register state */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700722 state->stack[spi].spilled_ptr = state->regs[value_regno];
723 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700724
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700725 for (i = 0; i < BPF_REG_SIZE; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700726 state->stack[spi].slot_type[i] = STACK_SPILL;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700727 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700728 /* regular write of data into stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700729 state->stack[spi].spilled_ptr = (struct bpf_reg_state) {};
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700730
731 for (i = 0; i < size; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700732 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
733 STACK_MISC;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700734 }
735 return 0;
736}
737
Edward Creedc503a82017-08-15 20:34:35 +0100738static void mark_stack_slot_read(const struct bpf_verifier_state *state, int slot)
739{
740 struct bpf_verifier_state *parent = state->parent;
741
742 while (parent) {
743 /* if read wasn't screened by an earlier write ... */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700744 if (state->stack[slot].spilled_ptr.live & REG_LIVE_WRITTEN)
Edward Creedc503a82017-08-15 20:34:35 +0100745 break;
746 /* ... then we depend on parent's value */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700747 parent->stack[slot].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +0100748 state = parent;
749 parent = state->parent;
750 }
751}
752
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700753static int check_stack_read(struct bpf_verifier_env *env,
754 struct bpf_verifier_state *state, int off, int size,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700755 int value_regno)
756{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700757 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
758 u8 *stype;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700759
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700760 if (state->allocated_stack <= slot) {
761 verbose(env, "invalid read from stack off %d+0 size %d\n",
762 off, size);
763 return -EACCES;
764 }
765 stype = state->stack[spi].slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700766
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700767 if (stype[0] == STACK_SPILL) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700768 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700769 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700770 return -EACCES;
771 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700772 for (i = 1; i < BPF_REG_SIZE; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700773 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700774 verbose(env, "corrupted spill memory\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700775 return -EACCES;
776 }
777 }
778
Edward Creedc503a82017-08-15 20:34:35 +0100779 if (value_regno >= 0) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700780 /* restore register state from stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700781 state->regs[value_regno] = state->stack[spi].spilled_ptr;
Edward Creedc503a82017-08-15 20:34:35 +0100782 mark_stack_slot_read(state, spi);
783 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700784 return 0;
785 } else {
786 for (i = 0; i < size; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700787 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_MISC) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700788 verbose(env, "invalid read from stack off %d+%d size %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700789 off, i, size);
790 return -EACCES;
791 }
792 }
793 if (value_regno >= 0)
794 /* have read misc data from the stack */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700795 mark_reg_unknown(env, state->regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700796 return 0;
797 }
798}
799
800/* check read/write into map element returned by bpf_map_lookup_elem() */
Edward Creef1174f72017-08-07 15:26:19 +0100801static int __check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800802 int size, bool zero_size_allowed)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700803{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700804 struct bpf_reg_state *regs = cur_regs(env);
805 struct bpf_map *map = regs[regno].map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700806
Yonghong Song9fd29c02017-11-12 14:49:09 -0800807 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
808 off + size > map->value_size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700809 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700810 map->value_size, off, size);
811 return -EACCES;
812 }
813 return 0;
814}
815
Edward Creef1174f72017-08-07 15:26:19 +0100816/* check read/write into a map element with possible variable offset */
817static int check_map_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800818 int off, int size, bool zero_size_allowed)
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800819{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700820 struct bpf_verifier_state *state = env->cur_state;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800821 struct bpf_reg_state *reg = &state->regs[regno];
822 int err;
823
Edward Creef1174f72017-08-07 15:26:19 +0100824 /* We may have adjusted the register to this map value, so we
825 * need to try adding each of min_value and max_value to off
826 * to make sure our theoretical access will be safe.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800827 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700828 if (env->log.level)
829 print_verifier_state(env, state);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800830 /* The minimum value is only important with signed
831 * comparisons where we can't assume the floor of a
832 * value is 0. If we are using signed variables for our
833 * index'es we need to make sure that whatever we use
834 * will have a set floor within our range.
835 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100836 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700837 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800838 regno);
839 return -EACCES;
840 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800841 err = __check_map_access(env, regno, reg->smin_value + off, size,
842 zero_size_allowed);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800843 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700844 verbose(env, "R%d min value is outside of the array range\n",
845 regno);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800846 return err;
847 }
848
Edward Creeb03c9f92017-08-07 15:26:36 +0100849 /* If we haven't set a max value then we need to bail since we can't be
850 * sure we won't do bad things.
851 * If reg->umax_value + off could overflow, treat that as unbounded too.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800852 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100853 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700854 verbose(env, "R%d unbounded memory access, make sure to bounds check any array access into a map\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800855 regno);
856 return -EACCES;
857 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800858 err = __check_map_access(env, regno, reg->umax_value + off, size,
859 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +0100860 if (err)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700861 verbose(env, "R%d max value is outside of the array range\n",
862 regno);
Edward Creef1174f72017-08-07 15:26:19 +0100863 return err;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800864}
865
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700866#define MAX_PACKET_OFF 0xffff
867
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100868static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100869 const struct bpf_call_arg_meta *meta,
870 enum bpf_access_type t)
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700871{
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200872 switch (env->prog->type) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100873 case BPF_PROG_TYPE_LWT_IN:
874 case BPF_PROG_TYPE_LWT_OUT:
875 /* dst_input() and dst_output() can't write for now */
876 if (t == BPF_WRITE)
877 return false;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +0100878 /* fallthrough */
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200879 case BPF_PROG_TYPE_SCHED_CLS:
880 case BPF_PROG_TYPE_SCHED_ACT:
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700881 case BPF_PROG_TYPE_XDP:
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100882 case BPF_PROG_TYPE_LWT_XMIT:
John Fastabend8a31db52017-08-15 22:33:09 -0700883 case BPF_PROG_TYPE_SK_SKB:
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200884 if (meta)
885 return meta->pkt_access;
886
887 env->seen_direct_write = true;
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700888 return true;
889 default:
890 return false;
891 }
892}
893
Edward Creef1174f72017-08-07 15:26:19 +0100894static int __check_packet_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800895 int off, int size, bool zero_size_allowed)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700896{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700897 struct bpf_reg_state *regs = cur_regs(env);
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100898 struct bpf_reg_state *reg = &regs[regno];
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700899
Yonghong Song9fd29c02017-11-12 14:49:09 -0800900 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
901 (u64)off + size > reg->range) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700902 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -0700903 off, size, regno, reg->id, reg->off, reg->range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700904 return -EACCES;
905 }
906 return 0;
907}
908
Edward Creef1174f72017-08-07 15:26:19 +0100909static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800910 int size, bool zero_size_allowed)
Edward Creef1174f72017-08-07 15:26:19 +0100911{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700912 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +0100913 struct bpf_reg_state *reg = &regs[regno];
914 int err;
915
916 /* We may have added a variable offset to the packet pointer; but any
917 * reg->range we have comes after that. We are only checking the fixed
918 * offset.
919 */
920
921 /* We don't allow negative numbers, because we aren't tracking enough
922 * detail to prove they're safe.
923 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100924 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700925 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Edward Creef1174f72017-08-07 15:26:19 +0100926 regno);
927 return -EACCES;
928 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800929 err = __check_packet_access(env, regno, off, size, zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +0100930 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700931 verbose(env, "R%d offset is outside of the packet\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100932 return err;
933 }
934 return err;
935}
936
937/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
Yonghong Song31fd8582017-06-13 15:52:13 -0700938static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700939 enum bpf_access_type t, enum bpf_reg_type *reg_type)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700940{
Daniel Borkmannf96da092017-07-02 02:13:27 +0200941 struct bpf_insn_access_aux info = {
942 .reg_type = *reg_type,
943 };
Yonghong Song31fd8582017-06-13 15:52:13 -0700944
Jakub Kicinski4f9218a2017-10-16 16:40:55 -0700945 if (env->ops->is_valid_access &&
946 env->ops->is_valid_access(off, size, t, &info)) {
Daniel Borkmannf96da092017-07-02 02:13:27 +0200947 /* A non zero info.ctx_field_size indicates that this field is a
948 * candidate for later verifier transformation to load the whole
949 * field and then apply a mask when accessed with a narrower
950 * access than actual ctx access size. A zero info.ctx_field_size
951 * will only allow for whole field access and rejects any other
952 * type of narrower access.
Yonghong Song31fd8582017-06-13 15:52:13 -0700953 */
Yonghong Song23994632017-06-22 15:07:39 -0700954 *reg_type = info.reg_type;
Yonghong Song31fd8582017-06-13 15:52:13 -0700955
Jakub Kicinski4f9218a2017-10-16 16:40:55 -0700956 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700957 /* remember the offset of last byte accessed in ctx */
958 if (env->prog->aux->max_ctx_offset < off + size)
959 env->prog->aux->max_ctx_offset = off + size;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700960 return 0;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700961 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700962
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700963 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700964 return -EACCES;
965}
966
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200967static bool __is_pointer_value(bool allow_ptr_leaks,
968 const struct bpf_reg_state *reg)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700969{
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200970 if (allow_ptr_leaks)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700971 return false;
972
Edward Creef1174f72017-08-07 15:26:19 +0100973 return reg->type != SCALAR_VALUE;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700974}
975
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200976static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
977{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700978 return __is_pointer_value(env->allow_ptr_leaks, cur_regs(env) + regno);
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200979}
980
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700981static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
982 const struct bpf_reg_state *reg,
David S. Millerd1174412017-05-10 11:22:52 -0700983 int off, int size, bool strict)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700984{
Edward Creef1174f72017-08-07 15:26:19 +0100985 struct tnum reg_off;
David S. Millere07b98d2017-05-10 11:38:07 -0700986 int ip_align;
David S. Millerd1174412017-05-10 11:22:52 -0700987
988 /* Byte size accesses are always allowed. */
989 if (!strict || size == 1)
990 return 0;
991
David S. Millere4eda882017-05-22 12:27:07 -0400992 /* For platforms that do not have a Kconfig enabling
993 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
994 * NET_IP_ALIGN is universally set to '2'. And on platforms
995 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
996 * to this code only in strict mode where we want to emulate
997 * the NET_IP_ALIGN==2 checking. Therefore use an
998 * unconditional IP align value of '2'.
David S. Millere07b98d2017-05-10 11:38:07 -0700999 */
David S. Millere4eda882017-05-22 12:27:07 -04001000 ip_align = 2;
Edward Creef1174f72017-08-07 15:26:19 +01001001
1002 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
1003 if (!tnum_is_aligned(reg_off, size)) {
1004 char tn_buf[48];
1005
1006 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001007 verbose(env,
1008 "misaligned packet access off %d+%s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001009 ip_align, tn_buf, reg->off, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001010 return -EACCES;
1011 }
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001012
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001013 return 0;
1014}
1015
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001016static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
1017 const struct bpf_reg_state *reg,
Edward Creef1174f72017-08-07 15:26:19 +01001018 const char *pointer_desc,
1019 int off, int size, bool strict)
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001020{
Edward Creef1174f72017-08-07 15:26:19 +01001021 struct tnum reg_off;
1022
1023 /* Byte size accesses are always allowed. */
1024 if (!strict || size == 1)
1025 return 0;
1026
1027 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
1028 if (!tnum_is_aligned(reg_off, size)) {
1029 char tn_buf[48];
1030
1031 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001032 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001033 pointer_desc, tn_buf, reg->off, off, size);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001034 return -EACCES;
1035 }
1036
1037 return 0;
1038}
1039
David S. Millere07b98d2017-05-10 11:38:07 -07001040static int check_ptr_alignment(struct bpf_verifier_env *env,
1041 const struct bpf_reg_state *reg,
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001042 int off, int size)
1043{
David S. Millere07b98d2017-05-10 11:38:07 -07001044 bool strict = env->strict_alignment;
Edward Creef1174f72017-08-07 15:26:19 +01001045 const char *pointer_desc = "";
David S. Millerd1174412017-05-10 11:22:52 -07001046
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001047 switch (reg->type) {
1048 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001049 case PTR_TO_PACKET_META:
1050 /* Special case, because of NET_IP_ALIGN. Given metadata sits
1051 * right in front, treat it the very same way.
1052 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001053 return check_pkt_ptr_alignment(env, reg, off, size, strict);
Edward Creef1174f72017-08-07 15:26:19 +01001054 case PTR_TO_MAP_VALUE:
1055 pointer_desc = "value ";
1056 break;
1057 case PTR_TO_CTX:
1058 pointer_desc = "context ";
1059 break;
1060 case PTR_TO_STACK:
1061 pointer_desc = "stack ";
Jann Horna5ec6ae2017-12-18 20:11:58 -08001062 /* The stack spill tracking logic in check_stack_write()
1063 * and check_stack_read() relies on stack accesses being
1064 * aligned.
1065 */
1066 strict = true;
Edward Creef1174f72017-08-07 15:26:19 +01001067 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001068 default:
Edward Creef1174f72017-08-07 15:26:19 +01001069 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001070 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001071 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
1072 strict);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001073}
1074
Jann Horn0c17d1d2017-12-18 20:11:55 -08001075/* truncate register to smaller size (in bytes)
1076 * must be called with size < BPF_REG_SIZE
1077 */
1078static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
1079{
1080 u64 mask;
1081
1082 /* clear high bits in bit representation */
1083 reg->var_off = tnum_cast(reg->var_off, size);
1084
1085 /* fix arithmetic bounds */
1086 mask = ((u64)1 << (size * 8)) - 1;
1087 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
1088 reg->umin_value &= mask;
1089 reg->umax_value &= mask;
1090 } else {
1091 reg->umin_value = 0;
1092 reg->umax_value = mask;
1093 }
1094 reg->smin_value = reg->umin_value;
1095 reg->smax_value = reg->umax_value;
1096}
1097
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001098/* check whether memory at (regno + off) is accessible for t = (read | write)
1099 * if t==write, value_regno is a register which value is stored into memory
1100 * if t==read, value_regno is a register which will receive the value from memory
1101 * if t==write && value_regno==-1, some unknown value is stored into memory
1102 * if t==read && value_regno==-1, don't care what we read from memory
1103 */
Yonghong Song31fd8582017-06-13 15:52:13 -07001104static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001105 int bpf_size, enum bpf_access_type t,
1106 int value_regno)
1107{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001108 struct bpf_verifier_state *state = env->cur_state;
1109 struct bpf_reg_state *regs = cur_regs(env);
1110 struct bpf_reg_state *reg = regs + regno;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001111 int size, err = 0;
1112
1113 size = bpf_size_to_bytes(bpf_size);
1114 if (size < 0)
1115 return size;
1116
Edward Creef1174f72017-08-07 15:26:19 +01001117 /* alignment checks will add in reg->off themselves */
David S. Millere07b98d2017-05-10 11:38:07 -07001118 err = check_ptr_alignment(env, reg, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001119 if (err)
1120 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001121
Edward Creef1174f72017-08-07 15:26:19 +01001122 /* for access checks, reg->off is just part of off */
1123 off += reg->off;
1124
1125 if (reg->type == PTR_TO_MAP_VALUE) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001126 if (t == BPF_WRITE && value_regno >= 0 &&
1127 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001128 verbose(env, "R%d leaks addr into map\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001129 return -EACCES;
1130 }
Josef Bacik48461132016-09-28 10:54:32 -04001131
Yonghong Song9fd29c02017-11-12 14:49:09 -08001132 err = check_map_access(env, regno, off, size, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001133 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001134 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001135
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001136 } else if (reg->type == PTR_TO_CTX) {
Edward Creef1174f72017-08-07 15:26:19 +01001137 enum bpf_reg_type reg_type = SCALAR_VALUE;
Alexei Starovoitov19de99f2016-06-15 18:25:38 -07001138
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001139 if (t == BPF_WRITE && value_regno >= 0 &&
1140 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001141 verbose(env, "R%d leaks addr into ctx\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001142 return -EACCES;
1143 }
Edward Creef1174f72017-08-07 15:26:19 +01001144 /* ctx accesses must be at a fixed offset, so that we can
1145 * determine what type of data were returned.
1146 */
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001147 if (reg->off) {
David S. Millerf8ddadc2017-10-22 13:36:53 +01001148 verbose(env,
1149 "dereference of modified ctx ptr R%d off=%d+%d, ctx+const is allowed, ctx+const+const is not\n",
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001150 regno, reg->off, off - reg->off);
1151 return -EACCES;
1152 }
1153 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
Edward Creef1174f72017-08-07 15:26:19 +01001154 char tn_buf[48];
1155
1156 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001157 verbose(env,
1158 "variable ctx access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001159 tn_buf, off, size);
1160 return -EACCES;
1161 }
Yonghong Song31fd8582017-06-13 15:52:13 -07001162 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001163 if (!err && t == BPF_READ && value_regno >= 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001164 /* ctx access returns either a scalar, or a
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001165 * PTR_TO_PACKET[_META,_END]. In the latter
1166 * case, we know the offset is zero.
Edward Creef1174f72017-08-07 15:26:19 +01001167 */
1168 if (reg_type == SCALAR_VALUE)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001169 mark_reg_unknown(env, regs, value_regno);
Edward Creef1174f72017-08-07 15:26:19 +01001170 else
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001171 mark_reg_known_zero(env, regs,
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001172 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001173 regs[value_regno].id = 0;
1174 regs[value_regno].off = 0;
1175 regs[value_regno].range = 0;
1176 regs[value_regno].type = reg_type;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001177 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001178
Edward Creef1174f72017-08-07 15:26:19 +01001179 } else if (reg->type == PTR_TO_STACK) {
1180 /* stack accesses must be at a fixed offset, so that we can
1181 * determine what type of data were returned.
1182 * See check_stack_read().
1183 */
1184 if (!tnum_is_const(reg->var_off)) {
1185 char tn_buf[48];
1186
1187 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001188 verbose(env, "variable stack access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001189 tn_buf, off, size);
1190 return -EACCES;
1191 }
1192 off += reg->var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001193 if (off >= 0 || off < -MAX_BPF_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001194 verbose(env, "invalid stack off=%d size=%d\n", off,
1195 size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001196 return -EACCES;
1197 }
Alexei Starovoitov87266792017-05-30 13:31:29 -07001198
1199 if (env->prog->aux->stack_depth < -off)
1200 env->prog->aux->stack_depth = -off;
1201
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001202 if (t == BPF_WRITE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001203 err = check_stack_write(env, state, off, size,
1204 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001205 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001206 err = check_stack_read(env, state, off, size,
1207 value_regno);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001208 } else if (reg_is_pkt_pointer(reg)) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001209 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001210 verbose(env, "cannot write into packet\n");
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001211 return -EACCES;
1212 }
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001213 if (t == BPF_WRITE && value_regno >= 0 &&
1214 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001215 verbose(env, "R%d leaks addr into packet\n",
1216 value_regno);
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001217 return -EACCES;
1218 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001219 err = check_packet_access(env, regno, off, size, false);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001220 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001221 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001222 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001223 verbose(env, "R%d invalid mem access '%s'\n", regno,
1224 reg_type_str[reg->type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001225 return -EACCES;
1226 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001227
Edward Creef1174f72017-08-07 15:26:19 +01001228 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001229 regs[value_regno].type == SCALAR_VALUE) {
Edward Creef1174f72017-08-07 15:26:19 +01001230 /* b/h/w load zero-extends, mark upper bits as known 0 */
Jann Horn0c17d1d2017-12-18 20:11:55 -08001231 coerce_reg_to_size(&regs[value_regno], size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001232 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001233 return err;
1234}
1235
Yonghong Song31fd8582017-06-13 15:52:13 -07001236static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001237{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001238 int err;
1239
1240 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
1241 insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001242 verbose(env, "BPF_XADD uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001243 return -EINVAL;
1244 }
1245
1246 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001247 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001248 if (err)
1249 return err;
1250
1251 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001252 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001253 if (err)
1254 return err;
1255
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001256 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001257 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001258 return -EACCES;
1259 }
1260
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001261 /* check whether atomic_add can read the memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001262 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001263 BPF_SIZE(insn->code), BPF_READ, -1);
1264 if (err)
1265 return err;
1266
1267 /* check whether atomic_add can write into the same memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001268 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001269 BPF_SIZE(insn->code), BPF_WRITE, -1);
1270}
1271
Edward Creef1174f72017-08-07 15:26:19 +01001272/* Does this register contain a constant zero? */
1273static bool register_is_null(struct bpf_reg_state reg)
1274{
1275 return reg.type == SCALAR_VALUE && tnum_equals_const(reg.var_off, 0);
1276}
1277
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001278/* when register 'regno' is passed into function that will read 'access_size'
1279 * bytes from that pointer, make sure that it's within stack boundary
Edward Creef1174f72017-08-07 15:26:19 +01001280 * and all elements of stack are initialized.
1281 * Unlike most pointer bounds-checking functions, this one doesn't take an
1282 * 'off' argument, so it has to add in reg->off itself.
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001283 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001284static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
Daniel Borkmann435faee12016-04-13 00:10:51 +02001285 int access_size, bool zero_size_allowed,
1286 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001287{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001288 struct bpf_verifier_state *state = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001289 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001290 int off, i, slot, spi;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001291
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001292 if (regs[regno].type != PTR_TO_STACK) {
Edward Creef1174f72017-08-07 15:26:19 +01001293 /* Allow zero-byte read from NULL, regardless of pointer type */
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001294 if (zero_size_allowed && access_size == 0 &&
Edward Creef1174f72017-08-07 15:26:19 +01001295 register_is_null(regs[regno]))
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001296 return 0;
1297
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001298 verbose(env, "R%d type=%s expected=%s\n", regno,
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001299 reg_type_str[regs[regno].type],
1300 reg_type_str[PTR_TO_STACK]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001301 return -EACCES;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001302 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001303
Edward Creef1174f72017-08-07 15:26:19 +01001304 /* Only allow fixed-offset stack reads */
1305 if (!tnum_is_const(regs[regno].var_off)) {
1306 char tn_buf[48];
1307
1308 tnum_strn(tn_buf, sizeof(tn_buf), regs[regno].var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001309 verbose(env, "invalid variable stack read R%d var_off=%s\n",
Edward Creef1174f72017-08-07 15:26:19 +01001310 regno, tn_buf);
Jann Hornea25f912017-12-18 20:11:57 -08001311 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01001312 }
1313 off = regs[regno].off + regs[regno].var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001314 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
Yonghong Song9fd29c02017-11-12 14:49:09 -08001315 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001316 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001317 regno, off, access_size);
1318 return -EACCES;
1319 }
1320
Alexei Starovoitov87266792017-05-30 13:31:29 -07001321 if (env->prog->aux->stack_depth < -off)
1322 env->prog->aux->stack_depth = -off;
1323
Daniel Borkmann435faee12016-04-13 00:10:51 +02001324 if (meta && meta->raw_mode) {
1325 meta->access_size = access_size;
1326 meta->regno = regno;
1327 return 0;
1328 }
1329
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001330 for (i = 0; i < access_size; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001331 slot = -(off + i) - 1;
1332 spi = slot / BPF_REG_SIZE;
1333 if (state->allocated_stack <= slot ||
1334 state->stack[spi].slot_type[slot % BPF_REG_SIZE] !=
1335 STACK_MISC) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001336 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001337 off, i, access_size);
1338 return -EACCES;
1339 }
1340 }
1341 return 0;
1342}
1343
Gianluca Borello06c1c042017-01-09 10:19:49 -08001344static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
1345 int access_size, bool zero_size_allowed,
1346 struct bpf_call_arg_meta *meta)
1347{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001348 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Gianluca Borello06c1c042017-01-09 10:19:49 -08001349
Edward Creef1174f72017-08-07 15:26:19 +01001350 switch (reg->type) {
Gianluca Borello06c1c042017-01-09 10:19:49 -08001351 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001352 case PTR_TO_PACKET_META:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001353 return check_packet_access(env, regno, reg->off, access_size,
1354 zero_size_allowed);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001355 case PTR_TO_MAP_VALUE:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001356 return check_map_access(env, regno, reg->off, access_size,
1357 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001358 default: /* scalar_value|ptr_to_stack or invalid ptr */
Gianluca Borello06c1c042017-01-09 10:19:49 -08001359 return check_stack_boundary(env, regno, access_size,
1360 zero_size_allowed, meta);
1361 }
1362}
1363
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001364static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001365 enum bpf_arg_type arg_type,
1366 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001367{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001368 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001369 enum bpf_reg_type expected_type, type = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001370 int err = 0;
1371
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001372 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001373 return 0;
1374
Edward Creedc503a82017-08-15 20:34:35 +01001375 err = check_reg_arg(env, regno, SRC_OP);
1376 if (err)
1377 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001378
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001379 if (arg_type == ARG_ANYTHING) {
1380 if (is_pointer_value(env, regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001381 verbose(env, "R%d leaks addr into helper function\n",
1382 regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001383 return -EACCES;
1384 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001385 return 0;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001386 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001387
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001388 if (type_is_pkt_pointer(type) &&
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001389 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001390 verbose(env, "helper access to the packet is not allowed\n");
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001391 return -EACCES;
1392 }
1393
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001394 if (arg_type == ARG_PTR_TO_MAP_KEY ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001395 arg_type == ARG_PTR_TO_MAP_VALUE) {
1396 expected_type = PTR_TO_STACK;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001397 if (!type_is_pkt_pointer(type) &&
1398 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001399 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001400 } else if (arg_type == ARG_CONST_SIZE ||
1401 arg_type == ARG_CONST_SIZE_OR_ZERO) {
Edward Creef1174f72017-08-07 15:26:19 +01001402 expected_type = SCALAR_VALUE;
1403 if (type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001404 goto err_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001405 } else if (arg_type == ARG_CONST_MAP_PTR) {
1406 expected_type = CONST_PTR_TO_MAP;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001407 if (type != expected_type)
1408 goto err_type;
Alexei Starovoitov608cd712015-03-26 19:53:57 -07001409 } else if (arg_type == ARG_PTR_TO_CTX) {
1410 expected_type = PTR_TO_CTX;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001411 if (type != expected_type)
1412 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001413 } else if (arg_type == ARG_PTR_TO_MEM ||
Gianluca Borellodb1ac492017-11-22 18:32:53 +00001414 arg_type == ARG_PTR_TO_MEM_OR_NULL ||
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001415 arg_type == ARG_PTR_TO_UNINIT_MEM) {
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001416 expected_type = PTR_TO_STACK;
1417 /* One exception here. In case function allows for NULL to be
Edward Creef1174f72017-08-07 15:26:19 +01001418 * passed in as argument, it's a SCALAR_VALUE type. Final test
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001419 * happens during stack boundary checking.
1420 */
Gianluca Borellodb1ac492017-11-22 18:32:53 +00001421 if (register_is_null(*reg) &&
1422 arg_type == ARG_PTR_TO_MEM_OR_NULL)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001423 /* final test in check_stack_boundary() */;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001424 else if (!type_is_pkt_pointer(type) &&
1425 type != PTR_TO_MAP_VALUE &&
Edward Creef1174f72017-08-07 15:26:19 +01001426 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001427 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001428 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001429 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001430 verbose(env, "unsupported arg_type %d\n", arg_type);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001431 return -EFAULT;
1432 }
1433
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001434 if (arg_type == ARG_CONST_MAP_PTR) {
1435 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001436 meta->map_ptr = reg->map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001437 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
1438 /* bpf_map_xxx(..., map_ptr, ..., key) call:
1439 * check that [key, key + map->key_size) are within
1440 * stack limits and initialized
1441 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001442 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001443 /* in function declaration map_ptr must come before
1444 * map_key, so that it's verified and known before
1445 * we have to check map_key here. Otherwise it means
1446 * that kernel subsystem misconfigured verifier
1447 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001448 verbose(env, "invalid map_ptr to access map->key\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001449 return -EACCES;
1450 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001451 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001452 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001453 meta->map_ptr->key_size,
1454 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001455 else
1456 err = check_stack_boundary(env, regno,
1457 meta->map_ptr->key_size,
1458 false, NULL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001459 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
1460 /* bpf_map_xxx(..., map_ptr, ..., value) call:
1461 * check [value, value + map->value_size) validity
1462 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001463 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001464 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001465 verbose(env, "invalid map_ptr to access map->value\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001466 return -EACCES;
1467 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001468 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001469 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001470 meta->map_ptr->value_size,
1471 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001472 else
1473 err = check_stack_boundary(env, regno,
1474 meta->map_ptr->value_size,
1475 false, NULL);
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001476 } else if (arg_type == ARG_CONST_SIZE ||
1477 arg_type == ARG_CONST_SIZE_OR_ZERO) {
1478 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001479
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001480 /* bpf_xxx(..., buf, len) call will access 'len' bytes
1481 * from stack pointer 'buf'. Check it
1482 * note: regno == len, regno - 1 == buf
1483 */
1484 if (regno == 0) {
1485 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001486 verbose(env,
1487 "ARG_CONST_SIZE cannot be first argument\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001488 return -EACCES;
1489 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001490
Edward Creef1174f72017-08-07 15:26:19 +01001491 /* The register is SCALAR_VALUE; the access check
1492 * happens using its boundaries.
Gianluca Borello06c1c042017-01-09 10:19:49 -08001493 */
Edward Creef1174f72017-08-07 15:26:19 +01001494
1495 if (!tnum_is_const(reg->var_off))
Gianluca Borello06c1c042017-01-09 10:19:49 -08001496 /* For unprivileged variable accesses, disable raw
1497 * mode so that the program is required to
1498 * initialize all the memory that the helper could
1499 * just partially fill up.
1500 */
1501 meta = NULL;
1502
Edward Creeb03c9f92017-08-07 15:26:36 +01001503 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001504 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
Edward Creef1174f72017-08-07 15:26:19 +01001505 regno);
1506 return -EACCES;
1507 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001508
Edward Creeb03c9f92017-08-07 15:26:36 +01001509 if (reg->umin_value == 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001510 err = check_helper_mem_access(env, regno - 1, 0,
1511 zero_size_allowed,
1512 meta);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001513 if (err)
1514 return err;
Gianluca Borello06c1c042017-01-09 10:19:49 -08001515 }
Edward Creef1174f72017-08-07 15:26:19 +01001516
Edward Creeb03c9f92017-08-07 15:26:36 +01001517 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001518 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
Edward Creef1174f72017-08-07 15:26:19 +01001519 regno);
1520 return -EACCES;
1521 }
1522 err = check_helper_mem_access(env, regno - 1,
Edward Creeb03c9f92017-08-07 15:26:36 +01001523 reg->umax_value,
Edward Creef1174f72017-08-07 15:26:19 +01001524 zero_size_allowed, meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001525 }
1526
1527 return err;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001528err_type:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001529 verbose(env, "R%d type=%s expected=%s\n", regno,
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001530 reg_type_str[type], reg_type_str[expected_type]);
1531 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001532}
1533
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001534static int check_map_func_compatibility(struct bpf_verifier_env *env,
1535 struct bpf_map *map, int func_id)
Kaixu Xia35578d72015-08-06 07:02:35 +00001536{
Kaixu Xia35578d72015-08-06 07:02:35 +00001537 if (!map)
1538 return 0;
1539
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001540 /* We need a two way check, first is from map perspective ... */
1541 switch (map->map_type) {
1542 case BPF_MAP_TYPE_PROG_ARRAY:
1543 if (func_id != BPF_FUNC_tail_call)
1544 goto error;
1545 break;
1546 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
1547 if (func_id != BPF_FUNC_perf_event_read &&
Yonghong Song908432c2017-10-05 09:19:20 -07001548 func_id != BPF_FUNC_perf_event_output &&
1549 func_id != BPF_FUNC_perf_event_read_value)
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001550 goto error;
1551 break;
1552 case BPF_MAP_TYPE_STACK_TRACE:
1553 if (func_id != BPF_FUNC_get_stackid)
1554 goto error;
1555 break;
Martin KaFai Lau4ed8ec52016-06-30 10:28:43 -07001556 case BPF_MAP_TYPE_CGROUP_ARRAY:
David S. Miller60747ef2016-08-18 01:17:32 -04001557 if (func_id != BPF_FUNC_skb_under_cgroup &&
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001558 func_id != BPF_FUNC_current_task_under_cgroup)
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001559 goto error;
1560 break;
John Fastabend546ac1f2017-07-17 09:28:56 -07001561 /* devmap returns a pointer to a live net_device ifindex that we cannot
1562 * allow to be modified from bpf side. So do not allow lookup elements
1563 * for now.
1564 */
1565 case BPF_MAP_TYPE_DEVMAP:
John Fastabend2ddf71e2017-07-17 09:30:02 -07001566 if (func_id != BPF_FUNC_redirect_map)
John Fastabend546ac1f2017-07-17 09:28:56 -07001567 goto error;
1568 break;
Jesper Dangaard Brouer6710e112017-10-16 12:19:28 +02001569 /* Restrict bpf side of cpumap, open when use-cases appear */
1570 case BPF_MAP_TYPE_CPUMAP:
1571 if (func_id != BPF_FUNC_redirect_map)
1572 goto error;
1573 break;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07001574 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07001575 case BPF_MAP_TYPE_HASH_OF_MAPS:
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07001576 if (func_id != BPF_FUNC_map_lookup_elem)
1577 goto error;
Martin KaFai Lau16a43622017-08-17 18:14:43 -07001578 break;
John Fastabend174a79f2017-08-15 22:32:47 -07001579 case BPF_MAP_TYPE_SOCKMAP:
1580 if (func_id != BPF_FUNC_sk_redirect_map &&
1581 func_id != BPF_FUNC_sock_map_update &&
1582 func_id != BPF_FUNC_map_delete_elem)
1583 goto error;
1584 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001585 default:
1586 break;
1587 }
1588
1589 /* ... and second from the function itself. */
1590 switch (func_id) {
1591 case BPF_FUNC_tail_call:
1592 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
1593 goto error;
1594 break;
1595 case BPF_FUNC_perf_event_read:
1596 case BPF_FUNC_perf_event_output:
Yonghong Song908432c2017-10-05 09:19:20 -07001597 case BPF_FUNC_perf_event_read_value:
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001598 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
1599 goto error;
1600 break;
1601 case BPF_FUNC_get_stackid:
1602 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
1603 goto error;
1604 break;
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001605 case BPF_FUNC_current_task_under_cgroup:
Daniel Borkmann747ea552016-08-12 22:17:17 +02001606 case BPF_FUNC_skb_under_cgroup:
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001607 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
1608 goto error;
1609 break;
John Fastabend97f91a72017-07-17 09:29:18 -07001610 case BPF_FUNC_redirect_map:
Jesper Dangaard Brouer9c270af2017-10-16 12:19:34 +02001611 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
1612 map->map_type != BPF_MAP_TYPE_CPUMAP)
John Fastabend97f91a72017-07-17 09:29:18 -07001613 goto error;
1614 break;
John Fastabend174a79f2017-08-15 22:32:47 -07001615 case BPF_FUNC_sk_redirect_map:
1616 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
1617 goto error;
1618 break;
1619 case BPF_FUNC_sock_map_update:
1620 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
1621 goto error;
1622 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001623 default:
1624 break;
Kaixu Xia35578d72015-08-06 07:02:35 +00001625 }
1626
1627 return 0;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001628error:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001629 verbose(env, "cannot pass map_type %d into func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001630 map->map_type, func_id_name(func_id), func_id);
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001631 return -EINVAL;
Kaixu Xia35578d72015-08-06 07:02:35 +00001632}
1633
Daniel Borkmann435faee12016-04-13 00:10:51 +02001634static int check_raw_mode(const struct bpf_func_proto *fn)
1635{
1636 int count = 0;
1637
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001638 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001639 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001640 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001641 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001642 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001643 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001644 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001645 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001646 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001647 count++;
1648
1649 return count > 1 ? -EINVAL : 0;
1650}
1651
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001652/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
1653 * are now invalid, so turn them into unknown SCALAR_VALUE.
Edward Creef1174f72017-08-07 15:26:19 +01001654 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001655static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001656{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001657 struct bpf_verifier_state *state = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001658 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001659 int i;
1660
1661 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001662 if (reg_is_pkt_pointer_any(&regs[i]))
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001663 mark_reg_unknown(env, regs, i);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001664
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001665 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
1666 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001667 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001668 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001669 if (reg_is_pkt_pointer_any(reg))
1670 __mark_reg_unknown(reg);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001671 }
1672}
1673
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07001674static int check_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001675{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001676 const struct bpf_func_proto *fn = NULL;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001677 struct bpf_reg_state *regs;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001678 struct bpf_call_arg_meta meta;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001679 bool changes_data;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001680 int i, err;
1681
1682 /* find function prototype */
1683 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001684 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
1685 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001686 return -EINVAL;
1687 }
1688
Jakub Kicinski00176a32017-10-16 16:40:54 -07001689 if (env->ops->get_func_proto)
1690 fn = env->ops->get_func_proto(func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001691
1692 if (!fn) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001693 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
1694 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001695 return -EINVAL;
1696 }
1697
1698 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +01001699 if (!env->prog->gpl_compatible && fn->gpl_only) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001700 verbose(env, "cannot call GPL only function from proprietary program\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001701 return -EINVAL;
1702 }
1703
Daniel Borkmann04514d12017-12-14 21:07:25 +01001704 /* With LD_ABS/IND some JITs save/restore skb from r1. */
Martin KaFai Lau17bedab2016-12-07 15:53:11 -08001705 changes_data = bpf_helper_changes_pkt_data(fn->func);
Daniel Borkmann04514d12017-12-14 21:07:25 +01001706 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
1707 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
1708 func_id_name(func_id), func_id);
1709 return -EINVAL;
1710 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001711
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001712 memset(&meta, 0, sizeof(meta));
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001713 meta.pkt_access = fn->pkt_access;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001714
Daniel Borkmann435faee12016-04-13 00:10:51 +02001715 /* We only support one arg being in raw mode at the moment, which
1716 * is sufficient for the helper functions we have right now.
1717 */
1718 err = check_raw_mode(fn);
1719 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001720 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001721 func_id_name(func_id), func_id);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001722 return err;
1723 }
1724
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001725 /* check args */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001726 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001727 if (err)
1728 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001729 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001730 if (err)
1731 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001732 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001733 if (err)
1734 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001735 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001736 if (err)
1737 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001738 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001739 if (err)
1740 return err;
1741
Daniel Borkmann435faee12016-04-13 00:10:51 +02001742 /* Mark slots with STACK_MISC in case of raw mode, stack offset
1743 * is inferred from register state.
1744 */
1745 for (i = 0; i < meta.access_size; i++) {
Yonghong Song31fd8582017-06-13 15:52:13 -07001746 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B, BPF_WRITE, -1);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001747 if (err)
1748 return err;
1749 }
1750
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001751 regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001752 /* reset caller saved regs */
Edward Creedc503a82017-08-15 20:34:35 +01001753 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001754 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01001755 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
1756 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001757
Edward Creedc503a82017-08-15 20:34:35 +01001758 /* update return register (already marked as written above) */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001759 if (fn->ret_type == RET_INTEGER) {
Edward Creef1174f72017-08-07 15:26:19 +01001760 /* sets type to SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001761 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001762 } else if (fn->ret_type == RET_VOID) {
1763 regs[BPF_REG_0].type = NOT_INIT;
1764 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
Martin KaFai Laufad73a12017-03-22 10:00:32 -07001765 struct bpf_insn_aux_data *insn_aux;
1766
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001767 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
Edward Creef1174f72017-08-07 15:26:19 +01001768 /* There is no offset yet applied, variable or fixed */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001769 mark_reg_known_zero(env, regs, BPF_REG_0);
Edward Creef1174f72017-08-07 15:26:19 +01001770 regs[BPF_REG_0].off = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001771 /* remember map_ptr, so that check_map_access()
1772 * can check 'value_size' boundary of memory access
1773 * to map element returned from bpf_map_lookup_elem()
1774 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001775 if (meta.map_ptr == NULL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001776 verbose(env,
1777 "kernel subsystem misconfigured verifier\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001778 return -EINVAL;
1779 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001780 regs[BPF_REG_0].map_ptr = meta.map_ptr;
Thomas Graf57a09bf2016-10-18 19:51:19 +02001781 regs[BPF_REG_0].id = ++env->id_gen;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07001782 insn_aux = &env->insn_aux_data[insn_idx];
1783 if (!insn_aux->map_ptr)
1784 insn_aux->map_ptr = meta.map_ptr;
1785 else if (insn_aux->map_ptr != meta.map_ptr)
1786 insn_aux->map_ptr = BPF_MAP_PTR_POISON;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001787 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001788 verbose(env, "unknown return type %d of func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001789 fn->ret_type, func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001790 return -EINVAL;
1791 }
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001792
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001793 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
Kaixu Xia35578d72015-08-06 07:02:35 +00001794 if (err)
1795 return err;
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001796
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001797 if (changes_data)
1798 clear_all_pkt_pointers(env);
1799 return 0;
1800}
1801
Edward Creeb03c9f92017-08-07 15:26:36 +01001802static bool signed_add_overflows(s64 a, s64 b)
1803{
1804 /* Do the add in u64, where overflow is well-defined */
1805 s64 res = (s64)((u64)a + (u64)b);
1806
1807 if (b < 0)
1808 return res > a;
1809 return res < a;
1810}
1811
1812static bool signed_sub_overflows(s64 a, s64 b)
1813{
1814 /* Do the sub in u64, where overflow is well-defined */
1815 s64 res = (s64)((u64)a - (u64)b);
1816
1817 if (b < 0)
1818 return res < a;
1819 return res > a;
David S. Millerd1174412017-05-10 11:22:52 -07001820}
1821
Edward Creef1174f72017-08-07 15:26:19 +01001822/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
Edward Creef1174f72017-08-07 15:26:19 +01001823 * Caller should also handle BPF_MOV case separately.
1824 * If we return -EACCES, caller may want to try again treating pointer as a
1825 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
1826 */
1827static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
1828 struct bpf_insn *insn,
1829 const struct bpf_reg_state *ptr_reg,
1830 const struct bpf_reg_state *off_reg)
Josef Bacik48461132016-09-28 10:54:32 -04001831{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001832 struct bpf_reg_state *regs = cur_regs(env), *dst_reg;
Edward Creef1174f72017-08-07 15:26:19 +01001833 bool known = tnum_is_const(off_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01001834 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
1835 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
1836 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
1837 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
Josef Bacik48461132016-09-28 10:54:32 -04001838 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01001839 u32 dst = insn->dst_reg;
Josef Bacik48461132016-09-28 10:54:32 -04001840
Edward Creef1174f72017-08-07 15:26:19 +01001841 dst_reg = &regs[dst];
Josef Bacik48461132016-09-28 10:54:32 -04001842
Edward Creeb03c9f92017-08-07 15:26:36 +01001843 if (WARN_ON_ONCE(known && (smin_val != smax_val))) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001844 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001845 verbose(env,
1846 "verifier internal error: known but bad sbounds\n");
Edward Creeb03c9f92017-08-07 15:26:36 +01001847 return -EINVAL;
1848 }
1849 if (WARN_ON_ONCE(known && (umin_val != umax_val))) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001850 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001851 verbose(env,
1852 "verifier internal error: known but bad ubounds\n");
Edward Creef1174f72017-08-07 15:26:19 +01001853 return -EINVAL;
Josef Bacik48461132016-09-28 10:54:32 -04001854 }
1855
Edward Creef1174f72017-08-07 15:26:19 +01001856 if (BPF_CLASS(insn->code) != BPF_ALU64) {
1857 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
1858 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001859 verbose(env,
1860 "R%d 32-bit pointer arithmetic prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001861 dst);
1862 return -EACCES;
1863 }
David S. Millerd1174412017-05-10 11:22:52 -07001864
Edward Creef1174f72017-08-07 15:26:19 +01001865 if (ptr_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
1866 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001867 verbose(env, "R%d pointer arithmetic on PTR_TO_MAP_VALUE_OR_NULL prohibited, null-check it first\n",
Edward Creef1174f72017-08-07 15:26:19 +01001868 dst);
1869 return -EACCES;
1870 }
1871 if (ptr_reg->type == CONST_PTR_TO_MAP) {
1872 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001873 verbose(env, "R%d pointer arithmetic on CONST_PTR_TO_MAP prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001874 dst);
1875 return -EACCES;
1876 }
1877 if (ptr_reg->type == PTR_TO_PACKET_END) {
1878 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001879 verbose(env, "R%d pointer arithmetic on PTR_TO_PACKET_END prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001880 dst);
1881 return -EACCES;
1882 }
1883
1884 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
1885 * The id may be overwritten later if we create a new variable offset.
Josef Bacik48461132016-09-28 10:54:32 -04001886 */
Edward Creef1174f72017-08-07 15:26:19 +01001887 dst_reg->type = ptr_reg->type;
1888 dst_reg->id = ptr_reg->id;
Josef Bacikf23cc642016-11-14 15:45:36 -05001889
Josef Bacik48461132016-09-28 10:54:32 -04001890 switch (opcode) {
1891 case BPF_ADD:
Edward Creef1174f72017-08-07 15:26:19 +01001892 /* We can take a fixed offset as long as it doesn't overflow
1893 * the s32 'off' field
1894 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001895 if (known && (ptr_reg->off + smin_val ==
1896 (s64)(s32)(ptr_reg->off + smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01001897 /* pointer += K. Accumulate it into fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01001898 dst_reg->smin_value = smin_ptr;
1899 dst_reg->smax_value = smax_ptr;
1900 dst_reg->umin_value = umin_ptr;
1901 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01001902 dst_reg->var_off = ptr_reg->var_off;
Edward Creeb03c9f92017-08-07 15:26:36 +01001903 dst_reg->off = ptr_reg->off + smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01001904 dst_reg->range = ptr_reg->range;
1905 break;
1906 }
Edward Creef1174f72017-08-07 15:26:19 +01001907 /* A new variable offset is created. Note that off_reg->off
1908 * == 0, since it's a scalar.
1909 * dst_reg gets the pointer type and since some positive
1910 * integer value was added to the pointer, give it a new 'id'
1911 * if it's a PTR_TO_PACKET.
1912 * this creates a new 'base' pointer, off_reg (variable) gets
1913 * added into the variable offset, and we copy the fixed offset
1914 * from ptr_reg.
1915 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001916 if (signed_add_overflows(smin_ptr, smin_val) ||
1917 signed_add_overflows(smax_ptr, smax_val)) {
1918 dst_reg->smin_value = S64_MIN;
1919 dst_reg->smax_value = S64_MAX;
1920 } else {
1921 dst_reg->smin_value = smin_ptr + smin_val;
1922 dst_reg->smax_value = smax_ptr + smax_val;
1923 }
1924 if (umin_ptr + umin_val < umin_ptr ||
1925 umax_ptr + umax_val < umax_ptr) {
1926 dst_reg->umin_value = 0;
1927 dst_reg->umax_value = U64_MAX;
1928 } else {
1929 dst_reg->umin_value = umin_ptr + umin_val;
1930 dst_reg->umax_value = umax_ptr + umax_val;
1931 }
Edward Creef1174f72017-08-07 15:26:19 +01001932 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
1933 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001934 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01001935 dst_reg->id = ++env->id_gen;
1936 /* something was added to pkt_ptr, set range to zero */
1937 dst_reg->range = 0;
1938 }
Josef Bacik48461132016-09-28 10:54:32 -04001939 break;
1940 case BPF_SUB:
Edward Creef1174f72017-08-07 15:26:19 +01001941 if (dst_reg == off_reg) {
1942 /* scalar -= pointer. Creates an unknown scalar */
1943 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001944 verbose(env, "R%d tried to subtract pointer from scalar\n",
Edward Creef1174f72017-08-07 15:26:19 +01001945 dst);
1946 return -EACCES;
1947 }
1948 /* We don't allow subtraction from FP, because (according to
1949 * test_verifier.c test "invalid fp arithmetic", JITs might not
1950 * be able to deal with it.
Edward Cree93057062017-07-21 14:37:34 +01001951 */
Edward Creef1174f72017-08-07 15:26:19 +01001952 if (ptr_reg->type == PTR_TO_STACK) {
1953 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001954 verbose(env, "R%d subtraction from stack pointer prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001955 dst);
1956 return -EACCES;
1957 }
Edward Creeb03c9f92017-08-07 15:26:36 +01001958 if (known && (ptr_reg->off - smin_val ==
1959 (s64)(s32)(ptr_reg->off - smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01001960 /* pointer -= K. Subtract it from fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01001961 dst_reg->smin_value = smin_ptr;
1962 dst_reg->smax_value = smax_ptr;
1963 dst_reg->umin_value = umin_ptr;
1964 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01001965 dst_reg->var_off = ptr_reg->var_off;
1966 dst_reg->id = ptr_reg->id;
Edward Creeb03c9f92017-08-07 15:26:36 +01001967 dst_reg->off = ptr_reg->off - smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01001968 dst_reg->range = ptr_reg->range;
1969 break;
1970 }
Edward Creef1174f72017-08-07 15:26:19 +01001971 /* A new variable offset is created. If the subtrahend is known
1972 * nonnegative, then any reg->range we had before is still good.
1973 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001974 if (signed_sub_overflows(smin_ptr, smax_val) ||
1975 signed_sub_overflows(smax_ptr, smin_val)) {
1976 /* Overflow possible, we know nothing */
1977 dst_reg->smin_value = S64_MIN;
1978 dst_reg->smax_value = S64_MAX;
1979 } else {
1980 dst_reg->smin_value = smin_ptr - smax_val;
1981 dst_reg->smax_value = smax_ptr - smin_val;
1982 }
1983 if (umin_ptr < umax_val) {
1984 /* Overflow possible, we know nothing */
1985 dst_reg->umin_value = 0;
1986 dst_reg->umax_value = U64_MAX;
1987 } else {
1988 /* Cannot overflow (as long as bounds are consistent) */
1989 dst_reg->umin_value = umin_ptr - umax_val;
1990 dst_reg->umax_value = umax_ptr - umin_val;
1991 }
Edward Creef1174f72017-08-07 15:26:19 +01001992 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
1993 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001994 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01001995 dst_reg->id = ++env->id_gen;
1996 /* something was added to pkt_ptr, set range to zero */
Edward Creeb03c9f92017-08-07 15:26:36 +01001997 if (smin_val < 0)
Edward Creef1174f72017-08-07 15:26:19 +01001998 dst_reg->range = 0;
1999 }
2000 break;
2001 case BPF_AND:
2002 case BPF_OR:
2003 case BPF_XOR:
2004 /* bitwise ops on pointers are troublesome, prohibit for now.
2005 * (However, in principle we could allow some cases, e.g.
2006 * ptr &= ~3 which would reduce min_value by 3.)
2007 */
2008 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002009 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01002010 dst, bpf_alu_string[opcode >> 4]);
2011 return -EACCES;
2012 default:
2013 /* other operators (e.g. MUL,LSH) produce non-pointer results */
2014 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002015 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01002016 dst, bpf_alu_string[opcode >> 4]);
2017 return -EACCES;
2018 }
2019
Edward Creeb03c9f92017-08-07 15:26:36 +01002020 __update_reg_bounds(dst_reg);
2021 __reg_deduce_bounds(dst_reg);
2022 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002023 return 0;
2024}
2025
Jann Horn468f6ea2017-12-18 20:11:56 -08002026/* WARNING: This function does calculations on 64-bit values, but the actual
2027 * execution may occur on 32-bit values. Therefore, things like bitshifts
2028 * need extra checks in the 32-bit case.
2029 */
Edward Creef1174f72017-08-07 15:26:19 +01002030static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
2031 struct bpf_insn *insn,
2032 struct bpf_reg_state *dst_reg,
2033 struct bpf_reg_state src_reg)
2034{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002035 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +01002036 u8 opcode = BPF_OP(insn->code);
2037 bool src_known, dst_known;
Edward Creeb03c9f92017-08-07 15:26:36 +01002038 s64 smin_val, smax_val;
2039 u64 umin_val, umax_val;
Jann Horn468f6ea2017-12-18 20:11:56 -08002040 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
Edward Creef1174f72017-08-07 15:26:19 +01002041
Edward Creeb03c9f92017-08-07 15:26:36 +01002042 smin_val = src_reg.smin_value;
2043 smax_val = src_reg.smax_value;
2044 umin_val = src_reg.umin_value;
2045 umax_val = src_reg.umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002046 src_known = tnum_is_const(src_reg.var_off);
2047 dst_known = tnum_is_const(dst_reg->var_off);
2048
2049 switch (opcode) {
2050 case BPF_ADD:
Edward Creeb03c9f92017-08-07 15:26:36 +01002051 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
2052 signed_add_overflows(dst_reg->smax_value, smax_val)) {
2053 dst_reg->smin_value = S64_MIN;
2054 dst_reg->smax_value = S64_MAX;
2055 } else {
2056 dst_reg->smin_value += smin_val;
2057 dst_reg->smax_value += smax_val;
2058 }
2059 if (dst_reg->umin_value + umin_val < umin_val ||
2060 dst_reg->umax_value + umax_val < umax_val) {
2061 dst_reg->umin_value = 0;
2062 dst_reg->umax_value = U64_MAX;
2063 } else {
2064 dst_reg->umin_value += umin_val;
2065 dst_reg->umax_value += umax_val;
2066 }
Edward Creef1174f72017-08-07 15:26:19 +01002067 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
2068 break;
2069 case BPF_SUB:
Edward Creeb03c9f92017-08-07 15:26:36 +01002070 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
2071 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
2072 /* Overflow possible, we know nothing */
2073 dst_reg->smin_value = S64_MIN;
2074 dst_reg->smax_value = S64_MAX;
2075 } else {
2076 dst_reg->smin_value -= smax_val;
2077 dst_reg->smax_value -= smin_val;
2078 }
2079 if (dst_reg->umin_value < umax_val) {
2080 /* Overflow possible, we know nothing */
2081 dst_reg->umin_value = 0;
2082 dst_reg->umax_value = U64_MAX;
2083 } else {
2084 /* Cannot overflow (as long as bounds are consistent) */
2085 dst_reg->umin_value -= umax_val;
2086 dst_reg->umax_value -= umin_val;
2087 }
Edward Creef1174f72017-08-07 15:26:19 +01002088 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
Josef Bacik48461132016-09-28 10:54:32 -04002089 break;
2090 case BPF_MUL:
Edward Creeb03c9f92017-08-07 15:26:36 +01002091 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
2092 if (smin_val < 0 || dst_reg->smin_value < 0) {
Edward Creef1174f72017-08-07 15:26:19 +01002093 /* Ain't nobody got time to multiply that sign */
Edward Creeb03c9f92017-08-07 15:26:36 +01002094 __mark_reg_unbounded(dst_reg);
2095 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002096 break;
2097 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002098 /* Both values are positive, so we can work with unsigned and
2099 * copy the result to signed (unless it exceeds S64_MAX).
Edward Creef1174f72017-08-07 15:26:19 +01002100 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002101 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
2102 /* Potential overflow, we know nothing */
2103 __mark_reg_unbounded(dst_reg);
2104 /* (except what we can learn from the var_off) */
2105 __update_reg_bounds(dst_reg);
2106 break;
2107 }
2108 dst_reg->umin_value *= umin_val;
2109 dst_reg->umax_value *= umax_val;
2110 if (dst_reg->umax_value > S64_MAX) {
2111 /* Overflow possible, we know nothing */
2112 dst_reg->smin_value = S64_MIN;
2113 dst_reg->smax_value = S64_MAX;
2114 } else {
2115 dst_reg->smin_value = dst_reg->umin_value;
2116 dst_reg->smax_value = dst_reg->umax_value;
2117 }
Josef Bacik48461132016-09-28 10:54:32 -04002118 break;
2119 case BPF_AND:
Edward Creef1174f72017-08-07 15:26:19 +01002120 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002121 __mark_reg_known(dst_reg, dst_reg->var_off.value &
2122 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002123 break;
2124 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002125 /* We get our minimum from the var_off, since that's inherently
2126 * bitwise. Our maximum is the minimum of the operands' maxima.
Josef Bacikf23cc642016-11-14 15:45:36 -05002127 */
Edward Creef1174f72017-08-07 15:26:19 +01002128 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002129 dst_reg->umin_value = dst_reg->var_off.value;
2130 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
2131 if (dst_reg->smin_value < 0 || smin_val < 0) {
2132 /* Lose signed bounds when ANDing negative numbers,
2133 * ain't nobody got time for that.
2134 */
2135 dst_reg->smin_value = S64_MIN;
2136 dst_reg->smax_value = S64_MAX;
2137 } else {
2138 /* ANDing two positives gives a positive, so safe to
2139 * cast result into s64.
2140 */
2141 dst_reg->smin_value = dst_reg->umin_value;
2142 dst_reg->smax_value = dst_reg->umax_value;
2143 }
2144 /* We may learn something more from the var_off */
2145 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002146 break;
2147 case BPF_OR:
2148 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002149 __mark_reg_known(dst_reg, dst_reg->var_off.value |
2150 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002151 break;
2152 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002153 /* We get our maximum from the var_off, and our minimum is the
2154 * maximum of the operands' minima
Edward Creef1174f72017-08-07 15:26:19 +01002155 */
2156 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002157 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
2158 dst_reg->umax_value = dst_reg->var_off.value |
2159 dst_reg->var_off.mask;
2160 if (dst_reg->smin_value < 0 || smin_val < 0) {
2161 /* Lose signed bounds when ORing negative numbers,
2162 * ain't nobody got time for that.
2163 */
2164 dst_reg->smin_value = S64_MIN;
2165 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002166 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002167 /* ORing two positives gives a positive, so safe to
2168 * cast result into s64.
2169 */
2170 dst_reg->smin_value = dst_reg->umin_value;
2171 dst_reg->smax_value = dst_reg->umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002172 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002173 /* We may learn something more from the var_off */
2174 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002175 break;
2176 case BPF_LSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002177 if (umax_val >= insn_bitness) {
2178 /* Shifts greater than 31 or 63 are undefined.
2179 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002180 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002181 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002182 break;
2183 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002184 /* We lose all sign bit information (except what we can pick
2185 * up from var_off)
Josef Bacik48461132016-09-28 10:54:32 -04002186 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002187 dst_reg->smin_value = S64_MIN;
2188 dst_reg->smax_value = S64_MAX;
2189 /* If we might shift our top bit out, then we know nothing */
2190 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
2191 dst_reg->umin_value = 0;
2192 dst_reg->umax_value = U64_MAX;
David S. Millerd1174412017-05-10 11:22:52 -07002193 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002194 dst_reg->umin_value <<= umin_val;
2195 dst_reg->umax_value <<= umax_val;
David S. Millerd1174412017-05-10 11:22:52 -07002196 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002197 if (src_known)
2198 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
2199 else
2200 dst_reg->var_off = tnum_lshift(tnum_unknown, umin_val);
2201 /* We may learn something more from the var_off */
2202 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002203 break;
2204 case BPF_RSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002205 if (umax_val >= insn_bitness) {
2206 /* Shifts greater than 31 or 63 are undefined.
2207 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002208 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002209 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002210 break;
2211 }
Edward Cree4374f252017-12-18 20:11:53 -08002212 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
2213 * be negative, then either:
2214 * 1) src_reg might be zero, so the sign bit of the result is
2215 * unknown, so we lose our signed bounds
2216 * 2) it's known negative, thus the unsigned bounds capture the
2217 * signed bounds
2218 * 3) the signed bounds cross zero, so they tell us nothing
2219 * about the result
2220 * If the value in dst_reg is known nonnegative, then again the
2221 * unsigned bounts capture the signed bounds.
2222 * Thus, in all cases it suffices to blow away our signed bounds
2223 * and rely on inferring new ones from the unsigned bounds and
2224 * var_off of the result.
2225 */
2226 dst_reg->smin_value = S64_MIN;
2227 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002228 if (src_known)
Edward Creeb03c9f92017-08-07 15:26:36 +01002229 dst_reg->var_off = tnum_rshift(dst_reg->var_off,
2230 umin_val);
Edward Creef1174f72017-08-07 15:26:19 +01002231 else
Edward Creeb03c9f92017-08-07 15:26:36 +01002232 dst_reg->var_off = tnum_rshift(tnum_unknown, umin_val);
2233 dst_reg->umin_value >>= umax_val;
2234 dst_reg->umax_value >>= umin_val;
2235 /* We may learn something more from the var_off */
2236 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002237 break;
2238 default:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002239 mark_reg_unknown(env, regs, insn->dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002240 break;
2241 }
2242
Jann Horn468f6ea2017-12-18 20:11:56 -08002243 if (BPF_CLASS(insn->code) != BPF_ALU64) {
2244 /* 32-bit ALU ops are (32,32)->32 */
2245 coerce_reg_to_size(dst_reg, 4);
2246 coerce_reg_to_size(&src_reg, 4);
2247 }
2248
Edward Creeb03c9f92017-08-07 15:26:36 +01002249 __reg_deduce_bounds(dst_reg);
2250 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002251 return 0;
2252}
2253
2254/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
2255 * and var_off.
2256 */
2257static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
2258 struct bpf_insn *insn)
2259{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002260 struct bpf_reg_state *regs = cur_regs(env), *dst_reg, *src_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002261 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
2262 u8 opcode = BPF_OP(insn->code);
2263 int rc;
2264
2265 dst_reg = &regs[insn->dst_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002266 src_reg = NULL;
2267 if (dst_reg->type != SCALAR_VALUE)
2268 ptr_reg = dst_reg;
2269 if (BPF_SRC(insn->code) == BPF_X) {
2270 src_reg = &regs[insn->src_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002271 if (src_reg->type != SCALAR_VALUE) {
2272 if (dst_reg->type != SCALAR_VALUE) {
2273 /* Combining two pointers by any ALU op yields
2274 * an arbitrary scalar.
2275 */
2276 if (!env->allow_ptr_leaks) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002277 verbose(env, "R%d pointer %s pointer prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01002278 insn->dst_reg,
2279 bpf_alu_string[opcode >> 4]);
2280 return -EACCES;
2281 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002282 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002283 return 0;
2284 } else {
2285 /* scalar += pointer
2286 * This is legal, but we have to reverse our
2287 * src/dest handling in computing the range
2288 */
2289 rc = adjust_ptr_min_max_vals(env, insn,
2290 src_reg, dst_reg);
2291 if (rc == -EACCES && env->allow_ptr_leaks) {
2292 /* scalar += unknown scalar */
2293 __mark_reg_unknown(&off_reg);
2294 return adjust_scalar_min_max_vals(
2295 env, insn,
2296 dst_reg, off_reg);
2297 }
2298 return rc;
2299 }
2300 } else if (ptr_reg) {
2301 /* pointer += scalar */
2302 rc = adjust_ptr_min_max_vals(env, insn,
2303 dst_reg, src_reg);
2304 if (rc == -EACCES && env->allow_ptr_leaks) {
2305 /* unknown scalar += scalar */
2306 __mark_reg_unknown(dst_reg);
2307 return adjust_scalar_min_max_vals(
2308 env, insn, dst_reg, *src_reg);
2309 }
2310 return rc;
2311 }
2312 } else {
2313 /* Pretend the src is a reg with a known value, since we only
2314 * need to be able to read from this state.
2315 */
2316 off_reg.type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01002317 __mark_reg_known(&off_reg, insn->imm);
Edward Creef1174f72017-08-07 15:26:19 +01002318 src_reg = &off_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002319 if (ptr_reg) { /* pointer += K */
2320 rc = adjust_ptr_min_max_vals(env, insn,
2321 ptr_reg, src_reg);
2322 if (rc == -EACCES && env->allow_ptr_leaks) {
2323 /* unknown scalar += K */
2324 __mark_reg_unknown(dst_reg);
2325 return adjust_scalar_min_max_vals(
2326 env, insn, dst_reg, off_reg);
2327 }
2328 return rc;
2329 }
2330 }
2331
2332 /* Got here implies adding two SCALAR_VALUEs */
2333 if (WARN_ON_ONCE(ptr_reg)) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002334 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002335 verbose(env, "verifier internal error: unexpected ptr_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01002336 return -EINVAL;
2337 }
2338 if (WARN_ON(!src_reg)) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002339 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002340 verbose(env, "verifier internal error: no src_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01002341 return -EINVAL;
2342 }
2343 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002344}
2345
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002346/* check validity of 32-bit and 64-bit arithmetic operations */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002347static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002348{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002349 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002350 u8 opcode = BPF_OP(insn->code);
2351 int err;
2352
2353 if (opcode == BPF_END || opcode == BPF_NEG) {
2354 if (opcode == BPF_NEG) {
2355 if (BPF_SRC(insn->code) != 0 ||
2356 insn->src_reg != BPF_REG_0 ||
2357 insn->off != 0 || insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002358 verbose(env, "BPF_NEG uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002359 return -EINVAL;
2360 }
2361 } else {
2362 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
Edward Creee67b8a62017-09-15 14:37:38 +01002363 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
2364 BPF_CLASS(insn->code) == BPF_ALU64) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002365 verbose(env, "BPF_END uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002366 return -EINVAL;
2367 }
2368 }
2369
2370 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01002371 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002372 if (err)
2373 return err;
2374
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002375 if (is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002376 verbose(env, "R%d pointer arithmetic prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002377 insn->dst_reg);
2378 return -EACCES;
2379 }
2380
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002381 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002382 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002383 if (err)
2384 return err;
2385
2386 } else if (opcode == BPF_MOV) {
2387
2388 if (BPF_SRC(insn->code) == BPF_X) {
2389 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002390 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002391 return -EINVAL;
2392 }
2393
2394 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01002395 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002396 if (err)
2397 return err;
2398 } else {
2399 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002400 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002401 return -EINVAL;
2402 }
2403 }
2404
2405 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002406 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002407 if (err)
2408 return err;
2409
2410 if (BPF_SRC(insn->code) == BPF_X) {
2411 if (BPF_CLASS(insn->code) == BPF_ALU64) {
2412 /* case: R1 = R2
2413 * copy register state to dest reg
2414 */
2415 regs[insn->dst_reg] = regs[insn->src_reg];
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -07002416 regs[insn->dst_reg].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002417 } else {
Edward Creef1174f72017-08-07 15:26:19 +01002418 /* R1 = (u32) R2 */
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002419 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002420 verbose(env,
2421 "R%d partial copy of pointer\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002422 insn->src_reg);
2423 return -EACCES;
2424 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002425 mark_reg_unknown(env, regs, insn->dst_reg);
Jann Horn0c17d1d2017-12-18 20:11:55 -08002426 coerce_reg_to_size(&regs[insn->dst_reg], 4);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002427 }
2428 } else {
2429 /* case: R = imm
2430 * remember the value we stored into this reg
2431 */
Edward Creef1174f72017-08-07 15:26:19 +01002432 regs[insn->dst_reg].type = SCALAR_VALUE;
Jann Horn95a762e2017-12-18 20:11:54 -08002433 if (BPF_CLASS(insn->code) == BPF_ALU64) {
2434 __mark_reg_known(regs + insn->dst_reg,
2435 insn->imm);
2436 } else {
2437 __mark_reg_known(regs + insn->dst_reg,
2438 (u32)insn->imm);
2439 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002440 }
2441
2442 } else if (opcode > BPF_END) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002443 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002444 return -EINVAL;
2445
2446 } else { /* all other ALU ops: and, sub, xor, add, ... */
2447
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002448 if (BPF_SRC(insn->code) == BPF_X) {
2449 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002450 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002451 return -EINVAL;
2452 }
2453 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002454 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002455 if (err)
2456 return err;
2457 } else {
2458 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002459 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002460 return -EINVAL;
2461 }
2462 }
2463
2464 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002465 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002466 if (err)
2467 return err;
2468
2469 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
2470 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002471 verbose(env, "div by zero\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002472 return -EINVAL;
2473 }
2474
Rabin Vincent229394e82016-01-12 20:17:08 +01002475 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
2476 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
2477 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
2478
2479 if (insn->imm < 0 || insn->imm >= size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002480 verbose(env, "invalid shift %d\n", insn->imm);
Rabin Vincent229394e82016-01-12 20:17:08 +01002481 return -EINVAL;
2482 }
2483 }
2484
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002485 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002486 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002487 if (err)
2488 return err;
2489
Edward Creef1174f72017-08-07 15:26:19 +01002490 return adjust_reg_min_max_vals(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002491 }
2492
2493 return 0;
2494}
2495
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002496static void find_good_pkt_pointers(struct bpf_verifier_state *state,
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002497 struct bpf_reg_state *dst_reg,
David S. Millerf8ddadc2017-10-22 13:36:53 +01002498 enum bpf_reg_type type,
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002499 bool range_right_open)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002500{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002501 struct bpf_reg_state *regs = state->regs, *reg;
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002502 u16 new_range;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002503 int i;
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002504
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002505 if (dst_reg->off < 0 ||
2506 (dst_reg->off == 0 && range_right_open))
Edward Creef1174f72017-08-07 15:26:19 +01002507 /* This doesn't give us any range */
2508 return;
2509
Edward Creeb03c9f92017-08-07 15:26:36 +01002510 if (dst_reg->umax_value > MAX_PACKET_OFF ||
2511 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
Edward Creef1174f72017-08-07 15:26:19 +01002512 /* Risk of overflow. For instance, ptr + (1<<63) may be less
2513 * than pkt_end, but that's because it's also less than pkt.
2514 */
2515 return;
2516
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002517 new_range = dst_reg->off;
2518 if (range_right_open)
2519 new_range--;
2520
2521 /* Examples for register markings:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002522 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002523 * pkt_data in dst register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002524 *
2525 * r2 = r3;
2526 * r2 += 8;
2527 * if (r2 > pkt_end) goto <handle exception>
2528 * <access okay>
2529 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002530 * r2 = r3;
2531 * r2 += 8;
2532 * if (r2 < pkt_end) goto <access okay>
2533 * <handle exception>
2534 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002535 * Where:
2536 * r2 == dst_reg, pkt_end == src_reg
2537 * r2=pkt(id=n,off=8,r=0)
2538 * r3=pkt(id=n,off=0,r=0)
2539 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002540 * pkt_data in src register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002541 *
2542 * r2 = r3;
2543 * r2 += 8;
2544 * if (pkt_end >= r2) goto <access okay>
2545 * <handle exception>
2546 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002547 * r2 = r3;
2548 * r2 += 8;
2549 * if (pkt_end <= r2) goto <handle exception>
2550 * <access okay>
2551 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002552 * Where:
2553 * pkt_end == dst_reg, r2 == src_reg
2554 * r2=pkt(id=n,off=8,r=0)
2555 * r3=pkt(id=n,off=0,r=0)
2556 *
2557 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002558 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
2559 * and [r3, r3 + 8-1) respectively is safe to access depending on
2560 * the check.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002561 */
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002562
Edward Creef1174f72017-08-07 15:26:19 +01002563 /* If our ids match, then we must have the same max_value. And we
2564 * don't care about the other reg's fixed offset, since if it's too big
2565 * the range won't allow anything.
2566 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
2567 */
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002568 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002569 if (regs[i].type == type && regs[i].id == dst_reg->id)
Alexei Starovoitovb1977682017-03-24 15:57:33 -07002570 /* keep the maximum range already checked */
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002571 regs[i].range = max(regs[i].range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002572
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002573 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2574 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002575 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002576 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002577 if (reg->type == type && reg->id == dst_reg->id)
Daniel Borkmannb06723d2017-11-01 23:58:09 +01002578 reg->range = max(reg->range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002579 }
2580}
2581
Josef Bacik48461132016-09-28 10:54:32 -04002582/* Adjusts the register min/max values in the case that the dst_reg is the
2583 * variable register that we are working on, and src_reg is a constant or we're
2584 * simply doing a BPF_K check.
Edward Creef1174f72017-08-07 15:26:19 +01002585 * In JEQ/JNE cases we also adjust the var_off values.
Josef Bacik48461132016-09-28 10:54:32 -04002586 */
2587static void reg_set_min_max(struct bpf_reg_state *true_reg,
2588 struct bpf_reg_state *false_reg, u64 val,
2589 u8 opcode)
2590{
Edward Creef1174f72017-08-07 15:26:19 +01002591 /* If the dst_reg is a pointer, we can't learn anything about its
2592 * variable offset from the compare (unless src_reg were a pointer into
2593 * the same object, but we don't bother with that.
2594 * Since false_reg and true_reg have the same type by construction, we
2595 * only need to check one of them for pointerness.
2596 */
2597 if (__is_pointer_value(false, false_reg))
2598 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002599
Josef Bacik48461132016-09-28 10:54:32 -04002600 switch (opcode) {
2601 case BPF_JEQ:
2602 /* If this is false then we know nothing Jon Snow, but if it is
2603 * true then we know for sure.
2604 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002605 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002606 break;
2607 case BPF_JNE:
2608 /* If this is true we know nothing Jon Snow, but if it is false
2609 * we know the value for sure;
2610 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002611 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002612 break;
2613 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002614 false_reg->umax_value = min(false_reg->umax_value, val);
2615 true_reg->umin_value = max(true_reg->umin_value, val + 1);
2616 break;
Josef Bacik48461132016-09-28 10:54:32 -04002617 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002618 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
2619 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04002620 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002621 case BPF_JLT:
2622 false_reg->umin_value = max(false_reg->umin_value, val);
2623 true_reg->umax_value = min(true_reg->umax_value, val - 1);
2624 break;
2625 case BPF_JSLT:
2626 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
2627 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
2628 break;
Josef Bacik48461132016-09-28 10:54:32 -04002629 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002630 false_reg->umax_value = min(false_reg->umax_value, val - 1);
2631 true_reg->umin_value = max(true_reg->umin_value, val);
2632 break;
Josef Bacik48461132016-09-28 10:54:32 -04002633 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002634 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
2635 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04002636 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002637 case BPF_JLE:
2638 false_reg->umin_value = max(false_reg->umin_value, val + 1);
2639 true_reg->umax_value = min(true_reg->umax_value, val);
2640 break;
2641 case BPF_JSLE:
2642 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
2643 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
2644 break;
Josef Bacik48461132016-09-28 10:54:32 -04002645 default:
2646 break;
2647 }
2648
Edward Creeb03c9f92017-08-07 15:26:36 +01002649 __reg_deduce_bounds(false_reg);
2650 __reg_deduce_bounds(true_reg);
2651 /* We might have learned some bits from the bounds. */
2652 __reg_bound_offset(false_reg);
2653 __reg_bound_offset(true_reg);
2654 /* Intersecting with the old var_off might have improved our bounds
2655 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2656 * then new var_off is (0; 0x7f...fc) which improves our umax.
2657 */
2658 __update_reg_bounds(false_reg);
2659 __update_reg_bounds(true_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002660}
2661
Edward Creef1174f72017-08-07 15:26:19 +01002662/* Same as above, but for the case that dst_reg holds a constant and src_reg is
2663 * the variable reg.
Josef Bacik48461132016-09-28 10:54:32 -04002664 */
2665static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
2666 struct bpf_reg_state *false_reg, u64 val,
2667 u8 opcode)
2668{
Edward Creef1174f72017-08-07 15:26:19 +01002669 if (__is_pointer_value(false, false_reg))
2670 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002671
Josef Bacik48461132016-09-28 10:54:32 -04002672 switch (opcode) {
2673 case BPF_JEQ:
2674 /* If this is false then we know nothing Jon Snow, but if it is
2675 * true then we know for sure.
2676 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002677 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002678 break;
2679 case BPF_JNE:
2680 /* If this is true we know nothing Jon Snow, but if it is false
2681 * we know the value for sure;
2682 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002683 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002684 break;
2685 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002686 true_reg->umax_value = min(true_reg->umax_value, val - 1);
2687 false_reg->umin_value = max(false_reg->umin_value, val);
2688 break;
Josef Bacik48461132016-09-28 10:54:32 -04002689 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002690 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
2691 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04002692 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002693 case BPF_JLT:
2694 true_reg->umin_value = max(true_reg->umin_value, val + 1);
2695 false_reg->umax_value = min(false_reg->umax_value, val);
2696 break;
2697 case BPF_JSLT:
2698 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
2699 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
2700 break;
Josef Bacik48461132016-09-28 10:54:32 -04002701 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002702 true_reg->umax_value = min(true_reg->umax_value, val);
2703 false_reg->umin_value = max(false_reg->umin_value, val + 1);
2704 break;
Josef Bacik48461132016-09-28 10:54:32 -04002705 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002706 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
2707 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04002708 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002709 case BPF_JLE:
2710 true_reg->umin_value = max(true_reg->umin_value, val);
2711 false_reg->umax_value = min(false_reg->umax_value, val - 1);
2712 break;
2713 case BPF_JSLE:
2714 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
2715 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
2716 break;
Josef Bacik48461132016-09-28 10:54:32 -04002717 default:
2718 break;
2719 }
2720
Edward Creeb03c9f92017-08-07 15:26:36 +01002721 __reg_deduce_bounds(false_reg);
2722 __reg_deduce_bounds(true_reg);
2723 /* We might have learned some bits from the bounds. */
2724 __reg_bound_offset(false_reg);
2725 __reg_bound_offset(true_reg);
2726 /* Intersecting with the old var_off might have improved our bounds
2727 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2728 * then new var_off is (0; 0x7f...fc) which improves our umax.
2729 */
2730 __update_reg_bounds(false_reg);
2731 __update_reg_bounds(true_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002732}
2733
2734/* Regs are known to be equal, so intersect their min/max/var_off */
2735static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
2736 struct bpf_reg_state *dst_reg)
2737{
Edward Creeb03c9f92017-08-07 15:26:36 +01002738 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
2739 dst_reg->umin_value);
2740 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
2741 dst_reg->umax_value);
2742 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
2743 dst_reg->smin_value);
2744 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
2745 dst_reg->smax_value);
Edward Creef1174f72017-08-07 15:26:19 +01002746 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
2747 dst_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002748 /* We might have learned new bounds from the var_off. */
2749 __update_reg_bounds(src_reg);
2750 __update_reg_bounds(dst_reg);
2751 /* We might have learned something about the sign bit. */
2752 __reg_deduce_bounds(src_reg);
2753 __reg_deduce_bounds(dst_reg);
2754 /* We might have learned some bits from the bounds. */
2755 __reg_bound_offset(src_reg);
2756 __reg_bound_offset(dst_reg);
2757 /* Intersecting with the old var_off might have improved our bounds
2758 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2759 * then new var_off is (0; 0x7f...fc) which improves our umax.
2760 */
2761 __update_reg_bounds(src_reg);
2762 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002763}
2764
2765static void reg_combine_min_max(struct bpf_reg_state *true_src,
2766 struct bpf_reg_state *true_dst,
2767 struct bpf_reg_state *false_src,
2768 struct bpf_reg_state *false_dst,
2769 u8 opcode)
2770{
2771 switch (opcode) {
2772 case BPF_JEQ:
2773 __reg_combine_min_max(true_src, true_dst);
2774 break;
2775 case BPF_JNE:
2776 __reg_combine_min_max(false_src, false_dst);
Edward Creeb03c9f92017-08-07 15:26:36 +01002777 break;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002778 }
Josef Bacik48461132016-09-28 10:54:32 -04002779}
2780
Thomas Graf57a09bf2016-10-18 19:51:19 +02002781static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
Edward Creef1174f72017-08-07 15:26:19 +01002782 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002783{
2784 struct bpf_reg_state *reg = &regs[regno];
2785
2786 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
Edward Creef1174f72017-08-07 15:26:19 +01002787 /* Old offset (both fixed and variable parts) should
2788 * have been known-zero, because we don't allow pointer
2789 * arithmetic on pointers that might be NULL.
2790 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002791 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
2792 !tnum_equals_const(reg->var_off, 0) ||
Edward Creef1174f72017-08-07 15:26:19 +01002793 reg->off)) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002794 __mark_reg_known_zero(reg);
2795 reg->off = 0;
Edward Creef1174f72017-08-07 15:26:19 +01002796 }
2797 if (is_null) {
2798 reg->type = SCALAR_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002799 } else if (reg->map_ptr->inner_map_meta) {
2800 reg->type = CONST_PTR_TO_MAP;
2801 reg->map_ptr = reg->map_ptr->inner_map_meta;
2802 } else {
Edward Creef1174f72017-08-07 15:26:19 +01002803 reg->type = PTR_TO_MAP_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002804 }
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002805 /* We don't need id from this point onwards anymore, thus we
2806 * should better reset it, so that state pruning has chances
2807 * to take effect.
2808 */
2809 reg->id = 0;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002810 }
2811}
2812
2813/* The logic is similar to find_good_pkt_pointers(), both could eventually
2814 * be folded together at some point.
2815 */
2816static void mark_map_regs(struct bpf_verifier_state *state, u32 regno,
Edward Creef1174f72017-08-07 15:26:19 +01002817 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002818{
2819 struct bpf_reg_state *regs = state->regs;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002820 u32 id = regs[regno].id;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002821 int i;
2822
2823 for (i = 0; i < MAX_BPF_REG; i++)
Edward Creef1174f72017-08-07 15:26:19 +01002824 mark_map_reg(regs, i, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002825
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002826 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2827 if (state->stack[i].slot_type[0] != STACK_SPILL)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002828 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002829 mark_map_reg(&state->stack[i].spilled_ptr, 0, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002830 }
2831}
2832
Daniel Borkmann5beca082017-11-01 23:58:10 +01002833static bool try_match_pkt_pointers(const struct bpf_insn *insn,
2834 struct bpf_reg_state *dst_reg,
2835 struct bpf_reg_state *src_reg,
2836 struct bpf_verifier_state *this_branch,
2837 struct bpf_verifier_state *other_branch)
2838{
2839 if (BPF_SRC(insn->code) != BPF_X)
2840 return false;
2841
2842 switch (BPF_OP(insn->code)) {
2843 case BPF_JGT:
2844 if ((dst_reg->type == PTR_TO_PACKET &&
2845 src_reg->type == PTR_TO_PACKET_END) ||
2846 (dst_reg->type == PTR_TO_PACKET_META &&
2847 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2848 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
2849 find_good_pkt_pointers(this_branch, dst_reg,
2850 dst_reg->type, false);
2851 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2852 src_reg->type == PTR_TO_PACKET) ||
2853 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2854 src_reg->type == PTR_TO_PACKET_META)) {
2855 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
2856 find_good_pkt_pointers(other_branch, src_reg,
2857 src_reg->type, true);
2858 } else {
2859 return false;
2860 }
2861 break;
2862 case BPF_JLT:
2863 if ((dst_reg->type == PTR_TO_PACKET &&
2864 src_reg->type == PTR_TO_PACKET_END) ||
2865 (dst_reg->type == PTR_TO_PACKET_META &&
2866 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2867 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
2868 find_good_pkt_pointers(other_branch, dst_reg,
2869 dst_reg->type, true);
2870 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2871 src_reg->type == PTR_TO_PACKET) ||
2872 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2873 src_reg->type == PTR_TO_PACKET_META)) {
2874 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
2875 find_good_pkt_pointers(this_branch, src_reg,
2876 src_reg->type, false);
2877 } else {
2878 return false;
2879 }
2880 break;
2881 case BPF_JGE:
2882 if ((dst_reg->type == PTR_TO_PACKET &&
2883 src_reg->type == PTR_TO_PACKET_END) ||
2884 (dst_reg->type == PTR_TO_PACKET_META &&
2885 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2886 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
2887 find_good_pkt_pointers(this_branch, dst_reg,
2888 dst_reg->type, true);
2889 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2890 src_reg->type == PTR_TO_PACKET) ||
2891 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2892 src_reg->type == PTR_TO_PACKET_META)) {
2893 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
2894 find_good_pkt_pointers(other_branch, src_reg,
2895 src_reg->type, false);
2896 } else {
2897 return false;
2898 }
2899 break;
2900 case BPF_JLE:
2901 if ((dst_reg->type == PTR_TO_PACKET &&
2902 src_reg->type == PTR_TO_PACKET_END) ||
2903 (dst_reg->type == PTR_TO_PACKET_META &&
2904 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2905 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
2906 find_good_pkt_pointers(other_branch, dst_reg,
2907 dst_reg->type, false);
2908 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2909 src_reg->type == PTR_TO_PACKET) ||
2910 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2911 src_reg->type == PTR_TO_PACKET_META)) {
2912 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
2913 find_good_pkt_pointers(this_branch, src_reg,
2914 src_reg->type, true);
2915 } else {
2916 return false;
2917 }
2918 break;
2919 default:
2920 return false;
2921 }
2922
2923 return true;
2924}
2925
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002926static int check_cond_jmp_op(struct bpf_verifier_env *env,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002927 struct bpf_insn *insn, int *insn_idx)
2928{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002929 struct bpf_verifier_state *other_branch, *this_branch = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002930 struct bpf_reg_state *regs = this_branch->regs, *dst_reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002931 u8 opcode = BPF_OP(insn->code);
2932 int err;
2933
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002934 if (opcode > BPF_JSLE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002935 verbose(env, "invalid BPF_JMP opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002936 return -EINVAL;
2937 }
2938
2939 if (BPF_SRC(insn->code) == BPF_X) {
2940 if (insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002941 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002942 return -EINVAL;
2943 }
2944
2945 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002946 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002947 if (err)
2948 return err;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002949
2950 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002951 verbose(env, "R%d pointer comparison prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002952 insn->src_reg);
2953 return -EACCES;
2954 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002955 } else {
2956 if (insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002957 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002958 return -EINVAL;
2959 }
2960 }
2961
2962 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002963 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002964 if (err)
2965 return err;
2966
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002967 dst_reg = &regs[insn->dst_reg];
2968
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002969 /* detect if R == 0 where R was initialized to zero earlier */
2970 if (BPF_SRC(insn->code) == BPF_K &&
2971 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
Edward Creef1174f72017-08-07 15:26:19 +01002972 dst_reg->type == SCALAR_VALUE &&
2973 tnum_equals_const(dst_reg->var_off, insn->imm)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002974 if (opcode == BPF_JEQ) {
2975 /* if (imm == imm) goto pc+off;
2976 * only follow the goto, ignore fall-through
2977 */
2978 *insn_idx += insn->off;
2979 return 0;
2980 } else {
2981 /* if (imm != imm) goto pc+off;
2982 * only follow fall-through branch, since
2983 * that's where the program will go
2984 */
2985 return 0;
2986 }
2987 }
2988
2989 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
2990 if (!other_branch)
2991 return -EFAULT;
2992
Josef Bacik48461132016-09-28 10:54:32 -04002993 /* detect if we are comparing against a constant value so we can adjust
2994 * our min/max values for our dst register.
Edward Creef1174f72017-08-07 15:26:19 +01002995 * this is only legit if both are scalars (or pointers to the same
2996 * object, I suppose, but we don't support that right now), because
2997 * otherwise the different base pointers mean the offsets aren't
2998 * comparable.
Josef Bacik48461132016-09-28 10:54:32 -04002999 */
3000 if (BPF_SRC(insn->code) == BPF_X) {
Edward Creef1174f72017-08-07 15:26:19 +01003001 if (dst_reg->type == SCALAR_VALUE &&
3002 regs[insn->src_reg].type == SCALAR_VALUE) {
3003 if (tnum_is_const(regs[insn->src_reg].var_off))
3004 reg_set_min_max(&other_branch->regs[insn->dst_reg],
3005 dst_reg, regs[insn->src_reg].var_off.value,
3006 opcode);
3007 else if (tnum_is_const(dst_reg->var_off))
3008 reg_set_min_max_inv(&other_branch->regs[insn->src_reg],
3009 &regs[insn->src_reg],
3010 dst_reg->var_off.value, opcode);
3011 else if (opcode == BPF_JEQ || opcode == BPF_JNE)
3012 /* Comparing for equality, we can combine knowledge */
3013 reg_combine_min_max(&other_branch->regs[insn->src_reg],
3014 &other_branch->regs[insn->dst_reg],
3015 &regs[insn->src_reg],
3016 &regs[insn->dst_reg], opcode);
3017 }
3018 } else if (dst_reg->type == SCALAR_VALUE) {
Josef Bacik48461132016-09-28 10:54:32 -04003019 reg_set_min_max(&other_branch->regs[insn->dst_reg],
3020 dst_reg, insn->imm, opcode);
3021 }
3022
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003023 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003024 if (BPF_SRC(insn->code) == BPF_K &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003025 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
3026 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Thomas Graf57a09bf2016-10-18 19:51:19 +02003027 /* Mark all identical map registers in each branch as either
3028 * safe or unknown depending R == 0 or R != 0 conditional.
3029 */
Edward Creef1174f72017-08-07 15:26:19 +01003030 mark_map_regs(this_branch, insn->dst_reg, opcode == BPF_JNE);
3031 mark_map_regs(other_branch, insn->dst_reg, opcode == BPF_JEQ);
Daniel Borkmann5beca082017-11-01 23:58:10 +01003032 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
3033 this_branch, other_branch) &&
3034 is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003035 verbose(env, "R%d pointer comparison prohibited\n",
3036 insn->dst_reg);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003037 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003038 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003039 if (env->log.level)
3040 print_verifier_state(env, this_branch);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003041 return 0;
3042}
3043
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003044/* return the map pointer stored inside BPF_LD_IMM64 instruction */
3045static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
3046{
3047 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
3048
3049 return (struct bpf_map *) (unsigned long) imm64;
3050}
3051
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003052/* verify BPF_LD_IMM64 instruction */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003053static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003054{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003055 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003056 int err;
3057
3058 if (BPF_SIZE(insn->code) != BPF_DW) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003059 verbose(env, "invalid BPF_LD_IMM insn\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003060 return -EINVAL;
3061 }
3062 if (insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003063 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003064 return -EINVAL;
3065 }
3066
Edward Creedc503a82017-08-15 20:34:35 +01003067 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003068 if (err)
3069 return err;
3070
Jakub Kicinski6b173872016-09-21 11:43:59 +01003071 if (insn->src_reg == 0) {
Jakub Kicinski6b173872016-09-21 11:43:59 +01003072 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
3073
Edward Creef1174f72017-08-07 15:26:19 +01003074 regs[insn->dst_reg].type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01003075 __mark_reg_known(&regs[insn->dst_reg], imm);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003076 return 0;
Jakub Kicinski6b173872016-09-21 11:43:59 +01003077 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003078
3079 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
3080 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
3081
3082 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
3083 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
3084 return 0;
3085}
3086
Daniel Borkmann96be4322015-03-01 12:31:46 +01003087static bool may_access_skb(enum bpf_prog_type type)
3088{
3089 switch (type) {
3090 case BPF_PROG_TYPE_SOCKET_FILTER:
3091 case BPF_PROG_TYPE_SCHED_CLS:
Daniel Borkmann94caee8c2015-03-20 15:11:11 +01003092 case BPF_PROG_TYPE_SCHED_ACT:
Daniel Borkmann96be4322015-03-01 12:31:46 +01003093 return true;
3094 default:
3095 return false;
3096 }
3097}
3098
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003099/* verify safety of LD_ABS|LD_IND instructions:
3100 * - they can only appear in the programs where ctx == skb
3101 * - since they are wrappers of function calls, they scratch R1-R5 registers,
3102 * preserve R6-R9, and store return value into R0
3103 *
3104 * Implicit input:
3105 * ctx == skb == R6 == CTX
3106 *
3107 * Explicit input:
3108 * SRC == any register
3109 * IMM == 32-bit immediate
3110 *
3111 * Output:
3112 * R0 - 8/16/32-bit skb data converted to cpu endianness
3113 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003114static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003115{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003116 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003117 u8 mode = BPF_MODE(insn->code);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003118 int i, err;
3119
Daniel Borkmann24701ec2015-03-01 12:31:47 +01003120 if (!may_access_skb(env->prog->type)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003121 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003122 return -EINVAL;
3123 }
3124
3125 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
Alexei Starovoitovd82bccc2016-04-12 10:26:19 -07003126 BPF_SIZE(insn->code) == BPF_DW ||
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003127 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003128 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003129 return -EINVAL;
3130 }
3131
3132 /* check whether implicit source operand (register R6) is readable */
Edward Creedc503a82017-08-15 20:34:35 +01003133 err = check_reg_arg(env, BPF_REG_6, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003134 if (err)
3135 return err;
3136
3137 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003138 verbose(env,
3139 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003140 return -EINVAL;
3141 }
3142
3143 if (mode == BPF_IND) {
3144 /* check explicit source operand */
Edward Creedc503a82017-08-15 20:34:35 +01003145 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003146 if (err)
3147 return err;
3148 }
3149
3150 /* reset caller saved regs to unreadable */
Edward Creedc503a82017-08-15 20:34:35 +01003151 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003152 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01003153 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
3154 }
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003155
3156 /* mark destination R0 register as readable, since it contains
Edward Creedc503a82017-08-15 20:34:35 +01003157 * the value fetched from the packet.
3158 * Already marked as written above.
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003159 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003160 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003161 return 0;
3162}
3163
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003164static int check_return_code(struct bpf_verifier_env *env)
3165{
3166 struct bpf_reg_state *reg;
3167 struct tnum range = tnum_range(0, 1);
3168
3169 switch (env->prog->type) {
3170 case BPF_PROG_TYPE_CGROUP_SKB:
3171 case BPF_PROG_TYPE_CGROUP_SOCK:
3172 case BPF_PROG_TYPE_SOCK_OPS:
Roman Gushchinebc614f2017-11-05 08:15:32 -05003173 case BPF_PROG_TYPE_CGROUP_DEVICE:
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003174 break;
3175 default:
3176 return 0;
3177 }
3178
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003179 reg = cur_regs(env) + BPF_REG_0;
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003180 if (reg->type != SCALAR_VALUE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003181 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003182 reg_type_str[reg->type]);
3183 return -EINVAL;
3184 }
3185
3186 if (!tnum_in(range, reg->var_off)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003187 verbose(env, "At program exit the register R0 ");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003188 if (!tnum_is_unknown(reg->var_off)) {
3189 char tn_buf[48];
3190
3191 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003192 verbose(env, "has value %s", tn_buf);
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003193 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003194 verbose(env, "has unknown scalar value");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003195 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003196 verbose(env, " should have been 0 or 1\n");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003197 return -EINVAL;
3198 }
3199 return 0;
3200}
3201
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003202/* non-recursive DFS pseudo code
3203 * 1 procedure DFS-iterative(G,v):
3204 * 2 label v as discovered
3205 * 3 let S be a stack
3206 * 4 S.push(v)
3207 * 5 while S is not empty
3208 * 6 t <- S.pop()
3209 * 7 if t is what we're looking for:
3210 * 8 return t
3211 * 9 for all edges e in G.adjacentEdges(t) do
3212 * 10 if edge e is already labelled
3213 * 11 continue with the next edge
3214 * 12 w <- G.adjacentVertex(t,e)
3215 * 13 if vertex w is not discovered and not explored
3216 * 14 label e as tree-edge
3217 * 15 label w as discovered
3218 * 16 S.push(w)
3219 * 17 continue at 5
3220 * 18 else if vertex w is discovered
3221 * 19 label e as back-edge
3222 * 20 else
3223 * 21 // vertex w is explored
3224 * 22 label e as forward- or cross-edge
3225 * 23 label t as explored
3226 * 24 S.pop()
3227 *
3228 * convention:
3229 * 0x10 - discovered
3230 * 0x11 - discovered and fall-through edge labelled
3231 * 0x12 - discovered and fall-through and branch edges labelled
3232 * 0x20 - explored
3233 */
3234
3235enum {
3236 DISCOVERED = 0x10,
3237 EXPLORED = 0x20,
3238 FALLTHROUGH = 1,
3239 BRANCH = 2,
3240};
3241
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003242#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003243
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003244static int *insn_stack; /* stack of insns to process */
3245static int cur_stack; /* current stack index */
3246static int *insn_state;
3247
3248/* t, w, e - match pseudo-code above:
3249 * t - index of current instruction
3250 * w - next instruction
3251 * e - edge
3252 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003253static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003254{
3255 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
3256 return 0;
3257
3258 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
3259 return 0;
3260
3261 if (w < 0 || w >= env->prog->len) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003262 verbose(env, "jump out of range from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003263 return -EINVAL;
3264 }
3265
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003266 if (e == BRANCH)
3267 /* mark branch target for state pruning */
3268 env->explored_states[w] = STATE_LIST_MARK;
3269
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003270 if (insn_state[w] == 0) {
3271 /* tree-edge */
3272 insn_state[t] = DISCOVERED | e;
3273 insn_state[w] = DISCOVERED;
3274 if (cur_stack >= env->prog->len)
3275 return -E2BIG;
3276 insn_stack[cur_stack++] = w;
3277 return 1;
3278 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003279 verbose(env, "back-edge from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003280 return -EINVAL;
3281 } else if (insn_state[w] == EXPLORED) {
3282 /* forward- or cross-edge */
3283 insn_state[t] = DISCOVERED | e;
3284 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003285 verbose(env, "insn state internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003286 return -EFAULT;
3287 }
3288 return 0;
3289}
3290
3291/* non-recursive depth-first-search to detect loops in BPF program
3292 * loop == back-edge in directed graph
3293 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003294static int check_cfg(struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003295{
3296 struct bpf_insn *insns = env->prog->insnsi;
3297 int insn_cnt = env->prog->len;
3298 int ret = 0;
3299 int i, t;
3300
3301 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
3302 if (!insn_state)
3303 return -ENOMEM;
3304
3305 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
3306 if (!insn_stack) {
3307 kfree(insn_state);
3308 return -ENOMEM;
3309 }
3310
3311 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
3312 insn_stack[0] = 0; /* 0 is the first instruction */
3313 cur_stack = 1;
3314
3315peek_stack:
3316 if (cur_stack == 0)
3317 goto check_state;
3318 t = insn_stack[cur_stack - 1];
3319
3320 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
3321 u8 opcode = BPF_OP(insns[t].code);
3322
3323 if (opcode == BPF_EXIT) {
3324 goto mark_explored;
3325 } else if (opcode == BPF_CALL) {
3326 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3327 if (ret == 1)
3328 goto peek_stack;
3329 else if (ret < 0)
3330 goto err_free;
Daniel Borkmann07016152016-04-05 22:33:17 +02003331 if (t + 1 < insn_cnt)
3332 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003333 } else if (opcode == BPF_JA) {
3334 if (BPF_SRC(insns[t].code) != BPF_K) {
3335 ret = -EINVAL;
3336 goto err_free;
3337 }
3338 /* unconditional jump with single edge */
3339 ret = push_insn(t, t + insns[t].off + 1,
3340 FALLTHROUGH, env);
3341 if (ret == 1)
3342 goto peek_stack;
3343 else if (ret < 0)
3344 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003345 /* tell verifier to check for equivalent states
3346 * after every call and jump
3347 */
Alexei Starovoitovc3de6312015-04-14 15:57:13 -07003348 if (t + 1 < insn_cnt)
3349 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003350 } else {
3351 /* conditional jump with two edges */
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02003352 env->explored_states[t] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003353 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3354 if (ret == 1)
3355 goto peek_stack;
3356 else if (ret < 0)
3357 goto err_free;
3358
3359 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
3360 if (ret == 1)
3361 goto peek_stack;
3362 else if (ret < 0)
3363 goto err_free;
3364 }
3365 } else {
3366 /* all other non-branch instructions with single
3367 * fall-through edge
3368 */
3369 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3370 if (ret == 1)
3371 goto peek_stack;
3372 else if (ret < 0)
3373 goto err_free;
3374 }
3375
3376mark_explored:
3377 insn_state[t] = EXPLORED;
3378 if (cur_stack-- <= 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003379 verbose(env, "pop stack internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003380 ret = -EFAULT;
3381 goto err_free;
3382 }
3383 goto peek_stack;
3384
3385check_state:
3386 for (i = 0; i < insn_cnt; i++) {
3387 if (insn_state[i] != EXPLORED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003388 verbose(env, "unreachable insn %d\n", i);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003389 ret = -EINVAL;
3390 goto err_free;
3391 }
3392 }
3393 ret = 0; /* cfg looks good */
3394
3395err_free:
3396 kfree(insn_state);
3397 kfree(insn_stack);
3398 return ret;
3399}
3400
Edward Creef1174f72017-08-07 15:26:19 +01003401/* check %cur's range satisfies %old's */
3402static bool range_within(struct bpf_reg_state *old,
3403 struct bpf_reg_state *cur)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003404{
Edward Creeb03c9f92017-08-07 15:26:36 +01003405 return old->umin_value <= cur->umin_value &&
3406 old->umax_value >= cur->umax_value &&
3407 old->smin_value <= cur->smin_value &&
3408 old->smax_value >= cur->smax_value;
Edward Creef1174f72017-08-07 15:26:19 +01003409}
3410
3411/* Maximum number of register states that can exist at once */
3412#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
3413struct idpair {
3414 u32 old;
3415 u32 cur;
3416};
3417
3418/* If in the old state two registers had the same id, then they need to have
3419 * the same id in the new state as well. But that id could be different from
3420 * the old state, so we need to track the mapping from old to new ids.
3421 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
3422 * regs with old id 5 must also have new id 9 for the new state to be safe. But
3423 * regs with a different old id could still have new id 9, we don't care about
3424 * that.
3425 * So we look through our idmap to see if this old id has been seen before. If
3426 * so, we require the new id to match; otherwise, we add the id pair to the map.
3427 */
3428static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
3429{
3430 unsigned int i;
3431
3432 for (i = 0; i < ID_MAP_SIZE; i++) {
3433 if (!idmap[i].old) {
3434 /* Reached an empty slot; haven't seen this id before */
3435 idmap[i].old = old_id;
3436 idmap[i].cur = cur_id;
3437 return true;
3438 }
3439 if (idmap[i].old == old_id)
3440 return idmap[i].cur == cur_id;
3441 }
3442 /* We ran out of idmap slots, which should be impossible */
3443 WARN_ON_ONCE(1);
3444 return false;
3445}
3446
3447/* Returns true if (rold safe implies rcur safe) */
Edward Cree1b688a12017-08-23 15:10:50 +01003448static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
3449 struct idpair *idmap)
Edward Creef1174f72017-08-07 15:26:19 +01003450{
Edward Creedc503a82017-08-15 20:34:35 +01003451 if (!(rold->live & REG_LIVE_READ))
3452 /* explored state didn't use this */
3453 return true;
3454
3455 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, live)) == 0)
Edward Creef1174f72017-08-07 15:26:19 +01003456 return true;
3457
3458 if (rold->type == NOT_INIT)
3459 /* explored state can't have used this */
3460 return true;
3461 if (rcur->type == NOT_INIT)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003462 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003463 switch (rold->type) {
3464 case SCALAR_VALUE:
3465 if (rcur->type == SCALAR_VALUE) {
3466 /* new val must satisfy old val knowledge */
3467 return range_within(rold, rcur) &&
3468 tnum_in(rold->var_off, rcur->var_off);
3469 } else {
Jann Horn179d1c52017-12-18 20:11:59 -08003470 /* We're trying to use a pointer in place of a scalar.
3471 * Even if the scalar was unbounded, this could lead to
3472 * pointer leaks because scalars are allowed to leak
3473 * while pointers are not. We could make this safe in
3474 * special cases if root is calling us, but it's
3475 * probably not worth the hassle.
Edward Creef1174f72017-08-07 15:26:19 +01003476 */
Jann Horn179d1c52017-12-18 20:11:59 -08003477 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003478 }
3479 case PTR_TO_MAP_VALUE:
Edward Cree1b688a12017-08-23 15:10:50 +01003480 /* If the new min/max/var_off satisfy the old ones and
3481 * everything else matches, we are OK.
3482 * We don't care about the 'id' value, because nothing
3483 * uses it for PTR_TO_MAP_VALUE (only for ..._OR_NULL)
3484 */
3485 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
3486 range_within(rold, rcur) &&
3487 tnum_in(rold->var_off, rcur->var_off);
Edward Creef1174f72017-08-07 15:26:19 +01003488 case PTR_TO_MAP_VALUE_OR_NULL:
3489 /* a PTR_TO_MAP_VALUE could be safe to use as a
3490 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
3491 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
3492 * checked, doing so could have affected others with the same
3493 * id, and we can't check for that because we lost the id when
3494 * we converted to a PTR_TO_MAP_VALUE.
3495 */
3496 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
3497 return false;
3498 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
3499 return false;
3500 /* Check our ids match any regs they're supposed to */
3501 return check_ids(rold->id, rcur->id, idmap);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003502 case PTR_TO_PACKET_META:
Edward Creef1174f72017-08-07 15:26:19 +01003503 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003504 if (rcur->type != rold->type)
Edward Creef1174f72017-08-07 15:26:19 +01003505 return false;
3506 /* We must have at least as much range as the old ptr
3507 * did, so that any accesses which were safe before are
3508 * still safe. This is true even if old range < old off,
3509 * since someone could have accessed through (ptr - k), or
3510 * even done ptr -= k in a register, to get a safe access.
3511 */
3512 if (rold->range > rcur->range)
3513 return false;
3514 /* If the offsets don't match, we can't trust our alignment;
3515 * nor can we be sure that we won't fall out of range.
3516 */
3517 if (rold->off != rcur->off)
3518 return false;
3519 /* id relations must be preserved */
3520 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
3521 return false;
3522 /* new val must satisfy old val knowledge */
3523 return range_within(rold, rcur) &&
3524 tnum_in(rold->var_off, rcur->var_off);
3525 case PTR_TO_CTX:
3526 case CONST_PTR_TO_MAP:
3527 case PTR_TO_STACK:
3528 case PTR_TO_PACKET_END:
3529 /* Only valid matches are exact, which memcmp() above
3530 * would have accepted
3531 */
3532 default:
3533 /* Don't know what's going on, just say it's not safe */
3534 return false;
3535 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003536
Edward Creef1174f72017-08-07 15:26:19 +01003537 /* Shouldn't get here; if we do, say it's not safe */
3538 WARN_ON_ONCE(1);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003539 return false;
3540}
3541
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003542static bool stacksafe(struct bpf_verifier_state *old,
3543 struct bpf_verifier_state *cur,
3544 struct idpair *idmap)
3545{
3546 int i, spi;
3547
3548 /* if explored stack has more populated slots than current stack
3549 * such stacks are not equivalent
3550 */
3551 if (old->allocated_stack > cur->allocated_stack)
3552 return false;
3553
3554 /* walk slots of the explored stack and ignore any additional
3555 * slots in the current stack, since explored(safe) state
3556 * didn't use them
3557 */
3558 for (i = 0; i < old->allocated_stack; i++) {
3559 spi = i / BPF_REG_SIZE;
3560
3561 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
3562 continue;
3563 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
3564 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
3565 /* Ex: old explored (safe) state has STACK_SPILL in
3566 * this stack slot, but current has has STACK_MISC ->
3567 * this verifier states are not equivalent,
3568 * return false to continue verification of this path
3569 */
3570 return false;
3571 if (i % BPF_REG_SIZE)
3572 continue;
3573 if (old->stack[spi].slot_type[0] != STACK_SPILL)
3574 continue;
3575 if (!regsafe(&old->stack[spi].spilled_ptr,
3576 &cur->stack[spi].spilled_ptr,
3577 idmap))
3578 /* when explored and current stack slot are both storing
3579 * spilled registers, check that stored pointers types
3580 * are the same as well.
3581 * Ex: explored safe path could have stored
3582 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
3583 * but current path has stored:
3584 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
3585 * such verifier states are not equivalent.
3586 * return false to continue verification of this path
3587 */
3588 return false;
3589 }
3590 return true;
3591}
3592
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003593/* compare two verifier states
3594 *
3595 * all states stored in state_list are known to be valid, since
3596 * verifier reached 'bpf_exit' instruction through them
3597 *
3598 * this function is called when verifier exploring different branches of
3599 * execution popped from the state stack. If it sees an old state that has
3600 * more strict register state and more strict stack state then this execution
3601 * branch doesn't need to be explored further, since verifier already
3602 * concluded that more strict state leads to valid finish.
3603 *
3604 * Therefore two states are equivalent if register state is more conservative
3605 * and explored stack state is more conservative than the current one.
3606 * Example:
3607 * explored current
3608 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
3609 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
3610 *
3611 * In other words if current stack state (one being explored) has more
3612 * valid slots than old one that already passed validation, it means
3613 * the verifier can stop exploring and conclude that current state is valid too
3614 *
3615 * Similarly with registers. If explored state has register type as invalid
3616 * whereas register type in current state is meaningful, it means that
3617 * the current state will reach 'bpf_exit' instruction safely
3618 */
Josef Bacik48461132016-09-28 10:54:32 -04003619static bool states_equal(struct bpf_verifier_env *env,
3620 struct bpf_verifier_state *old,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003621 struct bpf_verifier_state *cur)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003622{
Edward Creef1174f72017-08-07 15:26:19 +01003623 struct idpair *idmap;
3624 bool ret = false;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003625 int i;
3626
Edward Creef1174f72017-08-07 15:26:19 +01003627 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
3628 /* If we failed to allocate the idmap, just say it's not safe */
3629 if (!idmap)
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003630 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003631
3632 for (i = 0; i < MAX_BPF_REG; i++) {
Edward Cree1b688a12017-08-23 15:10:50 +01003633 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
Edward Creef1174f72017-08-07 15:26:19 +01003634 goto out_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003635 }
3636
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003637 if (!stacksafe(old, cur, idmap))
3638 goto out_free;
Edward Creef1174f72017-08-07 15:26:19 +01003639 ret = true;
3640out_free:
3641 kfree(idmap);
3642 return ret;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003643}
3644
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003645/* A write screens off any subsequent reads; but write marks come from the
3646 * straight-line code between a state and its parent. When we arrive at a
3647 * jump target (in the first iteration of the propagate_liveness() loop),
3648 * we didn't arrive by the straight-line code, so read marks in state must
3649 * propagate to parent regardless of state's write marks.
3650 */
Edward Creedc503a82017-08-15 20:34:35 +01003651static bool do_propagate_liveness(const struct bpf_verifier_state *state,
3652 struct bpf_verifier_state *parent)
3653{
Edward Cree63f45f82017-08-23 15:10:03 +01003654 bool writes = parent == state->parent; /* Observe write marks */
Edward Creedc503a82017-08-15 20:34:35 +01003655 bool touched = false; /* any changes made? */
3656 int i;
3657
3658 if (!parent)
3659 return touched;
3660 /* Propagate read liveness of registers... */
3661 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
3662 /* We don't need to worry about FP liveness because it's read-only */
3663 for (i = 0; i < BPF_REG_FP; i++) {
3664 if (parent->regs[i].live & REG_LIVE_READ)
3665 continue;
Edward Cree63f45f82017-08-23 15:10:03 +01003666 if (writes && (state->regs[i].live & REG_LIVE_WRITTEN))
3667 continue;
3668 if (state->regs[i].live & REG_LIVE_READ) {
Edward Creedc503a82017-08-15 20:34:35 +01003669 parent->regs[i].live |= REG_LIVE_READ;
3670 touched = true;
3671 }
3672 }
3673 /* ... and stack slots */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003674 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
3675 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
3676 if (parent->stack[i].slot_type[0] != STACK_SPILL)
Edward Creedc503a82017-08-15 20:34:35 +01003677 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003678 if (state->stack[i].slot_type[0] != STACK_SPILL)
Edward Creedc503a82017-08-15 20:34:35 +01003679 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003680 if (parent->stack[i].spilled_ptr.live & REG_LIVE_READ)
Edward Creedc503a82017-08-15 20:34:35 +01003681 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003682 if (writes &&
3683 (state->stack[i].spilled_ptr.live & REG_LIVE_WRITTEN))
Edward Cree63f45f82017-08-23 15:10:03 +01003684 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003685 if (state->stack[i].spilled_ptr.live & REG_LIVE_READ) {
3686 parent->stack[i].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +01003687 touched = true;
3688 }
3689 }
3690 return touched;
3691}
3692
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003693/* "parent" is "a state from which we reach the current state", but initially
3694 * it is not the state->parent (i.e. "the state whose straight-line code leads
3695 * to the current state"), instead it is the state that happened to arrive at
3696 * a (prunable) equivalent of the current state. See comment above
3697 * do_propagate_liveness() for consequences of this.
3698 * This function is just a more efficient way of calling mark_reg_read() or
3699 * mark_stack_slot_read() on each reg in "parent" that is read in "state",
3700 * though it requires that parent != state->parent in the call arguments.
3701 */
Edward Creedc503a82017-08-15 20:34:35 +01003702static void propagate_liveness(const struct bpf_verifier_state *state,
3703 struct bpf_verifier_state *parent)
3704{
3705 while (do_propagate_liveness(state, parent)) {
3706 /* Something changed, so we need to feed those changes onward */
3707 state = parent;
3708 parent = state->parent;
3709 }
3710}
3711
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003712static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003713{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003714 struct bpf_verifier_state_list *new_sl;
3715 struct bpf_verifier_state_list *sl;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003716 struct bpf_verifier_state *cur = env->cur_state;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07003717 int i, err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003718
3719 sl = env->explored_states[insn_idx];
3720 if (!sl)
3721 /* this 'insn_idx' instruction wasn't marked, so we will not
3722 * be doing state search here
3723 */
3724 return 0;
3725
3726 while (sl != STATE_LIST_MARK) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003727 if (states_equal(env, &sl->state, cur)) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003728 /* reached equivalent register/stack state,
Edward Creedc503a82017-08-15 20:34:35 +01003729 * prune the search.
3730 * Registers read by the continuation are read by us.
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003731 * If we have any write marks in env->cur_state, they
3732 * will prevent corresponding reads in the continuation
3733 * from reaching our parent (an explored_state). Our
3734 * own state will get the read marks recorded, but
3735 * they'll be immediately forgotten as we're pruning
3736 * this state and will pop a new one.
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003737 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003738 propagate_liveness(&sl->state, cur);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003739 return 1;
Edward Creedc503a82017-08-15 20:34:35 +01003740 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003741 sl = sl->next;
3742 }
3743
3744 /* there were no equivalent states, remember current one.
3745 * technically the current state is not proven to be safe yet,
3746 * but it will either reach bpf_exit (which means it's safe) or
3747 * it will be rejected. Since there are no loops, we won't be
3748 * seeing this 'insn_idx' instruction again on the way to bpf_exit
3749 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003750 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003751 if (!new_sl)
3752 return -ENOMEM;
3753
3754 /* add new state to the head of linked list */
Alexei Starovoitov1969db42017-11-01 00:08:04 -07003755 err = copy_verifier_state(&new_sl->state, cur);
3756 if (err) {
3757 free_verifier_state(&new_sl->state, false);
3758 kfree(new_sl);
3759 return err;
3760 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003761 new_sl->next = env->explored_states[insn_idx];
3762 env->explored_states[insn_idx] = new_sl;
Edward Creedc503a82017-08-15 20:34:35 +01003763 /* connect new state to parentage chain */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003764 cur->parent = &new_sl->state;
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003765 /* clear write marks in current state: the writes we did are not writes
3766 * our child did, so they don't screen off its reads from us.
3767 * (There are no read marks in current state, because reads always mark
3768 * their parent and current state never has children yet. Only
3769 * explored_states can get read marks.)
3770 */
Edward Creedc503a82017-08-15 20:34:35 +01003771 for (i = 0; i < BPF_REG_FP; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003772 cur->regs[i].live = REG_LIVE_NONE;
3773 for (i = 0; i < cur->allocated_stack / BPF_REG_SIZE; i++)
3774 if (cur->stack[i].slot_type[0] == STACK_SPILL)
3775 cur->stack[i].spilled_ptr.live = REG_LIVE_NONE;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003776 return 0;
3777}
3778
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003779static int ext_analyzer_insn_hook(struct bpf_verifier_env *env,
3780 int insn_idx, int prev_insn_idx)
3781{
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07003782 if (env->dev_ops && env->dev_ops->insn_hook)
3783 return env->dev_ops->insn_hook(env, insn_idx, prev_insn_idx);
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003784
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07003785 return 0;
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003786}
3787
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003788static int do_check(struct bpf_verifier_env *env)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003789{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003790 struct bpf_verifier_state *state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003791 struct bpf_insn *insns = env->prog->insnsi;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003792 struct bpf_reg_state *regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003793 int insn_cnt = env->prog->len;
3794 int insn_idx, prev_insn_idx = 0;
3795 int insn_processed = 0;
3796 bool do_print_state = false;
3797
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003798 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
3799 if (!state)
3800 return -ENOMEM;
3801 env->cur_state = state;
3802 init_reg_state(env, state->regs);
Edward Creedc503a82017-08-15 20:34:35 +01003803 state->parent = NULL;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003804 insn_idx = 0;
3805 for (;;) {
3806 struct bpf_insn *insn;
3807 u8 class;
3808 int err;
3809
3810 if (insn_idx >= insn_cnt) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003811 verbose(env, "invalid insn idx %d insn_cnt %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003812 insn_idx, insn_cnt);
3813 return -EFAULT;
3814 }
3815
3816 insn = &insns[insn_idx];
3817 class = BPF_CLASS(insn->code);
3818
Daniel Borkmann07016152016-04-05 22:33:17 +02003819 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003820 verbose(env,
3821 "BPF program is too large. Processed %d insn\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003822 insn_processed);
3823 return -E2BIG;
3824 }
3825
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003826 err = is_state_visited(env, insn_idx);
3827 if (err < 0)
3828 return err;
3829 if (err == 1) {
3830 /* found equivalent state, can prune the search */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003831 if (env->log.level) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003832 if (do_print_state)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003833 verbose(env, "\nfrom %d to %d: safe\n",
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003834 prev_insn_idx, insn_idx);
3835 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003836 verbose(env, "%d: safe\n", insn_idx);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003837 }
3838 goto process_bpf_exit;
3839 }
3840
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02003841 if (need_resched())
3842 cond_resched();
3843
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003844 if (env->log.level > 1 || (env->log.level && do_print_state)) {
3845 if (env->log.level > 1)
3846 verbose(env, "%d:", insn_idx);
David S. Millerc5fc9692017-05-10 11:25:17 -07003847 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003848 verbose(env, "\nfrom %d to %d:",
David S. Millerc5fc9692017-05-10 11:25:17 -07003849 prev_insn_idx, insn_idx);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003850 print_verifier_state(env, state);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003851 do_print_state = false;
3852 }
3853
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003854 if (env->log.level) {
3855 verbose(env, "%d: ", insn_idx);
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -07003856 print_bpf_insn(verbose, env, insn,
3857 env->allow_ptr_leaks);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003858 }
3859
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003860 err = ext_analyzer_insn_hook(env, insn_idx, prev_insn_idx);
3861 if (err)
3862 return err;
3863
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003864 regs = cur_regs(env);
Alexei Starovoitovc1311872017-11-22 16:42:05 -08003865 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003866 if (class == BPF_ALU || class == BPF_ALU64) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003867 err = check_alu_op(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003868 if (err)
3869 return err;
3870
3871 } else if (class == BPF_LDX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003872 enum bpf_reg_type *prev_src_type, src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003873
3874 /* check for reserved fields is already done */
3875
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003876 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003877 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003878 if (err)
3879 return err;
3880
Edward Creedc503a82017-08-15 20:34:35 +01003881 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003882 if (err)
3883 return err;
3884
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07003885 src_reg_type = regs[insn->src_reg].type;
3886
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003887 /* check that memory (src_reg + off) is readable,
3888 * the state of dst_reg will be updated by this func
3889 */
Yonghong Song31fd8582017-06-13 15:52:13 -07003890 err = check_mem_access(env, insn_idx, insn->src_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003891 BPF_SIZE(insn->code), BPF_READ,
3892 insn->dst_reg);
3893 if (err)
3894 return err;
3895
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003896 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
3897
3898 if (*prev_src_type == NOT_INIT) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003899 /* saw a valid insn
3900 * dst_reg = *(u32 *)(src_reg + off)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003901 * save type to validate intersecting paths
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003902 */
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003903 *prev_src_type = src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003904
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003905 } else if (src_reg_type != *prev_src_type &&
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003906 (src_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003907 *prev_src_type == PTR_TO_CTX)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003908 /* ABuser program is trying to use the same insn
3909 * dst_reg = *(u32*) (src_reg + off)
3910 * with different pointer types:
3911 * src_reg == ctx in one branch and
3912 * src_reg == stack|map in some other branch.
3913 * Reject it.
3914 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003915 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003916 return -EINVAL;
3917 }
3918
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003919 } else if (class == BPF_STX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003920 enum bpf_reg_type *prev_dst_type, dst_reg_type;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003921
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003922 if (BPF_MODE(insn->code) == BPF_XADD) {
Yonghong Song31fd8582017-06-13 15:52:13 -07003923 err = check_xadd(env, insn_idx, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003924 if (err)
3925 return err;
3926 insn_idx++;
3927 continue;
3928 }
3929
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003930 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003931 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003932 if (err)
3933 return err;
3934 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003935 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003936 if (err)
3937 return err;
3938
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003939 dst_reg_type = regs[insn->dst_reg].type;
3940
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003941 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07003942 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003943 BPF_SIZE(insn->code), BPF_WRITE,
3944 insn->src_reg);
3945 if (err)
3946 return err;
3947
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003948 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
3949
3950 if (*prev_dst_type == NOT_INIT) {
3951 *prev_dst_type = dst_reg_type;
3952 } else if (dst_reg_type != *prev_dst_type &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003953 (dst_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003954 *prev_dst_type == PTR_TO_CTX)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003955 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003956 return -EINVAL;
3957 }
3958
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003959 } else if (class == BPF_ST) {
3960 if (BPF_MODE(insn->code) != BPF_MEM ||
3961 insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003962 verbose(env, "BPF_ST uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003963 return -EINVAL;
3964 }
3965 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003966 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003967 if (err)
3968 return err;
3969
3970 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07003971 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003972 BPF_SIZE(insn->code), BPF_WRITE,
3973 -1);
3974 if (err)
3975 return err;
3976
3977 } else if (class == BPF_JMP) {
3978 u8 opcode = BPF_OP(insn->code);
3979
3980 if (opcode == BPF_CALL) {
3981 if (BPF_SRC(insn->code) != BPF_K ||
3982 insn->off != 0 ||
3983 insn->src_reg != BPF_REG_0 ||
3984 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003985 verbose(env, "BPF_CALL uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003986 return -EINVAL;
3987 }
3988
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07003989 err = check_call(env, insn->imm, insn_idx);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003990 if (err)
3991 return err;
3992
3993 } else if (opcode == BPF_JA) {
3994 if (BPF_SRC(insn->code) != BPF_K ||
3995 insn->imm != 0 ||
3996 insn->src_reg != BPF_REG_0 ||
3997 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003998 verbose(env, "BPF_JA uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003999 return -EINVAL;
4000 }
4001
4002 insn_idx += insn->off + 1;
4003 continue;
4004
4005 } else if (opcode == BPF_EXIT) {
4006 if (BPF_SRC(insn->code) != BPF_K ||
4007 insn->imm != 0 ||
4008 insn->src_reg != BPF_REG_0 ||
4009 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004010 verbose(env, "BPF_EXIT uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004011 return -EINVAL;
4012 }
4013
4014 /* eBPF calling convetion is such that R0 is used
4015 * to return the value from eBPF program.
4016 * Make sure that it's readable at this time
4017 * of bpf_exit, which means that program wrote
4018 * something into it earlier
4019 */
Edward Creedc503a82017-08-15 20:34:35 +01004020 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004021 if (err)
4022 return err;
4023
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004024 if (is_pointer_value(env, BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004025 verbose(env, "R0 leaks addr as return value\n");
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004026 return -EACCES;
4027 }
4028
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004029 err = check_return_code(env);
4030 if (err)
4031 return err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004032process_bpf_exit:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004033 err = pop_stack(env, &prev_insn_idx, &insn_idx);
4034 if (err < 0) {
4035 if (err != -ENOENT)
4036 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004037 break;
4038 } else {
4039 do_print_state = true;
4040 continue;
4041 }
4042 } else {
4043 err = check_cond_jmp_op(env, insn, &insn_idx);
4044 if (err)
4045 return err;
4046 }
4047 } else if (class == BPF_LD) {
4048 u8 mode = BPF_MODE(insn->code);
4049
4050 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004051 err = check_ld_abs(env, insn);
4052 if (err)
4053 return err;
4054
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004055 } else if (mode == BPF_IMM) {
4056 err = check_ld_imm(env, insn);
4057 if (err)
4058 return err;
4059
4060 insn_idx++;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004061 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004062 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004063 verbose(env, "invalid BPF_LD mode\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004064 return -EINVAL;
4065 }
4066 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004067 verbose(env, "unknown insn class %d\n", class);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004068 return -EINVAL;
4069 }
4070
4071 insn_idx++;
4072 }
4073
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004074 verbose(env, "processed %d insns, stack depth %d\n", insn_processed,
4075 env->prog->aux->stack_depth);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004076 return 0;
4077}
4078
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004079static int check_map_prealloc(struct bpf_map *map)
4080{
4081 return (map->map_type != BPF_MAP_TYPE_HASH &&
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07004082 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
4083 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004084 !(map->map_flags & BPF_F_NO_PREALLOC);
4085}
4086
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004087static int check_map_prog_compatibility(struct bpf_verifier_env *env,
4088 struct bpf_map *map,
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004089 struct bpf_prog *prog)
4090
4091{
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004092 /* Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use
4093 * preallocated hash maps, since doing memory allocation
4094 * in overflow_handler can crash depending on where nmi got
4095 * triggered.
4096 */
4097 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
4098 if (!check_map_prealloc(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004099 verbose(env, "perf_event programs can only use preallocated hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004100 return -EINVAL;
4101 }
4102 if (map->inner_map_meta &&
4103 !check_map_prealloc(map->inner_map_meta)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004104 verbose(env, "perf_event programs can only use preallocated inner hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004105 return -EINVAL;
4106 }
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004107 }
4108 return 0;
4109}
4110
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004111/* look for pseudo eBPF instructions that access map FDs and
4112 * replace them with actual map pointers
4113 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004114static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004115{
4116 struct bpf_insn *insn = env->prog->insnsi;
4117 int insn_cnt = env->prog->len;
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004118 int i, j, err;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004119
Daniel Borkmannf1f77142017-01-13 23:38:15 +01004120 err = bpf_prog_calc_tag(env->prog);
Daniel Borkmannaafe6ae2016-12-18 01:52:57 +01004121 if (err)
4122 return err;
4123
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004124 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004125 if (BPF_CLASS(insn->code) == BPF_LDX &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004126 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004127 verbose(env, "BPF_LDX uses reserved fields\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004128 return -EINVAL;
4129 }
4130
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004131 if (BPF_CLASS(insn->code) == BPF_STX &&
4132 ((BPF_MODE(insn->code) != BPF_MEM &&
4133 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004134 verbose(env, "BPF_STX uses reserved fields\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004135 return -EINVAL;
4136 }
4137
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004138 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
4139 struct bpf_map *map;
4140 struct fd f;
4141
4142 if (i == insn_cnt - 1 || insn[1].code != 0 ||
4143 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
4144 insn[1].off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004145 verbose(env, "invalid bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004146 return -EINVAL;
4147 }
4148
4149 if (insn->src_reg == 0)
4150 /* valid generic load 64-bit imm */
4151 goto next_insn;
4152
4153 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004154 verbose(env,
4155 "unrecognized bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004156 return -EINVAL;
4157 }
4158
4159 f = fdget(insn->imm);
Daniel Borkmannc2101292015-10-29 14:58:07 +01004160 map = __bpf_map_get(f);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004161 if (IS_ERR(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004162 verbose(env, "fd %d is not pointing to valid bpf_map\n",
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004163 insn->imm);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004164 return PTR_ERR(map);
4165 }
4166
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004167 err = check_map_prog_compatibility(env, map, env->prog);
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004168 if (err) {
4169 fdput(f);
4170 return err;
4171 }
4172
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004173 /* store map pointer inside BPF_LD_IMM64 instruction */
4174 insn[0].imm = (u32) (unsigned long) map;
4175 insn[1].imm = ((u64) (unsigned long) map) >> 32;
4176
4177 /* check whether we recorded this map already */
4178 for (j = 0; j < env->used_map_cnt; j++)
4179 if (env->used_maps[j] == map) {
4180 fdput(f);
4181 goto next_insn;
4182 }
4183
4184 if (env->used_map_cnt >= MAX_USED_MAPS) {
4185 fdput(f);
4186 return -E2BIG;
4187 }
4188
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004189 /* hold the map. If the program is rejected by verifier,
4190 * the map will be released by release_maps() or it
4191 * will be used by the valid program until it's unloaded
4192 * and all maps are released in free_bpf_prog_info()
4193 */
Alexei Starovoitov92117d82016-04-27 18:56:20 -07004194 map = bpf_map_inc(map, false);
4195 if (IS_ERR(map)) {
4196 fdput(f);
4197 return PTR_ERR(map);
4198 }
4199 env->used_maps[env->used_map_cnt++] = map;
4200
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004201 fdput(f);
4202next_insn:
4203 insn++;
4204 i++;
4205 }
4206 }
4207
4208 /* now all pseudo BPF_LD_IMM64 instructions load valid
4209 * 'struct bpf_map *' into a register instead of user map_fd.
4210 * These pointers will be used later by verifier to validate map access.
4211 */
4212 return 0;
4213}
4214
4215/* drop refcnt of maps used by the rejected program */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004216static void release_maps(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004217{
4218 int i;
4219
4220 for (i = 0; i < env->used_map_cnt; i++)
4221 bpf_map_put(env->used_maps[i]);
4222}
4223
4224/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004225static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004226{
4227 struct bpf_insn *insn = env->prog->insnsi;
4228 int insn_cnt = env->prog->len;
4229 int i;
4230
4231 for (i = 0; i < insn_cnt; i++, insn++)
4232 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
4233 insn->src_reg = 0;
4234}
4235
Alexei Starovoitov80419022017-03-15 18:26:41 -07004236/* single env->prog->insni[off] instruction was replaced with the range
4237 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
4238 * [0, off) and [off, end) to new locations, so the patched range stays zero
4239 */
4240static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
4241 u32 off, u32 cnt)
4242{
4243 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004244 int i;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004245
4246 if (cnt == 1)
4247 return 0;
4248 new_data = vzalloc(sizeof(struct bpf_insn_aux_data) * prog_len);
4249 if (!new_data)
4250 return -ENOMEM;
4251 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
4252 memcpy(new_data + off + cnt - 1, old_data + off,
4253 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004254 for (i = off; i < off + cnt - 1; i++)
4255 new_data[i].seen = true;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004256 env->insn_aux_data = new_data;
4257 vfree(old_data);
4258 return 0;
4259}
4260
4261static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
4262 const struct bpf_insn *patch, u32 len)
4263{
4264 struct bpf_prog *new_prog;
4265
4266 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
4267 if (!new_prog)
4268 return NULL;
4269 if (adjust_insn_aux_data(env, new_prog->len, off, len))
4270 return NULL;
4271 return new_prog;
4272}
4273
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004274/* The verifier does more data flow analysis than llvm and will not explore
4275 * branches that are dead at run time. Malicious programs can have dead code
4276 * too. Therefore replace all dead at-run-time code with nops.
4277 */
4278static void sanitize_dead_code(struct bpf_verifier_env *env)
4279{
4280 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
4281 struct bpf_insn nop = BPF_MOV64_REG(BPF_REG_0, BPF_REG_0);
4282 struct bpf_insn *insn = env->prog->insnsi;
4283 const int insn_cnt = env->prog->len;
4284 int i;
4285
4286 for (i = 0; i < insn_cnt; i++) {
4287 if (aux_data[i].seen)
4288 continue;
4289 memcpy(insn + i, &nop, sizeof(nop));
4290 }
4291}
4292
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004293/* convert load instructions that access fields of 'struct __sk_buff'
4294 * into sequence of instructions that access fields of 'struct sk_buff'
4295 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004296static int convert_ctx_accesses(struct bpf_verifier_env *env)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004297{
Jakub Kicinski00176a32017-10-16 16:40:54 -07004298 const struct bpf_verifier_ops *ops = env->ops;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004299 int i, cnt, size, ctx_field_size, delta = 0;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004300 const int insn_cnt = env->prog->len;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004301 struct bpf_insn insn_buf[16], *insn;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004302 struct bpf_prog *new_prog;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004303 enum bpf_access_type type;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004304 bool is_narrower_load;
4305 u32 target_size;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004306
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004307 if (ops->gen_prologue) {
4308 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
4309 env->prog);
4310 if (cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004311 verbose(env, "bpf verifier is misconfigured\n");
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004312 return -EINVAL;
4313 } else if (cnt) {
Alexei Starovoitov80419022017-03-15 18:26:41 -07004314 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004315 if (!new_prog)
4316 return -ENOMEM;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004317
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004318 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004319 delta += cnt - 1;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004320 }
4321 }
4322
4323 if (!ops->convert_ctx_access)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004324 return 0;
4325
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004326 insn = env->prog->insnsi + delta;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004327
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004328 for (i = 0; i < insn_cnt; i++, insn++) {
Daniel Borkmann62c79892017-01-12 11:51:33 +01004329 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
4330 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
4331 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07004332 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004333 type = BPF_READ;
Daniel Borkmann62c79892017-01-12 11:51:33 +01004334 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
4335 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
4336 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07004337 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004338 type = BPF_WRITE;
4339 else
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004340 continue;
4341
Alexei Starovoitov80419022017-03-15 18:26:41 -07004342 if (env->insn_aux_data[i + delta].ptr_type != PTR_TO_CTX)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004343 continue;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004344
Yonghong Song31fd8582017-06-13 15:52:13 -07004345 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004346 size = BPF_LDST_BYTES(insn);
Yonghong Song31fd8582017-06-13 15:52:13 -07004347
4348 /* If the read access is a narrower load of the field,
4349 * convert to a 4/8-byte load, to minimum program type specific
4350 * convert_ctx_access changes. If conversion is successful,
4351 * we will apply proper mask to the result.
4352 */
Daniel Borkmannf96da092017-07-02 02:13:27 +02004353 is_narrower_load = size < ctx_field_size;
Yonghong Song31fd8582017-06-13 15:52:13 -07004354 if (is_narrower_load) {
Daniel Borkmannf96da092017-07-02 02:13:27 +02004355 u32 off = insn->off;
4356 u8 size_code;
Yonghong Song31fd8582017-06-13 15:52:13 -07004357
Daniel Borkmannf96da092017-07-02 02:13:27 +02004358 if (type == BPF_WRITE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004359 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
Daniel Borkmannf96da092017-07-02 02:13:27 +02004360 return -EINVAL;
4361 }
4362
4363 size_code = BPF_H;
Yonghong Song31fd8582017-06-13 15:52:13 -07004364 if (ctx_field_size == 4)
4365 size_code = BPF_W;
4366 else if (ctx_field_size == 8)
4367 size_code = BPF_DW;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004368
Yonghong Song31fd8582017-06-13 15:52:13 -07004369 insn->off = off & ~(ctx_field_size - 1);
4370 insn->code = BPF_LDX | BPF_MEM | size_code;
4371 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02004372
4373 target_size = 0;
4374 cnt = ops->convert_ctx_access(type, insn, insn_buf, env->prog,
4375 &target_size);
4376 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
4377 (ctx_field_size && !target_size)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004378 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004379 return -EINVAL;
4380 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02004381
4382 if (is_narrower_load && size < target_size) {
Yonghong Song31fd8582017-06-13 15:52:13 -07004383 if (ctx_field_size <= 4)
4384 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02004385 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07004386 else
4387 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02004388 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07004389 }
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004390
Alexei Starovoitov80419022017-03-15 18:26:41 -07004391 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004392 if (!new_prog)
4393 return -ENOMEM;
4394
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004395 delta += cnt - 1;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004396
4397 /* keep walking new program and skip insns we just inserted */
4398 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004399 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004400 }
4401
4402 return 0;
4403}
4404
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004405/* fixup insn->imm field of bpf_call instructions
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004406 * and inline eligible helpers as explicit sequence of BPF instructions
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004407 *
4408 * this function is called after eBPF program passed verification
4409 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004410static int fixup_bpf_calls(struct bpf_verifier_env *env)
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004411{
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004412 struct bpf_prog *prog = env->prog;
4413 struct bpf_insn *insn = prog->insnsi;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004414 const struct bpf_func_proto *fn;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004415 const int insn_cnt = prog->len;
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004416 struct bpf_insn insn_buf[16];
4417 struct bpf_prog *new_prog;
4418 struct bpf_map *map_ptr;
4419 int i, cnt, delta = 0;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004420
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004421 for (i = 0; i < insn_cnt; i++, insn++) {
4422 if (insn->code != (BPF_JMP | BPF_CALL))
4423 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004424
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004425 if (insn->imm == BPF_FUNC_get_route_realm)
4426 prog->dst_needed = 1;
4427 if (insn->imm == BPF_FUNC_get_prandom_u32)
4428 bpf_user_rnd_init_once();
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004429 if (insn->imm == BPF_FUNC_tail_call) {
David S. Miller7b9f6da2017-04-20 10:35:33 -04004430 /* If we tail call into other programs, we
4431 * cannot make any assumptions since they can
4432 * be replaced dynamically during runtime in
4433 * the program array.
4434 */
4435 prog->cb_access = 1;
Alexei Starovoitov80a58d02017-05-30 13:31:30 -07004436 env->prog->aux->stack_depth = MAX_BPF_STACK;
David S. Miller7b9f6da2017-04-20 10:35:33 -04004437
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004438 /* mark bpf_tail_call as different opcode to avoid
4439 * conditional branch in the interpeter for every normal
4440 * call and to prevent accidental JITing by JIT compiler
4441 * that doesn't support bpf_tail_call yet
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004442 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004443 insn->imm = 0;
Alexei Starovoitov71189fa2017-05-30 13:31:27 -07004444 insn->code = BPF_JMP | BPF_TAIL_CALL;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004445 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004446 }
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004447
Daniel Borkmann89c63072017-08-19 03:12:45 +02004448 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
4449 * handlers are currently limited to 64 bit only.
4450 */
4451 if (ebpf_jit_enabled() && BITS_PER_LONG == 64 &&
4452 insn->imm == BPF_FUNC_map_lookup_elem) {
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004453 map_ptr = env->insn_aux_data[i + delta].map_ptr;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07004454 if (map_ptr == BPF_MAP_PTR_POISON ||
4455 !map_ptr->ops->map_gen_lookup)
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004456 goto patch_call_imm;
4457
4458 cnt = map_ptr->ops->map_gen_lookup(map_ptr, insn_buf);
4459 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004460 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004461 return -EINVAL;
4462 }
4463
4464 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf,
4465 cnt);
4466 if (!new_prog)
4467 return -ENOMEM;
4468
4469 delta += cnt - 1;
4470
4471 /* keep walking new program and skip insns we just inserted */
4472 env->prog = prog = new_prog;
4473 insn = new_prog->insnsi + i + delta;
4474 continue;
4475 }
4476
Daniel Borkmann109980b2017-09-08 00:14:51 +02004477 if (insn->imm == BPF_FUNC_redirect_map) {
Daniel Borkmann7c300132017-09-20 00:44:21 +02004478 /* Note, we cannot use prog directly as imm as subsequent
4479 * rewrites would still change the prog pointer. The only
4480 * stable address we can use is aux, which also works with
4481 * prog clones during blinding.
4482 */
4483 u64 addr = (unsigned long)prog->aux;
Daniel Borkmann109980b2017-09-08 00:14:51 +02004484 struct bpf_insn r4_ld[] = {
4485 BPF_LD_IMM64(BPF_REG_4, addr),
4486 *insn,
4487 };
4488 cnt = ARRAY_SIZE(r4_ld);
4489
4490 new_prog = bpf_patch_insn_data(env, i + delta, r4_ld, cnt);
4491 if (!new_prog)
4492 return -ENOMEM;
4493
4494 delta += cnt - 1;
4495 env->prog = prog = new_prog;
4496 insn = new_prog->insnsi + i + delta;
4497 }
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004498patch_call_imm:
Jakub Kicinski00176a32017-10-16 16:40:54 -07004499 fn = env->ops->get_func_proto(insn->imm);
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004500 /* all functions that have prototype and verifier allowed
4501 * programs to call them, must be real in-kernel functions
4502 */
4503 if (!fn->func) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004504 verbose(env,
4505 "kernel subsystem misconfigured func %s#%d\n",
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004506 func_id_name(insn->imm), insn->imm);
4507 return -EFAULT;
4508 }
4509 insn->imm = fn->func - __bpf_call_base;
4510 }
4511
4512 return 0;
4513}
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004514
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004515static void free_states(struct bpf_verifier_env *env)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004516{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004517 struct bpf_verifier_state_list *sl, *sln;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004518 int i;
4519
4520 if (!env->explored_states)
4521 return;
4522
4523 for (i = 0; i < env->prog->len; i++) {
4524 sl = env->explored_states[i];
4525
4526 if (sl)
4527 while (sl != STATE_LIST_MARK) {
4528 sln = sl->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07004529 free_verifier_state(&sl->state, false);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004530 kfree(sl);
4531 sl = sln;
4532 }
4533 }
4534
4535 kfree(env->explored_states);
4536}
4537
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004538int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004539{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004540 struct bpf_verifier_env *env;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004541 struct bpf_verifer_log *log;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004542 int ret = -EINVAL;
4543
Arnd Bergmanneba0c922017-11-02 12:05:52 +01004544 /* no program is valid */
4545 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
4546 return -EINVAL;
4547
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004548 /* 'struct bpf_verifier_env' can be global, but since it's not small,
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004549 * allocate/free it every time bpf_check() is called
4550 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004551 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004552 if (!env)
4553 return -ENOMEM;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004554 log = &env->log;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004555
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004556 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
4557 (*prog)->len);
4558 ret = -ENOMEM;
4559 if (!env->insn_aux_data)
4560 goto err_free_env;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004561 env->prog = *prog;
Jakub Kicinski00176a32017-10-16 16:40:54 -07004562 env->ops = bpf_verifier_ops[env->prog->type];
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004563
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004564 /* grab the mutex to protect few globals used by verifier */
4565 mutex_lock(&bpf_verifier_lock);
4566
4567 if (attr->log_level || attr->log_buf || attr->log_size) {
4568 /* user requested verbose verifier output
4569 * and supplied buffer to store the verification trace
4570 */
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07004571 log->level = attr->log_level;
4572 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
4573 log->len_total = attr->log_size;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004574
4575 ret = -EINVAL;
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07004576 /* log attributes have to be sane */
4577 if (log->len_total < 128 || log->len_total > UINT_MAX >> 8 ||
4578 !log->level || !log->ubuf)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004579 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004580 }
Daniel Borkmann1ad2f582017-05-25 01:05:05 +02004581
4582 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
4583 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
David S. Millere07b98d2017-05-10 11:38:07 -07004584 env->strict_alignment = true;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004585
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07004586 if (env->prog->aux->offload) {
4587 ret = bpf_prog_offload_verifier_prep(env);
4588 if (ret)
4589 goto err_unlock;
4590 }
4591
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004592 ret = replace_map_fd_with_map_ptr(env);
4593 if (ret < 0)
4594 goto skip_full_check;
4595
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004596 env->explored_states = kcalloc(env->prog->len,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004597 sizeof(struct bpf_verifier_state_list *),
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004598 GFP_USER);
4599 ret = -ENOMEM;
4600 if (!env->explored_states)
4601 goto skip_full_check;
4602
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004603 ret = check_cfg(env);
4604 if (ret < 0)
4605 goto skip_full_check;
4606
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004607 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
4608
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004609 ret = do_check(env);
Craig Gallek8c01c4f2017-11-02 11:18:01 -04004610 if (env->cur_state) {
4611 free_verifier_state(env->cur_state, true);
4612 env->cur_state = NULL;
4613 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004614
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004615skip_full_check:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004616 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004617 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004618
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004619 if (ret == 0)
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004620 sanitize_dead_code(env);
4621
4622 if (ret == 0)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004623 /* program is valid, convert *(u32*)(ctx + off) accesses */
4624 ret = convert_ctx_accesses(env);
4625
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004626 if (ret == 0)
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004627 ret = fixup_bpf_calls(env);
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004628
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004629 if (log->level && bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004630 ret = -ENOSPC;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004631 if (log->level && !log->ubuf) {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004632 ret = -EFAULT;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004633 goto err_release_maps;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004634 }
4635
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004636 if (ret == 0 && env->used_map_cnt) {
4637 /* if program passed verifier, update used_maps in bpf_prog_info */
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004638 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
4639 sizeof(env->used_maps[0]),
4640 GFP_KERNEL);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004641
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004642 if (!env->prog->aux->used_maps) {
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004643 ret = -ENOMEM;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004644 goto err_release_maps;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004645 }
4646
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004647 memcpy(env->prog->aux->used_maps, env->used_maps,
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004648 sizeof(env->used_maps[0]) * env->used_map_cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004649 env->prog->aux->used_map_cnt = env->used_map_cnt;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004650
4651 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
4652 * bpf_ld_imm64 instructions
4653 */
4654 convert_pseudo_ld_imm64(env);
4655 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004656
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004657err_release_maps:
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004658 if (!env->prog->aux->used_maps)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004659 /* if we didn't copy map pointers into bpf_prog_info, release
4660 * them now. Otherwise free_bpf_prog_info() will release them.
4661 */
4662 release_maps(env);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004663 *prog = env->prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004664err_unlock:
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004665 mutex_unlock(&bpf_verifier_lock);
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004666 vfree(env->insn_aux_data);
4667err_free_env:
4668 kfree(env);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004669 return ret;
4670}