blob: 77e4b5223867a2f5ca6f49454ab16cb7e3f22df2 [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002 * Copyright (c) 2016 Facebook
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +010017#include <linux/bpf_verifier.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070018#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
Thomas Grafebb676d2016-10-27 11:23:51 +020022#include <linux/stringify.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070023
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -070024#include "disasm.h"
25
Jakub Kicinski00176a32017-10-16 16:40:54 -070026static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
27#define BPF_PROG_TYPE(_id, _name) \
28 [_id] = & _name ## _verifier_ops,
29#define BPF_MAP_TYPE(_id, _ops)
30#include <linux/bpf_types.h>
31#undef BPF_PROG_TYPE
32#undef BPF_MAP_TYPE
33};
34
Alexei Starovoitov51580e72014-09-26 00:17:02 -070035/* bpf_check() is a static code analyzer that walks eBPF program
36 * instruction by instruction and updates register/stack state.
37 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
38 *
39 * The first pass is depth-first-search to check that the program is a DAG.
40 * It rejects the following programs:
41 * - larger than BPF_MAXINSNS insns
42 * - if loop is present (detected via back-edge)
43 * - unreachable insns exist (shouldn't be a forest. program = one function)
44 * - out of bounds or malformed jumps
45 * The second pass is all possible path descent from the 1st insn.
46 * Since it's analyzing all pathes through the program, the length of the
Gary Lineba38a92017-03-01 16:25:51 +080047 * analysis is limited to 64k insn, which may be hit even if total number of
Alexei Starovoitov51580e72014-09-26 00:17:02 -070048 * insn is less then 4K, but there are too many branches that change stack/regs.
49 * Number of 'branches to be analyzed' is limited to 1k
50 *
51 * On entry to each instruction, each register has a type, and the instruction
52 * changes the types of the registers depending on instruction semantics.
53 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
54 * copied to R1.
55 *
56 * All registers are 64-bit.
57 * R0 - return register
58 * R1-R5 argument passing registers
59 * R6-R9 callee saved registers
60 * R10 - frame pointer read-only
61 *
62 * At the start of BPF program the register R1 contains a pointer to bpf_context
63 * and has type PTR_TO_CTX.
64 *
65 * Verifier tracks arithmetic operations on pointers in case:
66 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
67 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
68 * 1st insn copies R10 (which has FRAME_PTR) type into R1
69 * and 2nd arithmetic instruction is pattern matched to recognize
70 * that it wants to construct a pointer to some element within stack.
71 * So after 2nd insn, the register R1 has type PTR_TO_STACK
72 * (and -20 constant is saved for further stack bounds checking).
73 * Meaning that this reg is a pointer to stack plus known immediate constant.
74 *
Edward Creef1174f72017-08-07 15:26:19 +010075 * Most of the time the registers have SCALAR_VALUE type, which
Alexei Starovoitov51580e72014-09-26 00:17:02 -070076 * means the register has some value, but it's not a valid pointer.
Edward Creef1174f72017-08-07 15:26:19 +010077 * (like pointer plus pointer becomes SCALAR_VALUE type)
Alexei Starovoitov51580e72014-09-26 00:17:02 -070078 *
79 * When verifier sees load or store instructions the type of base register
Edward Creef1174f72017-08-07 15:26:19 +010080 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK. These are three pointer
Alexei Starovoitov51580e72014-09-26 00:17:02 -070081 * types recognized by check_mem_access() function.
82 *
83 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
84 * and the range of [ptr, ptr + map's value_size) is accessible.
85 *
86 * registers used to pass values to function calls are checked against
87 * function argument constraints.
88 *
89 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
90 * It means that the register type passed to this function must be
91 * PTR_TO_STACK and it will be used inside the function as
92 * 'pointer to map element key'
93 *
94 * For example the argument constraints for bpf_map_lookup_elem():
95 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
96 * .arg1_type = ARG_CONST_MAP_PTR,
97 * .arg2_type = ARG_PTR_TO_MAP_KEY,
98 *
99 * ret_type says that this function returns 'pointer to map elem value or null'
100 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
101 * 2nd argument should be a pointer to stack, which will be used inside
102 * the helper function as a pointer to map element key.
103 *
104 * On the kernel side the helper function looks like:
105 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
106 * {
107 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
108 * void *key = (void *) (unsigned long) r2;
109 * void *value;
110 *
111 * here kernel can access 'key' and 'map' pointers safely, knowing that
112 * [key, key + map->key_size) bytes are valid and were initialized on
113 * the stack of eBPF program.
114 * }
115 *
116 * Corresponding eBPF program may look like:
117 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
118 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
119 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
120 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
121 * here verifier looks at prototype of map_lookup_elem() and sees:
122 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
123 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
124 *
125 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
126 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
127 * and were initialized prior to this call.
128 * If it's ok, then verifier allows this BPF_CALL insn and looks at
129 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
130 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
131 * returns ether pointer to map value or NULL.
132 *
133 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
134 * insn, the register holding that pointer in the true branch changes state to
135 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
136 * branch. See check_cond_jmp_op().
137 *
138 * After the call R0 is set to return type of the function and registers R1-R5
139 * are set to NOT_INIT to indicate that they are no longer readable.
140 */
141
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700142/* verifier_state + insn_idx are pushed to stack when branch is encountered */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100143struct bpf_verifier_stack_elem {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700144 /* verifer state is 'st'
145 * before processing instruction 'insn_idx'
146 * and after processing instruction 'prev_insn_idx'
147 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100148 struct bpf_verifier_state st;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700149 int insn_idx;
150 int prev_insn_idx;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100151 struct bpf_verifier_stack_elem *next;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700152};
153
Edward Cree8e17c1b2017-08-07 15:30:30 +0100154#define BPF_COMPLEXITY_LIMIT_INSNS 131072
Daniel Borkmann07016152016-04-05 22:33:17 +0200155#define BPF_COMPLEXITY_LIMIT_STACK 1024
156
Martin KaFai Laufad73a12017-03-22 10:00:32 -0700157#define BPF_MAP_PTR_POISON ((void *)0xeB9F + POISON_POINTER_DELTA)
158
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200159struct bpf_call_arg_meta {
160 struct bpf_map *map_ptr;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200161 bool raw_mode;
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200162 bool pkt_access;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200163 int regno;
164 int access_size;
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200165};
166
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700167static DEFINE_MUTEX(bpf_verifier_lock);
168
169/* log_level controls verbosity level of eBPF verifier.
170 * verbose() is used to dump the verification trace to the log, so the user
171 * can figure out what's wrong with the program
172 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700173static __printf(2, 3) void verbose(struct bpf_verifier_env *env,
174 const char *fmt, ...)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700175{
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700176 struct bpf_verifer_log *log = &env->log;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700177 unsigned int n;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700178 va_list args;
179
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700180 if (!log->level || !log->ubuf || bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700181 return;
182
183 va_start(args, fmt);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700184 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700185 va_end(args);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700186
187 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
188 "verifier log line truncated - local buffer too short\n");
189
190 n = min(log->len_total - log->len_used - 1, n);
191 log->kbuf[n] = '\0';
192
193 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
194 log->len_used += n;
195 else
196 log->ubuf = NULL;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700197}
198
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200199static bool type_is_pkt_pointer(enum bpf_reg_type type)
200{
201 return type == PTR_TO_PACKET ||
202 type == PTR_TO_PACKET_META;
203}
204
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700205/* string representation of 'enum bpf_reg_type' */
206static const char * const reg_type_str[] = {
207 [NOT_INIT] = "?",
Edward Creef1174f72017-08-07 15:26:19 +0100208 [SCALAR_VALUE] = "inv",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700209 [PTR_TO_CTX] = "ctx",
210 [CONST_PTR_TO_MAP] = "map_ptr",
211 [PTR_TO_MAP_VALUE] = "map_value",
212 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700213 [PTR_TO_STACK] = "fp",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700214 [PTR_TO_PACKET] = "pkt",
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200215 [PTR_TO_PACKET_META] = "pkt_meta",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700216 [PTR_TO_PACKET_END] = "pkt_end",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700217};
218
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700219static void print_verifier_state(struct bpf_verifier_env *env,
220 struct bpf_verifier_state *state)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700221{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100222 struct bpf_reg_state *reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700223 enum bpf_reg_type t;
224 int i;
225
226 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700227 reg = &state->regs[i];
228 t = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700229 if (t == NOT_INIT)
230 continue;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700231 verbose(env, " R%d=%s", i, reg_type_str[t]);
Edward Creef1174f72017-08-07 15:26:19 +0100232 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
233 tnum_is_const(reg->var_off)) {
234 /* reg->off should be 0 for SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700235 verbose(env, "%lld", reg->var_off.value + reg->off);
Edward Creef1174f72017-08-07 15:26:19 +0100236 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700237 verbose(env, "(id=%d", reg->id);
Edward Creef1174f72017-08-07 15:26:19 +0100238 if (t != SCALAR_VALUE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700239 verbose(env, ",off=%d", reg->off);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200240 if (type_is_pkt_pointer(t))
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700241 verbose(env, ",r=%d", reg->range);
Edward Creef1174f72017-08-07 15:26:19 +0100242 else if (t == CONST_PTR_TO_MAP ||
243 t == PTR_TO_MAP_VALUE ||
244 t == PTR_TO_MAP_VALUE_OR_NULL)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700245 verbose(env, ",ks=%d,vs=%d",
Edward Creef1174f72017-08-07 15:26:19 +0100246 reg->map_ptr->key_size,
247 reg->map_ptr->value_size);
Edward Cree7d1238f2017-08-07 15:26:56 +0100248 if (tnum_is_const(reg->var_off)) {
249 /* Typically an immediate SCALAR_VALUE, but
250 * could be a pointer whose offset is too big
251 * for reg->off
252 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700253 verbose(env, ",imm=%llx", reg->var_off.value);
Edward Cree7d1238f2017-08-07 15:26:56 +0100254 } else {
255 if (reg->smin_value != reg->umin_value &&
256 reg->smin_value != S64_MIN)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700257 verbose(env, ",smin_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100258 (long long)reg->smin_value);
259 if (reg->smax_value != reg->umax_value &&
260 reg->smax_value != S64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700261 verbose(env, ",smax_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100262 (long long)reg->smax_value);
263 if (reg->umin_value != 0)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700264 verbose(env, ",umin_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100265 (unsigned long long)reg->umin_value);
266 if (reg->umax_value != U64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700267 verbose(env, ",umax_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100268 (unsigned long long)reg->umax_value);
269 if (!tnum_is_unknown(reg->var_off)) {
270 char tn_buf[48];
Edward Creef1174f72017-08-07 15:26:19 +0100271
Edward Cree7d1238f2017-08-07 15:26:56 +0100272 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700273 verbose(env, ",var_off=%s", tn_buf);
Edward Cree7d1238f2017-08-07 15:26:56 +0100274 }
Edward Creef1174f72017-08-07 15:26:19 +0100275 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700276 verbose(env, ")");
Edward Creef1174f72017-08-07 15:26:19 +0100277 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700278 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700279 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
280 if (state->stack[i].slot_type[0] == STACK_SPILL)
281 verbose(env, " fp%d=%s",
282 -MAX_BPF_STACK + i * BPF_REG_SIZE,
283 reg_type_str[state->stack[i].spilled_ptr.type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700284 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700285 verbose(env, "\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700286}
287
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700288static int copy_stack_state(struct bpf_verifier_state *dst,
289 const struct bpf_verifier_state *src)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700290{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700291 if (!src->stack)
292 return 0;
293 if (WARN_ON_ONCE(dst->allocated_stack < src->allocated_stack)) {
294 /* internal bug, make state invalid to reject the program */
295 memset(dst, 0, sizeof(*dst));
296 return -EFAULT;
297 }
298 memcpy(dst->stack, src->stack,
299 sizeof(*src->stack) * (src->allocated_stack / BPF_REG_SIZE));
300 return 0;
301}
302
303/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
304 * make it consume minimal amount of memory. check_stack_write() access from
305 * the program calls into realloc_verifier_state() to grow the stack size.
306 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
307 * which this function copies over. It points to previous bpf_verifier_state
308 * which is never reallocated
309 */
310static int realloc_verifier_state(struct bpf_verifier_state *state, int size,
311 bool copy_old)
312{
313 u32 old_size = state->allocated_stack;
314 struct bpf_stack_state *new_stack;
315 int slot = size / BPF_REG_SIZE;
316
317 if (size <= old_size || !size) {
318 if (copy_old)
319 return 0;
320 state->allocated_stack = slot * BPF_REG_SIZE;
321 if (!size && old_size) {
322 kfree(state->stack);
323 state->stack = NULL;
324 }
325 return 0;
326 }
327 new_stack = kmalloc_array(slot, sizeof(struct bpf_stack_state),
328 GFP_KERNEL);
329 if (!new_stack)
330 return -ENOMEM;
331 if (copy_old) {
332 if (state->stack)
333 memcpy(new_stack, state->stack,
334 sizeof(*new_stack) * (old_size / BPF_REG_SIZE));
335 memset(new_stack + old_size / BPF_REG_SIZE, 0,
336 sizeof(*new_stack) * (size - old_size) / BPF_REG_SIZE);
337 }
338 state->allocated_stack = slot * BPF_REG_SIZE;
339 kfree(state->stack);
340 state->stack = new_stack;
341 return 0;
342}
343
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700344static void free_verifier_state(struct bpf_verifier_state *state,
345 bool free_self)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700346{
347 kfree(state->stack);
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700348 if (free_self)
349 kfree(state);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700350}
351
352/* copy verifier state from src to dst growing dst stack space
353 * when necessary to accommodate larger src stack
354 */
355static int copy_verifier_state(struct bpf_verifier_state *dst,
356 const struct bpf_verifier_state *src)
357{
358 int err;
359
360 err = realloc_verifier_state(dst, src->allocated_stack, false);
361 if (err)
362 return err;
363 memcpy(dst, src, offsetof(struct bpf_verifier_state, allocated_stack));
364 return copy_stack_state(dst, src);
365}
366
367static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
368 int *insn_idx)
369{
370 struct bpf_verifier_state *cur = env->cur_state;
371 struct bpf_verifier_stack_elem *elem, *head = env->head;
372 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700373
374 if (env->head == NULL)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700375 return -ENOENT;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700376
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700377 if (cur) {
378 err = copy_verifier_state(cur, &head->st);
379 if (err)
380 return err;
381 }
382 if (insn_idx)
383 *insn_idx = head->insn_idx;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700384 if (prev_insn_idx)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700385 *prev_insn_idx = head->prev_insn_idx;
386 elem = head->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700387 free_verifier_state(&head->st, false);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700388 kfree(head);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700389 env->head = elem;
390 env->stack_size--;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700391 return 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700392}
393
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100394static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
395 int insn_idx, int prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700396{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700397 struct bpf_verifier_state *cur = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100398 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700399 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700400
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700401 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700402 if (!elem)
403 goto err;
404
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700405 elem->insn_idx = insn_idx;
406 elem->prev_insn_idx = prev_insn_idx;
407 elem->next = env->head;
408 env->head = elem;
409 env->stack_size++;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700410 err = copy_verifier_state(&elem->st, cur);
411 if (err)
412 goto err;
Daniel Borkmann07016152016-04-05 22:33:17 +0200413 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700414 verbose(env, "BPF program is too complex\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700415 goto err;
416 }
417 return &elem->st;
418err:
419 /* pop all elements and return */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700420 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700421 return NULL;
422}
423
424#define CALLER_SAVED_REGS 6
425static const int caller_saved[CALLER_SAVED_REGS] = {
426 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
427};
428
Edward Creef1174f72017-08-07 15:26:19 +0100429static void __mark_reg_not_init(struct bpf_reg_state *reg);
430
Edward Creeb03c9f92017-08-07 15:26:36 +0100431/* Mark the unknown part of a register (variable offset or scalar value) as
432 * known to have the value @imm.
433 */
434static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
435{
436 reg->id = 0;
437 reg->var_off = tnum_const(imm);
438 reg->smin_value = (s64)imm;
439 reg->smax_value = (s64)imm;
440 reg->umin_value = imm;
441 reg->umax_value = imm;
442}
443
Edward Creef1174f72017-08-07 15:26:19 +0100444/* Mark the 'variable offset' part of a register as zero. This should be
445 * used only on registers holding a pointer type.
446 */
447static void __mark_reg_known_zero(struct bpf_reg_state *reg)
448{
Edward Creeb03c9f92017-08-07 15:26:36 +0100449 __mark_reg_known(reg, 0);
Edward Creef1174f72017-08-07 15:26:19 +0100450}
451
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700452static void mark_reg_known_zero(struct bpf_verifier_env *env,
453 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100454{
455 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700456 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100457 /* Something bad happened, let's kill all regs */
458 for (regno = 0; regno < MAX_BPF_REG; regno++)
459 __mark_reg_not_init(regs + regno);
460 return;
461 }
462 __mark_reg_known_zero(regs + regno);
463}
464
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200465static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
466{
467 return type_is_pkt_pointer(reg->type);
468}
469
470static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
471{
472 return reg_is_pkt_pointer(reg) ||
473 reg->type == PTR_TO_PACKET_END;
474}
475
476/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
477static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
478 enum bpf_reg_type which)
479{
480 /* The register can already have a range from prior markings.
481 * This is fine as long as it hasn't been advanced from its
482 * origin.
483 */
484 return reg->type == which &&
485 reg->id == 0 &&
486 reg->off == 0 &&
487 tnum_equals_const(reg->var_off, 0);
488}
489
Edward Creeb03c9f92017-08-07 15:26:36 +0100490/* Attempts to improve min/max values based on var_off information */
491static void __update_reg_bounds(struct bpf_reg_state *reg)
492{
493 /* min signed is max(sign bit) | min(other bits) */
494 reg->smin_value = max_t(s64, reg->smin_value,
495 reg->var_off.value | (reg->var_off.mask & S64_MIN));
496 /* max signed is min(sign bit) | max(other bits) */
497 reg->smax_value = min_t(s64, reg->smax_value,
498 reg->var_off.value | (reg->var_off.mask & S64_MAX));
499 reg->umin_value = max(reg->umin_value, reg->var_off.value);
500 reg->umax_value = min(reg->umax_value,
501 reg->var_off.value | reg->var_off.mask);
502}
503
504/* Uses signed min/max values to inform unsigned, and vice-versa */
505static void __reg_deduce_bounds(struct bpf_reg_state *reg)
506{
507 /* Learn sign from signed bounds.
508 * If we cannot cross the sign boundary, then signed and unsigned bounds
509 * are the same, so combine. This works even in the negative case, e.g.
510 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
511 */
512 if (reg->smin_value >= 0 || reg->smax_value < 0) {
513 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
514 reg->umin_value);
515 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
516 reg->umax_value);
517 return;
518 }
519 /* Learn sign from unsigned bounds. Signed bounds cross the sign
520 * boundary, so we must be careful.
521 */
522 if ((s64)reg->umax_value >= 0) {
523 /* Positive. We can't learn anything from the smin, but smax
524 * is positive, hence safe.
525 */
526 reg->smin_value = reg->umin_value;
527 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
528 reg->umax_value);
529 } else if ((s64)reg->umin_value < 0) {
530 /* Negative. We can't learn anything from the smax, but smin
531 * is negative, hence safe.
532 */
533 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
534 reg->umin_value);
535 reg->smax_value = reg->umax_value;
536 }
537}
538
539/* Attempts to improve var_off based on unsigned min/max information */
540static void __reg_bound_offset(struct bpf_reg_state *reg)
541{
542 reg->var_off = tnum_intersect(reg->var_off,
543 tnum_range(reg->umin_value,
544 reg->umax_value));
545}
546
547/* Reset the min/max bounds of a register */
548static void __mark_reg_unbounded(struct bpf_reg_state *reg)
549{
550 reg->smin_value = S64_MIN;
551 reg->smax_value = S64_MAX;
552 reg->umin_value = 0;
553 reg->umax_value = U64_MAX;
554}
555
Edward Creef1174f72017-08-07 15:26:19 +0100556/* Mark a register as having a completely unknown (scalar) value. */
557static void __mark_reg_unknown(struct bpf_reg_state *reg)
558{
559 reg->type = SCALAR_VALUE;
560 reg->id = 0;
561 reg->off = 0;
562 reg->var_off = tnum_unknown;
Edward Creeb03c9f92017-08-07 15:26:36 +0100563 __mark_reg_unbounded(reg);
Edward Creef1174f72017-08-07 15:26:19 +0100564}
565
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700566static void mark_reg_unknown(struct bpf_verifier_env *env,
567 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100568{
569 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700570 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100571 /* Something bad happened, let's kill all regs */
572 for (regno = 0; regno < MAX_BPF_REG; regno++)
573 __mark_reg_not_init(regs + regno);
574 return;
575 }
576 __mark_reg_unknown(regs + regno);
577}
578
579static void __mark_reg_not_init(struct bpf_reg_state *reg)
580{
581 __mark_reg_unknown(reg);
582 reg->type = NOT_INIT;
583}
584
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700585static void mark_reg_not_init(struct bpf_verifier_env *env,
586 struct bpf_reg_state *regs, u32 regno)
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200587{
Edward Creef1174f72017-08-07 15:26:19 +0100588 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700589 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100590 /* Something bad happened, let's kill all regs */
591 for (regno = 0; regno < MAX_BPF_REG; regno++)
592 __mark_reg_not_init(regs + regno);
593 return;
594 }
595 __mark_reg_not_init(regs + regno);
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200596}
597
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700598static void init_reg_state(struct bpf_verifier_env *env,
599 struct bpf_reg_state *regs)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700600{
601 int i;
602
Edward Creedc503a82017-08-15 20:34:35 +0100603 for (i = 0; i < MAX_BPF_REG; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700604 mark_reg_not_init(env, regs, i);
Edward Creedc503a82017-08-15 20:34:35 +0100605 regs[i].live = REG_LIVE_NONE;
606 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700607
608 /* frame pointer */
Edward Creef1174f72017-08-07 15:26:19 +0100609 regs[BPF_REG_FP].type = PTR_TO_STACK;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700610 mark_reg_known_zero(env, regs, BPF_REG_FP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700611
612 /* 1st arg to a function */
613 regs[BPF_REG_1].type = PTR_TO_CTX;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700614 mark_reg_known_zero(env, regs, BPF_REG_1);
Daniel Borkmann6760bf22016-12-18 01:52:59 +0100615}
616
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700617enum reg_arg_type {
618 SRC_OP, /* register is used as source operand */
619 DST_OP, /* register is used as destination operand */
620 DST_OP_NO_MARK /* same as above, check only, don't mark */
621};
622
Edward Creedc503a82017-08-15 20:34:35 +0100623static void mark_reg_read(const struct bpf_verifier_state *state, u32 regno)
624{
625 struct bpf_verifier_state *parent = state->parent;
626
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -0700627 if (regno == BPF_REG_FP)
628 /* We don't need to worry about FP liveness because it's read-only */
629 return;
630
Edward Creedc503a82017-08-15 20:34:35 +0100631 while (parent) {
632 /* if read wasn't screened by an earlier write ... */
633 if (state->regs[regno].live & REG_LIVE_WRITTEN)
634 break;
635 /* ... then we depend on parent's value */
636 parent->regs[regno].live |= REG_LIVE_READ;
637 state = parent;
638 parent = state->parent;
639 }
640}
641
642static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700643 enum reg_arg_type t)
644{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700645 struct bpf_reg_state *regs = env->cur_state->regs;
Edward Creedc503a82017-08-15 20:34:35 +0100646
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700647 if (regno >= MAX_BPF_REG) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700648 verbose(env, "R%d is invalid\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700649 return -EINVAL;
650 }
651
652 if (t == SRC_OP) {
653 /* check whether register used as source operand can be read */
654 if (regs[regno].type == NOT_INIT) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700655 verbose(env, "R%d !read_ok\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700656 return -EACCES;
657 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700658 mark_reg_read(env->cur_state, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700659 } else {
660 /* check whether register used as dest operand can be written to */
661 if (regno == BPF_REG_FP) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700662 verbose(env, "frame pointer is read only\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700663 return -EACCES;
664 }
Edward Creedc503a82017-08-15 20:34:35 +0100665 regs[regno].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700666 if (t == DST_OP)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700667 mark_reg_unknown(env, regs, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700668 }
669 return 0;
670}
671
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700672static bool is_spillable_regtype(enum bpf_reg_type type)
673{
674 switch (type) {
675 case PTR_TO_MAP_VALUE:
676 case PTR_TO_MAP_VALUE_OR_NULL:
677 case PTR_TO_STACK:
678 case PTR_TO_CTX:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700679 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200680 case PTR_TO_PACKET_META:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700681 case PTR_TO_PACKET_END:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700682 case CONST_PTR_TO_MAP:
683 return true;
684 default:
685 return false;
686 }
687}
688
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700689/* check_stack_read/write functions track spill/fill of registers,
690 * stack boundary and alignment are checked in check_mem_access()
691 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700692static int check_stack_write(struct bpf_verifier_env *env,
693 struct bpf_verifier_state *state, int off,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100694 int size, int value_regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700695{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700696 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
697
698 err = realloc_verifier_state(state, round_up(slot + 1, BPF_REG_SIZE),
699 true);
700 if (err)
701 return err;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700702 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
703 * so it's aligned access and [off, off + size) are within stack limits
704 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700705 if (!env->allow_ptr_leaks &&
706 state->stack[spi].slot_type[0] == STACK_SPILL &&
707 size != BPF_REG_SIZE) {
708 verbose(env, "attempt to corrupt spilled pointer on stack\n");
709 return -EACCES;
710 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700711
712 if (value_regno >= 0 &&
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700713 is_spillable_regtype(state->regs[value_regno].type)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700714
715 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700716 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700717 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700718 return -EACCES;
719 }
720
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700721 /* save register state */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700722 state->stack[spi].spilled_ptr = state->regs[value_regno];
723 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700724
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700725 for (i = 0; i < BPF_REG_SIZE; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700726 state->stack[spi].slot_type[i] = STACK_SPILL;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700727 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700728 /* regular write of data into stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700729 state->stack[spi].spilled_ptr = (struct bpf_reg_state) {};
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700730
731 for (i = 0; i < size; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700732 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
733 STACK_MISC;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700734 }
735 return 0;
736}
737
Edward Creedc503a82017-08-15 20:34:35 +0100738static void mark_stack_slot_read(const struct bpf_verifier_state *state, int slot)
739{
740 struct bpf_verifier_state *parent = state->parent;
741
742 while (parent) {
743 /* if read wasn't screened by an earlier write ... */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700744 if (state->stack[slot].spilled_ptr.live & REG_LIVE_WRITTEN)
Edward Creedc503a82017-08-15 20:34:35 +0100745 break;
746 /* ... then we depend on parent's value */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700747 parent->stack[slot].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +0100748 state = parent;
749 parent = state->parent;
750 }
751}
752
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700753static int check_stack_read(struct bpf_verifier_env *env,
754 struct bpf_verifier_state *state, int off, int size,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700755 int value_regno)
756{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700757 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
758 u8 *stype;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700759
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700760 if (state->allocated_stack <= slot) {
761 verbose(env, "invalid read from stack off %d+0 size %d\n",
762 off, size);
763 return -EACCES;
764 }
765 stype = state->stack[spi].slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700766
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700767 if (stype[0] == STACK_SPILL) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700768 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700769 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700770 return -EACCES;
771 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700772 for (i = 1; i < BPF_REG_SIZE; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700773 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700774 verbose(env, "corrupted spill memory\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700775 return -EACCES;
776 }
777 }
778
Edward Creedc503a82017-08-15 20:34:35 +0100779 if (value_regno >= 0) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700780 /* restore register state from stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700781 state->regs[value_regno] = state->stack[spi].spilled_ptr;
Edward Creedc503a82017-08-15 20:34:35 +0100782 mark_stack_slot_read(state, spi);
783 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700784 return 0;
785 } else {
786 for (i = 0; i < size; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700787 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_MISC) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700788 verbose(env, "invalid read from stack off %d+%d size %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700789 off, i, size);
790 return -EACCES;
791 }
792 }
793 if (value_regno >= 0)
794 /* have read misc data from the stack */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700795 mark_reg_unknown(env, state->regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700796 return 0;
797 }
798}
799
800/* check read/write into map element returned by bpf_map_lookup_elem() */
Edward Creef1174f72017-08-07 15:26:19 +0100801static int __check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800802 int size, bool zero_size_allowed)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700803{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700804 struct bpf_reg_state *regs = cur_regs(env);
805 struct bpf_map *map = regs[regno].map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700806
Yonghong Song9fd29c02017-11-12 14:49:09 -0800807 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
808 off + size > map->value_size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700809 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700810 map->value_size, off, size);
811 return -EACCES;
812 }
813 return 0;
814}
815
Edward Creef1174f72017-08-07 15:26:19 +0100816/* check read/write into a map element with possible variable offset */
817static int check_map_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800818 int off, int size, bool zero_size_allowed)
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800819{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700820 struct bpf_verifier_state *state = env->cur_state;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800821 struct bpf_reg_state *reg = &state->regs[regno];
822 int err;
823
Edward Creef1174f72017-08-07 15:26:19 +0100824 /* We may have adjusted the register to this map value, so we
825 * need to try adding each of min_value and max_value to off
826 * to make sure our theoretical access will be safe.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800827 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700828 if (env->log.level)
829 print_verifier_state(env, state);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800830 /* The minimum value is only important with signed
831 * comparisons where we can't assume the floor of a
832 * value is 0. If we are using signed variables for our
833 * index'es we need to make sure that whatever we use
834 * will have a set floor within our range.
835 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100836 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700837 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800838 regno);
839 return -EACCES;
840 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800841 err = __check_map_access(env, regno, reg->smin_value + off, size,
842 zero_size_allowed);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800843 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700844 verbose(env, "R%d min value is outside of the array range\n",
845 regno);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800846 return err;
847 }
848
Edward Creeb03c9f92017-08-07 15:26:36 +0100849 /* If we haven't set a max value then we need to bail since we can't be
850 * sure we won't do bad things.
851 * If reg->umax_value + off could overflow, treat that as unbounded too.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800852 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100853 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700854 verbose(env, "R%d unbounded memory access, make sure to bounds check any array access into a map\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800855 regno);
856 return -EACCES;
857 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800858 err = __check_map_access(env, regno, reg->umax_value + off, size,
859 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +0100860 if (err)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700861 verbose(env, "R%d max value is outside of the array range\n",
862 regno);
Edward Creef1174f72017-08-07 15:26:19 +0100863 return err;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800864}
865
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700866#define MAX_PACKET_OFF 0xffff
867
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100868static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100869 const struct bpf_call_arg_meta *meta,
870 enum bpf_access_type t)
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700871{
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200872 switch (env->prog->type) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100873 case BPF_PROG_TYPE_LWT_IN:
874 case BPF_PROG_TYPE_LWT_OUT:
875 /* dst_input() and dst_output() can't write for now */
876 if (t == BPF_WRITE)
877 return false;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +0100878 /* fallthrough */
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200879 case BPF_PROG_TYPE_SCHED_CLS:
880 case BPF_PROG_TYPE_SCHED_ACT:
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700881 case BPF_PROG_TYPE_XDP:
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100882 case BPF_PROG_TYPE_LWT_XMIT:
John Fastabend8a31db52017-08-15 22:33:09 -0700883 case BPF_PROG_TYPE_SK_SKB:
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200884 if (meta)
885 return meta->pkt_access;
886
887 env->seen_direct_write = true;
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700888 return true;
889 default:
890 return false;
891 }
892}
893
Edward Creef1174f72017-08-07 15:26:19 +0100894static int __check_packet_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800895 int off, int size, bool zero_size_allowed)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700896{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700897 struct bpf_reg_state *regs = cur_regs(env);
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100898 struct bpf_reg_state *reg = &regs[regno];
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700899
Yonghong Song9fd29c02017-11-12 14:49:09 -0800900 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
901 (u64)off + size > reg->range) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700902 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -0700903 off, size, regno, reg->id, reg->off, reg->range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700904 return -EACCES;
905 }
906 return 0;
907}
908
Edward Creef1174f72017-08-07 15:26:19 +0100909static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -0800910 int size, bool zero_size_allowed)
Edward Creef1174f72017-08-07 15:26:19 +0100911{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700912 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +0100913 struct bpf_reg_state *reg = &regs[regno];
914 int err;
915
916 /* We may have added a variable offset to the packet pointer; but any
917 * reg->range we have comes after that. We are only checking the fixed
918 * offset.
919 */
920
921 /* We don't allow negative numbers, because we aren't tracking enough
922 * detail to prove they're safe.
923 */
Edward Creeb03c9f92017-08-07 15:26:36 +0100924 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700925 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Edward Creef1174f72017-08-07 15:26:19 +0100926 regno);
927 return -EACCES;
928 }
Yonghong Song9fd29c02017-11-12 14:49:09 -0800929 err = __check_packet_access(env, regno, off, size, zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +0100930 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700931 verbose(env, "R%d offset is outside of the packet\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100932 return err;
933 }
934 return err;
935}
936
937/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
Yonghong Song31fd8582017-06-13 15:52:13 -0700938static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700939 enum bpf_access_type t, enum bpf_reg_type *reg_type)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700940{
Daniel Borkmannf96da092017-07-02 02:13:27 +0200941 struct bpf_insn_access_aux info = {
942 .reg_type = *reg_type,
943 };
Yonghong Song31fd8582017-06-13 15:52:13 -0700944
Jakub Kicinski4f9218a2017-10-16 16:40:55 -0700945 if (env->ops->is_valid_access &&
946 env->ops->is_valid_access(off, size, t, &info)) {
Daniel Borkmannf96da092017-07-02 02:13:27 +0200947 /* A non zero info.ctx_field_size indicates that this field is a
948 * candidate for later verifier transformation to load the whole
949 * field and then apply a mask when accessed with a narrower
950 * access than actual ctx access size. A zero info.ctx_field_size
951 * will only allow for whole field access and rejects any other
952 * type of narrower access.
Yonghong Song31fd8582017-06-13 15:52:13 -0700953 */
Yonghong Song23994632017-06-22 15:07:39 -0700954 *reg_type = info.reg_type;
Yonghong Song31fd8582017-06-13 15:52:13 -0700955
Jakub Kicinski4f9218a2017-10-16 16:40:55 -0700956 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700957 /* remember the offset of last byte accessed in ctx */
958 if (env->prog->aux->max_ctx_offset < off + size)
959 env->prog->aux->max_ctx_offset = off + size;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700960 return 0;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700961 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700962
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700963 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700964 return -EACCES;
965}
966
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200967static bool __is_pointer_value(bool allow_ptr_leaks,
968 const struct bpf_reg_state *reg)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700969{
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200970 if (allow_ptr_leaks)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700971 return false;
972
Edward Creef1174f72017-08-07 15:26:19 +0100973 return reg->type != SCALAR_VALUE;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700974}
975
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200976static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
977{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700978 return __is_pointer_value(env->allow_ptr_leaks, cur_regs(env) + regno);
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +0200979}
980
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700981static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
982 const struct bpf_reg_state *reg,
David S. Millerd1174412017-05-10 11:22:52 -0700983 int off, int size, bool strict)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700984{
Edward Creef1174f72017-08-07 15:26:19 +0100985 struct tnum reg_off;
David S. Millere07b98d2017-05-10 11:38:07 -0700986 int ip_align;
David S. Millerd1174412017-05-10 11:22:52 -0700987
988 /* Byte size accesses are always allowed. */
989 if (!strict || size == 1)
990 return 0;
991
David S. Millere4eda882017-05-22 12:27:07 -0400992 /* For platforms that do not have a Kconfig enabling
993 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
994 * NET_IP_ALIGN is universally set to '2'. And on platforms
995 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
996 * to this code only in strict mode where we want to emulate
997 * the NET_IP_ALIGN==2 checking. Therefore use an
998 * unconditional IP align value of '2'.
David S. Millere07b98d2017-05-10 11:38:07 -0700999 */
David S. Millere4eda882017-05-22 12:27:07 -04001000 ip_align = 2;
Edward Creef1174f72017-08-07 15:26:19 +01001001
1002 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
1003 if (!tnum_is_aligned(reg_off, size)) {
1004 char tn_buf[48];
1005
1006 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001007 verbose(env,
1008 "misaligned packet access off %d+%s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001009 ip_align, tn_buf, reg->off, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001010 return -EACCES;
1011 }
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001012
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001013 return 0;
1014}
1015
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001016static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
1017 const struct bpf_reg_state *reg,
Edward Creef1174f72017-08-07 15:26:19 +01001018 const char *pointer_desc,
1019 int off, int size, bool strict)
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001020{
Edward Creef1174f72017-08-07 15:26:19 +01001021 struct tnum reg_off;
1022
1023 /* Byte size accesses are always allowed. */
1024 if (!strict || size == 1)
1025 return 0;
1026
1027 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
1028 if (!tnum_is_aligned(reg_off, size)) {
1029 char tn_buf[48];
1030
1031 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001032 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001033 pointer_desc, tn_buf, reg->off, off, size);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001034 return -EACCES;
1035 }
1036
1037 return 0;
1038}
1039
David S. Millere07b98d2017-05-10 11:38:07 -07001040static int check_ptr_alignment(struct bpf_verifier_env *env,
1041 const struct bpf_reg_state *reg,
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001042 int off, int size)
1043{
David S. Millere07b98d2017-05-10 11:38:07 -07001044 bool strict = env->strict_alignment;
Edward Creef1174f72017-08-07 15:26:19 +01001045 const char *pointer_desc = "";
David S. Millerd1174412017-05-10 11:22:52 -07001046
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001047 switch (reg->type) {
1048 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001049 case PTR_TO_PACKET_META:
1050 /* Special case, because of NET_IP_ALIGN. Given metadata sits
1051 * right in front, treat it the very same way.
1052 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001053 return check_pkt_ptr_alignment(env, reg, off, size, strict);
Edward Creef1174f72017-08-07 15:26:19 +01001054 case PTR_TO_MAP_VALUE:
1055 pointer_desc = "value ";
1056 break;
1057 case PTR_TO_CTX:
1058 pointer_desc = "context ";
1059 break;
1060 case PTR_TO_STACK:
1061 pointer_desc = "stack ";
1062 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001063 default:
Edward Creef1174f72017-08-07 15:26:19 +01001064 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001065 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001066 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
1067 strict);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001068}
1069
Jann Horn0c17d1d2017-12-18 20:11:55 -08001070/* truncate register to smaller size (in bytes)
1071 * must be called with size < BPF_REG_SIZE
1072 */
1073static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
1074{
1075 u64 mask;
1076
1077 /* clear high bits in bit representation */
1078 reg->var_off = tnum_cast(reg->var_off, size);
1079
1080 /* fix arithmetic bounds */
1081 mask = ((u64)1 << (size * 8)) - 1;
1082 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
1083 reg->umin_value &= mask;
1084 reg->umax_value &= mask;
1085 } else {
1086 reg->umin_value = 0;
1087 reg->umax_value = mask;
1088 }
1089 reg->smin_value = reg->umin_value;
1090 reg->smax_value = reg->umax_value;
1091}
1092
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001093/* check whether memory at (regno + off) is accessible for t = (read | write)
1094 * if t==write, value_regno is a register which value is stored into memory
1095 * if t==read, value_regno is a register which will receive the value from memory
1096 * if t==write && value_regno==-1, some unknown value is stored into memory
1097 * if t==read && value_regno==-1, don't care what we read from memory
1098 */
Yonghong Song31fd8582017-06-13 15:52:13 -07001099static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001100 int bpf_size, enum bpf_access_type t,
1101 int value_regno)
1102{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001103 struct bpf_verifier_state *state = env->cur_state;
1104 struct bpf_reg_state *regs = cur_regs(env);
1105 struct bpf_reg_state *reg = regs + regno;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001106 int size, err = 0;
1107
1108 size = bpf_size_to_bytes(bpf_size);
1109 if (size < 0)
1110 return size;
1111
Edward Creef1174f72017-08-07 15:26:19 +01001112 /* alignment checks will add in reg->off themselves */
David S. Millere07b98d2017-05-10 11:38:07 -07001113 err = check_ptr_alignment(env, reg, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001114 if (err)
1115 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001116
Edward Creef1174f72017-08-07 15:26:19 +01001117 /* for access checks, reg->off is just part of off */
1118 off += reg->off;
1119
1120 if (reg->type == PTR_TO_MAP_VALUE) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001121 if (t == BPF_WRITE && value_regno >= 0 &&
1122 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001123 verbose(env, "R%d leaks addr into map\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001124 return -EACCES;
1125 }
Josef Bacik48461132016-09-28 10:54:32 -04001126
Yonghong Song9fd29c02017-11-12 14:49:09 -08001127 err = check_map_access(env, regno, off, size, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001128 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001129 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001130
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001131 } else if (reg->type == PTR_TO_CTX) {
Edward Creef1174f72017-08-07 15:26:19 +01001132 enum bpf_reg_type reg_type = SCALAR_VALUE;
Alexei Starovoitov19de99f2016-06-15 18:25:38 -07001133
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001134 if (t == BPF_WRITE && value_regno >= 0 &&
1135 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001136 verbose(env, "R%d leaks addr into ctx\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001137 return -EACCES;
1138 }
Edward Creef1174f72017-08-07 15:26:19 +01001139 /* ctx accesses must be at a fixed offset, so that we can
1140 * determine what type of data were returned.
1141 */
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001142 if (reg->off) {
David S. Millerf8ddadc2017-10-22 13:36:53 +01001143 verbose(env,
1144 "dereference of modified ctx ptr R%d off=%d+%d, ctx+const is allowed, ctx+const+const is not\n",
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001145 regno, reg->off, off - reg->off);
1146 return -EACCES;
1147 }
1148 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
Edward Creef1174f72017-08-07 15:26:19 +01001149 char tn_buf[48];
1150
1151 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001152 verbose(env,
1153 "variable ctx access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001154 tn_buf, off, size);
1155 return -EACCES;
1156 }
Yonghong Song31fd8582017-06-13 15:52:13 -07001157 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001158 if (!err && t == BPF_READ && value_regno >= 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001159 /* ctx access returns either a scalar, or a
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001160 * PTR_TO_PACKET[_META,_END]. In the latter
1161 * case, we know the offset is zero.
Edward Creef1174f72017-08-07 15:26:19 +01001162 */
1163 if (reg_type == SCALAR_VALUE)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001164 mark_reg_unknown(env, regs, value_regno);
Edward Creef1174f72017-08-07 15:26:19 +01001165 else
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001166 mark_reg_known_zero(env, regs,
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001167 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001168 regs[value_regno].id = 0;
1169 regs[value_regno].off = 0;
1170 regs[value_regno].range = 0;
1171 regs[value_regno].type = reg_type;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001172 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001173
Edward Creef1174f72017-08-07 15:26:19 +01001174 } else if (reg->type == PTR_TO_STACK) {
1175 /* stack accesses must be at a fixed offset, so that we can
1176 * determine what type of data were returned.
1177 * See check_stack_read().
1178 */
1179 if (!tnum_is_const(reg->var_off)) {
1180 char tn_buf[48];
1181
1182 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001183 verbose(env, "variable stack access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001184 tn_buf, off, size);
1185 return -EACCES;
1186 }
1187 off += reg->var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001188 if (off >= 0 || off < -MAX_BPF_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001189 verbose(env, "invalid stack off=%d size=%d\n", off,
1190 size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001191 return -EACCES;
1192 }
Alexei Starovoitov87266792017-05-30 13:31:29 -07001193
1194 if (env->prog->aux->stack_depth < -off)
1195 env->prog->aux->stack_depth = -off;
1196
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001197 if (t == BPF_WRITE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001198 err = check_stack_write(env, state, off, size,
1199 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001200 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001201 err = check_stack_read(env, state, off, size,
1202 value_regno);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001203 } else if (reg_is_pkt_pointer(reg)) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001204 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001205 verbose(env, "cannot write into packet\n");
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001206 return -EACCES;
1207 }
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001208 if (t == BPF_WRITE && value_regno >= 0 &&
1209 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001210 verbose(env, "R%d leaks addr into packet\n",
1211 value_regno);
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001212 return -EACCES;
1213 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001214 err = check_packet_access(env, regno, off, size, false);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001215 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001216 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001217 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001218 verbose(env, "R%d invalid mem access '%s'\n", regno,
1219 reg_type_str[reg->type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001220 return -EACCES;
1221 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001222
Edward Creef1174f72017-08-07 15:26:19 +01001223 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001224 regs[value_regno].type == SCALAR_VALUE) {
Edward Creef1174f72017-08-07 15:26:19 +01001225 /* b/h/w load zero-extends, mark upper bits as known 0 */
Jann Horn0c17d1d2017-12-18 20:11:55 -08001226 coerce_reg_to_size(&regs[value_regno], size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001227 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001228 return err;
1229}
1230
Yonghong Song31fd8582017-06-13 15:52:13 -07001231static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001232{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001233 int err;
1234
1235 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
1236 insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001237 verbose(env, "BPF_XADD uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001238 return -EINVAL;
1239 }
1240
1241 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001242 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001243 if (err)
1244 return err;
1245
1246 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001247 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001248 if (err)
1249 return err;
1250
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001251 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001252 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001253 return -EACCES;
1254 }
1255
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001256 /* check whether atomic_add can read the memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001257 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001258 BPF_SIZE(insn->code), BPF_READ, -1);
1259 if (err)
1260 return err;
1261
1262 /* check whether atomic_add can write into the same memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001263 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001264 BPF_SIZE(insn->code), BPF_WRITE, -1);
1265}
1266
Edward Creef1174f72017-08-07 15:26:19 +01001267/* Does this register contain a constant zero? */
1268static bool register_is_null(struct bpf_reg_state reg)
1269{
1270 return reg.type == SCALAR_VALUE && tnum_equals_const(reg.var_off, 0);
1271}
1272
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001273/* when register 'regno' is passed into function that will read 'access_size'
1274 * bytes from that pointer, make sure that it's within stack boundary
Edward Creef1174f72017-08-07 15:26:19 +01001275 * and all elements of stack are initialized.
1276 * Unlike most pointer bounds-checking functions, this one doesn't take an
1277 * 'off' argument, so it has to add in reg->off itself.
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001278 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001279static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
Daniel Borkmann435faee12016-04-13 00:10:51 +02001280 int access_size, bool zero_size_allowed,
1281 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001282{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001283 struct bpf_verifier_state *state = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001284 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001285 int off, i, slot, spi;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001286
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001287 if (regs[regno].type != PTR_TO_STACK) {
Edward Creef1174f72017-08-07 15:26:19 +01001288 /* Allow zero-byte read from NULL, regardless of pointer type */
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001289 if (zero_size_allowed && access_size == 0 &&
Edward Creef1174f72017-08-07 15:26:19 +01001290 register_is_null(regs[regno]))
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001291 return 0;
1292
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001293 verbose(env, "R%d type=%s expected=%s\n", regno,
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001294 reg_type_str[regs[regno].type],
1295 reg_type_str[PTR_TO_STACK]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001296 return -EACCES;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001297 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001298
Edward Creef1174f72017-08-07 15:26:19 +01001299 /* Only allow fixed-offset stack reads */
1300 if (!tnum_is_const(regs[regno].var_off)) {
1301 char tn_buf[48];
1302
1303 tnum_strn(tn_buf, sizeof(tn_buf), regs[regno].var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001304 verbose(env, "invalid variable stack read R%d var_off=%s\n",
Edward Creef1174f72017-08-07 15:26:19 +01001305 regno, tn_buf);
Jann Hornea25f912017-12-18 20:11:57 -08001306 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01001307 }
1308 off = regs[regno].off + regs[regno].var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001309 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
Yonghong Song9fd29c02017-11-12 14:49:09 -08001310 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001311 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001312 regno, off, access_size);
1313 return -EACCES;
1314 }
1315
Alexei Starovoitov87266792017-05-30 13:31:29 -07001316 if (env->prog->aux->stack_depth < -off)
1317 env->prog->aux->stack_depth = -off;
1318
Daniel Borkmann435faee12016-04-13 00:10:51 +02001319 if (meta && meta->raw_mode) {
1320 meta->access_size = access_size;
1321 meta->regno = regno;
1322 return 0;
1323 }
1324
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001325 for (i = 0; i < access_size; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001326 slot = -(off + i) - 1;
1327 spi = slot / BPF_REG_SIZE;
1328 if (state->allocated_stack <= slot ||
1329 state->stack[spi].slot_type[slot % BPF_REG_SIZE] !=
1330 STACK_MISC) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001331 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001332 off, i, access_size);
1333 return -EACCES;
1334 }
1335 }
1336 return 0;
1337}
1338
Gianluca Borello06c1c042017-01-09 10:19:49 -08001339static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
1340 int access_size, bool zero_size_allowed,
1341 struct bpf_call_arg_meta *meta)
1342{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001343 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Gianluca Borello06c1c042017-01-09 10:19:49 -08001344
Edward Creef1174f72017-08-07 15:26:19 +01001345 switch (reg->type) {
Gianluca Borello06c1c042017-01-09 10:19:49 -08001346 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001347 case PTR_TO_PACKET_META:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001348 return check_packet_access(env, regno, reg->off, access_size,
1349 zero_size_allowed);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001350 case PTR_TO_MAP_VALUE:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001351 return check_map_access(env, regno, reg->off, access_size,
1352 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001353 default: /* scalar_value|ptr_to_stack or invalid ptr */
Gianluca Borello06c1c042017-01-09 10:19:49 -08001354 return check_stack_boundary(env, regno, access_size,
1355 zero_size_allowed, meta);
1356 }
1357}
1358
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001359static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001360 enum bpf_arg_type arg_type,
1361 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001362{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001363 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001364 enum bpf_reg_type expected_type, type = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001365 int err = 0;
1366
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001367 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001368 return 0;
1369
Edward Creedc503a82017-08-15 20:34:35 +01001370 err = check_reg_arg(env, regno, SRC_OP);
1371 if (err)
1372 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001373
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001374 if (arg_type == ARG_ANYTHING) {
1375 if (is_pointer_value(env, regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001376 verbose(env, "R%d leaks addr into helper function\n",
1377 regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001378 return -EACCES;
1379 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001380 return 0;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001381 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001382
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001383 if (type_is_pkt_pointer(type) &&
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001384 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001385 verbose(env, "helper access to the packet is not allowed\n");
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001386 return -EACCES;
1387 }
1388
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001389 if (arg_type == ARG_PTR_TO_MAP_KEY ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001390 arg_type == ARG_PTR_TO_MAP_VALUE) {
1391 expected_type = PTR_TO_STACK;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001392 if (!type_is_pkt_pointer(type) &&
1393 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001394 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001395 } else if (arg_type == ARG_CONST_SIZE ||
1396 arg_type == ARG_CONST_SIZE_OR_ZERO) {
Edward Creef1174f72017-08-07 15:26:19 +01001397 expected_type = SCALAR_VALUE;
1398 if (type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001399 goto err_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001400 } else if (arg_type == ARG_CONST_MAP_PTR) {
1401 expected_type = CONST_PTR_TO_MAP;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001402 if (type != expected_type)
1403 goto err_type;
Alexei Starovoitov608cd712015-03-26 19:53:57 -07001404 } else if (arg_type == ARG_PTR_TO_CTX) {
1405 expected_type = PTR_TO_CTX;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001406 if (type != expected_type)
1407 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001408 } else if (arg_type == ARG_PTR_TO_MEM ||
Gianluca Borellodb1ac492017-11-22 18:32:53 +00001409 arg_type == ARG_PTR_TO_MEM_OR_NULL ||
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001410 arg_type == ARG_PTR_TO_UNINIT_MEM) {
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001411 expected_type = PTR_TO_STACK;
1412 /* One exception here. In case function allows for NULL to be
Edward Creef1174f72017-08-07 15:26:19 +01001413 * passed in as argument, it's a SCALAR_VALUE type. Final test
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001414 * happens during stack boundary checking.
1415 */
Gianluca Borellodb1ac492017-11-22 18:32:53 +00001416 if (register_is_null(*reg) &&
1417 arg_type == ARG_PTR_TO_MEM_OR_NULL)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001418 /* final test in check_stack_boundary() */;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001419 else if (!type_is_pkt_pointer(type) &&
1420 type != PTR_TO_MAP_VALUE &&
Edward Creef1174f72017-08-07 15:26:19 +01001421 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001422 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001423 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001424 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001425 verbose(env, "unsupported arg_type %d\n", arg_type);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001426 return -EFAULT;
1427 }
1428
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001429 if (arg_type == ARG_CONST_MAP_PTR) {
1430 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001431 meta->map_ptr = reg->map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001432 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
1433 /* bpf_map_xxx(..., map_ptr, ..., key) call:
1434 * check that [key, key + map->key_size) are within
1435 * stack limits and initialized
1436 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001437 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001438 /* in function declaration map_ptr must come before
1439 * map_key, so that it's verified and known before
1440 * we have to check map_key here. Otherwise it means
1441 * that kernel subsystem misconfigured verifier
1442 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001443 verbose(env, "invalid map_ptr to access map->key\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001444 return -EACCES;
1445 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001446 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001447 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001448 meta->map_ptr->key_size,
1449 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001450 else
1451 err = check_stack_boundary(env, regno,
1452 meta->map_ptr->key_size,
1453 false, NULL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001454 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
1455 /* bpf_map_xxx(..., map_ptr, ..., value) call:
1456 * check [value, value + map->value_size) validity
1457 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001458 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001459 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001460 verbose(env, "invalid map_ptr to access map->value\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001461 return -EACCES;
1462 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001463 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001464 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001465 meta->map_ptr->value_size,
1466 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001467 else
1468 err = check_stack_boundary(env, regno,
1469 meta->map_ptr->value_size,
1470 false, NULL);
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001471 } else if (arg_type == ARG_CONST_SIZE ||
1472 arg_type == ARG_CONST_SIZE_OR_ZERO) {
1473 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001474
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001475 /* bpf_xxx(..., buf, len) call will access 'len' bytes
1476 * from stack pointer 'buf'. Check it
1477 * note: regno == len, regno - 1 == buf
1478 */
1479 if (regno == 0) {
1480 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001481 verbose(env,
1482 "ARG_CONST_SIZE cannot be first argument\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001483 return -EACCES;
1484 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001485
Edward Creef1174f72017-08-07 15:26:19 +01001486 /* The register is SCALAR_VALUE; the access check
1487 * happens using its boundaries.
Gianluca Borello06c1c042017-01-09 10:19:49 -08001488 */
Edward Creef1174f72017-08-07 15:26:19 +01001489
1490 if (!tnum_is_const(reg->var_off))
Gianluca Borello06c1c042017-01-09 10:19:49 -08001491 /* For unprivileged variable accesses, disable raw
1492 * mode so that the program is required to
1493 * initialize all the memory that the helper could
1494 * just partially fill up.
1495 */
1496 meta = NULL;
1497
Edward Creeb03c9f92017-08-07 15:26:36 +01001498 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001499 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
Edward Creef1174f72017-08-07 15:26:19 +01001500 regno);
1501 return -EACCES;
1502 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001503
Edward Creeb03c9f92017-08-07 15:26:36 +01001504 if (reg->umin_value == 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001505 err = check_helper_mem_access(env, regno - 1, 0,
1506 zero_size_allowed,
1507 meta);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001508 if (err)
1509 return err;
Gianluca Borello06c1c042017-01-09 10:19:49 -08001510 }
Edward Creef1174f72017-08-07 15:26:19 +01001511
Edward Creeb03c9f92017-08-07 15:26:36 +01001512 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001513 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
Edward Creef1174f72017-08-07 15:26:19 +01001514 regno);
1515 return -EACCES;
1516 }
1517 err = check_helper_mem_access(env, regno - 1,
Edward Creeb03c9f92017-08-07 15:26:36 +01001518 reg->umax_value,
Edward Creef1174f72017-08-07 15:26:19 +01001519 zero_size_allowed, meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001520 }
1521
1522 return err;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001523err_type:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001524 verbose(env, "R%d type=%s expected=%s\n", regno,
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001525 reg_type_str[type], reg_type_str[expected_type]);
1526 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001527}
1528
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001529static int check_map_func_compatibility(struct bpf_verifier_env *env,
1530 struct bpf_map *map, int func_id)
Kaixu Xia35578d72015-08-06 07:02:35 +00001531{
Kaixu Xia35578d72015-08-06 07:02:35 +00001532 if (!map)
1533 return 0;
1534
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001535 /* We need a two way check, first is from map perspective ... */
1536 switch (map->map_type) {
1537 case BPF_MAP_TYPE_PROG_ARRAY:
1538 if (func_id != BPF_FUNC_tail_call)
1539 goto error;
1540 break;
1541 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
1542 if (func_id != BPF_FUNC_perf_event_read &&
Yonghong Song908432c2017-10-05 09:19:20 -07001543 func_id != BPF_FUNC_perf_event_output &&
1544 func_id != BPF_FUNC_perf_event_read_value)
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001545 goto error;
1546 break;
1547 case BPF_MAP_TYPE_STACK_TRACE:
1548 if (func_id != BPF_FUNC_get_stackid)
1549 goto error;
1550 break;
Martin KaFai Lau4ed8ec52016-06-30 10:28:43 -07001551 case BPF_MAP_TYPE_CGROUP_ARRAY:
David S. Miller60747ef2016-08-18 01:17:32 -04001552 if (func_id != BPF_FUNC_skb_under_cgroup &&
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001553 func_id != BPF_FUNC_current_task_under_cgroup)
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001554 goto error;
1555 break;
John Fastabend546ac1f2017-07-17 09:28:56 -07001556 /* devmap returns a pointer to a live net_device ifindex that we cannot
1557 * allow to be modified from bpf side. So do not allow lookup elements
1558 * for now.
1559 */
1560 case BPF_MAP_TYPE_DEVMAP:
John Fastabend2ddf71e2017-07-17 09:30:02 -07001561 if (func_id != BPF_FUNC_redirect_map)
John Fastabend546ac1f2017-07-17 09:28:56 -07001562 goto error;
1563 break;
Jesper Dangaard Brouer6710e112017-10-16 12:19:28 +02001564 /* Restrict bpf side of cpumap, open when use-cases appear */
1565 case BPF_MAP_TYPE_CPUMAP:
1566 if (func_id != BPF_FUNC_redirect_map)
1567 goto error;
1568 break;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07001569 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07001570 case BPF_MAP_TYPE_HASH_OF_MAPS:
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07001571 if (func_id != BPF_FUNC_map_lookup_elem)
1572 goto error;
Martin KaFai Lau16a43622017-08-17 18:14:43 -07001573 break;
John Fastabend174a79f2017-08-15 22:32:47 -07001574 case BPF_MAP_TYPE_SOCKMAP:
1575 if (func_id != BPF_FUNC_sk_redirect_map &&
1576 func_id != BPF_FUNC_sock_map_update &&
1577 func_id != BPF_FUNC_map_delete_elem)
1578 goto error;
1579 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001580 default:
1581 break;
1582 }
1583
1584 /* ... and second from the function itself. */
1585 switch (func_id) {
1586 case BPF_FUNC_tail_call:
1587 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
1588 goto error;
1589 break;
1590 case BPF_FUNC_perf_event_read:
1591 case BPF_FUNC_perf_event_output:
Yonghong Song908432c2017-10-05 09:19:20 -07001592 case BPF_FUNC_perf_event_read_value:
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001593 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
1594 goto error;
1595 break;
1596 case BPF_FUNC_get_stackid:
1597 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
1598 goto error;
1599 break;
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001600 case BPF_FUNC_current_task_under_cgroup:
Daniel Borkmann747ea552016-08-12 22:17:17 +02001601 case BPF_FUNC_skb_under_cgroup:
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001602 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
1603 goto error;
1604 break;
John Fastabend97f91a72017-07-17 09:29:18 -07001605 case BPF_FUNC_redirect_map:
Jesper Dangaard Brouer9c270af2017-10-16 12:19:34 +02001606 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
1607 map->map_type != BPF_MAP_TYPE_CPUMAP)
John Fastabend97f91a72017-07-17 09:29:18 -07001608 goto error;
1609 break;
John Fastabend174a79f2017-08-15 22:32:47 -07001610 case BPF_FUNC_sk_redirect_map:
1611 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
1612 goto error;
1613 break;
1614 case BPF_FUNC_sock_map_update:
1615 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
1616 goto error;
1617 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001618 default:
1619 break;
Kaixu Xia35578d72015-08-06 07:02:35 +00001620 }
1621
1622 return 0;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001623error:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001624 verbose(env, "cannot pass map_type %d into func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001625 map->map_type, func_id_name(func_id), func_id);
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001626 return -EINVAL;
Kaixu Xia35578d72015-08-06 07:02:35 +00001627}
1628
Daniel Borkmann435faee12016-04-13 00:10:51 +02001629static int check_raw_mode(const struct bpf_func_proto *fn)
1630{
1631 int count = 0;
1632
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001633 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001634 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001635 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001636 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001637 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001638 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001639 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001640 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001641 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001642 count++;
1643
1644 return count > 1 ? -EINVAL : 0;
1645}
1646
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001647/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
1648 * are now invalid, so turn them into unknown SCALAR_VALUE.
Edward Creef1174f72017-08-07 15:26:19 +01001649 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001650static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001651{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001652 struct bpf_verifier_state *state = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001653 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001654 int i;
1655
1656 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001657 if (reg_is_pkt_pointer_any(&regs[i]))
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001658 mark_reg_unknown(env, regs, i);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001659
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001660 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
1661 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001662 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001663 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001664 if (reg_is_pkt_pointer_any(reg))
1665 __mark_reg_unknown(reg);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001666 }
1667}
1668
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07001669static int check_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001670{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001671 const struct bpf_func_proto *fn = NULL;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001672 struct bpf_reg_state *regs;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001673 struct bpf_call_arg_meta meta;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001674 bool changes_data;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001675 int i, err;
1676
1677 /* find function prototype */
1678 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001679 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
1680 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001681 return -EINVAL;
1682 }
1683
Jakub Kicinski00176a32017-10-16 16:40:54 -07001684 if (env->ops->get_func_proto)
1685 fn = env->ops->get_func_proto(func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001686
1687 if (!fn) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001688 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
1689 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001690 return -EINVAL;
1691 }
1692
1693 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +01001694 if (!env->prog->gpl_compatible && fn->gpl_only) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001695 verbose(env, "cannot call GPL only function from proprietary program\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001696 return -EINVAL;
1697 }
1698
Daniel Borkmann04514d12017-12-14 21:07:25 +01001699 /* With LD_ABS/IND some JITs save/restore skb from r1. */
Martin KaFai Lau17bedab2016-12-07 15:53:11 -08001700 changes_data = bpf_helper_changes_pkt_data(fn->func);
Daniel Borkmann04514d12017-12-14 21:07:25 +01001701 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
1702 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
1703 func_id_name(func_id), func_id);
1704 return -EINVAL;
1705 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001706
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001707 memset(&meta, 0, sizeof(meta));
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001708 meta.pkt_access = fn->pkt_access;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001709
Daniel Borkmann435faee12016-04-13 00:10:51 +02001710 /* We only support one arg being in raw mode at the moment, which
1711 * is sufficient for the helper functions we have right now.
1712 */
1713 err = check_raw_mode(fn);
1714 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001715 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001716 func_id_name(func_id), func_id);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001717 return err;
1718 }
1719
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001720 /* check args */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001721 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001722 if (err)
1723 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001724 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001725 if (err)
1726 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001727 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001728 if (err)
1729 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001730 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001731 if (err)
1732 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001733 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001734 if (err)
1735 return err;
1736
Daniel Borkmann435faee12016-04-13 00:10:51 +02001737 /* Mark slots with STACK_MISC in case of raw mode, stack offset
1738 * is inferred from register state.
1739 */
1740 for (i = 0; i < meta.access_size; i++) {
Yonghong Song31fd8582017-06-13 15:52:13 -07001741 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B, BPF_WRITE, -1);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001742 if (err)
1743 return err;
1744 }
1745
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001746 regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001747 /* reset caller saved regs */
Edward Creedc503a82017-08-15 20:34:35 +01001748 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001749 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01001750 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
1751 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001752
Edward Creedc503a82017-08-15 20:34:35 +01001753 /* update return register (already marked as written above) */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001754 if (fn->ret_type == RET_INTEGER) {
Edward Creef1174f72017-08-07 15:26:19 +01001755 /* sets type to SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001756 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001757 } else if (fn->ret_type == RET_VOID) {
1758 regs[BPF_REG_0].type = NOT_INIT;
1759 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
Martin KaFai Laufad73a12017-03-22 10:00:32 -07001760 struct bpf_insn_aux_data *insn_aux;
1761
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001762 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
Edward Creef1174f72017-08-07 15:26:19 +01001763 /* There is no offset yet applied, variable or fixed */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001764 mark_reg_known_zero(env, regs, BPF_REG_0);
Edward Creef1174f72017-08-07 15:26:19 +01001765 regs[BPF_REG_0].off = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001766 /* remember map_ptr, so that check_map_access()
1767 * can check 'value_size' boundary of memory access
1768 * to map element returned from bpf_map_lookup_elem()
1769 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001770 if (meta.map_ptr == NULL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001771 verbose(env,
1772 "kernel subsystem misconfigured verifier\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001773 return -EINVAL;
1774 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001775 regs[BPF_REG_0].map_ptr = meta.map_ptr;
Thomas Graf57a09bf2016-10-18 19:51:19 +02001776 regs[BPF_REG_0].id = ++env->id_gen;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07001777 insn_aux = &env->insn_aux_data[insn_idx];
1778 if (!insn_aux->map_ptr)
1779 insn_aux->map_ptr = meta.map_ptr;
1780 else if (insn_aux->map_ptr != meta.map_ptr)
1781 insn_aux->map_ptr = BPF_MAP_PTR_POISON;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001782 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001783 verbose(env, "unknown return type %d of func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02001784 fn->ret_type, func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001785 return -EINVAL;
1786 }
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001787
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001788 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
Kaixu Xia35578d72015-08-06 07:02:35 +00001789 if (err)
1790 return err;
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001791
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001792 if (changes_data)
1793 clear_all_pkt_pointers(env);
1794 return 0;
1795}
1796
Edward Creeb03c9f92017-08-07 15:26:36 +01001797static bool signed_add_overflows(s64 a, s64 b)
1798{
1799 /* Do the add in u64, where overflow is well-defined */
1800 s64 res = (s64)((u64)a + (u64)b);
1801
1802 if (b < 0)
1803 return res > a;
1804 return res < a;
1805}
1806
1807static bool signed_sub_overflows(s64 a, s64 b)
1808{
1809 /* Do the sub in u64, where overflow is well-defined */
1810 s64 res = (s64)((u64)a - (u64)b);
1811
1812 if (b < 0)
1813 return res < a;
1814 return res > a;
David S. Millerd1174412017-05-10 11:22:52 -07001815}
1816
Edward Creef1174f72017-08-07 15:26:19 +01001817/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
Edward Creef1174f72017-08-07 15:26:19 +01001818 * Caller should also handle BPF_MOV case separately.
1819 * If we return -EACCES, caller may want to try again treating pointer as a
1820 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
1821 */
1822static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
1823 struct bpf_insn *insn,
1824 const struct bpf_reg_state *ptr_reg,
1825 const struct bpf_reg_state *off_reg)
Josef Bacik48461132016-09-28 10:54:32 -04001826{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001827 struct bpf_reg_state *regs = cur_regs(env), *dst_reg;
Edward Creef1174f72017-08-07 15:26:19 +01001828 bool known = tnum_is_const(off_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01001829 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
1830 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
1831 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
1832 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
Josef Bacik48461132016-09-28 10:54:32 -04001833 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01001834 u32 dst = insn->dst_reg;
Josef Bacik48461132016-09-28 10:54:32 -04001835
Edward Creef1174f72017-08-07 15:26:19 +01001836 dst_reg = &regs[dst];
Josef Bacik48461132016-09-28 10:54:32 -04001837
Edward Creeb03c9f92017-08-07 15:26:36 +01001838 if (WARN_ON_ONCE(known && (smin_val != smax_val))) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001839 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001840 verbose(env,
1841 "verifier internal error: known but bad sbounds\n");
Edward Creeb03c9f92017-08-07 15:26:36 +01001842 return -EINVAL;
1843 }
1844 if (WARN_ON_ONCE(known && (umin_val != umax_val))) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001845 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001846 verbose(env,
1847 "verifier internal error: known but bad ubounds\n");
Edward Creef1174f72017-08-07 15:26:19 +01001848 return -EINVAL;
Josef Bacik48461132016-09-28 10:54:32 -04001849 }
1850
Edward Creef1174f72017-08-07 15:26:19 +01001851 if (BPF_CLASS(insn->code) != BPF_ALU64) {
1852 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
1853 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001854 verbose(env,
1855 "R%d 32-bit pointer arithmetic prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001856 dst);
1857 return -EACCES;
1858 }
David S. Millerd1174412017-05-10 11:22:52 -07001859
Edward Creef1174f72017-08-07 15:26:19 +01001860 if (ptr_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
1861 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001862 verbose(env, "R%d pointer arithmetic on PTR_TO_MAP_VALUE_OR_NULL prohibited, null-check it first\n",
Edward Creef1174f72017-08-07 15:26:19 +01001863 dst);
1864 return -EACCES;
1865 }
1866 if (ptr_reg->type == CONST_PTR_TO_MAP) {
1867 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001868 verbose(env, "R%d pointer arithmetic on CONST_PTR_TO_MAP prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001869 dst);
1870 return -EACCES;
1871 }
1872 if (ptr_reg->type == PTR_TO_PACKET_END) {
1873 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001874 verbose(env, "R%d pointer arithmetic on PTR_TO_PACKET_END prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001875 dst);
1876 return -EACCES;
1877 }
1878
1879 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
1880 * The id may be overwritten later if we create a new variable offset.
Josef Bacik48461132016-09-28 10:54:32 -04001881 */
Edward Creef1174f72017-08-07 15:26:19 +01001882 dst_reg->type = ptr_reg->type;
1883 dst_reg->id = ptr_reg->id;
Josef Bacikf23cc642016-11-14 15:45:36 -05001884
Josef Bacik48461132016-09-28 10:54:32 -04001885 switch (opcode) {
1886 case BPF_ADD:
Edward Creef1174f72017-08-07 15:26:19 +01001887 /* We can take a fixed offset as long as it doesn't overflow
1888 * the s32 'off' field
1889 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001890 if (known && (ptr_reg->off + smin_val ==
1891 (s64)(s32)(ptr_reg->off + smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01001892 /* pointer += K. Accumulate it into fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01001893 dst_reg->smin_value = smin_ptr;
1894 dst_reg->smax_value = smax_ptr;
1895 dst_reg->umin_value = umin_ptr;
1896 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01001897 dst_reg->var_off = ptr_reg->var_off;
Edward Creeb03c9f92017-08-07 15:26:36 +01001898 dst_reg->off = ptr_reg->off + smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01001899 dst_reg->range = ptr_reg->range;
1900 break;
1901 }
Edward Creef1174f72017-08-07 15:26:19 +01001902 /* A new variable offset is created. Note that off_reg->off
1903 * == 0, since it's a scalar.
1904 * dst_reg gets the pointer type and since some positive
1905 * integer value was added to the pointer, give it a new 'id'
1906 * if it's a PTR_TO_PACKET.
1907 * this creates a new 'base' pointer, off_reg (variable) gets
1908 * added into the variable offset, and we copy the fixed offset
1909 * from ptr_reg.
1910 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001911 if (signed_add_overflows(smin_ptr, smin_val) ||
1912 signed_add_overflows(smax_ptr, smax_val)) {
1913 dst_reg->smin_value = S64_MIN;
1914 dst_reg->smax_value = S64_MAX;
1915 } else {
1916 dst_reg->smin_value = smin_ptr + smin_val;
1917 dst_reg->smax_value = smax_ptr + smax_val;
1918 }
1919 if (umin_ptr + umin_val < umin_ptr ||
1920 umax_ptr + umax_val < umax_ptr) {
1921 dst_reg->umin_value = 0;
1922 dst_reg->umax_value = U64_MAX;
1923 } else {
1924 dst_reg->umin_value = umin_ptr + umin_val;
1925 dst_reg->umax_value = umax_ptr + umax_val;
1926 }
Edward Creef1174f72017-08-07 15:26:19 +01001927 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
1928 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001929 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01001930 dst_reg->id = ++env->id_gen;
1931 /* something was added to pkt_ptr, set range to zero */
1932 dst_reg->range = 0;
1933 }
Josef Bacik48461132016-09-28 10:54:32 -04001934 break;
1935 case BPF_SUB:
Edward Creef1174f72017-08-07 15:26:19 +01001936 if (dst_reg == off_reg) {
1937 /* scalar -= pointer. Creates an unknown scalar */
1938 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001939 verbose(env, "R%d tried to subtract pointer from scalar\n",
Edward Creef1174f72017-08-07 15:26:19 +01001940 dst);
1941 return -EACCES;
1942 }
1943 /* We don't allow subtraction from FP, because (according to
1944 * test_verifier.c test "invalid fp arithmetic", JITs might not
1945 * be able to deal with it.
Edward Cree93057062017-07-21 14:37:34 +01001946 */
Edward Creef1174f72017-08-07 15:26:19 +01001947 if (ptr_reg->type == PTR_TO_STACK) {
1948 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001949 verbose(env, "R%d subtraction from stack pointer prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01001950 dst);
1951 return -EACCES;
1952 }
Edward Creeb03c9f92017-08-07 15:26:36 +01001953 if (known && (ptr_reg->off - smin_val ==
1954 (s64)(s32)(ptr_reg->off - smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01001955 /* pointer -= K. Subtract it from fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01001956 dst_reg->smin_value = smin_ptr;
1957 dst_reg->smax_value = smax_ptr;
1958 dst_reg->umin_value = umin_ptr;
1959 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01001960 dst_reg->var_off = ptr_reg->var_off;
1961 dst_reg->id = ptr_reg->id;
Edward Creeb03c9f92017-08-07 15:26:36 +01001962 dst_reg->off = ptr_reg->off - smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01001963 dst_reg->range = ptr_reg->range;
1964 break;
1965 }
Edward Creef1174f72017-08-07 15:26:19 +01001966 /* A new variable offset is created. If the subtrahend is known
1967 * nonnegative, then any reg->range we had before is still good.
1968 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001969 if (signed_sub_overflows(smin_ptr, smax_val) ||
1970 signed_sub_overflows(smax_ptr, smin_val)) {
1971 /* Overflow possible, we know nothing */
1972 dst_reg->smin_value = S64_MIN;
1973 dst_reg->smax_value = S64_MAX;
1974 } else {
1975 dst_reg->smin_value = smin_ptr - smax_val;
1976 dst_reg->smax_value = smax_ptr - smin_val;
1977 }
1978 if (umin_ptr < umax_val) {
1979 /* Overflow possible, we know nothing */
1980 dst_reg->umin_value = 0;
1981 dst_reg->umax_value = U64_MAX;
1982 } else {
1983 /* Cannot overflow (as long as bounds are consistent) */
1984 dst_reg->umin_value = umin_ptr - umax_val;
1985 dst_reg->umax_value = umax_ptr - umin_val;
1986 }
Edward Creef1174f72017-08-07 15:26:19 +01001987 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
1988 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001989 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01001990 dst_reg->id = ++env->id_gen;
1991 /* something was added to pkt_ptr, set range to zero */
Edward Creeb03c9f92017-08-07 15:26:36 +01001992 if (smin_val < 0)
Edward Creef1174f72017-08-07 15:26:19 +01001993 dst_reg->range = 0;
1994 }
1995 break;
1996 case BPF_AND:
1997 case BPF_OR:
1998 case BPF_XOR:
1999 /* bitwise ops on pointers are troublesome, prohibit for now.
2000 * (However, in principle we could allow some cases, e.g.
2001 * ptr &= ~3 which would reduce min_value by 3.)
2002 */
2003 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002004 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01002005 dst, bpf_alu_string[opcode >> 4]);
2006 return -EACCES;
2007 default:
2008 /* other operators (e.g. MUL,LSH) produce non-pointer results */
2009 if (!env->allow_ptr_leaks)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002010 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01002011 dst, bpf_alu_string[opcode >> 4]);
2012 return -EACCES;
2013 }
2014
Edward Creeb03c9f92017-08-07 15:26:36 +01002015 __update_reg_bounds(dst_reg);
2016 __reg_deduce_bounds(dst_reg);
2017 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002018 return 0;
2019}
2020
Jann Horn468f6ea2017-12-18 20:11:56 -08002021/* WARNING: This function does calculations on 64-bit values, but the actual
2022 * execution may occur on 32-bit values. Therefore, things like bitshifts
2023 * need extra checks in the 32-bit case.
2024 */
Edward Creef1174f72017-08-07 15:26:19 +01002025static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
2026 struct bpf_insn *insn,
2027 struct bpf_reg_state *dst_reg,
2028 struct bpf_reg_state src_reg)
2029{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002030 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +01002031 u8 opcode = BPF_OP(insn->code);
2032 bool src_known, dst_known;
Edward Creeb03c9f92017-08-07 15:26:36 +01002033 s64 smin_val, smax_val;
2034 u64 umin_val, umax_val;
Jann Horn468f6ea2017-12-18 20:11:56 -08002035 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
Edward Creef1174f72017-08-07 15:26:19 +01002036
Edward Creeb03c9f92017-08-07 15:26:36 +01002037 smin_val = src_reg.smin_value;
2038 smax_val = src_reg.smax_value;
2039 umin_val = src_reg.umin_value;
2040 umax_val = src_reg.umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002041 src_known = tnum_is_const(src_reg.var_off);
2042 dst_known = tnum_is_const(dst_reg->var_off);
2043
2044 switch (opcode) {
2045 case BPF_ADD:
Edward Creeb03c9f92017-08-07 15:26:36 +01002046 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
2047 signed_add_overflows(dst_reg->smax_value, smax_val)) {
2048 dst_reg->smin_value = S64_MIN;
2049 dst_reg->smax_value = S64_MAX;
2050 } else {
2051 dst_reg->smin_value += smin_val;
2052 dst_reg->smax_value += smax_val;
2053 }
2054 if (dst_reg->umin_value + umin_val < umin_val ||
2055 dst_reg->umax_value + umax_val < umax_val) {
2056 dst_reg->umin_value = 0;
2057 dst_reg->umax_value = U64_MAX;
2058 } else {
2059 dst_reg->umin_value += umin_val;
2060 dst_reg->umax_value += umax_val;
2061 }
Edward Creef1174f72017-08-07 15:26:19 +01002062 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
2063 break;
2064 case BPF_SUB:
Edward Creeb03c9f92017-08-07 15:26:36 +01002065 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
2066 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
2067 /* Overflow possible, we know nothing */
2068 dst_reg->smin_value = S64_MIN;
2069 dst_reg->smax_value = S64_MAX;
2070 } else {
2071 dst_reg->smin_value -= smax_val;
2072 dst_reg->smax_value -= smin_val;
2073 }
2074 if (dst_reg->umin_value < umax_val) {
2075 /* Overflow possible, we know nothing */
2076 dst_reg->umin_value = 0;
2077 dst_reg->umax_value = U64_MAX;
2078 } else {
2079 /* Cannot overflow (as long as bounds are consistent) */
2080 dst_reg->umin_value -= umax_val;
2081 dst_reg->umax_value -= umin_val;
2082 }
Edward Creef1174f72017-08-07 15:26:19 +01002083 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
Josef Bacik48461132016-09-28 10:54:32 -04002084 break;
2085 case BPF_MUL:
Edward Creeb03c9f92017-08-07 15:26:36 +01002086 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
2087 if (smin_val < 0 || dst_reg->smin_value < 0) {
Edward Creef1174f72017-08-07 15:26:19 +01002088 /* Ain't nobody got time to multiply that sign */
Edward Creeb03c9f92017-08-07 15:26:36 +01002089 __mark_reg_unbounded(dst_reg);
2090 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002091 break;
2092 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002093 /* Both values are positive, so we can work with unsigned and
2094 * copy the result to signed (unless it exceeds S64_MAX).
Edward Creef1174f72017-08-07 15:26:19 +01002095 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002096 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
2097 /* Potential overflow, we know nothing */
2098 __mark_reg_unbounded(dst_reg);
2099 /* (except what we can learn from the var_off) */
2100 __update_reg_bounds(dst_reg);
2101 break;
2102 }
2103 dst_reg->umin_value *= umin_val;
2104 dst_reg->umax_value *= umax_val;
2105 if (dst_reg->umax_value > S64_MAX) {
2106 /* Overflow possible, we know nothing */
2107 dst_reg->smin_value = S64_MIN;
2108 dst_reg->smax_value = S64_MAX;
2109 } else {
2110 dst_reg->smin_value = dst_reg->umin_value;
2111 dst_reg->smax_value = dst_reg->umax_value;
2112 }
Josef Bacik48461132016-09-28 10:54:32 -04002113 break;
2114 case BPF_AND:
Edward Creef1174f72017-08-07 15:26:19 +01002115 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002116 __mark_reg_known(dst_reg, dst_reg->var_off.value &
2117 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002118 break;
2119 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002120 /* We get our minimum from the var_off, since that's inherently
2121 * bitwise. Our maximum is the minimum of the operands' maxima.
Josef Bacikf23cc642016-11-14 15:45:36 -05002122 */
Edward Creef1174f72017-08-07 15:26:19 +01002123 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002124 dst_reg->umin_value = dst_reg->var_off.value;
2125 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
2126 if (dst_reg->smin_value < 0 || smin_val < 0) {
2127 /* Lose signed bounds when ANDing negative numbers,
2128 * ain't nobody got time for that.
2129 */
2130 dst_reg->smin_value = S64_MIN;
2131 dst_reg->smax_value = S64_MAX;
2132 } else {
2133 /* ANDing two positives gives a positive, so safe to
2134 * cast result into s64.
2135 */
2136 dst_reg->smin_value = dst_reg->umin_value;
2137 dst_reg->smax_value = dst_reg->umax_value;
2138 }
2139 /* We may learn something more from the var_off */
2140 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002141 break;
2142 case BPF_OR:
2143 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002144 __mark_reg_known(dst_reg, dst_reg->var_off.value |
2145 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002146 break;
2147 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002148 /* We get our maximum from the var_off, and our minimum is the
2149 * maximum of the operands' minima
Edward Creef1174f72017-08-07 15:26:19 +01002150 */
2151 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002152 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
2153 dst_reg->umax_value = dst_reg->var_off.value |
2154 dst_reg->var_off.mask;
2155 if (dst_reg->smin_value < 0 || smin_val < 0) {
2156 /* Lose signed bounds when ORing negative numbers,
2157 * ain't nobody got time for that.
2158 */
2159 dst_reg->smin_value = S64_MIN;
2160 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002161 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002162 /* ORing two positives gives a positive, so safe to
2163 * cast result into s64.
2164 */
2165 dst_reg->smin_value = dst_reg->umin_value;
2166 dst_reg->smax_value = dst_reg->umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002167 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002168 /* We may learn something more from the var_off */
2169 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002170 break;
2171 case BPF_LSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002172 if (umax_val >= insn_bitness) {
2173 /* Shifts greater than 31 or 63 are undefined.
2174 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002175 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002176 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002177 break;
2178 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002179 /* We lose all sign bit information (except what we can pick
2180 * up from var_off)
Josef Bacik48461132016-09-28 10:54:32 -04002181 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002182 dst_reg->smin_value = S64_MIN;
2183 dst_reg->smax_value = S64_MAX;
2184 /* If we might shift our top bit out, then we know nothing */
2185 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
2186 dst_reg->umin_value = 0;
2187 dst_reg->umax_value = U64_MAX;
David S. Millerd1174412017-05-10 11:22:52 -07002188 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002189 dst_reg->umin_value <<= umin_val;
2190 dst_reg->umax_value <<= umax_val;
David S. Millerd1174412017-05-10 11:22:52 -07002191 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002192 if (src_known)
2193 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
2194 else
2195 dst_reg->var_off = tnum_lshift(tnum_unknown, umin_val);
2196 /* We may learn something more from the var_off */
2197 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002198 break;
2199 case BPF_RSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002200 if (umax_val >= insn_bitness) {
2201 /* Shifts greater than 31 or 63 are undefined.
2202 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002203 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002204 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002205 break;
2206 }
Edward Cree4374f252017-12-18 20:11:53 -08002207 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
2208 * be negative, then either:
2209 * 1) src_reg might be zero, so the sign bit of the result is
2210 * unknown, so we lose our signed bounds
2211 * 2) it's known negative, thus the unsigned bounds capture the
2212 * signed bounds
2213 * 3) the signed bounds cross zero, so they tell us nothing
2214 * about the result
2215 * If the value in dst_reg is known nonnegative, then again the
2216 * unsigned bounts capture the signed bounds.
2217 * Thus, in all cases it suffices to blow away our signed bounds
2218 * and rely on inferring new ones from the unsigned bounds and
2219 * var_off of the result.
2220 */
2221 dst_reg->smin_value = S64_MIN;
2222 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002223 if (src_known)
Edward Creeb03c9f92017-08-07 15:26:36 +01002224 dst_reg->var_off = tnum_rshift(dst_reg->var_off,
2225 umin_val);
Edward Creef1174f72017-08-07 15:26:19 +01002226 else
Edward Creeb03c9f92017-08-07 15:26:36 +01002227 dst_reg->var_off = tnum_rshift(tnum_unknown, umin_val);
2228 dst_reg->umin_value >>= umax_val;
2229 dst_reg->umax_value >>= umin_val;
2230 /* We may learn something more from the var_off */
2231 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002232 break;
2233 default:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002234 mark_reg_unknown(env, regs, insn->dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002235 break;
2236 }
2237
Jann Horn468f6ea2017-12-18 20:11:56 -08002238 if (BPF_CLASS(insn->code) != BPF_ALU64) {
2239 /* 32-bit ALU ops are (32,32)->32 */
2240 coerce_reg_to_size(dst_reg, 4);
2241 coerce_reg_to_size(&src_reg, 4);
2242 }
2243
Edward Creeb03c9f92017-08-07 15:26:36 +01002244 __reg_deduce_bounds(dst_reg);
2245 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002246 return 0;
2247}
2248
2249/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
2250 * and var_off.
2251 */
2252static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
2253 struct bpf_insn *insn)
2254{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002255 struct bpf_reg_state *regs = cur_regs(env), *dst_reg, *src_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002256 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
2257 u8 opcode = BPF_OP(insn->code);
2258 int rc;
2259
2260 dst_reg = &regs[insn->dst_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002261 src_reg = NULL;
2262 if (dst_reg->type != SCALAR_VALUE)
2263 ptr_reg = dst_reg;
2264 if (BPF_SRC(insn->code) == BPF_X) {
2265 src_reg = &regs[insn->src_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002266 if (src_reg->type != SCALAR_VALUE) {
2267 if (dst_reg->type != SCALAR_VALUE) {
2268 /* Combining two pointers by any ALU op yields
2269 * an arbitrary scalar.
2270 */
2271 if (!env->allow_ptr_leaks) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002272 verbose(env, "R%d pointer %s pointer prohibited\n",
Edward Creef1174f72017-08-07 15:26:19 +01002273 insn->dst_reg,
2274 bpf_alu_string[opcode >> 4]);
2275 return -EACCES;
2276 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002277 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002278 return 0;
2279 } else {
2280 /* scalar += pointer
2281 * This is legal, but we have to reverse our
2282 * src/dest handling in computing the range
2283 */
2284 rc = adjust_ptr_min_max_vals(env, insn,
2285 src_reg, dst_reg);
2286 if (rc == -EACCES && env->allow_ptr_leaks) {
2287 /* scalar += unknown scalar */
2288 __mark_reg_unknown(&off_reg);
2289 return adjust_scalar_min_max_vals(
2290 env, insn,
2291 dst_reg, off_reg);
2292 }
2293 return rc;
2294 }
2295 } else if (ptr_reg) {
2296 /* pointer += scalar */
2297 rc = adjust_ptr_min_max_vals(env, insn,
2298 dst_reg, src_reg);
2299 if (rc == -EACCES && env->allow_ptr_leaks) {
2300 /* unknown scalar += scalar */
2301 __mark_reg_unknown(dst_reg);
2302 return adjust_scalar_min_max_vals(
2303 env, insn, dst_reg, *src_reg);
2304 }
2305 return rc;
2306 }
2307 } else {
2308 /* Pretend the src is a reg with a known value, since we only
2309 * need to be able to read from this state.
2310 */
2311 off_reg.type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01002312 __mark_reg_known(&off_reg, insn->imm);
Edward Creef1174f72017-08-07 15:26:19 +01002313 src_reg = &off_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002314 if (ptr_reg) { /* pointer += K */
2315 rc = adjust_ptr_min_max_vals(env, insn,
2316 ptr_reg, src_reg);
2317 if (rc == -EACCES && env->allow_ptr_leaks) {
2318 /* unknown scalar += K */
2319 __mark_reg_unknown(dst_reg);
2320 return adjust_scalar_min_max_vals(
2321 env, insn, dst_reg, off_reg);
2322 }
2323 return rc;
2324 }
2325 }
2326
2327 /* Got here implies adding two SCALAR_VALUEs */
2328 if (WARN_ON_ONCE(ptr_reg)) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002329 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002330 verbose(env, "verifier internal error: unexpected ptr_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01002331 return -EINVAL;
2332 }
2333 if (WARN_ON(!src_reg)) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002334 print_verifier_state(env, env->cur_state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002335 verbose(env, "verifier internal error: no src_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01002336 return -EINVAL;
2337 }
2338 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002339}
2340
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002341/* check validity of 32-bit and 64-bit arithmetic operations */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002342static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002343{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002344 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002345 u8 opcode = BPF_OP(insn->code);
2346 int err;
2347
2348 if (opcode == BPF_END || opcode == BPF_NEG) {
2349 if (opcode == BPF_NEG) {
2350 if (BPF_SRC(insn->code) != 0 ||
2351 insn->src_reg != BPF_REG_0 ||
2352 insn->off != 0 || insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002353 verbose(env, "BPF_NEG uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002354 return -EINVAL;
2355 }
2356 } else {
2357 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
Edward Creee67b8a62017-09-15 14:37:38 +01002358 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
2359 BPF_CLASS(insn->code) == BPF_ALU64) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002360 verbose(env, "BPF_END uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002361 return -EINVAL;
2362 }
2363 }
2364
2365 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01002366 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002367 if (err)
2368 return err;
2369
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002370 if (is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002371 verbose(env, "R%d pointer arithmetic prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002372 insn->dst_reg);
2373 return -EACCES;
2374 }
2375
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002376 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002377 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002378 if (err)
2379 return err;
2380
2381 } else if (opcode == BPF_MOV) {
2382
2383 if (BPF_SRC(insn->code) == BPF_X) {
2384 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002385 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002386 return -EINVAL;
2387 }
2388
2389 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01002390 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002391 if (err)
2392 return err;
2393 } else {
2394 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002395 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002396 return -EINVAL;
2397 }
2398 }
2399
2400 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002401 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002402 if (err)
2403 return err;
2404
2405 if (BPF_SRC(insn->code) == BPF_X) {
2406 if (BPF_CLASS(insn->code) == BPF_ALU64) {
2407 /* case: R1 = R2
2408 * copy register state to dest reg
2409 */
2410 regs[insn->dst_reg] = regs[insn->src_reg];
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -07002411 regs[insn->dst_reg].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002412 } else {
Edward Creef1174f72017-08-07 15:26:19 +01002413 /* R1 = (u32) R2 */
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002414 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002415 verbose(env,
2416 "R%d partial copy of pointer\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002417 insn->src_reg);
2418 return -EACCES;
2419 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002420 mark_reg_unknown(env, regs, insn->dst_reg);
Jann Horn0c17d1d2017-12-18 20:11:55 -08002421 coerce_reg_to_size(&regs[insn->dst_reg], 4);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002422 }
2423 } else {
2424 /* case: R = imm
2425 * remember the value we stored into this reg
2426 */
Edward Creef1174f72017-08-07 15:26:19 +01002427 regs[insn->dst_reg].type = SCALAR_VALUE;
Jann Horn95a762e2017-12-18 20:11:54 -08002428 if (BPF_CLASS(insn->code) == BPF_ALU64) {
2429 __mark_reg_known(regs + insn->dst_reg,
2430 insn->imm);
2431 } else {
2432 __mark_reg_known(regs + insn->dst_reg,
2433 (u32)insn->imm);
2434 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002435 }
2436
2437 } else if (opcode > BPF_END) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002438 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002439 return -EINVAL;
2440
2441 } else { /* all other ALU ops: and, sub, xor, add, ... */
2442
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002443 if (BPF_SRC(insn->code) == BPF_X) {
2444 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002445 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002446 return -EINVAL;
2447 }
2448 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002449 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002450 if (err)
2451 return err;
2452 } else {
2453 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002454 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002455 return -EINVAL;
2456 }
2457 }
2458
2459 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002460 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002461 if (err)
2462 return err;
2463
2464 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
2465 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002466 verbose(env, "div by zero\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002467 return -EINVAL;
2468 }
2469
Rabin Vincent229394e82016-01-12 20:17:08 +01002470 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
2471 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
2472 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
2473
2474 if (insn->imm < 0 || insn->imm >= size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002475 verbose(env, "invalid shift %d\n", insn->imm);
Rabin Vincent229394e82016-01-12 20:17:08 +01002476 return -EINVAL;
2477 }
2478 }
2479
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002480 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01002481 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002482 if (err)
2483 return err;
2484
Edward Creef1174f72017-08-07 15:26:19 +01002485 return adjust_reg_min_max_vals(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002486 }
2487
2488 return 0;
2489}
2490
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002491static void find_good_pkt_pointers(struct bpf_verifier_state *state,
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002492 struct bpf_reg_state *dst_reg,
David S. Millerf8ddadc2017-10-22 13:36:53 +01002493 enum bpf_reg_type type,
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002494 bool range_right_open)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002495{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002496 struct bpf_reg_state *regs = state->regs, *reg;
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002497 u16 new_range;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002498 int i;
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002499
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002500 if (dst_reg->off < 0 ||
2501 (dst_reg->off == 0 && range_right_open))
Edward Creef1174f72017-08-07 15:26:19 +01002502 /* This doesn't give us any range */
2503 return;
2504
Edward Creeb03c9f92017-08-07 15:26:36 +01002505 if (dst_reg->umax_value > MAX_PACKET_OFF ||
2506 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
Edward Creef1174f72017-08-07 15:26:19 +01002507 /* Risk of overflow. For instance, ptr + (1<<63) may be less
2508 * than pkt_end, but that's because it's also less than pkt.
2509 */
2510 return;
2511
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002512 new_range = dst_reg->off;
2513 if (range_right_open)
2514 new_range--;
2515
2516 /* Examples for register markings:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002517 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002518 * pkt_data in dst register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002519 *
2520 * r2 = r3;
2521 * r2 += 8;
2522 * if (r2 > pkt_end) goto <handle exception>
2523 * <access okay>
2524 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002525 * r2 = r3;
2526 * r2 += 8;
2527 * if (r2 < pkt_end) goto <access okay>
2528 * <handle exception>
2529 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002530 * Where:
2531 * r2 == dst_reg, pkt_end == src_reg
2532 * r2=pkt(id=n,off=8,r=0)
2533 * r3=pkt(id=n,off=0,r=0)
2534 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002535 * pkt_data in src register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002536 *
2537 * r2 = r3;
2538 * r2 += 8;
2539 * if (pkt_end >= r2) goto <access okay>
2540 * <handle exception>
2541 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002542 * r2 = r3;
2543 * r2 += 8;
2544 * if (pkt_end <= r2) goto <handle exception>
2545 * <access okay>
2546 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002547 * Where:
2548 * pkt_end == dst_reg, r2 == src_reg
2549 * r2=pkt(id=n,off=8,r=0)
2550 * r3=pkt(id=n,off=0,r=0)
2551 *
2552 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002553 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
2554 * and [r3, r3 + 8-1) respectively is safe to access depending on
2555 * the check.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002556 */
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002557
Edward Creef1174f72017-08-07 15:26:19 +01002558 /* If our ids match, then we must have the same max_value. And we
2559 * don't care about the other reg's fixed offset, since if it's too big
2560 * the range won't allow anything.
2561 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
2562 */
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002563 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002564 if (regs[i].type == type && regs[i].id == dst_reg->id)
Alexei Starovoitovb1977682017-03-24 15:57:33 -07002565 /* keep the maximum range already checked */
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02002566 regs[i].range = max(regs[i].range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002567
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002568 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2569 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002570 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002571 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002572 if (reg->type == type && reg->id == dst_reg->id)
Daniel Borkmannb06723d2017-11-01 23:58:09 +01002573 reg->range = max(reg->range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002574 }
2575}
2576
Josef Bacik48461132016-09-28 10:54:32 -04002577/* Adjusts the register min/max values in the case that the dst_reg is the
2578 * variable register that we are working on, and src_reg is a constant or we're
2579 * simply doing a BPF_K check.
Edward Creef1174f72017-08-07 15:26:19 +01002580 * In JEQ/JNE cases we also adjust the var_off values.
Josef Bacik48461132016-09-28 10:54:32 -04002581 */
2582static void reg_set_min_max(struct bpf_reg_state *true_reg,
2583 struct bpf_reg_state *false_reg, u64 val,
2584 u8 opcode)
2585{
Edward Creef1174f72017-08-07 15:26:19 +01002586 /* If the dst_reg is a pointer, we can't learn anything about its
2587 * variable offset from the compare (unless src_reg were a pointer into
2588 * the same object, but we don't bother with that.
2589 * Since false_reg and true_reg have the same type by construction, we
2590 * only need to check one of them for pointerness.
2591 */
2592 if (__is_pointer_value(false, false_reg))
2593 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002594
Josef Bacik48461132016-09-28 10:54:32 -04002595 switch (opcode) {
2596 case BPF_JEQ:
2597 /* If this is false then we know nothing Jon Snow, but if it is
2598 * true then we know for sure.
2599 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002600 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002601 break;
2602 case BPF_JNE:
2603 /* If this is true we know nothing Jon Snow, but if it is false
2604 * we know the value for sure;
2605 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002606 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002607 break;
2608 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002609 false_reg->umax_value = min(false_reg->umax_value, val);
2610 true_reg->umin_value = max(true_reg->umin_value, val + 1);
2611 break;
Josef Bacik48461132016-09-28 10:54:32 -04002612 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002613 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
2614 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04002615 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002616 case BPF_JLT:
2617 false_reg->umin_value = max(false_reg->umin_value, val);
2618 true_reg->umax_value = min(true_reg->umax_value, val - 1);
2619 break;
2620 case BPF_JSLT:
2621 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
2622 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
2623 break;
Josef Bacik48461132016-09-28 10:54:32 -04002624 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002625 false_reg->umax_value = min(false_reg->umax_value, val - 1);
2626 true_reg->umin_value = max(true_reg->umin_value, val);
2627 break;
Josef Bacik48461132016-09-28 10:54:32 -04002628 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002629 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
2630 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04002631 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002632 case BPF_JLE:
2633 false_reg->umin_value = max(false_reg->umin_value, val + 1);
2634 true_reg->umax_value = min(true_reg->umax_value, val);
2635 break;
2636 case BPF_JSLE:
2637 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
2638 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
2639 break;
Josef Bacik48461132016-09-28 10:54:32 -04002640 default:
2641 break;
2642 }
2643
Edward Creeb03c9f92017-08-07 15:26:36 +01002644 __reg_deduce_bounds(false_reg);
2645 __reg_deduce_bounds(true_reg);
2646 /* We might have learned some bits from the bounds. */
2647 __reg_bound_offset(false_reg);
2648 __reg_bound_offset(true_reg);
2649 /* Intersecting with the old var_off might have improved our bounds
2650 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2651 * then new var_off is (0; 0x7f...fc) which improves our umax.
2652 */
2653 __update_reg_bounds(false_reg);
2654 __update_reg_bounds(true_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002655}
2656
Edward Creef1174f72017-08-07 15:26:19 +01002657/* Same as above, but for the case that dst_reg holds a constant and src_reg is
2658 * the variable reg.
Josef Bacik48461132016-09-28 10:54:32 -04002659 */
2660static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
2661 struct bpf_reg_state *false_reg, u64 val,
2662 u8 opcode)
2663{
Edward Creef1174f72017-08-07 15:26:19 +01002664 if (__is_pointer_value(false, false_reg))
2665 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002666
Josef Bacik48461132016-09-28 10:54:32 -04002667 switch (opcode) {
2668 case BPF_JEQ:
2669 /* If this is false then we know nothing Jon Snow, but if it is
2670 * true then we know for sure.
2671 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002672 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002673 break;
2674 case BPF_JNE:
2675 /* If this is true we know nothing Jon Snow, but if it is false
2676 * we know the value for sure;
2677 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002678 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04002679 break;
2680 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002681 true_reg->umax_value = min(true_reg->umax_value, val - 1);
2682 false_reg->umin_value = max(false_reg->umin_value, val);
2683 break;
Josef Bacik48461132016-09-28 10:54:32 -04002684 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01002685 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
2686 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04002687 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002688 case BPF_JLT:
2689 true_reg->umin_value = max(true_reg->umin_value, val + 1);
2690 false_reg->umax_value = min(false_reg->umax_value, val);
2691 break;
2692 case BPF_JSLT:
2693 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
2694 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
2695 break;
Josef Bacik48461132016-09-28 10:54:32 -04002696 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002697 true_reg->umax_value = min(true_reg->umax_value, val);
2698 false_reg->umin_value = max(false_reg->umin_value, val + 1);
2699 break;
Josef Bacik48461132016-09-28 10:54:32 -04002700 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01002701 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
2702 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04002703 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002704 case BPF_JLE:
2705 true_reg->umin_value = max(true_reg->umin_value, val);
2706 false_reg->umax_value = min(false_reg->umax_value, val - 1);
2707 break;
2708 case BPF_JSLE:
2709 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
2710 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
2711 break;
Josef Bacik48461132016-09-28 10:54:32 -04002712 default:
2713 break;
2714 }
2715
Edward Creeb03c9f92017-08-07 15:26:36 +01002716 __reg_deduce_bounds(false_reg);
2717 __reg_deduce_bounds(true_reg);
2718 /* We might have learned some bits from the bounds. */
2719 __reg_bound_offset(false_reg);
2720 __reg_bound_offset(true_reg);
2721 /* Intersecting with the old var_off might have improved our bounds
2722 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2723 * then new var_off is (0; 0x7f...fc) which improves our umax.
2724 */
2725 __update_reg_bounds(false_reg);
2726 __update_reg_bounds(true_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002727}
2728
2729/* Regs are known to be equal, so intersect their min/max/var_off */
2730static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
2731 struct bpf_reg_state *dst_reg)
2732{
Edward Creeb03c9f92017-08-07 15:26:36 +01002733 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
2734 dst_reg->umin_value);
2735 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
2736 dst_reg->umax_value);
2737 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
2738 dst_reg->smin_value);
2739 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
2740 dst_reg->smax_value);
Edward Creef1174f72017-08-07 15:26:19 +01002741 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
2742 dst_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002743 /* We might have learned new bounds from the var_off. */
2744 __update_reg_bounds(src_reg);
2745 __update_reg_bounds(dst_reg);
2746 /* We might have learned something about the sign bit. */
2747 __reg_deduce_bounds(src_reg);
2748 __reg_deduce_bounds(dst_reg);
2749 /* We might have learned some bits from the bounds. */
2750 __reg_bound_offset(src_reg);
2751 __reg_bound_offset(dst_reg);
2752 /* Intersecting with the old var_off might have improved our bounds
2753 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
2754 * then new var_off is (0; 0x7f...fc) which improves our umax.
2755 */
2756 __update_reg_bounds(src_reg);
2757 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002758}
2759
2760static void reg_combine_min_max(struct bpf_reg_state *true_src,
2761 struct bpf_reg_state *true_dst,
2762 struct bpf_reg_state *false_src,
2763 struct bpf_reg_state *false_dst,
2764 u8 opcode)
2765{
2766 switch (opcode) {
2767 case BPF_JEQ:
2768 __reg_combine_min_max(true_src, true_dst);
2769 break;
2770 case BPF_JNE:
2771 __reg_combine_min_max(false_src, false_dst);
Edward Creeb03c9f92017-08-07 15:26:36 +01002772 break;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02002773 }
Josef Bacik48461132016-09-28 10:54:32 -04002774}
2775
Thomas Graf57a09bf2016-10-18 19:51:19 +02002776static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
Edward Creef1174f72017-08-07 15:26:19 +01002777 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002778{
2779 struct bpf_reg_state *reg = &regs[regno];
2780
2781 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
Edward Creef1174f72017-08-07 15:26:19 +01002782 /* Old offset (both fixed and variable parts) should
2783 * have been known-zero, because we don't allow pointer
2784 * arithmetic on pointers that might be NULL.
2785 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002786 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
2787 !tnum_equals_const(reg->var_off, 0) ||
Edward Creef1174f72017-08-07 15:26:19 +01002788 reg->off)) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002789 __mark_reg_known_zero(reg);
2790 reg->off = 0;
Edward Creef1174f72017-08-07 15:26:19 +01002791 }
2792 if (is_null) {
2793 reg->type = SCALAR_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002794 } else if (reg->map_ptr->inner_map_meta) {
2795 reg->type = CONST_PTR_TO_MAP;
2796 reg->map_ptr = reg->map_ptr->inner_map_meta;
2797 } else {
Edward Creef1174f72017-08-07 15:26:19 +01002798 reg->type = PTR_TO_MAP_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002799 }
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002800 /* We don't need id from this point onwards anymore, thus we
2801 * should better reset it, so that state pruning has chances
2802 * to take effect.
2803 */
2804 reg->id = 0;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002805 }
2806}
2807
2808/* The logic is similar to find_good_pkt_pointers(), both could eventually
2809 * be folded together at some point.
2810 */
2811static void mark_map_regs(struct bpf_verifier_state *state, u32 regno,
Edward Creef1174f72017-08-07 15:26:19 +01002812 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002813{
2814 struct bpf_reg_state *regs = state->regs;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002815 u32 id = regs[regno].id;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002816 int i;
2817
2818 for (i = 0; i < MAX_BPF_REG; i++)
Edward Creef1174f72017-08-07 15:26:19 +01002819 mark_map_reg(regs, i, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002820
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002821 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2822 if (state->stack[i].slot_type[0] != STACK_SPILL)
Thomas Graf57a09bf2016-10-18 19:51:19 +02002823 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002824 mark_map_reg(&state->stack[i].spilled_ptr, 0, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002825 }
2826}
2827
Daniel Borkmann5beca082017-11-01 23:58:10 +01002828static bool try_match_pkt_pointers(const struct bpf_insn *insn,
2829 struct bpf_reg_state *dst_reg,
2830 struct bpf_reg_state *src_reg,
2831 struct bpf_verifier_state *this_branch,
2832 struct bpf_verifier_state *other_branch)
2833{
2834 if (BPF_SRC(insn->code) != BPF_X)
2835 return false;
2836
2837 switch (BPF_OP(insn->code)) {
2838 case BPF_JGT:
2839 if ((dst_reg->type == PTR_TO_PACKET &&
2840 src_reg->type == PTR_TO_PACKET_END) ||
2841 (dst_reg->type == PTR_TO_PACKET_META &&
2842 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2843 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
2844 find_good_pkt_pointers(this_branch, dst_reg,
2845 dst_reg->type, false);
2846 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2847 src_reg->type == PTR_TO_PACKET) ||
2848 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2849 src_reg->type == PTR_TO_PACKET_META)) {
2850 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
2851 find_good_pkt_pointers(other_branch, src_reg,
2852 src_reg->type, true);
2853 } else {
2854 return false;
2855 }
2856 break;
2857 case BPF_JLT:
2858 if ((dst_reg->type == PTR_TO_PACKET &&
2859 src_reg->type == PTR_TO_PACKET_END) ||
2860 (dst_reg->type == PTR_TO_PACKET_META &&
2861 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2862 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
2863 find_good_pkt_pointers(other_branch, dst_reg,
2864 dst_reg->type, true);
2865 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2866 src_reg->type == PTR_TO_PACKET) ||
2867 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2868 src_reg->type == PTR_TO_PACKET_META)) {
2869 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
2870 find_good_pkt_pointers(this_branch, src_reg,
2871 src_reg->type, false);
2872 } else {
2873 return false;
2874 }
2875 break;
2876 case BPF_JGE:
2877 if ((dst_reg->type == PTR_TO_PACKET &&
2878 src_reg->type == PTR_TO_PACKET_END) ||
2879 (dst_reg->type == PTR_TO_PACKET_META &&
2880 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2881 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
2882 find_good_pkt_pointers(this_branch, dst_reg,
2883 dst_reg->type, true);
2884 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2885 src_reg->type == PTR_TO_PACKET) ||
2886 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2887 src_reg->type == PTR_TO_PACKET_META)) {
2888 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
2889 find_good_pkt_pointers(other_branch, src_reg,
2890 src_reg->type, false);
2891 } else {
2892 return false;
2893 }
2894 break;
2895 case BPF_JLE:
2896 if ((dst_reg->type == PTR_TO_PACKET &&
2897 src_reg->type == PTR_TO_PACKET_END) ||
2898 (dst_reg->type == PTR_TO_PACKET_META &&
2899 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
2900 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
2901 find_good_pkt_pointers(other_branch, dst_reg,
2902 dst_reg->type, false);
2903 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
2904 src_reg->type == PTR_TO_PACKET) ||
2905 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
2906 src_reg->type == PTR_TO_PACKET_META)) {
2907 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
2908 find_good_pkt_pointers(this_branch, src_reg,
2909 src_reg->type, true);
2910 } else {
2911 return false;
2912 }
2913 break;
2914 default:
2915 return false;
2916 }
2917
2918 return true;
2919}
2920
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002921static int check_cond_jmp_op(struct bpf_verifier_env *env,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002922 struct bpf_insn *insn, int *insn_idx)
2923{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002924 struct bpf_verifier_state *other_branch, *this_branch = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002925 struct bpf_reg_state *regs = this_branch->regs, *dst_reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002926 u8 opcode = BPF_OP(insn->code);
2927 int err;
2928
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02002929 if (opcode > BPF_JSLE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002930 verbose(env, "invalid BPF_JMP opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002931 return -EINVAL;
2932 }
2933
2934 if (BPF_SRC(insn->code) == BPF_X) {
2935 if (insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002936 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002937 return -EINVAL;
2938 }
2939
2940 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002941 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002942 if (err)
2943 return err;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002944
2945 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002946 verbose(env, "R%d pointer comparison prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002947 insn->src_reg);
2948 return -EACCES;
2949 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002950 } else {
2951 if (insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002952 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002953 return -EINVAL;
2954 }
2955 }
2956
2957 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01002958 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002959 if (err)
2960 return err;
2961
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002962 dst_reg = &regs[insn->dst_reg];
2963
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002964 /* detect if R == 0 where R was initialized to zero earlier */
2965 if (BPF_SRC(insn->code) == BPF_K &&
2966 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
Edward Creef1174f72017-08-07 15:26:19 +01002967 dst_reg->type == SCALAR_VALUE &&
2968 tnum_equals_const(dst_reg->var_off, insn->imm)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002969 if (opcode == BPF_JEQ) {
2970 /* if (imm == imm) goto pc+off;
2971 * only follow the goto, ignore fall-through
2972 */
2973 *insn_idx += insn->off;
2974 return 0;
2975 } else {
2976 /* if (imm != imm) goto pc+off;
2977 * only follow fall-through branch, since
2978 * that's where the program will go
2979 */
2980 return 0;
2981 }
2982 }
2983
2984 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
2985 if (!other_branch)
2986 return -EFAULT;
2987
Josef Bacik48461132016-09-28 10:54:32 -04002988 /* detect if we are comparing against a constant value so we can adjust
2989 * our min/max values for our dst register.
Edward Creef1174f72017-08-07 15:26:19 +01002990 * this is only legit if both are scalars (or pointers to the same
2991 * object, I suppose, but we don't support that right now), because
2992 * otherwise the different base pointers mean the offsets aren't
2993 * comparable.
Josef Bacik48461132016-09-28 10:54:32 -04002994 */
2995 if (BPF_SRC(insn->code) == BPF_X) {
Edward Creef1174f72017-08-07 15:26:19 +01002996 if (dst_reg->type == SCALAR_VALUE &&
2997 regs[insn->src_reg].type == SCALAR_VALUE) {
2998 if (tnum_is_const(regs[insn->src_reg].var_off))
2999 reg_set_min_max(&other_branch->regs[insn->dst_reg],
3000 dst_reg, regs[insn->src_reg].var_off.value,
3001 opcode);
3002 else if (tnum_is_const(dst_reg->var_off))
3003 reg_set_min_max_inv(&other_branch->regs[insn->src_reg],
3004 &regs[insn->src_reg],
3005 dst_reg->var_off.value, opcode);
3006 else if (opcode == BPF_JEQ || opcode == BPF_JNE)
3007 /* Comparing for equality, we can combine knowledge */
3008 reg_combine_min_max(&other_branch->regs[insn->src_reg],
3009 &other_branch->regs[insn->dst_reg],
3010 &regs[insn->src_reg],
3011 &regs[insn->dst_reg], opcode);
3012 }
3013 } else if (dst_reg->type == SCALAR_VALUE) {
Josef Bacik48461132016-09-28 10:54:32 -04003014 reg_set_min_max(&other_branch->regs[insn->dst_reg],
3015 dst_reg, insn->imm, opcode);
3016 }
3017
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003018 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003019 if (BPF_SRC(insn->code) == BPF_K &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003020 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
3021 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Thomas Graf57a09bf2016-10-18 19:51:19 +02003022 /* Mark all identical map registers in each branch as either
3023 * safe or unknown depending R == 0 or R != 0 conditional.
3024 */
Edward Creef1174f72017-08-07 15:26:19 +01003025 mark_map_regs(this_branch, insn->dst_reg, opcode == BPF_JNE);
3026 mark_map_regs(other_branch, insn->dst_reg, opcode == BPF_JEQ);
Daniel Borkmann5beca082017-11-01 23:58:10 +01003027 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
3028 this_branch, other_branch) &&
3029 is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003030 verbose(env, "R%d pointer comparison prohibited\n",
3031 insn->dst_reg);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003032 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003033 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003034 if (env->log.level)
3035 print_verifier_state(env, this_branch);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003036 return 0;
3037}
3038
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003039/* return the map pointer stored inside BPF_LD_IMM64 instruction */
3040static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
3041{
3042 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
3043
3044 return (struct bpf_map *) (unsigned long) imm64;
3045}
3046
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003047/* verify BPF_LD_IMM64 instruction */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003048static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003049{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003050 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003051 int err;
3052
3053 if (BPF_SIZE(insn->code) != BPF_DW) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003054 verbose(env, "invalid BPF_LD_IMM insn\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003055 return -EINVAL;
3056 }
3057 if (insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003058 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003059 return -EINVAL;
3060 }
3061
Edward Creedc503a82017-08-15 20:34:35 +01003062 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003063 if (err)
3064 return err;
3065
Jakub Kicinski6b173872016-09-21 11:43:59 +01003066 if (insn->src_reg == 0) {
Jakub Kicinski6b173872016-09-21 11:43:59 +01003067 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
3068
Edward Creef1174f72017-08-07 15:26:19 +01003069 regs[insn->dst_reg].type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01003070 __mark_reg_known(&regs[insn->dst_reg], imm);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003071 return 0;
Jakub Kicinski6b173872016-09-21 11:43:59 +01003072 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003073
3074 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
3075 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
3076
3077 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
3078 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
3079 return 0;
3080}
3081
Daniel Borkmann96be4322015-03-01 12:31:46 +01003082static bool may_access_skb(enum bpf_prog_type type)
3083{
3084 switch (type) {
3085 case BPF_PROG_TYPE_SOCKET_FILTER:
3086 case BPF_PROG_TYPE_SCHED_CLS:
Daniel Borkmann94caee8c2015-03-20 15:11:11 +01003087 case BPF_PROG_TYPE_SCHED_ACT:
Daniel Borkmann96be4322015-03-01 12:31:46 +01003088 return true;
3089 default:
3090 return false;
3091 }
3092}
3093
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003094/* verify safety of LD_ABS|LD_IND instructions:
3095 * - they can only appear in the programs where ctx == skb
3096 * - since they are wrappers of function calls, they scratch R1-R5 registers,
3097 * preserve R6-R9, and store return value into R0
3098 *
3099 * Implicit input:
3100 * ctx == skb == R6 == CTX
3101 *
3102 * Explicit input:
3103 * SRC == any register
3104 * IMM == 32-bit immediate
3105 *
3106 * Output:
3107 * R0 - 8/16/32-bit skb data converted to cpu endianness
3108 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003109static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003110{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003111 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003112 u8 mode = BPF_MODE(insn->code);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003113 int i, err;
3114
Daniel Borkmann24701ec2015-03-01 12:31:47 +01003115 if (!may_access_skb(env->prog->type)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003116 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003117 return -EINVAL;
3118 }
3119
3120 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
Alexei Starovoitovd82bccc2016-04-12 10:26:19 -07003121 BPF_SIZE(insn->code) == BPF_DW ||
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003122 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003123 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003124 return -EINVAL;
3125 }
3126
3127 /* check whether implicit source operand (register R6) is readable */
Edward Creedc503a82017-08-15 20:34:35 +01003128 err = check_reg_arg(env, BPF_REG_6, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003129 if (err)
3130 return err;
3131
3132 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003133 verbose(env,
3134 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003135 return -EINVAL;
3136 }
3137
3138 if (mode == BPF_IND) {
3139 /* check explicit source operand */
Edward Creedc503a82017-08-15 20:34:35 +01003140 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003141 if (err)
3142 return err;
3143 }
3144
3145 /* reset caller saved regs to unreadable */
Edward Creedc503a82017-08-15 20:34:35 +01003146 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003147 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01003148 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
3149 }
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003150
3151 /* mark destination R0 register as readable, since it contains
Edward Creedc503a82017-08-15 20:34:35 +01003152 * the value fetched from the packet.
3153 * Already marked as written above.
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003154 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003155 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003156 return 0;
3157}
3158
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003159static int check_return_code(struct bpf_verifier_env *env)
3160{
3161 struct bpf_reg_state *reg;
3162 struct tnum range = tnum_range(0, 1);
3163
3164 switch (env->prog->type) {
3165 case BPF_PROG_TYPE_CGROUP_SKB:
3166 case BPF_PROG_TYPE_CGROUP_SOCK:
3167 case BPF_PROG_TYPE_SOCK_OPS:
Roman Gushchinebc614f2017-11-05 08:15:32 -05003168 case BPF_PROG_TYPE_CGROUP_DEVICE:
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003169 break;
3170 default:
3171 return 0;
3172 }
3173
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003174 reg = cur_regs(env) + BPF_REG_0;
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003175 if (reg->type != SCALAR_VALUE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003176 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003177 reg_type_str[reg->type]);
3178 return -EINVAL;
3179 }
3180
3181 if (!tnum_in(range, reg->var_off)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003182 verbose(env, "At program exit the register R0 ");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003183 if (!tnum_is_unknown(reg->var_off)) {
3184 char tn_buf[48];
3185
3186 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003187 verbose(env, "has value %s", tn_buf);
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003188 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003189 verbose(env, "has unknown scalar value");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003190 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003191 verbose(env, " should have been 0 or 1\n");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003192 return -EINVAL;
3193 }
3194 return 0;
3195}
3196
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003197/* non-recursive DFS pseudo code
3198 * 1 procedure DFS-iterative(G,v):
3199 * 2 label v as discovered
3200 * 3 let S be a stack
3201 * 4 S.push(v)
3202 * 5 while S is not empty
3203 * 6 t <- S.pop()
3204 * 7 if t is what we're looking for:
3205 * 8 return t
3206 * 9 for all edges e in G.adjacentEdges(t) do
3207 * 10 if edge e is already labelled
3208 * 11 continue with the next edge
3209 * 12 w <- G.adjacentVertex(t,e)
3210 * 13 if vertex w is not discovered and not explored
3211 * 14 label e as tree-edge
3212 * 15 label w as discovered
3213 * 16 S.push(w)
3214 * 17 continue at 5
3215 * 18 else if vertex w is discovered
3216 * 19 label e as back-edge
3217 * 20 else
3218 * 21 // vertex w is explored
3219 * 22 label e as forward- or cross-edge
3220 * 23 label t as explored
3221 * 24 S.pop()
3222 *
3223 * convention:
3224 * 0x10 - discovered
3225 * 0x11 - discovered and fall-through edge labelled
3226 * 0x12 - discovered and fall-through and branch edges labelled
3227 * 0x20 - explored
3228 */
3229
3230enum {
3231 DISCOVERED = 0x10,
3232 EXPLORED = 0x20,
3233 FALLTHROUGH = 1,
3234 BRANCH = 2,
3235};
3236
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003237#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003238
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003239static int *insn_stack; /* stack of insns to process */
3240static int cur_stack; /* current stack index */
3241static int *insn_state;
3242
3243/* t, w, e - match pseudo-code above:
3244 * t - index of current instruction
3245 * w - next instruction
3246 * e - edge
3247 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003248static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003249{
3250 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
3251 return 0;
3252
3253 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
3254 return 0;
3255
3256 if (w < 0 || w >= env->prog->len) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003257 verbose(env, "jump out of range from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003258 return -EINVAL;
3259 }
3260
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003261 if (e == BRANCH)
3262 /* mark branch target for state pruning */
3263 env->explored_states[w] = STATE_LIST_MARK;
3264
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003265 if (insn_state[w] == 0) {
3266 /* tree-edge */
3267 insn_state[t] = DISCOVERED | e;
3268 insn_state[w] = DISCOVERED;
3269 if (cur_stack >= env->prog->len)
3270 return -E2BIG;
3271 insn_stack[cur_stack++] = w;
3272 return 1;
3273 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003274 verbose(env, "back-edge from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003275 return -EINVAL;
3276 } else if (insn_state[w] == EXPLORED) {
3277 /* forward- or cross-edge */
3278 insn_state[t] = DISCOVERED | e;
3279 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003280 verbose(env, "insn state internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003281 return -EFAULT;
3282 }
3283 return 0;
3284}
3285
3286/* non-recursive depth-first-search to detect loops in BPF program
3287 * loop == back-edge in directed graph
3288 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003289static int check_cfg(struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003290{
3291 struct bpf_insn *insns = env->prog->insnsi;
3292 int insn_cnt = env->prog->len;
3293 int ret = 0;
3294 int i, t;
3295
3296 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
3297 if (!insn_state)
3298 return -ENOMEM;
3299
3300 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
3301 if (!insn_stack) {
3302 kfree(insn_state);
3303 return -ENOMEM;
3304 }
3305
3306 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
3307 insn_stack[0] = 0; /* 0 is the first instruction */
3308 cur_stack = 1;
3309
3310peek_stack:
3311 if (cur_stack == 0)
3312 goto check_state;
3313 t = insn_stack[cur_stack - 1];
3314
3315 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
3316 u8 opcode = BPF_OP(insns[t].code);
3317
3318 if (opcode == BPF_EXIT) {
3319 goto mark_explored;
3320 } else if (opcode == BPF_CALL) {
3321 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3322 if (ret == 1)
3323 goto peek_stack;
3324 else if (ret < 0)
3325 goto err_free;
Daniel Borkmann07016152016-04-05 22:33:17 +02003326 if (t + 1 < insn_cnt)
3327 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003328 } else if (opcode == BPF_JA) {
3329 if (BPF_SRC(insns[t].code) != BPF_K) {
3330 ret = -EINVAL;
3331 goto err_free;
3332 }
3333 /* unconditional jump with single edge */
3334 ret = push_insn(t, t + insns[t].off + 1,
3335 FALLTHROUGH, env);
3336 if (ret == 1)
3337 goto peek_stack;
3338 else if (ret < 0)
3339 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003340 /* tell verifier to check for equivalent states
3341 * after every call and jump
3342 */
Alexei Starovoitovc3de6312015-04-14 15:57:13 -07003343 if (t + 1 < insn_cnt)
3344 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003345 } else {
3346 /* conditional jump with two edges */
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02003347 env->explored_states[t] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003348 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3349 if (ret == 1)
3350 goto peek_stack;
3351 else if (ret < 0)
3352 goto err_free;
3353
3354 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
3355 if (ret == 1)
3356 goto peek_stack;
3357 else if (ret < 0)
3358 goto err_free;
3359 }
3360 } else {
3361 /* all other non-branch instructions with single
3362 * fall-through edge
3363 */
3364 ret = push_insn(t, t + 1, FALLTHROUGH, env);
3365 if (ret == 1)
3366 goto peek_stack;
3367 else if (ret < 0)
3368 goto err_free;
3369 }
3370
3371mark_explored:
3372 insn_state[t] = EXPLORED;
3373 if (cur_stack-- <= 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003374 verbose(env, "pop stack internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003375 ret = -EFAULT;
3376 goto err_free;
3377 }
3378 goto peek_stack;
3379
3380check_state:
3381 for (i = 0; i < insn_cnt; i++) {
3382 if (insn_state[i] != EXPLORED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003383 verbose(env, "unreachable insn %d\n", i);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003384 ret = -EINVAL;
3385 goto err_free;
3386 }
3387 }
3388 ret = 0; /* cfg looks good */
3389
3390err_free:
3391 kfree(insn_state);
3392 kfree(insn_stack);
3393 return ret;
3394}
3395
Edward Creef1174f72017-08-07 15:26:19 +01003396/* check %cur's range satisfies %old's */
3397static bool range_within(struct bpf_reg_state *old,
3398 struct bpf_reg_state *cur)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003399{
Edward Creeb03c9f92017-08-07 15:26:36 +01003400 return old->umin_value <= cur->umin_value &&
3401 old->umax_value >= cur->umax_value &&
3402 old->smin_value <= cur->smin_value &&
3403 old->smax_value >= cur->smax_value;
Edward Creef1174f72017-08-07 15:26:19 +01003404}
3405
3406/* Maximum number of register states that can exist at once */
3407#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
3408struct idpair {
3409 u32 old;
3410 u32 cur;
3411};
3412
3413/* If in the old state two registers had the same id, then they need to have
3414 * the same id in the new state as well. But that id could be different from
3415 * the old state, so we need to track the mapping from old to new ids.
3416 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
3417 * regs with old id 5 must also have new id 9 for the new state to be safe. But
3418 * regs with a different old id could still have new id 9, we don't care about
3419 * that.
3420 * So we look through our idmap to see if this old id has been seen before. If
3421 * so, we require the new id to match; otherwise, we add the id pair to the map.
3422 */
3423static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
3424{
3425 unsigned int i;
3426
3427 for (i = 0; i < ID_MAP_SIZE; i++) {
3428 if (!idmap[i].old) {
3429 /* Reached an empty slot; haven't seen this id before */
3430 idmap[i].old = old_id;
3431 idmap[i].cur = cur_id;
3432 return true;
3433 }
3434 if (idmap[i].old == old_id)
3435 return idmap[i].cur == cur_id;
3436 }
3437 /* We ran out of idmap slots, which should be impossible */
3438 WARN_ON_ONCE(1);
3439 return false;
3440}
3441
3442/* Returns true if (rold safe implies rcur safe) */
Edward Cree1b688a12017-08-23 15:10:50 +01003443static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
3444 struct idpair *idmap)
Edward Creef1174f72017-08-07 15:26:19 +01003445{
Edward Creedc503a82017-08-15 20:34:35 +01003446 if (!(rold->live & REG_LIVE_READ))
3447 /* explored state didn't use this */
3448 return true;
3449
3450 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, live)) == 0)
Edward Creef1174f72017-08-07 15:26:19 +01003451 return true;
3452
3453 if (rold->type == NOT_INIT)
3454 /* explored state can't have used this */
3455 return true;
3456 if (rcur->type == NOT_INIT)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003457 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003458 switch (rold->type) {
3459 case SCALAR_VALUE:
3460 if (rcur->type == SCALAR_VALUE) {
3461 /* new val must satisfy old val knowledge */
3462 return range_within(rold, rcur) &&
3463 tnum_in(rold->var_off, rcur->var_off);
3464 } else {
3465 /* if we knew anything about the old value, we're not
3466 * equal, because we can't know anything about the
3467 * scalar value of the pointer in the new value.
3468 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003469 return rold->umin_value == 0 &&
3470 rold->umax_value == U64_MAX &&
3471 rold->smin_value == S64_MIN &&
3472 rold->smax_value == S64_MAX &&
Edward Creef1174f72017-08-07 15:26:19 +01003473 tnum_is_unknown(rold->var_off);
3474 }
3475 case PTR_TO_MAP_VALUE:
Edward Cree1b688a12017-08-23 15:10:50 +01003476 /* If the new min/max/var_off satisfy the old ones and
3477 * everything else matches, we are OK.
3478 * We don't care about the 'id' value, because nothing
3479 * uses it for PTR_TO_MAP_VALUE (only for ..._OR_NULL)
3480 */
3481 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
3482 range_within(rold, rcur) &&
3483 tnum_in(rold->var_off, rcur->var_off);
Edward Creef1174f72017-08-07 15:26:19 +01003484 case PTR_TO_MAP_VALUE_OR_NULL:
3485 /* a PTR_TO_MAP_VALUE could be safe to use as a
3486 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
3487 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
3488 * checked, doing so could have affected others with the same
3489 * id, and we can't check for that because we lost the id when
3490 * we converted to a PTR_TO_MAP_VALUE.
3491 */
3492 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
3493 return false;
3494 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
3495 return false;
3496 /* Check our ids match any regs they're supposed to */
3497 return check_ids(rold->id, rcur->id, idmap);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003498 case PTR_TO_PACKET_META:
Edward Creef1174f72017-08-07 15:26:19 +01003499 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003500 if (rcur->type != rold->type)
Edward Creef1174f72017-08-07 15:26:19 +01003501 return false;
3502 /* We must have at least as much range as the old ptr
3503 * did, so that any accesses which were safe before are
3504 * still safe. This is true even if old range < old off,
3505 * since someone could have accessed through (ptr - k), or
3506 * even done ptr -= k in a register, to get a safe access.
3507 */
3508 if (rold->range > rcur->range)
3509 return false;
3510 /* If the offsets don't match, we can't trust our alignment;
3511 * nor can we be sure that we won't fall out of range.
3512 */
3513 if (rold->off != rcur->off)
3514 return false;
3515 /* id relations must be preserved */
3516 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
3517 return false;
3518 /* new val must satisfy old val knowledge */
3519 return range_within(rold, rcur) &&
3520 tnum_in(rold->var_off, rcur->var_off);
3521 case PTR_TO_CTX:
3522 case CONST_PTR_TO_MAP:
3523 case PTR_TO_STACK:
3524 case PTR_TO_PACKET_END:
3525 /* Only valid matches are exact, which memcmp() above
3526 * would have accepted
3527 */
3528 default:
3529 /* Don't know what's going on, just say it's not safe */
3530 return false;
3531 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003532
Edward Creef1174f72017-08-07 15:26:19 +01003533 /* Shouldn't get here; if we do, say it's not safe */
3534 WARN_ON_ONCE(1);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003535 return false;
3536}
3537
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003538static bool stacksafe(struct bpf_verifier_state *old,
3539 struct bpf_verifier_state *cur,
3540 struct idpair *idmap)
3541{
3542 int i, spi;
3543
3544 /* if explored stack has more populated slots than current stack
3545 * such stacks are not equivalent
3546 */
3547 if (old->allocated_stack > cur->allocated_stack)
3548 return false;
3549
3550 /* walk slots of the explored stack and ignore any additional
3551 * slots in the current stack, since explored(safe) state
3552 * didn't use them
3553 */
3554 for (i = 0; i < old->allocated_stack; i++) {
3555 spi = i / BPF_REG_SIZE;
3556
3557 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
3558 continue;
3559 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
3560 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
3561 /* Ex: old explored (safe) state has STACK_SPILL in
3562 * this stack slot, but current has has STACK_MISC ->
3563 * this verifier states are not equivalent,
3564 * return false to continue verification of this path
3565 */
3566 return false;
3567 if (i % BPF_REG_SIZE)
3568 continue;
3569 if (old->stack[spi].slot_type[0] != STACK_SPILL)
3570 continue;
3571 if (!regsafe(&old->stack[spi].spilled_ptr,
3572 &cur->stack[spi].spilled_ptr,
3573 idmap))
3574 /* when explored and current stack slot are both storing
3575 * spilled registers, check that stored pointers types
3576 * are the same as well.
3577 * Ex: explored safe path could have stored
3578 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
3579 * but current path has stored:
3580 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
3581 * such verifier states are not equivalent.
3582 * return false to continue verification of this path
3583 */
3584 return false;
3585 }
3586 return true;
3587}
3588
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003589/* compare two verifier states
3590 *
3591 * all states stored in state_list are known to be valid, since
3592 * verifier reached 'bpf_exit' instruction through them
3593 *
3594 * this function is called when verifier exploring different branches of
3595 * execution popped from the state stack. If it sees an old state that has
3596 * more strict register state and more strict stack state then this execution
3597 * branch doesn't need to be explored further, since verifier already
3598 * concluded that more strict state leads to valid finish.
3599 *
3600 * Therefore two states are equivalent if register state is more conservative
3601 * and explored stack state is more conservative than the current one.
3602 * Example:
3603 * explored current
3604 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
3605 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
3606 *
3607 * In other words if current stack state (one being explored) has more
3608 * valid slots than old one that already passed validation, it means
3609 * the verifier can stop exploring and conclude that current state is valid too
3610 *
3611 * Similarly with registers. If explored state has register type as invalid
3612 * whereas register type in current state is meaningful, it means that
3613 * the current state will reach 'bpf_exit' instruction safely
3614 */
Josef Bacik48461132016-09-28 10:54:32 -04003615static bool states_equal(struct bpf_verifier_env *env,
3616 struct bpf_verifier_state *old,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003617 struct bpf_verifier_state *cur)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003618{
Edward Creef1174f72017-08-07 15:26:19 +01003619 struct idpair *idmap;
3620 bool ret = false;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003621 int i;
3622
Edward Creef1174f72017-08-07 15:26:19 +01003623 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
3624 /* If we failed to allocate the idmap, just say it's not safe */
3625 if (!idmap)
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003626 return false;
Edward Creef1174f72017-08-07 15:26:19 +01003627
3628 for (i = 0; i < MAX_BPF_REG; i++) {
Edward Cree1b688a12017-08-23 15:10:50 +01003629 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
Edward Creef1174f72017-08-07 15:26:19 +01003630 goto out_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003631 }
3632
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003633 if (!stacksafe(old, cur, idmap))
3634 goto out_free;
Edward Creef1174f72017-08-07 15:26:19 +01003635 ret = true;
3636out_free:
3637 kfree(idmap);
3638 return ret;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003639}
3640
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003641/* A write screens off any subsequent reads; but write marks come from the
3642 * straight-line code between a state and its parent. When we arrive at a
3643 * jump target (in the first iteration of the propagate_liveness() loop),
3644 * we didn't arrive by the straight-line code, so read marks in state must
3645 * propagate to parent regardless of state's write marks.
3646 */
Edward Creedc503a82017-08-15 20:34:35 +01003647static bool do_propagate_liveness(const struct bpf_verifier_state *state,
3648 struct bpf_verifier_state *parent)
3649{
Edward Cree63f45f82017-08-23 15:10:03 +01003650 bool writes = parent == state->parent; /* Observe write marks */
Edward Creedc503a82017-08-15 20:34:35 +01003651 bool touched = false; /* any changes made? */
3652 int i;
3653
3654 if (!parent)
3655 return touched;
3656 /* Propagate read liveness of registers... */
3657 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
3658 /* We don't need to worry about FP liveness because it's read-only */
3659 for (i = 0; i < BPF_REG_FP; i++) {
3660 if (parent->regs[i].live & REG_LIVE_READ)
3661 continue;
Edward Cree63f45f82017-08-23 15:10:03 +01003662 if (writes && (state->regs[i].live & REG_LIVE_WRITTEN))
3663 continue;
3664 if (state->regs[i].live & REG_LIVE_READ) {
Edward Creedc503a82017-08-15 20:34:35 +01003665 parent->regs[i].live |= REG_LIVE_READ;
3666 touched = true;
3667 }
3668 }
3669 /* ... and stack slots */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003670 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
3671 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
3672 if (parent->stack[i].slot_type[0] != STACK_SPILL)
Edward Creedc503a82017-08-15 20:34:35 +01003673 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003674 if (state->stack[i].slot_type[0] != STACK_SPILL)
Edward Creedc503a82017-08-15 20:34:35 +01003675 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003676 if (parent->stack[i].spilled_ptr.live & REG_LIVE_READ)
Edward Creedc503a82017-08-15 20:34:35 +01003677 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003678 if (writes &&
3679 (state->stack[i].spilled_ptr.live & REG_LIVE_WRITTEN))
Edward Cree63f45f82017-08-23 15:10:03 +01003680 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003681 if (state->stack[i].spilled_ptr.live & REG_LIVE_READ) {
3682 parent->stack[i].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +01003683 touched = true;
3684 }
3685 }
3686 return touched;
3687}
3688
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003689/* "parent" is "a state from which we reach the current state", but initially
3690 * it is not the state->parent (i.e. "the state whose straight-line code leads
3691 * to the current state"), instead it is the state that happened to arrive at
3692 * a (prunable) equivalent of the current state. See comment above
3693 * do_propagate_liveness() for consequences of this.
3694 * This function is just a more efficient way of calling mark_reg_read() or
3695 * mark_stack_slot_read() on each reg in "parent" that is read in "state",
3696 * though it requires that parent != state->parent in the call arguments.
3697 */
Edward Creedc503a82017-08-15 20:34:35 +01003698static void propagate_liveness(const struct bpf_verifier_state *state,
3699 struct bpf_verifier_state *parent)
3700{
3701 while (do_propagate_liveness(state, parent)) {
3702 /* Something changed, so we need to feed those changes onward */
3703 state = parent;
3704 parent = state->parent;
3705 }
3706}
3707
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003708static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003709{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003710 struct bpf_verifier_state_list *new_sl;
3711 struct bpf_verifier_state_list *sl;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003712 struct bpf_verifier_state *cur = env->cur_state;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07003713 int i, err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003714
3715 sl = env->explored_states[insn_idx];
3716 if (!sl)
3717 /* this 'insn_idx' instruction wasn't marked, so we will not
3718 * be doing state search here
3719 */
3720 return 0;
3721
3722 while (sl != STATE_LIST_MARK) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003723 if (states_equal(env, &sl->state, cur)) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003724 /* reached equivalent register/stack state,
Edward Creedc503a82017-08-15 20:34:35 +01003725 * prune the search.
3726 * Registers read by the continuation are read by us.
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003727 * If we have any write marks in env->cur_state, they
3728 * will prevent corresponding reads in the continuation
3729 * from reaching our parent (an explored_state). Our
3730 * own state will get the read marks recorded, but
3731 * they'll be immediately forgotten as we're pruning
3732 * this state and will pop a new one.
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003733 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003734 propagate_liveness(&sl->state, cur);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003735 return 1;
Edward Creedc503a82017-08-15 20:34:35 +01003736 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003737 sl = sl->next;
3738 }
3739
3740 /* there were no equivalent states, remember current one.
3741 * technically the current state is not proven to be safe yet,
3742 * but it will either reach bpf_exit (which means it's safe) or
3743 * it will be rejected. Since there are no loops, we won't be
3744 * seeing this 'insn_idx' instruction again on the way to bpf_exit
3745 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003746 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003747 if (!new_sl)
3748 return -ENOMEM;
3749
3750 /* add new state to the head of linked list */
Alexei Starovoitov1969db42017-11-01 00:08:04 -07003751 err = copy_verifier_state(&new_sl->state, cur);
3752 if (err) {
3753 free_verifier_state(&new_sl->state, false);
3754 kfree(new_sl);
3755 return err;
3756 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003757 new_sl->next = env->explored_states[insn_idx];
3758 env->explored_states[insn_idx] = new_sl;
Edward Creedc503a82017-08-15 20:34:35 +01003759 /* connect new state to parentage chain */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003760 cur->parent = &new_sl->state;
Edward Cree8e9cd9c2017-08-23 15:11:21 +01003761 /* clear write marks in current state: the writes we did are not writes
3762 * our child did, so they don't screen off its reads from us.
3763 * (There are no read marks in current state, because reads always mark
3764 * their parent and current state never has children yet. Only
3765 * explored_states can get read marks.)
3766 */
Edward Creedc503a82017-08-15 20:34:35 +01003767 for (i = 0; i < BPF_REG_FP; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003768 cur->regs[i].live = REG_LIVE_NONE;
3769 for (i = 0; i < cur->allocated_stack / BPF_REG_SIZE; i++)
3770 if (cur->stack[i].slot_type[0] == STACK_SPILL)
3771 cur->stack[i].spilled_ptr.live = REG_LIVE_NONE;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003772 return 0;
3773}
3774
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003775static int ext_analyzer_insn_hook(struct bpf_verifier_env *env,
3776 int insn_idx, int prev_insn_idx)
3777{
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07003778 if (env->dev_ops && env->dev_ops->insn_hook)
3779 return env->dev_ops->insn_hook(env, insn_idx, prev_insn_idx);
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003780
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07003781 return 0;
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003782}
3783
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003784static int do_check(struct bpf_verifier_env *env)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003785{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003786 struct bpf_verifier_state *state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003787 struct bpf_insn *insns = env->prog->insnsi;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003788 struct bpf_reg_state *regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003789 int insn_cnt = env->prog->len;
3790 int insn_idx, prev_insn_idx = 0;
3791 int insn_processed = 0;
3792 bool do_print_state = false;
3793
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003794 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
3795 if (!state)
3796 return -ENOMEM;
3797 env->cur_state = state;
3798 init_reg_state(env, state->regs);
Edward Creedc503a82017-08-15 20:34:35 +01003799 state->parent = NULL;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003800 insn_idx = 0;
3801 for (;;) {
3802 struct bpf_insn *insn;
3803 u8 class;
3804 int err;
3805
3806 if (insn_idx >= insn_cnt) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003807 verbose(env, "invalid insn idx %d insn_cnt %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003808 insn_idx, insn_cnt);
3809 return -EFAULT;
3810 }
3811
3812 insn = &insns[insn_idx];
3813 class = BPF_CLASS(insn->code);
3814
Daniel Borkmann07016152016-04-05 22:33:17 +02003815 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003816 verbose(env,
3817 "BPF program is too large. Processed %d insn\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003818 insn_processed);
3819 return -E2BIG;
3820 }
3821
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003822 err = is_state_visited(env, insn_idx);
3823 if (err < 0)
3824 return err;
3825 if (err == 1) {
3826 /* found equivalent state, can prune the search */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003827 if (env->log.level) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003828 if (do_print_state)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003829 verbose(env, "\nfrom %d to %d: safe\n",
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003830 prev_insn_idx, insn_idx);
3831 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003832 verbose(env, "%d: safe\n", insn_idx);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003833 }
3834 goto process_bpf_exit;
3835 }
3836
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02003837 if (need_resched())
3838 cond_resched();
3839
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003840 if (env->log.level > 1 || (env->log.level && do_print_state)) {
3841 if (env->log.level > 1)
3842 verbose(env, "%d:", insn_idx);
David S. Millerc5fc9692017-05-10 11:25:17 -07003843 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003844 verbose(env, "\nfrom %d to %d:",
David S. Millerc5fc9692017-05-10 11:25:17 -07003845 prev_insn_idx, insn_idx);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003846 print_verifier_state(env, state);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003847 do_print_state = false;
3848 }
3849
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003850 if (env->log.level) {
3851 verbose(env, "%d: ", insn_idx);
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -07003852 print_bpf_insn(verbose, env, insn,
3853 env->allow_ptr_leaks);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003854 }
3855
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003856 err = ext_analyzer_insn_hook(env, insn_idx, prev_insn_idx);
3857 if (err)
3858 return err;
3859
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003860 regs = cur_regs(env);
Alexei Starovoitovc1311872017-11-22 16:42:05 -08003861 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003862 if (class == BPF_ALU || class == BPF_ALU64) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003863 err = check_alu_op(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003864 if (err)
3865 return err;
3866
3867 } else if (class == BPF_LDX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003868 enum bpf_reg_type *prev_src_type, src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003869
3870 /* check for reserved fields is already done */
3871
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003872 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003873 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003874 if (err)
3875 return err;
3876
Edward Creedc503a82017-08-15 20:34:35 +01003877 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003878 if (err)
3879 return err;
3880
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07003881 src_reg_type = regs[insn->src_reg].type;
3882
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003883 /* check that memory (src_reg + off) is readable,
3884 * the state of dst_reg will be updated by this func
3885 */
Yonghong Song31fd8582017-06-13 15:52:13 -07003886 err = check_mem_access(env, insn_idx, insn->src_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003887 BPF_SIZE(insn->code), BPF_READ,
3888 insn->dst_reg);
3889 if (err)
3890 return err;
3891
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003892 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
3893
3894 if (*prev_src_type == NOT_INIT) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003895 /* saw a valid insn
3896 * dst_reg = *(u32 *)(src_reg + off)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003897 * save type to validate intersecting paths
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003898 */
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003899 *prev_src_type = src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003900
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003901 } else if (src_reg_type != *prev_src_type &&
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003902 (src_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003903 *prev_src_type == PTR_TO_CTX)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003904 /* ABuser program is trying to use the same insn
3905 * dst_reg = *(u32*) (src_reg + off)
3906 * with different pointer types:
3907 * src_reg == ctx in one branch and
3908 * src_reg == stack|map in some other branch.
3909 * Reject it.
3910 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003911 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003912 return -EINVAL;
3913 }
3914
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003915 } else if (class == BPF_STX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003916 enum bpf_reg_type *prev_dst_type, dst_reg_type;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003917
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003918 if (BPF_MODE(insn->code) == BPF_XADD) {
Yonghong Song31fd8582017-06-13 15:52:13 -07003919 err = check_xadd(env, insn_idx, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003920 if (err)
3921 return err;
3922 insn_idx++;
3923 continue;
3924 }
3925
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003926 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003927 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003928 if (err)
3929 return err;
3930 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003931 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003932 if (err)
3933 return err;
3934
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003935 dst_reg_type = regs[insn->dst_reg].type;
3936
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003937 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07003938 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003939 BPF_SIZE(insn->code), BPF_WRITE,
3940 insn->src_reg);
3941 if (err)
3942 return err;
3943
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003944 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
3945
3946 if (*prev_dst_type == NOT_INIT) {
3947 *prev_dst_type = dst_reg_type;
3948 } else if (dst_reg_type != *prev_dst_type &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003949 (dst_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003950 *prev_dst_type == PTR_TO_CTX)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003951 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003952 return -EINVAL;
3953 }
3954
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003955 } else if (class == BPF_ST) {
3956 if (BPF_MODE(insn->code) != BPF_MEM ||
3957 insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003958 verbose(env, "BPF_ST uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003959 return -EINVAL;
3960 }
3961 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003962 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003963 if (err)
3964 return err;
3965
3966 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07003967 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003968 BPF_SIZE(insn->code), BPF_WRITE,
3969 -1);
3970 if (err)
3971 return err;
3972
3973 } else if (class == BPF_JMP) {
3974 u8 opcode = BPF_OP(insn->code);
3975
3976 if (opcode == BPF_CALL) {
3977 if (BPF_SRC(insn->code) != BPF_K ||
3978 insn->off != 0 ||
3979 insn->src_reg != BPF_REG_0 ||
3980 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003981 verbose(env, "BPF_CALL uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003982 return -EINVAL;
3983 }
3984
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07003985 err = check_call(env, insn->imm, insn_idx);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003986 if (err)
3987 return err;
3988
3989 } else if (opcode == BPF_JA) {
3990 if (BPF_SRC(insn->code) != BPF_K ||
3991 insn->imm != 0 ||
3992 insn->src_reg != BPF_REG_0 ||
3993 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003994 verbose(env, "BPF_JA uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003995 return -EINVAL;
3996 }
3997
3998 insn_idx += insn->off + 1;
3999 continue;
4000
4001 } else if (opcode == BPF_EXIT) {
4002 if (BPF_SRC(insn->code) != BPF_K ||
4003 insn->imm != 0 ||
4004 insn->src_reg != BPF_REG_0 ||
4005 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004006 verbose(env, "BPF_EXIT uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004007 return -EINVAL;
4008 }
4009
4010 /* eBPF calling convetion is such that R0 is used
4011 * to return the value from eBPF program.
4012 * Make sure that it's readable at this time
4013 * of bpf_exit, which means that program wrote
4014 * something into it earlier
4015 */
Edward Creedc503a82017-08-15 20:34:35 +01004016 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004017 if (err)
4018 return err;
4019
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004020 if (is_pointer_value(env, BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004021 verbose(env, "R0 leaks addr as return value\n");
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004022 return -EACCES;
4023 }
4024
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004025 err = check_return_code(env);
4026 if (err)
4027 return err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004028process_bpf_exit:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004029 err = pop_stack(env, &prev_insn_idx, &insn_idx);
4030 if (err < 0) {
4031 if (err != -ENOENT)
4032 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004033 break;
4034 } else {
4035 do_print_state = true;
4036 continue;
4037 }
4038 } else {
4039 err = check_cond_jmp_op(env, insn, &insn_idx);
4040 if (err)
4041 return err;
4042 }
4043 } else if (class == BPF_LD) {
4044 u8 mode = BPF_MODE(insn->code);
4045
4046 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004047 err = check_ld_abs(env, insn);
4048 if (err)
4049 return err;
4050
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004051 } else if (mode == BPF_IMM) {
4052 err = check_ld_imm(env, insn);
4053 if (err)
4054 return err;
4055
4056 insn_idx++;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004057 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004058 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004059 verbose(env, "invalid BPF_LD mode\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004060 return -EINVAL;
4061 }
4062 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004063 verbose(env, "unknown insn class %d\n", class);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004064 return -EINVAL;
4065 }
4066
4067 insn_idx++;
4068 }
4069
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004070 verbose(env, "processed %d insns, stack depth %d\n", insn_processed,
4071 env->prog->aux->stack_depth);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004072 return 0;
4073}
4074
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004075static int check_map_prealloc(struct bpf_map *map)
4076{
4077 return (map->map_type != BPF_MAP_TYPE_HASH &&
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07004078 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
4079 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004080 !(map->map_flags & BPF_F_NO_PREALLOC);
4081}
4082
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004083static int check_map_prog_compatibility(struct bpf_verifier_env *env,
4084 struct bpf_map *map,
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004085 struct bpf_prog *prog)
4086
4087{
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004088 /* Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use
4089 * preallocated hash maps, since doing memory allocation
4090 * in overflow_handler can crash depending on where nmi got
4091 * triggered.
4092 */
4093 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
4094 if (!check_map_prealloc(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004095 verbose(env, "perf_event programs can only use preallocated hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004096 return -EINVAL;
4097 }
4098 if (map->inner_map_meta &&
4099 !check_map_prealloc(map->inner_map_meta)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004100 verbose(env, "perf_event programs can only use preallocated inner hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004101 return -EINVAL;
4102 }
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004103 }
4104 return 0;
4105}
4106
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004107/* look for pseudo eBPF instructions that access map FDs and
4108 * replace them with actual map pointers
4109 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004110static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004111{
4112 struct bpf_insn *insn = env->prog->insnsi;
4113 int insn_cnt = env->prog->len;
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004114 int i, j, err;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004115
Daniel Borkmannf1f77142017-01-13 23:38:15 +01004116 err = bpf_prog_calc_tag(env->prog);
Daniel Borkmannaafe6ae2016-12-18 01:52:57 +01004117 if (err)
4118 return err;
4119
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004120 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004121 if (BPF_CLASS(insn->code) == BPF_LDX &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004122 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004123 verbose(env, "BPF_LDX uses reserved fields\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004124 return -EINVAL;
4125 }
4126
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004127 if (BPF_CLASS(insn->code) == BPF_STX &&
4128 ((BPF_MODE(insn->code) != BPF_MEM &&
4129 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004130 verbose(env, "BPF_STX uses reserved fields\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004131 return -EINVAL;
4132 }
4133
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004134 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
4135 struct bpf_map *map;
4136 struct fd f;
4137
4138 if (i == insn_cnt - 1 || insn[1].code != 0 ||
4139 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
4140 insn[1].off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004141 verbose(env, "invalid bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004142 return -EINVAL;
4143 }
4144
4145 if (insn->src_reg == 0)
4146 /* valid generic load 64-bit imm */
4147 goto next_insn;
4148
4149 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004150 verbose(env,
4151 "unrecognized bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004152 return -EINVAL;
4153 }
4154
4155 f = fdget(insn->imm);
Daniel Borkmannc2101292015-10-29 14:58:07 +01004156 map = __bpf_map_get(f);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004157 if (IS_ERR(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004158 verbose(env, "fd %d is not pointing to valid bpf_map\n",
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004159 insn->imm);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004160 return PTR_ERR(map);
4161 }
4162
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004163 err = check_map_prog_compatibility(env, map, env->prog);
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004164 if (err) {
4165 fdput(f);
4166 return err;
4167 }
4168
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004169 /* store map pointer inside BPF_LD_IMM64 instruction */
4170 insn[0].imm = (u32) (unsigned long) map;
4171 insn[1].imm = ((u64) (unsigned long) map) >> 32;
4172
4173 /* check whether we recorded this map already */
4174 for (j = 0; j < env->used_map_cnt; j++)
4175 if (env->used_maps[j] == map) {
4176 fdput(f);
4177 goto next_insn;
4178 }
4179
4180 if (env->used_map_cnt >= MAX_USED_MAPS) {
4181 fdput(f);
4182 return -E2BIG;
4183 }
4184
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004185 /* hold the map. If the program is rejected by verifier,
4186 * the map will be released by release_maps() or it
4187 * will be used by the valid program until it's unloaded
4188 * and all maps are released in free_bpf_prog_info()
4189 */
Alexei Starovoitov92117d82016-04-27 18:56:20 -07004190 map = bpf_map_inc(map, false);
4191 if (IS_ERR(map)) {
4192 fdput(f);
4193 return PTR_ERR(map);
4194 }
4195 env->used_maps[env->used_map_cnt++] = map;
4196
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004197 fdput(f);
4198next_insn:
4199 insn++;
4200 i++;
4201 }
4202 }
4203
4204 /* now all pseudo BPF_LD_IMM64 instructions load valid
4205 * 'struct bpf_map *' into a register instead of user map_fd.
4206 * These pointers will be used later by verifier to validate map access.
4207 */
4208 return 0;
4209}
4210
4211/* drop refcnt of maps used by the rejected program */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004212static void release_maps(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004213{
4214 int i;
4215
4216 for (i = 0; i < env->used_map_cnt; i++)
4217 bpf_map_put(env->used_maps[i]);
4218}
4219
4220/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004221static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004222{
4223 struct bpf_insn *insn = env->prog->insnsi;
4224 int insn_cnt = env->prog->len;
4225 int i;
4226
4227 for (i = 0; i < insn_cnt; i++, insn++)
4228 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
4229 insn->src_reg = 0;
4230}
4231
Alexei Starovoitov80419022017-03-15 18:26:41 -07004232/* single env->prog->insni[off] instruction was replaced with the range
4233 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
4234 * [0, off) and [off, end) to new locations, so the patched range stays zero
4235 */
4236static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
4237 u32 off, u32 cnt)
4238{
4239 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004240 int i;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004241
4242 if (cnt == 1)
4243 return 0;
4244 new_data = vzalloc(sizeof(struct bpf_insn_aux_data) * prog_len);
4245 if (!new_data)
4246 return -ENOMEM;
4247 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
4248 memcpy(new_data + off + cnt - 1, old_data + off,
4249 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004250 for (i = off; i < off + cnt - 1; i++)
4251 new_data[i].seen = true;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004252 env->insn_aux_data = new_data;
4253 vfree(old_data);
4254 return 0;
4255}
4256
4257static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
4258 const struct bpf_insn *patch, u32 len)
4259{
4260 struct bpf_prog *new_prog;
4261
4262 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
4263 if (!new_prog)
4264 return NULL;
4265 if (adjust_insn_aux_data(env, new_prog->len, off, len))
4266 return NULL;
4267 return new_prog;
4268}
4269
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004270/* The verifier does more data flow analysis than llvm and will not explore
4271 * branches that are dead at run time. Malicious programs can have dead code
4272 * too. Therefore replace all dead at-run-time code with nops.
4273 */
4274static void sanitize_dead_code(struct bpf_verifier_env *env)
4275{
4276 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
4277 struct bpf_insn nop = BPF_MOV64_REG(BPF_REG_0, BPF_REG_0);
4278 struct bpf_insn *insn = env->prog->insnsi;
4279 const int insn_cnt = env->prog->len;
4280 int i;
4281
4282 for (i = 0; i < insn_cnt; i++) {
4283 if (aux_data[i].seen)
4284 continue;
4285 memcpy(insn + i, &nop, sizeof(nop));
4286 }
4287}
4288
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004289/* convert load instructions that access fields of 'struct __sk_buff'
4290 * into sequence of instructions that access fields of 'struct sk_buff'
4291 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004292static int convert_ctx_accesses(struct bpf_verifier_env *env)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004293{
Jakub Kicinski00176a32017-10-16 16:40:54 -07004294 const struct bpf_verifier_ops *ops = env->ops;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004295 int i, cnt, size, ctx_field_size, delta = 0;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004296 const int insn_cnt = env->prog->len;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004297 struct bpf_insn insn_buf[16], *insn;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004298 struct bpf_prog *new_prog;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004299 enum bpf_access_type type;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004300 bool is_narrower_load;
4301 u32 target_size;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004302
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004303 if (ops->gen_prologue) {
4304 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
4305 env->prog);
4306 if (cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004307 verbose(env, "bpf verifier is misconfigured\n");
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004308 return -EINVAL;
4309 } else if (cnt) {
Alexei Starovoitov80419022017-03-15 18:26:41 -07004310 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004311 if (!new_prog)
4312 return -ENOMEM;
Alexei Starovoitov80419022017-03-15 18:26:41 -07004313
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004314 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004315 delta += cnt - 1;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004316 }
4317 }
4318
4319 if (!ops->convert_ctx_access)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004320 return 0;
4321
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004322 insn = env->prog->insnsi + delta;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02004323
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004324 for (i = 0; i < insn_cnt; i++, insn++) {
Daniel Borkmann62c79892017-01-12 11:51:33 +01004325 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
4326 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
4327 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07004328 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004329 type = BPF_READ;
Daniel Borkmann62c79892017-01-12 11:51:33 +01004330 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
4331 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
4332 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07004333 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004334 type = BPF_WRITE;
4335 else
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004336 continue;
4337
Alexei Starovoitov80419022017-03-15 18:26:41 -07004338 if (env->insn_aux_data[i + delta].ptr_type != PTR_TO_CTX)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004339 continue;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004340
Yonghong Song31fd8582017-06-13 15:52:13 -07004341 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004342 size = BPF_LDST_BYTES(insn);
Yonghong Song31fd8582017-06-13 15:52:13 -07004343
4344 /* If the read access is a narrower load of the field,
4345 * convert to a 4/8-byte load, to minimum program type specific
4346 * convert_ctx_access changes. If conversion is successful,
4347 * we will apply proper mask to the result.
4348 */
Daniel Borkmannf96da092017-07-02 02:13:27 +02004349 is_narrower_load = size < ctx_field_size;
Yonghong Song31fd8582017-06-13 15:52:13 -07004350 if (is_narrower_load) {
Daniel Borkmannf96da092017-07-02 02:13:27 +02004351 u32 off = insn->off;
4352 u8 size_code;
Yonghong Song31fd8582017-06-13 15:52:13 -07004353
Daniel Borkmannf96da092017-07-02 02:13:27 +02004354 if (type == BPF_WRITE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004355 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
Daniel Borkmannf96da092017-07-02 02:13:27 +02004356 return -EINVAL;
4357 }
4358
4359 size_code = BPF_H;
Yonghong Song31fd8582017-06-13 15:52:13 -07004360 if (ctx_field_size == 4)
4361 size_code = BPF_W;
4362 else if (ctx_field_size == 8)
4363 size_code = BPF_DW;
Daniel Borkmannf96da092017-07-02 02:13:27 +02004364
Yonghong Song31fd8582017-06-13 15:52:13 -07004365 insn->off = off & ~(ctx_field_size - 1);
4366 insn->code = BPF_LDX | BPF_MEM | size_code;
4367 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02004368
4369 target_size = 0;
4370 cnt = ops->convert_ctx_access(type, insn, insn_buf, env->prog,
4371 &target_size);
4372 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
4373 (ctx_field_size && !target_size)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004374 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004375 return -EINVAL;
4376 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02004377
4378 if (is_narrower_load && size < target_size) {
Yonghong Song31fd8582017-06-13 15:52:13 -07004379 if (ctx_field_size <= 4)
4380 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02004381 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07004382 else
4383 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02004384 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07004385 }
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004386
Alexei Starovoitov80419022017-03-15 18:26:41 -07004387 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004388 if (!new_prog)
4389 return -ENOMEM;
4390
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004391 delta += cnt - 1;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004392
4393 /* keep walking new program and skip insns we just inserted */
4394 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004395 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004396 }
4397
4398 return 0;
4399}
4400
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004401/* fixup insn->imm field of bpf_call instructions
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004402 * and inline eligible helpers as explicit sequence of BPF instructions
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004403 *
4404 * this function is called after eBPF program passed verification
4405 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004406static int fixup_bpf_calls(struct bpf_verifier_env *env)
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004407{
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004408 struct bpf_prog *prog = env->prog;
4409 struct bpf_insn *insn = prog->insnsi;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004410 const struct bpf_func_proto *fn;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004411 const int insn_cnt = prog->len;
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004412 struct bpf_insn insn_buf[16];
4413 struct bpf_prog *new_prog;
4414 struct bpf_map *map_ptr;
4415 int i, cnt, delta = 0;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004416
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004417 for (i = 0; i < insn_cnt; i++, insn++) {
4418 if (insn->code != (BPF_JMP | BPF_CALL))
4419 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004420
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004421 if (insn->imm == BPF_FUNC_get_route_realm)
4422 prog->dst_needed = 1;
4423 if (insn->imm == BPF_FUNC_get_prandom_u32)
4424 bpf_user_rnd_init_once();
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004425 if (insn->imm == BPF_FUNC_tail_call) {
David S. Miller7b9f6da2017-04-20 10:35:33 -04004426 /* If we tail call into other programs, we
4427 * cannot make any assumptions since they can
4428 * be replaced dynamically during runtime in
4429 * the program array.
4430 */
4431 prog->cb_access = 1;
Alexei Starovoitov80a58d02017-05-30 13:31:30 -07004432 env->prog->aux->stack_depth = MAX_BPF_STACK;
David S. Miller7b9f6da2017-04-20 10:35:33 -04004433
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004434 /* mark bpf_tail_call as different opcode to avoid
4435 * conditional branch in the interpeter for every normal
4436 * call and to prevent accidental JITing by JIT compiler
4437 * that doesn't support bpf_tail_call yet
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004438 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004439 insn->imm = 0;
Alexei Starovoitov71189fa2017-05-30 13:31:27 -07004440 insn->code = BPF_JMP | BPF_TAIL_CALL;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004441 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004442 }
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004443
Daniel Borkmann89c63072017-08-19 03:12:45 +02004444 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
4445 * handlers are currently limited to 64 bit only.
4446 */
4447 if (ebpf_jit_enabled() && BITS_PER_LONG == 64 &&
4448 insn->imm == BPF_FUNC_map_lookup_elem) {
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004449 map_ptr = env->insn_aux_data[i + delta].map_ptr;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07004450 if (map_ptr == BPF_MAP_PTR_POISON ||
4451 !map_ptr->ops->map_gen_lookup)
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004452 goto patch_call_imm;
4453
4454 cnt = map_ptr->ops->map_gen_lookup(map_ptr, insn_buf);
4455 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004456 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004457 return -EINVAL;
4458 }
4459
4460 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf,
4461 cnt);
4462 if (!new_prog)
4463 return -ENOMEM;
4464
4465 delta += cnt - 1;
4466
4467 /* keep walking new program and skip insns we just inserted */
4468 env->prog = prog = new_prog;
4469 insn = new_prog->insnsi + i + delta;
4470 continue;
4471 }
4472
Daniel Borkmann109980b2017-09-08 00:14:51 +02004473 if (insn->imm == BPF_FUNC_redirect_map) {
Daniel Borkmann7c300132017-09-20 00:44:21 +02004474 /* Note, we cannot use prog directly as imm as subsequent
4475 * rewrites would still change the prog pointer. The only
4476 * stable address we can use is aux, which also works with
4477 * prog clones during blinding.
4478 */
4479 u64 addr = (unsigned long)prog->aux;
Daniel Borkmann109980b2017-09-08 00:14:51 +02004480 struct bpf_insn r4_ld[] = {
4481 BPF_LD_IMM64(BPF_REG_4, addr),
4482 *insn,
4483 };
4484 cnt = ARRAY_SIZE(r4_ld);
4485
4486 new_prog = bpf_patch_insn_data(env, i + delta, r4_ld, cnt);
4487 if (!new_prog)
4488 return -ENOMEM;
4489
4490 delta += cnt - 1;
4491 env->prog = prog = new_prog;
4492 insn = new_prog->insnsi + i + delta;
4493 }
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07004494patch_call_imm:
Jakub Kicinski00176a32017-10-16 16:40:54 -07004495 fn = env->ops->get_func_proto(insn->imm);
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004496 /* all functions that have prototype and verifier allowed
4497 * programs to call them, must be real in-kernel functions
4498 */
4499 if (!fn->func) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004500 verbose(env,
4501 "kernel subsystem misconfigured func %s#%d\n",
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004502 func_id_name(insn->imm), insn->imm);
4503 return -EFAULT;
4504 }
4505 insn->imm = fn->func - __bpf_call_base;
4506 }
4507
4508 return 0;
4509}
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004510
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004511static void free_states(struct bpf_verifier_env *env)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004512{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004513 struct bpf_verifier_state_list *sl, *sln;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004514 int i;
4515
4516 if (!env->explored_states)
4517 return;
4518
4519 for (i = 0; i < env->prog->len; i++) {
4520 sl = env->explored_states[i];
4521
4522 if (sl)
4523 while (sl != STATE_LIST_MARK) {
4524 sln = sl->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07004525 free_verifier_state(&sl->state, false);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004526 kfree(sl);
4527 sl = sln;
4528 }
4529 }
4530
4531 kfree(env->explored_states);
4532}
4533
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004534int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004535{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004536 struct bpf_verifier_env *env;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004537 struct bpf_verifer_log *log;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004538 int ret = -EINVAL;
4539
Arnd Bergmanneba0c922017-11-02 12:05:52 +01004540 /* no program is valid */
4541 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
4542 return -EINVAL;
4543
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004544 /* 'struct bpf_verifier_env' can be global, but since it's not small,
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004545 * allocate/free it every time bpf_check() is called
4546 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004547 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004548 if (!env)
4549 return -ENOMEM;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004550 log = &env->log;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004551
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004552 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
4553 (*prog)->len);
4554 ret = -ENOMEM;
4555 if (!env->insn_aux_data)
4556 goto err_free_env;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004557 env->prog = *prog;
Jakub Kicinski00176a32017-10-16 16:40:54 -07004558 env->ops = bpf_verifier_ops[env->prog->type];
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004559
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004560 /* grab the mutex to protect few globals used by verifier */
4561 mutex_lock(&bpf_verifier_lock);
4562
4563 if (attr->log_level || attr->log_buf || attr->log_size) {
4564 /* user requested verbose verifier output
4565 * and supplied buffer to store the verification trace
4566 */
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07004567 log->level = attr->log_level;
4568 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
4569 log->len_total = attr->log_size;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004570
4571 ret = -EINVAL;
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07004572 /* log attributes have to be sane */
4573 if (log->len_total < 128 || log->len_total > UINT_MAX >> 8 ||
4574 !log->level || !log->ubuf)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004575 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004576 }
Daniel Borkmann1ad2f582017-05-25 01:05:05 +02004577
4578 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
4579 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
David S. Millere07b98d2017-05-10 11:38:07 -07004580 env->strict_alignment = true;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004581
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07004582 if (env->prog->aux->offload) {
4583 ret = bpf_prog_offload_verifier_prep(env);
4584 if (ret)
4585 goto err_unlock;
4586 }
4587
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004588 ret = replace_map_fd_with_map_ptr(env);
4589 if (ret < 0)
4590 goto skip_full_check;
4591
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004592 env->explored_states = kcalloc(env->prog->len,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004593 sizeof(struct bpf_verifier_state_list *),
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004594 GFP_USER);
4595 ret = -ENOMEM;
4596 if (!env->explored_states)
4597 goto skip_full_check;
4598
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004599 ret = check_cfg(env);
4600 if (ret < 0)
4601 goto skip_full_check;
4602
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004603 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
4604
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004605 ret = do_check(env);
Craig Gallek8c01c4f2017-11-02 11:18:01 -04004606 if (env->cur_state) {
4607 free_verifier_state(env->cur_state, true);
4608 env->cur_state = NULL;
4609 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004610
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004611skip_full_check:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004612 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004613 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004614
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004615 if (ret == 0)
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004616 sanitize_dead_code(env);
4617
4618 if (ret == 0)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004619 /* program is valid, convert *(u32*)(ctx + off) accesses */
4620 ret = convert_ctx_accesses(env);
4621
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004622 if (ret == 0)
Alexei Starovoitov79741b32017-03-15 18:26:40 -07004623 ret = fixup_bpf_calls(env);
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07004624
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004625 if (log->level && bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004626 ret = -ENOSPC;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004627 if (log->level && !log->ubuf) {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004628 ret = -EFAULT;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004629 goto err_release_maps;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004630 }
4631
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004632 if (ret == 0 && env->used_map_cnt) {
4633 /* if program passed verifier, update used_maps in bpf_prog_info */
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004634 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
4635 sizeof(env->used_maps[0]),
4636 GFP_KERNEL);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004637
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004638 if (!env->prog->aux->used_maps) {
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004639 ret = -ENOMEM;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004640 goto err_release_maps;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004641 }
4642
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004643 memcpy(env->prog->aux->used_maps, env->used_maps,
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004644 sizeof(env->used_maps[0]) * env->used_map_cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004645 env->prog->aux->used_map_cnt = env->used_map_cnt;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004646
4647 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
4648 * bpf_ld_imm64 instructions
4649 */
4650 convert_pseudo_ld_imm64(env);
4651 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004652
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07004653err_release_maps:
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004654 if (!env->prog->aux->used_maps)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004655 /* if we didn't copy map pointers into bpf_prog_info, release
4656 * them now. Otherwise free_bpf_prog_info() will release them.
4657 */
4658 release_maps(env);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004659 *prog = env->prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004660err_unlock:
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07004661 mutex_unlock(&bpf_verifier_lock);
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004662 vfree(env->insn_aux_data);
4663err_free_env:
4664 kfree(env);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07004665 return ret;
4666}