blob: 5e6202e62265fd94f2d4f82ff89e0264011dffc2 [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002 * Copyright (c) 2016 Facebook
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +010017#include <linux/bpf_verifier.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070018#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
Thomas Grafebb676d2016-10-27 11:23:51 +020022#include <linux/stringify.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070023
24/* bpf_check() is a static code analyzer that walks eBPF program
25 * instruction by instruction and updates register/stack state.
26 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
27 *
28 * The first pass is depth-first-search to check that the program is a DAG.
29 * It rejects the following programs:
30 * - larger than BPF_MAXINSNS insns
31 * - if loop is present (detected via back-edge)
32 * - unreachable insns exist (shouldn't be a forest. program = one function)
33 * - out of bounds or malformed jumps
34 * The second pass is all possible path descent from the 1st insn.
35 * Since it's analyzing all pathes through the program, the length of the
Gary Lineba38a92017-03-01 16:25:51 +080036 * analysis is limited to 64k insn, which may be hit even if total number of
Alexei Starovoitov51580e72014-09-26 00:17:02 -070037 * insn is less then 4K, but there are too many branches that change stack/regs.
38 * Number of 'branches to be analyzed' is limited to 1k
39 *
40 * On entry to each instruction, each register has a type, and the instruction
41 * changes the types of the registers depending on instruction semantics.
42 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
43 * copied to R1.
44 *
45 * All registers are 64-bit.
46 * R0 - return register
47 * R1-R5 argument passing registers
48 * R6-R9 callee saved registers
49 * R10 - frame pointer read-only
50 *
51 * At the start of BPF program the register R1 contains a pointer to bpf_context
52 * and has type PTR_TO_CTX.
53 *
54 * Verifier tracks arithmetic operations on pointers in case:
55 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
56 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
57 * 1st insn copies R10 (which has FRAME_PTR) type into R1
58 * and 2nd arithmetic instruction is pattern matched to recognize
59 * that it wants to construct a pointer to some element within stack.
60 * So after 2nd insn, the register R1 has type PTR_TO_STACK
61 * (and -20 constant is saved for further stack bounds checking).
62 * Meaning that this reg is a pointer to stack plus known immediate constant.
63 *
64 * Most of the time the registers have UNKNOWN_VALUE type, which
65 * means the register has some value, but it's not a valid pointer.
66 * (like pointer plus pointer becomes UNKNOWN_VALUE type)
67 *
68 * When verifier sees load or store instructions the type of base register
69 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, FRAME_PTR. These are three pointer
70 * types recognized by check_mem_access() function.
71 *
72 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
73 * and the range of [ptr, ptr + map's value_size) is accessible.
74 *
75 * registers used to pass values to function calls are checked against
76 * function argument constraints.
77 *
78 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
79 * It means that the register type passed to this function must be
80 * PTR_TO_STACK and it will be used inside the function as
81 * 'pointer to map element key'
82 *
83 * For example the argument constraints for bpf_map_lookup_elem():
84 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
85 * .arg1_type = ARG_CONST_MAP_PTR,
86 * .arg2_type = ARG_PTR_TO_MAP_KEY,
87 *
88 * ret_type says that this function returns 'pointer to map elem value or null'
89 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
90 * 2nd argument should be a pointer to stack, which will be used inside
91 * the helper function as a pointer to map element key.
92 *
93 * On the kernel side the helper function looks like:
94 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
95 * {
96 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
97 * void *key = (void *) (unsigned long) r2;
98 * void *value;
99 *
100 * here kernel can access 'key' and 'map' pointers safely, knowing that
101 * [key, key + map->key_size) bytes are valid and were initialized on
102 * the stack of eBPF program.
103 * }
104 *
105 * Corresponding eBPF program may look like:
106 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
107 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
108 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
109 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
110 * here verifier looks at prototype of map_lookup_elem() and sees:
111 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
112 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
113 *
114 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
115 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
116 * and were initialized prior to this call.
117 * If it's ok, then verifier allows this BPF_CALL insn and looks at
118 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
119 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
120 * returns ether pointer to map value or NULL.
121 *
122 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
123 * insn, the register holding that pointer in the true branch changes state to
124 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
125 * branch. See check_cond_jmp_op().
126 *
127 * After the call R0 is set to return type of the function and registers R1-R5
128 * are set to NOT_INIT to indicate that they are no longer readable.
129 */
130
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700131/* verifier_state + insn_idx are pushed to stack when branch is encountered */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100132struct bpf_verifier_stack_elem {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700133 /* verifer state is 'st'
134 * before processing instruction 'insn_idx'
135 * and after processing instruction 'prev_insn_idx'
136 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100137 struct bpf_verifier_state st;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700138 int insn_idx;
139 int prev_insn_idx;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100140 struct bpf_verifier_stack_elem *next;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700141};
142
Daniel Borkmann07016152016-04-05 22:33:17 +0200143#define BPF_COMPLEXITY_LIMIT_INSNS 65536
144#define BPF_COMPLEXITY_LIMIT_STACK 1024
145
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200146struct bpf_call_arg_meta {
147 struct bpf_map *map_ptr;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200148 bool raw_mode;
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200149 bool pkt_access;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200150 int regno;
151 int access_size;
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200152};
153
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700154/* verbose verifier prints what it's seeing
155 * bpf_check() is called under lock, so no race to access these global vars
156 */
157static u32 log_level, log_size, log_len;
158static char *log_buf;
159
160static DEFINE_MUTEX(bpf_verifier_lock);
161
162/* log_level controls verbosity level of eBPF verifier.
163 * verbose() is used to dump the verification trace to the log, so the user
164 * can figure out what's wrong with the program
165 */
Daniel Borkmann1d056d92015-11-03 11:39:20 +0100166static __printf(1, 2) void verbose(const char *fmt, ...)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700167{
168 va_list args;
169
170 if (log_level == 0 || log_len >= log_size - 1)
171 return;
172
173 va_start(args, fmt);
174 log_len += vscnprintf(log_buf + log_len, log_size - log_len, fmt, args);
175 va_end(args);
176}
177
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700178/* string representation of 'enum bpf_reg_type' */
179static const char * const reg_type_str[] = {
180 [NOT_INIT] = "?",
181 [UNKNOWN_VALUE] = "inv",
182 [PTR_TO_CTX] = "ctx",
183 [CONST_PTR_TO_MAP] = "map_ptr",
184 [PTR_TO_MAP_VALUE] = "map_value",
185 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
Josef Bacik48461132016-09-28 10:54:32 -0400186 [PTR_TO_MAP_VALUE_ADJ] = "map_value_adj",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700187 [FRAME_PTR] = "fp",
188 [PTR_TO_STACK] = "fp",
189 [CONST_IMM] = "imm",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700190 [PTR_TO_PACKET] = "pkt",
191 [PTR_TO_PACKET_END] = "pkt_end",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700192};
193
Thomas Grafebb676d2016-10-27 11:23:51 +0200194#define __BPF_FUNC_STR_FN(x) [BPF_FUNC_ ## x] = __stringify(bpf_ ## x)
195static const char * const func_id_str[] = {
196 __BPF_FUNC_MAPPER(__BPF_FUNC_STR_FN)
197};
198#undef __BPF_FUNC_STR_FN
199
200static const char *func_id_name(int id)
201{
202 BUILD_BUG_ON(ARRAY_SIZE(func_id_str) != __BPF_FUNC_MAX_ID);
203
204 if (id >= 0 && id < __BPF_FUNC_MAX_ID && func_id_str[id])
205 return func_id_str[id];
206 else
207 return "unknown";
208}
209
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100210static void print_verifier_state(struct bpf_verifier_state *state)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700211{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100212 struct bpf_reg_state *reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700213 enum bpf_reg_type t;
214 int i;
215
216 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700217 reg = &state->regs[i];
218 t = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700219 if (t == NOT_INIT)
220 continue;
221 verbose(" R%d=%s", i, reg_type_str[t]);
222 if (t == CONST_IMM || t == PTR_TO_STACK)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700223 verbose("%lld", reg->imm);
224 else if (t == PTR_TO_PACKET)
225 verbose("(id=%d,off=%d,r=%d)",
226 reg->id, reg->off, reg->range);
227 else if (t == UNKNOWN_VALUE && reg->imm)
228 verbose("%lld", reg->imm);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700229 else if (t == CONST_PTR_TO_MAP || t == PTR_TO_MAP_VALUE ||
Josef Bacik48461132016-09-28 10:54:32 -0400230 t == PTR_TO_MAP_VALUE_OR_NULL ||
231 t == PTR_TO_MAP_VALUE_ADJ)
Thomas Graf57a09bf2016-10-18 19:51:19 +0200232 verbose("(ks=%d,vs=%d,id=%u)",
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700233 reg->map_ptr->key_size,
Thomas Graf57a09bf2016-10-18 19:51:19 +0200234 reg->map_ptr->value_size,
235 reg->id);
Josef Bacik48461132016-09-28 10:54:32 -0400236 if (reg->min_value != BPF_REGISTER_MIN_RANGE)
Josef Bacikf23cc642016-11-14 15:45:36 -0500237 verbose(",min_value=%lld",
238 (long long)reg->min_value);
Josef Bacik48461132016-09-28 10:54:32 -0400239 if (reg->max_value != BPF_REGISTER_MAX_RANGE)
240 verbose(",max_value=%llu",
241 (unsigned long long)reg->max_value);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700242 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700243 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700244 if (state->stack_slot_type[i] == STACK_SPILL)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700245 verbose(" fp%d=%s", -MAX_BPF_STACK + i,
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700246 reg_type_str[state->spilled_regs[i / BPF_REG_SIZE].type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700247 }
248 verbose("\n");
249}
250
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700251static const char *const bpf_class_string[] = {
252 [BPF_LD] = "ld",
253 [BPF_LDX] = "ldx",
254 [BPF_ST] = "st",
255 [BPF_STX] = "stx",
256 [BPF_ALU] = "alu",
257 [BPF_JMP] = "jmp",
258 [BPF_RET] = "BUG",
259 [BPF_ALU64] = "alu64",
260};
261
Alexei Starovoitov687f0712015-09-08 13:40:01 -0700262static const char *const bpf_alu_string[16] = {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700263 [BPF_ADD >> 4] = "+=",
264 [BPF_SUB >> 4] = "-=",
265 [BPF_MUL >> 4] = "*=",
266 [BPF_DIV >> 4] = "/=",
267 [BPF_OR >> 4] = "|=",
268 [BPF_AND >> 4] = "&=",
269 [BPF_LSH >> 4] = "<<=",
270 [BPF_RSH >> 4] = ">>=",
271 [BPF_NEG >> 4] = "neg",
272 [BPF_MOD >> 4] = "%=",
273 [BPF_XOR >> 4] = "^=",
274 [BPF_MOV >> 4] = "=",
275 [BPF_ARSH >> 4] = "s>>=",
276 [BPF_END >> 4] = "endian",
277};
278
279static const char *const bpf_ldst_string[] = {
280 [BPF_W >> 3] = "u32",
281 [BPF_H >> 3] = "u16",
282 [BPF_B >> 3] = "u8",
283 [BPF_DW >> 3] = "u64",
284};
285
Alexei Starovoitov687f0712015-09-08 13:40:01 -0700286static const char *const bpf_jmp_string[16] = {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700287 [BPF_JA >> 4] = "jmp",
288 [BPF_JEQ >> 4] = "==",
289 [BPF_JGT >> 4] = ">",
290 [BPF_JGE >> 4] = ">=",
291 [BPF_JSET >> 4] = "&",
292 [BPF_JNE >> 4] = "!=",
293 [BPF_JSGT >> 4] = "s>",
294 [BPF_JSGE >> 4] = "s>=",
295 [BPF_CALL >> 4] = "call",
296 [BPF_EXIT >> 4] = "exit",
297};
298
299static void print_bpf_insn(struct bpf_insn *insn)
300{
301 u8 class = BPF_CLASS(insn->code);
302
303 if (class == BPF_ALU || class == BPF_ALU64) {
304 if (BPF_SRC(insn->code) == BPF_X)
305 verbose("(%02x) %sr%d %s %sr%d\n",
306 insn->code, class == BPF_ALU ? "(u32) " : "",
307 insn->dst_reg,
308 bpf_alu_string[BPF_OP(insn->code) >> 4],
309 class == BPF_ALU ? "(u32) " : "",
310 insn->src_reg);
311 else
312 verbose("(%02x) %sr%d %s %s%d\n",
313 insn->code, class == BPF_ALU ? "(u32) " : "",
314 insn->dst_reg,
315 bpf_alu_string[BPF_OP(insn->code) >> 4],
316 class == BPF_ALU ? "(u32) " : "",
317 insn->imm);
318 } else if (class == BPF_STX) {
319 if (BPF_MODE(insn->code) == BPF_MEM)
320 verbose("(%02x) *(%s *)(r%d %+d) = r%d\n",
321 insn->code,
322 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
323 insn->dst_reg,
324 insn->off, insn->src_reg);
325 else if (BPF_MODE(insn->code) == BPF_XADD)
326 verbose("(%02x) lock *(%s *)(r%d %+d) += r%d\n",
327 insn->code,
328 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
329 insn->dst_reg, insn->off,
330 insn->src_reg);
331 else
332 verbose("BUG_%02x\n", insn->code);
333 } else if (class == BPF_ST) {
334 if (BPF_MODE(insn->code) != BPF_MEM) {
335 verbose("BUG_st_%02x\n", insn->code);
336 return;
337 }
338 verbose("(%02x) *(%s *)(r%d %+d) = %d\n",
339 insn->code,
340 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
341 insn->dst_reg,
342 insn->off, insn->imm);
343 } else if (class == BPF_LDX) {
344 if (BPF_MODE(insn->code) != BPF_MEM) {
345 verbose("BUG_ldx_%02x\n", insn->code);
346 return;
347 }
348 verbose("(%02x) r%d = *(%s *)(r%d %+d)\n",
349 insn->code, insn->dst_reg,
350 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
351 insn->src_reg, insn->off);
352 } else if (class == BPF_LD) {
353 if (BPF_MODE(insn->code) == BPF_ABS) {
354 verbose("(%02x) r0 = *(%s *)skb[%d]\n",
355 insn->code,
356 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
357 insn->imm);
358 } else if (BPF_MODE(insn->code) == BPF_IND) {
359 verbose("(%02x) r0 = *(%s *)skb[r%d + %d]\n",
360 insn->code,
361 bpf_ldst_string[BPF_SIZE(insn->code) >> 3],
362 insn->src_reg, insn->imm);
363 } else if (BPF_MODE(insn->code) == BPF_IMM) {
364 verbose("(%02x) r%d = 0x%x\n",
365 insn->code, insn->dst_reg, insn->imm);
366 } else {
367 verbose("BUG_ld_%02x\n", insn->code);
368 return;
369 }
370 } else if (class == BPF_JMP) {
371 u8 opcode = BPF_OP(insn->code);
372
373 if (opcode == BPF_CALL) {
Thomas Grafebb676d2016-10-27 11:23:51 +0200374 verbose("(%02x) call %s#%d\n", insn->code,
375 func_id_name(insn->imm), insn->imm);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700376 } else if (insn->code == (BPF_JMP | BPF_JA)) {
377 verbose("(%02x) goto pc%+d\n",
378 insn->code, insn->off);
379 } else if (insn->code == (BPF_JMP | BPF_EXIT)) {
380 verbose("(%02x) exit\n", insn->code);
381 } else if (BPF_SRC(insn->code) == BPF_X) {
382 verbose("(%02x) if r%d %s r%d goto pc%+d\n",
383 insn->code, insn->dst_reg,
384 bpf_jmp_string[BPF_OP(insn->code) >> 4],
385 insn->src_reg, insn->off);
386 } else {
387 verbose("(%02x) if r%d %s 0x%x goto pc%+d\n",
388 insn->code, insn->dst_reg,
389 bpf_jmp_string[BPF_OP(insn->code) >> 4],
390 insn->imm, insn->off);
391 }
392 } else {
393 verbose("(%02x) %s\n", insn->code, bpf_class_string[class]);
394 }
395}
396
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100397static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700398{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100399 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700400 int insn_idx;
401
402 if (env->head == NULL)
403 return -1;
404
405 memcpy(&env->cur_state, &env->head->st, sizeof(env->cur_state));
406 insn_idx = env->head->insn_idx;
407 if (prev_insn_idx)
408 *prev_insn_idx = env->head->prev_insn_idx;
409 elem = env->head->next;
410 kfree(env->head);
411 env->head = elem;
412 env->stack_size--;
413 return insn_idx;
414}
415
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100416static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
417 int insn_idx, int prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700418{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100419 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700420
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100421 elem = kmalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700422 if (!elem)
423 goto err;
424
425 memcpy(&elem->st, &env->cur_state, sizeof(env->cur_state));
426 elem->insn_idx = insn_idx;
427 elem->prev_insn_idx = prev_insn_idx;
428 elem->next = env->head;
429 env->head = elem;
430 env->stack_size++;
Daniel Borkmann07016152016-04-05 22:33:17 +0200431 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700432 verbose("BPF program is too complex\n");
433 goto err;
434 }
435 return &elem->st;
436err:
437 /* pop all elements and return */
438 while (pop_stack(env, NULL) >= 0);
439 return NULL;
440}
441
442#define CALLER_SAVED_REGS 6
443static const int caller_saved[CALLER_SAVED_REGS] = {
444 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
445};
446
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100447static void init_reg_state(struct bpf_reg_state *regs)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700448{
449 int i;
450
451 for (i = 0; i < MAX_BPF_REG; i++) {
452 regs[i].type = NOT_INIT;
453 regs[i].imm = 0;
Josef Bacik48461132016-09-28 10:54:32 -0400454 regs[i].min_value = BPF_REGISTER_MIN_RANGE;
455 regs[i].max_value = BPF_REGISTER_MAX_RANGE;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700456 }
457
458 /* frame pointer */
459 regs[BPF_REG_FP].type = FRAME_PTR;
460
461 /* 1st arg to a function */
462 regs[BPF_REG_1].type = PTR_TO_CTX;
463}
464
Daniel Borkmann6760bf22016-12-18 01:52:59 +0100465static void __mark_reg_unknown_value(struct bpf_reg_state *regs, u32 regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700466{
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700467 regs[regno].type = UNKNOWN_VALUE;
Thomas Graf57a09bf2016-10-18 19:51:19 +0200468 regs[regno].id = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700469 regs[regno].imm = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700470}
471
Daniel Borkmann6760bf22016-12-18 01:52:59 +0100472static void mark_reg_unknown_value(struct bpf_reg_state *regs, u32 regno)
473{
474 BUG_ON(regno >= MAX_BPF_REG);
475 __mark_reg_unknown_value(regs, regno);
476}
477
Josef Bacik48461132016-09-28 10:54:32 -0400478static void reset_reg_range_values(struct bpf_reg_state *regs, u32 regno)
479{
480 regs[regno].min_value = BPF_REGISTER_MIN_RANGE;
481 regs[regno].max_value = BPF_REGISTER_MAX_RANGE;
482}
483
Gianluca Borellof0318d02017-01-09 10:19:48 -0800484static void mark_reg_unknown_value_and_range(struct bpf_reg_state *regs,
485 u32 regno)
486{
487 mark_reg_unknown_value(regs, regno);
488 reset_reg_range_values(regs, regno);
489}
490
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700491enum reg_arg_type {
492 SRC_OP, /* register is used as source operand */
493 DST_OP, /* register is used as destination operand */
494 DST_OP_NO_MARK /* same as above, check only, don't mark */
495};
496
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100497static int check_reg_arg(struct bpf_reg_state *regs, u32 regno,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700498 enum reg_arg_type t)
499{
500 if (regno >= MAX_BPF_REG) {
501 verbose("R%d is invalid\n", regno);
502 return -EINVAL;
503 }
504
505 if (t == SRC_OP) {
506 /* check whether register used as source operand can be read */
507 if (regs[regno].type == NOT_INIT) {
508 verbose("R%d !read_ok\n", regno);
509 return -EACCES;
510 }
511 } else {
512 /* check whether register used as dest operand can be written to */
513 if (regno == BPF_REG_FP) {
514 verbose("frame pointer is read only\n");
515 return -EACCES;
516 }
517 if (t == DST_OP)
518 mark_reg_unknown_value(regs, regno);
519 }
520 return 0;
521}
522
523static int bpf_size_to_bytes(int bpf_size)
524{
525 if (bpf_size == BPF_W)
526 return 4;
527 else if (bpf_size == BPF_H)
528 return 2;
529 else if (bpf_size == BPF_B)
530 return 1;
531 else if (bpf_size == BPF_DW)
532 return 8;
533 else
534 return -EINVAL;
535}
536
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700537static bool is_spillable_regtype(enum bpf_reg_type type)
538{
539 switch (type) {
540 case PTR_TO_MAP_VALUE:
541 case PTR_TO_MAP_VALUE_OR_NULL:
Gianluca Borellof0318d02017-01-09 10:19:48 -0800542 case PTR_TO_MAP_VALUE_ADJ:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700543 case PTR_TO_STACK:
544 case PTR_TO_CTX:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700545 case PTR_TO_PACKET:
546 case PTR_TO_PACKET_END:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700547 case FRAME_PTR:
548 case CONST_PTR_TO_MAP:
549 return true;
550 default:
551 return false;
552 }
553}
554
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700555/* check_stack_read/write functions track spill/fill of registers,
556 * stack boundary and alignment are checked in check_mem_access()
557 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100558static int check_stack_write(struct bpf_verifier_state *state, int off,
559 int size, int value_regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700560{
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700561 int i;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700562 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
563 * so it's aligned access and [off, off + size) are within stack limits
564 */
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700565
566 if (value_regno >= 0 &&
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700567 is_spillable_regtype(state->regs[value_regno].type)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700568
569 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700570 if (size != BPF_REG_SIZE) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700571 verbose("invalid size of register spill\n");
572 return -EACCES;
573 }
574
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700575 /* save register state */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700576 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE] =
577 state->regs[value_regno];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700578
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700579 for (i = 0; i < BPF_REG_SIZE; i++)
580 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_SPILL;
581 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700582 /* regular write of data into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700583 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE] =
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100584 (struct bpf_reg_state) {};
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700585
586 for (i = 0; i < size; i++)
587 state->stack_slot_type[MAX_BPF_STACK + off + i] = STACK_MISC;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700588 }
589 return 0;
590}
591
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100592static int check_stack_read(struct bpf_verifier_state *state, int off, int size,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700593 int value_regno)
594{
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700595 u8 *slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700596 int i;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700597
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700598 slot_type = &state->stack_slot_type[MAX_BPF_STACK + off];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700599
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700600 if (slot_type[0] == STACK_SPILL) {
601 if (size != BPF_REG_SIZE) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700602 verbose("invalid size of register spill\n");
603 return -EACCES;
604 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700605 for (i = 1; i < BPF_REG_SIZE; i++) {
606 if (slot_type[i] != STACK_SPILL) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700607 verbose("corrupted spill memory\n");
608 return -EACCES;
609 }
610 }
611
612 if (value_regno >= 0)
613 /* restore register state from stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700614 state->regs[value_regno] =
615 state->spilled_regs[(MAX_BPF_STACK + off) / BPF_REG_SIZE];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700616 return 0;
617 } else {
618 for (i = 0; i < size; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700619 if (slot_type[i] != STACK_MISC) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700620 verbose("invalid read from stack off %d+%d size %d\n",
621 off, i, size);
622 return -EACCES;
623 }
624 }
625 if (value_regno >= 0)
626 /* have read misc data from the stack */
Gianluca Borellof0318d02017-01-09 10:19:48 -0800627 mark_reg_unknown_value_and_range(state->regs,
628 value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700629 return 0;
630 }
631}
632
633/* check read/write into map element returned by bpf_map_lookup_elem() */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100634static int check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700635 int size)
636{
637 struct bpf_map *map = env->cur_state.regs[regno].map_ptr;
638
Gianluca Borello57225692017-01-09 10:19:47 -0800639 if (off < 0 || size <= 0 || off + size > map->value_size) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700640 verbose("invalid access to map value, value_size=%d off=%d size=%d\n",
641 map->value_size, off, size);
642 return -EACCES;
643 }
644 return 0;
645}
646
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800647/* check read/write into an adjusted map element */
648static int check_map_access_adj(struct bpf_verifier_env *env, u32 regno,
649 int off, int size)
650{
651 struct bpf_verifier_state *state = &env->cur_state;
652 struct bpf_reg_state *reg = &state->regs[regno];
653 int err;
654
655 /* We adjusted the register to this map value, so we
656 * need to change off and size to min_value and max_value
657 * respectively to make sure our theoretical access will be
658 * safe.
659 */
660 if (log_level)
661 print_verifier_state(state);
662 env->varlen_map_value_access = true;
663 /* The minimum value is only important with signed
664 * comparisons where we can't assume the floor of a
665 * value is 0. If we are using signed variables for our
666 * index'es we need to make sure that whatever we use
667 * will have a set floor within our range.
668 */
669 if (reg->min_value < 0) {
670 verbose("R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
671 regno);
672 return -EACCES;
673 }
674 err = check_map_access(env, regno, reg->min_value + off, size);
675 if (err) {
676 verbose("R%d min value is outside of the array range\n",
677 regno);
678 return err;
679 }
680
681 /* If we haven't set a max value then we need to bail
682 * since we can't be sure we won't do bad things.
683 */
684 if (reg->max_value == BPF_REGISTER_MAX_RANGE) {
685 verbose("R%d unbounded memory access, make sure to bounds check any array access into a map\n",
686 regno);
687 return -EACCES;
688 }
689 return check_map_access(env, regno, reg->max_value + off, size);
690}
691
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700692#define MAX_PACKET_OFF 0xffff
693
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100694static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100695 const struct bpf_call_arg_meta *meta,
696 enum bpf_access_type t)
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700697{
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200698 switch (env->prog->type) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100699 case BPF_PROG_TYPE_LWT_IN:
700 case BPF_PROG_TYPE_LWT_OUT:
701 /* dst_input() and dst_output() can't write for now */
702 if (t == BPF_WRITE)
703 return false;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +0100704 /* fallthrough */
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200705 case BPF_PROG_TYPE_SCHED_CLS:
706 case BPF_PROG_TYPE_SCHED_ACT:
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700707 case BPF_PROG_TYPE_XDP:
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100708 case BPF_PROG_TYPE_LWT_XMIT:
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200709 if (meta)
710 return meta->pkt_access;
711
712 env->seen_direct_write = true;
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700713 return true;
714 default:
715 return false;
716 }
717}
718
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100719static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700720 int size)
721{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100722 struct bpf_reg_state *regs = env->cur_state.regs;
723 struct bpf_reg_state *reg = &regs[regno];
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700724
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -0700725 off += reg->off;
Daniel Borkmannb399cf62016-09-20 00:26:12 +0200726 if (off < 0 || size <= 0 || off + size > reg->range) {
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -0700727 verbose("invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
728 off, size, regno, reg->id, reg->off, reg->range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700729 return -EACCES;
730 }
731 return 0;
732}
733
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700734/* check access to 'struct bpf_context' fields */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100735static int check_ctx_access(struct bpf_verifier_env *env, int off, int size,
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700736 enum bpf_access_type t, enum bpf_reg_type *reg_type)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700737{
Jakub Kicinski13a27df2016-09-21 11:43:58 +0100738 /* for analyzer ctx accesses are already validated and converted */
739 if (env->analyzer_ops)
740 return 0;
741
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700742 if (env->prog->aux->ops->is_valid_access &&
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700743 env->prog->aux->ops->is_valid_access(off, size, t, reg_type)) {
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700744 /* remember the offset of last byte accessed in ctx */
745 if (env->prog->aux->max_ctx_offset < off + size)
746 env->prog->aux->max_ctx_offset = off + size;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700747 return 0;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -0700748 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700749
750 verbose("invalid bpf_context access off=%d size=%d\n", off, size);
751 return -EACCES;
752}
753
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100754static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700755{
756 if (env->allow_ptr_leaks)
757 return false;
758
759 switch (env->cur_state.regs[regno].type) {
760 case UNKNOWN_VALUE:
761 case CONST_IMM:
762 return false;
763 default:
764 return true;
765 }
766}
767
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100768static int check_ptr_alignment(struct bpf_verifier_env *env,
769 struct bpf_reg_state *reg, int off, int size)
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700770{
Josef Bacik48461132016-09-28 10:54:32 -0400771 if (reg->type != PTR_TO_PACKET && reg->type != PTR_TO_MAP_VALUE_ADJ) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700772 if (off % size != 0) {
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100773 verbose("misaligned access off %d size %d\n",
774 off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700775 return -EACCES;
776 } else {
777 return 0;
778 }
779 }
780
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700781 if (IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
782 /* misaligned access to packet is ok on x86,arm,arm64 */
783 return 0;
784
785 if (reg->id && size != 1) {
786 verbose("Unknown packet alignment. Only byte-sized access allowed\n");
787 return -EACCES;
788 }
789
790 /* skb->data is NET_IP_ALIGN-ed */
Josef Bacik48461132016-09-28 10:54:32 -0400791 if (reg->type == PTR_TO_PACKET &&
792 (NET_IP_ALIGN + reg->off + off) % size != 0) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700793 verbose("misaligned packet access off %d+%d+%d size %d\n",
794 NET_IP_ALIGN, reg->off, off, size);
795 return -EACCES;
796 }
797 return 0;
798}
799
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700800/* check whether memory at (regno + off) is accessible for t = (read | write)
801 * if t==write, value_regno is a register which value is stored into memory
802 * if t==read, value_regno is a register which will receive the value from memory
803 * if t==write && value_regno==-1, some unknown value is stored into memory
804 * if t==read && value_regno==-1, don't care what we read from memory
805 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100806static int check_mem_access(struct bpf_verifier_env *env, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700807 int bpf_size, enum bpf_access_type t,
808 int value_regno)
809{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100810 struct bpf_verifier_state *state = &env->cur_state;
811 struct bpf_reg_state *reg = &state->regs[regno];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700812 int size, err = 0;
813
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700814 if (reg->type == PTR_TO_STACK)
815 off += reg->imm;
Alex Gartrell24b4d2a2015-07-23 14:24:40 -0700816
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700817 size = bpf_size_to_bytes(bpf_size);
818 if (size < 0)
819 return size;
820
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700821 err = check_ptr_alignment(env, reg, off, size);
822 if (err)
823 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700824
Josef Bacik48461132016-09-28 10:54:32 -0400825 if (reg->type == PTR_TO_MAP_VALUE ||
826 reg->type == PTR_TO_MAP_VALUE_ADJ) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700827 if (t == BPF_WRITE && value_regno >= 0 &&
828 is_pointer_value(env, value_regno)) {
829 verbose("R%d leaks addr into map\n", value_regno);
830 return -EACCES;
831 }
Josef Bacik48461132016-09-28 10:54:32 -0400832
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -0800833 if (reg->type == PTR_TO_MAP_VALUE_ADJ)
834 err = check_map_access_adj(env, regno, off, size);
835 else
836 err = check_map_access(env, regno, off, size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700837 if (!err && t == BPF_READ && value_regno >= 0)
Gianluca Borellof0318d02017-01-09 10:19:48 -0800838 mark_reg_unknown_value_and_range(state->regs,
839 value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700840
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700841 } else if (reg->type == PTR_TO_CTX) {
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700842 enum bpf_reg_type reg_type = UNKNOWN_VALUE;
843
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700844 if (t == BPF_WRITE && value_regno >= 0 &&
845 is_pointer_value(env, value_regno)) {
846 verbose("R%d leaks addr into ctx\n", value_regno);
847 return -EACCES;
848 }
Alexei Starovoitov19de99f2016-06-15 18:25:38 -0700849 err = check_ctx_access(env, off, size, t, &reg_type);
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700850 if (!err && t == BPF_READ && value_regno >= 0) {
Gianluca Borellof0318d02017-01-09 10:19:48 -0800851 mark_reg_unknown_value_and_range(state->regs,
852 value_regno);
Mickaël Salaün19553512016-09-24 20:01:50 +0200853 /* note that reg.[id|off|range] == 0 */
854 state->regs[value_regno].type = reg_type;
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700855 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700856
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700857 } else if (reg->type == FRAME_PTR || reg->type == PTR_TO_STACK) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700858 if (off >= 0 || off < -MAX_BPF_STACK) {
859 verbose("invalid stack off=%d size=%d\n", off, size);
860 return -EACCES;
861 }
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700862 if (t == BPF_WRITE) {
863 if (!env->allow_ptr_leaks &&
864 state->stack_slot_type[MAX_BPF_STACK + off] == STACK_SPILL &&
865 size != BPF_REG_SIZE) {
866 verbose("attempt to corrupt spilled pointer on stack\n");
867 return -EACCES;
868 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700869 err = check_stack_write(state, off, size, value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700870 } else {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700871 err = check_stack_read(state, off, size, value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700872 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700873 } else if (state->regs[regno].type == PTR_TO_PACKET) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +0100874 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700875 verbose("cannot write into packet\n");
876 return -EACCES;
877 }
Brenden Blanco4acf6c02016-07-19 12:16:56 -0700878 if (t == BPF_WRITE && value_regno >= 0 &&
879 is_pointer_value(env, value_regno)) {
880 verbose("R%d leaks addr into packet\n", value_regno);
881 return -EACCES;
882 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700883 err = check_packet_access(env, regno, off, size);
884 if (!err && t == BPF_READ && value_regno >= 0)
Gianluca Borellof0318d02017-01-09 10:19:48 -0800885 mark_reg_unknown_value_and_range(state->regs,
886 value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700887 } else {
888 verbose("R%d invalid mem access '%s'\n",
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700889 regno, reg_type_str[reg->type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700890 return -EACCES;
891 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700892
893 if (!err && size <= 2 && value_regno >= 0 && env->allow_ptr_leaks &&
894 state->regs[value_regno].type == UNKNOWN_VALUE) {
895 /* 1 or 2 byte load zero-extends, determine the number of
896 * zero upper bits. Not doing it fo 4 byte load, since
897 * such values cannot be added to ptr_to_packet anyway.
898 */
899 state->regs[value_regno].imm = 64 - size * 8;
900 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700901 return err;
902}
903
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100904static int check_xadd(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700905{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100906 struct bpf_reg_state *regs = env->cur_state.regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700907 int err;
908
909 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
910 insn->imm != 0) {
911 verbose("BPF_XADD uses reserved fields\n");
912 return -EINVAL;
913 }
914
915 /* check src1 operand */
916 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
917 if (err)
918 return err;
919
920 /* check src2 operand */
921 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
922 if (err)
923 return err;
924
925 /* check whether atomic_add can read the memory */
926 err = check_mem_access(env, insn->dst_reg, insn->off,
927 BPF_SIZE(insn->code), BPF_READ, -1);
928 if (err)
929 return err;
930
931 /* check whether atomic_add can write into the same memory */
932 return check_mem_access(env, insn->dst_reg, insn->off,
933 BPF_SIZE(insn->code), BPF_WRITE, -1);
934}
935
936/* when register 'regno' is passed into function that will read 'access_size'
937 * bytes from that pointer, make sure that it's within stack boundary
938 * and all elements of stack are initialized
939 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100940static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
Daniel Borkmann435faee12016-04-13 00:10:51 +0200941 int access_size, bool zero_size_allowed,
942 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700943{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100944 struct bpf_verifier_state *state = &env->cur_state;
945 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700946 int off, i;
947
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +0100948 if (regs[regno].type != PTR_TO_STACK) {
949 if (zero_size_allowed && access_size == 0 &&
950 regs[regno].type == CONST_IMM &&
951 regs[regno].imm == 0)
952 return 0;
953
954 verbose("R%d type=%s expected=%s\n", regno,
955 reg_type_str[regs[regno].type],
956 reg_type_str[PTR_TO_STACK]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700957 return -EACCES;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +0100958 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700959
960 off = regs[regno].imm;
961 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
962 access_size <= 0) {
963 verbose("invalid stack type R%d off=%d access_size=%d\n",
964 regno, off, access_size);
965 return -EACCES;
966 }
967
Daniel Borkmann435faee12016-04-13 00:10:51 +0200968 if (meta && meta->raw_mode) {
969 meta->access_size = access_size;
970 meta->regno = regno;
971 return 0;
972 }
973
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700974 for (i = 0; i < access_size; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700975 if (state->stack_slot_type[MAX_BPF_STACK + off + i] != STACK_MISC) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700976 verbose("invalid indirect read from stack off %d+%d size %d\n",
977 off, i, access_size);
978 return -EACCES;
979 }
980 }
981 return 0;
982}
983
Gianluca Borello06c1c042017-01-09 10:19:49 -0800984static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
985 int access_size, bool zero_size_allowed,
986 struct bpf_call_arg_meta *meta)
987{
988 struct bpf_reg_state *regs = env->cur_state.regs;
989
990 switch (regs[regno].type) {
991 case PTR_TO_PACKET:
992 return check_packet_access(env, regno, 0, access_size);
993 case PTR_TO_MAP_VALUE:
994 return check_map_access(env, regno, 0, access_size);
995 case PTR_TO_MAP_VALUE_ADJ:
996 return check_map_access_adj(env, regno, 0, access_size);
997 default: /* const_imm|ptr_to_stack or invalid ptr */
998 return check_stack_boundary(env, regno, access_size,
999 zero_size_allowed, meta);
1000 }
1001}
1002
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001003static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001004 enum bpf_arg_type arg_type,
1005 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001006{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001007 struct bpf_reg_state *regs = env->cur_state.regs, *reg = &regs[regno];
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001008 enum bpf_reg_type expected_type, type = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001009 int err = 0;
1010
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001011 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001012 return 0;
1013
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001014 if (type == NOT_INIT) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001015 verbose("R%d !read_ok\n", regno);
1016 return -EACCES;
1017 }
1018
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001019 if (arg_type == ARG_ANYTHING) {
1020 if (is_pointer_value(env, regno)) {
1021 verbose("R%d leaks addr into helper function\n", regno);
1022 return -EACCES;
1023 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001024 return 0;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001025 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001026
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001027 if (type == PTR_TO_PACKET &&
1028 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001029 verbose("helper access to the packet is not allowed\n");
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001030 return -EACCES;
1031 }
1032
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001033 if (arg_type == ARG_PTR_TO_MAP_KEY ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001034 arg_type == ARG_PTR_TO_MAP_VALUE) {
1035 expected_type = PTR_TO_STACK;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001036 if (type != PTR_TO_PACKET && type != expected_type)
1037 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001038 } else if (arg_type == ARG_CONST_SIZE ||
1039 arg_type == ARG_CONST_SIZE_OR_ZERO) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001040 expected_type = CONST_IMM;
Gianluca Borello06c1c042017-01-09 10:19:49 -08001041 /* One exception. Allow UNKNOWN_VALUE registers when the
1042 * boundaries are known and don't cause unsafe memory accesses
1043 */
1044 if (type != UNKNOWN_VALUE && type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001045 goto err_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001046 } else if (arg_type == ARG_CONST_MAP_PTR) {
1047 expected_type = CONST_PTR_TO_MAP;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001048 if (type != expected_type)
1049 goto err_type;
Alexei Starovoitov608cd712015-03-26 19:53:57 -07001050 } else if (arg_type == ARG_PTR_TO_CTX) {
1051 expected_type = PTR_TO_CTX;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001052 if (type != expected_type)
1053 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001054 } else if (arg_type == ARG_PTR_TO_MEM ||
1055 arg_type == ARG_PTR_TO_UNINIT_MEM) {
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001056 expected_type = PTR_TO_STACK;
1057 /* One exception here. In case function allows for NULL to be
1058 * passed in as argument, it's a CONST_IMM type. Final test
1059 * happens during stack boundary checking.
1060 */
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001061 if (type == CONST_IMM && reg->imm == 0)
1062 /* final test in check_stack_boundary() */;
Gianluca Borello57225692017-01-09 10:19:47 -08001063 else if (type != PTR_TO_PACKET && type != PTR_TO_MAP_VALUE &&
1064 type != PTR_TO_MAP_VALUE_ADJ && type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001065 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001066 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001067 } else {
1068 verbose("unsupported arg_type %d\n", arg_type);
1069 return -EFAULT;
1070 }
1071
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001072 if (arg_type == ARG_CONST_MAP_PTR) {
1073 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001074 meta->map_ptr = reg->map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001075 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
1076 /* bpf_map_xxx(..., map_ptr, ..., key) call:
1077 * check that [key, key + map->key_size) are within
1078 * stack limits and initialized
1079 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001080 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001081 /* in function declaration map_ptr must come before
1082 * map_key, so that it's verified and known before
1083 * we have to check map_key here. Otherwise it means
1084 * that kernel subsystem misconfigured verifier
1085 */
1086 verbose("invalid map_ptr to access map->key\n");
1087 return -EACCES;
1088 }
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001089 if (type == PTR_TO_PACKET)
1090 err = check_packet_access(env, regno, 0,
1091 meta->map_ptr->key_size);
1092 else
1093 err = check_stack_boundary(env, regno,
1094 meta->map_ptr->key_size,
1095 false, NULL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001096 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
1097 /* bpf_map_xxx(..., map_ptr, ..., value) call:
1098 * check [value, value + map->value_size) validity
1099 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001100 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001101 /* kernel subsystem misconfigured verifier */
1102 verbose("invalid map_ptr to access map->value\n");
1103 return -EACCES;
1104 }
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001105 if (type == PTR_TO_PACKET)
1106 err = check_packet_access(env, regno, 0,
1107 meta->map_ptr->value_size);
1108 else
1109 err = check_stack_boundary(env, regno,
1110 meta->map_ptr->value_size,
1111 false, NULL);
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001112 } else if (arg_type == ARG_CONST_SIZE ||
1113 arg_type == ARG_CONST_SIZE_OR_ZERO) {
1114 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001115
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001116 /* bpf_xxx(..., buf, len) call will access 'len' bytes
1117 * from stack pointer 'buf'. Check it
1118 * note: regno == len, regno - 1 == buf
1119 */
1120 if (regno == 0) {
1121 /* kernel subsystem misconfigured verifier */
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001122 verbose("ARG_CONST_SIZE cannot be first argument\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001123 return -EACCES;
1124 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001125
1126 /* If the register is UNKNOWN_VALUE, the access check happens
1127 * using its boundaries. Otherwise, just use its imm
1128 */
1129 if (type == UNKNOWN_VALUE) {
1130 /* For unprivileged variable accesses, disable raw
1131 * mode so that the program is required to
1132 * initialize all the memory that the helper could
1133 * just partially fill up.
1134 */
1135 meta = NULL;
1136
1137 if (reg->min_value < 0) {
1138 verbose("R%d min value is negative, either use unsigned or 'var &= const'\n",
1139 regno);
1140 return -EACCES;
1141 }
1142
1143 if (reg->min_value == 0) {
1144 err = check_helper_mem_access(env, regno - 1, 0,
1145 zero_size_allowed,
1146 meta);
1147 if (err)
1148 return err;
1149 }
1150
1151 if (reg->max_value == BPF_REGISTER_MAX_RANGE) {
1152 verbose("R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
1153 regno);
1154 return -EACCES;
1155 }
1156 err = check_helper_mem_access(env, regno - 1,
1157 reg->max_value,
1158 zero_size_allowed, meta);
1159 if (err)
1160 return err;
1161 } else {
1162 /* register is CONST_IMM */
1163 err = check_helper_mem_access(env, regno - 1, reg->imm,
1164 zero_size_allowed, meta);
1165 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001166 }
1167
1168 return err;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001169err_type:
1170 verbose("R%d type=%s expected=%s\n", regno,
1171 reg_type_str[type], reg_type_str[expected_type]);
1172 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001173}
1174
Kaixu Xia35578d72015-08-06 07:02:35 +00001175static int check_map_func_compatibility(struct bpf_map *map, int func_id)
1176{
Kaixu Xia35578d72015-08-06 07:02:35 +00001177 if (!map)
1178 return 0;
1179
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001180 /* We need a two way check, first is from map perspective ... */
1181 switch (map->map_type) {
1182 case BPF_MAP_TYPE_PROG_ARRAY:
1183 if (func_id != BPF_FUNC_tail_call)
1184 goto error;
1185 break;
1186 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
1187 if (func_id != BPF_FUNC_perf_event_read &&
1188 func_id != BPF_FUNC_perf_event_output)
1189 goto error;
1190 break;
1191 case BPF_MAP_TYPE_STACK_TRACE:
1192 if (func_id != BPF_FUNC_get_stackid)
1193 goto error;
1194 break;
Martin KaFai Lau4ed8ec52016-06-30 10:28:43 -07001195 case BPF_MAP_TYPE_CGROUP_ARRAY:
David S. Miller60747ef2016-08-18 01:17:32 -04001196 if (func_id != BPF_FUNC_skb_under_cgroup &&
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001197 func_id != BPF_FUNC_current_task_under_cgroup)
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001198 goto error;
1199 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001200 default:
1201 break;
1202 }
1203
1204 /* ... and second from the function itself. */
1205 switch (func_id) {
1206 case BPF_FUNC_tail_call:
1207 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
1208 goto error;
1209 break;
1210 case BPF_FUNC_perf_event_read:
1211 case BPF_FUNC_perf_event_output:
1212 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
1213 goto error;
1214 break;
1215 case BPF_FUNC_get_stackid:
1216 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
1217 goto error;
1218 break;
Sargun Dhillon60d20f92016-08-12 08:56:52 -07001219 case BPF_FUNC_current_task_under_cgroup:
Daniel Borkmann747ea552016-08-12 22:17:17 +02001220 case BPF_FUNC_skb_under_cgroup:
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07001221 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
1222 goto error;
1223 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001224 default:
1225 break;
Kaixu Xia35578d72015-08-06 07:02:35 +00001226 }
1227
1228 return 0;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001229error:
Thomas Grafebb676d2016-10-27 11:23:51 +02001230 verbose("cannot pass map_type %d into func %s#%d\n",
1231 map->map_type, func_id_name(func_id), func_id);
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07001232 return -EINVAL;
Kaixu Xia35578d72015-08-06 07:02:35 +00001233}
1234
Daniel Borkmann435faee12016-04-13 00:10:51 +02001235static int check_raw_mode(const struct bpf_func_proto *fn)
1236{
1237 int count = 0;
1238
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001239 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001240 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001241 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001242 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001243 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001244 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001245 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001246 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001247 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02001248 count++;
1249
1250 return count > 1 ? -EINVAL : 0;
1251}
1252
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001253static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001254{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001255 struct bpf_verifier_state *state = &env->cur_state;
1256 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001257 int i;
1258
1259 for (i = 0; i < MAX_BPF_REG; i++)
1260 if (regs[i].type == PTR_TO_PACKET ||
1261 regs[i].type == PTR_TO_PACKET_END)
1262 mark_reg_unknown_value(regs, i);
1263
1264 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
1265 if (state->stack_slot_type[i] != STACK_SPILL)
1266 continue;
1267 reg = &state->spilled_regs[i / BPF_REG_SIZE];
1268 if (reg->type != PTR_TO_PACKET &&
1269 reg->type != PTR_TO_PACKET_END)
1270 continue;
1271 reg->type = UNKNOWN_VALUE;
1272 reg->imm = 0;
1273 }
1274}
1275
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001276static int check_call(struct bpf_verifier_env *env, int func_id)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001277{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001278 struct bpf_verifier_state *state = &env->cur_state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001279 const struct bpf_func_proto *fn = NULL;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001280 struct bpf_reg_state *regs = state->regs;
1281 struct bpf_reg_state *reg;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001282 struct bpf_call_arg_meta meta;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001283 bool changes_data;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001284 int i, err;
1285
1286 /* find function prototype */
1287 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
Thomas Grafebb676d2016-10-27 11:23:51 +02001288 verbose("invalid func %s#%d\n", func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001289 return -EINVAL;
1290 }
1291
1292 if (env->prog->aux->ops->get_func_proto)
1293 fn = env->prog->aux->ops->get_func_proto(func_id);
1294
1295 if (!fn) {
Thomas Grafebb676d2016-10-27 11:23:51 +02001296 verbose("unknown func %s#%d\n", func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001297 return -EINVAL;
1298 }
1299
1300 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +01001301 if (!env->prog->gpl_compatible && fn->gpl_only) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001302 verbose("cannot call GPL only function from proprietary program\n");
1303 return -EINVAL;
1304 }
1305
Martin KaFai Lau17bedab2016-12-07 15:53:11 -08001306 changes_data = bpf_helper_changes_pkt_data(fn->func);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001307
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001308 memset(&meta, 0, sizeof(meta));
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001309 meta.pkt_access = fn->pkt_access;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001310
Daniel Borkmann435faee12016-04-13 00:10:51 +02001311 /* We only support one arg being in raw mode at the moment, which
1312 * is sufficient for the helper functions we have right now.
1313 */
1314 err = check_raw_mode(fn);
1315 if (err) {
Thomas Grafebb676d2016-10-27 11:23:51 +02001316 verbose("kernel subsystem misconfigured func %s#%d\n",
1317 func_id_name(func_id), func_id);
Daniel Borkmann435faee12016-04-13 00:10:51 +02001318 return err;
1319 }
1320
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001321 /* check args */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001322 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001323 if (err)
1324 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001325 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001326 if (err)
1327 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001328 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001329 if (err)
1330 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001331 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001332 if (err)
1333 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001334 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001335 if (err)
1336 return err;
1337
Daniel Borkmann435faee12016-04-13 00:10:51 +02001338 /* Mark slots with STACK_MISC in case of raw mode, stack offset
1339 * is inferred from register state.
1340 */
1341 for (i = 0; i < meta.access_size; i++) {
1342 err = check_mem_access(env, meta.regno, i, BPF_B, BPF_WRITE, -1);
1343 if (err)
1344 return err;
1345 }
1346
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001347 /* reset caller saved regs */
1348 for (i = 0; i < CALLER_SAVED_REGS; i++) {
1349 reg = regs + caller_saved[i];
1350 reg->type = NOT_INIT;
1351 reg->imm = 0;
1352 }
1353
1354 /* update return register */
1355 if (fn->ret_type == RET_INTEGER) {
1356 regs[BPF_REG_0].type = UNKNOWN_VALUE;
1357 } else if (fn->ret_type == RET_VOID) {
1358 regs[BPF_REG_0].type = NOT_INIT;
1359 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
1360 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
Josef Bacik48461132016-09-28 10:54:32 -04001361 regs[BPF_REG_0].max_value = regs[BPF_REG_0].min_value = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001362 /* remember map_ptr, so that check_map_access()
1363 * can check 'value_size' boundary of memory access
1364 * to map element returned from bpf_map_lookup_elem()
1365 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001366 if (meta.map_ptr == NULL) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001367 verbose("kernel subsystem misconfigured verifier\n");
1368 return -EINVAL;
1369 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001370 regs[BPF_REG_0].map_ptr = meta.map_ptr;
Thomas Graf57a09bf2016-10-18 19:51:19 +02001371 regs[BPF_REG_0].id = ++env->id_gen;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001372 } else {
Thomas Grafebb676d2016-10-27 11:23:51 +02001373 verbose("unknown return type %d of func %s#%d\n",
1374 fn->ret_type, func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001375 return -EINVAL;
1376 }
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001377
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001378 err = check_map_func_compatibility(meta.map_ptr, func_id);
Kaixu Xia35578d72015-08-06 07:02:35 +00001379 if (err)
1380 return err;
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07001381
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001382 if (changes_data)
1383 clear_all_pkt_pointers(env);
1384 return 0;
1385}
1386
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001387static int check_packet_ptr_add(struct bpf_verifier_env *env,
1388 struct bpf_insn *insn)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001389{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001390 struct bpf_reg_state *regs = env->cur_state.regs;
1391 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
1392 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
1393 struct bpf_reg_state tmp_reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001394 s32 imm;
1395
1396 if (BPF_SRC(insn->code) == BPF_K) {
1397 /* pkt_ptr += imm */
1398 imm = insn->imm;
1399
1400add_imm:
William Tu63dfef72017-02-04 08:37:29 -08001401 if (imm < 0) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001402 verbose("addition of negative constant to packet pointer is not allowed\n");
1403 return -EACCES;
1404 }
1405 if (imm >= MAX_PACKET_OFF ||
1406 imm + dst_reg->off >= MAX_PACKET_OFF) {
1407 verbose("constant %d is too large to add to packet pointer\n",
1408 imm);
1409 return -EACCES;
1410 }
1411 /* a constant was added to pkt_ptr.
1412 * Remember it while keeping the same 'id'
1413 */
1414 dst_reg->off += imm;
1415 } else {
Alexei Starovoitov1b9b69e2016-05-19 18:17:14 -07001416 if (src_reg->type == PTR_TO_PACKET) {
1417 /* R6=pkt(id=0,off=0,r=62) R7=imm22; r7 += r6 */
1418 tmp_reg = *dst_reg; /* save r7 state */
1419 *dst_reg = *src_reg; /* copy pkt_ptr state r6 into r7 */
1420 src_reg = &tmp_reg; /* pretend it's src_reg state */
1421 /* if the checks below reject it, the copy won't matter,
1422 * since we're rejecting the whole program. If all ok,
1423 * then imm22 state will be added to r7
1424 * and r7 will be pkt(id=0,off=22,r=62) while
1425 * r6 will stay as pkt(id=0,off=0,r=62)
1426 */
1427 }
1428
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001429 if (src_reg->type == CONST_IMM) {
1430 /* pkt_ptr += reg where reg is known constant */
1431 imm = src_reg->imm;
1432 goto add_imm;
1433 }
1434 /* disallow pkt_ptr += reg
1435 * if reg is not uknown_value with guaranteed zero upper bits
1436 * otherwise pkt_ptr may overflow and addition will become
1437 * subtraction which is not allowed
1438 */
1439 if (src_reg->type != UNKNOWN_VALUE) {
1440 verbose("cannot add '%s' to ptr_to_packet\n",
1441 reg_type_str[src_reg->type]);
1442 return -EACCES;
1443 }
1444 if (src_reg->imm < 48) {
1445 verbose("cannot add integer value with %lld upper zero bits to ptr_to_packet\n",
1446 src_reg->imm);
1447 return -EACCES;
1448 }
1449 /* dst_reg stays as pkt_ptr type and since some positive
1450 * integer value was added to the pointer, increment its 'id'
1451 */
Jakub Kicinski1f415a72016-08-02 16:12:14 +01001452 dst_reg->id = ++env->id_gen;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001453
1454 /* something was added to pkt_ptr, set range and off to zero */
1455 dst_reg->off = 0;
1456 dst_reg->range = 0;
1457 }
1458 return 0;
1459}
1460
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001461static int evaluate_reg_alu(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001462{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001463 struct bpf_reg_state *regs = env->cur_state.regs;
1464 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001465 u8 opcode = BPF_OP(insn->code);
1466 s64 imm_log2;
1467
1468 /* for type == UNKNOWN_VALUE:
1469 * imm > 0 -> number of zero upper bits
1470 * imm == 0 -> don't track which is the same as all bits can be non-zero
1471 */
1472
1473 if (BPF_SRC(insn->code) == BPF_X) {
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001474 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001475
1476 if (src_reg->type == UNKNOWN_VALUE && src_reg->imm > 0 &&
1477 dst_reg->imm && opcode == BPF_ADD) {
1478 /* dreg += sreg
1479 * where both have zero upper bits. Adding them
1480 * can only result making one more bit non-zero
1481 * in the larger value.
1482 * Ex. 0xffff (imm=48) + 1 (imm=63) = 0x10000 (imm=47)
1483 * 0xffff (imm=48) + 0xffff = 0x1fffe (imm=47)
1484 */
1485 dst_reg->imm = min(dst_reg->imm, src_reg->imm);
1486 dst_reg->imm--;
1487 return 0;
1488 }
1489 if (src_reg->type == CONST_IMM && src_reg->imm > 0 &&
1490 dst_reg->imm && opcode == BPF_ADD) {
1491 /* dreg += sreg
1492 * where dreg has zero upper bits and sreg is const.
1493 * Adding them can only result making one more bit
1494 * non-zero in the larger value.
1495 */
1496 imm_log2 = __ilog2_u64((long long)src_reg->imm);
1497 dst_reg->imm = min(dst_reg->imm, 63 - imm_log2);
1498 dst_reg->imm--;
1499 return 0;
1500 }
1501 /* all other cases non supported yet, just mark dst_reg */
1502 dst_reg->imm = 0;
1503 return 0;
1504 }
1505
1506 /* sign extend 32-bit imm into 64-bit to make sure that
1507 * negative values occupy bit 63. Note ilog2() would have
1508 * been incorrect, since sizeof(insn->imm) == 4
1509 */
1510 imm_log2 = __ilog2_u64((long long)insn->imm);
1511
1512 if (dst_reg->imm && opcode == BPF_LSH) {
1513 /* reg <<= imm
1514 * if reg was a result of 2 byte load, then its imm == 48
1515 * which means that upper 48 bits are zero and shifting this reg
1516 * left by 4 would mean that upper 44 bits are still zero
1517 */
1518 dst_reg->imm -= insn->imm;
1519 } else if (dst_reg->imm && opcode == BPF_MUL) {
1520 /* reg *= imm
1521 * if multiplying by 14 subtract 4
1522 * This is conservative calculation of upper zero bits.
1523 * It's not trying to special case insn->imm == 1 or 0 cases
1524 */
1525 dst_reg->imm -= imm_log2 + 1;
1526 } else if (opcode == BPF_AND) {
1527 /* reg &= imm */
1528 dst_reg->imm = 63 - imm_log2;
1529 } else if (dst_reg->imm && opcode == BPF_ADD) {
1530 /* reg += imm */
1531 dst_reg->imm = min(dst_reg->imm, 63 - imm_log2);
1532 dst_reg->imm--;
1533 } else if (opcode == BPF_RSH) {
1534 /* reg >>= imm
1535 * which means that after right shift, upper bits will be zero
1536 * note that verifier already checked that
1537 * 0 <= imm < 64 for shift insn
1538 */
1539 dst_reg->imm += insn->imm;
1540 if (unlikely(dst_reg->imm > 64))
1541 /* some dumb code did:
1542 * r2 = *(u32 *)mem;
1543 * r2 >>= 32;
1544 * and all bits are zero now */
1545 dst_reg->imm = 64;
1546 } else {
1547 /* all other alu ops, means that we don't know what will
1548 * happen to the value, mark it with unknown number of zero bits
1549 */
1550 dst_reg->imm = 0;
1551 }
1552
1553 if (dst_reg->imm < 0) {
1554 /* all 64 bits of the register can contain non-zero bits
1555 * and such value cannot be added to ptr_to_packet, since it
1556 * may overflow, mark it as unknown to avoid further eval
1557 */
1558 dst_reg->imm = 0;
1559 }
1560 return 0;
1561}
1562
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001563static int evaluate_reg_imm_alu(struct bpf_verifier_env *env,
1564 struct bpf_insn *insn)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001565{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001566 struct bpf_reg_state *regs = env->cur_state.regs;
1567 struct bpf_reg_state *dst_reg = &regs[insn->dst_reg];
1568 struct bpf_reg_state *src_reg = &regs[insn->src_reg];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001569 u8 opcode = BPF_OP(insn->code);
Daniel Borkmann3fadc802017-01-24 01:06:30 +01001570 u64 dst_imm = dst_reg->imm;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001571
Daniel Borkmann3fadc802017-01-24 01:06:30 +01001572 /* dst_reg->type == CONST_IMM here. Simulate execution of insns
1573 * containing ALU ops. Don't care about overflow or negative
1574 * values, just add/sub/... them; registers are in u64.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001575 */
Daniel Borkmann3fadc802017-01-24 01:06:30 +01001576 if (opcode == BPF_ADD && BPF_SRC(insn->code) == BPF_K) {
1577 dst_imm += insn->imm;
1578 } else if (opcode == BPF_ADD && BPF_SRC(insn->code) == BPF_X &&
1579 src_reg->type == CONST_IMM) {
1580 dst_imm += src_reg->imm;
1581 } else if (opcode == BPF_SUB && BPF_SRC(insn->code) == BPF_K) {
1582 dst_imm -= insn->imm;
1583 } else if (opcode == BPF_SUB && BPF_SRC(insn->code) == BPF_X &&
1584 src_reg->type == CONST_IMM) {
1585 dst_imm -= src_reg->imm;
1586 } else if (opcode == BPF_MUL && BPF_SRC(insn->code) == BPF_K) {
1587 dst_imm *= insn->imm;
1588 } else if (opcode == BPF_MUL && BPF_SRC(insn->code) == BPF_X &&
1589 src_reg->type == CONST_IMM) {
1590 dst_imm *= src_reg->imm;
1591 } else if (opcode == BPF_OR && BPF_SRC(insn->code) == BPF_K) {
1592 dst_imm |= insn->imm;
1593 } else if (opcode == BPF_OR && BPF_SRC(insn->code) == BPF_X &&
1594 src_reg->type == CONST_IMM) {
1595 dst_imm |= src_reg->imm;
1596 } else if (opcode == BPF_AND && BPF_SRC(insn->code) == BPF_K) {
1597 dst_imm &= insn->imm;
1598 } else if (opcode == BPF_AND && BPF_SRC(insn->code) == BPF_X &&
1599 src_reg->type == CONST_IMM) {
1600 dst_imm &= src_reg->imm;
1601 } else if (opcode == BPF_RSH && BPF_SRC(insn->code) == BPF_K) {
1602 dst_imm >>= insn->imm;
1603 } else if (opcode == BPF_RSH && BPF_SRC(insn->code) == BPF_X &&
1604 src_reg->type == CONST_IMM) {
1605 dst_imm >>= src_reg->imm;
1606 } else if (opcode == BPF_LSH && BPF_SRC(insn->code) == BPF_K) {
1607 dst_imm <<= insn->imm;
1608 } else if (opcode == BPF_LSH && BPF_SRC(insn->code) == BPF_X &&
1609 src_reg->type == CONST_IMM) {
1610 dst_imm <<= src_reg->imm;
1611 } else {
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001612 mark_reg_unknown_value(regs, insn->dst_reg);
Daniel Borkmann3fadc802017-01-24 01:06:30 +01001613 goto out;
1614 }
1615
1616 dst_reg->imm = dst_imm;
1617out:
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001618 return 0;
1619}
1620
Josef Bacik48461132016-09-28 10:54:32 -04001621static void check_reg_overflow(struct bpf_reg_state *reg)
1622{
1623 if (reg->max_value > BPF_REGISTER_MAX_RANGE)
1624 reg->max_value = BPF_REGISTER_MAX_RANGE;
Josef Bacikf23cc642016-11-14 15:45:36 -05001625 if (reg->min_value < BPF_REGISTER_MIN_RANGE ||
1626 reg->min_value > BPF_REGISTER_MAX_RANGE)
Josef Bacik48461132016-09-28 10:54:32 -04001627 reg->min_value = BPF_REGISTER_MIN_RANGE;
1628}
1629
1630static void adjust_reg_min_max_vals(struct bpf_verifier_env *env,
1631 struct bpf_insn *insn)
1632{
1633 struct bpf_reg_state *regs = env->cur_state.regs, *dst_reg;
Josef Bacikf23cc642016-11-14 15:45:36 -05001634 s64 min_val = BPF_REGISTER_MIN_RANGE;
1635 u64 max_val = BPF_REGISTER_MAX_RANGE;
Josef Bacik48461132016-09-28 10:54:32 -04001636 u8 opcode = BPF_OP(insn->code);
1637
1638 dst_reg = &regs[insn->dst_reg];
1639 if (BPF_SRC(insn->code) == BPF_X) {
1640 check_reg_overflow(&regs[insn->src_reg]);
1641 min_val = regs[insn->src_reg].min_value;
1642 max_val = regs[insn->src_reg].max_value;
1643
1644 /* If the source register is a random pointer then the
1645 * min_value/max_value values represent the range of the known
1646 * accesses into that value, not the actual min/max value of the
1647 * register itself. In this case we have to reset the reg range
1648 * values so we know it is not safe to look at.
1649 */
1650 if (regs[insn->src_reg].type != CONST_IMM &&
1651 regs[insn->src_reg].type != UNKNOWN_VALUE) {
1652 min_val = BPF_REGISTER_MIN_RANGE;
1653 max_val = BPF_REGISTER_MAX_RANGE;
1654 }
1655 } else if (insn->imm < BPF_REGISTER_MAX_RANGE &&
1656 (s64)insn->imm > BPF_REGISTER_MIN_RANGE) {
1657 min_val = max_val = insn->imm;
Josef Bacik48461132016-09-28 10:54:32 -04001658 }
1659
1660 /* We don't know anything about what was done to this register, mark it
1661 * as unknown.
1662 */
1663 if (min_val == BPF_REGISTER_MIN_RANGE &&
1664 max_val == BPF_REGISTER_MAX_RANGE) {
1665 reset_reg_range_values(regs, insn->dst_reg);
1666 return;
1667 }
1668
Josef Bacikf23cc642016-11-14 15:45:36 -05001669 /* If one of our values was at the end of our ranges then we can't just
1670 * do our normal operations to the register, we need to set the values
1671 * to the min/max since they are undefined.
1672 */
1673 if (min_val == BPF_REGISTER_MIN_RANGE)
1674 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1675 if (max_val == BPF_REGISTER_MAX_RANGE)
1676 dst_reg->max_value = BPF_REGISTER_MAX_RANGE;
1677
Josef Bacik48461132016-09-28 10:54:32 -04001678 switch (opcode) {
1679 case BPF_ADD:
Josef Bacikf23cc642016-11-14 15:45:36 -05001680 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1681 dst_reg->min_value += min_val;
1682 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1683 dst_reg->max_value += max_val;
Josef Bacik48461132016-09-28 10:54:32 -04001684 break;
1685 case BPF_SUB:
Josef Bacikf23cc642016-11-14 15:45:36 -05001686 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1687 dst_reg->min_value -= min_val;
1688 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1689 dst_reg->max_value -= max_val;
Josef Bacik48461132016-09-28 10:54:32 -04001690 break;
1691 case BPF_MUL:
Josef Bacikf23cc642016-11-14 15:45:36 -05001692 if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
1693 dst_reg->min_value *= min_val;
1694 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1695 dst_reg->max_value *= max_val;
Josef Bacik48461132016-09-28 10:54:32 -04001696 break;
1697 case BPF_AND:
Josef Bacikf23cc642016-11-14 15:45:36 -05001698 /* Disallow AND'ing of negative numbers, ain't nobody got time
1699 * for that. Otherwise the minimum is 0 and the max is the max
1700 * value we could AND against.
1701 */
1702 if (min_val < 0)
1703 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1704 else
1705 dst_reg->min_value = 0;
Josef Bacik48461132016-09-28 10:54:32 -04001706 dst_reg->max_value = max_val;
1707 break;
1708 case BPF_LSH:
1709 /* Gotta have special overflow logic here, if we're shifting
1710 * more than MAX_RANGE then just assume we have an invalid
1711 * range.
1712 */
1713 if (min_val > ilog2(BPF_REGISTER_MAX_RANGE))
1714 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
Josef Bacikf23cc642016-11-14 15:45:36 -05001715 else if (dst_reg->min_value != BPF_REGISTER_MIN_RANGE)
Josef Bacik48461132016-09-28 10:54:32 -04001716 dst_reg->min_value <<= min_val;
1717
1718 if (max_val > ilog2(BPF_REGISTER_MAX_RANGE))
1719 dst_reg->max_value = BPF_REGISTER_MAX_RANGE;
Josef Bacikf23cc642016-11-14 15:45:36 -05001720 else if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
Josef Bacik48461132016-09-28 10:54:32 -04001721 dst_reg->max_value <<= max_val;
1722 break;
1723 case BPF_RSH:
Josef Bacikf23cc642016-11-14 15:45:36 -05001724 /* RSH by a negative number is undefined, and the BPF_RSH is an
1725 * unsigned shift, so make the appropriate casts.
Josef Bacik48461132016-09-28 10:54:32 -04001726 */
Josef Bacikf23cc642016-11-14 15:45:36 -05001727 if (min_val < 0 || dst_reg->min_value < 0)
1728 dst_reg->min_value = BPF_REGISTER_MIN_RANGE;
1729 else
1730 dst_reg->min_value =
1731 (u64)(dst_reg->min_value) >> min_val;
1732 if (dst_reg->max_value != BPF_REGISTER_MAX_RANGE)
1733 dst_reg->max_value >>= max_val;
Josef Bacik48461132016-09-28 10:54:32 -04001734 break;
1735 default:
1736 reset_reg_range_values(regs, insn->dst_reg);
1737 break;
1738 }
1739
1740 check_reg_overflow(dst_reg);
1741}
1742
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001743/* check validity of 32-bit and 64-bit arithmetic operations */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001744static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001745{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001746 struct bpf_reg_state *regs = env->cur_state.regs, *dst_reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001747 u8 opcode = BPF_OP(insn->code);
1748 int err;
1749
1750 if (opcode == BPF_END || opcode == BPF_NEG) {
1751 if (opcode == BPF_NEG) {
1752 if (BPF_SRC(insn->code) != 0 ||
1753 insn->src_reg != BPF_REG_0 ||
1754 insn->off != 0 || insn->imm != 0) {
1755 verbose("BPF_NEG uses reserved fields\n");
1756 return -EINVAL;
1757 }
1758 } else {
1759 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
1760 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64)) {
1761 verbose("BPF_END uses reserved fields\n");
1762 return -EINVAL;
1763 }
1764 }
1765
1766 /* check src operand */
1767 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1768 if (err)
1769 return err;
1770
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001771 if (is_pointer_value(env, insn->dst_reg)) {
1772 verbose("R%d pointer arithmetic prohibited\n",
1773 insn->dst_reg);
1774 return -EACCES;
1775 }
1776
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001777 /* check dest operand */
1778 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1779 if (err)
1780 return err;
1781
1782 } else if (opcode == BPF_MOV) {
1783
1784 if (BPF_SRC(insn->code) == BPF_X) {
1785 if (insn->imm != 0 || insn->off != 0) {
1786 verbose("BPF_MOV uses reserved fields\n");
1787 return -EINVAL;
1788 }
1789
1790 /* check src operand */
1791 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1792 if (err)
1793 return err;
1794 } else {
1795 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
1796 verbose("BPF_MOV uses reserved fields\n");
1797 return -EINVAL;
1798 }
1799 }
1800
1801 /* check dest operand */
1802 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
1803 if (err)
1804 return err;
1805
Josef Bacik48461132016-09-28 10:54:32 -04001806 /* we are setting our register to something new, we need to
1807 * reset its range values.
1808 */
1809 reset_reg_range_values(regs, insn->dst_reg);
1810
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001811 if (BPF_SRC(insn->code) == BPF_X) {
1812 if (BPF_CLASS(insn->code) == BPF_ALU64) {
1813 /* case: R1 = R2
1814 * copy register state to dest reg
1815 */
1816 regs[insn->dst_reg] = regs[insn->src_reg];
1817 } else {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001818 if (is_pointer_value(env, insn->src_reg)) {
1819 verbose("R%d partial copy of pointer\n",
1820 insn->src_reg);
1821 return -EACCES;
1822 }
Thomas Graf57a09bf2016-10-18 19:51:19 +02001823 mark_reg_unknown_value(regs, insn->dst_reg);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001824 }
1825 } else {
1826 /* case: R = imm
1827 * remember the value we stored into this reg
1828 */
1829 regs[insn->dst_reg].type = CONST_IMM;
1830 regs[insn->dst_reg].imm = insn->imm;
Josef Bacik48461132016-09-28 10:54:32 -04001831 regs[insn->dst_reg].max_value = insn->imm;
1832 regs[insn->dst_reg].min_value = insn->imm;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001833 }
1834
1835 } else if (opcode > BPF_END) {
1836 verbose("invalid BPF_ALU opcode %x\n", opcode);
1837 return -EINVAL;
1838
1839 } else { /* all other ALU ops: and, sub, xor, add, ... */
1840
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001841 if (BPF_SRC(insn->code) == BPF_X) {
1842 if (insn->imm != 0 || insn->off != 0) {
1843 verbose("BPF_ALU uses reserved fields\n");
1844 return -EINVAL;
1845 }
1846 /* check src1 operand */
1847 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
1848 if (err)
1849 return err;
1850 } else {
1851 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
1852 verbose("BPF_ALU uses reserved fields\n");
1853 return -EINVAL;
1854 }
1855 }
1856
1857 /* check src2 operand */
1858 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
1859 if (err)
1860 return err;
1861
1862 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
1863 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
1864 verbose("div by zero\n");
1865 return -EINVAL;
1866 }
1867
Rabin Vincent229394e82016-01-12 20:17:08 +01001868 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
1869 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
1870 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
1871
1872 if (insn->imm < 0 || insn->imm >= size) {
1873 verbose("invalid shift %d\n", insn->imm);
1874 return -EINVAL;
1875 }
1876 }
1877
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001878 /* check dest operand */
1879 err = check_reg_arg(regs, insn->dst_reg, DST_OP_NO_MARK);
1880 if (err)
1881 return err;
1882
1883 dst_reg = &regs[insn->dst_reg];
1884
Josef Bacik48461132016-09-28 10:54:32 -04001885 /* first we want to adjust our ranges. */
1886 adjust_reg_min_max_vals(env, insn);
1887
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001888 /* pattern match 'bpf_add Rx, imm' instruction */
1889 if (opcode == BPF_ADD && BPF_CLASS(insn->code) == BPF_ALU64 &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001890 dst_reg->type == FRAME_PTR && BPF_SRC(insn->code) == BPF_K) {
1891 dst_reg->type = PTR_TO_STACK;
1892 dst_reg->imm = insn->imm;
1893 return 0;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001894 } else if (opcode == BPF_ADD &&
1895 BPF_CLASS(insn->code) == BPF_ALU64 &&
Alexei Starovoitov1b9b69e2016-05-19 18:17:14 -07001896 (dst_reg->type == PTR_TO_PACKET ||
1897 (BPF_SRC(insn->code) == BPF_X &&
1898 regs[insn->src_reg].type == PTR_TO_PACKET))) {
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001899 /* ptr_to_packet += K|X */
1900 return check_packet_ptr_add(env, insn);
1901 } else if (BPF_CLASS(insn->code) == BPF_ALU64 &&
1902 dst_reg->type == UNKNOWN_VALUE &&
1903 env->allow_ptr_leaks) {
1904 /* unknown += K|X */
1905 return evaluate_reg_alu(env, insn);
1906 } else if (BPF_CLASS(insn->code) == BPF_ALU64 &&
1907 dst_reg->type == CONST_IMM &&
1908 env->allow_ptr_leaks) {
1909 /* reg_imm += K|X */
1910 return evaluate_reg_imm_alu(env, insn);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001911 } else if (is_pointer_value(env, insn->dst_reg)) {
1912 verbose("R%d pointer arithmetic prohibited\n",
1913 insn->dst_reg);
1914 return -EACCES;
1915 } else if (BPF_SRC(insn->code) == BPF_X &&
1916 is_pointer_value(env, insn->src_reg)) {
1917 verbose("R%d pointer arithmetic prohibited\n",
1918 insn->src_reg);
1919 return -EACCES;
1920 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001921
Josef Bacik48461132016-09-28 10:54:32 -04001922 /* If we did pointer math on a map value then just set it to our
1923 * PTR_TO_MAP_VALUE_ADJ type so we can deal with any stores or
1924 * loads to this register appropriately, otherwise just mark the
1925 * register as unknown.
1926 */
1927 if (env->allow_ptr_leaks &&
1928 (dst_reg->type == PTR_TO_MAP_VALUE ||
1929 dst_reg->type == PTR_TO_MAP_VALUE_ADJ))
1930 dst_reg->type = PTR_TO_MAP_VALUE_ADJ;
1931 else
1932 mark_reg_unknown_value(regs, insn->dst_reg);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001933 }
1934
1935 return 0;
1936}
1937
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001938static void find_good_pkt_pointers(struct bpf_verifier_state *state,
1939 struct bpf_reg_state *dst_reg)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001940{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001941 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001942 int i;
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02001943
1944 /* LLVM can generate two kind of checks:
1945 *
1946 * Type 1:
1947 *
1948 * r2 = r3;
1949 * r2 += 8;
1950 * if (r2 > pkt_end) goto <handle exception>
1951 * <access okay>
1952 *
1953 * Where:
1954 * r2 == dst_reg, pkt_end == src_reg
1955 * r2=pkt(id=n,off=8,r=0)
1956 * r3=pkt(id=n,off=0,r=0)
1957 *
1958 * Type 2:
1959 *
1960 * r2 = r3;
1961 * r2 += 8;
1962 * if (pkt_end >= r2) goto <access okay>
1963 * <handle exception>
1964 *
1965 * Where:
1966 * pkt_end == dst_reg, r2 == src_reg
1967 * r2=pkt(id=n,off=8,r=0)
1968 * r3=pkt(id=n,off=0,r=0)
1969 *
1970 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
1971 * so that range of bytes [r3, r3 + 8) is safe to access.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001972 */
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02001973
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001974 for (i = 0; i < MAX_BPF_REG; i++)
1975 if (regs[i].type == PTR_TO_PACKET && regs[i].id == dst_reg->id)
Alexei Starovoitovb1977682017-03-24 15:57:33 -07001976 /* keep the maximum range already checked */
1977 regs[i].range = max(regs[i].range, dst_reg->off);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001978
1979 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
1980 if (state->stack_slot_type[i] != STACK_SPILL)
1981 continue;
1982 reg = &state->spilled_regs[i / BPF_REG_SIZE];
1983 if (reg->type == PTR_TO_PACKET && reg->id == dst_reg->id)
Alexei Starovoitovb1977682017-03-24 15:57:33 -07001984 reg->range = max(reg->range, dst_reg->off);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001985 }
1986}
1987
Josef Bacik48461132016-09-28 10:54:32 -04001988/* Adjusts the register min/max values in the case that the dst_reg is the
1989 * variable register that we are working on, and src_reg is a constant or we're
1990 * simply doing a BPF_K check.
1991 */
1992static void reg_set_min_max(struct bpf_reg_state *true_reg,
1993 struct bpf_reg_state *false_reg, u64 val,
1994 u8 opcode)
1995{
1996 switch (opcode) {
1997 case BPF_JEQ:
1998 /* If this is false then we know nothing Jon Snow, but if it is
1999 * true then we know for sure.
2000 */
2001 true_reg->max_value = true_reg->min_value = val;
2002 break;
2003 case BPF_JNE:
2004 /* If this is true we know nothing Jon Snow, but if it is false
2005 * we know the value for sure;
2006 */
2007 false_reg->max_value = false_reg->min_value = val;
2008 break;
2009 case BPF_JGT:
2010 /* Unsigned comparison, the minimum value is 0. */
2011 false_reg->min_value = 0;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +01002012 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002013 case BPF_JSGT:
2014 /* If this is false then we know the maximum val is val,
2015 * otherwise we know the min val is val+1.
2016 */
2017 false_reg->max_value = val;
2018 true_reg->min_value = val + 1;
2019 break;
2020 case BPF_JGE:
2021 /* Unsigned comparison, the minimum value is 0. */
2022 false_reg->min_value = 0;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +01002023 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002024 case BPF_JSGE:
2025 /* If this is false then we know the maximum value is val - 1,
2026 * otherwise we know the mimimum value is val.
2027 */
2028 false_reg->max_value = val - 1;
2029 true_reg->min_value = val;
2030 break;
2031 default:
2032 break;
2033 }
2034
2035 check_reg_overflow(false_reg);
2036 check_reg_overflow(true_reg);
2037}
2038
2039/* Same as above, but for the case that dst_reg is a CONST_IMM reg and src_reg
2040 * is the variable reg.
2041 */
2042static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
2043 struct bpf_reg_state *false_reg, u64 val,
2044 u8 opcode)
2045{
2046 switch (opcode) {
2047 case BPF_JEQ:
2048 /* If this is false then we know nothing Jon Snow, but if it is
2049 * true then we know for sure.
2050 */
2051 true_reg->max_value = true_reg->min_value = val;
2052 break;
2053 case BPF_JNE:
2054 /* If this is true we know nothing Jon Snow, but if it is false
2055 * we know the value for sure;
2056 */
2057 false_reg->max_value = false_reg->min_value = val;
2058 break;
2059 case BPF_JGT:
2060 /* Unsigned comparison, the minimum value is 0. */
2061 true_reg->min_value = 0;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +01002062 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002063 case BPF_JSGT:
2064 /*
2065 * If this is false, then the val is <= the register, if it is
2066 * true the register <= to the val.
2067 */
2068 false_reg->min_value = val;
2069 true_reg->max_value = val - 1;
2070 break;
2071 case BPF_JGE:
2072 /* Unsigned comparison, the minimum value is 0. */
2073 true_reg->min_value = 0;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +01002074 /* fallthrough */
Josef Bacik48461132016-09-28 10:54:32 -04002075 case BPF_JSGE:
2076 /* If this is false then constant < register, if it is true then
2077 * the register < constant.
2078 */
2079 false_reg->min_value = val + 1;
2080 true_reg->max_value = val;
2081 break;
2082 default:
2083 break;
2084 }
2085
2086 check_reg_overflow(false_reg);
2087 check_reg_overflow(true_reg);
2088}
2089
Thomas Graf57a09bf2016-10-18 19:51:19 +02002090static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
2091 enum bpf_reg_type type)
2092{
2093 struct bpf_reg_state *reg = &regs[regno];
2094
2095 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
2096 reg->type = type;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002097 /* We don't need id from this point onwards anymore, thus we
2098 * should better reset it, so that state pruning has chances
2099 * to take effect.
2100 */
2101 reg->id = 0;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002102 if (type == UNKNOWN_VALUE)
Daniel Borkmann6760bf22016-12-18 01:52:59 +01002103 __mark_reg_unknown_value(regs, regno);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002104 }
2105}
2106
2107/* The logic is similar to find_good_pkt_pointers(), both could eventually
2108 * be folded together at some point.
2109 */
2110static void mark_map_regs(struct bpf_verifier_state *state, u32 regno,
2111 enum bpf_reg_type type)
2112{
2113 struct bpf_reg_state *regs = state->regs;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002114 u32 id = regs[regno].id;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002115 int i;
2116
2117 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002118 mark_map_reg(regs, i, id, type);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002119
2120 for (i = 0; i < MAX_BPF_STACK; i += BPF_REG_SIZE) {
2121 if (state->stack_slot_type[i] != STACK_SPILL)
2122 continue;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01002123 mark_map_reg(state->spilled_regs, i / BPF_REG_SIZE, id, type);
Thomas Graf57a09bf2016-10-18 19:51:19 +02002124 }
2125}
2126
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002127static int check_cond_jmp_op(struct bpf_verifier_env *env,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002128 struct bpf_insn *insn, int *insn_idx)
2129{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002130 struct bpf_verifier_state *other_branch, *this_branch = &env->cur_state;
2131 struct bpf_reg_state *regs = this_branch->regs, *dst_reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002132 u8 opcode = BPF_OP(insn->code);
2133 int err;
2134
2135 if (opcode > BPF_EXIT) {
2136 verbose("invalid BPF_JMP opcode %x\n", opcode);
2137 return -EINVAL;
2138 }
2139
2140 if (BPF_SRC(insn->code) == BPF_X) {
2141 if (insn->imm != 0) {
2142 verbose("BPF_JMP uses reserved fields\n");
2143 return -EINVAL;
2144 }
2145
2146 /* check src1 operand */
2147 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2148 if (err)
2149 return err;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002150
2151 if (is_pointer_value(env, insn->src_reg)) {
2152 verbose("R%d pointer comparison prohibited\n",
2153 insn->src_reg);
2154 return -EACCES;
2155 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002156 } else {
2157 if (insn->src_reg != BPF_REG_0) {
2158 verbose("BPF_JMP uses reserved fields\n");
2159 return -EINVAL;
2160 }
2161 }
2162
2163 /* check src2 operand */
2164 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
2165 if (err)
2166 return err;
2167
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002168 dst_reg = &regs[insn->dst_reg];
2169
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002170 /* detect if R == 0 where R was initialized to zero earlier */
2171 if (BPF_SRC(insn->code) == BPF_K &&
2172 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002173 dst_reg->type == CONST_IMM && dst_reg->imm == insn->imm) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002174 if (opcode == BPF_JEQ) {
2175 /* if (imm == imm) goto pc+off;
2176 * only follow the goto, ignore fall-through
2177 */
2178 *insn_idx += insn->off;
2179 return 0;
2180 } else {
2181 /* if (imm != imm) goto pc+off;
2182 * only follow fall-through branch, since
2183 * that's where the program will go
2184 */
2185 return 0;
2186 }
2187 }
2188
2189 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
2190 if (!other_branch)
2191 return -EFAULT;
2192
Josef Bacik48461132016-09-28 10:54:32 -04002193 /* detect if we are comparing against a constant value so we can adjust
2194 * our min/max values for our dst register.
2195 */
2196 if (BPF_SRC(insn->code) == BPF_X) {
2197 if (regs[insn->src_reg].type == CONST_IMM)
2198 reg_set_min_max(&other_branch->regs[insn->dst_reg],
2199 dst_reg, regs[insn->src_reg].imm,
2200 opcode);
2201 else if (dst_reg->type == CONST_IMM)
2202 reg_set_min_max_inv(&other_branch->regs[insn->src_reg],
2203 &regs[insn->src_reg], dst_reg->imm,
2204 opcode);
2205 } else {
2206 reg_set_min_max(&other_branch->regs[insn->dst_reg],
2207 dst_reg, insn->imm, opcode);
2208 }
2209
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002210 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002211 if (BPF_SRC(insn->code) == BPF_K &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002212 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
2213 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Thomas Graf57a09bf2016-10-18 19:51:19 +02002214 /* Mark all identical map registers in each branch as either
2215 * safe or unknown depending R == 0 or R != 0 conditional.
2216 */
2217 mark_map_regs(this_branch, insn->dst_reg,
2218 opcode == BPF_JEQ ? PTR_TO_MAP_VALUE : UNKNOWN_VALUE);
2219 mark_map_regs(other_branch, insn->dst_reg,
2220 opcode == BPF_JEQ ? UNKNOWN_VALUE : PTR_TO_MAP_VALUE);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002221 } else if (BPF_SRC(insn->code) == BPF_X && opcode == BPF_JGT &&
2222 dst_reg->type == PTR_TO_PACKET &&
2223 regs[insn->src_reg].type == PTR_TO_PACKET_END) {
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002224 find_good_pkt_pointers(this_branch, dst_reg);
2225 } else if (BPF_SRC(insn->code) == BPF_X && opcode == BPF_JGE &&
2226 dst_reg->type == PTR_TO_PACKET_END &&
2227 regs[insn->src_reg].type == PTR_TO_PACKET) {
2228 find_good_pkt_pointers(other_branch, &regs[insn->src_reg]);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002229 } else if (is_pointer_value(env, insn->dst_reg)) {
2230 verbose("R%d pointer comparison prohibited\n", insn->dst_reg);
2231 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002232 }
2233 if (log_level)
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02002234 print_verifier_state(this_branch);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002235 return 0;
2236}
2237
Alexei Starovoitov0246e642014-09-26 00:17:04 -07002238/* return the map pointer stored inside BPF_LD_IMM64 instruction */
2239static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
2240{
2241 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
2242
2243 return (struct bpf_map *) (unsigned long) imm64;
2244}
2245
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002246/* verify BPF_LD_IMM64 instruction */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002247static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002248{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002249 struct bpf_reg_state *regs = env->cur_state.regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002250 int err;
2251
2252 if (BPF_SIZE(insn->code) != BPF_DW) {
2253 verbose("invalid BPF_LD_IMM insn\n");
2254 return -EINVAL;
2255 }
2256 if (insn->off != 0) {
2257 verbose("BPF_LD_IMM64 uses reserved fields\n");
2258 return -EINVAL;
2259 }
2260
2261 err = check_reg_arg(regs, insn->dst_reg, DST_OP);
2262 if (err)
2263 return err;
2264
Jakub Kicinski6b173872016-09-21 11:43:59 +01002265 if (insn->src_reg == 0) {
Jakub Kicinski6b173872016-09-21 11:43:59 +01002266 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
2267
Jakub Kicinski6b173872016-09-21 11:43:59 +01002268 regs[insn->dst_reg].type = CONST_IMM;
2269 regs[insn->dst_reg].imm = imm;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002270 return 0;
Jakub Kicinski6b173872016-09-21 11:43:59 +01002271 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002272
2273 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
2274 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
2275
2276 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
2277 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
2278 return 0;
2279}
2280
Daniel Borkmann96be4322015-03-01 12:31:46 +01002281static bool may_access_skb(enum bpf_prog_type type)
2282{
2283 switch (type) {
2284 case BPF_PROG_TYPE_SOCKET_FILTER:
2285 case BPF_PROG_TYPE_SCHED_CLS:
Daniel Borkmann94caee8c2015-03-20 15:11:11 +01002286 case BPF_PROG_TYPE_SCHED_ACT:
Daniel Borkmann96be4322015-03-01 12:31:46 +01002287 return true;
2288 default:
2289 return false;
2290 }
2291}
2292
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002293/* verify safety of LD_ABS|LD_IND instructions:
2294 * - they can only appear in the programs where ctx == skb
2295 * - since they are wrappers of function calls, they scratch R1-R5 registers,
2296 * preserve R6-R9, and store return value into R0
2297 *
2298 * Implicit input:
2299 * ctx == skb == R6 == CTX
2300 *
2301 * Explicit input:
2302 * SRC == any register
2303 * IMM == 32-bit immediate
2304 *
2305 * Output:
2306 * R0 - 8/16/32-bit skb data converted to cpu endianness
2307 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002308static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002309{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002310 struct bpf_reg_state *regs = env->cur_state.regs;
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002311 u8 mode = BPF_MODE(insn->code);
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002312 struct bpf_reg_state *reg;
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002313 int i, err;
2314
Daniel Borkmann24701ec2015-03-01 12:31:47 +01002315 if (!may_access_skb(env->prog->type)) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002316 verbose("BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002317 return -EINVAL;
2318 }
2319
2320 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
Alexei Starovoitovd82bccc2016-04-12 10:26:19 -07002321 BPF_SIZE(insn->code) == BPF_DW ||
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002322 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002323 verbose("BPF_LD_[ABS|IND] uses reserved fields\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08002324 return -EINVAL;
2325 }
2326
2327 /* check whether implicit source operand (register R6) is readable */
2328 err = check_reg_arg(regs, BPF_REG_6, SRC_OP);
2329 if (err)
2330 return err;
2331
2332 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
2333 verbose("at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
2334 return -EINVAL;
2335 }
2336
2337 if (mode == BPF_IND) {
2338 /* check explicit source operand */
2339 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2340 if (err)
2341 return err;
2342 }
2343
2344 /* reset caller saved regs to unreadable */
2345 for (i = 0; i < CALLER_SAVED_REGS; i++) {
2346 reg = regs + caller_saved[i];
2347 reg->type = NOT_INIT;
2348 reg->imm = 0;
2349 }
2350
2351 /* mark destination R0 register as readable, since it contains
2352 * the value fetched from the packet
2353 */
2354 regs[BPF_REG_0].type = UNKNOWN_VALUE;
2355 return 0;
2356}
2357
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002358/* non-recursive DFS pseudo code
2359 * 1 procedure DFS-iterative(G,v):
2360 * 2 label v as discovered
2361 * 3 let S be a stack
2362 * 4 S.push(v)
2363 * 5 while S is not empty
2364 * 6 t <- S.pop()
2365 * 7 if t is what we're looking for:
2366 * 8 return t
2367 * 9 for all edges e in G.adjacentEdges(t) do
2368 * 10 if edge e is already labelled
2369 * 11 continue with the next edge
2370 * 12 w <- G.adjacentVertex(t,e)
2371 * 13 if vertex w is not discovered and not explored
2372 * 14 label e as tree-edge
2373 * 15 label w as discovered
2374 * 16 S.push(w)
2375 * 17 continue at 5
2376 * 18 else if vertex w is discovered
2377 * 19 label e as back-edge
2378 * 20 else
2379 * 21 // vertex w is explored
2380 * 22 label e as forward- or cross-edge
2381 * 23 label t as explored
2382 * 24 S.pop()
2383 *
2384 * convention:
2385 * 0x10 - discovered
2386 * 0x11 - discovered and fall-through edge labelled
2387 * 0x12 - discovered and fall-through and branch edges labelled
2388 * 0x20 - explored
2389 */
2390
2391enum {
2392 DISCOVERED = 0x10,
2393 EXPLORED = 0x20,
2394 FALLTHROUGH = 1,
2395 BRANCH = 2,
2396};
2397
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002398#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002399
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002400static int *insn_stack; /* stack of insns to process */
2401static int cur_stack; /* current stack index */
2402static int *insn_state;
2403
2404/* t, w, e - match pseudo-code above:
2405 * t - index of current instruction
2406 * w - next instruction
2407 * e - edge
2408 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002409static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002410{
2411 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
2412 return 0;
2413
2414 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
2415 return 0;
2416
2417 if (w < 0 || w >= env->prog->len) {
2418 verbose("jump out of range from insn %d to %d\n", t, w);
2419 return -EINVAL;
2420 }
2421
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002422 if (e == BRANCH)
2423 /* mark branch target for state pruning */
2424 env->explored_states[w] = STATE_LIST_MARK;
2425
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002426 if (insn_state[w] == 0) {
2427 /* tree-edge */
2428 insn_state[t] = DISCOVERED | e;
2429 insn_state[w] = DISCOVERED;
2430 if (cur_stack >= env->prog->len)
2431 return -E2BIG;
2432 insn_stack[cur_stack++] = w;
2433 return 1;
2434 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
2435 verbose("back-edge from insn %d to %d\n", t, w);
2436 return -EINVAL;
2437 } else if (insn_state[w] == EXPLORED) {
2438 /* forward- or cross-edge */
2439 insn_state[t] = DISCOVERED | e;
2440 } else {
2441 verbose("insn state internal bug\n");
2442 return -EFAULT;
2443 }
2444 return 0;
2445}
2446
2447/* non-recursive depth-first-search to detect loops in BPF program
2448 * loop == back-edge in directed graph
2449 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002450static int check_cfg(struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002451{
2452 struct bpf_insn *insns = env->prog->insnsi;
2453 int insn_cnt = env->prog->len;
2454 int ret = 0;
2455 int i, t;
2456
2457 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
2458 if (!insn_state)
2459 return -ENOMEM;
2460
2461 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
2462 if (!insn_stack) {
2463 kfree(insn_state);
2464 return -ENOMEM;
2465 }
2466
2467 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
2468 insn_stack[0] = 0; /* 0 is the first instruction */
2469 cur_stack = 1;
2470
2471peek_stack:
2472 if (cur_stack == 0)
2473 goto check_state;
2474 t = insn_stack[cur_stack - 1];
2475
2476 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
2477 u8 opcode = BPF_OP(insns[t].code);
2478
2479 if (opcode == BPF_EXIT) {
2480 goto mark_explored;
2481 } else if (opcode == BPF_CALL) {
2482 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2483 if (ret == 1)
2484 goto peek_stack;
2485 else if (ret < 0)
2486 goto err_free;
Daniel Borkmann07016152016-04-05 22:33:17 +02002487 if (t + 1 < insn_cnt)
2488 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002489 } else if (opcode == BPF_JA) {
2490 if (BPF_SRC(insns[t].code) != BPF_K) {
2491 ret = -EINVAL;
2492 goto err_free;
2493 }
2494 /* unconditional jump with single edge */
2495 ret = push_insn(t, t + insns[t].off + 1,
2496 FALLTHROUGH, env);
2497 if (ret == 1)
2498 goto peek_stack;
2499 else if (ret < 0)
2500 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002501 /* tell verifier to check for equivalent states
2502 * after every call and jump
2503 */
Alexei Starovoitovc3de6312015-04-14 15:57:13 -07002504 if (t + 1 < insn_cnt)
2505 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07002506 } else {
2507 /* conditional jump with two edges */
2508 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2509 if (ret == 1)
2510 goto peek_stack;
2511 else if (ret < 0)
2512 goto err_free;
2513
2514 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
2515 if (ret == 1)
2516 goto peek_stack;
2517 else if (ret < 0)
2518 goto err_free;
2519 }
2520 } else {
2521 /* all other non-branch instructions with single
2522 * fall-through edge
2523 */
2524 ret = push_insn(t, t + 1, FALLTHROUGH, env);
2525 if (ret == 1)
2526 goto peek_stack;
2527 else if (ret < 0)
2528 goto err_free;
2529 }
2530
2531mark_explored:
2532 insn_state[t] = EXPLORED;
2533 if (cur_stack-- <= 0) {
2534 verbose("pop stack internal bug\n");
2535 ret = -EFAULT;
2536 goto err_free;
2537 }
2538 goto peek_stack;
2539
2540check_state:
2541 for (i = 0; i < insn_cnt; i++) {
2542 if (insn_state[i] != EXPLORED) {
2543 verbose("unreachable insn %d\n", i);
2544 ret = -EINVAL;
2545 goto err_free;
2546 }
2547 }
2548 ret = 0; /* cfg looks good */
2549
2550err_free:
2551 kfree(insn_state);
2552 kfree(insn_stack);
2553 return ret;
2554}
2555
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002556/* the following conditions reduce the number of explored insns
2557 * from ~140k to ~80k for ultra large programs that use a lot of ptr_to_packet
2558 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002559static bool compare_ptrs_to_packet(struct bpf_reg_state *old,
2560 struct bpf_reg_state *cur)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002561{
2562 if (old->id != cur->id)
2563 return false;
2564
2565 /* old ptr_to_packet is more conservative, since it allows smaller
2566 * range. Ex:
2567 * old(off=0,r=10) is equal to cur(off=0,r=20), because
2568 * old(off=0,r=10) means that with range=10 the verifier proceeded
2569 * further and found no issues with the program. Now we're in the same
2570 * spot with cur(off=0,r=20), so we're safe too, since anything further
2571 * will only be looking at most 10 bytes after this pointer.
2572 */
2573 if (old->off == cur->off && old->range < cur->range)
2574 return true;
2575
2576 /* old(off=20,r=10) is equal to cur(off=22,re=22 or 5 or 0)
2577 * since both cannot be used for packet access and safe(old)
2578 * pointer has smaller off that could be used for further
2579 * 'if (ptr > data_end)' check
2580 * Ex:
2581 * old(off=20,r=10) and cur(off=22,r=22) and cur(off=22,r=0) mean
2582 * that we cannot access the packet.
2583 * The safe range is:
2584 * [ptr, ptr + range - off)
2585 * so whenever off >=range, it means no safe bytes from this pointer.
2586 * When comparing old->off <= cur->off, it means that older code
2587 * went with smaller offset and that offset was later
2588 * used to figure out the safe range after 'if (ptr > data_end)' check
2589 * Say, 'old' state was explored like:
2590 * ... R3(off=0, r=0)
2591 * R4 = R3 + 20
2592 * ... now R4(off=20,r=0) <-- here
2593 * if (R4 > data_end)
2594 * ... R4(off=20,r=20), R3(off=0,r=20) and R3 can be used to access.
2595 * ... the code further went all the way to bpf_exit.
2596 * Now the 'cur' state at the mark 'here' has R4(off=30,r=0).
2597 * old_R4(off=20,r=0) equal to cur_R4(off=30,r=0), since if the verifier
2598 * goes further, such cur_R4 will give larger safe packet range after
2599 * 'if (R4 > data_end)' and all further insn were already good with r=20,
2600 * so they will be good with r=30 and we can prune the search.
2601 */
2602 if (old->off <= cur->off &&
2603 old->off >= old->range && cur->off >= cur->range)
2604 return true;
2605
2606 return false;
2607}
2608
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002609/* compare two verifier states
2610 *
2611 * all states stored in state_list are known to be valid, since
2612 * verifier reached 'bpf_exit' instruction through them
2613 *
2614 * this function is called when verifier exploring different branches of
2615 * execution popped from the state stack. If it sees an old state that has
2616 * more strict register state and more strict stack state then this execution
2617 * branch doesn't need to be explored further, since verifier already
2618 * concluded that more strict state leads to valid finish.
2619 *
2620 * Therefore two states are equivalent if register state is more conservative
2621 * and explored stack state is more conservative than the current one.
2622 * Example:
2623 * explored current
2624 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
2625 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
2626 *
2627 * In other words if current stack state (one being explored) has more
2628 * valid slots than old one that already passed validation, it means
2629 * the verifier can stop exploring and conclude that current state is valid too
2630 *
2631 * Similarly with registers. If explored state has register type as invalid
2632 * whereas register type in current state is meaningful, it means that
2633 * the current state will reach 'bpf_exit' instruction safely
2634 */
Josef Bacik48461132016-09-28 10:54:32 -04002635static bool states_equal(struct bpf_verifier_env *env,
2636 struct bpf_verifier_state *old,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002637 struct bpf_verifier_state *cur)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002638{
Josef Bacike2d2afe2016-11-29 12:27:09 -05002639 bool varlen_map_access = env->varlen_map_value_access;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002640 struct bpf_reg_state *rold, *rcur;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002641 int i;
2642
2643 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002644 rold = &old->regs[i];
2645 rcur = &cur->regs[i];
2646
2647 if (memcmp(rold, rcur, sizeof(*rold)) == 0)
2648 continue;
2649
Josef Bacik48461132016-09-28 10:54:32 -04002650 /* If the ranges were not the same, but everything else was and
2651 * we didn't do a variable access into a map then we are a-ok.
2652 */
Josef Bacike2d2afe2016-11-29 12:27:09 -05002653 if (!varlen_map_access &&
Alexei Starovoitovd2a4dd32016-12-07 10:57:59 -08002654 memcmp(rold, rcur, offsetofend(struct bpf_reg_state, id)) == 0)
Josef Bacik48461132016-09-28 10:54:32 -04002655 continue;
2656
Josef Bacike2d2afe2016-11-29 12:27:09 -05002657 /* If we didn't map access then again we don't care about the
2658 * mismatched range values and it's ok if our old type was
2659 * UNKNOWN and we didn't go to a NOT_INIT'ed reg.
2660 */
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002661 if (rold->type == NOT_INIT ||
Josef Bacike2d2afe2016-11-29 12:27:09 -05002662 (!varlen_map_access && rold->type == UNKNOWN_VALUE &&
2663 rcur->type != NOT_INIT))
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002664 continue;
2665
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002666 if (rold->type == PTR_TO_PACKET && rcur->type == PTR_TO_PACKET &&
2667 compare_ptrs_to_packet(rold, rcur))
2668 continue;
2669
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002670 return false;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002671 }
2672
2673 for (i = 0; i < MAX_BPF_STACK; i++) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002674 if (old->stack_slot_type[i] == STACK_INVALID)
2675 continue;
2676 if (old->stack_slot_type[i] != cur->stack_slot_type[i])
2677 /* Ex: old explored (safe) state has STACK_SPILL in
2678 * this stack slot, but current has has STACK_MISC ->
2679 * this verifier states are not equivalent,
2680 * return false to continue verification of this path
2681 */
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002682 return false;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002683 if (i % BPF_REG_SIZE)
2684 continue;
2685 if (memcmp(&old->spilled_regs[i / BPF_REG_SIZE],
2686 &cur->spilled_regs[i / BPF_REG_SIZE],
2687 sizeof(old->spilled_regs[0])))
2688 /* when explored and current stack slot types are
2689 * the same, check that stored pointers types
2690 * are the same as well.
2691 * Ex: explored safe path could have stored
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002692 * (bpf_reg_state) {.type = PTR_TO_STACK, .imm = -8}
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002693 * but current path has stored:
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002694 * (bpf_reg_state) {.type = PTR_TO_STACK, .imm = -16}
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07002695 * such verifier states are not equivalent.
2696 * return false to continue verification of this path
2697 */
2698 return false;
2699 else
2700 continue;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002701 }
2702 return true;
2703}
2704
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002705static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002706{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002707 struct bpf_verifier_state_list *new_sl;
2708 struct bpf_verifier_state_list *sl;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002709
2710 sl = env->explored_states[insn_idx];
2711 if (!sl)
2712 /* this 'insn_idx' instruction wasn't marked, so we will not
2713 * be doing state search here
2714 */
2715 return 0;
2716
2717 while (sl != STATE_LIST_MARK) {
Josef Bacik48461132016-09-28 10:54:32 -04002718 if (states_equal(env, &sl->state, &env->cur_state))
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002719 /* reached equivalent register/stack state,
2720 * prune the search
2721 */
2722 return 1;
2723 sl = sl->next;
2724 }
2725
2726 /* there were no equivalent states, remember current one.
2727 * technically the current state is not proven to be safe yet,
2728 * but it will either reach bpf_exit (which means it's safe) or
2729 * it will be rejected. Since there are no loops, we won't be
2730 * seeing this 'insn_idx' instruction again on the way to bpf_exit
2731 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002732 new_sl = kmalloc(sizeof(struct bpf_verifier_state_list), GFP_USER);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002733 if (!new_sl)
2734 return -ENOMEM;
2735
2736 /* add new state to the head of linked list */
2737 memcpy(&new_sl->state, &env->cur_state, sizeof(env->cur_state));
2738 new_sl->next = env->explored_states[insn_idx];
2739 env->explored_states[insn_idx] = new_sl;
2740 return 0;
2741}
2742
Jakub Kicinski13a27df2016-09-21 11:43:58 +01002743static int ext_analyzer_insn_hook(struct bpf_verifier_env *env,
2744 int insn_idx, int prev_insn_idx)
2745{
2746 if (!env->analyzer_ops || !env->analyzer_ops->insn_hook)
2747 return 0;
2748
2749 return env->analyzer_ops->insn_hook(env, insn_idx, prev_insn_idx);
2750}
2751
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002752static int do_check(struct bpf_verifier_env *env)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002753{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002754 struct bpf_verifier_state *state = &env->cur_state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002755 struct bpf_insn *insns = env->prog->insnsi;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002756 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002757 int insn_cnt = env->prog->len;
2758 int insn_idx, prev_insn_idx = 0;
2759 int insn_processed = 0;
2760 bool do_print_state = false;
2761
2762 init_reg_state(regs);
2763 insn_idx = 0;
Josef Bacik48461132016-09-28 10:54:32 -04002764 env->varlen_map_value_access = false;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002765 for (;;) {
2766 struct bpf_insn *insn;
2767 u8 class;
2768 int err;
2769
2770 if (insn_idx >= insn_cnt) {
2771 verbose("invalid insn idx %d insn_cnt %d\n",
2772 insn_idx, insn_cnt);
2773 return -EFAULT;
2774 }
2775
2776 insn = &insns[insn_idx];
2777 class = BPF_CLASS(insn->code);
2778
Daniel Borkmann07016152016-04-05 22:33:17 +02002779 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
Colin Ian Kingbc1750f2017-02-23 00:20:53 +00002780 verbose("BPF program is too large. Processed %d insn\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002781 insn_processed);
2782 return -E2BIG;
2783 }
2784
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002785 err = is_state_visited(env, insn_idx);
2786 if (err < 0)
2787 return err;
2788 if (err == 1) {
2789 /* found equivalent state, can prune the search */
2790 if (log_level) {
2791 if (do_print_state)
2792 verbose("\nfrom %d to %d: safe\n",
2793 prev_insn_idx, insn_idx);
2794 else
2795 verbose("%d: safe\n", insn_idx);
2796 }
2797 goto process_bpf_exit;
2798 }
2799
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002800 if (log_level && do_print_state) {
2801 verbose("\nfrom %d to %d:", prev_insn_idx, insn_idx);
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07002802 print_verifier_state(&env->cur_state);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002803 do_print_state = false;
2804 }
2805
2806 if (log_level) {
2807 verbose("%d: ", insn_idx);
2808 print_bpf_insn(insn);
2809 }
2810
Jakub Kicinski13a27df2016-09-21 11:43:58 +01002811 err = ext_analyzer_insn_hook(env, insn_idx, prev_insn_idx);
2812 if (err)
2813 return err;
2814
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002815 if (class == BPF_ALU || class == BPF_ALU64) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002816 err = check_alu_op(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002817 if (err)
2818 return err;
2819
2820 } else if (class == BPF_LDX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002821 enum bpf_reg_type *prev_src_type, src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002822
2823 /* check for reserved fields is already done */
2824
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002825 /* check src operand */
2826 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2827 if (err)
2828 return err;
2829
2830 err = check_reg_arg(regs, insn->dst_reg, DST_OP_NO_MARK);
2831 if (err)
2832 return err;
2833
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07002834 src_reg_type = regs[insn->src_reg].type;
2835
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002836 /* check that memory (src_reg + off) is readable,
2837 * the state of dst_reg will be updated by this func
2838 */
2839 err = check_mem_access(env, insn->src_reg, insn->off,
2840 BPF_SIZE(insn->code), BPF_READ,
2841 insn->dst_reg);
2842 if (err)
2843 return err;
2844
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07002845 if (BPF_SIZE(insn->code) != BPF_W &&
2846 BPF_SIZE(insn->code) != BPF_DW) {
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07002847 insn_idx++;
2848 continue;
2849 }
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002850
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002851 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
2852
2853 if (*prev_src_type == NOT_INIT) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002854 /* saw a valid insn
2855 * dst_reg = *(u32 *)(src_reg + off)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002856 * save type to validate intersecting paths
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002857 */
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002858 *prev_src_type = src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002859
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002860 } else if (src_reg_type != *prev_src_type &&
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002861 (src_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002862 *prev_src_type == PTR_TO_CTX)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07002863 /* ABuser program is trying to use the same insn
2864 * dst_reg = *(u32*) (src_reg + off)
2865 * with different pointer types:
2866 * src_reg == ctx in one branch and
2867 * src_reg == stack|map in some other branch.
2868 * Reject it.
2869 */
2870 verbose("same insn cannot be used with different pointers\n");
2871 return -EINVAL;
2872 }
2873
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002874 } else if (class == BPF_STX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002875 enum bpf_reg_type *prev_dst_type, dst_reg_type;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07002876
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002877 if (BPF_MODE(insn->code) == BPF_XADD) {
2878 err = check_xadd(env, insn);
2879 if (err)
2880 return err;
2881 insn_idx++;
2882 continue;
2883 }
2884
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002885 /* check src1 operand */
2886 err = check_reg_arg(regs, insn->src_reg, SRC_OP);
2887 if (err)
2888 return err;
2889 /* check src2 operand */
2890 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
2891 if (err)
2892 return err;
2893
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07002894 dst_reg_type = regs[insn->dst_reg].type;
2895
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002896 /* check that memory (dst_reg + off) is writeable */
2897 err = check_mem_access(env, insn->dst_reg, insn->off,
2898 BPF_SIZE(insn->code), BPF_WRITE,
2899 insn->src_reg);
2900 if (err)
2901 return err;
2902
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002903 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
2904
2905 if (*prev_dst_type == NOT_INIT) {
2906 *prev_dst_type = dst_reg_type;
2907 } else if (dst_reg_type != *prev_dst_type &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07002908 (dst_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01002909 *prev_dst_type == PTR_TO_CTX)) {
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07002910 verbose("same insn cannot be used with different pointers\n");
2911 return -EINVAL;
2912 }
2913
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002914 } else if (class == BPF_ST) {
2915 if (BPF_MODE(insn->code) != BPF_MEM ||
2916 insn->src_reg != BPF_REG_0) {
2917 verbose("BPF_ST uses reserved fields\n");
2918 return -EINVAL;
2919 }
2920 /* check src operand */
2921 err = check_reg_arg(regs, insn->dst_reg, SRC_OP);
2922 if (err)
2923 return err;
2924
2925 /* check that memory (dst_reg + off) is writeable */
2926 err = check_mem_access(env, insn->dst_reg, insn->off,
2927 BPF_SIZE(insn->code), BPF_WRITE,
2928 -1);
2929 if (err)
2930 return err;
2931
2932 } else if (class == BPF_JMP) {
2933 u8 opcode = BPF_OP(insn->code);
2934
2935 if (opcode == BPF_CALL) {
2936 if (BPF_SRC(insn->code) != BPF_K ||
2937 insn->off != 0 ||
2938 insn->src_reg != BPF_REG_0 ||
2939 insn->dst_reg != BPF_REG_0) {
2940 verbose("BPF_CALL uses reserved fields\n");
2941 return -EINVAL;
2942 }
2943
2944 err = check_call(env, insn->imm);
2945 if (err)
2946 return err;
2947
2948 } else if (opcode == BPF_JA) {
2949 if (BPF_SRC(insn->code) != BPF_K ||
2950 insn->imm != 0 ||
2951 insn->src_reg != BPF_REG_0 ||
2952 insn->dst_reg != BPF_REG_0) {
2953 verbose("BPF_JA uses reserved fields\n");
2954 return -EINVAL;
2955 }
2956
2957 insn_idx += insn->off + 1;
2958 continue;
2959
2960 } else if (opcode == BPF_EXIT) {
2961 if (BPF_SRC(insn->code) != BPF_K ||
2962 insn->imm != 0 ||
2963 insn->src_reg != BPF_REG_0 ||
2964 insn->dst_reg != BPF_REG_0) {
2965 verbose("BPF_EXIT uses reserved fields\n");
2966 return -EINVAL;
2967 }
2968
2969 /* eBPF calling convetion is such that R0 is used
2970 * to return the value from eBPF program.
2971 * Make sure that it's readable at this time
2972 * of bpf_exit, which means that program wrote
2973 * something into it earlier
2974 */
2975 err = check_reg_arg(regs, BPF_REG_0, SRC_OP);
2976 if (err)
2977 return err;
2978
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07002979 if (is_pointer_value(env, BPF_REG_0)) {
2980 verbose("R0 leaks addr as return value\n");
2981 return -EACCES;
2982 }
2983
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07002984process_bpf_exit:
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002985 insn_idx = pop_stack(env, &prev_insn_idx);
2986 if (insn_idx < 0) {
2987 break;
2988 } else {
2989 do_print_state = true;
2990 continue;
2991 }
2992 } else {
2993 err = check_cond_jmp_op(env, insn, &insn_idx);
2994 if (err)
2995 return err;
2996 }
2997 } else if (class == BPF_LD) {
2998 u8 mode = BPF_MODE(insn->code);
2999
3000 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003001 err = check_ld_abs(env, insn);
3002 if (err)
3003 return err;
3004
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003005 } else if (mode == BPF_IMM) {
3006 err = check_ld_imm(env, insn);
3007 if (err)
3008 return err;
3009
3010 insn_idx++;
3011 } else {
3012 verbose("invalid BPF_LD mode\n");
3013 return -EINVAL;
3014 }
Josef Bacik48461132016-09-28 10:54:32 -04003015 reset_reg_range_values(regs, insn->dst_reg);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003016 } else {
3017 verbose("unknown insn class %d\n", class);
3018 return -EINVAL;
3019 }
3020
3021 insn_idx++;
3022 }
3023
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003024 verbose("processed %d insns\n", insn_processed);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003025 return 0;
3026}
3027
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07003028static int check_map_prog_compatibility(struct bpf_map *map,
3029 struct bpf_prog *prog)
3030
3031{
3032 if (prog->type == BPF_PROG_TYPE_PERF_EVENT &&
3033 (map->map_type == BPF_MAP_TYPE_HASH ||
3034 map->map_type == BPF_MAP_TYPE_PERCPU_HASH) &&
3035 (map->map_flags & BPF_F_NO_PREALLOC)) {
3036 verbose("perf_event programs can only use preallocated hash map\n");
3037 return -EINVAL;
3038 }
3039 return 0;
3040}
3041
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003042/* look for pseudo eBPF instructions that access map FDs and
3043 * replace them with actual map pointers
3044 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003045static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003046{
3047 struct bpf_insn *insn = env->prog->insnsi;
3048 int insn_cnt = env->prog->len;
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07003049 int i, j, err;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003050
Daniel Borkmannf1f77142017-01-13 23:38:15 +01003051 err = bpf_prog_calc_tag(env->prog);
Daniel Borkmannaafe6ae2016-12-18 01:52:57 +01003052 if (err)
3053 return err;
3054
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003055 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003056 if (BPF_CLASS(insn->code) == BPF_LDX &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003057 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003058 verbose("BPF_LDX uses reserved fields\n");
3059 return -EINVAL;
3060 }
3061
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003062 if (BPF_CLASS(insn->code) == BPF_STX &&
3063 ((BPF_MODE(insn->code) != BPF_MEM &&
3064 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
3065 verbose("BPF_STX uses reserved fields\n");
3066 return -EINVAL;
3067 }
3068
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003069 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
3070 struct bpf_map *map;
3071 struct fd f;
3072
3073 if (i == insn_cnt - 1 || insn[1].code != 0 ||
3074 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
3075 insn[1].off != 0) {
3076 verbose("invalid bpf_ld_imm64 insn\n");
3077 return -EINVAL;
3078 }
3079
3080 if (insn->src_reg == 0)
3081 /* valid generic load 64-bit imm */
3082 goto next_insn;
3083
3084 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
3085 verbose("unrecognized bpf_ld_imm64 insn\n");
3086 return -EINVAL;
3087 }
3088
3089 f = fdget(insn->imm);
Daniel Borkmannc2101292015-10-29 14:58:07 +01003090 map = __bpf_map_get(f);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003091 if (IS_ERR(map)) {
3092 verbose("fd %d is not pointing to valid bpf_map\n",
3093 insn->imm);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003094 return PTR_ERR(map);
3095 }
3096
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07003097 err = check_map_prog_compatibility(map, env->prog);
3098 if (err) {
3099 fdput(f);
3100 return err;
3101 }
3102
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003103 /* store map pointer inside BPF_LD_IMM64 instruction */
3104 insn[0].imm = (u32) (unsigned long) map;
3105 insn[1].imm = ((u64) (unsigned long) map) >> 32;
3106
3107 /* check whether we recorded this map already */
3108 for (j = 0; j < env->used_map_cnt; j++)
3109 if (env->used_maps[j] == map) {
3110 fdput(f);
3111 goto next_insn;
3112 }
3113
3114 if (env->used_map_cnt >= MAX_USED_MAPS) {
3115 fdput(f);
3116 return -E2BIG;
3117 }
3118
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003119 /* hold the map. If the program is rejected by verifier,
3120 * the map will be released by release_maps() or it
3121 * will be used by the valid program until it's unloaded
3122 * and all maps are released in free_bpf_prog_info()
3123 */
Alexei Starovoitov92117d82016-04-27 18:56:20 -07003124 map = bpf_map_inc(map, false);
3125 if (IS_ERR(map)) {
3126 fdput(f);
3127 return PTR_ERR(map);
3128 }
3129 env->used_maps[env->used_map_cnt++] = map;
3130
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003131 fdput(f);
3132next_insn:
3133 insn++;
3134 i++;
3135 }
3136 }
3137
3138 /* now all pseudo BPF_LD_IMM64 instructions load valid
3139 * 'struct bpf_map *' into a register instead of user map_fd.
3140 * These pointers will be used later by verifier to validate map access.
3141 */
3142 return 0;
3143}
3144
3145/* drop refcnt of maps used by the rejected program */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003146static void release_maps(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003147{
3148 int i;
3149
3150 for (i = 0; i < env->used_map_cnt; i++)
3151 bpf_map_put(env->used_maps[i]);
3152}
3153
3154/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003155static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003156{
3157 struct bpf_insn *insn = env->prog->insnsi;
3158 int insn_cnt = env->prog->len;
3159 int i;
3160
3161 for (i = 0; i < insn_cnt; i++, insn++)
3162 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
3163 insn->src_reg = 0;
3164}
3165
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003166/* convert load instructions that access fields of 'struct __sk_buff'
3167 * into sequence of instructions that access fields of 'struct sk_buff'
3168 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003169static int convert_ctx_accesses(struct bpf_verifier_env *env)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003170{
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003171 const struct bpf_verifier_ops *ops = env->prog->aux->ops;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003172 const int insn_cnt = env->prog->len;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003173 struct bpf_insn insn_buf[16], *insn;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003174 struct bpf_prog *new_prog;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003175 enum bpf_access_type type;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003176 int i, cnt, delta = 0;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003177
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003178 if (ops->gen_prologue) {
3179 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
3180 env->prog);
3181 if (cnt >= ARRAY_SIZE(insn_buf)) {
3182 verbose("bpf verifier is misconfigured\n");
3183 return -EINVAL;
3184 } else if (cnt) {
3185 new_prog = bpf_patch_insn_single(env->prog, 0,
3186 insn_buf, cnt);
3187 if (!new_prog)
3188 return -ENOMEM;
3189 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003190 delta += cnt - 1;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003191 }
3192 }
3193
3194 if (!ops->convert_ctx_access)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003195 return 0;
3196
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003197 insn = env->prog->insnsi + delta;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02003198
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003199 for (i = 0; i < insn_cnt; i++, insn++) {
Daniel Borkmann62c79892017-01-12 11:51:33 +01003200 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
3201 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
3202 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07003203 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003204 type = BPF_READ;
Daniel Borkmann62c79892017-01-12 11:51:33 +01003205 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
3206 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
3207 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07003208 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07003209 type = BPF_WRITE;
3210 else
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003211 continue;
3212
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003213 if (env->insn_aux_data[i].ptr_type != PTR_TO_CTX)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003214 continue;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003215
Daniel Borkmann6b8cc1d2017-01-12 11:51:32 +01003216 cnt = ops->convert_ctx_access(type, insn, insn_buf, env->prog);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003217 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
3218 verbose("bpf verifier is misconfigured\n");
3219 return -EINVAL;
3220 }
3221
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003222 new_prog = bpf_patch_insn_single(env->prog, i + delta, insn_buf,
3223 cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003224 if (!new_prog)
3225 return -ENOMEM;
3226
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003227 delta += cnt - 1;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003228
3229 /* keep walking new program and skip insns we just inserted */
3230 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003231 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003232 }
3233
3234 return 0;
3235}
3236
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003237static void free_states(struct bpf_verifier_env *env)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003238{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003239 struct bpf_verifier_state_list *sl, *sln;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003240 int i;
3241
3242 if (!env->explored_states)
3243 return;
3244
3245 for (i = 0; i < env->prog->len; i++) {
3246 sl = env->explored_states[i];
3247
3248 if (sl)
3249 while (sl != STATE_LIST_MARK) {
3250 sln = sl->next;
3251 kfree(sl);
3252 sl = sln;
3253 }
3254 }
3255
3256 kfree(env->explored_states);
3257}
3258
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003259int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003260{
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003261 char __user *log_ubuf = NULL;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003262 struct bpf_verifier_env *env;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003263 int ret = -EINVAL;
3264
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003265 /* 'struct bpf_verifier_env' can be global, but since it's not small,
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003266 * allocate/free it every time bpf_check() is called
3267 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003268 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003269 if (!env)
3270 return -ENOMEM;
3271
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003272 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
3273 (*prog)->len);
3274 ret = -ENOMEM;
3275 if (!env->insn_aux_data)
3276 goto err_free_env;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003277 env->prog = *prog;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003278
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003279 /* grab the mutex to protect few globals used by verifier */
3280 mutex_lock(&bpf_verifier_lock);
3281
3282 if (attr->log_level || attr->log_buf || attr->log_size) {
3283 /* user requested verbose verifier output
3284 * and supplied buffer to store the verification trace
3285 */
3286 log_level = attr->log_level;
3287 log_ubuf = (char __user *) (unsigned long) attr->log_buf;
3288 log_size = attr->log_size;
3289 log_len = 0;
3290
3291 ret = -EINVAL;
3292 /* log_* values have to be sane */
3293 if (log_size < 128 || log_size > UINT_MAX >> 8 ||
3294 log_level == 0 || log_ubuf == NULL)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003295 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003296
3297 ret = -ENOMEM;
3298 log_buf = vmalloc(log_size);
3299 if (!log_buf)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003300 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003301 } else {
3302 log_level = 0;
3303 }
3304
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003305 ret = replace_map_fd_with_map_ptr(env);
3306 if (ret < 0)
3307 goto skip_full_check;
3308
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003309 env->explored_states = kcalloc(env->prog->len,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003310 sizeof(struct bpf_verifier_state_list *),
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003311 GFP_USER);
3312 ret = -ENOMEM;
3313 if (!env->explored_states)
3314 goto skip_full_check;
3315
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003316 ret = check_cfg(env);
3317 if (ret < 0)
3318 goto skip_full_check;
3319
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003320 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
3321
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003322 ret = do_check(env);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003323
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003324skip_full_check:
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003325 while (pop_stack(env, NULL) >= 0);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003326 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003327
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003328 if (ret == 0)
3329 /* program is valid, convert *(u32*)(ctx + off) accesses */
3330 ret = convert_ctx_accesses(env);
3331
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003332 if (log_level && log_len >= log_size - 1) {
3333 BUG_ON(log_len >= log_size);
3334 /* verifier log exceeded user supplied buffer */
3335 ret = -ENOSPC;
3336 /* fall through to return what was recorded */
3337 }
3338
3339 /* copy verifier log back to user space including trailing zero */
3340 if (log_level && copy_to_user(log_ubuf, log_buf, log_len + 1) != 0) {
3341 ret = -EFAULT;
3342 goto free_log_buf;
3343 }
3344
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003345 if (ret == 0 && env->used_map_cnt) {
3346 /* if program passed verifier, update used_maps in bpf_prog_info */
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003347 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
3348 sizeof(env->used_maps[0]),
3349 GFP_KERNEL);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003350
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003351 if (!env->prog->aux->used_maps) {
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003352 ret = -ENOMEM;
3353 goto free_log_buf;
3354 }
3355
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003356 memcpy(env->prog->aux->used_maps, env->used_maps,
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003357 sizeof(env->used_maps[0]) * env->used_map_cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003358 env->prog->aux->used_map_cnt = env->used_map_cnt;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003359
3360 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
3361 * bpf_ld_imm64 instructions
3362 */
3363 convert_pseudo_ld_imm64(env);
3364 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003365
3366free_log_buf:
3367 if (log_level)
3368 vfree(log_buf);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003369 if (!env->prog->aux->used_maps)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003370 /* if we didn't copy map pointers into bpf_prog_info, release
3371 * them now. Otherwise free_bpf_prog_info() will release them.
3372 */
3373 release_maps(env);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07003374 *prog = env->prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003375err_unlock:
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07003376 mutex_unlock(&bpf_verifier_lock);
Jakub Kicinski3df126f2016-09-21 11:43:56 +01003377 vfree(env->insn_aux_data);
3378err_free_env:
3379 kfree(env);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003380 return ret;
3381}
Jakub Kicinski13a27df2016-09-21 11:43:58 +01003382
3383int bpf_analyzer(struct bpf_prog *prog, const struct bpf_ext_analyzer_ops *ops,
3384 void *priv)
3385{
3386 struct bpf_verifier_env *env;
3387 int ret;
3388
3389 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
3390 if (!env)
3391 return -ENOMEM;
3392
3393 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
3394 prog->len);
3395 ret = -ENOMEM;
3396 if (!env->insn_aux_data)
3397 goto err_free_env;
3398 env->prog = prog;
3399 env->analyzer_ops = ops;
3400 env->analyzer_priv = priv;
3401
3402 /* grab the mutex to protect few globals used by verifier */
3403 mutex_lock(&bpf_verifier_lock);
3404
3405 log_level = 0;
3406
3407 env->explored_states = kcalloc(env->prog->len,
3408 sizeof(struct bpf_verifier_state_list *),
3409 GFP_KERNEL);
3410 ret = -ENOMEM;
3411 if (!env->explored_states)
3412 goto skip_full_check;
3413
3414 ret = check_cfg(env);
3415 if (ret < 0)
3416 goto skip_full_check;
3417
3418 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
3419
3420 ret = do_check(env);
3421
3422skip_full_check:
3423 while (pop_stack(env, NULL) >= 0);
3424 free_states(env);
3425
3426 mutex_unlock(&bpf_verifier_lock);
3427 vfree(env->insn_aux_data);
3428err_free_env:
3429 kfree(env);
3430 return ret;
3431}
3432EXPORT_SYMBOL_GPL(bpf_analyzer);