blob: 8365259a7c5a9fc3ec567385433842286ef34df4 [file] [log] [blame]
Alexei Starovoitov51580e72014-09-26 00:17:02 -07001/* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002 * Copyright (c) 2016 Facebook
Alexei Starovoitov51580e72014-09-26 00:17:02 -07003 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of version 2 of the GNU General Public
6 * License as published by the Free Software Foundation.
7 *
8 * This program is distributed in the hope that it will be useful, but
9 * WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
11 * General Public License for more details.
12 */
13#include <linux/kernel.h>
14#include <linux/types.h>
15#include <linux/slab.h>
16#include <linux/bpf.h>
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +010017#include <linux/bpf_verifier.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070018#include <linux/filter.h>
19#include <net/netlink.h>
20#include <linux/file.h>
21#include <linux/vmalloc.h>
Thomas Grafebb676d2016-10-27 11:23:51 +020022#include <linux/stringify.h>
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -080023#include <linux/bsearch.h>
24#include <linux/sort.h>
Alexei Starovoitov51580e72014-09-26 00:17:02 -070025
Jakub Kicinskif4ac7e02017-10-09 10:30:12 -070026#include "disasm.h"
27
Jakub Kicinski00176a32017-10-16 16:40:54 -070028static const struct bpf_verifier_ops * const bpf_verifier_ops[] = {
29#define BPF_PROG_TYPE(_id, _name) \
30 [_id] = & _name ## _verifier_ops,
31#define BPF_MAP_TYPE(_id, _ops)
32#include <linux/bpf_types.h>
33#undef BPF_PROG_TYPE
34#undef BPF_MAP_TYPE
35};
36
Alexei Starovoitov51580e72014-09-26 00:17:02 -070037/* bpf_check() is a static code analyzer that walks eBPF program
38 * instruction by instruction and updates register/stack state.
39 * All paths of conditional branches are analyzed until 'bpf_exit' insn.
40 *
41 * The first pass is depth-first-search to check that the program is a DAG.
42 * It rejects the following programs:
43 * - larger than BPF_MAXINSNS insns
44 * - if loop is present (detected via back-edge)
45 * - unreachable insns exist (shouldn't be a forest. program = one function)
46 * - out of bounds or malformed jumps
47 * The second pass is all possible path descent from the 1st insn.
48 * Since it's analyzing all pathes through the program, the length of the
Gary Lineba38a92017-03-01 16:25:51 +080049 * analysis is limited to 64k insn, which may be hit even if total number of
Alexei Starovoitov51580e72014-09-26 00:17:02 -070050 * insn is less then 4K, but there are too many branches that change stack/regs.
51 * Number of 'branches to be analyzed' is limited to 1k
52 *
53 * On entry to each instruction, each register has a type, and the instruction
54 * changes the types of the registers depending on instruction semantics.
55 * If instruction is BPF_MOV64_REG(BPF_REG_1, BPF_REG_5), then type of R5 is
56 * copied to R1.
57 *
58 * All registers are 64-bit.
59 * R0 - return register
60 * R1-R5 argument passing registers
61 * R6-R9 callee saved registers
62 * R10 - frame pointer read-only
63 *
64 * At the start of BPF program the register R1 contains a pointer to bpf_context
65 * and has type PTR_TO_CTX.
66 *
67 * Verifier tracks arithmetic operations on pointers in case:
68 * BPF_MOV64_REG(BPF_REG_1, BPF_REG_10),
69 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, -20),
70 * 1st insn copies R10 (which has FRAME_PTR) type into R1
71 * and 2nd arithmetic instruction is pattern matched to recognize
72 * that it wants to construct a pointer to some element within stack.
73 * So after 2nd insn, the register R1 has type PTR_TO_STACK
74 * (and -20 constant is saved for further stack bounds checking).
75 * Meaning that this reg is a pointer to stack plus known immediate constant.
76 *
Edward Creef1174f72017-08-07 15:26:19 +010077 * Most of the time the registers have SCALAR_VALUE type, which
Alexei Starovoitov51580e72014-09-26 00:17:02 -070078 * means the register has some value, but it's not a valid pointer.
Edward Creef1174f72017-08-07 15:26:19 +010079 * (like pointer plus pointer becomes SCALAR_VALUE type)
Alexei Starovoitov51580e72014-09-26 00:17:02 -070080 *
81 * When verifier sees load or store instructions the type of base register
Edward Creef1174f72017-08-07 15:26:19 +010082 * can be: PTR_TO_MAP_VALUE, PTR_TO_CTX, PTR_TO_STACK. These are three pointer
Alexei Starovoitov51580e72014-09-26 00:17:02 -070083 * types recognized by check_mem_access() function.
84 *
85 * PTR_TO_MAP_VALUE means that this register is pointing to 'map element value'
86 * and the range of [ptr, ptr + map's value_size) is accessible.
87 *
88 * registers used to pass values to function calls are checked against
89 * function argument constraints.
90 *
91 * ARG_PTR_TO_MAP_KEY is one of such argument constraints.
92 * It means that the register type passed to this function must be
93 * PTR_TO_STACK and it will be used inside the function as
94 * 'pointer to map element key'
95 *
96 * For example the argument constraints for bpf_map_lookup_elem():
97 * .ret_type = RET_PTR_TO_MAP_VALUE_OR_NULL,
98 * .arg1_type = ARG_CONST_MAP_PTR,
99 * .arg2_type = ARG_PTR_TO_MAP_KEY,
100 *
101 * ret_type says that this function returns 'pointer to map elem value or null'
102 * function expects 1st argument to be a const pointer to 'struct bpf_map' and
103 * 2nd argument should be a pointer to stack, which will be used inside
104 * the helper function as a pointer to map element key.
105 *
106 * On the kernel side the helper function looks like:
107 * u64 bpf_map_lookup_elem(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
108 * {
109 * struct bpf_map *map = (struct bpf_map *) (unsigned long) r1;
110 * void *key = (void *) (unsigned long) r2;
111 * void *value;
112 *
113 * here kernel can access 'key' and 'map' pointers safely, knowing that
114 * [key, key + map->key_size) bytes are valid and were initialized on
115 * the stack of eBPF program.
116 * }
117 *
118 * Corresponding eBPF program may look like:
119 * BPF_MOV64_REG(BPF_REG_2, BPF_REG_10), // after this insn R2 type is FRAME_PTR
120 * BPF_ALU64_IMM(BPF_ADD, BPF_REG_2, -4), // after this insn R2 type is PTR_TO_STACK
121 * BPF_LD_MAP_FD(BPF_REG_1, map_fd), // after this insn R1 type is CONST_PTR_TO_MAP
122 * BPF_RAW_INSN(BPF_JMP | BPF_CALL, 0, 0, 0, BPF_FUNC_map_lookup_elem),
123 * here verifier looks at prototype of map_lookup_elem() and sees:
124 * .arg1_type == ARG_CONST_MAP_PTR and R1->type == CONST_PTR_TO_MAP, which is ok,
125 * Now verifier knows that this map has key of R1->map_ptr->key_size bytes
126 *
127 * Then .arg2_type == ARG_PTR_TO_MAP_KEY and R2->type == PTR_TO_STACK, ok so far,
128 * Now verifier checks that [R2, R2 + map's key_size) are within stack limits
129 * and were initialized prior to this call.
130 * If it's ok, then verifier allows this BPF_CALL insn and looks at
131 * .ret_type which is RET_PTR_TO_MAP_VALUE_OR_NULL, so it sets
132 * R0->type = PTR_TO_MAP_VALUE_OR_NULL which means bpf_map_lookup_elem() function
133 * returns ether pointer to map value or NULL.
134 *
135 * When type PTR_TO_MAP_VALUE_OR_NULL passes through 'if (reg != 0) goto +off'
136 * insn, the register holding that pointer in the true branch changes state to
137 * PTR_TO_MAP_VALUE and the same register changes state to CONST_IMM in the false
138 * branch. See check_cond_jmp_op().
139 *
140 * After the call R0 is set to return type of the function and registers R1-R5
141 * are set to NOT_INIT to indicate that they are no longer readable.
142 */
143
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700144/* verifier_state + insn_idx are pushed to stack when branch is encountered */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100145struct bpf_verifier_stack_elem {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700146 /* verifer state is 'st'
147 * before processing instruction 'insn_idx'
148 * and after processing instruction 'prev_insn_idx'
149 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100150 struct bpf_verifier_state st;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700151 int insn_idx;
152 int prev_insn_idx;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100153 struct bpf_verifier_stack_elem *next;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700154};
155
Edward Cree8e17c1b2017-08-07 15:30:30 +0100156#define BPF_COMPLEXITY_LIMIT_INSNS 131072
Daniel Borkmann07016152016-04-05 22:33:17 +0200157#define BPF_COMPLEXITY_LIMIT_STACK 1024
158
Martin KaFai Laufad73a12017-03-22 10:00:32 -0700159#define BPF_MAP_PTR_POISON ((void *)0xeB9F + POISON_POINTER_DELTA)
160
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200161struct bpf_call_arg_meta {
162 struct bpf_map *map_ptr;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200163 bool raw_mode;
Daniel Borkmann36bbef52016-09-20 00:26:13 +0200164 bool pkt_access;
Daniel Borkmann435faee12016-04-13 00:10:51 +0200165 int regno;
166 int access_size;
Daniel Borkmann33ff9822016-04-13 00:10:50 +0200167};
168
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700169static DEFINE_MUTEX(bpf_verifier_lock);
170
171/* log_level controls verbosity level of eBPF verifier.
Quentin Monnet430e68d2018-01-10 12:26:06 +0000172 * bpf_verifier_log_write() is used to dump the verification trace to the log,
173 * so the user can figure out what's wrong with the program
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700174 */
Quentin Monnet430e68d2018-01-10 12:26:06 +0000175__printf(2, 3) void bpf_verifier_log_write(struct bpf_verifier_env *env,
176 const char *fmt, ...)
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700177{
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700178 struct bpf_verifer_log *log = &env->log;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700179 unsigned int n;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700180 va_list args;
181
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700182 if (!log->level || !log->ubuf || bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700183 return;
184
185 va_start(args, fmt);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700186 n = vscnprintf(log->kbuf, BPF_VERIFIER_TMP_LOG_SIZE, fmt, args);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700187 va_end(args);
Jakub Kicinskia2a7d572017-10-09 10:30:15 -0700188
189 WARN_ONCE(n >= BPF_VERIFIER_TMP_LOG_SIZE - 1,
190 "verifier log line truncated - local buffer too short\n");
191
192 n = min(log->len_total - log->len_used - 1, n);
193 log->kbuf[n] = '\0';
194
195 if (!copy_to_user(log->ubuf + log->len_used, log->kbuf, n + 1))
196 log->len_used += n;
197 else
198 log->ubuf = NULL;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700199}
Quentin Monnet430e68d2018-01-10 12:26:06 +0000200EXPORT_SYMBOL_GPL(bpf_verifier_log_write);
201/* Historically bpf_verifier_log_write was called verbose, but the name was too
202 * generic for symbol export. The function was renamed, but not the calls in
203 * the verifier to avoid complicating backports. Hence the alias below.
204 */
205static __printf(2, 3) void verbose(struct bpf_verifier_env *env,
206 const char *fmt, ...)
207 __attribute__((alias("bpf_verifier_log_write")));
Alexei Starovoitovcbd35702014-09-26 00:17:03 -0700208
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200209static bool type_is_pkt_pointer(enum bpf_reg_type type)
210{
211 return type == PTR_TO_PACKET ||
212 type == PTR_TO_PACKET_META;
213}
214
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700215/* string representation of 'enum bpf_reg_type' */
216static const char * const reg_type_str[] = {
217 [NOT_INIT] = "?",
Edward Creef1174f72017-08-07 15:26:19 +0100218 [SCALAR_VALUE] = "inv",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700219 [PTR_TO_CTX] = "ctx",
220 [CONST_PTR_TO_MAP] = "map_ptr",
221 [PTR_TO_MAP_VALUE] = "map_value",
222 [PTR_TO_MAP_VALUE_OR_NULL] = "map_value_or_null",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700223 [PTR_TO_STACK] = "fp",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700224 [PTR_TO_PACKET] = "pkt",
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200225 [PTR_TO_PACKET_META] = "pkt_meta",
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700226 [PTR_TO_PACKET_END] = "pkt_end",
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700227};
228
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800229static void print_liveness(struct bpf_verifier_env *env,
230 enum bpf_reg_liveness live)
231{
232 if (live & (REG_LIVE_READ | REG_LIVE_WRITTEN))
233 verbose(env, "_");
234 if (live & REG_LIVE_READ)
235 verbose(env, "r");
236 if (live & REG_LIVE_WRITTEN)
237 verbose(env, "w");
238}
239
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800240static struct bpf_func_state *func(struct bpf_verifier_env *env,
241 const struct bpf_reg_state *reg)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700242{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800243 struct bpf_verifier_state *cur = env->cur_state;
244
245 return cur->frame[reg->frameno];
246}
247
248static void print_verifier_state(struct bpf_verifier_env *env,
249 const struct bpf_func_state *state)
250{
251 const struct bpf_reg_state *reg;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700252 enum bpf_reg_type t;
253 int i;
254
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800255 if (state->frameno)
256 verbose(env, " frame%d:", state->frameno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700257 for (i = 0; i < MAX_BPF_REG; i++) {
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -0700258 reg = &state->regs[i];
259 t = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700260 if (t == NOT_INIT)
261 continue;
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800262 verbose(env, " R%d", i);
263 print_liveness(env, reg->live);
264 verbose(env, "=%s", reg_type_str[t]);
Edward Creef1174f72017-08-07 15:26:19 +0100265 if ((t == SCALAR_VALUE || t == PTR_TO_STACK) &&
266 tnum_is_const(reg->var_off)) {
267 /* reg->off should be 0 for SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700268 verbose(env, "%lld", reg->var_off.value + reg->off);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800269 if (t == PTR_TO_STACK)
270 verbose(env, ",call_%d", func(env, reg)->callsite);
Edward Creef1174f72017-08-07 15:26:19 +0100271 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700272 verbose(env, "(id=%d", reg->id);
Edward Creef1174f72017-08-07 15:26:19 +0100273 if (t != SCALAR_VALUE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700274 verbose(env, ",off=%d", reg->off);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200275 if (type_is_pkt_pointer(t))
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700276 verbose(env, ",r=%d", reg->range);
Edward Creef1174f72017-08-07 15:26:19 +0100277 else if (t == CONST_PTR_TO_MAP ||
278 t == PTR_TO_MAP_VALUE ||
279 t == PTR_TO_MAP_VALUE_OR_NULL)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700280 verbose(env, ",ks=%d,vs=%d",
Edward Creef1174f72017-08-07 15:26:19 +0100281 reg->map_ptr->key_size,
282 reg->map_ptr->value_size);
Edward Cree7d1238f2017-08-07 15:26:56 +0100283 if (tnum_is_const(reg->var_off)) {
284 /* Typically an immediate SCALAR_VALUE, but
285 * could be a pointer whose offset is too big
286 * for reg->off
287 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700288 verbose(env, ",imm=%llx", reg->var_off.value);
Edward Cree7d1238f2017-08-07 15:26:56 +0100289 } else {
290 if (reg->smin_value != reg->umin_value &&
291 reg->smin_value != S64_MIN)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700292 verbose(env, ",smin_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100293 (long long)reg->smin_value);
294 if (reg->smax_value != reg->umax_value &&
295 reg->smax_value != S64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700296 verbose(env, ",smax_value=%lld",
Edward Cree7d1238f2017-08-07 15:26:56 +0100297 (long long)reg->smax_value);
298 if (reg->umin_value != 0)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700299 verbose(env, ",umin_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100300 (unsigned long long)reg->umin_value);
301 if (reg->umax_value != U64_MAX)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700302 verbose(env, ",umax_value=%llu",
Edward Cree7d1238f2017-08-07 15:26:56 +0100303 (unsigned long long)reg->umax_value);
304 if (!tnum_is_unknown(reg->var_off)) {
305 char tn_buf[48];
Edward Creef1174f72017-08-07 15:26:19 +0100306
Edward Cree7d1238f2017-08-07 15:26:56 +0100307 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700308 verbose(env, ",var_off=%s", tn_buf);
Edward Cree7d1238f2017-08-07 15:26:56 +0100309 }
Edward Creef1174f72017-08-07 15:26:19 +0100310 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700311 verbose(env, ")");
Edward Creef1174f72017-08-07 15:26:19 +0100312 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700313 }
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700314 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800315 if (state->stack[i].slot_type[0] == STACK_SPILL) {
316 verbose(env, " fp%d",
317 (-i - 1) * BPF_REG_SIZE);
318 print_liveness(env, state->stack[i].spilled_ptr.live);
319 verbose(env, "=%s",
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700320 reg_type_str[state->stack[i].spilled_ptr.type]);
Alexei Starovoitov4e920242017-11-30 21:31:36 -0800321 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -0800322 if (state->stack[i].slot_type[0] == STACK_ZERO)
323 verbose(env, " fp%d=0", (-i - 1) * BPF_REG_SIZE);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700324 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700325 verbose(env, "\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700326}
327
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800328static int copy_stack_state(struct bpf_func_state *dst,
329 const struct bpf_func_state *src)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700330{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700331 if (!src->stack)
332 return 0;
333 if (WARN_ON_ONCE(dst->allocated_stack < src->allocated_stack)) {
334 /* internal bug, make state invalid to reject the program */
335 memset(dst, 0, sizeof(*dst));
336 return -EFAULT;
337 }
338 memcpy(dst->stack, src->stack,
339 sizeof(*src->stack) * (src->allocated_stack / BPF_REG_SIZE));
340 return 0;
341}
342
343/* do_check() starts with zero-sized stack in struct bpf_verifier_state to
344 * make it consume minimal amount of memory. check_stack_write() access from
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800345 * the program calls into realloc_func_state() to grow the stack size.
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700346 * Note there is a non-zero 'parent' pointer inside bpf_verifier_state
347 * which this function copies over. It points to previous bpf_verifier_state
348 * which is never reallocated
349 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800350static int realloc_func_state(struct bpf_func_state *state, int size,
351 bool copy_old)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700352{
353 u32 old_size = state->allocated_stack;
354 struct bpf_stack_state *new_stack;
355 int slot = size / BPF_REG_SIZE;
356
357 if (size <= old_size || !size) {
358 if (copy_old)
359 return 0;
360 state->allocated_stack = slot * BPF_REG_SIZE;
361 if (!size && old_size) {
362 kfree(state->stack);
363 state->stack = NULL;
364 }
365 return 0;
366 }
367 new_stack = kmalloc_array(slot, sizeof(struct bpf_stack_state),
368 GFP_KERNEL);
369 if (!new_stack)
370 return -ENOMEM;
371 if (copy_old) {
372 if (state->stack)
373 memcpy(new_stack, state->stack,
374 sizeof(*new_stack) * (old_size / BPF_REG_SIZE));
375 memset(new_stack + old_size / BPF_REG_SIZE, 0,
376 sizeof(*new_stack) * (size - old_size) / BPF_REG_SIZE);
377 }
378 state->allocated_stack = slot * BPF_REG_SIZE;
379 kfree(state->stack);
380 state->stack = new_stack;
381 return 0;
382}
383
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800384static void free_func_state(struct bpf_func_state *state)
385{
Alexei Starovoitov58963512018-01-08 07:51:17 -0800386 if (!state)
387 return;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800388 kfree(state->stack);
389 kfree(state);
390}
391
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700392static void free_verifier_state(struct bpf_verifier_state *state,
393 bool free_self)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700394{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800395 int i;
396
397 for (i = 0; i <= state->curframe; i++) {
398 free_func_state(state->frame[i]);
399 state->frame[i] = NULL;
400 }
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700401 if (free_self)
402 kfree(state);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700403}
404
405/* copy verifier state from src to dst growing dst stack space
406 * when necessary to accommodate larger src stack
407 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800408static int copy_func_state(struct bpf_func_state *dst,
409 const struct bpf_func_state *src)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700410{
411 int err;
412
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800413 err = realloc_func_state(dst, src->allocated_stack, false);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700414 if (err)
415 return err;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800416 memcpy(dst, src, offsetof(struct bpf_func_state, allocated_stack));
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700417 return copy_stack_state(dst, src);
418}
419
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800420static int copy_verifier_state(struct bpf_verifier_state *dst_state,
421 const struct bpf_verifier_state *src)
422{
423 struct bpf_func_state *dst;
424 int i, err;
425
426 /* if dst has more stack frames then src frame, free them */
427 for (i = src->curframe + 1; i <= dst_state->curframe; i++) {
428 free_func_state(dst_state->frame[i]);
429 dst_state->frame[i] = NULL;
430 }
431 dst_state->curframe = src->curframe;
432 dst_state->parent = src->parent;
433 for (i = 0; i <= src->curframe; i++) {
434 dst = dst_state->frame[i];
435 if (!dst) {
436 dst = kzalloc(sizeof(*dst), GFP_KERNEL);
437 if (!dst)
438 return -ENOMEM;
439 dst_state->frame[i] = dst;
440 }
441 err = copy_func_state(dst, src->frame[i]);
442 if (err)
443 return err;
444 }
445 return 0;
446}
447
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700448static int pop_stack(struct bpf_verifier_env *env, int *prev_insn_idx,
449 int *insn_idx)
450{
451 struct bpf_verifier_state *cur = env->cur_state;
452 struct bpf_verifier_stack_elem *elem, *head = env->head;
453 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700454
455 if (env->head == NULL)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700456 return -ENOENT;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700457
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700458 if (cur) {
459 err = copy_verifier_state(cur, &head->st);
460 if (err)
461 return err;
462 }
463 if (insn_idx)
464 *insn_idx = head->insn_idx;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700465 if (prev_insn_idx)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700466 *prev_insn_idx = head->prev_insn_idx;
467 elem = head->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700468 free_verifier_state(&head->st, false);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700469 kfree(head);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700470 env->head = elem;
471 env->stack_size--;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700472 return 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700473}
474
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100475static struct bpf_verifier_state *push_stack(struct bpf_verifier_env *env,
476 int insn_idx, int prev_insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700477{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700478 struct bpf_verifier_state *cur = env->cur_state;
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +0100479 struct bpf_verifier_stack_elem *elem;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700480 int err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700481
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700482 elem = kzalloc(sizeof(struct bpf_verifier_stack_elem), GFP_KERNEL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700483 if (!elem)
484 goto err;
485
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700486 elem->insn_idx = insn_idx;
487 elem->prev_insn_idx = prev_insn_idx;
488 elem->next = env->head;
489 env->head = elem;
490 env->stack_size++;
Alexei Starovoitov1969db42017-11-01 00:08:04 -0700491 err = copy_verifier_state(&elem->st, cur);
492 if (err)
493 goto err;
Daniel Borkmann07016152016-04-05 22:33:17 +0200494 if (env->stack_size > BPF_COMPLEXITY_LIMIT_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700495 verbose(env, "BPF program is too complex\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700496 goto err;
497 }
498 return &elem->st;
499err:
Alexei Starovoitov58963512018-01-08 07:51:17 -0800500 free_verifier_state(env->cur_state, true);
501 env->cur_state = NULL;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700502 /* pop all elements and return */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700503 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700504 return NULL;
505}
506
507#define CALLER_SAVED_REGS 6
508static const int caller_saved[CALLER_SAVED_REGS] = {
509 BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5
510};
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800511#define CALLEE_SAVED_REGS 5
512static const int callee_saved[CALLEE_SAVED_REGS] = {
513 BPF_REG_6, BPF_REG_7, BPF_REG_8, BPF_REG_9
514};
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700515
Edward Creef1174f72017-08-07 15:26:19 +0100516static void __mark_reg_not_init(struct bpf_reg_state *reg);
517
Edward Creeb03c9f92017-08-07 15:26:36 +0100518/* Mark the unknown part of a register (variable offset or scalar value) as
519 * known to have the value @imm.
520 */
521static void __mark_reg_known(struct bpf_reg_state *reg, u64 imm)
522{
523 reg->id = 0;
524 reg->var_off = tnum_const(imm);
525 reg->smin_value = (s64)imm;
526 reg->smax_value = (s64)imm;
527 reg->umin_value = imm;
528 reg->umax_value = imm;
529}
530
Edward Creef1174f72017-08-07 15:26:19 +0100531/* Mark the 'variable offset' part of a register as zero. This should be
532 * used only on registers holding a pointer type.
533 */
534static void __mark_reg_known_zero(struct bpf_reg_state *reg)
535{
Edward Creeb03c9f92017-08-07 15:26:36 +0100536 __mark_reg_known(reg, 0);
Edward Creef1174f72017-08-07 15:26:19 +0100537}
538
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -0800539static void __mark_reg_const_zero(struct bpf_reg_state *reg)
540{
541 __mark_reg_known(reg, 0);
542 reg->off = 0;
543 reg->type = SCALAR_VALUE;
544}
545
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700546static void mark_reg_known_zero(struct bpf_verifier_env *env,
547 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100548{
549 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700550 verbose(env, "mark_reg_known_zero(regs, %u)\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +0100551 /* Something bad happened, let's kill all regs */
552 for (regno = 0; regno < MAX_BPF_REG; regno++)
553 __mark_reg_not_init(regs + regno);
554 return;
555 }
556 __mark_reg_known_zero(regs + regno);
557}
558
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200559static bool reg_is_pkt_pointer(const struct bpf_reg_state *reg)
560{
561 return type_is_pkt_pointer(reg->type);
562}
563
564static bool reg_is_pkt_pointer_any(const struct bpf_reg_state *reg)
565{
566 return reg_is_pkt_pointer(reg) ||
567 reg->type == PTR_TO_PACKET_END;
568}
569
570/* Unmodified PTR_TO_PACKET[_META,_END] register from ctx access. */
571static bool reg_is_init_pkt_pointer(const struct bpf_reg_state *reg,
572 enum bpf_reg_type which)
573{
574 /* The register can already have a range from prior markings.
575 * This is fine as long as it hasn't been advanced from its
576 * origin.
577 */
578 return reg->type == which &&
579 reg->id == 0 &&
580 reg->off == 0 &&
581 tnum_equals_const(reg->var_off, 0);
582}
583
Edward Creeb03c9f92017-08-07 15:26:36 +0100584/* Attempts to improve min/max values based on var_off information */
585static void __update_reg_bounds(struct bpf_reg_state *reg)
586{
587 /* min signed is max(sign bit) | min(other bits) */
588 reg->smin_value = max_t(s64, reg->smin_value,
589 reg->var_off.value | (reg->var_off.mask & S64_MIN));
590 /* max signed is min(sign bit) | max(other bits) */
591 reg->smax_value = min_t(s64, reg->smax_value,
592 reg->var_off.value | (reg->var_off.mask & S64_MAX));
593 reg->umin_value = max(reg->umin_value, reg->var_off.value);
594 reg->umax_value = min(reg->umax_value,
595 reg->var_off.value | reg->var_off.mask);
596}
597
598/* Uses signed min/max values to inform unsigned, and vice-versa */
599static void __reg_deduce_bounds(struct bpf_reg_state *reg)
600{
601 /* Learn sign from signed bounds.
602 * If we cannot cross the sign boundary, then signed and unsigned bounds
603 * are the same, so combine. This works even in the negative case, e.g.
604 * -3 s<= x s<= -1 implies 0xf...fd u<= x u<= 0xf...ff.
605 */
606 if (reg->smin_value >= 0 || reg->smax_value < 0) {
607 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
608 reg->umin_value);
609 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
610 reg->umax_value);
611 return;
612 }
613 /* Learn sign from unsigned bounds. Signed bounds cross the sign
614 * boundary, so we must be careful.
615 */
616 if ((s64)reg->umax_value >= 0) {
617 /* Positive. We can't learn anything from the smin, but smax
618 * is positive, hence safe.
619 */
620 reg->smin_value = reg->umin_value;
621 reg->smax_value = reg->umax_value = min_t(u64, reg->smax_value,
622 reg->umax_value);
623 } else if ((s64)reg->umin_value < 0) {
624 /* Negative. We can't learn anything from the smax, but smin
625 * is negative, hence safe.
626 */
627 reg->smin_value = reg->umin_value = max_t(u64, reg->smin_value,
628 reg->umin_value);
629 reg->smax_value = reg->umax_value;
630 }
631}
632
633/* Attempts to improve var_off based on unsigned min/max information */
634static void __reg_bound_offset(struct bpf_reg_state *reg)
635{
636 reg->var_off = tnum_intersect(reg->var_off,
637 tnum_range(reg->umin_value,
638 reg->umax_value));
639}
640
641/* Reset the min/max bounds of a register */
642static void __mark_reg_unbounded(struct bpf_reg_state *reg)
643{
644 reg->smin_value = S64_MIN;
645 reg->smax_value = S64_MAX;
646 reg->umin_value = 0;
647 reg->umax_value = U64_MAX;
648}
649
Edward Creef1174f72017-08-07 15:26:19 +0100650/* Mark a register as having a completely unknown (scalar) value. */
651static void __mark_reg_unknown(struct bpf_reg_state *reg)
652{
653 reg->type = SCALAR_VALUE;
654 reg->id = 0;
655 reg->off = 0;
656 reg->var_off = tnum_unknown;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800657 reg->frameno = 0;
Edward Creeb03c9f92017-08-07 15:26:36 +0100658 __mark_reg_unbounded(reg);
Edward Creef1174f72017-08-07 15:26:19 +0100659}
660
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700661static void mark_reg_unknown(struct bpf_verifier_env *env,
662 struct bpf_reg_state *regs, u32 regno)
Edward Creef1174f72017-08-07 15:26:19 +0100663{
664 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700665 verbose(env, "mark_reg_unknown(regs, %u)\n", regno);
Alexei Starovoitov19ceb412017-11-30 21:31:37 -0800666 /* Something bad happened, let's kill all regs except FP */
667 for (regno = 0; regno < BPF_REG_FP; regno++)
Edward Creef1174f72017-08-07 15:26:19 +0100668 __mark_reg_not_init(regs + regno);
669 return;
670 }
671 __mark_reg_unknown(regs + regno);
672}
673
674static void __mark_reg_not_init(struct bpf_reg_state *reg)
675{
676 __mark_reg_unknown(reg);
677 reg->type = NOT_INIT;
678}
679
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700680static void mark_reg_not_init(struct bpf_verifier_env *env,
681 struct bpf_reg_state *regs, u32 regno)
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200682{
Edward Creef1174f72017-08-07 15:26:19 +0100683 if (WARN_ON(regno >= MAX_BPF_REG)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700684 verbose(env, "mark_reg_not_init(regs, %u)\n", regno);
Alexei Starovoitov19ceb412017-11-30 21:31:37 -0800685 /* Something bad happened, let's kill all regs except FP */
686 for (regno = 0; regno < BPF_REG_FP; regno++)
Edward Creef1174f72017-08-07 15:26:19 +0100687 __mark_reg_not_init(regs + regno);
688 return;
689 }
690 __mark_reg_not_init(regs + regno);
Daniel Borkmanna9789ef2017-05-25 01:05:06 +0200691}
692
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700693static void init_reg_state(struct bpf_verifier_env *env,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800694 struct bpf_func_state *state)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700695{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800696 struct bpf_reg_state *regs = state->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700697 int i;
698
Edward Creedc503a82017-08-15 20:34:35 +0100699 for (i = 0; i < MAX_BPF_REG; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700700 mark_reg_not_init(env, regs, i);
Edward Creedc503a82017-08-15 20:34:35 +0100701 regs[i].live = REG_LIVE_NONE;
702 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700703
704 /* frame pointer */
Edward Creef1174f72017-08-07 15:26:19 +0100705 regs[BPF_REG_FP].type = PTR_TO_STACK;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700706 mark_reg_known_zero(env, regs, BPF_REG_FP);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800707 regs[BPF_REG_FP].frameno = state->frameno;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700708
709 /* 1st arg to a function */
710 regs[BPF_REG_1].type = PTR_TO_CTX;
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700711 mark_reg_known_zero(env, regs, BPF_REG_1);
Daniel Borkmann6760bf22016-12-18 01:52:59 +0100712}
713
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800714#define BPF_MAIN_FUNC (-1)
715static void init_func_state(struct bpf_verifier_env *env,
716 struct bpf_func_state *state,
717 int callsite, int frameno, int subprogno)
718{
719 state->callsite = callsite;
720 state->frameno = frameno;
721 state->subprogno = subprogno;
722 init_reg_state(env, state);
723}
724
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700725enum reg_arg_type {
726 SRC_OP, /* register is used as source operand */
727 DST_OP, /* register is used as destination operand */
728 DST_OP_NO_MARK /* same as above, check only, don't mark */
729};
730
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800731static int cmp_subprogs(const void *a, const void *b)
732{
733 return *(int *)a - *(int *)b;
734}
735
736static int find_subprog(struct bpf_verifier_env *env, int off)
737{
738 u32 *p;
739
740 p = bsearch(&off, env->subprog_starts, env->subprog_cnt,
741 sizeof(env->subprog_starts[0]), cmp_subprogs);
742 if (!p)
743 return -ENOENT;
744 return p - env->subprog_starts;
745
746}
747
748static int add_subprog(struct bpf_verifier_env *env, int off)
749{
750 int insn_cnt = env->prog->len;
751 int ret;
752
753 if (off >= insn_cnt || off < 0) {
754 verbose(env, "call to invalid destination\n");
755 return -EINVAL;
756 }
757 ret = find_subprog(env, off);
758 if (ret >= 0)
759 return 0;
760 if (env->subprog_cnt >= BPF_MAX_SUBPROGS) {
761 verbose(env, "too many subprograms\n");
762 return -E2BIG;
763 }
764 env->subprog_starts[env->subprog_cnt++] = off;
765 sort(env->subprog_starts, env->subprog_cnt,
766 sizeof(env->subprog_starts[0]), cmp_subprogs, NULL);
767 return 0;
768}
769
770static int check_subprogs(struct bpf_verifier_env *env)
771{
772 int i, ret, subprog_start, subprog_end, off, cur_subprog = 0;
773 struct bpf_insn *insn = env->prog->insnsi;
774 int insn_cnt = env->prog->len;
775
776 /* determine subprog starts. The end is one before the next starts */
777 for (i = 0; i < insn_cnt; i++) {
778 if (insn[i].code != (BPF_JMP | BPF_CALL))
779 continue;
780 if (insn[i].src_reg != BPF_PSEUDO_CALL)
781 continue;
782 if (!env->allow_ptr_leaks) {
783 verbose(env, "function calls to other bpf functions are allowed for root only\n");
784 return -EPERM;
785 }
786 if (bpf_prog_is_dev_bound(env->prog->aux)) {
Colin Ian Kinge90004d52017-12-18 14:03:12 +0000787 verbose(env, "function calls in offloaded programs are not supported yet\n");
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -0800788 return -EINVAL;
789 }
790 ret = add_subprog(env, i + insn[i].imm + 1);
791 if (ret < 0)
792 return ret;
793 }
794
795 if (env->log.level > 1)
796 for (i = 0; i < env->subprog_cnt; i++)
797 verbose(env, "func#%d @%d\n", i, env->subprog_starts[i]);
798
799 /* now check that all jumps are within the same subprog */
800 subprog_start = 0;
801 if (env->subprog_cnt == cur_subprog)
802 subprog_end = insn_cnt;
803 else
804 subprog_end = env->subprog_starts[cur_subprog++];
805 for (i = 0; i < insn_cnt; i++) {
806 u8 code = insn[i].code;
807
808 if (BPF_CLASS(code) != BPF_JMP)
809 goto next;
810 if (BPF_OP(code) == BPF_EXIT || BPF_OP(code) == BPF_CALL)
811 goto next;
812 off = i + insn[i].off + 1;
813 if (off < subprog_start || off >= subprog_end) {
814 verbose(env, "jump out of range from insn %d to %d\n", i, off);
815 return -EINVAL;
816 }
817next:
818 if (i == subprog_end - 1) {
819 /* to avoid fall-through from one subprog into another
820 * the last insn of the subprog should be either exit
821 * or unconditional jump back
822 */
823 if (code != (BPF_JMP | BPF_EXIT) &&
824 code != (BPF_JMP | BPF_JA)) {
825 verbose(env, "last insn is not an exit or jmp\n");
826 return -EINVAL;
827 }
828 subprog_start = subprog_end;
829 if (env->subprog_cnt == cur_subprog)
830 subprog_end = insn_cnt;
831 else
832 subprog_end = env->subprog_starts[cur_subprog++];
833 }
834 }
835 return 0;
836}
837
Colin Ian Kingfa2d41a2017-12-18 17:47:07 +0000838static
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800839struct bpf_verifier_state *skip_callee(struct bpf_verifier_env *env,
840 const struct bpf_verifier_state *state,
841 struct bpf_verifier_state *parent,
842 u32 regno)
Edward Creedc503a82017-08-15 20:34:35 +0100843{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800844 struct bpf_verifier_state *tmp = NULL;
845
846 /* 'parent' could be a state of caller and
847 * 'state' could be a state of callee. In such case
848 * parent->curframe < state->curframe
849 * and it's ok for r1 - r5 registers
850 *
851 * 'parent' could be a callee's state after it bpf_exit-ed.
852 * In such case parent->curframe > state->curframe
853 * and it's ok for r0 only
854 */
855 if (parent->curframe == state->curframe ||
856 (parent->curframe < state->curframe &&
857 regno >= BPF_REG_1 && regno <= BPF_REG_5) ||
858 (parent->curframe > state->curframe &&
859 regno == BPF_REG_0))
860 return parent;
861
862 if (parent->curframe > state->curframe &&
863 regno >= BPF_REG_6) {
864 /* for callee saved regs we have to skip the whole chain
865 * of states that belong to callee and mark as LIVE_READ
866 * the registers before the call
867 */
868 tmp = parent;
869 while (tmp && tmp->curframe != state->curframe) {
870 tmp = tmp->parent;
871 }
872 if (!tmp)
873 goto bug;
874 parent = tmp;
875 } else {
876 goto bug;
877 }
878 return parent;
879bug:
880 verbose(env, "verifier bug regno %d tmp %p\n", regno, tmp);
881 verbose(env, "regno %d parent frame %d current frame %d\n",
882 regno, parent->curframe, state->curframe);
Colin Ian Kingfa2d41a2017-12-18 17:47:07 +0000883 return NULL;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800884}
885
886static int mark_reg_read(struct bpf_verifier_env *env,
887 const struct bpf_verifier_state *state,
888 struct bpf_verifier_state *parent,
889 u32 regno)
890{
891 bool writes = parent == state->parent; /* Observe write marks */
Edward Creedc503a82017-08-15 20:34:35 +0100892
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -0700893 if (regno == BPF_REG_FP)
894 /* We don't need to worry about FP liveness because it's read-only */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800895 return 0;
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -0700896
Edward Creedc503a82017-08-15 20:34:35 +0100897 while (parent) {
898 /* if read wasn't screened by an earlier write ... */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800899 if (writes && state->frame[state->curframe]->regs[regno].live & REG_LIVE_WRITTEN)
Edward Creedc503a82017-08-15 20:34:35 +0100900 break;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800901 parent = skip_callee(env, state, parent, regno);
902 if (!parent)
903 return -EFAULT;
Edward Creedc503a82017-08-15 20:34:35 +0100904 /* ... then we depend on parent's value */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800905 parent->frame[parent->curframe]->regs[regno].live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +0100906 state = parent;
907 parent = state->parent;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800908 writes = true;
Edward Creedc503a82017-08-15 20:34:35 +0100909 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800910 return 0;
Edward Creedc503a82017-08-15 20:34:35 +0100911}
912
913static int check_reg_arg(struct bpf_verifier_env *env, u32 regno,
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700914 enum reg_arg_type t)
915{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800916 struct bpf_verifier_state *vstate = env->cur_state;
917 struct bpf_func_state *state = vstate->frame[vstate->curframe];
918 struct bpf_reg_state *regs = state->regs;
Edward Creedc503a82017-08-15 20:34:35 +0100919
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700920 if (regno >= MAX_BPF_REG) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700921 verbose(env, "R%d is invalid\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700922 return -EINVAL;
923 }
924
925 if (t == SRC_OP) {
926 /* check whether register used as source operand can be read */
927 if (regs[regno].type == NOT_INIT) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700928 verbose(env, "R%d !read_ok\n", regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700929 return -EACCES;
930 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800931 return mark_reg_read(env, vstate, vstate->parent, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700932 } else {
933 /* check whether register used as dest operand can be written to */
934 if (regno == BPF_REG_FP) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700935 verbose(env, "frame pointer is read only\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700936 return -EACCES;
937 }
Edward Creedc503a82017-08-15 20:34:35 +0100938 regs[regno].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700939 if (t == DST_OP)
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700940 mark_reg_unknown(env, regs, regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700941 }
942 return 0;
943}
944
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700945static bool is_spillable_regtype(enum bpf_reg_type type)
946{
947 switch (type) {
948 case PTR_TO_MAP_VALUE:
949 case PTR_TO_MAP_VALUE_OR_NULL:
950 case PTR_TO_STACK:
951 case PTR_TO_CTX:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700952 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +0200953 case PTR_TO_PACKET_META:
Alexei Starovoitov969bf052016-05-05 19:49:10 -0700954 case PTR_TO_PACKET_END:
Alexei Starovoitov1be7f752015-10-07 22:23:21 -0700955 case CONST_PTR_TO_MAP:
956 return true;
957 default:
958 return false;
959 }
960}
961
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -0800962/* Does this register contain a constant zero? */
963static bool register_is_null(struct bpf_reg_state *reg)
964{
965 return reg->type == SCALAR_VALUE && tnum_equals_const(reg->var_off, 0);
966}
967
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700968/* check_stack_read/write functions track spill/fill of registers,
969 * stack boundary and alignment are checked in check_mem_access()
970 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700971static int check_stack_write(struct bpf_verifier_env *env,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800972 struct bpf_func_state *state, /* func where register points to */
973 int off, int size, int value_regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700974{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800975 struct bpf_func_state *cur; /* state of the current function */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700976 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE, err;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800977 enum bpf_reg_type type;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700978
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800979 err = realloc_func_state(state, round_up(slot + 1, BPF_REG_SIZE),
980 true);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700981 if (err)
982 return err;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700983 /* caller checked that off % size == 0 and -MAX_BPF_STACK <= off < 0,
984 * so it's aligned access and [off, off + size) are within stack limits
985 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -0700986 if (!env->allow_ptr_leaks &&
987 state->stack[spi].slot_type[0] == STACK_SPILL &&
988 size != BPF_REG_SIZE) {
989 verbose(env, "attempt to corrupt spilled pointer on stack\n");
990 return -EACCES;
991 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700992
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800993 cur = env->cur_state->frame[env->cur_state->curframe];
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700994 if (value_regno >= 0 &&
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -0800995 is_spillable_regtype((type = cur->regs[value_regno].type))) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -0700996
997 /* register containing pointer is being spilled into stack */
Alexei Starovoitov9c3997602014-10-28 15:11:41 -0700998 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -0700999 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001000 return -EACCES;
1001 }
1002
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001003 if (state != cur && type == PTR_TO_STACK) {
1004 verbose(env, "cannot spill pointers to stack into stack frame of the caller\n");
1005 return -EINVAL;
1006 }
1007
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001008 /* save register state */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001009 state->stack[spi].spilled_ptr = cur->regs[value_regno];
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001010 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001011
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001012 for (i = 0; i < BPF_REG_SIZE; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001013 state->stack[spi].slot_type[i] = STACK_SPILL;
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001014 } else {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001015 u8 type = STACK_MISC;
1016
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001017 /* regular write of data into stack */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001018 state->stack[spi].spilled_ptr = (struct bpf_reg_state) {};
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001019
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001020 /* only mark the slot as written if all 8 bytes were written
1021 * otherwise read propagation may incorrectly stop too soon
1022 * when stack slots are partially written.
1023 * This heuristic means that read propagation will be
1024 * conservative, since it will add reg_live_read marks
1025 * to stack slots all the way to first state when programs
1026 * writes+reads less than 8 bytes
1027 */
1028 if (size == BPF_REG_SIZE)
1029 state->stack[spi].spilled_ptr.live |= REG_LIVE_WRITTEN;
1030
1031 /* when we zero initialize stack slots mark them as such */
1032 if (value_regno >= 0 &&
1033 register_is_null(&cur->regs[value_regno]))
1034 type = STACK_ZERO;
1035
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001036 for (i = 0; i < size; i++)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001037 state->stack[spi].slot_type[(slot - i) % BPF_REG_SIZE] =
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001038 type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001039 }
1040 return 0;
1041}
1042
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001043/* registers of every function are unique and mark_reg_read() propagates
1044 * the liveness in the following cases:
1045 * - from callee into caller for R1 - R5 that were used as arguments
1046 * - from caller into callee for R0 that used as result of the call
1047 * - from caller to the same caller skipping states of the callee for R6 - R9,
1048 * since R6 - R9 are callee saved by implicit function prologue and
1049 * caller's R6 != callee's R6, so when we propagate liveness up to
1050 * parent states we need to skip callee states for R6 - R9.
1051 *
1052 * stack slot marking is different, since stacks of caller and callee are
1053 * accessible in both (since caller can pass a pointer to caller's stack to
1054 * callee which can pass it to another function), hence mark_stack_slot_read()
1055 * has to propagate the stack liveness to all parent states at given frame number.
1056 * Consider code:
1057 * f1() {
1058 * ptr = fp - 8;
1059 * *ptr = ctx;
1060 * call f2 {
1061 * .. = *ptr;
1062 * }
1063 * .. = *ptr;
1064 * }
1065 * First *ptr is reading from f1's stack and mark_stack_slot_read() has
1066 * to mark liveness at the f1's frame and not f2's frame.
1067 * Second *ptr is also reading from f1's stack and mark_stack_slot_read() has
1068 * to propagate liveness to f2 states at f1's frame level and further into
1069 * f1 states at f1's frame level until write into that stack slot
1070 */
1071static void mark_stack_slot_read(struct bpf_verifier_env *env,
1072 const struct bpf_verifier_state *state,
1073 struct bpf_verifier_state *parent,
1074 int slot, int frameno)
Edward Creedc503a82017-08-15 20:34:35 +01001075{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001076 bool writes = parent == state->parent; /* Observe write marks */
Edward Creedc503a82017-08-15 20:34:35 +01001077
1078 while (parent) {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001079 if (parent->frame[frameno]->allocated_stack <= slot * BPF_REG_SIZE)
1080 /* since LIVE_WRITTEN mark is only done for full 8-byte
1081 * write the read marks are conservative and parent
1082 * state may not even have the stack allocated. In such case
1083 * end the propagation, since the loop reached beginning
1084 * of the function
1085 */
1086 break;
Edward Creedc503a82017-08-15 20:34:35 +01001087 /* if read wasn't screened by an earlier write ... */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001088 if (writes && state->frame[frameno]->stack[slot].spilled_ptr.live & REG_LIVE_WRITTEN)
Edward Creedc503a82017-08-15 20:34:35 +01001089 break;
1090 /* ... then we depend on parent's value */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001091 parent->frame[frameno]->stack[slot].spilled_ptr.live |= REG_LIVE_READ;
Edward Creedc503a82017-08-15 20:34:35 +01001092 state = parent;
1093 parent = state->parent;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001094 writes = true;
Edward Creedc503a82017-08-15 20:34:35 +01001095 }
1096}
1097
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001098static int check_stack_read(struct bpf_verifier_env *env,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001099 struct bpf_func_state *reg_state /* func where register points to */,
1100 int off, int size, int value_regno)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001101{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001102 struct bpf_verifier_state *vstate = env->cur_state;
1103 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001104 int i, slot = -off - 1, spi = slot / BPF_REG_SIZE;
1105 u8 *stype;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001106
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001107 if (reg_state->allocated_stack <= slot) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001108 verbose(env, "invalid read from stack off %d+0 size %d\n",
1109 off, size);
1110 return -EACCES;
1111 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001112 stype = reg_state->stack[spi].slot_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001113
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001114 if (stype[0] == STACK_SPILL) {
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001115 if (size != BPF_REG_SIZE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001116 verbose(env, "invalid size of register spill\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001117 return -EACCES;
1118 }
Alexei Starovoitov9c3997602014-10-28 15:11:41 -07001119 for (i = 1; i < BPF_REG_SIZE; i++) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001120 if (stype[(slot - i) % BPF_REG_SIZE] != STACK_SPILL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001121 verbose(env, "corrupted spill memory\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001122 return -EACCES;
1123 }
1124 }
1125
Edward Creedc503a82017-08-15 20:34:35 +01001126 if (value_regno >= 0) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001127 /* restore register state from stack */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001128 state->regs[value_regno] = reg_state->stack[spi].spilled_ptr;
Alexei Starovoitov2f18f622017-11-30 21:31:38 -08001129 /* mark reg as written since spilled pointer state likely
1130 * has its liveness marks cleared by is_state_visited()
1131 * which resets stack/reg liveness for state transitions
1132 */
1133 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
Edward Creedc503a82017-08-15 20:34:35 +01001134 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001135 mark_stack_slot_read(env, vstate, vstate->parent, spi,
1136 reg_state->frameno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001137 return 0;
1138 } else {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001139 int zeros = 0;
1140
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001141 for (i = 0; i < size; i++) {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001142 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_MISC)
1143 continue;
1144 if (stype[(slot - i) % BPF_REG_SIZE] == STACK_ZERO) {
1145 zeros++;
1146 continue;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001147 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001148 verbose(env, "invalid read from stack off %d+%d size %d\n",
1149 off, i, size);
1150 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001151 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001152 mark_stack_slot_read(env, vstate, vstate->parent, spi,
1153 reg_state->frameno);
1154 if (value_regno >= 0) {
1155 if (zeros == size) {
1156 /* any size read into register is zero extended,
1157 * so the whole register == const_zero
1158 */
1159 __mark_reg_const_zero(&state->regs[value_regno]);
1160 } else {
1161 /* have read misc data from the stack */
1162 mark_reg_unknown(env, state->regs, value_regno);
1163 }
1164 state->regs[value_regno].live |= REG_LIVE_WRITTEN;
1165 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001166 return 0;
1167 }
1168}
1169
1170/* check read/write into map element returned by bpf_map_lookup_elem() */
Edward Creef1174f72017-08-07 15:26:19 +01001171static int __check_map_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001172 int size, bool zero_size_allowed)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001173{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001174 struct bpf_reg_state *regs = cur_regs(env);
1175 struct bpf_map *map = regs[regno].map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001176
Yonghong Song9fd29c02017-11-12 14:49:09 -08001177 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
1178 off + size > map->value_size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001179 verbose(env, "invalid access to map value, value_size=%d off=%d size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001180 map->value_size, off, size);
1181 return -EACCES;
1182 }
1183 return 0;
1184}
1185
Edward Creef1174f72017-08-07 15:26:19 +01001186/* check read/write into a map element with possible variable offset */
1187static int check_map_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001188 int off, int size, bool zero_size_allowed)
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001189{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001190 struct bpf_verifier_state *vstate = env->cur_state;
1191 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001192 struct bpf_reg_state *reg = &state->regs[regno];
1193 int err;
1194
Edward Creef1174f72017-08-07 15:26:19 +01001195 /* We may have adjusted the register to this map value, so we
1196 * need to try adding each of min_value and max_value to off
1197 * to make sure our theoretical access will be safe.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001198 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001199 if (env->log.level)
1200 print_verifier_state(env, state);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001201 /* The minimum value is only important with signed
1202 * comparisons where we can't assume the floor of a
1203 * value is 0. If we are using signed variables for our
1204 * index'es we need to make sure that whatever we use
1205 * will have a set floor within our range.
1206 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001207 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001208 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001209 regno);
1210 return -EACCES;
1211 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001212 err = __check_map_access(env, regno, reg->smin_value + off, size,
1213 zero_size_allowed);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001214 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001215 verbose(env, "R%d min value is outside of the array range\n",
1216 regno);
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001217 return err;
1218 }
1219
Edward Creeb03c9f92017-08-07 15:26:36 +01001220 /* If we haven't set a max value then we need to bail since we can't be
1221 * sure we won't do bad things.
1222 * If reg->umax_value + off could overflow, treat that as unbounded too.
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001223 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001224 if (reg->umax_value >= BPF_MAX_VAR_OFF) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001225 verbose(env, "R%d unbounded memory access, make sure to bounds check any array access into a map\n",
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001226 regno);
1227 return -EACCES;
1228 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001229 err = __check_map_access(env, regno, reg->umax_value + off, size,
1230 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001231 if (err)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001232 verbose(env, "R%d max value is outside of the array range\n",
1233 regno);
Edward Creef1174f72017-08-07 15:26:19 +01001234 return err;
Gianluca Borellodbcfe5f2017-01-09 10:19:46 -08001235}
1236
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001237#define MAX_PACKET_OFF 0xffff
1238
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001239static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001240 const struct bpf_call_arg_meta *meta,
1241 enum bpf_access_type t)
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001242{
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001243 switch (env->prog->type) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001244 case BPF_PROG_TYPE_LWT_IN:
1245 case BPF_PROG_TYPE_LWT_OUT:
1246 /* dst_input() and dst_output() can't write for now */
1247 if (t == BPF_WRITE)
1248 return false;
Alexander Alemayhu7e57fbb2017-02-14 00:02:35 +01001249 /* fallthrough */
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001250 case BPF_PROG_TYPE_SCHED_CLS:
1251 case BPF_PROG_TYPE_SCHED_ACT:
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001252 case BPF_PROG_TYPE_XDP:
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001253 case BPF_PROG_TYPE_LWT_XMIT:
John Fastabend8a31db52017-08-15 22:33:09 -07001254 case BPF_PROG_TYPE_SK_SKB:
Daniel Borkmann36bbef52016-09-20 00:26:13 +02001255 if (meta)
1256 return meta->pkt_access;
1257
1258 env->seen_direct_write = true;
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001259 return true;
1260 default:
1261 return false;
1262 }
1263}
1264
Edward Creef1174f72017-08-07 15:26:19 +01001265static int __check_packet_access(struct bpf_verifier_env *env, u32 regno,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001266 int off, int size, bool zero_size_allowed)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001267{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001268 struct bpf_reg_state *regs = cur_regs(env);
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001269 struct bpf_reg_state *reg = &regs[regno];
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001270
Yonghong Song9fd29c02017-11-12 14:49:09 -08001271 if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) ||
1272 (u64)off + size > reg->range) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001273 verbose(env, "invalid access to packet, off=%d size=%d, R%d(id=%d,off=%d,r=%d)\n",
Alexei Starovoitovd91b28e2016-05-19 18:17:13 -07001274 off, size, regno, reg->id, reg->off, reg->range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001275 return -EACCES;
1276 }
1277 return 0;
1278}
1279
Edward Creef1174f72017-08-07 15:26:19 +01001280static int check_packet_access(struct bpf_verifier_env *env, u32 regno, int off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001281 int size, bool zero_size_allowed)
Edward Creef1174f72017-08-07 15:26:19 +01001282{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001283 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +01001284 struct bpf_reg_state *reg = &regs[regno];
1285 int err;
1286
1287 /* We may have added a variable offset to the packet pointer; but any
1288 * reg->range we have comes after that. We are only checking the fixed
1289 * offset.
1290 */
1291
1292 /* We don't allow negative numbers, because we aren't tracking enough
1293 * detail to prove they're safe.
1294 */
Edward Creeb03c9f92017-08-07 15:26:36 +01001295 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001296 verbose(env, "R%d min value is negative, either use unsigned index or do a if (index >=0) check.\n",
Edward Creef1174f72017-08-07 15:26:19 +01001297 regno);
1298 return -EACCES;
1299 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001300 err = __check_packet_access(env, regno, off, size, zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001301 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001302 verbose(env, "R%d offset is outside of the packet\n", regno);
Edward Creef1174f72017-08-07 15:26:19 +01001303 return err;
1304 }
1305 return err;
1306}
1307
1308/* check access to 'struct bpf_context' fields. Supports fixed offsets only */
Yonghong Song31fd8582017-06-13 15:52:13 -07001309static int check_ctx_access(struct bpf_verifier_env *env, int insn_idx, int off, int size,
Alexei Starovoitov19de99f2016-06-15 18:25:38 -07001310 enum bpf_access_type t, enum bpf_reg_type *reg_type)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001311{
Daniel Borkmannf96da092017-07-02 02:13:27 +02001312 struct bpf_insn_access_aux info = {
1313 .reg_type = *reg_type,
1314 };
Yonghong Song31fd8582017-06-13 15:52:13 -07001315
Jakub Kicinski4f9218a2017-10-16 16:40:55 -07001316 if (env->ops->is_valid_access &&
1317 env->ops->is_valid_access(off, size, t, &info)) {
Daniel Borkmannf96da092017-07-02 02:13:27 +02001318 /* A non zero info.ctx_field_size indicates that this field is a
1319 * candidate for later verifier transformation to load the whole
1320 * field and then apply a mask when accessed with a narrower
1321 * access than actual ctx access size. A zero info.ctx_field_size
1322 * will only allow for whole field access and rejects any other
1323 * type of narrower access.
Yonghong Song31fd8582017-06-13 15:52:13 -07001324 */
Yonghong Song23994632017-06-22 15:07:39 -07001325 *reg_type = info.reg_type;
Yonghong Song31fd8582017-06-13 15:52:13 -07001326
Jakub Kicinski4f9218a2017-10-16 16:40:55 -07001327 env->insn_aux_data[insn_idx].ctx_field_size = info.ctx_field_size;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -07001328 /* remember the offset of last byte accessed in ctx */
1329 if (env->prog->aux->max_ctx_offset < off + size)
1330 env->prog->aux->max_ctx_offset = off + size;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001331 return 0;
Alexei Starovoitov32bbe002016-04-06 18:43:28 -07001332 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001333
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001334 verbose(env, "invalid bpf_context access off=%d size=%d\n", off, size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001335 return -EACCES;
1336}
1337
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001338static bool __is_pointer_value(bool allow_ptr_leaks,
1339 const struct bpf_reg_state *reg)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001340{
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001341 if (allow_ptr_leaks)
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001342 return false;
1343
Edward Creef1174f72017-08-07 15:26:19 +01001344 return reg->type != SCALAR_VALUE;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001345}
1346
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001347static bool is_pointer_value(struct bpf_verifier_env *env, int regno)
1348{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001349 return __is_pointer_value(env->allow_ptr_leaks, cur_regs(env) + regno);
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02001350}
1351
Daniel Borkmannf37a8cb2018-01-16 23:30:10 +01001352static bool is_ctx_reg(struct bpf_verifier_env *env, int regno)
1353{
1354 const struct bpf_reg_state *reg = cur_regs(env) + regno;
1355
1356 return reg->type == PTR_TO_CTX;
1357}
1358
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001359static int check_pkt_ptr_alignment(struct bpf_verifier_env *env,
1360 const struct bpf_reg_state *reg,
David S. Millerd1174412017-05-10 11:22:52 -07001361 int off, int size, bool strict)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001362{
Edward Creef1174f72017-08-07 15:26:19 +01001363 struct tnum reg_off;
David S. Millere07b98d2017-05-10 11:38:07 -07001364 int ip_align;
David S. Millerd1174412017-05-10 11:22:52 -07001365
1366 /* Byte size accesses are always allowed. */
1367 if (!strict || size == 1)
1368 return 0;
1369
David S. Millere4eda882017-05-22 12:27:07 -04001370 /* For platforms that do not have a Kconfig enabling
1371 * CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS the value of
1372 * NET_IP_ALIGN is universally set to '2'. And on platforms
1373 * that do set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, we get
1374 * to this code only in strict mode where we want to emulate
1375 * the NET_IP_ALIGN==2 checking. Therefore use an
1376 * unconditional IP align value of '2'.
David S. Millere07b98d2017-05-10 11:38:07 -07001377 */
David S. Millere4eda882017-05-22 12:27:07 -04001378 ip_align = 2;
Edward Creef1174f72017-08-07 15:26:19 +01001379
1380 reg_off = tnum_add(reg->var_off, tnum_const(ip_align + reg->off + off));
1381 if (!tnum_is_aligned(reg_off, size)) {
1382 char tn_buf[48];
1383
1384 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001385 verbose(env,
1386 "misaligned packet access off %d+%s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001387 ip_align, tn_buf, reg->off, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001388 return -EACCES;
1389 }
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001390
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001391 return 0;
1392}
1393
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001394static int check_generic_ptr_alignment(struct bpf_verifier_env *env,
1395 const struct bpf_reg_state *reg,
Edward Creef1174f72017-08-07 15:26:19 +01001396 const char *pointer_desc,
1397 int off, int size, bool strict)
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001398{
Edward Creef1174f72017-08-07 15:26:19 +01001399 struct tnum reg_off;
1400
1401 /* Byte size accesses are always allowed. */
1402 if (!strict || size == 1)
1403 return 0;
1404
1405 reg_off = tnum_add(reg->var_off, tnum_const(reg->off + off));
1406 if (!tnum_is_aligned(reg_off, size)) {
1407 char tn_buf[48];
1408
1409 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001410 verbose(env, "misaligned %saccess off %s+%d+%d size %d\n",
Edward Creef1174f72017-08-07 15:26:19 +01001411 pointer_desc, tn_buf, reg->off, off, size);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001412 return -EACCES;
1413 }
1414
1415 return 0;
1416}
1417
David S. Millere07b98d2017-05-10 11:38:07 -07001418static int check_ptr_alignment(struct bpf_verifier_env *env,
1419 const struct bpf_reg_state *reg,
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001420 int off, int size)
1421{
David S. Millere07b98d2017-05-10 11:38:07 -07001422 bool strict = env->strict_alignment;
Edward Creef1174f72017-08-07 15:26:19 +01001423 const char *pointer_desc = "";
David S. Millerd1174412017-05-10 11:22:52 -07001424
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001425 switch (reg->type) {
1426 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001427 case PTR_TO_PACKET_META:
1428 /* Special case, because of NET_IP_ALIGN. Given metadata sits
1429 * right in front, treat it the very same way.
1430 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001431 return check_pkt_ptr_alignment(env, reg, off, size, strict);
Edward Creef1174f72017-08-07 15:26:19 +01001432 case PTR_TO_MAP_VALUE:
1433 pointer_desc = "value ";
1434 break;
1435 case PTR_TO_CTX:
1436 pointer_desc = "context ";
1437 break;
1438 case PTR_TO_STACK:
1439 pointer_desc = "stack ";
Jann Horna5ec6ae2017-12-18 20:11:58 -08001440 /* The stack spill tracking logic in check_stack_write()
1441 * and check_stack_read() relies on stack accesses being
1442 * aligned.
1443 */
1444 strict = true;
Edward Creef1174f72017-08-07 15:26:19 +01001445 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001446 default:
Edward Creef1174f72017-08-07 15:26:19 +01001447 break;
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001448 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001449 return check_generic_ptr_alignment(env, reg, pointer_desc, off, size,
1450 strict);
Daniel Borkmann79adffc2017-03-31 02:24:03 +02001451}
1452
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001453static int update_stack_depth(struct bpf_verifier_env *env,
1454 const struct bpf_func_state *func,
1455 int off)
1456{
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001457 u16 stack = env->subprog_stack_depth[func->subprogno];
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001458
1459 if (stack >= -off)
1460 return 0;
1461
1462 /* update known max for given subprogram */
1463 env->subprog_stack_depth[func->subprogno] = -off;
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001464 return 0;
1465}
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001466
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001467/* starting from main bpf function walk all instructions of the function
1468 * and recursively walk all callees that given function can call.
1469 * Ignore jump and exit insns.
1470 * Since recursion is prevented by check_cfg() this algorithm
1471 * only needs a local stack of MAX_CALL_FRAMES to remember callsites
1472 */
1473static int check_max_stack_depth(struct bpf_verifier_env *env)
1474{
1475 int depth = 0, frame = 0, subprog = 0, i = 0, subprog_end;
1476 struct bpf_insn *insn = env->prog->insnsi;
1477 int insn_cnt = env->prog->len;
1478 int ret_insn[MAX_CALL_FRAMES];
1479 int ret_prog[MAX_CALL_FRAMES];
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001480
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001481process_func:
1482 /* round up to 32-bytes, since this is granularity
1483 * of interpreter stack size
1484 */
1485 depth += round_up(max_t(u32, env->subprog_stack_depth[subprog], 1), 32);
1486 if (depth > MAX_BPF_STACK) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001487 verbose(env, "combined stack size of %d calls is %d. Too large\n",
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001488 frame + 1, depth);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001489 return -EACCES;
1490 }
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08001491continue_func:
1492 if (env->subprog_cnt == subprog)
1493 subprog_end = insn_cnt;
1494 else
1495 subprog_end = env->subprog_starts[subprog];
1496 for (; i < subprog_end; i++) {
1497 if (insn[i].code != (BPF_JMP | BPF_CALL))
1498 continue;
1499 if (insn[i].src_reg != BPF_PSEUDO_CALL)
1500 continue;
1501 /* remember insn and function to return to */
1502 ret_insn[frame] = i + 1;
1503 ret_prog[frame] = subprog;
1504
1505 /* find the callee */
1506 i = i + insn[i].imm + 1;
1507 subprog = find_subprog(env, i);
1508 if (subprog < 0) {
1509 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
1510 i);
1511 return -EFAULT;
1512 }
1513 subprog++;
1514 frame++;
1515 if (frame >= MAX_CALL_FRAMES) {
1516 WARN_ONCE(1, "verifier bug. Call stack is too deep\n");
1517 return -EFAULT;
1518 }
1519 goto process_func;
1520 }
1521 /* end of for() loop means the last insn of the 'subprog'
1522 * was reached. Doesn't matter whether it was JA or EXIT
1523 */
1524 if (frame == 0)
1525 return 0;
1526 depth -= round_up(max_t(u32, env->subprog_stack_depth[subprog], 1), 32);
1527 frame--;
1528 i = ret_insn[frame];
1529 subprog = ret_prog[frame];
1530 goto continue_func;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001531}
1532
David S. Miller19d28fb2018-01-11 21:27:54 -05001533#ifndef CONFIG_BPF_JIT_ALWAYS_ON
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08001534static int get_callee_stack_depth(struct bpf_verifier_env *env,
1535 const struct bpf_insn *insn, int idx)
1536{
1537 int start = idx + insn->imm + 1, subprog;
1538
1539 subprog = find_subprog(env, start);
1540 if (subprog < 0) {
1541 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
1542 start);
1543 return -EFAULT;
1544 }
1545 subprog++;
1546 return env->subprog_stack_depth[subprog];
1547}
David S. Miller19d28fb2018-01-11 21:27:54 -05001548#endif
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08001549
Jann Horn0c17d1d2017-12-18 20:11:55 -08001550/* truncate register to smaller size (in bytes)
1551 * must be called with size < BPF_REG_SIZE
1552 */
1553static void coerce_reg_to_size(struct bpf_reg_state *reg, int size)
1554{
1555 u64 mask;
1556
1557 /* clear high bits in bit representation */
1558 reg->var_off = tnum_cast(reg->var_off, size);
1559
1560 /* fix arithmetic bounds */
1561 mask = ((u64)1 << (size * 8)) - 1;
1562 if ((reg->umin_value & ~mask) == (reg->umax_value & ~mask)) {
1563 reg->umin_value &= mask;
1564 reg->umax_value &= mask;
1565 } else {
1566 reg->umin_value = 0;
1567 reg->umax_value = mask;
1568 }
1569 reg->smin_value = reg->umin_value;
1570 reg->smax_value = reg->umax_value;
1571}
1572
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001573/* check whether memory at (regno + off) is accessible for t = (read | write)
1574 * if t==write, value_regno is a register which value is stored into memory
1575 * if t==read, value_regno is a register which will receive the value from memory
1576 * if t==write && value_regno==-1, some unknown value is stored into memory
1577 * if t==read && value_regno==-1, don't care what we read from memory
1578 */
Yonghong Song31fd8582017-06-13 15:52:13 -07001579static int check_mem_access(struct bpf_verifier_env *env, int insn_idx, u32 regno, int off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001580 int bpf_size, enum bpf_access_type t,
1581 int value_regno)
1582{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001583 struct bpf_reg_state *regs = cur_regs(env);
1584 struct bpf_reg_state *reg = regs + regno;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001585 struct bpf_func_state *state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001586 int size, err = 0;
1587
1588 size = bpf_size_to_bytes(bpf_size);
1589 if (size < 0)
1590 return size;
1591
Edward Creef1174f72017-08-07 15:26:19 +01001592 /* alignment checks will add in reg->off themselves */
David S. Millere07b98d2017-05-10 11:38:07 -07001593 err = check_ptr_alignment(env, reg, off, size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001594 if (err)
1595 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001596
Edward Creef1174f72017-08-07 15:26:19 +01001597 /* for access checks, reg->off is just part of off */
1598 off += reg->off;
1599
1600 if (reg->type == PTR_TO_MAP_VALUE) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001601 if (t == BPF_WRITE && value_regno >= 0 &&
1602 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001603 verbose(env, "R%d leaks addr into map\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001604 return -EACCES;
1605 }
Josef Bacik48461132016-09-28 10:54:32 -04001606
Yonghong Song9fd29c02017-11-12 14:49:09 -08001607 err = check_map_access(env, regno, off, size, false);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001608 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001609 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001610
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07001611 } else if (reg->type == PTR_TO_CTX) {
Edward Creef1174f72017-08-07 15:26:19 +01001612 enum bpf_reg_type reg_type = SCALAR_VALUE;
Alexei Starovoitov19de99f2016-06-15 18:25:38 -07001613
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001614 if (t == BPF_WRITE && value_regno >= 0 &&
1615 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001616 verbose(env, "R%d leaks addr into ctx\n", value_regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001617 return -EACCES;
1618 }
Edward Creef1174f72017-08-07 15:26:19 +01001619 /* ctx accesses must be at a fixed offset, so that we can
1620 * determine what type of data were returned.
1621 */
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001622 if (reg->off) {
David S. Millerf8ddadc2017-10-22 13:36:53 +01001623 verbose(env,
1624 "dereference of modified ctx ptr R%d off=%d+%d, ctx+const is allowed, ctx+const+const is not\n",
Jakub Kicinski28e33f92017-10-16 11:16:55 -07001625 regno, reg->off, off - reg->off);
1626 return -EACCES;
1627 }
1628 if (!tnum_is_const(reg->var_off) || reg->var_off.value) {
Edward Creef1174f72017-08-07 15:26:19 +01001629 char tn_buf[48];
1630
1631 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001632 verbose(env,
1633 "variable ctx access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001634 tn_buf, off, size);
1635 return -EACCES;
1636 }
Yonghong Song31fd8582017-06-13 15:52:13 -07001637 err = check_ctx_access(env, insn_idx, off, size, t, &reg_type);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001638 if (!err && t == BPF_READ && value_regno >= 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001639 /* ctx access returns either a scalar, or a
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001640 * PTR_TO_PACKET[_META,_END]. In the latter
1641 * case, we know the offset is zero.
Edward Creef1174f72017-08-07 15:26:19 +01001642 */
1643 if (reg_type == SCALAR_VALUE)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001644 mark_reg_unknown(env, regs, value_regno);
Edward Creef1174f72017-08-07 15:26:19 +01001645 else
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001646 mark_reg_known_zero(env, regs,
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001647 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001648 regs[value_regno].id = 0;
1649 regs[value_regno].off = 0;
1650 regs[value_regno].range = 0;
1651 regs[value_regno].type = reg_type;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001652 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001653
Edward Creef1174f72017-08-07 15:26:19 +01001654 } else if (reg->type == PTR_TO_STACK) {
1655 /* stack accesses must be at a fixed offset, so that we can
1656 * determine what type of data were returned.
1657 * See check_stack_read().
1658 */
1659 if (!tnum_is_const(reg->var_off)) {
1660 char tn_buf[48];
1661
1662 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001663 verbose(env, "variable stack access var_off=%s off=%d size=%d",
Edward Creef1174f72017-08-07 15:26:19 +01001664 tn_buf, off, size);
1665 return -EACCES;
1666 }
1667 off += reg->var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001668 if (off >= 0 || off < -MAX_BPF_STACK) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001669 verbose(env, "invalid stack off=%d size=%d\n", off,
1670 size);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001671 return -EACCES;
1672 }
Alexei Starovoitov87266792017-05-30 13:31:29 -07001673
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001674 state = func(env, reg);
1675 err = update_stack_depth(env, state, off);
1676 if (err)
1677 return err;
Alexei Starovoitov87266792017-05-30 13:31:29 -07001678
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001679 if (t == BPF_WRITE)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001680 err = check_stack_write(env, state, off, size,
1681 value_regno);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001682 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001683 err = check_stack_read(env, state, off, size,
1684 value_regno);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001685 } else if (reg_is_pkt_pointer(reg)) {
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001686 if (t == BPF_WRITE && !may_access_direct_pkt_data(env, NULL, t)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001687 verbose(env, "cannot write into packet\n");
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001688 return -EACCES;
1689 }
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001690 if (t == BPF_WRITE && value_regno >= 0 &&
1691 is_pointer_value(env, value_regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001692 verbose(env, "R%d leaks addr into packet\n",
1693 value_regno);
Brenden Blanco4acf6c02016-07-19 12:16:56 -07001694 return -EACCES;
1695 }
Yonghong Song9fd29c02017-11-12 14:49:09 -08001696 err = check_packet_access(env, regno, off, size, false);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001697 if (!err && t == BPF_READ && value_regno >= 0)
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001698 mark_reg_unknown(env, regs, value_regno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001699 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001700 verbose(env, "R%d invalid mem access '%s'\n", regno,
1701 reg_type_str[reg->type]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001702 return -EACCES;
1703 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001704
Edward Creef1174f72017-08-07 15:26:19 +01001705 if (!err && size < BPF_REG_SIZE && value_regno >= 0 && t == BPF_READ &&
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001706 regs[value_regno].type == SCALAR_VALUE) {
Edward Creef1174f72017-08-07 15:26:19 +01001707 /* b/h/w load zero-extends, mark upper bits as known 0 */
Jann Horn0c17d1d2017-12-18 20:11:55 -08001708 coerce_reg_to_size(&regs[value_regno], size);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07001709 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001710 return err;
1711}
1712
Yonghong Song31fd8582017-06-13 15:52:13 -07001713static int check_xadd(struct bpf_verifier_env *env, int insn_idx, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001714{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001715 int err;
1716
1717 if ((BPF_SIZE(insn->code) != BPF_W && BPF_SIZE(insn->code) != BPF_DW) ||
1718 insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001719 verbose(env, "BPF_XADD uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001720 return -EINVAL;
1721 }
1722
1723 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001724 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001725 if (err)
1726 return err;
1727
1728 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01001729 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001730 if (err)
1731 return err;
1732
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001733 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001734 verbose(env, "R%d leaks addr into mem\n", insn->src_reg);
Daniel Borkmann6bdf6ab2017-06-29 03:04:59 +02001735 return -EACCES;
1736 }
1737
Daniel Borkmannf37a8cb2018-01-16 23:30:10 +01001738 if (is_ctx_reg(env, insn->dst_reg)) {
1739 verbose(env, "BPF_XADD stores into R%d context is not allowed\n",
1740 insn->dst_reg);
1741 return -EACCES;
1742 }
1743
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001744 /* check whether atomic_add can read the memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001745 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001746 BPF_SIZE(insn->code), BPF_READ, -1);
1747 if (err)
1748 return err;
1749
1750 /* check whether atomic_add can write into the same memory */
Yonghong Song31fd8582017-06-13 15:52:13 -07001751 return check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001752 BPF_SIZE(insn->code), BPF_WRITE, -1);
1753}
1754
1755/* when register 'regno' is passed into function that will read 'access_size'
1756 * bytes from that pointer, make sure that it's within stack boundary
Edward Creef1174f72017-08-07 15:26:19 +01001757 * and all elements of stack are initialized.
1758 * Unlike most pointer bounds-checking functions, this one doesn't take an
1759 * 'off' argument, so it has to add in reg->off itself.
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001760 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001761static int check_stack_boundary(struct bpf_verifier_env *env, int regno,
Daniel Borkmann435faee12016-04-13 00:10:51 +02001762 int access_size, bool zero_size_allowed,
1763 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001764{
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001765 struct bpf_reg_state *reg = cur_regs(env) + regno;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001766 struct bpf_func_state *state = func(env, reg);
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001767 int off, i, slot, spi;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001768
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001769 if (reg->type != PTR_TO_STACK) {
Edward Creef1174f72017-08-07 15:26:19 +01001770 /* Allow zero-byte read from NULL, regardless of pointer type */
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001771 if (zero_size_allowed && access_size == 0 &&
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001772 register_is_null(reg))
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001773 return 0;
1774
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001775 verbose(env, "R%d type=%s expected=%s\n", regno,
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001776 reg_type_str[reg->type],
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001777 reg_type_str[PTR_TO_STACK]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001778 return -EACCES;
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001779 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001780
Edward Creef1174f72017-08-07 15:26:19 +01001781 /* Only allow fixed-offset stack reads */
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001782 if (!tnum_is_const(reg->var_off)) {
Edward Creef1174f72017-08-07 15:26:19 +01001783 char tn_buf[48];
1784
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001785 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001786 verbose(env, "invalid variable stack read R%d var_off=%s\n",
Edward Creef1174f72017-08-07 15:26:19 +01001787 regno, tn_buf);
Jann Hornea25f912017-12-18 20:11:57 -08001788 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01001789 }
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001790 off = reg->off + reg->var_off.value;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001791 if (off >= 0 || off < -MAX_BPF_STACK || off + access_size > 0 ||
Yonghong Song9fd29c02017-11-12 14:49:09 -08001792 access_size < 0 || (access_size == 0 && !zero_size_allowed)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001793 verbose(env, "invalid stack type R%d off=%d access_size=%d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001794 regno, off, access_size);
1795 return -EACCES;
1796 }
1797
Daniel Borkmann435faee12016-04-13 00:10:51 +02001798 if (meta && meta->raw_mode) {
1799 meta->access_size = access_size;
1800 meta->regno = regno;
1801 return 0;
1802 }
1803
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001804 for (i = 0; i < access_size; i++) {
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001805 u8 *stype;
1806
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001807 slot = -(off + i) - 1;
1808 spi = slot / BPF_REG_SIZE;
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001809 if (state->allocated_stack <= slot)
1810 goto err;
1811 stype = &state->stack[spi].slot_type[slot % BPF_REG_SIZE];
1812 if (*stype == STACK_MISC)
1813 goto mark;
1814 if (*stype == STACK_ZERO) {
1815 /* helper can write anything into the stack */
1816 *stype = STACK_MISC;
1817 goto mark;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001818 }
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08001819err:
1820 verbose(env, "invalid indirect read from stack off %d+%d size %d\n",
1821 off, i, access_size);
1822 return -EACCES;
1823mark:
1824 /* reading any byte out of 8-byte 'spill_slot' will cause
1825 * the whole slot to be marked as 'read'
1826 */
1827 mark_stack_slot_read(env, env->cur_state, env->cur_state->parent,
1828 spi, state->frameno);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001829 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08001830 return update_stack_depth(env, state, off);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001831}
1832
Gianluca Borello06c1c042017-01-09 10:19:49 -08001833static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
1834 int access_size, bool zero_size_allowed,
1835 struct bpf_call_arg_meta *meta)
1836{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001837 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Gianluca Borello06c1c042017-01-09 10:19:49 -08001838
Edward Creef1174f72017-08-07 15:26:19 +01001839 switch (reg->type) {
Gianluca Borello06c1c042017-01-09 10:19:49 -08001840 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001841 case PTR_TO_PACKET_META:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001842 return check_packet_access(env, regno, reg->off, access_size,
1843 zero_size_allowed);
Gianluca Borello06c1c042017-01-09 10:19:49 -08001844 case PTR_TO_MAP_VALUE:
Yonghong Song9fd29c02017-11-12 14:49:09 -08001845 return check_map_access(env, regno, reg->off, access_size,
1846 zero_size_allowed);
Edward Creef1174f72017-08-07 15:26:19 +01001847 default: /* scalar_value|ptr_to_stack or invalid ptr */
Gianluca Borello06c1c042017-01-09 10:19:49 -08001848 return check_stack_boundary(env, regno, access_size,
1849 zero_size_allowed, meta);
1850 }
1851}
1852
Daniel Borkmann90133412018-01-20 01:24:29 +01001853static bool arg_type_is_mem_ptr(enum bpf_arg_type type)
1854{
1855 return type == ARG_PTR_TO_MEM ||
1856 type == ARG_PTR_TO_MEM_OR_NULL ||
1857 type == ARG_PTR_TO_UNINIT_MEM;
1858}
1859
1860static bool arg_type_is_mem_size(enum bpf_arg_type type)
1861{
1862 return type == ARG_CONST_SIZE ||
1863 type == ARG_CONST_SIZE_OR_ZERO;
1864}
1865
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01001866static int check_func_arg(struct bpf_verifier_env *env, u32 regno,
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001867 enum bpf_arg_type arg_type,
1868 struct bpf_call_arg_meta *meta)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001869{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07001870 struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001871 enum bpf_reg_type expected_type, type = reg->type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001872 int err = 0;
1873
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001874 if (arg_type == ARG_DONTCARE)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001875 return 0;
1876
Edward Creedc503a82017-08-15 20:34:35 +01001877 err = check_reg_arg(env, regno, SRC_OP);
1878 if (err)
1879 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001880
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001881 if (arg_type == ARG_ANYTHING) {
1882 if (is_pointer_value(env, regno)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001883 verbose(env, "R%d leaks addr into helper function\n",
1884 regno);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001885 return -EACCES;
1886 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001887 return 0;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07001888 }
Daniel Borkmann80f1d682015-03-12 17:21:42 +01001889
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001890 if (type_is_pkt_pointer(type) &&
Thomas Graf3a0af8f2016-11-30 17:10:10 +01001891 !may_access_direct_pkt_data(env, meta, BPF_READ)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001892 verbose(env, "helper access to the packet is not allowed\n");
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001893 return -EACCES;
1894 }
1895
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001896 if (arg_type == ARG_PTR_TO_MAP_KEY ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001897 arg_type == ARG_PTR_TO_MAP_VALUE) {
1898 expected_type = PTR_TO_STACK;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001899 if (!type_is_pkt_pointer(type) &&
1900 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001901 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001902 } else if (arg_type == ARG_CONST_SIZE ||
1903 arg_type == ARG_CONST_SIZE_OR_ZERO) {
Edward Creef1174f72017-08-07 15:26:19 +01001904 expected_type = SCALAR_VALUE;
1905 if (type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001906 goto err_type;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001907 } else if (arg_type == ARG_CONST_MAP_PTR) {
1908 expected_type = CONST_PTR_TO_MAP;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001909 if (type != expected_type)
1910 goto err_type;
Alexei Starovoitov608cd712015-03-26 19:53:57 -07001911 } else if (arg_type == ARG_PTR_TO_CTX) {
1912 expected_type = PTR_TO_CTX;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001913 if (type != expected_type)
1914 goto err_type;
Daniel Borkmann90133412018-01-20 01:24:29 +01001915 } else if (arg_type_is_mem_ptr(arg_type)) {
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001916 expected_type = PTR_TO_STACK;
1917 /* One exception here. In case function allows for NULL to be
Edward Creef1174f72017-08-07 15:26:19 +01001918 * passed in as argument, it's a SCALAR_VALUE type. Final test
Daniel Borkmann8e2fe1d92016-02-19 23:05:22 +01001919 * happens during stack boundary checking.
1920 */
Alexei Starovoitov914cb782017-11-30 21:31:40 -08001921 if (register_is_null(reg) &&
Gianluca Borellodb1ac492017-11-22 18:32:53 +00001922 arg_type == ARG_PTR_TO_MEM_OR_NULL)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001923 /* final test in check_stack_boundary() */;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001924 else if (!type_is_pkt_pointer(type) &&
1925 type != PTR_TO_MAP_VALUE &&
Edward Creef1174f72017-08-07 15:26:19 +01001926 type != expected_type)
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001927 goto err_type;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001928 meta->raw_mode = arg_type == ARG_PTR_TO_UNINIT_MEM;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001929 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001930 verbose(env, "unsupported arg_type %d\n", arg_type);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001931 return -EFAULT;
1932 }
1933
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001934 if (arg_type == ARG_CONST_MAP_PTR) {
1935 /* bpf_map_xxx(map_ptr) call: remember that map_ptr */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001936 meta->map_ptr = reg->map_ptr;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001937 } else if (arg_type == ARG_PTR_TO_MAP_KEY) {
1938 /* bpf_map_xxx(..., map_ptr, ..., key) call:
1939 * check that [key, key + map->key_size) are within
1940 * stack limits and initialized
1941 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001942 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001943 /* in function declaration map_ptr must come before
1944 * map_key, so that it's verified and known before
1945 * we have to check map_key here. Otherwise it means
1946 * that kernel subsystem misconfigured verifier
1947 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001948 verbose(env, "invalid map_ptr to access map->key\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001949 return -EACCES;
1950 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001951 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001952 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001953 meta->map_ptr->key_size,
1954 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001955 else
1956 err = check_stack_boundary(env, regno,
1957 meta->map_ptr->key_size,
1958 false, NULL);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001959 } else if (arg_type == ARG_PTR_TO_MAP_VALUE) {
1960 /* bpf_map_xxx(..., map_ptr, ..., value) call:
1961 * check [value, value + map->value_size) validity
1962 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02001963 if (!meta->map_ptr) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001964 /* kernel subsystem misconfigured verifier */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001965 verbose(env, "invalid map_ptr to access map->value\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001966 return -EACCES;
1967 }
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02001968 if (type_is_pkt_pointer(type))
Edward Creef1174f72017-08-07 15:26:19 +01001969 err = check_packet_access(env, regno, reg->off,
Yonghong Song9fd29c02017-11-12 14:49:09 -08001970 meta->map_ptr->value_size,
1971 false);
Alexei Starovoitov6841de82016-08-11 18:17:16 -07001972 else
1973 err = check_stack_boundary(env, regno,
1974 meta->map_ptr->value_size,
1975 false, NULL);
Daniel Borkmann90133412018-01-20 01:24:29 +01001976 } else if (arg_type_is_mem_size(arg_type)) {
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08001977 bool zero_size_allowed = (arg_type == ARG_CONST_SIZE_OR_ZERO);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07001978
Edward Creef1174f72017-08-07 15:26:19 +01001979 /* The register is SCALAR_VALUE; the access check
1980 * happens using its boundaries.
Gianluca Borello06c1c042017-01-09 10:19:49 -08001981 */
Edward Creef1174f72017-08-07 15:26:19 +01001982 if (!tnum_is_const(reg->var_off))
Gianluca Borello06c1c042017-01-09 10:19:49 -08001983 /* For unprivileged variable accesses, disable raw
1984 * mode so that the program is required to
1985 * initialize all the memory that the helper could
1986 * just partially fill up.
1987 */
1988 meta = NULL;
1989
Edward Creeb03c9f92017-08-07 15:26:36 +01001990 if (reg->smin_value < 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07001991 verbose(env, "R%d min value is negative, either use unsigned or 'var &= const'\n",
Edward Creef1174f72017-08-07 15:26:19 +01001992 regno);
1993 return -EACCES;
1994 }
Gianluca Borello06c1c042017-01-09 10:19:49 -08001995
Edward Creeb03c9f92017-08-07 15:26:36 +01001996 if (reg->umin_value == 0) {
Edward Creef1174f72017-08-07 15:26:19 +01001997 err = check_helper_mem_access(env, regno - 1, 0,
1998 zero_size_allowed,
1999 meta);
Gianluca Borello06c1c042017-01-09 10:19:49 -08002000 if (err)
2001 return err;
Gianluca Borello06c1c042017-01-09 10:19:49 -08002002 }
Edward Creef1174f72017-08-07 15:26:19 +01002003
Edward Creeb03c9f92017-08-07 15:26:36 +01002004 if (reg->umax_value >= BPF_MAX_VAR_SIZ) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002005 verbose(env, "R%d unbounded memory access, use 'var &= const' or 'if (var < const)'\n",
Edward Creef1174f72017-08-07 15:26:19 +01002006 regno);
2007 return -EACCES;
2008 }
2009 err = check_helper_mem_access(env, regno - 1,
Edward Creeb03c9f92017-08-07 15:26:36 +01002010 reg->umax_value,
Edward Creef1174f72017-08-07 15:26:19 +01002011 zero_size_allowed, meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002012 }
2013
2014 return err;
Alexei Starovoitov6841de82016-08-11 18:17:16 -07002015err_type:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002016 verbose(env, "R%d type=%s expected=%s\n", regno,
Alexei Starovoitov6841de82016-08-11 18:17:16 -07002017 reg_type_str[type], reg_type_str[expected_type]);
2018 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002019}
2020
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002021static int check_map_func_compatibility(struct bpf_verifier_env *env,
2022 struct bpf_map *map, int func_id)
Kaixu Xia35578d72015-08-06 07:02:35 +00002023{
Kaixu Xia35578d72015-08-06 07:02:35 +00002024 if (!map)
2025 return 0;
2026
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002027 /* We need a two way check, first is from map perspective ... */
2028 switch (map->map_type) {
2029 case BPF_MAP_TYPE_PROG_ARRAY:
2030 if (func_id != BPF_FUNC_tail_call)
2031 goto error;
2032 break;
2033 case BPF_MAP_TYPE_PERF_EVENT_ARRAY:
2034 if (func_id != BPF_FUNC_perf_event_read &&
Yonghong Song908432c2017-10-05 09:19:20 -07002035 func_id != BPF_FUNC_perf_event_output &&
2036 func_id != BPF_FUNC_perf_event_read_value)
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002037 goto error;
2038 break;
2039 case BPF_MAP_TYPE_STACK_TRACE:
2040 if (func_id != BPF_FUNC_get_stackid)
2041 goto error;
2042 break;
Martin KaFai Lau4ed8ec52016-06-30 10:28:43 -07002043 case BPF_MAP_TYPE_CGROUP_ARRAY:
David S. Miller60747ef2016-08-18 01:17:32 -04002044 if (func_id != BPF_FUNC_skb_under_cgroup &&
Sargun Dhillon60d20f92016-08-12 08:56:52 -07002045 func_id != BPF_FUNC_current_task_under_cgroup)
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07002046 goto error;
2047 break;
John Fastabend546ac1f2017-07-17 09:28:56 -07002048 /* devmap returns a pointer to a live net_device ifindex that we cannot
2049 * allow to be modified from bpf side. So do not allow lookup elements
2050 * for now.
2051 */
2052 case BPF_MAP_TYPE_DEVMAP:
John Fastabend2ddf71e2017-07-17 09:30:02 -07002053 if (func_id != BPF_FUNC_redirect_map)
John Fastabend546ac1f2017-07-17 09:28:56 -07002054 goto error;
2055 break;
Jesper Dangaard Brouer6710e112017-10-16 12:19:28 +02002056 /* Restrict bpf side of cpumap, open when use-cases appear */
2057 case BPF_MAP_TYPE_CPUMAP:
2058 if (func_id != BPF_FUNC_redirect_map)
2059 goto error;
2060 break;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002061 case BPF_MAP_TYPE_ARRAY_OF_MAPS:
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07002062 case BPF_MAP_TYPE_HASH_OF_MAPS:
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07002063 if (func_id != BPF_FUNC_map_lookup_elem)
2064 goto error;
Martin KaFai Lau16a43622017-08-17 18:14:43 -07002065 break;
John Fastabend174a79f2017-08-15 22:32:47 -07002066 case BPF_MAP_TYPE_SOCKMAP:
2067 if (func_id != BPF_FUNC_sk_redirect_map &&
2068 func_id != BPF_FUNC_sock_map_update &&
2069 func_id != BPF_FUNC_map_delete_elem)
2070 goto error;
2071 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002072 default:
2073 break;
2074 }
2075
2076 /* ... and second from the function itself. */
2077 switch (func_id) {
2078 case BPF_FUNC_tail_call:
2079 if (map->map_type != BPF_MAP_TYPE_PROG_ARRAY)
2080 goto error;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002081 if (env->subprog_cnt) {
2082 verbose(env, "tail_calls are not allowed in programs with bpf-to-bpf calls\n");
2083 return -EINVAL;
2084 }
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002085 break;
2086 case BPF_FUNC_perf_event_read:
2087 case BPF_FUNC_perf_event_output:
Yonghong Song908432c2017-10-05 09:19:20 -07002088 case BPF_FUNC_perf_event_read_value:
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002089 if (map->map_type != BPF_MAP_TYPE_PERF_EVENT_ARRAY)
2090 goto error;
2091 break;
2092 case BPF_FUNC_get_stackid:
2093 if (map->map_type != BPF_MAP_TYPE_STACK_TRACE)
2094 goto error;
2095 break;
Sargun Dhillon60d20f92016-08-12 08:56:52 -07002096 case BPF_FUNC_current_task_under_cgroup:
Daniel Borkmann747ea552016-08-12 22:17:17 +02002097 case BPF_FUNC_skb_under_cgroup:
Martin KaFai Lau4a482f32016-06-30 10:28:44 -07002098 if (map->map_type != BPF_MAP_TYPE_CGROUP_ARRAY)
2099 goto error;
2100 break;
John Fastabend97f91a72017-07-17 09:29:18 -07002101 case BPF_FUNC_redirect_map:
Jesper Dangaard Brouer9c270af2017-10-16 12:19:34 +02002102 if (map->map_type != BPF_MAP_TYPE_DEVMAP &&
2103 map->map_type != BPF_MAP_TYPE_CPUMAP)
John Fastabend97f91a72017-07-17 09:29:18 -07002104 goto error;
2105 break;
John Fastabend174a79f2017-08-15 22:32:47 -07002106 case BPF_FUNC_sk_redirect_map:
2107 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
2108 goto error;
2109 break;
2110 case BPF_FUNC_sock_map_update:
2111 if (map->map_type != BPF_MAP_TYPE_SOCKMAP)
2112 goto error;
2113 break;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002114 default:
2115 break;
Kaixu Xia35578d72015-08-06 07:02:35 +00002116 }
2117
2118 return 0;
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002119error:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002120 verbose(env, "cannot pass map_type %d into func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02002121 map->map_type, func_id_name(func_id), func_id);
Alexei Starovoitov6aff67c2016-04-27 18:56:21 -07002122 return -EINVAL;
Kaixu Xia35578d72015-08-06 07:02:35 +00002123}
2124
Daniel Borkmann90133412018-01-20 01:24:29 +01002125static bool check_raw_mode_ok(const struct bpf_func_proto *fn)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002126{
2127 int count = 0;
2128
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002129 if (fn->arg1_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002130 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002131 if (fn->arg2_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002132 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002133 if (fn->arg3_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002134 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002135 if (fn->arg4_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002136 count++;
Alexei Starovoitov39f19ebb2017-01-09 10:19:50 -08002137 if (fn->arg5_type == ARG_PTR_TO_UNINIT_MEM)
Daniel Borkmann435faee12016-04-13 00:10:51 +02002138 count++;
2139
Daniel Borkmann90133412018-01-20 01:24:29 +01002140 /* We only support one arg being in raw mode at the moment,
2141 * which is sufficient for the helper functions we have
2142 * right now.
2143 */
2144 return count <= 1;
2145}
2146
2147static bool check_args_pair_invalid(enum bpf_arg_type arg_curr,
2148 enum bpf_arg_type arg_next)
2149{
2150 return (arg_type_is_mem_ptr(arg_curr) &&
2151 !arg_type_is_mem_size(arg_next)) ||
2152 (!arg_type_is_mem_ptr(arg_curr) &&
2153 arg_type_is_mem_size(arg_next));
2154}
2155
2156static bool check_arg_pair_ok(const struct bpf_func_proto *fn)
2157{
2158 /* bpf_xxx(..., buf, len) call will access 'len'
2159 * bytes from memory 'buf'. Both arg types need
2160 * to be paired, so make sure there's no buggy
2161 * helper function specification.
2162 */
2163 if (arg_type_is_mem_size(fn->arg1_type) ||
2164 arg_type_is_mem_ptr(fn->arg5_type) ||
2165 check_args_pair_invalid(fn->arg1_type, fn->arg2_type) ||
2166 check_args_pair_invalid(fn->arg2_type, fn->arg3_type) ||
2167 check_args_pair_invalid(fn->arg3_type, fn->arg4_type) ||
2168 check_args_pair_invalid(fn->arg4_type, fn->arg5_type))
2169 return false;
2170
2171 return true;
2172}
2173
2174static int check_func_proto(const struct bpf_func_proto *fn)
2175{
2176 return check_raw_mode_ok(fn) &&
2177 check_arg_pair_ok(fn) ? 0 : -EINVAL;
Daniel Borkmann435faee12016-04-13 00:10:51 +02002178}
2179
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002180/* Packet data might have moved, any old PTR_TO_PACKET[_META,_END]
2181 * are now invalid, so turn them into unknown SCALAR_VALUE.
Edward Creef1174f72017-08-07 15:26:19 +01002182 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002183static void __clear_all_pkt_pointers(struct bpf_verifier_env *env,
2184 struct bpf_func_state *state)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002185{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01002186 struct bpf_reg_state *regs = state->regs, *reg;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002187 int i;
2188
2189 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002190 if (reg_is_pkt_pointer_any(&regs[i]))
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002191 mark_reg_unknown(env, regs, i);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002192
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002193 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
2194 if (state->stack[i].slot_type[0] != STACK_SPILL)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002195 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002196 reg = &state->stack[i].spilled_ptr;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002197 if (reg_is_pkt_pointer_any(reg))
2198 __mark_reg_unknown(reg);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002199 }
2200}
2201
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002202static void clear_all_pkt_pointers(struct bpf_verifier_env *env)
2203{
2204 struct bpf_verifier_state *vstate = env->cur_state;
2205 int i;
2206
2207 for (i = 0; i <= vstate->curframe; i++)
2208 __clear_all_pkt_pointers(env, vstate->frame[i]);
2209}
2210
2211static int check_func_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
2212 int *insn_idx)
2213{
2214 struct bpf_verifier_state *state = env->cur_state;
2215 struct bpf_func_state *caller, *callee;
2216 int i, subprog, target_insn;
2217
Alexei Starovoitovaada9ce2017-12-25 13:15:42 -08002218 if (state->curframe + 1 >= MAX_CALL_FRAMES) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002219 verbose(env, "the call stack of %d frames is too deep\n",
Alexei Starovoitovaada9ce2017-12-25 13:15:42 -08002220 state->curframe + 2);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002221 return -E2BIG;
2222 }
2223
2224 target_insn = *insn_idx + insn->imm;
2225 subprog = find_subprog(env, target_insn + 1);
2226 if (subprog < 0) {
2227 verbose(env, "verifier bug. No program starts at insn %d\n",
2228 target_insn + 1);
2229 return -EFAULT;
2230 }
2231
2232 caller = state->frame[state->curframe];
2233 if (state->frame[state->curframe + 1]) {
2234 verbose(env, "verifier bug. Frame %d already allocated\n",
2235 state->curframe + 1);
2236 return -EFAULT;
2237 }
2238
2239 callee = kzalloc(sizeof(*callee), GFP_KERNEL);
2240 if (!callee)
2241 return -ENOMEM;
2242 state->frame[state->curframe + 1] = callee;
2243
2244 /* callee cannot access r0, r6 - r9 for reading and has to write
2245 * into its own stack before reading from it.
2246 * callee can read/write into caller's stack
2247 */
2248 init_func_state(env, callee,
2249 /* remember the callsite, it will be used by bpf_exit */
2250 *insn_idx /* callsite */,
2251 state->curframe + 1 /* frameno within this callchain */,
2252 subprog + 1 /* subprog number within this prog */);
2253
2254 /* copy r1 - r5 args that callee can access */
2255 for (i = BPF_REG_1; i <= BPF_REG_5; i++)
2256 callee->regs[i] = caller->regs[i];
2257
2258 /* after the call regsiters r0 - r5 were scratched */
2259 for (i = 0; i < CALLER_SAVED_REGS; i++) {
2260 mark_reg_not_init(env, caller->regs, caller_saved[i]);
2261 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
2262 }
2263
2264 /* only increment it after check_reg_arg() finished */
2265 state->curframe++;
2266
2267 /* and go analyze first insn of the callee */
2268 *insn_idx = target_insn;
2269
2270 if (env->log.level) {
2271 verbose(env, "caller:\n");
2272 print_verifier_state(env, caller);
2273 verbose(env, "callee:\n");
2274 print_verifier_state(env, callee);
2275 }
2276 return 0;
2277}
2278
2279static int prepare_func_exit(struct bpf_verifier_env *env, int *insn_idx)
2280{
2281 struct bpf_verifier_state *state = env->cur_state;
2282 struct bpf_func_state *caller, *callee;
2283 struct bpf_reg_state *r0;
2284
2285 callee = state->frame[state->curframe];
2286 r0 = &callee->regs[BPF_REG_0];
2287 if (r0->type == PTR_TO_STACK) {
2288 /* technically it's ok to return caller's stack pointer
2289 * (or caller's caller's pointer) back to the caller,
2290 * since these pointers are valid. Only current stack
2291 * pointer will be invalid as soon as function exits,
2292 * but let's be conservative
2293 */
2294 verbose(env, "cannot return stack pointer to the caller\n");
2295 return -EINVAL;
2296 }
2297
2298 state->curframe--;
2299 caller = state->frame[state->curframe];
2300 /* return to the caller whatever r0 had in the callee */
2301 caller->regs[BPF_REG_0] = *r0;
2302
2303 *insn_idx = callee->callsite + 1;
2304 if (env->log.level) {
2305 verbose(env, "returning from callee:\n");
2306 print_verifier_state(env, callee);
2307 verbose(env, "to caller at %d:\n", *insn_idx);
2308 print_verifier_state(env, caller);
2309 }
2310 /* clear everything in the callee */
2311 free_func_state(callee);
2312 state->frame[state->curframe + 1] = NULL;
2313 return 0;
2314}
2315
2316static int check_helper_call(struct bpf_verifier_env *env, int func_id, int insn_idx)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002317{
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002318 const struct bpf_func_proto *fn = NULL;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002319 struct bpf_reg_state *regs;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002320 struct bpf_call_arg_meta meta;
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002321 bool changes_data;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002322 int i, err;
2323
2324 /* find function prototype */
2325 if (func_id < 0 || func_id >= __BPF_FUNC_MAX_ID) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002326 verbose(env, "invalid func %s#%d\n", func_id_name(func_id),
2327 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002328 return -EINVAL;
2329 }
2330
Jakub Kicinski00176a32017-10-16 16:40:54 -07002331 if (env->ops->get_func_proto)
2332 fn = env->ops->get_func_proto(func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002333 if (!fn) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002334 verbose(env, "unknown func %s#%d\n", func_id_name(func_id),
2335 func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002336 return -EINVAL;
2337 }
2338
2339 /* eBPF programs must be GPL compatible to use GPL-ed functions */
Daniel Borkmann24701ec2015-03-01 12:31:47 +01002340 if (!env->prog->gpl_compatible && fn->gpl_only) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002341 verbose(env, "cannot call GPL only function from proprietary program\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002342 return -EINVAL;
2343 }
2344
Daniel Borkmann04514d12017-12-14 21:07:25 +01002345 /* With LD_ABS/IND some JITs save/restore skb from r1. */
Martin KaFai Lau17bedab2016-12-07 15:53:11 -08002346 changes_data = bpf_helper_changes_pkt_data(fn->func);
Daniel Borkmann04514d12017-12-14 21:07:25 +01002347 if (changes_data && fn->arg1_type != ARG_PTR_TO_CTX) {
2348 verbose(env, "kernel subsystem misconfigured func %s#%d: r1 != ctx\n",
2349 func_id_name(func_id), func_id);
2350 return -EINVAL;
2351 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002352
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002353 memset(&meta, 0, sizeof(meta));
Daniel Borkmann36bbef52016-09-20 00:26:13 +02002354 meta.pkt_access = fn->pkt_access;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002355
Daniel Borkmann90133412018-01-20 01:24:29 +01002356 err = check_func_proto(fn);
Daniel Borkmann435faee12016-04-13 00:10:51 +02002357 if (err) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002358 verbose(env, "kernel subsystem misconfigured func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02002359 func_id_name(func_id), func_id);
Daniel Borkmann435faee12016-04-13 00:10:51 +02002360 return err;
2361 }
2362
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002363 /* check args */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002364 err = check_func_arg(env, BPF_REG_1, fn->arg1_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002365 if (err)
2366 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002367 err = check_func_arg(env, BPF_REG_2, fn->arg2_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002368 if (err)
2369 return err;
Alexei Starovoitovb2157392018-01-07 17:33:02 -08002370 if (func_id == BPF_FUNC_tail_call) {
2371 if (meta.map_ptr == NULL) {
2372 verbose(env, "verifier bug\n");
2373 return -EINVAL;
2374 }
2375 env->insn_aux_data[insn_idx].map_ptr = meta.map_ptr;
2376 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002377 err = check_func_arg(env, BPF_REG_3, fn->arg3_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002378 if (err)
2379 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002380 err = check_func_arg(env, BPF_REG_4, fn->arg4_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002381 if (err)
2382 return err;
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002383 err = check_func_arg(env, BPF_REG_5, fn->arg5_type, &meta);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002384 if (err)
2385 return err;
2386
Daniel Borkmann435faee12016-04-13 00:10:51 +02002387 /* Mark slots with STACK_MISC in case of raw mode, stack offset
2388 * is inferred from register state.
2389 */
2390 for (i = 0; i < meta.access_size; i++) {
Yonghong Song31fd8582017-06-13 15:52:13 -07002391 err = check_mem_access(env, insn_idx, meta.regno, i, BPF_B, BPF_WRITE, -1);
Daniel Borkmann435faee12016-04-13 00:10:51 +02002392 if (err)
2393 return err;
2394 }
2395
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002396 regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002397 /* reset caller saved regs */
Edward Creedc503a82017-08-15 20:34:35 +01002398 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002399 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01002400 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
2401 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002402
Edward Creedc503a82017-08-15 20:34:35 +01002403 /* update return register (already marked as written above) */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002404 if (fn->ret_type == RET_INTEGER) {
Edward Creef1174f72017-08-07 15:26:19 +01002405 /* sets type to SCALAR_VALUE */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002406 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002407 } else if (fn->ret_type == RET_VOID) {
2408 regs[BPF_REG_0].type = NOT_INIT;
2409 } else if (fn->ret_type == RET_PTR_TO_MAP_VALUE_OR_NULL) {
Martin KaFai Laufad73a12017-03-22 10:00:32 -07002410 struct bpf_insn_aux_data *insn_aux;
2411
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002412 regs[BPF_REG_0].type = PTR_TO_MAP_VALUE_OR_NULL;
Edward Creef1174f72017-08-07 15:26:19 +01002413 /* There is no offset yet applied, variable or fixed */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002414 mark_reg_known_zero(env, regs, BPF_REG_0);
Edward Creef1174f72017-08-07 15:26:19 +01002415 regs[BPF_REG_0].off = 0;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002416 /* remember map_ptr, so that check_map_access()
2417 * can check 'value_size' boundary of memory access
2418 * to map element returned from bpf_map_lookup_elem()
2419 */
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002420 if (meta.map_ptr == NULL) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002421 verbose(env,
2422 "kernel subsystem misconfigured verifier\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002423 return -EINVAL;
2424 }
Daniel Borkmann33ff9822016-04-13 00:10:50 +02002425 regs[BPF_REG_0].map_ptr = meta.map_ptr;
Thomas Graf57a09bf2016-10-18 19:51:19 +02002426 regs[BPF_REG_0].id = ++env->id_gen;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07002427 insn_aux = &env->insn_aux_data[insn_idx];
2428 if (!insn_aux->map_ptr)
2429 insn_aux->map_ptr = meta.map_ptr;
2430 else if (insn_aux->map_ptr != meta.map_ptr)
2431 insn_aux->map_ptr = BPF_MAP_PTR_POISON;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002432 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002433 verbose(env, "unknown return type %d of func %s#%d\n",
Thomas Grafebb676d2016-10-27 11:23:51 +02002434 fn->ret_type, func_id_name(func_id), func_id);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07002435 return -EINVAL;
2436 }
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07002437
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002438 err = check_map_func_compatibility(env, meta.map_ptr, func_id);
Kaixu Xia35578d72015-08-06 07:02:35 +00002439 if (err)
2440 return err;
Alexei Starovoitov04fd61ab2015-05-19 16:59:03 -07002441
Alexei Starovoitov969bf052016-05-05 19:49:10 -07002442 if (changes_data)
2443 clear_all_pkt_pointers(env);
2444 return 0;
2445}
2446
Edward Creeb03c9f92017-08-07 15:26:36 +01002447static bool signed_add_overflows(s64 a, s64 b)
2448{
2449 /* Do the add in u64, where overflow is well-defined */
2450 s64 res = (s64)((u64)a + (u64)b);
2451
2452 if (b < 0)
2453 return res > a;
2454 return res < a;
2455}
2456
2457static bool signed_sub_overflows(s64 a, s64 b)
2458{
2459 /* Do the sub in u64, where overflow is well-defined */
2460 s64 res = (s64)((u64)a - (u64)b);
2461
2462 if (b < 0)
2463 return res < a;
2464 return res > a;
David S. Millerd1174412017-05-10 11:22:52 -07002465}
2466
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002467static bool check_reg_sane_offset(struct bpf_verifier_env *env,
2468 const struct bpf_reg_state *reg,
2469 enum bpf_reg_type type)
2470{
2471 bool known = tnum_is_const(reg->var_off);
2472 s64 val = reg->var_off.value;
2473 s64 smin = reg->smin_value;
2474
2475 if (known && (val >= BPF_MAX_VAR_OFF || val <= -BPF_MAX_VAR_OFF)) {
2476 verbose(env, "math between %s pointer and %lld is not allowed\n",
2477 reg_type_str[type], val);
2478 return false;
2479 }
2480
2481 if (reg->off >= BPF_MAX_VAR_OFF || reg->off <= -BPF_MAX_VAR_OFF) {
2482 verbose(env, "%s pointer offset %d is not allowed\n",
2483 reg_type_str[type], reg->off);
2484 return false;
2485 }
2486
2487 if (smin == S64_MIN) {
2488 verbose(env, "math between %s pointer and register with unbounded min value is not allowed\n",
2489 reg_type_str[type]);
2490 return false;
2491 }
2492
2493 if (smin >= BPF_MAX_VAR_OFF || smin <= -BPF_MAX_VAR_OFF) {
2494 verbose(env, "value %lld makes %s pointer be out of bounds\n",
2495 smin, reg_type_str[type]);
2496 return false;
2497 }
2498
2499 return true;
2500}
2501
Edward Creef1174f72017-08-07 15:26:19 +01002502/* Handles arithmetic on a pointer and a scalar: computes new min/max and var_off.
Edward Creef1174f72017-08-07 15:26:19 +01002503 * Caller should also handle BPF_MOV case separately.
2504 * If we return -EACCES, caller may want to try again treating pointer as a
2505 * scalar. So we only emit a diagnostic if !env->allow_ptr_leaks.
2506 */
2507static int adjust_ptr_min_max_vals(struct bpf_verifier_env *env,
2508 struct bpf_insn *insn,
2509 const struct bpf_reg_state *ptr_reg,
2510 const struct bpf_reg_state *off_reg)
Josef Bacik48461132016-09-28 10:54:32 -04002511{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002512 struct bpf_verifier_state *vstate = env->cur_state;
2513 struct bpf_func_state *state = vstate->frame[vstate->curframe];
2514 struct bpf_reg_state *regs = state->regs, *dst_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002515 bool known = tnum_is_const(off_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002516 s64 smin_val = off_reg->smin_value, smax_val = off_reg->smax_value,
2517 smin_ptr = ptr_reg->smin_value, smax_ptr = ptr_reg->smax_value;
2518 u64 umin_val = off_reg->umin_value, umax_val = off_reg->umax_value,
2519 umin_ptr = ptr_reg->umin_value, umax_ptr = ptr_reg->umax_value;
Josef Bacik48461132016-09-28 10:54:32 -04002520 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01002521 u32 dst = insn->dst_reg;
Josef Bacik48461132016-09-28 10:54:32 -04002522
Edward Creef1174f72017-08-07 15:26:19 +01002523 dst_reg = &regs[dst];
Josef Bacik48461132016-09-28 10:54:32 -04002524
Daniel Borkmann6f161012018-01-18 01:15:21 +01002525 if ((known && (smin_val != smax_val || umin_val != umax_val)) ||
2526 smin_val > smax_val || umin_val > umax_val) {
2527 /* Taint dst register if offset had invalid bounds derived from
2528 * e.g. dead branches.
2529 */
2530 __mark_reg_unknown(dst_reg);
2531 return 0;
Josef Bacik48461132016-09-28 10:54:32 -04002532 }
2533
Edward Creef1174f72017-08-07 15:26:19 +01002534 if (BPF_CLASS(insn->code) != BPF_ALU64) {
2535 /* 32-bit ALU ops on pointers produce (meaningless) scalars */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002536 verbose(env,
2537 "R%d 32-bit pointer arithmetic prohibited\n",
2538 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002539 return -EACCES;
2540 }
David S. Millerd1174412017-05-10 11:22:52 -07002541
Edward Creef1174f72017-08-07 15:26:19 +01002542 if (ptr_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002543 verbose(env, "R%d pointer arithmetic on PTR_TO_MAP_VALUE_OR_NULL prohibited, null-check it first\n",
2544 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002545 return -EACCES;
2546 }
2547 if (ptr_reg->type == CONST_PTR_TO_MAP) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002548 verbose(env, "R%d pointer arithmetic on CONST_PTR_TO_MAP prohibited\n",
2549 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002550 return -EACCES;
2551 }
2552 if (ptr_reg->type == PTR_TO_PACKET_END) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002553 verbose(env, "R%d pointer arithmetic on PTR_TO_PACKET_END prohibited\n",
2554 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002555 return -EACCES;
2556 }
2557
2558 /* In case of 'scalar += pointer', dst_reg inherits pointer type and id.
2559 * The id may be overwritten later if we create a new variable offset.
Josef Bacik48461132016-09-28 10:54:32 -04002560 */
Edward Creef1174f72017-08-07 15:26:19 +01002561 dst_reg->type = ptr_reg->type;
2562 dst_reg->id = ptr_reg->id;
Josef Bacikf23cc642016-11-14 15:45:36 -05002563
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002564 if (!check_reg_sane_offset(env, off_reg, ptr_reg->type) ||
2565 !check_reg_sane_offset(env, ptr_reg, ptr_reg->type))
2566 return -EINVAL;
2567
Josef Bacik48461132016-09-28 10:54:32 -04002568 switch (opcode) {
2569 case BPF_ADD:
Edward Creef1174f72017-08-07 15:26:19 +01002570 /* We can take a fixed offset as long as it doesn't overflow
2571 * the s32 'off' field
2572 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002573 if (known && (ptr_reg->off + smin_val ==
2574 (s64)(s32)(ptr_reg->off + smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01002575 /* pointer += K. Accumulate it into fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01002576 dst_reg->smin_value = smin_ptr;
2577 dst_reg->smax_value = smax_ptr;
2578 dst_reg->umin_value = umin_ptr;
2579 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01002580 dst_reg->var_off = ptr_reg->var_off;
Edward Creeb03c9f92017-08-07 15:26:36 +01002581 dst_reg->off = ptr_reg->off + smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01002582 dst_reg->range = ptr_reg->range;
2583 break;
2584 }
Edward Creef1174f72017-08-07 15:26:19 +01002585 /* A new variable offset is created. Note that off_reg->off
2586 * == 0, since it's a scalar.
2587 * dst_reg gets the pointer type and since some positive
2588 * integer value was added to the pointer, give it a new 'id'
2589 * if it's a PTR_TO_PACKET.
2590 * this creates a new 'base' pointer, off_reg (variable) gets
2591 * added into the variable offset, and we copy the fixed offset
2592 * from ptr_reg.
2593 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002594 if (signed_add_overflows(smin_ptr, smin_val) ||
2595 signed_add_overflows(smax_ptr, smax_val)) {
2596 dst_reg->smin_value = S64_MIN;
2597 dst_reg->smax_value = S64_MAX;
2598 } else {
2599 dst_reg->smin_value = smin_ptr + smin_val;
2600 dst_reg->smax_value = smax_ptr + smax_val;
2601 }
2602 if (umin_ptr + umin_val < umin_ptr ||
2603 umax_ptr + umax_val < umax_ptr) {
2604 dst_reg->umin_value = 0;
2605 dst_reg->umax_value = U64_MAX;
2606 } else {
2607 dst_reg->umin_value = umin_ptr + umin_val;
2608 dst_reg->umax_value = umax_ptr + umax_val;
2609 }
Edward Creef1174f72017-08-07 15:26:19 +01002610 dst_reg->var_off = tnum_add(ptr_reg->var_off, off_reg->var_off);
2611 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002612 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01002613 dst_reg->id = ++env->id_gen;
2614 /* something was added to pkt_ptr, set range to zero */
2615 dst_reg->range = 0;
2616 }
Josef Bacik48461132016-09-28 10:54:32 -04002617 break;
2618 case BPF_SUB:
Edward Creef1174f72017-08-07 15:26:19 +01002619 if (dst_reg == off_reg) {
2620 /* scalar -= pointer. Creates an unknown scalar */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002621 verbose(env, "R%d tried to subtract pointer from scalar\n",
2622 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002623 return -EACCES;
2624 }
2625 /* We don't allow subtraction from FP, because (according to
2626 * test_verifier.c test "invalid fp arithmetic", JITs might not
2627 * be able to deal with it.
Edward Cree93057062017-07-21 14:37:34 +01002628 */
Edward Creef1174f72017-08-07 15:26:19 +01002629 if (ptr_reg->type == PTR_TO_STACK) {
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002630 verbose(env, "R%d subtraction from stack pointer prohibited\n",
2631 dst);
Edward Creef1174f72017-08-07 15:26:19 +01002632 return -EACCES;
2633 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002634 if (known && (ptr_reg->off - smin_val ==
2635 (s64)(s32)(ptr_reg->off - smin_val))) {
Edward Creef1174f72017-08-07 15:26:19 +01002636 /* pointer -= K. Subtract it from fixed offset */
Edward Creeb03c9f92017-08-07 15:26:36 +01002637 dst_reg->smin_value = smin_ptr;
2638 dst_reg->smax_value = smax_ptr;
2639 dst_reg->umin_value = umin_ptr;
2640 dst_reg->umax_value = umax_ptr;
Edward Creef1174f72017-08-07 15:26:19 +01002641 dst_reg->var_off = ptr_reg->var_off;
2642 dst_reg->id = ptr_reg->id;
Edward Creeb03c9f92017-08-07 15:26:36 +01002643 dst_reg->off = ptr_reg->off - smin_val;
Edward Creef1174f72017-08-07 15:26:19 +01002644 dst_reg->range = ptr_reg->range;
2645 break;
2646 }
Edward Creef1174f72017-08-07 15:26:19 +01002647 /* A new variable offset is created. If the subtrahend is known
2648 * nonnegative, then any reg->range we had before is still good.
2649 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002650 if (signed_sub_overflows(smin_ptr, smax_val) ||
2651 signed_sub_overflows(smax_ptr, smin_val)) {
2652 /* Overflow possible, we know nothing */
2653 dst_reg->smin_value = S64_MIN;
2654 dst_reg->smax_value = S64_MAX;
2655 } else {
2656 dst_reg->smin_value = smin_ptr - smax_val;
2657 dst_reg->smax_value = smax_ptr - smin_val;
2658 }
2659 if (umin_ptr < umax_val) {
2660 /* Overflow possible, we know nothing */
2661 dst_reg->umin_value = 0;
2662 dst_reg->umax_value = U64_MAX;
2663 } else {
2664 /* Cannot overflow (as long as bounds are consistent) */
2665 dst_reg->umin_value = umin_ptr - umax_val;
2666 dst_reg->umax_value = umax_ptr - umin_val;
2667 }
Edward Creef1174f72017-08-07 15:26:19 +01002668 dst_reg->var_off = tnum_sub(ptr_reg->var_off, off_reg->var_off);
2669 dst_reg->off = ptr_reg->off;
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02002670 if (reg_is_pkt_pointer(ptr_reg)) {
Edward Creef1174f72017-08-07 15:26:19 +01002671 dst_reg->id = ++env->id_gen;
2672 /* something was added to pkt_ptr, set range to zero */
Edward Creeb03c9f92017-08-07 15:26:36 +01002673 if (smin_val < 0)
Edward Creef1174f72017-08-07 15:26:19 +01002674 dst_reg->range = 0;
2675 }
2676 break;
2677 case BPF_AND:
2678 case BPF_OR:
2679 case BPF_XOR:
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002680 /* bitwise ops on pointers are troublesome, prohibit. */
2681 verbose(env, "R%d bitwise operator %s on pointer prohibited\n",
2682 dst, bpf_alu_string[opcode >> 4]);
Edward Creef1174f72017-08-07 15:26:19 +01002683 return -EACCES;
2684 default:
2685 /* other operators (e.g. MUL,LSH) produce non-pointer results */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002686 verbose(env, "R%d pointer arithmetic with %s operator prohibited\n",
2687 dst, bpf_alu_string[opcode >> 4]);
Edward Creef1174f72017-08-07 15:26:19 +01002688 return -EACCES;
2689 }
2690
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002691 if (!check_reg_sane_offset(env, dst_reg, ptr_reg->type))
2692 return -EINVAL;
2693
Edward Creeb03c9f92017-08-07 15:26:36 +01002694 __update_reg_bounds(dst_reg);
2695 __reg_deduce_bounds(dst_reg);
2696 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002697 return 0;
2698}
2699
Jann Horn468f6ea2017-12-18 20:11:56 -08002700/* WARNING: This function does calculations on 64-bit values, but the actual
2701 * execution may occur on 32-bit values. Therefore, things like bitshifts
2702 * need extra checks in the 32-bit case.
2703 */
Edward Creef1174f72017-08-07 15:26:19 +01002704static int adjust_scalar_min_max_vals(struct bpf_verifier_env *env,
2705 struct bpf_insn *insn,
2706 struct bpf_reg_state *dst_reg,
2707 struct bpf_reg_state src_reg)
2708{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07002709 struct bpf_reg_state *regs = cur_regs(env);
Edward Creef1174f72017-08-07 15:26:19 +01002710 u8 opcode = BPF_OP(insn->code);
2711 bool src_known, dst_known;
Edward Creeb03c9f92017-08-07 15:26:36 +01002712 s64 smin_val, smax_val;
2713 u64 umin_val, umax_val;
Jann Horn468f6ea2017-12-18 20:11:56 -08002714 u64 insn_bitness = (BPF_CLASS(insn->code) == BPF_ALU64) ? 64 : 32;
Edward Creef1174f72017-08-07 15:26:19 +01002715
Edward Creeb03c9f92017-08-07 15:26:36 +01002716 smin_val = src_reg.smin_value;
2717 smax_val = src_reg.smax_value;
2718 umin_val = src_reg.umin_value;
2719 umax_val = src_reg.umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002720 src_known = tnum_is_const(src_reg.var_off);
2721 dst_known = tnum_is_const(dst_reg->var_off);
2722
Daniel Borkmann6f161012018-01-18 01:15:21 +01002723 if ((src_known && (smin_val != smax_val || umin_val != umax_val)) ||
2724 smin_val > smax_val || umin_val > umax_val) {
2725 /* Taint dst register if offset had invalid bounds derived from
2726 * e.g. dead branches.
2727 */
2728 __mark_reg_unknown(dst_reg);
2729 return 0;
2730 }
2731
Alexei Starovoitovbb7f0f92017-12-18 20:12:00 -08002732 if (!src_known &&
2733 opcode != BPF_ADD && opcode != BPF_SUB && opcode != BPF_AND) {
2734 __mark_reg_unknown(dst_reg);
2735 return 0;
2736 }
2737
Edward Creef1174f72017-08-07 15:26:19 +01002738 switch (opcode) {
2739 case BPF_ADD:
Edward Creeb03c9f92017-08-07 15:26:36 +01002740 if (signed_add_overflows(dst_reg->smin_value, smin_val) ||
2741 signed_add_overflows(dst_reg->smax_value, smax_val)) {
2742 dst_reg->smin_value = S64_MIN;
2743 dst_reg->smax_value = S64_MAX;
2744 } else {
2745 dst_reg->smin_value += smin_val;
2746 dst_reg->smax_value += smax_val;
2747 }
2748 if (dst_reg->umin_value + umin_val < umin_val ||
2749 dst_reg->umax_value + umax_val < umax_val) {
2750 dst_reg->umin_value = 0;
2751 dst_reg->umax_value = U64_MAX;
2752 } else {
2753 dst_reg->umin_value += umin_val;
2754 dst_reg->umax_value += umax_val;
2755 }
Edward Creef1174f72017-08-07 15:26:19 +01002756 dst_reg->var_off = tnum_add(dst_reg->var_off, src_reg.var_off);
2757 break;
2758 case BPF_SUB:
Edward Creeb03c9f92017-08-07 15:26:36 +01002759 if (signed_sub_overflows(dst_reg->smin_value, smax_val) ||
2760 signed_sub_overflows(dst_reg->smax_value, smin_val)) {
2761 /* Overflow possible, we know nothing */
2762 dst_reg->smin_value = S64_MIN;
2763 dst_reg->smax_value = S64_MAX;
2764 } else {
2765 dst_reg->smin_value -= smax_val;
2766 dst_reg->smax_value -= smin_val;
2767 }
2768 if (dst_reg->umin_value < umax_val) {
2769 /* Overflow possible, we know nothing */
2770 dst_reg->umin_value = 0;
2771 dst_reg->umax_value = U64_MAX;
2772 } else {
2773 /* Cannot overflow (as long as bounds are consistent) */
2774 dst_reg->umin_value -= umax_val;
2775 dst_reg->umax_value -= umin_val;
2776 }
Edward Creef1174f72017-08-07 15:26:19 +01002777 dst_reg->var_off = tnum_sub(dst_reg->var_off, src_reg.var_off);
Josef Bacik48461132016-09-28 10:54:32 -04002778 break;
2779 case BPF_MUL:
Edward Creeb03c9f92017-08-07 15:26:36 +01002780 dst_reg->var_off = tnum_mul(dst_reg->var_off, src_reg.var_off);
2781 if (smin_val < 0 || dst_reg->smin_value < 0) {
Edward Creef1174f72017-08-07 15:26:19 +01002782 /* Ain't nobody got time to multiply that sign */
Edward Creeb03c9f92017-08-07 15:26:36 +01002783 __mark_reg_unbounded(dst_reg);
2784 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002785 break;
2786 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002787 /* Both values are positive, so we can work with unsigned and
2788 * copy the result to signed (unless it exceeds S64_MAX).
Edward Creef1174f72017-08-07 15:26:19 +01002789 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002790 if (umax_val > U32_MAX || dst_reg->umax_value > U32_MAX) {
2791 /* Potential overflow, we know nothing */
2792 __mark_reg_unbounded(dst_reg);
2793 /* (except what we can learn from the var_off) */
2794 __update_reg_bounds(dst_reg);
2795 break;
2796 }
2797 dst_reg->umin_value *= umin_val;
2798 dst_reg->umax_value *= umax_val;
2799 if (dst_reg->umax_value > S64_MAX) {
2800 /* Overflow possible, we know nothing */
2801 dst_reg->smin_value = S64_MIN;
2802 dst_reg->smax_value = S64_MAX;
2803 } else {
2804 dst_reg->smin_value = dst_reg->umin_value;
2805 dst_reg->smax_value = dst_reg->umax_value;
2806 }
Josef Bacik48461132016-09-28 10:54:32 -04002807 break;
2808 case BPF_AND:
Edward Creef1174f72017-08-07 15:26:19 +01002809 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002810 __mark_reg_known(dst_reg, dst_reg->var_off.value &
2811 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002812 break;
2813 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002814 /* We get our minimum from the var_off, since that's inherently
2815 * bitwise. Our maximum is the minimum of the operands' maxima.
Josef Bacikf23cc642016-11-14 15:45:36 -05002816 */
Edward Creef1174f72017-08-07 15:26:19 +01002817 dst_reg->var_off = tnum_and(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002818 dst_reg->umin_value = dst_reg->var_off.value;
2819 dst_reg->umax_value = min(dst_reg->umax_value, umax_val);
2820 if (dst_reg->smin_value < 0 || smin_val < 0) {
2821 /* Lose signed bounds when ANDing negative numbers,
2822 * ain't nobody got time for that.
2823 */
2824 dst_reg->smin_value = S64_MIN;
2825 dst_reg->smax_value = S64_MAX;
2826 } else {
2827 /* ANDing two positives gives a positive, so safe to
2828 * cast result into s64.
2829 */
2830 dst_reg->smin_value = dst_reg->umin_value;
2831 dst_reg->smax_value = dst_reg->umax_value;
2832 }
2833 /* We may learn something more from the var_off */
2834 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002835 break;
2836 case BPF_OR:
2837 if (src_known && dst_known) {
Edward Creeb03c9f92017-08-07 15:26:36 +01002838 __mark_reg_known(dst_reg, dst_reg->var_off.value |
2839 src_reg.var_off.value);
Edward Creef1174f72017-08-07 15:26:19 +01002840 break;
2841 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002842 /* We get our maximum from the var_off, and our minimum is the
2843 * maximum of the operands' minima
Edward Creef1174f72017-08-07 15:26:19 +01002844 */
2845 dst_reg->var_off = tnum_or(dst_reg->var_off, src_reg.var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01002846 dst_reg->umin_value = max(dst_reg->umin_value, umin_val);
2847 dst_reg->umax_value = dst_reg->var_off.value |
2848 dst_reg->var_off.mask;
2849 if (dst_reg->smin_value < 0 || smin_val < 0) {
2850 /* Lose signed bounds when ORing negative numbers,
2851 * ain't nobody got time for that.
2852 */
2853 dst_reg->smin_value = S64_MIN;
2854 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002855 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002856 /* ORing two positives gives a positive, so safe to
2857 * cast result into s64.
2858 */
2859 dst_reg->smin_value = dst_reg->umin_value;
2860 dst_reg->smax_value = dst_reg->umax_value;
Edward Creef1174f72017-08-07 15:26:19 +01002861 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002862 /* We may learn something more from the var_off */
2863 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002864 break;
2865 case BPF_LSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002866 if (umax_val >= insn_bitness) {
2867 /* Shifts greater than 31 or 63 are undefined.
2868 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002869 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002870 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002871 break;
2872 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002873 /* We lose all sign bit information (except what we can pick
2874 * up from var_off)
Josef Bacik48461132016-09-28 10:54:32 -04002875 */
Edward Creeb03c9f92017-08-07 15:26:36 +01002876 dst_reg->smin_value = S64_MIN;
2877 dst_reg->smax_value = S64_MAX;
2878 /* If we might shift our top bit out, then we know nothing */
2879 if (dst_reg->umax_value > 1ULL << (63 - umax_val)) {
2880 dst_reg->umin_value = 0;
2881 dst_reg->umax_value = U64_MAX;
David S. Millerd1174412017-05-10 11:22:52 -07002882 } else {
Edward Creeb03c9f92017-08-07 15:26:36 +01002883 dst_reg->umin_value <<= umin_val;
2884 dst_reg->umax_value <<= umax_val;
David S. Millerd1174412017-05-10 11:22:52 -07002885 }
Edward Creeb03c9f92017-08-07 15:26:36 +01002886 if (src_known)
2887 dst_reg->var_off = tnum_lshift(dst_reg->var_off, umin_val);
2888 else
2889 dst_reg->var_off = tnum_lshift(tnum_unknown, umin_val);
2890 /* We may learn something more from the var_off */
2891 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002892 break;
2893 case BPF_RSH:
Jann Horn468f6ea2017-12-18 20:11:56 -08002894 if (umax_val >= insn_bitness) {
2895 /* Shifts greater than 31 or 63 are undefined.
2896 * This includes shifts by a negative number.
Edward Creeb03c9f92017-08-07 15:26:36 +01002897 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002898 mark_reg_unknown(env, regs, insn->dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002899 break;
2900 }
Edward Cree4374f252017-12-18 20:11:53 -08002901 /* BPF_RSH is an unsigned shift. If the value in dst_reg might
2902 * be negative, then either:
2903 * 1) src_reg might be zero, so the sign bit of the result is
2904 * unknown, so we lose our signed bounds
2905 * 2) it's known negative, thus the unsigned bounds capture the
2906 * signed bounds
2907 * 3) the signed bounds cross zero, so they tell us nothing
2908 * about the result
2909 * If the value in dst_reg is known nonnegative, then again the
2910 * unsigned bounts capture the signed bounds.
2911 * Thus, in all cases it suffices to blow away our signed bounds
2912 * and rely on inferring new ones from the unsigned bounds and
2913 * var_off of the result.
2914 */
2915 dst_reg->smin_value = S64_MIN;
2916 dst_reg->smax_value = S64_MAX;
Edward Creef1174f72017-08-07 15:26:19 +01002917 if (src_known)
Edward Creeb03c9f92017-08-07 15:26:36 +01002918 dst_reg->var_off = tnum_rshift(dst_reg->var_off,
2919 umin_val);
Edward Creef1174f72017-08-07 15:26:19 +01002920 else
Edward Creeb03c9f92017-08-07 15:26:36 +01002921 dst_reg->var_off = tnum_rshift(tnum_unknown, umin_val);
2922 dst_reg->umin_value >>= umax_val;
2923 dst_reg->umax_value >>= umin_val;
2924 /* We may learn something more from the var_off */
2925 __update_reg_bounds(dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002926 break;
2927 default:
Jakub Kicinski61bd5212017-10-09 10:30:11 -07002928 mark_reg_unknown(env, regs, insn->dst_reg);
Josef Bacik48461132016-09-28 10:54:32 -04002929 break;
2930 }
2931
Jann Horn468f6ea2017-12-18 20:11:56 -08002932 if (BPF_CLASS(insn->code) != BPF_ALU64) {
2933 /* 32-bit ALU ops are (32,32)->32 */
2934 coerce_reg_to_size(dst_reg, 4);
2935 coerce_reg_to_size(&src_reg, 4);
2936 }
2937
Edward Creeb03c9f92017-08-07 15:26:36 +01002938 __reg_deduce_bounds(dst_reg);
2939 __reg_bound_offset(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002940 return 0;
2941}
2942
2943/* Handles ALU ops other than BPF_END, BPF_NEG and BPF_MOV: computes new min/max
2944 * and var_off.
2945 */
2946static int adjust_reg_min_max_vals(struct bpf_verifier_env *env,
2947 struct bpf_insn *insn)
2948{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08002949 struct bpf_verifier_state *vstate = env->cur_state;
2950 struct bpf_func_state *state = vstate->frame[vstate->curframe];
2951 struct bpf_reg_state *regs = state->regs, *dst_reg, *src_reg;
Edward Creef1174f72017-08-07 15:26:19 +01002952 struct bpf_reg_state *ptr_reg = NULL, off_reg = {0};
2953 u8 opcode = BPF_OP(insn->code);
Edward Creef1174f72017-08-07 15:26:19 +01002954
2955 dst_reg = &regs[insn->dst_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002956 src_reg = NULL;
2957 if (dst_reg->type != SCALAR_VALUE)
2958 ptr_reg = dst_reg;
2959 if (BPF_SRC(insn->code) == BPF_X) {
2960 src_reg = &regs[insn->src_reg];
Edward Creef1174f72017-08-07 15:26:19 +01002961 if (src_reg->type != SCALAR_VALUE) {
2962 if (dst_reg->type != SCALAR_VALUE) {
2963 /* Combining two pointers by any ALU op yields
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002964 * an arbitrary scalar. Disallow all math except
2965 * pointer subtraction
Edward Creef1174f72017-08-07 15:26:19 +01002966 */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002967 if (opcode == BPF_SUB){
2968 mark_reg_unknown(env, regs, insn->dst_reg);
2969 return 0;
Edward Creef1174f72017-08-07 15:26:19 +01002970 }
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002971 verbose(env, "R%d pointer %s pointer prohibited\n",
2972 insn->dst_reg,
2973 bpf_alu_string[opcode >> 4]);
2974 return -EACCES;
Edward Creef1174f72017-08-07 15:26:19 +01002975 } else {
2976 /* scalar += pointer
2977 * This is legal, but we have to reverse our
2978 * src/dest handling in computing the range
2979 */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002980 return adjust_ptr_min_max_vals(env, insn,
2981 src_reg, dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002982 }
2983 } else if (ptr_reg) {
2984 /* pointer += scalar */
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002985 return adjust_ptr_min_max_vals(env, insn,
2986 dst_reg, src_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002987 }
2988 } else {
2989 /* Pretend the src is a reg with a known value, since we only
2990 * need to be able to read from this state.
2991 */
2992 off_reg.type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01002993 __mark_reg_known(&off_reg, insn->imm);
Edward Creef1174f72017-08-07 15:26:19 +01002994 src_reg = &off_reg;
Alexei Starovoitov82abbf82017-12-18 20:15:20 -08002995 if (ptr_reg) /* pointer += K */
2996 return adjust_ptr_min_max_vals(env, insn,
2997 ptr_reg, src_reg);
Edward Creef1174f72017-08-07 15:26:19 +01002998 }
2999
3000 /* Got here implies adding two SCALAR_VALUEs */
3001 if (WARN_ON_ONCE(ptr_reg)) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003002 print_verifier_state(env, state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003003 verbose(env, "verifier internal error: unexpected ptr_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01003004 return -EINVAL;
3005 }
3006 if (WARN_ON(!src_reg)) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003007 print_verifier_state(env, state);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003008 verbose(env, "verifier internal error: no src_reg\n");
Edward Creef1174f72017-08-07 15:26:19 +01003009 return -EINVAL;
3010 }
3011 return adjust_scalar_min_max_vals(env, insn, dst_reg, *src_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003012}
3013
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003014/* check validity of 32-bit and 64-bit arithmetic operations */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003015static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003016{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003017 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003018 u8 opcode = BPF_OP(insn->code);
3019 int err;
3020
3021 if (opcode == BPF_END || opcode == BPF_NEG) {
3022 if (opcode == BPF_NEG) {
3023 if (BPF_SRC(insn->code) != 0 ||
3024 insn->src_reg != BPF_REG_0 ||
3025 insn->off != 0 || insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003026 verbose(env, "BPF_NEG uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003027 return -EINVAL;
3028 }
3029 } else {
3030 if (insn->src_reg != BPF_REG_0 || insn->off != 0 ||
Edward Creee67b8a62017-09-15 14:37:38 +01003031 (insn->imm != 16 && insn->imm != 32 && insn->imm != 64) ||
3032 BPF_CLASS(insn->code) == BPF_ALU64) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003033 verbose(env, "BPF_END uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003034 return -EINVAL;
3035 }
3036 }
3037
3038 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003039 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003040 if (err)
3041 return err;
3042
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003043 if (is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003044 verbose(env, "R%d pointer arithmetic prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003045 insn->dst_reg);
3046 return -EACCES;
3047 }
3048
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003049 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01003050 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003051 if (err)
3052 return err;
3053
3054 } else if (opcode == BPF_MOV) {
3055
3056 if (BPF_SRC(insn->code) == BPF_X) {
3057 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003058 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003059 return -EINVAL;
3060 }
3061
3062 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01003063 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003064 if (err)
3065 return err;
3066 } else {
3067 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003068 verbose(env, "BPF_MOV uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003069 return -EINVAL;
3070 }
3071 }
3072
3073 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01003074 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003075 if (err)
3076 return err;
3077
3078 if (BPF_SRC(insn->code) == BPF_X) {
3079 if (BPF_CLASS(insn->code) == BPF_ALU64) {
3080 /* case: R1 = R2
3081 * copy register state to dest reg
3082 */
3083 regs[insn->dst_reg] = regs[insn->src_reg];
Alexei Starovoitov8fe2d6c2017-10-05 16:20:56 -07003084 regs[insn->dst_reg].live |= REG_LIVE_WRITTEN;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003085 } else {
Edward Creef1174f72017-08-07 15:26:19 +01003086 /* R1 = (u32) R2 */
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003087 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003088 verbose(env,
3089 "R%d partial copy of pointer\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003090 insn->src_reg);
3091 return -EACCES;
3092 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003093 mark_reg_unknown(env, regs, insn->dst_reg);
Jann Horn0c17d1d2017-12-18 20:11:55 -08003094 coerce_reg_to_size(&regs[insn->dst_reg], 4);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003095 }
3096 } else {
3097 /* case: R = imm
3098 * remember the value we stored into this reg
3099 */
Edward Creef1174f72017-08-07 15:26:19 +01003100 regs[insn->dst_reg].type = SCALAR_VALUE;
Jann Horn95a762e2017-12-18 20:11:54 -08003101 if (BPF_CLASS(insn->code) == BPF_ALU64) {
3102 __mark_reg_known(regs + insn->dst_reg,
3103 insn->imm);
3104 } else {
3105 __mark_reg_known(regs + insn->dst_reg,
3106 (u32)insn->imm);
3107 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003108 }
3109
3110 } else if (opcode > BPF_END) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003111 verbose(env, "invalid BPF_ALU opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003112 return -EINVAL;
3113
3114 } else { /* all other ALU ops: and, sub, xor, add, ... */
3115
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003116 if (BPF_SRC(insn->code) == BPF_X) {
3117 if (insn->imm != 0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003118 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003119 return -EINVAL;
3120 }
3121 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003122 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003123 if (err)
3124 return err;
3125 } else {
3126 if (insn->src_reg != BPF_REG_0 || insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003127 verbose(env, "BPF_ALU uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003128 return -EINVAL;
3129 }
3130 }
3131
3132 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003133 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003134 if (err)
3135 return err;
3136
3137 if ((opcode == BPF_MOD || opcode == BPF_DIV) &&
3138 BPF_SRC(insn->code) == BPF_K && insn->imm == 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003139 verbose(env, "div by zero\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003140 return -EINVAL;
3141 }
3142
Daniel Borkmann7891a872018-01-10 20:04:37 +01003143 if (opcode == BPF_ARSH && BPF_CLASS(insn->code) != BPF_ALU64) {
3144 verbose(env, "BPF_ARSH not supported for 32 bit ALU\n");
3145 return -EINVAL;
3146 }
3147
Rabin Vincent229394e82016-01-12 20:17:08 +01003148 if ((opcode == BPF_LSH || opcode == BPF_RSH ||
3149 opcode == BPF_ARSH) && BPF_SRC(insn->code) == BPF_K) {
3150 int size = BPF_CLASS(insn->code) == BPF_ALU64 ? 64 : 32;
3151
3152 if (insn->imm < 0 || insn->imm >= size) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003153 verbose(env, "invalid shift %d\n", insn->imm);
Rabin Vincent229394e82016-01-12 20:17:08 +01003154 return -EINVAL;
3155 }
3156 }
3157
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003158 /* check dest operand */
Edward Creedc503a82017-08-15 20:34:35 +01003159 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003160 if (err)
3161 return err;
3162
Edward Creef1174f72017-08-07 15:26:19 +01003163 return adjust_reg_min_max_vals(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003164 }
3165
3166 return 0;
3167}
3168
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003169static void find_good_pkt_pointers(struct bpf_verifier_state *vstate,
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003170 struct bpf_reg_state *dst_reg,
David S. Millerf8ddadc2017-10-22 13:36:53 +01003171 enum bpf_reg_type type,
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003172 bool range_right_open)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003173{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003174 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003175 struct bpf_reg_state *regs = state->regs, *reg;
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003176 u16 new_range;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003177 int i, j;
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003178
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003179 if (dst_reg->off < 0 ||
3180 (dst_reg->off == 0 && range_right_open))
Edward Creef1174f72017-08-07 15:26:19 +01003181 /* This doesn't give us any range */
3182 return;
3183
Edward Creeb03c9f92017-08-07 15:26:36 +01003184 if (dst_reg->umax_value > MAX_PACKET_OFF ||
3185 dst_reg->umax_value + dst_reg->off > MAX_PACKET_OFF)
Edward Creef1174f72017-08-07 15:26:19 +01003186 /* Risk of overflow. For instance, ptr + (1<<63) may be less
3187 * than pkt_end, but that's because it's also less than pkt.
3188 */
3189 return;
3190
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003191 new_range = dst_reg->off;
3192 if (range_right_open)
3193 new_range--;
3194
3195 /* Examples for register markings:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003196 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003197 * pkt_data in dst register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003198 *
3199 * r2 = r3;
3200 * r2 += 8;
3201 * if (r2 > pkt_end) goto <handle exception>
3202 * <access okay>
3203 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003204 * r2 = r3;
3205 * r2 += 8;
3206 * if (r2 < pkt_end) goto <access okay>
3207 * <handle exception>
3208 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003209 * Where:
3210 * r2 == dst_reg, pkt_end == src_reg
3211 * r2=pkt(id=n,off=8,r=0)
3212 * r3=pkt(id=n,off=0,r=0)
3213 *
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003214 * pkt_data in src register:
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003215 *
3216 * r2 = r3;
3217 * r2 += 8;
3218 * if (pkt_end >= r2) goto <access okay>
3219 * <handle exception>
3220 *
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003221 * r2 = r3;
3222 * r2 += 8;
3223 * if (pkt_end <= r2) goto <handle exception>
3224 * <access okay>
3225 *
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003226 * Where:
3227 * pkt_end == dst_reg, r2 == src_reg
3228 * r2=pkt(id=n,off=8,r=0)
3229 * r3=pkt(id=n,off=0,r=0)
3230 *
3231 * Find register r3 and mark its range as r3=pkt(id=n,off=0,r=8)
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003232 * or r3=pkt(id=n,off=0,r=8-1), so that range of bytes [r3, r3 + 8)
3233 * and [r3, r3 + 8-1) respectively is safe to access depending on
3234 * the check.
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003235 */
Daniel Borkmann2d2be8c2016-09-08 01:03:42 +02003236
Edward Creef1174f72017-08-07 15:26:19 +01003237 /* If our ids match, then we must have the same max_value. And we
3238 * don't care about the other reg's fixed offset, since if it's too big
3239 * the range won't allow anything.
3240 * dst_reg->off is known < MAX_PACKET_OFF, therefore it fits in a u16.
3241 */
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003242 for (i = 0; i < MAX_BPF_REG; i++)
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02003243 if (regs[i].type == type && regs[i].id == dst_reg->id)
Alexei Starovoitovb1977682017-03-24 15:57:33 -07003244 /* keep the maximum range already checked */
Daniel Borkmannfb2a3112017-10-21 02:34:21 +02003245 regs[i].range = max(regs[i].range, new_range);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003246
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003247 for (j = 0; j <= vstate->curframe; j++) {
3248 state = vstate->frame[j];
3249 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
3250 if (state->stack[i].slot_type[0] != STACK_SPILL)
3251 continue;
3252 reg = &state->stack[i].spilled_ptr;
3253 if (reg->type == type && reg->id == dst_reg->id)
3254 reg->range = max(reg->range, new_range);
3255 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07003256 }
3257}
3258
Josef Bacik48461132016-09-28 10:54:32 -04003259/* Adjusts the register min/max values in the case that the dst_reg is the
3260 * variable register that we are working on, and src_reg is a constant or we're
3261 * simply doing a BPF_K check.
Edward Creef1174f72017-08-07 15:26:19 +01003262 * In JEQ/JNE cases we also adjust the var_off values.
Josef Bacik48461132016-09-28 10:54:32 -04003263 */
3264static void reg_set_min_max(struct bpf_reg_state *true_reg,
3265 struct bpf_reg_state *false_reg, u64 val,
3266 u8 opcode)
3267{
Edward Creef1174f72017-08-07 15:26:19 +01003268 /* If the dst_reg is a pointer, we can't learn anything about its
3269 * variable offset from the compare (unless src_reg were a pointer into
3270 * the same object, but we don't bother with that.
3271 * Since false_reg and true_reg have the same type by construction, we
3272 * only need to check one of them for pointerness.
3273 */
3274 if (__is_pointer_value(false, false_reg))
3275 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02003276
Josef Bacik48461132016-09-28 10:54:32 -04003277 switch (opcode) {
3278 case BPF_JEQ:
3279 /* If this is false then we know nothing Jon Snow, but if it is
3280 * true then we know for sure.
3281 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003282 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003283 break;
3284 case BPF_JNE:
3285 /* If this is true we know nothing Jon Snow, but if it is false
3286 * we know the value for sure;
3287 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003288 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003289 break;
3290 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003291 false_reg->umax_value = min(false_reg->umax_value, val);
3292 true_reg->umin_value = max(true_reg->umin_value, val + 1);
3293 break;
Josef Bacik48461132016-09-28 10:54:32 -04003294 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003295 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
3296 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04003297 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003298 case BPF_JLT:
3299 false_reg->umin_value = max(false_reg->umin_value, val);
3300 true_reg->umax_value = min(true_reg->umax_value, val - 1);
3301 break;
3302 case BPF_JSLT:
3303 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
3304 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
3305 break;
Josef Bacik48461132016-09-28 10:54:32 -04003306 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003307 false_reg->umax_value = min(false_reg->umax_value, val - 1);
3308 true_reg->umin_value = max(true_reg->umin_value, val);
3309 break;
Josef Bacik48461132016-09-28 10:54:32 -04003310 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003311 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
3312 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04003313 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003314 case BPF_JLE:
3315 false_reg->umin_value = max(false_reg->umin_value, val + 1);
3316 true_reg->umax_value = min(true_reg->umax_value, val);
3317 break;
3318 case BPF_JSLE:
3319 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
3320 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
3321 break;
Josef Bacik48461132016-09-28 10:54:32 -04003322 default:
3323 break;
3324 }
3325
Edward Creeb03c9f92017-08-07 15:26:36 +01003326 __reg_deduce_bounds(false_reg);
3327 __reg_deduce_bounds(true_reg);
3328 /* We might have learned some bits from the bounds. */
3329 __reg_bound_offset(false_reg);
3330 __reg_bound_offset(true_reg);
3331 /* Intersecting with the old var_off might have improved our bounds
3332 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
3333 * then new var_off is (0; 0x7f...fc) which improves our umax.
3334 */
3335 __update_reg_bounds(false_reg);
3336 __update_reg_bounds(true_reg);
Josef Bacik48461132016-09-28 10:54:32 -04003337}
3338
Edward Creef1174f72017-08-07 15:26:19 +01003339/* Same as above, but for the case that dst_reg holds a constant and src_reg is
3340 * the variable reg.
Josef Bacik48461132016-09-28 10:54:32 -04003341 */
3342static void reg_set_min_max_inv(struct bpf_reg_state *true_reg,
3343 struct bpf_reg_state *false_reg, u64 val,
3344 u8 opcode)
3345{
Edward Creef1174f72017-08-07 15:26:19 +01003346 if (__is_pointer_value(false, false_reg))
3347 return;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02003348
Josef Bacik48461132016-09-28 10:54:32 -04003349 switch (opcode) {
3350 case BPF_JEQ:
3351 /* If this is false then we know nothing Jon Snow, but if it is
3352 * true then we know for sure.
3353 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003354 __mark_reg_known(true_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003355 break;
3356 case BPF_JNE:
3357 /* If this is true we know nothing Jon Snow, but if it is false
3358 * we know the value for sure;
3359 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003360 __mark_reg_known(false_reg, val);
Josef Bacik48461132016-09-28 10:54:32 -04003361 break;
3362 case BPF_JGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003363 true_reg->umax_value = min(true_reg->umax_value, val - 1);
3364 false_reg->umin_value = max(false_reg->umin_value, val);
3365 break;
Josef Bacik48461132016-09-28 10:54:32 -04003366 case BPF_JSGT:
Edward Creeb03c9f92017-08-07 15:26:36 +01003367 true_reg->smax_value = min_t(s64, true_reg->smax_value, val - 1);
3368 false_reg->smin_value = max_t(s64, false_reg->smin_value, val);
Josef Bacik48461132016-09-28 10:54:32 -04003369 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003370 case BPF_JLT:
3371 true_reg->umin_value = max(true_reg->umin_value, val + 1);
3372 false_reg->umax_value = min(false_reg->umax_value, val);
3373 break;
3374 case BPF_JSLT:
3375 true_reg->smin_value = max_t(s64, true_reg->smin_value, val + 1);
3376 false_reg->smax_value = min_t(s64, false_reg->smax_value, val);
3377 break;
Josef Bacik48461132016-09-28 10:54:32 -04003378 case BPF_JGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003379 true_reg->umax_value = min(true_reg->umax_value, val);
3380 false_reg->umin_value = max(false_reg->umin_value, val + 1);
3381 break;
Josef Bacik48461132016-09-28 10:54:32 -04003382 case BPF_JSGE:
Edward Creeb03c9f92017-08-07 15:26:36 +01003383 true_reg->smax_value = min_t(s64, true_reg->smax_value, val);
3384 false_reg->smin_value = max_t(s64, false_reg->smin_value, val + 1);
Josef Bacik48461132016-09-28 10:54:32 -04003385 break;
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003386 case BPF_JLE:
3387 true_reg->umin_value = max(true_reg->umin_value, val);
3388 false_reg->umax_value = min(false_reg->umax_value, val - 1);
3389 break;
3390 case BPF_JSLE:
3391 true_reg->smin_value = max_t(s64, true_reg->smin_value, val);
3392 false_reg->smax_value = min_t(s64, false_reg->smax_value, val - 1);
3393 break;
Josef Bacik48461132016-09-28 10:54:32 -04003394 default:
3395 break;
3396 }
3397
Edward Creeb03c9f92017-08-07 15:26:36 +01003398 __reg_deduce_bounds(false_reg);
3399 __reg_deduce_bounds(true_reg);
3400 /* We might have learned some bits from the bounds. */
3401 __reg_bound_offset(false_reg);
3402 __reg_bound_offset(true_reg);
3403 /* Intersecting with the old var_off might have improved our bounds
3404 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
3405 * then new var_off is (0; 0x7f...fc) which improves our umax.
3406 */
3407 __update_reg_bounds(false_reg);
3408 __update_reg_bounds(true_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003409}
3410
3411/* Regs are known to be equal, so intersect their min/max/var_off */
3412static void __reg_combine_min_max(struct bpf_reg_state *src_reg,
3413 struct bpf_reg_state *dst_reg)
3414{
Edward Creeb03c9f92017-08-07 15:26:36 +01003415 src_reg->umin_value = dst_reg->umin_value = max(src_reg->umin_value,
3416 dst_reg->umin_value);
3417 src_reg->umax_value = dst_reg->umax_value = min(src_reg->umax_value,
3418 dst_reg->umax_value);
3419 src_reg->smin_value = dst_reg->smin_value = max(src_reg->smin_value,
3420 dst_reg->smin_value);
3421 src_reg->smax_value = dst_reg->smax_value = min(src_reg->smax_value,
3422 dst_reg->smax_value);
Edward Creef1174f72017-08-07 15:26:19 +01003423 src_reg->var_off = dst_reg->var_off = tnum_intersect(src_reg->var_off,
3424 dst_reg->var_off);
Edward Creeb03c9f92017-08-07 15:26:36 +01003425 /* We might have learned new bounds from the var_off. */
3426 __update_reg_bounds(src_reg);
3427 __update_reg_bounds(dst_reg);
3428 /* We might have learned something about the sign bit. */
3429 __reg_deduce_bounds(src_reg);
3430 __reg_deduce_bounds(dst_reg);
3431 /* We might have learned some bits from the bounds. */
3432 __reg_bound_offset(src_reg);
3433 __reg_bound_offset(dst_reg);
3434 /* Intersecting with the old var_off might have improved our bounds
3435 * slightly. e.g. if umax was 0x7f...f and var_off was (0; 0xf...fc),
3436 * then new var_off is (0; 0x7f...fc) which improves our umax.
3437 */
3438 __update_reg_bounds(src_reg);
3439 __update_reg_bounds(dst_reg);
Edward Creef1174f72017-08-07 15:26:19 +01003440}
3441
3442static void reg_combine_min_max(struct bpf_reg_state *true_src,
3443 struct bpf_reg_state *true_dst,
3444 struct bpf_reg_state *false_src,
3445 struct bpf_reg_state *false_dst,
3446 u8 opcode)
3447{
3448 switch (opcode) {
3449 case BPF_JEQ:
3450 __reg_combine_min_max(true_src, true_dst);
3451 break;
3452 case BPF_JNE:
3453 __reg_combine_min_max(false_src, false_dst);
Edward Creeb03c9f92017-08-07 15:26:36 +01003454 break;
Daniel Borkmann4cabc5b2017-07-21 00:00:21 +02003455 }
Josef Bacik48461132016-09-28 10:54:32 -04003456}
3457
Thomas Graf57a09bf2016-10-18 19:51:19 +02003458static void mark_map_reg(struct bpf_reg_state *regs, u32 regno, u32 id,
Edward Creef1174f72017-08-07 15:26:19 +01003459 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02003460{
3461 struct bpf_reg_state *reg = &regs[regno];
3462
3463 if (reg->type == PTR_TO_MAP_VALUE_OR_NULL && reg->id == id) {
Edward Creef1174f72017-08-07 15:26:19 +01003464 /* Old offset (both fixed and variable parts) should
3465 * have been known-zero, because we don't allow pointer
3466 * arithmetic on pointers that might be NULL.
3467 */
Edward Creeb03c9f92017-08-07 15:26:36 +01003468 if (WARN_ON_ONCE(reg->smin_value || reg->smax_value ||
3469 !tnum_equals_const(reg->var_off, 0) ||
Edward Creef1174f72017-08-07 15:26:19 +01003470 reg->off)) {
Edward Creeb03c9f92017-08-07 15:26:36 +01003471 __mark_reg_known_zero(reg);
3472 reg->off = 0;
Edward Creef1174f72017-08-07 15:26:19 +01003473 }
3474 if (is_null) {
3475 reg->type = SCALAR_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07003476 } else if (reg->map_ptr->inner_map_meta) {
3477 reg->type = CONST_PTR_TO_MAP;
3478 reg->map_ptr = reg->map_ptr->inner_map_meta;
3479 } else {
Edward Creef1174f72017-08-07 15:26:19 +01003480 reg->type = PTR_TO_MAP_VALUE;
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07003481 }
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01003482 /* We don't need id from this point onwards anymore, thus we
3483 * should better reset it, so that state pruning has chances
3484 * to take effect.
3485 */
3486 reg->id = 0;
Thomas Graf57a09bf2016-10-18 19:51:19 +02003487 }
3488}
3489
3490/* The logic is similar to find_good_pkt_pointers(), both could eventually
3491 * be folded together at some point.
3492 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003493static void mark_map_regs(struct bpf_verifier_state *vstate, u32 regno,
Edward Creef1174f72017-08-07 15:26:19 +01003494 bool is_null)
Thomas Graf57a09bf2016-10-18 19:51:19 +02003495{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003496 struct bpf_func_state *state = vstate->frame[vstate->curframe];
Thomas Graf57a09bf2016-10-18 19:51:19 +02003497 struct bpf_reg_state *regs = state->regs;
Daniel Borkmanna08dd0d2016-12-15 01:30:06 +01003498 u32 id = regs[regno].id;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003499 int i, j;
Thomas Graf57a09bf2016-10-18 19:51:19 +02003500
3501 for (i = 0; i < MAX_BPF_REG; i++)
Edward Creef1174f72017-08-07 15:26:19 +01003502 mark_map_reg(regs, i, id, is_null);
Thomas Graf57a09bf2016-10-18 19:51:19 +02003503
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003504 for (j = 0; j <= vstate->curframe; j++) {
3505 state = vstate->frame[j];
3506 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
3507 if (state->stack[i].slot_type[0] != STACK_SPILL)
3508 continue;
3509 mark_map_reg(&state->stack[i].spilled_ptr, 0, id, is_null);
3510 }
Thomas Graf57a09bf2016-10-18 19:51:19 +02003511 }
3512}
3513
Daniel Borkmann5beca082017-11-01 23:58:10 +01003514static bool try_match_pkt_pointers(const struct bpf_insn *insn,
3515 struct bpf_reg_state *dst_reg,
3516 struct bpf_reg_state *src_reg,
3517 struct bpf_verifier_state *this_branch,
3518 struct bpf_verifier_state *other_branch)
3519{
3520 if (BPF_SRC(insn->code) != BPF_X)
3521 return false;
3522
3523 switch (BPF_OP(insn->code)) {
3524 case BPF_JGT:
3525 if ((dst_reg->type == PTR_TO_PACKET &&
3526 src_reg->type == PTR_TO_PACKET_END) ||
3527 (dst_reg->type == PTR_TO_PACKET_META &&
3528 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3529 /* pkt_data' > pkt_end, pkt_meta' > pkt_data */
3530 find_good_pkt_pointers(this_branch, dst_reg,
3531 dst_reg->type, false);
3532 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3533 src_reg->type == PTR_TO_PACKET) ||
3534 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3535 src_reg->type == PTR_TO_PACKET_META)) {
3536 /* pkt_end > pkt_data', pkt_data > pkt_meta' */
3537 find_good_pkt_pointers(other_branch, src_reg,
3538 src_reg->type, true);
3539 } else {
3540 return false;
3541 }
3542 break;
3543 case BPF_JLT:
3544 if ((dst_reg->type == PTR_TO_PACKET &&
3545 src_reg->type == PTR_TO_PACKET_END) ||
3546 (dst_reg->type == PTR_TO_PACKET_META &&
3547 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3548 /* pkt_data' < pkt_end, pkt_meta' < pkt_data */
3549 find_good_pkt_pointers(other_branch, dst_reg,
3550 dst_reg->type, true);
3551 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3552 src_reg->type == PTR_TO_PACKET) ||
3553 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3554 src_reg->type == PTR_TO_PACKET_META)) {
3555 /* pkt_end < pkt_data', pkt_data > pkt_meta' */
3556 find_good_pkt_pointers(this_branch, src_reg,
3557 src_reg->type, false);
3558 } else {
3559 return false;
3560 }
3561 break;
3562 case BPF_JGE:
3563 if ((dst_reg->type == PTR_TO_PACKET &&
3564 src_reg->type == PTR_TO_PACKET_END) ||
3565 (dst_reg->type == PTR_TO_PACKET_META &&
3566 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3567 /* pkt_data' >= pkt_end, pkt_meta' >= pkt_data */
3568 find_good_pkt_pointers(this_branch, dst_reg,
3569 dst_reg->type, true);
3570 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3571 src_reg->type == PTR_TO_PACKET) ||
3572 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3573 src_reg->type == PTR_TO_PACKET_META)) {
3574 /* pkt_end >= pkt_data', pkt_data >= pkt_meta' */
3575 find_good_pkt_pointers(other_branch, src_reg,
3576 src_reg->type, false);
3577 } else {
3578 return false;
3579 }
3580 break;
3581 case BPF_JLE:
3582 if ((dst_reg->type == PTR_TO_PACKET &&
3583 src_reg->type == PTR_TO_PACKET_END) ||
3584 (dst_reg->type == PTR_TO_PACKET_META &&
3585 reg_is_init_pkt_pointer(src_reg, PTR_TO_PACKET))) {
3586 /* pkt_data' <= pkt_end, pkt_meta' <= pkt_data */
3587 find_good_pkt_pointers(other_branch, dst_reg,
3588 dst_reg->type, false);
3589 } else if ((dst_reg->type == PTR_TO_PACKET_END &&
3590 src_reg->type == PTR_TO_PACKET) ||
3591 (reg_is_init_pkt_pointer(dst_reg, PTR_TO_PACKET) &&
3592 src_reg->type == PTR_TO_PACKET_META)) {
3593 /* pkt_end <= pkt_data', pkt_data <= pkt_meta' */
3594 find_good_pkt_pointers(this_branch, src_reg,
3595 src_reg->type, true);
3596 } else {
3597 return false;
3598 }
3599 break;
3600 default:
3601 return false;
3602 }
3603
3604 return true;
3605}
3606
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003607static int check_cond_jmp_op(struct bpf_verifier_env *env,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003608 struct bpf_insn *insn, int *insn_idx)
3609{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003610 struct bpf_verifier_state *this_branch = env->cur_state;
3611 struct bpf_verifier_state *other_branch;
3612 struct bpf_reg_state *regs = this_branch->frame[this_branch->curframe]->regs;
3613 struct bpf_reg_state *dst_reg, *other_branch_regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003614 u8 opcode = BPF_OP(insn->code);
3615 int err;
3616
Daniel Borkmannb4e432f2017-08-10 01:40:02 +02003617 if (opcode > BPF_JSLE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003618 verbose(env, "invalid BPF_JMP opcode %x\n", opcode);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003619 return -EINVAL;
3620 }
3621
3622 if (BPF_SRC(insn->code) == BPF_X) {
3623 if (insn->imm != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003624 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003625 return -EINVAL;
3626 }
3627
3628 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003629 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003630 if (err)
3631 return err;
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003632
3633 if (is_pointer_value(env, insn->src_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003634 verbose(env, "R%d pointer comparison prohibited\n",
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003635 insn->src_reg);
3636 return -EACCES;
3637 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003638 } else {
3639 if (insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003640 verbose(env, "BPF_JMP uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003641 return -EINVAL;
3642 }
3643 }
3644
3645 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01003646 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003647 if (err)
3648 return err;
3649
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003650 dst_reg = &regs[insn->dst_reg];
3651
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003652 /* detect if R == 0 where R was initialized to zero earlier */
3653 if (BPF_SRC(insn->code) == BPF_K &&
3654 (opcode == BPF_JEQ || opcode == BPF_JNE) &&
Edward Creef1174f72017-08-07 15:26:19 +01003655 dst_reg->type == SCALAR_VALUE &&
Alexei Starovoitov3bf15922017-11-30 21:31:39 -08003656 tnum_is_const(dst_reg->var_off)) {
3657 if ((opcode == BPF_JEQ && dst_reg->var_off.value == insn->imm) ||
3658 (opcode == BPF_JNE && dst_reg->var_off.value != insn->imm)) {
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003659 /* if (imm == imm) goto pc+off;
3660 * only follow the goto, ignore fall-through
3661 */
3662 *insn_idx += insn->off;
3663 return 0;
3664 } else {
3665 /* if (imm != imm) goto pc+off;
3666 * only follow fall-through branch, since
3667 * that's where the program will go
3668 */
3669 return 0;
3670 }
3671 }
3672
3673 other_branch = push_stack(env, *insn_idx + insn->off + 1, *insn_idx);
3674 if (!other_branch)
3675 return -EFAULT;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003676 other_branch_regs = other_branch->frame[other_branch->curframe]->regs;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003677
Josef Bacik48461132016-09-28 10:54:32 -04003678 /* detect if we are comparing against a constant value so we can adjust
3679 * our min/max values for our dst register.
Edward Creef1174f72017-08-07 15:26:19 +01003680 * this is only legit if both are scalars (or pointers to the same
3681 * object, I suppose, but we don't support that right now), because
3682 * otherwise the different base pointers mean the offsets aren't
3683 * comparable.
Josef Bacik48461132016-09-28 10:54:32 -04003684 */
3685 if (BPF_SRC(insn->code) == BPF_X) {
Edward Creef1174f72017-08-07 15:26:19 +01003686 if (dst_reg->type == SCALAR_VALUE &&
3687 regs[insn->src_reg].type == SCALAR_VALUE) {
3688 if (tnum_is_const(regs[insn->src_reg].var_off))
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003689 reg_set_min_max(&other_branch_regs[insn->dst_reg],
Edward Creef1174f72017-08-07 15:26:19 +01003690 dst_reg, regs[insn->src_reg].var_off.value,
3691 opcode);
3692 else if (tnum_is_const(dst_reg->var_off))
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003693 reg_set_min_max_inv(&other_branch_regs[insn->src_reg],
Edward Creef1174f72017-08-07 15:26:19 +01003694 &regs[insn->src_reg],
3695 dst_reg->var_off.value, opcode);
3696 else if (opcode == BPF_JEQ || opcode == BPF_JNE)
3697 /* Comparing for equality, we can combine knowledge */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003698 reg_combine_min_max(&other_branch_regs[insn->src_reg],
3699 &other_branch_regs[insn->dst_reg],
Edward Creef1174f72017-08-07 15:26:19 +01003700 &regs[insn->src_reg],
3701 &regs[insn->dst_reg], opcode);
3702 }
3703 } else if (dst_reg->type == SCALAR_VALUE) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003704 reg_set_min_max(&other_branch_regs[insn->dst_reg],
Josef Bacik48461132016-09-28 10:54:32 -04003705 dst_reg, insn->imm, opcode);
3706 }
3707
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003708 /* detect if R == 0 where R is returned from bpf_map_lookup_elem() */
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003709 if (BPF_SRC(insn->code) == BPF_K &&
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07003710 insn->imm == 0 && (opcode == BPF_JEQ || opcode == BPF_JNE) &&
3711 dst_reg->type == PTR_TO_MAP_VALUE_OR_NULL) {
Thomas Graf57a09bf2016-10-18 19:51:19 +02003712 /* Mark all identical map registers in each branch as either
3713 * safe or unknown depending R == 0 or R != 0 conditional.
3714 */
Edward Creef1174f72017-08-07 15:26:19 +01003715 mark_map_regs(this_branch, insn->dst_reg, opcode == BPF_JNE);
3716 mark_map_regs(other_branch, insn->dst_reg, opcode == BPF_JEQ);
Daniel Borkmann5beca082017-11-01 23:58:10 +01003717 } else if (!try_match_pkt_pointers(insn, dst_reg, &regs[insn->src_reg],
3718 this_branch, other_branch) &&
3719 is_pointer_value(env, insn->dst_reg)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003720 verbose(env, "R%d pointer comparison prohibited\n",
3721 insn->dst_reg);
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07003722 return -EACCES;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003723 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003724 if (env->log.level)
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003725 print_verifier_state(env, this_branch->frame[this_branch->curframe]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003726 return 0;
3727}
3728
Alexei Starovoitov0246e642014-09-26 00:17:04 -07003729/* return the map pointer stored inside BPF_LD_IMM64 instruction */
3730static struct bpf_map *ld_imm64_to_map_ptr(struct bpf_insn *insn)
3731{
3732 u64 imm64 = ((u64) (u32) insn[0].imm) | ((u64) (u32) insn[1].imm) << 32;
3733
3734 return (struct bpf_map *) (unsigned long) imm64;
3735}
3736
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003737/* verify BPF_LD_IMM64 instruction */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003738static int check_ld_imm(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003739{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003740 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003741 int err;
3742
3743 if (BPF_SIZE(insn->code) != BPF_DW) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003744 verbose(env, "invalid BPF_LD_IMM insn\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003745 return -EINVAL;
3746 }
3747 if (insn->off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003748 verbose(env, "BPF_LD_IMM64 uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003749 return -EINVAL;
3750 }
3751
Edward Creedc503a82017-08-15 20:34:35 +01003752 err = check_reg_arg(env, insn->dst_reg, DST_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003753 if (err)
3754 return err;
3755
Jakub Kicinski6b173872016-09-21 11:43:59 +01003756 if (insn->src_reg == 0) {
Jakub Kicinski6b173872016-09-21 11:43:59 +01003757 u64 imm = ((u64)(insn + 1)->imm << 32) | (u32)insn->imm;
3758
Edward Creef1174f72017-08-07 15:26:19 +01003759 regs[insn->dst_reg].type = SCALAR_VALUE;
Edward Creeb03c9f92017-08-07 15:26:36 +01003760 __mark_reg_known(&regs[insn->dst_reg], imm);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003761 return 0;
Jakub Kicinski6b173872016-09-21 11:43:59 +01003762 }
Alexei Starovoitov17a52672014-09-26 00:17:06 -07003763
3764 /* replace_map_fd_with_map_ptr() should have caught bad ld_imm64 */
3765 BUG_ON(insn->src_reg != BPF_PSEUDO_MAP_FD);
3766
3767 regs[insn->dst_reg].type = CONST_PTR_TO_MAP;
3768 regs[insn->dst_reg].map_ptr = ld_imm64_to_map_ptr(insn);
3769 return 0;
3770}
3771
Daniel Borkmann96be4322015-03-01 12:31:46 +01003772static bool may_access_skb(enum bpf_prog_type type)
3773{
3774 switch (type) {
3775 case BPF_PROG_TYPE_SOCKET_FILTER:
3776 case BPF_PROG_TYPE_SCHED_CLS:
Daniel Borkmann94caee8c2015-03-20 15:11:11 +01003777 case BPF_PROG_TYPE_SCHED_ACT:
Daniel Borkmann96be4322015-03-01 12:31:46 +01003778 return true;
3779 default:
3780 return false;
3781 }
3782}
3783
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003784/* verify safety of LD_ABS|LD_IND instructions:
3785 * - they can only appear in the programs where ctx == skb
3786 * - since they are wrappers of function calls, they scratch R1-R5 registers,
3787 * preserve R6-R9, and store return value into R0
3788 *
3789 * Implicit input:
3790 * ctx == skb == R6 == CTX
3791 *
3792 * Explicit input:
3793 * SRC == any register
3794 * IMM == 32-bit immediate
3795 *
3796 * Output:
3797 * R0 - 8/16/32-bit skb data converted to cpu endianness
3798 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003799static int check_ld_abs(struct bpf_verifier_env *env, struct bpf_insn *insn)
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003800{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003801 struct bpf_reg_state *regs = cur_regs(env);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003802 u8 mode = BPF_MODE(insn->code);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003803 int i, err;
3804
Daniel Borkmann24701ec2015-03-01 12:31:47 +01003805 if (!may_access_skb(env->prog->type)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003806 verbose(env, "BPF_LD_[ABS|IND] instructions not allowed for this program type\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003807 return -EINVAL;
3808 }
3809
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08003810 if (env->subprog_cnt) {
3811 /* when program has LD_ABS insn JITs and interpreter assume
3812 * that r1 == ctx == skb which is not the case for callees
3813 * that can have arbitrary arguments. It's problematic
3814 * for main prog as well since JITs would need to analyze
3815 * all functions in order to make proper register save/restore
3816 * decisions in the main prog. Hence disallow LD_ABS with calls
3817 */
3818 verbose(env, "BPF_LD_[ABS|IND] instructions cannot be mixed with bpf-to-bpf calls\n");
3819 return -EINVAL;
3820 }
3821
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003822 if (insn->dst_reg != BPF_REG_0 || insn->off != 0 ||
Alexei Starovoitovd82bccc2016-04-12 10:26:19 -07003823 BPF_SIZE(insn->code) == BPF_DW ||
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003824 (mode == BPF_ABS && insn->src_reg != BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003825 verbose(env, "BPF_LD_[ABS|IND] uses reserved fields\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003826 return -EINVAL;
3827 }
3828
3829 /* check whether implicit source operand (register R6) is readable */
Edward Creedc503a82017-08-15 20:34:35 +01003830 err = check_reg_arg(env, BPF_REG_6, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003831 if (err)
3832 return err;
3833
3834 if (regs[BPF_REG_6].type != PTR_TO_CTX) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003835 verbose(env,
3836 "at the time of BPF_LD_ABS|IND R6 != pointer to skb\n");
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003837 return -EINVAL;
3838 }
3839
3840 if (mode == BPF_IND) {
3841 /* check explicit source operand */
Edward Creedc503a82017-08-15 20:34:35 +01003842 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003843 if (err)
3844 return err;
3845 }
3846
3847 /* reset caller saved regs to unreadable */
Edward Creedc503a82017-08-15 20:34:35 +01003848 for (i = 0; i < CALLER_SAVED_REGS; i++) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003849 mark_reg_not_init(env, regs, caller_saved[i]);
Edward Creedc503a82017-08-15 20:34:35 +01003850 check_reg_arg(env, caller_saved[i], DST_OP_NO_MARK);
3851 }
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003852
3853 /* mark destination R0 register as readable, since it contains
Edward Creedc503a82017-08-15 20:34:35 +01003854 * the value fetched from the packet.
3855 * Already marked as written above.
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003856 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003857 mark_reg_unknown(env, regs, BPF_REG_0);
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08003858 return 0;
3859}
3860
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003861static int check_return_code(struct bpf_verifier_env *env)
3862{
3863 struct bpf_reg_state *reg;
3864 struct tnum range = tnum_range(0, 1);
3865
3866 switch (env->prog->type) {
3867 case BPF_PROG_TYPE_CGROUP_SKB:
3868 case BPF_PROG_TYPE_CGROUP_SOCK:
3869 case BPF_PROG_TYPE_SOCK_OPS:
Roman Gushchinebc614f2017-11-05 08:15:32 -05003870 case BPF_PROG_TYPE_CGROUP_DEVICE:
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003871 break;
3872 default:
3873 return 0;
3874 }
3875
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07003876 reg = cur_regs(env) + BPF_REG_0;
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003877 if (reg->type != SCALAR_VALUE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003878 verbose(env, "At program exit the register R0 is not a known value (%s)\n",
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003879 reg_type_str[reg->type]);
3880 return -EINVAL;
3881 }
3882
3883 if (!tnum_in(range, reg->var_off)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003884 verbose(env, "At program exit the register R0 ");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003885 if (!tnum_is_unknown(reg->var_off)) {
3886 char tn_buf[48];
3887
3888 tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003889 verbose(env, "has value %s", tn_buf);
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003890 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003891 verbose(env, "has unknown scalar value");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003892 }
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003893 verbose(env, " should have been 0 or 1\n");
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07003894 return -EINVAL;
3895 }
3896 return 0;
3897}
3898
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003899/* non-recursive DFS pseudo code
3900 * 1 procedure DFS-iterative(G,v):
3901 * 2 label v as discovered
3902 * 3 let S be a stack
3903 * 4 S.push(v)
3904 * 5 while S is not empty
3905 * 6 t <- S.pop()
3906 * 7 if t is what we're looking for:
3907 * 8 return t
3908 * 9 for all edges e in G.adjacentEdges(t) do
3909 * 10 if edge e is already labelled
3910 * 11 continue with the next edge
3911 * 12 w <- G.adjacentVertex(t,e)
3912 * 13 if vertex w is not discovered and not explored
3913 * 14 label e as tree-edge
3914 * 15 label w as discovered
3915 * 16 S.push(w)
3916 * 17 continue at 5
3917 * 18 else if vertex w is discovered
3918 * 19 label e as back-edge
3919 * 20 else
3920 * 21 // vertex w is explored
3921 * 22 label e as forward- or cross-edge
3922 * 23 label t as explored
3923 * 24 S.pop()
3924 *
3925 * convention:
3926 * 0x10 - discovered
3927 * 0x11 - discovered and fall-through edge labelled
3928 * 0x12 - discovered and fall-through and branch edges labelled
3929 * 0x20 - explored
3930 */
3931
3932enum {
3933 DISCOVERED = 0x10,
3934 EXPLORED = 0x20,
3935 FALLTHROUGH = 1,
3936 BRANCH = 2,
3937};
3938
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003939#define STATE_LIST_MARK ((struct bpf_verifier_state_list *) -1L)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003940
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003941static int *insn_stack; /* stack of insns to process */
3942static int cur_stack; /* current stack index */
3943static int *insn_state;
3944
3945/* t, w, e - match pseudo-code above:
3946 * t - index of current instruction
3947 * w - next instruction
3948 * e - edge
3949 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003950static int push_insn(int t, int w, int e, struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003951{
3952 if (e == FALLTHROUGH && insn_state[t] >= (DISCOVERED | FALLTHROUGH))
3953 return 0;
3954
3955 if (e == BRANCH && insn_state[t] >= (DISCOVERED | BRANCH))
3956 return 0;
3957
3958 if (w < 0 || w >= env->prog->len) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003959 verbose(env, "jump out of range from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003960 return -EINVAL;
3961 }
3962
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07003963 if (e == BRANCH)
3964 /* mark branch target for state pruning */
3965 env->explored_states[w] = STATE_LIST_MARK;
3966
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003967 if (insn_state[w] == 0) {
3968 /* tree-edge */
3969 insn_state[t] = DISCOVERED | e;
3970 insn_state[w] = DISCOVERED;
3971 if (cur_stack >= env->prog->len)
3972 return -E2BIG;
3973 insn_stack[cur_stack++] = w;
3974 return 1;
3975 } else if ((insn_state[w] & 0xF0) == DISCOVERED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003976 verbose(env, "back-edge from insn %d to %d\n", t, w);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003977 return -EINVAL;
3978 } else if (insn_state[w] == EXPLORED) {
3979 /* forward- or cross-edge */
3980 insn_state[t] = DISCOVERED | e;
3981 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07003982 verbose(env, "insn state internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003983 return -EFAULT;
3984 }
3985 return 0;
3986}
3987
3988/* non-recursive depth-first-search to detect loops in BPF program
3989 * loop == back-edge in directed graph
3990 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01003991static int check_cfg(struct bpf_verifier_env *env)
Alexei Starovoitov475fb782014-09-26 00:17:05 -07003992{
3993 struct bpf_insn *insns = env->prog->insnsi;
3994 int insn_cnt = env->prog->len;
3995 int ret = 0;
3996 int i, t;
3997
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08003998 ret = check_subprogs(env);
3999 if (ret < 0)
4000 return ret;
4001
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004002 insn_state = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
4003 if (!insn_state)
4004 return -ENOMEM;
4005
4006 insn_stack = kcalloc(insn_cnt, sizeof(int), GFP_KERNEL);
4007 if (!insn_stack) {
4008 kfree(insn_state);
4009 return -ENOMEM;
4010 }
4011
4012 insn_state[0] = DISCOVERED; /* mark 1st insn as discovered */
4013 insn_stack[0] = 0; /* 0 is the first instruction */
4014 cur_stack = 1;
4015
4016peek_stack:
4017 if (cur_stack == 0)
4018 goto check_state;
4019 t = insn_stack[cur_stack - 1];
4020
4021 if (BPF_CLASS(insns[t].code) == BPF_JMP) {
4022 u8 opcode = BPF_OP(insns[t].code);
4023
4024 if (opcode == BPF_EXIT) {
4025 goto mark_explored;
4026 } else if (opcode == BPF_CALL) {
4027 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4028 if (ret == 1)
4029 goto peek_stack;
4030 else if (ret < 0)
4031 goto err_free;
Daniel Borkmann07016152016-04-05 22:33:17 +02004032 if (t + 1 < insn_cnt)
4033 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08004034 if (insns[t].src_reg == BPF_PSEUDO_CALL) {
4035 env->explored_states[t] = STATE_LIST_MARK;
4036 ret = push_insn(t, t + insns[t].imm + 1, BRANCH, env);
4037 if (ret == 1)
4038 goto peek_stack;
4039 else if (ret < 0)
4040 goto err_free;
4041 }
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004042 } else if (opcode == BPF_JA) {
4043 if (BPF_SRC(insns[t].code) != BPF_K) {
4044 ret = -EINVAL;
4045 goto err_free;
4046 }
4047 /* unconditional jump with single edge */
4048 ret = push_insn(t, t + insns[t].off + 1,
4049 FALLTHROUGH, env);
4050 if (ret == 1)
4051 goto peek_stack;
4052 else if (ret < 0)
4053 goto err_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004054 /* tell verifier to check for equivalent states
4055 * after every call and jump
4056 */
Alexei Starovoitovc3de6312015-04-14 15:57:13 -07004057 if (t + 1 < insn_cnt)
4058 env->explored_states[t + 1] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004059 } else {
4060 /* conditional jump with two edges */
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02004061 env->explored_states[t] = STATE_LIST_MARK;
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004062 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4063 if (ret == 1)
4064 goto peek_stack;
4065 else if (ret < 0)
4066 goto err_free;
4067
4068 ret = push_insn(t, t + insns[t].off + 1, BRANCH, env);
4069 if (ret == 1)
4070 goto peek_stack;
4071 else if (ret < 0)
4072 goto err_free;
4073 }
4074 } else {
4075 /* all other non-branch instructions with single
4076 * fall-through edge
4077 */
4078 ret = push_insn(t, t + 1, FALLTHROUGH, env);
4079 if (ret == 1)
4080 goto peek_stack;
4081 else if (ret < 0)
4082 goto err_free;
4083 }
4084
4085mark_explored:
4086 insn_state[t] = EXPLORED;
4087 if (cur_stack-- <= 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004088 verbose(env, "pop stack internal bug\n");
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004089 ret = -EFAULT;
4090 goto err_free;
4091 }
4092 goto peek_stack;
4093
4094check_state:
4095 for (i = 0; i < insn_cnt; i++) {
4096 if (insn_state[i] != EXPLORED) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004097 verbose(env, "unreachable insn %d\n", i);
Alexei Starovoitov475fb782014-09-26 00:17:05 -07004098 ret = -EINVAL;
4099 goto err_free;
4100 }
4101 }
4102 ret = 0; /* cfg looks good */
4103
4104err_free:
4105 kfree(insn_state);
4106 kfree(insn_stack);
4107 return ret;
4108}
4109
Edward Creef1174f72017-08-07 15:26:19 +01004110/* check %cur's range satisfies %old's */
4111static bool range_within(struct bpf_reg_state *old,
4112 struct bpf_reg_state *cur)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004113{
Edward Creeb03c9f92017-08-07 15:26:36 +01004114 return old->umin_value <= cur->umin_value &&
4115 old->umax_value >= cur->umax_value &&
4116 old->smin_value <= cur->smin_value &&
4117 old->smax_value >= cur->smax_value;
Edward Creef1174f72017-08-07 15:26:19 +01004118}
4119
4120/* Maximum number of register states that can exist at once */
4121#define ID_MAP_SIZE (MAX_BPF_REG + MAX_BPF_STACK / BPF_REG_SIZE)
4122struct idpair {
4123 u32 old;
4124 u32 cur;
4125};
4126
4127/* If in the old state two registers had the same id, then they need to have
4128 * the same id in the new state as well. But that id could be different from
4129 * the old state, so we need to track the mapping from old to new ids.
4130 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent
4131 * regs with old id 5 must also have new id 9 for the new state to be safe. But
4132 * regs with a different old id could still have new id 9, we don't care about
4133 * that.
4134 * So we look through our idmap to see if this old id has been seen before. If
4135 * so, we require the new id to match; otherwise, we add the id pair to the map.
4136 */
4137static bool check_ids(u32 old_id, u32 cur_id, struct idpair *idmap)
4138{
4139 unsigned int i;
4140
4141 for (i = 0; i < ID_MAP_SIZE; i++) {
4142 if (!idmap[i].old) {
4143 /* Reached an empty slot; haven't seen this id before */
4144 idmap[i].old = old_id;
4145 idmap[i].cur = cur_id;
4146 return true;
4147 }
4148 if (idmap[i].old == old_id)
4149 return idmap[i].cur == cur_id;
4150 }
4151 /* We ran out of idmap slots, which should be impossible */
4152 WARN_ON_ONCE(1);
4153 return false;
4154}
4155
4156/* Returns true if (rold safe implies rcur safe) */
Edward Cree1b688a12017-08-23 15:10:50 +01004157static bool regsafe(struct bpf_reg_state *rold, struct bpf_reg_state *rcur,
4158 struct idpair *idmap)
Edward Creef1174f72017-08-07 15:26:19 +01004159{
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004160 bool equal;
4161
Edward Creedc503a82017-08-15 20:34:35 +01004162 if (!(rold->live & REG_LIVE_READ))
4163 /* explored state didn't use this */
4164 return true;
4165
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004166 equal = memcmp(rold, rcur, offsetof(struct bpf_reg_state, frameno)) == 0;
4167
4168 if (rold->type == PTR_TO_STACK)
4169 /* two stack pointers are equal only if they're pointing to
4170 * the same stack frame, since fp-8 in foo != fp-8 in bar
4171 */
4172 return equal && rold->frameno == rcur->frameno;
4173
4174 if (equal)
Edward Creef1174f72017-08-07 15:26:19 +01004175 return true;
4176
4177 if (rold->type == NOT_INIT)
4178 /* explored state can't have used this */
4179 return true;
4180 if (rcur->type == NOT_INIT)
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004181 return false;
Edward Creef1174f72017-08-07 15:26:19 +01004182 switch (rold->type) {
4183 case SCALAR_VALUE:
4184 if (rcur->type == SCALAR_VALUE) {
4185 /* new val must satisfy old val knowledge */
4186 return range_within(rold, rcur) &&
4187 tnum_in(rold->var_off, rcur->var_off);
4188 } else {
Jann Horn179d1c52017-12-18 20:11:59 -08004189 /* We're trying to use a pointer in place of a scalar.
4190 * Even if the scalar was unbounded, this could lead to
4191 * pointer leaks because scalars are allowed to leak
4192 * while pointers are not. We could make this safe in
4193 * special cases if root is calling us, but it's
4194 * probably not worth the hassle.
Edward Creef1174f72017-08-07 15:26:19 +01004195 */
Jann Horn179d1c52017-12-18 20:11:59 -08004196 return false;
Edward Creef1174f72017-08-07 15:26:19 +01004197 }
4198 case PTR_TO_MAP_VALUE:
Edward Cree1b688a12017-08-23 15:10:50 +01004199 /* If the new min/max/var_off satisfy the old ones and
4200 * everything else matches, we are OK.
4201 * We don't care about the 'id' value, because nothing
4202 * uses it for PTR_TO_MAP_VALUE (only for ..._OR_NULL)
4203 */
4204 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 &&
4205 range_within(rold, rcur) &&
4206 tnum_in(rold->var_off, rcur->var_off);
Edward Creef1174f72017-08-07 15:26:19 +01004207 case PTR_TO_MAP_VALUE_OR_NULL:
4208 /* a PTR_TO_MAP_VALUE could be safe to use as a
4209 * PTR_TO_MAP_VALUE_OR_NULL into the same map.
4210 * However, if the old PTR_TO_MAP_VALUE_OR_NULL then got NULL-
4211 * checked, doing so could have affected others with the same
4212 * id, and we can't check for that because we lost the id when
4213 * we converted to a PTR_TO_MAP_VALUE.
4214 */
4215 if (rcur->type != PTR_TO_MAP_VALUE_OR_NULL)
4216 return false;
4217 if (memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)))
4218 return false;
4219 /* Check our ids match any regs they're supposed to */
4220 return check_ids(rold->id, rcur->id, idmap);
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02004221 case PTR_TO_PACKET_META:
Edward Creef1174f72017-08-07 15:26:19 +01004222 case PTR_TO_PACKET:
Daniel Borkmannde8f3a82017-09-25 02:25:51 +02004223 if (rcur->type != rold->type)
Edward Creef1174f72017-08-07 15:26:19 +01004224 return false;
4225 /* We must have at least as much range as the old ptr
4226 * did, so that any accesses which were safe before are
4227 * still safe. This is true even if old range < old off,
4228 * since someone could have accessed through (ptr - k), or
4229 * even done ptr -= k in a register, to get a safe access.
4230 */
4231 if (rold->range > rcur->range)
4232 return false;
4233 /* If the offsets don't match, we can't trust our alignment;
4234 * nor can we be sure that we won't fall out of range.
4235 */
4236 if (rold->off != rcur->off)
4237 return false;
4238 /* id relations must be preserved */
4239 if (rold->id && !check_ids(rold->id, rcur->id, idmap))
4240 return false;
4241 /* new val must satisfy old val knowledge */
4242 return range_within(rold, rcur) &&
4243 tnum_in(rold->var_off, rcur->var_off);
4244 case PTR_TO_CTX:
4245 case CONST_PTR_TO_MAP:
Edward Creef1174f72017-08-07 15:26:19 +01004246 case PTR_TO_PACKET_END:
4247 /* Only valid matches are exact, which memcmp() above
4248 * would have accepted
4249 */
4250 default:
4251 /* Don't know what's going on, just say it's not safe */
4252 return false;
4253 }
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004254
Edward Creef1174f72017-08-07 15:26:19 +01004255 /* Shouldn't get here; if we do, say it's not safe */
4256 WARN_ON_ONCE(1);
Alexei Starovoitov969bf052016-05-05 19:49:10 -07004257 return false;
4258}
4259
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004260static bool stacksafe(struct bpf_func_state *old,
4261 struct bpf_func_state *cur,
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004262 struct idpair *idmap)
4263{
4264 int i, spi;
4265
4266 /* if explored stack has more populated slots than current stack
4267 * such stacks are not equivalent
4268 */
4269 if (old->allocated_stack > cur->allocated_stack)
4270 return false;
4271
4272 /* walk slots of the explored stack and ignore any additional
4273 * slots in the current stack, since explored(safe) state
4274 * didn't use them
4275 */
4276 for (i = 0; i < old->allocated_stack; i++) {
4277 spi = i / BPF_REG_SIZE;
4278
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004279 if (!(old->stack[spi].spilled_ptr.live & REG_LIVE_READ))
4280 /* explored state didn't use this */
Gianluca Borellofd05e572017-12-23 10:09:55 +00004281 continue;
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004282
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004283 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_INVALID)
4284 continue;
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004285 /* if old state was safe with misc data in the stack
4286 * it will be safe with zero-initialized stack.
4287 * The opposite is not true
4288 */
4289 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_MISC &&
4290 cur->stack[spi].slot_type[i % BPF_REG_SIZE] == STACK_ZERO)
4291 continue;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004292 if (old->stack[spi].slot_type[i % BPF_REG_SIZE] !=
4293 cur->stack[spi].slot_type[i % BPF_REG_SIZE])
4294 /* Ex: old explored (safe) state has STACK_SPILL in
4295 * this stack slot, but current has has STACK_MISC ->
4296 * this verifier states are not equivalent,
4297 * return false to continue verification of this path
4298 */
4299 return false;
4300 if (i % BPF_REG_SIZE)
4301 continue;
4302 if (old->stack[spi].slot_type[0] != STACK_SPILL)
4303 continue;
4304 if (!regsafe(&old->stack[spi].spilled_ptr,
4305 &cur->stack[spi].spilled_ptr,
4306 idmap))
4307 /* when explored and current stack slot are both storing
4308 * spilled registers, check that stored pointers types
4309 * are the same as well.
4310 * Ex: explored safe path could have stored
4311 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8}
4312 * but current path has stored:
4313 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16}
4314 * such verifier states are not equivalent.
4315 * return false to continue verification of this path
4316 */
4317 return false;
4318 }
4319 return true;
4320}
4321
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004322/* compare two verifier states
4323 *
4324 * all states stored in state_list are known to be valid, since
4325 * verifier reached 'bpf_exit' instruction through them
4326 *
4327 * this function is called when verifier exploring different branches of
4328 * execution popped from the state stack. If it sees an old state that has
4329 * more strict register state and more strict stack state then this execution
4330 * branch doesn't need to be explored further, since verifier already
4331 * concluded that more strict state leads to valid finish.
4332 *
4333 * Therefore two states are equivalent if register state is more conservative
4334 * and explored stack state is more conservative than the current one.
4335 * Example:
4336 * explored current
4337 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC)
4338 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC)
4339 *
4340 * In other words if current stack state (one being explored) has more
4341 * valid slots than old one that already passed validation, it means
4342 * the verifier can stop exploring and conclude that current state is valid too
4343 *
4344 * Similarly with registers. If explored state has register type as invalid
4345 * whereas register type in current state is meaningful, it means that
4346 * the current state will reach 'bpf_exit' instruction safely
4347 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004348static bool func_states_equal(struct bpf_func_state *old,
4349 struct bpf_func_state *cur)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004350{
Edward Creef1174f72017-08-07 15:26:19 +01004351 struct idpair *idmap;
4352 bool ret = false;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004353 int i;
4354
Edward Creef1174f72017-08-07 15:26:19 +01004355 idmap = kcalloc(ID_MAP_SIZE, sizeof(struct idpair), GFP_KERNEL);
4356 /* If we failed to allocate the idmap, just say it's not safe */
4357 if (!idmap)
Alexei Starovoitov1a0dc1a2016-05-05 19:49:09 -07004358 return false;
Edward Creef1174f72017-08-07 15:26:19 +01004359
4360 for (i = 0; i < MAX_BPF_REG; i++) {
Edward Cree1b688a12017-08-23 15:10:50 +01004361 if (!regsafe(&old->regs[i], &cur->regs[i], idmap))
Edward Creef1174f72017-08-07 15:26:19 +01004362 goto out_free;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004363 }
4364
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004365 if (!stacksafe(old, cur, idmap))
4366 goto out_free;
Edward Creef1174f72017-08-07 15:26:19 +01004367 ret = true;
4368out_free:
4369 kfree(idmap);
4370 return ret;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004371}
4372
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004373static bool states_equal(struct bpf_verifier_env *env,
4374 struct bpf_verifier_state *old,
4375 struct bpf_verifier_state *cur)
Edward Creedc503a82017-08-15 20:34:35 +01004376{
Edward Creedc503a82017-08-15 20:34:35 +01004377 int i;
4378
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004379 if (old->curframe != cur->curframe)
4380 return false;
4381
4382 /* for states to be equal callsites have to be the same
4383 * and all frame states need to be equivalent
4384 */
4385 for (i = 0; i <= old->curframe; i++) {
4386 if (old->frame[i]->callsite != cur->frame[i]->callsite)
4387 return false;
4388 if (!func_states_equal(old->frame[i], cur->frame[i]))
4389 return false;
4390 }
4391 return true;
4392}
4393
4394/* A write screens off any subsequent reads; but write marks come from the
4395 * straight-line code between a state and its parent. When we arrive at an
4396 * equivalent state (jump target or such) we didn't arrive by the straight-line
4397 * code, so read marks in the state must propagate to the parent regardless
4398 * of the state's write marks. That's what 'parent == state->parent' comparison
4399 * in mark_reg_read() and mark_stack_slot_read() is for.
4400 */
4401static int propagate_liveness(struct bpf_verifier_env *env,
4402 const struct bpf_verifier_state *vstate,
4403 struct bpf_verifier_state *vparent)
4404{
4405 int i, frame, err = 0;
4406 struct bpf_func_state *state, *parent;
4407
4408 if (vparent->curframe != vstate->curframe) {
4409 WARN(1, "propagate_live: parent frame %d current frame %d\n",
4410 vparent->curframe, vstate->curframe);
4411 return -EFAULT;
4412 }
Edward Creedc503a82017-08-15 20:34:35 +01004413 /* Propagate read liveness of registers... */
4414 BUILD_BUG_ON(BPF_REG_FP + 1 != MAX_BPF_REG);
4415 /* We don't need to worry about FP liveness because it's read-only */
4416 for (i = 0; i < BPF_REG_FP; i++) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004417 if (vparent->frame[vparent->curframe]->regs[i].live & REG_LIVE_READ)
Edward Creedc503a82017-08-15 20:34:35 +01004418 continue;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004419 if (vstate->frame[vstate->curframe]->regs[i].live & REG_LIVE_READ) {
4420 err = mark_reg_read(env, vstate, vparent, i);
4421 if (err)
4422 return err;
Edward Creedc503a82017-08-15 20:34:35 +01004423 }
4424 }
Edward Creedc503a82017-08-15 20:34:35 +01004425
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004426 /* ... and stack slots */
4427 for (frame = 0; frame <= vstate->curframe; frame++) {
4428 state = vstate->frame[frame];
4429 parent = vparent->frame[frame];
4430 for (i = 0; i < state->allocated_stack / BPF_REG_SIZE &&
4431 i < parent->allocated_stack / BPF_REG_SIZE; i++) {
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004432 if (parent->stack[i].spilled_ptr.live & REG_LIVE_READ)
4433 continue;
4434 if (state->stack[i].spilled_ptr.live & REG_LIVE_READ)
4435 mark_stack_slot_read(env, vstate, vparent, i, frame);
4436 }
Edward Creedc503a82017-08-15 20:34:35 +01004437 }
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004438 return err;
Edward Creedc503a82017-08-15 20:34:35 +01004439}
4440
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004441static int is_state_visited(struct bpf_verifier_env *env, int insn_idx)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004442{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004443 struct bpf_verifier_state_list *new_sl;
4444 struct bpf_verifier_state_list *sl;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004445 struct bpf_verifier_state *cur = env->cur_state;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004446 int i, j, err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004447
4448 sl = env->explored_states[insn_idx];
4449 if (!sl)
4450 /* this 'insn_idx' instruction wasn't marked, so we will not
4451 * be doing state search here
4452 */
4453 return 0;
4454
4455 while (sl != STATE_LIST_MARK) {
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004456 if (states_equal(env, &sl->state, cur)) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004457 /* reached equivalent register/stack state,
Edward Creedc503a82017-08-15 20:34:35 +01004458 * prune the search.
4459 * Registers read by the continuation are read by us.
Edward Cree8e9cd9c2017-08-23 15:11:21 +01004460 * If we have any write marks in env->cur_state, they
4461 * will prevent corresponding reads in the continuation
4462 * from reaching our parent (an explored_state). Our
4463 * own state will get the read marks recorded, but
4464 * they'll be immediately forgotten as we're pruning
4465 * this state and will pop a new one.
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004466 */
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004467 err = propagate_liveness(env, &sl->state, cur);
4468 if (err)
4469 return err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004470 return 1;
Edward Creedc503a82017-08-15 20:34:35 +01004471 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004472 sl = sl->next;
4473 }
4474
4475 /* there were no equivalent states, remember current one.
4476 * technically the current state is not proven to be safe yet,
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004477 * but it will either reach outer most bpf_exit (which means it's safe)
4478 * or it will be rejected. Since there are no loops, we won't be
4479 * seeing this tuple (frame[0].callsite, frame[1].callsite, .. insn_idx)
4480 * again on the way to bpf_exit
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004481 */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004482 new_sl = kzalloc(sizeof(struct bpf_verifier_state_list), GFP_KERNEL);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004483 if (!new_sl)
4484 return -ENOMEM;
4485
4486 /* add new state to the head of linked list */
Alexei Starovoitov1969db42017-11-01 00:08:04 -07004487 err = copy_verifier_state(&new_sl->state, cur);
4488 if (err) {
4489 free_verifier_state(&new_sl->state, false);
4490 kfree(new_sl);
4491 return err;
4492 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004493 new_sl->next = env->explored_states[insn_idx];
4494 env->explored_states[insn_idx] = new_sl;
Edward Creedc503a82017-08-15 20:34:35 +01004495 /* connect new state to parentage chain */
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004496 cur->parent = &new_sl->state;
Edward Cree8e9cd9c2017-08-23 15:11:21 +01004497 /* clear write marks in current state: the writes we did are not writes
4498 * our child did, so they don't screen off its reads from us.
4499 * (There are no read marks in current state, because reads always mark
4500 * their parent and current state never has children yet. Only
4501 * explored_states can get read marks.)
4502 */
Edward Creedc503a82017-08-15 20:34:35 +01004503 for (i = 0; i < BPF_REG_FP; i++)
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004504 cur->frame[cur->curframe]->regs[i].live = REG_LIVE_NONE;
4505
4506 /* all stack frames are accessible from callee, clear them all */
4507 for (j = 0; j <= cur->curframe; j++) {
4508 struct bpf_func_state *frame = cur->frame[j];
4509
4510 for (i = 0; i < frame->allocated_stack / BPF_REG_SIZE; i++)
Alexei Starovoitovcc2b14d2017-12-14 17:55:08 -08004511 frame->stack[i].spilled_ptr.live = REG_LIVE_NONE;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004512 }
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004513 return 0;
4514}
4515
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004516static int do_check(struct bpf_verifier_env *env)
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004517{
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004518 struct bpf_verifier_state *state;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004519 struct bpf_insn *insns = env->prog->insnsi;
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004520 struct bpf_reg_state *regs;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004521 int insn_cnt = env->prog->len, i;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004522 int insn_idx, prev_insn_idx = 0;
4523 int insn_processed = 0;
4524 bool do_print_state = false;
4525
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004526 state = kzalloc(sizeof(struct bpf_verifier_state), GFP_KERNEL);
4527 if (!state)
4528 return -ENOMEM;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004529 state->curframe = 0;
Edward Creedc503a82017-08-15 20:34:35 +01004530 state->parent = NULL;
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004531 state->frame[0] = kzalloc(sizeof(struct bpf_func_state), GFP_KERNEL);
4532 if (!state->frame[0]) {
4533 kfree(state);
4534 return -ENOMEM;
4535 }
4536 env->cur_state = state;
4537 init_func_state(env, state->frame[0],
4538 BPF_MAIN_FUNC /* callsite */,
4539 0 /* frameno */,
4540 0 /* subprogno, zero == main subprog */);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004541 insn_idx = 0;
4542 for (;;) {
4543 struct bpf_insn *insn;
4544 u8 class;
4545 int err;
4546
4547 if (insn_idx >= insn_cnt) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004548 verbose(env, "invalid insn idx %d insn_cnt %d\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004549 insn_idx, insn_cnt);
4550 return -EFAULT;
4551 }
4552
4553 insn = &insns[insn_idx];
4554 class = BPF_CLASS(insn->code);
4555
Daniel Borkmann07016152016-04-05 22:33:17 +02004556 if (++insn_processed > BPF_COMPLEXITY_LIMIT_INSNS) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004557 verbose(env,
4558 "BPF program is too large. Processed %d insn\n",
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004559 insn_processed);
4560 return -E2BIG;
4561 }
4562
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004563 err = is_state_visited(env, insn_idx);
4564 if (err < 0)
4565 return err;
4566 if (err == 1) {
4567 /* found equivalent state, can prune the search */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004568 if (env->log.level) {
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004569 if (do_print_state)
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004570 verbose(env, "\nfrom %d to %d: safe\n",
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004571 prev_insn_idx, insn_idx);
4572 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004573 verbose(env, "%d: safe\n", insn_idx);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004574 }
4575 goto process_bpf_exit;
4576 }
4577
Daniel Borkmann3c2ce602017-05-18 03:00:06 +02004578 if (need_resched())
4579 cond_resched();
4580
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004581 if (env->log.level > 1 || (env->log.level && do_print_state)) {
4582 if (env->log.level > 1)
4583 verbose(env, "%d:", insn_idx);
David S. Millerc5fc9692017-05-10 11:25:17 -07004584 else
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004585 verbose(env, "\nfrom %d to %d:",
David S. Millerc5fc9692017-05-10 11:25:17 -07004586 prev_insn_idx, insn_idx);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004587 print_verifier_state(env, state->frame[state->curframe]);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004588 do_print_state = false;
4589 }
4590
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004591 if (env->log.level) {
Daniel Borkmann7105e822017-12-20 13:42:57 +01004592 const struct bpf_insn_cbs cbs = {
4593 .cb_print = verbose,
4594 };
4595
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004596 verbose(env, "%d: ", insn_idx);
Daniel Borkmann7105e822017-12-20 13:42:57 +01004597 print_bpf_insn(&cbs, env, insn, env->allow_ptr_leaks);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004598 }
4599
Jakub Kicinskicae19272017-12-27 18:39:05 -08004600 if (bpf_prog_is_dev_bound(env->prog->aux)) {
4601 err = bpf_prog_offload_verify_insn(env, insn_idx,
4602 prev_insn_idx);
4603 if (err)
4604 return err;
4605 }
Jakub Kicinski13a27df2016-09-21 11:43:58 +01004606
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004607 regs = cur_regs(env);
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004608 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004609 if (class == BPF_ALU || class == BPF_ALU64) {
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004610 err = check_alu_op(env, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004611 if (err)
4612 return err;
4613
4614 } else if (class == BPF_LDX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004615 enum bpf_reg_type *prev_src_type, src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004616
4617 /* check for reserved fields is already done */
4618
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004619 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01004620 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004621 if (err)
4622 return err;
4623
Edward Creedc503a82017-08-15 20:34:35 +01004624 err = check_reg_arg(env, insn->dst_reg, DST_OP_NO_MARK);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004625 if (err)
4626 return err;
4627
Alexei Starovoitov725f9dc2015-04-15 16:19:33 -07004628 src_reg_type = regs[insn->src_reg].type;
4629
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004630 /* check that memory (src_reg + off) is readable,
4631 * the state of dst_reg will be updated by this func
4632 */
Yonghong Song31fd8582017-06-13 15:52:13 -07004633 err = check_mem_access(env, insn_idx, insn->src_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004634 BPF_SIZE(insn->code), BPF_READ,
4635 insn->dst_reg);
4636 if (err)
4637 return err;
4638
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004639 prev_src_type = &env->insn_aux_data[insn_idx].ptr_type;
4640
4641 if (*prev_src_type == NOT_INIT) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004642 /* saw a valid insn
4643 * dst_reg = *(u32 *)(src_reg + off)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004644 * save type to validate intersecting paths
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004645 */
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004646 *prev_src_type = src_reg_type;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004647
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004648 } else if (src_reg_type != *prev_src_type &&
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004649 (src_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004650 *prev_src_type == PTR_TO_CTX)) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004651 /* ABuser program is trying to use the same insn
4652 * dst_reg = *(u32*) (src_reg + off)
4653 * with different pointer types:
4654 * src_reg == ctx in one branch and
4655 * src_reg == stack|map in some other branch.
4656 * Reject it.
4657 */
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004658 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004659 return -EINVAL;
4660 }
4661
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004662 } else if (class == BPF_STX) {
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004663 enum bpf_reg_type *prev_dst_type, dst_reg_type;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004664
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004665 if (BPF_MODE(insn->code) == BPF_XADD) {
Yonghong Song31fd8582017-06-13 15:52:13 -07004666 err = check_xadd(env, insn_idx, insn);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004667 if (err)
4668 return err;
4669 insn_idx++;
4670 continue;
4671 }
4672
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004673 /* check src1 operand */
Edward Creedc503a82017-08-15 20:34:35 +01004674 err = check_reg_arg(env, insn->src_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004675 if (err)
4676 return err;
4677 /* check src2 operand */
Edward Creedc503a82017-08-15 20:34:35 +01004678 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004679 if (err)
4680 return err;
4681
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004682 dst_reg_type = regs[insn->dst_reg].type;
4683
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004684 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07004685 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004686 BPF_SIZE(insn->code), BPF_WRITE,
4687 insn->src_reg);
4688 if (err)
4689 return err;
4690
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004691 prev_dst_type = &env->insn_aux_data[insn_idx].ptr_type;
4692
4693 if (*prev_dst_type == NOT_INIT) {
4694 *prev_dst_type = dst_reg_type;
4695 } else if (dst_reg_type != *prev_dst_type &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004696 (dst_reg_type == PTR_TO_CTX ||
Jakub Kicinski3df126f2016-09-21 11:43:56 +01004697 *prev_dst_type == PTR_TO_CTX)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004698 verbose(env, "same insn cannot be used with different pointers\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004699 return -EINVAL;
4700 }
4701
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004702 } else if (class == BPF_ST) {
4703 if (BPF_MODE(insn->code) != BPF_MEM ||
4704 insn->src_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004705 verbose(env, "BPF_ST uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004706 return -EINVAL;
4707 }
4708 /* check src operand */
Edward Creedc503a82017-08-15 20:34:35 +01004709 err = check_reg_arg(env, insn->dst_reg, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004710 if (err)
4711 return err;
4712
Daniel Borkmannf37a8cb2018-01-16 23:30:10 +01004713 if (is_ctx_reg(env, insn->dst_reg)) {
4714 verbose(env, "BPF_ST stores into R%d context is not allowed\n",
4715 insn->dst_reg);
4716 return -EACCES;
4717 }
4718
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004719 /* check that memory (dst_reg + off) is writeable */
Yonghong Song31fd8582017-06-13 15:52:13 -07004720 err = check_mem_access(env, insn_idx, insn->dst_reg, insn->off,
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004721 BPF_SIZE(insn->code), BPF_WRITE,
4722 -1);
4723 if (err)
4724 return err;
4725
4726 } else if (class == BPF_JMP) {
4727 u8 opcode = BPF_OP(insn->code);
4728
4729 if (opcode == BPF_CALL) {
4730 if (BPF_SRC(insn->code) != BPF_K ||
4731 insn->off != 0 ||
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004732 (insn->src_reg != BPF_REG_0 &&
4733 insn->src_reg != BPF_PSEUDO_CALL) ||
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004734 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004735 verbose(env, "BPF_CALL uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004736 return -EINVAL;
4737 }
4738
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004739 if (insn->src_reg == BPF_PSEUDO_CALL)
4740 err = check_func_call(env, insn, &insn_idx);
4741 else
4742 err = check_helper_call(env, insn->imm, insn_idx);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004743 if (err)
4744 return err;
4745
4746 } else if (opcode == BPF_JA) {
4747 if (BPF_SRC(insn->code) != BPF_K ||
4748 insn->imm != 0 ||
4749 insn->src_reg != BPF_REG_0 ||
4750 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004751 verbose(env, "BPF_JA uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004752 return -EINVAL;
4753 }
4754
4755 insn_idx += insn->off + 1;
4756 continue;
4757
4758 } else if (opcode == BPF_EXIT) {
4759 if (BPF_SRC(insn->code) != BPF_K ||
4760 insn->imm != 0 ||
4761 insn->src_reg != BPF_REG_0 ||
4762 insn->dst_reg != BPF_REG_0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004763 verbose(env, "BPF_EXIT uses reserved fields\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004764 return -EINVAL;
4765 }
4766
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004767 if (state->curframe) {
4768 /* exit from nested function */
4769 prev_insn_idx = insn_idx;
4770 err = prepare_func_exit(env, &insn_idx);
4771 if (err)
4772 return err;
4773 do_print_state = true;
4774 continue;
4775 }
4776
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004777 /* eBPF calling convetion is such that R0 is used
4778 * to return the value from eBPF program.
4779 * Make sure that it's readable at this time
4780 * of bpf_exit, which means that program wrote
4781 * something into it earlier
4782 */
Edward Creedc503a82017-08-15 20:34:35 +01004783 err = check_reg_arg(env, BPF_REG_0, SRC_OP);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004784 if (err)
4785 return err;
4786
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004787 if (is_pointer_value(env, BPF_REG_0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004788 verbose(env, "R0 leaks addr as return value\n");
Alexei Starovoitov1be7f752015-10-07 22:23:21 -07004789 return -EACCES;
4790 }
4791
Alexei Starovoitov390ee7e2017-10-02 22:50:23 -07004792 err = check_return_code(env);
4793 if (err)
4794 return err;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07004795process_bpf_exit:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07004796 err = pop_stack(env, &prev_insn_idx, &insn_idx);
4797 if (err < 0) {
4798 if (err != -ENOENT)
4799 return err;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004800 break;
4801 } else {
4802 do_print_state = true;
4803 continue;
4804 }
4805 } else {
4806 err = check_cond_jmp_op(env, insn, &insn_idx);
4807 if (err)
4808 return err;
4809 }
4810 } else if (class == BPF_LD) {
4811 u8 mode = BPF_MODE(insn->code);
4812
4813 if (mode == BPF_ABS || mode == BPF_IND) {
Alexei Starovoitovddd872b2014-12-01 15:06:34 -08004814 err = check_ld_abs(env, insn);
4815 if (err)
4816 return err;
4817
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004818 } else if (mode == BPF_IMM) {
4819 err = check_ld_imm(env, insn);
4820 if (err)
4821 return err;
4822
4823 insn_idx++;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08004824 env->insn_aux_data[insn_idx].seen = true;
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004825 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004826 verbose(env, "invalid BPF_LD mode\n");
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004827 return -EINVAL;
4828 }
4829 } else {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004830 verbose(env, "unknown insn class %d\n", class);
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004831 return -EINVAL;
4832 }
4833
4834 insn_idx++;
4835 }
4836
Daniel Borkmann4bd95f42018-01-20 01:24:36 +01004837 verbose(env, "processed %d insns (limit %d), stack depth ",
4838 insn_processed, BPF_COMPLEXITY_LIMIT_INSNS);
Alexei Starovoitovf4d7e402017-12-14 17:55:06 -08004839 for (i = 0; i < env->subprog_cnt + 1; i++) {
4840 u32 depth = env->subprog_stack_depth[i];
4841
4842 verbose(env, "%d", depth);
4843 if (i + 1 < env->subprog_cnt + 1)
4844 verbose(env, "+");
4845 }
4846 verbose(env, "\n");
4847 env->prog->aux->stack_depth = env->subprog_stack_depth[0];
Alexei Starovoitov17a52672014-09-26 00:17:06 -07004848 return 0;
4849}
4850
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004851static int check_map_prealloc(struct bpf_map *map)
4852{
4853 return (map->map_type != BPF_MAP_TYPE_HASH &&
Martin KaFai Laubcc6b1b2017-03-22 10:00:34 -07004854 map->map_type != BPF_MAP_TYPE_PERCPU_HASH &&
4855 map->map_type != BPF_MAP_TYPE_HASH_OF_MAPS) ||
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004856 !(map->map_flags & BPF_F_NO_PREALLOC);
4857}
4858
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004859static int check_map_prog_compatibility(struct bpf_verifier_env *env,
4860 struct bpf_map *map,
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004861 struct bpf_prog *prog)
4862
4863{
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004864 /* Make sure that BPF_PROG_TYPE_PERF_EVENT programs only use
4865 * preallocated hash maps, since doing memory allocation
4866 * in overflow_handler can crash depending on where nmi got
4867 * triggered.
4868 */
4869 if (prog->type == BPF_PROG_TYPE_PERF_EVENT) {
4870 if (!check_map_prealloc(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004871 verbose(env, "perf_event programs can only use preallocated hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004872 return -EINVAL;
4873 }
4874 if (map->inner_map_meta &&
4875 !check_map_prealloc(map->inner_map_meta)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004876 verbose(env, "perf_event programs can only use preallocated inner hash map\n");
Martin KaFai Lau56f668d2017-03-22 10:00:33 -07004877 return -EINVAL;
4878 }
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004879 }
Jakub Kicinskia3884572018-01-11 20:29:09 -08004880
4881 if ((bpf_prog_is_dev_bound(prog->aux) || bpf_map_is_dev_bound(map)) &&
4882 !bpf_offload_dev_match(prog, map)) {
4883 verbose(env, "offload device mismatch between prog and map\n");
4884 return -EINVAL;
4885 }
4886
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004887 return 0;
4888}
4889
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004890/* look for pseudo eBPF instructions that access map FDs and
4891 * replace them with actual map pointers
4892 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004893static int replace_map_fd_with_map_ptr(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004894{
4895 struct bpf_insn *insn = env->prog->insnsi;
4896 int insn_cnt = env->prog->len;
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004897 int i, j, err;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004898
Daniel Borkmannf1f77142017-01-13 23:38:15 +01004899 err = bpf_prog_calc_tag(env->prog);
Daniel Borkmannaafe6ae2016-12-18 01:52:57 +01004900 if (err)
4901 return err;
4902
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004903 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004904 if (BPF_CLASS(insn->code) == BPF_LDX &&
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004905 (BPF_MODE(insn->code) != BPF_MEM || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004906 verbose(env, "BPF_LDX uses reserved fields\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07004907 return -EINVAL;
4908 }
4909
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004910 if (BPF_CLASS(insn->code) == BPF_STX &&
4911 ((BPF_MODE(insn->code) != BPF_MEM &&
4912 BPF_MODE(insn->code) != BPF_XADD) || insn->imm != 0)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004913 verbose(env, "BPF_STX uses reserved fields\n");
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07004914 return -EINVAL;
4915 }
4916
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004917 if (insn[0].code == (BPF_LD | BPF_IMM | BPF_DW)) {
4918 struct bpf_map *map;
4919 struct fd f;
4920
4921 if (i == insn_cnt - 1 || insn[1].code != 0 ||
4922 insn[1].dst_reg != 0 || insn[1].src_reg != 0 ||
4923 insn[1].off != 0) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004924 verbose(env, "invalid bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004925 return -EINVAL;
4926 }
4927
4928 if (insn->src_reg == 0)
4929 /* valid generic load 64-bit imm */
4930 goto next_insn;
4931
4932 if (insn->src_reg != BPF_PSEUDO_MAP_FD) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004933 verbose(env,
4934 "unrecognized bpf_ld_imm64 insn\n");
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004935 return -EINVAL;
4936 }
4937
4938 f = fdget(insn->imm);
Daniel Borkmannc2101292015-10-29 14:58:07 +01004939 map = __bpf_map_get(f);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004940 if (IS_ERR(map)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004941 verbose(env, "fd %d is not pointing to valid bpf_map\n",
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004942 insn->imm);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004943 return PTR_ERR(map);
4944 }
4945
Jakub Kicinski61bd5212017-10-09 10:30:11 -07004946 err = check_map_prog_compatibility(env, map, env->prog);
Alexei Starovoitovfdc15d32016-09-01 18:37:23 -07004947 if (err) {
4948 fdput(f);
4949 return err;
4950 }
4951
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004952 /* store map pointer inside BPF_LD_IMM64 instruction */
4953 insn[0].imm = (u32) (unsigned long) map;
4954 insn[1].imm = ((u64) (unsigned long) map) >> 32;
4955
4956 /* check whether we recorded this map already */
4957 for (j = 0; j < env->used_map_cnt; j++)
4958 if (env->used_maps[j] == map) {
4959 fdput(f);
4960 goto next_insn;
4961 }
4962
4963 if (env->used_map_cnt >= MAX_USED_MAPS) {
4964 fdput(f);
4965 return -E2BIG;
4966 }
4967
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004968 /* hold the map. If the program is rejected by verifier,
4969 * the map will be released by release_maps() or it
4970 * will be used by the valid program until it's unloaded
4971 * and all maps are released in free_bpf_prog_info()
4972 */
Alexei Starovoitov92117d82016-04-27 18:56:20 -07004973 map = bpf_map_inc(map, false);
4974 if (IS_ERR(map)) {
4975 fdput(f);
4976 return PTR_ERR(map);
4977 }
4978 env->used_maps[env->used_map_cnt++] = map;
4979
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004980 fdput(f);
4981next_insn:
4982 insn++;
4983 i++;
4984 }
4985 }
4986
4987 /* now all pseudo BPF_LD_IMM64 instructions load valid
4988 * 'struct bpf_map *' into a register instead of user map_fd.
4989 * These pointers will be used later by verifier to validate map access.
4990 */
4991 return 0;
4992}
4993
4994/* drop refcnt of maps used by the rejected program */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01004995static void release_maps(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07004996{
4997 int i;
4998
4999 for (i = 0; i < env->used_map_cnt; i++)
5000 bpf_map_put(env->used_maps[i]);
5001}
5002
5003/* convert pseudo BPF_LD_IMM64 into generic BPF_LD_IMM64 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005004static void convert_pseudo_ld_imm64(struct bpf_verifier_env *env)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005005{
5006 struct bpf_insn *insn = env->prog->insnsi;
5007 int insn_cnt = env->prog->len;
5008 int i;
5009
5010 for (i = 0; i < insn_cnt; i++, insn++)
5011 if (insn->code == (BPF_LD | BPF_IMM | BPF_DW))
5012 insn->src_reg = 0;
5013}
5014
Alexei Starovoitov80419022017-03-15 18:26:41 -07005015/* single env->prog->insni[off] instruction was replaced with the range
5016 * insni[off, off + cnt). Adjust corresponding insn_aux_data by copying
5017 * [0, off) and [off, end) to new locations, so the patched range stays zero
5018 */
5019static int adjust_insn_aux_data(struct bpf_verifier_env *env, u32 prog_len,
5020 u32 off, u32 cnt)
5021{
5022 struct bpf_insn_aux_data *new_data, *old_data = env->insn_aux_data;
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005023 int i;
Alexei Starovoitov80419022017-03-15 18:26:41 -07005024
5025 if (cnt == 1)
5026 return 0;
5027 new_data = vzalloc(sizeof(struct bpf_insn_aux_data) * prog_len);
5028 if (!new_data)
5029 return -ENOMEM;
5030 memcpy(new_data, old_data, sizeof(struct bpf_insn_aux_data) * off);
5031 memcpy(new_data + off + cnt - 1, old_data + off,
5032 sizeof(struct bpf_insn_aux_data) * (prog_len - off - cnt + 1));
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005033 for (i = off; i < off + cnt - 1; i++)
5034 new_data[i].seen = true;
Alexei Starovoitov80419022017-03-15 18:26:41 -07005035 env->insn_aux_data = new_data;
5036 vfree(old_data);
5037 return 0;
5038}
5039
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005040static void adjust_subprog_starts(struct bpf_verifier_env *env, u32 off, u32 len)
5041{
5042 int i;
5043
5044 if (len == 1)
5045 return;
5046 for (i = 0; i < env->subprog_cnt; i++) {
5047 if (env->subprog_starts[i] < off)
5048 continue;
5049 env->subprog_starts[i] += len - 1;
5050 }
5051}
5052
Alexei Starovoitov80419022017-03-15 18:26:41 -07005053static struct bpf_prog *bpf_patch_insn_data(struct bpf_verifier_env *env, u32 off,
5054 const struct bpf_insn *patch, u32 len)
5055{
5056 struct bpf_prog *new_prog;
5057
5058 new_prog = bpf_patch_insn_single(env->prog, off, patch, len);
5059 if (!new_prog)
5060 return NULL;
5061 if (adjust_insn_aux_data(env, new_prog->len, off, len))
5062 return NULL;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005063 adjust_subprog_starts(env, off, len);
Alexei Starovoitov80419022017-03-15 18:26:41 -07005064 return new_prog;
5065}
5066
Daniel Borkmann2a5418a2018-01-26 23:33:37 +01005067/* The verifier does more data flow analysis than llvm and will not
5068 * explore branches that are dead at run time. Malicious programs can
5069 * have dead code too. Therefore replace all dead at-run-time code
5070 * with 'ja -1'.
5071 *
5072 * Just nops are not optimal, e.g. if they would sit at the end of the
5073 * program and through another bug we would manage to jump there, then
5074 * we'd execute beyond program memory otherwise. Returning exception
5075 * code also wouldn't work since we can have subprogs where the dead
5076 * code could be located.
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005077 */
5078static void sanitize_dead_code(struct bpf_verifier_env *env)
5079{
5080 struct bpf_insn_aux_data *aux_data = env->insn_aux_data;
Daniel Borkmann2a5418a2018-01-26 23:33:37 +01005081 struct bpf_insn trap = BPF_JMP_IMM(BPF_JA, 0, 0, -1);
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005082 struct bpf_insn *insn = env->prog->insnsi;
5083 const int insn_cnt = env->prog->len;
5084 int i;
5085
5086 for (i = 0; i < insn_cnt; i++) {
5087 if (aux_data[i].seen)
5088 continue;
Daniel Borkmann2a5418a2018-01-26 23:33:37 +01005089 memcpy(insn + i, &trap, sizeof(trap));
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005090 }
5091}
5092
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005093/* convert load instructions that access fields of 'struct __sk_buff'
5094 * into sequence of instructions that access fields of 'struct sk_buff'
5095 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005096static int convert_ctx_accesses(struct bpf_verifier_env *env)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005097{
Jakub Kicinski00176a32017-10-16 16:40:54 -07005098 const struct bpf_verifier_ops *ops = env->ops;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005099 int i, cnt, size, ctx_field_size, delta = 0;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005100 const int insn_cnt = env->prog->len;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005101 struct bpf_insn insn_buf[16], *insn;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005102 struct bpf_prog *new_prog;
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005103 enum bpf_access_type type;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005104 bool is_narrower_load;
5105 u32 target_size;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005106
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005107 if (ops->gen_prologue) {
5108 cnt = ops->gen_prologue(insn_buf, env->seen_direct_write,
5109 env->prog);
5110 if (cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005111 verbose(env, "bpf verifier is misconfigured\n");
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005112 return -EINVAL;
5113 } else if (cnt) {
Alexei Starovoitov80419022017-03-15 18:26:41 -07005114 new_prog = bpf_patch_insn_data(env, 0, insn_buf, cnt);
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005115 if (!new_prog)
5116 return -ENOMEM;
Alexei Starovoitov80419022017-03-15 18:26:41 -07005117
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005118 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005119 delta += cnt - 1;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005120 }
5121 }
5122
5123 if (!ops->convert_ctx_access)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005124 return 0;
5125
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005126 insn = env->prog->insnsi + delta;
Daniel Borkmann36bbef52016-09-20 00:26:13 +02005127
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005128 for (i = 0; i < insn_cnt; i++, insn++) {
Daniel Borkmann62c79892017-01-12 11:51:33 +01005129 if (insn->code == (BPF_LDX | BPF_MEM | BPF_B) ||
5130 insn->code == (BPF_LDX | BPF_MEM | BPF_H) ||
5131 insn->code == (BPF_LDX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07005132 insn->code == (BPF_LDX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005133 type = BPF_READ;
Daniel Borkmann62c79892017-01-12 11:51:33 +01005134 else if (insn->code == (BPF_STX | BPF_MEM | BPF_B) ||
5135 insn->code == (BPF_STX | BPF_MEM | BPF_H) ||
5136 insn->code == (BPF_STX | BPF_MEM | BPF_W) ||
Alexei Starovoitovea2e7ce2016-09-01 18:37:21 -07005137 insn->code == (BPF_STX | BPF_MEM | BPF_DW))
Alexei Starovoitovd691f9e2015-06-04 10:11:54 -07005138 type = BPF_WRITE;
5139 else
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005140 continue;
5141
Alexei Starovoitov80419022017-03-15 18:26:41 -07005142 if (env->insn_aux_data[i + delta].ptr_type != PTR_TO_CTX)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005143 continue;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005144
Yonghong Song31fd8582017-06-13 15:52:13 -07005145 ctx_field_size = env->insn_aux_data[i + delta].ctx_field_size;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005146 size = BPF_LDST_BYTES(insn);
Yonghong Song31fd8582017-06-13 15:52:13 -07005147
5148 /* If the read access is a narrower load of the field,
5149 * convert to a 4/8-byte load, to minimum program type specific
5150 * convert_ctx_access changes. If conversion is successful,
5151 * we will apply proper mask to the result.
5152 */
Daniel Borkmannf96da092017-07-02 02:13:27 +02005153 is_narrower_load = size < ctx_field_size;
Yonghong Song31fd8582017-06-13 15:52:13 -07005154 if (is_narrower_load) {
Daniel Borkmannf96da092017-07-02 02:13:27 +02005155 u32 off = insn->off;
5156 u8 size_code;
Yonghong Song31fd8582017-06-13 15:52:13 -07005157
Daniel Borkmannf96da092017-07-02 02:13:27 +02005158 if (type == BPF_WRITE) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005159 verbose(env, "bpf verifier narrow ctx access misconfigured\n");
Daniel Borkmannf96da092017-07-02 02:13:27 +02005160 return -EINVAL;
5161 }
5162
5163 size_code = BPF_H;
Yonghong Song31fd8582017-06-13 15:52:13 -07005164 if (ctx_field_size == 4)
5165 size_code = BPF_W;
5166 else if (ctx_field_size == 8)
5167 size_code = BPF_DW;
Daniel Borkmannf96da092017-07-02 02:13:27 +02005168
Yonghong Song31fd8582017-06-13 15:52:13 -07005169 insn->off = off & ~(ctx_field_size - 1);
5170 insn->code = BPF_LDX | BPF_MEM | size_code;
5171 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02005172
5173 target_size = 0;
5174 cnt = ops->convert_ctx_access(type, insn, insn_buf, env->prog,
5175 &target_size);
5176 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf) ||
5177 (ctx_field_size && !target_size)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005178 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005179 return -EINVAL;
5180 }
Daniel Borkmannf96da092017-07-02 02:13:27 +02005181
5182 if (is_narrower_load && size < target_size) {
Yonghong Song31fd8582017-06-13 15:52:13 -07005183 if (ctx_field_size <= 4)
5184 insn_buf[cnt++] = BPF_ALU32_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02005185 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07005186 else
5187 insn_buf[cnt++] = BPF_ALU64_IMM(BPF_AND, insn->dst_reg,
Daniel Borkmannf96da092017-07-02 02:13:27 +02005188 (1 << size * 8) - 1);
Yonghong Song31fd8582017-06-13 15:52:13 -07005189 }
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005190
Alexei Starovoitov80419022017-03-15 18:26:41 -07005191 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005192 if (!new_prog)
5193 return -ENOMEM;
5194
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005195 delta += cnt - 1;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005196
5197 /* keep walking new program and skip insns we just inserted */
5198 env->prog = new_prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005199 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005200 }
5201
5202 return 0;
5203}
5204
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005205static int jit_subprogs(struct bpf_verifier_env *env)
5206{
5207 struct bpf_prog *prog = env->prog, **func, *tmp;
5208 int i, j, subprog_start, subprog_end = 0, len, subprog;
Daniel Borkmann7105e822017-12-20 13:42:57 +01005209 struct bpf_insn *insn;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005210 void *old_bpf_func;
5211 int err = -ENOMEM;
5212
5213 if (env->subprog_cnt == 0)
5214 return 0;
5215
Daniel Borkmann7105e822017-12-20 13:42:57 +01005216 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005217 if (insn->code != (BPF_JMP | BPF_CALL) ||
5218 insn->src_reg != BPF_PSEUDO_CALL)
5219 continue;
5220 subprog = find_subprog(env, i + insn->imm + 1);
5221 if (subprog < 0) {
5222 WARN_ONCE(1, "verifier bug. No program starts at insn %d\n",
5223 i + insn->imm + 1);
5224 return -EFAULT;
5225 }
5226 /* temporarily remember subprog id inside insn instead of
5227 * aux_data, since next loop will split up all insns into funcs
5228 */
5229 insn->off = subprog + 1;
5230 /* remember original imm in case JIT fails and fallback
5231 * to interpreter will be needed
5232 */
5233 env->insn_aux_data[i].call_imm = insn->imm;
5234 /* point imm to __bpf_call_base+1 from JITs point of view */
5235 insn->imm = 1;
5236 }
5237
5238 func = kzalloc(sizeof(prog) * (env->subprog_cnt + 1), GFP_KERNEL);
5239 if (!func)
5240 return -ENOMEM;
5241
5242 for (i = 0; i <= env->subprog_cnt; i++) {
5243 subprog_start = subprog_end;
5244 if (env->subprog_cnt == i)
5245 subprog_end = prog->len;
5246 else
5247 subprog_end = env->subprog_starts[i];
5248
5249 len = subprog_end - subprog_start;
5250 func[i] = bpf_prog_alloc(bpf_prog_size(len), GFP_USER);
5251 if (!func[i])
5252 goto out_free;
5253 memcpy(func[i]->insnsi, &prog->insnsi[subprog_start],
5254 len * sizeof(struct bpf_insn));
Daniel Borkmann4f74d802017-12-20 13:42:56 +01005255 func[i]->type = prog->type;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005256 func[i]->len = len;
Daniel Borkmann4f74d802017-12-20 13:42:56 +01005257 if (bpf_prog_calc_tag(func[i]))
5258 goto out_free;
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005259 func[i]->is_func = 1;
5260 /* Use bpf_prog_F_tag to indicate functions in stack traces.
5261 * Long term would need debug info to populate names
5262 */
5263 func[i]->aux->name[0] = 'F';
5264 func[i]->aux->stack_depth = env->subprog_stack_depth[i];
5265 func[i]->jit_requested = 1;
5266 func[i] = bpf_int_jit_compile(func[i]);
5267 if (!func[i]->jited) {
5268 err = -ENOTSUPP;
5269 goto out_free;
5270 }
5271 cond_resched();
5272 }
5273 /* at this point all bpf functions were successfully JITed
5274 * now populate all bpf_calls with correct addresses and
5275 * run last pass of JIT
5276 */
5277 for (i = 0; i <= env->subprog_cnt; i++) {
5278 insn = func[i]->insnsi;
5279 for (j = 0; j < func[i]->len; j++, insn++) {
5280 if (insn->code != (BPF_JMP | BPF_CALL) ||
5281 insn->src_reg != BPF_PSEUDO_CALL)
5282 continue;
5283 subprog = insn->off;
5284 insn->off = 0;
5285 insn->imm = (u64 (*)(u64, u64, u64, u64, u64))
5286 func[subprog]->bpf_func -
5287 __bpf_call_base;
5288 }
5289 }
5290 for (i = 0; i <= env->subprog_cnt; i++) {
5291 old_bpf_func = func[i]->bpf_func;
5292 tmp = bpf_int_jit_compile(func[i]);
5293 if (tmp != func[i] || func[i]->bpf_func != old_bpf_func) {
5294 verbose(env, "JIT doesn't support bpf-to-bpf calls\n");
5295 err = -EFAULT;
5296 goto out_free;
5297 }
5298 cond_resched();
5299 }
5300
5301 /* finally lock prog and jit images for all functions and
5302 * populate kallsysm
5303 */
5304 for (i = 0; i <= env->subprog_cnt; i++) {
5305 bpf_prog_lock_ro(func[i]);
5306 bpf_prog_kallsyms_add(func[i]);
5307 }
Daniel Borkmann7105e822017-12-20 13:42:57 +01005308
5309 /* Last step: make now unused interpreter insns from main
5310 * prog consistent for later dump requests, so they can
5311 * later look the same as if they were interpreted only.
5312 */
5313 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
5314 unsigned long addr;
5315
5316 if (insn->code != (BPF_JMP | BPF_CALL) ||
5317 insn->src_reg != BPF_PSEUDO_CALL)
5318 continue;
5319 insn->off = env->insn_aux_data[i].call_imm;
5320 subprog = find_subprog(env, i + insn->off + 1);
5321 addr = (unsigned long)func[subprog + 1]->bpf_func;
5322 addr &= PAGE_MASK;
5323 insn->imm = (u64 (*)(u64, u64, u64, u64, u64))
5324 addr - __bpf_call_base;
5325 }
5326
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005327 prog->jited = 1;
5328 prog->bpf_func = func[0]->bpf_func;
5329 prog->aux->func = func;
5330 prog->aux->func_cnt = env->subprog_cnt + 1;
5331 return 0;
5332out_free:
5333 for (i = 0; i <= env->subprog_cnt; i++)
5334 if (func[i])
5335 bpf_jit_free(func[i]);
5336 kfree(func);
5337 /* cleanup main prog to be interpreted */
5338 prog->jit_requested = 0;
5339 for (i = 0, insn = prog->insnsi; i < prog->len; i++, insn++) {
5340 if (insn->code != (BPF_JMP | BPF_CALL) ||
5341 insn->src_reg != BPF_PSEUDO_CALL)
5342 continue;
5343 insn->off = 0;
5344 insn->imm = env->insn_aux_data[i].call_imm;
5345 }
5346 return err;
5347}
5348
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005349static int fixup_call_args(struct bpf_verifier_env *env)
5350{
David S. Miller19d28fb2018-01-11 21:27:54 -05005351#ifndef CONFIG_BPF_JIT_ALWAYS_ON
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005352 struct bpf_prog *prog = env->prog;
5353 struct bpf_insn *insn = prog->insnsi;
5354 int i, depth;
David S. Miller19d28fb2018-01-11 21:27:54 -05005355#endif
5356 int err;
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005357
David S. Miller19d28fb2018-01-11 21:27:54 -05005358 err = 0;
5359 if (env->prog->jit_requested) {
5360 err = jit_subprogs(env);
5361 if (err == 0)
Alexei Starovoitov1c2a0882017-12-14 17:55:15 -08005362 return 0;
David S. Miller19d28fb2018-01-11 21:27:54 -05005363 }
5364#ifndef CONFIG_BPF_JIT_ALWAYS_ON
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005365 for (i = 0; i < prog->len; i++, insn++) {
5366 if (insn->code != (BPF_JMP | BPF_CALL) ||
5367 insn->src_reg != BPF_PSEUDO_CALL)
5368 continue;
5369 depth = get_callee_stack_depth(env, insn, i);
5370 if (depth < 0)
5371 return depth;
5372 bpf_patch_call_args(insn, depth);
5373 }
David S. Miller19d28fb2018-01-11 21:27:54 -05005374 err = 0;
5375#endif
5376 return err;
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005377}
5378
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005379/* fixup insn->imm field of bpf_call instructions
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005380 * and inline eligible helpers as explicit sequence of BPF instructions
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005381 *
5382 * this function is called after eBPF program passed verification
5383 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005384static int fixup_bpf_calls(struct bpf_verifier_env *env)
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005385{
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005386 struct bpf_prog *prog = env->prog;
5387 struct bpf_insn *insn = prog->insnsi;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005388 const struct bpf_func_proto *fn;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005389 const int insn_cnt = prog->len;
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005390 struct bpf_insn insn_buf[16];
5391 struct bpf_prog *new_prog;
5392 struct bpf_map *map_ptr;
5393 int i, cnt, delta = 0;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005394
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005395 for (i = 0; i < insn_cnt; i++, insn++) {
Alexei Starovoitov68fda452018-01-12 18:59:52 -08005396 if (insn->code == (BPF_ALU | BPF_MOD | BPF_X) ||
5397 insn->code == (BPF_ALU | BPF_DIV | BPF_X)) {
5398 /* due to JIT bugs clear upper 32-bits of src register
5399 * before div/mod operation
5400 */
5401 insn_buf[0] = BPF_MOV32_REG(insn->src_reg, insn->src_reg);
5402 insn_buf[1] = *insn;
5403 cnt = 2;
5404 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
5405 if (!new_prog)
5406 return -ENOMEM;
5407
5408 delta += cnt - 1;
5409 env->prog = prog = new_prog;
5410 insn = new_prog->insnsi + i + delta;
5411 continue;
5412 }
5413
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005414 if (insn->code != (BPF_JMP | BPF_CALL))
5415 continue;
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005416 if (insn->src_reg == BPF_PSEUDO_CALL)
5417 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005418
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005419 if (insn->imm == BPF_FUNC_get_route_realm)
5420 prog->dst_needed = 1;
5421 if (insn->imm == BPF_FUNC_get_prandom_u32)
5422 bpf_user_rnd_init_once();
Josef Bacik9802d862017-12-11 11:36:48 -05005423 if (insn->imm == BPF_FUNC_override_return)
5424 prog->kprobe_override = 1;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005425 if (insn->imm == BPF_FUNC_tail_call) {
David S. Miller7b9f6da2017-04-20 10:35:33 -04005426 /* If we tail call into other programs, we
5427 * cannot make any assumptions since they can
5428 * be replaced dynamically during runtime in
5429 * the program array.
5430 */
5431 prog->cb_access = 1;
Alexei Starovoitov80a58d02017-05-30 13:31:30 -07005432 env->prog->aux->stack_depth = MAX_BPF_STACK;
David S. Miller7b9f6da2017-04-20 10:35:33 -04005433
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005434 /* mark bpf_tail_call as different opcode to avoid
5435 * conditional branch in the interpeter for every normal
5436 * call and to prevent accidental JITing by JIT compiler
5437 * that doesn't support bpf_tail_call yet
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005438 */
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005439 insn->imm = 0;
Alexei Starovoitov71189fa2017-05-30 13:31:27 -07005440 insn->code = BPF_JMP | BPF_TAIL_CALL;
Alexei Starovoitovb2157392018-01-07 17:33:02 -08005441
5442 /* instead of changing every JIT dealing with tail_call
5443 * emit two extra insns:
5444 * if (index >= max_entries) goto out;
5445 * index &= array->index_mask;
5446 * to avoid out-of-bounds cpu speculation
5447 */
5448 map_ptr = env->insn_aux_data[i + delta].map_ptr;
5449 if (map_ptr == BPF_MAP_PTR_POISON) {
Colin Ian King40950342018-01-10 09:20:54 +00005450 verbose(env, "tail_call abusing map_ptr\n");
Alexei Starovoitovb2157392018-01-07 17:33:02 -08005451 return -EINVAL;
5452 }
5453 if (!map_ptr->unpriv_array)
5454 continue;
5455 insn_buf[0] = BPF_JMP_IMM(BPF_JGE, BPF_REG_3,
5456 map_ptr->max_entries, 2);
5457 insn_buf[1] = BPF_ALU32_IMM(BPF_AND, BPF_REG_3,
5458 container_of(map_ptr,
5459 struct bpf_array,
5460 map)->index_mask);
5461 insn_buf[2] = *insn;
5462 cnt = 3;
5463 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf, cnt);
5464 if (!new_prog)
5465 return -ENOMEM;
5466
5467 delta += cnt - 1;
5468 env->prog = prog = new_prog;
5469 insn = new_prog->insnsi + i + delta;
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005470 continue;
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005471 }
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005472
Daniel Borkmann89c63072017-08-19 03:12:45 +02005473 /* BPF_EMIT_CALL() assumptions in some of the map_gen_lookup
5474 * handlers are currently limited to 64 bit only.
5475 */
Alexei Starovoitov60b58afc2017-12-14 17:55:14 -08005476 if (prog->jit_requested && BITS_PER_LONG == 64 &&
Daniel Borkmann89c63072017-08-19 03:12:45 +02005477 insn->imm == BPF_FUNC_map_lookup_elem) {
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005478 map_ptr = env->insn_aux_data[i + delta].map_ptr;
Martin KaFai Laufad73a12017-03-22 10:00:32 -07005479 if (map_ptr == BPF_MAP_PTR_POISON ||
5480 !map_ptr->ops->map_gen_lookup)
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005481 goto patch_call_imm;
5482
5483 cnt = map_ptr->ops->map_gen_lookup(map_ptr, insn_buf);
5484 if (cnt == 0 || cnt >= ARRAY_SIZE(insn_buf)) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005485 verbose(env, "bpf verifier is misconfigured\n");
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005486 return -EINVAL;
5487 }
5488
5489 new_prog = bpf_patch_insn_data(env, i + delta, insn_buf,
5490 cnt);
5491 if (!new_prog)
5492 return -ENOMEM;
5493
5494 delta += cnt - 1;
5495
5496 /* keep walking new program and skip insns we just inserted */
5497 env->prog = prog = new_prog;
5498 insn = new_prog->insnsi + i + delta;
5499 continue;
5500 }
5501
Daniel Borkmann109980b2017-09-08 00:14:51 +02005502 if (insn->imm == BPF_FUNC_redirect_map) {
Daniel Borkmann7c300132017-09-20 00:44:21 +02005503 /* Note, we cannot use prog directly as imm as subsequent
5504 * rewrites would still change the prog pointer. The only
5505 * stable address we can use is aux, which also works with
5506 * prog clones during blinding.
5507 */
5508 u64 addr = (unsigned long)prog->aux;
Daniel Borkmann109980b2017-09-08 00:14:51 +02005509 struct bpf_insn r4_ld[] = {
5510 BPF_LD_IMM64(BPF_REG_4, addr),
5511 *insn,
5512 };
5513 cnt = ARRAY_SIZE(r4_ld);
5514
5515 new_prog = bpf_patch_insn_data(env, i + delta, r4_ld, cnt);
5516 if (!new_prog)
5517 return -ENOMEM;
5518
5519 delta += cnt - 1;
5520 env->prog = prog = new_prog;
5521 insn = new_prog->insnsi + i + delta;
5522 }
Alexei Starovoitov81ed18a2017-03-15 18:26:42 -07005523patch_call_imm:
Jakub Kicinski00176a32017-10-16 16:40:54 -07005524 fn = env->ops->get_func_proto(insn->imm);
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005525 /* all functions that have prototype and verifier allowed
5526 * programs to call them, must be real in-kernel functions
5527 */
5528 if (!fn->func) {
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005529 verbose(env,
5530 "kernel subsystem misconfigured func %s#%d\n",
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005531 func_id_name(insn->imm), insn->imm);
5532 return -EFAULT;
5533 }
5534 insn->imm = fn->func - __bpf_call_base;
5535 }
5536
5537 return 0;
5538}
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005539
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005540static void free_states(struct bpf_verifier_env *env)
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005541{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005542 struct bpf_verifier_state_list *sl, *sln;
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005543 int i;
5544
5545 if (!env->explored_states)
5546 return;
5547
5548 for (i = 0; i < env->prog->len; i++) {
5549 sl = env->explored_states[i];
5550
5551 if (sl)
5552 while (sl != STATE_LIST_MARK) {
5553 sln = sl->next;
Alexei Starovoitov1969db42017-11-01 00:08:04 -07005554 free_verifier_state(&sl->state, false);
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005555 kfree(sl);
5556 sl = sln;
5557 }
5558 }
5559
5560 kfree(env->explored_states);
5561}
5562
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005563int bpf_check(struct bpf_prog **prog, union bpf_attr *attr)
Alexei Starovoitov51580e72014-09-26 00:17:02 -07005564{
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005565 struct bpf_verifier_env *env;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005566 struct bpf_verifer_log *log;
Alexei Starovoitov51580e72014-09-26 00:17:02 -07005567 int ret = -EINVAL;
5568
Arnd Bergmanneba0c922017-11-02 12:05:52 +01005569 /* no program is valid */
5570 if (ARRAY_SIZE(bpf_verifier_ops) == 0)
5571 return -EINVAL;
5572
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005573 /* 'struct bpf_verifier_env' can be global, but since it's not small,
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005574 * allocate/free it every time bpf_check() is called
5575 */
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005576 env = kzalloc(sizeof(struct bpf_verifier_env), GFP_KERNEL);
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005577 if (!env)
5578 return -ENOMEM;
Jakub Kicinski61bd5212017-10-09 10:30:11 -07005579 log = &env->log;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005580
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005581 env->insn_aux_data = vzalloc(sizeof(struct bpf_insn_aux_data) *
5582 (*prog)->len);
5583 ret = -ENOMEM;
5584 if (!env->insn_aux_data)
5585 goto err_free_env;
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005586 env->prog = *prog;
Jakub Kicinski00176a32017-10-16 16:40:54 -07005587 env->ops = bpf_verifier_ops[env->prog->type];
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005588
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005589 /* grab the mutex to protect few globals used by verifier */
5590 mutex_lock(&bpf_verifier_lock);
5591
5592 if (attr->log_level || attr->log_buf || attr->log_size) {
5593 /* user requested verbose verifier output
5594 * and supplied buffer to store the verification trace
5595 */
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07005596 log->level = attr->log_level;
5597 log->ubuf = (char __user *) (unsigned long) attr->log_buf;
5598 log->len_total = attr->log_size;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005599
5600 ret = -EINVAL;
Jakub Kicinskie7bf8242017-10-09 10:30:10 -07005601 /* log attributes have to be sane */
5602 if (log->len_total < 128 || log->len_total > UINT_MAX >> 8 ||
5603 !log->level || !log->ubuf)
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005604 goto err_unlock;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005605 }
Daniel Borkmann1ad2f582017-05-25 01:05:05 +02005606
5607 env->strict_alignment = !!(attr->prog_flags & BPF_F_STRICT_ALIGNMENT);
5608 if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
David S. Millere07b98d2017-05-10 11:38:07 -07005609 env->strict_alignment = true;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005610
Jakub Kicinskicae19272017-12-27 18:39:05 -08005611 if (bpf_prog_is_dev_bound(env->prog->aux)) {
Jakub Kicinskiab3f0062017-11-03 13:56:17 -07005612 ret = bpf_prog_offload_verifier_prep(env);
5613 if (ret)
5614 goto err_unlock;
5615 }
5616
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005617 ret = replace_map_fd_with_map_ptr(env);
5618 if (ret < 0)
5619 goto skip_full_check;
5620
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005621 env->explored_states = kcalloc(env->prog->len,
Jakub Kicinski58e2af8b2016-09-21 11:43:57 +01005622 sizeof(struct bpf_verifier_state_list *),
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005623 GFP_USER);
5624 ret = -ENOMEM;
5625 if (!env->explored_states)
5626 goto skip_full_check;
5627
Alexei Starovoitovcc8b0b92017-12-14 17:55:05 -08005628 env->allow_ptr_leaks = capable(CAP_SYS_ADMIN);
5629
Alexei Starovoitov475fb782014-09-26 00:17:05 -07005630 ret = check_cfg(env);
5631 if (ret < 0)
5632 goto skip_full_check;
5633
Alexei Starovoitov17a52672014-09-26 00:17:06 -07005634 ret = do_check(env);
Craig Gallek8c01c4f2017-11-02 11:18:01 -04005635 if (env->cur_state) {
5636 free_verifier_state(env->cur_state, true);
5637 env->cur_state = NULL;
5638 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005639
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005640skip_full_check:
Alexei Starovoitov638f5b92017-10-31 18:16:05 -07005641 while (!pop_stack(env, NULL, NULL));
Alexei Starovoitovf1bca822014-09-29 18:50:01 -07005642 free_states(env);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005643
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005644 if (ret == 0)
Alexei Starovoitovc1311872017-11-22 16:42:05 -08005645 sanitize_dead_code(env);
5646
5647 if (ret == 0)
Alexei Starovoitov70a87ff2017-12-25 13:15:40 -08005648 ret = check_max_stack_depth(env);
5649
5650 if (ret == 0)
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005651 /* program is valid, convert *(u32*)(ctx + off) accesses */
5652 ret = convert_ctx_accesses(env);
5653
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005654 if (ret == 0)
Alexei Starovoitov79741b32017-03-15 18:26:40 -07005655 ret = fixup_bpf_calls(env);
Alexei Starovoitove245c5c62017-03-15 18:26:39 -07005656
Alexei Starovoitov1ea47e02017-12-14 17:55:13 -08005657 if (ret == 0)
5658 ret = fixup_call_args(env);
5659
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005660 if (log->level && bpf_verifier_log_full(log))
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005661 ret = -ENOSPC;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005662 if (log->level && !log->ubuf) {
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005663 ret = -EFAULT;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005664 goto err_release_maps;
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005665 }
5666
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005667 if (ret == 0 && env->used_map_cnt) {
5668 /* if program passed verifier, update used_maps in bpf_prog_info */
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005669 env->prog->aux->used_maps = kmalloc_array(env->used_map_cnt,
5670 sizeof(env->used_maps[0]),
5671 GFP_KERNEL);
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005672
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005673 if (!env->prog->aux->used_maps) {
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005674 ret = -ENOMEM;
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005675 goto err_release_maps;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005676 }
5677
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005678 memcpy(env->prog->aux->used_maps, env->used_maps,
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005679 sizeof(env->used_maps[0]) * env->used_map_cnt);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005680 env->prog->aux->used_map_cnt = env->used_map_cnt;
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005681
5682 /* program is valid. Convert pseudo bpf_ld_imm64 into generic
5683 * bpf_ld_imm64 instructions
5684 */
5685 convert_pseudo_ld_imm64(env);
5686 }
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005687
Jakub Kicinskia2a7d572017-10-09 10:30:15 -07005688err_release_maps:
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005689 if (!env->prog->aux->used_maps)
Alexei Starovoitov0246e642014-09-26 00:17:04 -07005690 /* if we didn't copy map pointers into bpf_prog_info, release
5691 * them now. Otherwise free_bpf_prog_info() will release them.
5692 */
5693 release_maps(env);
Alexei Starovoitov9bac3d62015-03-13 11:57:42 -07005694 *prog = env->prog;
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005695err_unlock:
Alexei Starovoitovcbd35702014-09-26 00:17:03 -07005696 mutex_unlock(&bpf_verifier_lock);
Jakub Kicinski3df126f2016-09-21 11:43:56 +01005697 vfree(env->insn_aux_data);
5698err_free_env:
5699 kfree(env);
Alexei Starovoitov51580e72014-09-26 00:17:02 -07005700 return ret;
5701}