Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 1 | // Copyright 2015 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package java |
| 16 | |
Jaewoong Jung | f9b4465 | 2020-12-21 12:29:12 -0800 | [diff] [blame] | 17 | // This file contains the module implementations for android_app, android_test, and some more |
| 18 | // related module types, including their override variants. |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 19 | |
| 20 | import ( |
Jaewoong Jung | a5e5abc | 2019-04-26 14:31:50 -0700 | [diff] [blame] | 21 | "path/filepath" |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 22 | "sort" |
Jaewoong Jung | a5e5abc | 2019-04-26 14:31:50 -0700 | [diff] [blame] | 23 | "strings" |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 24 | |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 25 | "github.com/google/blueprint" |
| 26 | "github.com/google/blueprint/proptools" |
| 27 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 28 | "android/soong/android" |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 29 | "android/soong/cc" |
Ulya Trafimovich | d4bcea4 | 2020-06-03 14:57:22 +0100 | [diff] [blame] | 30 | "android/soong/dexpreopt" |
Colin Cross | 303e21f | 2018-08-07 16:49:25 -0700 | [diff] [blame] | 31 | "android/soong/tradefed" |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 32 | ) |
| 33 | |
Colin Cross | 3bc7ffa | 2017-11-22 16:19:37 -0800 | [diff] [blame] | 34 | func init() { |
Paul Duffin | f9b1da0 | 2019-12-18 19:51:55 +0000 | [diff] [blame] | 35 | RegisterAppBuildComponents(android.InitRegistrationContext) |
Colin Cross | 3bc7ffa | 2017-11-22 16:19:37 -0800 | [diff] [blame] | 36 | } |
| 37 | |
Paul Duffin | f9b1da0 | 2019-12-18 19:51:55 +0000 | [diff] [blame] | 38 | func RegisterAppBuildComponents(ctx android.RegistrationContext) { |
| 39 | ctx.RegisterModuleType("android_app", AndroidAppFactory) |
| 40 | ctx.RegisterModuleType("android_test", AndroidTestFactory) |
| 41 | ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory) |
| 42 | ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory) |
| 43 | ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory) |
| 44 | ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory) |
Paul Duffin | f9b1da0 | 2019-12-18 19:51:55 +0000 | [diff] [blame] | 45 | } |
| 46 | |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 47 | // AndroidManifest.xml merging |
| 48 | // package splits |
| 49 | |
Colin Cross | fabb608 | 2018-02-20 17:22:23 -0800 | [diff] [blame] | 50 | type appProperties struct { |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 51 | // Names of extra android_app_certificate modules to sign the apk with in the form ":module". |
Colin Cross | 7d5136f | 2015-05-11 13:39:40 -0700 | [diff] [blame] | 52 | Additional_certificates []string |
| 53 | |
| 54 | // If set, create package-export.apk, which other packages can |
| 55 | // use to get PRODUCT-agnostic resource data like IDs and type definitions. |
Nan Zhang | ea568a4 | 2017-11-08 21:20:04 -0800 | [diff] [blame] | 56 | Export_package_resources *bool |
Colin Cross | 7d5136f | 2015-05-11 13:39:40 -0700 | [diff] [blame] | 57 | |
Colin Cross | 1605606 | 2017-12-13 22:46:28 -0800 | [diff] [blame] | 58 | // Specifies that this app should be installed to the priv-app directory, |
| 59 | // where the system will grant it additional privileges not available to |
| 60 | // normal apps. |
| 61 | Privileged *bool |
Colin Cross | a97c5d3 | 2018-03-28 14:58:31 -0700 | [diff] [blame] | 62 | |
| 63 | // list of resource labels to generate individual resource packages |
| 64 | Package_splits []string |
Jason Monk | d4122be | 2018-08-10 09:33:36 -0400 | [diff] [blame] | 65 | |
| 66 | // Names of modules to be overridden. Listed modules can only be other binaries |
| 67 | // (in Make or Soong). |
| 68 | // This does not completely prevent installation of the overridden binaries, but if both |
| 69 | // binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed |
| 70 | // from PRODUCT_PACKAGES. |
| 71 | Overrides []string |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 72 | |
| 73 | // list of native libraries that will be provided in or alongside the resulting jar |
| 74 | Jni_libs []string `android:"arch_variant"` |
| 75 | |
Colin Cross | 7204cf0 | 2020-05-06 17:51:39 -0700 | [diff] [blame] | 76 | // if true, use JNI libraries that link against platform APIs even if this module sets |
Colin Cross | ee87c60 | 2020-02-19 16:57:15 -0800 | [diff] [blame] | 77 | // sdk_version. |
| 78 | Jni_uses_platform_apis *bool |
| 79 | |
Colin Cross | 7204cf0 | 2020-05-06 17:51:39 -0700 | [diff] [blame] | 80 | // if true, use JNI libraries that link against SDK APIs even if this module does not set |
| 81 | // sdk_version. |
| 82 | Jni_uses_sdk_apis *bool |
| 83 | |
Jaewoong Jung | bc625cd | 2019-05-06 15:48:44 -0700 | [diff] [blame] | 84 | // STL library to use for JNI libraries. |
| 85 | Stl *string `android:"arch_variant"` |
| 86 | |
Colin Cross | e4246ab | 2019-02-05 21:55:21 -0800 | [diff] [blame] | 87 | // Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest |
| 88 | // flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 89 | // sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for |
| 90 | // android_app modules that are embedded to APEXes, defaults to false for other module types where the native |
| 91 | // libraries are generally preinstalled outside the APK. |
Colin Cross | e4246ab | 2019-02-05 21:55:21 -0800 | [diff] [blame] | 92 | Use_embedded_native_libs *bool |
Colin Cross | 46abdad | 2019-02-07 13:07:08 -0800 | [diff] [blame] | 93 | |
| 94 | // Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that |
| 95 | // they are used from inside the APK at runtime. |
| 96 | Use_embedded_dex *bool |
Colin Cross | 47fa9d3 | 2019-03-26 10:51:39 -0700 | [diff] [blame] | 97 | |
| 98 | // Forces native libraries to always be packaged into the APK, |
| 99 | // Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed. |
| 100 | // True for android_test* modules. |
| 101 | AlwaysPackageNativeLibs bool `blueprint:"mutated"` |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 102 | |
| 103 | // If set, find and merge all NOTICE files that this module and its dependencies have and store |
| 104 | // it in the APK as an asset. |
| 105 | Embed_notices *bool |
Jaewoong Jung | 87a33e7 | 2020-03-26 14:01:48 -0700 | [diff] [blame] | 106 | |
| 107 | // cc.Coverage related properties |
| 108 | PreventInstall bool `blueprint:"mutated"` |
| 109 | HideFromMake bool `blueprint:"mutated"` |
| 110 | IsCoverageVariant bool `blueprint:"mutated"` |
Artur Satayev | 2db1c3f | 2020-04-08 19:09:30 +0100 | [diff] [blame] | 111 | |
| 112 | // Whether this app is considered mainline updatable or not. When set to true, this will enforce |
Artur Satayev | f40fc85 | 2020-04-16 13:43:02 +0100 | [diff] [blame] | 113 | // additional rules to make sure an app can safely be updated. Default is false. |
| 114 | // Prefer using other specific properties if build behaviour must be changed; avoid using this |
| 115 | // flag for anything but neverallow rules (unless the behaviour change is invisible to owners). |
Artur Satayev | 2db1c3f | 2020-04-08 19:09:30 +0100 | [diff] [blame] | 116 | Updatable *bool |
Colin Cross | 7d5136f | 2015-05-11 13:39:40 -0700 | [diff] [blame] | 117 | } |
| 118 | |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 119 | // android_app properties that can be overridden by override_android_app |
| 120 | type overridableAppProperties struct { |
| 121 | // The name of a certificate in the default certificate directory, blank to use the default product certificate, |
| 122 | // or an android_app_certificate module name in the form ":module". |
| 123 | Certificate *string |
Jaewoong Jung | 6f373f6 | 2019-03-13 10:13:24 -0700 | [diff] [blame] | 124 | |
Jaewoong Jung | 1c1b6e6 | 2021-03-09 15:02:31 -0800 | [diff] [blame] | 125 | // Name of the signing certificate lineage file or filegroup module. |
| 126 | Lineage *string `android:"path"` |
Liz Kammer | e2b27f4 | 2020-05-07 13:24:05 -0700 | [diff] [blame] | 127 | |
Jaewoong Jung | 6f373f6 | 2019-03-13 10:13:24 -0700 | [diff] [blame] | 128 | // the package name of this app. The package name in the manifest file is used if one was not given. |
| 129 | Package_name *string |
Baligh Uddin | 5b16dfb | 2020-02-11 17:27:19 -0800 | [diff] [blame] | 130 | |
| 131 | // the logging parent of this app. |
| 132 | Logging_parent *string |
Liz Kammer | 9f9fd02 | 2020-06-18 19:44:06 +0000 | [diff] [blame] | 133 | |
| 134 | // Whether to rename the package in resources to the override name rather than the base name. Defaults to true. |
| 135 | Rename_resources_package *bool |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 136 | } |
| 137 | |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 138 | type AndroidApp struct { |
Colin Cross | a97c5d3 | 2018-03-28 14:58:31 -0700 | [diff] [blame] | 139 | Library |
| 140 | aapt |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 141 | android.OverridableModuleBase |
Colin Cross | a97c5d3 | 2018-03-28 14:58:31 -0700 | [diff] [blame] | 142 | |
Jiyong Park | c00cbd9 | 2018-10-30 21:20:05 +0900 | [diff] [blame] | 143 | certificate Certificate |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 144 | |
Colin Cross | fabb608 | 2018-02-20 17:22:23 -0800 | [diff] [blame] | 145 | appProperties appProperties |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 146 | |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 147 | overridableAppProperties overridableAppProperties |
| 148 | |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 149 | jniLibs []jniLib |
| 150 | installPathForJNISymbols android.Path |
| 151 | embeddedJniLibs bool |
| 152 | jniCoverageOutputs android.Paths |
Colin Cross | f623721 | 2018-10-29 23:14:58 -0700 | [diff] [blame] | 153 | |
| 154 | bundleFile android.Path |
Jaewoong Jung | 9d22a91 | 2019-01-23 16:27:47 -0800 | [diff] [blame] | 155 | |
| 156 | // the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES. |
| 157 | installApkName string |
Jaewoong Jung | 4102e5d | 2019-02-27 16:26:28 -0800 | [diff] [blame] | 158 | |
Colin Cross | 70dda7e | 2019-10-01 22:05:35 -0700 | [diff] [blame] | 159 | installDir android.InstallPath |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 160 | |
Jaewoong Jung | 7dd4ae2 | 2019-09-27 17:13:15 -0700 | [diff] [blame] | 161 | onDeviceDir string |
| 162 | |
Jaewoong Jung | 4102e5d | 2019-02-27 16:26:28 -0800 | [diff] [blame] | 163 | additionalAaptFlags []string |
Jaewoong Jung | 9877279 | 2019-07-01 17:15:13 -0700 | [diff] [blame] | 164 | |
| 165 | noticeOutputs android.NoticeOutputs |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 166 | |
| 167 | overriddenManifestPackageName string |
Artur Satayev | 1111b84 | 2020-04-27 19:05:28 +0100 | [diff] [blame] | 168 | |
| 169 | android.ApexBundleDepsInfo |
Colin Cross | e1731a5 | 2017-12-14 11:22:55 -0800 | [diff] [blame] | 170 | } |
| 171 | |
Martin Stjernholm | 6d41527 | 2020-01-31 17:10:36 +0000 | [diff] [blame] | 172 | func (a *AndroidApp) IsInstallable() bool { |
| 173 | return Bool(a.properties.Installable) |
| 174 | } |
| 175 | |
Colin Cross | 89c3158 | 2018-04-30 15:55:11 -0700 | [diff] [blame] | 176 | func (a *AndroidApp) ExportedProguardFlagFiles() android.Paths { |
| 177 | return nil |
| 178 | } |
| 179 | |
Colin Cross | 66f7882 | 2018-05-02 12:58:28 -0700 | [diff] [blame] | 180 | func (a *AndroidApp) ExportedStaticPackages() android.Paths { |
| 181 | return nil |
| 182 | } |
| 183 | |
Sundong Ahn | e1f05aa | 2019-08-27 13:55:42 +0900 | [diff] [blame] | 184 | func (a *AndroidApp) OutputFile() android.Path { |
| 185 | return a.outputFile |
| 186 | } |
| 187 | |
Colin Cross | 503c1d0 | 2020-01-28 14:00:53 -0800 | [diff] [blame] | 188 | func (a *AndroidApp) Certificate() Certificate { |
| 189 | return a.certificate |
| 190 | } |
| 191 | |
Jaewoong Jung | 87a33e7 | 2020-03-26 14:01:48 -0700 | [diff] [blame] | 192 | func (a *AndroidApp) JniCoverageOutputs() android.Paths { |
| 193 | return a.jniCoverageOutputs |
| 194 | } |
| 195 | |
Colin Cross | a97c5d3 | 2018-03-28 14:58:31 -0700 | [diff] [blame] | 196 | var _ AndroidLibraryDependency = (*AndroidApp)(nil) |
| 197 | |
Jiyong Park | c00cbd9 | 2018-10-30 21:20:05 +0900 | [diff] [blame] | 198 | type Certificate struct { |
Colin Cross | 503c1d0 | 2020-01-28 14:00:53 -0800 | [diff] [blame] | 199 | Pem, Key android.Path |
| 200 | presigned bool |
| 201 | } |
| 202 | |
Sasha Smundak | 18d98bc | 2020-05-27 16:36:07 -0700 | [diff] [blame] | 203 | var PresignedCertificate = Certificate{presigned: true} |
Colin Cross | 503c1d0 | 2020-01-28 14:00:53 -0800 | [diff] [blame] | 204 | |
| 205 | func (c Certificate) AndroidMkString() string { |
| 206 | if c.presigned { |
| 207 | return "PRESIGNED" |
| 208 | } else { |
| 209 | return c.Pem.String() |
| 210 | } |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 211 | } |
| 212 | |
Colin Cross | 46c9b8b | 2017-06-22 16:51:17 -0700 | [diff] [blame] | 213 | func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) { |
| 214 | a.Module.deps(ctx) |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 215 | |
Jiyong Park | 6a927c4 | 2020-01-21 02:03:43 +0900 | [diff] [blame] | 216 | if String(a.appProperties.Stl) == "c++_shared" && !a.sdkVersion().specified() { |
Jaewoong Jung | bc625cd | 2019-05-06 15:48:44 -0700 | [diff] [blame] | 217 | ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared") |
| 218 | } |
| 219 | |
Paul Duffin | 250e619 | 2019-06-07 10:44:37 +0100 | [diff] [blame] | 220 | sdkDep := decodeSdkDep(ctx, sdkContext(a)) |
| 221 | if sdkDep.hasFrameworkLibs() { |
| 222 | a.aapt.deps(ctx, sdkDep) |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 223 | } |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 224 | |
Colin Cross | 3c00770 | 2020-05-08 11:20:24 -0700 | [diff] [blame] | 225 | usesSDK := a.sdkVersion().specified() && a.sdkVersion().kind != sdkCorePlatform |
| 226 | |
| 227 | if usesSDK && Bool(a.appProperties.Jni_uses_sdk_apis) { |
| 228 | ctx.PropertyErrorf("jni_uses_sdk_apis", |
| 229 | "can only be set for modules that do not set sdk_version") |
| 230 | } else if !usesSDK && Bool(a.appProperties.Jni_uses_platform_apis) { |
| 231 | ctx.PropertyErrorf("jni_uses_platform_apis", |
| 232 | "can only be set for modules that set sdk_version") |
| 233 | } |
| 234 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 235 | for _, jniTarget := range ctx.MultiTargets() { |
Colin Cross | 0f7d2ef | 2019-10-16 11:03:10 -0700 | [diff] [blame] | 236 | variation := append(jniTarget.Variations(), |
| 237 | blueprint.Variation{Mutator: "link", Variation: "shared"}) |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 238 | |
| 239 | // If the app builds against an Android SDK use the SDK variant of JNI dependencies |
| 240 | // unless jni_uses_platform_apis is set. |
Colin Cross | c2d2405 | 2020-05-13 11:05:02 -0700 | [diff] [blame] | 241 | // Don't require the SDK variant for apps that are shipped on vendor, etc., as they already |
| 242 | // have stable APIs through the VNDK. |
| 243 | if (usesSDK && !a.RequiresStableAPIs(ctx) && |
| 244 | !Bool(a.appProperties.Jni_uses_platform_apis)) || |
Colin Cross | 7204cf0 | 2020-05-06 17:51:39 -0700 | [diff] [blame] | 245 | Bool(a.appProperties.Jni_uses_sdk_apis) { |
Colin Cross | c511bc5 | 2020-04-07 16:50:32 +0000 | [diff] [blame] | 246 | variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"}) |
| 247 | } |
Colin Cross | de78d13 | 2020-10-09 18:59:49 -0700 | [diff] [blame] | 248 | ctx.AddFarVariationDependencies(variation, jniLibTag, a.appProperties.Jni_libs...) |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 249 | } |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 250 | |
Paul Duffin | 250e619 | 2019-06-07 10:44:37 +0100 | [diff] [blame] | 251 | a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs()) |
Jaewoong Jung | b639a6a | 2019-05-10 15:16:29 -0700 | [diff] [blame] | 252 | } |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 253 | |
Jaewoong Jung | b639a6a | 2019-05-10 15:16:29 -0700 | [diff] [blame] | 254 | func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) { |
Jaewoong Jung | 2ad817c | 2019-01-18 14:27:16 -0800 | [diff] [blame] | 255 | cert := android.SrcIsModule(a.getCertString(ctx)) |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 256 | if cert != "" { |
| 257 | ctx.AddDependency(ctx.Module(), certificateTag, cert) |
| 258 | } |
| 259 | |
| 260 | for _, cert := range a.appProperties.Additional_certificates { |
| 261 | cert = android.SrcIsModule(cert) |
| 262 | if cert != "" { |
| 263 | ctx.AddDependency(ctx.Module(), certificateTag, cert) |
| 264 | } else { |
| 265 | ctx.PropertyErrorf("additional_certificates", |
| 266 | `must be names of android_app_certificate modules in the form ":module"`) |
| 267 | } |
| 268 | } |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 269 | } |
| 270 | |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 271 | func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
| 272 | a.generateAndroidBuildActions(ctx) |
| 273 | } |
| 274 | |
Colin Cross | 46c9b8b | 2017-06-22 16:51:17 -0700 | [diff] [blame] | 275 | func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
Artur Satayev | 2db1c3f | 2020-04-08 19:09:30 +0100 | [diff] [blame] | 276 | a.checkAppSdkVersions(ctx) |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 277 | a.generateAndroidBuildActions(ctx) |
| 278 | } |
| 279 | |
Artur Satayev | 2db1c3f | 2020-04-08 19:09:30 +0100 | [diff] [blame] | 280 | func (a *AndroidApp) checkAppSdkVersions(ctx android.ModuleContext) { |
Artur Satayev | 849f844 | 2020-04-28 14:57:42 +0100 | [diff] [blame] | 281 | if a.Updatable() { |
Artur Satayev | 2db1c3f | 2020-04-08 19:09:30 +0100 | [diff] [blame] | 282 | if !a.sdkVersion().stable() { |
| 283 | ctx.PropertyErrorf("sdk_version", "Updatable apps must use stable SDKs, found %v", a.sdkVersion()) |
| 284 | } |
Artur Satayev | f40fc85 | 2020-04-16 13:43:02 +0100 | [diff] [blame] | 285 | if String(a.deviceProperties.Min_sdk_version) == "" { |
| 286 | ctx.PropertyErrorf("updatable", "updatable apps must set min_sdk_version.") |
| 287 | } |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 288 | |
Jooyung Han | bbc3fb7 | 2020-04-29 14:01:06 +0900 | [diff] [blame] | 289 | if minSdkVersion, err := a.minSdkVersion().effectiveVersion(ctx); err == nil { |
| 290 | a.checkJniLibsSdkVersion(ctx, minSdkVersion) |
Dan Albert | c806053 | 2020-07-22 22:32:17 -0700 | [diff] [blame] | 291 | android.CheckMinSdkVersion(a, ctx, minSdkVersion.ApiLevel(ctx)) |
Jooyung Han | bbc3fb7 | 2020-04-29 14:01:06 +0900 | [diff] [blame] | 292 | } else { |
| 293 | ctx.PropertyErrorf("min_sdk_version", "%s", err.Error()) |
| 294 | } |
Artur Satayev | 2db1c3f | 2020-04-08 19:09:30 +0100 | [diff] [blame] | 295 | } |
| 296 | |
| 297 | a.checkPlatformAPI(ctx) |
| 298 | a.checkSdkVersions(ctx) |
| 299 | } |
| 300 | |
Jooyung Han | bbc3fb7 | 2020-04-29 14:01:06 +0900 | [diff] [blame] | 301 | // If an updatable APK sets min_sdk_version, min_sdk_vesion of JNI libs should match with it. |
| 302 | // This check is enforced for "updatable" APKs (including APK-in-APEX). |
| 303 | // b/155209650: until min_sdk_version is properly supported, use sdk_version instead. |
| 304 | // because, sdk_version is overridden by min_sdk_version (if set as smaller) |
| 305 | // and linkType is checked with dependencies so we can be sure that the whole dependency tree |
| 306 | // will meet the requirements. |
| 307 | func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVersion sdkVersion) { |
| 308 | // It's enough to check direct JNI deps' sdk_version because all transitive deps from JNI deps are checked in cc.checkLinkType() |
| 309 | ctx.VisitDirectDeps(func(m android.Module) { |
| 310 | if !IsJniDepTag(ctx.OtherModuleDependencyTag(m)) { |
| 311 | return |
| 312 | } |
| 313 | dep, _ := m.(*cc.Module) |
Jooyung Han | 652d5b3 | 2020-05-20 17:12:13 +0900 | [diff] [blame] | 314 | // The domain of cc.sdk_version is "current" and <number> |
| 315 | // We can rely on sdkSpec to convert it to <number> so that "current" is handled |
| 316 | // properly regardless of sdk finalization. |
| 317 | jniSdkVersion, err := sdkSpecFrom(dep.SdkVersion()).effectiveVersion(ctx) |
| 318 | if err != nil || minSdkVersion < jniSdkVersion { |
Jooyung Han | bbc3fb7 | 2020-04-29 14:01:06 +0900 | [diff] [blame] | 319 | ctx.OtherModuleErrorf(dep, "sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)", |
| 320 | dep.SdkVersion(), minSdkVersion, ctx.ModuleName()) |
| 321 | return |
| 322 | } |
| 323 | |
| 324 | }) |
| 325 | } |
| 326 | |
Sasha Smundak | 6ad7725 | 2019-05-01 13:16:22 -0700 | [diff] [blame] | 327 | // Returns true if the native libraries should be stored in the APK uncompressed and the |
Colin Cross | e4246ab | 2019-02-05 21:55:21 -0800 | [diff] [blame] | 328 | // extractNativeLibs application flag should be set to false in the manifest. |
Sasha Smundak | 6ad7725 | 2019-05-01 13:16:22 -0700 | [diff] [blame] | 329 | func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool { |
Jiyong Park | 6a927c4 | 2020-01-21 02:03:43 +0900 | [diff] [blame] | 330 | minSdkVersion, err := a.minSdkVersion().effectiveVersion(ctx) |
Colin Cross | e4246ab | 2019-02-05 21:55:21 -0800 | [diff] [blame] | 331 | if err != nil { |
| 332 | ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.minSdkVersion(), err) |
| 333 | } |
| 334 | |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 335 | apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo) |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 336 | return (minSdkVersion >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) || |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 337 | !apexInfo.IsForPlatform() |
Colin Cross | e4246ab | 2019-02-05 21:55:21 -0800 | [diff] [blame] | 338 | } |
| 339 | |
Colin Cross | 43f08db | 2018-11-12 10:13:39 -0800 | [diff] [blame] | 340 | // Returns whether this module should have the dex file stored uncompressed in the APK. |
| 341 | func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool { |
Colin Cross | 46abdad | 2019-02-07 13:07:08 -0800 | [diff] [blame] | 342 | if Bool(a.appProperties.Use_embedded_dex) { |
| 343 | return true |
| 344 | } |
| 345 | |
Colin Cross | 53a87f5 | 2019-06-25 13:35:30 -0700 | [diff] [blame] | 346 | // Uncompress dex in APKs of privileged apps (even for unbundled builds, they may |
| 347 | // be preinstalled as prebuilts). |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 348 | if ctx.Config().UncompressPrivAppDex() && a.Privileged() { |
Nicolas Geoffray | fa6e9ec | 2019-02-12 13:12:16 +0000 | [diff] [blame] | 349 | return true |
| 350 | } |
| 351 | |
Colin Cross | 53a87f5 | 2019-06-25 13:35:30 -0700 | [diff] [blame] | 352 | if ctx.Config().UnbundledBuild() { |
| 353 | return false |
| 354 | } |
| 355 | |
Jaewoong Jung | acf18d7 | 2019-05-02 14:55:29 -0700 | [diff] [blame] | 356 | return shouldUncompressDex(ctx, &a.dexpreopter) |
Colin Cross | 5a0dcd5 | 2018-10-05 14:20:06 -0700 | [diff] [blame] | 357 | } |
| 358 | |
Jaewoong Jung | bc625cd | 2019-05-06 15:48:44 -0700 | [diff] [blame] | 359 | func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool { |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 360 | apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo) |
Jaewoong Jung | bc625cd | 2019-05-06 15:48:44 -0700 | [diff] [blame] | 361 | return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) || |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 362 | !apexInfo.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs |
Jaewoong Jung | bc625cd | 2019-05-06 15:48:44 -0700 | [diff] [blame] | 363 | } |
| 364 | |
Liz Kammer | 9f9fd02 | 2020-06-18 19:44:06 +0000 | [diff] [blame] | 365 | func generateAaptRenamePackageFlags(packageName string, renameResourcesPackage bool) []string { |
| 366 | aaptFlags := []string{"--rename-manifest-package " + packageName} |
| 367 | if renameResourcesPackage { |
| 368 | // Required to rename the package name in the resources table. |
| 369 | aaptFlags = append(aaptFlags, "--rename-resources-package "+packageName) |
| 370 | } |
| 371 | return aaptFlags |
| 372 | } |
| 373 | |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 374 | func (a *AndroidApp) OverriddenManifestPackageName() string { |
| 375 | return a.overriddenManifestPackageName |
| 376 | } |
| 377 | |
Liz Kammer | 9f9fd02 | 2020-06-18 19:44:06 +0000 | [diff] [blame] | 378 | func (a *AndroidApp) renameResourcesPackage() bool { |
| 379 | return proptools.BoolDefault(a.overridableAppProperties.Rename_resources_package, true) |
| 380 | } |
| 381 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 382 | func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) { |
David Brazdil | d25060a | 2019-02-18 18:24:16 +0000 | [diff] [blame] | 383 | a.aapt.usesNonSdkApis = Bool(a.Module.deviceProperties.Platform_apis) |
| 384 | |
Jaewoong Jung | c27ab66 | 2019-05-30 15:51:14 -0700 | [diff] [blame] | 385 | // Ask manifest_fixer to add or update the application element indicating this app has no code. |
| 386 | a.aapt.hasNoCode = !a.hasCode(ctx) |
| 387 | |
Jaewoong Jung | de4c02f | 2019-01-22 11:19:56 -0800 | [diff] [blame] | 388 | aaptLinkFlags := []string{} |
Colin Cross | 3bc7ffa | 2017-11-22 16:19:37 -0800 | [diff] [blame] | 389 | |
Jaewoong Jung | de4c02f | 2019-01-22 11:19:56 -0800 | [diff] [blame] | 390 | // Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided. |
Jaewoong Jung | 3aff578 | 2020-02-11 07:54:35 -0800 | [diff] [blame] | 391 | hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product") |
Colin Cross | e78dcd3 | 2018-04-19 15:25:19 -0700 | [diff] [blame] | 392 | if !hasProduct && len(ctx.Config().ProductAAPTCharacteristics()) > 0 { |
Jaewoong Jung | de4c02f | 2019-01-22 11:19:56 -0800 | [diff] [blame] | 393 | aaptLinkFlags = append(aaptLinkFlags, "--product", ctx.Config().ProductAAPTCharacteristics()) |
Colin Cross | e78dcd3 | 2018-04-19 15:25:19 -0700 | [diff] [blame] | 394 | } |
| 395 | |
Dan Willemsen | 72be590 | 2018-10-24 20:24:57 -0700 | [diff] [blame] | 396 | if !Bool(a.aaptProperties.Aapt_include_all_resources) { |
| 397 | // Product AAPT config |
| 398 | for _, aaptConfig := range ctx.Config().ProductAAPTConfig() { |
Jaewoong Jung | de4c02f | 2019-01-22 11:19:56 -0800 | [diff] [blame] | 399 | aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig) |
Dan Willemsen | 72be590 | 2018-10-24 20:24:57 -0700 | [diff] [blame] | 400 | } |
Colin Cross | e78dcd3 | 2018-04-19 15:25:19 -0700 | [diff] [blame] | 401 | |
Dan Willemsen | 72be590 | 2018-10-24 20:24:57 -0700 | [diff] [blame] | 402 | // Product AAPT preferred config |
| 403 | if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 { |
Jaewoong Jung | de4c02f | 2019-01-22 11:19:56 -0800 | [diff] [blame] | 404 | aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig()) |
Dan Willemsen | 72be590 | 2018-10-24 20:24:57 -0700 | [diff] [blame] | 405 | } |
Colin Cross | e78dcd3 | 2018-04-19 15:25:19 -0700 | [diff] [blame] | 406 | } |
| 407 | |
Jiyong Park | 7f67f48 | 2019-01-05 12:57:48 +0900 | [diff] [blame] | 408 | manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName()) |
Jaewoong Jung | 6f373f6 | 2019-03-13 10:13:24 -0700 | [diff] [blame] | 409 | if overridden || a.overridableAppProperties.Package_name != nil { |
| 410 | // The product override variable has a priority over the package_name property. |
| 411 | if !overridden { |
| 412 | manifestPackageName = *a.overridableAppProperties.Package_name |
| 413 | } |
Liz Kammer | 9f9fd02 | 2020-06-18 19:44:06 +0000 | [diff] [blame] | 414 | aaptLinkFlags = append(aaptLinkFlags, generateAaptRenamePackageFlags(manifestPackageName, a.renameResourcesPackage())...) |
Jiyong Park | cfaa164 | 2020-02-28 16:51:07 +0900 | [diff] [blame] | 415 | a.overriddenManifestPackageName = manifestPackageName |
Jiyong Park | 7f67f48 | 2019-01-05 12:57:48 +0900 | [diff] [blame] | 416 | } |
| 417 | |
Jaewoong Jung | 4102e5d | 2019-02-27 16:26:28 -0800 | [diff] [blame] | 418 | aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...) |
| 419 | |
Colin Cross | e560c4a | 2019-03-19 16:03:11 -0700 | [diff] [blame] | 420 | a.aapt.splitNames = a.appProperties.Package_splits |
Baligh Uddin | 5b16dfb | 2020-02-11 17:27:19 -0800 | [diff] [blame] | 421 | a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent) |
Ulya Trafimovich | b23d28c | 2020-10-08 12:53:58 +0100 | [diff] [blame] | 422 | a.aapt.buildActions(ctx, sdkContext(a), a.classLoaderContexts, aaptLinkFlags...) |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 423 | |
Colin Cross | 46c9b8b | 2017-06-22 16:51:17 -0700 | [diff] [blame] | 424 | // apps manifests are handled by aapt, don't let Module see them |
Dan Willemsen | 34cc69e | 2015-09-23 15:26:20 -0700 | [diff] [blame] | 425 | a.properties.Manifest = nil |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 426 | } |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 427 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 428 | func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) { |
Colin Cross | 89c3158 | 2018-04-30 15:55:11 -0700 | [diff] [blame] | 429 | var staticLibProguardFlagFiles android.Paths |
| 430 | ctx.VisitDirectDeps(func(m android.Module) { |
| 431 | if lib, ok := m.(AndroidLibraryDependency); ok && ctx.OtherModuleDependencyTag(m) == staticLibTag { |
| 432 | staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, lib.ExportedProguardFlagFiles()...) |
| 433 | } |
| 434 | }) |
| 435 | |
| 436 | staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles) |
| 437 | |
| 438 | a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, staticLibProguardFlagFiles...) |
| 439 | a.Module.extraProguardFlagFiles = append(a.Module.extraProguardFlagFiles, a.proguardOptionsFile) |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 440 | } |
Colin Cross | 66dbc0b | 2017-12-28 12:23:20 -0800 | [diff] [blame] | 441 | |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 442 | func (a *AndroidApp) installPath(ctx android.ModuleContext) android.InstallPath { |
Colin Cross | 43f08db | 2018-11-12 10:13:39 -0800 | [diff] [blame] | 443 | var installDir string |
| 444 | if ctx.ModuleName() == "framework-res" { |
| 445 | // framework-res.apk is installed as system/framework/framework-res.apk |
| 446 | installDir = "framework" |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 447 | } else if a.Privileged() { |
Jaewoong Jung | 9d22a91 | 2019-01-23 16:27:47 -0800 | [diff] [blame] | 448 | installDir = filepath.Join("priv-app", a.installApkName) |
Colin Cross | 43f08db | 2018-11-12 10:13:39 -0800 | [diff] [blame] | 449 | } else { |
Jaewoong Jung | 9d22a91 | 2019-01-23 16:27:47 -0800 | [diff] [blame] | 450 | installDir = filepath.Join("app", a.installApkName) |
Colin Cross | 43f08db | 2018-11-12 10:13:39 -0800 | [diff] [blame] | 451 | } |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 452 | |
| 453 | return android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk") |
| 454 | } |
| 455 | |
Ulya Trafimovich | 1855424 | 2020-11-03 15:55:11 +0000 | [diff] [blame] | 456 | func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) android.Path { |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 457 | a.dexpreopter.installPath = a.installPath(ctx) |
Ulya Trafimovich | 76b0852 | 2021-01-14 17:52:43 +0000 | [diff] [blame] | 458 | a.dexpreopter.isApp = true |
Liz Kammer | a7a64f3 | 2020-07-09 15:16:41 -0700 | [diff] [blame] | 459 | if a.dexProperties.Uncompress_dex == nil { |
David Srbecky | e033cba | 2020-05-20 22:20:28 +0100 | [diff] [blame] | 460 | // If the value was not force-set by the user, use reasonable default based on the module. |
Liz Kammer | a7a64f3 | 2020-07-09 15:16:41 -0700 | [diff] [blame] | 461 | a.dexProperties.Uncompress_dex = proptools.BoolPtr(a.shouldUncompressDex(ctx)) |
David Srbecky | e033cba | 2020-05-20 22:20:28 +0100 | [diff] [blame] | 462 | } |
Liz Kammer | a7a64f3 | 2020-07-09 15:16:41 -0700 | [diff] [blame] | 463 | a.dexpreopter.uncompressedDex = *a.dexProperties.Uncompress_dex |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 464 | a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries() |
Ulya Trafimovich | b23d28c | 2020-10-08 12:53:58 +0100 | [diff] [blame] | 465 | a.dexpreopter.classLoaderContexts = a.classLoaderContexts |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 466 | a.dexpreopter.manifestFile = a.mergedManifestFile |
| 467 | |
Colin Cross | 5ab4e6d | 2017-11-22 16:20:45 -0800 | [diff] [blame] | 468 | if ctx.ModuleName() != "framework-res" { |
| 469 | a.Module.compile(ctx, a.aaptSrcJar) |
| 470 | } |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 471 | |
Colin Cross | b014f07 | 2021-02-26 14:54:36 -0800 | [diff] [blame] | 472 | return a.dexJarFile |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 473 | } |
Colin Cross | 3bc7ffa | 2017-11-22 16:19:37 -0800 | [diff] [blame] | 474 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 475 | func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, ctx android.ModuleContext) android.WritablePath { |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 476 | var jniJarFile android.WritablePath |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 477 | if len(jniLibs) > 0 { |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 478 | a.jniLibs = jniLibs |
Jaewoong Jung | bc625cd | 2019-05-06 15:48:44 -0700 | [diff] [blame] | 479 | if a.shouldEmbedJnis(ctx) { |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 480 | jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip") |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 481 | a.installPathForJNISymbols = a.installPath(ctx).ToMakePath() |
Sasha Smundak | 6ad7725 | 2019-05-01 13:16:22 -0700 | [diff] [blame] | 482 | TransformJniLibsToJar(ctx, jniJarFile, jniLibs, a.useEmbeddedNativeLibs(ctx)) |
Jaewoong Jung | 87a33e7 | 2020-03-26 14:01:48 -0700 | [diff] [blame] | 483 | for _, jni := range jniLibs { |
| 484 | if jni.coverageFile.Valid() { |
Jaewoong Jung | 46984ee | 2020-04-07 13:07:55 -0700 | [diff] [blame] | 485 | // Only collect coverage for the first target arch if this is a multilib target. |
| 486 | // TODO(jungjw): Ideally, we want to collect both reports, but that would cause coverage |
| 487 | // data file path collisions since the current coverage file path format doesn't contain |
| 488 | // arch-related strings. This is fine for now though; the code coverage team doesn't use |
| 489 | // multi-arch targets such as test_suite_* for coverage collections yet. |
| 490 | // |
| 491 | // Work with the team to come up with a new format that handles multilib modules properly |
| 492 | // and change this. |
| 493 | if len(ctx.Config().Targets[android.Android]) == 1 || |
Jaewoong Jung | 642916f | 2020-10-09 17:25:15 -0700 | [diff] [blame] | 494 | ctx.Config().AndroidFirstDeviceTarget.Arch.ArchType == jni.target.Arch.ArchType { |
Jaewoong Jung | 46984ee | 2020-04-07 13:07:55 -0700 | [diff] [blame] | 495 | a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path()) |
| 496 | } |
Jaewoong Jung | 87a33e7 | 2020-03-26 14:01:48 -0700 | [diff] [blame] | 497 | } |
| 498 | } |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 499 | a.embeddedJniLibs = true |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 500 | } |
| 501 | } |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 502 | return jniJarFile |
| 503 | } |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 504 | |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 505 | func (a *AndroidApp) JNISymbolsInstalls(installPath string) android.RuleBuilderInstalls { |
| 506 | var jniSymbols android.RuleBuilderInstalls |
| 507 | for _, jniLib := range a.jniLibs { |
| 508 | if jniLib.unstrippedFile != nil { |
| 509 | jniSymbols = append(jniSymbols, android.RuleBuilderInstall{ |
| 510 | From: jniLib.unstrippedFile, |
| 511 | To: filepath.Join(installPath, targetToJniDir(jniLib.target), jniLib.unstrippedFile.Base()), |
| 512 | }) |
| 513 | } |
| 514 | } |
| 515 | return jniSymbols |
| 516 | } |
| 517 | |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 518 | func (a *AndroidApp) noticeBuildActions(ctx android.ModuleContext) { |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 519 | // Collect NOTICE files from all dependencies. |
| 520 | seenModules := make(map[android.Module]bool) |
| 521 | noticePathSet := make(map[android.Path]bool) |
| 522 | |
| 523 | ctx.WalkDeps(func(child android.Module, parent android.Module) bool { |
| 524 | // Have we already seen this? |
| 525 | if _, ok := seenModules[child]; ok { |
| 526 | return false |
| 527 | } |
| 528 | seenModules[child] = true |
| 529 | |
| 530 | // Skip host modules. |
Jiyong Park | 1613e55 | 2020-09-14 19:43:17 +0900 | [diff] [blame] | 531 | if child.Target().Os.Class == android.Host { |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 532 | return false |
| 533 | } |
| 534 | |
Bob Badour | a75b057 | 2020-02-18 20:21:55 -0800 | [diff] [blame] | 535 | paths := child.(android.Module).NoticeFiles() |
| 536 | if len(paths) > 0 { |
| 537 | for _, path := range paths { |
| 538 | noticePathSet[path] = true |
| 539 | } |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 540 | } |
| 541 | return true |
| 542 | }) |
| 543 | |
| 544 | // If the app has one, add it too. |
Bob Badour | a75b057 | 2020-02-18 20:21:55 -0800 | [diff] [blame] | 545 | if len(a.NoticeFiles()) > 0 { |
| 546 | for _, path := range a.NoticeFiles() { |
| 547 | noticePathSet[path] = true |
| 548 | } |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 549 | } |
| 550 | |
| 551 | if len(noticePathSet) == 0 { |
Jaewoong Jung | 9877279 | 2019-07-01 17:15:13 -0700 | [diff] [blame] | 552 | return |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 553 | } |
| 554 | var noticePaths []android.Path |
| 555 | for path := range noticePathSet { |
| 556 | noticePaths = append(noticePaths, path) |
| 557 | } |
| 558 | sort.Slice(noticePaths, func(i, j int) bool { |
| 559 | return noticePaths[i].String() < noticePaths[j].String() |
| 560 | }) |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 561 | |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 562 | a.noticeOutputs = android.BuildNoticeOutput(ctx, a.installDir, a.installApkName+".apk", noticePaths) |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 563 | } |
| 564 | |
Jaewoong Jung | ccbb393 | 2019-04-15 09:48:31 -0700 | [diff] [blame] | 565 | // Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it |
| 566 | // isn't a cert module reference. Also checks and enforces system cert restriction if applicable. |
| 567 | func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate, ctx android.ModuleContext) []Certificate { |
| 568 | if android.SrcIsModule(certPropValue) == "" { |
| 569 | var mainCert Certificate |
| 570 | if certPropValue != "" { |
| 571 | defaultDir := ctx.Config().DefaultAppCertificateDir(ctx) |
| 572 | mainCert = Certificate{ |
Colin Cross | 503c1d0 | 2020-01-28 14:00:53 -0800 | [diff] [blame] | 573 | Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"), |
| 574 | Key: defaultDir.Join(ctx, certPropValue+".pk8"), |
Jaewoong Jung | ccbb393 | 2019-04-15 09:48:31 -0700 | [diff] [blame] | 575 | } |
| 576 | } else { |
| 577 | pem, key := ctx.Config().DefaultAppCertificate(ctx) |
Colin Cross | 503c1d0 | 2020-01-28 14:00:53 -0800 | [diff] [blame] | 578 | mainCert = Certificate{ |
| 579 | Pem: pem, |
| 580 | Key: key, |
| 581 | } |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 582 | } |
Jaewoong Jung | ccbb393 | 2019-04-15 09:48:31 -0700 | [diff] [blame] | 583 | certificates = append([]Certificate{mainCert}, certificates...) |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 584 | } |
| 585 | |
Jaewoong Jung | ccbb393 | 2019-04-15 09:48:31 -0700 | [diff] [blame] | 586 | if !m.Platform() { |
| 587 | certPath := certificates[0].Pem.String() |
Jeongik Cha | c946414 | 2019-01-07 12:07:27 +0900 | [diff] [blame] | 588 | systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String() |
| 589 | if strings.HasPrefix(certPath, systemCertPath) { |
| 590 | enforceSystemCert := ctx.Config().EnforceSystemCertificate() |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 591 | allowed := ctx.Config().EnforceSystemCertificateAllowList() |
Jeongik Cha | c946414 | 2019-01-07 12:07:27 +0900 | [diff] [blame] | 592 | |
Colin Cross | 440e0d0 | 2020-06-11 11:32:11 -0700 | [diff] [blame] | 593 | if enforceSystemCert && !inList(m.Name(), allowed) { |
Jeongik Cha | c946414 | 2019-01-07 12:07:27 +0900 | [diff] [blame] | 594 | ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.") |
| 595 | } |
| 596 | } |
| 597 | } |
| 598 | |
Jaewoong Jung | ccbb393 | 2019-04-15 09:48:31 -0700 | [diff] [blame] | 599 | return certificates |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 600 | } |
| 601 | |
Jooyung Han | 39ee119 | 2020-03-23 20:21:11 +0900 | [diff] [blame] | 602 | func (a *AndroidApp) InstallApkName() string { |
| 603 | return a.installApkName |
| 604 | } |
| 605 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 606 | func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) { |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 607 | var apkDeps android.Paths |
| 608 | |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 609 | if !ctx.Provider(android.ApexInfoProvider).(android.ApexInfo).IsForPlatform() { |
| 610 | a.hideApexVariantFromMake = true |
| 611 | } |
| 612 | |
Jeongik Cha | 538c0d0 | 2019-07-11 15:54:27 +0900 | [diff] [blame] | 613 | a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx) |
| 614 | a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex) |
| 615 | |
Jaewoong Jung | 9d22a91 | 2019-01-23 16:27:47 -0800 | [diff] [blame] | 616 | // Check if the install APK name needs to be overridden. |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 617 | a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(a.Name()) |
Jaewoong Jung | 9d22a91 | 2019-01-23 16:27:47 -0800 | [diff] [blame] | 618 | |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 619 | if ctx.ModuleName() == "framework-res" { |
| 620 | // framework-res.apk is installed as system/framework/framework-res.apk |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 621 | a.installDir = android.PathForModuleInstall(ctx, "framework") |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 622 | } else if a.Privileged() { |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 623 | a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName) |
| 624 | } else if ctx.InstallInTestcases() { |
Jaewoong Jung | 326a941 | 2019-11-21 10:41:00 -0800 | [diff] [blame] | 625 | a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch()) |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 626 | } else { |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 627 | a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName) |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 628 | } |
Jaewoong Jung | 7dd4ae2 | 2019-09-27 17:13:15 -0700 | [diff] [blame] | 629 | a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir) |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 630 | |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 631 | a.noticeBuildActions(ctx) |
Jaewoong Jung | 9877279 | 2019-07-01 17:15:13 -0700 | [diff] [blame] | 632 | if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") { |
| 633 | a.aapt.noticeFile = a.noticeOutputs.HtmlGzOutput |
| 634 | } |
Jaewoong Jung | 5b425e2 | 2019-06-17 17:40:56 -0700 | [diff] [blame] | 635 | |
Ulya Trafimovich | b23d28c | 2020-10-08 12:53:58 +0100 | [diff] [blame] | 636 | a.classLoaderContexts = a.usesLibrary.classLoaderContextForUsesLibDeps(ctx) |
Ulya Trafimovich | 1855424 | 2020-11-03 15:55:11 +0000 | [diff] [blame] | 637 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 638 | // Process all building blocks, from AAPT to certificates. |
| 639 | a.aaptBuildActions(ctx) |
| 640 | |
Ulya Trafimovich | fc24ad3 | 2020-08-19 16:32:54 +0100 | [diff] [blame] | 641 | // The decision to enforce <uses-library> checks is made before adding implicit SDK libraries. |
| 642 | a.usesLibrary.freezeEnforceUsesLibraries() |
| 643 | |
| 644 | // Add implicit SDK libraries to <uses-library> list. |
Ulya Trafimovich | b23d28c | 2020-10-08 12:53:58 +0100 | [diff] [blame] | 645 | for _, usesLib := range a.classLoaderContexts.UsesLibs() { |
Ulya Trafimovich | 663dc53 | 2020-09-10 12:48:53 +0100 | [diff] [blame] | 646 | a.usesLibrary.addLib(usesLib, inList(usesLib, dexpreopt.OptionalCompatUsesLibs)) |
Ulya Trafimovich | fc24ad3 | 2020-08-19 16:32:54 +0100 | [diff] [blame] | 647 | } |
| 648 | |
| 649 | // Check that the <uses-library> list is coherent with the manifest. |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 650 | if a.usesLibrary.enforceUsesLibraries() { |
| 651 | manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(ctx, a.mergedManifestFile) |
| 652 | apkDeps = append(apkDeps, manifestCheckFile) |
| 653 | } |
| 654 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 655 | a.proguardBuildActions(ctx) |
| 656 | |
Colin Cross | 014489c | 2020-06-02 20:09:13 -0700 | [diff] [blame] | 657 | a.linter.mergedManifest = a.aapt.mergedManifestFile |
| 658 | a.linter.manifest = a.aapt.manifestPath |
| 659 | a.linter.resources = a.aapt.resourceFiles |
Colin Cross | c0efd1d | 2020-07-03 11:56:24 -0700 | [diff] [blame] | 660 | a.linter.buildModuleReportZip = ctx.Config().UnbundledBuildApps() |
Colin Cross | 014489c | 2020-06-02 20:09:13 -0700 | [diff] [blame] | 661 | |
Ulya Trafimovich | 1855424 | 2020-11-03 15:55:11 +0000 | [diff] [blame] | 662 | dexJarFile := a.dexBuildActions(ctx) |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 663 | |
Colin Cross | c2d2405 | 2020-05-13 11:05:02 -0700 | [diff] [blame] | 664 | jniLibs, certificateDeps := collectAppDeps(ctx, a, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis)) |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 665 | jniJarFile := a.jniBuildActions(jniLibs, ctx) |
| 666 | |
| 667 | if ctx.Failed() { |
| 668 | return |
| 669 | } |
| 670 | |
Jaewoong Jung | ccbb393 | 2019-04-15 09:48:31 -0700 | [diff] [blame] | 671 | certificates := processMainCert(a.ModuleBase, a.getCertString(ctx), certificateDeps, ctx) |
| 672 | a.certificate = certificates[0] |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 673 | |
| 674 | // Build a final signed app package. |
Jaewoong Jung | 5a49881 | 2019-11-07 14:14:38 -0800 | [diff] [blame] | 675 | packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk") |
Songchun Fan | 17d69e3 | 2020-03-24 20:32:24 -0700 | [diff] [blame] | 676 | v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature) |
| 677 | var v4SignatureFile android.WritablePath = nil |
| 678 | if v4SigningRequested { |
| 679 | v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig") |
| 680 | } |
Liz Kammer | e2b27f4 | 2020-05-07 13:24:05 -0700 | [diff] [blame] | 681 | var lineageFile android.Path |
| 682 | if lineage := String(a.overridableAppProperties.Lineage); lineage != "" { |
| 683 | lineageFile = android.PathForModuleSrc(ctx, lineage) |
| 684 | } |
Liz Kammer | 70dd74d | 2020-05-07 13:24:05 -0700 | [diff] [blame] | 685 | CreateAndSignAppPackage(ctx, packageFile, a.exportPackage, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile, lineageFile) |
Colin Cross | 3bc7ffa | 2017-11-22 16:19:37 -0800 | [diff] [blame] | 686 | a.outputFile = packageFile |
Songchun Fan | 17d69e3 | 2020-03-24 20:32:24 -0700 | [diff] [blame] | 687 | if v4SigningRequested { |
| 688 | a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile) |
| 689 | } |
Colin Cross | 3bc7ffa | 2017-11-22 16:19:37 -0800 | [diff] [blame] | 690 | |
Colin Cross | e560c4a | 2019-03-19 16:03:11 -0700 | [diff] [blame] | 691 | for _, split := range a.aapt.splits { |
| 692 | // Sign the split APKs |
Jaewoong Jung | 5a49881 | 2019-11-07 14:14:38 -0800 | [diff] [blame] | 693 | packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk") |
Songchun Fan | 17d69e3 | 2020-03-24 20:32:24 -0700 | [diff] [blame] | 694 | if v4SigningRequested { |
| 695 | v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig") |
| 696 | } |
Liz Kammer | 70dd74d | 2020-05-07 13:24:05 -0700 | [diff] [blame] | 697 | CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile, lineageFile) |
Colin Cross | e560c4a | 2019-03-19 16:03:11 -0700 | [diff] [blame] | 698 | a.extraOutputFiles = append(a.extraOutputFiles, packageFile) |
Songchun Fan | 17d69e3 | 2020-03-24 20:32:24 -0700 | [diff] [blame] | 699 | if v4SigningRequested { |
| 700 | a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile) |
| 701 | } |
Colin Cross | e560c4a | 2019-03-19 16:03:11 -0700 | [diff] [blame] | 702 | } |
| 703 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 704 | // Build an app bundle. |
Colin Cross | f623721 | 2018-10-29 23:14:58 -0700 | [diff] [blame] | 705 | bundleFile := android.PathForModuleOut(ctx, "base.zip") |
| 706 | BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile) |
| 707 | a.bundleFile = bundleFile |
| 708 | |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 709 | apexInfo := ctx.Provider(android.ApexInfoProvider).(android.ApexInfo) |
| 710 | |
Jaewoong Jung | 590b1ae | 2019-01-22 16:40:58 -0800 | [diff] [blame] | 711 | // Install the app package. |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 712 | if (Bool(a.Module.properties.Installable) || ctx.Host()) && apexInfo.IsForPlatform() { |
Jiyong Park | 8ba50f9 | 2019-11-13 15:01:01 +0900 | [diff] [blame] | 713 | ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile) |
| 714 | for _, extra := range a.extraOutputFiles { |
| 715 | ctx.InstallFile(a.installDir, extra.Base(), extra) |
| 716 | } |
Colin Cross | 5ab4e6d | 2017-11-22 16:20:45 -0800 | [diff] [blame] | 717 | } |
Artur Satayev | 1111b84 | 2020-04-27 19:05:28 +0100 | [diff] [blame] | 718 | |
| 719 | a.buildAppDependencyInfo(ctx) |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 720 | } |
| 721 | |
Colin Cross | c2d2405 | 2020-05-13 11:05:02 -0700 | [diff] [blame] | 722 | type appDepsInterface interface { |
| 723 | sdkVersion() sdkSpec |
| 724 | minSdkVersion() sdkSpec |
| 725 | RequiresStableAPIs(ctx android.BaseModuleContext) bool |
| 726 | } |
| 727 | |
| 728 | func collectAppDeps(ctx android.ModuleContext, app appDepsInterface, |
| 729 | shouldCollectRecursiveNativeDeps bool, |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 730 | checkNativeSdkVersion bool) ([]jniLib, []Certificate) { |
Colin Cross | c2d2405 | 2020-05-13 11:05:02 -0700 | [diff] [blame] | 731 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 732 | var jniLibs []jniLib |
Jiyong Park | c00cbd9 | 2018-10-30 21:20:05 +0900 | [diff] [blame] | 733 | var certificates []Certificate |
Peter Collingbourne | ad84f97 | 2019-12-17 16:46:18 -0800 | [diff] [blame] | 734 | seenModulePaths := make(map[string]bool) |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 735 | |
Colin Cross | c2d2405 | 2020-05-13 11:05:02 -0700 | [diff] [blame] | 736 | if checkNativeSdkVersion { |
| 737 | checkNativeSdkVersion = app.sdkVersion().specified() && |
| 738 | app.sdkVersion().kind != sdkCorePlatform && !app.RequiresStableAPIs(ctx) |
| 739 | } |
| 740 | |
Peter Collingbourne | ad84f97 | 2019-12-17 16:46:18 -0800 | [diff] [blame] | 741 | ctx.WalkDeps(func(module android.Module, parent android.Module) bool { |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 742 | otherName := ctx.OtherModuleName(module) |
| 743 | tag := ctx.OtherModuleDependencyTag(module) |
| 744 | |
Colin Cross | f0913fb | 2020-07-29 12:59:39 -0700 | [diff] [blame] | 745 | if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) { |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 746 | if dep, ok := module.(*cc.Module); ok { |
Colin Cross | 95f1ca0 | 2020-10-29 20:47:22 -0700 | [diff] [blame] | 747 | if dep.IsNdk(ctx.Config()) || dep.IsStubs() { |
Peter Collingbourne | ad84f97 | 2019-12-17 16:46:18 -0800 | [diff] [blame] | 748 | return false |
| 749 | } |
| 750 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 751 | lib := dep.OutputFile() |
Peter Collingbourne | ad84f97 | 2019-12-17 16:46:18 -0800 | [diff] [blame] | 752 | path := lib.Path() |
| 753 | if seenModulePaths[path.String()] { |
| 754 | return false |
| 755 | } |
| 756 | seenModulePaths[path.String()] = true |
| 757 | |
Colin Cross | c2d2405 | 2020-05-13 11:05:02 -0700 | [diff] [blame] | 758 | if checkNativeSdkVersion && dep.SdkVersion() == "" { |
| 759 | ctx.PropertyErrorf("jni_libs", "JNI dependency %q uses platform APIs, but this module does not", |
| 760 | otherName) |
Colin Cross | 094cde4 | 2020-02-15 10:38:00 -0800 | [diff] [blame] | 761 | } |
| 762 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 763 | if lib.Valid() { |
| 764 | jniLibs = append(jniLibs, jniLib{ |
Colin Cross | 403cc15 | 2020-07-06 14:15:24 -0700 | [diff] [blame] | 765 | name: ctx.OtherModuleName(module), |
| 766 | path: path, |
| 767 | target: module.Target(), |
| 768 | coverageFile: dep.CoverageOutputFile(), |
| 769 | unstrippedFile: dep.UnstrippedOutputFile(), |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 770 | }) |
| 771 | } else { |
| 772 | ctx.ModuleErrorf("dependency %q missing output file", otherName) |
| 773 | } |
| 774 | } else { |
| 775 | ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName) |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 776 | } |
Peter Collingbourne | ad84f97 | 2019-12-17 16:46:18 -0800 | [diff] [blame] | 777 | |
| 778 | return shouldCollectRecursiveNativeDeps |
| 779 | } |
| 780 | |
| 781 | if tag == certificateTag { |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 782 | if dep, ok := module.(*AndroidAppCertificate); ok { |
Jiyong Park | c00cbd9 | 2018-10-30 21:20:05 +0900 | [diff] [blame] | 783 | certificates = append(certificates, dep.Certificate) |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 784 | } else { |
| 785 | ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName) |
| 786 | } |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 787 | } |
Peter Collingbourne | ad84f97 | 2019-12-17 16:46:18 -0800 | [diff] [blame] | 788 | |
| 789 | return false |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 790 | }) |
| 791 | |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 792 | return jniLibs, certificates |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 793 | } |
| 794 | |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 795 | func (a *AndroidApp) WalkPayloadDeps(ctx android.ModuleContext, do android.PayloadDepsCallback) { |
Artur Satayev | 1111b84 | 2020-04-27 19:05:28 +0100 | [diff] [blame] | 796 | ctx.WalkDeps(func(child, parent android.Module) bool { |
| 797 | isExternal := !a.DepIsInSameApex(ctx, child) |
| 798 | if am, ok := child.(android.ApexModule); ok { |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 799 | if !do(ctx, parent, am, isExternal) { |
| 800 | return false |
| 801 | } |
Artur Satayev | 1111b84 | 2020-04-27 19:05:28 +0100 | [diff] [blame] | 802 | } |
| 803 | return !isExternal |
| 804 | }) |
| 805 | } |
| 806 | |
| 807 | func (a *AndroidApp) buildAppDependencyInfo(ctx android.ModuleContext) { |
| 808 | if ctx.Host() { |
| 809 | return |
| 810 | } |
| 811 | |
| 812 | depsInfo := android.DepNameToDepInfoMap{} |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 813 | a.WalkPayloadDeps(ctx, func(ctx android.ModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool { |
Artur Satayev | 1111b84 | 2020-04-27 19:05:28 +0100 | [diff] [blame] | 814 | depName := to.Name() |
Artur Satayev | 533b98c | 2021-03-11 18:03:42 +0000 | [diff] [blame^] | 815 | |
| 816 | // Skip dependencies that are only available to APEXes; they are developed with updatability |
| 817 | // in mind and don't need manual approval. |
| 818 | if to.(android.ApexModule).NotAvailableForPlatform() { |
| 819 | return true |
| 820 | } |
| 821 | |
Artur Satayev | 1111b84 | 2020-04-27 19:05:28 +0100 | [diff] [blame] | 822 | if info, exist := depsInfo[depName]; exist { |
| 823 | info.From = append(info.From, from.Name()) |
| 824 | info.IsExternal = info.IsExternal && externalDep |
| 825 | depsInfo[depName] = info |
| 826 | } else { |
| 827 | toMinSdkVersion := "(no version)" |
| 828 | if m, ok := to.(interface{ MinSdkVersion() string }); ok { |
| 829 | if v := m.MinSdkVersion(); v != "" { |
| 830 | toMinSdkVersion = v |
| 831 | } |
| 832 | } |
| 833 | depsInfo[depName] = android.ApexModuleDepInfo{ |
| 834 | To: depName, |
| 835 | From: []string{from.Name()}, |
| 836 | IsExternal: externalDep, |
| 837 | MinSdkVersion: toMinSdkVersion, |
| 838 | } |
| 839 | } |
Jooyung Han | 749dc69 | 2020-04-15 11:03:39 +0900 | [diff] [blame] | 840 | return true |
Artur Satayev | 1111b84 | 2020-04-27 19:05:28 +0100 | [diff] [blame] | 841 | }) |
| 842 | |
| 843 | a.ApexBundleDepsInfo.BuildDepsInfoLists(ctx, a.MinSdkVersion(), depsInfo) |
| 844 | } |
| 845 | |
Artur Satayev | 849f844 | 2020-04-28 14:57:42 +0100 | [diff] [blame] | 846 | func (a *AndroidApp) Updatable() bool { |
Colin Cross | 56a8321 | 2020-09-15 18:30:11 -0700 | [diff] [blame] | 847 | return Bool(a.appProperties.Updatable) |
Artur Satayev | 849f844 | 2020-04-28 14:57:42 +0100 | [diff] [blame] | 848 | } |
| 849 | |
Colin Cross | 0ea8ba8 | 2019-06-06 14:33:29 -0700 | [diff] [blame] | 850 | func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string { |
Jaewoong Jung | 2ad817c | 2019-01-18 14:27:16 -0800 | [diff] [blame] | 851 | certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName()) |
| 852 | if overridden { |
Jaewoong Jung | acb6db3 | 2019-02-28 16:22:30 +0000 | [diff] [blame] | 853 | return ":" + certificate |
Jaewoong Jung | 2ad817c | 2019-01-18 14:27:16 -0800 | [diff] [blame] | 854 | } |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 855 | return String(a.overridableAppProperties.Certificate) |
Jaewoong Jung | 2ad817c | 2019-01-18 14:27:16 -0800 | [diff] [blame] | 856 | } |
| 857 | |
Jiyong Park | 0f80c18 | 2020-01-31 02:49:53 +0900 | [diff] [blame] | 858 | func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool { |
| 859 | if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) { |
| 860 | return true |
| 861 | } |
| 862 | return a.Library.DepIsInSameApex(ctx, dep) |
| 863 | } |
| 864 | |
Jiyong Park | b7c639e | 2019-08-19 14:56:02 +0900 | [diff] [blame] | 865 | // For OutputFileProducer interface |
| 866 | func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) { |
| 867 | switch tag { |
| 868 | case ".aapt.srcjar": |
| 869 | return []android.Path{a.aaptSrcJar}, nil |
Anton Hansson | 092aca4 | 2020-08-13 19:37:22 +0100 | [diff] [blame] | 870 | case ".export-package.apk": |
| 871 | return []android.Path{a.exportPackage}, nil |
Jiyong Park | b7c639e | 2019-08-19 14:56:02 +0900 | [diff] [blame] | 872 | } |
| 873 | return a.Library.OutputFiles(tag) |
| 874 | } |
| 875 | |
Jiyong Park | f748731 | 2019-10-17 12:54:30 +0900 | [diff] [blame] | 876 | func (a *AndroidApp) Privileged() bool { |
| 877 | return Bool(a.appProperties.Privileged) |
| 878 | } |
| 879 | |
Jaewoong Jung | 87a33e7 | 2020-03-26 14:01:48 -0700 | [diff] [blame] | 880 | func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.BaseModuleContext) bool { |
Colin Cross | 1a6acd4 | 2020-06-16 17:51:46 -0700 | [diff] [blame] | 881 | return ctx.Device() && ctx.DeviceConfig().NativeCoverageEnabled() |
Jaewoong Jung | 87a33e7 | 2020-03-26 14:01:48 -0700 | [diff] [blame] | 882 | } |
| 883 | |
| 884 | func (a *AndroidApp) PreventInstall() { |
| 885 | a.appProperties.PreventInstall = true |
| 886 | } |
| 887 | |
| 888 | func (a *AndroidApp) HideFromMake() { |
| 889 | a.appProperties.HideFromMake = true |
| 890 | } |
| 891 | |
| 892 | func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) { |
| 893 | a.appProperties.IsCoverageVariant = coverage |
| 894 | } |
| 895 | |
Ivan Lozano | a0cd8f9 | 2020-04-09 09:56:02 -0400 | [diff] [blame] | 896 | func (a *AndroidApp) EnableCoverageIfNeeded() {} |
| 897 | |
Jaewoong Jung | 87a33e7 | 2020-03-26 14:01:48 -0700 | [diff] [blame] | 898 | var _ cc.Coverage = (*AndroidApp)(nil) |
| 899 | |
Colin Cross | 1b16b0e | 2019-02-12 14:41:32 -0800 | [diff] [blame] | 900 | // android_app compiles sources and Android resources into an Android application package `.apk` file. |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 901 | func AndroidAppFactory() android.Module { |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 902 | module := &AndroidApp{} |
| 903 | |
Liz Kammer | a7a64f3 | 2020-07-09 15:16:41 -0700 | [diff] [blame] | 904 | module.Module.dexProperties.Optimize.EnabledByDefault = true |
| 905 | module.Module.dexProperties.Optimize.Shrink = proptools.BoolPtr(true) |
Colin Cross | 66dbc0b | 2017-12-28 12:23:20 -0800 | [diff] [blame] | 906 | |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 907 | module.Module.properties.Instrument = true |
Colin Cross | 9ae1b92 | 2018-06-26 17:59:05 -0700 | [diff] [blame] | 908 | module.Module.properties.Installable = proptools.BoolPtr(true) |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 909 | |
Colin Cross | ce6734e | 2020-06-15 16:09:53 -0700 | [diff] [blame] | 910 | module.addHostAndDeviceProperties() |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 911 | module.AddProperties( |
Colin Cross | a97c5d3 | 2018-03-28 14:58:31 -0700 | [diff] [blame] | 912 | &module.aaptProperties, |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 913 | &module.appProperties, |
Ulya Trafimovich | 21a7375 | 2020-09-01 17:33:48 +0100 | [diff] [blame] | 914 | &module.overridableAppProperties) |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 915 | |
Ulya Trafimovich | 22890c4 | 2021-01-05 12:04:17 +0000 | [diff] [blame] | 916 | module.usesLibrary.enforce = true |
| 917 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 918 | android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon) |
| 919 | android.InitDefaultableModule(module) |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 920 | android.InitOverridableModule(module, &module.appProperties.Overrides) |
Jiyong Park | 52cd06f | 2019-11-11 10:14:32 +0900 | [diff] [blame] | 921 | android.InitApexModule(module) |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 922 | |
Colin Cross | 3624285 | 2017-06-23 15:06:31 -0700 | [diff] [blame] | 923 | return module |
Colin Cross | 30e076a | 2015-04-13 13:58:27 -0700 | [diff] [blame] | 924 | } |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 925 | |
| 926 | type appTestProperties struct { |
Liz Kammer | 6b0c552 | 2020-04-28 16:10:55 -0700 | [diff] [blame] | 927 | // The name of the android_app module that the tests will run against. |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 928 | Instrumentation_for *string |
Jaewoong Jung | 26dedd3 | 2019-06-06 08:45:58 -0700 | [diff] [blame] | 929 | |
| 930 | // if specified, the instrumentation target package name in the manifest is overwritten by it. |
| 931 | Instrumentation_target_package *string |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 932 | } |
| 933 | |
| 934 | type AndroidTest struct { |
| 935 | AndroidApp |
| 936 | |
| 937 | appTestProperties appTestProperties |
| 938 | |
| 939 | testProperties testProperties |
Colin Cross | 303e21f | 2018-08-07 16:49:25 -0700 | [diff] [blame] | 940 | |
Dan Shi | 95d1942 | 2020-08-15 12:24:26 -0700 | [diff] [blame] | 941 | testConfig android.Path |
| 942 | extraTestConfigs android.Paths |
| 943 | data android.Paths |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 944 | } |
| 945 | |
Jaewoong Jung | 0949f31 | 2019-09-11 10:25:18 -0700 | [diff] [blame] | 946 | func (a *AndroidTest) InstallInTestcases() bool { |
| 947 | return true |
| 948 | } |
| 949 | |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 950 | func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
easoncylee | 5bcff5d | 2020-04-30 14:57:06 +0800 | [diff] [blame] | 951 | var configs []tradefed.Config |
Jaewoong Jung | 26dedd3 | 2019-06-06 08:45:58 -0700 | [diff] [blame] | 952 | if a.appTestProperties.Instrumentation_target_package != nil { |
| 953 | a.additionalAaptFlags = append(a.additionalAaptFlags, |
| 954 | "--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package) |
| 955 | } else if a.appTestProperties.Instrumentation_for != nil { |
| 956 | // Check if the instrumentation target package is overridden. |
Jaewoong Jung | 4102e5d | 2019-02-27 16:26:28 -0800 | [diff] [blame] | 957 | manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for) |
| 958 | if overridden { |
| 959 | a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName) |
| 960 | } |
| 961 | } |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 962 | a.generateAndroidBuildActions(ctx) |
Colin Cross | 303e21f | 2018-08-07 16:49:25 -0700 | [diff] [blame] | 963 | |
easoncylee | 5bcff5d | 2020-04-30 14:57:06 +0800 | [diff] [blame] | 964 | for _, module := range a.testProperties.Test_mainline_modules { |
| 965 | configs = append(configs, tradefed.Option{Name: "config-descriptor:metadata", Key: "mainline-param", Value: module}) |
| 966 | } |
| 967 | |
Jaewoong Jung | 3998234 | 2020-01-14 10:27:18 -0800 | [diff] [blame] | 968 | testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config, |
easoncylee | 5bcff5d | 2020-04-30 14:57:06 +0800 | [diff] [blame] | 969 | a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config, configs) |
Jaewoong Jung | 3998234 | 2020-01-14 10:27:18 -0800 | [diff] [blame] | 970 | a.testConfig = a.FixTestConfig(ctx, testConfig) |
Dan Shi | 95d1942 | 2020-08-15 12:24:26 -0700 | [diff] [blame] | 971 | a.extraTestConfigs = android.PathsForModuleSrc(ctx, a.testProperties.Test_options.Extra_test_configs) |
Colin Cross | 8a49795 | 2019-03-05 22:25:09 -0800 | [diff] [blame] | 972 | a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data) |
Colin Cross | 303e21f | 2018-08-07 16:49:25 -0700 | [diff] [blame] | 973 | } |
| 974 | |
Jaewoong Jung | 3998234 | 2020-01-14 10:27:18 -0800 | [diff] [blame] | 975 | func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path { |
| 976 | if testConfig == nil { |
| 977 | return nil |
| 978 | } |
| 979 | |
| 980 | fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml") |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 981 | rule := android.NewRuleBuilder(pctx, ctx) |
| 982 | command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig) |
Jaewoong Jung | 3998234 | 2020-01-14 10:27:18 -0800 | [diff] [blame] | 983 | fixNeeded := false |
| 984 | |
| 985 | if ctx.ModuleName() != a.installApkName { |
| 986 | fixNeeded = true |
| 987 | command.FlagWithArg("--test-file-name ", a.installApkName+".apk") |
| 988 | } |
| 989 | |
| 990 | if a.overridableAppProperties.Package_name != nil { |
| 991 | fixNeeded = true |
| 992 | command.FlagWithInput("--manifest ", a.manifestPath). |
| 993 | FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name) |
| 994 | } |
| 995 | |
| 996 | if fixNeeded { |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 997 | rule.Build("fix_test_config", "fix test config") |
Jaewoong Jung | 3998234 | 2020-01-14 10:27:18 -0800 | [diff] [blame] | 998 | return fixedConfig |
| 999 | } |
| 1000 | return testConfig |
| 1001 | } |
| 1002 | |
Colin Cross | 303e21f | 2018-08-07 16:49:25 -0700 | [diff] [blame] | 1003 | func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) { |
Colin Cross | 303e21f | 2018-08-07 16:49:25 -0700 | [diff] [blame] | 1004 | a.AndroidApp.DepsMutator(ctx) |
Jaewoong Jung | 26dedd3 | 2019-06-06 08:45:58 -0700 | [diff] [blame] | 1005 | } |
| 1006 | |
| 1007 | func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) { |
| 1008 | a.AndroidApp.OverridablePropertiesDepsMutator(ctx) |
Colin Cross | 4b964c0 | 2018-10-15 16:18:06 -0700 | [diff] [blame] | 1009 | if a.appTestProperties.Instrumentation_for != nil { |
| 1010 | // The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac, |
| 1011 | // but not added to the aapt2 link includes like a normal android_app or android_library dependency, so |
| 1012 | // use instrumentationForTag instead of libTag. |
| 1013 | ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for)) |
| 1014 | } |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 1015 | } |
| 1016 | |
Colin Cross | 1b16b0e | 2019-02-12 14:41:32 -0800 | [diff] [blame] | 1017 | // android_test compiles test sources and Android resources into an Android application package `.apk` file and |
| 1018 | // creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file. |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 1019 | func AndroidTestFactory() android.Module { |
| 1020 | module := &AndroidTest{} |
| 1021 | |
Liz Kammer | a7a64f3 | 2020-07-09 15:16:41 -0700 | [diff] [blame] | 1022 | module.Module.dexProperties.Optimize.EnabledByDefault = true |
Colin Cross | 5067db9 | 2018-09-17 16:46:35 -0700 | [diff] [blame] | 1023 | |
| 1024 | module.Module.properties.Instrument = true |
Colin Cross | 9ae1b92 | 2018-06-26 17:59:05 -0700 | [diff] [blame] | 1025 | module.Module.properties.Installable = proptools.BoolPtr(true) |
Colin Cross | e4246ab | 2019-02-05 21:55:21 -0800 | [diff] [blame] | 1026 | module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true) |
Colin Cross | 47fa9d3 | 2019-03-26 10:51:39 -0700 | [diff] [blame] | 1027 | module.appProperties.AlwaysPackageNativeLibs = true |
Colin Cross | 43f08db | 2018-11-12 10:13:39 -0800 | [diff] [blame] | 1028 | module.Module.dexpreopter.isTest = true |
Colin Cross | 014489c | 2020-06-02 20:09:13 -0700 | [diff] [blame] | 1029 | module.Module.linter.test = true |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 1030 | |
Colin Cross | ce6734e | 2020-06-15 16:09:53 -0700 | [diff] [blame] | 1031 | module.addHostAndDeviceProperties() |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 1032 | module.AddProperties( |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 1033 | &module.aaptProperties, |
| 1034 | &module.appProperties, |
Dan Willemsen | f5531d2 | 2018-07-16 17:21:19 -0700 | [diff] [blame] | 1035 | &module.appTestProperties, |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 1036 | &module.overridableAppProperties, |
Dan Willemsen | f5531d2 | 2018-07-16 17:21:19 -0700 | [diff] [blame] | 1037 | &module.testProperties) |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 1038 | |
Colin Cross | a4f0881 | 2018-10-02 22:03:40 -0700 | [diff] [blame] | 1039 | android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon) |
| 1040 | android.InitDefaultableModule(module) |
Jaewoong Jung | 26dedd3 | 2019-06-06 08:45:58 -0700 | [diff] [blame] | 1041 | android.InitOverridableModule(module, &module.appProperties.Overrides) |
Colin Cross | ae5caf5 | 2018-05-22 11:11:52 -0700 | [diff] [blame] | 1042 | return module |
| 1043 | } |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 1044 | |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1045 | type appTestHelperAppProperties struct { |
| 1046 | // list of compatibility suites (for example "cts", "vts") that the module should be |
| 1047 | // installed into. |
| 1048 | Test_suites []string `android:"arch_variant"` |
Dan Shi | 6ffaaa8 | 2019-09-26 11:41:36 -0700 | [diff] [blame] | 1049 | |
| 1050 | // Flag to indicate whether or not to create test config automatically. If AndroidTest.xml |
| 1051 | // doesn't exist next to the Android.bp, this attribute doesn't need to be set to true |
| 1052 | // explicitly. |
| 1053 | Auto_gen_config *bool |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1054 | } |
| 1055 | |
| 1056 | type AndroidTestHelperApp struct { |
| 1057 | AndroidApp |
| 1058 | |
| 1059 | appTestHelperAppProperties appTestHelperAppProperties |
| 1060 | } |
| 1061 | |
Jaewoong Jung | 326a941 | 2019-11-21 10:41:00 -0800 | [diff] [blame] | 1062 | func (a *AndroidTestHelperApp) InstallInTestcases() bool { |
| 1063 | return true |
| 1064 | } |
| 1065 | |
Colin Cross | 1b16b0e | 2019-02-12 14:41:32 -0800 | [diff] [blame] | 1066 | // android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that |
| 1067 | // will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a |
| 1068 | // test. |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1069 | func AndroidTestHelperAppFactory() android.Module { |
| 1070 | module := &AndroidTestHelperApp{} |
| 1071 | |
Liz Kammer | a7a64f3 | 2020-07-09 15:16:41 -0700 | [diff] [blame] | 1072 | module.Module.dexProperties.Optimize.EnabledByDefault = true |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1073 | |
| 1074 | module.Module.properties.Installable = proptools.BoolPtr(true) |
Colin Cross | e4246ab | 2019-02-05 21:55:21 -0800 | [diff] [blame] | 1075 | module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true) |
Colin Cross | 47fa9d3 | 2019-03-26 10:51:39 -0700 | [diff] [blame] | 1076 | module.appProperties.AlwaysPackageNativeLibs = true |
Colin Cross | 43f08db | 2018-11-12 10:13:39 -0800 | [diff] [blame] | 1077 | module.Module.dexpreopter.isTest = true |
Colin Cross | 014489c | 2020-06-02 20:09:13 -0700 | [diff] [blame] | 1078 | module.Module.linter.test = true |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1079 | |
Colin Cross | ce6734e | 2020-06-15 16:09:53 -0700 | [diff] [blame] | 1080 | module.addHostAndDeviceProperties() |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1081 | module.AddProperties( |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1082 | &module.aaptProperties, |
| 1083 | &module.appProperties, |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 1084 | &module.appTestHelperAppProperties, |
Ulya Trafimovich | 21a7375 | 2020-09-01 17:33:48 +0100 | [diff] [blame] | 1085 | &module.overridableAppProperties) |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1086 | |
| 1087 | android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon) |
| 1088 | android.InitDefaultableModule(module) |
Anton Hansson | 3d2b6b4 | 2020-01-10 15:06:01 +0000 | [diff] [blame] | 1089 | android.InitApexModule(module) |
Colin Cross | 252fc6f | 2018-10-04 15:22:03 -0700 | [diff] [blame] | 1090 | return module |
| 1091 | } |
| 1092 | |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 1093 | type AndroidAppCertificate struct { |
| 1094 | android.ModuleBase |
| 1095 | properties AndroidAppCertificateProperties |
Jiyong Park | c00cbd9 | 2018-10-30 21:20:05 +0900 | [diff] [blame] | 1096 | Certificate Certificate |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 1097 | } |
| 1098 | |
| 1099 | type AndroidAppCertificateProperties struct { |
| 1100 | // Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name. |
| 1101 | Certificate *string |
| 1102 | } |
| 1103 | |
Colin Cross | 1b16b0e | 2019-02-12 14:41:32 -0800 | [diff] [blame] | 1104 | // android_app_certificate modules can be referenced by the certificates property of android_app modules to select |
| 1105 | // the signing key. |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 1106 | func AndroidAppCertificateFactory() android.Module { |
| 1107 | module := &AndroidAppCertificate{} |
| 1108 | module.AddProperties(&module.properties) |
| 1109 | android.InitAndroidModule(module) |
| 1110 | return module |
| 1111 | } |
| 1112 | |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 1113 | func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
| 1114 | cert := String(c.properties.Certificate) |
Jiyong Park | c00cbd9 | 2018-10-30 21:20:05 +0900 | [diff] [blame] | 1115 | c.Certificate = Certificate{ |
Colin Cross | 503c1d0 | 2020-01-28 14:00:53 -0800 | [diff] [blame] | 1116 | Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"), |
| 1117 | Key: android.PathForModuleSrc(ctx, cert+".pk8"), |
Colin Cross | bd01e2a | 2018-10-04 15:21:03 -0700 | [diff] [blame] | 1118 | } |
| 1119 | } |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 1120 | |
| 1121 | type OverrideAndroidApp struct { |
| 1122 | android.ModuleBase |
| 1123 | android.OverrideModuleBase |
| 1124 | } |
| 1125 | |
Sasha Smundak | 613cbb1 | 2020-06-05 10:27:23 -0700 | [diff] [blame] | 1126 | func (i *OverrideAndroidApp) GenerateAndroidBuildActions(_ android.ModuleContext) { |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 1127 | // All the overrides happen in the base module. |
| 1128 | // TODO(jungjw): Check the base module type. |
| 1129 | } |
| 1130 | |
| 1131 | // override_android_app is used to create an android_app module based on another android_app by overriding |
| 1132 | // some of its properties. |
| 1133 | func OverrideAndroidAppModuleFactory() android.Module { |
| 1134 | m := &OverrideAndroidApp{} |
| 1135 | m.AddProperties(&overridableAppProperties{}) |
| 1136 | |
Jaewoong Jung | b639a6a | 2019-05-10 15:16:29 -0700 | [diff] [blame] | 1137 | android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon) |
Jaewoong Jung | 525443a | 2019-02-28 15:35:54 -0800 | [diff] [blame] | 1138 | android.InitOverrideModule(m) |
| 1139 | return m |
| 1140 | } |
Jaewoong Jung | ccbb393 | 2019-04-15 09:48:31 -0700 | [diff] [blame] | 1141 | |
Jaewoong Jung | 26dedd3 | 2019-06-06 08:45:58 -0700 | [diff] [blame] | 1142 | type OverrideAndroidTest struct { |
| 1143 | android.ModuleBase |
| 1144 | android.OverrideModuleBase |
| 1145 | } |
| 1146 | |
Sasha Smundak | 613cbb1 | 2020-06-05 10:27:23 -0700 | [diff] [blame] | 1147 | func (i *OverrideAndroidTest) GenerateAndroidBuildActions(_ android.ModuleContext) { |
Jaewoong Jung | 26dedd3 | 2019-06-06 08:45:58 -0700 | [diff] [blame] | 1148 | // All the overrides happen in the base module. |
| 1149 | // TODO(jungjw): Check the base module type. |
| 1150 | } |
| 1151 | |
| 1152 | // override_android_test is used to create an android_app module based on another android_test by overriding |
| 1153 | // some of its properties. |
| 1154 | func OverrideAndroidTestModuleFactory() android.Module { |
| 1155 | m := &OverrideAndroidTest{} |
| 1156 | m.AddProperties(&overridableAppProperties{}) |
| 1157 | m.AddProperties(&appTestProperties{}) |
| 1158 | |
| 1159 | android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon) |
| 1160 | android.InitOverrideModule(m) |
| 1161 | return m |
| 1162 | } |
| 1163 | |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1164 | type UsesLibraryProperties struct { |
| 1165 | // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file. |
| 1166 | Uses_libs []string |
| 1167 | |
| 1168 | // A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with |
| 1169 | // required=false. |
| 1170 | Optional_uses_libs []string |
| 1171 | |
| 1172 | // If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults |
| 1173 | // to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future. |
| 1174 | Enforce_uses_libs *bool |
Ulya Trafimovich | 21a7375 | 2020-09-01 17:33:48 +0100 | [diff] [blame] | 1175 | |
Ulya Trafimovich | 54027b5 | 2020-09-09 14:08:23 +0100 | [diff] [blame] | 1176 | // Optional name of the <uses-library> provided by this module. This is needed for non-SDK |
| 1177 | // libraries, because SDK ones are automatically picked up by Soong. The <uses-library> name |
| 1178 | // normally is the same as the module name, but there are exceptions. |
| 1179 | Provides_uses_lib *string |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1180 | } |
| 1181 | |
| 1182 | // usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the |
| 1183 | // <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the |
| 1184 | // uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps |
| 1185 | // with knowledge of their shared libraries. |
| 1186 | type usesLibrary struct { |
| 1187 | usesLibraryProperties UsesLibraryProperties |
Ulya Trafimovich | 22890c4 | 2021-01-05 12:04:17 +0000 | [diff] [blame] | 1188 | |
| 1189 | // Whether to enforce verify_uses_library check. |
| 1190 | enforce bool |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1191 | } |
| 1192 | |
Ulya Trafimovich | fc24ad3 | 2020-08-19 16:32:54 +0100 | [diff] [blame] | 1193 | func (u *usesLibrary) addLib(lib string, optional bool) { |
| 1194 | if !android.InList(lib, u.usesLibraryProperties.Uses_libs) && !android.InList(lib, u.usesLibraryProperties.Optional_uses_libs) { |
| 1195 | if optional { |
| 1196 | u.usesLibraryProperties.Optional_uses_libs = append(u.usesLibraryProperties.Optional_uses_libs, lib) |
| 1197 | } else { |
| 1198 | u.usesLibraryProperties.Uses_libs = append(u.usesLibraryProperties.Uses_libs, lib) |
| 1199 | } |
| 1200 | } |
| 1201 | } |
| 1202 | |
Paul Duffin | 250e619 | 2019-06-07 10:44:37 +0100 | [diff] [blame] | 1203 | func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, hasFrameworkLibs bool) { |
Colin Cross | 3245b2c | 2019-06-07 13:18:09 -0700 | [diff] [blame] | 1204 | if !ctx.Config().UnbundledBuild() { |
| 1205 | ctx.AddVariationDependencies(nil, usesLibTag, u.usesLibraryProperties.Uses_libs...) |
| 1206 | ctx.AddVariationDependencies(nil, usesLibTag, u.presentOptionalUsesLibs(ctx)...) |
Paul Duffin | 250e619 | 2019-06-07 10:44:37 +0100 | [diff] [blame] | 1207 | // Only add these extra dependencies if the module depends on framework libs. This avoids |
| 1208 | // creating a cyclic dependency: |
| 1209 | // e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res. |
| 1210 | if hasFrameworkLibs { |
Ulya Trafimovich | 5f364b6 | 2020-06-30 12:39:01 +0100 | [diff] [blame] | 1211 | // Dexpreopt needs paths to the dex jars of these libraries in order to construct |
| 1212 | // class loader context for dex2oat. Add them as a dependency with a special tag. |
Ulya Trafimovich | b521811 | 2020-10-07 15:11:32 +0100 | [diff] [blame] | 1213 | ctx.AddVariationDependencies(nil, usesLibCompat29Tag, dexpreopt.CompatUsesLibs29...) |
| 1214 | ctx.AddVariationDependencies(nil, usesLibCompat28Tag, dexpreopt.OptionalCompatUsesLibs28...) |
| 1215 | ctx.AddVariationDependencies(nil, usesLibCompat30Tag, dexpreopt.OptionalCompatUsesLibs30...) |
Colin Cross | 3245b2c | 2019-06-07 13:18:09 -0700 | [diff] [blame] | 1216 | } |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1217 | } |
| 1218 | } |
| 1219 | |
| 1220 | // presentOptionalUsesLibs returns optional_uses_libs after filtering out MissingUsesLibraries, which don't exist in the |
| 1221 | // build. |
| 1222 | func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string { |
| 1223 | optionalUsesLibs, _ := android.FilterList(u.usesLibraryProperties.Optional_uses_libs, ctx.Config().MissingUsesLibraries()) |
| 1224 | return optionalUsesLibs |
| 1225 | } |
| 1226 | |
Ulya Trafimovich | eea486a | 2021-02-26 11:38:21 +0000 | [diff] [blame] | 1227 | // Helper function to replace string in a list. |
| 1228 | func replaceInList(list []string, oldstr, newstr string) { |
| 1229 | for i, str := range list { |
| 1230 | if str == oldstr { |
| 1231 | list[i] = newstr |
| 1232 | } |
| 1233 | } |
| 1234 | } |
| 1235 | |
Ulya Trafimovich | 8cbc5d2 | 2020-11-03 15:15:46 +0000 | [diff] [blame] | 1236 | // Returns a map of module names of shared library dependencies to the paths |
Ulya Trafimovich | d4bcea4 | 2020-06-03 14:57:22 +0100 | [diff] [blame] | 1237 | // to their dex jars on host and on device. |
Ulya Trafimovich | 8cbc5d2 | 2020-11-03 15:15:46 +0000 | [diff] [blame] | 1238 | func (u *usesLibrary) classLoaderContextForUsesLibDeps(ctx android.ModuleContext) dexpreopt.ClassLoaderContextMap { |
| 1239 | clcMap := make(dexpreopt.ClassLoaderContextMap) |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1240 | |
| 1241 | if !ctx.Config().UnbundledBuild() { |
Ulya Trafimovich | b521811 | 2020-10-07 15:11:32 +0100 | [diff] [blame] | 1242 | ctx.VisitDirectDeps(func(m android.Module) { |
Ulya Trafimovich | 8cbc5d2 | 2020-11-03 15:15:46 +0000 | [diff] [blame] | 1243 | if tag, ok := ctx.OtherModuleDependencyTag(m).(usesLibraryDependencyTag); ok { |
Ulya Trafimovich | b521811 | 2020-10-07 15:11:32 +0100 | [diff] [blame] | 1244 | dep := ctx.OtherModuleName(m) |
Ulya Trafimovich | dbf3166 | 2020-12-17 12:07:54 +0000 | [diff] [blame] | 1245 | if lib, ok := m.(UsesLibraryDependency); ok { |
Ulya Trafimovich | eea486a | 2021-02-26 11:38:21 +0000 | [diff] [blame] | 1246 | libName := dep |
| 1247 | if ulib, ok := m.(ProvidesUsesLib); ok && ulib.ProvidesUsesLib() != nil { |
| 1248 | libName = *ulib.ProvidesUsesLib() |
| 1249 | // Replace module name with library name in `uses_libs`/`optional_uses_libs` |
| 1250 | // in order to pass verify_uses_libraries check (which compares these |
| 1251 | // properties against library names written in the manifest). |
| 1252 | replaceInList(u.usesLibraryProperties.Uses_libs, dep, libName) |
| 1253 | replaceInList(u.usesLibraryProperties.Optional_uses_libs, dep, libName) |
| 1254 | } |
| 1255 | clcMap.AddContext(ctx, tag.sdkVersion, libName, |
Ulya Trafimovich | b23d28c | 2020-10-08 12:53:58 +0100 | [diff] [blame] | 1256 | lib.DexJarBuildPath(), lib.DexJarInstallPath(), lib.ClassLoaderContexts()) |
Ulya Trafimovich | b521811 | 2020-10-07 15:11:32 +0100 | [diff] [blame] | 1257 | } else if ctx.Config().AllowMissingDependencies() { |
| 1258 | ctx.AddMissingDependencies([]string{dep}) |
| 1259 | } else { |
| 1260 | ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library", dep) |
| 1261 | } |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1262 | } |
| 1263 | }) |
| 1264 | } |
| 1265 | |
Ulya Trafimovich | 8cbc5d2 | 2020-11-03 15:15:46 +0000 | [diff] [blame] | 1266 | return clcMap |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1267 | } |
| 1268 | |
| 1269 | // enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs |
| 1270 | // properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true |
| 1271 | // unconditionally in the future. |
| 1272 | func (u *usesLibrary) enforceUsesLibraries() bool { |
| 1273 | defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 || |
| 1274 | len(u.usesLibraryProperties.Optional_uses_libs) > 0 |
Ulya Trafimovich | 22890c4 | 2021-01-05 12:04:17 +0000 | [diff] [blame] | 1275 | return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, u.enforce || defaultEnforceUsesLibs) |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1276 | } |
| 1277 | |
Ulya Trafimovich | fc24ad3 | 2020-08-19 16:32:54 +0100 | [diff] [blame] | 1278 | // Freeze the value of `enforce_uses_libs` based on the current values of `uses_libs` and `optional_uses_libs`. |
| 1279 | func (u *usesLibrary) freezeEnforceUsesLibraries() { |
| 1280 | enforce := u.enforceUsesLibraries() |
| 1281 | u.usesLibraryProperties.Enforce_uses_libs = &enforce |
| 1282 | } |
| 1283 | |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1284 | // verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against the ones specified |
| 1285 | // in the uses_libs and optional_uses_libs properties. It returns the path to a copy of the manifest. |
| 1286 | func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path { |
| 1287 | outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml") |
Ulya Trafimovich | 8c35fcf | 2021-02-17 16:23:28 +0000 | [diff] [blame] | 1288 | statusFile := dexpreopt.UsesLibrariesStatusFile(ctx) |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1289 | |
Ulya Trafimovich | 6e55ef1 | 2021-03-04 12:37:50 +0000 | [diff] [blame] | 1290 | // Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the |
| 1291 | // check is not necessary, and although it is good to have, it is difficult to maintain on |
| 1292 | // non-linux build platforms where dexpreopt is generally disabled (the check may fail due to |
| 1293 | // various unrelated reasons, such as a failure to get manifest from an APK). |
| 1294 | if dexpreopt.GetGlobalConfig(ctx).DisablePreopt { |
| 1295 | return manifest |
| 1296 | } |
| 1297 | |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 1298 | rule := android.NewRuleBuilder(pctx, ctx) |
| 1299 | cmd := rule.Command().BuiltTool("manifest_check"). |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1300 | Flag("--enforce-uses-libraries"). |
| 1301 | Input(manifest). |
Ulya Trafimovich | 8c35fcf | 2021-02-17 16:23:28 +0000 | [diff] [blame] | 1302 | FlagWithOutput("--enforce-uses-libraries-status ", statusFile). |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1303 | FlagWithOutput("-o ", outputFile) |
| 1304 | |
Ulya Trafimovich | 8c35fcf | 2021-02-17 16:23:28 +0000 | [diff] [blame] | 1305 | if dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck { |
| 1306 | cmd.Flag("--enforce-uses-libraries-relax") |
| 1307 | } |
| 1308 | |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1309 | for _, lib := range u.usesLibraryProperties.Uses_libs { |
| 1310 | cmd.FlagWithArg("--uses-library ", lib) |
| 1311 | } |
| 1312 | |
| 1313 | for _, lib := range u.usesLibraryProperties.Optional_uses_libs { |
| 1314 | cmd.FlagWithArg("--optional-uses-library ", lib) |
| 1315 | } |
| 1316 | |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 1317 | rule.Build("verify_uses_libraries", "verify <uses-library>") |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1318 | |
| 1319 | return outputFile |
| 1320 | } |
| 1321 | |
| 1322 | // verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the ones specified |
| 1323 | // in the uses_libs and optional_uses_libs properties. It returns the path to a copy of the APK. |
| 1324 | func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) android.Path { |
| 1325 | outputFile := android.PathForModuleOut(ctx, "verify_uses_libraries", apk.Base()) |
Ulya Trafimovich | 8c35fcf | 2021-02-17 16:23:28 +0000 | [diff] [blame] | 1326 | statusFile := dexpreopt.UsesLibrariesStatusFile(ctx) |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1327 | |
Ulya Trafimovich | 6e55ef1 | 2021-03-04 12:37:50 +0000 | [diff] [blame] | 1328 | // Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the |
| 1329 | // check is not necessary, and although it is good to have, it is difficult to maintain on |
| 1330 | // non-linux build platforms where dexpreopt is generally disabled (the check may fail due to |
| 1331 | // various unrelated reasons, such as a failure to get manifest from an APK). |
| 1332 | if dexpreopt.GetGlobalConfig(ctx).DisablePreopt { |
| 1333 | return apk |
| 1334 | } |
| 1335 | |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 1336 | rule := android.NewRuleBuilder(pctx, ctx) |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1337 | aapt := ctx.Config().HostToolPath(ctx, "aapt") |
| 1338 | rule.Command(). |
| 1339 | Textf("aapt_binary=%s", aapt.String()).Implicit(aapt). |
| 1340 | Textf(`uses_library_names="%s"`, strings.Join(u.usesLibraryProperties.Uses_libs, " ")). |
| 1341 | Textf(`optional_uses_library_names="%s"`, strings.Join(u.usesLibraryProperties.Optional_uses_libs, " ")). |
Jaewoong Jung | 8431282 | 2021-02-24 21:09:10 -0800 | [diff] [blame] | 1342 | Textf(`relax_check="%t"`, dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck). |
Ulya Trafimovich | 8c35fcf | 2021-02-17 16:23:28 +0000 | [diff] [blame] | 1343 | Tool(android.PathForSource(ctx, "build/make/core/verify_uses_libraries.sh")).Input(apk).Output(statusFile) |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1344 | rule.Command().Text("cp -f").Input(apk).Output(outputFile) |
| 1345 | |
Colin Cross | f1a035e | 2020-11-16 17:32:30 -0800 | [diff] [blame] | 1346 | rule.Build("verify_uses_libraries", "verify <uses-library>") |
Colin Cross | 50ddcc4 | 2019-05-16 12:28:22 -0700 | [diff] [blame] | 1347 | |
| 1348 | return outputFile |
| 1349 | } |