Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "inliner.h" |
| 18 | |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 19 | #include "art_method-inl.h" |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 20 | #include "base/enums.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 21 | #include "builder.h" |
| 22 | #include "class_linker.h" |
Vladimir Marko | b4eb1b1 | 2018-05-24 11:09:38 +0100 | [diff] [blame] | 23 | #include "class_root.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 24 | #include "constant_folding.h" |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 25 | #include "data_type-inl.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 26 | #include "dead_code_elimination.h" |
Andreas Gampe | b95c74b | 2017-04-20 19:43:21 -0700 | [diff] [blame] | 27 | #include "dex/inline_method_analyser.h" |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 28 | #include "dex/verification_results.h" |
Andreas Gampe | 8cf9cb3 | 2017-07-19 09:28:38 -0700 | [diff] [blame] | 29 | #include "dex/verified_method.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 30 | #include "driver/compiler_driver-inl.h" |
Calin Juravle | ec74835 | 2015-07-29 13:52:12 +0100 | [diff] [blame] | 31 | #include "driver/compiler_options.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 32 | #include "driver/dex_compilation_unit.h" |
| 33 | #include "instruction_simplifier.h" |
Scott Wakeling | d60a1af | 2015-07-22 14:32:44 +0100 | [diff] [blame] | 34 | #include "intrinsics.h" |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 35 | #include "jit/jit.h" |
| 36 | #include "jit/jit_code_cache.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 37 | #include "mirror/class_loader.h" |
| 38 | #include "mirror/dex_cache.h" |
| 39 | #include "nodes.h" |
Nicolas Geoffray | 335005e | 2015-06-25 10:01:47 +0100 | [diff] [blame] | 40 | #include "optimizing_compiler.h" |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 41 | #include "reference_type_propagation.h" |
Matthew Gharrity | e928885 | 2016-07-14 14:08:16 -0700 | [diff] [blame] | 42 | #include "register_allocator_linear_scan.h" |
Andreas Gampe | 8cf9cb3 | 2017-07-19 09:28:38 -0700 | [diff] [blame] | 43 | #include "scoped_thread_state_change-inl.h" |
Vladimir Marko | dc151b2 | 2015-10-15 18:02:30 +0100 | [diff] [blame] | 44 | #include "sharpening.h" |
David Brazdil | 4833f5a | 2015-12-16 10:37:39 +0000 | [diff] [blame] | 45 | #include "ssa_builder.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 46 | #include "ssa_phi_elimination.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 47 | #include "thread.h" |
| 48 | |
| 49 | namespace art { |
| 50 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 51 | // Instruction limit to control memory. |
| 52 | static constexpr size_t kMaximumNumberOfTotalInstructions = 1024; |
| 53 | |
| 54 | // Maximum number of instructions for considering a method small, |
| 55 | // which we will always try to inline if the other non-instruction limits |
| 56 | // are not reached. |
| 57 | static constexpr size_t kMaximumNumberOfInstructionsForSmallMethod = 3; |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 58 | |
| 59 | // Limit the number of dex registers that we accumulate while inlining |
| 60 | // to avoid creating large amount of nested environments. |
Nicolas Geoffray | f81621e | 2017-06-07 13:18:03 +0100 | [diff] [blame] | 61 | static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 32; |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 62 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 63 | // Limit recursive call inlining, which do not benefit from too |
| 64 | // much inlining compared to code locality. |
| 65 | static constexpr size_t kMaximumNumberOfRecursiveCalls = 4; |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 66 | |
Calin Juravle | e2492d4 | 2017-03-20 11:42:13 -0700 | [diff] [blame] | 67 | // Controls the use of inline caches in AOT mode. |
Calin Juravle | 8af7089 | 2017-03-28 15:31:44 -0700 | [diff] [blame] | 68 | static constexpr bool kUseAOTInlineCaches = true; |
Calin Juravle | e2492d4 | 2017-03-20 11:42:13 -0700 | [diff] [blame] | 69 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 70 | // We check for line numbers to make sure the DepthString implementation |
| 71 | // aligns the output nicely. |
| 72 | #define LOG_INTERNAL(msg) \ |
| 73 | static_assert(__LINE__ > 10, "Unhandled line number"); \ |
| 74 | static_assert(__LINE__ < 10000, "Unhandled line number"); \ |
| 75 | VLOG(compiler) << DepthString(__LINE__) << msg |
| 76 | |
| 77 | #define LOG_TRY() LOG_INTERNAL("Try inlinining call: ") |
| 78 | #define LOG_NOTE() LOG_INTERNAL("Note: ") |
| 79 | #define LOG_SUCCESS() LOG_INTERNAL("Success: ") |
Igor Murashkin | 1e065a5 | 2017-08-09 13:20:34 -0700 | [diff] [blame] | 80 | #define LOG_FAIL(stats_ptr, stat) MaybeRecordStat(stats_ptr, stat); LOG_INTERNAL("Fail: ") |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 81 | #define LOG_FAIL_NO_STAT() LOG_INTERNAL("Fail: ") |
| 82 | |
| 83 | std::string HInliner::DepthString(int line) const { |
| 84 | std::string value; |
| 85 | // Indent according to the inlining depth. |
| 86 | size_t count = depth_; |
| 87 | // Line numbers get printed in the log, so add a space if the log's line is less |
| 88 | // than 1000, and two if less than 100. 10 cannot be reached as it's the copyright. |
| 89 | if (!kIsTargetBuild) { |
| 90 | if (line < 100) { |
| 91 | value += " "; |
| 92 | } |
| 93 | if (line < 1000) { |
| 94 | value += " "; |
| 95 | } |
| 96 | // Safeguard if this file reaches more than 10000 lines. |
| 97 | DCHECK_LT(line, 10000); |
| 98 | } |
| 99 | for (size_t i = 0; i < count; ++i) { |
| 100 | value += " "; |
| 101 | } |
| 102 | return value; |
| 103 | } |
| 104 | |
| 105 | static size_t CountNumberOfInstructions(HGraph* graph) { |
| 106 | size_t number_of_instructions = 0; |
| 107 | for (HBasicBlock* block : graph->GetReversePostOrderSkipEntryBlock()) { |
| 108 | for (HInstructionIterator instr_it(block->GetInstructions()); |
| 109 | !instr_it.Done(); |
| 110 | instr_it.Advance()) { |
| 111 | ++number_of_instructions; |
| 112 | } |
| 113 | } |
| 114 | return number_of_instructions; |
| 115 | } |
| 116 | |
| 117 | void HInliner::UpdateInliningBudget() { |
| 118 | if (total_number_of_instructions_ >= kMaximumNumberOfTotalInstructions) { |
| 119 | // Always try to inline small methods. |
| 120 | inlining_budget_ = kMaximumNumberOfInstructionsForSmallMethod; |
| 121 | } else { |
| 122 | inlining_budget_ = std::max( |
| 123 | kMaximumNumberOfInstructionsForSmallMethod, |
| 124 | kMaximumNumberOfTotalInstructions - total_number_of_instructions_); |
| 125 | } |
| 126 | } |
| 127 | |
Aart Bik | 2477320 | 2018-04-26 10:28:51 -0700 | [diff] [blame] | 128 | bool HInliner::Run() { |
Vladimir Marko | 213ee2d | 2018-06-22 11:56:34 +0100 | [diff] [blame] | 129 | if (codegen_->GetCompilerOptions().GetInlineMaxCodeUnits() == 0) { |
Aart Bik | 2477320 | 2018-04-26 10:28:51 -0700 | [diff] [blame] | 130 | // Inlining effectively disabled. |
| 131 | return false; |
| 132 | } else if (graph_->IsDebuggable()) { |
Nicolas Geoffray | e50b8d2 | 2015-03-13 08:57:42 +0000 | [diff] [blame] | 133 | // For simplicity, we currently never inline when the graph is debuggable. This avoids |
| 134 | // doing some logic in the runtime to discover if a method could have been inlined. |
Aart Bik | 2477320 | 2018-04-26 10:28:51 -0700 | [diff] [blame] | 135 | return false; |
Nicolas Geoffray | e50b8d2 | 2015-03-13 08:57:42 +0000 | [diff] [blame] | 136 | } |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 137 | |
Aart Bik | 2477320 | 2018-04-26 10:28:51 -0700 | [diff] [blame] | 138 | bool didInline = false; |
| 139 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 140 | // Initialize the number of instructions for the method being compiled. Recursive calls |
| 141 | // to HInliner::Run have already updated the instruction count. |
| 142 | if (outermost_graph_ == graph_) { |
| 143 | total_number_of_instructions_ = CountNumberOfInstructions(graph_); |
| 144 | } |
| 145 | |
| 146 | UpdateInliningBudget(); |
| 147 | DCHECK_NE(total_number_of_instructions_, 0u); |
| 148 | DCHECK_NE(inlining_budget_, 0u); |
| 149 | |
Roland Levillain | 6c3af16 | 2017-04-27 11:18:56 +0100 | [diff] [blame] | 150 | // If we're compiling with a core image (which is only used for |
| 151 | // test purposes), honor inlining directives in method names: |
| 152 | // - if a method's name contains the substring "$inline$", ensure |
| 153 | // that this method is actually inlined; |
| 154 | // - if a method's name contains the substring "$noinline$", do not |
| 155 | // inline that method. |
Vladimir Marko | be0c7cf | 2018-03-19 13:40:56 +0000 | [diff] [blame] | 156 | // We limit the latter to AOT compilation, as the JIT may or may not inline |
Nicolas Geoffray | 08490b8 | 2017-07-18 12:58:10 +0100 | [diff] [blame] | 157 | // depending on the state of classes at runtime. |
Vladimir Marko | be0c7cf | 2018-03-19 13:40:56 +0000 | [diff] [blame] | 158 | const bool honor_noinline_directives = IsCompilingWithCoreImage(); |
| 159 | const bool honor_inline_directives = |
| 160 | honor_noinline_directives && Runtime::Current()->IsAotCompiler(); |
Roland Levillain | 6c3af16 | 2017-04-27 11:18:56 +0100 | [diff] [blame] | 161 | |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 162 | // Keep a copy of all blocks when starting the visit. |
| 163 | ArenaVector<HBasicBlock*> blocks = graph_->GetReversePostOrder(); |
Vladimir Marko | fa6b93c | 2015-09-15 10:15:55 +0100 | [diff] [blame] | 164 | DCHECK(!blocks.empty()); |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 165 | // Because we are changing the graph when inlining, |
| 166 | // we just iterate over the blocks of the outer method. |
| 167 | // This avoids doing the inlining work again on the inlined blocks. |
| 168 | for (HBasicBlock* block : blocks) { |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 169 | for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) { |
| 170 | HInstruction* next = instruction->GetNext(); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 171 | HInvoke* call = instruction->AsInvoke(); |
Razvan A Lupusoru | 3e90a96 | 2015-03-27 13:44:44 -0700 | [diff] [blame] | 172 | // As long as the call is not intrinsified, it is worth trying to inline. |
| 173 | if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) { |
Vladimir Marko | be0c7cf | 2018-03-19 13:40:56 +0000 | [diff] [blame] | 174 | if (honor_noinline_directives) { |
Nicolas Geoffray | b703d18 | 2017-02-14 18:05:28 +0000 | [diff] [blame] | 175 | // Debugging case: directives in method names control or assert on inlining. |
| 176 | std::string callee_name = outer_compilation_unit_.GetDexFile()->PrettyMethod( |
| 177 | call->GetDexMethodIndex(), /* with_signature */ false); |
| 178 | // Tests prevent inlining by having $noinline$ in their method names. |
| 179 | if (callee_name.find("$noinline$") == std::string::npos) { |
Aart Bik | 2477320 | 2018-04-26 10:28:51 -0700 | [diff] [blame] | 180 | if (TryInline(call)) { |
| 181 | didInline = true; |
Aart Bik | 54e45c5 | 2018-04-27 13:57:21 -0700 | [diff] [blame] | 182 | } else if (honor_inline_directives) { |
Nicolas Geoffray | 1949baf | 2017-10-17 12:14:53 +0000 | [diff] [blame] | 183 | bool should_have_inlined = (callee_name.find("$inline$") != std::string::npos); |
| 184 | CHECK(!should_have_inlined) << "Could not inline " << callee_name; |
Nicolas Geoffray | b703d18 | 2017-02-14 18:05:28 +0000 | [diff] [blame] | 185 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 186 | } |
Guillaume "Vermeille" Sanchez | e918d38 | 2015-06-03 15:32:41 +0100 | [diff] [blame] | 187 | } else { |
Vladimir Marko | be0c7cf | 2018-03-19 13:40:56 +0000 | [diff] [blame] | 188 | DCHECK(!honor_inline_directives); |
Nicolas Geoffray | b703d18 | 2017-02-14 18:05:28 +0000 | [diff] [blame] | 189 | // Normal case: try to inline. |
Aart Bik | 2477320 | 2018-04-26 10:28:51 -0700 | [diff] [blame] | 190 | if (TryInline(call)) { |
| 191 | didInline = true; |
| 192 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 193 | } |
| 194 | } |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 195 | instruction = next; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 196 | } |
| 197 | } |
Aart Bik | 2477320 | 2018-04-26 10:28:51 -0700 | [diff] [blame] | 198 | |
| 199 | return didInline; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 200 | } |
| 201 | |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 202 | static bool IsMethodOrDeclaringClassFinal(ArtMethod* method) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 203 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 204 | return method->IsFinal() || method->GetDeclaringClass()->IsFinal(); |
| 205 | } |
| 206 | |
| 207 | /** |
| 208 | * Given the `resolved_method` looked up in the dex cache, try to find |
| 209 | * the actual runtime target of an interface or virtual call. |
| 210 | * Return nullptr if the runtime target cannot be proven. |
| 211 | */ |
| 212 | static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 213 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 214 | if (IsMethodOrDeclaringClassFinal(resolved_method)) { |
| 215 | // No need to lookup further, the resolved method will be the target. |
| 216 | return resolved_method; |
| 217 | } |
| 218 | |
| 219 | HInstruction* receiver = invoke->InputAt(0); |
| 220 | if (receiver->IsNullCheck()) { |
| 221 | // Due to multiple levels of inlining within the same pass, it might be that |
| 222 | // null check does not have the reference type of the actual receiver. |
| 223 | receiver = receiver->InputAt(0); |
| 224 | } |
| 225 | ReferenceTypeInfo info = receiver->GetReferenceTypeInfo(); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 226 | DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName(); |
| 227 | if (!info.IsExact()) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 228 | // We currently only support inlining with known receivers. |
| 229 | // TODO: Remove this check, we should be able to inline final methods |
| 230 | // on unknown receivers. |
| 231 | return nullptr; |
| 232 | } else if (info.GetTypeHandle()->IsInterface()) { |
| 233 | // Statically knowing that the receiver has an interface type cannot |
| 234 | // help us find what is the target method. |
| 235 | return nullptr; |
| 236 | } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) { |
| 237 | // The method that we're trying to call is not in the receiver's class or super classes. |
| 238 | return nullptr; |
Nicolas Geoffray | ab5327d | 2016-03-18 11:36:20 +0000 | [diff] [blame] | 239 | } else if (info.GetTypeHandle()->IsErroneous()) { |
| 240 | // If the type is erroneous, do not go further, as we are going to query the vtable or |
| 241 | // imt table, that we can only safely do on non-erroneous classes. |
| 242 | return nullptr; |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 243 | } |
| 244 | |
| 245 | ClassLinker* cl = Runtime::Current()->GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 246 | PointerSize pointer_size = cl->GetImagePointerSize(); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 247 | if (invoke->IsInvokeInterface()) { |
| 248 | resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface( |
| 249 | resolved_method, pointer_size); |
| 250 | } else { |
| 251 | DCHECK(invoke->IsInvokeVirtual()); |
| 252 | resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual( |
| 253 | resolved_method, pointer_size); |
| 254 | } |
| 255 | |
| 256 | if (resolved_method == nullptr) { |
| 257 | // The information we had on the receiver was not enough to find |
| 258 | // the target method. Since we check above the exact type of the receiver, |
| 259 | // the only reason this can happen is an IncompatibleClassChangeError. |
| 260 | return nullptr; |
Alex Light | 9139e00 | 2015-10-09 15:59:48 -0700 | [diff] [blame] | 261 | } else if (!resolved_method->IsInvokable()) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 262 | // The information we had on the receiver was not enough to find |
| 263 | // the target method. Since we check above the exact type of the receiver, |
| 264 | // the only reason this can happen is an IncompatibleClassChangeError. |
| 265 | return nullptr; |
| 266 | } else if (IsMethodOrDeclaringClassFinal(resolved_method)) { |
| 267 | // A final method has to be the target method. |
| 268 | return resolved_method; |
| 269 | } else if (info.IsExact()) { |
| 270 | // If we found a method and the receiver's concrete type is statically |
| 271 | // known, we know for sure the target. |
| 272 | return resolved_method; |
| 273 | } else { |
| 274 | // Even if we did find a method, the receiver type was not enough to |
| 275 | // statically find the runtime target. |
| 276 | return nullptr; |
| 277 | } |
| 278 | } |
| 279 | |
| 280 | static uint32_t FindMethodIndexIn(ArtMethod* method, |
| 281 | const DexFile& dex_file, |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 282 | uint32_t name_and_signature_index) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 283 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 284 | if (IsSameDexFile(*method->GetDexFile(), dex_file)) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 285 | return method->GetDexMethodIndex(); |
| 286 | } else { |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 287 | return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 288 | } |
| 289 | } |
| 290 | |
Andreas Gampe | a5b09a6 | 2016-11-17 15:21:22 -0800 | [diff] [blame] | 291 | static dex::TypeIndex FindClassIndexIn(mirror::Class* cls, |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 292 | const DexCompilationUnit& compilation_unit) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 293 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 294 | const DexFile& dex_file = *compilation_unit.GetDexFile(); |
Andreas Gampe | a5b09a6 | 2016-11-17 15:21:22 -0800 | [diff] [blame] | 295 | dex::TypeIndex index; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 296 | if (cls->GetDexCache() == nullptr) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 297 | DCHECK(cls->IsArrayClass()) << cls->PrettyClass(); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 298 | index = cls->FindTypeIndexInOtherDexFile(dex_file); |
Andreas Gampe | a5b09a6 | 2016-11-17 15:21:22 -0800 | [diff] [blame] | 299 | } else if (!cls->GetDexTypeIndex().IsValid()) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 300 | DCHECK(cls->IsProxyClass()) << cls->PrettyClass(); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 301 | // TODO: deal with proxy classes. |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 302 | } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) { |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 303 | DCHECK_EQ(cls->GetDexCache(), compilation_unit.GetDexCache().Get()); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 304 | index = cls->GetDexTypeIndex(); |
Nicolas Geoffray | 491617a | 2016-07-19 17:06:23 +0100 | [diff] [blame] | 305 | } else { |
| 306 | index = cls->FindTypeIndexInOtherDexFile(dex_file); |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 307 | // We cannot guarantee the entry will resolve to the same class, |
Nicolas Geoffray | 491617a | 2016-07-19 17:06:23 +0100 | [diff] [blame] | 308 | // as there may be different class loaders. So only return the index if it's |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 309 | // the right class already resolved with the class loader. |
| 310 | if (index.IsValid()) { |
Vladimir Marko | 666ee3d | 2017-12-11 18:37:36 +0000 | [diff] [blame] | 311 | ObjPtr<mirror::Class> resolved = compilation_unit.GetClassLinker()->LookupResolvedType( |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 312 | index, compilation_unit.GetDexCache().Get(), compilation_unit.GetClassLoader().Get()); |
| 313 | if (resolved != cls) { |
| 314 | index = dex::TypeIndex::Invalid(); |
| 315 | } |
Nicolas Geoffray | 491617a | 2016-07-19 17:06:23 +0100 | [diff] [blame] | 316 | } |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 317 | } |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 318 | |
| 319 | return index; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 320 | } |
| 321 | |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 322 | class ScopedProfilingInfoInlineUse { |
| 323 | public: |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 324 | explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self) |
| 325 | : method_(method), |
| 326 | self_(self), |
| 327 | // Fetch the profiling info ahead of using it. If it's null when fetching, |
| 328 | // we should not call JitCodeCache::DoneInlining. |
| 329 | profiling_info_( |
| 330 | Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) { |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 331 | } |
| 332 | |
| 333 | ~ScopedProfilingInfoInlineUse() { |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 334 | if (profiling_info_ != nullptr) { |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 335 | PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize(); |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 336 | DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size)); |
| 337 | Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_); |
| 338 | } |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 339 | } |
| 340 | |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 341 | ProfilingInfo* GetProfilingInfo() const { return profiling_info_; } |
| 342 | |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 343 | private: |
| 344 | ArtMethod* const method_; |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 345 | Thread* const self_; |
| 346 | ProfilingInfo* const profiling_info_; |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 347 | }; |
| 348 | |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 349 | HInliner::InlineCacheType HInliner::GetInlineCacheType( |
| 350 | const Handle<mirror::ObjectArray<mirror::Class>>& classes) |
| 351 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 352 | uint8_t number_of_types = 0; |
| 353 | for (; number_of_types < InlineCache::kIndividualCacheSize; ++number_of_types) { |
| 354 | if (classes->Get(number_of_types) == nullptr) { |
| 355 | break; |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 356 | } |
| 357 | } |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 358 | |
| 359 | if (number_of_types == 0) { |
| 360 | return kInlineCacheUninitialized; |
| 361 | } else if (number_of_types == 1) { |
| 362 | return kInlineCacheMonomorphic; |
| 363 | } else if (number_of_types == InlineCache::kIndividualCacheSize) { |
| 364 | return kInlineCacheMegamorphic; |
| 365 | } else { |
| 366 | return kInlineCachePolymorphic; |
| 367 | } |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 368 | } |
| 369 | |
| 370 | static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes) |
| 371 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 372 | DCHECK(classes->Get(0) != nullptr); |
| 373 | return classes->Get(0); |
| 374 | } |
| 375 | |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 376 | ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) { |
| 377 | if (!resolved_method->HasSingleImplementation()) { |
| 378 | return nullptr; |
| 379 | } |
| 380 | if (Runtime::Current()->IsAotCompiler()) { |
| 381 | // No CHA-based devirtulization for AOT compiler (yet). |
| 382 | return nullptr; |
| 383 | } |
| 384 | if (outermost_graph_->IsCompilingOsr()) { |
| 385 | // We do not support HDeoptimize in OSR methods. |
| 386 | return nullptr; |
| 387 | } |
Mingyao Yang | e8fcd01 | 2017-01-20 10:43:30 -0800 | [diff] [blame] | 388 | PointerSize pointer_size = caller_compilation_unit_.GetClassLinker()->GetImagePointerSize(); |
Nicolas Geoffray | 18ea1c9 | 2017-03-27 08:00:18 +0000 | [diff] [blame] | 389 | ArtMethod* single_impl = resolved_method->GetSingleImplementation(pointer_size); |
| 390 | if (single_impl == nullptr) { |
| 391 | return nullptr; |
| 392 | } |
| 393 | if (single_impl->IsProxyMethod()) { |
| 394 | // Proxy method is a generic invoker that's not worth |
| 395 | // devirtualizing/inlining. It also causes issues when the proxy |
| 396 | // method is in another dex file if we try to rewrite invoke-interface to |
| 397 | // invoke-virtual because a proxy method doesn't have a real dex file. |
| 398 | return nullptr; |
| 399 | } |
Nicolas Geoffray | 8e33e84 | 2017-04-03 16:55:16 +0100 | [diff] [blame] | 400 | if (!single_impl->GetDeclaringClass()->IsResolved()) { |
| 401 | // There's a race with the class loading, which updates the CHA info |
| 402 | // before setting the class to resolved. So we just bail for this |
| 403 | // rare occurence. |
| 404 | return nullptr; |
| 405 | } |
Nicolas Geoffray | 18ea1c9 | 2017-03-27 08:00:18 +0000 | [diff] [blame] | 406 | return single_impl; |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 407 | } |
| 408 | |
Aart Bik | 2c148f0 | 2018-02-02 14:30:35 -0800 | [diff] [blame] | 409 | static bool IsMethodUnverified(CompilerDriver* const compiler_driver, ArtMethod* method) |
David Sehr | 0225f8e | 2018-01-31 08:52:24 +0000 | [diff] [blame] | 410 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Aart Bik | 2c148f0 | 2018-02-02 14:30:35 -0800 | [diff] [blame] | 411 | if (!method->GetDeclaringClass()->IsVerified()) { |
| 412 | if (Runtime::Current()->UseJitCompilation()) { |
| 413 | // We're at runtime, we know this is cold code if the class |
| 414 | // is not verified, so don't bother analyzing. |
| 415 | return true; |
| 416 | } |
| 417 | uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex(); |
| 418 | if (!compiler_driver->IsMethodVerifiedWithoutFailures( |
| 419 | method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) { |
| 420 | // Method has soft or hard failures, don't analyze. |
| 421 | return true; |
| 422 | } |
| 423 | } |
| 424 | return false; |
| 425 | } |
| 426 | |
| 427 | static bool AlwaysThrows(CompilerDriver* const compiler_driver, ArtMethod* method) |
| 428 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 429 | DCHECK(method != nullptr); |
| 430 | // Skip non-compilable and unverified methods. |
| 431 | if (!method->IsCompilable() || IsMethodUnverified(compiler_driver, method)) { |
| 432 | return false; |
| 433 | } |
Aart Bik | a8b8e9b | 2018-01-09 11:01:02 -0800 | [diff] [blame] | 434 | // Skip native methods, methods with try blocks, and methods that are too large. |
Aart Bik | 2c148f0 | 2018-02-02 14:30:35 -0800 | [diff] [blame] | 435 | CodeItemDataAccessor accessor(method->DexInstructionData()); |
Aart Bik | a8b8e9b | 2018-01-09 11:01:02 -0800 | [diff] [blame] | 436 | if (!accessor.HasCodeItem() || |
| 437 | accessor.TriesSize() != 0 || |
| 438 | accessor.InsnsSizeInCodeUnits() > kMaximumNumberOfTotalInstructions) { |
| 439 | return false; |
| 440 | } |
| 441 | // Scan for exits. |
| 442 | bool throw_seen = false; |
| 443 | for (const DexInstructionPcPair& pair : accessor) { |
| 444 | switch (pair.Inst().Opcode()) { |
| 445 | case Instruction::RETURN: |
| 446 | case Instruction::RETURN_VOID: |
| 447 | case Instruction::RETURN_WIDE: |
| 448 | case Instruction::RETURN_OBJECT: |
| 449 | case Instruction::RETURN_VOID_NO_BARRIER: |
| 450 | return false; // found regular control flow back |
| 451 | case Instruction::THROW: |
| 452 | throw_seen = true; |
| 453 | break; |
| 454 | default: |
| 455 | break; |
| 456 | } |
| 457 | } |
| 458 | return throw_seen; |
| 459 | } |
| 460 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 461 | bool HInliner::TryInline(HInvoke* invoke_instruction) { |
Orion Hodson | ac14139 | 2017-01-13 11:53:47 +0000 | [diff] [blame] | 462 | if (invoke_instruction->IsInvokeUnresolved() || |
Orion Hodson | 4c8e12e | 2018-05-18 08:33:20 +0100 | [diff] [blame] | 463 | invoke_instruction->IsInvokePolymorphic() || |
| 464 | invoke_instruction->IsInvokeCustom()) { |
| 465 | return false; // Don't bother to move further if we know the method is unresolved or the |
| 466 | // invocation is polymorphic (invoke-{polymorphic,custom}). |
Calin Juravle | 175dc73 | 2015-08-25 15:42:32 +0100 | [diff] [blame] | 467 | } |
| 468 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 469 | ScopedObjectAccess soa(Thread::Current()); |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 470 | uint32_t method_index = invoke_instruction->GetDexMethodIndex(); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 471 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 472 | LOG_TRY() << caller_dex_file.PrettyMethod(method_index); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 473 | |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 474 | ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod(); |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 475 | if (resolved_method == nullptr) { |
| 476 | DCHECK(invoke_instruction->IsInvokeStaticOrDirect()); |
| 477 | DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()); |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 478 | LOG_FAIL_NO_STAT() << "Not inlining a String.<init> method"; |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 479 | return false; |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 480 | } |
| 481 | ArtMethod* actual_method = nullptr; |
| 482 | |
| 483 | if (invoke_instruction->IsInvokeStaticOrDirect()) { |
Andreas Gampe | fd2140f | 2015-12-23 16:30:44 -0800 | [diff] [blame] | 484 | actual_method = resolved_method; |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 485 | } else { |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 486 | // Check if we can statically find the method. |
| 487 | actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 488 | } |
| 489 | |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 490 | bool cha_devirtualize = false; |
| 491 | if (actual_method == nullptr) { |
| 492 | ArtMethod* method = TryCHADevirtualization(resolved_method); |
| 493 | if (method != nullptr) { |
| 494 | cha_devirtualize = true; |
| 495 | actual_method = method; |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 496 | LOG_NOTE() << "Try CHA-based inlining of " << actual_method->PrettyMethod(); |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 497 | } |
| 498 | } |
| 499 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 500 | if (actual_method != nullptr) { |
Aart Bik | d4e328f | 2018-01-16 14:14:34 -0800 | [diff] [blame] | 501 | // Single target. |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 502 | bool result = TryInlineAndReplace(invoke_instruction, |
| 503 | actual_method, |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 504 | ReferenceTypeInfo::CreateInvalid(), |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 505 | /* do_rtp */ true, |
| 506 | cha_devirtualize); |
Aart Bik | d4e328f | 2018-01-16 14:14:34 -0800 | [diff] [blame] | 507 | if (result) { |
| 508 | // Successfully inlined. |
| 509 | if (!invoke_instruction->IsInvokeStaticOrDirect()) { |
| 510 | if (cha_devirtualize) { |
| 511 | // Add dependency due to devirtualization. We've assumed resolved_method |
| 512 | // has single implementation. |
| 513 | outermost_graph_->AddCHASingleImplementationDependency(resolved_method); |
| 514 | MaybeRecordStat(stats_, MethodCompilationStat::kCHAInline); |
| 515 | } else { |
| 516 | MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvokeVirtualOrInterface); |
| 517 | } |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 518 | } |
Aart Bik | 2c148f0 | 2018-02-02 14:30:35 -0800 | [diff] [blame] | 519 | } else if (!cha_devirtualize && AlwaysThrows(compiler_driver_, actual_method)) { |
Aart Bik | d4e328f | 2018-01-16 14:14:34 -0800 | [diff] [blame] | 520 | // Set always throws property for non-inlined method call with single target |
| 521 | // (unless it was obtained through CHA, because that would imply we have |
| 522 | // to add the CHA dependency, which seems not worth it). |
| 523 | invoke_instruction->SetAlwaysThrows(true); |
Calin Juravle | 6915898 | 2016-03-16 11:53:41 +0000 | [diff] [blame] | 524 | } |
| 525 | return result; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 526 | } |
Andreas Gampe | fd2140f | 2015-12-23 16:30:44 -0800 | [diff] [blame] | 527 | DCHECK(!invoke_instruction->IsInvokeStaticOrDirect()); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 528 | |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 529 | // Try using inline caches. |
| 530 | return TryInlineFromInlineCache(caller_dex_file, invoke_instruction, resolved_method); |
| 531 | } |
| 532 | |
| 533 | static Handle<mirror::ObjectArray<mirror::Class>> AllocateInlineCacheHolder( |
| 534 | const DexCompilationUnit& compilation_unit, |
| 535 | StackHandleScope<1>* hs) |
| 536 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 537 | Thread* self = Thread::Current(); |
| 538 | ClassLinker* class_linker = compilation_unit.GetClassLinker(); |
| 539 | Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs->NewHandle( |
| 540 | mirror::ObjectArray<mirror::Class>::Alloc( |
| 541 | self, |
Vladimir Marko | b4eb1b1 | 2018-05-24 11:09:38 +0100 | [diff] [blame] | 542 | GetClassRoot<mirror::ObjectArray<mirror::Class>>(class_linker), |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 543 | InlineCache::kIndividualCacheSize)); |
| 544 | if (inline_cache == nullptr) { |
| 545 | // We got an OOME. Just clear the exception, and don't inline. |
| 546 | DCHECK(self->IsExceptionPending()); |
| 547 | self->ClearException(); |
| 548 | VLOG(compiler) << "Out of memory in the compiler when trying to inline"; |
| 549 | } |
| 550 | return inline_cache; |
| 551 | } |
| 552 | |
Calin Juravle | af44e6c | 2017-05-23 14:24:55 -0700 | [diff] [blame] | 553 | bool HInliner::UseOnlyPolymorphicInliningWithNoDeopt() { |
| 554 | // If we are compiling AOT or OSR, pretend the call using inline caches is polymorphic and |
| 555 | // do not generate a deopt. |
| 556 | // |
| 557 | // For AOT: |
| 558 | // Generating a deopt does not ensure that we will actually capture the new types; |
| 559 | // and the danger is that we could be stuck in a loop with "forever" deoptimizations. |
| 560 | // Take for example the following scenario: |
| 561 | // - we capture the inline cache in one run |
| 562 | // - the next run, we deoptimize because we miss a type check, but the method |
| 563 | // never becomes hot again |
| 564 | // In this case, the inline cache will not be updated in the profile and the AOT code |
| 565 | // will keep deoptimizing. |
| 566 | // Another scenario is if we use profile compilation for a process which is not allowed |
| 567 | // to JIT (e.g. system server). If we deoptimize we will run interpreted code for the |
| 568 | // rest of the lifetime. |
| 569 | // TODO(calin): |
| 570 | // This is a compromise because we will most likely never update the inline cache |
| 571 | // in the profile (unless there's another reason to deopt). So we might be stuck with |
| 572 | // a sub-optimal inline cache. |
| 573 | // We could be smarter when capturing inline caches to mitigate this. |
| 574 | // (e.g. by having different thresholds for new and old methods). |
| 575 | // |
| 576 | // For OSR: |
| 577 | // We may come from the interpreter and it may have seen different receiver types. |
| 578 | return Runtime::Current()->IsAotCompiler() || outermost_graph_->IsCompilingOsr(); |
| 579 | } |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 580 | bool HInliner::TryInlineFromInlineCache(const DexFile& caller_dex_file, |
| 581 | HInvoke* invoke_instruction, |
| 582 | ArtMethod* resolved_method) |
| 583 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Calin Juravle | e2492d4 | 2017-03-20 11:42:13 -0700 | [diff] [blame] | 584 | if (Runtime::Current()->IsAotCompiler() && !kUseAOTInlineCaches) { |
| 585 | return false; |
| 586 | } |
| 587 | |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 588 | StackHandleScope<1> hs(Thread::Current()); |
| 589 | Handle<mirror::ObjectArray<mirror::Class>> inline_cache; |
| 590 | InlineCacheType inline_cache_type = Runtime::Current()->IsAotCompiler() |
| 591 | ? GetInlineCacheAOT(caller_dex_file, invoke_instruction, &hs, &inline_cache) |
| 592 | : GetInlineCacheJIT(invoke_instruction, &hs, &inline_cache); |
| 593 | |
| 594 | switch (inline_cache_type) { |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 595 | case kInlineCacheNoData: { |
| 596 | LOG_FAIL_NO_STAT() |
| 597 | << "Interface or virtual call to " |
| 598 | << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex()) |
| 599 | << " could not be statically determined"; |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 600 | return false; |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 601 | } |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 602 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 603 | case kInlineCacheUninitialized: { |
| 604 | LOG_FAIL_NO_STAT() |
| 605 | << "Interface or virtual call to " |
| 606 | << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex()) |
| 607 | << " is not hit and not inlined"; |
| 608 | return false; |
| 609 | } |
| 610 | |
| 611 | case kInlineCacheMonomorphic: { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 612 | MaybeRecordStat(stats_, MethodCompilationStat::kMonomorphicCall); |
Calin Juravle | af44e6c | 2017-05-23 14:24:55 -0700 | [diff] [blame] | 613 | if (UseOnlyPolymorphicInliningWithNoDeopt()) { |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 614 | return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache); |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 615 | } else { |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 616 | return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache); |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 617 | } |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 618 | } |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 619 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 620 | case kInlineCachePolymorphic: { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 621 | MaybeRecordStat(stats_, MethodCompilationStat::kPolymorphicCall); |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 622 | return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache); |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 623 | } |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 624 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 625 | case kInlineCacheMegamorphic: { |
| 626 | LOG_FAIL_NO_STAT() |
| 627 | << "Interface or virtual call to " |
| 628 | << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex()) |
| 629 | << " is megamorphic and not inlined"; |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 630 | MaybeRecordStat(stats_, MethodCompilationStat::kMegamorphicCall); |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 631 | return false; |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 632 | } |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 633 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 634 | case kInlineCacheMissingTypes: { |
| 635 | LOG_FAIL_NO_STAT() |
| 636 | << "Interface or virtual call to " |
| 637 | << caller_dex_file.PrettyMethod(invoke_instruction->GetDexMethodIndex()) |
| 638 | << " is missing types and not inlined"; |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 639 | return false; |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 640 | } |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 641 | } |
| 642 | UNREACHABLE(); |
| 643 | } |
| 644 | |
| 645 | HInliner::InlineCacheType HInliner::GetInlineCacheJIT( |
| 646 | HInvoke* invoke_instruction, |
| 647 | StackHandleScope<1>* hs, |
| 648 | /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache) |
| 649 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 650 | DCHECK(Runtime::Current()->UseJitCompilation()); |
| 651 | |
| 652 | ArtMethod* caller = graph_->GetArtMethod(); |
| 653 | // Under JIT, we should always know the caller. |
| 654 | DCHECK(caller != nullptr); |
| 655 | ScopedProfilingInfoInlineUse spiis(caller, Thread::Current()); |
| 656 | ProfilingInfo* profiling_info = spiis.GetProfilingInfo(); |
| 657 | |
| 658 | if (profiling_info == nullptr) { |
| 659 | return kInlineCacheNoData; |
| 660 | } |
| 661 | |
| 662 | *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs); |
| 663 | if (inline_cache->Get() == nullptr) { |
| 664 | // We can't extract any data if we failed to allocate; |
| 665 | return kInlineCacheNoData; |
| 666 | } else { |
| 667 | Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto( |
| 668 | *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()), |
| 669 | *inline_cache); |
| 670 | return GetInlineCacheType(*inline_cache); |
| 671 | } |
| 672 | } |
| 673 | |
| 674 | HInliner::InlineCacheType HInliner::GetInlineCacheAOT( |
| 675 | const DexFile& caller_dex_file, |
| 676 | HInvoke* invoke_instruction, |
| 677 | StackHandleScope<1>* hs, |
| 678 | /*out*/Handle<mirror::ObjectArray<mirror::Class>>* inline_cache) |
| 679 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 680 | DCHECK(Runtime::Current()->IsAotCompiler()); |
| 681 | const ProfileCompilationInfo* pci = compiler_driver_->GetProfileCompilationInfo(); |
| 682 | if (pci == nullptr) { |
| 683 | return kInlineCacheNoData; |
| 684 | } |
| 685 | |
Calin Juravle | cc3171a | 2017-05-19 16:47:53 -0700 | [diff] [blame] | 686 | std::unique_ptr<ProfileCompilationInfo::OfflineProfileMethodInfo> offline_profile = |
| 687 | pci->GetMethod(caller_dex_file.GetLocation(), |
| 688 | caller_dex_file.GetLocationChecksum(), |
| 689 | caller_compilation_unit_.GetDexMethodIndex()); |
| 690 | if (offline_profile == nullptr) { |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 691 | return kInlineCacheNoData; // no profile information for this invocation. |
| 692 | } |
| 693 | |
| 694 | *inline_cache = AllocateInlineCacheHolder(caller_compilation_unit_, hs); |
| 695 | if (inline_cache == nullptr) { |
| 696 | // We can't extract any data if we failed to allocate; |
| 697 | return kInlineCacheNoData; |
| 698 | } else { |
| 699 | return ExtractClassesFromOfflineProfile(invoke_instruction, |
Calin Juravle | cc3171a | 2017-05-19 16:47:53 -0700 | [diff] [blame] | 700 | *(offline_profile.get()), |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 701 | *inline_cache); |
| 702 | } |
| 703 | } |
| 704 | |
| 705 | HInliner::InlineCacheType HInliner::ExtractClassesFromOfflineProfile( |
| 706 | const HInvoke* invoke_instruction, |
| 707 | const ProfileCompilationInfo::OfflineProfileMethodInfo& offline_profile, |
| 708 | /*out*/Handle<mirror::ObjectArray<mirror::Class>> inline_cache) |
| 709 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Calin Juravle | e6f87cc | 2017-05-24 17:41:05 -0700 | [diff] [blame] | 710 | const auto it = offline_profile.inline_caches->find(invoke_instruction->GetDexPc()); |
| 711 | if (it == offline_profile.inline_caches->end()) { |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 712 | return kInlineCacheUninitialized; |
| 713 | } |
| 714 | |
| 715 | const ProfileCompilationInfo::DexPcData& dex_pc_data = it->second; |
| 716 | |
| 717 | if (dex_pc_data.is_missing_types) { |
| 718 | return kInlineCacheMissingTypes; |
| 719 | } |
| 720 | if (dex_pc_data.is_megamorphic) { |
| 721 | return kInlineCacheMegamorphic; |
| 722 | } |
| 723 | |
| 724 | DCHECK_LE(dex_pc_data.classes.size(), InlineCache::kIndividualCacheSize); |
| 725 | Thread* self = Thread::Current(); |
| 726 | // We need to resolve the class relative to the containing dex file. |
| 727 | // So first, build a mapping from the index of dex file in the profile to |
| 728 | // its dex cache. This will avoid repeating the lookup when walking over |
| 729 | // the inline cache types. |
| 730 | std::vector<ObjPtr<mirror::DexCache>> dex_profile_index_to_dex_cache( |
| 731 | offline_profile.dex_references.size()); |
| 732 | for (size_t i = 0; i < offline_profile.dex_references.size(); i++) { |
| 733 | bool found = false; |
Vladimir Marko | 213ee2d | 2018-06-22 11:56:34 +0100 | [diff] [blame] | 734 | for (const DexFile* dex_file : codegen_->GetCompilerOptions().GetDexFilesForOatFile()) { |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 735 | if (offline_profile.dex_references[i].MatchesDex(dex_file)) { |
| 736 | dex_profile_index_to_dex_cache[i] = |
| 737 | caller_compilation_unit_.GetClassLinker()->FindDexCache(self, *dex_file); |
| 738 | found = true; |
| 739 | } |
| 740 | } |
| 741 | if (!found) { |
| 742 | VLOG(compiler) << "Could not find profiled dex file: " |
| 743 | << offline_profile.dex_references[i].dex_location; |
| 744 | return kInlineCacheMissingTypes; |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 745 | } |
| 746 | } |
| 747 | |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 748 | // Walk over the classes and resolve them. If we cannot find a type we return |
| 749 | // kInlineCacheMissingTypes. |
| 750 | int ic_index = 0; |
| 751 | for (const ProfileCompilationInfo::ClassReference& class_ref : dex_pc_data.classes) { |
| 752 | ObjPtr<mirror::DexCache> dex_cache = |
| 753 | dex_profile_index_to_dex_cache[class_ref.dex_profile_index]; |
| 754 | DCHECK(dex_cache != nullptr); |
Calin Juravle | 0855688 | 2017-05-26 16:40:45 -0700 | [diff] [blame] | 755 | |
| 756 | if (!dex_cache->GetDexFile()->IsTypeIndexValid(class_ref.type_index)) { |
| 757 | VLOG(compiler) << "Profile data corrupt: type index " << class_ref.type_index |
| 758 | << "is invalid in location" << dex_cache->GetDexFile()->GetLocation(); |
| 759 | return kInlineCacheNoData; |
| 760 | } |
Vladimir Marko | 666ee3d | 2017-12-11 18:37:36 +0000 | [diff] [blame] | 761 | ObjPtr<mirror::Class> clazz = caller_compilation_unit_.GetClassLinker()->LookupResolvedType( |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 762 | class_ref.type_index, |
| 763 | dex_cache, |
| 764 | caller_compilation_unit_.GetClassLoader().Get()); |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 765 | if (clazz != nullptr) { |
| 766 | inline_cache->Set(ic_index++, clazz); |
| 767 | } else { |
| 768 | VLOG(compiler) << "Could not resolve class from inline cache in AOT mode " |
| 769 | << caller_compilation_unit_.GetDexFile()->PrettyMethod( |
| 770 | invoke_instruction->GetDexMethodIndex()) << " : " |
| 771 | << caller_compilation_unit_ |
| 772 | .GetDexFile()->StringByTypeIdx(class_ref.type_index); |
| 773 | return kInlineCacheMissingTypes; |
| 774 | } |
| 775 | } |
| 776 | return GetInlineCacheType(inline_cache); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 777 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 778 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 779 | HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker, |
| 780 | HInstruction* receiver, |
| 781 | uint32_t dex_pc) const { |
Vladimir Marko | b4eb1b1 | 2018-05-24 11:09:38 +0100 | [diff] [blame] | 782 | ArtField* field = GetClassRoot<mirror::Object>(class_linker)->GetInstanceField(0); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 783 | DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_"); |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 784 | HInstanceFieldGet* result = new (graph_->GetAllocator()) HInstanceFieldGet( |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 785 | receiver, |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 786 | field, |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 787 | DataType::Type::kReference, |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 788 | field->GetOffset(), |
| 789 | field->IsVolatile(), |
| 790 | field->GetDexFieldIndex(), |
| 791 | field->GetDeclaringClass()->GetDexClassDefIndex(), |
| 792 | *field->GetDexFile(), |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 793 | dex_pc); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 794 | // The class of a field is effectively final, and does not have any memory dependencies. |
| 795 | result->SetSideEffects(SideEffects::None()); |
| 796 | return result; |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 797 | } |
| 798 | |
Nicolas Geoffray | 4c0b4bc | 2017-03-17 13:08:26 +0000 | [diff] [blame] | 799 | static ArtMethod* ResolveMethodFromInlineCache(Handle<mirror::Class> klass, |
| 800 | ArtMethod* resolved_method, |
| 801 | HInstruction* invoke_instruction, |
| 802 | PointerSize pointer_size) |
| 803 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 804 | if (Runtime::Current()->IsAotCompiler()) { |
| 805 | // We can get unrelated types when working with profiles (corruption, |
| 806 | // systme updates, or anyone can write to it). So first check if the class |
| 807 | // actually implements the declaring class of the method that is being |
| 808 | // called in bytecode. |
| 809 | // Note: the lookup methods used below require to have assignable types. |
| 810 | if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(klass.Get())) { |
| 811 | return nullptr; |
| 812 | } |
| 813 | } |
| 814 | |
| 815 | if (invoke_instruction->IsInvokeInterface()) { |
| 816 | resolved_method = klass->FindVirtualMethodForInterface(resolved_method, pointer_size); |
| 817 | } else { |
| 818 | DCHECK(invoke_instruction->IsInvokeVirtual()); |
| 819 | resolved_method = klass->FindVirtualMethodForVirtual(resolved_method, pointer_size); |
| 820 | } |
| 821 | DCHECK(resolved_method != nullptr); |
| 822 | return resolved_method; |
| 823 | } |
| 824 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 825 | bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction, |
| 826 | ArtMethod* resolved_method, |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 827 | Handle<mirror::ObjectArray<mirror::Class>> classes) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 828 | DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface()) |
| 829 | << invoke_instruction->DebugName(); |
| 830 | |
Andreas Gampe | a5b09a6 | 2016-11-17 15:21:22 -0800 | [diff] [blame] | 831 | dex::TypeIndex class_index = FindClassIndexIn( |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 832 | GetMonomorphicType(classes), caller_compilation_unit_); |
Andreas Gampe | a5b09a6 | 2016-11-17 15:21:22 -0800 | [diff] [blame] | 833 | if (!class_index.IsValid()) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 834 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 835 | << "Call to " << ArtMethod::PrettyMethod(resolved_method) |
| 836 | << " from inline cache is not inlined because its class is not" |
| 837 | << " accessible to the caller"; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 838 | return false; |
| 839 | } |
| 840 | |
| 841 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 842 | PointerSize pointer_size = class_linker->GetImagePointerSize(); |
Nicolas Geoffray | 4c0b4bc | 2017-03-17 13:08:26 +0000 | [diff] [blame] | 843 | Handle<mirror::Class> monomorphic_type = handles_->NewHandle(GetMonomorphicType(classes)); |
| 844 | resolved_method = ResolveMethodFromInlineCache( |
| 845 | monomorphic_type, resolved_method, invoke_instruction, pointer_size); |
| 846 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 847 | LOG_NOTE() << "Try inline monomorphic call to " << resolved_method->PrettyMethod(); |
Nicolas Geoffray | 4c0b4bc | 2017-03-17 13:08:26 +0000 | [diff] [blame] | 848 | if (resolved_method == nullptr) { |
| 849 | // Bogus AOT profile, bail. |
| 850 | DCHECK(Runtime::Current()->IsAotCompiler()); |
| 851 | return false; |
| 852 | } |
| 853 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 854 | HInstruction* receiver = invoke_instruction->InputAt(0); |
| 855 | HInstruction* cursor = invoke_instruction->GetPrevious(); |
| 856 | HBasicBlock* bb_cursor = invoke_instruction->GetBlock(); |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 857 | if (!TryInlineAndReplace(invoke_instruction, |
| 858 | resolved_method, |
Nicolas Geoffray | 5247c08 | 2017-01-13 14:17:29 +0000 | [diff] [blame] | 859 | ReferenceTypeInfo::Create(monomorphic_type, /* is_exact */ true), |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 860 | /* do_rtp */ false, |
| 861 | /* cha_devirtualize */ false)) { |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 862 | return false; |
| 863 | } |
| 864 | |
| 865 | // We successfully inlined, now add a guard. |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 866 | AddTypeGuard(receiver, |
| 867 | cursor, |
| 868 | bb_cursor, |
| 869 | class_index, |
Nicolas Geoffray | 5247c08 | 2017-01-13 14:17:29 +0000 | [diff] [blame] | 870 | monomorphic_type, |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 871 | invoke_instruction, |
| 872 | /* with_deoptimization */ true); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 873 | |
| 874 | // Run type propagation to get the guard typed, and eventually propagate the |
| 875 | // type of the receiver. |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 876 | ReferenceTypePropagation rtp_fixup(graph_, |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 877 | outer_compilation_unit_.GetClassLoader(), |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 878 | outer_compilation_unit_.GetDexCache(), |
| 879 | handles_, |
| 880 | /* is_first_run */ false); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 881 | rtp_fixup.Run(); |
| 882 | |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 883 | MaybeRecordStat(stats_, MethodCompilationStat::kInlinedMonomorphicCall); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 884 | return true; |
| 885 | } |
| 886 | |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 887 | void HInliner::AddCHAGuard(HInstruction* invoke_instruction, |
| 888 | uint32_t dex_pc, |
| 889 | HInstruction* cursor, |
| 890 | HBasicBlock* bb_cursor) { |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 891 | HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetAllocator()) |
| 892 | HShouldDeoptimizeFlag(graph_->GetAllocator(), dex_pc); |
| 893 | HInstruction* compare = new (graph_->GetAllocator()) HNotEqual( |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 894 | deopt_flag, graph_->GetIntConstant(0, dex_pc)); |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 895 | HInstruction* deopt = new (graph_->GetAllocator()) HDeoptimize( |
| 896 | graph_->GetAllocator(), compare, DeoptimizationKind::kCHA, dex_pc); |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 897 | |
| 898 | if (cursor != nullptr) { |
| 899 | bb_cursor->InsertInstructionAfter(deopt_flag, cursor); |
| 900 | } else { |
| 901 | bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction()); |
| 902 | } |
Mingyao Yang | b0b051a | 2016-11-17 09:04:53 -0800 | [diff] [blame] | 903 | bb_cursor->InsertInstructionAfter(compare, deopt_flag); |
| 904 | bb_cursor->InsertInstructionAfter(deopt, compare); |
| 905 | |
| 906 | // Add receiver as input to aid CHA guard optimization later. |
| 907 | deopt_flag->AddInput(invoke_instruction->InputAt(0)); |
| 908 | DCHECK_EQ(deopt_flag->InputCount(), 1u); |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 909 | deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
Mingyao Yang | b0b051a | 2016-11-17 09:04:53 -0800 | [diff] [blame] | 910 | outermost_graph_->IncrementNumberOfCHAGuards(); |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 911 | } |
| 912 | |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 913 | HInstruction* HInliner::AddTypeGuard(HInstruction* receiver, |
| 914 | HInstruction* cursor, |
| 915 | HBasicBlock* bb_cursor, |
Andreas Gampe | a5b09a6 | 2016-11-17 15:21:22 -0800 | [diff] [blame] | 916 | dex::TypeIndex class_index, |
Nicolas Geoffray | 5247c08 | 2017-01-13 14:17:29 +0000 | [diff] [blame] | 917 | Handle<mirror::Class> klass, |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 918 | HInstruction* invoke_instruction, |
| 919 | bool with_deoptimization) { |
| 920 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
| 921 | HInstanceFieldGet* receiver_class = BuildGetReceiverClass( |
| 922 | class_linker, receiver, invoke_instruction->GetDexPc()); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 923 | if (cursor != nullptr) { |
| 924 | bb_cursor->InsertInstructionAfter(receiver_class, cursor); |
| 925 | } else { |
| 926 | bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction()); |
| 927 | } |
Nicolas Geoffray | 5687634 | 2016-12-16 16:09:08 +0000 | [diff] [blame] | 928 | |
| 929 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
Calin Juravle | 07f01df | 2017-04-28 19:58:01 -0700 | [diff] [blame] | 930 | bool is_referrer; |
| 931 | ArtMethod* outermost_art_method = outermost_graph_->GetArtMethod(); |
| 932 | if (outermost_art_method == nullptr) { |
| 933 | DCHECK(Runtime::Current()->IsAotCompiler()); |
| 934 | // We are in AOT mode and we don't have an ART method to determine |
| 935 | // if the inlined method belongs to the referrer. Assume it doesn't. |
| 936 | is_referrer = false; |
| 937 | } else { |
| 938 | is_referrer = klass.Get() == outermost_art_method->GetDeclaringClass(); |
| 939 | } |
| 940 | |
Nicolas Geoffray | 5687634 | 2016-12-16 16:09:08 +0000 | [diff] [blame] | 941 | // Note that we will just compare the classes, so we don't need Java semantics access checks. |
| 942 | // Note that the type index and the dex file are relative to the method this type guard is |
| 943 | // inlined into. |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 944 | HLoadClass* load_class = new (graph_->GetAllocator()) HLoadClass(graph_->GetCurrentMethod(), |
| 945 | class_index, |
| 946 | caller_dex_file, |
| 947 | klass, |
| 948 | is_referrer, |
| 949 | invoke_instruction->GetDexPc(), |
| 950 | /* needs_access_check */ false); |
Nicolas Geoffray | c4aa82c | 2017-03-06 14:38:52 +0000 | [diff] [blame] | 951 | HLoadClass::LoadKind kind = HSharpening::ComputeLoadClassKind( |
Nicolas Geoffray | 83c8e27 | 2017-01-31 14:36:37 +0000 | [diff] [blame] | 952 | load_class, codegen_, compiler_driver_, caller_compilation_unit_); |
| 953 | DCHECK(kind != HLoadClass::LoadKind::kInvalid) |
| 954 | << "We should always be able to reference a class for inline caches"; |
Vladimir Marko | 28e012a | 2017-12-07 11:22:59 +0000 | [diff] [blame] | 955 | // Load kind must be set before inserting the instruction into the graph. |
Nicolas Geoffray | 83c8e27 | 2017-01-31 14:36:37 +0000 | [diff] [blame] | 956 | load_class->SetLoadKind(kind); |
Vladimir Marko | 28e012a | 2017-12-07 11:22:59 +0000 | [diff] [blame] | 957 | bb_cursor->InsertInstructionAfter(load_class, receiver_class); |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 958 | // In AOT mode, we will most likely load the class from BSS, which will involve a call |
| 959 | // to the runtime. In this case, the load instruction will need an environment so copy |
| 960 | // it from the invoke instruction. |
| 961 | if (load_class->NeedsEnvironment()) { |
| 962 | DCHECK(Runtime::Current()->IsAotCompiler()); |
| 963 | load_class->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
| 964 | } |
Nicolas Geoffray | 5687634 | 2016-12-16 16:09:08 +0000 | [diff] [blame] | 965 | |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 966 | HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(load_class, receiver_class); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 967 | bb_cursor->InsertInstructionAfter(compare, load_class); |
| 968 | if (with_deoptimization) { |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 969 | HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize( |
| 970 | graph_->GetAllocator(), |
Nicolas Geoffray | 6f8e2c9 | 2017-03-23 14:37:26 +0000 | [diff] [blame] | 971 | compare, |
| 972 | receiver, |
Nicolas Geoffray | 4e92c3c | 2017-05-08 09:34:26 +0100 | [diff] [blame] | 973 | Runtime::Current()->IsAotCompiler() |
| 974 | ? DeoptimizationKind::kAotInlineCache |
| 975 | : DeoptimizationKind::kJitInlineCache, |
Nicolas Geoffray | 6f8e2c9 | 2017-03-23 14:37:26 +0000 | [diff] [blame] | 976 | invoke_instruction->GetDexPc()); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 977 | bb_cursor->InsertInstructionAfter(deoptimize, compare); |
| 978 | deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
Nicolas Geoffray | 6f8e2c9 | 2017-03-23 14:37:26 +0000 | [diff] [blame] | 979 | DCHECK_EQ(invoke_instruction->InputAt(0), receiver); |
| 980 | receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize); |
| 981 | deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo()); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 982 | } |
| 983 | return compare; |
| 984 | } |
| 985 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 986 | bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction, |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 987 | ArtMethod* resolved_method, |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 988 | Handle<mirror::ObjectArray<mirror::Class>> classes) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 989 | DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface()) |
| 990 | << invoke_instruction->DebugName(); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 991 | |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 992 | if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) { |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 993 | return true; |
| 994 | } |
| 995 | |
| 996 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 997 | PointerSize pointer_size = class_linker->GetImagePointerSize(); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 998 | |
| 999 | bool all_targets_inlined = true; |
| 1000 | bool one_target_inlined = false; |
| 1001 | for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) { |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 1002 | if (classes->Get(i) == nullptr) { |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1003 | break; |
| 1004 | } |
| 1005 | ArtMethod* method = nullptr; |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1006 | |
| 1007 | Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i)); |
Nicolas Geoffray | 4c0b4bc | 2017-03-17 13:08:26 +0000 | [diff] [blame] | 1008 | method = ResolveMethodFromInlineCache( |
| 1009 | handle, resolved_method, invoke_instruction, pointer_size); |
| 1010 | if (method == nullptr) { |
| 1011 | DCHECK(Runtime::Current()->IsAotCompiler()); |
| 1012 | // AOT profile is bogus. This loop expects to iterate over all entries, |
| 1013 | // so just just continue. |
| 1014 | all_targets_inlined = false; |
| 1015 | continue; |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1016 | } |
| 1017 | |
| 1018 | HInstruction* receiver = invoke_instruction->InputAt(0); |
| 1019 | HInstruction* cursor = invoke_instruction->GetPrevious(); |
| 1020 | HBasicBlock* bb_cursor = invoke_instruction->GetBlock(); |
| 1021 | |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 1022 | dex::TypeIndex class_index = FindClassIndexIn(handle.Get(), caller_compilation_unit_); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1023 | HInstruction* return_replacement = nullptr; |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1024 | LOG_NOTE() << "Try inline polymorphic call to " << method->PrettyMethod(); |
Andreas Gampe | a5b09a6 | 2016-11-17 15:21:22 -0800 | [diff] [blame] | 1025 | if (!class_index.IsValid() || |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1026 | !TryBuildAndInline(invoke_instruction, |
| 1027 | method, |
| 1028 | ReferenceTypeInfo::Create(handle, /* is_exact */ true), |
| 1029 | &return_replacement)) { |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1030 | all_targets_inlined = false; |
| 1031 | } else { |
| 1032 | one_target_inlined = true; |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1033 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1034 | LOG_SUCCESS() << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method) |
| 1035 | << " has inlined " << ArtMethod::PrettyMethod(method); |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 1036 | |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1037 | // If we have inlined all targets before, and this receiver is the last seen, |
| 1038 | // we deoptimize instead of keeping the original invoke instruction. |
Calin Juravle | af44e6c | 2017-05-23 14:24:55 -0700 | [diff] [blame] | 1039 | bool deoptimize = !UseOnlyPolymorphicInliningWithNoDeopt() && |
| 1040 | all_targets_inlined && |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1041 | (i != InlineCache::kIndividualCacheSize - 1) && |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 1042 | (classes->Get(i + 1) == nullptr); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1043 | |
Nicolas Geoffray | 5687634 | 2016-12-16 16:09:08 +0000 | [diff] [blame] | 1044 | HInstruction* compare = AddTypeGuard(receiver, |
| 1045 | cursor, |
| 1046 | bb_cursor, |
| 1047 | class_index, |
Nicolas Geoffray | 5247c08 | 2017-01-13 14:17:29 +0000 | [diff] [blame] | 1048 | handle, |
Nicolas Geoffray | 5687634 | 2016-12-16 16:09:08 +0000 | [diff] [blame] | 1049 | invoke_instruction, |
| 1050 | deoptimize); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1051 | if (deoptimize) { |
| 1052 | if (return_replacement != nullptr) { |
| 1053 | invoke_instruction->ReplaceWith(return_replacement); |
| 1054 | } |
| 1055 | invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction); |
| 1056 | // Because the inline cache data can be populated concurrently, we force the end of the |
Nicolas Geoffray | 4c0b4bc | 2017-03-17 13:08:26 +0000 | [diff] [blame] | 1057 | // iteration. Otherwise, we could see a new receiver type. |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1058 | break; |
| 1059 | } else { |
| 1060 | CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction); |
| 1061 | } |
| 1062 | } |
| 1063 | } |
| 1064 | |
| 1065 | if (!one_target_inlined) { |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1066 | LOG_FAIL_NO_STAT() |
| 1067 | << "Call to " << ArtMethod::PrettyMethod(resolved_method) |
| 1068 | << " from inline cache is not inlined because none" |
| 1069 | << " of its targets could be inlined"; |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1070 | return false; |
| 1071 | } |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 1072 | |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1073 | MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1074 | |
| 1075 | // Run type propagation to get the guards typed. |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 1076 | ReferenceTypePropagation rtp_fixup(graph_, |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 1077 | outer_compilation_unit_.GetClassLoader(), |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 1078 | outer_compilation_unit_.GetDexCache(), |
| 1079 | handles_, |
| 1080 | /* is_first_run */ false); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1081 | rtp_fixup.Run(); |
| 1082 | return true; |
| 1083 | } |
| 1084 | |
| 1085 | void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare, |
| 1086 | HInstruction* return_replacement, |
| 1087 | HInstruction* invoke_instruction) { |
| 1088 | uint32_t dex_pc = invoke_instruction->GetDexPc(); |
| 1089 | HBasicBlock* cursor_block = compare->GetBlock(); |
| 1090 | HBasicBlock* original_invoke_block = invoke_instruction->GetBlock(); |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1091 | ArenaAllocator* allocator = graph_->GetAllocator(); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1092 | |
| 1093 | // Spit the block after the compare: `cursor_block` will now be the start of the diamond, |
| 1094 | // and the returned block is the start of the then branch (that could contain multiple blocks). |
| 1095 | HBasicBlock* then = cursor_block->SplitAfterForInlining(compare); |
| 1096 | |
| 1097 | // Split the block containing the invoke before and after the invoke. The returned block |
| 1098 | // of the split before will contain the invoke and will be the otherwise branch of |
| 1099 | // the diamond. The returned block of the split after will be the merge block |
| 1100 | // of the diamond. |
| 1101 | HBasicBlock* end_then = invoke_instruction->GetBlock(); |
| 1102 | HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction); |
| 1103 | HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction); |
| 1104 | |
| 1105 | // If the methods we are inlining return a value, we create a phi in the merge block |
| 1106 | // that will have the `invoke_instruction and the `return_replacement` as inputs. |
| 1107 | if (return_replacement != nullptr) { |
| 1108 | HPhi* phi = new (allocator) HPhi( |
| 1109 | allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc); |
| 1110 | merge->AddPhi(phi); |
| 1111 | invoke_instruction->ReplaceWith(phi); |
| 1112 | phi->AddInput(return_replacement); |
| 1113 | phi->AddInput(invoke_instruction); |
| 1114 | } |
| 1115 | |
| 1116 | // Add the control flow instructions. |
| 1117 | otherwise->AddInstruction(new (allocator) HGoto(dex_pc)); |
| 1118 | end_then->AddInstruction(new (allocator) HGoto(dex_pc)); |
| 1119 | cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc)); |
| 1120 | |
| 1121 | // Add the newly created blocks to the graph. |
| 1122 | graph_->AddBlock(then); |
| 1123 | graph_->AddBlock(otherwise); |
| 1124 | graph_->AddBlock(merge); |
| 1125 | |
| 1126 | // Set up successor (and implictly predecessor) relations. |
| 1127 | cursor_block->AddSuccessor(otherwise); |
| 1128 | cursor_block->AddSuccessor(then); |
| 1129 | end_then->AddSuccessor(merge); |
| 1130 | otherwise->AddSuccessor(merge); |
| 1131 | |
| 1132 | // Set up dominance information. |
| 1133 | then->SetDominator(cursor_block); |
| 1134 | cursor_block->AddDominatedBlock(then); |
| 1135 | otherwise->SetDominator(cursor_block); |
| 1136 | cursor_block->AddDominatedBlock(otherwise); |
| 1137 | merge->SetDominator(cursor_block); |
| 1138 | cursor_block->AddDominatedBlock(merge); |
| 1139 | |
| 1140 | // Update the revert post order. |
| 1141 | size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block); |
| 1142 | MakeRoomFor(&graph_->reverse_post_order_, 1, index); |
| 1143 | graph_->reverse_post_order_[++index] = then; |
| 1144 | index = IndexOfElement(graph_->reverse_post_order_, end_then); |
| 1145 | MakeRoomFor(&graph_->reverse_post_order_, 2, index); |
| 1146 | graph_->reverse_post_order_[++index] = otherwise; |
| 1147 | graph_->reverse_post_order_[++index] = merge; |
| 1148 | |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1149 | |
Nicolas Geoffray | a1d8ddf | 2016-02-29 11:46:58 +0000 | [diff] [blame] | 1150 | graph_->UpdateLoopAndTryInformationOfNewBlock( |
| 1151 | then, original_invoke_block, /* replace_if_back_edge */ false); |
| 1152 | graph_->UpdateLoopAndTryInformationOfNewBlock( |
| 1153 | otherwise, original_invoke_block, /* replace_if_back_edge */ false); |
| 1154 | |
| 1155 | // In case the original invoke location was a back edge, we need to update |
| 1156 | // the loop to now have the merge block as a back edge. |
| 1157 | graph_->UpdateLoopAndTryInformationOfNewBlock( |
| 1158 | merge, original_invoke_block, /* replace_if_back_edge */ true); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 1159 | } |
| 1160 | |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 1161 | bool HInliner::TryInlinePolymorphicCallToSameTarget( |
| 1162 | HInvoke* invoke_instruction, |
| 1163 | ArtMethod* resolved_method, |
| 1164 | Handle<mirror::ObjectArray<mirror::Class>> classes) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1165 | // This optimization only works under JIT for now. |
Calin Juravle | 13439f0 | 2017-02-21 01:17:21 -0800 | [diff] [blame] | 1166 | if (!Runtime::Current()->UseJitCompilation()) { |
| 1167 | return false; |
| 1168 | } |
| 1169 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1170 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 1171 | PointerSize pointer_size = class_linker->GetImagePointerSize(); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1172 | |
| 1173 | DCHECK(resolved_method != nullptr); |
| 1174 | ArtMethod* actual_method = nullptr; |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 1175 | size_t method_index = invoke_instruction->IsInvokeVirtual() |
| 1176 | ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex() |
| 1177 | : invoke_instruction->AsInvokeInterface()->GetImtIndex(); |
| 1178 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1179 | // Check whether we are actually calling the same method among |
| 1180 | // the different types seen. |
| 1181 | for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) { |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 1182 | if (classes->Get(i) == nullptr) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1183 | break; |
| 1184 | } |
| 1185 | ArtMethod* new_method = nullptr; |
| 1186 | if (invoke_instruction->IsInvokeInterface()) { |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 1187 | new_method = classes->Get(i)->GetImt(pointer_size)->Get( |
Matthew Gharrity | 465ecc8 | 2016-07-19 21:32:52 +0000 | [diff] [blame] | 1188 | method_index, pointer_size); |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 1189 | if (new_method->IsRuntimeMethod()) { |
| 1190 | // Bail out as soon as we see a conflict trampoline in one of the target's |
| 1191 | // interface table. |
| 1192 | return false; |
| 1193 | } |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1194 | } else { |
| 1195 | DCHECK(invoke_instruction->IsInvokeVirtual()); |
Nicolas Geoffray | e51ca8b | 2016-11-22 14:49:31 +0000 | [diff] [blame] | 1196 | new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1197 | } |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 1198 | DCHECK(new_method != nullptr); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1199 | if (actual_method == nullptr) { |
| 1200 | actual_method = new_method; |
| 1201 | } else if (actual_method != new_method) { |
| 1202 | // Different methods, bailout. |
| 1203 | return false; |
| 1204 | } |
| 1205 | } |
| 1206 | |
| 1207 | HInstruction* receiver = invoke_instruction->InputAt(0); |
| 1208 | HInstruction* cursor = invoke_instruction->GetPrevious(); |
| 1209 | HBasicBlock* bb_cursor = invoke_instruction->GetBlock(); |
| 1210 | |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1211 | HInstruction* return_replacement = nullptr; |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1212 | if (!TryBuildAndInline(invoke_instruction, |
| 1213 | actual_method, |
| 1214 | ReferenceTypeInfo::CreateInvalid(), |
| 1215 | &return_replacement)) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1216 | return false; |
| 1217 | } |
| 1218 | |
| 1219 | // We successfully inlined, now add a guard. |
| 1220 | HInstanceFieldGet* receiver_class = BuildGetReceiverClass( |
| 1221 | class_linker, receiver, invoke_instruction->GetDexPc()); |
| 1222 | |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1223 | DataType::Type type = Is64BitInstructionSet(graph_->GetInstructionSet()) |
| 1224 | ? DataType::Type::kInt64 |
| 1225 | : DataType::Type::kInt32; |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1226 | HClassTableGet* class_table_get = new (graph_->GetAllocator()) HClassTableGet( |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1227 | receiver_class, |
| 1228 | type, |
Vladimir Marko | a1de918 | 2016-02-25 11:37:38 +0000 | [diff] [blame] | 1229 | invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable |
| 1230 | : HClassTableGet::TableKind::kIMTable, |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 1231 | method_index, |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1232 | invoke_instruction->GetDexPc()); |
| 1233 | |
| 1234 | HConstant* constant; |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1235 | if (type == DataType::Type::kInt64) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1236 | constant = graph_->GetLongConstant( |
| 1237 | reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc()); |
| 1238 | } else { |
| 1239 | constant = graph_->GetIntConstant( |
| 1240 | reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc()); |
| 1241 | } |
| 1242 | |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1243 | HNotEqual* compare = new (graph_->GetAllocator()) HNotEqual(class_table_get, constant); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1244 | if (cursor != nullptr) { |
| 1245 | bb_cursor->InsertInstructionAfter(receiver_class, cursor); |
| 1246 | } else { |
| 1247 | bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction()); |
| 1248 | } |
| 1249 | bb_cursor->InsertInstructionAfter(class_table_get, receiver_class); |
| 1250 | bb_cursor->InsertInstructionAfter(compare, class_table_get); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1251 | |
| 1252 | if (outermost_graph_->IsCompilingOsr()) { |
| 1253 | CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction); |
| 1254 | } else { |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1255 | HDeoptimize* deoptimize = new (graph_->GetAllocator()) HDeoptimize( |
| 1256 | graph_->GetAllocator(), |
Nicolas Geoffray | 6f8e2c9 | 2017-03-23 14:37:26 +0000 | [diff] [blame] | 1257 | compare, |
| 1258 | receiver, |
Nicolas Geoffray | 4e92c3c | 2017-05-08 09:34:26 +0100 | [diff] [blame] | 1259 | DeoptimizationKind::kJitSameTarget, |
Nicolas Geoffray | 6f8e2c9 | 2017-03-23 14:37:26 +0000 | [diff] [blame] | 1260 | invoke_instruction->GetDexPc()); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1261 | bb_cursor->InsertInstructionAfter(deoptimize, compare); |
| 1262 | deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
| 1263 | if (return_replacement != nullptr) { |
| 1264 | invoke_instruction->ReplaceWith(return_replacement); |
| 1265 | } |
Nicolas Geoffray | 6f8e2c9 | 2017-03-23 14:37:26 +0000 | [diff] [blame] | 1266 | receiver->ReplaceUsesDominatedBy(deoptimize, deoptimize); |
Nicolas Geoffray | 1be7cbd | 2016-04-29 13:56:01 +0100 | [diff] [blame] | 1267 | invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction); |
Nicolas Geoffray | 6f8e2c9 | 2017-03-23 14:37:26 +0000 | [diff] [blame] | 1268 | deoptimize->SetReferenceTypeInfo(receiver->GetReferenceTypeInfo()); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1269 | } |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1270 | |
| 1271 | // Run type propagation to get the guard typed. |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 1272 | ReferenceTypePropagation rtp_fixup(graph_, |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 1273 | outer_compilation_unit_.GetClassLoader(), |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 1274 | outer_compilation_unit_.GetDexCache(), |
| 1275 | handles_, |
| 1276 | /* is_first_run */ false); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1277 | rtp_fixup.Run(); |
| 1278 | |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1279 | MaybeRecordStat(stats_, MethodCompilationStat::kInlinedPolymorphicCall); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1280 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1281 | LOG_SUCCESS() << "Inlined same polymorphic target " << actual_method->PrettyMethod(); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 1282 | return true; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 1283 | } |
| 1284 | |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 1285 | bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction, |
| 1286 | ArtMethod* method, |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1287 | ReferenceTypeInfo receiver_type, |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 1288 | bool do_rtp, |
| 1289 | bool cha_devirtualize) { |
Mingyao Yang | 6b1aebe | 2017-11-27 15:39:04 -0800 | [diff] [blame] | 1290 | DCHECK(!invoke_instruction->IsIntrinsic()); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1291 | HInstruction* return_replacement = nullptr; |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 1292 | uint32_t dex_pc = invoke_instruction->GetDexPc(); |
| 1293 | HInstruction* cursor = invoke_instruction->GetPrevious(); |
| 1294 | HBasicBlock* bb_cursor = invoke_instruction->GetBlock(); |
Mingyao Yang | 6b1aebe | 2017-11-27 15:39:04 -0800 | [diff] [blame] | 1295 | bool should_remove_invoke_instruction = false; |
| 1296 | |
| 1297 | // If invoke_instruction is devirtualized to a different method, give intrinsics |
| 1298 | // another chance before we try to inline it. |
| 1299 | bool wrong_invoke_type = false; |
| 1300 | if (invoke_instruction->GetResolvedMethod() != method && |
| 1301 | IntrinsicsRecognizer::Recognize(invoke_instruction, method, &wrong_invoke_type)) { |
| 1302 | MaybeRecordStat(stats_, MethodCompilationStat::kIntrinsicRecognized); |
| 1303 | if (invoke_instruction->IsInvokeInterface()) { |
| 1304 | // We don't intrinsify an invoke-interface directly. |
| 1305 | // Replace the invoke-interface with an invoke-virtual. |
| 1306 | HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual( |
| 1307 | graph_->GetAllocator(), |
| 1308 | invoke_instruction->GetNumberOfArguments(), |
| 1309 | invoke_instruction->GetType(), |
| 1310 | invoke_instruction->GetDexPc(), |
| 1311 | invoke_instruction->GetDexMethodIndex(), // Use interface method's dex method index. |
| 1312 | method, |
| 1313 | method->GetMethodIndex()); |
| 1314 | HInputsRef inputs = invoke_instruction->GetInputs(); |
| 1315 | for (size_t index = 0; index != inputs.size(); ++index) { |
| 1316 | new_invoke->SetArgumentAt(index, inputs[index]); |
| 1317 | } |
| 1318 | invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction); |
| 1319 | new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
| 1320 | if (invoke_instruction->GetType() == DataType::Type::kReference) { |
| 1321 | new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo()); |
| 1322 | } |
| 1323 | // Run intrinsic recognizer again to set new_invoke's intrinsic. |
| 1324 | IntrinsicsRecognizer::Recognize(new_invoke, method, &wrong_invoke_type); |
| 1325 | DCHECK_NE(new_invoke->GetIntrinsic(), Intrinsics::kNone); |
| 1326 | return_replacement = new_invoke; |
| 1327 | // invoke_instruction is replaced with new_invoke. |
| 1328 | should_remove_invoke_instruction = true; |
| 1329 | } else { |
| 1330 | // invoke_instruction is intrinsified and stays. |
| 1331 | } |
| 1332 | } else if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) { |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1333 | if (invoke_instruction->IsInvokeInterface()) { |
Nicolas Geoffray | 18ea1c9 | 2017-03-27 08:00:18 +0000 | [diff] [blame] | 1334 | DCHECK(!method->IsProxyMethod()); |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1335 | // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always |
| 1336 | // better than an invoke-interface because: |
| 1337 | // 1) In the best case, the interface call has one more indirection (to fetch the IMT). |
| 1338 | // 2) We will not go to the conflict trampoline with an invoke-virtual. |
| 1339 | // TODO: Consider sharpening once it is not dependent on the compiler driver. |
Nicolas Geoffray | 18ea1c9 | 2017-03-27 08:00:18 +0000 | [diff] [blame] | 1340 | |
| 1341 | if (method->IsDefault() && !method->IsCopied()) { |
| 1342 | // Changing to invoke-virtual cannot be done on an original default method |
| 1343 | // since it's not in any vtable. Devirtualization by exact type/inline-cache |
| 1344 | // always uses a method in the iftable which is never an original default |
| 1345 | // method. |
| 1346 | // On the other hand, inlining an original default method by CHA is fine. |
| 1347 | DCHECK(cha_devirtualize); |
| 1348 | return false; |
| 1349 | } |
| 1350 | |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1351 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 1352 | uint32_t dex_method_index = FindMethodIndexIn( |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1353 | method, caller_dex_file, invoke_instruction->GetDexMethodIndex()); |
Andreas Gampe | e2abbc6 | 2017-09-15 11:59:26 -0700 | [diff] [blame] | 1354 | if (dex_method_index == dex::kDexNoIndex) { |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1355 | return false; |
| 1356 | } |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1357 | HInvokeVirtual* new_invoke = new (graph_->GetAllocator()) HInvokeVirtual( |
| 1358 | graph_->GetAllocator(), |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1359 | invoke_instruction->GetNumberOfArguments(), |
| 1360 | invoke_instruction->GetType(), |
| 1361 | invoke_instruction->GetDexPc(), |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 1362 | dex_method_index, |
| 1363 | method, |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1364 | method->GetMethodIndex()); |
| 1365 | HInputsRef inputs = invoke_instruction->GetInputs(); |
| 1366 | for (size_t index = 0; index != inputs.size(); ++index) { |
| 1367 | new_invoke->SetArgumentAt(index, inputs[index]); |
| 1368 | } |
| 1369 | invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction); |
| 1370 | new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1371 | if (invoke_instruction->GetType() == DataType::Type::kReference) { |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1372 | new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo()); |
| 1373 | } |
| 1374 | return_replacement = new_invoke; |
Mingyao Yang | 6b1aebe | 2017-11-27 15:39:04 -0800 | [diff] [blame] | 1375 | // invoke_instruction is replaced with new_invoke. |
| 1376 | should_remove_invoke_instruction = true; |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 1377 | } else { |
| 1378 | // TODO: Consider sharpening an invoke virtual once it is not dependent on the |
| 1379 | // compiler driver. |
| 1380 | return false; |
| 1381 | } |
Mingyao Yang | 6b1aebe | 2017-11-27 15:39:04 -0800 | [diff] [blame] | 1382 | } else { |
| 1383 | // invoke_instruction is inlined. |
| 1384 | should_remove_invoke_instruction = true; |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1385 | } |
Mingyao Yang | 6b1aebe | 2017-11-27 15:39:04 -0800 | [diff] [blame] | 1386 | |
Mingyao Yang | 063fc77 | 2016-08-02 11:02:54 -0700 | [diff] [blame] | 1387 | if (cha_devirtualize) { |
| 1388 | AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor); |
| 1389 | } |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1390 | if (return_replacement != nullptr) { |
| 1391 | invoke_instruction->ReplaceWith(return_replacement); |
| 1392 | } |
Mingyao Yang | 6b1aebe | 2017-11-27 15:39:04 -0800 | [diff] [blame] | 1393 | if (should_remove_invoke_instruction) { |
| 1394 | invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction); |
| 1395 | } |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1396 | FixUpReturnReferenceType(method, return_replacement); |
| 1397 | if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) { |
| 1398 | // Actual return value has a more specific type than the method's declared |
| 1399 | // return type. Run RTP again on the outer graph to propagate it. |
| 1400 | ReferenceTypePropagation(graph_, |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 1401 | outer_compilation_unit_.GetClassLoader(), |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1402 | outer_compilation_unit_.GetDexCache(), |
| 1403 | handles_, |
| 1404 | /* is_first_run */ false).Run(); |
| 1405 | } |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1406 | return true; |
| 1407 | } |
| 1408 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1409 | size_t HInliner::CountRecursiveCallsOf(ArtMethod* method) const { |
| 1410 | const HInliner* current = this; |
| 1411 | size_t count = 0; |
| 1412 | do { |
| 1413 | if (current->graph_->GetArtMethod() == method) { |
| 1414 | ++count; |
| 1415 | } |
| 1416 | current = current->parent_; |
| 1417 | } while (current != nullptr); |
| 1418 | return count; |
| 1419 | } |
| 1420 | |
Vladimir Marko | 213ee2d | 2018-06-22 11:56:34 +0100 | [diff] [blame] | 1421 | static inline bool MayInline(const CompilerOptions& compiler_options, |
| 1422 | const DexFile& inlined_from, |
| 1423 | const DexFile& inlined_into) { |
| 1424 | if (kIsTargetBuild) { |
| 1425 | return true; |
| 1426 | } |
| 1427 | |
| 1428 | // We're not allowed to inline across dex files if we're the no-inline-from dex file. |
| 1429 | if (!IsSameDexFile(inlined_from, inlined_into) && |
| 1430 | ContainsElement(compiler_options.GetNoInlineFromDexFile(), &inlined_from)) { |
| 1431 | return false; |
| 1432 | } |
| 1433 | |
| 1434 | return true; |
| 1435 | } |
| 1436 | |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1437 | bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction, |
| 1438 | ArtMethod* method, |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1439 | ReferenceTypeInfo receiver_type, |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1440 | HInstruction** return_replacement) { |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1441 | if (method->IsProxyMethod()) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1442 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedProxy) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1443 | << "Method " << method->PrettyMethod() |
| 1444 | << " is not inlined because of unimplemented inline support for proxy methods."; |
| 1445 | return false; |
| 1446 | } |
| 1447 | |
| 1448 | if (CountRecursiveCallsOf(method) > kMaximumNumberOfRecursiveCalls) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1449 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRecursiveBudget) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1450 | << "Method " |
| 1451 | << method->PrettyMethod() |
| 1452 | << " is not inlined because it has reached its recursive call budget."; |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1453 | return false; |
| 1454 | } |
| 1455 | |
Jeff Hao | dcdc85b | 2015-12-04 14:06:18 -0800 | [diff] [blame] | 1456 | // Check whether we're allowed to inline. The outermost compilation unit is the relevant |
| 1457 | // dex file here (though the transitivity of an inline chain would allow checking the calller). |
Vladimir Marko | 213ee2d | 2018-06-22 11:56:34 +0100 | [diff] [blame] | 1458 | if (!MayInline(codegen_->GetCompilerOptions(), |
| 1459 | *method->GetDexFile(), |
| 1460 | *outer_compilation_unit_.GetDexFile())) { |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1461 | if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) { |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1462 | LOG_SUCCESS() << "Successfully replaced pattern of invoke " |
| 1463 | << method->PrettyMethod(); |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1464 | MaybeRecordStat(stats_, MethodCompilationStat::kReplacedInvokeWithSimplePattern); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1465 | return true; |
| 1466 | } |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1467 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedWont) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1468 | << "Won't inline " << method->PrettyMethod() << " in " |
| 1469 | << outer_compilation_unit_.GetDexFile()->GetLocation() << " (" |
| 1470 | << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from " |
| 1471 | << method->GetDexFile()->GetLocation(); |
Jeff Hao | dcdc85b | 2015-12-04 14:06:18 -0800 | [diff] [blame] | 1472 | return false; |
| 1473 | } |
| 1474 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 1475 | bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile()); |
| 1476 | |
David Sehr | 0225f8e | 2018-01-31 08:52:24 +0000 | [diff] [blame] | 1477 | CodeItemDataAccessor accessor(method->DexInstructionData()); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1478 | |
Mathieu Chartier | 808c7a5 | 2017-12-15 11:19:33 -0800 | [diff] [blame] | 1479 | if (!accessor.HasCodeItem()) { |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1480 | LOG_FAIL_NO_STAT() |
| 1481 | << "Method " << method->PrettyMethod() << " is not inlined because it is native"; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1482 | return false; |
| 1483 | } |
| 1484 | |
Vladimir Marko | 213ee2d | 2018-06-22 11:56:34 +0100 | [diff] [blame] | 1485 | size_t inline_max_code_units = codegen_->GetCompilerOptions().GetInlineMaxCodeUnits(); |
Mathieu Chartier | 808c7a5 | 2017-12-15 11:19:33 -0800 | [diff] [blame] | 1486 | if (accessor.InsnsSizeInCodeUnits() > inline_max_code_units) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1487 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCodeItem) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1488 | << "Method " << method->PrettyMethod() |
| 1489 | << " is not inlined because its code item is too big: " |
Mathieu Chartier | 808c7a5 | 2017-12-15 11:19:33 -0800 | [diff] [blame] | 1490 | << accessor.InsnsSizeInCodeUnits() |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1491 | << " > " |
| 1492 | << inline_max_code_units; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1493 | return false; |
| 1494 | } |
| 1495 | |
Mathieu Chartier | 808c7a5 | 2017-12-15 11:19:33 -0800 | [diff] [blame] | 1496 | if (accessor.TriesSize() != 0) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1497 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1498 | << "Method " << method->PrettyMethod() << " is not inlined because of try block"; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1499 | return false; |
| 1500 | } |
| 1501 | |
Nicolas Geoffray | 250a378 | 2016-04-20 16:27:53 +0100 | [diff] [blame] | 1502 | if (!method->IsCompilable()) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1503 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1504 | << "Method " << method->PrettyMethod() |
| 1505 | << " has soft failures un-handled by the compiler, so it cannot be inlined"; |
Aart Bik | 897df03 | 2018-02-07 13:29:11 -0800 | [diff] [blame] | 1506 | return false; |
Nicolas Geoffray | 250a378 | 2016-04-20 16:27:53 +0100 | [diff] [blame] | 1507 | } |
| 1508 | |
Aart Bik | 2c148f0 | 2018-02-02 14:30:35 -0800 | [diff] [blame] | 1509 | if (IsMethodUnverified(compiler_driver_, method)) { |
| 1510 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedNotVerified) |
| 1511 | << "Method " << method->PrettyMethod() |
| 1512 | << " couldn't be verified, so it cannot be inlined"; |
| 1513 | return false; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1514 | } |
| 1515 | |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 1516 | if (invoke_instruction->IsInvokeStaticOrDirect() && |
| 1517 | invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) { |
| 1518 | // Case of a static method that cannot be inlined because it implicitly |
| 1519 | // requires an initialization check of its declaring class. |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1520 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache) |
| 1521 | << "Method " << method->PrettyMethod() |
| 1522 | << " is not inlined because it is static and requires a clinit" |
| 1523 | << " check that cannot be emitted due to Dex cache limitations"; |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 1524 | return false; |
| 1525 | } |
| 1526 | |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1527 | if (!TryBuildAndInlineHelper( |
| 1528 | invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) { |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 1529 | return false; |
| 1530 | } |
| 1531 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1532 | LOG_SUCCESS() << method->PrettyMethod(); |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1533 | MaybeRecordStat(stats_, MethodCompilationStat::kInlinedInvoke); |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 1534 | return true; |
| 1535 | } |
| 1536 | |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1537 | static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction, |
| 1538 | size_t arg_vreg_index) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 1539 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1540 | size_t input_index = 0; |
| 1541 | for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) { |
| 1542 | DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments()); |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1543 | if (DataType::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) { |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1544 | ++i; |
| 1545 | DCHECK_NE(i, arg_vreg_index); |
| 1546 | } |
| 1547 | } |
| 1548 | DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments()); |
| 1549 | return invoke_instruction->InputAt(input_index); |
| 1550 | } |
| 1551 | |
| 1552 | // Try to recognize known simple patterns and replace invoke call with appropriate instructions. |
| 1553 | bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction, |
| 1554 | ArtMethod* resolved_method, |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1555 | HInstruction** return_replacement) { |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1556 | InlineMethod inline_method; |
| 1557 | if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) { |
| 1558 | return false; |
| 1559 | } |
| 1560 | |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1561 | switch (inline_method.opcode) { |
| 1562 | case kInlineOpNop: |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1563 | DCHECK_EQ(invoke_instruction->GetType(), DataType::Type::kVoid); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1564 | *return_replacement = nullptr; |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1565 | break; |
| 1566 | case kInlineOpReturnArg: |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1567 | *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, |
| 1568 | inline_method.d.return_data.arg); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1569 | break; |
| 1570 | case kInlineOpNonWideConst: |
| 1571 | if (resolved_method->GetShorty()[0] == 'L') { |
| 1572 | DCHECK_EQ(inline_method.d.data, 0u); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1573 | *return_replacement = graph_->GetNullConstant(); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1574 | } else { |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1575 | *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data)); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1576 | } |
| 1577 | break; |
| 1578 | case kInlineOpIGet: { |
| 1579 | const InlineIGetIPutData& data = inline_method.d.ifield_data; |
| 1580 | if (data.method_is_static || data.object_arg != 0u) { |
| 1581 | // TODO: Needs null check. |
| 1582 | return false; |
| 1583 | } |
| 1584 | HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg); |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1585 | HInstanceFieldGet* iget = CreateInstanceFieldGet(data.field_idx, resolved_method, obj); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1586 | DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset); |
| 1587 | DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile); |
| 1588 | invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1589 | *return_replacement = iget; |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1590 | break; |
| 1591 | } |
| 1592 | case kInlineOpIPut: { |
| 1593 | const InlineIGetIPutData& data = inline_method.d.ifield_data; |
| 1594 | if (data.method_is_static || data.object_arg != 0u) { |
| 1595 | // TODO: Needs null check. |
| 1596 | return false; |
| 1597 | } |
| 1598 | HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg); |
| 1599 | HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg); |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1600 | HInstanceFieldSet* iput = CreateInstanceFieldSet(data.field_idx, resolved_method, obj, value); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1601 | DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset); |
| 1602 | DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile); |
| 1603 | invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction); |
| 1604 | if (data.return_arg_plus1 != 0u) { |
| 1605 | size_t return_arg = data.return_arg_plus1 - 1u; |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1606 | *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1607 | } |
| 1608 | break; |
| 1609 | } |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1610 | case kInlineOpConstructor: { |
| 1611 | const InlineConstructorData& data = inline_method.d.constructor_data; |
| 1612 | // Get the indexes to arrays for easier processing. |
| 1613 | uint16_t iput_field_indexes[] = { |
| 1614 | data.iput0_field_index, data.iput1_field_index, data.iput2_field_index |
| 1615 | }; |
| 1616 | uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg }; |
| 1617 | static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch"); |
| 1618 | // Count valid field indexes. |
| 1619 | size_t number_of_iputs = 0u; |
| 1620 | while (number_of_iputs != arraysize(iput_field_indexes) && |
| 1621 | iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) { |
| 1622 | // Check that there are no duplicate valid field indexes. |
| 1623 | DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1, |
| 1624 | iput_field_indexes + arraysize(iput_field_indexes), |
| 1625 | iput_field_indexes[number_of_iputs])); |
| 1626 | ++number_of_iputs; |
| 1627 | } |
| 1628 | // Check that there are no valid field indexes in the rest of the array. |
| 1629 | DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs, |
| 1630 | iput_field_indexes + arraysize(iput_field_indexes), |
| 1631 | [](uint16_t index) { return index != DexFile::kDexNoIndex16; })); |
| 1632 | |
| 1633 | // Create HInstanceFieldSet for each IPUT that stores non-zero data. |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1634 | HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u); |
| 1635 | bool needs_constructor_barrier = false; |
| 1636 | for (size_t i = 0; i != number_of_iputs; ++i) { |
| 1637 | HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]); |
Roland Levillain | 1a65388 | 2016-03-18 18:05:57 +0000 | [diff] [blame] | 1638 | if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) { |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1639 | uint16_t field_index = iput_field_indexes[i]; |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1640 | bool is_final; |
| 1641 | HInstanceFieldSet* iput = |
| 1642 | CreateInstanceFieldSet(field_index, resolved_method, obj, value, &is_final); |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1643 | invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction); |
| 1644 | |
| 1645 | // Check whether the field is final. If it is, we need to add a barrier. |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1646 | if (is_final) { |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1647 | needs_constructor_barrier = true; |
| 1648 | } |
| 1649 | } |
| 1650 | } |
| 1651 | if (needs_constructor_barrier) { |
Igor Murashkin | d01745e | 2017-04-05 16:40:31 -0700 | [diff] [blame] | 1652 | // See CompilerDriver::RequiresConstructorBarrier for more details. |
| 1653 | DCHECK(obj != nullptr) << "only non-static methods can have a constructor fence"; |
| 1654 | |
| 1655 | HConstructorFence* constructor_fence = |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1656 | new (graph_->GetAllocator()) HConstructorFence(obj, kNoDexPc, graph_->GetAllocator()); |
Igor Murashkin | d01745e | 2017-04-05 16:40:31 -0700 | [diff] [blame] | 1657 | invoke_instruction->GetBlock()->InsertInstructionBefore(constructor_fence, |
| 1658 | invoke_instruction); |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1659 | } |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1660 | *return_replacement = nullptr; |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1661 | break; |
| 1662 | } |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1663 | default: |
| 1664 | LOG(FATAL) << "UNREACHABLE"; |
| 1665 | UNREACHABLE(); |
| 1666 | } |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1667 | return true; |
| 1668 | } |
| 1669 | |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1670 | HInstanceFieldGet* HInliner::CreateInstanceFieldGet(uint32_t field_index, |
| 1671 | ArtMethod* referrer, |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1672 | HInstruction* obj) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 1673 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1674 | ClassLinker* class_linker = Runtime::Current()->GetClassLinker(); |
| 1675 | ArtField* resolved_field = |
| 1676 | class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1677 | DCHECK(resolved_field != nullptr); |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1678 | HInstanceFieldGet* iget = new (graph_->GetAllocator()) HInstanceFieldGet( |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1679 | obj, |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 1680 | resolved_field, |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1681 | DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]), |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1682 | resolved_field->GetOffset(), |
| 1683 | resolved_field->IsVolatile(), |
| 1684 | field_index, |
| 1685 | resolved_field->GetDeclaringClass()->GetDexClassDefIndex(), |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1686 | *referrer->GetDexFile(), |
Vladimir Marko | adda435 | 2016-01-29 10:24:41 +0000 | [diff] [blame] | 1687 | // Read barrier generates a runtime call in slow path and we need a valid |
| 1688 | // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537. |
| 1689 | /* dex_pc */ 0); |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1690 | if (iget->GetType() == DataType::Type::kReference) { |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 1691 | // Use the same dex_cache that we used for field lookup as the hint_dex_cache. |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1692 | Handle<mirror::DexCache> dex_cache = handles_->NewHandle(referrer->GetDexCache()); |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 1693 | ReferenceTypePropagation rtp(graph_, |
| 1694 | outer_compilation_unit_.GetClassLoader(), |
| 1695 | dex_cache, |
| 1696 | handles_, |
| 1697 | /* is_first_run */ false); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1698 | rtp.Visit(iget); |
| 1699 | } |
| 1700 | return iget; |
| 1701 | } |
| 1702 | |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1703 | HInstanceFieldSet* HInliner::CreateInstanceFieldSet(uint32_t field_index, |
| 1704 | ArtMethod* referrer, |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1705 | HInstruction* obj, |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1706 | HInstruction* value, |
| 1707 | bool* is_final) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 1708 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1709 | ClassLinker* class_linker = Runtime::Current()->GetClassLinker(); |
| 1710 | ArtField* resolved_field = |
| 1711 | class_linker->LookupResolvedField(field_index, referrer, /* is_static */ false); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1712 | DCHECK(resolved_field != nullptr); |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1713 | if (is_final != nullptr) { |
| 1714 | // This information is needed only for constructors. |
| 1715 | DCHECK(referrer->IsConstructor()); |
| 1716 | *is_final = resolved_field->IsFinal(); |
| 1717 | } |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1718 | HInstanceFieldSet* iput = new (graph_->GetAllocator()) HInstanceFieldSet( |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1719 | obj, |
| 1720 | value, |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 1721 | resolved_field, |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1722 | DataType::FromShorty(resolved_field->GetTypeDescriptor()[0]), |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1723 | resolved_field->GetOffset(), |
| 1724 | resolved_field->IsVolatile(), |
| 1725 | field_index, |
| 1726 | resolved_field->GetDeclaringClass()->GetDexClassDefIndex(), |
Vladimir Marko | f44d36c | 2017-03-14 14:18:46 +0000 | [diff] [blame] | 1727 | *referrer->GetDexFile(), |
Vladimir Marko | adda435 | 2016-01-29 10:24:41 +0000 | [diff] [blame] | 1728 | // Read barrier generates a runtime call in slow path and we need a valid |
| 1729 | // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537. |
| 1730 | /* dex_pc */ 0); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1731 | return iput; |
| 1732 | } |
Nicolas Geoffray | d9994f0 | 2016-02-11 17:35:55 +0000 | [diff] [blame] | 1733 | |
Vladimir Marko | b1d0ee1 | 2017-04-20 19:50:32 +0100 | [diff] [blame] | 1734 | template <typename T> |
| 1735 | static inline Handle<T> NewHandleIfDifferent(T* object, |
| 1736 | Handle<T> hint, |
| 1737 | VariableSizedHandleScope* handles) |
| 1738 | REQUIRES_SHARED(Locks::mutator_lock_) { |
| 1739 | return (object != hint.Get()) ? handles->NewHandle(object) : hint; |
| 1740 | } |
| 1741 | |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1742 | bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction, |
| 1743 | ArtMethod* resolved_method, |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1744 | ReferenceTypeInfo receiver_type, |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1745 | bool same_dex_file, |
| 1746 | HInstruction** return_replacement) { |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1747 | DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid())); |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 1748 | ScopedObjectAccess soa(Thread::Current()); |
| 1749 | const DexFile::CodeItem* code_item = resolved_method->GetCodeItem(); |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 1750 | const DexFile& callee_dex_file = *resolved_method->GetDexFile(); |
| 1751 | uint32_t method_index = resolved_method->GetDexMethodIndex(); |
David Sehr | 0225f8e | 2018-01-31 08:52:24 +0000 | [diff] [blame] | 1752 | CodeItemDebugInfoAccessor code_item_accessor(resolved_method->DexInstructionDebugInfo()); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 1753 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Vladimir Marko | b1d0ee1 | 2017-04-20 19:50:32 +0100 | [diff] [blame] | 1754 | Handle<mirror::DexCache> dex_cache = NewHandleIfDifferent(resolved_method->GetDexCache(), |
| 1755 | caller_compilation_unit_.GetDexCache(), |
| 1756 | handles_); |
| 1757 | Handle<mirror::ClassLoader> class_loader = |
| 1758 | NewHandleIfDifferent(resolved_method->GetDeclaringClass()->GetClassLoader(), |
| 1759 | caller_compilation_unit_.GetClassLoader(), |
| 1760 | handles_); |
Nicolas Geoffray | f1aedb1 | 2016-07-28 03:49:14 +0100 | [diff] [blame] | 1761 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1762 | DexCompilationUnit dex_compilation_unit( |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 1763 | class_loader, |
Nicolas Geoffray | 5b82d33 | 2016-02-18 14:22:32 +0000 | [diff] [blame] | 1764 | class_linker, |
| 1765 | callee_dex_file, |
| 1766 | code_item, |
| 1767 | resolved_method->GetDeclaringClass()->GetDexClassDefIndex(), |
| 1768 | method_index, |
| 1769 | resolved_method->GetAccessFlags(), |
| 1770 | /* verified_method */ nullptr, |
| 1771 | dex_cache); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1772 | |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 1773 | InvokeType invoke_type = invoke_instruction->GetInvokeType(); |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 1774 | if (invoke_type == kInterface) { |
| 1775 | // We have statically resolved the dispatch. To please the class linker |
| 1776 | // at runtime, we change this call as if it was a virtual call. |
| 1777 | invoke_type = kVirtual; |
| 1778 | } |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 1779 | |
| 1780 | const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId(); |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1781 | HGraph* callee_graph = new (graph_->GetAllocator()) HGraph( |
| 1782 | graph_->GetAllocator(), |
| 1783 | graph_->GetArenaStack(), |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 1784 | callee_dex_file, |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 1785 | method_index, |
Vladimir Marko | a043111 | 2018-06-25 09:32:54 +0100 | [diff] [blame^] | 1786 | codegen_->GetCompilerOptions().GetInstructionSet(), |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 1787 | invoke_type, |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 1788 | graph_->IsDebuggable(), |
Nicolas Geoffray | b331feb | 2016-02-05 16:51:53 +0000 | [diff] [blame] | 1789 | /* osr */ false, |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 1790 | caller_instruction_counter); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 1791 | callee_graph->SetArtMethod(resolved_method); |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 1792 | |
Vladimir Marko | 438709f | 2017-02-23 18:56:13 +0000 | [diff] [blame] | 1793 | // When they are needed, allocate `inline_stats_` on the Arena instead |
Roland Levillain | a8013fd | 2016-04-04 15:34:31 +0100 | [diff] [blame] | 1794 | // of on the stack, as Clang might produce a stack frame too large |
| 1795 | // for this function, that would not fit the requirements of the |
| 1796 | // `-Wframe-larger-than` option. |
Vladimir Marko | 438709f | 2017-02-23 18:56:13 +0000 | [diff] [blame] | 1797 | if (stats_ != nullptr) { |
| 1798 | // Reuse one object for all inline attempts from this caller to keep Arena memory usage low. |
| 1799 | if (inline_stats_ == nullptr) { |
Vladimir Marko | ca6fff8 | 2017-10-03 14:49:14 +0100 | [diff] [blame] | 1800 | void* storage = graph_->GetAllocator()->Alloc<OptimizingCompilerStats>(kArenaAllocMisc); |
Vladimir Marko | 438709f | 2017-02-23 18:56:13 +0000 | [diff] [blame] | 1801 | inline_stats_ = new (storage) OptimizingCompilerStats; |
| 1802 | } else { |
| 1803 | inline_stats_->Reset(); |
| 1804 | } |
| 1805 | } |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 1806 | HGraphBuilder builder(callee_graph, |
Mathieu Chartier | 808c7a5 | 2017-12-15 11:19:33 -0800 | [diff] [blame] | 1807 | code_item_accessor, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1808 | &dex_compilation_unit, |
| 1809 | &outer_compilation_unit_, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1810 | compiler_driver_, |
Nicolas Geoffray | 83c8e27 | 2017-01-31 14:36:37 +0000 | [diff] [blame] | 1811 | codegen_, |
Vladimir Marko | 438709f | 2017-02-23 18:56:13 +0000 | [diff] [blame] | 1812 | inline_stats_, |
Nicolas Geoffray | 8eaa8e5 | 2017-11-13 17:47:50 +0000 | [diff] [blame] | 1813 | resolved_method->GetQuickenedInfo(), |
David Brazdil | dee58d6 | 2016-04-07 09:54:26 +0000 | [diff] [blame] | 1814 | handles_); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1815 | |
David Brazdil | dee58d6 | 2016-04-07 09:54:26 +0000 | [diff] [blame] | 1816 | if (builder.BuildGraph() != kAnalysisSuccess) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1817 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedCannotBuild) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1818 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1819 | << " could not be built, so cannot be inlined"; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1820 | return false; |
| 1821 | } |
| 1822 | |
Vladimir Marko | a043111 | 2018-06-25 09:32:54 +0100 | [diff] [blame^] | 1823 | if (!RegisterAllocator::CanAllocateRegistersFor( |
| 1824 | *callee_graph, codegen_->GetCompilerOptions().GetInstructionSet())) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1825 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedRegisterAllocator) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1826 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1827 | << " cannot be inlined because of the register allocator"; |
Nicolas Geoffray | 259136f | 2014-12-17 23:21:58 +0000 | [diff] [blame] | 1828 | return false; |
| 1829 | } |
| 1830 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1831 | size_t parameter_index = 0; |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1832 | bool run_rtp = false; |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1833 | for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions()); |
| 1834 | !instructions.Done(); |
| 1835 | instructions.Advance()) { |
| 1836 | HInstruction* current = instructions.Current(); |
| 1837 | if (current->IsParameterValue()) { |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1838 | HInstruction* argument = invoke_instruction->InputAt(parameter_index); |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1839 | if (argument->IsNullConstant()) { |
| 1840 | current->ReplaceWith(callee_graph->GetNullConstant()); |
| 1841 | } else if (argument->IsIntConstant()) { |
| 1842 | current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue())); |
| 1843 | } else if (argument->IsLongConstant()) { |
| 1844 | current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue())); |
| 1845 | } else if (argument->IsFloatConstant()) { |
| 1846 | current->ReplaceWith( |
| 1847 | callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue())); |
| 1848 | } else if (argument->IsDoubleConstant()) { |
| 1849 | current->ReplaceWith( |
| 1850 | callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue())); |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 1851 | } else if (argument->GetType() == DataType::Type::kReference) { |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1852 | if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) { |
| 1853 | run_rtp = true; |
| 1854 | current->SetReferenceTypeInfo(receiver_type); |
| 1855 | } else { |
| 1856 | current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo()); |
| 1857 | } |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1858 | current->AsParameterValue()->SetCanBeNull(argument->CanBeNull()); |
| 1859 | } |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1860 | ++parameter_index; |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1861 | } |
| 1862 | } |
| 1863 | |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1864 | // We have replaced formal arguments with actual arguments. If actual types |
| 1865 | // are more specific than the declared ones, run RTP again on the inner graph. |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 1866 | if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) { |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1867 | ReferenceTypePropagation(callee_graph, |
Vladimir Marko | 8d6768d | 2017-03-14 10:13:21 +0000 | [diff] [blame] | 1868 | outer_compilation_unit_.GetClassLoader(), |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1869 | dex_compilation_unit.GetDexCache(), |
| 1870 | handles_, |
| 1871 | /* is_first_run */ false).Run(); |
| 1872 | } |
| 1873 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1874 | RunOptimizations(callee_graph, code_item, dex_compilation_unit); |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 1875 | |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1876 | HBasicBlock* exit_block = callee_graph->GetExitBlock(); |
| 1877 | if (exit_block == nullptr) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1878 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1879 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1880 | << " could not be inlined because it has an infinite loop"; |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1881 | return false; |
| 1882 | } |
| 1883 | |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 1884 | bool has_one_return = false; |
Vladimir Marko | 6058455 | 2015-09-03 13:35:12 +0000 | [diff] [blame] | 1885 | for (HBasicBlock* predecessor : exit_block->GetPredecessors()) { |
| 1886 | if (predecessor->GetLastInstruction()->IsThrow()) { |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 1887 | if (invoke_instruction->GetBlock()->IsTryBlock()) { |
| 1888 | // TODO(ngeoffray): Support adding HTryBoundary in Hgraph::InlineInto. |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1889 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedTryCatch) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1890 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1891 | << " could not be inlined because one branch always throws and" |
| 1892 | << " caller is in a try/catch block"; |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 1893 | return false; |
| 1894 | } else if (graph_->GetExitBlock() == nullptr) { |
| 1895 | // TODO(ngeoffray): Support adding HExit in the caller graph. |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1896 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInfiniteLoop) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1897 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1898 | << " could not be inlined because one branch always throws and" |
| 1899 | << " caller does not have an exit block"; |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 1900 | return false; |
Nicolas Geoffray | 1eede6a | 2017-03-02 16:14:53 +0000 | [diff] [blame] | 1901 | } else if (graph_->HasIrreducibleLoops()) { |
| 1902 | // TODO(ngeoffray): Support re-computing loop information to graphs with |
| 1903 | // irreducible loops? |
| 1904 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1905 | << " could not be inlined because one branch always throws and" |
| 1906 | << " caller has irreducible loops"; |
| 1907 | return false; |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 1908 | } |
| 1909 | } else { |
| 1910 | has_one_return = true; |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1911 | } |
| 1912 | } |
Nicolas Geoffray | fdb7d63 | 2017-02-08 15:07:18 +0000 | [diff] [blame] | 1913 | |
| 1914 | if (!has_one_return) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1915 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedAlwaysThrows) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1916 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1917 | << " could not be inlined because it always throws"; |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1918 | return false; |
| 1919 | } |
| 1920 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1921 | size_t number_of_instructions = 0; |
Vladimir Marko | 2c45bc9 | 2016-10-25 16:54:12 +0100 | [diff] [blame] | 1922 | // Skip the entry block, it does not contain instructions that prevent inlining. |
| 1923 | for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) { |
David Sehr | c757dec | 2016-11-04 15:48:34 -0700 | [diff] [blame] | 1924 | if (block->IsLoopHeader()) { |
| 1925 | if (block->GetLoopInformation()->IsIrreducible()) { |
| 1926 | // Don't inline methods with irreducible loops, they could prevent some |
| 1927 | // optimizations to run. |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1928 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedIrreducibleLoop) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1929 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1930 | << " could not be inlined because it contains an irreducible loop"; |
David Sehr | c757dec | 2016-11-04 15:48:34 -0700 | [diff] [blame] | 1931 | return false; |
| 1932 | } |
| 1933 | if (!block->GetLoopInformation()->HasExitEdge()) { |
| 1934 | // Don't inline methods with loops without exit, since they cause the |
| 1935 | // loop information to be computed incorrectly when updating after |
| 1936 | // inlining. |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1937 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedLoopWithoutExit) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1938 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1939 | << " could not be inlined because it contains a loop with no exit"; |
David Sehr | c757dec | 2016-11-04 15:48:34 -0700 | [diff] [blame] | 1940 | return false; |
| 1941 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1942 | } |
| 1943 | |
| 1944 | for (HInstructionIterator instr_it(block->GetInstructions()); |
| 1945 | !instr_it.Done(); |
| 1946 | instr_it.Advance()) { |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1947 | if (++number_of_instructions >= inlining_budget_) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1948 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedInstructionBudget) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1949 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1950 | << " is not inlined because the outer method has reached" |
| 1951 | << " its instruction budget limit."; |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1952 | return false; |
| 1953 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1954 | HInstruction* current = instr_it.Current(); |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1955 | if (current->NeedsEnvironment() && |
| 1956 | (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters)) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1957 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedEnvironmentBudget) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1958 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1959 | << " is not inlined because its caller has reached" |
| 1960 | << " its environment budget limit."; |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 1961 | return false; |
| 1962 | } |
Nicolas Geoffray | 276d9da | 2015-02-02 18:24:11 +0000 | [diff] [blame] | 1963 | |
Nicolas Geoffray | fbdfa6d | 2017-02-03 10:43:13 +0000 | [diff] [blame] | 1964 | if (current->NeedsEnvironment() && |
| 1965 | !CanEncodeInlinedMethodInStackMap(*caller_compilation_unit_.GetDexFile(), |
| 1966 | resolved_method)) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1967 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedStackMaps) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1968 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1969 | << " could not be inlined because " << current->DebugName() |
| 1970 | << " needs an environment, is in a different dex file" |
| 1971 | << ", and cannot be encoded in the stack maps."; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1972 | return false; |
| 1973 | } |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1974 | |
Vladimir Marko | dc151b2 | 2015-10-15 18:02:30 +0100 | [diff] [blame] | 1975 | if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) { |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1976 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedDexCache) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1977 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1978 | << " could not be inlined because " << current->DebugName() |
| 1979 | << " it is in a different dex file and requires access to the dex cache"; |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1980 | return false; |
| 1981 | } |
Nicolas Geoffray | d930929 | 2015-10-31 22:21:31 +0000 | [diff] [blame] | 1982 | |
Nicolas Geoffray | d930929 | 2015-10-31 22:21:31 +0000 | [diff] [blame] | 1983 | if (current->IsUnresolvedStaticFieldGet() || |
| 1984 | current->IsUnresolvedInstanceFieldGet() || |
| 1985 | current->IsUnresolvedStaticFieldSet() || |
| 1986 | current->IsUnresolvedInstanceFieldSet()) { |
| 1987 | // Entrypoint for unresolved fields does not handle inlined frames. |
Vladimir Marko | cd09e1f | 2017-11-24 15:02:40 +0000 | [diff] [blame] | 1988 | LOG_FAIL(stats_, MethodCompilationStat::kNotInlinedUnresolvedEntrypoint) |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1989 | << "Method " << callee_dex_file.PrettyMethod(method_index) |
| 1990 | << " could not be inlined because it is using an unresolved" |
| 1991 | << " entrypoint"; |
Nicolas Geoffray | d930929 | 2015-10-31 22:21:31 +0000 | [diff] [blame] | 1992 | return false; |
| 1993 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1994 | } |
| 1995 | } |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 1996 | DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId()) |
| 1997 | << "No instructions can be added to the outer graph while inner graph is being built"; |
| 1998 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 1999 | // Inline the callee graph inside the caller graph. |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 2000 | const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId(); |
| 2001 | graph_->SetCurrentInstructionId(callee_instruction_counter); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 2002 | *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction); |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 2003 | // Update our budget for other inlining attempts in `caller_graph`. |
| 2004 | total_number_of_instructions_ += number_of_instructions; |
| 2005 | UpdateInliningBudget(); |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 2006 | |
| 2007 | DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId()) |
| 2008 | << "No instructions can be added to the inner graph during inlining into the outer graph"; |
| 2009 | |
Vladimir Marko | 438709f | 2017-02-23 18:56:13 +0000 | [diff] [blame] | 2010 | if (stats_ != nullptr) { |
| 2011 | DCHECK(inline_stats_ != nullptr); |
| 2012 | inline_stats_->AddTo(stats_); |
| 2013 | } |
| 2014 | |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 2015 | return true; |
| 2016 | } |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 2017 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 2018 | void HInliner::RunOptimizations(HGraph* callee_graph, |
| 2019 | const DexFile::CodeItem* code_item, |
| 2020 | const DexCompilationUnit& dex_compilation_unit) { |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 2021 | // Note: if the outermost_graph_ is being compiled OSR, we should not run any |
| 2022 | // optimization that could lead to a HDeoptimize. The following optimizations do not. |
Vladimir Marko | 438709f | 2017-02-23 18:56:13 +0000 | [diff] [blame] | 2023 | HDeadCodeElimination dce(callee_graph, inline_stats_, "dead_code_elimination$inliner"); |
Andreas Gampe | ca620d7 | 2016-11-08 08:09:33 -0800 | [diff] [blame] | 2024 | HConstantFolding fold(callee_graph, "constant_folding$inliner"); |
Vladimir Marko | 28e012a | 2017-12-07 11:22:59 +0000 | [diff] [blame] | 2025 | HSharpening sharpening(callee_graph, codegen_, compiler_driver_); |
Vladimir Marko | 6597946 | 2017-05-19 17:25:12 +0100 | [diff] [blame] | 2026 | InstructionSimplifier simplify(callee_graph, codegen_, compiler_driver_, inline_stats_); |
Vladimir Marko | 438709f | 2017-02-23 18:56:13 +0000 | [diff] [blame] | 2027 | IntrinsicsRecognizer intrinsics(callee_graph, inline_stats_); |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 2028 | |
| 2029 | HOptimization* optimizations[] = { |
| 2030 | &intrinsics, |
| 2031 | &sharpening, |
| 2032 | &simplify, |
| 2033 | &fold, |
| 2034 | &dce, |
| 2035 | }; |
| 2036 | |
| 2037 | for (size_t i = 0; i < arraysize(optimizations); ++i) { |
| 2038 | HOptimization* optimization = optimizations[i]; |
| 2039 | optimization->Run(); |
| 2040 | } |
| 2041 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 2042 | // Bail early for pathological cases on the environment (for example recursive calls, |
| 2043 | // or too large environment). |
| 2044 | if (total_number_of_dex_registers_ >= kMaximumNumberOfCumulatedDexRegisters) { |
| 2045 | LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod() |
| 2046 | << " will not be inlined because the outer method has reached" |
| 2047 | << " its environment budget limit."; |
| 2048 | return; |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 2049 | } |
| 2050 | |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 2051 | // Bail early if we know we already are over the limit. |
| 2052 | size_t number_of_instructions = CountNumberOfInstructions(callee_graph); |
| 2053 | if (number_of_instructions > inlining_budget_) { |
| 2054 | LOG_NOTE() << "Calls in " << callee_graph->GetArtMethod()->PrettyMethod() |
| 2055 | << " will not be inlined because the outer method has reached" |
| 2056 | << " its instruction budget limit. " << number_of_instructions; |
| 2057 | return; |
| 2058 | } |
| 2059 | |
Mathieu Chartier | 698ebbc | 2018-01-05 11:00:42 -0800 | [diff] [blame] | 2060 | CodeItemDataAccessor accessor(callee_graph->GetDexFile(), code_item); |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 2061 | HInliner inliner(callee_graph, |
| 2062 | outermost_graph_, |
| 2063 | codegen_, |
| 2064 | outer_compilation_unit_, |
| 2065 | dex_compilation_unit, |
| 2066 | compiler_driver_, |
| 2067 | handles_, |
| 2068 | inline_stats_, |
Mathieu Chartier | 808c7a5 | 2017-12-15 11:19:33 -0800 | [diff] [blame] | 2069 | total_number_of_dex_registers_ + accessor.RegistersSize(), |
Nicolas Geoffray | f6d4668 | 2017-02-28 17:41:45 +0000 | [diff] [blame] | 2070 | total_number_of_instructions_ + number_of_instructions, |
| 2071 | this, |
| 2072 | depth_ + 1); |
| 2073 | inliner.Run(); |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 2074 | } |
| 2075 | |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2076 | static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti, |
| 2077 | bool declared_can_be_null, |
| 2078 | HInstruction* actual_obj) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 2079 | REQUIRES_SHARED(Locks::mutator_lock_) { |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2080 | if (declared_can_be_null && !actual_obj->CanBeNull()) { |
| 2081 | return true; |
| 2082 | } |
| 2083 | |
| 2084 | ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo(); |
| 2085 | return (actual_rti.IsExact() && !declared_rti.IsExact()) || |
Nicolas Geoffray | 0f001b7 | 2017-01-04 16:46:23 +0000 | [diff] [blame] | 2086 | declared_rti.IsStrictSupertypeOf(actual_rti); |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2087 | } |
| 2088 | |
Vladimir Marko | b45528c | 2017-07-27 14:14:28 +0100 | [diff] [blame] | 2089 | ReferenceTypeInfo HInliner::GetClassRTI(ObjPtr<mirror::Class> klass) { |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2090 | return ReferenceTypePropagation::IsAdmissible(klass) |
| 2091 | ? ReferenceTypeInfo::Create(handles_->NewHandle(klass)) |
| 2092 | : graph_->GetInexactObjectRti(); |
| 2093 | } |
| 2094 | |
| 2095 | bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) { |
| 2096 | // If this is an instance call, test whether the type of the `this` argument |
| 2097 | // is more specific than the class which declares the method. |
| 2098 | if (!resolved_method->IsStatic()) { |
| 2099 | if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()), |
| 2100 | /* declared_can_be_null */ false, |
| 2101 | invoke_instruction->InputAt(0u))) { |
| 2102 | return true; |
| 2103 | } |
| 2104 | } |
| 2105 | |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2106 | // Iterate over the list of parameter types and test whether any of the |
| 2107 | // actual inputs has a more specific reference type than the type declared in |
| 2108 | // the signature. |
| 2109 | const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList(); |
| 2110 | for (size_t param_idx = 0, |
| 2111 | input_idx = resolved_method->IsStatic() ? 0 : 1, |
| 2112 | e = (param_list == nullptr ? 0 : param_list->Size()); |
| 2113 | param_idx < e; |
| 2114 | ++param_idx, ++input_idx) { |
| 2115 | HInstruction* input = invoke_instruction->InputAt(input_idx); |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 2116 | if (input->GetType() == DataType::Type::kReference) { |
Vladimir Marko | b45528c | 2017-07-27 14:14:28 +0100 | [diff] [blame] | 2117 | ObjPtr<mirror::Class> param_cls = resolved_method->LookupResolvedClassFromTypeIndex( |
| 2118 | param_list->GetTypeItem(param_idx).type_idx_); |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2119 | if (IsReferenceTypeRefinement(GetClassRTI(param_cls), |
| 2120 | /* declared_can_be_null */ true, |
| 2121 | input)) { |
| 2122 | return true; |
| 2123 | } |
| 2124 | } |
| 2125 | } |
| 2126 | |
| 2127 | return false; |
| 2128 | } |
| 2129 | |
| 2130 | bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction, |
| 2131 | HInstruction* return_replacement) { |
Alex Light | 68289a5 | 2015-12-15 17:30:30 -0800 | [diff] [blame] | 2132 | // Check the integrity of reference types and run another type propagation if needed. |
David Brazdil | 4833f5a | 2015-12-16 10:37:39 +0000 | [diff] [blame] | 2133 | if (return_replacement != nullptr) { |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 2134 | if (return_replacement->GetType() == DataType::Type::kReference) { |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2135 | // Test if the return type is a refinement of the declared return type. |
| 2136 | if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(), |
| 2137 | /* declared_can_be_null */ true, |
| 2138 | return_replacement)) { |
| 2139 | return true; |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 2140 | } else if (return_replacement->IsInstanceFieldGet()) { |
| 2141 | HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet(); |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 2142 | if (field_get->GetFieldInfo().GetField() == |
Vladimir Marko | b4eb1b1 | 2018-05-24 11:09:38 +0100 | [diff] [blame] | 2143 | GetClassRoot<mirror::Object>()->GetInstanceField(0)) { |
Nicolas Geoffray | c52b26d | 2016-12-19 09:18:07 +0000 | [diff] [blame] | 2144 | return true; |
| 2145 | } |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2146 | } |
| 2147 | } else if (return_replacement->IsInstanceOf()) { |
| 2148 | // Inlining InstanceOf into an If may put a tighter bound on reference types. |
| 2149 | return true; |
| 2150 | } |
| 2151 | } |
| 2152 | |
| 2153 | return false; |
| 2154 | } |
| 2155 | |
| 2156 | void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method, |
| 2157 | HInstruction* return_replacement) { |
| 2158 | if (return_replacement != nullptr) { |
Vladimir Marko | 0ebe0d8 | 2017-09-21 22:50:39 +0100 | [diff] [blame] | 2159 | if (return_replacement->GetType() == DataType::Type::kReference) { |
David Brazdil | 4833f5a | 2015-12-16 10:37:39 +0000 | [diff] [blame] | 2160 | if (!return_replacement->GetReferenceTypeInfo().IsValid()) { |
| 2161 | // Make sure that we have a valid type for the return. We may get an invalid one when |
| 2162 | // we inline invokes with multiple branches and create a Phi for the result. |
| 2163 | // TODO: we could be more precise by merging the phi inputs but that requires |
| 2164 | // some functionality from the reference type propagation. |
| 2165 | DCHECK(return_replacement->IsPhi()); |
Vladimir Marko | b45528c | 2017-07-27 14:14:28 +0100 | [diff] [blame] | 2166 | ObjPtr<mirror::Class> cls = resolved_method->LookupResolvedReturnType(); |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 2167 | return_replacement->SetReferenceTypeInfo(GetClassRTI(cls)); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 2168 | } |
Calin Juravle | cdfed3d | 2015-10-26 14:05:01 +0000 | [diff] [blame] | 2169 | } |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 2170 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 2171 | } |
| 2172 | |
| 2173 | } // namespace art |