blob: d7da46bbe7804349b57434ed4aef369008c81121 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Andreas Gampe542451c2016-07-26 09:02:02 -070020#include "base/enums.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000021#include "builder.h"
22#include "class_linker.h"
23#include "constant_folding.h"
24#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000025#include "dex/verified_method.h"
26#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000027#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010028#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "driver/dex_compilation_unit.h"
30#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010031#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000032#include "jit/jit.h"
33#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000034#include "mirror/class_loader.h"
35#include "mirror/dex_cache.h"
36#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010037#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010038#include "reference_type_propagation.h"
Matthew Gharritye9288852016-07-14 14:08:16 -070039#include "register_allocator_linear_scan.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000040#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010041#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000042#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000043#include "ssa_phi_elimination.h"
Mathieu Chartier0795f232016-09-27 18:43:30 -070044#include "scoped_thread_state_change-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000045#include "thread.h"
46
47namespace art {
48
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000049static constexpr size_t kMaximumNumberOfHInstructions = 32;
50
51// Limit the number of dex registers that we accumulate while inlining
52// to avoid creating large amount of nested environments.
53static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
54
55// Avoid inlining within a huge method due to memory pressure.
56static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070057
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000058void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010059 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
60 if ((compiler_options.GetInlineDepthLimit() == 0)
61 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
62 return;
63 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000064 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
65 return;
66 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000067 if (graph_->IsDebuggable()) {
68 // For simplicity, we currently never inline when the graph is debuggable. This avoids
69 // doing some logic in the runtime to discover if a method could have been inlined.
70 return;
71 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010072 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
73 DCHECK(!blocks.empty());
74 HBasicBlock* next_block = blocks[0];
75 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010076 // Because we are changing the graph when inlining, we need to remember the next block.
77 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010078 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010079 continue;
80 }
81 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010082 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000083 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
84 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010085 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070086 // As long as the call is not intrinsified, it is worth trying to inline.
87 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000088 // We use the original invoke type to ensure the resolution of the called method
89 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000090 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010091 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000092 std::string callee_name =
David Sehr709b0702016-10-13 09:12:37 -070093 outer_compilation_unit_.GetDexFile()->PrettyMethod(call->GetDexMethodIndex());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000094 bool should_inline = callee_name.find("$inline$") != std::string::npos;
95 CHECK(!should_inline) << "Could not inline " << callee_name;
96 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010097 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010098 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010099 std::string callee_name =
David Sehr709b0702016-10-13 09:12:37 -0700100 outer_compilation_unit_.GetDexFile()->PrettyMethod(call->GetDexMethodIndex());
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +0100101 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
102 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
103 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000104 }
105 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000106 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000107 }
108 }
109}
110
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100111static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700112 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100113 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
114}
115
116/**
117 * Given the `resolved_method` looked up in the dex cache, try to find
118 * the actual runtime target of an interface or virtual call.
119 * Return nullptr if the runtime target cannot be proven.
120 */
121static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700122 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100123 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
124 // No need to lookup further, the resolved method will be the target.
125 return resolved_method;
126 }
127
128 HInstruction* receiver = invoke->InputAt(0);
129 if (receiver->IsNullCheck()) {
130 // Due to multiple levels of inlining within the same pass, it might be that
131 // null check does not have the reference type of the actual receiver.
132 receiver = receiver->InputAt(0);
133 }
134 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000135 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
136 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100137 // We currently only support inlining with known receivers.
138 // TODO: Remove this check, we should be able to inline final methods
139 // on unknown receivers.
140 return nullptr;
141 } else if (info.GetTypeHandle()->IsInterface()) {
142 // Statically knowing that the receiver has an interface type cannot
143 // help us find what is the target method.
144 return nullptr;
145 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
146 // The method that we're trying to call is not in the receiver's class or super classes.
147 return nullptr;
Nicolas Geoffrayab5327d2016-03-18 11:36:20 +0000148 } else if (info.GetTypeHandle()->IsErroneous()) {
149 // If the type is erroneous, do not go further, as we are going to query the vtable or
150 // imt table, that we can only safely do on non-erroneous classes.
151 return nullptr;
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100152 }
153
154 ClassLinker* cl = Runtime::Current()->GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700155 PointerSize pointer_size = cl->GetImagePointerSize();
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100156 if (invoke->IsInvokeInterface()) {
157 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
158 resolved_method, pointer_size);
159 } else {
160 DCHECK(invoke->IsInvokeVirtual());
161 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
162 resolved_method, pointer_size);
163 }
164
165 if (resolved_method == nullptr) {
166 // The information we had on the receiver was not enough to find
167 // the target method. Since we check above the exact type of the receiver,
168 // the only reason this can happen is an IncompatibleClassChangeError.
169 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700170 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100171 // The information we had on the receiver was not enough to find
172 // the target method. Since we check above the exact type of the receiver,
173 // the only reason this can happen is an IncompatibleClassChangeError.
174 return nullptr;
175 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
176 // A final method has to be the target method.
177 return resolved_method;
178 } else if (info.IsExact()) {
179 // If we found a method and the receiver's concrete type is statically
180 // known, we know for sure the target.
181 return resolved_method;
182 } else {
183 // Even if we did find a method, the receiver type was not enough to
184 // statically find the runtime target.
185 return nullptr;
186 }
187}
188
189static uint32_t FindMethodIndexIn(ArtMethod* method,
190 const DexFile& dex_file,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000191 uint32_t name_and_signature_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700192 REQUIRES_SHARED(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100193 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100194 return method->GetDexMethodIndex();
195 } else {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000196 return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100197 }
198}
199
Andreas Gampea5b09a62016-11-17 15:21:22 -0800200static dex::TypeIndex FindClassIndexIn(mirror::Class* cls,
201 const DexFile& dex_file,
202 Handle<mirror::DexCache> dex_cache)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -0700203 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampea5b09a62016-11-17 15:21:22 -0800204 dex::TypeIndex index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100205 if (cls->GetDexCache() == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700206 DCHECK(cls->IsArrayClass()) << cls->PrettyClass();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000207 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Andreas Gampea5b09a62016-11-17 15:21:22 -0800208 } else if (!cls->GetDexTypeIndex().IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700209 DCHECK(cls->IsProxyClass()) << cls->PrettyClass();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100210 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100211 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100212 DCHECK_EQ(cls->GetDexCache(), dex_cache.Get());
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000213 index = cls->GetDexTypeIndex();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100214 // Update the dex cache to ensure the class is in. The generated code will
215 // consider it is. We make it safe by updating the dex cache, as other
216 // dex files might also load the class, and there is no guarantee the dex
217 // cache of the dex file of the class will be updated.
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000218 if (dex_cache->GetResolvedType(index) == nullptr) {
219 dex_cache->SetResolvedType(index, cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100220 }
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100221 } else {
222 index = cls->FindTypeIndexInOtherDexFile(dex_file);
223 // We cannot guarantee the entry in the dex cache will resolve to the same class,
224 // as there may be different class loaders. So only return the index if it's
225 // the right class in the dex cache already.
Andreas Gampea5b09a62016-11-17 15:21:22 -0800226 if (index.IsValid() && dex_cache->GetResolvedType(index) != cls) {
227 index = dex::TypeIndex::Invalid();
Nicolas Geoffray491617a2016-07-19 17:06:23 +0100228 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100229 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000230
231 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100232}
233
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000234class ScopedProfilingInfoInlineUse {
235 public:
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000236 explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self)
237 : method_(method),
238 self_(self),
239 // Fetch the profiling info ahead of using it. If it's null when fetching,
240 // we should not call JitCodeCache::DoneInlining.
241 profiling_info_(
242 Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000243 }
244
245 ~ScopedProfilingInfoInlineUse() {
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000246 if (profiling_info_ != nullptr) {
Andreas Gampe542451c2016-07-26 09:02:02 -0700247 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000248 DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size));
249 Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_);
250 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000251 }
252
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000253 ProfilingInfo* GetProfilingInfo() const { return profiling_info_; }
254
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000255 private:
256 ArtMethod* const method_;
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000257 Thread* const self_;
258 ProfilingInfo* const profiling_info_;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000259};
260
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000261static bool IsMonomorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
262 REQUIRES_SHARED(Locks::mutator_lock_) {
263 DCHECK_GE(InlineCache::kIndividualCacheSize, 2);
264 return classes->Get(0) != nullptr && classes->Get(1) == nullptr;
265}
266
267static bool IsMegamorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
268 REQUIRES_SHARED(Locks::mutator_lock_) {
269 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
270 if (classes->Get(i) == nullptr) {
271 return false;
272 }
273 }
274 return true;
275}
276
277static mirror::Class* GetMonomorphicType(Handle<mirror::ObjectArray<mirror::Class>> classes)
278 REQUIRES_SHARED(Locks::mutator_lock_) {
279 DCHECK(classes->Get(0) != nullptr);
280 return classes->Get(0);
281}
282
283static bool IsUninitialized(Handle<mirror::ObjectArray<mirror::Class>> classes)
284 REQUIRES_SHARED(Locks::mutator_lock_) {
285 return classes->Get(0) == nullptr;
286}
287
288static bool IsPolymorphic(Handle<mirror::ObjectArray<mirror::Class>> classes)
289 REQUIRES_SHARED(Locks::mutator_lock_) {
290 DCHECK_GE(InlineCache::kIndividualCacheSize, 3);
291 return classes->Get(1) != nullptr &&
292 classes->Get(InlineCache::kIndividualCacheSize - 1) == nullptr;
293}
294
Mingyao Yang063fc772016-08-02 11:02:54 -0700295ArtMethod* HInliner::TryCHADevirtualization(ArtMethod* resolved_method) {
296 if (!resolved_method->HasSingleImplementation()) {
297 return nullptr;
298 }
299 if (Runtime::Current()->IsAotCompiler()) {
300 // No CHA-based devirtulization for AOT compiler (yet).
301 return nullptr;
302 }
303 if (outermost_graph_->IsCompilingOsr()) {
304 // We do not support HDeoptimize in OSR methods.
305 return nullptr;
306 }
307 return resolved_method->GetSingleImplementation();
308}
309
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700310bool HInliner::TryInline(HInvoke* invoke_instruction) {
Orion Hodsonac141392017-01-13 11:53:47 +0000311 if (invoke_instruction->IsInvokeUnresolved() ||
312 invoke_instruction->IsInvokePolymorphic()) {
313 return false; // Don't bother to move further if we know the method is unresolved or an
314 // invoke-polymorphic.
Calin Juravle175dc732015-08-25 15:42:32 +0100315 }
316
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000317 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100318 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000319 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
David Sehr709b0702016-10-13 09:12:37 -0700320 VLOG(compiler) << "Try inlining " << caller_dex_file.PrettyMethod(method_index);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000321
Nicolas Geoffray35071052015-06-09 15:43:38 +0100322 // We can query the dex cache directly. The verifier has populated it already.
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100323 ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod();
Andreas Gampefd2140f2015-12-23 16:30:44 -0800324 ArtMethod* actual_method = nullptr;
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100325 if (resolved_method == nullptr) {
326 DCHECK(invoke_instruction->IsInvokeStaticOrDirect());
327 DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit());
328 VLOG(compiler) << "Not inlining a String.<init> method";
329 return false;
330 } else if (invoke_instruction->IsInvokeStaticOrDirect()) {
Andreas Gampefd2140f2015-12-23 16:30:44 -0800331 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000332 } else {
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100333 // Check if we can statically find the method.
334 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000335 }
336
Mingyao Yang063fc772016-08-02 11:02:54 -0700337 bool cha_devirtualize = false;
338 if (actual_method == nullptr) {
339 ArtMethod* method = TryCHADevirtualization(resolved_method);
340 if (method != nullptr) {
341 cha_devirtualize = true;
342 actual_method = method;
343 }
344 }
345
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100346 if (actual_method != nullptr) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700347 bool result = TryInlineAndReplace(invoke_instruction,
348 actual_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000349 ReferenceTypeInfo::CreateInvalid(),
Mingyao Yang063fc772016-08-02 11:02:54 -0700350 /* do_rtp */ true,
351 cha_devirtualize);
Calin Juravle69158982016-03-16 11:53:41 +0000352 if (result && !invoke_instruction->IsInvokeStaticOrDirect()) {
Mingyao Yang063fc772016-08-02 11:02:54 -0700353 if (cha_devirtualize) {
354 // Add dependency due to devirtulization. We've assumed resolved_method
355 // has single implementation.
356 outermost_graph_->AddCHASingleImplementationDependency(resolved_method);
357 MaybeRecordStat(kCHAInline);
358 } else {
359 MaybeRecordStat(kInlinedInvokeVirtualOrInterface);
360 }
Calin Juravle69158982016-03-16 11:53:41 +0000361 }
362 return result;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100363 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000364
Andreas Gampefd2140f2015-12-23 16:30:44 -0800365 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100366
367 // Check if we can use an inline cache.
368 ArtMethod* caller = graph_->GetArtMethod();
Calin Juravleffc87072016-04-20 14:22:09 +0100369 if (Runtime::Current()->UseJitCompilation()) {
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000370 // Under JIT, we should always know the caller.
371 DCHECK(caller != nullptr);
Nicolas Geoffray07e3ca92016-03-11 09:57:57 +0000372 ScopedProfilingInfoInlineUse spiis(caller, soa.Self());
373 ProfilingInfo* profiling_info = spiis.GetProfilingInfo();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000374 if (profiling_info != nullptr) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000375 StackHandleScope<1> hs(soa.Self());
376 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
377 Handle<mirror::ObjectArray<mirror::Class>> inline_cache = hs.NewHandle(
378 mirror::ObjectArray<mirror::Class>::Alloc(
379 soa.Self(),
380 class_linker->GetClassRoot(ClassLinker::kClassArrayClass),
381 InlineCache::kIndividualCacheSize));
382 if (inline_cache.Get() == nullptr) {
383 // We got an OOME. Just clear the exception, and don't inline.
384 DCHECK(soa.Self()->IsExceptionPending());
385 soa.Self()->ClearException();
386 VLOG(compiler) << "Out of memory in the compiler when trying to inline";
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000387 return false;
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000388 } else {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000389 Runtime::Current()->GetJit()->GetCodeCache()->CopyInlineCacheInto(
390 *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()),
391 inline_cache);
392 if (IsUninitialized(inline_cache)) {
393 VLOG(compiler) << "Interface or virtual call to "
394 << caller_dex_file.PrettyMethod(method_index)
395 << " is not hit and not inlined";
396 return false;
397 } else if (IsMonomorphic(inline_cache)) {
398 MaybeRecordStat(kMonomorphicCall);
399 if (outermost_graph_->IsCompilingOsr()) {
400 // If we are compiling OSR, we pretend this call is polymorphic, as we may come from the
401 // interpreter and it may have seen different receiver types.
402 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
403 } else {
404 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, inline_cache);
405 }
406 } else if (IsPolymorphic(inline_cache)) {
407 MaybeRecordStat(kPolymorphicCall);
408 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, inline_cache);
409 } else {
410 DCHECK(IsMegamorphic(inline_cache));
411 VLOG(compiler) << "Interface or virtual call to "
412 << caller_dex_file.PrettyMethod(method_index)
413 << " is megamorphic and not inlined";
414 MaybeRecordStat(kMegamorphicCall);
415 return false;
416 }
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000417 }
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100418 }
419 }
420
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100421 VLOG(compiler) << "Interface or virtual call to "
David Sehr709b0702016-10-13 09:12:37 -0700422 << caller_dex_file.PrettyMethod(method_index)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100423 << " could not be statically determined";
424 return false;
425}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000426
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000427HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
428 HInstruction* receiver,
429 uint32_t dex_pc) const {
430 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
431 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000432 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000433 receiver,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000434 field,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000435 Primitive::kPrimNot,
436 field->GetOffset(),
437 field->IsVolatile(),
438 field->GetDexFieldIndex(),
439 field->GetDeclaringClass()->GetDexClassDefIndex(),
440 *field->GetDexFile(),
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000441 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000442 // The class of a field is effectively final, and does not have any memory dependencies.
443 result->SetSideEffects(SideEffects::None());
444 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000445}
446
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100447bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
448 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000449 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000450 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
451 << invoke_instruction->DebugName();
452
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100453 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Andreas Gampea5b09a62016-11-17 15:21:22 -0800454 dex::TypeIndex class_index = FindClassIndexIn(
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000455 GetMonomorphicType(classes), caller_dex_file, caller_compilation_unit_.GetDexCache());
Andreas Gampea5b09a62016-11-17 15:21:22 -0800456 if (!class_index.IsValid()) {
David Sehr709b0702016-10-13 09:12:37 -0700457 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100458 << " from inline cache is not inlined because its class is not"
459 << " accessible to the caller";
460 return false;
461 }
462
463 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700464 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100465 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000466 resolved_method = GetMonomorphicType(classes)->FindVirtualMethodForInterface(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100467 resolved_method, pointer_size);
468 } else {
469 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000470 resolved_method = GetMonomorphicType(classes)->FindVirtualMethodForVirtual(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100471 resolved_method, pointer_size);
472 }
473 DCHECK(resolved_method != nullptr);
474 HInstruction* receiver = invoke_instruction->InputAt(0);
475 HInstruction* cursor = invoke_instruction->GetPrevious();
476 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000477 Handle<mirror::Class> handle = handles_->NewHandle(GetMonomorphicType(classes));
Mingyao Yang063fc772016-08-02 11:02:54 -0700478 if (!TryInlineAndReplace(invoke_instruction,
479 resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000480 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
Mingyao Yang063fc772016-08-02 11:02:54 -0700481 /* do_rtp */ false,
482 /* cha_devirtualize */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100483 return false;
484 }
485
486 // We successfully inlined, now add a guard.
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000487 AddTypeGuard(receiver,
488 cursor,
489 bb_cursor,
490 class_index,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000491 GetMonomorphicType(classes),
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000492 invoke_instruction,
493 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100494
495 // Run type propagation to get the guard typed, and eventually propagate the
496 // type of the receiver.
Vladimir Marko456307a2016-04-19 14:12:13 +0000497 ReferenceTypePropagation rtp_fixup(graph_,
498 outer_compilation_unit_.GetDexCache(),
499 handles_,
500 /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100501 rtp_fixup.Run();
502
503 MaybeRecordStat(kInlinedMonomorphicCall);
504 return true;
505}
506
Mingyao Yang063fc772016-08-02 11:02:54 -0700507void HInliner::AddCHAGuard(HInstruction* invoke_instruction,
508 uint32_t dex_pc,
509 HInstruction* cursor,
510 HBasicBlock* bb_cursor) {
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800511 HShouldDeoptimizeFlag* deopt_flag = new (graph_->GetArena())
512 HShouldDeoptimizeFlag(graph_->GetArena(), dex_pc);
513 HInstruction* compare = new (graph_->GetArena()) HNotEqual(
Mingyao Yang063fc772016-08-02 11:02:54 -0700514 deopt_flag, graph_->GetIntConstant(0, dex_pc));
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800515 HInstruction* deopt = new (graph_->GetArena()) HDeoptimize(compare, dex_pc);
Mingyao Yang063fc772016-08-02 11:02:54 -0700516
517 if (cursor != nullptr) {
518 bb_cursor->InsertInstructionAfter(deopt_flag, cursor);
519 } else {
520 bb_cursor->InsertInstructionBefore(deopt_flag, bb_cursor->GetFirstInstruction());
521 }
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800522 bb_cursor->InsertInstructionAfter(compare, deopt_flag);
523 bb_cursor->InsertInstructionAfter(deopt, compare);
524
525 // Add receiver as input to aid CHA guard optimization later.
526 deopt_flag->AddInput(invoke_instruction->InputAt(0));
527 DCHECK_EQ(deopt_flag->InputCount(), 1u);
Mingyao Yang063fc772016-08-02 11:02:54 -0700528 deopt->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
Mingyao Yangb0b051a2016-11-17 09:04:53 -0800529 outermost_graph_->IncrementNumberOfCHAGuards();
Mingyao Yang063fc772016-08-02 11:02:54 -0700530}
531
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000532HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
533 HInstruction* cursor,
534 HBasicBlock* bb_cursor,
Andreas Gampea5b09a62016-11-17 15:21:22 -0800535 dex::TypeIndex class_index,
Nicolas Geoffray56876342016-12-16 16:09:08 +0000536 mirror::Class* klass,
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000537 HInstruction* invoke_instruction,
538 bool with_deoptimization) {
Nicolas Geoffray56876342016-12-16 16:09:08 +0000539 ScopedAssertNoThreadSuspension sants("Adding compiler type guard");
540
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000541 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
542 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
543 class_linker, receiver, invoke_instruction->GetDexPc());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000544 if (cursor != nullptr) {
545 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
546 } else {
547 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
548 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000549
550 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
551 bool is_referrer = (klass == outermost_graph_->GetArtMethod()->GetDeclaringClass());
552 // Note that we will just compare the classes, so we don't need Java semantics access checks.
553 // Note that the type index and the dex file are relative to the method this type guard is
554 // inlined into.
555 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
556 class_index,
557 caller_dex_file,
558 is_referrer,
559 invoke_instruction->GetDexPc(),
560 /* needs_access_check */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000561 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
Nicolas Geoffray56876342016-12-16 16:09:08 +0000562 // Sharpen after adding the instruction, as the sharpening may remove inputs.
563 HSharpening::SharpenClass(load_class, klass, handles_, codegen_, compiler_driver_);
564
565 // TODO: Extend reference type propagation to understand the guard.
566 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000567 bb_cursor->InsertInstructionAfter(compare, load_class);
568 if (with_deoptimization) {
569 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
570 compare, invoke_instruction->GetDexPc());
571 bb_cursor->InsertInstructionAfter(deoptimize, compare);
572 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
573 }
574 return compare;
575}
576
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000577bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100578 ArtMethod* resolved_method,
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000579 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000580 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
581 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000582
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000583 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, classes)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000584 return true;
585 }
586
587 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700588 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000589 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
590
591 bool all_targets_inlined = true;
592 bool one_target_inlined = false;
593 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000594 if (classes->Get(i) == nullptr) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000595 break;
596 }
597 ArtMethod* method = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000598
599 Handle<mirror::Class> handle = handles_->NewHandle(classes->Get(i));
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000600 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000601 method = handle->FindVirtualMethodForInterface(resolved_method, pointer_size);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000602 } else {
603 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000604 method = handle->FindVirtualMethodForVirtual(resolved_method, pointer_size);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000605 }
606
607 HInstruction* receiver = invoke_instruction->InputAt(0);
608 HInstruction* cursor = invoke_instruction->GetPrevious();
609 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
610
Andreas Gampea5b09a62016-11-17 15:21:22 -0800611 dex::TypeIndex class_index = FindClassIndexIn(
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000612 handle.Get(), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000613 HInstruction* return_replacement = nullptr;
Andreas Gampea5b09a62016-11-17 15:21:22 -0800614 if (!class_index.IsValid() ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000615 !TryBuildAndInline(invoke_instruction,
616 method,
617 ReferenceTypeInfo::Create(handle, /* is_exact */ true),
618 &return_replacement)) {
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000619 all_targets_inlined = false;
620 } else {
621 one_target_inlined = true;
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000622
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000623 VLOG(compiler) << "Polymorphic call to " << ArtMethod::PrettyMethod(resolved_method)
624 << " has inlined " << ArtMethod::PrettyMethod(method);
625
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000626 // If we have inlined all targets before, and this receiver is the last seen,
627 // we deoptimize instead of keeping the original invoke instruction.
628 bool deoptimize = all_targets_inlined &&
629 (i != InlineCache::kIndividualCacheSize - 1) &&
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000630 (classes->Get(i + 1) == nullptr);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100631
632 if (outermost_graph_->IsCompilingOsr()) {
633 // We do not support HDeoptimize in OSR methods.
634 deoptimize = false;
635 }
Nicolas Geoffray56876342016-12-16 16:09:08 +0000636 HInstruction* compare = AddTypeGuard(receiver,
637 cursor,
638 bb_cursor,
639 class_index,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000640 handle.Get(),
Nicolas Geoffray56876342016-12-16 16:09:08 +0000641 invoke_instruction,
642 deoptimize);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000643 if (deoptimize) {
644 if (return_replacement != nullptr) {
645 invoke_instruction->ReplaceWith(return_replacement);
646 }
647 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
648 // Because the inline cache data can be populated concurrently, we force the end of the
649 // iteration. Otherhwise, we could see a new receiver type.
650 break;
651 } else {
652 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
653 }
654 }
655 }
656
657 if (!one_target_inlined) {
David Sehr709b0702016-10-13 09:12:37 -0700658 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000659 << " from inline cache is not inlined because none"
660 << " of its targets could be inlined";
661 return false;
662 }
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +0000663
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000664 MaybeRecordStat(kInlinedPolymorphicCall);
665
666 // Run type propagation to get the guards typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000667 ReferenceTypePropagation rtp_fixup(graph_,
668 outer_compilation_unit_.GetDexCache(),
669 handles_,
670 /* is_first_run */ false);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000671 rtp_fixup.Run();
672 return true;
673}
674
675void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
676 HInstruction* return_replacement,
677 HInstruction* invoke_instruction) {
678 uint32_t dex_pc = invoke_instruction->GetDexPc();
679 HBasicBlock* cursor_block = compare->GetBlock();
680 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
681 ArenaAllocator* allocator = graph_->GetArena();
682
683 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
684 // and the returned block is the start of the then branch (that could contain multiple blocks).
685 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
686
687 // Split the block containing the invoke before and after the invoke. The returned block
688 // of the split before will contain the invoke and will be the otherwise branch of
689 // the diamond. The returned block of the split after will be the merge block
690 // of the diamond.
691 HBasicBlock* end_then = invoke_instruction->GetBlock();
692 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
693 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
694
695 // If the methods we are inlining return a value, we create a phi in the merge block
696 // that will have the `invoke_instruction and the `return_replacement` as inputs.
697 if (return_replacement != nullptr) {
698 HPhi* phi = new (allocator) HPhi(
699 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
700 merge->AddPhi(phi);
701 invoke_instruction->ReplaceWith(phi);
702 phi->AddInput(return_replacement);
703 phi->AddInput(invoke_instruction);
704 }
705
706 // Add the control flow instructions.
707 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
708 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
709 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
710
711 // Add the newly created blocks to the graph.
712 graph_->AddBlock(then);
713 graph_->AddBlock(otherwise);
714 graph_->AddBlock(merge);
715
716 // Set up successor (and implictly predecessor) relations.
717 cursor_block->AddSuccessor(otherwise);
718 cursor_block->AddSuccessor(then);
719 end_then->AddSuccessor(merge);
720 otherwise->AddSuccessor(merge);
721
722 // Set up dominance information.
723 then->SetDominator(cursor_block);
724 cursor_block->AddDominatedBlock(then);
725 otherwise->SetDominator(cursor_block);
726 cursor_block->AddDominatedBlock(otherwise);
727 merge->SetDominator(cursor_block);
728 cursor_block->AddDominatedBlock(merge);
729
730 // Update the revert post order.
731 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
732 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
733 graph_->reverse_post_order_[++index] = then;
734 index = IndexOfElement(graph_->reverse_post_order_, end_then);
735 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
736 graph_->reverse_post_order_[++index] = otherwise;
737 graph_->reverse_post_order_[++index] = merge;
738
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000739
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +0000740 graph_->UpdateLoopAndTryInformationOfNewBlock(
741 then, original_invoke_block, /* replace_if_back_edge */ false);
742 graph_->UpdateLoopAndTryInformationOfNewBlock(
743 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
744
745 // In case the original invoke location was a back edge, we need to update
746 // the loop to now have the merge block as a back edge.
747 graph_->UpdateLoopAndTryInformationOfNewBlock(
748 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000749}
750
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000751bool HInliner::TryInlinePolymorphicCallToSameTarget(
752 HInvoke* invoke_instruction,
753 ArtMethod* resolved_method,
754 Handle<mirror::ObjectArray<mirror::Class>> classes) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000755 // This optimization only works under JIT for now.
Calin Juravleffc87072016-04-20 14:22:09 +0100756 DCHECK(Runtime::Current()->UseJitCompilation());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000757 if (graph_->GetInstructionSet() == kMips64) {
758 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000759 return false;
760 }
761 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Andreas Gampe542451c2016-07-26 09:02:02 -0700762 PointerSize pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000763
764 DCHECK(resolved_method != nullptr);
765 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000766 size_t method_index = invoke_instruction->IsInvokeVirtual()
767 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
768 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
769
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000770 // Check whether we are actually calling the same method among
771 // the different types seen.
772 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000773 if (classes->Get(i) == nullptr) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000774 break;
775 }
776 ArtMethod* new_method = nullptr;
777 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000778 new_method = classes->Get(i)->GetImt(pointer_size)->Get(
Matthew Gharrity465ecc82016-07-19 21:32:52 +0000779 method_index, pointer_size);
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000780 if (new_method->IsRuntimeMethod()) {
781 // Bail out as soon as we see a conflict trampoline in one of the target's
782 // interface table.
783 return false;
784 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000785 } else {
786 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffraye51ca8b2016-11-22 14:49:31 +0000787 new_method = classes->Get(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000788 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000789 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000790 if (actual_method == nullptr) {
791 actual_method = new_method;
792 } else if (actual_method != new_method) {
793 // Different methods, bailout.
David Sehr709b0702016-10-13 09:12:37 -0700794 VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method)
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000795 << " from inline cache is not inlined because it resolves"
796 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000797 return false;
798 }
799 }
800
801 HInstruction* receiver = invoke_instruction->InputAt(0);
802 HInstruction* cursor = invoke_instruction->GetPrevious();
803 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
804
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100805 HInstruction* return_replacement = nullptr;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000806 if (!TryBuildAndInline(invoke_instruction,
807 actual_method,
808 ReferenceTypeInfo::CreateInvalid(),
809 &return_replacement)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000810 return false;
811 }
812
813 // We successfully inlined, now add a guard.
814 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
815 class_linker, receiver, invoke_instruction->GetDexPc());
816
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000817 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
818 ? Primitive::kPrimLong
819 : Primitive::kPrimInt;
820 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
821 receiver_class,
822 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +0000823 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
824 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000825 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000826 invoke_instruction->GetDexPc());
827
828 HConstant* constant;
829 if (type == Primitive::kPrimLong) {
830 constant = graph_->GetLongConstant(
831 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
832 } else {
833 constant = graph_->GetIntConstant(
834 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
835 }
836
837 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000838 if (cursor != nullptr) {
839 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
840 } else {
841 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
842 }
843 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
844 bb_cursor->InsertInstructionAfter(compare, class_table_get);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100845
846 if (outermost_graph_->IsCompilingOsr()) {
847 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
848 } else {
849 // TODO: Extend reference type propagation to understand the guard.
850 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
851 compare, invoke_instruction->GetDexPc());
852 bb_cursor->InsertInstructionAfter(deoptimize, compare);
853 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
854 if (return_replacement != nullptr) {
855 invoke_instruction->ReplaceWith(return_replacement);
856 }
Nicolas Geoffray1be7cbd2016-04-29 13:56:01 +0100857 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100858 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000859
860 // Run type propagation to get the guard typed.
Vladimir Marko456307a2016-04-19 14:12:13 +0000861 ReferenceTypePropagation rtp_fixup(graph_,
862 outer_compilation_unit_.GetDexCache(),
863 handles_,
864 /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000865 rtp_fixup.Run();
866
867 MaybeRecordStat(kInlinedPolymorphicCall);
868
869 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100870}
871
Mingyao Yang063fc772016-08-02 11:02:54 -0700872bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction,
873 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000874 ReferenceTypeInfo receiver_type,
Mingyao Yang063fc772016-08-02 11:02:54 -0700875 bool do_rtp,
876 bool cha_devirtualize) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000877 HInstruction* return_replacement = nullptr;
Mingyao Yang063fc772016-08-02 11:02:54 -0700878 uint32_t dex_pc = invoke_instruction->GetDexPc();
879 HInstruction* cursor = invoke_instruction->GetPrevious();
880 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000881 if (!TryBuildAndInline(invoke_instruction, method, receiver_type, &return_replacement)) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000882 if (invoke_instruction->IsInvokeInterface()) {
883 // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always
884 // better than an invoke-interface because:
885 // 1) In the best case, the interface call has one more indirection (to fetch the IMT).
886 // 2) We will not go to the conflict trampoline with an invoke-virtual.
887 // TODO: Consider sharpening once it is not dependent on the compiler driver.
888 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100889 uint32_t dex_method_index = FindMethodIndexIn(
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000890 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100891 if (dex_method_index == DexFile::kDexNoIndex) {
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000892 return false;
893 }
894 HInvokeVirtual* new_invoke = new (graph_->GetArena()) HInvokeVirtual(
895 graph_->GetArena(),
896 invoke_instruction->GetNumberOfArguments(),
897 invoke_instruction->GetType(),
898 invoke_instruction->GetDexPc(),
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +0100899 dex_method_index,
900 method,
Nicolas Geoffray5bf7bac2016-07-06 14:18:23 +0000901 method->GetMethodIndex());
902 HInputsRef inputs = invoke_instruction->GetInputs();
903 for (size_t index = 0; index != inputs.size(); ++index) {
904 new_invoke->SetArgumentAt(index, inputs[index]);
905 }
906 invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction);
907 new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
908 if (invoke_instruction->GetType() == Primitive::kPrimNot) {
909 new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo());
910 }
911 return_replacement = new_invoke;
912 } else {
913 // TODO: Consider sharpening an invoke virtual once it is not dependent on the
914 // compiler driver.
915 return false;
916 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000917 }
Mingyao Yang063fc772016-08-02 11:02:54 -0700918 if (cha_devirtualize) {
919 AddCHAGuard(invoke_instruction, dex_pc, cursor, bb_cursor);
920 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000921 if (return_replacement != nullptr) {
922 invoke_instruction->ReplaceWith(return_replacement);
923 }
924 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
David Brazdil94ab38f2016-06-21 17:48:19 +0100925 FixUpReturnReferenceType(method, return_replacement);
926 if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) {
927 // Actual return value has a more specific type than the method's declared
928 // return type. Run RTP again on the outer graph to propagate it.
929 ReferenceTypePropagation(graph_,
930 outer_compilation_unit_.GetDexCache(),
931 handles_,
932 /* is_first_run */ false).Run();
933 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000934 return true;
935}
936
937bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
938 ArtMethod* method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +0000939 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000940 HInstruction** return_replacement) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100941 if (method->IsProxyMethod()) {
David Sehr709b0702016-10-13 09:12:37 -0700942 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray93a18c52016-04-22 13:16:14 +0100943 << " is not inlined because of unimplemented inline support for proxy methods.";
944 return false;
945 }
946
Jeff Haodcdc85b2015-12-04 14:06:18 -0800947 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
948 // dex file here (though the transitivity of an inline chain would allow checking the calller).
949 if (!compiler_driver_->MayInline(method->GetDexFile(),
950 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000951 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
David Sehr709b0702016-10-13 09:12:37 -0700952 VLOG(compiler) << "Successfully replaced pattern of invoke "
953 << method->PrettyMethod();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000954 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
955 return true;
956 }
David Sehr709b0702016-10-13 09:12:37 -0700957 VLOG(compiler) << "Won't inline " << method->PrettyMethod() << " in "
Jeff Haodcdc85b2015-12-04 14:06:18 -0800958 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
959 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
960 << method->GetDexFile()->GetLocation();
961 return false;
962 }
963
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100964 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
965
966 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000967
968 if (code_item == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -0700969 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000970 << " is not inlined because it is native";
971 return false;
972 }
973
Calin Juravleec748352015-07-29 13:52:12 +0100974 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
975 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
David Sehr709b0702016-10-13 09:12:37 -0700976 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000977 << " is too big to inline: "
978 << code_item->insns_size_in_code_units_
979 << " > "
980 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000981 return false;
982 }
983
984 if (code_item->tries_size_ != 0) {
David Sehr709b0702016-10-13 09:12:37 -0700985 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000986 << " is not inlined because of try block";
987 return false;
988 }
989
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100990 if (!method->IsCompilable()) {
David Sehr709b0702016-10-13 09:12:37 -0700991 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffray250a3782016-04-20 16:27:53 +0100992 << " has soft failures un-handled by the compiler, so it cannot be inlined";
993 }
994
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100995 if (!method->GetDeclaringClass()->IsVerified()) {
996 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Calin Juravleffc87072016-04-20 14:22:09 +0100997 if (Runtime::Current()->UseJitCompilation() ||
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000998 !compiler_driver_->IsMethodVerifiedWithoutFailures(
999 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
David Sehr709b0702016-10-13 09:12:37 -07001000 VLOG(compiler) << "Method " << method->PrettyMethod()
Nicolas Geoffrayccc61972015-10-01 14:34:20 +01001001 << " couldn't be verified, so it cannot be inlined";
1002 return false;
1003 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001004 }
1005
Roland Levillain4c0eb422015-04-24 16:43:49 +01001006 if (invoke_instruction->IsInvokeStaticOrDirect() &&
1007 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
1008 // Case of a static method that cannot be inlined because it implicitly
1009 // requires an initialization check of its declaring class.
David Sehr709b0702016-10-13 09:12:37 -07001010 VLOG(compiler) << "Method " << method->PrettyMethod()
Roland Levillain4c0eb422015-04-24 16:43:49 +01001011 << " is not inlined because it is static and requires a clinit"
1012 << " check that cannot be emitted due to Dex cache limitations";
1013 return false;
1014 }
1015
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001016 if (!TryBuildAndInlineHelper(
1017 invoke_instruction, method, receiver_type, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001018 return false;
1019 }
1020
David Sehr709b0702016-10-13 09:12:37 -07001021 VLOG(compiler) << "Successfully inlined " << method->PrettyMethod();
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001022 MaybeRecordStat(kInlinedInvoke);
1023 return true;
1024}
1025
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001026static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
1027 size_t arg_vreg_index)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001028 REQUIRES_SHARED(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001029 size_t input_index = 0;
1030 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
1031 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1032 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
1033 ++i;
1034 DCHECK_NE(i, arg_vreg_index);
1035 }
1036 }
1037 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
1038 return invoke_instruction->InputAt(input_index);
1039}
1040
1041// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
1042bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
1043 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001044 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001045 InlineMethod inline_method;
1046 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
1047 return false;
1048 }
1049
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001050 switch (inline_method.opcode) {
1051 case kInlineOpNop:
1052 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001053 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001054 break;
1055 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001056 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
1057 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001058 break;
1059 case kInlineOpNonWideConst:
1060 if (resolved_method->GetShorty()[0] == 'L') {
1061 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001062 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001063 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001064 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001065 }
1066 break;
1067 case kInlineOpIGet: {
1068 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1069 if (data.method_is_static || data.object_arg != 0u) {
1070 // TODO: Needs null check.
1071 return false;
1072 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001073 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001074 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +00001075 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001076 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
1077 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
1078 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001079 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001080 break;
1081 }
1082 case kInlineOpIPut: {
1083 const InlineIGetIPutData& data = inline_method.d.ifield_data;
1084 if (data.method_is_static || data.object_arg != 0u) {
1085 // TODO: Needs null check.
1086 return false;
1087 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001088 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001089 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
1090 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +00001091 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001092 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
1093 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
1094 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1095 if (data.return_arg_plus1 != 0u) {
1096 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001097 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001098 }
1099 break;
1100 }
Vladimir Marko354efa62016-02-04 19:46:56 +00001101 case kInlineOpConstructor: {
1102 const InlineConstructorData& data = inline_method.d.constructor_data;
1103 // Get the indexes to arrays for easier processing.
1104 uint16_t iput_field_indexes[] = {
1105 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
1106 };
1107 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
1108 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
1109 // Count valid field indexes.
1110 size_t number_of_iputs = 0u;
1111 while (number_of_iputs != arraysize(iput_field_indexes) &&
1112 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
1113 // Check that there are no duplicate valid field indexes.
1114 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
1115 iput_field_indexes + arraysize(iput_field_indexes),
1116 iput_field_indexes[number_of_iputs]));
1117 ++number_of_iputs;
1118 }
1119 // Check that there are no valid field indexes in the rest of the array.
1120 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
1121 iput_field_indexes + arraysize(iput_field_indexes),
1122 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
1123
1124 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
1125 Handle<mirror::DexCache> dex_cache;
1126 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
1127 bool needs_constructor_barrier = false;
1128 for (size_t i = 0; i != number_of_iputs; ++i) {
1129 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
Roland Levillain1a653882016-03-18 18:05:57 +00001130 if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) {
Vladimir Marko354efa62016-02-04 19:46:56 +00001131 if (dex_cache.GetReference() == nullptr) {
1132 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
1133 }
1134 uint16_t field_index = iput_field_indexes[i];
1135 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
1136 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
1137
1138 // Check whether the field is final. If it is, we need to add a barrier.
Andreas Gampe542451c2016-07-26 09:02:02 -07001139 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Marko354efa62016-02-04 19:46:56 +00001140 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1141 DCHECK(resolved_field != nullptr);
1142 if (resolved_field->IsFinal()) {
1143 needs_constructor_barrier = true;
1144 }
1145 }
1146 }
1147 if (needs_constructor_barrier) {
1148 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
1149 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
1150 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001151 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +00001152 break;
1153 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001154 default:
1155 LOG(FATAL) << "UNREACHABLE";
1156 UNREACHABLE();
1157 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001158 return true;
1159}
1160
Vladimir Marko354efa62016-02-04 19:46:56 +00001161HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001162 uint32_t field_index,
1163 HInstruction* obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001164 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001165 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001166 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1167 DCHECK(resolved_field != nullptr);
1168 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
1169 obj,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001170 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001171 resolved_field->GetTypeAsPrimitiveType(),
1172 resolved_field->GetOffset(),
1173 resolved_field->IsVolatile(),
1174 field_index,
1175 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001176 *dex_cache->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001177 // Read barrier generates a runtime call in slow path and we need a valid
1178 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1179 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001180 if (iget->GetType() == Primitive::kPrimNot) {
Vladimir Marko456307a2016-04-19 14:12:13 +00001181 // Use the same dex_cache that we used for field lookup as the hint_dex_cache.
1182 ReferenceTypePropagation rtp(graph_, dex_cache, handles_, /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001183 rtp.Visit(iget);
1184 }
1185 return iget;
1186}
1187
Vladimir Marko354efa62016-02-04 19:46:56 +00001188HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001189 uint32_t field_index,
1190 HInstruction* obj,
1191 HInstruction* value)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001192 REQUIRES_SHARED(Locks::mutator_lock_) {
Andreas Gampe542451c2016-07-26 09:02:02 -07001193 PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001194 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
1195 DCHECK(resolved_field != nullptr);
1196 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
1197 obj,
1198 value,
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001199 resolved_field,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001200 resolved_field->GetTypeAsPrimitiveType(),
1201 resolved_field->GetOffset(),
1202 resolved_field->IsVolatile(),
1203 field_index,
1204 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +00001205 *dex_cache->GetDexFile(),
Vladimir Markoadda4352016-01-29 10:24:41 +00001206 // Read barrier generates a runtime call in slow path and we need a valid
1207 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
1208 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001209 return iput;
1210}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001211
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001212bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
1213 ArtMethod* resolved_method,
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001214 ReferenceTypeInfo receiver_type,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001215 bool same_dex_file,
1216 HInstruction** return_replacement) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001217 DCHECK(!(resolved_method->IsStatic() && receiver_type.IsValid()));
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +00001218 ScopedObjectAccess soa(Thread::Current());
1219 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001220 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
1221 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +00001222 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -07001223 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001224 Handle<mirror::ClassLoader> class_loader(handles_->NewHandle(
1225 resolved_method->GetDeclaringClass()->GetClassLoader()));
1226
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001227 DexCompilationUnit dex_compilation_unit(
Nicolas Geoffrayf1aedb12016-07-28 03:49:14 +01001228 class_loader.ToJObject(),
Nicolas Geoffray5b82d332016-02-18 14:22:32 +00001229 class_linker,
1230 callee_dex_file,
1231 code_item,
1232 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1233 method_index,
1234 resolved_method->GetAccessFlags(),
1235 /* verified_method */ nullptr,
1236 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001237
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001238 bool requires_ctor_barrier = false;
1239
1240 if (dex_compilation_unit.IsConstructor()) {
1241 // If it's a super invocation and we already generate a barrier there's no need
1242 // to generate another one.
1243 // We identify super calls by looking at the "this" pointer. If its value is the
1244 // same as the local "this" pointer then we must have a super invocation.
1245 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1246 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1247 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1248 requires_ctor_barrier = false;
1249 } else {
1250 Thread* self = Thread::Current();
1251 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1252 dex_compilation_unit.GetDexFile(),
1253 dex_compilation_unit.GetClassDefIndex());
1254 }
1255 }
1256
Nicolas Geoffray5e4e11e2016-09-22 13:17:41 +01001257 InvokeType invoke_type = invoke_instruction->GetInvokeType();
Nicolas Geoffray35071052015-06-09 15:43:38 +01001258 if (invoke_type == kInterface) {
1259 // We have statically resolved the dispatch. To please the class linker
1260 // at runtime, we change this call as if it was a virtual call.
1261 invoke_type = kVirtual;
1262 }
David Brazdil3f523062016-02-29 16:53:33 +00001263
1264 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001265 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001266 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001267 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001268 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001269 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001270 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001271 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001272 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001273 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001274 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001275 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001276
Roland Levillaina8013fd2016-04-04 15:34:31 +01001277 // When they are needed, allocate `inline_stats` on the heap instead
1278 // of on the stack, as Clang might produce a stack frame too large
1279 // for this function, that would not fit the requirements of the
1280 // `-Wframe-larger-than` option.
1281 std::unique_ptr<OptimizingCompilerStats> inline_stats =
1282 (stats_ == nullptr) ? nullptr : MakeUnique<OptimizingCompilerStats>();
David Brazdil5e8b1372015-01-23 14:39:08 +00001283 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001284 &dex_compilation_unit,
1285 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001286 resolved_method->GetDexFile(),
David Brazdil86ea7ee2016-02-16 09:26:07 +00001287 *code_item,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001288 compiler_driver_,
Roland Levillaina8013fd2016-04-04 15:34:31 +01001289 inline_stats.get(),
Vladimir Marko97d7e1c2016-10-04 14:44:28 +01001290 resolved_method->GetQuickenedInfo(class_linker->GetImagePointerSize()),
David Brazdildee58d62016-04-07 09:54:26 +00001291 dex_cache,
1292 handles_);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001293
David Brazdildee58d62016-04-07 09:54:26 +00001294 if (builder.BuildGraph() != kAnalysisSuccess) {
David Sehr709b0702016-10-13 09:12:37 -07001295 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001296 << " could not be built, so cannot be inlined";
1297 return false;
1298 }
1299
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001300 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1301 compiler_driver_->GetInstructionSet())) {
David Sehr709b0702016-10-13 09:12:37 -07001302 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001303 << " cannot be inlined because of the register allocator";
1304 return false;
1305 }
1306
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001307 size_t parameter_index = 0;
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001308 bool run_rtp = false;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001309 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1310 !instructions.Done();
1311 instructions.Advance()) {
1312 HInstruction* current = instructions.Current();
1313 if (current->IsParameterValue()) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001314 HInstruction* argument = invoke_instruction->InputAt(parameter_index);
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001315 if (argument->IsNullConstant()) {
1316 current->ReplaceWith(callee_graph->GetNullConstant());
1317 } else if (argument->IsIntConstant()) {
1318 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1319 } else if (argument->IsLongConstant()) {
1320 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1321 } else if (argument->IsFloatConstant()) {
1322 current->ReplaceWith(
1323 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1324 } else if (argument->IsDoubleConstant()) {
1325 current->ReplaceWith(
1326 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1327 } else if (argument->GetType() == Primitive::kPrimNot) {
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001328 if (!resolved_method->IsStatic() && parameter_index == 0 && receiver_type.IsValid()) {
1329 run_rtp = true;
1330 current->SetReferenceTypeInfo(receiver_type);
1331 } else {
1332 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1333 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001334 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1335 }
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001336 ++parameter_index;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001337 }
1338 }
1339
David Brazdil94ab38f2016-06-21 17:48:19 +01001340 // We have replaced formal arguments with actual arguments. If actual types
1341 // are more specific than the declared ones, run RTP again on the inner graph.
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001342 if (run_rtp || ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001343 ReferenceTypePropagation(callee_graph,
1344 dex_compilation_unit.GetDexCache(),
1345 handles_,
1346 /* is_first_run */ false).Run();
1347 }
1348
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001349 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001350 size_t number_of_inlined_instructions =
1351 RunOptimizations(callee_graph, code_item, dex_compilation_unit);
1352 number_of_instructions_budget += number_of_inlined_instructions;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001353
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001354 // TODO: We should abort only if all predecessors throw. However,
1355 // HGraph::InlineInto currently does not handle an exit block with
1356 // a throw predecessor.
1357 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1358 if (exit_block == nullptr) {
David Sehr709b0702016-10-13 09:12:37 -07001359 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001360 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001361 return false;
1362 }
1363
1364 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001365 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1366 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001367 has_throw_predecessor = true;
1368 break;
1369 }
1370 }
1371 if (has_throw_predecessor) {
David Sehr709b0702016-10-13 09:12:37 -07001372 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001373 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001374 return false;
1375 }
1376
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001377 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001378
1379 bool can_inline_environment =
1380 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1381
Vladimir Marko2c45bc92016-10-25 16:54:12 +01001382 // Skip the entry block, it does not contain instructions that prevent inlining.
1383 for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) {
David Sehrc757dec2016-11-04 15:48:34 -07001384 if (block->IsLoopHeader()) {
1385 if (block->GetLoopInformation()->IsIrreducible()) {
1386 // Don't inline methods with irreducible loops, they could prevent some
1387 // optimizations to run.
1388 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1389 << " could not be inlined because it contains an irreducible loop";
1390 return false;
1391 }
1392 if (!block->GetLoopInformation()->HasExitEdge()) {
1393 // Don't inline methods with loops without exit, since they cause the
1394 // loop information to be computed incorrectly when updating after
1395 // inlining.
1396 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
1397 << " could not be inlined because it contains a loop with no exit";
1398 return false;
1399 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001400 }
1401
1402 for (HInstructionIterator instr_it(block->GetInstructions());
1403 !instr_it.Done();
1404 instr_it.Advance()) {
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001405 if (number_of_instructions++ == number_of_instructions_budget) {
David Sehr709b0702016-10-13 09:12:37 -07001406 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001407 << " is not inlined because its caller has reached"
1408 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001409 return false;
1410 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001411 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001412 if (!can_inline_environment && current->NeedsEnvironment()) {
David Sehr709b0702016-10-13 09:12:37 -07001413 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001414 << " is not inlined because its caller has reached"
1415 << " its environment budget limit.";
1416 return false;
1417 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001418
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001419 if (!same_dex_file && current->NeedsEnvironment()) {
David Sehr709b0702016-10-13 09:12:37 -07001420 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001421 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001422 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001423 return false;
1424 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001425
Vladimir Markodc151b22015-10-15 18:02:30 +01001426 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
David Sehr709b0702016-10-13 09:12:37 -07001427 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001428 << " could not be inlined because " << current->DebugName()
1429 << " it is in a different dex file and requires access to the dex cache";
1430 return false;
1431 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001432
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001433 if (current->IsNewArray() &&
1434 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
David Sehr709b0702016-10-13 09:12:37 -07001435 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001436 << " could not be inlined because it is using an entrypoint"
1437 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001438 // Allocation entrypoint does not handle inlined frames.
1439 return false;
1440 }
1441
1442 if (current->IsUnresolvedStaticFieldGet() ||
1443 current->IsUnresolvedInstanceFieldGet() ||
1444 current->IsUnresolvedStaticFieldSet() ||
1445 current->IsUnresolvedInstanceFieldSet()) {
1446 // Entrypoint for unresolved fields does not handle inlined frames.
David Sehr709b0702016-10-13 09:12:37 -07001447 VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index)
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001448 << " could not be inlined because it is using an unresolved"
1449 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001450 return false;
1451 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001452 }
1453 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001454 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001455
David Brazdil3f523062016-02-29 16:53:33 +00001456 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1457 << "No instructions can be added to the outer graph while inner graph is being built";
1458
1459 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1460 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001461 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
David Brazdil3f523062016-02-29 16:53:33 +00001462
1463 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1464 << "No instructions can be added to the inner graph during inlining into the outer graph";
1465
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001466 return true;
1467}
Calin Juravle2e768302015-07-28 14:41:11 +00001468
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001469size_t HInliner::RunOptimizations(HGraph* callee_graph,
1470 const DexFile::CodeItem* code_item,
1471 const DexCompilationUnit& dex_compilation_unit) {
Nicolas Geoffray93a18c52016-04-22 13:16:14 +01001472 // Note: if the outermost_graph_ is being compiled OSR, we should not run any
1473 // optimization that could lead to a HDeoptimize. The following optimizations do not.
Andreas Gampeca620d72016-11-08 08:09:33 -08001474 HDeadCodeElimination dce(callee_graph, stats_, "dead_code_elimination$inliner");
1475 HConstantFolding fold(callee_graph, "constant_folding$inliner");
Nicolas Geoffray22384ae2016-12-12 22:33:36 +00001476 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_, handles_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001477 InstructionSimplifier simplify(callee_graph, stats_);
Nicolas Geoffray762869d2016-07-15 15:28:35 +01001478 IntrinsicsRecognizer intrinsics(callee_graph, stats_);
Roland Levillaina3aef2e2016-04-06 17:45:58 +01001479
1480 HOptimization* optimizations[] = {
1481 &intrinsics,
1482 &sharpening,
1483 &simplify,
1484 &fold,
1485 &dce,
1486 };
1487
1488 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1489 HOptimization* optimization = optimizations[i];
1490 optimization->Run();
1491 }
1492
1493 size_t number_of_inlined_instructions = 0u;
1494 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
1495 HInliner inliner(callee_graph,
1496 outermost_graph_,
1497 codegen_,
1498 outer_compilation_unit_,
1499 dex_compilation_unit,
1500 compiler_driver_,
1501 handles_,
1502 stats_,
1503 total_number_of_dex_registers_ + code_item->registers_size_,
1504 depth_ + 1);
1505 inliner.Run();
1506 number_of_inlined_instructions += inliner.number_of_inlined_instructions_;
1507 }
1508
1509 return number_of_inlined_instructions;
1510}
1511
David Brazdil94ab38f2016-06-21 17:48:19 +01001512static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti,
1513 bool declared_can_be_null,
1514 HInstruction* actual_obj)
Andreas Gampebdf7f1c2016-08-30 16:38:47 -07001515 REQUIRES_SHARED(Locks::mutator_lock_) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001516 if (declared_can_be_null && !actual_obj->CanBeNull()) {
1517 return true;
1518 }
1519
1520 ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo();
1521 return (actual_rti.IsExact() && !declared_rti.IsExact()) ||
Nicolas Geoffray0f001b72017-01-04 16:46:23 +00001522 declared_rti.IsStrictSupertypeOf(actual_rti);
David Brazdil94ab38f2016-06-21 17:48:19 +01001523}
1524
1525ReferenceTypeInfo HInliner::GetClassRTI(mirror::Class* klass) {
1526 return ReferenceTypePropagation::IsAdmissible(klass)
1527 ? ReferenceTypeInfo::Create(handles_->NewHandle(klass))
1528 : graph_->GetInexactObjectRti();
1529}
1530
1531bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) {
1532 // If this is an instance call, test whether the type of the `this` argument
1533 // is more specific than the class which declares the method.
1534 if (!resolved_method->IsStatic()) {
1535 if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()),
1536 /* declared_can_be_null */ false,
1537 invoke_instruction->InputAt(0u))) {
1538 return true;
1539 }
1540 }
1541
Andreas Gampe542451c2016-07-26 09:02:02 -07001542 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
David Brazdil94ab38f2016-06-21 17:48:19 +01001543
1544 // Iterate over the list of parameter types and test whether any of the
1545 // actual inputs has a more specific reference type than the type declared in
1546 // the signature.
1547 const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList();
1548 for (size_t param_idx = 0,
1549 input_idx = resolved_method->IsStatic() ? 0 : 1,
1550 e = (param_list == nullptr ? 0 : param_list->Size());
1551 param_idx < e;
1552 ++param_idx, ++input_idx) {
1553 HInstruction* input = invoke_instruction->InputAt(input_idx);
1554 if (input->GetType() == Primitive::kPrimNot) {
1555 mirror::Class* param_cls = resolved_method->GetDexCacheResolvedType(
1556 param_list->GetTypeItem(param_idx).type_idx_,
1557 pointer_size);
1558 if (IsReferenceTypeRefinement(GetClassRTI(param_cls),
1559 /* declared_can_be_null */ true,
1560 input)) {
1561 return true;
1562 }
1563 }
1564 }
1565
1566 return false;
1567}
1568
1569bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction,
1570 HInstruction* return_replacement) {
Alex Light68289a52015-12-15 17:30:30 -08001571 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001572 if (return_replacement != nullptr) {
1573 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil94ab38f2016-06-21 17:48:19 +01001574 // Test if the return type is a refinement of the declared return type.
1575 if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(),
1576 /* declared_can_be_null */ true,
1577 return_replacement)) {
1578 return true;
Nicolas Geoffrayc52b26d2016-12-19 09:18:07 +00001579 } else if (return_replacement->IsInstanceFieldGet()) {
1580 HInstanceFieldGet* field_get = return_replacement->AsInstanceFieldGet();
1581 ClassLinker* class_linker = Runtime::Current()->GetClassLinker();
1582 if (field_get->GetFieldInfo().GetField() ==
1583 class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0)) {
1584 return true;
1585 }
David Brazdil94ab38f2016-06-21 17:48:19 +01001586 }
1587 } else if (return_replacement->IsInstanceOf()) {
1588 // Inlining InstanceOf into an If may put a tighter bound on reference types.
1589 return true;
1590 }
1591 }
1592
1593 return false;
1594}
1595
1596void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method,
1597 HInstruction* return_replacement) {
1598 if (return_replacement != nullptr) {
1599 if (return_replacement->GetType() == Primitive::kPrimNot) {
David Brazdil4833f5a2015-12-16 10:37:39 +00001600 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1601 // Make sure that we have a valid type for the return. We may get an invalid one when
1602 // we inline invokes with multiple branches and create a Phi for the result.
1603 // TODO: we could be more precise by merging the phi inputs but that requires
1604 // some functionality from the reference type propagation.
1605 DCHECK(return_replacement->IsPhi());
Andreas Gampe542451c2016-07-26 09:02:02 -07001606 PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
Nicolas Geoffray44fd0e52016-03-16 15:16:06 +00001607 mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */, pointer_size);
David Brazdil94ab38f2016-06-21 17:48:19 +01001608 return_replacement->SetReferenceTypeInfo(GetClassRTI(cls));
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001609 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001610 }
Calin Juravle2e768302015-07-28 14:41:11 +00001611 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001612}
1613
1614} // namespace art