blob: 48d32999b780fce6b442606ce2e76f9bbe19aa87 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000020#include "builder.h"
21#include "class_linker.h"
22#include "constant_folding.h"
23#include "dead_code_elimination.h"
24#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010025#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000026#include "driver/dex_compilation_unit.h"
27#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010028#include "intrinsics.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000029#include "mirror/class_loader.h"
30#include "mirror/dex_cache.h"
31#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010032#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010033#include "reference_type_propagation.h"
Nicolas Geoffray259136f2014-12-17 23:21:58 +000034#include "register_allocator.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010035#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000036#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000037#include "ssa_phi_elimination.h"
38#include "scoped_thread_state_change.h"
39#include "thread.h"
Calin Juravlef1c6d9e2015-04-13 18:42:21 +010040#include "dex/verified_method.h"
41#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000042
43namespace art {
44
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000045static constexpr size_t kMaximumNumberOfHInstructions = 32;
46
47// Limit the number of dex registers that we accumulate while inlining
48// to avoid creating large amount of nested environments.
49static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
50
51// Avoid inlining within a huge method due to memory pressure.
52static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070053
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000054void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010055 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
56 if ((compiler_options.GetInlineDepthLimit() == 0)
57 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
58 return;
59 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000060 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
61 return;
62 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000063 if (graph_->IsDebuggable()) {
64 // For simplicity, we currently never inline when the graph is debuggable. This avoids
65 // doing some logic in the runtime to discover if a method could have been inlined.
66 return;
67 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010068 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
69 DCHECK(!blocks.empty());
70 HBasicBlock* next_block = blocks[0];
71 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010072 // Because we are changing the graph when inlining, we need to remember the next block.
73 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010074 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010075 continue;
76 }
77 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010078 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000079 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
80 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010081 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070082 // As long as the call is not intrinsified, it is worth trying to inline.
83 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000084 // We use the original invoke type to ensure the resolution of the called method
85 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000086 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010087 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000088 std::string callee_name =
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000089 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000090 bool should_inline = callee_name.find("$inline$") != std::string::npos;
91 CHECK(!should_inline) << "Could not inline " << callee_name;
92 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010093 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010094 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010095 std::string callee_name =
96 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
97 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
98 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
99 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000100 }
101 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000102 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000103 }
104 }
105}
106
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100107static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700108 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100109 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
110}
111
112/**
113 * Given the `resolved_method` looked up in the dex cache, try to find
114 * the actual runtime target of an interface or virtual call.
115 * Return nullptr if the runtime target cannot be proven.
116 */
117static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700118 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100119 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
120 // No need to lookup further, the resolved method will be the target.
121 return resolved_method;
122 }
123
124 HInstruction* receiver = invoke->InputAt(0);
125 if (receiver->IsNullCheck()) {
126 // Due to multiple levels of inlining within the same pass, it might be that
127 // null check does not have the reference type of the actual receiver.
128 receiver = receiver->InputAt(0);
129 }
130 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000131 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
132 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100133 // We currently only support inlining with known receivers.
134 // TODO: Remove this check, we should be able to inline final methods
135 // on unknown receivers.
136 return nullptr;
137 } else if (info.GetTypeHandle()->IsInterface()) {
138 // Statically knowing that the receiver has an interface type cannot
139 // help us find what is the target method.
140 return nullptr;
141 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
142 // The method that we're trying to call is not in the receiver's class or super classes.
143 return nullptr;
144 }
145
146 ClassLinker* cl = Runtime::Current()->GetClassLinker();
147 size_t pointer_size = cl->GetImagePointerSize();
148 if (invoke->IsInvokeInterface()) {
149 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
150 resolved_method, pointer_size);
151 } else {
152 DCHECK(invoke->IsInvokeVirtual());
153 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
154 resolved_method, pointer_size);
155 }
156
157 if (resolved_method == nullptr) {
158 // The information we had on the receiver was not enough to find
159 // the target method. Since we check above the exact type of the receiver,
160 // the only reason this can happen is an IncompatibleClassChangeError.
161 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700162 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100163 // The information we had on the receiver was not enough to find
164 // the target method. Since we check above the exact type of the receiver,
165 // the only reason this can happen is an IncompatibleClassChangeError.
166 return nullptr;
167 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
168 // A final method has to be the target method.
169 return resolved_method;
170 } else if (info.IsExact()) {
171 // If we found a method and the receiver's concrete type is statically
172 // known, we know for sure the target.
173 return resolved_method;
174 } else {
175 // Even if we did find a method, the receiver type was not enough to
176 // statically find the runtime target.
177 return nullptr;
178 }
179}
180
181static uint32_t FindMethodIndexIn(ArtMethod* method,
182 const DexFile& dex_file,
183 uint32_t referrer_index)
Mathieu Chartier90443472015-07-16 20:32:27 -0700184 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100185 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100186 return method->GetDexMethodIndex();
187 } else {
188 return method->FindDexMethodIndexInOtherDexFile(dex_file, referrer_index);
189 }
190}
191
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100192static uint32_t FindClassIndexIn(mirror::Class* cls, const DexFile& dex_file)
193 SHARED_REQUIRES(Locks::mutator_lock_) {
194 if (cls->GetDexCache() == nullptr) {
195 DCHECK(cls->IsArrayClass());
196 // TODO: find the class in `dex_file`.
197 return DexFile::kDexNoIndex;
198 } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) {
199 // TODO: deal with proxy classes.
200 return DexFile::kDexNoIndex;
201 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
202 // Update the dex cache to ensure the class is in. The generated code will
203 // consider it is. We make it safe by updating the dex cache, as other
204 // dex files might also load the class, and there is no guarantee the dex
205 // cache of the dex file of the class will be updated.
206 if (cls->GetDexCache()->GetResolvedType(cls->GetDexTypeIndex()) == nullptr) {
207 cls->GetDexCache()->SetResolvedType(cls->GetDexTypeIndex(), cls);
208 }
209 return cls->GetDexTypeIndex();
210 } else {
211 // TODO: find the class in `dex_file`.
212 return DexFile::kDexNoIndex;
213 }
214}
215
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700216bool HInliner::TryInline(HInvoke* invoke_instruction) {
Calin Juravle175dc732015-08-25 15:42:32 +0100217 if (invoke_instruction->IsInvokeUnresolved()) {
218 return false; // Don't bother to move further if we know the method is unresolved.
219 }
220
Vladimir Marko58155012015-08-19 12:49:41 +0000221 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000222 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000223 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
224 VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000225
Nicolas Geoffray35071052015-06-09 15:43:38 +0100226 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
227 // We can query the dex cache directly. The verifier has populated it already.
Vladimir Marko58155012015-08-19 12:49:41 +0000228 ArtMethod* resolved_method;
Andreas Gampefd2140f2015-12-23 16:30:44 -0800229 ArtMethod* actual_method = nullptr;
Vladimir Marko58155012015-08-19 12:49:41 +0000230 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Nicolas Geoffraye5234232015-12-02 09:06:11 +0000231 if (invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()) {
232 VLOG(compiler) << "Not inlining a String.<init> method";
233 return false;
234 }
Vladimir Marko58155012015-08-19 12:49:41 +0000235 MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700236 mirror::DexCache* const dex_cache = (&caller_dex_file == ref.dex_file)
237 ? caller_compilation_unit_.GetDexCache().Get()
238 : class_linker->FindDexCache(soa.Self(), *ref.dex_file);
239 resolved_method = dex_cache->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000240 ref.dex_method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800241 // actual_method == resolved_method for direct or static calls.
242 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000243 } else {
Mathieu Chartier736b5602015-09-02 14:54:11 -0700244 resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000245 method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800246 if (resolved_method != nullptr) {
247 // Check if we can statically find the method.
248 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
249 }
Vladimir Marko58155012015-08-19 12:49:41 +0000250 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000251
Mathieu Chartiere401d142015-04-22 13:56:20 -0700252 if (resolved_method == nullptr) {
Calin Juravle175dc732015-08-25 15:42:32 +0100253 // TODO: Can this still happen?
Nicolas Geoffray35071052015-06-09 15:43:38 +0100254 // Method cannot be resolved if it is in another dex file we do not have access to.
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000255 VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000256 return false;
257 }
258
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100259 if (actual_method != nullptr) {
260 return TryInline(invoke_instruction, actual_method);
261 }
Andreas Gampefd2140f2015-12-23 16:30:44 -0800262 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100263
264 // Check if we can use an inline cache.
265 ArtMethod* caller = graph_->GetArtMethod();
266 size_t pointer_size = class_linker->GetImagePointerSize();
267 // Under JIT, we should always know the caller.
268 DCHECK(!Runtime::Current()->UseJit() || (caller != nullptr));
269 if (caller != nullptr && caller->GetProfilingInfo(pointer_size) != nullptr) {
270 ProfilingInfo* profiling_info = caller->GetProfilingInfo(pointer_size);
271 const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc());
272 if (ic.IsUnitialized()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100273 VLOG(compiler) << "Interface or virtual call to "
274 << PrettyMethod(method_index, caller_dex_file)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100275 << " is not hit and not inlined";
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100276 return false;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100277 } else if (ic.IsMonomorphic()) {
278 MaybeRecordStat(kMonomorphicCall);
279 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic);
280 } else if (ic.IsPolymorphic()) {
281 MaybeRecordStat(kPolymorphicCall);
282 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
283 } else {
284 DCHECK(ic.IsMegamorphic());
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100285 VLOG(compiler) << "Interface or virtual call to "
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100286 << PrettyMethod(method_index, caller_dex_file)
287 << " is megamorphic and not inlined";
288 MaybeRecordStat(kMegamorphicCall);
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100289 return false;
290 }
291 }
292
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100293 VLOG(compiler) << "Interface or virtual call to "
294 << PrettyMethod(method_index, caller_dex_file)
295 << " could not be statically determined";
296 return false;
297}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000298
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100299bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
300 ArtMethod* resolved_method,
301 const InlineCache& ic) {
302 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
303 uint32_t class_index = FindClassIndexIn(ic.GetMonomorphicType(), caller_dex_file);
304 if (class_index == DexFile::kDexNoIndex) {
305 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
306 << " from inline cache is not inlined because its class is not"
307 << " accessible to the caller";
308 return false;
309 }
310
311 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
312 size_t pointer_size = class_linker->GetImagePointerSize();
313 if (invoke_instruction->IsInvokeInterface()) {
314 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface(
315 resolved_method, pointer_size);
316 } else {
317 DCHECK(invoke_instruction->IsInvokeVirtual());
318 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual(
319 resolved_method, pointer_size);
320 }
321 DCHECK(resolved_method != nullptr);
322 HInstruction* receiver = invoke_instruction->InputAt(0);
323 HInstruction* cursor = invoke_instruction->GetPrevious();
324 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
325
326 if (!TryInline(invoke_instruction, resolved_method, /* do_rtp */ false)) {
327 return false;
328 }
329
330 // We successfully inlined, now add a guard.
331 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
332 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
333 HInstanceFieldGet* field_get = new (graph_->GetArena()) HInstanceFieldGet(
334 receiver,
335 Primitive::kPrimNot,
336 field->GetOffset(),
337 field->IsVolatile(),
338 field->GetDexFieldIndex(),
339 field->GetDeclaringClass()->GetDexClassDefIndex(),
340 *field->GetDexFile(),
341 handles_->NewHandle(field->GetDexCache()),
342 invoke_instruction->GetDexPc());
343
344 bool is_referrer =
345 (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
346 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
347 class_index,
348 caller_dex_file,
349 is_referrer,
350 invoke_instruction->GetDexPc(),
351 /* needs_access_check */ false,
352 /* is_in_dex_cache */ true);
353
354 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, field_get);
355 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
356 compare, invoke_instruction->GetDexPc());
357 // TODO: Extend reference type propagation to understand the guard.
358 if (cursor != nullptr) {
359 bb_cursor->InsertInstructionAfter(load_class, cursor);
360 } else {
361 bb_cursor->InsertInstructionBefore(load_class, bb_cursor->GetFirstInstruction());
362 }
363 bb_cursor->InsertInstructionAfter(field_get, load_class);
364 bb_cursor->InsertInstructionAfter(compare, field_get);
365 bb_cursor->InsertInstructionAfter(deoptimize, compare);
366 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
367
368 // Run type propagation to get the guard typed, and eventually propagate the
369 // type of the receiver.
370 ReferenceTypePropagation rtp_fixup(graph_, handles_);
371 rtp_fixup.Run();
372
373 MaybeRecordStat(kInlinedMonomorphicCall);
374 return true;
375}
376
377bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction ATTRIBUTE_UNUSED,
378 ArtMethod* resolved_method,
379 const InlineCache& ic ATTRIBUTE_UNUSED) {
380 // TODO
381 VLOG(compiler) << "Unimplemented polymorphic inlining for "
382 << PrettyMethod(resolved_method);
383 return false;
384}
385
386bool HInliner::TryInline(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) {
387 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Jeff Haodcdc85b2015-12-04 14:06:18 -0800388
389 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
390 // dex file here (though the transitivity of an inline chain would allow checking the calller).
391 if (!compiler_driver_->MayInline(method->GetDexFile(),
392 outer_compilation_unit_.GetDexFile())) {
393 VLOG(compiler) << "Won't inline " << PrettyMethod(method) << " in "
394 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
395 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
396 << method->GetDexFile()->GetLocation();
397 return false;
398 }
399
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100400 uint32_t method_index = FindMethodIndexIn(
401 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
402 if (method_index == DexFile::kDexNoIndex) {
403 VLOG(compiler) << "Call to "
404 << PrettyMethod(method)
405 << " cannot be inlined because unaccessible to caller";
406 return false;
407 }
408
409 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
410
411 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000412
413 if (code_item == nullptr) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100414 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000415 << " is not inlined because it is native";
416 return false;
417 }
418
Calin Juravleec748352015-07-29 13:52:12 +0100419 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
420 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100421 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000422 << " is too big to inline";
423 return false;
424 }
425
426 if (code_item->tries_size_ != 0) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100427 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000428 << " is not inlined because of try block";
429 return false;
430 }
431
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100432 if (!method->GetDeclaringClass()->IsVerified()) {
433 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100434 if (!compiler_driver_->IsMethodVerifiedWithoutFailures(
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100435 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100436 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
437 << " couldn't be verified, so it cannot be inlined";
438 return false;
439 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000440 }
441
Roland Levillain4c0eb422015-04-24 16:43:49 +0100442 if (invoke_instruction->IsInvokeStaticOrDirect() &&
443 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
444 // Case of a static method that cannot be inlined because it implicitly
445 // requires an initialization check of its declaring class.
446 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
447 << " is not inlined because it is static and requires a clinit"
448 << " check that cannot be emitted due to Dex cache limitations";
449 return false;
450 }
451
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100452 if (!TryBuildAndInline(method, invoke_instruction, same_dex_file, do_rtp)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000453 return false;
454 }
455
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000456 VLOG(compiler) << "Successfully inlined " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000457 MaybeRecordStat(kInlinedInvoke);
458 return true;
459}
460
Mathieu Chartiere401d142015-04-22 13:56:20 -0700461bool HInliner::TryBuildAndInline(ArtMethod* resolved_method,
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000462 HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100463 bool same_dex_file,
464 bool do_rtp) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000465 ScopedObjectAccess soa(Thread::Current());
466 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100467 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
468 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +0000469 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700470 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000471 DexCompilationUnit dex_compilation_unit(
472 nullptr,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000473 caller_compilation_unit_.GetClassLoader(),
Calin Juravle2e768302015-07-28 14:41:11 +0000474 class_linker,
Nicolas Geoffray8dbf0cf2015-08-11 02:14:38 +0000475 callee_dex_file,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000476 code_item,
477 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
Nicolas Geoffray8dbf0cf2015-08-11 02:14:38 +0000478 method_index,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000479 resolved_method->GetAccessFlags(),
Mathieu Chartier736b5602015-09-02 14:54:11 -0700480 compiler_driver_->GetVerifiedMethod(&callee_dex_file, method_index),
481 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000482
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100483 bool requires_ctor_barrier = false;
484
485 if (dex_compilation_unit.IsConstructor()) {
486 // If it's a super invocation and we already generate a barrier there's no need
487 // to generate another one.
488 // We identify super calls by looking at the "this" pointer. If its value is the
489 // same as the local "this" pointer then we must have a super invocation.
490 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
491 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
492 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
493 requires_ctor_barrier = false;
494 } else {
495 Thread* self = Thread::Current();
496 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
497 dex_compilation_unit.GetDexFile(),
498 dex_compilation_unit.GetClassDefIndex());
499 }
500 }
501
Nicolas Geoffray35071052015-06-09 15:43:38 +0100502 InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType();
503 if (invoke_type == kInterface) {
504 // We have statically resolved the dispatch. To please the class linker
505 // at runtime, we change this call as if it was a virtual call.
506 invoke_type = kVirtual;
507 }
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +0000508 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +0100509 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100510 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +0100511 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +0100512 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -0700513 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +0100514 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +0100515 graph_->IsDebuggable(),
516 graph_->GetCurrentInstructionId());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100517 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +0000518
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000519 OptimizingCompilerStats inline_stats;
David Brazdil5e8b1372015-01-23 14:39:08 +0000520 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000521 &dex_compilation_unit,
522 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000523 resolved_method->GetDexFile(),
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000524 compiler_driver_,
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +0000525 &inline_stats,
Mathieu Chartier736b5602015-09-02 14:54:11 -0700526 resolved_method->GetQuickenedInfo(),
527 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000528
David Brazdil5e8b1372015-01-23 14:39:08 +0000529 if (!builder.BuildGraph(*code_item)) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100530 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000531 << " could not be built, so cannot be inlined";
532 return false;
533 }
534
Nicolas Geoffray259136f2014-12-17 23:21:58 +0000535 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
536 compiler_driver_->GetInstructionSet())) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100537 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray259136f2014-12-17 23:21:58 +0000538 << " cannot be inlined because of the register allocator";
539 return false;
540 }
541
David Brazdil4833f5a2015-12-16 10:37:39 +0000542 if (callee_graph->TryBuildingSsa(handles_) != kBuildSsaSuccess) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100543 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000544 << " could not be transformed to SSA";
545 return false;
546 }
547
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700548 size_t parameter_index = 0;
549 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
550 !instructions.Done();
551 instructions.Advance()) {
552 HInstruction* current = instructions.Current();
553 if (current->IsParameterValue()) {
554 HInstruction* argument = invoke_instruction->InputAt(parameter_index++);
555 if (argument->IsNullConstant()) {
556 current->ReplaceWith(callee_graph->GetNullConstant());
557 } else if (argument->IsIntConstant()) {
558 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
559 } else if (argument->IsLongConstant()) {
560 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
561 } else if (argument->IsFloatConstant()) {
562 current->ReplaceWith(
563 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
564 } else if (argument->IsDoubleConstant()) {
565 current->ReplaceWith(
566 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
567 } else if (argument->GetType() == Primitive::kPrimNot) {
568 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
569 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
570 }
571 }
572 }
573
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000574 // Run simple optimizations on the graph.
Calin Juravle7a9c8852015-04-21 14:07:50 +0100575 HDeadCodeElimination dce(callee_graph, stats_);
Nicolas Geoffraye34648d2015-11-23 08:59:07 +0000576 HConstantFolding fold(callee_graph);
Vladimir Markodc151b22015-10-15 18:02:30 +0100577 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_);
Calin Juravleacf735c2015-02-12 15:25:22 +0000578 InstructionSimplifier simplify(callee_graph, stats_);
Nicolas Geoffraye34648d2015-11-23 08:59:07 +0000579 IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000580
581 HOptimization* optimizations[] = {
Scott Wakelingd60a1af2015-07-22 14:32:44 +0100582 &intrinsics,
Vladimir Markodc151b22015-10-15 18:02:30 +0100583 &sharpening,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000584 &simplify,
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700585 &fold,
Vladimir Marko9e23df52015-11-10 17:14:35 +0000586 &dce,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000587 };
588
589 for (size_t i = 0; i < arraysize(optimizations); ++i) {
590 HOptimization* optimization = optimizations[i];
591 optimization->Run();
592 }
593
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700594 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Calin Juravleec748352015-07-29 13:52:12 +0100595 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000596 HInliner inliner(callee_graph,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100597 outermost_graph_,
Vladimir Markodc151b22015-10-15 18:02:30 +0100598 codegen_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000599 outer_compilation_unit_,
600 dex_compilation_unit,
601 compiler_driver_,
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100602 handles_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000603 stats_,
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000604 total_number_of_dex_registers_ + code_item->registers_size_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000605 depth_ + 1);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000606 inliner.Run();
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700607 number_of_instructions_budget += inliner.number_of_inlined_instructions_;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000608 }
609
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100610 // TODO: We should abort only if all predecessors throw. However,
611 // HGraph::InlineInto currently does not handle an exit block with
612 // a throw predecessor.
613 HBasicBlock* exit_block = callee_graph->GetExitBlock();
614 if (exit_block == nullptr) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100615 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100616 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100617 return false;
618 }
619
620 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +0000621 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
622 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100623 has_throw_predecessor = true;
624 break;
625 }
626 }
627 if (has_throw_predecessor) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100628 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100629 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100630 return false;
631 }
632
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000633 HReversePostOrderIterator it(*callee_graph);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000634 it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining.
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700635 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000636
637 bool can_inline_environment =
638 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
639
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000640 for (; !it.Done(); it.Advance()) {
641 HBasicBlock* block = it.Current();
642 if (block->IsLoopHeader()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100643 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000644 << " could not be inlined because it contains a loop";
645 return false;
646 }
647
648 for (HInstructionIterator instr_it(block->GetInstructions());
649 !instr_it.Done();
650 instr_it.Advance()) {
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700651 if (number_of_instructions++ == number_of_instructions_budget) {
652 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000653 << " is not inlined because its caller has reached"
654 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700655 return false;
656 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000657 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +0000658 if (!can_inline_environment && current->NeedsEnvironment()) {
659 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
660 << " is not inlined because its caller has reached"
661 << " its environment budget limit.";
662 return false;
663 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +0000664
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100665 if (current->IsInvokeInterface()) {
666 // Disable inlining of interface calls. The cost in case of entering the
667 // resolution conflict is currently too high.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100668 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100669 << " could not be inlined because it has an interface call.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000670 return false;
671 }
672
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100673 if (!same_dex_file && current->NeedsEnvironment()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100674 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000675 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +0100676 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000677 return false;
678 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000679
Vladimir Markodc151b22015-10-15 18:02:30 +0100680 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100681 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000682 << " could not be inlined because " << current->DebugName()
683 << " it is in a different dex file and requires access to the dex cache";
684 return false;
685 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +0000686
687 if (current->IsNewInstance() &&
688 (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) {
689 // Allocation entrypoint does not handle inlined frames.
690 return false;
691 }
692
693 if (current->IsNewArray() &&
694 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
695 // Allocation entrypoint does not handle inlined frames.
696 return false;
697 }
698
699 if (current->IsUnresolvedStaticFieldGet() ||
700 current->IsUnresolvedInstanceFieldGet() ||
701 current->IsUnresolvedStaticFieldSet() ||
702 current->IsUnresolvedInstanceFieldSet()) {
703 // Entrypoint for unresolved fields does not handle inlined frames.
704 return false;
705 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000706 }
707 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700708 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000709
Calin Juravle2e768302015-07-28 14:41:11 +0000710 HInstruction* return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
Calin Juravle214bbcd2015-10-20 14:54:07 +0100711 if (return_replacement != nullptr) {
712 DCHECK_EQ(graph_, return_replacement->GetBlock()->GetGraph());
713 }
Calin Juravle2e768302015-07-28 14:41:11 +0000714
Alex Light68289a52015-12-15 17:30:30 -0800715 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +0000716 if (return_replacement != nullptr) {
717 if (return_replacement->GetType() == Primitive::kPrimNot) {
718 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
719 // Make sure that we have a valid type for the return. We may get an invalid one when
720 // we inline invokes with multiple branches and create a Phi for the result.
721 // TODO: we could be more precise by merging the phi inputs but that requires
722 // some functionality from the reference type propagation.
723 DCHECK(return_replacement->IsPhi());
724 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
725 ReferenceTypeInfo::TypeHandle return_handle =
726 handles_->NewHandle(resolved_method->GetReturnType(true /* resolve */, pointer_size));
727 return_replacement->SetReferenceTypeInfo(ReferenceTypeInfo::Create(
728 return_handle, return_handle->CannotBeAssignedFromOtherTypes() /* is_exact */));
729 }
Alex Light68289a52015-12-15 17:30:30 -0800730
David Brazdil4833f5a2015-12-16 10:37:39 +0000731 if (do_rtp) {
732 // If the return type is a refinement of the declared type run the type propagation again.
733 ReferenceTypeInfo return_rti = return_replacement->GetReferenceTypeInfo();
734 ReferenceTypeInfo invoke_rti = invoke_instruction->GetReferenceTypeInfo();
735 if (invoke_rti.IsStrictSupertypeOf(return_rti)
736 || (return_rti.IsExact() && !invoke_rti.IsExact())
737 || !return_replacement->CanBeNull()) {
738 ReferenceTypePropagation(graph_, handles_).Run();
739 }
740 }
741 } else if (return_replacement->IsInstanceOf()) {
742 if (do_rtp) {
743 // Inlining InstanceOf into an If may put a tighter bound on reference types.
744 ReferenceTypePropagation(graph_, handles_).Run();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100745 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +0000746 }
Calin Juravle2e768302015-07-28 14:41:11 +0000747 }
Nicolas Geoffray7c5367b2014-12-17 10:13:46 +0000748
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000749 return true;
750}
751
752} // namespace art