Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2014 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "inliner.h" |
| 18 | |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 19 | #include "art_method-inl.h" |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 20 | #include "base/enums.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 21 | #include "builder.h" |
| 22 | #include "class_linker.h" |
| 23 | #include "constant_folding.h" |
| 24 | #include "dead_code_elimination.h" |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 25 | #include "dex/verified_method.h" |
| 26 | #include "dex/verification_results.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 27 | #include "driver/compiler_driver-inl.h" |
Calin Juravle | ec74835 | 2015-07-29 13:52:12 +0100 | [diff] [blame] | 28 | #include "driver/compiler_options.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 29 | #include "driver/dex_compilation_unit.h" |
| 30 | #include "instruction_simplifier.h" |
Scott Wakeling | d60a1af | 2015-07-22 14:32:44 +0100 | [diff] [blame] | 31 | #include "intrinsics.h" |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 32 | #include "jit/jit.h" |
| 33 | #include "jit/jit_code_cache.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 34 | #include "mirror/class_loader.h" |
| 35 | #include "mirror/dex_cache.h" |
| 36 | #include "nodes.h" |
Nicolas Geoffray | 335005e | 2015-06-25 10:01:47 +0100 | [diff] [blame] | 37 | #include "optimizing_compiler.h" |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 38 | #include "reference_type_propagation.h" |
Matthew Gharrity | e928885 | 2016-07-14 14:08:16 -0700 | [diff] [blame] | 39 | #include "register_allocator_linear_scan.h" |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 40 | #include "quick/inline_method_analyser.h" |
Vladimir Marko | dc151b2 | 2015-10-15 18:02:30 +0100 | [diff] [blame] | 41 | #include "sharpening.h" |
David Brazdil | 4833f5a | 2015-12-16 10:37:39 +0000 | [diff] [blame] | 42 | #include "ssa_builder.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 43 | #include "ssa_phi_elimination.h" |
Mathieu Chartier | 0795f23 | 2016-09-27 18:43:30 -0700 | [diff] [blame] | 44 | #include "scoped_thread_state_change-inl.h" |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 45 | #include "thread.h" |
| 46 | |
| 47 | namespace art { |
| 48 | |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 49 | static constexpr size_t kMaximumNumberOfHInstructions = 32; |
| 50 | |
| 51 | // Limit the number of dex registers that we accumulate while inlining |
| 52 | // to avoid creating large amount of nested environments. |
| 53 | static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64; |
| 54 | |
| 55 | // Avoid inlining within a huge method due to memory pressure. |
| 56 | static constexpr size_t kMaximumCodeUnitSize = 4096; |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 57 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 58 | void HInliner::Run() { |
Calin Juravle | 8f96df8 | 2015-07-29 15:58:48 +0100 | [diff] [blame] | 59 | const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions(); |
| 60 | if ((compiler_options.GetInlineDepthLimit() == 0) |
| 61 | || (compiler_options.GetInlineMaxCodeUnits() == 0)) { |
| 62 | return; |
| 63 | } |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 64 | if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) { |
| 65 | return; |
| 66 | } |
Nicolas Geoffray | e50b8d2 | 2015-03-13 08:57:42 +0000 | [diff] [blame] | 67 | if (graph_->IsDebuggable()) { |
| 68 | // For simplicity, we currently never inline when the graph is debuggable. This avoids |
| 69 | // doing some logic in the runtime to discover if a method could have been inlined. |
| 70 | return; |
| 71 | } |
Vladimir Marko | fa6b93c | 2015-09-15 10:15:55 +0100 | [diff] [blame] | 72 | const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder(); |
| 73 | DCHECK(!blocks.empty()); |
| 74 | HBasicBlock* next_block = blocks[0]; |
| 75 | for (size_t i = 0; i < blocks.size(); ++i) { |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 76 | // Because we are changing the graph when inlining, we need to remember the next block. |
| 77 | // This avoids doing the inlining work again on the inlined blocks. |
Vladimir Marko | fa6b93c | 2015-09-15 10:15:55 +0100 | [diff] [blame] | 78 | if (blocks[i] != next_block) { |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 79 | continue; |
| 80 | } |
| 81 | HBasicBlock* block = next_block; |
Vladimir Marko | fa6b93c | 2015-09-15 10:15:55 +0100 | [diff] [blame] | 82 | next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1]; |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 83 | for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) { |
| 84 | HInstruction* next = instruction->GetNext(); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 85 | HInvoke* call = instruction->AsInvoke(); |
Razvan A Lupusoru | 3e90a96 | 2015-03-27 13:44:44 -0700 | [diff] [blame] | 86 | // As long as the call is not intrinsified, it is worth trying to inline. |
| 87 | if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) { |
Nicolas Geoffray | 7904129 | 2015-03-26 10:05:54 +0000 | [diff] [blame] | 88 | // We use the original invoke type to ensure the resolution of the called method |
| 89 | // works properly. |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 90 | if (!TryInline(call)) { |
Nicolas Geoffray | 335005e | 2015-06-25 10:01:47 +0100 | [diff] [blame] | 91 | if (kIsDebugBuild && IsCompilingWithCoreImage()) { |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 92 | std::string callee_name = |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 93 | outer_compilation_unit_.GetDexFile()->PrettyMethod(call->GetDexMethodIndex()); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 94 | bool should_inline = callee_name.find("$inline$") != std::string::npos; |
| 95 | CHECK(!should_inline) << "Could not inline " << callee_name; |
| 96 | } |
Guillaume "Vermeille" Sanchez | e918d38 | 2015-06-03 15:32:41 +0100 | [diff] [blame] | 97 | } else { |
Nicolas Geoffray | 335005e | 2015-06-25 10:01:47 +0100 | [diff] [blame] | 98 | if (kIsDebugBuild && IsCompilingWithCoreImage()) { |
Guillaume "Vermeille" Sanchez | e918d38 | 2015-06-03 15:32:41 +0100 | [diff] [blame] | 99 | std::string callee_name = |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 100 | outer_compilation_unit_.GetDexFile()->PrettyMethod(call->GetDexMethodIndex()); |
Guillaume "Vermeille" Sanchez | e918d38 | 2015-06-03 15:32:41 +0100 | [diff] [blame] | 101 | bool must_not_inline = callee_name.find("$noinline$") != std::string::npos; |
| 102 | CHECK(!must_not_inline) << "Should not have inlined " << callee_name; |
| 103 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 104 | } |
| 105 | } |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 106 | instruction = next; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 107 | } |
| 108 | } |
| 109 | } |
| 110 | |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 111 | static bool IsMethodOrDeclaringClassFinal(ArtMethod* method) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 112 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 113 | return method->IsFinal() || method->GetDeclaringClass()->IsFinal(); |
| 114 | } |
| 115 | |
| 116 | /** |
| 117 | * Given the `resolved_method` looked up in the dex cache, try to find |
| 118 | * the actual runtime target of an interface or virtual call. |
| 119 | * Return nullptr if the runtime target cannot be proven. |
| 120 | */ |
| 121 | static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 122 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 123 | if (IsMethodOrDeclaringClassFinal(resolved_method)) { |
| 124 | // No need to lookup further, the resolved method will be the target. |
| 125 | return resolved_method; |
| 126 | } |
| 127 | |
| 128 | HInstruction* receiver = invoke->InputAt(0); |
| 129 | if (receiver->IsNullCheck()) { |
| 130 | // Due to multiple levels of inlining within the same pass, it might be that |
| 131 | // null check does not have the reference type of the actual receiver. |
| 132 | receiver = receiver->InputAt(0); |
| 133 | } |
| 134 | ReferenceTypeInfo info = receiver->GetReferenceTypeInfo(); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 135 | DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName(); |
| 136 | if (!info.IsExact()) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 137 | // We currently only support inlining with known receivers. |
| 138 | // TODO: Remove this check, we should be able to inline final methods |
| 139 | // on unknown receivers. |
| 140 | return nullptr; |
| 141 | } else if (info.GetTypeHandle()->IsInterface()) { |
| 142 | // Statically knowing that the receiver has an interface type cannot |
| 143 | // help us find what is the target method. |
| 144 | return nullptr; |
| 145 | } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) { |
| 146 | // The method that we're trying to call is not in the receiver's class or super classes. |
| 147 | return nullptr; |
Nicolas Geoffray | ab5327d | 2016-03-18 11:36:20 +0000 | [diff] [blame] | 148 | } else if (info.GetTypeHandle()->IsErroneous()) { |
| 149 | // If the type is erroneous, do not go further, as we are going to query the vtable or |
| 150 | // imt table, that we can only safely do on non-erroneous classes. |
| 151 | return nullptr; |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 152 | } |
| 153 | |
| 154 | ClassLinker* cl = Runtime::Current()->GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 155 | PointerSize pointer_size = cl->GetImagePointerSize(); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 156 | if (invoke->IsInvokeInterface()) { |
| 157 | resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface( |
| 158 | resolved_method, pointer_size); |
| 159 | } else { |
| 160 | DCHECK(invoke->IsInvokeVirtual()); |
| 161 | resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual( |
| 162 | resolved_method, pointer_size); |
| 163 | } |
| 164 | |
| 165 | if (resolved_method == nullptr) { |
| 166 | // The information we had on the receiver was not enough to find |
| 167 | // the target method. Since we check above the exact type of the receiver, |
| 168 | // the only reason this can happen is an IncompatibleClassChangeError. |
| 169 | return nullptr; |
Alex Light | 9139e00 | 2015-10-09 15:59:48 -0700 | [diff] [blame] | 170 | } else if (!resolved_method->IsInvokable()) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 171 | // The information we had on the receiver was not enough to find |
| 172 | // the target method. Since we check above the exact type of the receiver, |
| 173 | // the only reason this can happen is an IncompatibleClassChangeError. |
| 174 | return nullptr; |
| 175 | } else if (IsMethodOrDeclaringClassFinal(resolved_method)) { |
| 176 | // A final method has to be the target method. |
| 177 | return resolved_method; |
| 178 | } else if (info.IsExact()) { |
| 179 | // If we found a method and the receiver's concrete type is statically |
| 180 | // known, we know for sure the target. |
| 181 | return resolved_method; |
| 182 | } else { |
| 183 | // Even if we did find a method, the receiver type was not enough to |
| 184 | // statically find the runtime target. |
| 185 | return nullptr; |
| 186 | } |
| 187 | } |
| 188 | |
| 189 | static uint32_t FindMethodIndexIn(ArtMethod* method, |
| 190 | const DexFile& dex_file, |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 191 | uint32_t name_and_signature_index) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 192 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 193 | if (IsSameDexFile(*method->GetDexFile(), dex_file)) { |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 194 | return method->GetDexMethodIndex(); |
| 195 | } else { |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 196 | return method->FindDexMethodIndexInOtherDexFile(dex_file, name_and_signature_index); |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 197 | } |
| 198 | } |
| 199 | |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 200 | static uint32_t FindClassIndexIn(mirror::Class* cls, |
| 201 | const DexFile& dex_file, |
| 202 | Handle<mirror::DexCache> dex_cache) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 203 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 204 | uint32_t index = DexFile::kDexNoIndex; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 205 | if (cls->GetDexCache() == nullptr) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 206 | DCHECK(cls->IsArrayClass()) << cls->PrettyClass(); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 207 | index = cls->FindTypeIndexInOtherDexFile(dex_file); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 208 | } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 209 | DCHECK(cls->IsProxyClass()) << cls->PrettyClass(); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 210 | // TODO: deal with proxy classes. |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 211 | } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) { |
Nicolas Geoffray | 491617a | 2016-07-19 17:06:23 +0100 | [diff] [blame] | 212 | DCHECK_EQ(cls->GetDexCache(), dex_cache.Get()); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 213 | index = cls->GetDexTypeIndex(); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 214 | // Update the dex cache to ensure the class is in. The generated code will |
| 215 | // consider it is. We make it safe by updating the dex cache, as other |
| 216 | // dex files might also load the class, and there is no guarantee the dex |
| 217 | // cache of the dex file of the class will be updated. |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 218 | if (dex_cache->GetResolvedType(index) == nullptr) { |
| 219 | dex_cache->SetResolvedType(index, cls); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 220 | } |
Nicolas Geoffray | 491617a | 2016-07-19 17:06:23 +0100 | [diff] [blame] | 221 | } else { |
| 222 | index = cls->FindTypeIndexInOtherDexFile(dex_file); |
| 223 | // We cannot guarantee the entry in the dex cache will resolve to the same class, |
| 224 | // as there may be different class loaders. So only return the index if it's |
| 225 | // the right class in the dex cache already. |
| 226 | if (index != DexFile::kDexNoIndex && dex_cache->GetResolvedType(index) != cls) { |
| 227 | index = DexFile::kDexNoIndex; |
| 228 | } |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 229 | } |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 230 | |
| 231 | return index; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 232 | } |
| 233 | |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 234 | class ScopedProfilingInfoInlineUse { |
| 235 | public: |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 236 | explicit ScopedProfilingInfoInlineUse(ArtMethod* method, Thread* self) |
| 237 | : method_(method), |
| 238 | self_(self), |
| 239 | // Fetch the profiling info ahead of using it. If it's null when fetching, |
| 240 | // we should not call JitCodeCache::DoneInlining. |
| 241 | profiling_info_( |
| 242 | Runtime::Current()->GetJit()->GetCodeCache()->NotifyCompilerUse(method, self)) { |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 243 | } |
| 244 | |
| 245 | ~ScopedProfilingInfoInlineUse() { |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 246 | if (profiling_info_ != nullptr) { |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 247 | PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize(); |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 248 | DCHECK_EQ(profiling_info_, method_->GetProfilingInfo(pointer_size)); |
| 249 | Runtime::Current()->GetJit()->GetCodeCache()->DoneCompilerUse(method_, self_); |
| 250 | } |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 251 | } |
| 252 | |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 253 | ProfilingInfo* GetProfilingInfo() const { return profiling_info_; } |
| 254 | |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 255 | private: |
| 256 | ArtMethod* const method_; |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 257 | Thread* const self_; |
| 258 | ProfilingInfo* const profiling_info_; |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 259 | }; |
| 260 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 261 | bool HInliner::TryInline(HInvoke* invoke_instruction) { |
Calin Juravle | 175dc73 | 2015-08-25 15:42:32 +0100 | [diff] [blame] | 262 | if (invoke_instruction->IsInvokeUnresolved()) { |
| 263 | return false; // Don't bother to move further if we know the method is unresolved. |
| 264 | } |
| 265 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 266 | ScopedObjectAccess soa(Thread::Current()); |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 267 | uint32_t method_index = invoke_instruction->GetDexMethodIndex(); |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 268 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 269 | VLOG(compiler) << "Try inlining " << caller_dex_file.PrettyMethod(method_index); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 270 | |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 271 | // We can query the dex cache directly. The verifier has populated it already. |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 272 | ArtMethod* resolved_method = invoke_instruction->GetResolvedMethod(); |
Andreas Gampe | fd2140f | 2015-12-23 16:30:44 -0800 | [diff] [blame] | 273 | ArtMethod* actual_method = nullptr; |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 274 | if (resolved_method == nullptr) { |
| 275 | DCHECK(invoke_instruction->IsInvokeStaticOrDirect()); |
| 276 | DCHECK(invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()); |
| 277 | VLOG(compiler) << "Not inlining a String.<init> method"; |
| 278 | return false; |
| 279 | } else if (invoke_instruction->IsInvokeStaticOrDirect()) { |
Andreas Gampe | fd2140f | 2015-12-23 16:30:44 -0800 | [diff] [blame] | 280 | actual_method = resolved_method; |
Vladimir Marko | 5815501 | 2015-08-19 12:49:41 +0000 | [diff] [blame] | 281 | } else { |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 282 | // Check if we can statically find the method. |
| 283 | actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 284 | } |
| 285 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 286 | if (actual_method != nullptr) { |
Calin Juravle | 6915898 | 2016-03-16 11:53:41 +0000 | [diff] [blame] | 287 | bool result = TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ true); |
| 288 | if (result && !invoke_instruction->IsInvokeStaticOrDirect()) { |
| 289 | MaybeRecordStat(kInlinedInvokeVirtualOrInterface); |
| 290 | } |
| 291 | return result; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 292 | } |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 293 | |
Andreas Gampe | fd2140f | 2015-12-23 16:30:44 -0800 | [diff] [blame] | 294 | DCHECK(!invoke_instruction->IsInvokeStaticOrDirect()); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 295 | |
| 296 | // Check if we can use an inline cache. |
| 297 | ArtMethod* caller = graph_->GetArtMethod(); |
Calin Juravle | ffc8707 | 2016-04-20 14:22:09 +0100 | [diff] [blame] | 298 | if (Runtime::Current()->UseJitCompilation()) { |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 299 | // Under JIT, we should always know the caller. |
| 300 | DCHECK(caller != nullptr); |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 301 | ScopedProfilingInfoInlineUse spiis(caller, soa.Self()); |
| 302 | ProfilingInfo* profiling_info = spiis.GetProfilingInfo(); |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 303 | if (profiling_info != nullptr) { |
| 304 | const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc()); |
Nicolas Geoffray | 07e3ca9 | 2016-03-11 09:57:57 +0000 | [diff] [blame] | 305 | if (ic.IsUninitialized()) { |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 306 | VLOG(compiler) << "Interface or virtual call to " |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 307 | << caller_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 308 | << " is not hit and not inlined"; |
| 309 | return false; |
| 310 | } else if (ic.IsMonomorphic()) { |
| 311 | MaybeRecordStat(kMonomorphicCall); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 312 | if (outermost_graph_->IsCompilingOsr()) { |
| 313 | // If we are compiling OSR, we pretend this call is polymorphic, as we may come from the |
| 314 | // interpreter and it may have seen different receiver types. |
| 315 | return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic); |
| 316 | } else { |
| 317 | return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic); |
| 318 | } |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 319 | } else if (ic.IsPolymorphic()) { |
| 320 | MaybeRecordStat(kPolymorphicCall); |
| 321 | return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic); |
| 322 | } else { |
| 323 | DCHECK(ic.IsMegamorphic()); |
| 324 | VLOG(compiler) << "Interface or virtual call to " |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 325 | << caller_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | b6e20ae | 2016-03-07 14:29:04 +0000 | [diff] [blame] | 326 | << " is megamorphic and not inlined"; |
| 327 | MaybeRecordStat(kMegamorphicCall); |
| 328 | return false; |
| 329 | } |
Nicolas Geoffray | 454a481 | 2015-06-09 10:37:32 +0100 | [diff] [blame] | 330 | } |
| 331 | } |
| 332 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 333 | VLOG(compiler) << "Interface or virtual call to " |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 334 | << caller_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 335 | << " could not be statically determined"; |
| 336 | return false; |
| 337 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 338 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 339 | HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker, |
| 340 | HInstruction* receiver, |
| 341 | uint32_t dex_pc) const { |
| 342 | ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0); |
| 343 | DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_"); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 344 | HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet( |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 345 | receiver, |
| 346 | Primitive::kPrimNot, |
| 347 | field->GetOffset(), |
| 348 | field->IsVolatile(), |
| 349 | field->GetDexFieldIndex(), |
| 350 | field->GetDeclaringClass()->GetDexClassDefIndex(), |
| 351 | *field->GetDexFile(), |
| 352 | handles_->NewHandle(field->GetDexCache()), |
| 353 | dex_pc); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 354 | // The class of a field is effectively final, and does not have any memory dependencies. |
| 355 | result->SetSideEffects(SideEffects::None()); |
| 356 | return result; |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 357 | } |
| 358 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 359 | bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction, |
| 360 | ArtMethod* resolved_method, |
| 361 | const InlineCache& ic) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 362 | DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface()) |
| 363 | << invoke_instruction->DebugName(); |
| 364 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 365 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
Nicolas Geoffray | e4084a5 | 2016-02-18 14:43:42 +0000 | [diff] [blame] | 366 | uint32_t class_index = FindClassIndexIn( |
| 367 | ic.GetMonomorphicType(), caller_dex_file, caller_compilation_unit_.GetDexCache()); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 368 | if (class_index == DexFile::kDexNoIndex) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 369 | VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method) |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 370 | << " from inline cache is not inlined because its class is not" |
| 371 | << " accessible to the caller"; |
| 372 | return false; |
| 373 | } |
| 374 | |
| 375 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 376 | PointerSize pointer_size = class_linker->GetImagePointerSize(); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 377 | if (invoke_instruction->IsInvokeInterface()) { |
| 378 | resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface( |
| 379 | resolved_method, pointer_size); |
| 380 | } else { |
| 381 | DCHECK(invoke_instruction->IsInvokeVirtual()); |
| 382 | resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual( |
| 383 | resolved_method, pointer_size); |
| 384 | } |
| 385 | DCHECK(resolved_method != nullptr); |
| 386 | HInstruction* receiver = invoke_instruction->InputAt(0); |
| 387 | HInstruction* cursor = invoke_instruction->GetPrevious(); |
| 388 | HBasicBlock* bb_cursor = invoke_instruction->GetBlock(); |
| 389 | |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 390 | if (!TryInlineAndReplace(invoke_instruction, resolved_method, /* do_rtp */ false)) { |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 391 | return false; |
| 392 | } |
| 393 | |
| 394 | // We successfully inlined, now add a guard. |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 395 | bool is_referrer = |
| 396 | (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass()); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 397 | AddTypeGuard(receiver, |
| 398 | cursor, |
| 399 | bb_cursor, |
| 400 | class_index, |
| 401 | is_referrer, |
| 402 | invoke_instruction, |
| 403 | /* with_deoptimization */ true); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 404 | |
| 405 | // Run type propagation to get the guard typed, and eventually propagate the |
| 406 | // type of the receiver. |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 407 | ReferenceTypePropagation rtp_fixup(graph_, |
| 408 | outer_compilation_unit_.GetDexCache(), |
| 409 | handles_, |
| 410 | /* is_first_run */ false); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 411 | rtp_fixup.Run(); |
| 412 | |
| 413 | MaybeRecordStat(kInlinedMonomorphicCall); |
| 414 | return true; |
| 415 | } |
| 416 | |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 417 | HInstruction* HInliner::AddTypeGuard(HInstruction* receiver, |
| 418 | HInstruction* cursor, |
| 419 | HBasicBlock* bb_cursor, |
| 420 | uint32_t class_index, |
| 421 | bool is_referrer, |
| 422 | HInstruction* invoke_instruction, |
| 423 | bool with_deoptimization) { |
| 424 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
| 425 | HInstanceFieldGet* receiver_class = BuildGetReceiverClass( |
| 426 | class_linker, receiver, invoke_instruction->GetDexPc()); |
| 427 | |
| 428 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
| 429 | // Note that we will just compare the classes, so we don't need Java semantics access checks. |
| 430 | // Also, the caller of `AddTypeGuard` must have guaranteed that the class is in the dex cache. |
| 431 | HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(), |
| 432 | class_index, |
| 433 | caller_dex_file, |
| 434 | is_referrer, |
| 435 | invoke_instruction->GetDexPc(), |
| 436 | /* needs_access_check */ false, |
Mathieu Chartier | 31b12e3 | 2016-09-02 17:11:57 -0700 | [diff] [blame] | 437 | /* is_in_dex_cache */ true, |
| 438 | /* is_in_boot_image */ false); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 439 | |
| 440 | HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class); |
| 441 | // TODO: Extend reference type propagation to understand the guard. |
| 442 | if (cursor != nullptr) { |
| 443 | bb_cursor->InsertInstructionAfter(receiver_class, cursor); |
| 444 | } else { |
| 445 | bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction()); |
| 446 | } |
| 447 | bb_cursor->InsertInstructionAfter(load_class, receiver_class); |
| 448 | bb_cursor->InsertInstructionAfter(compare, load_class); |
| 449 | if (with_deoptimization) { |
| 450 | HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize( |
| 451 | compare, invoke_instruction->GetDexPc()); |
| 452 | bb_cursor->InsertInstructionAfter(deoptimize, compare); |
| 453 | deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
| 454 | } |
| 455 | return compare; |
| 456 | } |
| 457 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 458 | bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction, |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 459 | ArtMethod* resolved_method, |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 460 | const InlineCache& ic) { |
| 461 | DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface()) |
| 462 | << invoke_instruction->DebugName(); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 463 | |
| 464 | if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, ic)) { |
| 465 | return true; |
| 466 | } |
| 467 | |
| 468 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 469 | PointerSize pointer_size = class_linker->GetImagePointerSize(); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 470 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
| 471 | |
| 472 | bool all_targets_inlined = true; |
| 473 | bool one_target_inlined = false; |
| 474 | for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) { |
| 475 | if (ic.GetTypeAt(i) == nullptr) { |
| 476 | break; |
| 477 | } |
| 478 | ArtMethod* method = nullptr; |
| 479 | if (invoke_instruction->IsInvokeInterface()) { |
| 480 | method = ic.GetTypeAt(i)->FindVirtualMethodForInterface( |
| 481 | resolved_method, pointer_size); |
| 482 | } else { |
| 483 | DCHECK(invoke_instruction->IsInvokeVirtual()); |
| 484 | method = ic.GetTypeAt(i)->FindVirtualMethodForVirtual( |
| 485 | resolved_method, pointer_size); |
| 486 | } |
| 487 | |
| 488 | HInstruction* receiver = invoke_instruction->InputAt(0); |
| 489 | HInstruction* cursor = invoke_instruction->GetPrevious(); |
| 490 | HBasicBlock* bb_cursor = invoke_instruction->GetBlock(); |
| 491 | |
Nicolas Geoffray | 1fe26e1 | 2016-02-18 16:55:42 +0000 | [diff] [blame] | 492 | uint32_t class_index = FindClassIndexIn( |
| 493 | ic.GetTypeAt(i), caller_dex_file, caller_compilation_unit_.GetDexCache()); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 494 | HInstruction* return_replacement = nullptr; |
| 495 | if (class_index == DexFile::kDexNoIndex || |
| 496 | !TryBuildAndInline(invoke_instruction, method, &return_replacement)) { |
| 497 | all_targets_inlined = false; |
| 498 | } else { |
| 499 | one_target_inlined = true; |
| 500 | bool is_referrer = (ic.GetTypeAt(i) == outermost_graph_->GetArtMethod()->GetDeclaringClass()); |
| 501 | |
| 502 | // If we have inlined all targets before, and this receiver is the last seen, |
| 503 | // we deoptimize instead of keeping the original invoke instruction. |
| 504 | bool deoptimize = all_targets_inlined && |
| 505 | (i != InlineCache::kIndividualCacheSize - 1) && |
| 506 | (ic.GetTypeAt(i + 1) == nullptr); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 507 | |
| 508 | if (outermost_graph_->IsCompilingOsr()) { |
| 509 | // We do not support HDeoptimize in OSR methods. |
| 510 | deoptimize = false; |
| 511 | } |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 512 | HInstruction* compare = AddTypeGuard( |
| 513 | receiver, cursor, bb_cursor, class_index, is_referrer, invoke_instruction, deoptimize); |
| 514 | if (deoptimize) { |
| 515 | if (return_replacement != nullptr) { |
| 516 | invoke_instruction->ReplaceWith(return_replacement); |
| 517 | } |
| 518 | invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction); |
| 519 | // Because the inline cache data can be populated concurrently, we force the end of the |
| 520 | // iteration. Otherhwise, we could see a new receiver type. |
| 521 | break; |
| 522 | } else { |
| 523 | CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction); |
| 524 | } |
| 525 | } |
| 526 | } |
| 527 | |
| 528 | if (!one_target_inlined) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 529 | VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method) |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 530 | << " from inline cache is not inlined because none" |
| 531 | << " of its targets could be inlined"; |
| 532 | return false; |
| 533 | } |
| 534 | MaybeRecordStat(kInlinedPolymorphicCall); |
| 535 | |
| 536 | // Run type propagation to get the guards typed. |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 537 | ReferenceTypePropagation rtp_fixup(graph_, |
| 538 | outer_compilation_unit_.GetDexCache(), |
| 539 | handles_, |
| 540 | /* is_first_run */ false); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 541 | rtp_fixup.Run(); |
| 542 | return true; |
| 543 | } |
| 544 | |
| 545 | void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare, |
| 546 | HInstruction* return_replacement, |
| 547 | HInstruction* invoke_instruction) { |
| 548 | uint32_t dex_pc = invoke_instruction->GetDexPc(); |
| 549 | HBasicBlock* cursor_block = compare->GetBlock(); |
| 550 | HBasicBlock* original_invoke_block = invoke_instruction->GetBlock(); |
| 551 | ArenaAllocator* allocator = graph_->GetArena(); |
| 552 | |
| 553 | // Spit the block after the compare: `cursor_block` will now be the start of the diamond, |
| 554 | // and the returned block is the start of the then branch (that could contain multiple blocks). |
| 555 | HBasicBlock* then = cursor_block->SplitAfterForInlining(compare); |
| 556 | |
| 557 | // Split the block containing the invoke before and after the invoke. The returned block |
| 558 | // of the split before will contain the invoke and will be the otherwise branch of |
| 559 | // the diamond. The returned block of the split after will be the merge block |
| 560 | // of the diamond. |
| 561 | HBasicBlock* end_then = invoke_instruction->GetBlock(); |
| 562 | HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction); |
| 563 | HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction); |
| 564 | |
| 565 | // If the methods we are inlining return a value, we create a phi in the merge block |
| 566 | // that will have the `invoke_instruction and the `return_replacement` as inputs. |
| 567 | if (return_replacement != nullptr) { |
| 568 | HPhi* phi = new (allocator) HPhi( |
| 569 | allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc); |
| 570 | merge->AddPhi(phi); |
| 571 | invoke_instruction->ReplaceWith(phi); |
| 572 | phi->AddInput(return_replacement); |
| 573 | phi->AddInput(invoke_instruction); |
| 574 | } |
| 575 | |
| 576 | // Add the control flow instructions. |
| 577 | otherwise->AddInstruction(new (allocator) HGoto(dex_pc)); |
| 578 | end_then->AddInstruction(new (allocator) HGoto(dex_pc)); |
| 579 | cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc)); |
| 580 | |
| 581 | // Add the newly created blocks to the graph. |
| 582 | graph_->AddBlock(then); |
| 583 | graph_->AddBlock(otherwise); |
| 584 | graph_->AddBlock(merge); |
| 585 | |
| 586 | // Set up successor (and implictly predecessor) relations. |
| 587 | cursor_block->AddSuccessor(otherwise); |
| 588 | cursor_block->AddSuccessor(then); |
| 589 | end_then->AddSuccessor(merge); |
| 590 | otherwise->AddSuccessor(merge); |
| 591 | |
| 592 | // Set up dominance information. |
| 593 | then->SetDominator(cursor_block); |
| 594 | cursor_block->AddDominatedBlock(then); |
| 595 | otherwise->SetDominator(cursor_block); |
| 596 | cursor_block->AddDominatedBlock(otherwise); |
| 597 | merge->SetDominator(cursor_block); |
| 598 | cursor_block->AddDominatedBlock(merge); |
| 599 | |
| 600 | // Update the revert post order. |
| 601 | size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block); |
| 602 | MakeRoomFor(&graph_->reverse_post_order_, 1, index); |
| 603 | graph_->reverse_post_order_[++index] = then; |
| 604 | index = IndexOfElement(graph_->reverse_post_order_, end_then); |
| 605 | MakeRoomFor(&graph_->reverse_post_order_, 2, index); |
| 606 | graph_->reverse_post_order_[++index] = otherwise; |
| 607 | graph_->reverse_post_order_[++index] = merge; |
| 608 | |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 609 | |
Nicolas Geoffray | a1d8ddf | 2016-02-29 11:46:58 +0000 | [diff] [blame] | 610 | graph_->UpdateLoopAndTryInformationOfNewBlock( |
| 611 | then, original_invoke_block, /* replace_if_back_edge */ false); |
| 612 | graph_->UpdateLoopAndTryInformationOfNewBlock( |
| 613 | otherwise, original_invoke_block, /* replace_if_back_edge */ false); |
| 614 | |
| 615 | // In case the original invoke location was a back edge, we need to update |
| 616 | // the loop to now have the merge block as a back edge. |
| 617 | graph_->UpdateLoopAndTryInformationOfNewBlock( |
| 618 | merge, original_invoke_block, /* replace_if_back_edge */ true); |
Nicolas Geoffray | 916cc1d | 2016-02-18 11:12:31 +0000 | [diff] [blame] | 619 | } |
| 620 | |
| 621 | bool HInliner::TryInlinePolymorphicCallToSameTarget(HInvoke* invoke_instruction, |
| 622 | ArtMethod* resolved_method, |
| 623 | const InlineCache& ic) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 624 | // This optimization only works under JIT for now. |
Calin Juravle | ffc8707 | 2016-04-20 14:22:09 +0100 | [diff] [blame] | 625 | DCHECK(Runtime::Current()->UseJitCompilation()); |
Roland Levillain | 2aba7cd | 2016-02-03 12:27:20 +0000 | [diff] [blame] | 626 | if (graph_->GetInstructionSet() == kMips64) { |
| 627 | // TODO: Support HClassTableGet for mips64. |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 628 | return false; |
| 629 | } |
| 630 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 631 | PointerSize pointer_size = class_linker->GetImagePointerSize(); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 632 | |
| 633 | DCHECK(resolved_method != nullptr); |
| 634 | ArtMethod* actual_method = nullptr; |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 635 | size_t method_index = invoke_instruction->IsInvokeVirtual() |
| 636 | ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex() |
| 637 | : invoke_instruction->AsInvokeInterface()->GetImtIndex(); |
| 638 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 639 | // Check whether we are actually calling the same method among |
| 640 | // the different types seen. |
| 641 | for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) { |
| 642 | if (ic.GetTypeAt(i) == nullptr) { |
| 643 | break; |
| 644 | } |
| 645 | ArtMethod* new_method = nullptr; |
| 646 | if (invoke_instruction->IsInvokeInterface()) { |
Artem Udovichenko | a62cb9b | 2016-06-30 09:18:25 +0000 | [diff] [blame] | 647 | new_method = ic.GetTypeAt(i)->GetImt(pointer_size)->Get( |
Matthew Gharrity | 465ecc8 | 2016-07-19 21:32:52 +0000 | [diff] [blame] | 648 | method_index, pointer_size); |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 649 | if (new_method->IsRuntimeMethod()) { |
| 650 | // Bail out as soon as we see a conflict trampoline in one of the target's |
| 651 | // interface table. |
| 652 | return false; |
| 653 | } |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 654 | } else { |
| 655 | DCHECK(invoke_instruction->IsInvokeVirtual()); |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 656 | new_method = ic.GetTypeAt(i)->GetEmbeddedVTableEntry(method_index, pointer_size); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 657 | } |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 658 | DCHECK(new_method != nullptr); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 659 | if (actual_method == nullptr) { |
| 660 | actual_method = new_method; |
| 661 | } else if (actual_method != new_method) { |
| 662 | // Different methods, bailout. |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 663 | VLOG(compiler) << "Call to " << ArtMethod::PrettyMethod(resolved_method) |
Nicolas Geoffray | d9994f0 | 2016-02-11 17:35:55 +0000 | [diff] [blame] | 664 | << " from inline cache is not inlined because it resolves" |
| 665 | << " to different methods"; |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 666 | return false; |
| 667 | } |
| 668 | } |
| 669 | |
| 670 | HInstruction* receiver = invoke_instruction->InputAt(0); |
| 671 | HInstruction* cursor = invoke_instruction->GetPrevious(); |
| 672 | HBasicBlock* bb_cursor = invoke_instruction->GetBlock(); |
| 673 | |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 674 | HInstruction* return_replacement = nullptr; |
| 675 | if (!TryBuildAndInline(invoke_instruction, actual_method, &return_replacement)) { |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 676 | return false; |
| 677 | } |
| 678 | |
| 679 | // We successfully inlined, now add a guard. |
| 680 | HInstanceFieldGet* receiver_class = BuildGetReceiverClass( |
| 681 | class_linker, receiver, invoke_instruction->GetDexPc()); |
| 682 | |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 683 | Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet()) |
| 684 | ? Primitive::kPrimLong |
| 685 | : Primitive::kPrimInt; |
| 686 | HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet( |
| 687 | receiver_class, |
| 688 | type, |
Vladimir Marko | a1de918 | 2016-02-25 11:37:38 +0000 | [diff] [blame] | 689 | invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable |
| 690 | : HClassTableGet::TableKind::kIMTable, |
Nicolas Geoffray | 4f97a21 | 2016-02-25 16:17:54 +0000 | [diff] [blame] | 691 | method_index, |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 692 | invoke_instruction->GetDexPc()); |
| 693 | |
| 694 | HConstant* constant; |
| 695 | if (type == Primitive::kPrimLong) { |
| 696 | constant = graph_->GetLongConstant( |
| 697 | reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc()); |
| 698 | } else { |
| 699 | constant = graph_->GetIntConstant( |
| 700 | reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc()); |
| 701 | } |
| 702 | |
| 703 | HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 704 | if (cursor != nullptr) { |
| 705 | bb_cursor->InsertInstructionAfter(receiver_class, cursor); |
| 706 | } else { |
| 707 | bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction()); |
| 708 | } |
| 709 | bb_cursor->InsertInstructionAfter(class_table_get, receiver_class); |
| 710 | bb_cursor->InsertInstructionAfter(compare, class_table_get); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 711 | |
| 712 | if (outermost_graph_->IsCompilingOsr()) { |
| 713 | CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction); |
| 714 | } else { |
| 715 | // TODO: Extend reference type propagation to understand the guard. |
| 716 | HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize( |
| 717 | compare, invoke_instruction->GetDexPc()); |
| 718 | bb_cursor->InsertInstructionAfter(deoptimize, compare); |
| 719 | deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
| 720 | if (return_replacement != nullptr) { |
| 721 | invoke_instruction->ReplaceWith(return_replacement); |
| 722 | } |
Nicolas Geoffray | 1be7cbd | 2016-04-29 13:56:01 +0100 | [diff] [blame] | 723 | invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction); |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 724 | } |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 725 | |
| 726 | // Run type propagation to get the guard typed. |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 727 | ReferenceTypePropagation rtp_fixup(graph_, |
| 728 | outer_compilation_unit_.GetDexCache(), |
| 729 | handles_, |
| 730 | /* is_first_run */ false); |
Nicolas Geoffray | a42363f | 2015-12-17 14:57:09 +0000 | [diff] [blame] | 731 | rtp_fixup.Run(); |
| 732 | |
| 733 | MaybeRecordStat(kInlinedPolymorphicCall); |
| 734 | |
| 735 | return true; |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 736 | } |
| 737 | |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 738 | bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) { |
| 739 | HInstruction* return_replacement = nullptr; |
| 740 | if (!TryBuildAndInline(invoke_instruction, method, &return_replacement)) { |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 741 | if (invoke_instruction->IsInvokeInterface()) { |
| 742 | // Turn an invoke-interface into an invoke-virtual. An invoke-virtual is always |
| 743 | // better than an invoke-interface because: |
| 744 | // 1) In the best case, the interface call has one more indirection (to fetch the IMT). |
| 745 | // 2) We will not go to the conflict trampoline with an invoke-virtual. |
| 746 | // TODO: Consider sharpening once it is not dependent on the compiler driver. |
| 747 | const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile(); |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 748 | uint32_t dex_method_index = FindMethodIndexIn( |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 749 | method, caller_dex_file, invoke_instruction->GetDexMethodIndex()); |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 750 | if (dex_method_index == DexFile::kDexNoIndex) { |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 751 | return false; |
| 752 | } |
| 753 | HInvokeVirtual* new_invoke = new (graph_->GetArena()) HInvokeVirtual( |
| 754 | graph_->GetArena(), |
| 755 | invoke_instruction->GetNumberOfArguments(), |
| 756 | invoke_instruction->GetType(), |
| 757 | invoke_instruction->GetDexPc(), |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 758 | dex_method_index, |
| 759 | method, |
Nicolas Geoffray | 5bf7bac | 2016-07-06 14:18:23 +0000 | [diff] [blame] | 760 | method->GetMethodIndex()); |
| 761 | HInputsRef inputs = invoke_instruction->GetInputs(); |
| 762 | for (size_t index = 0; index != inputs.size(); ++index) { |
| 763 | new_invoke->SetArgumentAt(index, inputs[index]); |
| 764 | } |
| 765 | invoke_instruction->GetBlock()->InsertInstructionBefore(new_invoke, invoke_instruction); |
| 766 | new_invoke->CopyEnvironmentFrom(invoke_instruction->GetEnvironment()); |
| 767 | if (invoke_instruction->GetType() == Primitive::kPrimNot) { |
| 768 | new_invoke->SetReferenceTypeInfo(invoke_instruction->GetReferenceTypeInfo()); |
| 769 | } |
| 770 | return_replacement = new_invoke; |
| 771 | } else { |
| 772 | // TODO: Consider sharpening an invoke virtual once it is not dependent on the |
| 773 | // compiler driver. |
| 774 | return false; |
| 775 | } |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 776 | } |
| 777 | if (return_replacement != nullptr) { |
| 778 | invoke_instruction->ReplaceWith(return_replacement); |
| 779 | } |
| 780 | invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction); |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 781 | FixUpReturnReferenceType(method, return_replacement); |
| 782 | if (do_rtp && ReturnTypeMoreSpecific(invoke_instruction, return_replacement)) { |
| 783 | // Actual return value has a more specific type than the method's declared |
| 784 | // return type. Run RTP again on the outer graph to propagate it. |
| 785 | ReferenceTypePropagation(graph_, |
| 786 | outer_compilation_unit_.GetDexCache(), |
| 787 | handles_, |
| 788 | /* is_first_run */ false).Run(); |
| 789 | } |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 790 | return true; |
| 791 | } |
| 792 | |
| 793 | bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction, |
| 794 | ArtMethod* method, |
| 795 | HInstruction** return_replacement) { |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 796 | if (method->IsProxyMethod()) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 797 | VLOG(compiler) << "Method " << method->PrettyMethod() |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 798 | << " is not inlined because of unimplemented inline support for proxy methods."; |
| 799 | return false; |
| 800 | } |
| 801 | |
Jeff Hao | dcdc85b | 2015-12-04 14:06:18 -0800 | [diff] [blame] | 802 | // Check whether we're allowed to inline. The outermost compilation unit is the relevant |
| 803 | // dex file here (though the transitivity of an inline chain would allow checking the calller). |
| 804 | if (!compiler_driver_->MayInline(method->GetDexFile(), |
| 805 | outer_compilation_unit_.GetDexFile())) { |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 806 | if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 807 | VLOG(compiler) << "Successfully replaced pattern of invoke " |
| 808 | << method->PrettyMethod(); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 809 | MaybeRecordStat(kReplacedInvokeWithSimplePattern); |
| 810 | return true; |
| 811 | } |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 812 | VLOG(compiler) << "Won't inline " << method->PrettyMethod() << " in " |
Jeff Hao | dcdc85b | 2015-12-04 14:06:18 -0800 | [diff] [blame] | 813 | << outer_compilation_unit_.GetDexFile()->GetLocation() << " (" |
| 814 | << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from " |
| 815 | << method->GetDexFile()->GetLocation(); |
| 816 | return false; |
| 817 | } |
| 818 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 819 | bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile()); |
| 820 | |
| 821 | const DexFile::CodeItem* code_item = method->GetCodeItem(); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 822 | |
| 823 | if (code_item == nullptr) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 824 | VLOG(compiler) << "Method " << method->PrettyMethod() |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 825 | << " is not inlined because it is native"; |
| 826 | return false; |
| 827 | } |
| 828 | |
Calin Juravle | ec74835 | 2015-07-29 13:52:12 +0100 | [diff] [blame] | 829 | size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits(); |
| 830 | if (code_item->insns_size_in_code_units_ > inline_max_code_units) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 831 | VLOG(compiler) << "Method " << method->PrettyMethod() |
Nicolas Geoffray | 788f2f0 | 2016-01-22 12:41:38 +0000 | [diff] [blame] | 832 | << " is too big to inline: " |
| 833 | << code_item->insns_size_in_code_units_ |
| 834 | << " > " |
| 835 | << inline_max_code_units; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 836 | return false; |
| 837 | } |
| 838 | |
| 839 | if (code_item->tries_size_ != 0) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 840 | VLOG(compiler) << "Method " << method->PrettyMethod() |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 841 | << " is not inlined because of try block"; |
| 842 | return false; |
| 843 | } |
| 844 | |
Nicolas Geoffray | 250a378 | 2016-04-20 16:27:53 +0100 | [diff] [blame] | 845 | if (!method->IsCompilable()) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 846 | VLOG(compiler) << "Method " << method->PrettyMethod() |
Nicolas Geoffray | 250a378 | 2016-04-20 16:27:53 +0100 | [diff] [blame] | 847 | << " has soft failures un-handled by the compiler, so it cannot be inlined"; |
| 848 | } |
| 849 | |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 850 | if (!method->GetDeclaringClass()->IsVerified()) { |
| 851 | uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex(); |
Calin Juravle | ffc8707 | 2016-04-20 14:22:09 +0100 | [diff] [blame] | 852 | if (Runtime::Current()->UseJitCompilation() || |
Nicolas Geoffray | 5b82d33 | 2016-02-18 14:22:32 +0000 | [diff] [blame] | 853 | !compiler_driver_->IsMethodVerifiedWithoutFailures( |
| 854 | method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 855 | VLOG(compiler) << "Method " << method->PrettyMethod() |
Nicolas Geoffray | ccc6197 | 2015-10-01 14:34:20 +0100 | [diff] [blame] | 856 | << " couldn't be verified, so it cannot be inlined"; |
| 857 | return false; |
| 858 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 859 | } |
| 860 | |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 861 | if (invoke_instruction->IsInvokeStaticOrDirect() && |
| 862 | invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) { |
| 863 | // Case of a static method that cannot be inlined because it implicitly |
| 864 | // requires an initialization check of its declaring class. |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 865 | VLOG(compiler) << "Method " << method->PrettyMethod() |
Roland Levillain | 4c0eb42 | 2015-04-24 16:43:49 +0100 | [diff] [blame] | 866 | << " is not inlined because it is static and requires a clinit" |
| 867 | << " check that cannot be emitted due to Dex cache limitations"; |
| 868 | return false; |
| 869 | } |
| 870 | |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 871 | if (!TryBuildAndInlineHelper(invoke_instruction, method, same_dex_file, return_replacement)) { |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 872 | return false; |
| 873 | } |
| 874 | |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 875 | VLOG(compiler) << "Successfully inlined " << method->PrettyMethod(); |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 876 | MaybeRecordStat(kInlinedInvoke); |
| 877 | return true; |
| 878 | } |
| 879 | |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 880 | static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction, |
| 881 | size_t arg_vreg_index) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 882 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 883 | size_t input_index = 0; |
| 884 | for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) { |
| 885 | DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments()); |
| 886 | if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) { |
| 887 | ++i; |
| 888 | DCHECK_NE(i, arg_vreg_index); |
| 889 | } |
| 890 | } |
| 891 | DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments()); |
| 892 | return invoke_instruction->InputAt(input_index); |
| 893 | } |
| 894 | |
| 895 | // Try to recognize known simple patterns and replace invoke call with appropriate instructions. |
| 896 | bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction, |
| 897 | ArtMethod* resolved_method, |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 898 | HInstruction** return_replacement) { |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 899 | InlineMethod inline_method; |
| 900 | if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) { |
| 901 | return false; |
| 902 | } |
| 903 | |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 904 | switch (inline_method.opcode) { |
| 905 | case kInlineOpNop: |
| 906 | DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 907 | *return_replacement = nullptr; |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 908 | break; |
| 909 | case kInlineOpReturnArg: |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 910 | *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, |
| 911 | inline_method.d.return_data.arg); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 912 | break; |
| 913 | case kInlineOpNonWideConst: |
| 914 | if (resolved_method->GetShorty()[0] == 'L') { |
| 915 | DCHECK_EQ(inline_method.d.data, 0u); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 916 | *return_replacement = graph_->GetNullConstant(); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 917 | } else { |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 918 | *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data)); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 919 | } |
| 920 | break; |
| 921 | case kInlineOpIGet: { |
| 922 | const InlineIGetIPutData& data = inline_method.d.ifield_data; |
| 923 | if (data.method_is_static || data.object_arg != 0u) { |
| 924 | // TODO: Needs null check. |
| 925 | return false; |
| 926 | } |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 927 | Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache())); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 928 | HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg); |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 929 | HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 930 | DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset); |
| 931 | DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile); |
| 932 | invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 933 | *return_replacement = iget; |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 934 | break; |
| 935 | } |
| 936 | case kInlineOpIPut: { |
| 937 | const InlineIGetIPutData& data = inline_method.d.ifield_data; |
| 938 | if (data.method_is_static || data.object_arg != 0u) { |
| 939 | // TODO: Needs null check. |
| 940 | return false; |
| 941 | } |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 942 | Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache())); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 943 | HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg); |
| 944 | HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg); |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 945 | HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 946 | DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset); |
| 947 | DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile); |
| 948 | invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction); |
| 949 | if (data.return_arg_plus1 != 0u) { |
| 950 | size_t return_arg = data.return_arg_plus1 - 1u; |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 951 | *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 952 | } |
| 953 | break; |
| 954 | } |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 955 | case kInlineOpConstructor: { |
| 956 | const InlineConstructorData& data = inline_method.d.constructor_data; |
| 957 | // Get the indexes to arrays for easier processing. |
| 958 | uint16_t iput_field_indexes[] = { |
| 959 | data.iput0_field_index, data.iput1_field_index, data.iput2_field_index |
| 960 | }; |
| 961 | uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg }; |
| 962 | static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch"); |
| 963 | // Count valid field indexes. |
| 964 | size_t number_of_iputs = 0u; |
| 965 | while (number_of_iputs != arraysize(iput_field_indexes) && |
| 966 | iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) { |
| 967 | // Check that there are no duplicate valid field indexes. |
| 968 | DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1, |
| 969 | iput_field_indexes + arraysize(iput_field_indexes), |
| 970 | iput_field_indexes[number_of_iputs])); |
| 971 | ++number_of_iputs; |
| 972 | } |
| 973 | // Check that there are no valid field indexes in the rest of the array. |
| 974 | DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs, |
| 975 | iput_field_indexes + arraysize(iput_field_indexes), |
| 976 | [](uint16_t index) { return index != DexFile::kDexNoIndex16; })); |
| 977 | |
| 978 | // Create HInstanceFieldSet for each IPUT that stores non-zero data. |
| 979 | Handle<mirror::DexCache> dex_cache; |
| 980 | HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u); |
| 981 | bool needs_constructor_barrier = false; |
| 982 | for (size_t i = 0; i != number_of_iputs; ++i) { |
| 983 | HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]); |
Roland Levillain | 1a65388 | 2016-03-18 18:05:57 +0000 | [diff] [blame] | 984 | if (!value->IsConstant() || !value->AsConstant()->IsZeroBitPattern()) { |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 985 | if (dex_cache.GetReference() == nullptr) { |
| 986 | dex_cache = handles_->NewHandle(resolved_method->GetDexCache()); |
| 987 | } |
| 988 | uint16_t field_index = iput_field_indexes[i]; |
| 989 | HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value); |
| 990 | invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction); |
| 991 | |
| 992 | // Check whether the field is final. If it is, we need to add a barrier. |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 993 | PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet()); |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 994 | ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size); |
| 995 | DCHECK(resolved_field != nullptr); |
| 996 | if (resolved_field->IsFinal()) { |
| 997 | needs_constructor_barrier = true; |
| 998 | } |
| 999 | } |
| 1000 | } |
| 1001 | if (needs_constructor_barrier) { |
| 1002 | HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc); |
| 1003 | invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction); |
| 1004 | } |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1005 | *return_replacement = nullptr; |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1006 | break; |
| 1007 | } |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1008 | default: |
| 1009 | LOG(FATAL) << "UNREACHABLE"; |
| 1010 | UNREACHABLE(); |
| 1011 | } |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1012 | return true; |
| 1013 | } |
| 1014 | |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1015 | HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache, |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1016 | uint32_t field_index, |
| 1017 | HInstruction* obj) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 1018 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 1019 | PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet()); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1020 | ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size); |
| 1021 | DCHECK(resolved_field != nullptr); |
| 1022 | HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet( |
| 1023 | obj, |
| 1024 | resolved_field->GetTypeAsPrimitiveType(), |
| 1025 | resolved_field->GetOffset(), |
| 1026 | resolved_field->IsVolatile(), |
| 1027 | field_index, |
| 1028 | resolved_field->GetDeclaringClass()->GetDexClassDefIndex(), |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1029 | *dex_cache->GetDexFile(), |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1030 | dex_cache, |
Vladimir Marko | adda435 | 2016-01-29 10:24:41 +0000 | [diff] [blame] | 1031 | // Read barrier generates a runtime call in slow path and we need a valid |
| 1032 | // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537. |
| 1033 | /* dex_pc */ 0); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1034 | if (iget->GetType() == Primitive::kPrimNot) { |
Vladimir Marko | 456307a | 2016-04-19 14:12:13 +0000 | [diff] [blame] | 1035 | // Use the same dex_cache that we used for field lookup as the hint_dex_cache. |
| 1036 | ReferenceTypePropagation rtp(graph_, dex_cache, handles_, /* is_first_run */ false); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1037 | rtp.Visit(iget); |
| 1038 | } |
| 1039 | return iget; |
| 1040 | } |
| 1041 | |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1042 | HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache, |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1043 | uint32_t field_index, |
| 1044 | HInstruction* obj, |
| 1045 | HInstruction* value) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 1046 | REQUIRES_SHARED(Locks::mutator_lock_) { |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 1047 | PointerSize pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet()); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1048 | ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size); |
| 1049 | DCHECK(resolved_field != nullptr); |
| 1050 | HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet( |
| 1051 | obj, |
| 1052 | value, |
| 1053 | resolved_field->GetTypeAsPrimitiveType(), |
| 1054 | resolved_field->GetOffset(), |
| 1055 | resolved_field->IsVolatile(), |
| 1056 | field_index, |
| 1057 | resolved_field->GetDeclaringClass()->GetDexClassDefIndex(), |
Vladimir Marko | 354efa6 | 2016-02-04 19:46:56 +0000 | [diff] [blame] | 1058 | *dex_cache->GetDexFile(), |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1059 | dex_cache, |
Vladimir Marko | adda435 | 2016-01-29 10:24:41 +0000 | [diff] [blame] | 1060 | // Read barrier generates a runtime call in slow path and we need a valid |
| 1061 | // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537. |
| 1062 | /* dex_pc */ 0); |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1063 | return iput; |
| 1064 | } |
Nicolas Geoffray | d9994f0 | 2016-02-11 17:35:55 +0000 | [diff] [blame] | 1065 | |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1066 | bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction, |
| 1067 | ArtMethod* resolved_method, |
| 1068 | bool same_dex_file, |
| 1069 | HInstruction** return_replacement) { |
Nicolas Geoffray | c0365b1 | 2015-03-18 18:31:52 +0000 | [diff] [blame] | 1070 | ScopedObjectAccess soa(Thread::Current()); |
| 1071 | const DexFile::CodeItem* code_item = resolved_method->GetCodeItem(); |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 1072 | const DexFile& callee_dex_file = *resolved_method->GetDexFile(); |
| 1073 | uint32_t method_index = resolved_method->GetDexMethodIndex(); |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 1074 | ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker(); |
Mathieu Chartier | 736b560 | 2015-09-02 14:54:11 -0700 | [diff] [blame] | 1075 | Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache())); |
Nicolas Geoffray | f1aedb1 | 2016-07-28 03:49:14 +0100 | [diff] [blame] | 1076 | Handle<mirror::ClassLoader> class_loader(handles_->NewHandle( |
| 1077 | resolved_method->GetDeclaringClass()->GetClassLoader())); |
| 1078 | |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1079 | DexCompilationUnit dex_compilation_unit( |
Nicolas Geoffray | f1aedb1 | 2016-07-28 03:49:14 +0100 | [diff] [blame] | 1080 | class_loader.ToJObject(), |
Nicolas Geoffray | 5b82d33 | 2016-02-18 14:22:32 +0000 | [diff] [blame] | 1081 | class_linker, |
| 1082 | callee_dex_file, |
| 1083 | code_item, |
| 1084 | resolved_method->GetDeclaringClass()->GetDexClassDefIndex(), |
| 1085 | method_index, |
| 1086 | resolved_method->GetAccessFlags(), |
| 1087 | /* verified_method */ nullptr, |
| 1088 | dex_cache); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1089 | |
Calin Juravle | 3cd4fc8 | 2015-05-14 15:15:42 +0100 | [diff] [blame] | 1090 | bool requires_ctor_barrier = false; |
| 1091 | |
| 1092 | if (dex_compilation_unit.IsConstructor()) { |
| 1093 | // If it's a super invocation and we already generate a barrier there's no need |
| 1094 | // to generate another one. |
| 1095 | // We identify super calls by looking at the "this" pointer. If its value is the |
| 1096 | // same as the local "this" pointer then we must have a super invocation. |
| 1097 | bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue() |
| 1098 | && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis(); |
| 1099 | if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) { |
| 1100 | requires_ctor_barrier = false; |
| 1101 | } else { |
| 1102 | Thread* self = Thread::Current(); |
| 1103 | requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self, |
| 1104 | dex_compilation_unit.GetDexFile(), |
| 1105 | dex_compilation_unit.GetClassDefIndex()); |
| 1106 | } |
| 1107 | } |
| 1108 | |
Nicolas Geoffray | 5e4e11e | 2016-09-22 13:17:41 +0100 | [diff] [blame] | 1109 | InvokeType invoke_type = invoke_instruction->GetInvokeType(); |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 1110 | if (invoke_type == kInterface) { |
| 1111 | // We have statically resolved the dispatch. To please the class linker |
| 1112 | // at runtime, we change this call as if it was a virtual call. |
| 1113 | invoke_type = kVirtual; |
| 1114 | } |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 1115 | |
| 1116 | const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId(); |
Nicolas Geoffray | e0fe7ae | 2015-03-09 10:02:49 +0000 | [diff] [blame] | 1117 | HGraph* callee_graph = new (graph_->GetArena()) HGraph( |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 1118 | graph_->GetArena(), |
Guillaume "Vermeille" Sanchez | ae09d2d | 2015-05-29 10:52:55 +0100 | [diff] [blame] | 1119 | callee_dex_file, |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 1120 | method_index, |
Calin Juravle | 3cd4fc8 | 2015-05-14 15:15:42 +0100 | [diff] [blame] | 1121 | requires_ctor_barrier, |
Mathieu Chartier | e401d14 | 2015-04-22 13:56:20 -0700 | [diff] [blame] | 1122 | compiler_driver_->GetInstructionSet(), |
Nicolas Geoffray | 3507105 | 2015-06-09 15:43:38 +0100 | [diff] [blame] | 1123 | invoke_type, |
Nicolas Geoffray | 0a23d74 | 2015-05-07 11:57:35 +0100 | [diff] [blame] | 1124 | graph_->IsDebuggable(), |
Nicolas Geoffray | b331feb | 2016-02-05 16:51:53 +0000 | [diff] [blame] | 1125 | /* osr */ false, |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 1126 | caller_instruction_counter); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 1127 | callee_graph->SetArtMethod(resolved_method); |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 1128 | |
Roland Levillain | a8013fd | 2016-04-04 15:34:31 +0100 | [diff] [blame] | 1129 | // When they are needed, allocate `inline_stats` on the heap instead |
| 1130 | // of on the stack, as Clang might produce a stack frame too large |
| 1131 | // for this function, that would not fit the requirements of the |
| 1132 | // `-Wframe-larger-than` option. |
| 1133 | std::unique_ptr<OptimizingCompilerStats> inline_stats = |
| 1134 | (stats_ == nullptr) ? nullptr : MakeUnique<OptimizingCompilerStats>(); |
David Brazdil | 5e8b137 | 2015-01-23 14:39:08 +0000 | [diff] [blame] | 1135 | HGraphBuilder builder(callee_graph, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1136 | &dex_compilation_unit, |
| 1137 | &outer_compilation_unit_, |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1138 | resolved_method->GetDexFile(), |
David Brazdil | 86ea7ee | 2016-02-16 09:26:07 +0000 | [diff] [blame] | 1139 | *code_item, |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1140 | compiler_driver_, |
Roland Levillain | a8013fd | 2016-04-04 15:34:31 +0100 | [diff] [blame] | 1141 | inline_stats.get(), |
Vladimir Marko | 97d7e1c | 2016-10-04 14:44:28 +0100 | [diff] [blame] | 1142 | resolved_method->GetQuickenedInfo(class_linker->GetImagePointerSize()), |
David Brazdil | dee58d6 | 2016-04-07 09:54:26 +0000 | [diff] [blame] | 1143 | dex_cache, |
| 1144 | handles_); |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1145 | |
David Brazdil | dee58d6 | 2016-04-07 09:54:26 +0000 | [diff] [blame] | 1146 | if (builder.BuildGraph() != kAnalysisSuccess) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1147 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1148 | << " could not be built, so cannot be inlined"; |
| 1149 | return false; |
| 1150 | } |
| 1151 | |
Nicolas Geoffray | 259136f | 2014-12-17 23:21:58 +0000 | [diff] [blame] | 1152 | if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph, |
| 1153 | compiler_driver_->GetInstructionSet())) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1154 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | 259136f | 2014-12-17 23:21:58 +0000 | [diff] [blame] | 1155 | << " cannot be inlined because of the register allocator"; |
| 1156 | return false; |
| 1157 | } |
| 1158 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1159 | size_t parameter_index = 0; |
| 1160 | for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions()); |
| 1161 | !instructions.Done(); |
| 1162 | instructions.Advance()) { |
| 1163 | HInstruction* current = instructions.Current(); |
| 1164 | if (current->IsParameterValue()) { |
| 1165 | HInstruction* argument = invoke_instruction->InputAt(parameter_index++); |
| 1166 | if (argument->IsNullConstant()) { |
| 1167 | current->ReplaceWith(callee_graph->GetNullConstant()); |
| 1168 | } else if (argument->IsIntConstant()) { |
| 1169 | current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue())); |
| 1170 | } else if (argument->IsLongConstant()) { |
| 1171 | current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue())); |
| 1172 | } else if (argument->IsFloatConstant()) { |
| 1173 | current->ReplaceWith( |
| 1174 | callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue())); |
| 1175 | } else if (argument->IsDoubleConstant()) { |
| 1176 | current->ReplaceWith( |
| 1177 | callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue())); |
| 1178 | } else if (argument->GetType() == Primitive::kPrimNot) { |
| 1179 | current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo()); |
| 1180 | current->AsParameterValue()->SetCanBeNull(argument->CanBeNull()); |
| 1181 | } |
| 1182 | } |
| 1183 | } |
| 1184 | |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1185 | // We have replaced formal arguments with actual arguments. If actual types |
| 1186 | // are more specific than the declared ones, run RTP again on the inner graph. |
| 1187 | if (ArgumentTypesMoreSpecific(invoke_instruction, resolved_method)) { |
| 1188 | ReferenceTypePropagation(callee_graph, |
| 1189 | dex_compilation_unit.GetDexCache(), |
| 1190 | handles_, |
| 1191 | /* is_first_run */ false).Run(); |
| 1192 | } |
| 1193 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1194 | size_t number_of_instructions_budget = kMaximumNumberOfHInstructions; |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 1195 | size_t number_of_inlined_instructions = |
| 1196 | RunOptimizations(callee_graph, code_item, dex_compilation_unit); |
| 1197 | number_of_instructions_budget += number_of_inlined_instructions; |
Nicolas Geoffray | ef87c5d | 2015-01-30 12:41:14 +0000 | [diff] [blame] | 1198 | |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1199 | // TODO: We should abort only if all predecessors throw. However, |
| 1200 | // HGraph::InlineInto currently does not handle an exit block with |
| 1201 | // a throw predecessor. |
| 1202 | HBasicBlock* exit_block = callee_graph->GetExitBlock(); |
| 1203 | if (exit_block == nullptr) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1204 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1205 | << " could not be inlined because it has an infinite loop"; |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1206 | return false; |
| 1207 | } |
| 1208 | |
| 1209 | bool has_throw_predecessor = false; |
Vladimir Marko | 6058455 | 2015-09-03 13:35:12 +0000 | [diff] [blame] | 1210 | for (HBasicBlock* predecessor : exit_block->GetPredecessors()) { |
| 1211 | if (predecessor->GetLastInstruction()->IsThrow()) { |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1212 | has_throw_predecessor = true; |
| 1213 | break; |
| 1214 | } |
| 1215 | } |
| 1216 | if (has_throw_predecessor) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1217 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1218 | << " could not be inlined because one branch always throws"; |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1219 | return false; |
| 1220 | } |
| 1221 | |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1222 | size_t number_of_instructions = 0; |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 1223 | |
| 1224 | bool can_inline_environment = |
| 1225 | total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters; |
| 1226 | |
Vladimir Marko | 2c45bc9 | 2016-10-25 16:54:12 +0100 | [diff] [blame] | 1227 | // Skip the entry block, it does not contain instructions that prevent inlining. |
| 1228 | for (HBasicBlock* block : callee_graph->GetReversePostOrderSkipEntryBlock()) { |
Nicolas Geoffray | 788f2f0 | 2016-01-22 12:41:38 +0000 | [diff] [blame] | 1229 | if (block->IsLoopHeader() && block->GetLoopInformation()->IsIrreducible()) { |
| 1230 | // Don't inline methods with irreducible loops, they could prevent some |
| 1231 | // optimizations to run. |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1232 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | 788f2f0 | 2016-01-22 12:41:38 +0000 | [diff] [blame] | 1233 | << " could not be inlined because it contains an irreducible loop"; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1234 | return false; |
| 1235 | } |
| 1236 | |
| 1237 | for (HInstructionIterator instr_it(block->GetInstructions()); |
| 1238 | !instr_it.Done(); |
| 1239 | instr_it.Advance()) { |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 1240 | if (number_of_instructions++ == number_of_instructions_budget) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1241 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 1242 | << " is not inlined because its caller has reached" |
| 1243 | << " its instruction budget limit."; |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1244 | return false; |
| 1245 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1246 | HInstruction* current = instr_it.Current(); |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 1247 | if (!can_inline_environment && current->NeedsEnvironment()) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1248 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | 5949fa0 | 2015-12-18 10:57:10 +0000 | [diff] [blame] | 1249 | << " is not inlined because its caller has reached" |
| 1250 | << " its environment budget limit."; |
| 1251 | return false; |
| 1252 | } |
Nicolas Geoffray | 276d9da | 2015-02-02 18:24:11 +0000 | [diff] [blame] | 1253 | |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1254 | if (!same_dex_file && current->NeedsEnvironment()) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1255 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1256 | << " could not be inlined because " << current->DebugName() |
Nicolas Geoffray | d23eeef | 2015-05-18 22:31:29 +0100 | [diff] [blame] | 1257 | << " needs an environment and is in a different dex file"; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1258 | return false; |
| 1259 | } |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1260 | |
Vladimir Marko | dc151b2 | 2015-10-15 18:02:30 +0100 | [diff] [blame] | 1261 | if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1262 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | 9437b78 | 2015-03-25 10:08:51 +0000 | [diff] [blame] | 1263 | << " could not be inlined because " << current->DebugName() |
| 1264 | << " it is in a different dex file and requires access to the dex cache"; |
| 1265 | return false; |
| 1266 | } |
Nicolas Geoffray | d930929 | 2015-10-31 22:21:31 +0000 | [diff] [blame] | 1267 | |
| 1268 | if (current->IsNewInstance() && |
| 1269 | (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1270 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | d9994f0 | 2016-02-11 17:35:55 +0000 | [diff] [blame] | 1271 | << " could not be inlined because it is using an entrypoint" |
| 1272 | << " with access checks"; |
Nicolas Geoffray | d930929 | 2015-10-31 22:21:31 +0000 | [diff] [blame] | 1273 | // Allocation entrypoint does not handle inlined frames. |
| 1274 | return false; |
| 1275 | } |
| 1276 | |
| 1277 | if (current->IsNewArray() && |
| 1278 | (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) { |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1279 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | d9994f0 | 2016-02-11 17:35:55 +0000 | [diff] [blame] | 1280 | << " could not be inlined because it is using an entrypoint" |
| 1281 | << " with access checks"; |
Nicolas Geoffray | d930929 | 2015-10-31 22:21:31 +0000 | [diff] [blame] | 1282 | // Allocation entrypoint does not handle inlined frames. |
| 1283 | return false; |
| 1284 | } |
| 1285 | |
| 1286 | if (current->IsUnresolvedStaticFieldGet() || |
| 1287 | current->IsUnresolvedInstanceFieldGet() || |
| 1288 | current->IsUnresolvedStaticFieldSet() || |
| 1289 | current->IsUnresolvedInstanceFieldSet()) { |
| 1290 | // Entrypoint for unresolved fields does not handle inlined frames. |
David Sehr | 709b070 | 2016-10-13 09:12:37 -0700 | [diff] [blame] | 1291 | VLOG(compiler) << "Method " << callee_dex_file.PrettyMethod(method_index) |
Nicolas Geoffray | d9994f0 | 2016-02-11 17:35:55 +0000 | [diff] [blame] | 1292 | << " could not be inlined because it is using an unresolved" |
| 1293 | << " entrypoint"; |
Nicolas Geoffray | d930929 | 2015-10-31 22:21:31 +0000 | [diff] [blame] | 1294 | return false; |
| 1295 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1296 | } |
| 1297 | } |
Nicolas Geoffray | e418dda | 2015-08-11 20:03:09 -0700 | [diff] [blame] | 1298 | number_of_inlined_instructions_ += number_of_instructions; |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1299 | |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 1300 | DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId()) |
| 1301 | << "No instructions can be added to the outer graph while inner graph is being built"; |
| 1302 | |
| 1303 | const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId(); |
| 1304 | graph_->SetCurrentInstructionId(callee_instruction_counter); |
Nicolas Geoffray | 55bd749 | 2016-02-16 15:37:12 +0000 | [diff] [blame] | 1305 | *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction); |
David Brazdil | 3f52306 | 2016-02-29 16:53:33 +0000 | [diff] [blame] | 1306 | |
| 1307 | DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId()) |
| 1308 | << "No instructions can be added to the inner graph during inlining into the outer graph"; |
| 1309 | |
Vladimir Marko | be10e8e | 2016-01-22 12:09:44 +0000 | [diff] [blame] | 1310 | return true; |
| 1311 | } |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 1312 | |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 1313 | size_t HInliner::RunOptimizations(HGraph* callee_graph, |
| 1314 | const DexFile::CodeItem* code_item, |
| 1315 | const DexCompilationUnit& dex_compilation_unit) { |
Nicolas Geoffray | 93a18c5 | 2016-04-22 13:16:14 +0100 | [diff] [blame] | 1316 | // Note: if the outermost_graph_ is being compiled OSR, we should not run any |
| 1317 | // optimization that could lead to a HDeoptimize. The following optimizations do not. |
Andreas Gampe | ca620d7 | 2016-11-08 08:09:33 -0800 | [diff] [blame^] | 1318 | HDeadCodeElimination dce(callee_graph, stats_, "dead_code_elimination$inliner"); |
| 1319 | HConstantFolding fold(callee_graph, "constant_folding$inliner"); |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 1320 | HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_); |
| 1321 | InstructionSimplifier simplify(callee_graph, stats_); |
Nicolas Geoffray | 762869d | 2016-07-15 15:28:35 +0100 | [diff] [blame] | 1322 | IntrinsicsRecognizer intrinsics(callee_graph, stats_); |
Roland Levillain | a3aef2e | 2016-04-06 17:45:58 +0100 | [diff] [blame] | 1323 | |
| 1324 | HOptimization* optimizations[] = { |
| 1325 | &intrinsics, |
| 1326 | &sharpening, |
| 1327 | &simplify, |
| 1328 | &fold, |
| 1329 | &dce, |
| 1330 | }; |
| 1331 | |
| 1332 | for (size_t i = 0; i < arraysize(optimizations); ++i) { |
| 1333 | HOptimization* optimization = optimizations[i]; |
| 1334 | optimization->Run(); |
| 1335 | } |
| 1336 | |
| 1337 | size_t number_of_inlined_instructions = 0u; |
| 1338 | if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) { |
| 1339 | HInliner inliner(callee_graph, |
| 1340 | outermost_graph_, |
| 1341 | codegen_, |
| 1342 | outer_compilation_unit_, |
| 1343 | dex_compilation_unit, |
| 1344 | compiler_driver_, |
| 1345 | handles_, |
| 1346 | stats_, |
| 1347 | total_number_of_dex_registers_ + code_item->registers_size_, |
| 1348 | depth_ + 1); |
| 1349 | inliner.Run(); |
| 1350 | number_of_inlined_instructions += inliner.number_of_inlined_instructions_; |
| 1351 | } |
| 1352 | |
| 1353 | return number_of_inlined_instructions; |
| 1354 | } |
| 1355 | |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1356 | static bool IsReferenceTypeRefinement(ReferenceTypeInfo declared_rti, |
| 1357 | bool declared_can_be_null, |
| 1358 | HInstruction* actual_obj) |
Andreas Gampe | bdf7f1c | 2016-08-30 16:38:47 -0700 | [diff] [blame] | 1359 | REQUIRES_SHARED(Locks::mutator_lock_) { |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1360 | if (declared_can_be_null && !actual_obj->CanBeNull()) { |
| 1361 | return true; |
| 1362 | } |
| 1363 | |
| 1364 | ReferenceTypeInfo actual_rti = actual_obj->GetReferenceTypeInfo(); |
| 1365 | return (actual_rti.IsExact() && !declared_rti.IsExact()) || |
| 1366 | declared_rti.IsStrictSupertypeOf(actual_rti); |
| 1367 | } |
| 1368 | |
| 1369 | ReferenceTypeInfo HInliner::GetClassRTI(mirror::Class* klass) { |
| 1370 | return ReferenceTypePropagation::IsAdmissible(klass) |
| 1371 | ? ReferenceTypeInfo::Create(handles_->NewHandle(klass)) |
| 1372 | : graph_->GetInexactObjectRti(); |
| 1373 | } |
| 1374 | |
| 1375 | bool HInliner::ArgumentTypesMoreSpecific(HInvoke* invoke_instruction, ArtMethod* resolved_method) { |
| 1376 | // If this is an instance call, test whether the type of the `this` argument |
| 1377 | // is more specific than the class which declares the method. |
| 1378 | if (!resolved_method->IsStatic()) { |
| 1379 | if (IsReferenceTypeRefinement(GetClassRTI(resolved_method->GetDeclaringClass()), |
| 1380 | /* declared_can_be_null */ false, |
| 1381 | invoke_instruction->InputAt(0u))) { |
| 1382 | return true; |
| 1383 | } |
| 1384 | } |
| 1385 | |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 1386 | PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize(); |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1387 | |
| 1388 | // Iterate over the list of parameter types and test whether any of the |
| 1389 | // actual inputs has a more specific reference type than the type declared in |
| 1390 | // the signature. |
| 1391 | const DexFile::TypeList* param_list = resolved_method->GetParameterTypeList(); |
| 1392 | for (size_t param_idx = 0, |
| 1393 | input_idx = resolved_method->IsStatic() ? 0 : 1, |
| 1394 | e = (param_list == nullptr ? 0 : param_list->Size()); |
| 1395 | param_idx < e; |
| 1396 | ++param_idx, ++input_idx) { |
| 1397 | HInstruction* input = invoke_instruction->InputAt(input_idx); |
| 1398 | if (input->GetType() == Primitive::kPrimNot) { |
| 1399 | mirror::Class* param_cls = resolved_method->GetDexCacheResolvedType( |
| 1400 | param_list->GetTypeItem(param_idx).type_idx_, |
| 1401 | pointer_size); |
| 1402 | if (IsReferenceTypeRefinement(GetClassRTI(param_cls), |
| 1403 | /* declared_can_be_null */ true, |
| 1404 | input)) { |
| 1405 | return true; |
| 1406 | } |
| 1407 | } |
| 1408 | } |
| 1409 | |
| 1410 | return false; |
| 1411 | } |
| 1412 | |
| 1413 | bool HInliner::ReturnTypeMoreSpecific(HInvoke* invoke_instruction, |
| 1414 | HInstruction* return_replacement) { |
Alex Light | 68289a5 | 2015-12-15 17:30:30 -0800 | [diff] [blame] | 1415 | // Check the integrity of reference types and run another type propagation if needed. |
David Brazdil | 4833f5a | 2015-12-16 10:37:39 +0000 | [diff] [blame] | 1416 | if (return_replacement != nullptr) { |
| 1417 | if (return_replacement->GetType() == Primitive::kPrimNot) { |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1418 | // Test if the return type is a refinement of the declared return type. |
| 1419 | if (IsReferenceTypeRefinement(invoke_instruction->GetReferenceTypeInfo(), |
| 1420 | /* declared_can_be_null */ true, |
| 1421 | return_replacement)) { |
| 1422 | return true; |
| 1423 | } |
| 1424 | } else if (return_replacement->IsInstanceOf()) { |
| 1425 | // Inlining InstanceOf into an If may put a tighter bound on reference types. |
| 1426 | return true; |
| 1427 | } |
| 1428 | } |
| 1429 | |
| 1430 | return false; |
| 1431 | } |
| 1432 | |
| 1433 | void HInliner::FixUpReturnReferenceType(ArtMethod* resolved_method, |
| 1434 | HInstruction* return_replacement) { |
| 1435 | if (return_replacement != nullptr) { |
| 1436 | if (return_replacement->GetType() == Primitive::kPrimNot) { |
David Brazdil | 4833f5a | 2015-12-16 10:37:39 +0000 | [diff] [blame] | 1437 | if (!return_replacement->GetReferenceTypeInfo().IsValid()) { |
| 1438 | // Make sure that we have a valid type for the return. We may get an invalid one when |
| 1439 | // we inline invokes with multiple branches and create a Phi for the result. |
| 1440 | // TODO: we could be more precise by merging the phi inputs but that requires |
| 1441 | // some functionality from the reference type propagation. |
| 1442 | DCHECK(return_replacement->IsPhi()); |
Andreas Gampe | 542451c | 2016-07-26 09:02:02 -0700 | [diff] [blame] | 1443 | PointerSize pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize(); |
Nicolas Geoffray | 44fd0e5 | 2016-03-16 15:16:06 +0000 | [diff] [blame] | 1444 | mirror::Class* cls = resolved_method->GetReturnType(false /* resolve */, pointer_size); |
David Brazdil | 94ab38f | 2016-06-21 17:48:19 +0100 | [diff] [blame] | 1445 | return_replacement->SetReferenceTypeInfo(GetClassRTI(cls)); |
Nicolas Geoffray | 73be1e8 | 2015-09-17 15:22:56 +0100 | [diff] [blame] | 1446 | } |
Calin Juravle | cdfed3d | 2015-10-26 14:05:01 +0000 | [diff] [blame] | 1447 | } |
Calin Juravle | 2e76830 | 2015-07-28 14:41:11 +0000 | [diff] [blame] | 1448 | } |
Nicolas Geoffray | e53798a | 2014-12-01 10:31:54 +0000 | [diff] [blame] | 1449 | } |
| 1450 | |
| 1451 | } // namespace art |