Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 1 | /* |
| 2 | * Copyright © 2015 Intel Corporation |
| 3 | * |
| 4 | * Permission is hereby granted, free of charge, to any person obtaining a |
| 5 | * copy of this software and associated documentation files (the "Software"), |
| 6 | * to deal in the Software without restriction, including without limitation |
| 7 | * the rights to use, copy, modify, merge, publish, distribute, sublicense, |
| 8 | * and/or sell copies of the Software, and to permit persons to whom the |
| 9 | * Software is furnished to do so, subject to the following conditions: |
| 10 | * |
| 11 | * The above copyright notice and this permission notice (including the next |
| 12 | * paragraph) shall be included in all copies or substantial portions of the |
| 13 | * Software. |
| 14 | * |
| 15 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
| 16 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
| 17 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
| 18 | * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
| 19 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING |
| 20 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS |
| 21 | * IN THE SOFTWARE. |
| 22 | * |
| 23 | */ |
| 24 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 25 | #include <linux/kthread.h> |
Ingo Molnar | ae7e81c | 2017-02-01 18:07:51 +0100 | [diff] [blame] | 26 | #include <uapi/linux/sched/types.h> |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 27 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 28 | #include "i915_drv.h" |
| 29 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 30 | static unsigned int __intel_breadcrumbs_wakeup(struct intel_breadcrumbs *b) |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 31 | { |
Chris Wilson | 56299fb | 2017-02-27 20:58:48 +0000 | [diff] [blame] | 32 | struct intel_wait *wait; |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 33 | unsigned int result = 0; |
| 34 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 35 | lockdep_assert_held(&b->irq_lock); |
| 36 | |
| 37 | wait = b->irq_wait; |
Chris Wilson | 56299fb | 2017-02-27 20:58:48 +0000 | [diff] [blame] | 38 | if (wait) { |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 39 | result = ENGINE_WAKEUP_WAITER; |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 40 | if (wake_up_process(wait->tsk)) |
| 41 | result |= ENGINE_WAKEUP_ASLEEP; |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 42 | } |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 43 | |
| 44 | return result; |
| 45 | } |
| 46 | |
| 47 | unsigned int intel_engine_wakeup(struct intel_engine_cs *engine) |
| 48 | { |
| 49 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | 467221b | 2017-03-20 14:31:33 +0000 | [diff] [blame] | 50 | unsigned long flags; |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 51 | unsigned int result; |
| 52 | |
Chris Wilson | 467221b | 2017-03-20 14:31:33 +0000 | [diff] [blame] | 53 | spin_lock_irqsave(&b->irq_lock, flags); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 54 | result = __intel_breadcrumbs_wakeup(b); |
Chris Wilson | 467221b | 2017-03-20 14:31:33 +0000 | [diff] [blame] | 55 | spin_unlock_irqrestore(&b->irq_lock, flags); |
Chris Wilson | 8d769ea | 2017-02-27 20:58:47 +0000 | [diff] [blame] | 56 | |
| 57 | return result; |
| 58 | } |
| 59 | |
Chris Wilson | 2246bea | 2017-02-17 15:13:00 +0000 | [diff] [blame] | 60 | static unsigned long wait_timeout(void) |
| 61 | { |
| 62 | return round_jiffies_up(jiffies + DRM_I915_HANGCHECK_JIFFIES); |
| 63 | } |
| 64 | |
Chris Wilson | 80166e40 | 2017-02-28 08:50:18 +0000 | [diff] [blame] | 65 | static noinline void missed_breadcrumb(struct intel_engine_cs *engine) |
| 66 | { |
Helge Deller | 516726d | 2017-09-06 22:27:52 +0200 | [diff] [blame] | 67 | DRM_DEBUG_DRIVER("%s missed breadcrumb at %pS, irq posted? %s, current seqno=%x, last=%x\n", |
Chris Wilson | 80166e40 | 2017-02-28 08:50:18 +0000 | [diff] [blame] | 68 | engine->name, __builtin_return_address(0), |
| 69 | yesno(test_bit(ENGINE_IRQ_BREADCRUMB, |
Chris Wilson | 695eaa3 | 2017-04-23 18:06:19 +0100 | [diff] [blame] | 70 | &engine->irq_posted)), |
| 71 | intel_engine_get_seqno(engine), |
| 72 | intel_engine_last_submit(engine)); |
Chris Wilson | 80166e40 | 2017-02-28 08:50:18 +0000 | [diff] [blame] | 73 | |
| 74 | set_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings); |
| 75 | } |
| 76 | |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 77 | static void intel_breadcrumbs_hangcheck(struct timer_list *t) |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 78 | { |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 79 | struct intel_engine_cs *engine = from_timer(engine, t, |
| 80 | breadcrumbs.hangcheck); |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 81 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 82 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 83 | if (!b->irq_armed) |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 84 | return; |
| 85 | |
Chris Wilson | 2246bea | 2017-02-17 15:13:00 +0000 | [diff] [blame] | 86 | if (b->hangcheck_interrupts != atomic_read(&engine->irq_count)) { |
| 87 | b->hangcheck_interrupts = atomic_read(&engine->irq_count); |
| 88 | mod_timer(&b->hangcheck, wait_timeout()); |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 89 | return; |
| 90 | } |
| 91 | |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 92 | /* We keep the hangcheck timer alive until we disarm the irq, even |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 93 | * if there are no waiters at present. |
| 94 | * |
| 95 | * If the waiter was currently running, assume it hasn't had a chance |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 96 | * to process the pending interrupt (e.g, low priority task on a loaded |
| 97 | * system) and wait until it sleeps before declaring a missed interrupt. |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 98 | * |
| 99 | * If the waiter was asleep (and not even pending a wakeup), then we |
| 100 | * must have missed an interrupt as the GPU has stopped advancing |
| 101 | * but we still have a waiter. Assuming all batches complete within |
| 102 | * DRM_I915_HANGCHECK_JIFFIES [1.5s]! |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 103 | */ |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 104 | if (intel_engine_wakeup(engine) & ENGINE_WAKEUP_ASLEEP) { |
Chris Wilson | 80166e40 | 2017-02-28 08:50:18 +0000 | [diff] [blame] | 105 | missed_breadcrumb(engine); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 106 | mod_timer(&engine->breadcrumbs.fake_irq, jiffies + 1); |
| 107 | } else { |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 108 | mod_timer(&b->hangcheck, wait_timeout()); |
Chris Wilson | 8998567 | 2017-02-17 15:13:02 +0000 | [diff] [blame] | 109 | } |
Chris Wilson | 83348ba | 2016-08-09 17:47:51 +0100 | [diff] [blame] | 110 | } |
| 111 | |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 112 | static void intel_breadcrumbs_fake_irq(struct timer_list *t) |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 113 | { |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 114 | struct intel_engine_cs *engine = from_timer(engine, t, |
| 115 | breadcrumbs.fake_irq); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 116 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 117 | |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 118 | /* The timer persists in case we cannot enable interrupts, |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 119 | * or if we have previously seen seqno/interrupt incoherency |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 120 | * ("missed interrupt" syndrome, better known as a "missed breadcrumb"). |
| 121 | * Here the worker will wake up every jiffie in order to kick the |
| 122 | * oldest waiter to do the coherent seqno check. |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 123 | */ |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 124 | |
Tvrtko Ursulin | a9e6493 | 2017-03-06 15:03:20 +0000 | [diff] [blame] | 125 | spin_lock_irq(&b->irq_lock); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 126 | if (!__intel_breadcrumbs_wakeup(b)) |
| 127 | __intel_engine_disarm_breadcrumbs(engine); |
Tvrtko Ursulin | a9e6493 | 2017-03-06 15:03:20 +0000 | [diff] [blame] | 128 | spin_unlock_irq(&b->irq_lock); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 129 | if (!b->irq_armed) |
Chris Wilson | 19d0a57 | 2017-02-27 20:58:49 +0000 | [diff] [blame] | 130 | return; |
| 131 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 132 | mod_timer(&b->fake_irq, jiffies + 1); |
Chris Wilson | 19d0a57 | 2017-02-27 20:58:49 +0000 | [diff] [blame] | 133 | |
| 134 | /* Ensure that even if the GPU hangs, we get woken up. |
| 135 | * |
| 136 | * However, note that if no one is waiting, we never notice |
| 137 | * a gpu hang. Eventually, we will have to wait for a resource |
| 138 | * held by the GPU and so trigger a hangcheck. In the most |
| 139 | * pathological case, this will be upon memory starvation! To |
| 140 | * prevent this, we also queue the hangcheck from the retire |
| 141 | * worker. |
| 142 | */ |
| 143 | i915_queue_hangcheck(engine->i915); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 144 | } |
| 145 | |
| 146 | static void irq_enable(struct intel_engine_cs *engine) |
| 147 | { |
Chris Wilson | 3d5564e | 2016-07-01 17:23:23 +0100 | [diff] [blame] | 148 | /* Enabling the IRQ may miss the generation of the interrupt, but |
| 149 | * we still need to force the barrier before reading the seqno, |
| 150 | * just in case. |
| 151 | */ |
Chris Wilson | 538b257 | 2017-01-24 15:18:05 +0000 | [diff] [blame] | 152 | set_bit(ENGINE_IRQ_BREADCRUMB, &engine->irq_posted); |
Chris Wilson | 31bb59c | 2016-07-01 17:23:27 +0100 | [diff] [blame] | 153 | |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 154 | /* Caller disables interrupts */ |
| 155 | spin_lock(&engine->i915->irq_lock); |
Chris Wilson | 31bb59c | 2016-07-01 17:23:27 +0100 | [diff] [blame] | 156 | engine->irq_enable(engine); |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 157 | spin_unlock(&engine->i915->irq_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 158 | } |
| 159 | |
| 160 | static void irq_disable(struct intel_engine_cs *engine) |
| 161 | { |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 162 | /* Caller disables interrupts */ |
| 163 | spin_lock(&engine->i915->irq_lock); |
Chris Wilson | 31bb59c | 2016-07-01 17:23:27 +0100 | [diff] [blame] | 164 | engine->irq_disable(engine); |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 165 | spin_unlock(&engine->i915->irq_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 166 | } |
| 167 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 168 | void __intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine) |
| 169 | { |
| 170 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 171 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 172 | lockdep_assert_held(&b->irq_lock); |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 173 | GEM_BUG_ON(b->irq_wait); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 174 | |
| 175 | if (b->irq_enabled) { |
| 176 | irq_disable(engine); |
| 177 | b->irq_enabled = false; |
| 178 | } |
| 179 | |
| 180 | b->irq_armed = false; |
| 181 | } |
| 182 | |
| 183 | void intel_engine_disarm_breadcrumbs(struct intel_engine_cs *engine) |
| 184 | { |
| 185 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | a5cae7b | 2017-03-15 21:07:24 +0000 | [diff] [blame] | 186 | struct intel_wait *wait, *n, *first; |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 187 | |
| 188 | if (!b->irq_armed) |
| 189 | return; |
| 190 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 191 | /* We only disarm the irq when we are idle (all requests completed), |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 192 | * so if the bottom-half remains asleep, it missed the request |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 193 | * completion. |
| 194 | */ |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 195 | |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 196 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | a5cae7b | 2017-03-15 21:07:24 +0000 | [diff] [blame] | 197 | |
| 198 | spin_lock(&b->irq_lock); |
| 199 | first = fetch_and_zero(&b->irq_wait); |
| 200 | __intel_engine_disarm_breadcrumbs(engine); |
| 201 | spin_unlock(&b->irq_lock); |
| 202 | |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 203 | rbtree_postorder_for_each_entry_safe(wait, n, &b->waiters, node) { |
| 204 | RB_CLEAR_NODE(&wait->node); |
Chris Wilson | a5cae7b | 2017-03-15 21:07:24 +0000 | [diff] [blame] | 205 | if (wake_up_process(wait->tsk) && wait == first) |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 206 | missed_breadcrumb(engine); |
| 207 | } |
| 208 | b->waiters = RB_ROOT; |
| 209 | |
Chris Wilson | e1c0c91 | 2017-03-06 09:29:15 +0000 | [diff] [blame] | 210 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 211 | } |
| 212 | |
Chris Wilson | 6ef98ea | 2017-02-17 15:13:03 +0000 | [diff] [blame] | 213 | static bool use_fake_irq(const struct intel_breadcrumbs *b) |
| 214 | { |
| 215 | const struct intel_engine_cs *engine = |
| 216 | container_of(b, struct intel_engine_cs, breadcrumbs); |
| 217 | |
| 218 | if (!test_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings)) |
| 219 | return false; |
| 220 | |
| 221 | /* Only start with the heavy weight fake irq timer if we have not |
| 222 | * seen any interrupts since enabling it the first time. If the |
| 223 | * interrupts are still arriving, it means we made a mistake in our |
| 224 | * engine->seqno_barrier(), a timing error that should be transient |
| 225 | * and unlikely to reoccur. |
| 226 | */ |
| 227 | return atomic_read(&engine->irq_count) == b->hangcheck_interrupts; |
| 228 | } |
| 229 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 230 | static void enable_fake_irq(struct intel_breadcrumbs *b) |
| 231 | { |
| 232 | /* Ensure we never sleep indefinitely */ |
| 233 | if (!b->irq_enabled || use_fake_irq(b)) |
| 234 | mod_timer(&b->fake_irq, jiffies + 1); |
| 235 | else |
| 236 | mod_timer(&b->hangcheck, wait_timeout()); |
| 237 | } |
| 238 | |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 239 | static bool __intel_breadcrumbs_enable_irq(struct intel_breadcrumbs *b) |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 240 | { |
| 241 | struct intel_engine_cs *engine = |
| 242 | container_of(b, struct intel_engine_cs, breadcrumbs); |
| 243 | struct drm_i915_private *i915 = engine->i915; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 244 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 245 | lockdep_assert_held(&b->irq_lock); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 246 | if (b->irq_armed) |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 247 | return false; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 248 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 249 | /* The breadcrumb irq will be disarmed on the interrupt after the |
| 250 | * waiters are signaled. This gives us a single interrupt window in |
| 251 | * which we can add a new waiter and avoid the cost of re-enabling |
| 252 | * the irq. |
| 253 | */ |
| 254 | b->irq_armed = true; |
| 255 | GEM_BUG_ON(b->irq_enabled); |
| 256 | |
Chris Wilson | f97fbf9 | 2017-02-13 17:15:14 +0000 | [diff] [blame] | 257 | if (I915_SELFTEST_ONLY(b->mock)) { |
| 258 | /* For our mock objects we want to avoid interaction |
| 259 | * with the real hardware (which is not set up). So |
| 260 | * we simply pretend we have enabled the powerwell |
| 261 | * and the irq, and leave it up to the mock |
| 262 | * implementation to call intel_engine_wakeup() |
| 263 | * itself when it wants to simulate a user interrupt, |
| 264 | */ |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 265 | return true; |
Chris Wilson | f97fbf9 | 2017-02-13 17:15:14 +0000 | [diff] [blame] | 266 | } |
| 267 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 268 | /* Since we are waiting on a request, the GPU should be busy |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 269 | * and should have its own rpm reference. This is tracked |
| 270 | * by i915->gt.awake, we can forgo holding our own wakref |
| 271 | * for the interrupt as before i915->gt.awake is released (when |
| 272 | * the driver is idle) we disarm the breadcrumbs. |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 273 | */ |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 274 | |
| 275 | /* No interrupts? Kick the waiter every jiffie! */ |
| 276 | if (intel_irqs_enabled(i915)) { |
Chris Wilson | 3d5564e | 2016-07-01 17:23:23 +0100 | [diff] [blame] | 277 | if (!test_bit(engine->id, &i915->gpu_error.test_irq_rings)) |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 278 | irq_enable(engine); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 279 | b->irq_enabled = true; |
| 280 | } |
| 281 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 282 | enable_fake_irq(b); |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 283 | return true; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 284 | } |
| 285 | |
| 286 | static inline struct intel_wait *to_wait(struct rb_node *node) |
| 287 | { |
Chris Wilson | d856786 | 2016-12-20 10:40:03 +0000 | [diff] [blame] | 288 | return rb_entry(node, struct intel_wait, node); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 289 | } |
| 290 | |
| 291 | static inline void __intel_breadcrumbs_finish(struct intel_breadcrumbs *b, |
| 292 | struct intel_wait *wait) |
| 293 | { |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 294 | lockdep_assert_held(&b->rb_lock); |
Chris Wilson | 908a6cb | 2017-03-15 21:07:25 +0000 | [diff] [blame] | 295 | GEM_BUG_ON(b->irq_wait == wait); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 296 | |
| 297 | /* This request is completed, so remove it from the tree, mark it as |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 298 | * complete, and *then* wake up the associated task. N.B. when the |
| 299 | * task wakes up, it will find the empty rb_node, discern that it |
| 300 | * has already been removed from the tree and skip the serialisation |
| 301 | * of the b->rb_lock and b->irq_lock. This means that the destruction |
| 302 | * of the intel_wait is not serialised with the interrupt handler |
| 303 | * by the waiter - it must instead be serialised by the caller. |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 304 | */ |
| 305 | rb_erase(&wait->node, &b->waiters); |
| 306 | RB_CLEAR_NODE(&wait->node); |
| 307 | |
| 308 | wake_up_process(wait->tsk); /* implicit smp_wmb() */ |
| 309 | } |
| 310 | |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 311 | static inline void __intel_breadcrumbs_next(struct intel_engine_cs *engine, |
| 312 | struct rb_node *next) |
| 313 | { |
| 314 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 315 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 316 | spin_lock(&b->irq_lock); |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 317 | GEM_BUG_ON(!b->irq_armed); |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 318 | GEM_BUG_ON(!b->irq_wait); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 319 | b->irq_wait = to_wait(next); |
| 320 | spin_unlock(&b->irq_lock); |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 321 | |
| 322 | /* We always wake up the next waiter that takes over as the bottom-half |
| 323 | * as we may delegate not only the irq-seqno barrier to the next waiter |
| 324 | * but also the task of waking up concurrent waiters. |
| 325 | */ |
| 326 | if (next) |
| 327 | wake_up_process(to_wait(next)->tsk); |
| 328 | } |
| 329 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 330 | static bool __intel_engine_add_wait(struct intel_engine_cs *engine, |
| 331 | struct intel_wait *wait) |
| 332 | { |
| 333 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 334 | struct rb_node **p, *parent, *completed; |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 335 | bool first, armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 336 | u32 seqno; |
| 337 | |
| 338 | /* Insert the request into the retirement ordered list |
| 339 | * of waiters by walking the rbtree. If we are the oldest |
| 340 | * seqno in the tree (the first to be retired), then |
| 341 | * set ourselves as the bottom-half. |
| 342 | * |
| 343 | * As we descend the tree, prune completed branches since we hold the |
| 344 | * spinlock we know that the first_waiter must be delayed and can |
| 345 | * reduce some of the sequential wake up latency if we take action |
| 346 | * ourselves and wake up the completed tasks in parallel. Also, by |
| 347 | * removing stale elements in the tree, we may be able to reduce the |
| 348 | * ping-pong between the old bottom-half and ourselves as first-waiter. |
| 349 | */ |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 350 | armed = false; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 351 | first = true; |
| 352 | parent = NULL; |
| 353 | completed = NULL; |
Chris Wilson | 1b7744e | 2016-07-01 17:23:17 +0100 | [diff] [blame] | 354 | seqno = intel_engine_get_seqno(engine); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 355 | |
| 356 | /* If the request completed before we managed to grab the spinlock, |
| 357 | * return now before adding ourselves to the rbtree. We let the |
| 358 | * current bottom-half handle any pending wakeups and instead |
| 359 | * try and get out of the way quickly. |
| 360 | */ |
| 361 | if (i915_seqno_passed(seqno, wait->seqno)) { |
| 362 | RB_CLEAR_NODE(&wait->node); |
| 363 | return first; |
| 364 | } |
| 365 | |
| 366 | p = &b->waiters.rb_node; |
| 367 | while (*p) { |
| 368 | parent = *p; |
| 369 | if (wait->seqno == to_wait(parent)->seqno) { |
| 370 | /* We have multiple waiters on the same seqno, select |
| 371 | * the highest priority task (that with the smallest |
| 372 | * task->prio) to serve as the bottom-half for this |
| 373 | * group. |
| 374 | */ |
| 375 | if (wait->tsk->prio > to_wait(parent)->tsk->prio) { |
| 376 | p = &parent->rb_right; |
| 377 | first = false; |
| 378 | } else { |
| 379 | p = &parent->rb_left; |
| 380 | } |
| 381 | } else if (i915_seqno_passed(wait->seqno, |
| 382 | to_wait(parent)->seqno)) { |
| 383 | p = &parent->rb_right; |
| 384 | if (i915_seqno_passed(seqno, to_wait(parent)->seqno)) |
| 385 | completed = parent; |
| 386 | else |
| 387 | first = false; |
| 388 | } else { |
| 389 | p = &parent->rb_left; |
| 390 | } |
| 391 | } |
| 392 | rb_link_node(&wait->node, parent, p); |
| 393 | rb_insert_color(&wait->node, &b->waiters); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 394 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 395 | if (first) { |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 396 | spin_lock(&b->irq_lock); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 397 | b->irq_wait = wait; |
Chris Wilson | 0417131 | 2016-07-06 12:39:00 +0100 | [diff] [blame] | 398 | /* After assigning ourselves as the new bottom-half, we must |
| 399 | * perform a cursory check to prevent a missed interrupt. |
| 400 | * Either we miss the interrupt whilst programming the hardware, |
| 401 | * or if there was a previous waiter (for a later seqno) they |
| 402 | * may be woken instead of us (due to the inherent race |
Chris Wilson | aca34b6 | 2016-07-06 12:39:02 +0100 | [diff] [blame] | 403 | * in the unlocked read of b->irq_seqno_bh in the irq handler) |
| 404 | * and so we miss the wake up. |
Chris Wilson | 0417131 | 2016-07-06 12:39:00 +0100 | [diff] [blame] | 405 | */ |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 406 | armed = __intel_breadcrumbs_enable_irq(b); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 407 | spin_unlock(&b->irq_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 408 | } |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 409 | |
| 410 | if (completed) { |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 411 | /* Advance the bottom-half (b->irq_wait) before we wake up |
| 412 | * the waiters who may scribble over their intel_wait |
| 413 | * just as the interrupt handler is dereferencing it via |
| 414 | * b->irq_wait. |
| 415 | */ |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 416 | if (!first) { |
| 417 | struct rb_node *next = rb_next(completed); |
| 418 | GEM_BUG_ON(next == &wait->node); |
| 419 | __intel_breadcrumbs_next(engine, next); |
| 420 | } |
| 421 | |
| 422 | do { |
| 423 | struct intel_wait *crumb = to_wait(completed); |
| 424 | completed = rb_prev(completed); |
| 425 | __intel_breadcrumbs_finish(b, crumb); |
| 426 | } while (completed); |
| 427 | } |
| 428 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 429 | GEM_BUG_ON(!b->irq_wait); |
Chris Wilson | 429732e | 2017-03-15 21:07:23 +0000 | [diff] [blame] | 430 | GEM_BUG_ON(!b->irq_armed); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 431 | GEM_BUG_ON(rb_first(&b->waiters) != &b->irq_wait->node); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 432 | |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 433 | return armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 434 | } |
| 435 | |
| 436 | bool intel_engine_add_wait(struct intel_engine_cs *engine, |
| 437 | struct intel_wait *wait) |
| 438 | { |
| 439 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 440 | bool armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 441 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 442 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 443 | armed = __intel_engine_add_wait(engine, wait); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 444 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 445 | if (armed) |
| 446 | return armed; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 447 | |
Chris Wilson | bac2ef4 | 2017-06-08 12:14:03 +0100 | [diff] [blame] | 448 | /* Make the caller recheck if its request has already started. */ |
| 449 | return i915_seqno_passed(intel_engine_get_seqno(engine), |
| 450 | wait->seqno - 1); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 451 | } |
| 452 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 453 | static inline bool chain_wakeup(struct rb_node *rb, int priority) |
| 454 | { |
| 455 | return rb && to_wait(rb)->tsk->prio <= priority; |
| 456 | } |
| 457 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 458 | static inline int wakeup_priority(struct intel_breadcrumbs *b, |
| 459 | struct task_struct *tsk) |
| 460 | { |
| 461 | if (tsk == b->signaler) |
| 462 | return INT_MIN; |
| 463 | else |
| 464 | return tsk->prio; |
| 465 | } |
| 466 | |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 467 | static void __intel_engine_remove_wait(struct intel_engine_cs *engine, |
| 468 | struct intel_wait *wait) |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 469 | { |
| 470 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 471 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 472 | lockdep_assert_held(&b->rb_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 473 | |
| 474 | if (RB_EMPTY_NODE(&wait->node)) |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 475 | goto out; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 476 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 477 | if (b->irq_wait == wait) { |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 478 | const int priority = wakeup_priority(b, wait->tsk); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 479 | struct rb_node *next; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 480 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 481 | /* We are the current bottom-half. Find the next candidate, |
| 482 | * the first waiter in the queue on the remaining oldest |
| 483 | * request. As multiple seqnos may complete in the time it |
| 484 | * takes us to wake up and find the next waiter, we have to |
| 485 | * wake up that waiter for it to perform its own coherent |
| 486 | * completion check. |
| 487 | */ |
| 488 | next = rb_next(&wait->node); |
| 489 | if (chain_wakeup(next, priority)) { |
| 490 | /* If the next waiter is already complete, |
| 491 | * wake it up and continue onto the next waiter. So |
| 492 | * if have a small herd, they will wake up in parallel |
| 493 | * rather than sequentially, which should reduce |
| 494 | * the overall latency in waking all the completed |
| 495 | * clients. |
| 496 | * |
| 497 | * However, waking up a chain adds extra latency to |
| 498 | * the first_waiter. This is undesirable if that |
| 499 | * waiter is a high priority task. |
| 500 | */ |
Chris Wilson | 1b7744e | 2016-07-01 17:23:17 +0100 | [diff] [blame] | 501 | u32 seqno = intel_engine_get_seqno(engine); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 502 | |
| 503 | while (i915_seqno_passed(seqno, to_wait(next)->seqno)) { |
| 504 | struct rb_node *n = rb_next(next); |
| 505 | |
| 506 | __intel_breadcrumbs_finish(b, to_wait(next)); |
| 507 | next = n; |
| 508 | if (!chain_wakeup(next, priority)) |
| 509 | break; |
| 510 | } |
| 511 | } |
| 512 | |
Chris Wilson | b66255f | 2017-03-03 17:14:22 +0000 | [diff] [blame] | 513 | __intel_breadcrumbs_next(engine, next); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 514 | } else { |
| 515 | GEM_BUG_ON(rb_first(&b->waiters) == &wait->node); |
| 516 | } |
| 517 | |
| 518 | GEM_BUG_ON(RB_EMPTY_NODE(&wait->node)); |
| 519 | rb_erase(&wait->node, &b->waiters); |
Chris Wilson | 6e06827 | 2017-11-15 12:14:58 +0000 | [diff] [blame^] | 520 | RB_CLEAR_NODE(&wait->node); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 521 | |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 522 | out: |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 523 | GEM_BUG_ON(b->irq_wait == wait); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 524 | GEM_BUG_ON(rb_first(&b->waiters) != |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 525 | (b->irq_wait ? &b->irq_wait->node : NULL)); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 526 | } |
| 527 | |
| 528 | void intel_engine_remove_wait(struct intel_engine_cs *engine, |
| 529 | struct intel_wait *wait) |
| 530 | { |
| 531 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 532 | |
| 533 | /* Quick check to see if this waiter was already decoupled from |
| 534 | * the tree by the bottom-half to avoid contention on the spinlock |
| 535 | * by the herd. |
| 536 | */ |
Chris Wilson | 908a6cb | 2017-03-15 21:07:25 +0000 | [diff] [blame] | 537 | if (RB_EMPTY_NODE(&wait->node)) { |
| 538 | GEM_BUG_ON(READ_ONCE(b->irq_wait) == wait); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 539 | return; |
Chris Wilson | 908a6cb | 2017-03-15 21:07:25 +0000 | [diff] [blame] | 540 | } |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 541 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 542 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 543 | __intel_engine_remove_wait(engine, wait); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 544 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 545 | } |
| 546 | |
Chris Wilson | d6a2289 | 2017-02-23 07:44:17 +0000 | [diff] [blame] | 547 | static bool signal_valid(const struct drm_i915_gem_request *request) |
| 548 | { |
| 549 | return intel_wait_check_request(&request->signaling.wait, request); |
| 550 | } |
| 551 | |
| 552 | static bool signal_complete(const struct drm_i915_gem_request *request) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 553 | { |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 554 | if (!request) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 555 | return false; |
| 556 | |
| 557 | /* If another process served as the bottom-half it may have already |
| 558 | * signalled that this wait is already completed. |
| 559 | */ |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 560 | if (intel_wait_complete(&request->signaling.wait)) |
Chris Wilson | d6a2289 | 2017-02-23 07:44:17 +0000 | [diff] [blame] | 561 | return signal_valid(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 562 | |
| 563 | /* Carefully check if the request is complete, giving time for the |
| 564 | * seqno to be visible or if the GPU hung. |
| 565 | */ |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 566 | if (__i915_request_irq_complete(request)) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 567 | return true; |
| 568 | |
| 569 | return false; |
| 570 | } |
| 571 | |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 572 | static struct drm_i915_gem_request *to_signaler(struct rb_node *rb) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 573 | { |
Chris Wilson | d856786 | 2016-12-20 10:40:03 +0000 | [diff] [blame] | 574 | return rb_entry(rb, struct drm_i915_gem_request, signaling.node); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 575 | } |
| 576 | |
| 577 | static void signaler_set_rtpriority(void) |
| 578 | { |
| 579 | struct sched_param param = { .sched_priority = 1 }; |
| 580 | |
| 581 | sched_setscheduler_nocheck(current, SCHED_FIFO, ¶m); |
| 582 | } |
| 583 | |
| 584 | static int intel_breadcrumbs_signaler(void *arg) |
| 585 | { |
| 586 | struct intel_engine_cs *engine = arg; |
| 587 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 588 | struct drm_i915_gem_request *request; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 589 | |
| 590 | /* Install ourselves with high priority to reduce signalling latency */ |
| 591 | signaler_set_rtpriority(); |
| 592 | |
| 593 | do { |
Chris Wilson | a7980a6 | 2017-04-04 13:05:31 +0100 | [diff] [blame] | 594 | bool do_schedule = true; |
| 595 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 596 | set_current_state(TASK_INTERRUPTIBLE); |
| 597 | |
| 598 | /* We are either woken up by the interrupt bottom-half, |
| 599 | * or by a client adding a new signaller. In both cases, |
| 600 | * the GPU seqno may have advanced beyond our oldest signal. |
| 601 | * If it has, propagate the signal, remove the waiter and |
| 602 | * check again with the next oldest signal. Otherwise we |
| 603 | * need to wait for a new interrupt from the GPU or for |
| 604 | * a new client. |
| 605 | */ |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 606 | rcu_read_lock(); |
| 607 | request = rcu_dereference(b->first_signal); |
| 608 | if (request) |
| 609 | request = i915_gem_request_get_rcu(request); |
| 610 | rcu_read_unlock(); |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 611 | if (signal_complete(request)) { |
Chris Wilson | 7c9e934 | 2017-01-24 11:00:09 +0000 | [diff] [blame] | 612 | local_bh_disable(); |
| 613 | dma_fence_signal(&request->fence); |
| 614 | local_bh_enable(); /* kick start the tasklets */ |
| 615 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 616 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 617 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 618 | /* Wake up all other completed waiters and select the |
| 619 | * next bottom-half for the next user interrupt. |
| 620 | */ |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 621 | __intel_engine_remove_wait(engine, |
| 622 | &request->signaling.wait); |
Chris Wilson | 5590af3 | 2016-09-09 14:11:54 +0100 | [diff] [blame] | 623 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 624 | /* Find the next oldest signal. Note that as we have |
| 625 | * not been holding the lock, another client may |
| 626 | * have installed an even older signal than the one |
| 627 | * we just completed - so double check we are still |
| 628 | * the oldest before picking the next one. |
| 629 | */ |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 630 | if (request == rcu_access_pointer(b->first_signal)) { |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 631 | struct rb_node *rb = |
| 632 | rb_next(&request->signaling.node); |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 633 | rcu_assign_pointer(b->first_signal, |
| 634 | rb ? to_signaler(rb) : NULL); |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 635 | } |
| 636 | rb_erase(&request->signaling.node, &b->signals); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 637 | RB_CLEAR_NODE(&request->signaling.node); |
| 638 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 639 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 640 | |
Chris Wilson | e8a261e | 2016-07-20 13:31:49 +0100 | [diff] [blame] | 641 | i915_gem_request_put(request); |
Chris Wilson | a7980a6 | 2017-04-04 13:05:31 +0100 | [diff] [blame] | 642 | |
| 643 | /* If the engine is saturated we may be continually |
| 644 | * processing completed requests. This angers the |
| 645 | * NMI watchdog if we never let anything else |
| 646 | * have access to the CPU. Let's pretend to be nice |
| 647 | * and relinquish the CPU if we burn through the |
| 648 | * entire RT timeslice! |
| 649 | */ |
| 650 | do_schedule = need_resched(); |
| 651 | } |
| 652 | |
| 653 | if (unlikely(do_schedule)) { |
Chris Wilson | d6a2289 | 2017-02-23 07:44:17 +0000 | [diff] [blame] | 654 | DEFINE_WAIT(exec); |
| 655 | |
Chris Wilson | b1becb8 | 2017-04-03 11:51:24 +0100 | [diff] [blame] | 656 | if (kthread_should_park()) |
| 657 | kthread_parkme(); |
| 658 | |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 659 | if (kthread_should_stop()) { |
| 660 | GEM_BUG_ON(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 661 | break; |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 662 | } |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 663 | |
Chris Wilson | d6a2289 | 2017-02-23 07:44:17 +0000 | [diff] [blame] | 664 | if (request) |
| 665 | add_wait_queue(&request->execute, &exec); |
| 666 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 667 | schedule(); |
Chris Wilson | fe3288b | 2017-02-12 17:20:01 +0000 | [diff] [blame] | 668 | |
Chris Wilson | d6a2289 | 2017-02-23 07:44:17 +0000 | [diff] [blame] | 669 | if (request) |
| 670 | remove_wait_queue(&request->execute, &exec); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 671 | } |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 672 | i915_gem_request_put(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 673 | } while (1); |
| 674 | __set_current_state(TASK_RUNNING); |
| 675 | |
| 676 | return 0; |
| 677 | } |
| 678 | |
Chris Wilson | f7b02a5 | 2017-04-26 09:06:59 +0100 | [diff] [blame] | 679 | void intel_engine_enable_signaling(struct drm_i915_gem_request *request, |
| 680 | bool wakeup) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 681 | { |
| 682 | struct intel_engine_cs *engine = request->engine; |
| 683 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | 754c9fd | 2017-02-23 07:44:14 +0000 | [diff] [blame] | 684 | u32 seqno; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 685 | |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 686 | /* Note that we may be called from an interrupt handler on another |
| 687 | * device (e.g. nouveau signaling a fence completion causing us |
| 688 | * to submit a request, and so enable signaling). As such, |
Chris Wilson | a6b0a141 | 2017-03-15 22:22:59 +0000 | [diff] [blame] | 689 | * we need to make sure that all other users of b->rb_lock protect |
Chris Wilson | f6168e3 | 2016-10-28 13:58:55 +0100 | [diff] [blame] | 690 | * against interrupts, i.e. use spin_lock_irqsave. |
| 691 | */ |
| 692 | |
| 693 | /* locked by dma_fence_enable_sw_signaling() (irqsafe fence->lock) */ |
Chris Wilson | e60a870 | 2017-03-02 11:51:30 +0000 | [diff] [blame] | 694 | GEM_BUG_ON(!irqs_disabled()); |
Chris Wilson | 6752041 | 2017-03-02 13:28:01 +0000 | [diff] [blame] | 695 | lockdep_assert_held(&request->lock); |
Chris Wilson | 754c9fd | 2017-02-23 07:44:14 +0000 | [diff] [blame] | 696 | |
| 697 | seqno = i915_gem_request_global_seqno(request); |
| 698 | if (!seqno) |
Chris Wilson | 65e4760 | 2016-10-28 13:58:49 +0100 | [diff] [blame] | 699 | return; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 700 | |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 701 | request->signaling.wait.tsk = b->signaler; |
Chris Wilson | 56299fb | 2017-02-27 20:58:48 +0000 | [diff] [blame] | 702 | request->signaling.wait.request = request; |
Chris Wilson | 754c9fd | 2017-02-23 07:44:14 +0000 | [diff] [blame] | 703 | request->signaling.wait.seqno = seqno; |
Chris Wilson | e8a261e | 2016-07-20 13:31:49 +0100 | [diff] [blame] | 704 | i915_gem_request_get(request); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 705 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 706 | spin_lock(&b->rb_lock); |
Chris Wilson | 4a50d20 | 2016-07-26 12:01:50 +0100 | [diff] [blame] | 707 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 708 | /* First add ourselves into the list of waiters, but register our |
| 709 | * bottom-half as the signaller thread. As per usual, only the oldest |
| 710 | * waiter (not just signaller) is tasked as the bottom-half waking |
| 711 | * up all completed waiters after the user interrupt. |
| 712 | * |
| 713 | * If we are the oldest waiter, enable the irq (after which we |
| 714 | * must double check that the seqno did not complete). |
| 715 | */ |
Chris Wilson | f7b02a5 | 2017-04-26 09:06:59 +0100 | [diff] [blame] | 716 | wakeup &= __intel_engine_add_wait(engine, &request->signaling.wait); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 717 | |
Chris Wilson | 735e0eb | 2017-06-08 12:14:04 +0100 | [diff] [blame] | 718 | if (!__i915_gem_request_completed(request, seqno)) { |
| 719 | struct rb_node *parent, **p; |
| 720 | bool first; |
| 721 | |
| 722 | /* Now insert ourselves into the retirement ordered list of |
| 723 | * signals on this engine. We track the oldest seqno as that |
| 724 | * will be the first signal to complete. |
| 725 | */ |
| 726 | parent = NULL; |
| 727 | first = true; |
| 728 | p = &b->signals.rb_node; |
| 729 | while (*p) { |
| 730 | parent = *p; |
| 731 | if (i915_seqno_passed(seqno, |
| 732 | to_signaler(parent)->signaling.wait.seqno)) { |
| 733 | p = &parent->rb_right; |
| 734 | first = false; |
| 735 | } else { |
| 736 | p = &parent->rb_left; |
| 737 | } |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 738 | } |
Chris Wilson | 735e0eb | 2017-06-08 12:14:04 +0100 | [diff] [blame] | 739 | rb_link_node(&request->signaling.node, parent, p); |
| 740 | rb_insert_color(&request->signaling.node, &b->signals); |
| 741 | if (first) |
| 742 | rcu_assign_pointer(b->first_signal, request); |
| 743 | } else { |
| 744 | __intel_engine_remove_wait(engine, &request->signaling.wait); |
| 745 | i915_gem_request_put(request); |
| 746 | wakeup = false; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 747 | } |
Chris Wilson | b385085 | 2016-07-01 17:23:26 +0100 | [diff] [blame] | 748 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 749 | spin_unlock(&b->rb_lock); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 750 | |
| 751 | if (wakeup) |
| 752 | wake_up_process(b->signaler); |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 753 | } |
| 754 | |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 755 | void intel_engine_cancel_signaling(struct drm_i915_gem_request *request) |
| 756 | { |
| 757 | struct intel_engine_cs *engine = request->engine; |
| 758 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 759 | |
Chris Wilson | e60a870 | 2017-03-02 11:51:30 +0000 | [diff] [blame] | 760 | GEM_BUG_ON(!irqs_disabled()); |
Chris Wilson | 6752041 | 2017-03-02 13:28:01 +0000 | [diff] [blame] | 761 | lockdep_assert_held(&request->lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 762 | GEM_BUG_ON(!request->signaling.wait.seqno); |
| 763 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 764 | spin_lock(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 765 | |
| 766 | if (!RB_EMPTY_NODE(&request->signaling.node)) { |
| 767 | if (request == rcu_access_pointer(b->first_signal)) { |
| 768 | struct rb_node *rb = |
| 769 | rb_next(&request->signaling.node); |
| 770 | rcu_assign_pointer(b->first_signal, |
| 771 | rb ? to_signaler(rb) : NULL); |
| 772 | } |
| 773 | rb_erase(&request->signaling.node, &b->signals); |
| 774 | RB_CLEAR_NODE(&request->signaling.node); |
| 775 | i915_gem_request_put(request); |
| 776 | } |
| 777 | |
| 778 | __intel_engine_remove_wait(engine, &request->signaling.wait); |
| 779 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 780 | spin_unlock(&b->rb_lock); |
Chris Wilson | 9eb143b | 2017-02-23 07:44:16 +0000 | [diff] [blame] | 781 | |
| 782 | request->signaling.wait.seqno = 0; |
| 783 | } |
| 784 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 785 | int intel_engine_init_breadcrumbs(struct intel_engine_cs *engine) |
| 786 | { |
| 787 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 788 | struct task_struct *tsk; |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 789 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 790 | spin_lock_init(&b->rb_lock); |
| 791 | spin_lock_init(&b->irq_lock); |
| 792 | |
Kees Cook | 39cbf2a | 2017-10-17 09:53:04 +0300 | [diff] [blame] | 793 | timer_setup(&b->fake_irq, intel_breadcrumbs_fake_irq, 0); |
| 794 | timer_setup(&b->hangcheck, intel_breadcrumbs_hangcheck, 0); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 795 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 796 | /* Spawn a thread to provide a common bottom-half for all signals. |
| 797 | * As this is an asynchronous interface we cannot steal the current |
| 798 | * task for handling the bottom-half to the user interrupt, therefore |
| 799 | * we create a thread to do the coherent seqno dance after the |
| 800 | * interrupt and then signal the waitqueue (via the dma-buf/fence). |
| 801 | */ |
| 802 | tsk = kthread_run(intel_breadcrumbs_signaler, engine, |
| 803 | "i915/signal:%d", engine->id); |
| 804 | if (IS_ERR(tsk)) |
| 805 | return PTR_ERR(tsk); |
| 806 | |
| 807 | b->signaler = tsk; |
| 808 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 809 | return 0; |
| 810 | } |
| 811 | |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 812 | static void cancel_fake_irq(struct intel_engine_cs *engine) |
| 813 | { |
| 814 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 815 | |
| 816 | del_timer_sync(&b->hangcheck); |
| 817 | del_timer_sync(&b->fake_irq); |
| 818 | clear_bit(engine->id, &engine->i915->gpu_error.missed_irq_rings); |
| 819 | } |
| 820 | |
| 821 | void intel_engine_reset_breadcrumbs(struct intel_engine_cs *engine) |
| 822 | { |
| 823 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 824 | |
| 825 | cancel_fake_irq(engine); |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 826 | spin_lock_irq(&b->irq_lock); |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 827 | |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 828 | if (b->irq_enabled) |
| 829 | irq_enable(engine); |
| 830 | else |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 831 | irq_disable(engine); |
Chris Wilson | 67b807a8 | 2017-02-27 20:58:50 +0000 | [diff] [blame] | 832 | |
| 833 | /* We set the IRQ_BREADCRUMB bit when we enable the irq presuming the |
| 834 | * GPU is active and may have already executed the MI_USER_INTERRUPT |
| 835 | * before the CPU is ready to receive. However, the engine is currently |
| 836 | * idle (we haven't started it yet), there is no possibility for a |
| 837 | * missed interrupt as we enabled the irq and so we can clear the |
| 838 | * immediate wakeup (until a real interrupt arrives for the waiter). |
| 839 | */ |
| 840 | clear_bit(ENGINE_IRQ_BREADCRUMB, &engine->irq_posted); |
| 841 | |
| 842 | if (b->irq_armed) |
| 843 | enable_fake_irq(b); |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 844 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 845 | spin_unlock_irq(&b->irq_lock); |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 846 | } |
| 847 | |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 848 | void intel_engine_fini_breadcrumbs(struct intel_engine_cs *engine) |
| 849 | { |
| 850 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 851 | |
Chris Wilson | 381744f | 2016-11-21 11:07:59 +0000 | [diff] [blame] | 852 | /* The engines should be idle and all requests accounted for! */ |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 853 | WARN_ON(READ_ONCE(b->irq_wait)); |
Chris Wilson | 381744f | 2016-11-21 11:07:59 +0000 | [diff] [blame] | 854 | WARN_ON(!RB_EMPTY_ROOT(&b->waiters)); |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 855 | WARN_ON(rcu_access_pointer(b->first_signal)); |
Chris Wilson | 381744f | 2016-11-21 11:07:59 +0000 | [diff] [blame] | 856 | WARN_ON(!RB_EMPTY_ROOT(&b->signals)); |
| 857 | |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 858 | if (!IS_ERR_OR_NULL(b->signaler)) |
| 859 | kthread_stop(b->signaler); |
| 860 | |
Chris Wilson | ad07dfc | 2016-10-07 07:53:26 +0100 | [diff] [blame] | 861 | cancel_fake_irq(engine); |
Chris Wilson | 688e6c7 | 2016-07-01 17:23:15 +0100 | [diff] [blame] | 862 | } |
| 863 | |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 864 | bool intel_breadcrumbs_busy(struct intel_engine_cs *engine) |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 865 | { |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 866 | struct intel_breadcrumbs *b = &engine->breadcrumbs; |
| 867 | bool busy = false; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 868 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 869 | spin_lock_irq(&b->rb_lock); |
Chris Wilson | 6a5d1db | 2016-11-08 14:37:19 +0000 | [diff] [blame] | 870 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 871 | if (b->irq_wait) { |
| 872 | wake_up_process(b->irq_wait->tsk); |
Chris Wilson | 4bd6639 | 2017-03-15 21:07:22 +0000 | [diff] [blame] | 873 | busy = true; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 874 | } |
| 875 | |
Chris Wilson | cced5e2 | 2017-02-23 07:44:15 +0000 | [diff] [blame] | 876 | if (rcu_access_pointer(b->first_signal)) { |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 877 | wake_up_process(b->signaler); |
Chris Wilson | 4bd6639 | 2017-03-15 21:07:22 +0000 | [diff] [blame] | 878 | busy = true; |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 879 | } |
| 880 | |
Chris Wilson | 61d3dc7 | 2017-03-03 19:08:24 +0000 | [diff] [blame] | 881 | spin_unlock_irq(&b->rb_lock); |
Chris Wilson | 9b6586a | 2017-02-23 07:44:08 +0000 | [diff] [blame] | 882 | |
| 883 | return busy; |
Chris Wilson | c81d461 | 2016-07-01 17:23:25 +0100 | [diff] [blame] | 884 | } |
Chris Wilson | f97fbf9 | 2017-02-13 17:15:14 +0000 | [diff] [blame] | 885 | |
| 886 | #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) |
| 887 | #include "selftests/intel_breadcrumbs.c" |
| 888 | #endif |