blob: 82371fe2ccc65b6963e8eea7db614fd60957e879 [file] [log] [blame]
Linus Walleijdae5f0a2018-09-25 09:08:48 +02001// SPDX-License-Identifier: GPL-2.0
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +09002#include <linux/idr.h>
3#include <linux/mutex.h>
4#include <linux/device.h>
5#include <linux/sysfs.h>
6#include <linux/gpio/consumer.h>
7#include <linux/gpio/driver.h>
8#include <linux/interrupt.h>
9#include <linux/kdev_t.h>
Johan Hovoldc43960f2015-05-04 17:10:37 +020010#include <linux/slab.h>
Christophe Leroy1efba35a2017-12-18 11:08:35 +010011#include <linux/ctype.h>
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090012
13#include "gpiolib.h"
14
Johan Hovoldcef17172015-05-04 17:10:48 +020015#define GPIO_IRQF_TRIGGER_FALLING BIT(0)
16#define GPIO_IRQF_TRIGGER_RISING BIT(1)
17#define GPIO_IRQF_TRIGGER_BOTH (GPIO_IRQF_TRIGGER_FALLING | \
18 GPIO_IRQF_TRIGGER_RISING)
19
Johan Hovoldc43960f2015-05-04 17:10:37 +020020struct gpiod_data {
21 struct gpio_desc *desc;
Johan Hovold6ffcb792015-05-04 17:10:44 +020022
23 struct mutex mutex;
Johan Hovolda08f5c22015-05-04 17:10:39 +020024 struct kernfs_node *value_kn;
Johan Hovold2ec74a92015-05-04 17:10:41 +020025 int irq;
Johan Hovoldcef17172015-05-04 17:10:48 +020026 unsigned char irq_flags;
Johan Hovold427fdee2015-05-04 17:10:47 +020027
28 bool direction_can_change;
Johan Hovoldc43960f2015-05-04 17:10:37 +020029};
30
Johan Hovold6ffcb792015-05-04 17:10:44 +020031/*
32 * Lock to serialise gpiod export and unexport, and prevent re-export of
33 * gpiod whose chip is being unregistered.
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090034 */
35static DEFINE_MUTEX(sysfs_lock);
36
37/*
38 * /sys/class/gpio/gpioN... only for GPIOs that are exported
39 * /direction
40 * * MAY BE OMITTED if kernel won't allow direction changes
41 * * is read/write as "in" or "out"
42 * * may also be written as "high" or "low", initializing
43 * output value as specified ("out" implies "low")
44 * /value
45 * * always readable, subject to hardware behavior
46 * * may be writable, as zero/nonzero
47 * /edge
48 * * configures behavior of poll(2) on /value
49 * * available only if pin can generate IRQs on input
50 * * is read/write as "none", "falling", "rising", or "both"
51 * /active_low
52 * * configures polarity of /value
53 * * is read/write as zero/nonzero
54 * * also affects existing and subsequent "falling" and "rising"
55 * /edge configuration
56 */
57
Johan Hovold6beac9d12015-05-04 17:10:34 +020058static ssize_t direction_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090059 struct device_attribute *attr, char *buf)
60{
Johan Hovoldc43960f2015-05-04 17:10:37 +020061 struct gpiod_data *data = dev_get_drvdata(dev);
62 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090063 ssize_t status;
64
Johan Hovold6ffcb792015-05-04 17:10:44 +020065 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090066
Johan Hovoldf0b78662015-05-04 17:10:36 +020067 gpiod_get_direction(desc);
68 status = sprintf(buf, "%s\n",
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090069 test_bit(FLAG_IS_OUT, &desc->flags)
70 ? "out" : "in");
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090071
Johan Hovold6ffcb792015-05-04 17:10:44 +020072 mutex_unlock(&data->mutex);
73
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090074 return status;
75}
76
Johan Hovold6beac9d12015-05-04 17:10:34 +020077static ssize_t direction_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090078 struct device_attribute *attr, const char *buf, size_t size)
79{
Johan Hovoldc43960f2015-05-04 17:10:37 +020080 struct gpiod_data *data = dev_get_drvdata(dev);
81 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090082 ssize_t status;
83
Johan Hovold6ffcb792015-05-04 17:10:44 +020084 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090085
Johan Hovoldf0b78662015-05-04 17:10:36 +020086 if (sysfs_streq(buf, "high"))
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090087 status = gpiod_direction_output_raw(desc, 1);
88 else if (sysfs_streq(buf, "out") || sysfs_streq(buf, "low"))
89 status = gpiod_direction_output_raw(desc, 0);
90 else if (sysfs_streq(buf, "in"))
91 status = gpiod_direction_input(desc);
92 else
93 status = -EINVAL;
94
Johan Hovold6ffcb792015-05-04 17:10:44 +020095 mutex_unlock(&data->mutex);
96
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090097 return status ? : size;
98}
Johan Hovold6beac9d12015-05-04 17:10:34 +020099static DEVICE_ATTR_RW(direction);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900100
Johan Hovold6beac9d12015-05-04 17:10:34 +0200101static ssize_t value_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900102 struct device_attribute *attr, char *buf)
103{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200104 struct gpiod_data *data = dev_get_drvdata(dev);
105 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900106 ssize_t status;
107
Johan Hovold6ffcb792015-05-04 17:10:44 +0200108 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900109
Christophe Leroy9295c012017-12-18 11:08:31 +0100110 status = gpiod_get_value_cansleep(desc);
111 if (status < 0)
112 goto err;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900113
Christophe Leroy7a94b882017-12-18 11:08:33 +0100114 buf[0] = '0' + status;
115 buf[1] = '\n';
116 status = 2;
Christophe Leroy9295c012017-12-18 11:08:31 +0100117err:
Johan Hovold6ffcb792015-05-04 17:10:44 +0200118 mutex_unlock(&data->mutex);
119
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900120 return status;
121}
122
Johan Hovold6beac9d12015-05-04 17:10:34 +0200123static ssize_t value_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900124 struct device_attribute *attr, const char *buf, size_t size)
125{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200126 struct gpiod_data *data = dev_get_drvdata(dev);
127 struct gpio_desc *desc = data->desc;
Christophe Leroy1efba35a2017-12-18 11:08:35 +0100128 ssize_t status = 0;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900129
Johan Hovold6ffcb792015-05-04 17:10:44 +0200130 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900131
Johan Hovoldf0b78662015-05-04 17:10:36 +0200132 if (!test_bit(FLAG_IS_OUT, &desc->flags)) {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900133 status = -EPERM;
Johan Hovoldf0b78662015-05-04 17:10:36 +0200134 } else {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900135 long value;
136
Christophe Leroy1efba35a2017-12-18 11:08:35 +0100137 if (size <= 2 && isdigit(buf[0]) &&
138 (size == 1 || buf[1] == '\n'))
139 value = buf[0] - '0';
140 else
141 status = kstrtol(buf, 0, &value);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900142 if (status == 0) {
143 gpiod_set_value_cansleep(desc, value);
144 status = size;
145 }
146 }
147
Johan Hovold6ffcb792015-05-04 17:10:44 +0200148 mutex_unlock(&data->mutex);
149
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900150 return status;
151}
Christophe Leroy7fda9102017-12-18 11:08:29 +0100152static DEVICE_ATTR_PREALLOC(value, S_IWUSR | S_IRUGO, value_show, value_store);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900153
154static irqreturn_t gpio_sysfs_irq(int irq, void *priv)
155{
Johan Hovolda08f5c22015-05-04 17:10:39 +0200156 struct gpiod_data *data = priv;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900157
Johan Hovolda08f5c22015-05-04 17:10:39 +0200158 sysfs_notify_dirent(data->value_kn);
159
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900160 return IRQ_HANDLED;
161}
162
Johan Hovold6ffcb792015-05-04 17:10:44 +0200163/* Caller holds gpiod-data mutex. */
Johan Hovoldcef17172015-05-04 17:10:48 +0200164static int gpio_sysfs_request_irq(struct device *dev, unsigned char flags)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900165{
Johan Hovold0f628502015-05-04 17:10:38 +0200166 struct gpiod_data *data = dev_get_drvdata(dev);
167 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900168 unsigned long irq_flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200169 int ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900170
Johan Hovold2ec74a92015-05-04 17:10:41 +0200171 data->irq = gpiod_to_irq(desc);
172 if (data->irq < 0)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900173 return -EIO;
174
Johan Hovold2ec74a92015-05-04 17:10:41 +0200175 data->value_kn = sysfs_get_dirent(dev->kobj.sd, "value");
176 if (!data->value_kn)
177 return -ENODEV;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900178
179 irq_flags = IRQF_SHARED;
Johan Hovoldcef17172015-05-04 17:10:48 +0200180 if (flags & GPIO_IRQF_TRIGGER_FALLING)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900181 irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
182 IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
Johan Hovoldcef17172015-05-04 17:10:48 +0200183 if (flags & GPIO_IRQF_TRIGGER_RISING)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900184 irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
185 IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING;
186
Johan Hovold52176d02015-05-04 17:10:28 +0200187 /*
188 * FIXME: This should be done in the irq_request_resources callback
189 * when the irq is requested, but a few drivers currently fail
190 * to do so.
191 *
192 * Remove this redundant call (along with the corresponding
193 * unlock) when those drivers have been fixed.
194 */
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100195 ret = gpiochip_lock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900196 if (ret < 0)
Johan Hovold2ec74a92015-05-04 17:10:41 +0200197 goto err_put_kn;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900198
Johan Hovold2ec74a92015-05-04 17:10:41 +0200199 ret = request_any_context_irq(data->irq, gpio_sysfs_irq, irq_flags,
Johan Hovolda08f5c22015-05-04 17:10:39 +0200200 "gpiolib", data);
Johan Hovold52176d02015-05-04 17:10:28 +0200201 if (ret < 0)
202 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900203
Johan Hovoldcef17172015-05-04 17:10:48 +0200204 data->irq_flags = flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200205
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900206 return 0;
207
Johan Hovold52176d02015-05-04 17:10:28 +0200208err_unlock:
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100209 gpiochip_unlock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Johan Hovold2ec74a92015-05-04 17:10:41 +0200210err_put_kn:
211 sysfs_put(data->value_kn);
212
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900213 return ret;
214}
215
Johan Hovold6ffcb792015-05-04 17:10:44 +0200216/*
217 * Caller holds gpiod-data mutex (unless called after class-device
218 * deregistration).
219 */
Johan Hovold2ec74a92015-05-04 17:10:41 +0200220static void gpio_sysfs_free_irq(struct device *dev)
221{
222 struct gpiod_data *data = dev_get_drvdata(dev);
223 struct gpio_desc *desc = data->desc;
224
Johan Hovoldcef17172015-05-04 17:10:48 +0200225 data->irq_flags = 0;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200226 free_irq(data->irq, data);
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100227 gpiochip_unlock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Johan Hovold2ec74a92015-05-04 17:10:41 +0200228 sysfs_put(data->value_kn);
229}
230
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900231static const struct {
232 const char *name;
Johan Hovoldcef17172015-05-04 17:10:48 +0200233 unsigned char flags;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900234} trigger_types[] = {
235 { "none", 0 },
Johan Hovoldcef17172015-05-04 17:10:48 +0200236 { "falling", GPIO_IRQF_TRIGGER_FALLING },
237 { "rising", GPIO_IRQF_TRIGGER_RISING },
238 { "both", GPIO_IRQF_TRIGGER_BOTH },
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900239};
240
Johan Hovold6beac9d12015-05-04 17:10:34 +0200241static ssize_t edge_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900242 struct device_attribute *attr, char *buf)
243{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200244 struct gpiod_data *data = dev_get_drvdata(dev);
Johan Hovoldf0b78662015-05-04 17:10:36 +0200245 ssize_t status = 0;
246 int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900247
Johan Hovold6ffcb792015-05-04 17:10:44 +0200248 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900249
Johan Hovoldf0b78662015-05-04 17:10:36 +0200250 for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
Johan Hovoldcef17172015-05-04 17:10:48 +0200251 if (data->irq_flags == trigger_types[i].flags) {
Johan Hovoldf0b78662015-05-04 17:10:36 +0200252 status = sprintf(buf, "%s\n", trigger_types[i].name);
253 break;
254 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900255 }
256
Johan Hovold6ffcb792015-05-04 17:10:44 +0200257 mutex_unlock(&data->mutex);
258
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900259 return status;
260}
261
Johan Hovold6beac9d12015-05-04 17:10:34 +0200262static ssize_t edge_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900263 struct device_attribute *attr, const char *buf, size_t size)
264{
Johan Hovoldb91e1802015-05-04 17:10:40 +0200265 struct gpiod_data *data = dev_get_drvdata(dev);
Johan Hovoldcef17172015-05-04 17:10:48 +0200266 unsigned char flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200267 ssize_t status = size;
Johan Hovolde4339ce2015-05-04 17:10:42 +0200268 int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900269
Johan Hovolde4339ce2015-05-04 17:10:42 +0200270 for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900271 if (sysfs_streq(trigger_types[i].name, buf))
Johan Hovolde4339ce2015-05-04 17:10:42 +0200272 break;
273 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900274
Johan Hovolde4339ce2015-05-04 17:10:42 +0200275 if (i == ARRAY_SIZE(trigger_types))
276 return -EINVAL;
277
Johan Hovoldb91e1802015-05-04 17:10:40 +0200278 flags = trigger_types[i].flags;
279
Johan Hovold6ffcb792015-05-04 17:10:44 +0200280 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900281
Johan Hovoldcef17172015-05-04 17:10:48 +0200282 if (flags == data->irq_flags) {
Johan Hovoldb91e1802015-05-04 17:10:40 +0200283 status = size;
284 goto out_unlock;
285 }
286
Johan Hovoldcef17172015-05-04 17:10:48 +0200287 if (data->irq_flags)
Johan Hovold2ec74a92015-05-04 17:10:41 +0200288 gpio_sysfs_free_irq(dev);
289
290 if (flags) {
291 status = gpio_sysfs_request_irq(dev, flags);
292 if (!status)
293 status = size;
294 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900295
Johan Hovoldb91e1802015-05-04 17:10:40 +0200296out_unlock:
Johan Hovold6ffcb792015-05-04 17:10:44 +0200297 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900298
299 return status;
300}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200301static DEVICE_ATTR_RW(edge);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900302
Johan Hovold6ffcb792015-05-04 17:10:44 +0200303/* Caller holds gpiod-data mutex. */
Johan Hovold2f323b82015-05-04 17:10:46 +0200304static int gpio_sysfs_set_active_low(struct device *dev, int value)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900305{
Johan Hovold0f628502015-05-04 17:10:38 +0200306 struct gpiod_data *data = dev_get_drvdata(dev);
307 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900308 int status = 0;
Johan Hovoldcef17172015-05-04 17:10:48 +0200309 unsigned int flags = data->irq_flags;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900310
311 if (!!test_bit(FLAG_ACTIVE_LOW, &desc->flags) == !!value)
312 return 0;
313
314 if (value)
315 set_bit(FLAG_ACTIVE_LOW, &desc->flags);
316 else
317 clear_bit(FLAG_ACTIVE_LOW, &desc->flags);
318
319 /* reconfigure poll(2) support if enabled on one edge only */
Johan Hovoldcef17172015-05-04 17:10:48 +0200320 if (flags == GPIO_IRQF_TRIGGER_FALLING ||
321 flags == GPIO_IRQF_TRIGGER_RISING) {
Johan Hovold2ec74a92015-05-04 17:10:41 +0200322 gpio_sysfs_free_irq(dev);
Johan Hovoldcef17172015-05-04 17:10:48 +0200323 status = gpio_sysfs_request_irq(dev, flags);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900324 }
325
326 return status;
327}
328
Johan Hovold6beac9d12015-05-04 17:10:34 +0200329static ssize_t active_low_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900330 struct device_attribute *attr, char *buf)
331{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200332 struct gpiod_data *data = dev_get_drvdata(dev);
333 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900334 ssize_t status;
335
Johan Hovold6ffcb792015-05-04 17:10:44 +0200336 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900337
Johan Hovoldf0b78662015-05-04 17:10:36 +0200338 status = sprintf(buf, "%d\n",
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900339 !!test_bit(FLAG_ACTIVE_LOW, &desc->flags));
340
Johan Hovold6ffcb792015-05-04 17:10:44 +0200341 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900342
343 return status;
344}
345
Johan Hovold6beac9d12015-05-04 17:10:34 +0200346static ssize_t active_low_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900347 struct device_attribute *attr, const char *buf, size_t size)
348{
Johan Hovold6ffcb792015-05-04 17:10:44 +0200349 struct gpiod_data *data = dev_get_drvdata(dev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900350 ssize_t status;
Johan Hovoldf0b78662015-05-04 17:10:36 +0200351 long value;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900352
Johan Hovold6ffcb792015-05-04 17:10:44 +0200353 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900354
Johan Hovoldf0b78662015-05-04 17:10:36 +0200355 status = kstrtol(buf, 0, &value);
356 if (status == 0)
Johan Hovold2f323b82015-05-04 17:10:46 +0200357 status = gpio_sysfs_set_active_low(dev, value);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900358
Johan Hovold6ffcb792015-05-04 17:10:44 +0200359 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900360
361 return status ? : size;
362}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200363static DEVICE_ATTR_RW(active_low);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900364
Johan Hovoldebbeba12015-01-13 13:00:06 +0100365static umode_t gpio_is_visible(struct kobject *kobj, struct attribute *attr,
366 int n)
367{
Wang Qing97cd7382020-06-12 16:05:45 +0800368 struct device *dev = kobj_to_dev(kobj);
Johan Hovoldc43960f2015-05-04 17:10:37 +0200369 struct gpiod_data *data = dev_get_drvdata(dev);
370 struct gpio_desc *desc = data->desc;
Johan Hovoldebbeba12015-01-13 13:00:06 +0100371 umode_t mode = attr->mode;
Johan Hovold427fdee2015-05-04 17:10:47 +0200372 bool show_direction = data->direction_can_change;
Johan Hovoldebbeba12015-01-13 13:00:06 +0100373
374 if (attr == &dev_attr_direction.attr) {
375 if (!show_direction)
376 mode = 0;
377 } else if (attr == &dev_attr_edge.attr) {
378 if (gpiod_to_irq(desc) < 0)
379 mode = 0;
380 if (!show_direction && test_bit(FLAG_IS_OUT, &desc->flags))
381 mode = 0;
382 }
383
384 return mode;
385}
386
Johan Hovold0915e6f2015-01-13 13:00:05 +0100387static struct attribute *gpio_attrs[] = {
Johan Hovoldebbeba12015-01-13 13:00:06 +0100388 &dev_attr_direction.attr,
389 &dev_attr_edge.attr,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900390 &dev_attr_value.attr,
391 &dev_attr_active_low.attr,
392 NULL,
393};
Johan Hovoldebbeba12015-01-13 13:00:06 +0100394
395static const struct attribute_group gpio_group = {
396 .attrs = gpio_attrs,
397 .is_visible = gpio_is_visible,
398};
399
400static const struct attribute_group *gpio_groups[] = {
401 &gpio_group,
402 NULL
403};
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900404
405/*
406 * /sys/class/gpio/gpiochipN/
407 * /base ... matching gpio_chip.base (N)
408 * /label ... matching gpio_chip.label
409 * /ngpio ... matching gpio_chip.ngpio
410 */
411
Johan Hovold6beac9d12015-05-04 17:10:34 +0200412static ssize_t base_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900413 struct device_attribute *attr, char *buf)
414{
415 const struct gpio_chip *chip = dev_get_drvdata(dev);
416
417 return sprintf(buf, "%d\n", chip->base);
418}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200419static DEVICE_ATTR_RO(base);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900420
Johan Hovold6beac9d12015-05-04 17:10:34 +0200421static ssize_t label_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900422 struct device_attribute *attr, char *buf)
423{
424 const struct gpio_chip *chip = dev_get_drvdata(dev);
425
426 return sprintf(buf, "%s\n", chip->label ? : "");
427}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200428static DEVICE_ATTR_RO(label);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900429
Johan Hovold6beac9d12015-05-04 17:10:34 +0200430static ssize_t ngpio_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900431 struct device_attribute *attr, char *buf)
432{
433 const struct gpio_chip *chip = dev_get_drvdata(dev);
434
435 return sprintf(buf, "%u\n", chip->ngpio);
436}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200437static DEVICE_ATTR_RO(ngpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900438
Johan Hovold121b6a72015-01-13 13:00:04 +0100439static struct attribute *gpiochip_attrs[] = {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900440 &dev_attr_base.attr,
441 &dev_attr_label.attr,
442 &dev_attr_ngpio.attr,
443 NULL,
444};
Johan Hovold121b6a72015-01-13 13:00:04 +0100445ATTRIBUTE_GROUPS(gpiochip);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900446
447/*
448 * /sys/class/gpio/export ... write-only
449 * integer N ... number of GPIO to export (full access)
450 * /sys/class/gpio/unexport ... write-only
451 * integer N ... number of GPIO to unexport
452 */
453static ssize_t export_store(struct class *class,
454 struct class_attribute *attr,
455 const char *buf, size_t len)
456{
457 long gpio;
458 struct gpio_desc *desc;
459 int status;
460
461 status = kstrtol(buf, 0, &gpio);
462 if (status < 0)
463 goto done;
464
Linus Walleijf13a0b02018-09-13 14:05:26 +0200465 desc = gpio_to_desc(gpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900466 /* reject invalid GPIOs */
467 if (!desc) {
468 pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
469 return -EINVAL;
470 }
471
472 /* No extra locking here; FLAG_SYSFS just signifies that the
473 * request and export were done by on behalf of userspace, so
474 * they may be undone on its behalf too.
475 */
476
477 status = gpiod_request(desc, "sysfs");
478 if (status < 0) {
479 if (status == -EPROBE_DEFER)
480 status = -ENODEV;
481 goto done;
482 }
Andrew Jefferye10f72b2017-11-30 14:25:24 +1030483
484 status = gpiod_set_transitory(desc, false);
485 if (!status) {
486 status = gpiod_export(desc, true);
487 if (status < 0)
488 gpiod_free(desc);
489 else
490 set_bit(FLAG_SYSFS, &desc->flags);
491 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900492
493done:
494 if (status)
495 pr_debug("%s: status %d\n", __func__, status);
496 return status ? : len;
497}
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200498static CLASS_ATTR_WO(export);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900499
500static ssize_t unexport_store(struct class *class,
501 struct class_attribute *attr,
502 const char *buf, size_t len)
503{
504 long gpio;
505 struct gpio_desc *desc;
506 int status;
507
508 status = kstrtol(buf, 0, &gpio);
509 if (status < 0)
510 goto done;
511
Linus Walleijf13a0b02018-09-13 14:05:26 +0200512 desc = gpio_to_desc(gpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900513 /* reject bogus commands (gpio_unexport ignores them) */
514 if (!desc) {
515 pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
516 return -EINVAL;
517 }
518
519 status = -EINVAL;
520
521 /* No extra locking here; FLAG_SYSFS just signifies that the
522 * request and export were done by on behalf of userspace, so
523 * they may be undone on its behalf too.
524 */
525 if (test_and_clear_bit(FLAG_SYSFS, &desc->flags)) {
526 status = 0;
527 gpiod_free(desc);
528 }
529done:
530 if (status)
531 pr_debug("%s: status %d\n", __func__, status);
532 return status ? : len;
533}
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200534static CLASS_ATTR_WO(unexport);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900535
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200536static struct attribute *gpio_class_attrs[] = {
537 &class_attr_export.attr,
538 &class_attr_unexport.attr,
539 NULL,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900540};
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200541ATTRIBUTE_GROUPS(gpio_class);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900542
543static struct class gpio_class = {
544 .name = "gpio",
545 .owner = THIS_MODULE,
546
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200547 .class_groups = gpio_class_groups,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900548};
549
550
551/**
552 * gpiod_export - export a GPIO through sysfs
Thierry Reding2d9d0512017-07-24 16:57:26 +0200553 * @desc: GPIO to make available, already requested
554 * @direction_may_change: true if userspace may change GPIO direction
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900555 * Context: arch_initcall or later
556 *
557 * When drivers want to make a GPIO accessible to userspace after they
558 * have requested it -- perhaps while debugging, or as part of their
559 * public interface -- they may use this routine. If the GPIO can
560 * change direction (some can't) and the caller allows it, userspace
561 * will see "direction" sysfs attribute which may be used to change
562 * the gpio's direction. A "value" attribute will always be provided.
563 *
564 * Returns zero on success, else an error.
565 */
566int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
567{
Johan Hovold483d8212015-04-21 17:42:09 +0200568 struct gpio_chip *chip;
Linus Walleijff2b1352015-10-20 11:10:38 +0200569 struct gpio_device *gdev;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200570 struct gpiod_data *data;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900571 unsigned long flags;
572 int status;
573 const char *ioname = NULL;
574 struct device *dev;
575 int offset;
576
577 /* can't export until sysfs is available ... */
578 if (!gpio_class.p) {
579 pr_debug("%s: called too early!\n", __func__);
580 return -ENOENT;
581 }
582
583 if (!desc) {
584 pr_debug("%s: invalid gpio descriptor\n", __func__);
585 return -EINVAL;
586 }
587
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100588 gdev = desc->gdev;
589 chip = gdev->chip;
Johan Hovold483d8212015-04-21 17:42:09 +0200590
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900591 mutex_lock(&sysfs_lock);
592
Johan Hovold483d8212015-04-21 17:42:09 +0200593 /* check if chip is being removed */
Linus Walleijafbc4f32016-02-09 13:21:06 +0100594 if (!chip || !gdev->mockdev) {
Johan Hovold483d8212015-04-21 17:42:09 +0200595 status = -ENODEV;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200596 goto err_unlock;
Johan Hovold483d8212015-04-21 17:42:09 +0200597 }
598
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900599 spin_lock_irqsave(&gpio_lock, flags);
600 if (!test_bit(FLAG_REQUESTED, &desc->flags) ||
601 test_bit(FLAG_EXPORT, &desc->flags)) {
602 spin_unlock_irqrestore(&gpio_lock, flags);
603 gpiod_dbg(desc, "%s: unavailable (requested=%d, exported=%d)\n",
604 __func__,
605 test_bit(FLAG_REQUESTED, &desc->flags),
606 test_bit(FLAG_EXPORT, &desc->flags));
607 status = -EPERM;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200608 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900609 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900610 spin_unlock_irqrestore(&gpio_lock, flags);
611
Johan Hovoldc43960f2015-05-04 17:10:37 +0200612 data = kzalloc(sizeof(*data), GFP_KERNEL);
613 if (!data) {
614 status = -ENOMEM;
615 goto err_unlock;
616 }
617
618 data->desc = desc;
Johan Hovold6ffcb792015-05-04 17:10:44 +0200619 mutex_init(&data->mutex);
Johan Hovold427fdee2015-05-04 17:10:47 +0200620 if (chip->direction_input && chip->direction_output)
621 data->direction_can_change = direction_may_change;
622 else
623 data->direction_can_change = false;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200624
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900625 offset = gpio_chip_hwgpio(desc);
Johan Hovoldcecf58a2015-05-04 17:10:29 +0200626 if (chip->names && chip->names[offset])
627 ioname = chip->names[offset];
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900628
Linus Walleijff2b1352015-10-20 11:10:38 +0200629 dev = device_create_with_groups(&gpio_class, &gdev->dev,
Johan Hovoldc43960f2015-05-04 17:10:37 +0200630 MKDEV(0, 0), data, gpio_groups,
Johan Hovold0915e6f2015-01-13 13:00:05 +0100631 ioname ? ioname : "gpio%u",
632 desc_to_gpio(desc));
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900633 if (IS_ERR(dev)) {
634 status = PTR_ERR(dev);
Johan Hovoldc43960f2015-05-04 17:10:37 +0200635 goto err_free_data;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900636 }
637
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900638 set_bit(FLAG_EXPORT, &desc->flags);
639 mutex_unlock(&sysfs_lock);
640 return 0;
641
Johan Hovoldc43960f2015-05-04 17:10:37 +0200642err_free_data:
643 kfree(data);
644err_unlock:
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900645 mutex_unlock(&sysfs_lock);
646 gpiod_dbg(desc, "%s: status %d\n", __func__, status);
647 return status;
648}
649EXPORT_SYMBOL_GPL(gpiod_export);
650
Johan Hovoldc43960f2015-05-04 17:10:37 +0200651static int match_export(struct device *dev, const void *desc)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900652{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200653 struct gpiod_data *data = dev_get_drvdata(dev);
654
655 return data->desc == desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900656}
657
658/**
659 * gpiod_export_link - create a sysfs link to an exported GPIO node
660 * @dev: device under which to create symlink
661 * @name: name of the symlink
Thierry Reding2d9d0512017-07-24 16:57:26 +0200662 * @desc: GPIO to create symlink to, already exported
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900663 *
664 * Set up a symlink from /sys/.../dev/name to /sys/class/gpio/gpioN
665 * node. Caller is responsible for unlinking.
666 *
667 * Returns zero on success, else an error.
668 */
669int gpiod_export_link(struct device *dev, const char *name,
670 struct gpio_desc *desc)
671{
Johan Hovold56d30ec2015-05-04 17:10:43 +0200672 struct device *cdev;
673 int ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900674
675 if (!desc) {
676 pr_warn("%s: invalid GPIO\n", __func__);
677 return -EINVAL;
678 }
679
Johan Hovold56d30ec2015-05-04 17:10:43 +0200680 cdev = class_find_device(&gpio_class, NULL, desc, match_export);
681 if (!cdev)
682 return -ENODEV;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900683
Johan Hovold56d30ec2015-05-04 17:10:43 +0200684 ret = sysfs_create_link(&dev->kobj, &cdev->kobj, name);
685 put_device(cdev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900686
Johan Hovold56d30ec2015-05-04 17:10:43 +0200687 return ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900688}
689EXPORT_SYMBOL_GPL(gpiod_export_link);
690
691/**
Amitesh Singh31963eb2016-09-08 17:11:20 +0530692 * gpiod_unexport - reverse effect of gpiod_export()
Thierry Reding2d9d0512017-07-24 16:57:26 +0200693 * @desc: GPIO to make unavailable
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900694 *
Amitesh Singh31963eb2016-09-08 17:11:20 +0530695 * This is implicit on gpiod_free().
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900696 */
697void gpiod_unexport(struct gpio_desc *desc)
698{
Johan Hovold72eba6f2015-05-04 17:10:45 +0200699 struct gpiod_data *data;
700 struct device *dev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900701
702 if (!desc) {
703 pr_warn("%s: invalid GPIO\n", __func__);
704 return;
705 }
706
707 mutex_lock(&sysfs_lock);
708
Johan Hovold72eba6f2015-05-04 17:10:45 +0200709 if (!test_bit(FLAG_EXPORT, &desc->flags))
710 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900711
Johan Hovold72eba6f2015-05-04 17:10:45 +0200712 dev = class_find_device(&gpio_class, NULL, desc, match_export);
713 if (!dev)
714 goto err_unlock;
715
716 data = dev_get_drvdata(dev);
717
Johan Hovold72eba6f2015-05-04 17:10:45 +0200718 clear_bit(FLAG_EXPORT, &desc->flags);
719
720 device_unregister(dev);
721
722 /*
723 * Release irq after deregistration to prevent race with edge_store.
724 */
Johan Hovoldcef17172015-05-04 17:10:48 +0200725 if (data->irq_flags)
Johan Hovold72eba6f2015-05-04 17:10:45 +0200726 gpio_sysfs_free_irq(dev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900727
728 mutex_unlock(&sysfs_lock);
729
Johan Hovold72eba6f2015-05-04 17:10:45 +0200730 put_device(dev);
731 kfree(data);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900732
Johan Hovold72eba6f2015-05-04 17:10:45 +0200733 return;
734
735err_unlock:
736 mutex_unlock(&sysfs_lock);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900737}
738EXPORT_SYMBOL_GPL(gpiod_unexport);
739
Linus Walleijafbc4f32016-02-09 13:21:06 +0100740int gpiochip_sysfs_register(struct gpio_device *gdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900741{
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900742 struct device *dev;
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800743 struct device *parent;
Linus Walleijafbc4f32016-02-09 13:21:06 +0100744 struct gpio_chip *chip = gdev->chip;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900745
Johan Hovold426577b2015-05-04 17:10:32 +0200746 /*
747 * Many systems add gpio chips for SOC support very early,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900748 * before driver model support is available. In those cases we
Johan Hovold426577b2015-05-04 17:10:32 +0200749 * register later, in gpiolib_sysfs_init() ... here we just
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900750 * verify that _some_ field of gpio_class got initialized.
751 */
752 if (!gpio_class.p)
753 return 0;
754
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800755 /*
756 * For sysfs backward compatibility we need to preserve this
757 * preferred parenting to the gpio_chip parent field, if set.
758 */
759 if (chip->parent)
760 parent = chip->parent;
761 else
762 parent = &gdev->dev;
763
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900764 /* use chip->base for the ID; it's already known to be unique */
Geert Uytterhoevenddd88912019-11-27 09:42:47 +0100765 dev = device_create_with_groups(&gpio_class, parent, MKDEV(0, 0), chip,
766 gpiochip_groups, GPIOCHIP_NAME "%d",
767 chip->base);
Johan Hovold121b6a72015-01-13 13:00:04 +0100768 if (IS_ERR(dev))
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200769 return PTR_ERR(dev);
Johan Hovold3ff74be2015-05-04 17:10:30 +0200770
771 mutex_lock(&sysfs_lock);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100772 gdev->mockdev = dev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900773 mutex_unlock(&sysfs_lock);
774
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200775 return 0;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900776}
777
Linus Walleijafbc4f32016-02-09 13:21:06 +0100778void gpiochip_sysfs_unregister(struct gpio_device *gdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900779{
Johan Hovold483d8212015-04-21 17:42:09 +0200780 struct gpio_desc *desc;
Linus Walleijafbc4f32016-02-09 13:21:06 +0100781 struct gpio_chip *chip = gdev->chip;
Johan Hovold483d8212015-04-21 17:42:09 +0200782 unsigned int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900783
Linus Walleijafbc4f32016-02-09 13:21:06 +0100784 if (!gdev->mockdev)
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200785 return;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900786
Linus Walleijafbc4f32016-02-09 13:21:06 +0100787 device_unregister(gdev->mockdev);
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200788
789 /* prevent further gpiod exports */
790 mutex_lock(&sysfs_lock);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100791 gdev->mockdev = NULL;
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200792 mutex_unlock(&sysfs_lock);
Johan Hovold483d8212015-04-21 17:42:09 +0200793
794 /* unregister gpiod class devices owned by sysfs */
795 for (i = 0; i < chip->ngpio; i++) {
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100796 desc = &gdev->descs[i];
Johan Hovold483d8212015-04-21 17:42:09 +0200797 if (test_and_clear_bit(FLAG_SYSFS, &desc->flags))
798 gpiod_free(desc);
799 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900800}
801
802static int __init gpiolib_sysfs_init(void)
803{
804 int status;
805 unsigned long flags;
Linus Walleijff2b1352015-10-20 11:10:38 +0200806 struct gpio_device *gdev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900807
808 status = class_register(&gpio_class);
809 if (status < 0)
810 return status;
811
812 /* Scan and register the gpio_chips which registered very
813 * early (e.g. before the class_register above was called).
814 *
815 * We run before arch_initcall() so chip->dev nodes can have
816 * registered, and so arch_initcall() can always gpio_export().
817 */
818 spin_lock_irqsave(&gpio_lock, flags);
Linus Walleijff2b1352015-10-20 11:10:38 +0200819 list_for_each_entry(gdev, &gpio_devices, list) {
Linus Walleijafbc4f32016-02-09 13:21:06 +0100820 if (gdev->mockdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900821 continue;
822
Alexandre Courbot14141a92014-07-22 16:17:40 +0900823 /*
Johan Hovold426577b2015-05-04 17:10:32 +0200824 * TODO we yield gpio_lock here because
825 * gpiochip_sysfs_register() acquires a mutex. This is unsafe
826 * and needs to be fixed.
Alexandre Courbot14141a92014-07-22 16:17:40 +0900827 *
828 * Also it would be nice to use gpiochip_find() here so we
829 * can keep gpio_chips local to gpiolib.c, but the yield of
830 * gpio_lock prevents us from doing this.
831 */
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900832 spin_unlock_irqrestore(&gpio_lock, flags);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100833 status = gpiochip_sysfs_register(gdev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900834 spin_lock_irqsave(&gpio_lock, flags);
835 }
836 spin_unlock_irqrestore(&gpio_lock, flags);
837
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900838 return status;
839}
840postcore_initcall(gpiolib_sysfs_init);