blob: ef34b8f56bd1f32c02bb9b56e7a425c50f9a1b26 [file] [log] [blame]
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +09001#include <linux/idr.h>
2#include <linux/mutex.h>
3#include <linux/device.h>
4#include <linux/sysfs.h>
Masami Hiramatsu90b05b02017-08-02 13:47:42 +09005#include <linux/gpio.h>
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +09006#include <linux/gpio/consumer.h>
7#include <linux/gpio/driver.h>
8#include <linux/interrupt.h>
9#include <linux/kdev_t.h>
Johan Hovoldc43960f2015-05-04 17:10:37 +020010#include <linux/slab.h>
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090011
12#include "gpiolib.h"
13
Johan Hovoldcef17172015-05-04 17:10:48 +020014#define GPIO_IRQF_TRIGGER_FALLING BIT(0)
15#define GPIO_IRQF_TRIGGER_RISING BIT(1)
16#define GPIO_IRQF_TRIGGER_BOTH (GPIO_IRQF_TRIGGER_FALLING | \
17 GPIO_IRQF_TRIGGER_RISING)
18
Johan Hovoldc43960f2015-05-04 17:10:37 +020019struct gpiod_data {
20 struct gpio_desc *desc;
Johan Hovold6ffcb792015-05-04 17:10:44 +020021
22 struct mutex mutex;
Johan Hovolda08f5c22015-05-04 17:10:39 +020023 struct kernfs_node *value_kn;
Johan Hovold2ec74a92015-05-04 17:10:41 +020024 int irq;
Johan Hovoldcef17172015-05-04 17:10:48 +020025 unsigned char irq_flags;
Johan Hovold427fdee2015-05-04 17:10:47 +020026
27 bool direction_can_change;
Johan Hovoldc43960f2015-05-04 17:10:37 +020028};
29
Johan Hovold6ffcb792015-05-04 17:10:44 +020030/*
31 * Lock to serialise gpiod export and unexport, and prevent re-export of
32 * gpiod whose chip is being unregistered.
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090033 */
34static DEFINE_MUTEX(sysfs_lock);
35
36/*
37 * /sys/class/gpio/gpioN... only for GPIOs that are exported
38 * /direction
39 * * MAY BE OMITTED if kernel won't allow direction changes
40 * * is read/write as "in" or "out"
41 * * may also be written as "high" or "low", initializing
42 * output value as specified ("out" implies "low")
43 * /value
44 * * always readable, subject to hardware behavior
45 * * may be writable, as zero/nonzero
46 * /edge
47 * * configures behavior of poll(2) on /value
48 * * available only if pin can generate IRQs on input
49 * * is read/write as "none", "falling", "rising", or "both"
50 * /active_low
51 * * configures polarity of /value
52 * * is read/write as zero/nonzero
53 * * also affects existing and subsequent "falling" and "rising"
54 * /edge configuration
55 */
56
Johan Hovold6beac9d12015-05-04 17:10:34 +020057static ssize_t direction_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090058 struct device_attribute *attr, char *buf)
59{
Johan Hovoldc43960f2015-05-04 17:10:37 +020060 struct gpiod_data *data = dev_get_drvdata(dev);
61 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090062 ssize_t status;
63
Johan Hovold6ffcb792015-05-04 17:10:44 +020064 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090065
Johan Hovoldf0b78662015-05-04 17:10:36 +020066 gpiod_get_direction(desc);
67 status = sprintf(buf, "%s\n",
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090068 test_bit(FLAG_IS_OUT, &desc->flags)
69 ? "out" : "in");
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090070
Johan Hovold6ffcb792015-05-04 17:10:44 +020071 mutex_unlock(&data->mutex);
72
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090073 return status;
74}
75
Johan Hovold6beac9d12015-05-04 17:10:34 +020076static ssize_t direction_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090077 struct device_attribute *attr, const char *buf, size_t size)
78{
Johan Hovoldc43960f2015-05-04 17:10:37 +020079 struct gpiod_data *data = dev_get_drvdata(dev);
80 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090081 ssize_t status;
82
Johan Hovold6ffcb792015-05-04 17:10:44 +020083 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090084
Johan Hovoldf0b78662015-05-04 17:10:36 +020085 if (sysfs_streq(buf, "high"))
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090086 status = gpiod_direction_output_raw(desc, 1);
87 else if (sysfs_streq(buf, "out") || sysfs_streq(buf, "low"))
88 status = gpiod_direction_output_raw(desc, 0);
89 else if (sysfs_streq(buf, "in"))
90 status = gpiod_direction_input(desc);
91 else
92 status = -EINVAL;
93
Johan Hovold6ffcb792015-05-04 17:10:44 +020094 mutex_unlock(&data->mutex);
95
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090096 return status ? : size;
97}
Johan Hovold6beac9d12015-05-04 17:10:34 +020098static DEVICE_ATTR_RW(direction);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090099
Johan Hovold6beac9d12015-05-04 17:10:34 +0200100static ssize_t value_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900101 struct device_attribute *attr, char *buf)
102{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200103 struct gpiod_data *data = dev_get_drvdata(dev);
104 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900105 ssize_t status;
106
Johan Hovold6ffcb792015-05-04 17:10:44 +0200107 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900108
Christophe Leroy9295c012017-12-18 11:08:31 +0100109 status = gpiod_get_value_cansleep(desc);
110 if (status < 0)
111 goto err;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900112
Christophe Leroy9295c012017-12-18 11:08:31 +0100113 status = sprintf(buf, "%d\n", status);
114err:
Johan Hovold6ffcb792015-05-04 17:10:44 +0200115 mutex_unlock(&data->mutex);
116
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900117 return status;
118}
119
Johan Hovold6beac9d12015-05-04 17:10:34 +0200120static ssize_t value_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900121 struct device_attribute *attr, const char *buf, size_t size)
122{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200123 struct gpiod_data *data = dev_get_drvdata(dev);
124 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900125 ssize_t status;
126
Johan Hovold6ffcb792015-05-04 17:10:44 +0200127 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900128
Johan Hovoldf0b78662015-05-04 17:10:36 +0200129 if (!test_bit(FLAG_IS_OUT, &desc->flags)) {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900130 status = -EPERM;
Johan Hovoldf0b78662015-05-04 17:10:36 +0200131 } else {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900132 long value;
133
134 status = kstrtol(buf, 0, &value);
135 if (status == 0) {
136 gpiod_set_value_cansleep(desc, value);
137 status = size;
138 }
139 }
140
Johan Hovold6ffcb792015-05-04 17:10:44 +0200141 mutex_unlock(&data->mutex);
142
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900143 return status;
144}
Christophe Leroy7fda9102017-12-18 11:08:29 +0100145static DEVICE_ATTR_PREALLOC(value, S_IWUSR | S_IRUGO, value_show, value_store);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900146
147static irqreturn_t gpio_sysfs_irq(int irq, void *priv)
148{
Johan Hovolda08f5c22015-05-04 17:10:39 +0200149 struct gpiod_data *data = priv;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900150
Johan Hovolda08f5c22015-05-04 17:10:39 +0200151 sysfs_notify_dirent(data->value_kn);
152
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900153 return IRQ_HANDLED;
154}
155
Johan Hovold6ffcb792015-05-04 17:10:44 +0200156/* Caller holds gpiod-data mutex. */
Johan Hovoldcef17172015-05-04 17:10:48 +0200157static int gpio_sysfs_request_irq(struct device *dev, unsigned char flags)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900158{
Johan Hovold0f628502015-05-04 17:10:38 +0200159 struct gpiod_data *data = dev_get_drvdata(dev);
160 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900161 unsigned long irq_flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200162 int ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900163
Johan Hovold2ec74a92015-05-04 17:10:41 +0200164 data->irq = gpiod_to_irq(desc);
165 if (data->irq < 0)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900166 return -EIO;
167
Johan Hovold2ec74a92015-05-04 17:10:41 +0200168 data->value_kn = sysfs_get_dirent(dev->kobj.sd, "value");
169 if (!data->value_kn)
170 return -ENODEV;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900171
172 irq_flags = IRQF_SHARED;
Johan Hovoldcef17172015-05-04 17:10:48 +0200173 if (flags & GPIO_IRQF_TRIGGER_FALLING)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900174 irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
175 IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
Johan Hovoldcef17172015-05-04 17:10:48 +0200176 if (flags & GPIO_IRQF_TRIGGER_RISING)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900177 irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
178 IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING;
179
Johan Hovold52176d02015-05-04 17:10:28 +0200180 /*
181 * FIXME: This should be done in the irq_request_resources callback
182 * when the irq is requested, but a few drivers currently fail
183 * to do so.
184 *
185 * Remove this redundant call (along with the corresponding
186 * unlock) when those drivers have been fixed.
187 */
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100188 ret = gpiochip_lock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900189 if (ret < 0)
Johan Hovold2ec74a92015-05-04 17:10:41 +0200190 goto err_put_kn;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900191
Johan Hovold2ec74a92015-05-04 17:10:41 +0200192 ret = request_any_context_irq(data->irq, gpio_sysfs_irq, irq_flags,
Johan Hovolda08f5c22015-05-04 17:10:39 +0200193 "gpiolib", data);
Johan Hovold52176d02015-05-04 17:10:28 +0200194 if (ret < 0)
195 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900196
Johan Hovoldcef17172015-05-04 17:10:48 +0200197 data->irq_flags = flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200198
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900199 return 0;
200
Johan Hovold52176d02015-05-04 17:10:28 +0200201err_unlock:
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100202 gpiochip_unlock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Johan Hovold2ec74a92015-05-04 17:10:41 +0200203err_put_kn:
204 sysfs_put(data->value_kn);
205
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900206 return ret;
207}
208
Johan Hovold6ffcb792015-05-04 17:10:44 +0200209/*
210 * Caller holds gpiod-data mutex (unless called after class-device
211 * deregistration).
212 */
Johan Hovold2ec74a92015-05-04 17:10:41 +0200213static void gpio_sysfs_free_irq(struct device *dev)
214{
215 struct gpiod_data *data = dev_get_drvdata(dev);
216 struct gpio_desc *desc = data->desc;
217
Johan Hovoldcef17172015-05-04 17:10:48 +0200218 data->irq_flags = 0;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200219 free_irq(data->irq, data);
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100220 gpiochip_unlock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Johan Hovold2ec74a92015-05-04 17:10:41 +0200221 sysfs_put(data->value_kn);
222}
223
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900224static const struct {
225 const char *name;
Johan Hovoldcef17172015-05-04 17:10:48 +0200226 unsigned char flags;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900227} trigger_types[] = {
228 { "none", 0 },
Johan Hovoldcef17172015-05-04 17:10:48 +0200229 { "falling", GPIO_IRQF_TRIGGER_FALLING },
230 { "rising", GPIO_IRQF_TRIGGER_RISING },
231 { "both", GPIO_IRQF_TRIGGER_BOTH },
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900232};
233
Johan Hovold6beac9d12015-05-04 17:10:34 +0200234static ssize_t edge_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900235 struct device_attribute *attr, char *buf)
236{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200237 struct gpiod_data *data = dev_get_drvdata(dev);
Johan Hovoldf0b78662015-05-04 17:10:36 +0200238 ssize_t status = 0;
239 int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900240
Johan Hovold6ffcb792015-05-04 17:10:44 +0200241 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900242
Johan Hovoldf0b78662015-05-04 17:10:36 +0200243 for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
Johan Hovoldcef17172015-05-04 17:10:48 +0200244 if (data->irq_flags == trigger_types[i].flags) {
Johan Hovoldf0b78662015-05-04 17:10:36 +0200245 status = sprintf(buf, "%s\n", trigger_types[i].name);
246 break;
247 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900248 }
249
Johan Hovold6ffcb792015-05-04 17:10:44 +0200250 mutex_unlock(&data->mutex);
251
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900252 return status;
253}
254
Johan Hovold6beac9d12015-05-04 17:10:34 +0200255static ssize_t edge_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900256 struct device_attribute *attr, const char *buf, size_t size)
257{
Johan Hovoldb91e1802015-05-04 17:10:40 +0200258 struct gpiod_data *data = dev_get_drvdata(dev);
Johan Hovoldcef17172015-05-04 17:10:48 +0200259 unsigned char flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200260 ssize_t status = size;
Johan Hovolde4339ce2015-05-04 17:10:42 +0200261 int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900262
Johan Hovolde4339ce2015-05-04 17:10:42 +0200263 for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900264 if (sysfs_streq(trigger_types[i].name, buf))
Johan Hovolde4339ce2015-05-04 17:10:42 +0200265 break;
266 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900267
Johan Hovolde4339ce2015-05-04 17:10:42 +0200268 if (i == ARRAY_SIZE(trigger_types))
269 return -EINVAL;
270
Johan Hovoldb91e1802015-05-04 17:10:40 +0200271 flags = trigger_types[i].flags;
272
Johan Hovold6ffcb792015-05-04 17:10:44 +0200273 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900274
Johan Hovoldcef17172015-05-04 17:10:48 +0200275 if (flags == data->irq_flags) {
Johan Hovoldb91e1802015-05-04 17:10:40 +0200276 status = size;
277 goto out_unlock;
278 }
279
Johan Hovoldcef17172015-05-04 17:10:48 +0200280 if (data->irq_flags)
Johan Hovold2ec74a92015-05-04 17:10:41 +0200281 gpio_sysfs_free_irq(dev);
282
283 if (flags) {
284 status = gpio_sysfs_request_irq(dev, flags);
285 if (!status)
286 status = size;
287 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900288
Johan Hovoldb91e1802015-05-04 17:10:40 +0200289out_unlock:
Johan Hovold6ffcb792015-05-04 17:10:44 +0200290 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900291
292 return status;
293}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200294static DEVICE_ATTR_RW(edge);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900295
Johan Hovold6ffcb792015-05-04 17:10:44 +0200296/* Caller holds gpiod-data mutex. */
Johan Hovold2f323b82015-05-04 17:10:46 +0200297static int gpio_sysfs_set_active_low(struct device *dev, int value)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900298{
Johan Hovold0f628502015-05-04 17:10:38 +0200299 struct gpiod_data *data = dev_get_drvdata(dev);
300 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900301 int status = 0;
Johan Hovoldcef17172015-05-04 17:10:48 +0200302 unsigned int flags = data->irq_flags;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900303
304 if (!!test_bit(FLAG_ACTIVE_LOW, &desc->flags) == !!value)
305 return 0;
306
307 if (value)
308 set_bit(FLAG_ACTIVE_LOW, &desc->flags);
309 else
310 clear_bit(FLAG_ACTIVE_LOW, &desc->flags);
311
312 /* reconfigure poll(2) support if enabled on one edge only */
Johan Hovoldcef17172015-05-04 17:10:48 +0200313 if (flags == GPIO_IRQF_TRIGGER_FALLING ||
314 flags == GPIO_IRQF_TRIGGER_RISING) {
Johan Hovold2ec74a92015-05-04 17:10:41 +0200315 gpio_sysfs_free_irq(dev);
Johan Hovoldcef17172015-05-04 17:10:48 +0200316 status = gpio_sysfs_request_irq(dev, flags);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900317 }
318
319 return status;
320}
321
Johan Hovold6beac9d12015-05-04 17:10:34 +0200322static ssize_t active_low_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900323 struct device_attribute *attr, char *buf)
324{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200325 struct gpiod_data *data = dev_get_drvdata(dev);
326 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900327 ssize_t status;
328
Johan Hovold6ffcb792015-05-04 17:10:44 +0200329 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900330
Johan Hovoldf0b78662015-05-04 17:10:36 +0200331 status = sprintf(buf, "%d\n",
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900332 !!test_bit(FLAG_ACTIVE_LOW, &desc->flags));
333
Johan Hovold6ffcb792015-05-04 17:10:44 +0200334 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900335
336 return status;
337}
338
Johan Hovold6beac9d12015-05-04 17:10:34 +0200339static ssize_t active_low_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900340 struct device_attribute *attr, const char *buf, size_t size)
341{
Johan Hovold6ffcb792015-05-04 17:10:44 +0200342 struct gpiod_data *data = dev_get_drvdata(dev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900343 ssize_t status;
Johan Hovoldf0b78662015-05-04 17:10:36 +0200344 long value;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900345
Johan Hovold6ffcb792015-05-04 17:10:44 +0200346 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900347
Johan Hovoldf0b78662015-05-04 17:10:36 +0200348 status = kstrtol(buf, 0, &value);
349 if (status == 0)
Johan Hovold2f323b82015-05-04 17:10:46 +0200350 status = gpio_sysfs_set_active_low(dev, value);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900351
Johan Hovold6ffcb792015-05-04 17:10:44 +0200352 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900353
354 return status ? : size;
355}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200356static DEVICE_ATTR_RW(active_low);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900357
Johan Hovoldebbeba12015-01-13 13:00:06 +0100358static umode_t gpio_is_visible(struct kobject *kobj, struct attribute *attr,
359 int n)
360{
361 struct device *dev = container_of(kobj, struct device, kobj);
Johan Hovoldc43960f2015-05-04 17:10:37 +0200362 struct gpiod_data *data = dev_get_drvdata(dev);
363 struct gpio_desc *desc = data->desc;
Johan Hovoldebbeba12015-01-13 13:00:06 +0100364 umode_t mode = attr->mode;
Johan Hovold427fdee2015-05-04 17:10:47 +0200365 bool show_direction = data->direction_can_change;
Johan Hovoldebbeba12015-01-13 13:00:06 +0100366
367 if (attr == &dev_attr_direction.attr) {
368 if (!show_direction)
369 mode = 0;
370 } else if (attr == &dev_attr_edge.attr) {
371 if (gpiod_to_irq(desc) < 0)
372 mode = 0;
373 if (!show_direction && test_bit(FLAG_IS_OUT, &desc->flags))
374 mode = 0;
375 }
376
377 return mode;
378}
379
Johan Hovold0915e6f2015-01-13 13:00:05 +0100380static struct attribute *gpio_attrs[] = {
Johan Hovoldebbeba12015-01-13 13:00:06 +0100381 &dev_attr_direction.attr,
382 &dev_attr_edge.attr,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900383 &dev_attr_value.attr,
384 &dev_attr_active_low.attr,
385 NULL,
386};
Johan Hovoldebbeba12015-01-13 13:00:06 +0100387
388static const struct attribute_group gpio_group = {
389 .attrs = gpio_attrs,
390 .is_visible = gpio_is_visible,
391};
392
393static const struct attribute_group *gpio_groups[] = {
394 &gpio_group,
395 NULL
396};
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900397
398/*
399 * /sys/class/gpio/gpiochipN/
400 * /base ... matching gpio_chip.base (N)
401 * /label ... matching gpio_chip.label
402 * /ngpio ... matching gpio_chip.ngpio
403 */
404
Johan Hovold6beac9d12015-05-04 17:10:34 +0200405static ssize_t base_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900406 struct device_attribute *attr, char *buf)
407{
408 const struct gpio_chip *chip = dev_get_drvdata(dev);
409
410 return sprintf(buf, "%d\n", chip->base);
411}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200412static DEVICE_ATTR_RO(base);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900413
Johan Hovold6beac9d12015-05-04 17:10:34 +0200414static ssize_t label_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900415 struct device_attribute *attr, char *buf)
416{
417 const struct gpio_chip *chip = dev_get_drvdata(dev);
418
419 return sprintf(buf, "%s\n", chip->label ? : "");
420}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200421static DEVICE_ATTR_RO(label);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900422
Johan Hovold6beac9d12015-05-04 17:10:34 +0200423static ssize_t ngpio_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900424 struct device_attribute *attr, char *buf)
425{
426 const struct gpio_chip *chip = dev_get_drvdata(dev);
427
428 return sprintf(buf, "%u\n", chip->ngpio);
429}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200430static DEVICE_ATTR_RO(ngpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900431
Johan Hovold121b6a72015-01-13 13:00:04 +0100432static struct attribute *gpiochip_attrs[] = {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900433 &dev_attr_base.attr,
434 &dev_attr_label.attr,
435 &dev_attr_ngpio.attr,
436 NULL,
437};
Johan Hovold121b6a72015-01-13 13:00:04 +0100438ATTRIBUTE_GROUPS(gpiochip);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900439
Masami Hiramatsu90b05b02017-08-02 13:47:42 +0900440static struct gpio_desc *gpio_to_valid_desc(int gpio)
441{
442 return gpio_is_valid(gpio) ? gpio_to_desc(gpio) : NULL;
443}
444
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900445/*
446 * /sys/class/gpio/export ... write-only
447 * integer N ... number of GPIO to export (full access)
448 * /sys/class/gpio/unexport ... write-only
449 * integer N ... number of GPIO to unexport
450 */
451static ssize_t export_store(struct class *class,
452 struct class_attribute *attr,
453 const char *buf, size_t len)
454{
455 long gpio;
456 struct gpio_desc *desc;
457 int status;
458
459 status = kstrtol(buf, 0, &gpio);
460 if (status < 0)
461 goto done;
462
Masami Hiramatsu90b05b02017-08-02 13:47:42 +0900463 desc = gpio_to_valid_desc(gpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900464 /* reject invalid GPIOs */
465 if (!desc) {
466 pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
467 return -EINVAL;
468 }
469
470 /* No extra locking here; FLAG_SYSFS just signifies that the
471 * request and export were done by on behalf of userspace, so
472 * they may be undone on its behalf too.
473 */
474
475 status = gpiod_request(desc, "sysfs");
476 if (status < 0) {
477 if (status == -EPROBE_DEFER)
478 status = -ENODEV;
479 goto done;
480 }
Andrew Jefferye10f72b2017-11-30 14:25:24 +1030481
482 status = gpiod_set_transitory(desc, false);
483 if (!status) {
484 status = gpiod_export(desc, true);
485 if (status < 0)
486 gpiod_free(desc);
487 else
488 set_bit(FLAG_SYSFS, &desc->flags);
489 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900490
491done:
492 if (status)
493 pr_debug("%s: status %d\n", __func__, status);
494 return status ? : len;
495}
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200496static CLASS_ATTR_WO(export);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900497
498static ssize_t unexport_store(struct class *class,
499 struct class_attribute *attr,
500 const char *buf, size_t len)
501{
502 long gpio;
503 struct gpio_desc *desc;
504 int status;
505
506 status = kstrtol(buf, 0, &gpio);
507 if (status < 0)
508 goto done;
509
Masami Hiramatsu90b05b02017-08-02 13:47:42 +0900510 desc = gpio_to_valid_desc(gpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900511 /* reject bogus commands (gpio_unexport ignores them) */
512 if (!desc) {
513 pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
514 return -EINVAL;
515 }
516
517 status = -EINVAL;
518
519 /* No extra locking here; FLAG_SYSFS just signifies that the
520 * request and export were done by on behalf of userspace, so
521 * they may be undone on its behalf too.
522 */
523 if (test_and_clear_bit(FLAG_SYSFS, &desc->flags)) {
524 status = 0;
525 gpiod_free(desc);
526 }
527done:
528 if (status)
529 pr_debug("%s: status %d\n", __func__, status);
530 return status ? : len;
531}
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200532static CLASS_ATTR_WO(unexport);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900533
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200534static struct attribute *gpio_class_attrs[] = {
535 &class_attr_export.attr,
536 &class_attr_unexport.attr,
537 NULL,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900538};
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200539ATTRIBUTE_GROUPS(gpio_class);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900540
541static struct class gpio_class = {
542 .name = "gpio",
543 .owner = THIS_MODULE,
544
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200545 .class_groups = gpio_class_groups,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900546};
547
548
549/**
550 * gpiod_export - export a GPIO through sysfs
Thierry Reding2d9d0512017-07-24 16:57:26 +0200551 * @desc: GPIO to make available, already requested
552 * @direction_may_change: true if userspace may change GPIO direction
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900553 * Context: arch_initcall or later
554 *
555 * When drivers want to make a GPIO accessible to userspace after they
556 * have requested it -- perhaps while debugging, or as part of their
557 * public interface -- they may use this routine. If the GPIO can
558 * change direction (some can't) and the caller allows it, userspace
559 * will see "direction" sysfs attribute which may be used to change
560 * the gpio's direction. A "value" attribute will always be provided.
561 *
562 * Returns zero on success, else an error.
563 */
564int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
565{
Johan Hovold483d8212015-04-21 17:42:09 +0200566 struct gpio_chip *chip;
Linus Walleijff2b1352015-10-20 11:10:38 +0200567 struct gpio_device *gdev;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200568 struct gpiod_data *data;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900569 unsigned long flags;
570 int status;
571 const char *ioname = NULL;
572 struct device *dev;
573 int offset;
574
575 /* can't export until sysfs is available ... */
576 if (!gpio_class.p) {
577 pr_debug("%s: called too early!\n", __func__);
578 return -ENOENT;
579 }
580
581 if (!desc) {
582 pr_debug("%s: invalid gpio descriptor\n", __func__);
583 return -EINVAL;
584 }
585
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100586 gdev = desc->gdev;
587 chip = gdev->chip;
Johan Hovold483d8212015-04-21 17:42:09 +0200588
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900589 mutex_lock(&sysfs_lock);
590
Johan Hovold483d8212015-04-21 17:42:09 +0200591 /* check if chip is being removed */
Linus Walleijafbc4f32016-02-09 13:21:06 +0100592 if (!chip || !gdev->mockdev) {
Johan Hovold483d8212015-04-21 17:42:09 +0200593 status = -ENODEV;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200594 goto err_unlock;
Johan Hovold483d8212015-04-21 17:42:09 +0200595 }
596
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900597 spin_lock_irqsave(&gpio_lock, flags);
598 if (!test_bit(FLAG_REQUESTED, &desc->flags) ||
599 test_bit(FLAG_EXPORT, &desc->flags)) {
600 spin_unlock_irqrestore(&gpio_lock, flags);
601 gpiod_dbg(desc, "%s: unavailable (requested=%d, exported=%d)\n",
602 __func__,
603 test_bit(FLAG_REQUESTED, &desc->flags),
604 test_bit(FLAG_EXPORT, &desc->flags));
605 status = -EPERM;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200606 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900607 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900608 spin_unlock_irqrestore(&gpio_lock, flags);
609
Johan Hovoldc43960f2015-05-04 17:10:37 +0200610 data = kzalloc(sizeof(*data), GFP_KERNEL);
611 if (!data) {
612 status = -ENOMEM;
613 goto err_unlock;
614 }
615
616 data->desc = desc;
Johan Hovold6ffcb792015-05-04 17:10:44 +0200617 mutex_init(&data->mutex);
Johan Hovold427fdee2015-05-04 17:10:47 +0200618 if (chip->direction_input && chip->direction_output)
619 data->direction_can_change = direction_may_change;
620 else
621 data->direction_can_change = false;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200622
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900623 offset = gpio_chip_hwgpio(desc);
Johan Hovoldcecf58a2015-05-04 17:10:29 +0200624 if (chip->names && chip->names[offset])
625 ioname = chip->names[offset];
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900626
Linus Walleijff2b1352015-10-20 11:10:38 +0200627 dev = device_create_with_groups(&gpio_class, &gdev->dev,
Johan Hovoldc43960f2015-05-04 17:10:37 +0200628 MKDEV(0, 0), data, gpio_groups,
Johan Hovold0915e6f2015-01-13 13:00:05 +0100629 ioname ? ioname : "gpio%u",
630 desc_to_gpio(desc));
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900631 if (IS_ERR(dev)) {
632 status = PTR_ERR(dev);
Johan Hovoldc43960f2015-05-04 17:10:37 +0200633 goto err_free_data;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900634 }
635
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900636 set_bit(FLAG_EXPORT, &desc->flags);
637 mutex_unlock(&sysfs_lock);
638 return 0;
639
Johan Hovoldc43960f2015-05-04 17:10:37 +0200640err_free_data:
641 kfree(data);
642err_unlock:
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900643 mutex_unlock(&sysfs_lock);
644 gpiod_dbg(desc, "%s: status %d\n", __func__, status);
645 return status;
646}
647EXPORT_SYMBOL_GPL(gpiod_export);
648
Johan Hovoldc43960f2015-05-04 17:10:37 +0200649static int match_export(struct device *dev, const void *desc)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900650{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200651 struct gpiod_data *data = dev_get_drvdata(dev);
652
653 return data->desc == desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900654}
655
656/**
657 * gpiod_export_link - create a sysfs link to an exported GPIO node
658 * @dev: device under which to create symlink
659 * @name: name of the symlink
Thierry Reding2d9d0512017-07-24 16:57:26 +0200660 * @desc: GPIO to create symlink to, already exported
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900661 *
662 * Set up a symlink from /sys/.../dev/name to /sys/class/gpio/gpioN
663 * node. Caller is responsible for unlinking.
664 *
665 * Returns zero on success, else an error.
666 */
667int gpiod_export_link(struct device *dev, const char *name,
668 struct gpio_desc *desc)
669{
Johan Hovold56d30ec2015-05-04 17:10:43 +0200670 struct device *cdev;
671 int ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900672
673 if (!desc) {
674 pr_warn("%s: invalid GPIO\n", __func__);
675 return -EINVAL;
676 }
677
Johan Hovold56d30ec2015-05-04 17:10:43 +0200678 cdev = class_find_device(&gpio_class, NULL, desc, match_export);
679 if (!cdev)
680 return -ENODEV;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900681
Johan Hovold56d30ec2015-05-04 17:10:43 +0200682 ret = sysfs_create_link(&dev->kobj, &cdev->kobj, name);
683 put_device(cdev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900684
Johan Hovold56d30ec2015-05-04 17:10:43 +0200685 return ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900686}
687EXPORT_SYMBOL_GPL(gpiod_export_link);
688
689/**
Amitesh Singh31963eb2016-09-08 17:11:20 +0530690 * gpiod_unexport - reverse effect of gpiod_export()
Thierry Reding2d9d0512017-07-24 16:57:26 +0200691 * @desc: GPIO to make unavailable
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900692 *
Amitesh Singh31963eb2016-09-08 17:11:20 +0530693 * This is implicit on gpiod_free().
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900694 */
695void gpiod_unexport(struct gpio_desc *desc)
696{
Johan Hovold72eba6f2015-05-04 17:10:45 +0200697 struct gpiod_data *data;
698 struct device *dev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900699
700 if (!desc) {
701 pr_warn("%s: invalid GPIO\n", __func__);
702 return;
703 }
704
705 mutex_lock(&sysfs_lock);
706
Johan Hovold72eba6f2015-05-04 17:10:45 +0200707 if (!test_bit(FLAG_EXPORT, &desc->flags))
708 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900709
Johan Hovold72eba6f2015-05-04 17:10:45 +0200710 dev = class_find_device(&gpio_class, NULL, desc, match_export);
711 if (!dev)
712 goto err_unlock;
713
714 data = dev_get_drvdata(dev);
715
Johan Hovold72eba6f2015-05-04 17:10:45 +0200716 clear_bit(FLAG_EXPORT, &desc->flags);
717
718 device_unregister(dev);
719
720 /*
721 * Release irq after deregistration to prevent race with edge_store.
722 */
Johan Hovoldcef17172015-05-04 17:10:48 +0200723 if (data->irq_flags)
Johan Hovold72eba6f2015-05-04 17:10:45 +0200724 gpio_sysfs_free_irq(dev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900725
726 mutex_unlock(&sysfs_lock);
727
Johan Hovold72eba6f2015-05-04 17:10:45 +0200728 put_device(dev);
729 kfree(data);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900730
Johan Hovold72eba6f2015-05-04 17:10:45 +0200731 return;
732
733err_unlock:
734 mutex_unlock(&sysfs_lock);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900735}
736EXPORT_SYMBOL_GPL(gpiod_unexport);
737
Linus Walleijafbc4f32016-02-09 13:21:06 +0100738int gpiochip_sysfs_register(struct gpio_device *gdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900739{
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900740 struct device *dev;
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800741 struct device *parent;
Linus Walleijafbc4f32016-02-09 13:21:06 +0100742 struct gpio_chip *chip = gdev->chip;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900743
Johan Hovold426577b2015-05-04 17:10:32 +0200744 /*
745 * Many systems add gpio chips for SOC support very early,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900746 * before driver model support is available. In those cases we
Johan Hovold426577b2015-05-04 17:10:32 +0200747 * register later, in gpiolib_sysfs_init() ... here we just
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900748 * verify that _some_ field of gpio_class got initialized.
749 */
750 if (!gpio_class.p)
751 return 0;
752
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800753 /*
754 * For sysfs backward compatibility we need to preserve this
755 * preferred parenting to the gpio_chip parent field, if set.
756 */
757 if (chip->parent)
758 parent = chip->parent;
759 else
760 parent = &gdev->dev;
761
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900762 /* use chip->base for the ID; it's already known to be unique */
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800763 dev = device_create_with_groups(&gpio_class, parent,
Linus Walleij58383c782015-11-04 09:56:26 +0100764 MKDEV(0, 0),
Johan Hovold121b6a72015-01-13 13:00:04 +0100765 chip, gpiochip_groups,
766 "gpiochip%d", chip->base);
767 if (IS_ERR(dev))
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200768 return PTR_ERR(dev);
Johan Hovold3ff74be2015-05-04 17:10:30 +0200769
770 mutex_lock(&sysfs_lock);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100771 gdev->mockdev = dev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900772 mutex_unlock(&sysfs_lock);
773
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200774 return 0;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900775}
776
Linus Walleijafbc4f32016-02-09 13:21:06 +0100777void gpiochip_sysfs_unregister(struct gpio_device *gdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900778{
Johan Hovold483d8212015-04-21 17:42:09 +0200779 struct gpio_desc *desc;
Linus Walleijafbc4f32016-02-09 13:21:06 +0100780 struct gpio_chip *chip = gdev->chip;
Johan Hovold483d8212015-04-21 17:42:09 +0200781 unsigned int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900782
Linus Walleijafbc4f32016-02-09 13:21:06 +0100783 if (!gdev->mockdev)
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200784 return;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900785
Linus Walleijafbc4f32016-02-09 13:21:06 +0100786 device_unregister(gdev->mockdev);
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200787
788 /* prevent further gpiod exports */
789 mutex_lock(&sysfs_lock);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100790 gdev->mockdev = NULL;
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200791 mutex_unlock(&sysfs_lock);
Johan Hovold483d8212015-04-21 17:42:09 +0200792
793 /* unregister gpiod class devices owned by sysfs */
794 for (i = 0; i < chip->ngpio; i++) {
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100795 desc = &gdev->descs[i];
Johan Hovold483d8212015-04-21 17:42:09 +0200796 if (test_and_clear_bit(FLAG_SYSFS, &desc->flags))
797 gpiod_free(desc);
798 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900799}
800
801static int __init gpiolib_sysfs_init(void)
802{
803 int status;
804 unsigned long flags;
Linus Walleijff2b1352015-10-20 11:10:38 +0200805 struct gpio_device *gdev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900806
807 status = class_register(&gpio_class);
808 if (status < 0)
809 return status;
810
811 /* Scan and register the gpio_chips which registered very
812 * early (e.g. before the class_register above was called).
813 *
814 * We run before arch_initcall() so chip->dev nodes can have
815 * registered, and so arch_initcall() can always gpio_export().
816 */
817 spin_lock_irqsave(&gpio_lock, flags);
Linus Walleijff2b1352015-10-20 11:10:38 +0200818 list_for_each_entry(gdev, &gpio_devices, list) {
Linus Walleijafbc4f32016-02-09 13:21:06 +0100819 if (gdev->mockdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900820 continue;
821
Alexandre Courbot14141a92014-07-22 16:17:40 +0900822 /*
Johan Hovold426577b2015-05-04 17:10:32 +0200823 * TODO we yield gpio_lock here because
824 * gpiochip_sysfs_register() acquires a mutex. This is unsafe
825 * and needs to be fixed.
Alexandre Courbot14141a92014-07-22 16:17:40 +0900826 *
827 * Also it would be nice to use gpiochip_find() here so we
828 * can keep gpio_chips local to gpiolib.c, but the yield of
829 * gpio_lock prevents us from doing this.
830 */
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900831 spin_unlock_irqrestore(&gpio_lock, flags);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100832 status = gpiochip_sysfs_register(gdev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900833 spin_lock_irqsave(&gpio_lock, flags);
834 }
835 spin_unlock_irqrestore(&gpio_lock, flags);
836
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900837 return status;
838}
839postcore_initcall(gpiolib_sysfs_init);