blob: 5335d7897a734b5b3d4cf6ede76b2f623a16c5aa [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Nan Zhang61eaedb2017-11-02 13:28:15 -070021 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070022 "strings"
23 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070024
Colin Crossa4f08812018-10-02 22:03:40 -070025 "android/soong/android"
26 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080027 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070028 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070029)
30
31var buildDir string
32
33func setUp() {
34 var err error
35 buildDir, err = ioutil.TempDir("", "soong_java_test")
36 if err != nil {
37 panic(err)
38 }
39}
40
41func tearDown() {
42 os.RemoveAll(buildDir)
43}
44
45func TestMain(m *testing.M) {
46 run := func() int {
47 setUp()
48 defer tearDown()
49
50 return m.Run()
51 }
52
53 os.Exit(run())
54}
Colin Cross527012a2017-11-30 22:56:16 -080055
56func testConfig(env map[string]string) android.Config {
Colin Crosse4759b92019-02-15 10:37:39 -080057 return TestConfig(buildDir, env)
Colin Cross1369cdb2017-09-29 17:58:17 -070058}
59
Colin Cross527012a2017-11-30 22:56:16 -080060func testContext(config android.Config, bp string,
61 fs map[string][]byte) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070062
Colin Cross4c428df2017-09-15 17:36:05 -070063 ctx := android.NewTestArchContext()
Colin Cross72bb3632017-07-13 16:23:21 -070064 ctx.RegisterModuleType("android_app", android.ModuleFactoryAdaptor(AndroidAppFactory))
Jaewoong Jung2ad817c2019-01-18 14:27:16 -080065 ctx.RegisterModuleType("android_app_certificate", android.ModuleFactoryAdaptor(AndroidAppCertificateFactory))
Jaewoong Jungccbb3932019-04-15 09:48:31 -070066 ctx.RegisterModuleType("android_app_import", android.ModuleFactoryAdaptor(AndroidAppImportFactory))
Colin Crossa97c5d32018-03-28 14:58:31 -070067 ctx.RegisterModuleType("android_library", android.ModuleFactoryAdaptor(AndroidLibraryFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070068 ctx.RegisterModuleType("android_test", android.ModuleFactoryAdaptor(AndroidTestFactory))
Colin Cross638149e2019-01-05 22:12:12 -080069 ctx.RegisterModuleType("android_test_helper_app", android.ModuleFactoryAdaptor(AndroidTestHelperAppFactory))
70 ctx.RegisterModuleType("java_binary", android.ModuleFactoryAdaptor(BinaryFactory))
Colin Cross6b4a32d2017-12-05 13:42:45 -080071 ctx.RegisterModuleType("java_binary_host", android.ModuleFactoryAdaptor(BinaryHostFactory))
Colin Cross3d7c9822019-03-01 13:46:24 -080072 ctx.RegisterModuleType("java_device_for_host", android.ModuleFactoryAdaptor(DeviceForHostFactory))
73 ctx.RegisterModuleType("java_host_for_device", android.ModuleFactoryAdaptor(HostForDeviceFactory))
Colin Cross9ae1b922018-06-26 17:59:05 -070074 ctx.RegisterModuleType("java_library", android.ModuleFactoryAdaptor(LibraryFactory))
Colin Cross2acdae82017-09-15 19:44:24 -070075 ctx.RegisterModuleType("java_library_host", android.ModuleFactoryAdaptor(LibraryHostFactory))
Colin Cross638149e2019-01-05 22:12:12 -080076 ctx.RegisterModuleType("java_test", android.ModuleFactoryAdaptor(TestFactory))
Colin Cross74d73e22017-08-02 11:05:49 -070077 ctx.RegisterModuleType("java_import", android.ModuleFactoryAdaptor(ImportFactory))
Colin Cross3d7c9822019-03-01 13:46:24 -080078 ctx.RegisterModuleType("java_import_host", android.ModuleFactoryAdaptor(ImportFactoryHost))
Colin Cross89536d42017-07-07 14:35:50 -070079 ctx.RegisterModuleType("java_defaults", android.ModuleFactoryAdaptor(defaultsFactory))
Colin Cross1369cdb2017-09-29 17:58:17 -070080 ctx.RegisterModuleType("java_system_modules", android.ModuleFactoryAdaptor(SystemModulesFactory))
Colin Cross54250902017-12-05 09:28:08 -080081 ctx.RegisterModuleType("java_genrule", android.ModuleFactoryAdaptor(genRuleFactory))
Colin Crossbe9cdb82019-01-21 21:37:16 -080082 ctx.RegisterModuleType("java_plugin", android.ModuleFactoryAdaptor(PluginFactory))
Colin Cross42be7612019-02-21 18:12:14 -080083 ctx.RegisterModuleType("dex_import", android.ModuleFactoryAdaptor(DexImportFactory))
Pirama Arumuga Nainar955dc492018-04-17 14:58:42 -070084 ctx.RegisterModuleType("filegroup", android.ModuleFactoryAdaptor(android.FileGroupFactory))
Colin Cross54190b32017-10-09 15:34:10 -070085 ctx.RegisterModuleType("genrule", android.ModuleFactoryAdaptor(genrule.GenRuleFactory))
Nan Zhang581fd212018-01-10 16:06:12 -080086 ctx.RegisterModuleType("droiddoc", android.ModuleFactoryAdaptor(DroiddocFactory))
87 ctx.RegisterModuleType("droiddoc_host", android.ModuleFactoryAdaptor(DroiddocHostFactory))
Nan Zhangf4936b02018-08-01 15:00:28 -070088 ctx.RegisterModuleType("droiddoc_template", android.ModuleFactoryAdaptor(ExportedDroiddocDirFactory))
Inseob Kimc0907f12019-02-08 21:00:45 +090089 ctx.RegisterModuleType("java_sdk_library", android.ModuleFactoryAdaptor(SdkLibraryFactory))
Colin Cross79c7c262019-04-17 11:11:46 -070090 ctx.RegisterModuleType("java_sdk_library_import", android.ModuleFactoryAdaptor(sdkLibraryImportFactory))
Jaewoong Jung525443a2019-02-28 15:35:54 -080091 ctx.RegisterModuleType("override_android_app", android.ModuleFactoryAdaptor(OverrideAndroidAppModuleFactory))
Inseob Kimc0907f12019-02-08 21:00:45 +090092 ctx.RegisterModuleType("prebuilt_apis", android.ModuleFactoryAdaptor(PrebuiltApisFactory))
Colin Cross5ea9bcc2017-07-27 15:41:32 -070093 ctx.PreArchMutators(android.RegisterPrebuiltsPreArchMutators)
94 ctx.PreArchMutators(android.RegisterPrebuiltsPostDepsMutators)
Colin Cross89536d42017-07-07 14:35:50 -070095 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Jaewoong Jung525443a2019-02-28 15:35:54 -080096 ctx.PreArchMutators(android.RegisterOverridePreArchMutators)
Jiyong Parkc678ad32018-04-10 13:07:10 +090097 ctx.PreArchMutators(func(ctx android.RegisterMutatorsContext) {
Inseob Kimc0907f12019-02-08 21:00:45 +090098 ctx.TopDown("prebuilt_apis", PrebuiltApisMutator).Parallel()
Jiyong Parkc678ad32018-04-10 13:07:10 +090099 })
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800100 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -0700101 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -0700102
103 // Register module types and mutators from cc needed for JNI testing
104 ctx.RegisterModuleType("cc_library", android.ModuleFactoryAdaptor(cc.LibraryFactory))
105 ctx.RegisterModuleType("cc_object", android.ModuleFactoryAdaptor(cc.ObjectFactory))
106 ctx.RegisterModuleType("toolchain_library", android.ModuleFactoryAdaptor(cc.ToolchainLibraryFactory))
Colin Cross47fa9d32019-03-26 10:51:39 -0700107 ctx.RegisterModuleType("llndk_library", android.ModuleFactoryAdaptor(cc.LlndkLibraryFactory))
Colin Crossa4f08812018-10-02 22:03:40 -0700108 ctx.PreDepsMutators(func(ctx android.RegisterMutatorsContext) {
109 ctx.BottomUp("link", cc.LinkageMutator).Parallel()
110 ctx.BottomUp("begin", cc.BeginMutator).Parallel()
111 })
112
Colin Crosse4759b92019-02-15 10:37:39 -0800113 bp += GatherRequiredDepsForTest()
Colin Cross1369cdb2017-09-29 17:58:17 -0700114
Colin Cross824bee32017-11-22 17:27:51 -0800115 mockFS := map[string][]byte{
Jiyong Park58c518b2018-05-12 22:29:12 +0900116 "Android.bp": []byte(bp),
117 "a.java": nil,
118 "b.java": nil,
119 "c.java": nil,
120 "b.kt": nil,
121 "a.jar": nil,
122 "b.jar": nil,
123 "java-res/a/a": nil,
124 "java-res/b/b": nil,
125 "java-res2/a": nil,
126 "java-fg/a.java": nil,
127 "java-fg/b.java": nil,
128 "java-fg/c.java": nil,
129 "api/current.txt": nil,
130 "api/removed.txt": nil,
131 "api/system-current.txt": nil,
132 "api/system-removed.txt": nil,
133 "api/test-current.txt": nil,
134 "api/test-removed.txt": nil,
Colin Cross3047fa22019-04-18 10:56:44 -0700135 "framework/aidl/a.aidl": nil,
Colin Cross0532fb02017-10-02 16:57:40 -0700136
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100137 "prebuilts/sdk/14/public/android.jar": nil,
138 "prebuilts/sdk/14/public/framework.aidl": nil,
139 "prebuilts/sdk/14/system/android.jar": nil,
Colin Cross98fd5742019-01-09 23:04:25 -0800140 "prebuilts/sdk/17/public/android.jar": nil,
141 "prebuilts/sdk/17/public/framework.aidl": nil,
142 "prebuilts/sdk/17/system/android.jar": nil,
Colin Crossff0daf42019-04-02 16:10:56 -0700143 "prebuilts/sdk/25/public/android.jar": nil,
144 "prebuilts/sdk/25/public/framework.aidl": nil,
145 "prebuilts/sdk/25/system/android.jar": nil,
Colin Cross86a60ae2018-05-29 14:44:55 -0700146 "prebuilts/sdk/current/core/android.jar": nil,
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100147 "prebuilts/sdk/current/public/android.jar": nil,
148 "prebuilts/sdk/current/public/framework.aidl": nil,
149 "prebuilts/sdk/current/public/core.jar": nil,
150 "prebuilts/sdk/current/system/android.jar": nil,
151 "prebuilts/sdk/current/test/android.jar": nil,
Jiyong Park58c518b2018-05-12 22:29:12 +0900152 "prebuilts/sdk/28/public/api/foo.txt": nil,
153 "prebuilts/sdk/28/system/api/foo.txt": nil,
154 "prebuilts/sdk/28/test/api/foo.txt": nil,
155 "prebuilts/sdk/28/public/api/foo-removed.txt": nil,
156 "prebuilts/sdk/28/system/api/foo-removed.txt": nil,
157 "prebuilts/sdk/28/test/api/foo-removed.txt": nil,
158 "prebuilts/sdk/28/public/api/bar.txt": nil,
159 "prebuilts/sdk/28/system/api/bar.txt": nil,
160 "prebuilts/sdk/28/test/api/bar.txt": nil,
161 "prebuilts/sdk/28/public/api/bar-removed.txt": nil,
162 "prebuilts/sdk/28/system/api/bar-removed.txt": nil,
163 "prebuilts/sdk/28/test/api/bar-removed.txt": nil,
Colin Cross86a60ae2018-05-29 14:44:55 -0700164 "prebuilts/sdk/tools/core-lambda-stubs.jar": nil,
Sundong Ahn27eecb92018-06-21 13:47:17 +0900165 "prebuilts/sdk/Android.bp": []byte(`prebuilt_apis { name: "sdk", api_dirs: ["14", "28", "current"],}`),
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800166
Jaewoong Jungccbb3932019-04-15 09:48:31 -0700167 "prebuilts/apk/app.apk": nil,
168
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800169 // For framework-res, which is an implicit dependency for framework
Dan Willemsen412160e2019-04-09 21:36:26 -0700170 "AndroidManifest.xml": nil,
171 "build/make/target/product/security/testkey": nil,
Colin Cross6b4a32d2017-12-05 13:42:45 -0800172
173 "build/soong/scripts/jar-wrapper.sh": nil,
Colin Cross7fdd2b72018-01-02 18:14:25 -0800174
Colin Cross66dbc0b2017-12-28 12:23:20 -0800175 "build/make/core/proguard.flags": nil,
176 "build/make/core/proguard_basic_keeps.flags": nil,
177
Colin Cross7fdd2b72018-01-02 18:14:25 -0800178 "jdk8/jre/lib/jce.jar": nil,
179 "jdk8/jre/lib/rt.jar": nil,
Nan Zhang61819ce2018-05-04 18:49:16 -0700180 "jdk8/lib/tools.jar": nil,
Nan Zhang581fd212018-01-10 16:06:12 -0800181
182 "bar-doc/a.java": nil,
183 "bar-doc/b.java": nil,
Jiyong Park1e440682018-05-23 18:42:04 +0900184 "bar-doc/IFoo.aidl": nil,
Nan Zhang581fd212018-01-10 16:06:12 -0800185 "bar-doc/known_oj_tags.txt": nil,
186 "external/doclava/templates-sdk": nil,
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800187
188 "cert/new_cert.x509.pem": nil,
189 "cert/new_cert.pk8": nil,
Colin Cross824bee32017-11-22 17:27:51 -0800190 }
191
192 for k, v := range fs {
193 mockFS[k] = v
194 }
195
196 ctx.MockFileSystem(mockFS)
Colin Cross72bb3632017-07-13 16:23:21 -0700197
Colin Cross527012a2017-11-30 22:56:16 -0800198 return ctx
199}
200
201func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800202 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800203
204 pathCtx := android.PathContextForTesting(config, nil)
205 setDexpreoptTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
206
207 ctx.Register()
Jiyong Park58c518b2018-05-12 22:29:12 +0900208 _, errs := ctx.ParseFileList(".", []string{"Android.bp", "prebuilts/sdk/Android.bp"})
Logan Chien42039712018-03-12 16:29:17 +0800209 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700210 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800211 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800212}
213
214func testJava(t *testing.T, bp string) *android.TestContext {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800215 t.Helper()
Colin Cross527012a2017-11-30 22:56:16 -0800216 config := testConfig(nil)
217 ctx := testContext(config, bp, nil)
218 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700219
220 return ctx
221}
222
Colin Cross2acdae82017-09-15 19:44:24 -0700223func moduleToPath(name string) string {
224 switch {
225 case name == `""`:
226 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700227 case strings.HasSuffix(name, ".jar"):
228 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700229 default:
230 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700231 }
232}
233
Colin Cross72bb3632017-07-13 16:23:21 -0700234func TestSimple(t *testing.T) {
235 ctx := testJava(t, `
236 java_library {
237 name: "foo",
238 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700239 libs: ["bar"],
240 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700241 }
242
243 java_library {
244 name: "bar",
245 srcs: ["b.java"],
246 }
247
248 java_library {
249 name: "baz",
250 srcs: ["c.java"],
251 }
Colin Crossd5934c82017-10-02 13:55:26 -0700252 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700253
Colin Cross4c428df2017-09-15 17:36:05 -0700254 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700255 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700256
257 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
258 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
259 }
260
Colin Cross1ee23172017-10-18 14:44:18 -0700261 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700262 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
263 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700264
Nan Zhanged19fc32017-10-19 13:06:22 -0700265 if !strings.Contains(javac.Args["classpath"], barTurbine) {
266 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700267 }
268
Nan Zhanged19fc32017-10-19 13:06:22 -0700269 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
270 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700271 }
272
273 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
274 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700275 }
276}
277
Colin Crossd5934c82017-10-02 13:55:26 -0700278func TestArchSpecific(t *testing.T) {
279 ctx := testJava(t, `
280 java_library {
281 name: "foo",
282 srcs: ["a.java"],
283 target: {
284 android: {
285 srcs: ["b.java"],
286 },
287 },
288 }
289 `)
290
291 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
292 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
293 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
294 }
295}
296
Colin Cross6b4a32d2017-12-05 13:42:45 -0800297func TestBinary(t *testing.T) {
298 ctx := testJava(t, `
299 java_library_host {
300 name: "foo",
301 srcs: ["a.java"],
302 }
303
304 java_binary_host {
305 name: "bar",
306 srcs: ["b.java"],
307 static_libs: ["foo"],
308 }
309 `)
310
311 buildOS := android.BuildOs.String()
312
313 bar := ctx.ModuleForTests("bar", buildOS+"_common")
314 barJar := bar.Output("bar.jar").Output.String()
315 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
316 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
317
318 // Test that the install binary wrapper depends on the installed jar file
319 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
320 t.Errorf("expected binary wrapper implicits [%q], got %v",
321 barJar, barWrapperDeps)
322 }
323
324}
325
Colin Cross72bb3632017-07-13 16:23:21 -0700326func TestPrebuilts(t *testing.T) {
327 ctx := testJava(t, `
328 java_library {
329 name: "foo",
330 srcs: ["a.java"],
Colin Cross79c7c262019-04-17 11:11:46 -0700331 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700332 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700333 }
334
Colin Cross74d73e22017-08-02 11:05:49 -0700335 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700336 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700337 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700338 }
339
Colin Cross74d73e22017-08-02 11:05:49 -0700340 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700341 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700342 jars: ["b.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700343 }
Colin Cross42be7612019-02-21 18:12:14 -0800344
345 dex_import {
346 name: "qux",
347 jars: ["b.jar"],
348 }
Colin Cross79c7c262019-04-17 11:11:46 -0700349
350 java_sdk_library_import {
351 name: "sdklib",
352 jars: ["b.jar"],
353 }
Colin Cross72bb3632017-07-13 16:23:21 -0700354 `)
355
Colin Cross4c428df2017-09-15 17:36:05 -0700356 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700357 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross37f6d792018-07-12 12:28:41 -0700358 barJar := ctx.ModuleForTests("bar", "android_common").Rule("combineJar").Output
359 bazJar := ctx.ModuleForTests("baz", "android_common").Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700360 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700361
Colin Cross37f6d792018-07-12 12:28:41 -0700362 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
363 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700364 }
365
Colin Cross79c7c262019-04-17 11:11:46 -0700366 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
367 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
368 }
369
Colin Cross37f6d792018-07-12 12:28:41 -0700370 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
371 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700372 }
Colin Cross42be7612019-02-21 18:12:14 -0800373
374 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700375}
376
Colin Cross89536d42017-07-07 14:35:50 -0700377func TestDefaults(t *testing.T) {
378 ctx := testJava(t, `
379 java_defaults {
380 name: "defaults",
381 srcs: ["a.java"],
382 libs: ["bar"],
383 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700384 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700385 }
386
387 java_library {
388 name: "foo",
389 defaults: ["defaults"],
390 }
391
392 java_library {
393 name: "bar",
394 srcs: ["b.java"],
395 }
396
397 java_library {
398 name: "baz",
399 srcs: ["c.java"],
400 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700401
402 android_test {
403 name: "atestOptimize",
404 defaults: ["defaults"],
405 optimize: {enabled: true},
406 }
407
408 android_test {
409 name: "atestNoOptimize",
410 defaults: ["defaults"],
411 }
412
413 android_test {
414 name: "atestDefault",
415 srcs: ["a.java"],
416 }
Colin Cross89536d42017-07-07 14:35:50 -0700417 `)
418
Colin Cross4c428df2017-09-15 17:36:05 -0700419 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700420 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700421
422 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
423 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
424 }
425
Nan Zhanged19fc32017-10-19 13:06:22 -0700426 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
427 if !strings.Contains(javac.Args["classpath"], barTurbine) {
428 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700429 }
430
Colin Cross1ee23172017-10-18 14:44:18 -0700431 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700432 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
433 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700434 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700435
436 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
437 if atestOptimize.Output == nil {
438 t.Errorf("atestOptimize should optimize APK")
439 }
440
441 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
442 if atestNoOptimize.Output == nil {
443 t.Errorf("atestNoOptimize should not optimize APK")
444 }
445
446 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
447 if atestDefault.Output == nil {
448 t.Errorf("atestDefault should optimize APK")
449 }
Colin Cross89536d42017-07-07 14:35:50 -0700450}
451
Colin Cross0f37af02017-09-27 17:42:05 -0700452func TestResources(t *testing.T) {
453 var table = []struct {
454 name string
455 prop string
456 extra string
457 args string
458 }{
459 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700460 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700461 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800462 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700463 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700464 },
465 {
466 // Test that a module with java_resources includes the files
467 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700468 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
469 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700470 },
471 {
472 // Test that a module with a filegroup in java_resources includes the files with the
473 // path prefix
474 name: "resource filegroup",
475 prop: `java_resources: [":foo-res"]`,
476 extra: `
477 filegroup {
478 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800479 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700480 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700481 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700482 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700483 },
484 {
485 // Test that a module with "include_srcs: true" includes its source files in the resources jar
486 name: "include sources",
487 prop: `include_srcs: true`,
Colin Crossaf9c55b2017-10-03 14:50:08 -0700488 args: "-C . -f a.java -f b.java -f c.java",
Colin Cross0f37af02017-09-27 17:42:05 -0700489 },
Colin Cross0ead1d72018-04-10 13:07:42 -0700490 {
491 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
492 name: "wildcard dirs",
493 prop: `java_resource_dirs: ["java-res/*"]`,
494 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
495 },
496 {
497 // Test that a module exclude_java_resource_dirs excludes the files
498 name: "wildcard dirs",
499 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
500 args: "-C java-res/a -f java-res/a/a",
501 },
Colin Crosscedd4762018-09-13 11:26:19 -0700502 {
503 // Test wildcards in java_resources
504 name: "wildcard files",
505 prop: `java_resources: ["java-res/**/*"]`,
506 args: "-C . -f java-res/a/a -f java-res/b/b",
507 },
508 {
509 // Test exclude_java_resources with java_resources
510 name: "wildcard files with exclude",
511 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
512 args: "-C . -f java-res/a/a",
513 },
514 {
515 // Test exclude_java_resources with java_resource_dirs
516 name: "resource dirs with exclude files",
517 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
518 args: "-C java-res -f java-res/a/a",
519 },
520 {
521 // Test exclude_java_resource_dirs with java_resource_dirs
522 name: "resource dirs with exclude files",
523 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
524 args: "-C java-res -f java-res/a/a -f java-res/b/b",
525 },
Colin Cross0f37af02017-09-27 17:42:05 -0700526 }
527
528 for _, test := range table {
529 t.Run(test.name, func(t *testing.T) {
530 ctx := testJava(t, `
531 java_library {
532 name: "foo",
533 srcs: [
534 "a.java",
535 "b.java",
536 "c.java",
537 ],
538 `+test.prop+`,
539 }
540 `+test.extra)
541
Colin Cross331a1212018-08-15 20:40:52 -0700542 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700543 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700544
545 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
546 t.Errorf("foo combined jars %v does not contain %q",
547 foo.Inputs.Strings(), fooRes.Output.String())
548 }
549
Colin Crossaf9c55b2017-10-03 14:50:08 -0700550 if fooRes.Args["jarArgs"] != test.args {
551 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700552 fooRes.Args["jarArgs"], test.args)
553 }
554 })
555 }
556}
557
Colin Cross54190b32017-10-09 15:34:10 -0700558func TestGeneratedSources(t *testing.T) {
559 ctx := testJava(t, `
560 java_library {
561 name: "foo",
562 srcs: [
563 "a*.java",
564 ":gen",
565 "b*.java",
566 ],
567 }
568
569 genrule {
570 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800571 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700572 out: ["gen.java"],
573 }
574 `)
575
576 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
577 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
578
Colin Cross15e86d92017-10-20 15:07:08 -0700579 if filepath.Base(genrule.Output.String()) != "gen.java" {
580 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700581 }
582
583 if len(javac.Inputs) != 3 ||
584 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700585 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700586 javac.Inputs[2].String() != "b.java" {
587 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
588 }
589}
590
Nan Zhang61eaedb2017-11-02 13:28:15 -0700591func TestTurbine(t *testing.T) {
592 ctx := testJava(t, `
593 java_library {
594 name: "foo",
595 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +0900596 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700597 }
598
599 java_library {
600 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -0800601 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -0700602 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +0900603 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700604 }
605
606 java_library {
607 name: "baz",
608 srcs: ["c.java"],
609 libs: ["bar"],
610 sdk_version: "14",
611 }
612 `)
613
614 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
615 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
616 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
617 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
618 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
619
620 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
621 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
622 }
623
624 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
625 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
626 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
627 }
628 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
629 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
630 }
631 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
632 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
633 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100634 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -0700635 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100636 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700637 }
638}
639
640func TestSharding(t *testing.T) {
641 ctx := testJava(t, `
642 java_library {
643 name: "bar",
644 srcs: ["a.java","b.java","c.java"],
645 javac_shard_size: 1
646 }
647 `)
648
649 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
650 for i := 0; i < 3; i++ {
651 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
652 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
653 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
654 }
655 }
656}
657
Nan Zhang581fd212018-01-10 16:06:12 -0800658func TestDroiddoc(t *testing.T) {
659 ctx := testJava(t, `
Dan Willemsencc090972018-02-26 14:33:31 -0800660 droiddoc_template {
661 name: "droiddoc-templates-sdk",
662 path: ".",
663 }
Nan Zhang581fd212018-01-10 16:06:12 -0800664 droiddoc {
665 name: "bar-doc",
666 srcs: [
667 "bar-doc/*.java",
Jiyong Park1e440682018-05-23 18:42:04 +0900668 "bar-doc/IFoo.aidl",
Nan Zhang581fd212018-01-10 16:06:12 -0800669 ],
670 exclude_srcs: [
671 "bar-doc/b.java"
672 ],
Dan Willemsencc090972018-02-26 14:33:31 -0800673 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -0800674 hdf: [
675 "android.whichdoc offline",
676 ],
677 knowntags: [
678 "bar-doc/known_oj_tags.txt",
679 ],
680 proofread_file: "libcore-proofread.txt",
681 todo_file: "libcore-docs-todo.html",
682 args: "-offlinemode -title \"libcore\"",
683 }
684 `)
685
Nan Zhang3bb14202018-02-28 10:14:25 -0800686 stubsJar := filepath.Join(buildDir, ".intermediates", "bar-doc", "android_common", "bar-doc-stubs.srcjar")
687 barDoc := ctx.ModuleForTests("bar-doc", "android_common").Output("bar-doc-stubs.srcjar")
Nan Zhang581fd212018-01-10 16:06:12 -0800688 if stubsJar != barDoc.Output.String() {
689 t.Errorf("expected stubs Jar [%q], got %q", stubsJar, barDoc.Output.String())
690 }
Jiyong Park1e440682018-05-23 18:42:04 +0900691 inputs := ctx.ModuleForTests("bar-doc", "android_common").Rule("javadoc").Inputs
692 var javaSrcs []string
693 for _, i := range inputs {
694 javaSrcs = append(javaSrcs, i.Base())
695 }
696 if len(javaSrcs) != 2 || javaSrcs[0] != "a.java" || javaSrcs[1] != "IFoo.java" {
697 t.Errorf("inputs of bar-doc must be []string{\"a.java\", \"IFoo.java\", but was %#v.", javaSrcs)
698 }
Nan Zhang581fd212018-01-10 16:06:12 -0800699}
700
Colin Cross54250902017-12-05 09:28:08 -0800701func TestJarGenrules(t *testing.T) {
702 ctx := testJava(t, `
703 java_library {
704 name: "foo",
705 srcs: ["a.java"],
706 }
707
708 java_genrule {
709 name: "jargen",
710 tool_files: ["b.java"],
711 cmd: "$(location b.java) $(in) $(out)",
712 out: ["jargen.jar"],
713 srcs: [":foo"],
714 }
715
716 java_library {
717 name: "bar",
718 static_libs: ["jargen"],
719 srcs: ["c.java"],
720 }
721
722 java_library {
723 name: "baz",
724 libs: ["jargen"],
725 srcs: ["c.java"],
726 }
727 `)
728
729 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
730 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
731 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
732 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
733 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
734
735 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
736 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
737 }
738
739 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
740 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
741 }
742
743 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
744 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
745 }
746
747 if len(barCombined.Inputs) != 2 ||
748 barCombined.Inputs[0].String() != bar.Output.String() ||
749 barCombined.Inputs[1].String() != jargen.Output.String() {
750 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
751 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
752 }
753}
754
Nan Zhang27e284d2018-02-09 21:03:53 +0000755func TestExcludeFileGroupInSrcs(t *testing.T) {
756 ctx := testJava(t, `
757 java_library {
758 name: "foo",
759 srcs: ["a.java", ":foo-srcs"],
760 exclude_srcs: ["a.java", ":foo-excludes"],
761 }
762
763 filegroup {
764 name: "foo-srcs",
765 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
766 }
767
768 filegroup {
769 name: "foo-excludes",
770 srcs: ["java-fg/a.java", "java-fg/b.java"],
771 }
772 `)
773
774 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
775
776 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
777 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
778 }
779}
Jiyong Parkc678ad32018-04-10 13:07:10 +0900780
781func TestJavaSdkLibrary(t *testing.T) {
782 ctx := testJava(t, `
783 droiddoc_template {
784 name: "droiddoc-templates-sdk",
785 path: ".",
786 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900787 java_sdk_library {
788 name: "foo",
789 srcs: ["a.java", "b.java"],
790 api_packages: ["foo"],
791 }
792 java_sdk_library {
793 name: "bar",
794 srcs: ["a.java", "b.java"],
795 api_packages: ["bar"],
796 }
797 java_library {
798 name: "baz",
799 srcs: ["c.java"],
800 libs: ["foo", "bar"],
801 sdk_version: "system_current",
802 }
Jiyong Park1be96912018-05-28 18:02:19 +0900803 java_library {
804 name: "qux",
805 srcs: ["c.java"],
806 libs: ["baz"],
807 sdk_version: "system_current",
808 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900809 `)
810
811 // check the existence of the internal modules
812 ctx.ModuleForTests("foo", "android_common")
813 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix, "android_common")
814 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +0900815 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkTestApiSuffix, "android_common")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900816 ctx.ModuleForTests("foo"+sdkDocsSuffix, "android_common")
817 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +0900818 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkTestApiSuffix, "android_common")
Jaewoong Jungb9a11512019-01-15 10:47:05 -0800819 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_arm64_armv8-a")
Jiyong Park58c518b2018-05-12 22:29:12 +0900820 ctx.ModuleForTests("foo.api.public.28", "")
821 ctx.ModuleForTests("foo.api.system.28", "")
822 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900823
824 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
825 // tests if baz is actually linked to the stubs lib
826 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
827 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
828 "foo.stubs.system.jar")
829 }
830 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +0900831 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +0900832 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +0900833 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900834 }
835 // test if baz is not linked to the system variant of foo
836 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
837 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
838 "foo.stubs.jar")
839 }
Jiyong Park1be96912018-05-28 18:02:19 +0900840
841 // test if baz has exported SDK lib names foo and bar to qux
842 qux := ctx.ModuleForTests("qux", "android_common")
843 if quxLib, ok := qux.Module().(*Library); ok {
844 sdkLibs := quxLib.ExportedSdkLibs()
845 if len(sdkLibs) != 2 || !android.InList("foo", sdkLibs) || !android.InList("bar", sdkLibs) {
846 t.Errorf("qux should export \"foo\" and \"bar\" but exports %v", sdkLibs)
847 }
848 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900849}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +0200850
851var compilerFlagsTestCases = []struct {
852 in string
853 out bool
854}{
855 {
856 in: "a",
857 out: false,
858 },
859 {
860 in: "-a",
861 out: true,
862 },
863 {
864 in: "-no-jdk",
865 out: false,
866 },
867 {
868 in: "-no-stdlib",
869 out: false,
870 },
871 {
872 in: "-kotlin-home",
873 out: false,
874 },
875 {
876 in: "-kotlin-home /some/path",
877 out: false,
878 },
879 {
880 in: "-include-runtime",
881 out: false,
882 },
883 {
884 in: "-Xintellij-plugin-root",
885 out: false,
886 },
887}
888
889type mockContext struct {
890 android.ModuleContext
891 result bool
892}
893
894func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
895 // CheckBadCompilerFlags calls this function when the flag should be rejected
896 ctx.result = false
897}
898
899func TestCompilerFlags(t *testing.T) {
900 for _, testCase := range compilerFlagsTestCases {
901 ctx := &mockContext{result: true}
902 CheckKotlincFlags(ctx, []string{testCase.in})
903 if ctx.result != testCase.out {
904 t.Errorf("incorrect output:")
905 t.Errorf(" input: %#v", testCase.in)
906 t.Errorf(" expected: %#v", testCase.out)
907 t.Errorf(" got: %#v", ctx.result)
908 }
909 }
910}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -0800911
912// TODO(jungjw): Consider making this more robust by ignoring path order.
913func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
914 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
915 flags := strings.Split(variables["javacFlags"], " ")
916 got := ""
917 for _, flag := range flags {
918 keyEnd := strings.Index(flag, "=")
919 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
920 got = flag[keyEnd+1:]
921 break
922 }
923 }
924 if expected != got {
925 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
926 }
927}
928
929func TestPatchModule(t *testing.T) {
930 bp := `
931 java_library {
932 name: "foo",
933 srcs: ["a.java"],
934 }
935
936 java_library {
937 name: "bar",
938 srcs: ["b.java"],
939 no_standard_libs: true,
940 system_modules: "none",
941 patch_module: "java.base",
942 }
943
944 java_library {
945 name: "baz",
946 srcs: ["c.java"],
947 patch_module: "java.base",
948 }
949 `
950
951 t.Run("1.8", func(t *testing.T) {
952 // Test default javac 1.8
953 ctx := testJava(t, bp)
954
955 checkPatchModuleFlag(t, ctx, "foo", "")
956 checkPatchModuleFlag(t, ctx, "bar", "")
957 checkPatchModuleFlag(t, ctx, "baz", "")
958 })
959
960 t.Run("1.9", func(t *testing.T) {
961 // Test again with javac 1.9
962 config := testConfig(map[string]string{"EXPERIMENTAL_USE_OPENJDK9": "true"})
963 ctx := testContext(config, bp, nil)
964 run(t, ctx, config)
965
966 checkPatchModuleFlag(t, ctx, "foo", "")
967 expected := "java.base=.:" + buildDir
968 checkPatchModuleFlag(t, ctx, "bar", expected)
969 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
970 checkPatchModuleFlag(t, ctx, "baz", expected)
971 })
972}