blob: f8661a6d1aa21444082258c93f702414c1f48185 [file] [log] [blame]
Colin Cross16b23492016-01-06 14:41:07 -08001// Copyright 2016 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package cc
16
17import (
18 "fmt"
Jeff Gaston72765392017-11-28 16:37:53 -080019 "sort"
Colin Cross16b23492016-01-06 14:41:07 -080020 "strings"
Vishwath Mohane7128792017-11-17 11:08:10 -080021 "sync"
Colin Cross16b23492016-01-06 14:41:07 -080022
Colin Cross6b753602018-06-21 13:03:07 -070023 "github.com/google/blueprint"
Liz Kammerb2fc4702021-06-25 14:53:40 -040024 "github.com/google/blueprint/proptools"
Colin Cross6b753602018-06-21 13:03:07 -070025
Colin Cross635c3b02016-05-18 15:37:25 -070026 "android/soong/android"
Evgenii Stepanovaf36db12016-08-15 14:18:24 -070027 "android/soong/cc/config"
Kiyoung Kim48f37782021-07-07 12:42:39 +090028 "android/soong/snapshot"
Colin Cross16b23492016-01-06 14:41:07 -080029)
30
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070031var (
32 // Any C flags added by sanitizer which libTooling tools may not
33 // understand also need to be added to ClangLibToolingUnknownCflags in
34 // cc/config/clang.go
Vishwath Mohanf3918d32017-02-14 07:59:33 -080035
Yi Kong20233a42019-08-21 01:38:40 -070036 asanCflags = []string{
37 "-fno-omit-frame-pointer",
Yi Kong20233a42019-08-21 01:38:40 -070038 }
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070039 asanLdflags = []string{"-Wl,-u,__asan_preinit"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070040
Yi Kong286abc62021-11-04 16:14:14 +080041 hwasanCflags = []string{
42 "-fno-omit-frame-pointer",
43 "-Wno-frame-larger-than=",
Evgenii Stepanov96fa3dd2020-03-27 19:38:42 +000044 "-fsanitize-hwaddress-abi=platform",
Florian Mayer0b981f52022-02-16 23:46:53 +000045 "-mllvm", "-hwasan-use-after-scope=1",
Yi Kong286abc62021-11-04 16:14:14 +080046 }
47
48 // ThinLTO performs codegen during link time, thus these flags need to
49 // passed to both CFLAGS and LDFLAGS.
50 hwasanCommonflags = []string{
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080051 // The following improves debug location information
52 // availability at the cost of its accuracy. It increases
53 // the likelihood of a stack variable's frame offset
54 // to be recorded in the debug info, which is important
55 // for the quality of hwasan reports. The downside is a
56 // higher number of "optimized out" stack variables.
57 // b/112437883.
Yi Kong286abc62021-11-04 16:14:14 +080058 "-instcombine-lower-dbg-declare=0",
Mitch Phillipsb1c574f2020-06-22 13:28:23 -070059 // TODO(b/159343917): HWASan and GlobalISel don't play nicely, and
60 // GlobalISel is the default at -O0 on aarch64.
Yi Kong286abc62021-11-04 16:14:14 +080061 "--aarch64-enable-global-isel-at-O=-1",
62 "-fast-isel=false",
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080063 }
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070064
Vishwath Mohanb743e9c2017-11-01 09:20:21 +000065 cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso",
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -070066 "-fsanitize-ignorelist=external/compiler-rt/lib/cfi/cfi_blocklist.txt"}
Evgenii Stepanovdbf1d4f2018-08-31 12:54:33 -070067 // -flto and -fvisibility are required by clang when -fsanitize=cfi is
68 // used, but have no effect on assembly files
69 cfiAsflags = []string{"-flto", "-fvisibility=default"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070070 cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi",
Pirama Arumuga Nainarbdb17f02017-08-28 21:50:17 -070071 "-Wl,-plugin-opt,O1"}
Inseob Kim74d25562020-08-04 00:41:38 +090072 cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070073
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -070074 intOverflowCflags = []string{"-fsanitize-ignorelist=build/soong/cc/config/integer_overflow_blocklist.txt"}
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080075
Peter Collingbournebd19db02019-03-06 10:38:48 -080076 minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined",
Ivan Lozanoae6ae1d2018-10-08 09:29:39 -070077 "-fno-sanitize-recover=integer,undefined"}
Evgenii Stepanov2c6484e2019-05-15 12:49:54 -070078 hwasanGlobalOptions = []string{"heap_history_size=1023", "stack_history_size=512",
79 "export_memory_stats=0", "max_malloc_fill_size=0"}
Dan Willemsencbceaab2016-10-13 16:44:07 -070080)
81
Ivan Lozano3968d8f2020-12-14 11:27:52 -050082type SanitizerType int
Colin Cross16b23492016-01-06 14:41:07 -080083
Colin Cross16b23492016-01-06 14:41:07 -080084const (
Ivan Lozano3968d8f2020-12-14 11:27:52 -050085 Asan SanitizerType = iota + 1
Tri Vo6eafc362021-04-01 11:29:09 -070086 Hwasan
Colin Cross16b23492016-01-06 14:41:07 -080087 tsan
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070088 intOverflow
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080089 scs
Ivan Lozano3968d8f2020-12-14 11:27:52 -050090 Fuzzer
Ivan Lozano62cd0382021-11-01 10:27:54 -040091 Memtag_heap
Liz Kammer75db9312021-07-07 16:41:50 -040092 cfi // cfi is last to prevent it running before incompatible mutators
Colin Cross16b23492016-01-06 14:41:07 -080093)
94
Liz Kammer75db9312021-07-07 16:41:50 -040095var Sanitizers = []SanitizerType{
96 Asan,
97 Hwasan,
98 tsan,
99 intOverflow,
100 scs,
101 Fuzzer,
Ivan Lozano62cd0382021-11-01 10:27:54 -0400102 Memtag_heap,
Liz Kammer75db9312021-07-07 16:41:50 -0400103 cfi, // cfi is last to prevent it running before incompatible mutators
104}
105
Jiyong Park82226632019-02-01 10:50:50 +0900106// Name of the sanitizer variation for this sanitizer type
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500107func (t SanitizerType) variationName() string {
Colin Cross16b23492016-01-06 14:41:07 -0800108 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500109 case Asan:
Colin Cross16b23492016-01-06 14:41:07 -0800110 return "asan"
Tri Vo6eafc362021-04-01 11:29:09 -0700111 case Hwasan:
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700112 return "hwasan"
Colin Cross16b23492016-01-06 14:41:07 -0800113 case tsan:
114 return "tsan"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700115 case intOverflow:
116 return "intOverflow"
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000117 case cfi:
118 return "cfi"
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800119 case scs:
120 return "scs"
Ivan Lozano62cd0382021-11-01 10:27:54 -0400121 case Memtag_heap:
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700122 return "memtag_heap"
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500123 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700124 return "fuzzer"
Colin Cross16b23492016-01-06 14:41:07 -0800125 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500126 panic(fmt.Errorf("unknown SanitizerType %d", t))
Colin Cross16b23492016-01-06 14:41:07 -0800127 }
128}
129
Jiyong Park82226632019-02-01 10:50:50 +0900130// This is the sanitizer names in SANITIZE_[TARGET|HOST]
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500131func (t SanitizerType) name() string {
Jiyong Park82226632019-02-01 10:50:50 +0900132 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500133 case Asan:
Jiyong Park82226632019-02-01 10:50:50 +0900134 return "address"
Tri Vo6eafc362021-04-01 11:29:09 -0700135 case Hwasan:
Jiyong Park82226632019-02-01 10:50:50 +0900136 return "hwaddress"
Ivan Lozano62cd0382021-11-01 10:27:54 -0400137 case Memtag_heap:
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700138 return "memtag_heap"
Jiyong Park82226632019-02-01 10:50:50 +0900139 case tsan:
140 return "thread"
141 case intOverflow:
142 return "integer_overflow"
143 case cfi:
144 return "cfi"
145 case scs:
146 return "shadow-call-stack"
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500147 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700148 return "fuzzer"
Jiyong Park82226632019-02-01 10:50:50 +0900149 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500150 panic(fmt.Errorf("unknown SanitizerType %d", t))
Jiyong Park82226632019-02-01 10:50:50 +0900151 }
152}
153
Liz Kammer75db9312021-07-07 16:41:50 -0400154func (t SanitizerType) registerMutators(ctx android.RegisterMutatorsContext) {
155 switch t {
156 case Asan, Hwasan, Fuzzer, scs, tsan, cfi:
157 ctx.TopDown(t.variationName()+"_deps", sanitizerDepsMutator(t))
158 ctx.BottomUp(t.variationName(), sanitizerMutator(t))
Ivan Lozano62cd0382021-11-01 10:27:54 -0400159 case Memtag_heap, intOverflow:
Liz Kammer75db9312021-07-07 16:41:50 -0400160 // do nothing
161 default:
162 panic(fmt.Errorf("unknown SanitizerType %d", t))
163 }
164}
165
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500166func (*Module) SanitizerSupported(t SanitizerType) bool {
167 switch t {
168 case Asan:
169 return true
Tri Vo6eafc362021-04-01 11:29:09 -0700170 case Hwasan:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500171 return true
172 case tsan:
173 return true
174 case intOverflow:
175 return true
176 case cfi:
177 return true
178 case scs:
179 return true
180 case Fuzzer:
181 return true
Ivan Lozano62cd0382021-11-01 10:27:54 -0400182 case Memtag_heap:
183 return true
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500184 default:
185 return false
186 }
187}
188
189// incompatibleWithCfi returns true if a sanitizer is incompatible with CFI.
190func (t SanitizerType) incompatibleWithCfi() bool {
Tri Vo6eafc362021-04-01 11:29:09 -0700191 return t == Asan || t == Fuzzer || t == Hwasan
Jiyong Park1d1119f2019-07-29 21:27:18 +0900192}
193
Martin Stjernholmb0249572020-09-15 02:32:35 +0100194type SanitizeUserProps struct {
Liz Kammer75b9b402021-06-25 15:19:27 -0400195 // Prevent use of any sanitizers on this module
Martin Stjernholmb0249572020-09-15 02:32:35 +0100196 Never *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800197
Liz Kammer75b9b402021-06-25 15:19:27 -0400198 // ASan (Address sanitizer), incompatible with static binaries.
199 // Always runs in a diagnostic mode.
200 // Use of address sanitizer disables cfi sanitizer.
201 // Hwaddress sanitizer takes precedence over this sanitizer.
202 Address *bool `android:"arch_variant"`
203 // TSan (Thread sanitizer), incompatible with static binaries and 32 bit architectures.
204 // Always runs in a diagnostic mode.
205 // Use of thread sanitizer disables cfi and scudo sanitizers.
206 // Hwaddress sanitizer takes precedence over this sanitizer.
207 Thread *bool `android:"arch_variant"`
208 // HWASan (Hardware Address sanitizer).
209 // Use of hwasan sanitizer disables cfi, address, thread, and scudo sanitizers.
Martin Stjernholmb0249572020-09-15 02:32:35 +0100210 Hwaddress *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800211
Liz Kammer75b9b402021-06-25 15:19:27 -0400212 // Undefined behavior sanitizer
213 All_undefined *bool `android:"arch_variant"`
214 // Subset of undefined behavior sanitizer
215 Undefined *bool `android:"arch_variant"`
216 // List of specific undefined behavior sanitizers to enable
217 Misc_undefined []string `android:"arch_variant"`
218 // Fuzzer, incompatible with static binaries.
219 Fuzzer *bool `android:"arch_variant"`
220 // safe-stack sanitizer, incompatible with 32-bit architectures.
221 Safestack *bool `android:"arch_variant"`
222 // cfi sanitizer, incompatible with asan, hwasan, fuzzer, or Darwin
223 Cfi *bool `android:"arch_variant"`
224 // signed/unsigned integer overflow sanitizer, incompatible with Darwin.
225 Integer_overflow *bool `android:"arch_variant"`
226 // scudo sanitizer, incompatible with asan, hwasan, tsan
227 // This should not be used in Android 11+ : https://source.android.com/devices/tech/debug/scudo
228 // deprecated
229 Scudo *bool `android:"arch_variant"`
230 // shadow-call-stack sanitizer, only available on arm64
231 Scs *bool `android:"arch_variant"`
232 // Memory-tagging, only available on arm64
233 // if diag.memtag unset or false, enables async memory tagging
234 Memtag_heap *bool `android:"arch_variant"`
Martin Stjernholmb0249572020-09-15 02:32:35 +0100235
236 // A modifier for ASAN and HWASAN for write only instrumentation
237 Writeonly *bool `android:"arch_variant"`
238
239 // Sanitizers to run in the diagnostic mode (as opposed to the release mode).
240 // Replaces abort() on error with a human-readable error message.
241 // Address and Thread sanitizers always run in diagnostic mode.
242 Diag struct {
Liz Kammer75b9b402021-06-25 15:19:27 -0400243 // Undefined behavior sanitizer, diagnostic mode
244 Undefined *bool `android:"arch_variant"`
245 // cfi sanitizer, diagnostic mode, incompatible with asan, hwasan, fuzzer, or Darwin
246 Cfi *bool `android:"arch_variant"`
247 // signed/unsigned integer overflow sanitizer, diagnostic mode, incompatible with Darwin.
248 Integer_overflow *bool `android:"arch_variant"`
249 // Memory-tagging, only available on arm64
250 // requires sanitizer.memtag: true
251 // if set, enables sync memory tagging
252 Memtag_heap *bool `android:"arch_variant"`
253 // List of specific undefined behavior sanitizers to enable in diagnostic mode
254 Misc_undefined []string `android:"arch_variant"`
255 // List of sanitizers to pass to -fno-sanitize-recover
256 // results in only the first detected error for these sanitizers being reported and program then
257 // exits with a non-zero exit code.
258 No_recover []string `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800259 } `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800260
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800261 // Sanitizers to run with flag configuration specified
262 Config struct {
263 // Enables CFI support flags for assembly-heavy libraries
264 Cfi_assembly_support *bool `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800265 } `android:"arch_variant"`
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800266
Liz Kammer75b9b402021-06-25 15:19:27 -0400267 // List of sanitizers to pass to -fsanitize-recover
268 // allows execution to continue for these sanitizers to detect multiple errors rather than only
269 // the first one
Martin Stjernholmb0249572020-09-15 02:32:35 +0100270 Recover []string
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000271
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -0700272 // value to pass to -fsanitize-ignorelist
Martin Stjernholmb0249572020-09-15 02:32:35 +0100273 Blocklist *string
274}
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700275
Martin Stjernholmb0249572020-09-15 02:32:35 +0100276type SanitizeProperties struct {
Martin Stjernholmb0249572020-09-15 02:32:35 +0100277 Sanitize SanitizeUserProps `android:"arch_variant"`
278 SanitizerEnabled bool `blueprint:"mutated"`
279 SanitizeDep bool `blueprint:"mutated"`
280 MinimalRuntimeDep bool `blueprint:"mutated"`
281 BuiltinsDep bool `blueprint:"mutated"`
282 UbsanRuntimeDep bool `blueprint:"mutated"`
283 InSanitizerDir bool `blueprint:"mutated"`
284 Sanitizers []string `blueprint:"mutated"`
285 DiagSanitizers []string `blueprint:"mutated"`
Colin Cross16b23492016-01-06 14:41:07 -0800286}
287
288type sanitize struct {
289 Properties SanitizeProperties
290}
291
Cindy Zhou18417cb2020-12-10 07:12:38 -0800292// Mark this tag with a check to see if apex dependency check should be skipped
293func (t libraryDependencyTag) SkipApexAllowedDependenciesCheck() bool {
294 return t.skipApexAllowedDependenciesCheck
295}
296
297var _ android.SkipApexAllowedDependenciesCheck = (*libraryDependencyTag)(nil)
298
Vishwath Mohane7128792017-11-17 11:08:10 -0800299func init() {
300 android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700301 android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider)
Vishwath Mohane7128792017-11-17 11:08:10 -0800302}
303
Colin Cross16b23492016-01-06 14:41:07 -0800304func (sanitize *sanitize) props() []interface{} {
305 return []interface{}{&sanitize.Properties}
306}
307
308func (sanitize *sanitize) begin(ctx BaseModuleContext) {
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700309 s := &sanitize.Properties.Sanitize
310
Colin Cross16b23492016-01-06 14:41:07 -0800311 // Don't apply sanitizers to NDK code.
Jeff Gastonaf3cc2d2017-09-27 17:01:44 -0700312 if ctx.useSdk() {
Nan Zhang0007d812017-11-07 10:57:05 -0800313 s.Never = BoolPtr(true)
Colin Cross16b23492016-01-06 14:41:07 -0800314 }
315
316 // Never always wins.
Nan Zhang0007d812017-11-07 10:57:05 -0800317 if Bool(s.Never) {
Colin Cross16b23492016-01-06 14:41:07 -0800318 return
319 }
320
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800321 // cc_test targets default to SYNC MemTag unless explicitly set to ASYNC (via diag: {memtag_heap}).
Liz Kammer7b920b42021-06-22 16:57:27 -0400322 if ctx.testBinary() {
323 if s.Memtag_heap == nil {
324 s.Memtag_heap = proptools.BoolPtr(true)
325 }
326 if s.Diag.Memtag_heap == nil {
327 s.Diag.Memtag_heap = proptools.BoolPtr(true)
328 }
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800329 }
330
Colin Cross16b23492016-01-06 14:41:07 -0800331 var globalSanitizers []string
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700332 var globalSanitizersDiag []string
333
Dan Willemsen8536d6b2018-10-07 20:54:34 -0700334 if ctx.Host() {
335 if !ctx.Windows() {
336 globalSanitizers = ctx.Config().SanitizeHost()
337 }
338 } else {
339 arches := ctx.Config().SanitizeDeviceArch()
340 if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) {
341 globalSanitizers = ctx.Config().SanitizeDevice()
342 globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag()
Colin Cross16b23492016-01-06 14:41:07 -0800343 }
344 }
345
Colin Cross16b23492016-01-06 14:41:07 -0800346 if len(globalSanitizers) > 0 {
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000347 var found bool
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700348 if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400349 s.All_undefined = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000350 }
Colin Cross16b23492016-01-06 14:41:07 -0800351
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700352 if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400353 s.Undefined = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000354 }
355
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700356 if found, globalSanitizers = removeFromList("address", globalSanitizers); found && s.Address == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400357 s.Address = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000358 }
359
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700360 if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400361 s.Thread = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000362 }
363
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700364 if found, globalSanitizers = removeFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400365 s.Fuzzer = proptools.BoolPtr(true)
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700366 }
367
368 if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400369 s.Safestack = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000370 }
371
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700372 if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil {
Colin Cross6510f912017-11-29 00:27:14 -0800373 if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400374 s.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700375 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700376 }
377
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700378 // Global integer_overflow builds do not support static libraries.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700379 if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil {
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700380 if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400381 s.Integer_overflow = proptools.BoolPtr(true)
Ivan Lozano5f595532017-07-13 14:46:05 -0700382 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700383 }
384
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700385 if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400386 s.Scudo = proptools.BoolPtr(true)
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700387 }
388
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700389 if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400390 s.Hwaddress = proptools.BoolPtr(true)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700391 }
392
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000393 if found, globalSanitizers = removeFromList("writeonly", globalSanitizers); found && s.Writeonly == nil {
394 // Hwaddress and Address are set before, so we can check them here
395 // If they aren't explicitly set in the blueprint/SANITIZE_(HOST|TARGET), they would be nil instead of false
396 if s.Address == nil && s.Hwaddress == nil {
397 ctx.ModuleErrorf("writeonly modifier cannot be used without 'address' or 'hwaddress'")
398 }
Liz Kammerb2fc4702021-06-25 14:53:40 -0400399 s.Writeonly = proptools.BoolPtr(true)
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000400 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700401 if found, globalSanitizers = removeFromList("memtag_heap", globalSanitizers); found && s.Memtag_heap == nil {
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800402 if !ctx.Config().MemtagHeapDisabledForPath(ctx.ModuleDir()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400403 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800404 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700405 }
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000406
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000407 if len(globalSanitizers) > 0 {
408 ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0])
409 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700410
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700411 // Global integer_overflow builds do not support static library diagnostics.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700412 if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found &&
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700413 s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400414 s.Diag.Integer_overflow = proptools.BoolPtr(true)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700415 }
416
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700417 if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found &&
418 s.Diag.Cfi == nil && Bool(s.Cfi) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400419 s.Diag.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700420 }
421
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800422 if found, globalSanitizersDiag = removeFromList("memtag_heap", globalSanitizersDiag); found &&
423 s.Diag.Memtag_heap == nil && Bool(s.Memtag_heap) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400424 s.Diag.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800425 }
426
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700427 if len(globalSanitizersDiag) > 0 {
428 ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0])
429 }
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700430 }
Colin Cross3c344ef2016-07-18 15:44:56 -0700431
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800432 // Enable Memtag for all components in the include paths (for Aarch64 only)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800433 if ctx.Arch().ArchType == android.Arm64 {
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800434 if ctx.Config().MemtagHeapSyncEnabledForPath(ctx.ModuleDir()) {
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800435 if s.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400436 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800437 }
438 if s.Diag.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400439 s.Diag.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800440 }
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800441 } else if ctx.Config().MemtagHeapAsyncEnabledForPath(ctx.ModuleDir()) {
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800442 if s.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400443 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800444 }
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800445 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700446 }
447
Elvis Chien9c993542021-06-25 01:15:17 +0800448 // Enable CFI for non-host components in the include paths
449 if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && !ctx.Host() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400450 s.Cfi = proptools.BoolPtr(true)
Vishwath Mohan3af8ee02018-03-30 02:55:23 +0000451 if inList("cfi", ctx.Config().SanitizeDeviceDiag()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400452 s.Diag.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700453 }
454 }
455
Elliott Hughesda3a0712020-03-06 16:55:28 -0800456 // Is CFI actually enabled?
457 if !ctx.Config().EnableCFI() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400458 s.Cfi = nil
459 s.Diag.Cfi = nil
Vishwath Mohan1b017a72017-01-19 13:54:55 -0800460 }
461
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700462 // HWASan requires AArch64 hardware feature (top-byte-ignore).
463 if ctx.Arch().ArchType != android.Arm64 {
464 s.Hwaddress = nil
465 }
466
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800467 // SCS is only implemented on AArch64.
Peter Collingbournebd19db02019-03-06 10:38:48 -0800468 if ctx.Arch().ArchType != android.Arm64 {
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800469 s.Scs = nil
470 }
471
Ivan Lozano62cd0382021-11-01 10:27:54 -0400472 // Memtag_heap is only implemented on AArch64.
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700473 if ctx.Arch().ArchType != android.Arm64 {
474 s.Memtag_heap = nil
475 }
476
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700477 // Also disable CFI if ASAN is enabled.
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700478 if Bool(s.Address) || Bool(s.Hwaddress) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400479 s.Cfi = nil
480 s.Diag.Cfi = nil
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700481 }
482
Colin Cross528d67e2021-07-23 22:23:07 +0000483 // Disable sanitizers that depend on the UBSan runtime for windows/darwin/musl builds.
484 if !ctx.Os().Linux() || ctx.Os() == android.LinuxMusl {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400485 s.Cfi = nil
486 s.Diag.Cfi = nil
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700487 s.Misc_undefined = nil
488 s.Undefined = nil
489 s.All_undefined = nil
490 s.Integer_overflow = nil
Vishwath Mohane7128792017-11-17 11:08:10 -0800491 }
492
Vishwath Mohan9ccbba02018-05-28 13:54:48 -0700493 // Also disable CFI for VNDK variants of components
494 if ctx.isVndk() && ctx.useVndk() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900495 if ctx.static() {
496 // Cfi variant for static vndk should be captured as vendor snapshot,
497 // so don't strictly disable Cfi.
498 s.Cfi = nil
499 s.Diag.Cfi = nil
500 } else {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400501 s.Cfi = nil
502 s.Diag.Cfi = nil
Inseob Kimc42f2f22020-07-29 20:32:10 +0900503 }
Inseob Kimeec88e12020-01-22 11:11:29 +0900504 }
505
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700506 // HWASan ramdisk (which is built from recovery) goes over some bootloader limit.
Yifan Hong60e0cfb2020-10-21 15:17:56 -0700507 // Keep libc instrumented so that ramdisk / vendor_ramdisk / recovery can run hwasan-instrumented code if necessary.
508 if (ctx.inRamdisk() || ctx.inVendorRamdisk() || ctx.inRecovery()) && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700509 s.Hwaddress = nil
510 }
511
Colin Cross3c344ef2016-07-18 15:44:56 -0700512 if ctx.staticBinary() {
513 s.Address = nil
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700514 s.Fuzzer = nil
Colin Cross3c344ef2016-07-18 15:44:56 -0700515 s.Thread = nil
Colin Cross16b23492016-01-06 14:41:07 -0800516 }
517
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700518 if Bool(s.All_undefined) {
519 s.Undefined = nil
520 }
521
Evgenii Stepanov0a8a0d02016-05-12 13:54:53 -0700522 if !ctx.toolchain().Is64Bit() {
523 // TSAN and SafeStack are not supported on 32-bit architectures
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700524 s.Thread = nil
525 s.Safestack = nil
Colin Cross16b23492016-01-06 14:41:07 -0800526 // TODO(ccross): error for compile_multilib = "32"?
527 }
528
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800529 if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) ||
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700530 Bool(s.Fuzzer) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 ||
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700531 Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs) || Bool(s.Memtag_heap)) {
Colin Cross3c344ef2016-07-18 15:44:56 -0700532 sanitize.Properties.SanitizerEnabled = true
533 }
534
Kostya Kortchinskyd5275c82019-02-01 08:42:56 -0800535 // Disable Scudo if ASan or TSan is enabled, or if it's disabled globally.
536 if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) || ctx.Config().DisableScudo() {
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700537 s.Scudo = nil
538 }
539
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700540 if Bool(s.Hwaddress) {
541 s.Address = nil
542 s.Thread = nil
543 }
Mitch Phillips5007c4a2022-03-02 01:25:22 +0000544
545 // TODO(b/131771163): CFI transiently depends on LTO, and thus Fuzzer is
546 // mutually incompatible.
547 if Bool(s.Fuzzer) {
548 s.Cfi = nil
549 }
Colin Cross16b23492016-01-06 14:41:07 -0800550}
551
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800552func toDisableImplicitIntegerChange(flags []string) bool {
553 // Returns true if any flag is fsanitize*integer, and there is
554 // no explicit flag about sanitize=implicit-integer-sign-change.
555 for _, f := range flags {
556 if strings.Contains(f, "sanitize=implicit-integer-sign-change") {
557 return false
558 }
559 }
560 for _, f := range flags {
561 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
562 return true
563 }
564 }
565 return false
566}
567
Yabin Cuidb7dda82020-11-30 15:47:45 -0800568func toDisableUnsignedShiftBaseChange(flags []string) bool {
569 // Returns true if any flag is fsanitize*integer, and there is
570 // no explicit flag about sanitize=unsigned-shift-base.
571 for _, f := range flags {
572 if strings.Contains(f, "sanitize=unsigned-shift-base") {
573 return false
574 }
575 }
576 for _, f := range flags {
577 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
578 return true
579 }
580 }
581 return false
582}
583
Colin Cross16b23492016-01-06 14:41:07 -0800584func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags {
Ivan Lozano59fdea22018-05-10 14:17:22 -0700585 minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a"
Ivan Lozano30c5db22018-02-21 15:49:20 -0800586
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500587 if sanitize.Properties.MinimalRuntimeDep {
Colin Cross4af21ed2019-11-04 09:37:55 -0800588 flags.Local.LdFlags = append(flags.Local.LdFlags,
Colin Cross4af21ed2019-11-04 09:37:55 -0800589 "-Wl,--exclude-libs,"+minimalRuntimeLib)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800590 }
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500591
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700592 if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep {
Colin Cross16b23492016-01-06 14:41:07 -0800593 return flags
594 }
595
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700596 if Bool(sanitize.Properties.Sanitize.Address) {
Colin Cross635c3b02016-05-18 15:37:25 -0700597 if ctx.Arch().ArchType == android.Arm {
Colin Cross16b23492016-01-06 14:41:07 -0800598 // Frame pointer based unwinder in ASan requires ARM frame setup.
599 // TODO: put in flags?
600 flags.RequiredInstructionSet = "arm"
601 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800602 flags.Local.CFlags = append(flags.Local.CFlags, asanCflags...)
603 flags.Local.LdFlags = append(flags.Local.LdFlags, asanLdflags...)
Colin Cross16b23492016-01-06 14:41:07 -0800604
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000605 if Bool(sanitize.Properties.Sanitize.Writeonly) {
606 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-instrument-reads=0")
607 }
608
Colin Cross16b23492016-01-06 14:41:07 -0800609 if ctx.Host() {
610 // -nodefaultlibs (provided with libc++) prevents the driver from linking
611 // libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Colin Cross4af21ed2019-11-04 09:37:55 -0800612 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--no-as-needed")
Colin Cross16b23492016-01-06 14:41:07 -0800613 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800614 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-globals=0")
Jiyong Parka2aca282019-02-02 13:13:38 +0900615 if ctx.bootstrap() {
616 flags.DynamicLinker = "/system/bin/bootstrap/linker_asan"
617 } else {
618 flags.DynamicLinker = "/system/bin/linker_asan"
619 }
Colin Cross16b23492016-01-06 14:41:07 -0800620 if flags.Toolchain.Is64Bit() {
621 flags.DynamicLinker += "64"
622 }
623 }
Colin Cross16b23492016-01-06 14:41:07 -0800624 }
625
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700626 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800627 flags.Local.CFlags = append(flags.Local.CFlags, hwasanCflags...)
Yi Kong286abc62021-11-04 16:14:14 +0800628
629 for _, flag := range hwasanCommonflags {
630 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", flag)
631 }
632 for _, flag := range hwasanCommonflags {
633 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,-mllvm,"+flag)
634 }
635
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000636 if Bool(sanitize.Properties.Sanitize.Writeonly) {
637 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-hwasan-instrument-reads=0")
638 }
Yabin Cui6be405e2017-10-19 15:52:11 -0700639 }
640
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700641 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800642 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize=fuzzer-no-link")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700643
Mitch Phillips5007c4a2022-03-02 01:25:22 +0000644 // TODO(b/131771163): LTO and Fuzzer support is mutually incompatible.
645 _, flags.Local.LdFlags = removeFromList("-flto", flags.Local.LdFlags)
646 _, flags.Local.CFlags = removeFromList("-flto", flags.Local.CFlags)
647 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-lto")
648 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-lto")
649
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700650 // TODO(b/142430592): Upstream linker scripts for sanitizer runtime libraries
651 // discard the sancov_lowest_stack symbol, because it's emulated TLS (and thus
652 // doesn't match the linker script due to the "__emutls_v." prefix).
Colin Cross4af21ed2019-11-04 09:37:55 -0800653 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-coverage=stack-depth")
654 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-coverage=stack-depth")
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700655
Mitch Phillipsb9b3e792019-08-28 12:41:07 -0700656 // Disable fortify for fuzzing builds. Generally, we'll be building with
657 // UBSan or ASan here and the fortify checks pollute the stack traces.
Colin Cross4af21ed2019-11-04 09:37:55 -0800658 flags.Local.CFlags = append(flags.Local.CFlags, "-U_FORTIFY_SOURCE")
Mitch Phillips734b4cb2019-12-10 08:44:52 -0800659
660 // Build fuzzer-sanitized libraries with an $ORIGIN DT_RUNPATH. Android's
661 // linker uses DT_RUNPATH, not DT_RPATH. When we deploy cc_fuzz targets and
662 // their libraries to /data/fuzz/<arch>/lib, any transient shared library gets
663 // the DT_RUNPATH from the shared library above it, and not the executable,
664 // meaning that the lookup falls back to the system. Adding the $ORIGIN to the
665 // DT_RUNPATH here means that transient shared libraries can be found
666 // colocated with their parents.
667 flags.Local.LdFlags = append(flags.Local.LdFlags, `-Wl,-rpath,\$$ORIGIN`)
Colin Cross16b23492016-01-06 14:41:07 -0800668 }
669
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700670 if Bool(sanitize.Properties.Sanitize.Cfi) {
Evgenii Stepanov7ebf9fa2017-01-20 14:13:06 -0800671 if ctx.Arch().ArchType == android.Arm {
672 // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up
673 // to do this on a function basis, so force Thumb on the entire module.
674 flags.RequiredInstructionSet = "thumb"
675 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000676
Colin Cross4af21ed2019-11-04 09:37:55 -0800677 flags.Local.CFlags = append(flags.Local.CFlags, cfiCflags...)
678 flags.Local.AsFlags = append(flags.Local.AsFlags, cfiAsflags...)
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800679 if Bool(sanitize.Properties.Sanitize.Config.Cfi_assembly_support) {
680 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-cfi-canonical-jump-tables")
681 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000682 // Only append the default visibility flag if -fvisibility has not already been set
683 // to hidden.
Colin Cross4af21ed2019-11-04 09:37:55 -0800684 if !inList("-fvisibility=hidden", flags.Local.CFlags) {
685 flags.Local.CFlags = append(flags.Local.CFlags, "-fvisibility=default")
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000686 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800687 flags.Local.LdFlags = append(flags.Local.LdFlags, cfiLdflags...)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000688
689 if ctx.staticBinary() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800690 _, flags.Local.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.CFlags)
691 _, flags.Local.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.LdFlags)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000692 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700693 }
694
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700695 if Bool(sanitize.Properties.Sanitize.Integer_overflow) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800696 flags.Local.CFlags = append(flags.Local.CFlags, intOverflowCflags...)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700697 }
698
Jiyong Park379de2f2018-12-19 02:47:14 +0900699 if len(sanitize.Properties.Sanitizers) > 0 {
700 sanitizeArg := "-fsanitize=" + strings.Join(sanitize.Properties.Sanitizers, ",")
Colin Cross4af21ed2019-11-04 09:37:55 -0800701 flags.Local.CFlags = append(flags.Local.CFlags, sanitizeArg)
702 flags.Local.AsFlags = append(flags.Local.AsFlags, sanitizeArg)
Colin Cross234b01d2022-02-07 13:49:03 -0800703 flags.Local.LdFlags = append(flags.Local.LdFlags, sanitizeArg)
704
705 if ctx.toolchain().Bionic() {
706 // Bionic sanitizer runtimes have already been added as dependencies so that
707 // the right variant of the runtime will be used (with the "-android"
708 // suffix), so don't let clang the runtime library.
709 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-link-runtime")
710 } else {
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800711 // Host sanitizers only link symbols in the final executable, so
712 // there will always be undefined symbols in intermediate libraries.
Colin Cross4af21ed2019-11-04 09:37:55 -0800713 _, flags.Global.LdFlags = removeFromList("-Wl,--no-undefined", flags.Global.LdFlags)
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500714
Colin Cross234b01d2022-02-07 13:49:03 -0800715 // non-Bionic toolchain prebuilts are missing UBSan's vptr and function san
716 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=vptr,function")
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500717 }
718
719 if enableMinimalRuntime(sanitize) {
720 flags.Local.CFlags = append(flags.Local.CFlags, strings.Join(minimalRuntimeFlags, " "))
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500721 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib)
Colin Cross16b23492016-01-06 14:41:07 -0800722 }
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700723
724 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
725 // When fuzzing, we wish to crash with diagnostics on any bug.
Colin Cross4af21ed2019-11-04 09:37:55 -0800726 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap=all", "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700727 } else if ctx.Host() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800728 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700729 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800730 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700731 }
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800732 // http://b/119329758, Android core does not boot up with this sanitizer yet.
Colin Cross4af21ed2019-11-04 09:37:55 -0800733 if toDisableImplicitIntegerChange(flags.Local.CFlags) {
734 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=implicit-integer-sign-change")
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800735 }
Yabin Cuidb7dda82020-11-30 15:47:45 -0800736 // http://b/171275751, Android doesn't build with this sanitizer yet.
737 if toDisableUnsignedShiftBaseChange(flags.Local.CFlags) {
738 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=unsigned-shift-base")
739 }
Colin Cross16b23492016-01-06 14:41:07 -0800740 }
741
Jiyong Park379de2f2018-12-19 02:47:14 +0900742 if len(sanitize.Properties.DiagSanitizers) > 0 {
Colin Cross4af21ed2019-11-04 09:37:55 -0800743 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap="+strings.Join(sanitize.Properties.DiagSanitizers, ","))
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700744 }
745 // FIXME: enable RTTI if diag + (cfi or vptr)
746
Andreas Gampe97071162017-05-08 13:15:23 -0700747 if sanitize.Properties.Sanitize.Recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800748 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-recover="+
Andreas Gampe97071162017-05-08 13:15:23 -0700749 strings.Join(sanitize.Properties.Sanitize.Recover, ","))
750 }
751
Ivan Lozano7929bba2018-12-12 09:36:31 -0800752 if sanitize.Properties.Sanitize.Diag.No_recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800753 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover="+
Ivan Lozano7929bba2018-12-12 09:36:31 -0800754 strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ","))
755 }
756
Pirama Arumuga Nainar6c4ccca2020-07-27 11:49:51 -0700757 blocklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blocklist)
758 if blocklist.Valid() {
Pirama Arumuga Nainar582fc2d2021-08-27 15:12:56 -0700759 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-ignorelist="+blocklist.String())
Pirama Arumuga Nainar6c4ccca2020-07-27 11:49:51 -0700760 flags.CFlagsDeps = append(flags.CFlagsDeps, blocklist.Path())
761 }
762
Colin Cross16b23492016-01-06 14:41:07 -0800763 return flags
764}
765
Colin Crossd80cbca2020-02-24 12:01:37 -0800766func (sanitize *sanitize) AndroidMkEntries(ctx AndroidMkContext, entries *android.AndroidMkEntries) {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900767 // Add a suffix for cfi/hwasan/scs-enabled static/header libraries to allow surfacing
768 // both the sanitized and non-sanitized variants to make without a name conflict.
Colin Crossd80cbca2020-02-24 12:01:37 -0800769 if entries.Class == "STATIC_LIBRARIES" || entries.Class == "HEADER_LIBRARIES" {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900770 if Bool(sanitize.Properties.Sanitize.Cfi) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800771 entries.SubName += ".cfi"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900772 }
773 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800774 entries.SubName += ".hwasan"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900775 }
776 if Bool(sanitize.Properties.Sanitize.Scs) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800777 entries.SubName += ".scs"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900778 }
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800779 }
Colin Cross8ff9ef42017-05-08 13:44:11 -0700780}
781
Vishwath Mohan1dd88392017-03-29 22:00:18 -0700782func (sanitize *sanitize) inSanitizerDir() bool {
783 return sanitize.Properties.InSanitizerDir
Colin Cross30d5f512016-05-03 18:02:42 -0700784}
785
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500786// getSanitizerBoolPtr returns the SanitizerTypes associated bool pointer from SanitizeProperties.
787func (sanitize *sanitize) getSanitizerBoolPtr(t SanitizerType) *bool {
Vishwath Mohan95229302017-08-11 00:53:16 +0000788 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500789 case Asan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000790 return sanitize.Properties.Sanitize.Address
Tri Vo6eafc362021-04-01 11:29:09 -0700791 case Hwasan:
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700792 return sanitize.Properties.Sanitize.Hwaddress
Vishwath Mohan95229302017-08-11 00:53:16 +0000793 case tsan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000794 return sanitize.Properties.Sanitize.Thread
Vishwath Mohan95229302017-08-11 00:53:16 +0000795 case intOverflow:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000796 return sanitize.Properties.Sanitize.Integer_overflow
797 case cfi:
798 return sanitize.Properties.Sanitize.Cfi
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800799 case scs:
800 return sanitize.Properties.Sanitize.Scs
Ivan Lozano62cd0382021-11-01 10:27:54 -0400801 case Memtag_heap:
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700802 return sanitize.Properties.Sanitize.Memtag_heap
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500803 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700804 return sanitize.Properties.Sanitize.Fuzzer
Vishwath Mohan95229302017-08-11 00:53:16 +0000805 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500806 panic(fmt.Errorf("unknown SanitizerType %d", t))
Vishwath Mohan95229302017-08-11 00:53:16 +0000807 }
808}
809
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500810// isUnsanitizedVariant returns true if no sanitizers are enabled.
Dan Albert7d1eecf2018-01-19 12:30:45 -0800811func (sanitize *sanitize) isUnsanitizedVariant() bool {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500812 return !sanitize.isSanitizerEnabled(Asan) &&
Tri Vo6eafc362021-04-01 11:29:09 -0700813 !sanitize.isSanitizerEnabled(Hwasan) &&
Dan Albert7d1eecf2018-01-19 12:30:45 -0800814 !sanitize.isSanitizerEnabled(tsan) &&
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800815 !sanitize.isSanitizerEnabled(cfi) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700816 !sanitize.isSanitizerEnabled(scs) &&
Ivan Lozano62cd0382021-11-01 10:27:54 -0400817 !sanitize.isSanitizerEnabled(Memtag_heap) &&
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500818 !sanitize.isSanitizerEnabled(Fuzzer)
Dan Albert7d1eecf2018-01-19 12:30:45 -0800819}
820
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500821// isVariantOnProductionDevice returns true if variant is for production devices (no non-production sanitizers enabled).
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700822func (sanitize *sanitize) isVariantOnProductionDevice() bool {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500823 return !sanitize.isSanitizerEnabled(Asan) &&
Tri Vo6eafc362021-04-01 11:29:09 -0700824 !sanitize.isSanitizerEnabled(Hwasan) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700825 !sanitize.isSanitizerEnabled(tsan) &&
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500826 !sanitize.isSanitizerEnabled(Fuzzer)
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700827}
828
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500829func (sanitize *sanitize) SetSanitizer(t SanitizerType, b bool) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400830 bPtr := proptools.BoolPtr(b)
831 if !b {
832 bPtr = nil
833 }
Colin Cross16b23492016-01-06 14:41:07 -0800834 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500835 case Asan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400836 sanitize.Properties.Sanitize.Address = bPtr
Tri Vo6eafc362021-04-01 11:29:09 -0700837 case Hwasan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400838 sanitize.Properties.Sanitize.Hwaddress = bPtr
Colin Cross16b23492016-01-06 14:41:07 -0800839 case tsan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400840 sanitize.Properties.Sanitize.Thread = bPtr
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700841 case intOverflow:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400842 sanitize.Properties.Sanitize.Integer_overflow = bPtr
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000843 case cfi:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400844 sanitize.Properties.Sanitize.Cfi = bPtr
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800845 case scs:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400846 sanitize.Properties.Sanitize.Scs = bPtr
Ivan Lozano62cd0382021-11-01 10:27:54 -0400847 case Memtag_heap:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400848 sanitize.Properties.Sanitize.Memtag_heap = bPtr
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500849 case Fuzzer:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400850 sanitize.Properties.Sanitize.Fuzzer = bPtr
Colin Cross16b23492016-01-06 14:41:07 -0800851 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500852 panic(fmt.Errorf("unknown SanitizerType %d", t))
Colin Cross16b23492016-01-06 14:41:07 -0800853 }
854 if b {
855 sanitize.Properties.SanitizerEnabled = true
856 }
857}
858
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000859// Check if the sanitizer is explicitly disabled (as opposed to nil by
860// virtue of not being set).
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500861func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t SanitizerType) bool {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000862 if sanitize == nil {
863 return false
864 }
865
866 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
867 return sanitizerVal != nil && *sanitizerVal == false
868}
869
870// There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled)
871// because enabling a sanitizer either directly (via the blueprint) or
872// indirectly (via a mutator) sets the bool ptr to true, and you can't
873// distinguish between the cases. It isn't needed though - both cases can be
874// treated identically.
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500875func (sanitize *sanitize) isSanitizerEnabled(t SanitizerType) bool {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000876 if sanitize == nil {
877 return false
878 }
879
880 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
881 return sanitizerVal != nil && *sanitizerVal == true
882}
883
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500884// IsSanitizableDependencyTag returns true if the dependency tag is sanitizable.
885func IsSanitizableDependencyTag(tag blueprint.DependencyTag) bool {
Colin Cross6e511a92020-07-27 21:26:48 -0700886 switch t := tag.(type) {
887 case dependencyTag:
888 return t == reuseObjTag || t == objDepTag
889 case libraryDependencyTag:
890 return true
891 default:
892 return false
893 }
Colin Cross6b753602018-06-21 13:03:07 -0700894}
895
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500896func (m *Module) SanitizableDepTagChecker() SantizableDependencyTagChecker {
897 return IsSanitizableDependencyTag
898}
899
Inseob Kimc42f2f22020-07-29 20:32:10 +0900900// Determines if the current module is a static library going to be captured
901// as vendor snapshot. Such modules must create both cfi and non-cfi variants,
902// except for ones which explicitly disable cfi.
903func needsCfiForVendorSnapshot(mctx android.TopDownMutatorContext) bool {
Kiyoung Kim48f37782021-07-07 12:42:39 +0900904 if snapshot.IsVendorProprietaryModule(mctx) {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900905 return false
906 }
907
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500908 c := mctx.Module().(PlatformSanitizeable)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900909
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500910 if !c.InVendor() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900911 return false
912 }
913
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500914 if !c.StaticallyLinked() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900915 return false
916 }
917
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500918 if c.IsPrebuilt() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900919 return false
920 }
921
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500922 if !c.SanitizerSupported(cfi) {
923 return false
924 }
925
926 return c.SanitizePropDefined() &&
927 !c.SanitizeNever() &&
928 !c.IsSanitizerExplicitlyDisabled(cfi)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900929}
930
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700931// Propagate sanitizer requirements down from binaries
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500932func sanitizerDepsMutator(t SanitizerType) func(android.TopDownMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -0700933 return func(mctx android.TopDownMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500934 if c, ok := mctx.Module().(PlatformSanitizeable); ok {
935 enabled := c.IsSanitizerEnabled(t)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900936 if t == cfi && needsCfiForVendorSnapshot(mctx) {
937 // We shouldn't change the result of isSanitizerEnabled(cfi) to correctly
938 // determine defaultVariation in sanitizerMutator below.
939 // Instead, just mark SanitizeDep to forcefully create cfi variant.
940 enabled = true
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500941 c.SetSanitizeDep(true)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900942 }
943 if enabled {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500944 isSanitizableDependencyTag := c.SanitizableDepTagChecker()
Inseob Kimc42f2f22020-07-29 20:32:10 +0900945 mctx.WalkDeps(func(child, parent android.Module) bool {
946 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
947 return false
948 }
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500949 if d, ok := child.(PlatformSanitizeable); ok && d.SanitizePropDefined() &&
950 !d.SanitizeNever() &&
951 !d.IsSanitizerExplicitlyDisabled(t) {
Colin Crossaf98f582021-05-12 17:27:32 -0700952 if t == cfi || t == Hwasan || t == scs || t == Asan {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500953 if d.StaticallyLinked() && d.SanitizerSupported(t) {
954 // Rust does not support some of these sanitizers, so we need to check if it's
955 // supported before setting this true.
956 d.SetSanitizeDep(true)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900957 }
958 } else {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500959 d.SetSanitizeDep(true)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700960 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000961 }
Inseob Kimc42f2f22020-07-29 20:32:10 +0900962 return true
963 })
964 }
Jiyong Parkf97782b2019-02-13 20:28:58 +0900965 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok {
966 // If an APEX module includes a lib which is enabled for a sanitizer T, then
967 // the APEX module is also enabled for the same sanitizer type.
968 mctx.VisitDirectDeps(func(child android.Module) {
969 if c, ok := child.(*Module); ok && c.sanitize.isSanitizerEnabled(t) {
970 sanitizeable.EnableSanitizer(t.name())
971 }
972 })
Colin Cross16b23492016-01-06 14:41:07 -0800973 }
974 }
975}
976
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500977func (c *Module) SanitizeNever() bool {
978 return Bool(c.sanitize.Properties.Sanitize.Never)
979}
980
981func (c *Module) IsSanitizerExplicitlyDisabled(t SanitizerType) bool {
982 return c.sanitize.isSanitizerExplicitlyDisabled(t)
983}
984
Ivan Lozano30c5db22018-02-21 15:49:20 -0800985// Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies.
Colin Cross6b753602018-06-21 13:03:07 -0700986func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500987 // Change this to PlatformSanitizable when/if non-cc modules support ubsan sanitizers.
Colin Cross6b753602018-06-21 13:03:07 -0700988 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500989 isSanitizableDependencyTag := c.SanitizableDepTagChecker()
Colin Cross6b753602018-06-21 13:03:07 -0700990 mctx.WalkDeps(func(child, parent android.Module) bool {
991 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
992 return false
993 }
Ivan Lozano30c5db22018-02-21 15:49:20 -0800994
Inseob Kimeec88e12020-01-22 11:11:29 +0900995 d, ok := child.(*Module)
996 if !ok || !d.static() {
997 return false
998 }
999 if d.sanitize != nil {
Colin Cross6b753602018-06-21 13:03:07 -07001000 if enableMinimalRuntime(d.sanitize) {
1001 // If a static dependency is built with the minimal runtime,
1002 // make sure we include the ubsan minimal runtime.
1003 c.sanitize.Properties.MinimalRuntimeDep = true
Inseob Kim8471cda2019-11-15 09:59:12 +09001004 } else if enableUbsanRuntime(d.sanitize) {
Colin Cross6b753602018-06-21 13:03:07 -07001005 // If a static dependency runs with full ubsan diagnostics,
1006 // make sure we include the ubsan runtime.
1007 c.sanitize.Properties.UbsanRuntimeDep = true
Ivan Lozano30c5db22018-02-21 15:49:20 -08001008 }
Colin Cross0b908332019-06-19 23:00:20 -07001009
1010 if c.sanitize.Properties.MinimalRuntimeDep &&
1011 c.sanitize.Properties.UbsanRuntimeDep {
1012 // both flags that this mutator might set are true, so don't bother recursing
1013 return false
1014 }
1015
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001016 if c.Os() == android.Linux {
1017 c.sanitize.Properties.BuiltinsDep = true
1018 }
1019
Colin Cross0b908332019-06-19 23:00:20 -07001020 return true
Colin Cross6b753602018-06-21 13:03:07 -07001021 }
Inseob Kimeec88e12020-01-22 11:11:29 +09001022
Jose Galmesf7294582020-11-13 12:07:36 -08001023 if p, ok := d.linker.(*snapshotLibraryDecorator); ok {
Inseob Kimeec88e12020-01-22 11:11:29 +09001024 if Bool(p.properties.Sanitize_minimal_dep) {
1025 c.sanitize.Properties.MinimalRuntimeDep = true
1026 }
1027 if Bool(p.properties.Sanitize_ubsan_dep) {
1028 c.sanitize.Properties.UbsanRuntimeDep = true
1029 }
1030 }
1031
1032 return false
Colin Cross6b753602018-06-21 13:03:07 -07001033 })
Ivan Lozano30c5db22018-02-21 15:49:20 -08001034 }
1035}
1036
Jiyong Park379de2f2018-12-19 02:47:14 +09001037// Add the dependency to the runtime library for each of the sanitizer variants
1038func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001039 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Pirama Arumuga Nainar6aa21022019-01-25 00:20:35 +00001040 if !c.Enabled() {
1041 return
1042 }
Jiyong Park379de2f2018-12-19 02:47:14 +09001043 var sanitizers []string
1044 var diagSanitizers []string
1045
1046 if Bool(c.sanitize.Properties.Sanitize.All_undefined) {
1047 sanitizers = append(sanitizers, "undefined")
1048 } else {
1049 if Bool(c.sanitize.Properties.Sanitize.Undefined) {
1050 sanitizers = append(sanitizers,
1051 "bool",
1052 "integer-divide-by-zero",
1053 "return",
1054 "returns-nonnull-attribute",
1055 "shift-exponent",
1056 "unreachable",
1057 "vla-bound",
1058 // TODO(danalbert): The following checks currently have compiler performance issues.
1059 //"alignment",
1060 //"bounds",
1061 //"enum",
1062 //"float-cast-overflow",
1063 //"float-divide-by-zero",
1064 //"nonnull-attribute",
1065 //"null",
1066 //"shift-base",
1067 //"signed-integer-overflow",
1068 // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on.
1069 // https://llvm.org/PR19302
1070 // http://reviews.llvm.org/D6974
1071 // "object-size",
1072 )
1073 }
1074 sanitizers = append(sanitizers, c.sanitize.Properties.Sanitize.Misc_undefined...)
1075 }
1076
1077 if Bool(c.sanitize.Properties.Sanitize.Diag.Undefined) {
1078 diagSanitizers = append(diagSanitizers, "undefined")
1079 }
1080
1081 diagSanitizers = append(diagSanitizers, c.sanitize.Properties.Sanitize.Diag.Misc_undefined...)
1082
1083 if Bool(c.sanitize.Properties.Sanitize.Address) {
1084 sanitizers = append(sanitizers, "address")
1085 diagSanitizers = append(diagSanitizers, "address")
1086 }
1087
1088 if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
1089 sanitizers = append(sanitizers, "hwaddress")
1090 }
1091
1092 if Bool(c.sanitize.Properties.Sanitize.Thread) {
1093 sanitizers = append(sanitizers, "thread")
1094 }
1095
1096 if Bool(c.sanitize.Properties.Sanitize.Safestack) {
1097 sanitizers = append(sanitizers, "safe-stack")
1098 }
1099
1100 if Bool(c.sanitize.Properties.Sanitize.Cfi) {
1101 sanitizers = append(sanitizers, "cfi")
1102
1103 if Bool(c.sanitize.Properties.Sanitize.Diag.Cfi) {
1104 diagSanitizers = append(diagSanitizers, "cfi")
1105 }
1106 }
1107
1108 if Bool(c.sanitize.Properties.Sanitize.Integer_overflow) {
1109 sanitizers = append(sanitizers, "unsigned-integer-overflow")
1110 sanitizers = append(sanitizers, "signed-integer-overflow")
1111 if Bool(c.sanitize.Properties.Sanitize.Diag.Integer_overflow) {
1112 diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow")
1113 diagSanitizers = append(diagSanitizers, "signed-integer-overflow")
1114 }
1115 }
1116
1117 if Bool(c.sanitize.Properties.Sanitize.Scudo) {
1118 sanitizers = append(sanitizers, "scudo")
1119 }
1120
1121 if Bool(c.sanitize.Properties.Sanitize.Scs) {
1122 sanitizers = append(sanitizers, "shadow-call-stack")
1123 }
1124
Ivan Lozanod7586b62021-04-01 09:49:36 -04001125 if Bool(c.sanitize.Properties.Sanitize.Memtag_heap) && c.Binary() {
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -07001126 noteDep := "note_memtag_heap_async"
1127 if Bool(c.sanitize.Properties.Sanitize.Diag.Memtag_heap) {
1128 noteDep = "note_memtag_heap_sync"
1129 }
Inseob Kim253f5212021-04-08 17:10:31 +09001130 // If we're using snapshots, redirect to snapshot whenever possible
1131 // TODO(b/178470649): clean manual snapshot redirections
1132 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1133 if lib, ok := snapshot.StaticLibs[noteDep]; ok {
1134 noteDep = lib
1135 }
Ivan Lozano62cd0382021-11-01 10:27:54 -04001136 depTag := StaticDepTag(true)
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -07001137 variations := append(mctx.Target().Variations(),
1138 blueprint.Variation{Mutator: "link", Variation: "static"})
1139 if c.Device() {
1140 variations = append(variations, c.ImageVariation())
1141 }
1142 mctx.AddFarVariationDependencies(variations, depTag, noteDep)
1143 }
1144
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001145 if Bool(c.sanitize.Properties.Sanitize.Fuzzer) {
1146 sanitizers = append(sanitizers, "fuzzer-no-link")
1147 }
1148
Jiyong Park379de2f2018-12-19 02:47:14 +09001149 // Save the list of sanitizers. These will be used again when generating
1150 // the build rules (for Cflags, etc.)
1151 c.sanitize.Properties.Sanitizers = sanitizers
1152 c.sanitize.Properties.DiagSanitizers = diagSanitizers
1153
Ivan Lozanof3b190f2020-03-06 12:01:21 -05001154 // TODO(b/150822854) Hosts have a different default behavior and assume the runtime library is used.
1155 if c.Host() {
1156 diagSanitizers = sanitizers
1157 }
1158
Jiyong Park379de2f2018-12-19 02:47:14 +09001159 // Determine the runtime library required
1160 runtimeLibrary := ""
Ryan Prichardb49fe1b2019-10-11 15:03:34 -07001161 var extraStaticDeps []string
Jiyong Park379de2f2018-12-19 02:47:14 +09001162 toolchain := c.toolchain(mctx)
1163 if Bool(c.sanitize.Properties.Sanitize.Address) {
1164 runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain)
1165 } else if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
1166 if c.staticBinary() {
1167 runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain)
Ryan Prichardb49fe1b2019-10-11 15:03:34 -07001168 extraStaticDeps = []string{"libdl"}
Jiyong Park379de2f2018-12-19 02:47:14 +09001169 } else {
1170 runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain)
1171 }
1172 } else if Bool(c.sanitize.Properties.Sanitize.Thread) {
1173 runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain)
1174 } else if Bool(c.sanitize.Properties.Sanitize.Scudo) {
1175 if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep {
1176 runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain)
1177 } else {
1178 runtimeLibrary = config.ScudoRuntimeLibrary(toolchain)
1179 }
Mitch Phillipsb8e593d2019-10-09 17:18:59 -07001180 } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001181 Bool(c.sanitize.Properties.Sanitize.Fuzzer) ||
1182 Bool(c.sanitize.Properties.Sanitize.Undefined) ||
1183 Bool(c.sanitize.Properties.Sanitize.All_undefined) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001184 runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain)
Colin Cross32f1de32021-03-29 13:41:37 -07001185 if c.staticBinary() {
1186 runtimeLibrary += ".static"
1187 }
Jiyong Park379de2f2018-12-19 02:47:14 +09001188 }
1189
Colin Cross06c80eb2022-02-10 10:34:19 -08001190 addStaticDeps := func(deps ...string) {
1191 // If we're using snapshots, redirect to snapshot whenever possible
1192 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1193 for idx, dep := range deps {
1194 if lib, ok := snapshot.StaticLibs[dep]; ok {
1195 deps[idx] = lib
1196 }
1197 }
1198
1199 // static executable gets static runtime libs
1200 depTag := libraryDependencyTag{Kind: staticLibraryDependency}
1201 variations := append(mctx.Target().Variations(),
1202 blueprint.Variation{Mutator: "link", Variation: "static"})
1203 if c.Device() {
1204 variations = append(variations, c.ImageVariation())
1205 }
1206 if c.UseSdk() {
1207 variations = append(variations,
1208 blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
1209 }
1210 mctx.AddFarVariationDependencies(variations, depTag, deps...)
1211
1212 }
1213 if enableMinimalRuntime(c.sanitize) || c.sanitize.Properties.MinimalRuntimeDep {
1214 addStaticDeps(config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(toolchain))
1215 }
1216 if c.sanitize.Properties.BuiltinsDep {
1217 addStaticDeps(config.BuiltinsRuntimeLibrary(toolchain))
1218 }
1219
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001220 if runtimeLibrary != "" && (toolchain.Bionic() || c.sanitize.Properties.UbsanRuntimeDep) {
1221 // UBSan is supported on non-bionic linux host builds as well
Jiyong Park379de2f2018-12-19 02:47:14 +09001222
1223 // Adding dependency to the runtime library. We are using *FarVariation*
1224 // because the runtime libraries themselves are not mutated by sanitizer
1225 // mutators and thus don't have sanitizer variants whereas this module
1226 // has been already mutated.
1227 //
1228 // Note that by adding dependency with {static|shared}DepTag, the lib is
1229 // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module
1230 if c.staticBinary() {
Colin Cross06c80eb2022-02-10 10:34:19 -08001231 addStaticDeps(runtimeLibrary)
1232 addStaticDeps(extraStaticDeps...)
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001233 } else if !c.static() && !c.Header() {
Colin Crosse0edaf92021-01-11 17:31:17 -08001234 // If we're using snapshots, redirect to snapshot whenever possible
1235 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1236 if lib, ok := snapshot.SharedLibs[runtimeLibrary]; ok {
1237 runtimeLibrary = lib
Inseob Kimeec88e12020-01-22 11:11:29 +09001238 }
Colin Crosse0edaf92021-01-11 17:31:17 -08001239
Cindy Zhou18417cb2020-12-10 07:12:38 -08001240 // Skip apex dependency check for sharedLibraryDependency
1241 // when sanitizer diags are enabled. Skipping the check will allow
1242 // building with diag libraries without having to list the
1243 // dependency in Apex's allowed_deps file.
1244 diagEnabled := len(diagSanitizers) > 0
Jiyong Park3b1746a2019-01-29 11:15:04 +09001245 // dynamic executable and shared libs get shared runtime libs
Cindy Zhou18417cb2020-12-10 07:12:38 -08001246 depTag := libraryDependencyTag{
1247 Kind: sharedLibraryDependency,
1248 Order: earlyLibraryDependency,
1249
1250 skipApexAllowedDependenciesCheck: diagEnabled,
1251 }
Colin Cross42507332020-08-21 16:15:23 -07001252 variations := append(mctx.Target().Variations(),
1253 blueprint.Variation{Mutator: "link", Variation: "shared"})
1254 if c.Device() {
1255 variations = append(variations, c.ImageVariation())
1256 }
Colin Cross06c80eb2022-02-10 10:34:19 -08001257 if c.UseSdk() {
1258 variations = append(variations,
1259 blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
1260 }
Ivan Lozanod67a6b02021-05-20 13:01:32 -04001261 AddSharedLibDependenciesWithVersions(mctx, c, variations, depTag, runtimeLibrary, "", true)
Jiyong Park379de2f2018-12-19 02:47:14 +09001262 }
1263 // static lib does not have dependency to the runtime library. The
1264 // dependency will be added to the executables or shared libs using
1265 // the static lib.
1266 }
1267 }
1268}
1269
1270type Sanitizeable interface {
1271 android.Module
Jiyong Park388ef3f2019-01-28 19:47:32 +09001272 IsSanitizerEnabled(ctx android.BaseModuleContext, sanitizerName string) bool
Jiyong Parkf97782b2019-02-13 20:28:58 +09001273 EnableSanitizer(sanitizerName string)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001274 AddSanitizerDependencies(ctx android.BottomUpMutatorContext, sanitizerName string)
Jiyong Park379de2f2018-12-19 02:47:14 +09001275}
1276
Ivan Lozanod7586b62021-04-01 09:49:36 -04001277func (c *Module) MinimalRuntimeDep() bool {
1278 return c.sanitize.Properties.MinimalRuntimeDep
1279}
1280
1281func (c *Module) UbsanRuntimeDep() bool {
1282 return c.sanitize.Properties.UbsanRuntimeDep
1283}
1284
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001285func (c *Module) SanitizePropDefined() bool {
1286 return c.sanitize != nil
1287}
1288
1289func (c *Module) IsSanitizerEnabled(t SanitizerType) bool {
1290 return c.sanitize.isSanitizerEnabled(t)
1291}
1292
1293func (c *Module) SanitizeDep() bool {
1294 return c.sanitize.Properties.SanitizeDep
1295}
1296
1297func (c *Module) StaticallyLinked() bool {
1298 return c.static()
1299}
1300
1301func (c *Module) SetInSanitizerDir() {
1302 if c.sanitize != nil {
1303 c.sanitize.Properties.InSanitizerDir = true
1304 }
1305}
1306
1307func (c *Module) SetSanitizer(t SanitizerType, b bool) {
1308 if c.sanitize != nil {
1309 c.sanitize.SetSanitizer(t, b)
1310 }
1311}
1312
1313func (c *Module) SetSanitizeDep(b bool) {
1314 if c.sanitize != nil {
1315 c.sanitize.Properties.SanitizeDep = b
1316 }
1317}
1318
1319var _ PlatformSanitizeable = (*Module)(nil)
1320
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001321// Create sanitized variants for modules that need them
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001322func sanitizerMutator(t SanitizerType) func(android.BottomUpMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -07001323 return func(mctx android.BottomUpMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001324 if c, ok := mctx.Module().(PlatformSanitizeable); ok && c.SanitizePropDefined() {
Ivan Lozano5482d6a2021-11-01 10:13:25 -04001325
1326 // Make sure we're not setting CFI to any value if it's not supported.
1327 cfiSupported := mctx.Module().(PlatformSanitizeable).SanitizerSupported(cfi)
1328
Liz Kammer187d5442021-06-25 14:50:12 -04001329 if c.Binary() && c.IsSanitizerEnabled(t) {
Jiyong Park82226632019-02-01 10:50:50 +09001330 modules := mctx.CreateVariations(t.variationName())
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001331 modules[0].(PlatformSanitizeable).SetSanitizer(t, true)
1332 } else if c.IsSanitizerEnabled(t) || c.SanitizeDep() {
1333 isSanitizerEnabled := c.IsSanitizerEnabled(t)
Colin Crossaf98f582021-05-12 17:27:32 -07001334 if c.StaticallyLinked() || c.Header() || t == Fuzzer {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001335 // Static and header libs are split into non-sanitized and sanitized variants.
1336 // Shared libs are not split. However, for asan and fuzzer, we split even for shared
1337 // libs because a library sanitized for asan/fuzzer can't be linked from a library
1338 // that isn't sanitized for asan/fuzzer.
1339 //
1340 // Note for defaultVariation: since we don't split for shared libs but for static/header
1341 // libs, it is possible for the sanitized variant of a static/header lib to depend
1342 // on non-sanitized variant of a shared lib. Such unfulfilled variation causes an
1343 // error when the module is split. defaultVariation is the name of the variation that
1344 // will be used when such a dangling dependency occurs during the split of the current
1345 // module. By setting it to the name of the sanitized variation, the dangling dependency
1346 // is redirected to the sanitized variant of the dependent module.
1347 defaultVariation := t.variationName()
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001348 // Not all PlatformSanitizeable modules support the CFI sanitizer
Jiyong Park1d1119f2019-07-29 21:27:18 +09001349 mctx.SetDefaultDependencyVariation(&defaultVariation)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001350
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001351 modules := mctx.CreateVariations("", t.variationName())
1352 modules[0].(PlatformSanitizeable).SetSanitizer(t, false)
1353 modules[1].(PlatformSanitizeable).SetSanitizer(t, true)
1354 modules[0].(PlatformSanitizeable).SetSanitizeDep(false)
1355 modules[1].(PlatformSanitizeable).SetSanitizeDep(false)
1356
1357 if mctx.Device() && t.incompatibleWithCfi() && cfiSupported {
Ivan Lozano4774a812020-03-10 16:23:57 -04001358 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1359 // are incompatible with cfi
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001360 modules[1].(PlatformSanitizeable).SetSanitizer(cfi, false)
Ivan Lozano4774a812020-03-10 16:23:57 -04001361 }
1362
Jiyong Park1d1119f2019-07-29 21:27:18 +09001363 // For cfi/scs/hwasan, we can export both sanitized and un-sanitized variants
1364 // to Make, because the sanitized version has a different suffix in name.
1365 // For other types of sanitizers, suppress the variation that is disabled.
Tri Vo6eafc362021-04-01 11:29:09 -07001366 if t != cfi && t != scs && t != Hwasan {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001367 if isSanitizerEnabled {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001368 modules[0].(PlatformSanitizeable).SetPreventInstall()
1369 modules[0].(PlatformSanitizeable).SetHideFromMake()
Jiyong Park1d1119f2019-07-29 21:27:18 +09001370 } else {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001371 modules[1].(PlatformSanitizeable).SetPreventInstall()
1372 modules[1].(PlatformSanitizeable).SetHideFromMake()
Jiyong Park1d1119f2019-07-29 21:27:18 +09001373 }
1374 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001375
Jiyong Park1d1119f2019-07-29 21:27:18 +09001376 // Export the static lib name to make
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001377 if c.StaticallyLinked() && c.ExportedToMake() {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001378 if t == cfi {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001379 cfiStaticLibs(mctx.Config()).add(c, c.Module().Name())
Tri Vo6eafc362021-04-01 11:29:09 -07001380 } else if t == Hwasan {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001381 hwasanStaticLibs(mctx.Config()).add(c, c.Module().Name())
Jiyong Park1d1119f2019-07-29 21:27:18 +09001382 }
1383 }
1384 } else {
1385 // Shared libs are not split. Only the sanitized variant is created.
1386 modules := mctx.CreateVariations(t.variationName())
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001387 modules[0].(PlatformSanitizeable).SetSanitizer(t, true)
1388 modules[0].(PlatformSanitizeable).SetSanitizeDep(false)
Vishwath Mohane7128792017-11-17 11:08:10 -08001389
Jiyong Park1d1119f2019-07-29 21:27:18 +09001390 // locate the asan libraries under /data/asan
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001391 if mctx.Device() && t == Asan && isSanitizerEnabled {
1392 modules[0].(PlatformSanitizeable).SetInSanitizerDir()
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001393 }
Ivan Lozano4774a812020-03-10 16:23:57 -04001394
Ivan Lozano5482d6a2021-11-01 10:13:25 -04001395 if mctx.Device() && t.incompatibleWithCfi() && cfiSupported {
Ivan Lozano4774a812020-03-10 16:23:57 -04001396 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1397 // are incompatible with cfi
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001398 modules[0].(PlatformSanitizeable).SetSanitizer(cfi, false)
Ivan Lozano4774a812020-03-10 16:23:57 -04001399 }
Vishwath Mohane21fe422017-11-01 19:42:45 -07001400 }
Colin Cross16b23492016-01-06 14:41:07 -08001401 }
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001402 c.SetSanitizeDep(false)
Jiyong Park82226632019-02-01 10:50:50 +09001403 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok && sanitizeable.IsSanitizerEnabled(mctx, t.name()) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001404 // APEX modules fall here
Jooyung Han8ce8db92020-05-15 19:05:05 +09001405 sanitizeable.AddSanitizerDependencies(mctx, t.name())
Jiyong Park82226632019-02-01 10:50:50 +09001406 mctx.CreateVariations(t.variationName())
Inseob Kimc42f2f22020-07-29 20:32:10 +09001407 } else if c, ok := mctx.Module().(*Module); ok {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001408 //TODO: When Rust modules have vendor support, enable this path for PlatformSanitizeable
1409
Inseob Kimc42f2f22020-07-29 20:32:10 +09001410 // Check if it's a snapshot module supporting sanitizer
1411 if s, ok := c.linker.(snapshotSanitizer); ok && s.isSanitizerEnabled(t) {
1412 // Set default variation as above.
1413 defaultVariation := t.variationName()
1414 mctx.SetDefaultDependencyVariation(&defaultVariation)
1415 modules := mctx.CreateVariations("", t.variationName())
1416 modules[0].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, false)
1417 modules[1].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, true)
1418
1419 // Export the static lib name to make
1420 if c.static() && c.ExportedToMake() {
1421 if t == cfi {
1422 // use BaseModuleName which is the name for Make.
1423 cfiStaticLibs(mctx.Config()).add(c, c.BaseModuleName())
1424 }
1425 }
1426 }
Colin Cross16b23492016-01-06 14:41:07 -08001427 }
1428 }
1429}
Vishwath Mohane7128792017-11-17 11:08:10 -08001430
Inseob Kim74d25562020-08-04 00:41:38 +09001431type sanitizerStaticLibsMap struct {
1432 // libsMap contains one list of modules per each image and each arch.
1433 // e.g. libs[vendor]["arm"] contains arm modules installed to vendor
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001434 libsMap map[ImageVariantType]map[string][]string
Inseob Kim74d25562020-08-04 00:41:38 +09001435 libsMapLock sync.Mutex
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001436 sanitizerType SanitizerType
Inseob Kim74d25562020-08-04 00:41:38 +09001437}
1438
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001439func newSanitizerStaticLibsMap(t SanitizerType) *sanitizerStaticLibsMap {
Inseob Kim74d25562020-08-04 00:41:38 +09001440 return &sanitizerStaticLibsMap{
1441 sanitizerType: t,
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001442 libsMap: make(map[ImageVariantType]map[string][]string),
Inseob Kim74d25562020-08-04 00:41:38 +09001443 }
1444}
1445
1446// Add the current module to sanitizer static libs maps
1447// Each module should pass its exported name as names of Make and Soong can differ.
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001448func (s *sanitizerStaticLibsMap) add(c LinkableInterface, name string) {
1449 image := GetImageVariantType(c)
1450 arch := c.Module().Target().Arch.ArchType.String()
Inseob Kim74d25562020-08-04 00:41:38 +09001451
1452 s.libsMapLock.Lock()
1453 defer s.libsMapLock.Unlock()
1454
1455 if _, ok := s.libsMap[image]; !ok {
1456 s.libsMap[image] = make(map[string][]string)
1457 }
1458
1459 s.libsMap[image][arch] = append(s.libsMap[image][arch], name)
1460}
1461
1462// Exports makefile variables in the following format:
1463// SOONG_{sanitizer}_{image}_{arch}_STATIC_LIBRARIES
1464// e.g. SOONG_cfi_core_x86_STATIC_LIBRARIES
1465// These are to be used by use_soong_sanitized_static_libraries.
1466// See build/make/core/binary.mk for more details.
1467func (s *sanitizerStaticLibsMap) exportToMake(ctx android.MakeVarsContext) {
1468 for _, image := range android.SortedStringKeys(s.libsMap) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001469 archMap := s.libsMap[ImageVariantType(image)]
Inseob Kim74d25562020-08-04 00:41:38 +09001470 for _, arch := range android.SortedStringKeys(archMap) {
1471 libs := archMap[arch]
1472 sort.Strings(libs)
1473
1474 key := fmt.Sprintf(
1475 "SOONG_%s_%s_%s_STATIC_LIBRARIES",
1476 s.sanitizerType.variationName(),
1477 image, // already upper
1478 arch)
1479
1480 ctx.Strict(key, strings.Join(libs, " "))
1481 }
1482 }
1483}
1484
Colin Cross571cccf2019-02-04 11:22:08 -08001485var cfiStaticLibsKey = android.NewOnceKey("cfiStaticLibs")
1486
Inseob Kim74d25562020-08-04 00:41:38 +09001487func cfiStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001488 return config.Once(cfiStaticLibsKey, func() interface{} {
Inseob Kim74d25562020-08-04 00:41:38 +09001489 return newSanitizerStaticLibsMap(cfi)
1490 }).(*sanitizerStaticLibsMap)
Vishwath Mohane7128792017-11-17 11:08:10 -08001491}
1492
Colin Cross571cccf2019-02-04 11:22:08 -08001493var hwasanStaticLibsKey = android.NewOnceKey("hwasanStaticLibs")
1494
Inseob Kim74d25562020-08-04 00:41:38 +09001495func hwasanStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001496 return config.Once(hwasanStaticLibsKey, func() interface{} {
Tri Vo6eafc362021-04-01 11:29:09 -07001497 return newSanitizerStaticLibsMap(Hwasan)
Inseob Kim74d25562020-08-04 00:41:38 +09001498 }).(*sanitizerStaticLibsMap)
Jiyong Park1d1119f2019-07-29 21:27:18 +09001499}
1500
Ivan Lozano30c5db22018-02-21 15:49:20 -08001501func enableMinimalRuntime(sanitize *sanitize) bool {
1502 if !Bool(sanitize.Properties.Sanitize.Address) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001503 !Bool(sanitize.Properties.Sanitize.Hwaddress) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001504 !Bool(sanitize.Properties.Sanitize.Fuzzer) &&
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001505
Ivan Lozano30c5db22018-02-21 15:49:20 -08001506 (Bool(sanitize.Properties.Sanitize.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001507 len(sanitize.Properties.Sanitize.Misc_undefined) > 0 ||
1508 Bool(sanitize.Properties.Sanitize.Undefined) ||
1509 Bool(sanitize.Properties.Sanitize.All_undefined)) &&
1510
Ivan Lozano30c5db22018-02-21 15:49:20 -08001511 !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
1512 Bool(sanitize.Properties.Sanitize.Diag.Cfi) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001513 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Ivan Lozano30c5db22018-02-21 15:49:20 -08001514 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) {
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001515
Ivan Lozano30c5db22018-02-21 15:49:20 -08001516 return true
1517 }
1518 return false
1519}
1520
Ivan Lozanod7586b62021-04-01 09:49:36 -04001521func (m *Module) UbsanRuntimeNeeded() bool {
1522 return enableUbsanRuntime(m.sanitize)
1523}
1524
1525func (m *Module) MinimalRuntimeNeeded() bool {
1526 return enableMinimalRuntime(m.sanitize)
1527}
1528
Inseob Kim8471cda2019-11-15 09:59:12 +09001529func enableUbsanRuntime(sanitize *sanitize) bool {
1530 return Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001531 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Inseob Kim8471cda2019-11-15 09:59:12 +09001532 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0
1533}
1534
Vishwath Mohane7128792017-11-17 11:08:10 -08001535func cfiMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001536 cfiStaticLibs(ctx.Config()).exportToMake(ctx)
Vishwath Mohane7128792017-11-17 11:08:10 -08001537}
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001538
1539func hwasanMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001540 hwasanStaticLibs(ctx.Config()).exportToMake(ctx)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001541}