blob: 3863c3a7c818d2224a0a6c1162ba1d90799c559e [file] [log] [blame]
Colin Cross16b23492016-01-06 14:41:07 -08001// Copyright 2016 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package cc
16
17import (
18 "fmt"
Jeff Gaston72765392017-11-28 16:37:53 -080019 "sort"
Colin Cross16b23492016-01-06 14:41:07 -080020 "strings"
Vishwath Mohane7128792017-11-17 11:08:10 -080021 "sync"
Colin Cross16b23492016-01-06 14:41:07 -080022
Colin Cross6b753602018-06-21 13:03:07 -070023 "github.com/google/blueprint"
Liz Kammerb2fc4702021-06-25 14:53:40 -040024 "github.com/google/blueprint/proptools"
Colin Cross6b753602018-06-21 13:03:07 -070025
Colin Cross635c3b02016-05-18 15:37:25 -070026 "android/soong/android"
Evgenii Stepanovaf36db12016-08-15 14:18:24 -070027 "android/soong/cc/config"
Kiyoung Kim48f37782021-07-07 12:42:39 +090028 "android/soong/snapshot"
Colin Cross16b23492016-01-06 14:41:07 -080029)
30
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070031var (
32 // Any C flags added by sanitizer which libTooling tools may not
33 // understand also need to be added to ClangLibToolingUnknownCflags in
34 // cc/config/clang.go
Vishwath Mohanf3918d32017-02-14 07:59:33 -080035
Yi Kong20233a42019-08-21 01:38:40 -070036 asanCflags = []string{
37 "-fno-omit-frame-pointer",
38 "-fno-experimental-new-pass-manager",
39 }
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070040 asanLdflags = []string{"-Wl,-u,__asan_preinit"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070041
Peter Collingbourne967511a2019-03-19 21:39:54 -070042 hwasanCflags = []string{"-fno-omit-frame-pointer", "-Wno-frame-larger-than=",
Evgenii Stepanov96fa3dd2020-03-27 19:38:42 +000043 "-fsanitize-hwaddress-abi=platform",
44 "-fno-experimental-new-pass-manager",
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080045 // The following improves debug location information
46 // availability at the cost of its accuracy. It increases
47 // the likelihood of a stack variable's frame offset
48 // to be recorded in the debug info, which is important
49 // for the quality of hwasan reports. The downside is a
50 // higher number of "optimized out" stack variables.
51 // b/112437883.
52 "-mllvm", "-instcombine-lower-dbg-declare=0",
Mitch Phillipsb1c574f2020-06-22 13:28:23 -070053 // TODO(b/159343917): HWASan and GlobalISel don't play nicely, and
54 // GlobalISel is the default at -O0 on aarch64.
55 "-mllvm", "--aarch64-enable-global-isel-at-O=-1",
56 "-mllvm", "-fast-isel=false",
Evgenii Stepanov64bee4d2019-11-22 18:37:10 -080057 }
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -070058
Vishwath Mohanb743e9c2017-11-01 09:20:21 +000059 cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso",
Pirama Arumuga Nainareb8d4032020-07-27 11:22:35 -070060 "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blocklist.txt"}
Evgenii Stepanovdbf1d4f2018-08-31 12:54:33 -070061 // -flto and -fvisibility are required by clang when -fsanitize=cfi is
62 // used, but have no effect on assembly files
63 cfiAsflags = []string{"-flto", "-fvisibility=default"}
Jayant Chowdhary9677e8c2017-06-15 14:45:18 -070064 cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi",
Pirama Arumuga Nainarbdb17f02017-08-28 21:50:17 -070065 "-Wl,-plugin-opt,O1"}
Inseob Kim74d25562020-08-04 00:41:38 +090066 cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070067
Pirama Arumuga Nainareb8d4032020-07-27 11:22:35 -070068 intOverflowCflags = []string{"-fsanitize-blacklist=build/soong/cc/config/integer_overflow_blocklist.txt"}
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080069
Peter Collingbournebd19db02019-03-06 10:38:48 -080070 minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined",
Ivan Lozanoae6ae1d2018-10-08 09:29:39 -070071 "-fno-sanitize-recover=integer,undefined"}
Evgenii Stepanov2c6484e2019-05-15 12:49:54 -070072 hwasanGlobalOptions = []string{"heap_history_size=1023", "stack_history_size=512",
73 "export_memory_stats=0", "max_malloc_fill_size=0"}
Dan Willemsencbceaab2016-10-13 16:44:07 -070074)
75
Ivan Lozano3968d8f2020-12-14 11:27:52 -050076type SanitizerType int
Colin Cross16b23492016-01-06 14:41:07 -080077
Colin Cross16b23492016-01-06 14:41:07 -080078const (
Ivan Lozano3968d8f2020-12-14 11:27:52 -050079 Asan SanitizerType = iota + 1
Tri Vo6eafc362021-04-01 11:29:09 -070080 Hwasan
Colin Cross16b23492016-01-06 14:41:07 -080081 tsan
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -070082 intOverflow
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -080083 scs
Ivan Lozano3968d8f2020-12-14 11:27:52 -050084 Fuzzer
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -070085 memtag_heap
Liz Kammer75db9312021-07-07 16:41:50 -040086 cfi // cfi is last to prevent it running before incompatible mutators
Colin Cross16b23492016-01-06 14:41:07 -080087)
88
Liz Kammer75db9312021-07-07 16:41:50 -040089var Sanitizers = []SanitizerType{
90 Asan,
91 Hwasan,
92 tsan,
93 intOverflow,
94 scs,
95 Fuzzer,
96 memtag_heap,
97 cfi, // cfi is last to prevent it running before incompatible mutators
98}
99
Jiyong Park82226632019-02-01 10:50:50 +0900100// Name of the sanitizer variation for this sanitizer type
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500101func (t SanitizerType) variationName() string {
Colin Cross16b23492016-01-06 14:41:07 -0800102 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500103 case Asan:
Colin Cross16b23492016-01-06 14:41:07 -0800104 return "asan"
Tri Vo6eafc362021-04-01 11:29:09 -0700105 case Hwasan:
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700106 return "hwasan"
Colin Cross16b23492016-01-06 14:41:07 -0800107 case tsan:
108 return "tsan"
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700109 case intOverflow:
110 return "intOverflow"
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000111 case cfi:
112 return "cfi"
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800113 case scs:
114 return "scs"
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700115 case memtag_heap:
116 return "memtag_heap"
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500117 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700118 return "fuzzer"
Colin Cross16b23492016-01-06 14:41:07 -0800119 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500120 panic(fmt.Errorf("unknown SanitizerType %d", t))
Colin Cross16b23492016-01-06 14:41:07 -0800121 }
122}
123
Jiyong Park82226632019-02-01 10:50:50 +0900124// This is the sanitizer names in SANITIZE_[TARGET|HOST]
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500125func (t SanitizerType) name() string {
Jiyong Park82226632019-02-01 10:50:50 +0900126 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500127 case Asan:
Jiyong Park82226632019-02-01 10:50:50 +0900128 return "address"
Tri Vo6eafc362021-04-01 11:29:09 -0700129 case Hwasan:
Jiyong Park82226632019-02-01 10:50:50 +0900130 return "hwaddress"
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700131 case memtag_heap:
132 return "memtag_heap"
Jiyong Park82226632019-02-01 10:50:50 +0900133 case tsan:
134 return "thread"
135 case intOverflow:
136 return "integer_overflow"
137 case cfi:
138 return "cfi"
139 case scs:
140 return "shadow-call-stack"
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500141 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700142 return "fuzzer"
Jiyong Park82226632019-02-01 10:50:50 +0900143 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500144 panic(fmt.Errorf("unknown SanitizerType %d", t))
Jiyong Park82226632019-02-01 10:50:50 +0900145 }
146}
147
Liz Kammer75db9312021-07-07 16:41:50 -0400148func (t SanitizerType) registerMutators(ctx android.RegisterMutatorsContext) {
149 switch t {
150 case Asan, Hwasan, Fuzzer, scs, tsan, cfi:
151 ctx.TopDown(t.variationName()+"_deps", sanitizerDepsMutator(t))
152 ctx.BottomUp(t.variationName(), sanitizerMutator(t))
153 case memtag_heap, intOverflow:
154 // do nothing
155 default:
156 panic(fmt.Errorf("unknown SanitizerType %d", t))
157 }
158}
159
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500160func (*Module) SanitizerSupported(t SanitizerType) bool {
161 switch t {
162 case Asan:
163 return true
Tri Vo6eafc362021-04-01 11:29:09 -0700164 case Hwasan:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500165 return true
166 case tsan:
167 return true
168 case intOverflow:
169 return true
170 case cfi:
171 return true
172 case scs:
173 return true
174 case Fuzzer:
175 return true
176 default:
177 return false
178 }
179}
180
181// incompatibleWithCfi returns true if a sanitizer is incompatible with CFI.
182func (t SanitizerType) incompatibleWithCfi() bool {
Tri Vo6eafc362021-04-01 11:29:09 -0700183 return t == Asan || t == Fuzzer || t == Hwasan
Jiyong Park1d1119f2019-07-29 21:27:18 +0900184}
185
Martin Stjernholmb0249572020-09-15 02:32:35 +0100186type SanitizeUserProps struct {
Liz Kammer75b9b402021-06-25 15:19:27 -0400187 // Prevent use of any sanitizers on this module
Martin Stjernholmb0249572020-09-15 02:32:35 +0100188 Never *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800189
Liz Kammer75b9b402021-06-25 15:19:27 -0400190 // ASan (Address sanitizer), incompatible with static binaries.
191 // Always runs in a diagnostic mode.
192 // Use of address sanitizer disables cfi sanitizer.
193 // Hwaddress sanitizer takes precedence over this sanitizer.
194 Address *bool `android:"arch_variant"`
195 // TSan (Thread sanitizer), incompatible with static binaries and 32 bit architectures.
196 // Always runs in a diagnostic mode.
197 // Use of thread sanitizer disables cfi and scudo sanitizers.
198 // Hwaddress sanitizer takes precedence over this sanitizer.
199 Thread *bool `android:"arch_variant"`
200 // HWASan (Hardware Address sanitizer).
201 // Use of hwasan sanitizer disables cfi, address, thread, and scudo sanitizers.
Martin Stjernholmb0249572020-09-15 02:32:35 +0100202 Hwaddress *bool `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800203
Liz Kammer75b9b402021-06-25 15:19:27 -0400204 // Undefined behavior sanitizer
205 All_undefined *bool `android:"arch_variant"`
206 // Subset of undefined behavior sanitizer
207 Undefined *bool `android:"arch_variant"`
208 // List of specific undefined behavior sanitizers to enable
209 Misc_undefined []string `android:"arch_variant"`
210 // Fuzzer, incompatible with static binaries.
211 Fuzzer *bool `android:"arch_variant"`
212 // safe-stack sanitizer, incompatible with 32-bit architectures.
213 Safestack *bool `android:"arch_variant"`
214 // cfi sanitizer, incompatible with asan, hwasan, fuzzer, or Darwin
215 Cfi *bool `android:"arch_variant"`
216 // signed/unsigned integer overflow sanitizer, incompatible with Darwin.
217 Integer_overflow *bool `android:"arch_variant"`
218 // scudo sanitizer, incompatible with asan, hwasan, tsan
219 // This should not be used in Android 11+ : https://source.android.com/devices/tech/debug/scudo
220 // deprecated
221 Scudo *bool `android:"arch_variant"`
222 // shadow-call-stack sanitizer, only available on arm64
223 Scs *bool `android:"arch_variant"`
224 // Memory-tagging, only available on arm64
225 // if diag.memtag unset or false, enables async memory tagging
226 Memtag_heap *bool `android:"arch_variant"`
Martin Stjernholmb0249572020-09-15 02:32:35 +0100227
228 // A modifier for ASAN and HWASAN for write only instrumentation
229 Writeonly *bool `android:"arch_variant"`
230
231 // Sanitizers to run in the diagnostic mode (as opposed to the release mode).
232 // Replaces abort() on error with a human-readable error message.
233 // Address and Thread sanitizers always run in diagnostic mode.
234 Diag struct {
Liz Kammer75b9b402021-06-25 15:19:27 -0400235 // Undefined behavior sanitizer, diagnostic mode
236 Undefined *bool `android:"arch_variant"`
237 // cfi sanitizer, diagnostic mode, incompatible with asan, hwasan, fuzzer, or Darwin
238 Cfi *bool `android:"arch_variant"`
239 // signed/unsigned integer overflow sanitizer, diagnostic mode, incompatible with Darwin.
240 Integer_overflow *bool `android:"arch_variant"`
241 // Memory-tagging, only available on arm64
242 // requires sanitizer.memtag: true
243 // if set, enables sync memory tagging
244 Memtag_heap *bool `android:"arch_variant"`
245 // List of specific undefined behavior sanitizers to enable in diagnostic mode
246 Misc_undefined []string `android:"arch_variant"`
247 // List of sanitizers to pass to -fno-sanitize-recover
248 // results in only the first detected error for these sanitizers being reported and program then
249 // exits with a non-zero exit code.
250 No_recover []string `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800251 } `android:"arch_variant"`
Colin Cross16b23492016-01-06 14:41:07 -0800252
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800253 // Sanitizers to run with flag configuration specified
254 Config struct {
255 // Enables CFI support flags for assembly-heavy libraries
256 Cfi_assembly_support *bool `android:"arch_variant"`
Cindy Zhoud3fe4922020-12-01 11:14:30 -0800257 } `android:"arch_variant"`
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800258
Liz Kammer75b9b402021-06-25 15:19:27 -0400259 // List of sanitizers to pass to -fsanitize-recover
260 // allows execution to continue for these sanitizers to detect multiple errors rather than only
261 // the first one
Martin Stjernholmb0249572020-09-15 02:32:35 +0100262 Recover []string
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000263
Martin Stjernholmb0249572020-09-15 02:32:35 +0100264 // value to pass to -fsanitize-blacklist
265 Blocklist *string
266}
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700267
Martin Stjernholmb0249572020-09-15 02:32:35 +0100268type SanitizeProperties struct {
Liz Kammer75b9b402021-06-25 15:19:27 -0400269 // Sanitizers are not supported for Fuchsia.
Martin Stjernholmb0249572020-09-15 02:32:35 +0100270 Sanitize SanitizeUserProps `android:"arch_variant"`
271 SanitizerEnabled bool `blueprint:"mutated"`
272 SanitizeDep bool `blueprint:"mutated"`
273 MinimalRuntimeDep bool `blueprint:"mutated"`
274 BuiltinsDep bool `blueprint:"mutated"`
275 UbsanRuntimeDep bool `blueprint:"mutated"`
276 InSanitizerDir bool `blueprint:"mutated"`
277 Sanitizers []string `blueprint:"mutated"`
278 DiagSanitizers []string `blueprint:"mutated"`
Colin Cross16b23492016-01-06 14:41:07 -0800279}
280
281type sanitize struct {
282 Properties SanitizeProperties
283}
284
Cindy Zhou18417cb2020-12-10 07:12:38 -0800285// Mark this tag with a check to see if apex dependency check should be skipped
286func (t libraryDependencyTag) SkipApexAllowedDependenciesCheck() bool {
287 return t.skipApexAllowedDependenciesCheck
288}
289
290var _ android.SkipApexAllowedDependenciesCheck = (*libraryDependencyTag)(nil)
291
Vishwath Mohane7128792017-11-17 11:08:10 -0800292func init() {
293 android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700294 android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider)
Vishwath Mohane7128792017-11-17 11:08:10 -0800295}
296
Colin Cross16b23492016-01-06 14:41:07 -0800297func (sanitize *sanitize) props() []interface{} {
298 return []interface{}{&sanitize.Properties}
299}
300
301func (sanitize *sanitize) begin(ctx BaseModuleContext) {
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700302 s := &sanitize.Properties.Sanitize
303
Colin Cross16b23492016-01-06 14:41:07 -0800304 // Don't apply sanitizers to NDK code.
Jeff Gastonaf3cc2d2017-09-27 17:01:44 -0700305 if ctx.useSdk() {
Nan Zhang0007d812017-11-07 10:57:05 -0800306 s.Never = BoolPtr(true)
Colin Cross16b23492016-01-06 14:41:07 -0800307 }
308
Doug Hornc32c6b02019-01-17 14:44:05 -0800309 // Sanitizers do not work on Fuchsia yet.
310 if ctx.Fuchsia() {
311 s.Never = BoolPtr(true)
312 }
313
Colin Cross16b23492016-01-06 14:41:07 -0800314 // Never always wins.
Nan Zhang0007d812017-11-07 10:57:05 -0800315 if Bool(s.Never) {
Colin Cross16b23492016-01-06 14:41:07 -0800316 return
317 }
318
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800319 // cc_test targets default to SYNC MemTag unless explicitly set to ASYNC (via diag: {memtag_heap}).
Liz Kammer7b920b42021-06-22 16:57:27 -0400320 if ctx.testBinary() {
321 if s.Memtag_heap == nil {
322 s.Memtag_heap = proptools.BoolPtr(true)
323 }
324 if s.Diag.Memtag_heap == nil {
325 s.Diag.Memtag_heap = proptools.BoolPtr(true)
326 }
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800327 }
328
Colin Cross16b23492016-01-06 14:41:07 -0800329 var globalSanitizers []string
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700330 var globalSanitizersDiag []string
331
Dan Willemsen8536d6b2018-10-07 20:54:34 -0700332 if ctx.Host() {
333 if !ctx.Windows() {
334 globalSanitizers = ctx.Config().SanitizeHost()
335 }
336 } else {
337 arches := ctx.Config().SanitizeDeviceArch()
338 if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) {
339 globalSanitizers = ctx.Config().SanitizeDevice()
340 globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag()
Colin Cross16b23492016-01-06 14:41:07 -0800341 }
342 }
343
Colin Cross16b23492016-01-06 14:41:07 -0800344 if len(globalSanitizers) > 0 {
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000345 var found bool
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700346 if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400347 s.All_undefined = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000348 }
Colin Cross16b23492016-01-06 14:41:07 -0800349
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700350 if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400351 s.Undefined = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000352 }
353
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700354 if found, globalSanitizers = removeFromList("address", globalSanitizers); found && s.Address == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400355 s.Address = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000356 }
357
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700358 if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400359 s.Thread = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000360 }
361
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700362 if found, globalSanitizers = removeFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400363 s.Fuzzer = proptools.BoolPtr(true)
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700364 }
365
366 if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400367 s.Safestack = proptools.BoolPtr(true)
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000368 }
369
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700370 if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil {
Colin Cross6510f912017-11-29 00:27:14 -0800371 if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400372 s.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700373 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700374 }
375
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700376 // Global integer_overflow builds do not support static libraries.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700377 if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil {
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700378 if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400379 s.Integer_overflow = proptools.BoolPtr(true)
Ivan Lozano5f595532017-07-13 14:46:05 -0700380 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700381 }
382
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700383 if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400384 s.Scudo = proptools.BoolPtr(true)
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700385 }
386
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700387 if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400388 s.Hwaddress = proptools.BoolPtr(true)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700389 }
390
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000391 if found, globalSanitizers = removeFromList("writeonly", globalSanitizers); found && s.Writeonly == nil {
392 // Hwaddress and Address are set before, so we can check them here
393 // If they aren't explicitly set in the blueprint/SANITIZE_(HOST|TARGET), they would be nil instead of false
394 if s.Address == nil && s.Hwaddress == nil {
395 ctx.ModuleErrorf("writeonly modifier cannot be used without 'address' or 'hwaddress'")
396 }
Liz Kammerb2fc4702021-06-25 14:53:40 -0400397 s.Writeonly = proptools.BoolPtr(true)
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000398 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700399 if found, globalSanitizers = removeFromList("memtag_heap", globalSanitizers); found && s.Memtag_heap == nil {
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800400 if !ctx.Config().MemtagHeapDisabledForPath(ctx.ModuleDir()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400401 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800402 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700403 }
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000404
Evgenii Stepanov05bafd32016-07-07 17:38:41 +0000405 if len(globalSanitizers) > 0 {
406 ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0])
407 }
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700408
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700409 // Global integer_overflow builds do not support static library diagnostics.
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700410 if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found &&
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700411 s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400412 s.Diag.Integer_overflow = proptools.BoolPtr(true)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700413 }
414
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700415 if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found &&
416 s.Diag.Cfi == nil && Bool(s.Cfi) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400417 s.Diag.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700418 }
419
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800420 if found, globalSanitizersDiag = removeFromList("memtag_heap", globalSanitizersDiag); found &&
421 s.Diag.Memtag_heap == nil && Bool(s.Memtag_heap) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400422 s.Diag.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800423 }
424
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700425 if len(globalSanitizersDiag) > 0 {
426 ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0])
427 }
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700428 }
Colin Cross3c344ef2016-07-18 15:44:56 -0700429
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800430 // Enable Memtag for all components in the include paths (for Aarch64 only)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800431 if ctx.Arch().ArchType == android.Arm64 {
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800432 if ctx.Config().MemtagHeapSyncEnabledForPath(ctx.ModuleDir()) {
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800433 if s.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400434 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800435 }
436 if s.Diag.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400437 s.Diag.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800438 }
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800439 } else if ctx.Config().MemtagHeapAsyncEnabledForPath(ctx.ModuleDir()) {
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800440 if s.Memtag_heap == nil {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400441 s.Memtag_heap = proptools.BoolPtr(true)
Evgenii Stepanov04896ca2021-01-12 18:28:33 -0800442 }
Evgenii Stepanov4beaa0c2021-01-05 16:41:26 -0800443 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700444 }
445
Vishwath Mohan1c54f662018-05-24 18:36:18 -0700446 // Enable CFI for all components in the include paths (for Aarch64 only)
447 if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && ctx.Arch().ArchType == android.Arm64 {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400448 s.Cfi = proptools.BoolPtr(true)
Vishwath Mohan3af8ee02018-03-30 02:55:23 +0000449 if inList("cfi", ctx.Config().SanitizeDeviceDiag()) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400450 s.Diag.Cfi = proptools.BoolPtr(true)
Vishwath Mohan1fa3ac52017-10-31 02:26:14 -0700451 }
452 }
453
Elliott Hughesda3a0712020-03-06 16:55:28 -0800454 // Is CFI actually enabled?
455 if !ctx.Config().EnableCFI() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400456 s.Cfi = nil
457 s.Diag.Cfi = nil
Vishwath Mohan1b017a72017-01-19 13:54:55 -0800458 }
459
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700460 // HWASan requires AArch64 hardware feature (top-byte-ignore).
461 if ctx.Arch().ArchType != android.Arm64 {
462 s.Hwaddress = nil
463 }
464
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800465 // SCS is only implemented on AArch64.
Peter Collingbournebd19db02019-03-06 10:38:48 -0800466 if ctx.Arch().ArchType != android.Arm64 {
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800467 s.Scs = nil
468 }
469
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700470 // memtag_heap is only implemented on AArch64.
471 if ctx.Arch().ArchType != android.Arm64 {
472 s.Memtag_heap = nil
473 }
474
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700475 // Also disable CFI if ASAN is enabled.
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700476 if Bool(s.Address) || Bool(s.Hwaddress) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400477 s.Cfi = nil
478 s.Diag.Cfi = nil
Vishwath Mohan8f4fdd82017-04-20 07:42:52 -0700479 }
480
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500481 // Disable sanitizers that depend on the UBSan runtime for windows/darwin builds.
482 if !ctx.Os().Linux() {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400483 s.Cfi = nil
484 s.Diag.Cfi = nil
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700485 s.Misc_undefined = nil
486 s.Undefined = nil
487 s.All_undefined = nil
488 s.Integer_overflow = nil
Vishwath Mohane7128792017-11-17 11:08:10 -0800489 }
490
Vishwath Mohan9ccbba02018-05-28 13:54:48 -0700491 // Also disable CFI for VNDK variants of components
492 if ctx.isVndk() && ctx.useVndk() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900493 if ctx.static() {
494 // Cfi variant for static vndk should be captured as vendor snapshot,
495 // so don't strictly disable Cfi.
496 s.Cfi = nil
497 s.Diag.Cfi = nil
498 } else {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400499 s.Cfi = nil
500 s.Diag.Cfi = nil
Inseob Kimc42f2f22020-07-29 20:32:10 +0900501 }
Inseob Kimeec88e12020-01-22 11:11:29 +0900502 }
503
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700504 // HWASan ramdisk (which is built from recovery) goes over some bootloader limit.
Yifan Hong60e0cfb2020-10-21 15:17:56 -0700505 // Keep libc instrumented so that ramdisk / vendor_ramdisk / recovery can run hwasan-instrumented code if necessary.
506 if (ctx.inRamdisk() || ctx.inVendorRamdisk() || ctx.inRecovery()) && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") {
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700507 s.Hwaddress = nil
508 }
509
Colin Cross3c344ef2016-07-18 15:44:56 -0700510 if ctx.staticBinary() {
511 s.Address = nil
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700512 s.Fuzzer = nil
Colin Cross3c344ef2016-07-18 15:44:56 -0700513 s.Thread = nil
Colin Cross16b23492016-01-06 14:41:07 -0800514 }
515
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700516 if Bool(s.All_undefined) {
517 s.Undefined = nil
518 }
519
Evgenii Stepanov0a8a0d02016-05-12 13:54:53 -0700520 if !ctx.toolchain().Is64Bit() {
521 // TSAN and SafeStack are not supported on 32-bit architectures
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700522 s.Thread = nil
523 s.Safestack = nil
Colin Cross16b23492016-01-06 14:41:07 -0800524 // TODO(ccross): error for compile_multilib = "32"?
525 }
526
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800527 if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) ||
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700528 Bool(s.Fuzzer) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 ||
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700529 Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs) || Bool(s.Memtag_heap)) {
Colin Cross3c344ef2016-07-18 15:44:56 -0700530 sanitize.Properties.SanitizerEnabled = true
531 }
532
Kostya Kortchinskyd5275c82019-02-01 08:42:56 -0800533 // Disable Scudo if ASan or TSan is enabled, or if it's disabled globally.
534 if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) || ctx.Config().DisableScudo() {
Kostya Kortchinskyd18ae5c2018-06-12 14:46:54 -0700535 s.Scudo = nil
536 }
537
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700538 if Bool(s.Hwaddress) {
539 s.Address = nil
540 s.Thread = nil
Evgenii Stepanovb15a5642021-06-23 12:30:55 -0700541 // Disable ubsan diagnosic as a workaround for a compiler bug.
542 // TODO(b/191808836): re-enable.
543 s.Diag.Undefined = nil
544 s.Diag.Integer_overflow = nil
545 s.Diag.Misc_undefined = nil
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700546 }
547
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700548 // TODO(b/131771163): CFI transiently depends on LTO, and thus Fuzzer is
549 // mutually incompatible.
550 if Bool(s.Fuzzer) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400551 s.Cfi = nil
Colin Cross16b23492016-01-06 14:41:07 -0800552 }
553}
554
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800555func toDisableImplicitIntegerChange(flags []string) bool {
556 // Returns true if any flag is fsanitize*integer, and there is
557 // no explicit flag about sanitize=implicit-integer-sign-change.
558 for _, f := range flags {
559 if strings.Contains(f, "sanitize=implicit-integer-sign-change") {
560 return false
561 }
562 }
563 for _, f := range flags {
564 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
565 return true
566 }
567 }
568 return false
569}
570
Yabin Cuidb7dda82020-11-30 15:47:45 -0800571func toDisableUnsignedShiftBaseChange(flags []string) bool {
572 // Returns true if any flag is fsanitize*integer, and there is
573 // no explicit flag about sanitize=unsigned-shift-base.
574 for _, f := range flags {
575 if strings.Contains(f, "sanitize=unsigned-shift-base") {
576 return false
577 }
578 }
579 for _, f := range flags {
580 if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") {
581 return true
582 }
583 }
584 return false
585}
586
Colin Cross16b23492016-01-06 14:41:07 -0800587func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags {
Ivan Lozano59fdea22018-05-10 14:17:22 -0700588 minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a"
589 minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500590 builtinsRuntimeLib := config.BuiltinsRuntimeLibrary(ctx.toolchain()) + ".a"
591 builtinsRuntimePath := "${config.ClangAsanLibDir}/" + builtinsRuntimeLib
Ivan Lozano30c5db22018-02-21 15:49:20 -0800592
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500593 if sanitize.Properties.MinimalRuntimeDep {
Colin Cross4af21ed2019-11-04 09:37:55 -0800594 flags.Local.LdFlags = append(flags.Local.LdFlags,
595 minimalRuntimePath,
596 "-Wl,--exclude-libs,"+minimalRuntimeLib)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800597 }
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500598
599 if sanitize.Properties.BuiltinsDep {
600 flags.libFlags = append([]string{builtinsRuntimePath}, flags.libFlags...)
601 }
602
Ivan Lozanoa9255a82018-03-13 10:41:07 -0700603 if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep {
Colin Cross16b23492016-01-06 14:41:07 -0800604 return flags
605 }
606
Evgenii Stepanovfcfe56d2016-07-07 10:54:07 -0700607 if Bool(sanitize.Properties.Sanitize.Address) {
Colin Cross635c3b02016-05-18 15:37:25 -0700608 if ctx.Arch().ArchType == android.Arm {
Colin Cross16b23492016-01-06 14:41:07 -0800609 // Frame pointer based unwinder in ASan requires ARM frame setup.
610 // TODO: put in flags?
611 flags.RequiredInstructionSet = "arm"
612 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800613 flags.Local.CFlags = append(flags.Local.CFlags, asanCflags...)
614 flags.Local.LdFlags = append(flags.Local.LdFlags, asanLdflags...)
Colin Cross16b23492016-01-06 14:41:07 -0800615
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000616 if Bool(sanitize.Properties.Sanitize.Writeonly) {
617 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-instrument-reads=0")
618 }
619
Colin Cross16b23492016-01-06 14:41:07 -0800620 if ctx.Host() {
621 // -nodefaultlibs (provided with libc++) prevents the driver from linking
622 // libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Colin Cross4af21ed2019-11-04 09:37:55 -0800623 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--no-as-needed")
Colin Cross16b23492016-01-06 14:41:07 -0800624 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800625 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-asan-globals=0")
Jiyong Parka2aca282019-02-02 13:13:38 +0900626 if ctx.bootstrap() {
627 flags.DynamicLinker = "/system/bin/bootstrap/linker_asan"
628 } else {
629 flags.DynamicLinker = "/system/bin/linker_asan"
630 }
Colin Cross16b23492016-01-06 14:41:07 -0800631 if flags.Toolchain.Is64Bit() {
632 flags.DynamicLinker += "64"
633 }
634 }
Colin Cross16b23492016-01-06 14:41:07 -0800635 }
636
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700637 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800638 flags.Local.CFlags = append(flags.Local.CFlags, hwasanCflags...)
Jasraj Bedibb4511d2020-07-23 22:58:17 +0000639 if Bool(sanitize.Properties.Sanitize.Writeonly) {
640 flags.Local.CFlags = append(flags.Local.CFlags, "-mllvm", "-hwasan-instrument-reads=0")
641 }
Yabin Cui6be405e2017-10-19 15:52:11 -0700642 }
643
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700644 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800645 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize=fuzzer-no-link")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700646
647 // TODO(b/131771163): LTO and Fuzzer support is mutually incompatible.
Colin Cross4af21ed2019-11-04 09:37:55 -0800648 _, flags.Local.LdFlags = removeFromList("-flto", flags.Local.LdFlags)
649 _, flags.Local.CFlags = removeFromList("-flto", flags.Local.CFlags)
650 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-lto")
651 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-lto")
Mitch Phillips74384752019-06-17 10:33:52 -0700652
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700653 // TODO(b/142430592): Upstream linker scripts for sanitizer runtime libraries
654 // discard the sancov_lowest_stack symbol, because it's emulated TLS (and thus
655 // doesn't match the linker script due to the "__emutls_v." prefix).
Colin Cross4af21ed2019-11-04 09:37:55 -0800656 flags.Local.LdFlags = append(flags.Local.LdFlags, "-fno-sanitize-coverage=stack-depth")
657 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-coverage=stack-depth")
Mitch Phillipsb8e593d2019-10-09 17:18:59 -0700658
Mitch Phillips74384752019-06-17 10:33:52 -0700659 // TODO(b/133876586): Experimental PM breaks sanitizer coverage.
Colin Cross4af21ed2019-11-04 09:37:55 -0800660 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-experimental-new-pass-manager")
Mitch Phillipsb9b3e792019-08-28 12:41:07 -0700661
662 // Disable fortify for fuzzing builds. Generally, we'll be building with
663 // UBSan or ASan here and the fortify checks pollute the stack traces.
Colin Cross4af21ed2019-11-04 09:37:55 -0800664 flags.Local.CFlags = append(flags.Local.CFlags, "-U_FORTIFY_SOURCE")
Mitch Phillips734b4cb2019-12-10 08:44:52 -0800665
666 // Build fuzzer-sanitized libraries with an $ORIGIN DT_RUNPATH. Android's
667 // linker uses DT_RUNPATH, not DT_RPATH. When we deploy cc_fuzz targets and
668 // their libraries to /data/fuzz/<arch>/lib, any transient shared library gets
669 // the DT_RUNPATH from the shared library above it, and not the executable,
670 // meaning that the lookup falls back to the system. Adding the $ORIGIN to the
671 // DT_RUNPATH here means that transient shared libraries can be found
672 // colocated with their parents.
673 flags.Local.LdFlags = append(flags.Local.LdFlags, `-Wl,-rpath,\$$ORIGIN`)
Colin Cross16b23492016-01-06 14:41:07 -0800674 }
675
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700676 if Bool(sanitize.Properties.Sanitize.Cfi) {
Evgenii Stepanov7ebf9fa2017-01-20 14:13:06 -0800677 if ctx.Arch().ArchType == android.Arm {
678 // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up
679 // to do this on a function basis, so force Thumb on the entire module.
680 flags.RequiredInstructionSet = "thumb"
681 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000682
Colin Cross4af21ed2019-11-04 09:37:55 -0800683 flags.Local.CFlags = append(flags.Local.CFlags, cfiCflags...)
684 flags.Local.AsFlags = append(flags.Local.AsFlags, cfiAsflags...)
Cindy Zhou8cd45de2020-11-16 08:41:00 -0800685 if Bool(sanitize.Properties.Sanitize.Config.Cfi_assembly_support) {
686 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-cfi-canonical-jump-tables")
687 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000688 // Only append the default visibility flag if -fvisibility has not already been set
689 // to hidden.
Colin Cross4af21ed2019-11-04 09:37:55 -0800690 if !inList("-fvisibility=hidden", flags.Local.CFlags) {
691 flags.Local.CFlags = append(flags.Local.CFlags, "-fvisibility=default")
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000692 }
Colin Cross4af21ed2019-11-04 09:37:55 -0800693 flags.Local.LdFlags = append(flags.Local.LdFlags, cfiLdflags...)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000694
695 if ctx.staticBinary() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800696 _, flags.Local.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.CFlags)
697 _, flags.Local.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.Local.LdFlags)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000698 }
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700699 }
700
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700701 if Bool(sanitize.Properties.Sanitize.Integer_overflow) {
Colin Cross4af21ed2019-11-04 09:37:55 -0800702 flags.Local.CFlags = append(flags.Local.CFlags, intOverflowCflags...)
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700703 }
704
Jiyong Park379de2f2018-12-19 02:47:14 +0900705 if len(sanitize.Properties.Sanitizers) > 0 {
706 sanitizeArg := "-fsanitize=" + strings.Join(sanitize.Properties.Sanitizers, ",")
Ivan Lozano30c5db22018-02-21 15:49:20 -0800707
Colin Cross4af21ed2019-11-04 09:37:55 -0800708 flags.Local.CFlags = append(flags.Local.CFlags, sanitizeArg)
709 flags.Local.AsFlags = append(flags.Local.AsFlags, sanitizeArg)
Colin Cross16b23492016-01-06 14:41:07 -0800710 if ctx.Host() {
Evgenii Stepanov76cee232017-01-27 15:44:44 -0800711 // Host sanitizers only link symbols in the final executable, so
712 // there will always be undefined symbols in intermediate libraries.
Colin Cross4af21ed2019-11-04 09:37:55 -0800713 _, flags.Global.LdFlags = removeFromList("-Wl,--no-undefined", flags.Global.LdFlags)
714 flags.Local.LdFlags = append(flags.Local.LdFlags, sanitizeArg)
Ivan Lozano9ac32c72020-02-19 15:24:02 -0500715
716 // non-Bionic toolchain prebuilts are missing UBSan's vptr and function sanitizers
717 if !ctx.toolchain().Bionic() {
718 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=vptr,function")
719 }
720 }
721
722 if enableMinimalRuntime(sanitize) {
723 flags.Local.CFlags = append(flags.Local.CFlags, strings.Join(minimalRuntimeFlags, " "))
724 flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...)
725 flags.Local.LdFlags = append(flags.Local.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib)
726 if !ctx.toolchain().Bionic() {
727 flags.libFlags = append([]string{builtinsRuntimePath}, flags.libFlags...)
Ivan Lozano30c5db22018-02-21 15:49:20 -0800728 }
Colin Cross16b23492016-01-06 14:41:07 -0800729 }
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700730
731 if Bool(sanitize.Properties.Sanitize.Fuzzer) {
732 // When fuzzing, we wish to crash with diagnostics on any bug.
Colin Cross4af21ed2019-11-04 09:37:55 -0800733 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap=all", "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700734 } else if ctx.Host() {
Colin Cross4af21ed2019-11-04 09:37:55 -0800735 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover=all")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700736 } else {
Colin Cross4af21ed2019-11-04 09:37:55 -0800737 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort")
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700738 }
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800739 // http://b/119329758, Android core does not boot up with this sanitizer yet.
Colin Cross4af21ed2019-11-04 09:37:55 -0800740 if toDisableImplicitIntegerChange(flags.Local.CFlags) {
741 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=implicit-integer-sign-change")
Chih-Hung Hsieh3567e622018-11-15 14:01:36 -0800742 }
Yabin Cuidb7dda82020-11-30 15:47:45 -0800743 // http://b/171275751, Android doesn't build with this sanitizer yet.
744 if toDisableUnsignedShiftBaseChange(flags.Local.CFlags) {
745 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize=unsigned-shift-base")
746 }
Colin Cross16b23492016-01-06 14:41:07 -0800747 }
748
Jiyong Park379de2f2018-12-19 02:47:14 +0900749 if len(sanitize.Properties.DiagSanitizers) > 0 {
Colin Cross4af21ed2019-11-04 09:37:55 -0800750 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-trap="+strings.Join(sanitize.Properties.DiagSanitizers, ","))
Evgenii Stepanov1e405e12016-08-16 15:39:54 -0700751 }
752 // FIXME: enable RTTI if diag + (cfi or vptr)
753
Andreas Gampe97071162017-05-08 13:15:23 -0700754 if sanitize.Properties.Sanitize.Recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800755 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-recover="+
Andreas Gampe97071162017-05-08 13:15:23 -0700756 strings.Join(sanitize.Properties.Sanitize.Recover, ","))
757 }
758
Ivan Lozano7929bba2018-12-12 09:36:31 -0800759 if sanitize.Properties.Sanitize.Diag.No_recover != nil {
Colin Cross4af21ed2019-11-04 09:37:55 -0800760 flags.Local.CFlags = append(flags.Local.CFlags, "-fno-sanitize-recover="+
Ivan Lozano7929bba2018-12-12 09:36:31 -0800761 strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ","))
762 }
763
Pirama Arumuga Nainar6c4ccca2020-07-27 11:49:51 -0700764 blocklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blocklist)
765 if blocklist.Valid() {
766 flags.Local.CFlags = append(flags.Local.CFlags, "-fsanitize-blacklist="+blocklist.String())
767 flags.CFlagsDeps = append(flags.CFlagsDeps, blocklist.Path())
768 }
769
Colin Cross16b23492016-01-06 14:41:07 -0800770 return flags
771}
772
Colin Crossd80cbca2020-02-24 12:01:37 -0800773func (sanitize *sanitize) AndroidMkEntries(ctx AndroidMkContext, entries *android.AndroidMkEntries) {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900774 // Add a suffix for cfi/hwasan/scs-enabled static/header libraries to allow surfacing
775 // both the sanitized and non-sanitized variants to make without a name conflict.
Colin Crossd80cbca2020-02-24 12:01:37 -0800776 if entries.Class == "STATIC_LIBRARIES" || entries.Class == "HEADER_LIBRARIES" {
Jiyong Park1d1119f2019-07-29 21:27:18 +0900777 if Bool(sanitize.Properties.Sanitize.Cfi) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800778 entries.SubName += ".cfi"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900779 }
780 if Bool(sanitize.Properties.Sanitize.Hwaddress) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800781 entries.SubName += ".hwasan"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900782 }
783 if Bool(sanitize.Properties.Sanitize.Scs) {
Colin Crossd80cbca2020-02-24 12:01:37 -0800784 entries.SubName += ".scs"
Jiyong Park1d1119f2019-07-29 21:27:18 +0900785 }
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800786 }
Colin Cross8ff9ef42017-05-08 13:44:11 -0700787}
788
Vishwath Mohan1dd88392017-03-29 22:00:18 -0700789func (sanitize *sanitize) inSanitizerDir() bool {
790 return sanitize.Properties.InSanitizerDir
Colin Cross30d5f512016-05-03 18:02:42 -0700791}
792
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500793// getSanitizerBoolPtr returns the SanitizerTypes associated bool pointer from SanitizeProperties.
794func (sanitize *sanitize) getSanitizerBoolPtr(t SanitizerType) *bool {
Vishwath Mohan95229302017-08-11 00:53:16 +0000795 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500796 case Asan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000797 return sanitize.Properties.Sanitize.Address
Tri Vo6eafc362021-04-01 11:29:09 -0700798 case Hwasan:
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700799 return sanitize.Properties.Sanitize.Hwaddress
Vishwath Mohan95229302017-08-11 00:53:16 +0000800 case tsan:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000801 return sanitize.Properties.Sanitize.Thread
Vishwath Mohan95229302017-08-11 00:53:16 +0000802 case intOverflow:
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000803 return sanitize.Properties.Sanitize.Integer_overflow
804 case cfi:
805 return sanitize.Properties.Sanitize.Cfi
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800806 case scs:
807 return sanitize.Properties.Sanitize.Scs
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700808 case memtag_heap:
809 return sanitize.Properties.Sanitize.Memtag_heap
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500810 case Fuzzer:
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700811 return sanitize.Properties.Sanitize.Fuzzer
Vishwath Mohan95229302017-08-11 00:53:16 +0000812 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500813 panic(fmt.Errorf("unknown SanitizerType %d", t))
Vishwath Mohan95229302017-08-11 00:53:16 +0000814 }
815}
816
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500817// isUnsanitizedVariant returns true if no sanitizers are enabled.
Dan Albert7d1eecf2018-01-19 12:30:45 -0800818func (sanitize *sanitize) isUnsanitizedVariant() bool {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500819 return !sanitize.isSanitizerEnabled(Asan) &&
Tri Vo6eafc362021-04-01 11:29:09 -0700820 !sanitize.isSanitizerEnabled(Hwasan) &&
Dan Albert7d1eecf2018-01-19 12:30:45 -0800821 !sanitize.isSanitizerEnabled(tsan) &&
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800822 !sanitize.isSanitizerEnabled(cfi) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700823 !sanitize.isSanitizerEnabled(scs) &&
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700824 !sanitize.isSanitizerEnabled(memtag_heap) &&
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500825 !sanitize.isSanitizerEnabled(Fuzzer)
Dan Albert7d1eecf2018-01-19 12:30:45 -0800826}
827
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500828// isVariantOnProductionDevice returns true if variant is for production devices (no non-production sanitizers enabled).
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700829func (sanitize *sanitize) isVariantOnProductionDevice() bool {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500830 return !sanitize.isSanitizerEnabled(Asan) &&
Tri Vo6eafc362021-04-01 11:29:09 -0700831 !sanitize.isSanitizerEnabled(Hwasan) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -0700832 !sanitize.isSanitizerEnabled(tsan) &&
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500833 !sanitize.isSanitizerEnabled(Fuzzer)
Jayant Chowdharyb7e08ca2018-05-10 15:29:24 -0700834}
835
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500836func (sanitize *sanitize) SetSanitizer(t SanitizerType, b bool) {
Liz Kammerb2fc4702021-06-25 14:53:40 -0400837 bPtr := proptools.BoolPtr(b)
838 if !b {
839 bPtr = nil
840 }
Colin Cross16b23492016-01-06 14:41:07 -0800841 switch t {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500842 case Asan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400843 sanitize.Properties.Sanitize.Address = bPtr
Tri Vo6eafc362021-04-01 11:29:09 -0700844 case Hwasan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400845 sanitize.Properties.Sanitize.Hwaddress = bPtr
Colin Cross16b23492016-01-06 14:41:07 -0800846 case tsan:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400847 sanitize.Properties.Sanitize.Thread = bPtr
Ivan Lozano0c3a1ef2017-06-28 09:10:48 -0700848 case intOverflow:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400849 sanitize.Properties.Sanitize.Integer_overflow = bPtr
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000850 case cfi:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400851 sanitize.Properties.Sanitize.Cfi = bPtr
Peter Collingbourne8c7e6e22018-11-19 16:03:58 -0800852 case scs:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400853 sanitize.Properties.Sanitize.Scs = bPtr
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -0700854 case memtag_heap:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400855 sanitize.Properties.Sanitize.Memtag_heap = bPtr
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500856 case Fuzzer:
Liz Kammerb2fc4702021-06-25 14:53:40 -0400857 sanitize.Properties.Sanitize.Fuzzer = bPtr
Colin Cross16b23492016-01-06 14:41:07 -0800858 default:
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500859 panic(fmt.Errorf("unknown SanitizerType %d", t))
Colin Cross16b23492016-01-06 14:41:07 -0800860 }
861 if b {
862 sanitize.Properties.SanitizerEnabled = true
863 }
864}
865
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000866// Check if the sanitizer is explicitly disabled (as opposed to nil by
867// virtue of not being set).
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500868func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t SanitizerType) bool {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000869 if sanitize == nil {
870 return false
871 }
872
873 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
874 return sanitizerVal != nil && *sanitizerVal == false
875}
876
877// There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled)
878// because enabling a sanitizer either directly (via the blueprint) or
879// indirectly (via a mutator) sets the bool ptr to true, and you can't
880// distinguish between the cases. It isn't needed though - both cases can be
881// treated identically.
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500882func (sanitize *sanitize) isSanitizerEnabled(t SanitizerType) bool {
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000883 if sanitize == nil {
884 return false
885 }
886
887 sanitizerVal := sanitize.getSanitizerBoolPtr(t)
888 return sanitizerVal != nil && *sanitizerVal == true
889}
890
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500891// IsSanitizableDependencyTag returns true if the dependency tag is sanitizable.
892func IsSanitizableDependencyTag(tag blueprint.DependencyTag) bool {
Colin Cross6e511a92020-07-27 21:26:48 -0700893 switch t := tag.(type) {
894 case dependencyTag:
895 return t == reuseObjTag || t == objDepTag
896 case libraryDependencyTag:
897 return true
898 default:
899 return false
900 }
Colin Cross6b753602018-06-21 13:03:07 -0700901}
902
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500903func (m *Module) SanitizableDepTagChecker() SantizableDependencyTagChecker {
904 return IsSanitizableDependencyTag
905}
906
Inseob Kimc42f2f22020-07-29 20:32:10 +0900907// Determines if the current module is a static library going to be captured
908// as vendor snapshot. Such modules must create both cfi and non-cfi variants,
909// except for ones which explicitly disable cfi.
910func needsCfiForVendorSnapshot(mctx android.TopDownMutatorContext) bool {
Kiyoung Kim48f37782021-07-07 12:42:39 +0900911 if snapshot.IsVendorProprietaryModule(mctx) {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900912 return false
913 }
914
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500915 c := mctx.Module().(PlatformSanitizeable)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900916
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500917 if !c.InVendor() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900918 return false
919 }
920
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500921 if !c.StaticallyLinked() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900922 return false
923 }
924
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500925 if c.IsPrebuilt() {
Inseob Kimc42f2f22020-07-29 20:32:10 +0900926 return false
927 }
928
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500929 if !c.SanitizerSupported(cfi) {
930 return false
931 }
932
933 return c.SanitizePropDefined() &&
934 !c.SanitizeNever() &&
935 !c.IsSanitizerExplicitlyDisabled(cfi)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900936}
937
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700938// Propagate sanitizer requirements down from binaries
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500939func sanitizerDepsMutator(t SanitizerType) func(android.TopDownMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -0700940 return func(mctx android.TopDownMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500941 if c, ok := mctx.Module().(PlatformSanitizeable); ok {
942 enabled := c.IsSanitizerEnabled(t)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900943 if t == cfi && needsCfiForVendorSnapshot(mctx) {
944 // We shouldn't change the result of isSanitizerEnabled(cfi) to correctly
945 // determine defaultVariation in sanitizerMutator below.
946 // Instead, just mark SanitizeDep to forcefully create cfi variant.
947 enabled = true
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500948 c.SetSanitizeDep(true)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900949 }
950 if enabled {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500951 isSanitizableDependencyTag := c.SanitizableDepTagChecker()
Inseob Kimc42f2f22020-07-29 20:32:10 +0900952 mctx.WalkDeps(func(child, parent android.Module) bool {
953 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
954 return false
955 }
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500956 if d, ok := child.(PlatformSanitizeable); ok && d.SanitizePropDefined() &&
957 !d.SanitizeNever() &&
958 !d.IsSanitizerExplicitlyDisabled(t) {
Colin Crossaf98f582021-05-12 17:27:32 -0700959 if t == cfi || t == Hwasan || t == scs || t == Asan {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500960 if d.StaticallyLinked() && d.SanitizerSupported(t) {
961 // Rust does not support some of these sanitizers, so we need to check if it's
962 // supported before setting this true.
963 d.SetSanitizeDep(true)
Inseob Kimc42f2f22020-07-29 20:32:10 +0900964 }
965 } else {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500966 d.SetSanitizeDep(true)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -0700967 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +0000968 }
Inseob Kimc42f2f22020-07-29 20:32:10 +0900969 return true
970 })
971 }
Jiyong Parkf97782b2019-02-13 20:28:58 +0900972 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok {
973 // If an APEX module includes a lib which is enabled for a sanitizer T, then
974 // the APEX module is also enabled for the same sanitizer type.
975 mctx.VisitDirectDeps(func(child android.Module) {
976 if c, ok := child.(*Module); ok && c.sanitize.isSanitizerEnabled(t) {
977 sanitizeable.EnableSanitizer(t.name())
978 }
979 })
Colin Cross16b23492016-01-06 14:41:07 -0800980 }
981 }
982}
983
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500984func (c *Module) SanitizeNever() bool {
985 return Bool(c.sanitize.Properties.Sanitize.Never)
986}
987
988func (c *Module) IsSanitizerExplicitlyDisabled(t SanitizerType) bool {
989 return c.sanitize.isSanitizerExplicitlyDisabled(t)
990}
991
Ivan Lozano30c5db22018-02-21 15:49:20 -0800992// Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies.
Colin Cross6b753602018-06-21 13:03:07 -0700993func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500994 // Change this to PlatformSanitizable when/if non-cc modules support ubsan sanitizers.
Colin Cross6b753602018-06-21 13:03:07 -0700995 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Ivan Lozano3968d8f2020-12-14 11:27:52 -0500996 isSanitizableDependencyTag := c.SanitizableDepTagChecker()
Colin Cross6b753602018-06-21 13:03:07 -0700997 mctx.WalkDeps(func(child, parent android.Module) bool {
998 if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) {
999 return false
1000 }
Ivan Lozano30c5db22018-02-21 15:49:20 -08001001
Inseob Kimeec88e12020-01-22 11:11:29 +09001002 d, ok := child.(*Module)
1003 if !ok || !d.static() {
1004 return false
1005 }
1006 if d.sanitize != nil {
Colin Cross6b753602018-06-21 13:03:07 -07001007 if enableMinimalRuntime(d.sanitize) {
1008 // If a static dependency is built with the minimal runtime,
1009 // make sure we include the ubsan minimal runtime.
1010 c.sanitize.Properties.MinimalRuntimeDep = true
Inseob Kim8471cda2019-11-15 09:59:12 +09001011 } else if enableUbsanRuntime(d.sanitize) {
Colin Cross6b753602018-06-21 13:03:07 -07001012 // If a static dependency runs with full ubsan diagnostics,
1013 // make sure we include the ubsan runtime.
1014 c.sanitize.Properties.UbsanRuntimeDep = true
Ivan Lozano30c5db22018-02-21 15:49:20 -08001015 }
Colin Cross0b908332019-06-19 23:00:20 -07001016
1017 if c.sanitize.Properties.MinimalRuntimeDep &&
1018 c.sanitize.Properties.UbsanRuntimeDep {
1019 // both flags that this mutator might set are true, so don't bother recursing
1020 return false
1021 }
1022
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001023 if c.Os() == android.Linux {
1024 c.sanitize.Properties.BuiltinsDep = true
1025 }
1026
Colin Cross0b908332019-06-19 23:00:20 -07001027 return true
Colin Cross6b753602018-06-21 13:03:07 -07001028 }
Inseob Kimeec88e12020-01-22 11:11:29 +09001029
Jose Galmesf7294582020-11-13 12:07:36 -08001030 if p, ok := d.linker.(*snapshotLibraryDecorator); ok {
Inseob Kimeec88e12020-01-22 11:11:29 +09001031 if Bool(p.properties.Sanitize_minimal_dep) {
1032 c.sanitize.Properties.MinimalRuntimeDep = true
1033 }
1034 if Bool(p.properties.Sanitize_ubsan_dep) {
1035 c.sanitize.Properties.UbsanRuntimeDep = true
1036 }
1037 }
1038
1039 return false
Colin Cross6b753602018-06-21 13:03:07 -07001040 })
Ivan Lozano30c5db22018-02-21 15:49:20 -08001041 }
1042}
1043
Jiyong Park379de2f2018-12-19 02:47:14 +09001044// Add the dependency to the runtime library for each of the sanitizer variants
1045func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001046 if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil {
Pirama Arumuga Nainar6aa21022019-01-25 00:20:35 +00001047 if !c.Enabled() {
1048 return
1049 }
Jiyong Park379de2f2018-12-19 02:47:14 +09001050 var sanitizers []string
1051 var diagSanitizers []string
1052
1053 if Bool(c.sanitize.Properties.Sanitize.All_undefined) {
1054 sanitizers = append(sanitizers, "undefined")
1055 } else {
1056 if Bool(c.sanitize.Properties.Sanitize.Undefined) {
1057 sanitizers = append(sanitizers,
1058 "bool",
1059 "integer-divide-by-zero",
1060 "return",
1061 "returns-nonnull-attribute",
1062 "shift-exponent",
1063 "unreachable",
1064 "vla-bound",
1065 // TODO(danalbert): The following checks currently have compiler performance issues.
1066 //"alignment",
1067 //"bounds",
1068 //"enum",
1069 //"float-cast-overflow",
1070 //"float-divide-by-zero",
1071 //"nonnull-attribute",
1072 //"null",
1073 //"shift-base",
1074 //"signed-integer-overflow",
1075 // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on.
1076 // https://llvm.org/PR19302
1077 // http://reviews.llvm.org/D6974
1078 // "object-size",
1079 )
1080 }
1081 sanitizers = append(sanitizers, c.sanitize.Properties.Sanitize.Misc_undefined...)
1082 }
1083
1084 if Bool(c.sanitize.Properties.Sanitize.Diag.Undefined) {
1085 diagSanitizers = append(diagSanitizers, "undefined")
1086 }
1087
1088 diagSanitizers = append(diagSanitizers, c.sanitize.Properties.Sanitize.Diag.Misc_undefined...)
1089
1090 if Bool(c.sanitize.Properties.Sanitize.Address) {
1091 sanitizers = append(sanitizers, "address")
1092 diagSanitizers = append(diagSanitizers, "address")
1093 }
1094
1095 if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
1096 sanitizers = append(sanitizers, "hwaddress")
1097 }
1098
1099 if Bool(c.sanitize.Properties.Sanitize.Thread) {
1100 sanitizers = append(sanitizers, "thread")
1101 }
1102
1103 if Bool(c.sanitize.Properties.Sanitize.Safestack) {
1104 sanitizers = append(sanitizers, "safe-stack")
1105 }
1106
1107 if Bool(c.sanitize.Properties.Sanitize.Cfi) {
1108 sanitizers = append(sanitizers, "cfi")
1109
1110 if Bool(c.sanitize.Properties.Sanitize.Diag.Cfi) {
1111 diagSanitizers = append(diagSanitizers, "cfi")
1112 }
1113 }
1114
1115 if Bool(c.sanitize.Properties.Sanitize.Integer_overflow) {
1116 sanitizers = append(sanitizers, "unsigned-integer-overflow")
1117 sanitizers = append(sanitizers, "signed-integer-overflow")
1118 if Bool(c.sanitize.Properties.Sanitize.Diag.Integer_overflow) {
1119 diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow")
1120 diagSanitizers = append(diagSanitizers, "signed-integer-overflow")
1121 }
1122 }
1123
1124 if Bool(c.sanitize.Properties.Sanitize.Scudo) {
1125 sanitizers = append(sanitizers, "scudo")
1126 }
1127
1128 if Bool(c.sanitize.Properties.Sanitize.Scs) {
1129 sanitizers = append(sanitizers, "shadow-call-stack")
1130 }
1131
Ivan Lozanod7586b62021-04-01 09:49:36 -04001132 if Bool(c.sanitize.Properties.Sanitize.Memtag_heap) && c.Binary() {
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -07001133 noteDep := "note_memtag_heap_async"
1134 if Bool(c.sanitize.Properties.Sanitize.Diag.Memtag_heap) {
1135 noteDep = "note_memtag_heap_sync"
1136 }
Inseob Kim253f5212021-04-08 17:10:31 +09001137 // If we're using snapshots, redirect to snapshot whenever possible
1138 // TODO(b/178470649): clean manual snapshot redirections
1139 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1140 if lib, ok := snapshot.StaticLibs[noteDep]; ok {
1141 noteDep = lib
1142 }
Evgenii Stepanov193ac2e2020-04-28 15:09:12 -07001143 depTag := libraryDependencyTag{Kind: staticLibraryDependency, wholeStatic: true}
1144 variations := append(mctx.Target().Variations(),
1145 blueprint.Variation{Mutator: "link", Variation: "static"})
1146 if c.Device() {
1147 variations = append(variations, c.ImageVariation())
1148 }
1149 mctx.AddFarVariationDependencies(variations, depTag, noteDep)
1150 }
1151
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001152 if Bool(c.sanitize.Properties.Sanitize.Fuzzer) {
1153 sanitizers = append(sanitizers, "fuzzer-no-link")
1154 }
1155
Jiyong Park379de2f2018-12-19 02:47:14 +09001156 // Save the list of sanitizers. These will be used again when generating
1157 // the build rules (for Cflags, etc.)
1158 c.sanitize.Properties.Sanitizers = sanitizers
1159 c.sanitize.Properties.DiagSanitizers = diagSanitizers
1160
Ivan Lozanof3b190f2020-03-06 12:01:21 -05001161 // TODO(b/150822854) Hosts have a different default behavior and assume the runtime library is used.
1162 if c.Host() {
1163 diagSanitizers = sanitizers
1164 }
1165
Jiyong Park379de2f2018-12-19 02:47:14 +09001166 // Determine the runtime library required
1167 runtimeLibrary := ""
Ryan Prichardb49fe1b2019-10-11 15:03:34 -07001168 var extraStaticDeps []string
Jiyong Park379de2f2018-12-19 02:47:14 +09001169 toolchain := c.toolchain(mctx)
1170 if Bool(c.sanitize.Properties.Sanitize.Address) {
1171 runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain)
1172 } else if Bool(c.sanitize.Properties.Sanitize.Hwaddress) {
1173 if c.staticBinary() {
1174 runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain)
Ryan Prichardb49fe1b2019-10-11 15:03:34 -07001175 extraStaticDeps = []string{"libdl"}
Jiyong Park379de2f2018-12-19 02:47:14 +09001176 } else {
1177 runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain)
1178 }
1179 } else if Bool(c.sanitize.Properties.Sanitize.Thread) {
1180 runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain)
1181 } else if Bool(c.sanitize.Properties.Sanitize.Scudo) {
1182 if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep {
1183 runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain)
1184 } else {
1185 runtimeLibrary = config.ScudoRuntimeLibrary(toolchain)
1186 }
Mitch Phillipsb8e593d2019-10-09 17:18:59 -07001187 } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001188 Bool(c.sanitize.Properties.Sanitize.Fuzzer) ||
1189 Bool(c.sanitize.Properties.Sanitize.Undefined) ||
1190 Bool(c.sanitize.Properties.Sanitize.All_undefined) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001191 runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain)
Colin Cross32f1de32021-03-29 13:41:37 -07001192 if c.staticBinary() {
1193 runtimeLibrary += ".static"
1194 }
Jiyong Park379de2f2018-12-19 02:47:14 +09001195 }
1196
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001197 if runtimeLibrary != "" && (toolchain.Bionic() || c.sanitize.Properties.UbsanRuntimeDep) {
1198 // UBSan is supported on non-bionic linux host builds as well
Jiyong Park379de2f2018-12-19 02:47:14 +09001199
1200 // Adding dependency to the runtime library. We are using *FarVariation*
1201 // because the runtime libraries themselves are not mutated by sanitizer
1202 // mutators and thus don't have sanitizer variants whereas this module
1203 // has been already mutated.
1204 //
1205 // Note that by adding dependency with {static|shared}DepTag, the lib is
1206 // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module
1207 if c.staticBinary() {
Inseob Kimeec88e12020-01-22 11:11:29 +09001208 deps := append(extraStaticDeps, runtimeLibrary)
Colin Crosse0edaf92021-01-11 17:31:17 -08001209 // If we're using snapshots, redirect to snapshot whenever possible
1210 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1211 for idx, dep := range deps {
1212 if lib, ok := snapshot.StaticLibs[dep]; ok {
1213 deps[idx] = lib
Inseob Kimeec88e12020-01-22 11:11:29 +09001214 }
1215 }
1216
Jiyong Park379de2f2018-12-19 02:47:14 +09001217 // static executable gets static runtime libs
Colin Cross6e511a92020-07-27 21:26:48 -07001218 depTag := libraryDependencyTag{Kind: staticLibraryDependency}
Colin Cross42507332020-08-21 16:15:23 -07001219 variations := append(mctx.Target().Variations(),
1220 blueprint.Variation{Mutator: "link", Variation: "static"})
1221 if c.Device() {
1222 variations = append(variations, c.ImageVariation())
1223 }
1224 mctx.AddFarVariationDependencies(variations, depTag, deps...)
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001225 } else if !c.static() && !c.Header() {
Colin Crosse0edaf92021-01-11 17:31:17 -08001226 // If we're using snapshots, redirect to snapshot whenever possible
1227 snapshot := mctx.Provider(SnapshotInfoProvider).(SnapshotInfo)
1228 if lib, ok := snapshot.SharedLibs[runtimeLibrary]; ok {
1229 runtimeLibrary = lib
Inseob Kimeec88e12020-01-22 11:11:29 +09001230 }
Colin Crosse0edaf92021-01-11 17:31:17 -08001231
Cindy Zhou18417cb2020-12-10 07:12:38 -08001232 // Skip apex dependency check for sharedLibraryDependency
1233 // when sanitizer diags are enabled. Skipping the check will allow
1234 // building with diag libraries without having to list the
1235 // dependency in Apex's allowed_deps file.
1236 diagEnabled := len(diagSanitizers) > 0
Jiyong Park3b1746a2019-01-29 11:15:04 +09001237 // dynamic executable and shared libs get shared runtime libs
Cindy Zhou18417cb2020-12-10 07:12:38 -08001238 depTag := libraryDependencyTag{
1239 Kind: sharedLibraryDependency,
1240 Order: earlyLibraryDependency,
1241
1242 skipApexAllowedDependenciesCheck: diagEnabled,
1243 }
Colin Cross42507332020-08-21 16:15:23 -07001244 variations := append(mctx.Target().Variations(),
1245 blueprint.Variation{Mutator: "link", Variation: "shared"})
1246 if c.Device() {
1247 variations = append(variations, c.ImageVariation())
1248 }
Ivan Lozanod67a6b02021-05-20 13:01:32 -04001249 AddSharedLibDependenciesWithVersions(mctx, c, variations, depTag, runtimeLibrary, "", true)
Jiyong Park379de2f2018-12-19 02:47:14 +09001250 }
1251 // static lib does not have dependency to the runtime library. The
1252 // dependency will be added to the executables or shared libs using
1253 // the static lib.
1254 }
1255 }
1256}
1257
1258type Sanitizeable interface {
1259 android.Module
Jiyong Park388ef3f2019-01-28 19:47:32 +09001260 IsSanitizerEnabled(ctx android.BaseModuleContext, sanitizerName string) bool
Jiyong Parkf97782b2019-02-13 20:28:58 +09001261 EnableSanitizer(sanitizerName string)
Jooyung Han8ce8db92020-05-15 19:05:05 +09001262 AddSanitizerDependencies(ctx android.BottomUpMutatorContext, sanitizerName string)
Jiyong Park379de2f2018-12-19 02:47:14 +09001263}
1264
Ivan Lozanod7586b62021-04-01 09:49:36 -04001265func (c *Module) MinimalRuntimeDep() bool {
1266 return c.sanitize.Properties.MinimalRuntimeDep
1267}
1268
1269func (c *Module) UbsanRuntimeDep() bool {
1270 return c.sanitize.Properties.UbsanRuntimeDep
1271}
1272
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001273func (c *Module) SanitizePropDefined() bool {
1274 return c.sanitize != nil
1275}
1276
1277func (c *Module) IsSanitizerEnabled(t SanitizerType) bool {
1278 return c.sanitize.isSanitizerEnabled(t)
1279}
1280
1281func (c *Module) SanitizeDep() bool {
1282 return c.sanitize.Properties.SanitizeDep
1283}
1284
1285func (c *Module) StaticallyLinked() bool {
1286 return c.static()
1287}
1288
1289func (c *Module) SetInSanitizerDir() {
1290 if c.sanitize != nil {
1291 c.sanitize.Properties.InSanitizerDir = true
1292 }
1293}
1294
1295func (c *Module) SetSanitizer(t SanitizerType, b bool) {
1296 if c.sanitize != nil {
1297 c.sanitize.SetSanitizer(t, b)
1298 }
1299}
1300
1301func (c *Module) SetSanitizeDep(b bool) {
1302 if c.sanitize != nil {
1303 c.sanitize.Properties.SanitizeDep = b
1304 }
1305}
1306
1307var _ PlatformSanitizeable = (*Module)(nil)
1308
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001309// Create sanitized variants for modules that need them
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001310func sanitizerMutator(t SanitizerType) func(android.BottomUpMutatorContext) {
Colin Cross635c3b02016-05-18 15:37:25 -07001311 return func(mctx android.BottomUpMutatorContext) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001312 if c, ok := mctx.Module().(PlatformSanitizeable); ok && c.SanitizePropDefined() {
Liz Kammer187d5442021-06-25 14:50:12 -04001313 if c.Binary() && c.IsSanitizerEnabled(t) {
Jiyong Park82226632019-02-01 10:50:50 +09001314 modules := mctx.CreateVariations(t.variationName())
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001315 modules[0].(PlatformSanitizeable).SetSanitizer(t, true)
1316 } else if c.IsSanitizerEnabled(t) || c.SanitizeDep() {
1317 isSanitizerEnabled := c.IsSanitizerEnabled(t)
Colin Crossaf98f582021-05-12 17:27:32 -07001318 if c.StaticallyLinked() || c.Header() || t == Fuzzer {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001319 // Static and header libs are split into non-sanitized and sanitized variants.
1320 // Shared libs are not split. However, for asan and fuzzer, we split even for shared
1321 // libs because a library sanitized for asan/fuzzer can't be linked from a library
1322 // that isn't sanitized for asan/fuzzer.
1323 //
1324 // Note for defaultVariation: since we don't split for shared libs but for static/header
1325 // libs, it is possible for the sanitized variant of a static/header lib to depend
1326 // on non-sanitized variant of a shared lib. Such unfulfilled variation causes an
1327 // error when the module is split. defaultVariation is the name of the variation that
1328 // will be used when such a dangling dependency occurs during the split of the current
1329 // module. By setting it to the name of the sanitized variation, the dangling dependency
1330 // is redirected to the sanitized variant of the dependent module.
1331 defaultVariation := t.variationName()
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001332 // Not all PlatformSanitizeable modules support the CFI sanitizer
1333 cfiSupported := mctx.Module().(PlatformSanitizeable).SanitizerSupported(cfi)
Jiyong Park1d1119f2019-07-29 21:27:18 +09001334 mctx.SetDefaultDependencyVariation(&defaultVariation)
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001335
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001336 modules := mctx.CreateVariations("", t.variationName())
1337 modules[0].(PlatformSanitizeable).SetSanitizer(t, false)
1338 modules[1].(PlatformSanitizeable).SetSanitizer(t, true)
1339 modules[0].(PlatformSanitizeable).SetSanitizeDep(false)
1340 modules[1].(PlatformSanitizeable).SetSanitizeDep(false)
1341
1342 if mctx.Device() && t.incompatibleWithCfi() && cfiSupported {
Ivan Lozano4774a812020-03-10 16:23:57 -04001343 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1344 // are incompatible with cfi
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001345 modules[1].(PlatformSanitizeable).SetSanitizer(cfi, false)
Ivan Lozano4774a812020-03-10 16:23:57 -04001346 }
1347
Jiyong Park1d1119f2019-07-29 21:27:18 +09001348 // For cfi/scs/hwasan, we can export both sanitized and un-sanitized variants
1349 // to Make, because the sanitized version has a different suffix in name.
1350 // For other types of sanitizers, suppress the variation that is disabled.
Tri Vo6eafc362021-04-01 11:29:09 -07001351 if t != cfi && t != scs && t != Hwasan {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001352 if isSanitizerEnabled {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001353 modules[0].(PlatformSanitizeable).SetPreventInstall()
1354 modules[0].(PlatformSanitizeable).SetHideFromMake()
Jiyong Park1d1119f2019-07-29 21:27:18 +09001355 } else {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001356 modules[1].(PlatformSanitizeable).SetPreventInstall()
1357 modules[1].(PlatformSanitizeable).SetHideFromMake()
Jiyong Park1d1119f2019-07-29 21:27:18 +09001358 }
1359 }
Vishwath Mohanb743e9c2017-11-01 09:20:21 +00001360
Jiyong Park1d1119f2019-07-29 21:27:18 +09001361 // Export the static lib name to make
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001362 if c.StaticallyLinked() && c.ExportedToMake() {
Jiyong Park1d1119f2019-07-29 21:27:18 +09001363 if t == cfi {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001364 cfiStaticLibs(mctx.Config()).add(c, c.Module().Name())
Tri Vo6eafc362021-04-01 11:29:09 -07001365 } else if t == Hwasan {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001366 hwasanStaticLibs(mctx.Config()).add(c, c.Module().Name())
Jiyong Park1d1119f2019-07-29 21:27:18 +09001367 }
1368 }
1369 } else {
1370 // Shared libs are not split. Only the sanitized variant is created.
1371 modules := mctx.CreateVariations(t.variationName())
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001372 modules[0].(PlatformSanitizeable).SetSanitizer(t, true)
1373 modules[0].(PlatformSanitizeable).SetSanitizeDep(false)
Vishwath Mohane7128792017-11-17 11:08:10 -08001374
Jiyong Park1d1119f2019-07-29 21:27:18 +09001375 // locate the asan libraries under /data/asan
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001376 if mctx.Device() && t == Asan && isSanitizerEnabled {
1377 modules[0].(PlatformSanitizeable).SetInSanitizerDir()
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001378 }
Ivan Lozano4774a812020-03-10 16:23:57 -04001379
1380 if mctx.Device() && t.incompatibleWithCfi() {
1381 // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that
1382 // are incompatible with cfi
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001383 modules[0].(PlatformSanitizeable).SetSanitizer(cfi, false)
Ivan Lozano4774a812020-03-10 16:23:57 -04001384 }
Vishwath Mohane21fe422017-11-01 19:42:45 -07001385 }
Colin Cross16b23492016-01-06 14:41:07 -08001386 }
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001387 c.SetSanitizeDep(false)
Jiyong Park82226632019-02-01 10:50:50 +09001388 } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok && sanitizeable.IsSanitizerEnabled(mctx, t.name()) {
Jiyong Park379de2f2018-12-19 02:47:14 +09001389 // APEX modules fall here
Jooyung Han8ce8db92020-05-15 19:05:05 +09001390 sanitizeable.AddSanitizerDependencies(mctx, t.name())
Jiyong Park82226632019-02-01 10:50:50 +09001391 mctx.CreateVariations(t.variationName())
Inseob Kimc42f2f22020-07-29 20:32:10 +09001392 } else if c, ok := mctx.Module().(*Module); ok {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001393 //TODO: When Rust modules have vendor support, enable this path for PlatformSanitizeable
1394
Inseob Kimc42f2f22020-07-29 20:32:10 +09001395 // Check if it's a snapshot module supporting sanitizer
1396 if s, ok := c.linker.(snapshotSanitizer); ok && s.isSanitizerEnabled(t) {
1397 // Set default variation as above.
1398 defaultVariation := t.variationName()
1399 mctx.SetDefaultDependencyVariation(&defaultVariation)
1400 modules := mctx.CreateVariations("", t.variationName())
1401 modules[0].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, false)
1402 modules[1].(*Module).linker.(snapshotSanitizer).setSanitizerVariation(t, true)
1403
1404 // Export the static lib name to make
1405 if c.static() && c.ExportedToMake() {
1406 if t == cfi {
1407 // use BaseModuleName which is the name for Make.
1408 cfiStaticLibs(mctx.Config()).add(c, c.BaseModuleName())
1409 }
1410 }
1411 }
Colin Cross16b23492016-01-06 14:41:07 -08001412 }
1413 }
1414}
Vishwath Mohane7128792017-11-17 11:08:10 -08001415
Inseob Kim74d25562020-08-04 00:41:38 +09001416type sanitizerStaticLibsMap struct {
1417 // libsMap contains one list of modules per each image and each arch.
1418 // e.g. libs[vendor]["arm"] contains arm modules installed to vendor
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001419 libsMap map[ImageVariantType]map[string][]string
Inseob Kim74d25562020-08-04 00:41:38 +09001420 libsMapLock sync.Mutex
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001421 sanitizerType SanitizerType
Inseob Kim74d25562020-08-04 00:41:38 +09001422}
1423
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001424func newSanitizerStaticLibsMap(t SanitizerType) *sanitizerStaticLibsMap {
Inseob Kim74d25562020-08-04 00:41:38 +09001425 return &sanitizerStaticLibsMap{
1426 sanitizerType: t,
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001427 libsMap: make(map[ImageVariantType]map[string][]string),
Inseob Kim74d25562020-08-04 00:41:38 +09001428 }
1429}
1430
1431// Add the current module to sanitizer static libs maps
1432// Each module should pass its exported name as names of Make and Soong can differ.
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001433func (s *sanitizerStaticLibsMap) add(c LinkableInterface, name string) {
1434 image := GetImageVariantType(c)
1435 arch := c.Module().Target().Arch.ArchType.String()
Inseob Kim74d25562020-08-04 00:41:38 +09001436
1437 s.libsMapLock.Lock()
1438 defer s.libsMapLock.Unlock()
1439
1440 if _, ok := s.libsMap[image]; !ok {
1441 s.libsMap[image] = make(map[string][]string)
1442 }
1443
1444 s.libsMap[image][arch] = append(s.libsMap[image][arch], name)
1445}
1446
1447// Exports makefile variables in the following format:
1448// SOONG_{sanitizer}_{image}_{arch}_STATIC_LIBRARIES
1449// e.g. SOONG_cfi_core_x86_STATIC_LIBRARIES
1450// These are to be used by use_soong_sanitized_static_libraries.
1451// See build/make/core/binary.mk for more details.
1452func (s *sanitizerStaticLibsMap) exportToMake(ctx android.MakeVarsContext) {
1453 for _, image := range android.SortedStringKeys(s.libsMap) {
Ivan Lozano3968d8f2020-12-14 11:27:52 -05001454 archMap := s.libsMap[ImageVariantType(image)]
Inseob Kim74d25562020-08-04 00:41:38 +09001455 for _, arch := range android.SortedStringKeys(archMap) {
1456 libs := archMap[arch]
1457 sort.Strings(libs)
1458
1459 key := fmt.Sprintf(
1460 "SOONG_%s_%s_%s_STATIC_LIBRARIES",
1461 s.sanitizerType.variationName(),
1462 image, // already upper
1463 arch)
1464
1465 ctx.Strict(key, strings.Join(libs, " "))
1466 }
1467 }
1468}
1469
Colin Cross571cccf2019-02-04 11:22:08 -08001470var cfiStaticLibsKey = android.NewOnceKey("cfiStaticLibs")
1471
Inseob Kim74d25562020-08-04 00:41:38 +09001472func cfiStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001473 return config.Once(cfiStaticLibsKey, func() interface{} {
Inseob Kim74d25562020-08-04 00:41:38 +09001474 return newSanitizerStaticLibsMap(cfi)
1475 }).(*sanitizerStaticLibsMap)
Vishwath Mohane7128792017-11-17 11:08:10 -08001476}
1477
Colin Cross571cccf2019-02-04 11:22:08 -08001478var hwasanStaticLibsKey = android.NewOnceKey("hwasanStaticLibs")
1479
Inseob Kim74d25562020-08-04 00:41:38 +09001480func hwasanStaticLibs(config android.Config) *sanitizerStaticLibsMap {
Colin Cross571cccf2019-02-04 11:22:08 -08001481 return config.Once(hwasanStaticLibsKey, func() interface{} {
Tri Vo6eafc362021-04-01 11:29:09 -07001482 return newSanitizerStaticLibsMap(Hwasan)
Inseob Kim74d25562020-08-04 00:41:38 +09001483 }).(*sanitizerStaticLibsMap)
Jiyong Park1d1119f2019-07-29 21:27:18 +09001484}
1485
Ivan Lozano30c5db22018-02-21 15:49:20 -08001486func enableMinimalRuntime(sanitize *sanitize) bool {
1487 if !Bool(sanitize.Properties.Sanitize.Address) &&
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001488 !Bool(sanitize.Properties.Sanitize.Hwaddress) &&
Mitch Phillips5a6ea6c2019-05-01 14:42:05 -07001489 !Bool(sanitize.Properties.Sanitize.Fuzzer) &&
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001490
Ivan Lozano30c5db22018-02-21 15:49:20 -08001491 (Bool(sanitize.Properties.Sanitize.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001492 len(sanitize.Properties.Sanitize.Misc_undefined) > 0 ||
1493 Bool(sanitize.Properties.Sanitize.Undefined) ||
1494 Bool(sanitize.Properties.Sanitize.All_undefined)) &&
1495
Ivan Lozano30c5db22018-02-21 15:49:20 -08001496 !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
1497 Bool(sanitize.Properties.Sanitize.Diag.Cfi) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001498 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Ivan Lozano30c5db22018-02-21 15:49:20 -08001499 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) {
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001500
Ivan Lozano30c5db22018-02-21 15:49:20 -08001501 return true
1502 }
1503 return false
1504}
1505
Ivan Lozanod7586b62021-04-01 09:49:36 -04001506func (m *Module) UbsanRuntimeNeeded() bool {
1507 return enableUbsanRuntime(m.sanitize)
1508}
1509
1510func (m *Module) MinimalRuntimeNeeded() bool {
1511 return enableMinimalRuntime(m.sanitize)
1512}
1513
Inseob Kim8471cda2019-11-15 09:59:12 +09001514func enableUbsanRuntime(sanitize *sanitize) bool {
1515 return Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) ||
Ivan Lozano9ac32c72020-02-19 15:24:02 -05001516 Bool(sanitize.Properties.Sanitize.Diag.Undefined) ||
Inseob Kim8471cda2019-11-15 09:59:12 +09001517 len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0
1518}
1519
Vishwath Mohane7128792017-11-17 11:08:10 -08001520func cfiMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001521 cfiStaticLibs(ctx.Config()).exportToMake(ctx)
Vishwath Mohane7128792017-11-17 11:08:10 -08001522}
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001523
1524func hwasanMakeVarsProvider(ctx android.MakeVarsContext) {
Inseob Kim74d25562020-08-04 00:41:38 +09001525 hwasanStaticLibs(ctx.Config()).exportToMake(ctx)
Evgenii Stepanovd97a6e92018-08-02 16:19:13 -07001526}