Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1 | // Copyright 2016 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package cc |
| 16 | |
| 17 | import ( |
| 18 | "fmt" |
Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 19 | "sort" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 20 | "strings" |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 21 | "sync" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 22 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 23 | "github.com/google/blueprint" |
| 24 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 25 | "android/soong/android" |
Evgenii Stepanov | af36db1 | 2016-08-15 14:18:24 -0700 | [diff] [blame] | 26 | "android/soong/cc/config" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 27 | ) |
| 28 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 29 | var ( |
| 30 | // Any C flags added by sanitizer which libTooling tools may not |
| 31 | // understand also need to be added to ClangLibToolingUnknownCflags in |
| 32 | // cc/config/clang.go |
Vishwath Mohan | f3918d3 | 2017-02-14 07:59:33 -0800 | [diff] [blame] | 33 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 34 | asanCflags = []string{"-fno-omit-frame-pointer"} |
| 35 | asanLdflags = []string{"-Wl,-u,__asan_preinit"} |
| 36 | asanLibs = []string{"libasan"} |
| 37 | |
Evgenii Stepanov | 0a87b66 | 2018-12-07 15:33:24 -0800 | [diff] [blame] | 38 | hwasanCflags = []string{"-mllvm", "-hwasan-with-ifunc=0", "-fno-omit-frame-pointer", "-Wno-frame-larger-than=", "-mllvm", "-hwasan-create-frame-descriptions=0"} |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 39 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 40 | cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso", |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 41 | "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blacklist.txt"} |
Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 42 | // -flto and -fvisibility are required by clang when -fsanitize=cfi is |
| 43 | // used, but have no effect on assembly files |
| 44 | cfiAsflags = []string{"-flto", "-fvisibility=default"} |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 45 | cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi", |
Pirama Arumuga Nainar | bdb17f0 | 2017-08-28 21:50:17 -0700 | [diff] [blame] | 46 | "-Wl,-plugin-opt,O1"} |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 47 | cfiExportsMapPath = "build/soong/cc/config/cfi_exports.map" |
| 48 | cfiStaticLibsMutex sync.Mutex |
| 49 | hwasanStaticLibsMutex sync.Mutex |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 50 | |
Evgenii Stepanov | 98f5b06 | 2018-11-29 15:12:51 -0800 | [diff] [blame] | 51 | intOverflowCflags = []string{"-fsanitize-blacklist=build/soong/cc/config/integer_overflow_blacklist.txt"} |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 52 | |
| 53 | // Pass -Xclang before -fsanitize-minimal-runtime to work around a driver |
| 54 | // check which rejects -fsanitize-minimal-runtime together with |
| 55 | // -fsanitize=shadow-call-stack even though this combination of flags |
| 56 | // is valid. |
| 57 | // TODO(pcc): Remove the -Xclang once LLVM r346526 is rolled into the compiler. |
| 58 | minimalRuntimeFlags = []string{"-Xclang", "-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined", |
Ivan Lozano | ae6ae1d | 2018-10-08 09:29:39 -0700 | [diff] [blame] | 59 | "-fno-sanitize-recover=integer,undefined"} |
Evgenii Stepanov | 3c5a52a | 2018-12-18 17:02:44 -0800 | [diff] [blame] | 60 | hwasanGlobalOptions = []string{"heap_history_size=1023,stack_history_size=512"} |
Dan Willemsen | cbceaab | 2016-10-13 16:44:07 -0700 | [diff] [blame] | 61 | ) |
| 62 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 63 | type sanitizerType int |
| 64 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 65 | func boolPtr(v bool) *bool { |
| 66 | if v { |
| 67 | return &v |
| 68 | } else { |
| 69 | return nil |
| 70 | } |
| 71 | } |
| 72 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 73 | const ( |
| 74 | asan sanitizerType = iota + 1 |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 75 | hwasan |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 76 | tsan |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 77 | intOverflow |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 78 | cfi |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 79 | scs |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 80 | ) |
| 81 | |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame^] | 82 | // Name of the sanitizer variation for this sanitizer type |
| 83 | func (t sanitizerType) variationName() string { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 84 | switch t { |
| 85 | case asan: |
| 86 | return "asan" |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 87 | case hwasan: |
| 88 | return "hwasan" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 89 | case tsan: |
| 90 | return "tsan" |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 91 | case intOverflow: |
| 92 | return "intOverflow" |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 93 | case cfi: |
| 94 | return "cfi" |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 95 | case scs: |
| 96 | return "scs" |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 97 | default: |
| 98 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 99 | } |
| 100 | } |
| 101 | |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame^] | 102 | // This is the sanitizer names in SANITIZE_[TARGET|HOST] |
| 103 | func (t sanitizerType) name() string { |
| 104 | switch t { |
| 105 | case asan: |
| 106 | return "address" |
| 107 | case hwasan: |
| 108 | return "hwaddress" |
| 109 | case tsan: |
| 110 | return "thread" |
| 111 | case intOverflow: |
| 112 | return "integer_overflow" |
| 113 | case cfi: |
| 114 | return "cfi" |
| 115 | case scs: |
| 116 | return "shadow-call-stack" |
| 117 | default: |
| 118 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 119 | } |
| 120 | } |
| 121 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 122 | type SanitizeProperties struct { |
| 123 | // enable AddressSanitizer, ThreadSanitizer, or UndefinedBehaviorSanitizer |
| 124 | Sanitize struct { |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 125 | Never *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 126 | |
| 127 | // main sanitizers |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 128 | Address *bool `android:"arch_variant"` |
| 129 | Thread *bool `android:"arch_variant"` |
| 130 | Hwaddress *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 131 | |
| 132 | // local sanitizers |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 133 | Undefined *bool `android:"arch_variant"` |
| 134 | All_undefined *bool `android:"arch_variant"` |
| 135 | Misc_undefined []string `android:"arch_variant"` |
| 136 | Coverage *bool `android:"arch_variant"` |
| 137 | Safestack *bool `android:"arch_variant"` |
| 138 | Cfi *bool `android:"arch_variant"` |
| 139 | Integer_overflow *bool `android:"arch_variant"` |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 140 | Scudo *bool `android:"arch_variant"` |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 141 | Scs *bool `android:"arch_variant"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 142 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 143 | // Sanitizers to run in the diagnostic mode (as opposed to the release mode). |
| 144 | // Replaces abort() on error with a human-readable error message. |
| 145 | // Address and Thread sanitizers always run in diagnostic mode. |
| 146 | Diag struct { |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 147 | Undefined *bool `android:"arch_variant"` |
| 148 | Cfi *bool `android:"arch_variant"` |
| 149 | Integer_overflow *bool `android:"arch_variant"` |
| 150 | Misc_undefined []string `android:"arch_variant"` |
Ivan Lozano | 7929bba | 2018-12-12 09:36:31 -0800 | [diff] [blame] | 151 | No_recover []string |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 152 | } |
| 153 | |
| 154 | // value to pass to -fsanitize-recover= |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 155 | Recover []string |
| 156 | |
| 157 | // value to pass to -fsanitize-blacklist |
| 158 | Blacklist *string |
| 159 | } `android:"arch_variant"` |
| 160 | |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 161 | SanitizerEnabled bool `blueprint:"mutated"` |
| 162 | SanitizeDep bool `blueprint:"mutated"` |
| 163 | MinimalRuntimeDep bool `blueprint:"mutated"` |
| 164 | UbsanRuntimeDep bool `blueprint:"mutated"` |
| 165 | InSanitizerDir bool `blueprint:"mutated"` |
| 166 | Sanitizers []string `blueprint:"mutated"` |
| 167 | DiagSanitizers []string `blueprint:"mutated"` |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 168 | } |
| 169 | |
| 170 | type sanitize struct { |
| 171 | Properties SanitizeProperties |
| 172 | } |
| 173 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 174 | func init() { |
| 175 | android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider) |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 176 | android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 177 | } |
| 178 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 179 | func (sanitize *sanitize) props() []interface{} { |
| 180 | return []interface{}{&sanitize.Properties} |
| 181 | } |
| 182 | |
| 183 | func (sanitize *sanitize) begin(ctx BaseModuleContext) { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 184 | s := &sanitize.Properties.Sanitize |
| 185 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 186 | // Don't apply sanitizers to NDK code. |
Jeff Gaston | af3cc2d | 2017-09-27 17:01:44 -0700 | [diff] [blame] | 187 | if ctx.useSdk() { |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 188 | s.Never = BoolPtr(true) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 189 | } |
| 190 | |
Doug Horn | c32c6b0 | 2019-01-17 14:44:05 -0800 | [diff] [blame] | 191 | // Sanitizers do not work on Fuchsia yet. |
| 192 | if ctx.Fuchsia() { |
| 193 | s.Never = BoolPtr(true) |
| 194 | } |
| 195 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 196 | // Never always wins. |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 197 | if Bool(s.Never) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 198 | return |
| 199 | } |
| 200 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 201 | var globalSanitizers []string |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 202 | var globalSanitizersDiag []string |
| 203 | |
Dan Willemsen | 8536d6b | 2018-10-07 20:54:34 -0700 | [diff] [blame] | 204 | if ctx.Host() { |
| 205 | if !ctx.Windows() { |
| 206 | globalSanitizers = ctx.Config().SanitizeHost() |
| 207 | } |
| 208 | } else { |
| 209 | arches := ctx.Config().SanitizeDeviceArch() |
| 210 | if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) { |
| 211 | globalSanitizers = ctx.Config().SanitizeDevice() |
| 212 | globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag() |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 213 | } |
| 214 | } |
| 215 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 216 | if len(globalSanitizers) > 0 { |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 217 | var found bool |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 218 | if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil { |
| 219 | s.All_undefined = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 220 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 221 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 222 | if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil { |
| 223 | s.Undefined = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 224 | } |
| 225 | |
Evgenii Stepanov | 774cb81 | 2016-12-28 15:52:54 -0800 | [diff] [blame] | 226 | if found, globalSanitizers = removeFromList("address", globalSanitizers); found { |
| 227 | if s.Address == nil { |
| 228 | s.Address = boolPtr(true) |
| 229 | } else if *s.Address == false { |
| 230 | // Coverage w/o address is an error. If globalSanitizers includes both, and the module |
| 231 | // disables address, then disable coverage as well. |
| 232 | _, globalSanitizers = removeFromList("coverage", globalSanitizers) |
| 233 | } |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 234 | } |
| 235 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 236 | if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil { |
| 237 | s.Thread = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 238 | } |
| 239 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 240 | if found, globalSanitizers = removeFromList("coverage", globalSanitizers); found && s.Coverage == nil { |
| 241 | s.Coverage = boolPtr(true) |
| 242 | } |
| 243 | |
| 244 | if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil { |
| 245 | s.Safestack = boolPtr(true) |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 246 | } |
| 247 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 248 | if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 249 | if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) { |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 250 | s.Cfi = boolPtr(true) |
| 251 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 252 | } |
| 253 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 254 | // Global integer_overflow builds do not support static libraries. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 255 | if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 256 | if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() { |
Ivan Lozano | 5f59553 | 2017-07-13 14:46:05 -0700 | [diff] [blame] | 257 | s.Integer_overflow = boolPtr(true) |
| 258 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 259 | } |
| 260 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 261 | if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil { |
| 262 | s.Scudo = boolPtr(true) |
| 263 | } |
| 264 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 265 | if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil { |
| 266 | s.Hwaddress = boolPtr(true) |
| 267 | } |
| 268 | |
Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 269 | if len(globalSanitizers) > 0 { |
| 270 | ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0]) |
| 271 | } |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 272 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 273 | // Global integer_overflow builds do not support static library diagnostics. |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 274 | if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found && |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 275 | s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() { |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 276 | s.Diag.Integer_overflow = boolPtr(true) |
| 277 | } |
| 278 | |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 279 | if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found && |
| 280 | s.Diag.Cfi == nil && Bool(s.Cfi) { |
| 281 | s.Diag.Cfi = boolPtr(true) |
| 282 | } |
| 283 | |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 284 | if len(globalSanitizersDiag) > 0 { |
| 285 | ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0]) |
| 286 | } |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 287 | } |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 288 | |
Vishwath Mohan | 1c54f66 | 2018-05-24 18:36:18 -0700 | [diff] [blame] | 289 | // Enable CFI for all components in the include paths (for Aarch64 only) |
| 290 | if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && ctx.Arch().ArchType == android.Arm64 { |
Vishwath Mohan | 3af8ee0 | 2018-03-30 02:55:23 +0000 | [diff] [blame] | 291 | s.Cfi = boolPtr(true) |
| 292 | if inList("cfi", ctx.Config().SanitizeDeviceDiag()) { |
| 293 | s.Diag.Cfi = boolPtr(true) |
Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 294 | } |
| 295 | } |
| 296 | |
Evgenii Stepanov | a83fdac | 2017-01-31 18:37:30 -0800 | [diff] [blame] | 297 | // CFI needs gold linker, and mips toolchain does not have one. |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 298 | if !ctx.Config().EnableCFI() || ctx.Arch().ArchType == android.Mips || ctx.Arch().ArchType == android.Mips64 { |
Vishwath Mohan | 1b017a7 | 2017-01-19 13:54:55 -0800 | [diff] [blame] | 299 | s.Cfi = nil |
| 300 | s.Diag.Cfi = nil |
| 301 | } |
| 302 | |
Vishwath Mohan | 6d67e6e | 2017-02-07 20:31:41 -0800 | [diff] [blame] | 303 | // Also disable CFI for arm32 until b/35157333 is fixed. |
| 304 | if ctx.Arch().ArchType == android.Arm { |
| 305 | s.Cfi = nil |
| 306 | s.Diag.Cfi = nil |
| 307 | } |
| 308 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 309 | // HWASan requires AArch64 hardware feature (top-byte-ignore). |
| 310 | if ctx.Arch().ArchType != android.Arm64 { |
| 311 | s.Hwaddress = nil |
| 312 | } |
| 313 | |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 314 | // SCS is only implemented on AArch64. |
| 315 | // We also disable SCS if ASAN, TSAN or HWASAN are enabled because Clang considers |
| 316 | // them to be incompatible, although they are in fact compatible. |
| 317 | // TODO(pcc): Remove these checks once r347282 is rolled into the compiler. |
| 318 | if ctx.Arch().ArchType != android.Arm64 || Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) { |
| 319 | s.Scs = nil |
| 320 | } |
| 321 | |
Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 322 | // Also disable CFI if ASAN is enabled. |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 323 | if Bool(s.Address) || Bool(s.Hwaddress) { |
Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 324 | s.Cfi = nil |
| 325 | s.Diag.Cfi = nil |
| 326 | } |
| 327 | |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 328 | // Disable sanitizers that depend on the UBSan runtime for host builds. |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 329 | if ctx.Host() { |
| 330 | s.Cfi = nil |
| 331 | s.Diag.Cfi = nil |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 332 | s.Misc_undefined = nil |
| 333 | s.Undefined = nil |
| 334 | s.All_undefined = nil |
| 335 | s.Integer_overflow = nil |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 336 | } |
| 337 | |
Vishwath Mohan | 9ccbba0 | 2018-05-28 13:54:48 -0700 | [diff] [blame] | 338 | // Also disable CFI for VNDK variants of components |
| 339 | if ctx.isVndk() && ctx.useVndk() { |
Vishwath Mohan | 7589c82 | 2018-05-23 19:29:55 -0700 | [diff] [blame] | 340 | s.Cfi = nil |
| 341 | s.Diag.Cfi = nil |
| 342 | } |
| 343 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 344 | // HWASan ramdisk (which is built from recovery) goes over some bootloader limit. |
Evgenii Stepanov | 1e79844 | 2018-11-15 17:34:18 -0800 | [diff] [blame] | 345 | // Keep libc instrumented so that recovery can run hwasan-instrumented code if necessary. |
| 346 | if ctx.inRecovery() && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") { |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 347 | s.Hwaddress = nil |
| 348 | } |
| 349 | |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 350 | if ctx.staticBinary() { |
| 351 | s.Address = nil |
Colin Cross | 91169fe | 2016-08-11 15:54:20 -0700 | [diff] [blame] | 352 | s.Coverage = nil |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 353 | s.Thread = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 354 | } |
| 355 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 356 | if Bool(s.All_undefined) { |
| 357 | s.Undefined = nil |
| 358 | } |
| 359 | |
Evgenii Stepanov | 0a8a0d0 | 2016-05-12 13:54:53 -0700 | [diff] [blame] | 360 | if !ctx.toolchain().Is64Bit() { |
| 361 | // TSAN and SafeStack are not supported on 32-bit architectures |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 362 | s.Thread = nil |
| 363 | s.Safestack = nil |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 364 | // TODO(ccross): error for compile_multilib = "32"? |
| 365 | } |
| 366 | |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 367 | if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) || |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 368 | Bool(s.Coverage) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 || |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 369 | Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs)) { |
Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 370 | sanitize.Properties.SanitizerEnabled = true |
| 371 | } |
| 372 | |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 373 | // Disable Scudo if ASan or TSan is enabled. |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 374 | if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) { |
Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 375 | s.Scudo = nil |
| 376 | } |
| 377 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 378 | if Bool(s.Hwaddress) { |
| 379 | s.Address = nil |
| 380 | s.Thread = nil |
| 381 | } |
| 382 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 383 | if Bool(s.Coverage) { |
| 384 | if !Bool(s.Address) { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 385 | ctx.ModuleErrorf(`Use of "coverage" also requires "address"`) |
| 386 | } |
| 387 | } |
| 388 | } |
| 389 | |
| 390 | func (sanitize *sanitize) deps(ctx BaseModuleContext, deps Deps) Deps { |
| 391 | if !sanitize.Properties.SanitizerEnabled { // || c.static() { |
| 392 | return deps |
| 393 | } |
| 394 | |
| 395 | if ctx.Device() { |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 396 | if Bool(sanitize.Properties.Sanitize.Address) { |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 397 | deps.StaticLibs = append(deps.StaticLibs, asanLibs...) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 398 | } |
| 399 | } |
| 400 | |
| 401 | return deps |
| 402 | } |
| 403 | |
Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 404 | func toDisableImplicitIntegerChange(flags []string) bool { |
| 405 | // Returns true if any flag is fsanitize*integer, and there is |
| 406 | // no explicit flag about sanitize=implicit-integer-sign-change. |
| 407 | for _, f := range flags { |
| 408 | if strings.Contains(f, "sanitize=implicit-integer-sign-change") { |
| 409 | return false |
| 410 | } |
| 411 | } |
| 412 | for _, f := range flags { |
| 413 | if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") { |
| 414 | return true |
| 415 | } |
| 416 | } |
| 417 | return false |
| 418 | } |
| 419 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 420 | func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags { |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 421 | minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a" |
| 422 | minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 423 | |
| 424 | if ctx.Device() && sanitize.Properties.MinimalRuntimeDep { |
| 425 | flags.LdFlags = append(flags.LdFlags, minimalRuntimePath) |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 426 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 427 | } |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 428 | if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 429 | return flags |
| 430 | } |
| 431 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 432 | if Bool(sanitize.Properties.Sanitize.Address) { |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 433 | if ctx.Arch().ArchType == android.Arm { |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 434 | // Frame pointer based unwinder in ASan requires ARM frame setup. |
| 435 | // TODO: put in flags? |
| 436 | flags.RequiredInstructionSet = "arm" |
| 437 | } |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 438 | flags.CFlags = append(flags.CFlags, asanCflags...) |
| 439 | flags.LdFlags = append(flags.LdFlags, asanLdflags...) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 440 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 441 | if ctx.Host() { |
| 442 | // -nodefaultlibs (provided with libc++) prevents the driver from linking |
| 443 | // libraries needed with -fsanitize=address. http://b/18650275 (WAI) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 444 | flags.LdFlags = append(flags.LdFlags, "-Wl,--no-as-needed") |
| 445 | } else { |
| 446 | flags.CFlags = append(flags.CFlags, "-mllvm", "-asan-globals=0") |
| 447 | flags.DynamicLinker = "/system/bin/linker_asan" |
| 448 | if flags.Toolchain.Is64Bit() { |
| 449 | flags.DynamicLinker += "64" |
| 450 | } |
| 451 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 452 | } |
| 453 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 454 | if Bool(sanitize.Properties.Sanitize.Hwaddress) { |
| 455 | flags.CFlags = append(flags.CFlags, hwasanCflags...) |
Yabin Cui | 6be405e | 2017-10-19 15:52:11 -0700 | [diff] [blame] | 456 | } |
| 457 | |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 458 | if Bool(sanitize.Properties.Sanitize.Coverage) { |
Zach Riggle | 06bbd89 | 2017-08-21 17:12:32 -0400 | [diff] [blame] | 459 | flags.CFlags = append(flags.CFlags, "-fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp") |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 460 | } |
| 461 | |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 462 | if Bool(sanitize.Properties.Sanitize.Cfi) { |
Evgenii Stepanov | 7ebf9fa | 2017-01-20 14:13:06 -0800 | [diff] [blame] | 463 | if ctx.Arch().ArchType == android.Arm { |
| 464 | // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up |
| 465 | // to do this on a function basis, so force Thumb on the entire module. |
| 466 | flags.RequiredInstructionSet = "thumb" |
| 467 | } |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 468 | |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 469 | flags.CFlags = append(flags.CFlags, cfiCflags...) |
Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 470 | flags.AsFlags = append(flags.AsFlags, cfiAsflags...) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 471 | // Only append the default visibility flag if -fvisibility has not already been set |
| 472 | // to hidden. |
| 473 | if !inList("-fvisibility=hidden", flags.CFlags) { |
| 474 | flags.CFlags = append(flags.CFlags, "-fvisibility=default") |
| 475 | } |
Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 476 | flags.LdFlags = append(flags.LdFlags, cfiLdflags...) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 477 | |
| 478 | if ctx.staticBinary() { |
| 479 | _, flags.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.CFlags) |
| 480 | _, flags.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.LdFlags) |
| 481 | } |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 482 | } |
| 483 | |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 484 | if Bool(sanitize.Properties.Sanitize.Integer_overflow) { |
Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 485 | flags.CFlags = append(flags.CFlags, intOverflowCflags...) |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 486 | } |
| 487 | |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 488 | if len(sanitize.Properties.Sanitizers) > 0 { |
| 489 | sanitizeArg := "-fsanitize=" + strings.Join(sanitize.Properties.Sanitizers, ",") |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 490 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 491 | flags.CFlags = append(flags.CFlags, sanitizeArg) |
Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 492 | flags.AsFlags = append(flags.AsFlags, sanitizeArg) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 493 | if ctx.Host() { |
| 494 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-recover=all") |
| 495 | flags.LdFlags = append(flags.LdFlags, sanitizeArg) |
Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 496 | // Host sanitizers only link symbols in the final executable, so |
| 497 | // there will always be undefined symbols in intermediate libraries. |
| 498 | _, flags.LdFlags = removeFromList("-Wl,--no-undefined", flags.LdFlags) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 499 | } else { |
Colin Cross | 263abbd | 2016-07-15 13:10:48 -0700 | [diff] [blame] | 500 | flags.CFlags = append(flags.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort") |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 501 | |
| 502 | if enableMinimalRuntime(sanitize) { |
| 503 | flags.CFlags = append(flags.CFlags, strings.Join(minimalRuntimeFlags, " ")) |
| 504 | flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...) |
Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 505 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 506 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 507 | } |
Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 508 | // http://b/119329758, Android core does not boot up with this sanitizer yet. |
| 509 | if toDisableImplicitIntegerChange(flags.CFlags) { |
| 510 | flags.CFlags = append(flags.CFlags, "-fno-sanitize=implicit-integer-sign-change") |
| 511 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 512 | } |
| 513 | |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 514 | if len(sanitize.Properties.DiagSanitizers) > 0 { |
| 515 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-trap="+strings.Join(sanitize.Properties.DiagSanitizers, ",")) |
Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 516 | } |
| 517 | // FIXME: enable RTTI if diag + (cfi or vptr) |
| 518 | |
Andreas Gampe | 9707116 | 2017-05-08 13:15:23 -0700 | [diff] [blame] | 519 | if sanitize.Properties.Sanitize.Recover != nil { |
| 520 | flags.CFlags = append(flags.CFlags, "-fsanitize-recover="+ |
| 521 | strings.Join(sanitize.Properties.Sanitize.Recover, ",")) |
| 522 | } |
| 523 | |
Ivan Lozano | 7929bba | 2018-12-12 09:36:31 -0800 | [diff] [blame] | 524 | if sanitize.Properties.Sanitize.Diag.No_recover != nil { |
| 525 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-recover="+ |
| 526 | strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ",")) |
| 527 | } |
| 528 | |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 529 | blacklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blacklist) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 530 | if blacklist.Valid() { |
| 531 | flags.CFlags = append(flags.CFlags, "-fsanitize-blacklist="+blacklist.String()) |
| 532 | flags.CFlagsDeps = append(flags.CFlagsDeps, blacklist.Path()) |
| 533 | } |
| 534 | |
| 535 | return flags |
| 536 | } |
| 537 | |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 538 | func (sanitize *sanitize) AndroidMk(ctx AndroidMkContext, ret *android.AndroidMkData) { |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 539 | // Add a suffix for CFI-enabled static libraries to allow surfacing both to make without a |
| 540 | // name conflict. |
| 541 | if ret.Class == "STATIC_LIBRARIES" && Bool(sanitize.Properties.Sanitize.Cfi) { |
| 542 | ret.SubName += ".cfi" |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 543 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 544 | if ret.Class == "STATIC_LIBRARIES" && Bool(sanitize.Properties.Sanitize.Hwaddress) { |
| 545 | ret.SubName += ".hwasan" |
| 546 | } |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 547 | if ret.Class == "STATIC_LIBRARIES" && Bool(sanitize.Properties.Sanitize.Scs) { |
| 548 | ret.SubName += ".scs" |
| 549 | } |
Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 550 | } |
| 551 | |
Vishwath Mohan | 1dd8839 | 2017-03-29 22:00:18 -0700 | [diff] [blame] | 552 | func (sanitize *sanitize) inSanitizerDir() bool { |
| 553 | return sanitize.Properties.InSanitizerDir |
Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 554 | } |
| 555 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 556 | func (sanitize *sanitize) getSanitizerBoolPtr(t sanitizerType) *bool { |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 557 | switch t { |
| 558 | case asan: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 559 | return sanitize.Properties.Sanitize.Address |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 560 | case hwasan: |
| 561 | return sanitize.Properties.Sanitize.Hwaddress |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 562 | case tsan: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 563 | return sanitize.Properties.Sanitize.Thread |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 564 | case intOverflow: |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 565 | return sanitize.Properties.Sanitize.Integer_overflow |
| 566 | case cfi: |
| 567 | return sanitize.Properties.Sanitize.Cfi |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 568 | case scs: |
| 569 | return sanitize.Properties.Sanitize.Scs |
Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 570 | default: |
| 571 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 572 | } |
| 573 | } |
| 574 | |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 575 | func (sanitize *sanitize) isUnsanitizedVariant() bool { |
| 576 | return !sanitize.isSanitizerEnabled(asan) && |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 577 | !sanitize.isSanitizerEnabled(hwasan) && |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 578 | !sanitize.isSanitizerEnabled(tsan) && |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 579 | !sanitize.isSanitizerEnabled(cfi) && |
| 580 | !sanitize.isSanitizerEnabled(scs) |
Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 581 | } |
| 582 | |
Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 583 | func (sanitize *sanitize) isVariantOnProductionDevice() bool { |
| 584 | return !sanitize.isSanitizerEnabled(asan) && |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 585 | !sanitize.isSanitizerEnabled(hwasan) && |
Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 586 | !sanitize.isSanitizerEnabled(tsan) |
| 587 | } |
| 588 | |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 589 | func (sanitize *sanitize) SetSanitizer(t sanitizerType, b bool) { |
| 590 | switch t { |
| 591 | case asan: |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 592 | sanitize.Properties.Sanitize.Address = boolPtr(b) |
Colin Cross | 91169fe | 2016-08-11 15:54:20 -0700 | [diff] [blame] | 593 | if !b { |
| 594 | sanitize.Properties.Sanitize.Coverage = nil |
| 595 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 596 | case hwasan: |
| 597 | sanitize.Properties.Sanitize.Hwaddress = boolPtr(b) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 598 | case tsan: |
Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 599 | sanitize.Properties.Sanitize.Thread = boolPtr(b) |
Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 600 | case intOverflow: |
| 601 | sanitize.Properties.Sanitize.Integer_overflow = boolPtr(b) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 602 | case cfi: |
| 603 | sanitize.Properties.Sanitize.Cfi = boolPtr(b) |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 604 | case scs: |
| 605 | sanitize.Properties.Sanitize.Scs = boolPtr(b) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 606 | default: |
| 607 | panic(fmt.Errorf("unknown sanitizerType %d", t)) |
| 608 | } |
| 609 | if b { |
| 610 | sanitize.Properties.SanitizerEnabled = true |
| 611 | } |
| 612 | } |
| 613 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 614 | // Check if the sanitizer is explicitly disabled (as opposed to nil by |
| 615 | // virtue of not being set). |
| 616 | func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t sanitizerType) bool { |
| 617 | if sanitize == nil { |
| 618 | return false |
| 619 | } |
| 620 | |
| 621 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 622 | return sanitizerVal != nil && *sanitizerVal == false |
| 623 | } |
| 624 | |
| 625 | // There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled) |
| 626 | // because enabling a sanitizer either directly (via the blueprint) or |
| 627 | // indirectly (via a mutator) sets the bool ptr to true, and you can't |
| 628 | // distinguish between the cases. It isn't needed though - both cases can be |
| 629 | // treated identically. |
| 630 | func (sanitize *sanitize) isSanitizerEnabled(t sanitizerType) bool { |
| 631 | if sanitize == nil { |
| 632 | return false |
| 633 | } |
| 634 | |
| 635 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) |
| 636 | return sanitizerVal != nil && *sanitizerVal == true |
| 637 | } |
| 638 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 639 | func isSanitizableDependencyTag(tag blueprint.DependencyTag) bool { |
| 640 | t, ok := tag.(dependencyTag) |
| 641 | return ok && t.library || t == reuseObjTag |
| 642 | } |
| 643 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 644 | // Propagate sanitizer requirements down from binaries |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 645 | func sanitizerDepsMutator(t sanitizerType) func(android.TopDownMutatorContext) { |
| 646 | return func(mctx android.TopDownMutatorContext) { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 647 | if c, ok := mctx.Module().(*Module); ok && c.sanitize.isSanitizerEnabled(t) { |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 648 | mctx.WalkDeps(func(child, parent android.Module) bool { |
| 649 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { |
| 650 | return false |
| 651 | } |
| 652 | if d, ok := child.(*Module); ok && d.sanitize != nil && |
Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 653 | !Bool(d.sanitize.Properties.Sanitize.Never) && |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 654 | !d.sanitize.isSanitizerExplicitlyDisabled(t) { |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 655 | if t == cfi || t == hwasan || t == scs { |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 656 | if d.static() { |
| 657 | d.sanitize.Properties.SanitizeDep = true |
| 658 | } |
| 659 | } else { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 660 | d.sanitize.Properties.SanitizeDep = true |
| 661 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 662 | } |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 663 | return true |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 664 | }) |
| 665 | } |
| 666 | } |
| 667 | } |
| 668 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 669 | // Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies. |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 670 | func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) { |
| 671 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
| 672 | mctx.WalkDeps(func(child, parent android.Module) bool { |
| 673 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { |
| 674 | return false |
| 675 | } |
| 676 | if d, ok := child.(*Module); ok && d.static() && d.sanitize != nil { |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 677 | |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 678 | if enableMinimalRuntime(d.sanitize) { |
| 679 | // If a static dependency is built with the minimal runtime, |
| 680 | // make sure we include the ubsan minimal runtime. |
| 681 | c.sanitize.Properties.MinimalRuntimeDep = true |
| 682 | } else if Bool(d.sanitize.Properties.Sanitize.Diag.Integer_overflow) || |
| 683 | len(d.sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0 { |
| 684 | // If a static dependency runs with full ubsan diagnostics, |
| 685 | // make sure we include the ubsan runtime. |
| 686 | c.sanitize.Properties.UbsanRuntimeDep = true |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 687 | } |
Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 688 | } |
| 689 | return true |
| 690 | }) |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 691 | } |
| 692 | } |
| 693 | |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 694 | // Add the dependency to the runtime library for each of the sanitizer variants |
| 695 | func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 696 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
Pirama Arumuga Nainar | 6aa2102 | 2019-01-25 00:20:35 +0000 | [diff] [blame] | 697 | if !c.Enabled() { |
| 698 | return |
| 699 | } |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 700 | var sanitizers []string |
| 701 | var diagSanitizers []string |
| 702 | |
| 703 | if Bool(c.sanitize.Properties.Sanitize.All_undefined) { |
| 704 | sanitizers = append(sanitizers, "undefined") |
| 705 | } else { |
| 706 | if Bool(c.sanitize.Properties.Sanitize.Undefined) { |
| 707 | sanitizers = append(sanitizers, |
| 708 | "bool", |
| 709 | "integer-divide-by-zero", |
| 710 | "return", |
| 711 | "returns-nonnull-attribute", |
| 712 | "shift-exponent", |
| 713 | "unreachable", |
| 714 | "vla-bound", |
| 715 | // TODO(danalbert): The following checks currently have compiler performance issues. |
| 716 | //"alignment", |
| 717 | //"bounds", |
| 718 | //"enum", |
| 719 | //"float-cast-overflow", |
| 720 | //"float-divide-by-zero", |
| 721 | //"nonnull-attribute", |
| 722 | //"null", |
| 723 | //"shift-base", |
| 724 | //"signed-integer-overflow", |
| 725 | // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on. |
| 726 | // https://llvm.org/PR19302 |
| 727 | // http://reviews.llvm.org/D6974 |
| 728 | // "object-size", |
| 729 | ) |
| 730 | } |
| 731 | sanitizers = append(sanitizers, c.sanitize.Properties.Sanitize.Misc_undefined...) |
| 732 | } |
| 733 | |
| 734 | if Bool(c.sanitize.Properties.Sanitize.Diag.Undefined) { |
| 735 | diagSanitizers = append(diagSanitizers, "undefined") |
| 736 | } |
| 737 | |
| 738 | diagSanitizers = append(diagSanitizers, c.sanitize.Properties.Sanitize.Diag.Misc_undefined...) |
| 739 | |
| 740 | if Bool(c.sanitize.Properties.Sanitize.Address) { |
| 741 | sanitizers = append(sanitizers, "address") |
| 742 | diagSanitizers = append(diagSanitizers, "address") |
| 743 | } |
| 744 | |
| 745 | if Bool(c.sanitize.Properties.Sanitize.Hwaddress) { |
| 746 | sanitizers = append(sanitizers, "hwaddress") |
| 747 | } |
| 748 | |
| 749 | if Bool(c.sanitize.Properties.Sanitize.Thread) { |
| 750 | sanitizers = append(sanitizers, "thread") |
| 751 | } |
| 752 | |
| 753 | if Bool(c.sanitize.Properties.Sanitize.Safestack) { |
| 754 | sanitizers = append(sanitizers, "safe-stack") |
| 755 | } |
| 756 | |
| 757 | if Bool(c.sanitize.Properties.Sanitize.Cfi) { |
| 758 | sanitizers = append(sanitizers, "cfi") |
| 759 | |
| 760 | if Bool(c.sanitize.Properties.Sanitize.Diag.Cfi) { |
| 761 | diagSanitizers = append(diagSanitizers, "cfi") |
| 762 | } |
| 763 | } |
| 764 | |
| 765 | if Bool(c.sanitize.Properties.Sanitize.Integer_overflow) { |
| 766 | sanitizers = append(sanitizers, "unsigned-integer-overflow") |
| 767 | sanitizers = append(sanitizers, "signed-integer-overflow") |
| 768 | if Bool(c.sanitize.Properties.Sanitize.Diag.Integer_overflow) { |
| 769 | diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow") |
| 770 | diagSanitizers = append(diagSanitizers, "signed-integer-overflow") |
| 771 | } |
| 772 | } |
| 773 | |
| 774 | if Bool(c.sanitize.Properties.Sanitize.Scudo) { |
| 775 | sanitizers = append(sanitizers, "scudo") |
| 776 | } |
| 777 | |
| 778 | if Bool(c.sanitize.Properties.Sanitize.Scs) { |
| 779 | sanitizers = append(sanitizers, "shadow-call-stack") |
| 780 | } |
| 781 | |
| 782 | // Save the list of sanitizers. These will be used again when generating |
| 783 | // the build rules (for Cflags, etc.) |
| 784 | c.sanitize.Properties.Sanitizers = sanitizers |
| 785 | c.sanitize.Properties.DiagSanitizers = diagSanitizers |
| 786 | |
| 787 | // Determine the runtime library required |
| 788 | runtimeLibrary := "" |
| 789 | toolchain := c.toolchain(mctx) |
| 790 | if Bool(c.sanitize.Properties.Sanitize.Address) { |
| 791 | runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain) |
| 792 | } else if Bool(c.sanitize.Properties.Sanitize.Hwaddress) { |
| 793 | if c.staticBinary() { |
| 794 | runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain) |
| 795 | } else { |
| 796 | runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain) |
| 797 | } |
| 798 | } else if Bool(c.sanitize.Properties.Sanitize.Thread) { |
| 799 | runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain) |
| 800 | } else if Bool(c.sanitize.Properties.Sanitize.Scudo) { |
| 801 | if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep { |
| 802 | runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain) |
| 803 | } else { |
| 804 | runtimeLibrary = config.ScudoRuntimeLibrary(toolchain) |
| 805 | } |
| 806 | } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep { |
| 807 | runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain) |
| 808 | } |
| 809 | |
| 810 | if mctx.Device() && runtimeLibrary != "" { |
Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 811 | if inList(runtimeLibrary, llndkLibraries) && !c.static() && c.useVndk() { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 812 | runtimeLibrary = runtimeLibrary + llndkLibrarySuffix |
| 813 | } |
| 814 | |
| 815 | // Adding dependency to the runtime library. We are using *FarVariation* |
| 816 | // because the runtime libraries themselves are not mutated by sanitizer |
| 817 | // mutators and thus don't have sanitizer variants whereas this module |
| 818 | // has been already mutated. |
| 819 | // |
| 820 | // Note that by adding dependency with {static|shared}DepTag, the lib is |
| 821 | // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module |
| 822 | if c.staticBinary() { |
| 823 | // static executable gets static runtime libs |
| 824 | mctx.AddFarVariationDependencies([]blueprint.Variation{ |
| 825 | {Mutator: "link", Variation: "static"}, |
Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 826 | {Mutator: "image", Variation: c.imageVariation()}, |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 827 | {Mutator: "arch", Variation: mctx.Target().String()}, |
| 828 | }, staticDepTag, runtimeLibrary) |
| 829 | } else if !c.static() { |
Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 830 | // dynamic executable and shared libs get shared runtime libs |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 831 | mctx.AddFarVariationDependencies([]blueprint.Variation{ |
| 832 | {Mutator: "link", Variation: "shared"}, |
Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 833 | {Mutator: "image", Variation: c.imageVariation()}, |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 834 | {Mutator: "arch", Variation: mctx.Target().String()}, |
Jiyong Park | 64a44f2 | 2019-01-18 14:37:08 +0900 | [diff] [blame] | 835 | }, earlySharedDepTag, runtimeLibrary) |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 836 | } |
| 837 | // static lib does not have dependency to the runtime library. The |
| 838 | // dependency will be added to the executables or shared libs using |
| 839 | // the static lib. |
| 840 | } |
| 841 | } |
| 842 | } |
| 843 | |
| 844 | type Sanitizeable interface { |
| 845 | android.Module |
Jiyong Park | 388ef3f | 2019-01-28 19:47:32 +0900 | [diff] [blame] | 846 | IsSanitizerEnabled(ctx android.BaseModuleContext, sanitizerName string) bool |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 847 | } |
| 848 | |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 849 | // Create sanitized variants for modules that need them |
Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 850 | func sanitizerMutator(t sanitizerType) func(android.BottomUpMutatorContext) { |
| 851 | return func(mctx android.BottomUpMutatorContext) { |
Vishwath Mohan | e615345 | 2017-08-11 00:52:44 +0000 | [diff] [blame] | 852 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 853 | if c.isDependencyRoot() && c.sanitize.isSanitizerEnabled(t) { |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame^] | 854 | modules := mctx.CreateVariations(t.variationName()) |
Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 855 | modules[0].(*Module).sanitize.SetSanitizer(t, true) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 856 | } else if c.sanitize.isSanitizerEnabled(t) || c.sanitize.Properties.SanitizeDep { |
| 857 | // Save original sanitizer status before we assign values to variant |
| 858 | // 0 as that overwrites the original. |
| 859 | isSanitizerEnabled := c.sanitize.isSanitizerEnabled(t) |
| 860 | |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame^] | 861 | modules := mctx.CreateVariations("", t.variationName()) |
Colin Cross | b0f2895 | 2016-09-19 16:46:53 -0700 | [diff] [blame] | 862 | modules[0].(*Module).sanitize.SetSanitizer(t, false) |
| 863 | modules[1].(*Module).sanitize.SetSanitizer(t, true) |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 864 | |
Colin Cross | b0f2895 | 2016-09-19 16:46:53 -0700 | [diff] [blame] | 865 | modules[0].(*Module).sanitize.Properties.SanitizeDep = false |
| 866 | modules[1].(*Module).sanitize.Properties.SanitizeDep = false |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 867 | |
| 868 | // We don't need both variants active for anything but CFI-enabled |
| 869 | // target static libraries, so suppress the appropriate variant in |
| 870 | // all other cases. |
| 871 | if t == cfi { |
| 872 | if c.static() { |
| 873 | if !mctx.Device() { |
| 874 | if isSanitizerEnabled { |
| 875 | modules[0].(*Module).Properties.PreventInstall = true |
| 876 | modules[0].(*Module).Properties.HideFromMake = true |
| 877 | } else { |
| 878 | modules[1].(*Module).Properties.PreventInstall = true |
| 879 | modules[1].(*Module).Properties.HideFromMake = true |
| 880 | } |
| 881 | } else { |
Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 882 | cfiStaticLibs := cfiStaticLibs(mctx.Config()) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 883 | |
| 884 | cfiStaticLibsMutex.Lock() |
| 885 | *cfiStaticLibs = append(*cfiStaticLibs, c.Name()) |
| 886 | cfiStaticLibsMutex.Unlock() |
| 887 | } |
| 888 | } else { |
| 889 | modules[0].(*Module).Properties.PreventInstall = true |
| 890 | modules[0].(*Module).Properties.HideFromMake = true |
| 891 | } |
| 892 | } else if t == asan { |
| 893 | if mctx.Device() { |
| 894 | // CFI and ASAN are currently mutually exclusive so disable |
| 895 | // CFI if this is an ASAN variant. |
Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 896 | modules[1].(*Module).sanitize.Properties.InSanitizerDir = true |
| 897 | modules[1].(*Module).sanitize.SetSanitizer(cfi, false) |
| 898 | } |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 899 | if isSanitizerEnabled { |
| 900 | modules[0].(*Module).Properties.PreventInstall = true |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 901 | modules[0].(*Module).Properties.HideFromMake = true |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 902 | } else { |
| 903 | modules[1].(*Module).Properties.PreventInstall = true |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 904 | modules[1].(*Module).Properties.HideFromMake = true |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 905 | } |
Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 906 | } else if t == scs { |
| 907 | // We don't currently link any static libraries built with make into |
| 908 | // libraries built with SCS, so we don't need logic for propagating |
| 909 | // SCSness of dependencies into make. |
| 910 | if !c.static() { |
| 911 | if isSanitizerEnabled { |
| 912 | modules[0].(*Module).Properties.PreventInstall = true |
| 913 | modules[0].(*Module).Properties.HideFromMake = true |
| 914 | } else { |
| 915 | modules[1].(*Module).Properties.PreventInstall = true |
| 916 | modules[1].(*Module).Properties.HideFromMake = true |
| 917 | } |
| 918 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 919 | } else if t == hwasan { |
| 920 | if mctx.Device() { |
| 921 | // CFI and HWASAN are currently mutually exclusive so disable |
| 922 | // CFI if this is an HWASAN variant. |
| 923 | modules[1].(*Module).sanitize.SetSanitizer(cfi, false) |
| 924 | } |
| 925 | |
| 926 | if c.static() { |
| 927 | if c.useVndk() { |
| 928 | hwasanVendorStaticLibs := hwasanVendorStaticLibs(mctx.Config()) |
| 929 | hwasanStaticLibsMutex.Lock() |
| 930 | *hwasanVendorStaticLibs = append(*hwasanVendorStaticLibs, c.Name()) |
| 931 | hwasanStaticLibsMutex.Unlock() |
| 932 | } else { |
| 933 | hwasanStaticLibs := hwasanStaticLibs(mctx.Config()) |
| 934 | hwasanStaticLibsMutex.Lock() |
| 935 | *hwasanStaticLibs = append(*hwasanStaticLibs, c.Name()) |
| 936 | hwasanStaticLibsMutex.Unlock() |
| 937 | } |
| 938 | } else { |
| 939 | if isSanitizerEnabled { |
| 940 | modules[0].(*Module).Properties.PreventInstall = true |
| 941 | modules[0].(*Module).Properties.HideFromMake = true |
| 942 | } else { |
| 943 | modules[1].(*Module).Properties.PreventInstall = true |
| 944 | modules[1].(*Module).Properties.HideFromMake = true |
| 945 | } |
| 946 | } |
Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 947 | } |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 948 | } |
| 949 | c.sanitize.Properties.SanitizeDep = false |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame^] | 950 | } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok && sanitizeable.IsSanitizerEnabled(mctx, t.name()) { |
Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 951 | // APEX modules fall here |
Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame^] | 952 | mctx.CreateVariations(t.variationName()) |
Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 953 | } |
| 954 | } |
| 955 | } |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 956 | |
| 957 | func cfiStaticLibs(config android.Config) *[]string { |
| 958 | return config.Once("cfiStaticLibs", func() interface{} { |
| 959 | return &[]string{} |
| 960 | }).(*[]string) |
| 961 | } |
| 962 | |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 963 | func hwasanStaticLibs(config android.Config) *[]string { |
| 964 | return config.Once("hwasanStaticLibs", func() interface{} { |
| 965 | return &[]string{} |
| 966 | }).(*[]string) |
| 967 | } |
| 968 | |
| 969 | func hwasanVendorStaticLibs(config android.Config) *[]string { |
| 970 | return config.Once("hwasanVendorStaticLibs", func() interface{} { |
| 971 | return &[]string{} |
| 972 | }).(*[]string) |
| 973 | } |
| 974 | |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 975 | func enableMinimalRuntime(sanitize *sanitize) bool { |
| 976 | if !Bool(sanitize.Properties.Sanitize.Address) && |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 977 | !Bool(sanitize.Properties.Sanitize.Hwaddress) && |
Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 978 | (Bool(sanitize.Properties.Sanitize.Integer_overflow) || |
| 979 | len(sanitize.Properties.Sanitize.Misc_undefined) > 0) && |
| 980 | !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) || |
| 981 | Bool(sanitize.Properties.Sanitize.Diag.Cfi) || |
| 982 | len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) { |
| 983 | return true |
| 984 | } |
| 985 | return false |
| 986 | } |
| 987 | |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 988 | func cfiMakeVarsProvider(ctx android.MakeVarsContext) { |
| 989 | cfiStaticLibs := cfiStaticLibs(ctx.Config()) |
Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 990 | sort.Strings(*cfiStaticLibs) |
Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 991 | ctx.Strict("SOONG_CFI_STATIC_LIBRARIES", strings.Join(*cfiStaticLibs, " ")) |
| 992 | } |
Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 993 | |
| 994 | func hwasanMakeVarsProvider(ctx android.MakeVarsContext) { |
| 995 | hwasanStaticLibs := hwasanStaticLibs(ctx.Config()) |
| 996 | sort.Strings(*hwasanStaticLibs) |
| 997 | ctx.Strict("SOONG_HWASAN_STATIC_LIBRARIES", strings.Join(*hwasanStaticLibs, " ")) |
| 998 | |
| 999 | hwasanVendorStaticLibs := hwasanVendorStaticLibs(ctx.Config()) |
| 1000 | sort.Strings(*hwasanVendorStaticLibs) |
| 1001 | ctx.Strict("SOONG_HWASAN_VENDOR_STATIC_LIBRARIES", strings.Join(*hwasanVendorStaticLibs, " ")) |
| 1002 | } |