blob: e4a7fbed20f1ae763e5c021a1ef9a27cd4aadb15 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Nan Zhang61eaedb2017-11-02 13:28:15 -070021 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070022 "strings"
23 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070024
Colin Crossa4f08812018-10-02 22:03:40 -070025 "android/soong/android"
26 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080027 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070028 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070029)
30
31var buildDir string
32
33func setUp() {
34 var err error
35 buildDir, err = ioutil.TempDir("", "soong_java_test")
36 if err != nil {
37 panic(err)
38 }
39}
40
41func tearDown() {
42 os.RemoveAll(buildDir)
43}
44
45func TestMain(m *testing.M) {
46 run := func() int {
47 setUp()
48 defer tearDown()
49
50 return m.Run()
51 }
52
53 os.Exit(run())
54}
Colin Cross527012a2017-11-30 22:56:16 -080055
56func testConfig(env map[string]string) android.Config {
Colin Crosse4759b92019-02-15 10:37:39 -080057 return TestConfig(buildDir, env)
Colin Cross1369cdb2017-09-29 17:58:17 -070058}
59
Colin Cross527012a2017-11-30 22:56:16 -080060func testContext(config android.Config, bp string,
61 fs map[string][]byte) *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070062
Colin Cross4c428df2017-09-15 17:36:05 -070063 ctx := android.NewTestArchContext()
Colin Cross72bb3632017-07-13 16:23:21 -070064 ctx.RegisterModuleType("android_app", android.ModuleFactoryAdaptor(AndroidAppFactory))
Jaewoong Jung2ad817c2019-01-18 14:27:16 -080065 ctx.RegisterModuleType("android_app_certificate", android.ModuleFactoryAdaptor(AndroidAppCertificateFactory))
Colin Crossa97c5d32018-03-28 14:58:31 -070066 ctx.RegisterModuleType("android_library", android.ModuleFactoryAdaptor(AndroidLibraryFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070067 ctx.RegisterModuleType("android_test", android.ModuleFactoryAdaptor(AndroidTestFactory))
Colin Cross638149e2019-01-05 22:12:12 -080068 ctx.RegisterModuleType("android_test_helper_app", android.ModuleFactoryAdaptor(AndroidTestHelperAppFactory))
69 ctx.RegisterModuleType("java_binary", android.ModuleFactoryAdaptor(BinaryFactory))
Colin Cross6b4a32d2017-12-05 13:42:45 -080070 ctx.RegisterModuleType("java_binary_host", android.ModuleFactoryAdaptor(BinaryHostFactory))
Colin Cross3d7c9822019-03-01 13:46:24 -080071 ctx.RegisterModuleType("java_device_for_host", android.ModuleFactoryAdaptor(DeviceForHostFactory))
72 ctx.RegisterModuleType("java_host_for_device", android.ModuleFactoryAdaptor(HostForDeviceFactory))
Colin Cross9ae1b922018-06-26 17:59:05 -070073 ctx.RegisterModuleType("java_library", android.ModuleFactoryAdaptor(LibraryFactory))
Colin Cross2acdae82017-09-15 19:44:24 -070074 ctx.RegisterModuleType("java_library_host", android.ModuleFactoryAdaptor(LibraryHostFactory))
Colin Cross638149e2019-01-05 22:12:12 -080075 ctx.RegisterModuleType("java_test", android.ModuleFactoryAdaptor(TestFactory))
Colin Cross74d73e22017-08-02 11:05:49 -070076 ctx.RegisterModuleType("java_import", android.ModuleFactoryAdaptor(ImportFactory))
Colin Cross3d7c9822019-03-01 13:46:24 -080077 ctx.RegisterModuleType("java_import_host", android.ModuleFactoryAdaptor(ImportFactoryHost))
Colin Cross89536d42017-07-07 14:35:50 -070078 ctx.RegisterModuleType("java_defaults", android.ModuleFactoryAdaptor(defaultsFactory))
Colin Cross1369cdb2017-09-29 17:58:17 -070079 ctx.RegisterModuleType("java_system_modules", android.ModuleFactoryAdaptor(SystemModulesFactory))
Colin Cross54250902017-12-05 09:28:08 -080080 ctx.RegisterModuleType("java_genrule", android.ModuleFactoryAdaptor(genRuleFactory))
Colin Crossbe9cdb82019-01-21 21:37:16 -080081 ctx.RegisterModuleType("java_plugin", android.ModuleFactoryAdaptor(PluginFactory))
Colin Cross42be7612019-02-21 18:12:14 -080082 ctx.RegisterModuleType("dex_import", android.ModuleFactoryAdaptor(DexImportFactory))
Pirama Arumuga Nainar955dc492018-04-17 14:58:42 -070083 ctx.RegisterModuleType("filegroup", android.ModuleFactoryAdaptor(android.FileGroupFactory))
Colin Cross54190b32017-10-09 15:34:10 -070084 ctx.RegisterModuleType("genrule", android.ModuleFactoryAdaptor(genrule.GenRuleFactory))
Nan Zhang581fd212018-01-10 16:06:12 -080085 ctx.RegisterModuleType("droiddoc", android.ModuleFactoryAdaptor(DroiddocFactory))
86 ctx.RegisterModuleType("droiddoc_host", android.ModuleFactoryAdaptor(DroiddocHostFactory))
Nan Zhangf4936b02018-08-01 15:00:28 -070087 ctx.RegisterModuleType("droiddoc_template", android.ModuleFactoryAdaptor(ExportedDroiddocDirFactory))
Inseob Kimc0907f12019-02-08 21:00:45 +090088 ctx.RegisterModuleType("java_sdk_library", android.ModuleFactoryAdaptor(SdkLibraryFactory))
Colin Cross79c7c262019-04-17 11:11:46 -070089 ctx.RegisterModuleType("java_sdk_library_import", android.ModuleFactoryAdaptor(sdkLibraryImportFactory))
Jaewoong Jung525443a2019-02-28 15:35:54 -080090 ctx.RegisterModuleType("override_android_app", android.ModuleFactoryAdaptor(OverrideAndroidAppModuleFactory))
Inseob Kimc0907f12019-02-08 21:00:45 +090091 ctx.RegisterModuleType("prebuilt_apis", android.ModuleFactoryAdaptor(PrebuiltApisFactory))
Colin Cross5ea9bcc2017-07-27 15:41:32 -070092 ctx.PreArchMutators(android.RegisterPrebuiltsPreArchMutators)
93 ctx.PreArchMutators(android.RegisterPrebuiltsPostDepsMutators)
Colin Cross89536d42017-07-07 14:35:50 -070094 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Jaewoong Jung525443a2019-02-28 15:35:54 -080095 ctx.PreArchMutators(android.RegisterOverridePreArchMutators)
Jiyong Parkc678ad32018-04-10 13:07:10 +090096 ctx.PreArchMutators(func(ctx android.RegisterMutatorsContext) {
Inseob Kimc0907f12019-02-08 21:00:45 +090097 ctx.TopDown("prebuilt_apis", PrebuiltApisMutator).Parallel()
Jiyong Parkc678ad32018-04-10 13:07:10 +090098 })
Colin Cross3bc7ffa2017-11-22 16:19:37 -080099 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -0700100 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -0700101
102 // Register module types and mutators from cc needed for JNI testing
103 ctx.RegisterModuleType("cc_library", android.ModuleFactoryAdaptor(cc.LibraryFactory))
104 ctx.RegisterModuleType("cc_object", android.ModuleFactoryAdaptor(cc.ObjectFactory))
105 ctx.RegisterModuleType("toolchain_library", android.ModuleFactoryAdaptor(cc.ToolchainLibraryFactory))
Colin Cross47fa9d32019-03-26 10:51:39 -0700106 ctx.RegisterModuleType("llndk_library", android.ModuleFactoryAdaptor(cc.LlndkLibraryFactory))
Colin Crossa4f08812018-10-02 22:03:40 -0700107 ctx.PreDepsMutators(func(ctx android.RegisterMutatorsContext) {
108 ctx.BottomUp("link", cc.LinkageMutator).Parallel()
109 ctx.BottomUp("begin", cc.BeginMutator).Parallel()
110 })
111
Colin Crosse4759b92019-02-15 10:37:39 -0800112 bp += GatherRequiredDepsForTest()
Colin Cross1369cdb2017-09-29 17:58:17 -0700113
Colin Cross824bee32017-11-22 17:27:51 -0800114 mockFS := map[string][]byte{
Jiyong Park58c518b2018-05-12 22:29:12 +0900115 "Android.bp": []byte(bp),
116 "a.java": nil,
117 "b.java": nil,
118 "c.java": nil,
119 "b.kt": nil,
120 "a.jar": nil,
121 "b.jar": nil,
122 "java-res/a/a": nil,
123 "java-res/b/b": nil,
124 "java-res2/a": nil,
125 "java-fg/a.java": nil,
126 "java-fg/b.java": nil,
127 "java-fg/c.java": nil,
128 "api/current.txt": nil,
129 "api/removed.txt": nil,
130 "api/system-current.txt": nil,
131 "api/system-removed.txt": nil,
132 "api/test-current.txt": nil,
133 "api/test-removed.txt": nil,
Colin Cross3047fa22019-04-18 10:56:44 -0700134 "framework/aidl/a.aidl": nil,
Colin Cross0532fb02017-10-02 16:57:40 -0700135
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100136 "prebuilts/sdk/14/public/android.jar": nil,
137 "prebuilts/sdk/14/public/framework.aidl": nil,
138 "prebuilts/sdk/14/system/android.jar": nil,
Colin Cross98fd5742019-01-09 23:04:25 -0800139 "prebuilts/sdk/17/public/android.jar": nil,
140 "prebuilts/sdk/17/public/framework.aidl": nil,
141 "prebuilts/sdk/17/system/android.jar": nil,
Colin Crossff0daf42019-04-02 16:10:56 -0700142 "prebuilts/sdk/25/public/android.jar": nil,
143 "prebuilts/sdk/25/public/framework.aidl": nil,
144 "prebuilts/sdk/25/system/android.jar": nil,
Colin Cross86a60ae2018-05-29 14:44:55 -0700145 "prebuilts/sdk/current/core/android.jar": nil,
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100146 "prebuilts/sdk/current/public/android.jar": nil,
147 "prebuilts/sdk/current/public/framework.aidl": nil,
148 "prebuilts/sdk/current/public/core.jar": nil,
149 "prebuilts/sdk/current/system/android.jar": nil,
150 "prebuilts/sdk/current/test/android.jar": nil,
Jiyong Park58c518b2018-05-12 22:29:12 +0900151 "prebuilts/sdk/28/public/api/foo.txt": nil,
152 "prebuilts/sdk/28/system/api/foo.txt": nil,
153 "prebuilts/sdk/28/test/api/foo.txt": nil,
154 "prebuilts/sdk/28/public/api/foo-removed.txt": nil,
155 "prebuilts/sdk/28/system/api/foo-removed.txt": nil,
156 "prebuilts/sdk/28/test/api/foo-removed.txt": nil,
157 "prebuilts/sdk/28/public/api/bar.txt": nil,
158 "prebuilts/sdk/28/system/api/bar.txt": nil,
159 "prebuilts/sdk/28/test/api/bar.txt": nil,
160 "prebuilts/sdk/28/public/api/bar-removed.txt": nil,
161 "prebuilts/sdk/28/system/api/bar-removed.txt": nil,
162 "prebuilts/sdk/28/test/api/bar-removed.txt": nil,
Colin Cross86a60ae2018-05-29 14:44:55 -0700163 "prebuilts/sdk/tools/core-lambda-stubs.jar": nil,
Sundong Ahn27eecb92018-06-21 13:47:17 +0900164 "prebuilts/sdk/Android.bp": []byte(`prebuilt_apis { name: "sdk", api_dirs: ["14", "28", "current"],}`),
Colin Cross5ab4e6d2017-11-22 16:20:45 -0800165
166 // For framework-res, which is an implicit dependency for framework
Dan Willemsen412160e2019-04-09 21:36:26 -0700167 "AndroidManifest.xml": nil,
168 "build/make/target/product/security/testkey": nil,
Colin Cross6b4a32d2017-12-05 13:42:45 -0800169
170 "build/soong/scripts/jar-wrapper.sh": nil,
Colin Cross7fdd2b72018-01-02 18:14:25 -0800171
Colin Cross66dbc0b2017-12-28 12:23:20 -0800172 "build/make/core/proguard.flags": nil,
173 "build/make/core/proguard_basic_keeps.flags": nil,
174
Colin Cross7fdd2b72018-01-02 18:14:25 -0800175 "jdk8/jre/lib/jce.jar": nil,
176 "jdk8/jre/lib/rt.jar": nil,
Nan Zhang61819ce2018-05-04 18:49:16 -0700177 "jdk8/lib/tools.jar": nil,
Nan Zhang581fd212018-01-10 16:06:12 -0800178
179 "bar-doc/a.java": nil,
180 "bar-doc/b.java": nil,
Jiyong Park1e440682018-05-23 18:42:04 +0900181 "bar-doc/IFoo.aidl": nil,
Nan Zhang581fd212018-01-10 16:06:12 -0800182 "bar-doc/known_oj_tags.txt": nil,
183 "external/doclava/templates-sdk": nil,
Jaewoong Jung2ad817c2019-01-18 14:27:16 -0800184
185 "cert/new_cert.x509.pem": nil,
186 "cert/new_cert.pk8": nil,
Colin Cross824bee32017-11-22 17:27:51 -0800187 }
188
189 for k, v := range fs {
190 mockFS[k] = v
191 }
192
193 ctx.MockFileSystem(mockFS)
Colin Cross72bb3632017-07-13 16:23:21 -0700194
Colin Cross527012a2017-11-30 22:56:16 -0800195 return ctx
196}
197
198func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800199 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800200
201 pathCtx := android.PathContextForTesting(config, nil)
202 setDexpreoptTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
203
204 ctx.Register()
Jiyong Park58c518b2018-05-12 22:29:12 +0900205 _, errs := ctx.ParseFileList(".", []string{"Android.bp", "prebuilts/sdk/Android.bp"})
Logan Chien42039712018-03-12 16:29:17 +0800206 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700207 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800208 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800209}
210
211func testJava(t *testing.T, bp string) *android.TestContext {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800212 t.Helper()
Colin Cross527012a2017-11-30 22:56:16 -0800213 config := testConfig(nil)
214 ctx := testContext(config, bp, nil)
215 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700216
217 return ctx
218}
219
Colin Cross2acdae82017-09-15 19:44:24 -0700220func moduleToPath(name string) string {
221 switch {
222 case name == `""`:
223 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700224 case strings.HasSuffix(name, ".jar"):
225 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700226 default:
227 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700228 }
229}
230
Colin Cross72bb3632017-07-13 16:23:21 -0700231func TestSimple(t *testing.T) {
232 ctx := testJava(t, `
233 java_library {
234 name: "foo",
235 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700236 libs: ["bar"],
237 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700238 }
239
240 java_library {
241 name: "bar",
242 srcs: ["b.java"],
243 }
244
245 java_library {
246 name: "baz",
247 srcs: ["c.java"],
248 }
Colin Crossd5934c82017-10-02 13:55:26 -0700249 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700250
Colin Cross4c428df2017-09-15 17:36:05 -0700251 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700252 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700253
254 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
255 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
256 }
257
Colin Cross1ee23172017-10-18 14:44:18 -0700258 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700259 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
260 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700261
Nan Zhanged19fc32017-10-19 13:06:22 -0700262 if !strings.Contains(javac.Args["classpath"], barTurbine) {
263 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700264 }
265
Nan Zhanged19fc32017-10-19 13:06:22 -0700266 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
267 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700268 }
269
270 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
271 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700272 }
273}
274
Colin Crossd5934c82017-10-02 13:55:26 -0700275func TestArchSpecific(t *testing.T) {
276 ctx := testJava(t, `
277 java_library {
278 name: "foo",
279 srcs: ["a.java"],
280 target: {
281 android: {
282 srcs: ["b.java"],
283 },
284 },
285 }
286 `)
287
288 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
289 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
290 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
291 }
292}
293
Colin Cross6b4a32d2017-12-05 13:42:45 -0800294func TestBinary(t *testing.T) {
295 ctx := testJava(t, `
296 java_library_host {
297 name: "foo",
298 srcs: ["a.java"],
299 }
300
301 java_binary_host {
302 name: "bar",
303 srcs: ["b.java"],
304 static_libs: ["foo"],
305 }
306 `)
307
308 buildOS := android.BuildOs.String()
309
310 bar := ctx.ModuleForTests("bar", buildOS+"_common")
311 barJar := bar.Output("bar.jar").Output.String()
312 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
313 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
314
315 // Test that the install binary wrapper depends on the installed jar file
316 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
317 t.Errorf("expected binary wrapper implicits [%q], got %v",
318 barJar, barWrapperDeps)
319 }
320
321}
322
Colin Cross72bb3632017-07-13 16:23:21 -0700323func TestPrebuilts(t *testing.T) {
324 ctx := testJava(t, `
325 java_library {
326 name: "foo",
327 srcs: ["a.java"],
Colin Cross79c7c262019-04-17 11:11:46 -0700328 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700329 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700330 }
331
Colin Cross74d73e22017-08-02 11:05:49 -0700332 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700333 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700334 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700335 }
336
Colin Cross74d73e22017-08-02 11:05:49 -0700337 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700338 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700339 jars: ["b.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700340 }
Colin Cross42be7612019-02-21 18:12:14 -0800341
342 dex_import {
343 name: "qux",
344 jars: ["b.jar"],
345 }
Colin Cross79c7c262019-04-17 11:11:46 -0700346
347 java_sdk_library_import {
348 name: "sdklib",
349 jars: ["b.jar"],
350 }
Colin Cross72bb3632017-07-13 16:23:21 -0700351 `)
352
Colin Cross4c428df2017-09-15 17:36:05 -0700353 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700354 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross37f6d792018-07-12 12:28:41 -0700355 barJar := ctx.ModuleForTests("bar", "android_common").Rule("combineJar").Output
356 bazJar := ctx.ModuleForTests("baz", "android_common").Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700357 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700358
Colin Cross37f6d792018-07-12 12:28:41 -0700359 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
360 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700361 }
362
Colin Cross79c7c262019-04-17 11:11:46 -0700363 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
364 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
365 }
366
Colin Cross37f6d792018-07-12 12:28:41 -0700367 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
368 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700369 }
Colin Cross42be7612019-02-21 18:12:14 -0800370
371 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700372}
373
Colin Cross89536d42017-07-07 14:35:50 -0700374func TestDefaults(t *testing.T) {
375 ctx := testJava(t, `
376 java_defaults {
377 name: "defaults",
378 srcs: ["a.java"],
379 libs: ["bar"],
380 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700381 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700382 }
383
384 java_library {
385 name: "foo",
386 defaults: ["defaults"],
387 }
388
389 java_library {
390 name: "bar",
391 srcs: ["b.java"],
392 }
393
394 java_library {
395 name: "baz",
396 srcs: ["c.java"],
397 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700398
399 android_test {
400 name: "atestOptimize",
401 defaults: ["defaults"],
402 optimize: {enabled: true},
403 }
404
405 android_test {
406 name: "atestNoOptimize",
407 defaults: ["defaults"],
408 }
409
410 android_test {
411 name: "atestDefault",
412 srcs: ["a.java"],
413 }
Colin Cross89536d42017-07-07 14:35:50 -0700414 `)
415
Colin Cross4c428df2017-09-15 17:36:05 -0700416 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700417 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700418
419 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
420 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
421 }
422
Nan Zhanged19fc32017-10-19 13:06:22 -0700423 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
424 if !strings.Contains(javac.Args["classpath"], barTurbine) {
425 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700426 }
427
Colin Cross1ee23172017-10-18 14:44:18 -0700428 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700429 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
430 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700431 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700432
433 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
434 if atestOptimize.Output == nil {
435 t.Errorf("atestOptimize should optimize APK")
436 }
437
438 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
439 if atestNoOptimize.Output == nil {
440 t.Errorf("atestNoOptimize should not optimize APK")
441 }
442
443 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
444 if atestDefault.Output == nil {
445 t.Errorf("atestDefault should optimize APK")
446 }
Colin Cross89536d42017-07-07 14:35:50 -0700447}
448
Colin Cross0f37af02017-09-27 17:42:05 -0700449func TestResources(t *testing.T) {
450 var table = []struct {
451 name string
452 prop string
453 extra string
454 args string
455 }{
456 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700457 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700458 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800459 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700460 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700461 },
462 {
463 // Test that a module with java_resources includes the files
464 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700465 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
466 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700467 },
468 {
469 // Test that a module with a filegroup in java_resources includes the files with the
470 // path prefix
471 name: "resource filegroup",
472 prop: `java_resources: [":foo-res"]`,
473 extra: `
474 filegroup {
475 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800476 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700477 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700478 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700479 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700480 },
481 {
482 // Test that a module with "include_srcs: true" includes its source files in the resources jar
483 name: "include sources",
484 prop: `include_srcs: true`,
Colin Crossaf9c55b2017-10-03 14:50:08 -0700485 args: "-C . -f a.java -f b.java -f c.java",
Colin Cross0f37af02017-09-27 17:42:05 -0700486 },
Colin Cross0ead1d72018-04-10 13:07:42 -0700487 {
488 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
489 name: "wildcard dirs",
490 prop: `java_resource_dirs: ["java-res/*"]`,
491 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
492 },
493 {
494 // Test that a module exclude_java_resource_dirs excludes the files
495 name: "wildcard dirs",
496 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
497 args: "-C java-res/a -f java-res/a/a",
498 },
Colin Crosscedd4762018-09-13 11:26:19 -0700499 {
500 // Test wildcards in java_resources
501 name: "wildcard files",
502 prop: `java_resources: ["java-res/**/*"]`,
503 args: "-C . -f java-res/a/a -f java-res/b/b",
504 },
505 {
506 // Test exclude_java_resources with java_resources
507 name: "wildcard files with exclude",
508 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
509 args: "-C . -f java-res/a/a",
510 },
511 {
512 // Test exclude_java_resources with java_resource_dirs
513 name: "resource dirs with exclude files",
514 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
515 args: "-C java-res -f java-res/a/a",
516 },
517 {
518 // Test exclude_java_resource_dirs with java_resource_dirs
519 name: "resource dirs with exclude files",
520 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
521 args: "-C java-res -f java-res/a/a -f java-res/b/b",
522 },
Colin Cross0f37af02017-09-27 17:42:05 -0700523 }
524
525 for _, test := range table {
526 t.Run(test.name, func(t *testing.T) {
527 ctx := testJava(t, `
528 java_library {
529 name: "foo",
530 srcs: [
531 "a.java",
532 "b.java",
533 "c.java",
534 ],
535 `+test.prop+`,
536 }
537 `+test.extra)
538
Colin Cross331a1212018-08-15 20:40:52 -0700539 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700540 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700541
542 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
543 t.Errorf("foo combined jars %v does not contain %q",
544 foo.Inputs.Strings(), fooRes.Output.String())
545 }
546
Colin Crossaf9c55b2017-10-03 14:50:08 -0700547 if fooRes.Args["jarArgs"] != test.args {
548 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700549 fooRes.Args["jarArgs"], test.args)
550 }
551 })
552 }
553}
554
Colin Cross54190b32017-10-09 15:34:10 -0700555func TestGeneratedSources(t *testing.T) {
556 ctx := testJava(t, `
557 java_library {
558 name: "foo",
559 srcs: [
560 "a*.java",
561 ":gen",
562 "b*.java",
563 ],
564 }
565
566 genrule {
567 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800568 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700569 out: ["gen.java"],
570 }
571 `)
572
573 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
574 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
575
Colin Cross15e86d92017-10-20 15:07:08 -0700576 if filepath.Base(genrule.Output.String()) != "gen.java" {
577 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700578 }
579
580 if len(javac.Inputs) != 3 ||
581 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700582 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700583 javac.Inputs[2].String() != "b.java" {
584 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
585 }
586}
587
Nan Zhang61eaedb2017-11-02 13:28:15 -0700588func TestTurbine(t *testing.T) {
589 ctx := testJava(t, `
590 java_library {
591 name: "foo",
592 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +0900593 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700594 }
595
596 java_library {
597 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -0800598 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -0700599 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +0900600 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700601 }
602
603 java_library {
604 name: "baz",
605 srcs: ["c.java"],
606 libs: ["bar"],
607 sdk_version: "14",
608 }
609 `)
610
611 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
612 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
613 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
614 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
615 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
616
617 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
618 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
619 }
620
621 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
622 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
623 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
624 }
625 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
626 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
627 }
628 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
629 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
630 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100631 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -0700632 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100633 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700634 }
635}
636
637func TestSharding(t *testing.T) {
638 ctx := testJava(t, `
639 java_library {
640 name: "bar",
641 srcs: ["a.java","b.java","c.java"],
642 javac_shard_size: 1
643 }
644 `)
645
646 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
647 for i := 0; i < 3; i++ {
648 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
649 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
650 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
651 }
652 }
653}
654
Nan Zhang581fd212018-01-10 16:06:12 -0800655func TestDroiddoc(t *testing.T) {
656 ctx := testJava(t, `
Dan Willemsencc090972018-02-26 14:33:31 -0800657 droiddoc_template {
658 name: "droiddoc-templates-sdk",
659 path: ".",
660 }
Nan Zhang581fd212018-01-10 16:06:12 -0800661 droiddoc {
662 name: "bar-doc",
663 srcs: [
664 "bar-doc/*.java",
Jiyong Park1e440682018-05-23 18:42:04 +0900665 "bar-doc/IFoo.aidl",
Nan Zhang581fd212018-01-10 16:06:12 -0800666 ],
667 exclude_srcs: [
668 "bar-doc/b.java"
669 ],
Dan Willemsencc090972018-02-26 14:33:31 -0800670 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -0800671 hdf: [
672 "android.whichdoc offline",
673 ],
674 knowntags: [
675 "bar-doc/known_oj_tags.txt",
676 ],
677 proofread_file: "libcore-proofread.txt",
678 todo_file: "libcore-docs-todo.html",
679 args: "-offlinemode -title \"libcore\"",
680 }
681 `)
682
Nan Zhang3bb14202018-02-28 10:14:25 -0800683 stubsJar := filepath.Join(buildDir, ".intermediates", "bar-doc", "android_common", "bar-doc-stubs.srcjar")
684 barDoc := ctx.ModuleForTests("bar-doc", "android_common").Output("bar-doc-stubs.srcjar")
Nan Zhang581fd212018-01-10 16:06:12 -0800685 if stubsJar != barDoc.Output.String() {
686 t.Errorf("expected stubs Jar [%q], got %q", stubsJar, barDoc.Output.String())
687 }
Jiyong Park1e440682018-05-23 18:42:04 +0900688 inputs := ctx.ModuleForTests("bar-doc", "android_common").Rule("javadoc").Inputs
689 var javaSrcs []string
690 for _, i := range inputs {
691 javaSrcs = append(javaSrcs, i.Base())
692 }
693 if len(javaSrcs) != 2 || javaSrcs[0] != "a.java" || javaSrcs[1] != "IFoo.java" {
694 t.Errorf("inputs of bar-doc must be []string{\"a.java\", \"IFoo.java\", but was %#v.", javaSrcs)
695 }
Nan Zhang581fd212018-01-10 16:06:12 -0800696}
697
Colin Cross54250902017-12-05 09:28:08 -0800698func TestJarGenrules(t *testing.T) {
699 ctx := testJava(t, `
700 java_library {
701 name: "foo",
702 srcs: ["a.java"],
703 }
704
705 java_genrule {
706 name: "jargen",
707 tool_files: ["b.java"],
708 cmd: "$(location b.java) $(in) $(out)",
709 out: ["jargen.jar"],
710 srcs: [":foo"],
711 }
712
713 java_library {
714 name: "bar",
715 static_libs: ["jargen"],
716 srcs: ["c.java"],
717 }
718
719 java_library {
720 name: "baz",
721 libs: ["jargen"],
722 srcs: ["c.java"],
723 }
724 `)
725
726 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
727 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
728 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
729 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
730 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
731
732 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
733 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
734 }
735
736 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
737 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
738 }
739
740 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
741 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
742 }
743
744 if len(barCombined.Inputs) != 2 ||
745 barCombined.Inputs[0].String() != bar.Output.String() ||
746 barCombined.Inputs[1].String() != jargen.Output.String() {
747 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
748 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
749 }
750}
751
Nan Zhang27e284d2018-02-09 21:03:53 +0000752func TestExcludeFileGroupInSrcs(t *testing.T) {
753 ctx := testJava(t, `
754 java_library {
755 name: "foo",
756 srcs: ["a.java", ":foo-srcs"],
757 exclude_srcs: ["a.java", ":foo-excludes"],
758 }
759
760 filegroup {
761 name: "foo-srcs",
762 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
763 }
764
765 filegroup {
766 name: "foo-excludes",
767 srcs: ["java-fg/a.java", "java-fg/b.java"],
768 }
769 `)
770
771 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
772
773 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
774 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
775 }
776}
Jiyong Parkc678ad32018-04-10 13:07:10 +0900777
778func TestJavaSdkLibrary(t *testing.T) {
779 ctx := testJava(t, `
780 droiddoc_template {
781 name: "droiddoc-templates-sdk",
782 path: ".",
783 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900784 java_sdk_library {
785 name: "foo",
786 srcs: ["a.java", "b.java"],
787 api_packages: ["foo"],
788 }
789 java_sdk_library {
790 name: "bar",
791 srcs: ["a.java", "b.java"],
792 api_packages: ["bar"],
793 }
794 java_library {
795 name: "baz",
796 srcs: ["c.java"],
797 libs: ["foo", "bar"],
798 sdk_version: "system_current",
799 }
Jiyong Park1be96912018-05-28 18:02:19 +0900800 java_library {
801 name: "qux",
802 srcs: ["c.java"],
803 libs: ["baz"],
804 sdk_version: "system_current",
805 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900806 `)
807
808 // check the existence of the internal modules
809 ctx.ModuleForTests("foo", "android_common")
810 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix, "android_common")
811 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +0900812 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkTestApiSuffix, "android_common")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900813 ctx.ModuleForTests("foo"+sdkDocsSuffix, "android_common")
814 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +0900815 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkTestApiSuffix, "android_common")
Jaewoong Jungb9a11512019-01-15 10:47:05 -0800816 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_arm64_armv8-a")
Jiyong Park58c518b2018-05-12 22:29:12 +0900817 ctx.ModuleForTests("foo.api.public.28", "")
818 ctx.ModuleForTests("foo.api.system.28", "")
819 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900820
821 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
822 // tests if baz is actually linked to the stubs lib
823 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
824 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
825 "foo.stubs.system.jar")
826 }
827 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +0900828 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +0900829 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +0900830 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +0900831 }
832 // test if baz is not linked to the system variant of foo
833 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
834 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
835 "foo.stubs.jar")
836 }
Jiyong Park1be96912018-05-28 18:02:19 +0900837
838 // test if baz has exported SDK lib names foo and bar to qux
839 qux := ctx.ModuleForTests("qux", "android_common")
840 if quxLib, ok := qux.Module().(*Library); ok {
841 sdkLibs := quxLib.ExportedSdkLibs()
842 if len(sdkLibs) != 2 || !android.InList("foo", sdkLibs) || !android.InList("bar", sdkLibs) {
843 t.Errorf("qux should export \"foo\" and \"bar\" but exports %v", sdkLibs)
844 }
845 }
Jiyong Parkc678ad32018-04-10 13:07:10 +0900846}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +0200847
848var compilerFlagsTestCases = []struct {
849 in string
850 out bool
851}{
852 {
853 in: "a",
854 out: false,
855 },
856 {
857 in: "-a",
858 out: true,
859 },
860 {
861 in: "-no-jdk",
862 out: false,
863 },
864 {
865 in: "-no-stdlib",
866 out: false,
867 },
868 {
869 in: "-kotlin-home",
870 out: false,
871 },
872 {
873 in: "-kotlin-home /some/path",
874 out: false,
875 },
876 {
877 in: "-include-runtime",
878 out: false,
879 },
880 {
881 in: "-Xintellij-plugin-root",
882 out: false,
883 },
884}
885
886type mockContext struct {
887 android.ModuleContext
888 result bool
889}
890
891func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
892 // CheckBadCompilerFlags calls this function when the flag should be rejected
893 ctx.result = false
894}
895
896func TestCompilerFlags(t *testing.T) {
897 for _, testCase := range compilerFlagsTestCases {
898 ctx := &mockContext{result: true}
899 CheckKotlincFlags(ctx, []string{testCase.in})
900 if ctx.result != testCase.out {
901 t.Errorf("incorrect output:")
902 t.Errorf(" input: %#v", testCase.in)
903 t.Errorf(" expected: %#v", testCase.out)
904 t.Errorf(" got: %#v", ctx.result)
905 }
906 }
907}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -0800908
909// TODO(jungjw): Consider making this more robust by ignoring path order.
910func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
911 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
912 flags := strings.Split(variables["javacFlags"], " ")
913 got := ""
914 for _, flag := range flags {
915 keyEnd := strings.Index(flag, "=")
916 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
917 got = flag[keyEnd+1:]
918 break
919 }
920 }
921 if expected != got {
922 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
923 }
924}
925
926func TestPatchModule(t *testing.T) {
927 bp := `
928 java_library {
929 name: "foo",
930 srcs: ["a.java"],
931 }
932
933 java_library {
934 name: "bar",
935 srcs: ["b.java"],
936 no_standard_libs: true,
937 system_modules: "none",
938 patch_module: "java.base",
939 }
940
941 java_library {
942 name: "baz",
943 srcs: ["c.java"],
944 patch_module: "java.base",
945 }
946 `
947
Pete Gillin0c2143e2019-05-02 15:32:11 +0100948 t.Run("Java language level 8", func(t *testing.T) {
949 // Test default javac -source 1.8 -target 1.8
Jaewoong Jung38e4fb22018-12-12 09:01:34 -0800950 ctx := testJava(t, bp)
951
952 checkPatchModuleFlag(t, ctx, "foo", "")
953 checkPatchModuleFlag(t, ctx, "bar", "")
954 checkPatchModuleFlag(t, ctx, "baz", "")
955 })
956
Pete Gillin0c2143e2019-05-02 15:32:11 +0100957 t.Run("Java language level 9", func(t *testing.T) {
958 // Test again with javac -source 9 -target 9
959 config := testConfig(map[string]string{"EXPERIMENTAL_JAVA_LANGUAGE_LEVEL_9": "true"})
Jaewoong Jung38e4fb22018-12-12 09:01:34 -0800960 ctx := testContext(config, bp, nil)
961 run(t, ctx, config)
962
963 checkPatchModuleFlag(t, ctx, "foo", "")
964 expected := "java.base=.:" + buildDir
965 checkPatchModuleFlag(t, ctx, "bar", expected)
966 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
967 checkPatchModuleFlag(t, ctx, "baz", expected)
968 })
969}