blob: dd2bc85f43cc8efa07f8b5aec62a76581ca59ee9 [file] [log] [blame]
Thomas Gleixner55716d22019-06-01 10:08:42 +02001// SPDX-License-Identifier: GPL-2.0-only
Greg Kroah-Hartman0650fd52006-01-20 14:08:59 -08002
Linus Torvalds1da177e2005-04-16 15:20:36 -07003/*
4 * drm_sysfs.c - Modifications to drm_sysfs_class.c to support
5 * extra sysfs attribute from DRM. Normal drm_sysfs_class
6 * does not allow adding attributes.
7 *
8 * Copyright (c) 2004 Jon Smirl <jonsmirl@gmail.com>
9 * Copyright (c) 2003-2004 Greg Kroah-Hartman <greg@kroah.com>
10 * Copyright (c) 2003-2004 IBM Corp.
Linus Torvalds1da177e2005-04-16 15:20:36 -070011 */
12
Linus Torvalds1da177e2005-04-16 15:20:36 -070013#include <linux/device.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070014#include <linux/err.h>
Paul Gortmaker2d1a8a42011-08-30 18:16:33 -040015#include <linux/export.h>
Sam Ravnborg0500c042019-05-26 19:35:35 +020016#include <linux/gfp.h>
Andrzej Pietrasiewicze1a29c62019-07-26 19:22:55 +020017#include <linux/i2c.h>
Sam Ravnborg0500c042019-05-26 19:35:35 +020018#include <linux/kdev_t.h>
19#include <linux/slab.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070020
Sam Ravnborg0500c042019-05-26 19:35:35 +020021#include <drm/drm_connector.h>
22#include <drm/drm_device.h>
23#include <drm/drm_file.h>
24#include <drm/drm_modes.h>
25#include <drm/drm_print.h>
26#include <drm/drm_property.h>
David Howells760285e2012-10-02 18:01:07 +010027#include <drm/drm_sysfs.h>
Sam Ravnborg0500c042019-05-26 19:35:35 +020028
Daniel Vetter67d0ec42014-09-10 12:43:53 +020029#include "drm_internal.h"
Ramalingam C6fe2ce02019-08-01 17:11:16 +053030#include "drm_crtc_internal.h"
Linus Torvalds1da177e2005-04-16 15:20:36 -070031
Dave Airlie5bdebb12013-10-11 14:07:25 +100032#define to_drm_minor(d) dev_get_drvdata(d)
33#define to_drm_connector(d) dev_get_drvdata(d)
Jesse Barnese8b962b2007-11-22 14:02:38 +100034
Daniel Vettere2271702017-04-04 11:52:55 +020035/**
36 * DOC: overview
37 *
38 * DRM provides very little additional support to drivers for sysfs
39 * interactions, beyond just all the standard stuff. Drivers who want to expose
40 * additional sysfs properties and property groups can attach them at either
41 * &drm_device.dev or &drm_connector.kdev.
42 *
43 * Registration is automatically handled when calling drm_dev_register(), or
44 * drm_connector_register() in case of hot-plugged connectors. Unregistration is
45 * also automatically handled by drm_dev_unregister() and
46 * drm_connector_unregister().
47 */
48
Thomas Hellstrom08e4d532009-08-20 19:02:31 +100049static struct device_type drm_sysfs_device_minor = {
50 .name = "drm_minor"
51};
52
David Herrmannfcc90212015-09-09 14:21:30 +020053struct class *drm_class;
54
Al Viro2c9ede52011-07-23 20:24:48 -040055static char *drm_devnode(struct device *dev, umode_t *mode)
Kay Sievers02200d02009-04-30 15:23:42 +020056{
57 return kasprintf(GFP_KERNEL, "dri/%s", dev_name(dev));
58}
59
David Herrmann82d5e732016-09-01 14:48:36 +020060static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810");
Linus Torvalds1da177e2005-04-16 15:20:36 -070061
62/**
David Herrmannfcc90212015-09-09 14:21:30 +020063 * drm_sysfs_init - initialize sysfs helpers
Linus Torvalds1da177e2005-04-16 15:20:36 -070064 *
David Herrmannfcc90212015-09-09 14:21:30 +020065 * This is used to create the DRM class, which is the implicit parent of any
66 * other top-level DRM sysfs objects.
Linus Torvalds1da177e2005-04-16 15:20:36 -070067 *
David Herrmannfcc90212015-09-09 14:21:30 +020068 * You must call drm_sysfs_destroy() to release the allocated resources.
69 *
70 * Return: 0 on success, negative error code on failure.
Linus Torvalds1da177e2005-04-16 15:20:36 -070071 */
David Herrmannfcc90212015-09-09 14:21:30 +020072int drm_sysfs_init(void)
Linus Torvalds1da177e2005-04-16 15:20:36 -070073{
Jeff Garzik24f73c92006-10-10 14:23:37 -070074 int err;
Linus Torvalds1da177e2005-04-16 15:20:36 -070075
David Herrmannfcc90212015-09-09 14:21:30 +020076 drm_class = class_create(THIS_MODULE, "drm");
77 if (IS_ERR(drm_class))
78 return PTR_ERR(drm_class);
79
David Herrmannfcc90212015-09-09 14:21:30 +020080 err = class_create_file(drm_class, &class_attr_version.attr);
81 if (err) {
82 class_destroy(drm_class);
83 drm_class = NULL;
84 return err;
Jeff Garzik24f73c92006-10-10 14:23:37 -070085 }
Linus Torvalds1da177e2005-04-16 15:20:36 -070086
David Herrmannfcc90212015-09-09 14:21:30 +020087 drm_class->devnode = drm_devnode;
Ramalingam C6498bf52019-05-07 21:57:38 +053088 drm_setup_hdcp_srm(drm_class);
David Herrmannfcc90212015-09-09 14:21:30 +020089 return 0;
Linus Torvalds1da177e2005-04-16 15:20:36 -070090}
91
92/**
Jesse Barnese8b962b2007-11-22 14:02:38 +100093 * drm_sysfs_destroy - destroys DRM class
Linus Torvalds1da177e2005-04-16 15:20:36 -070094 *
Jesse Barnese8b962b2007-11-22 14:02:38 +100095 * Destroy the DRM device class.
Linus Torvalds1da177e2005-04-16 15:20:36 -070096 */
Jesse Barnese8b962b2007-11-22 14:02:38 +100097void drm_sysfs_destroy(void)
Linus Torvalds1da177e2005-04-16 15:20:36 -070098{
David Herrmann26b91ae2015-09-09 14:21:29 +020099 if (IS_ERR_OR_NULL(drm_class))
Linus Torvalds1da177e2005-04-16 15:20:36 -0700100 return;
Ramalingam C6498bf52019-05-07 21:57:38 +0530101 drm_teardown_hdcp_srm(drm_class);
Andi Kleen0933e2d2010-01-05 12:48:09 +0100102 class_remove_file(drm_class, &class_attr_version.attr);
Jesse Barnese8b962b2007-11-22 14:02:38 +1000103 class_destroy(drm_class);
Dave Airlie49099c42012-07-06 18:06:42 +0100104 drm_class = NULL;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700105}
106
Dave Airlief453ba02008-11-07 14:05:41 -0800107/*
108 * Connector properties
109 */
Chris Wilsonc484f022015-03-06 12:36:42 +0000110static ssize_t status_store(struct device *device,
111 struct device_attribute *attr,
112 const char *buf, size_t count)
113{
114 struct drm_connector *connector = to_drm_connector(device);
115 struct drm_device *dev = connector->dev;
Daniel Vettered293f72015-11-19 17:46:50 +0100116 enum drm_connector_force old_force;
Chris Wilsonc484f022015-03-06 12:36:42 +0000117 int ret;
118
119 ret = mutex_lock_interruptible(&dev->mode_config.mutex);
120 if (ret)
121 return ret;
122
Daniel Vettered293f72015-11-19 17:46:50 +0100123 old_force = connector->force;
Chris Wilsonc484f022015-03-06 12:36:42 +0000124
Daniel Vettered293f72015-11-19 17:46:50 +0100125 if (sysfs_streq(buf, "detect"))
Chris Wilsonc484f022015-03-06 12:36:42 +0000126 connector->force = 0;
Daniel Vettered293f72015-11-19 17:46:50 +0100127 else if (sysfs_streq(buf, "on"))
Chris Wilsonc484f022015-03-06 12:36:42 +0000128 connector->force = DRM_FORCE_ON;
Daniel Vettered293f72015-11-19 17:46:50 +0100129 else if (sysfs_streq(buf, "on-digital"))
Chris Wilsonc484f022015-03-06 12:36:42 +0000130 connector->force = DRM_FORCE_ON_DIGITAL;
Daniel Vettered293f72015-11-19 17:46:50 +0100131 else if (sysfs_streq(buf, "off"))
Chris Wilsonc484f022015-03-06 12:36:42 +0000132 connector->force = DRM_FORCE_OFF;
Daniel Vettered293f72015-11-19 17:46:50 +0100133 else
Chris Wilsonc484f022015-03-06 12:36:42 +0000134 ret = -EINVAL;
135
Daniel Vettered293f72015-11-19 17:46:50 +0100136 if (old_force != connector->force || !connector->force) {
137 DRM_DEBUG_KMS("[CONNECTOR:%d:%s] force updated from %d to %d or reprobing\n",
Chris Wilsonc484f022015-03-06 12:36:42 +0000138 connector->base.id,
139 connector->name,
Daniel Vettered293f72015-11-19 17:46:50 +0100140 old_force, connector->force);
Chris Wilsonc484f022015-03-06 12:36:42 +0000141
Daniel Vettered293f72015-11-19 17:46:50 +0100142 connector->funcs->fill_modes(connector,
143 dev->mode_config.max_width,
144 dev->mode_config.max_height);
Chris Wilsonc484f022015-03-06 12:36:42 +0000145 }
146
147 mutex_unlock(&dev->mode_config.mutex);
148
Russell King38d85712015-06-06 08:27:30 +1000149 return ret ? ret : count;
Chris Wilsonc484f022015-03-06 12:36:42 +0000150}
151
Dave Airlief453ba02008-11-07 14:05:41 -0800152static ssize_t status_show(struct device *device,
153 struct device_attribute *attr,
154 char *buf)
155{
156 struct drm_connector *connector = to_drm_connector(device);
Daniel Vetter4eb9b942016-03-30 11:45:13 +0200157 enum drm_connector_status status;
158
159 status = READ_ONCE(connector->status);
Chris Wilson007c80a2011-03-15 11:40:00 +0000160
Keith Packard75185c92009-05-30 20:42:25 -0700161 return snprintf(buf, PAGE_SIZE, "%s\n",
Daniel Vetter4eb9b942016-03-30 11:45:13 +0200162 drm_get_connector_status_name(status));
Dave Airlief453ba02008-11-07 14:05:41 -0800163}
164
165static ssize_t dpms_show(struct device *device,
166 struct device_attribute *attr,
167 char *buf)
168{
169 struct drm_connector *connector = to_drm_connector(device);
Daniel Vetter621bd0f2015-09-29 09:56:53 +0200170 int dpms;
Dave Airlief453ba02008-11-07 14:05:41 -0800171
Daniel Vetter621bd0f2015-09-29 09:56:53 +0200172 dpms = READ_ONCE(connector->dpms);
Dave Airlief453ba02008-11-07 14:05:41 -0800173
Keith Packard75185c92009-05-30 20:42:25 -0700174 return snprintf(buf, PAGE_SIZE, "%s\n",
Daniel Vetter621bd0f2015-09-29 09:56:53 +0200175 drm_get_dpms_name(dpms));
Dave Airlief453ba02008-11-07 14:05:41 -0800176}
177
178static ssize_t enabled_show(struct device *device,
179 struct device_attribute *attr,
180 char *buf)
181{
182 struct drm_connector *connector = to_drm_connector(device);
Daniel Vetter4eb9b942016-03-30 11:45:13 +0200183 bool enabled;
Dave Airlief453ba02008-11-07 14:05:41 -0800184
Daniel Vetter4eb9b942016-03-30 11:45:13 +0200185 enabled = READ_ONCE(connector->encoder);
186
187 return snprintf(buf, PAGE_SIZE, enabled ? "enabled\n" : "disabled\n");
Dave Airlief453ba02008-11-07 14:05:41 -0800188}
189
Chris Wright2c3c8be2010-05-12 18:28:57 -0700190static ssize_t edid_show(struct file *filp, struct kobject *kobj,
191 struct bin_attribute *attr, char *buf, loff_t off,
192 size_t count)
Dave Airlief453ba02008-11-07 14:05:41 -0800193{
Geliang Tangd122cbf2016-01-13 22:48:41 +0800194 struct device *connector_dev = kobj_to_dev(kobj);
Dave Airlief453ba02008-11-07 14:05:41 -0800195 struct drm_connector *connector = to_drm_connector(connector_dev);
196 unsigned char *edid;
197 size_t size;
Daniel Vettera48a62b2015-10-02 13:01:02 +0200198 ssize_t ret = 0;
Dave Airlief453ba02008-11-07 14:05:41 -0800199
Daniel Vettera48a62b2015-10-02 13:01:02 +0200200 mutex_lock(&connector->dev->mode_config.mutex);
Dave Airlief453ba02008-11-07 14:05:41 -0800201 if (!connector->edid_blob_ptr)
Daniel Vettera48a62b2015-10-02 13:01:02 +0200202 goto unlock;
Dave Airlief453ba02008-11-07 14:05:41 -0800203
204 edid = connector->edid_blob_ptr->data;
205 size = connector->edid_blob_ptr->length;
206 if (!edid)
Daniel Vettera48a62b2015-10-02 13:01:02 +0200207 goto unlock;
Dave Airlief453ba02008-11-07 14:05:41 -0800208
209 if (off >= size)
Daniel Vettera48a62b2015-10-02 13:01:02 +0200210 goto unlock;
Dave Airlief453ba02008-11-07 14:05:41 -0800211
212 if (off + count > size)
213 count = size - off;
214 memcpy(buf, edid + off, count);
215
Daniel Vettera48a62b2015-10-02 13:01:02 +0200216 ret = count;
217unlock:
218 mutex_unlock(&connector->dev->mode_config.mutex);
219
220 return ret;
Dave Airlief453ba02008-11-07 14:05:41 -0800221}
222
223static ssize_t modes_show(struct device *device,
224 struct device_attribute *attr,
225 char *buf)
226{
227 struct drm_connector *connector = to_drm_connector(device);
228 struct drm_display_mode *mode;
229 int written = 0;
230
Daniel Vettera48a62b2015-10-02 13:01:02 +0200231 mutex_lock(&connector->dev->mode_config.mutex);
Dave Airlief453ba02008-11-07 14:05:41 -0800232 list_for_each_entry(mode, &connector->modes, head) {
233 written += snprintf(buf + written, PAGE_SIZE - written, "%s\n",
234 mode->name);
235 }
Daniel Vettera48a62b2015-10-02 13:01:02 +0200236 mutex_unlock(&connector->dev->mode_config.mutex);
Dave Airlief453ba02008-11-07 14:05:41 -0800237
238 return written;
239}
240
Chris Wilsonc484f022015-03-06 12:36:42 +0000241static DEVICE_ATTR_RW(status);
Takashi Iwai335f1a62015-02-04 11:58:53 +0100242static DEVICE_ATTR_RO(enabled);
243static DEVICE_ATTR_RO(dpms);
244static DEVICE_ATTR_RO(modes);
245
246static struct attribute *connector_dev_attrs[] = {
247 &dev_attr_status.attr,
248 &dev_attr_enabled.attr,
249 &dev_attr_dpms.attr,
250 &dev_attr_modes.attr,
251 NULL
Dave Airlief453ba02008-11-07 14:05:41 -0800252};
253
Dave Airlief453ba02008-11-07 14:05:41 -0800254static struct bin_attribute edid_attr = {
255 .attr.name = "edid",
Keith Packarde36ebaf2009-05-30 20:42:26 -0700256 .attr.mode = 0444,
Adam Jackson7466f4c2010-03-29 21:43:23 +0000257 .size = 0,
Dave Airlief453ba02008-11-07 14:05:41 -0800258 .read = edid_show,
259};
260
Takashi Iwai335f1a62015-02-04 11:58:53 +0100261static struct bin_attribute *connector_bin_attrs[] = {
262 &edid_attr,
263 NULL
264};
265
266static const struct attribute_group connector_dev_group = {
267 .attrs = connector_dev_attrs,
268 .bin_attrs = connector_bin_attrs,
269};
270
Takashi Iwai335f1a62015-02-04 11:58:53 +0100271static const struct attribute_group *connector_dev_groups[] = {
272 &connector_dev_group,
Takashi Iwai335f1a62015-02-04 11:58:53 +0100273 NULL
274};
275
Dave Airlief453ba02008-11-07 14:05:41 -0800276int drm_sysfs_connector_add(struct drm_connector *connector)
277{
278 struct drm_device *dev = connector->dev;
Dave Airlief453ba02008-11-07 14:05:41 -0800279
Dave Airlie5bdebb12013-10-11 14:07:25 +1000280 if (connector->kdev)
281 return 0;
282
Takashi Iwai335f1a62015-02-04 11:58:53 +0100283 connector->kdev =
284 device_create_with_groups(drm_class, dev->primary->kdev, 0,
285 connector, connector_dev_groups,
286 "card%d-%s", dev->primary->index,
287 connector->name);
Dave Airlief453ba02008-11-07 14:05:41 -0800288 DRM_DEBUG("adding \"%s\" to sysfs\n",
Jani Nikula25933822014-06-03 14:56:20 +0300289 connector->name);
Dave Airlief453ba02008-11-07 14:05:41 -0800290
Dave Airlie5bdebb12013-10-11 14:07:25 +1000291 if (IS_ERR(connector->kdev)) {
292 DRM_ERROR("failed to register connector device: %ld\n", PTR_ERR(connector->kdev));
Takashi Iwai335f1a62015-02-04 11:58:53 +0100293 return PTR_ERR(connector->kdev);
Dave Airlief453ba02008-11-07 14:05:41 -0800294 }
295
Dave Airlief453ba02008-11-07 14:05:41 -0800296 /* Let userspace know we have a new connector */
297 drm_sysfs_hotplug_event(dev);
298
Andrzej Pietrasiewicze1a29c62019-07-26 19:22:55 +0200299 if (connector->ddc)
300 return sysfs_create_link(&connector->kdev->kobj,
301 &connector->ddc->dev.kobj, "ddc");
Dave Airlief453ba02008-11-07 14:05:41 -0800302 return 0;
Dave Airlief453ba02008-11-07 14:05:41 -0800303}
Dave Airlief453ba02008-11-07 14:05:41 -0800304
Dave Airlief453ba02008-11-07 14:05:41 -0800305void drm_sysfs_connector_remove(struct drm_connector *connector)
306{
Dave Airlie5bdebb12013-10-11 14:07:25 +1000307 if (!connector->kdev)
Dave Airlie1828fe62012-02-20 14:15:02 +0000308 return;
Andrzej Pietrasiewicze1a29c62019-07-26 19:22:55 +0200309
310 if (connector->ddc)
311 sysfs_remove_link(&connector->kdev->kobj, "ddc");
312
Dave Airlief453ba02008-11-07 14:05:41 -0800313 DRM_DEBUG("removing \"%s\" from sysfs\n",
Jani Nikula25933822014-06-03 14:56:20 +0300314 connector->name);
Dave Airlief453ba02008-11-07 14:05:41 -0800315
Dave Airlie5bdebb12013-10-11 14:07:25 +1000316 device_unregister(connector->kdev);
317 connector->kdev = NULL;
Dave Airlief453ba02008-11-07 14:05:41 -0800318}
Dave Airlief453ba02008-11-07 14:05:41 -0800319
Daniel Vetterce858822018-11-29 10:42:26 +0100320void drm_sysfs_lease_event(struct drm_device *dev)
321{
322 char *event_string = "LEASE=1";
323 char *envp[] = { event_string, NULL };
324
325 DRM_DEBUG("generating lease event\n");
326
327 kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp);
328}
329
Dave Airlief453ba02008-11-07 14:05:41 -0800330/**
331 * drm_sysfs_hotplug_event - generate a DRM uevent
332 * @dev: DRM device
333 *
334 * Send a uevent for the DRM device specified by @dev. Currently we only
335 * set HOTPLUG=1 in the uevent environment, but this could be expanded to
336 * deal with other types of events.
Ramalingam C6fe2ce02019-08-01 17:11:16 +0530337 *
338 * Any new uapi should be using the drm_sysfs_connector_status_event()
339 * for uevents on connector status change.
Dave Airlief453ba02008-11-07 14:05:41 -0800340 */
341void drm_sysfs_hotplug_event(struct drm_device *dev)
342{
343 char *event_string = "HOTPLUG=1";
344 char *envp[] = { event_string, NULL };
345
346 DRM_DEBUG("generating hotplug event\n");
347
Dave Airlie5bdebb12013-10-11 14:07:25 +1000348 kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp);
Dave Airlief453ba02008-11-07 14:05:41 -0800349}
Jesse Barnes5ca58282009-03-31 14:11:15 -0700350EXPORT_SYMBOL(drm_sysfs_hotplug_event);
Dave Airlief453ba02008-11-07 14:05:41 -0800351
Ramalingam C6fe2ce02019-08-01 17:11:16 +0530352/**
353 * drm_sysfs_connector_status_event - generate a DRM uevent for connector
354 * property status change
355 * @connector: connector on which property status changed
356 * @property: connector property whose status changed.
357 *
358 * Send a uevent for the DRM device specified by @dev. Currently we
359 * set HOTPLUG=1 and connector id along with the attached property id
360 * related to the status change.
361 */
362void drm_sysfs_connector_status_event(struct drm_connector *connector,
363 struct drm_property *property)
364{
365 struct drm_device *dev = connector->dev;
366 char hotplug_str[] = "HOTPLUG=1", conn_id[21], prop_id[21];
367 char *envp[4] = { hotplug_str, conn_id, prop_id, NULL };
368
369 WARN_ON(!drm_mode_obj_find_prop_id(&connector->base,
370 property->base.id));
371
372 snprintf(conn_id, ARRAY_SIZE(conn_id),
373 "CONNECTOR=%u", connector->base.id);
374 snprintf(prop_id, ARRAY_SIZE(prop_id),
375 "PROPERTY=%u", property->base.id);
376
377 DRM_DEBUG("generating connector status event\n");
378
379 kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp);
380}
381EXPORT_SYMBOL(drm_sysfs_connector_status_event);
382
David Herrmann760c9602013-11-21 20:50:50 +1000383static void drm_sysfs_release(struct device *dev)
384{
385 kfree(dev);
386}
387
David Herrmanne1728072014-07-23 11:38:38 +0200388struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
Jesse Barnese8b962b2007-11-22 14:02:38 +1000389{
David Herrmanne1728072014-07-23 11:38:38 +0200390 const char *minor_str;
391 struct device *kdev;
David Herrmann760c9602013-11-21 20:50:50 +1000392 int r;
Jesse Barnese8b962b2007-11-22 14:02:38 +1000393
Daniel Vetter0d49f302018-04-20 08:51:59 +0200394 if (minor->type == DRM_MINOR_RENDER)
David Herrmanne1728072014-07-23 11:38:38 +0200395 minor_str = "renderD%d";
396 else
397 minor_str = "card%d";
Jesse Barnese8b962b2007-11-22 14:02:38 +1000398
David Herrmanne1728072014-07-23 11:38:38 +0200399 kdev = kzalloc(sizeof(*kdev), GFP_KERNEL);
400 if (!kdev)
401 return ERR_PTR(-ENOMEM);
David Herrmann760c9602013-11-21 20:50:50 +1000402
David Herrmanne1728072014-07-23 11:38:38 +0200403 device_initialize(kdev);
404 kdev->devt = MKDEV(DRM_MAJOR, minor->index);
405 kdev->class = drm_class;
406 kdev->type = &drm_sysfs_device_minor;
407 kdev->parent = minor->dev->dev;
408 kdev->release = drm_sysfs_release;
409 dev_set_drvdata(kdev, minor);
David Herrmann760c9602013-11-21 20:50:50 +1000410
David Herrmanne1728072014-07-23 11:38:38 +0200411 r = dev_set_name(kdev, minor_str, minor->index);
David Herrmann760c9602013-11-21 20:50:50 +1000412 if (r < 0)
David Herrmanne1728072014-07-23 11:38:38 +0200413 goto err_free;
David Herrmann760c9602013-11-21 20:50:50 +1000414
David Herrmanne1728072014-07-23 11:38:38 +0200415 return kdev;
David Herrmann760c9602013-11-21 20:50:50 +1000416
David Herrmanne1728072014-07-23 11:38:38 +0200417err_free:
418 put_device(kdev);
419 return ERR_PTR(r);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700420}
421
422/**
Daniel Vettere2271702017-04-04 11:52:55 +0200423 * drm_class_device_register - register new device with the DRM sysfs class
424 * @dev: device to register
Thomas Hellstrom327c2252009-08-17 16:28:37 +0200425 *
Daniel Vettere2271702017-04-04 11:52:55 +0200426 * Registers a new &struct device within the DRM sysfs class. Essentially only
427 * used by ttm to have a place for its global settings. Drivers should never use
428 * this.
Thomas Hellstrom327c2252009-08-17 16:28:37 +0200429 */
Thomas Hellstrom327c2252009-08-17 16:28:37 +0200430int drm_class_device_register(struct device *dev)
431{
Dave Airlie49099c42012-07-06 18:06:42 +0100432 if (!drm_class || IS_ERR(drm_class))
433 return -ENOENT;
434
Thomas Hellstrom327c2252009-08-17 16:28:37 +0200435 dev->class = drm_class;
436 return device_register(dev);
437}
438EXPORT_SYMBOL_GPL(drm_class_device_register);
439
Daniel Vettere2271702017-04-04 11:52:55 +0200440/**
441 * drm_class_device_unregister - unregister device with the DRM sysfs class
442 * @dev: device to unregister
443 *
444 * Unregisters a &struct device from the DRM sysfs class. Essentially only used
445 * by ttm to have a place for its global settings. Drivers should never use
446 * this.
447 */
Thomas Hellstrom327c2252009-08-17 16:28:37 +0200448void drm_class_device_unregister(struct device *dev)
449{
450 return device_unregister(dev);
451}
452EXPORT_SYMBOL_GPL(drm_class_device_unregister);