Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 1 | /* |
Jiri Pirko | 0c6965d | 2014-11-05 20:51:51 +0100 | [diff] [blame] | 2 | * net/sched/act_pedit.c Generic packet editor |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 3 | * |
| 4 | * This program is free software; you can redistribute it and/or |
| 5 | * modify it under the terms of the GNU General Public License |
| 6 | * as published by the Free Software Foundation; either version |
| 7 | * 2 of the License, or (at your option) any later version. |
| 8 | * |
| 9 | * Authors: Jamal Hadi Salim (2002-4) |
| 10 | */ |
| 11 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 12 | #include <linux/types.h> |
| 13 | #include <linux/kernel.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 14 | #include <linux/string.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 15 | #include <linux/errno.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 16 | #include <linux/skbuff.h> |
| 17 | #include <linux/rtnetlink.h> |
| 18 | #include <linux/module.h> |
| 19 | #include <linux/init.h> |
Tejun Heo | 5a0e3ad | 2010-03-24 17:04:11 +0900 | [diff] [blame] | 20 | #include <linux/slab.h> |
Arnaldo Carvalho de Melo | dc5fc57 | 2007-03-25 23:06:12 -0700 | [diff] [blame] | 21 | #include <net/netlink.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 22 | #include <net/pkt_sched.h> |
| 23 | #include <linux/tc_act/tc_pedit.h> |
| 24 | #include <net/tc_act/tc_pedit.h> |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 25 | #include <uapi/linux/tc_act/tc_pedit.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 26 | |
Alexey Dobriyan | c7d03a0 | 2016-11-17 04:58:21 +0300 | [diff] [blame] | 27 | static unsigned int pedit_net_id; |
WANG Cong | a85a970 | 2016-07-25 16:09:41 -0700 | [diff] [blame] | 28 | static struct tc_action_ops act_pedit_ops; |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 29 | |
Patrick McHardy | 53b2bf3 | 2008-01-23 20:36:30 -0800 | [diff] [blame] | 30 | static const struct nla_policy pedit_policy[TCA_PEDIT_MAX + 1] = { |
jamal | 53f7e35 | 2009-10-11 04:21:38 +0000 | [diff] [blame] | 31 | [TCA_PEDIT_PARMS] = { .len = sizeof(struct tc_pedit) }, |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 32 | [TCA_PEDIT_KEYS_EX] = { .type = NLA_NESTED }, |
Patrick McHardy | 53b2bf3 | 2008-01-23 20:36:30 -0800 | [diff] [blame] | 33 | }; |
| 34 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 35 | static const struct nla_policy pedit_key_ex_policy[TCA_PEDIT_KEY_EX_MAX + 1] = { |
| 36 | [TCA_PEDIT_KEY_EX_HTYPE] = { .type = NLA_U16 }, |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 37 | [TCA_PEDIT_KEY_EX_CMD] = { .type = NLA_U16 }, |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 38 | }; |
| 39 | |
| 40 | static struct tcf_pedit_key_ex *tcf_pedit_keys_ex_parse(struct nlattr *nla, |
| 41 | u8 n) |
| 42 | { |
| 43 | struct tcf_pedit_key_ex *keys_ex; |
| 44 | struct tcf_pedit_key_ex *k; |
| 45 | const struct nlattr *ka; |
| 46 | int err = -EINVAL; |
| 47 | int rem; |
| 48 | |
| 49 | if (!nla || !n) |
| 50 | return NULL; |
| 51 | |
| 52 | keys_ex = kcalloc(n, sizeof(*k), GFP_KERNEL); |
| 53 | if (!keys_ex) |
| 54 | return ERR_PTR(-ENOMEM); |
| 55 | |
| 56 | k = keys_ex; |
| 57 | |
| 58 | nla_for_each_nested(ka, nla, rem) { |
| 59 | struct nlattr *tb[TCA_PEDIT_KEY_EX_MAX + 1]; |
| 60 | |
| 61 | if (!n) { |
| 62 | err = -EINVAL; |
| 63 | goto err_out; |
| 64 | } |
| 65 | n--; |
| 66 | |
| 67 | if (nla_type(ka) != TCA_PEDIT_KEY_EX) { |
| 68 | err = -EINVAL; |
| 69 | goto err_out; |
| 70 | } |
| 71 | |
| 72 | err = nla_parse_nested(tb, TCA_PEDIT_KEY_EX_MAX, ka, |
Johannes Berg | fceb643 | 2017-04-12 14:34:07 +0200 | [diff] [blame] | 73 | pedit_key_ex_policy, NULL); |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 74 | if (err) |
| 75 | goto err_out; |
| 76 | |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 77 | if (!tb[TCA_PEDIT_KEY_EX_HTYPE] || |
| 78 | !tb[TCA_PEDIT_KEY_EX_CMD]) { |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 79 | err = -EINVAL; |
| 80 | goto err_out; |
| 81 | } |
| 82 | |
| 83 | k->htype = nla_get_u16(tb[TCA_PEDIT_KEY_EX_HTYPE]); |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 84 | k->cmd = nla_get_u16(tb[TCA_PEDIT_KEY_EX_CMD]); |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 85 | |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 86 | if (k->htype > TCA_PEDIT_HDR_TYPE_MAX || |
| 87 | k->cmd > TCA_PEDIT_CMD_MAX) { |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 88 | err = -EINVAL; |
| 89 | goto err_out; |
| 90 | } |
| 91 | |
| 92 | k++; |
| 93 | } |
| 94 | |
Dan Carpenter | c4f65b0 | 2017-06-14 13:29:31 +0300 | [diff] [blame] | 95 | if (n) { |
| 96 | err = -EINVAL; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 97 | goto err_out; |
Dan Carpenter | c4f65b0 | 2017-06-14 13:29:31 +0300 | [diff] [blame] | 98 | } |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 99 | |
| 100 | return keys_ex; |
| 101 | |
| 102 | err_out: |
| 103 | kfree(keys_ex); |
| 104 | return ERR_PTR(err); |
| 105 | } |
| 106 | |
| 107 | static int tcf_pedit_key_ex_dump(struct sk_buff *skb, |
| 108 | struct tcf_pedit_key_ex *keys_ex, int n) |
| 109 | { |
| 110 | struct nlattr *keys_start = nla_nest_start(skb, TCA_PEDIT_KEYS_EX); |
| 111 | |
Davide Caratti | 85eb9af | 2018-08-27 22:56:22 +0200 | [diff] [blame] | 112 | if (!keys_start) |
| 113 | goto nla_failure; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 114 | for (; n > 0; n--) { |
| 115 | struct nlattr *key_start; |
| 116 | |
| 117 | key_start = nla_nest_start(skb, TCA_PEDIT_KEY_EX); |
Davide Caratti | 85eb9af | 2018-08-27 22:56:22 +0200 | [diff] [blame] | 118 | if (!key_start) |
| 119 | goto nla_failure; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 120 | |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 121 | if (nla_put_u16(skb, TCA_PEDIT_KEY_EX_HTYPE, keys_ex->htype) || |
Davide Caratti | 85eb9af | 2018-08-27 22:56:22 +0200 | [diff] [blame] | 122 | nla_put_u16(skb, TCA_PEDIT_KEY_EX_CMD, keys_ex->cmd)) |
| 123 | goto nla_failure; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 124 | |
| 125 | nla_nest_end(skb, key_start); |
| 126 | |
| 127 | keys_ex++; |
| 128 | } |
| 129 | |
| 130 | nla_nest_end(skb, keys_start); |
| 131 | |
| 132 | return 0; |
Davide Caratti | 85eb9af | 2018-08-27 22:56:22 +0200 | [diff] [blame] | 133 | nla_failure: |
| 134 | nla_nest_cancel(skb, keys_start); |
| 135 | return -EINVAL; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 136 | } |
| 137 | |
Benjamin LaHaise | c1b5273 | 2013-01-14 05:15:39 +0000 | [diff] [blame] | 138 | static int tcf_pedit_init(struct net *net, struct nlattr *nla, |
WANG Cong | a85a970 | 2016-07-25 16:09:41 -0700 | [diff] [blame] | 139 | struct nlattr *est, struct tc_action **a, |
Vlad Buslov | 789871b | 2018-07-05 17:24:25 +0300 | [diff] [blame] | 140 | int ovr, int bind, bool rtnl_held, |
| 141 | struct netlink_ext_ack *extack) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 142 | { |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 143 | struct tc_action_net *tn = net_generic(net, pedit_net_id); |
Patrick McHardy | 7ba699c | 2008-01-22 22:11:50 -0800 | [diff] [blame] | 144 | struct nlattr *tb[TCA_PEDIT_MAX + 1]; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 145 | struct tc_pedit_key *keys = NULL; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 146 | struct tcf_pedit_key_ex *keys_ex; |
Roman Mashak | 80f0f57 | 2018-06-27 13:33:30 -0400 | [diff] [blame] | 147 | struct tc_pedit *parm; |
| 148 | struct nlattr *pattr; |
| 149 | struct tcf_pedit *p; |
| 150 | int ret = 0, err; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 151 | int ksize; |
| 152 | |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 153 | if (!nla) { |
| 154 | NL_SET_ERR_MSG_MOD(extack, "Pedit requires attributes to be passed"); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 155 | return -EINVAL; |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 156 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 157 | |
Johannes Berg | fceb643 | 2017-04-12 14:34:07 +0200 | [diff] [blame] | 158 | err = nla_parse_nested(tb, TCA_PEDIT_MAX, nla, pedit_policy, NULL); |
Patrick McHardy | cee6372 | 2008-01-23 20:33:32 -0800 | [diff] [blame] | 159 | if (err < 0) |
| 160 | return err; |
| 161 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 162 | pattr = tb[TCA_PEDIT_PARMS]; |
| 163 | if (!pattr) |
| 164 | pattr = tb[TCA_PEDIT_PARMS_EX]; |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 165 | if (!pattr) { |
| 166 | NL_SET_ERR_MSG_MOD(extack, "Missing required TCA_PEDIT_PARMS or TCA_PEDIT_PARMS_EX pedit attribute"); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 167 | return -EINVAL; |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 168 | } |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 169 | |
| 170 | parm = nla_data(pattr); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 171 | ksize = parm->nkeys * sizeof(struct tc_pedit_key); |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 172 | if (nla_len(pattr) < sizeof(*parm) + ksize) { |
| 173 | NL_SET_ERR_MSG_ATTR(extack, pattr, "Length of TCA_PEDIT_PARMS or TCA_PEDIT_PARMS_EX pedit attribute is invalid"); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 174 | return -EINVAL; |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 175 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 176 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 177 | keys_ex = tcf_pedit_keys_ex_parse(tb[TCA_PEDIT_KEYS_EX], parm->nkeys); |
| 178 | if (IS_ERR(keys_ex)) |
| 179 | return PTR_ERR(keys_ex); |
| 180 | |
Vlad Buslov | 0190c1d | 2018-07-05 17:24:32 +0300 | [diff] [blame] | 181 | err = tcf_idr_check_alloc(tn, &parm->index, a, bind); |
| 182 | if (!err) { |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 183 | if (!parm->nkeys) { |
Vlad Buslov | 0190c1d | 2018-07-05 17:24:32 +0300 | [diff] [blame] | 184 | tcf_idr_cleanup(tn, parm->index); |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 185 | NL_SET_ERR_MSG_MOD(extack, "Pedit requires keys to be passed"); |
Wei Yongjun | 30e99ed | 2018-07-03 13:45:12 +0000 | [diff] [blame] | 186 | ret = -EINVAL; |
| 187 | goto out_free; |
Roman Mashak | 9868c0b | 2018-07-02 00:02:02 -0400 | [diff] [blame] | 188 | } |
Chris Mi | 65a206c | 2017-08-30 02:31:59 -0400 | [diff] [blame] | 189 | ret = tcf_idr_create(tn, parm->index, est, a, |
| 190 | &act_pedit_ops, bind, false); |
Vlad Buslov | 0190c1d | 2018-07-05 17:24:32 +0300 | [diff] [blame] | 191 | if (ret) { |
| 192 | tcf_idr_cleanup(tn, parm->index); |
Wei Yongjun | 30e99ed | 2018-07-03 13:45:12 +0000 | [diff] [blame] | 193 | goto out_free; |
Vlad Buslov | 0190c1d | 2018-07-05 17:24:32 +0300 | [diff] [blame] | 194 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 195 | ret = ACT_P_CREATED; |
Vlad Buslov | 0190c1d | 2018-07-05 17:24:32 +0300 | [diff] [blame] | 196 | } else if (err > 0) { |
Jamal Hadi Salim | 1a29321 | 2013-12-23 08:02:11 -0500 | [diff] [blame] | 197 | if (bind) |
Wei Yongjun | 30e99ed | 2018-07-03 13:45:12 +0000 | [diff] [blame] | 198 | goto out_free; |
Wei Yongjun | 30e99ed | 2018-07-03 13:45:12 +0000 | [diff] [blame] | 199 | if (!ovr) { |
| 200 | ret = -EEXIST; |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 201 | goto out_release; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 202 | } |
Vlad Buslov | 0190c1d | 2018-07-05 17:24:32 +0300 | [diff] [blame] | 203 | } else { |
Davide Caratti | 19ab691 | 2018-11-14 12:17:25 +0100 | [diff] [blame] | 204 | ret = err; |
| 205 | goto out_free; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 206 | } |
| 207 | |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 208 | p = to_pedit(*a); |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 209 | spin_lock_bh(&p->tcf_lock); |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 210 | |
| 211 | if (ret == ACT_P_CREATED || |
| 212 | (p->tcfp_nkeys && p->tcfp_nkeys != parm->nkeys)) { |
| 213 | keys = kmalloc(ksize, GFP_ATOMIC); |
| 214 | if (!keys) { |
| 215 | spin_unlock_bh(&p->tcf_lock); |
| 216 | ret = -ENOMEM; |
| 217 | goto out_release; |
| 218 | } |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 219 | kfree(p->tcfp_keys); |
| 220 | p->tcfp_keys = keys; |
| 221 | p->tcfp_nkeys = parm->nkeys; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 222 | } |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 223 | memcpy(p->tcfp_keys, parm->keys, ksize); |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 224 | |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 225 | p->tcfp_flags = parm->flags; |
| 226 | p->tcf_action = parm->action; |
| 227 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 228 | kfree(p->tcfp_keys_ex); |
| 229 | p->tcfp_keys_ex = keys_ex; |
| 230 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 231 | spin_unlock_bh(&p->tcf_lock); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 232 | if (ret == ACT_P_CREATED) |
Chris Mi | 65a206c | 2017-08-30 02:31:59 -0400 | [diff] [blame] | 233 | tcf_idr_insert(tn, *a); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 234 | return ret; |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 235 | |
| 236 | out_release: |
| 237 | tcf_idr_release(*a, bind); |
Wei Yongjun | 30e99ed | 2018-07-03 13:45:12 +0000 | [diff] [blame] | 238 | out_free: |
| 239 | kfree(keys_ex); |
| 240 | return ret; |
| 241 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 242 | } |
| 243 | |
Cong Wang | 9a63b25 | 2017-12-05 12:53:07 -0800 | [diff] [blame] | 244 | static void tcf_pedit_cleanup(struct tc_action *a) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 245 | { |
WANG Cong | a85a970 | 2016-07-25 16:09:41 -0700 | [diff] [blame] | 246 | struct tcf_pedit *p = to_pedit(a); |
WANG Cong | a5b5c95 | 2014-02-11 17:07:32 -0800 | [diff] [blame] | 247 | struct tc_pedit_key *keys = p->tcfp_keys; |
Roman Mashak | 80f0f57 | 2018-06-27 13:33:30 -0400 | [diff] [blame] | 248 | |
WANG Cong | a5b5c95 | 2014-02-11 17:07:32 -0800 | [diff] [blame] | 249 | kfree(keys); |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 250 | kfree(p->tcfp_keys_ex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 251 | } |
| 252 | |
Amir Vadai | 95c2027 | 2016-11-28 12:56:40 +0200 | [diff] [blame] | 253 | static bool offset_valid(struct sk_buff *skb, int offset) |
| 254 | { |
| 255 | if (offset > 0 && offset > skb->len) |
| 256 | return false; |
| 257 | |
| 258 | if (offset < 0 && -offset > skb_headroom(skb)) |
| 259 | return false; |
| 260 | |
| 261 | return true; |
| 262 | } |
| 263 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 264 | static int pedit_skb_hdr_offset(struct sk_buff *skb, |
| 265 | enum pedit_header_type htype, int *hoffset) |
| 266 | { |
| 267 | int ret = -EINVAL; |
| 268 | |
| 269 | switch (htype) { |
| 270 | case TCA_PEDIT_KEY_EX_HDR_TYPE_ETH: |
| 271 | if (skb_mac_header_was_set(skb)) { |
| 272 | *hoffset = skb_mac_offset(skb); |
| 273 | ret = 0; |
| 274 | } |
| 275 | break; |
| 276 | case TCA_PEDIT_KEY_EX_HDR_TYPE_NETWORK: |
| 277 | case TCA_PEDIT_KEY_EX_HDR_TYPE_IP4: |
| 278 | case TCA_PEDIT_KEY_EX_HDR_TYPE_IP6: |
| 279 | *hoffset = skb_network_offset(skb); |
| 280 | ret = 0; |
| 281 | break; |
| 282 | case TCA_PEDIT_KEY_EX_HDR_TYPE_TCP: |
| 283 | case TCA_PEDIT_KEY_EX_HDR_TYPE_UDP: |
| 284 | if (skb_transport_header_was_set(skb)) { |
| 285 | *hoffset = skb_transport_offset(skb); |
| 286 | ret = 0; |
| 287 | } |
| 288 | break; |
| 289 | default: |
| 290 | ret = -EINVAL; |
| 291 | break; |
YueHaibing | 0a80848 | 2018-07-28 18:29:01 +0800 | [diff] [blame] | 292 | } |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 293 | |
| 294 | return ret; |
| 295 | } |
| 296 | |
Jamal Hadi Salim | 6a2b401 | 2018-08-12 09:34:55 -0400 | [diff] [blame] | 297 | static int tcf_pedit_act(struct sk_buff *skb, const struct tc_action *a, |
| 298 | struct tcf_result *res) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 299 | { |
WANG Cong | a85a970 | 2016-07-25 16:09:41 -0700 | [diff] [blame] | 300 | struct tcf_pedit *p = to_pedit(a); |
Florian Westphal | 4749c3ef | 2015-04-30 12:12:00 +0200 | [diff] [blame] | 301 | int i; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 302 | |
Pravin B Shelar | 14bbd6a | 2013-02-14 09:44:49 +0000 | [diff] [blame] | 303 | if (skb_unclone(skb, GFP_ATOMIC)) |
Eric Dumazet | cc7ec45 | 2011-01-19 19:26:56 +0000 | [diff] [blame] | 304 | return p->tcf_action; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 305 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 306 | spin_lock(&p->tcf_lock); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 307 | |
Jamal Hadi Salim | 9c4a4e4 | 2016-06-06 06:32:53 -0400 | [diff] [blame] | 308 | tcf_lastuse_update(&p->tcf_tm); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 309 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 310 | if (p->tcfp_nkeys > 0) { |
| 311 | struct tc_pedit_key *tkey = p->tcfp_keys; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 312 | struct tcf_pedit_key_ex *tkey_ex = p->tcfp_keys_ex; |
Roman Mashak | 80f0f57 | 2018-06-27 13:33:30 -0400 | [diff] [blame] | 313 | enum pedit_header_type htype = |
| 314 | TCA_PEDIT_KEY_EX_HDR_TYPE_NETWORK; |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 315 | enum pedit_cmd cmd = TCA_PEDIT_KEY_EX_CMD_SET; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 316 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 317 | for (i = p->tcfp_nkeys; i > 0; i--, tkey++) { |
Roman Mashak | 544377c | 2018-06-27 13:33:32 -0400 | [diff] [blame] | 318 | u32 *ptr, hdata; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 319 | int offset = tkey->off; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 320 | int hoffset; |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 321 | u32 val; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 322 | int rc; |
| 323 | |
| 324 | if (tkey_ex) { |
| 325 | htype = tkey_ex->htype; |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 326 | cmd = tkey_ex->cmd; |
| 327 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 328 | tkey_ex++; |
| 329 | } |
| 330 | |
| 331 | rc = pedit_skb_hdr_offset(skb, htype, &hoffset); |
| 332 | if (rc) { |
Roman Mashak | 95b0d2d | 2018-06-27 13:33:34 -0400 | [diff] [blame] | 333 | pr_info("tc action pedit bad header type specified (0x%x)\n", |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 334 | htype); |
| 335 | goto bad; |
| 336 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 337 | |
| 338 | if (tkey->offmask) { |
Roman Mashak | 4305274 | 2018-06-27 13:33:35 -0400 | [diff] [blame] | 339 | u8 *d, _d; |
Changli Gao | db2c241 | 2010-06-02 04:55:02 +0000 | [diff] [blame] | 340 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 341 | if (!offset_valid(skb, hoffset + tkey->at)) { |
Roman Mashak | 95b0d2d | 2018-06-27 13:33:34 -0400 | [diff] [blame] | 342 | pr_info("tc action pedit 'at' offset %d out of bounds\n", |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 343 | hoffset + tkey->at); |
Amir Vadai | 95c2027 | 2016-11-28 12:56:40 +0200 | [diff] [blame] | 344 | goto bad; |
| 345 | } |
Roman Mashak | 80f0f57 | 2018-06-27 13:33:30 -0400 | [diff] [blame] | 346 | d = skb_header_pointer(skb, hoffset + tkey->at, |
Roman Mashak | 6ff7586 | 2018-06-27 13:33:33 -0400 | [diff] [blame] | 347 | sizeof(_d), &_d); |
Changli Gao | db2c241 | 2010-06-02 04:55:02 +0000 | [diff] [blame] | 348 | if (!d) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 349 | goto bad; |
Changli Gao | db2c241 | 2010-06-02 04:55:02 +0000 | [diff] [blame] | 350 | offset += (*d & tkey->offmask) >> tkey->shift; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 351 | } |
| 352 | |
| 353 | if (offset % 4) { |
Roman Mashak | 95b0d2d | 2018-06-27 13:33:34 -0400 | [diff] [blame] | 354 | pr_info("tc action pedit offset must be on 32 bit boundaries\n"); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 355 | goto bad; |
| 356 | } |
Amir Vadai | 95c2027 | 2016-11-28 12:56:40 +0200 | [diff] [blame] | 357 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 358 | if (!offset_valid(skb, hoffset + offset)) { |
Roman Mashak | 95b0d2d | 2018-06-27 13:33:34 -0400 | [diff] [blame] | 359 | pr_info("tc action pedit offset %d out of bounds\n", |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 360 | hoffset + offset); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 361 | goto bad; |
| 362 | } |
| 363 | |
Roman Mashak | 80f0f57 | 2018-06-27 13:33:30 -0400 | [diff] [blame] | 364 | ptr = skb_header_pointer(skb, hoffset + offset, |
Roman Mashak | 6ff7586 | 2018-06-27 13:33:33 -0400 | [diff] [blame] | 365 | sizeof(hdata), &hdata); |
Changli Gao | db2c241 | 2010-06-02 04:55:02 +0000 | [diff] [blame] | 366 | if (!ptr) |
| 367 | goto bad; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 368 | /* just do it, baby */ |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 369 | switch (cmd) { |
| 370 | case TCA_PEDIT_KEY_EX_CMD_SET: |
| 371 | val = tkey->val; |
| 372 | break; |
| 373 | case TCA_PEDIT_KEY_EX_CMD_ADD: |
| 374 | val = (*ptr + tkey->val) & ~tkey->mask; |
| 375 | break; |
| 376 | default: |
Roman Mashak | 95b0d2d | 2018-06-27 13:33:34 -0400 | [diff] [blame] | 377 | pr_info("tc action pedit bad command (%d)\n", |
Amir Vadai | 853a14b | 2017-02-07 09:56:08 +0200 | [diff] [blame] | 378 | cmd); |
| 379 | goto bad; |
| 380 | } |
| 381 | |
| 382 | *ptr = ((*ptr & tkey->mask) ^ val); |
Roman Mashak | 544377c | 2018-06-27 13:33:32 -0400 | [diff] [blame] | 383 | if (ptr == &hdata) |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 384 | skb_store_bits(skb, hoffset + offset, ptr, 4); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 385 | } |
YOSHIFUJI Hideaki | 10297b9 | 2007-02-09 23:25:16 +0900 | [diff] [blame] | 386 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 387 | goto done; |
Roman Mashak | 80f0f57 | 2018-06-27 13:33:30 -0400 | [diff] [blame] | 388 | } else { |
stephen hemminger | 6ff9c36 | 2010-05-12 06:37:05 +0000 | [diff] [blame] | 389 | WARN(1, "pedit BUG: index %d\n", p->tcf_index); |
Roman Mashak | 80f0f57 | 2018-06-27 13:33:30 -0400 | [diff] [blame] | 390 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 391 | |
| 392 | bad: |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 393 | p->tcf_qstats.overlimits++; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 394 | done: |
Eric Dumazet | bfe0d02 | 2011-01-09 08:30:54 +0000 | [diff] [blame] | 395 | bstats_update(&p->tcf_bstats, skb); |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 396 | spin_unlock(&p->tcf_lock); |
| 397 | return p->tcf_action; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 398 | } |
| 399 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 400 | static int tcf_pedit_dump(struct sk_buff *skb, struct tc_action *a, |
| 401 | int bind, int ref) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 402 | { |
Arnaldo Carvalho de Melo | 27a884d | 2007-04-19 20:29:13 -0700 | [diff] [blame] | 403 | unsigned char *b = skb_tail_pointer(skb); |
WANG Cong | a85a970 | 2016-07-25 16:09:41 -0700 | [diff] [blame] | 404 | struct tcf_pedit *p = to_pedit(a); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 405 | struct tc_pedit *opt; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 406 | struct tcf_t t; |
YOSHIFUJI Hideaki | 10297b9 | 2007-02-09 23:25:16 +0900 | [diff] [blame] | 407 | int s; |
| 408 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 409 | s = sizeof(*opt) + p->tcfp_nkeys * sizeof(struct tc_pedit_key); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 410 | |
| 411 | /* netlink spinlocks held above us - must use ATOMIC */ |
Panagiotis Issaris | 0da974f | 2006-07-21 14:51:30 -0700 | [diff] [blame] | 412 | opt = kzalloc(s, GFP_ATOMIC); |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 413 | if (unlikely(!opt)) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 414 | return -ENOBUFS; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 415 | |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 416 | spin_lock_bh(&p->tcf_lock); |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 417 | memcpy(opt->keys, p->tcfp_keys, |
| 418 | p->tcfp_nkeys * sizeof(struct tc_pedit_key)); |
| 419 | opt->index = p->tcf_index; |
| 420 | opt->nkeys = p->tcfp_nkeys; |
| 421 | opt->flags = p->tcfp_flags; |
| 422 | opt->action = p->tcf_action; |
Vlad Buslov | 036bb44 | 2018-07-05 17:24:24 +0300 | [diff] [blame] | 423 | opt->refcnt = refcount_read(&p->tcf_refcnt) - ref; |
| 424 | opt->bindcnt = atomic_read(&p->tcf_bindcnt) - bind; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 425 | |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 426 | if (p->tcfp_keys_ex) { |
Davide Caratti | 85eb9af | 2018-08-27 22:56:22 +0200 | [diff] [blame] | 427 | if (tcf_pedit_key_ex_dump(skb, |
| 428 | p->tcfp_keys_ex, |
| 429 | p->tcfp_nkeys)) |
| 430 | goto nla_put_failure; |
Amir Vadai | 71d0ed7 | 2017-02-07 09:56:07 +0200 | [diff] [blame] | 431 | |
| 432 | if (nla_put(skb, TCA_PEDIT_PARMS_EX, s, opt)) |
| 433 | goto nla_put_failure; |
| 434 | } else { |
| 435 | if (nla_put(skb, TCA_PEDIT_PARMS, s, opt)) |
| 436 | goto nla_put_failure; |
| 437 | } |
Jamal Hadi Salim | 48d8ee1 | 2016-06-06 06:32:55 -0400 | [diff] [blame] | 438 | |
| 439 | tcf_tm_dump(&t, &p->tcf_tm); |
Nicolas Dichtel | 9854518e | 2016-04-26 10:06:18 +0200 | [diff] [blame] | 440 | if (nla_put_64bit(skb, TCA_PEDIT_TM, sizeof(t), &t, TCA_PEDIT_PAD)) |
David S. Miller | 1b34ec4 | 2012-03-29 05:11:39 -0400 | [diff] [blame] | 441 | goto nla_put_failure; |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 442 | spin_unlock_bh(&p->tcf_lock); |
Jamal Hadi Salim | 48d8ee1 | 2016-06-06 06:32:55 -0400 | [diff] [blame] | 443 | |
Patrick McHardy | 541673c8 | 2006-01-08 22:17:27 -0800 | [diff] [blame] | 444 | kfree(opt); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 445 | return skb->len; |
| 446 | |
Patrick McHardy | 7ba699c | 2008-01-22 22:11:50 -0800 | [diff] [blame] | 447 | nla_put_failure: |
Vlad Buslov | 67b0c1a | 2018-08-10 20:51:46 +0300 | [diff] [blame] | 448 | spin_unlock_bh(&p->tcf_lock); |
Arnaldo Carvalho de Melo | dc5fc57 | 2007-03-25 23:06:12 -0700 | [diff] [blame] | 449 | nlmsg_trim(skb, b); |
Patrick McHardy | 541673c8 | 2006-01-08 22:17:27 -0800 | [diff] [blame] | 450 | kfree(opt); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 451 | return -1; |
| 452 | } |
| 453 | |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 454 | static int tcf_pedit_walker(struct net *net, struct sk_buff *skb, |
| 455 | struct netlink_callback *cb, int type, |
Alexander Aring | 4178010 | 2018-02-15 10:54:58 -0500 | [diff] [blame] | 456 | const struct tc_action_ops *ops, |
| 457 | struct netlink_ext_ack *extack) |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 458 | { |
| 459 | struct tc_action_net *tn = net_generic(net, pedit_net_id); |
| 460 | |
Alexander Aring | b362014 | 2018-02-15 10:54:59 -0500 | [diff] [blame] | 461 | return tcf_generic_walker(tn, skb, cb, type, ops, extack); |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 462 | } |
| 463 | |
Cong Wang | f061b48 | 2018-08-29 10:15:35 -0700 | [diff] [blame] | 464 | static int tcf_pedit_search(struct net *net, struct tc_action **a, u32 index) |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 465 | { |
| 466 | struct tc_action_net *tn = net_generic(net, pedit_net_id); |
| 467 | |
Chris Mi | 65a206c | 2017-08-30 02:31:59 -0400 | [diff] [blame] | 468 | return tcf_idr_search(tn, a, index); |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 469 | } |
| 470 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 471 | static struct tc_action_ops act_pedit_ops = { |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 472 | .kind = "pedit", |
| 473 | .type = TCA_ACT_PEDIT, |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 474 | .owner = THIS_MODULE, |
Jamal Hadi Salim | 6a2b401 | 2018-08-12 09:34:55 -0400 | [diff] [blame] | 475 | .act = tcf_pedit_act, |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 476 | .dump = tcf_pedit_dump, |
| 477 | .cleanup = tcf_pedit_cleanup, |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 478 | .init = tcf_pedit_init, |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 479 | .walk = tcf_pedit_walker, |
| 480 | .lookup = tcf_pedit_search, |
WANG Cong | a85a970 | 2016-07-25 16:09:41 -0700 | [diff] [blame] | 481 | .size = sizeof(struct tcf_pedit), |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 482 | }; |
| 483 | |
| 484 | static __net_init int pedit_init_net(struct net *net) |
| 485 | { |
| 486 | struct tc_action_net *tn = net_generic(net, pedit_net_id); |
| 487 | |
Cong Wang | c7e460c | 2017-11-06 13:47:18 -0800 | [diff] [blame] | 488 | return tc_action_net_init(tn, &act_pedit_ops); |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 489 | } |
| 490 | |
Cong Wang | 039af9c | 2017-12-11 15:35:03 -0800 | [diff] [blame] | 491 | static void __net_exit pedit_exit_net(struct list_head *net_list) |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 492 | { |
Cong Wang | 039af9c | 2017-12-11 15:35:03 -0800 | [diff] [blame] | 493 | tc_action_net_exit(net_list, pedit_net_id); |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 494 | } |
| 495 | |
| 496 | static struct pernet_operations pedit_net_ops = { |
| 497 | .init = pedit_init_net, |
Cong Wang | 039af9c | 2017-12-11 15:35:03 -0800 | [diff] [blame] | 498 | .exit_batch = pedit_exit_net, |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 499 | .id = &pedit_net_id, |
| 500 | .size = sizeof(struct tc_action_net), |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 501 | }; |
| 502 | |
| 503 | MODULE_AUTHOR("Jamal Hadi Salim(2002-4)"); |
| 504 | MODULE_DESCRIPTION("Generic Packet Editor actions"); |
| 505 | MODULE_LICENSE("GPL"); |
| 506 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 507 | static int __init pedit_init_module(void) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 508 | { |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 509 | return tcf_register_action(&act_pedit_ops, &pedit_net_ops); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 510 | } |
| 511 | |
David S. Miller | e9ce1cd | 2006-08-21 23:54:55 -0700 | [diff] [blame] | 512 | static void __exit pedit_cleanup_module(void) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 513 | { |
WANG Cong | ddf97cc | 2016-02-22 15:57:53 -0800 | [diff] [blame] | 514 | tcf_unregister_action(&act_pedit_ops, &pedit_net_ops); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 515 | } |
| 516 | |
| 517 | module_init(pedit_init_module); |
| 518 | module_exit(pedit_cleanup_module); |