blob: 07fa760805125a73ca45b0a96f1fc38266b70660 [file] [log] [blame]
Thomas Gleixner2874c5f2019-05-27 08:55:01 +02001// SPDX-License-Identifier: GPL-2.0-or-later
Linus Torvalds1da177e2005-04-16 15:20:36 -07002/*
3 * Sysfs attributes of bridge ports
4 * Linux ethernet bridge
5 *
6 * Authors:
7 * Stephen Hemminger <shemminger@osdl.org>
Linus Torvalds1da177e2005-04-16 15:20:36 -07008 */
9
Randy Dunlap4fc268d2006-01-11 12:17:47 -080010#include <linux/capability.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070011#include <linux/kernel.h>
12#include <linux/netdevice.h>
13#include <linux/if_bridge.h>
14#include <linux/rtnetlink.h>
15#include <linux/spinlock.h>
Ingo Molnar174cd4b2017-02-02 19:15:33 +010016#include <linux/sched/signal.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070017
18#include "br_private.h"
19
Nikolay Aleksandrov1e16f382021-01-29 13:51:42 +020020/* IMPORTANT: new bridge port options must be added with netlink support only
21 * please do not add new sysfs entries
22 */
23
Linus Torvalds1da177e2005-04-16 15:20:36 -070024struct brport_attribute {
25 struct attribute attr;
26 ssize_t (*show)(struct net_bridge_port *, char *);
stephen hemminger14f98f22011-04-04 14:03:33 +000027 int (*store)(struct net_bridge_port *, unsigned long);
Nikolay Aleksandrova5f3ea52018-07-23 11:16:58 +030028 int (*store_raw)(struct net_bridge_port *, char *);
29};
30
31#define BRPORT_ATTR_RAW(_name, _mode, _show, _store) \
32const struct brport_attribute brport_attr_##_name = { \
33 .attr = {.name = __stringify(_name), \
34 .mode = _mode }, \
35 .show = _show, \
36 .store_raw = _store, \
Linus Torvalds1da177e2005-04-16 15:20:36 -070037};
38
tanxiaojun31a5b832013-12-19 13:28:12 +080039#define BRPORT_ATTR(_name, _mode, _show, _store) \
stephen hemminger5a0d5132012-07-30 08:55:49 +000040const struct brport_attribute brport_attr_##_name = { \
Linus Torvalds1da177e2005-04-16 15:20:36 -070041 .attr = {.name = __stringify(_name), \
Tejun Heo7b595752007-06-14 03:45:17 +090042 .mode = _mode }, \
Linus Torvalds1da177e2005-04-16 15:20:36 -070043 .show = _show, \
44 .store = _store, \
45};
46
stephen hemmingercd753732012-11-13 07:53:06 +000047#define BRPORT_ATTR_FLAG(_name, _mask) \
48static ssize_t show_##_name(struct net_bridge_port *p, char *buf) \
49{ \
50 return sprintf(buf, "%d\n", !!(p->flags & _mask)); \
51} \
52static int store_##_name(struct net_bridge_port *p, unsigned long v) \
53{ \
Vlad Yasevich63c3a622014-05-16 09:59:15 -040054 return store_flag(p, v, _mask); \
stephen hemmingercd753732012-11-13 07:53:06 +000055} \
Joe Perchesd6444062018-03-23 15:54:38 -070056static BRPORT_ATTR(_name, 0644, \
stephen hemmingercd753732012-11-13 07:53:06 +000057 show_##_name, store_##_name)
58
Vlad Yasevich63c3a622014-05-16 09:59:15 -040059static int store_flag(struct net_bridge_port *p, unsigned long v,
60 unsigned long mask)
61{
Vladimir Oltean078bbb82021-02-12 17:15:53 +020062 struct netlink_ext_ack extack = {0};
Vladimir Oltean8043c842021-02-07 21:47:33 +020063 unsigned long flags = p->flags;
64 int err;
Vlad Yasevich63c3a622014-05-16 09:59:15 -040065
66 if (v)
67 flags |= mask;
68 else
69 flags &= ~mask;
70
71 if (flags != p->flags) {
Vladimir Oltean078bbb82021-02-12 17:15:53 +020072 err = br_switchdev_set_port_flag(p, flags, mask, &extack);
73 if (err) {
74 netdev_err(p->dev, "%s\n", extack._msg);
Vladimir Oltean8043c842021-02-07 21:47:33 +020075 return err;
Vladimir Oltean078bbb82021-02-12 17:15:53 +020076 }
Vladimir Oltean8043c842021-02-07 21:47:33 +020077
Vlad Yasevich63c3a622014-05-16 09:59:15 -040078 p->flags = flags;
Vlad Yaseviche028e4b2014-05-16 09:59:16 -040079 br_port_flags_change(p, mask);
Vlad Yasevich63c3a622014-05-16 09:59:15 -040080 }
81 return 0;
82}
stephen hemmingercd753732012-11-13 07:53:06 +000083
Linus Torvalds1da177e2005-04-16 15:20:36 -070084static ssize_t show_path_cost(struct net_bridge_port *p, char *buf)
85{
86 return sprintf(buf, "%d\n", p->path_cost);
87}
stephen hemminger14f98f22011-04-04 14:03:33 +000088
Joe Perchesd6444062018-03-23 15:54:38 -070089static BRPORT_ATTR(path_cost, 0644,
stephen hemminger14f98f22011-04-04 14:03:33 +000090 show_path_cost, br_stp_set_path_cost);
Linus Torvalds1da177e2005-04-16 15:20:36 -070091
92static ssize_t show_priority(struct net_bridge_port *p, char *buf)
93{
94 return sprintf(buf, "%d\n", p->priority);
95}
stephen hemminger14f98f22011-04-04 14:03:33 +000096
Joe Perchesd6444062018-03-23 15:54:38 -070097static BRPORT_ATTR(priority, 0644,
stephen hemminger14f98f22011-04-04 14:03:33 +000098 show_priority, br_stp_set_port_priority);
Linus Torvalds1da177e2005-04-16 15:20:36 -070099
100static ssize_t show_designated_root(struct net_bridge_port *p, char *buf)
101{
102 return br_show_bridge_id(buf, &p->designated_root);
103}
Joe Perchesd6444062018-03-23 15:54:38 -0700104static BRPORT_ATTR(designated_root, 0444, show_designated_root, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700105
106static ssize_t show_designated_bridge(struct net_bridge_port *p, char *buf)
107{
108 return br_show_bridge_id(buf, &p->designated_bridge);
109}
Joe Perchesd6444062018-03-23 15:54:38 -0700110static BRPORT_ATTR(designated_bridge, 0444, show_designated_bridge, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700111
112static ssize_t show_designated_port(struct net_bridge_port *p, char *buf)
113{
114 return sprintf(buf, "%d\n", p->designated_port);
115}
Joe Perchesd6444062018-03-23 15:54:38 -0700116static BRPORT_ATTR(designated_port, 0444, show_designated_port, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700117
118static ssize_t show_designated_cost(struct net_bridge_port *p, char *buf)
119{
120 return sprintf(buf, "%d\n", p->designated_cost);
121}
Joe Perchesd6444062018-03-23 15:54:38 -0700122static BRPORT_ATTR(designated_cost, 0444, show_designated_cost, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700123
124static ssize_t show_port_id(struct net_bridge_port *p, char *buf)
125{
126 return sprintf(buf, "0x%x\n", p->port_id);
127}
Joe Perchesd6444062018-03-23 15:54:38 -0700128static BRPORT_ATTR(port_id, 0444, show_port_id, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700129
130static ssize_t show_port_no(struct net_bridge_port *p, char *buf)
131{
132 return sprintf(buf, "0x%x\n", p->port_no);
133}
134
Joe Perchesd6444062018-03-23 15:54:38 -0700135static BRPORT_ATTR(port_no, 0444, show_port_no, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700136
137static ssize_t show_change_ack(struct net_bridge_port *p, char *buf)
138{
139 return sprintf(buf, "%d\n", p->topology_change_ack);
140}
Joe Perchesd6444062018-03-23 15:54:38 -0700141static BRPORT_ATTR(change_ack, 0444, show_change_ack, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700142
143static ssize_t show_config_pending(struct net_bridge_port *p, char *buf)
144{
145 return sprintf(buf, "%d\n", p->config_pending);
146}
Joe Perchesd6444062018-03-23 15:54:38 -0700147static BRPORT_ATTR(config_pending, 0444, show_config_pending, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700148
149static ssize_t show_port_state(struct net_bridge_port *p, char *buf)
150{
151 return sprintf(buf, "%d\n", p->state);
152}
Joe Perchesd6444062018-03-23 15:54:38 -0700153static BRPORT_ATTR(state, 0444, show_port_state, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700154
155static ssize_t show_message_age_timer(struct net_bridge_port *p,
156 char *buf)
157{
158 return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
159}
Joe Perchesd6444062018-03-23 15:54:38 -0700160static BRPORT_ATTR(message_age_timer, 0444, show_message_age_timer, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700161
162static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
163 char *buf)
164{
165 return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
166}
Joe Perchesd6444062018-03-23 15:54:38 -0700167static BRPORT_ATTR(forward_delay_timer, 0444, show_forward_delay_timer, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700168
169static ssize_t show_hold_timer(struct net_bridge_port *p,
170 char *buf)
171{
172 return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
173}
Joe Perchesd6444062018-03-23 15:54:38 -0700174static BRPORT_ATTR(hold_timer, 0444, show_hold_timer, NULL);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700175
stephen hemminger14f98f22011-04-04 14:03:33 +0000176static int store_flush(struct net_bridge_port *p, unsigned long v)
Stephen Hemminger9cf63742007-04-09 12:57:54 -0700177{
Nikolay Aleksandrov1ea2d022015-06-23 05:28:16 -0700178 br_fdb_delete_by_port(p->br, p, 0, 0); // Don't delete local entry
Stephen Hemminger9cf63742007-04-09 12:57:54 -0700179 return 0;
180}
Joe Perchesd6444062018-03-23 15:54:38 -0700181static BRPORT_ATTR(flush, 0200, NULL, store_flush);
Stephen Hemminger9cf63742007-04-09 12:57:54 -0700182
Nikolay Aleksandrov5af48b52017-09-27 16:12:44 +0300183static ssize_t show_group_fwd_mask(struct net_bridge_port *p, char *buf)
184{
185 return sprintf(buf, "%#x\n", p->group_fwd_mask);
186}
187
188static int store_group_fwd_mask(struct net_bridge_port *p,
189 unsigned long v)
190{
191 if (v & BR_GROUPFWD_MACPAUSE)
192 return -EINVAL;
193 p->group_fwd_mask = v;
194
195 return 0;
196}
Joe Perchesd6444062018-03-23 15:54:38 -0700197static BRPORT_ATTR(group_fwd_mask, 0644, show_group_fwd_mask,
Nikolay Aleksandrov5af48b52017-09-27 16:12:44 +0300198 store_group_fwd_mask);
199
Nikolay Aleksandrov2756f682018-07-23 11:16:59 +0300200static ssize_t show_backup_port(struct net_bridge_port *p, char *buf)
201{
202 struct net_bridge_port *backup_p;
203 int ret = 0;
204
205 rcu_read_lock();
206 backup_p = rcu_dereference(p->backup_port);
207 if (backup_p)
208 ret = sprintf(buf, "%s\n", backup_p->dev->name);
209 rcu_read_unlock();
210
211 return ret;
212}
213
214static int store_backup_port(struct net_bridge_port *p, char *buf)
215{
216 struct net_device *backup_dev = NULL;
217 char *nl = strchr(buf, '\n');
218
219 if (nl)
220 *nl = '\0';
221
222 if (strlen(buf) > 0) {
223 backup_dev = __dev_get_by_name(dev_net(p->dev), buf);
224 if (!backup_dev)
225 return -ENOENT;
226 }
227
228 return nbp_backup_change(p, backup_dev);
229}
230static BRPORT_ATTR_RAW(backup_port, 0644, show_backup_port, store_backup_port);
231
stephen hemmingercd753732012-11-13 07:53:06 +0000232BRPORT_ATTR_FLAG(hairpin_mode, BR_HAIRPIN_MODE);
stephen hemmingera2e01a62012-11-13 07:53:07 +0000233BRPORT_ATTR_FLAG(bpdu_guard, BR_BPDU_GUARD);
stephen hemminger1007dd12012-11-13 07:53:08 +0000234BRPORT_ATTR_FLAG(root_block, BR_ROOT_BLOCK);
Vlad Yasevich9ba18892013-06-05 10:08:00 -0400235BRPORT_ATTR_FLAG(learning, BR_LEARNING);
Vlad Yasevich867a5942013-06-05 10:08:01 -0400236BRPORT_ATTR_FLAG(unicast_flood, BR_FLOOD);
Kyeyoon Park95850112014-10-23 14:49:17 -0700237BRPORT_ATTR_FLAG(proxyarp, BR_PROXYARP);
Jouni Malinen842a9ae2015-03-04 12:54:21 +0200238BRPORT_ATTR_FLAG(proxyarp_wifi, BR_PROXYARP_WIFI);
Nikolay Aleksandrovb6cb5ac2016-08-31 15:36:52 +0200239BRPORT_ATTR_FLAG(multicast_flood, BR_MCAST_FLOOD);
Mike Manning99f906e2017-04-26 14:48:09 +0100240BRPORT_ATTR_FLAG(broadcast_flood, BR_BCAST_FLOOD);
Roopa Prabhu821f1b22017-10-06 22:12:37 -0700241BRPORT_ATTR_FLAG(neigh_suppress, BR_NEIGH_SUPPRESS);
Nikolay Aleksandrov7d850ab2018-05-24 11:56:48 +0300242BRPORT_ATTR_FLAG(isolated, BR_ISOLATED);
Fischer, Anna3982d3d2009-08-13 06:55:16 +0000243
Herbert Xu0909e112010-02-27 19:41:49 +0000244#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
245static ssize_t show_multicast_router(struct net_bridge_port *p, char *buf)
246{
Nikolay Aleksandrov96322332021-07-19 20:06:23 +0300247 return sprintf(buf, "%d\n", p->multicast_ctx.multicast_router);
Herbert Xu0909e112010-02-27 19:41:49 +0000248}
249
stephen hemminger14f98f22011-04-04 14:03:33 +0000250static int store_multicast_router(struct net_bridge_port *p,
Herbert Xu0909e112010-02-27 19:41:49 +0000251 unsigned long v)
252{
Nikolay Aleksandrova53581d2021-08-20 15:42:54 +0300253 return br_multicast_set_port_router(&p->multicast_ctx, v);
Herbert Xu0909e112010-02-27 19:41:49 +0000254}
Joe Perchesd6444062018-03-23 15:54:38 -0700255static BRPORT_ATTR(multicast_router, 0644, show_multicast_router,
Herbert Xu0909e112010-02-27 19:41:49 +0000256 store_multicast_router);
Amerigo Wang50426b52012-12-03 23:56:40 +0000257
David S. Millerc2d3bab2012-12-05 16:24:45 -0500258BRPORT_ATTR_FLAG(multicast_fast_leave, BR_MULTICAST_FAST_LEAVE);
Felix Fietkau6db6f0e2017-01-21 21:01:32 +0100259BRPORT_ATTR_FLAG(multicast_to_unicast, BR_MULTICAST_TO_UNICAST);
Herbert Xu0909e112010-02-27 19:41:49 +0000260#endif
261
stephen hemminger5a0d5132012-07-30 08:55:49 +0000262static const struct brport_attribute *brport_attrs[] = {
Linus Torvalds1da177e2005-04-16 15:20:36 -0700263 &brport_attr_path_cost,
264 &brport_attr_priority,
265 &brport_attr_port_id,
266 &brport_attr_port_no,
267 &brport_attr_designated_root,
268 &brport_attr_designated_bridge,
269 &brport_attr_designated_port,
270 &brport_attr_designated_cost,
271 &brport_attr_state,
272 &brport_attr_change_ack,
273 &brport_attr_config_pending,
274 &brport_attr_message_age_timer,
275 &brport_attr_forward_delay_timer,
276 &brport_attr_hold_timer,
Stephen Hemminger9cf63742007-04-09 12:57:54 -0700277 &brport_attr_flush,
Fischer, Anna3982d3d2009-08-13 06:55:16 +0000278 &brport_attr_hairpin_mode,
stephen hemmingera2e01a62012-11-13 07:53:07 +0000279 &brport_attr_bpdu_guard,
stephen hemminger1007dd12012-11-13 07:53:08 +0000280 &brport_attr_root_block,
Vlad Yasevich9ba18892013-06-05 10:08:00 -0400281 &brport_attr_learning,
Vlad Yasevich867a5942013-06-05 10:08:01 -0400282 &brport_attr_unicast_flood,
Herbert Xu0909e112010-02-27 19:41:49 +0000283#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
284 &brport_attr_multicast_router,
Amerigo Wang50426b52012-12-03 23:56:40 +0000285 &brport_attr_multicast_fast_leave,
Felix Fietkau6db6f0e2017-01-21 21:01:32 +0100286 &brport_attr_multicast_to_unicast,
Herbert Xu0909e112010-02-27 19:41:49 +0000287#endif
Kyeyoon Park95850112014-10-23 14:49:17 -0700288 &brport_attr_proxyarp,
Jouni Malinen842a9ae2015-03-04 12:54:21 +0200289 &brport_attr_proxyarp_wifi,
Nikolay Aleksandrov4eb67532016-10-13 15:20:52 +0200290 &brport_attr_multicast_flood,
Mike Manning99f906e2017-04-26 14:48:09 +0100291 &brport_attr_broadcast_flood,
Nikolay Aleksandrov5af48b52017-09-27 16:12:44 +0300292 &brport_attr_group_fwd_mask,
Roopa Prabhu821f1b22017-10-06 22:12:37 -0700293 &brport_attr_neigh_suppress,
Nikolay Aleksandrov7d850ab2018-05-24 11:56:48 +0300294 &brport_attr_isolated,
Nikolay Aleksandrov2756f682018-07-23 11:16:59 +0300295 &brport_attr_backup_port,
Linus Torvalds1da177e2005-04-16 15:20:36 -0700296 NULL
297};
298
299#define to_brport_attr(_at) container_of(_at, struct brport_attribute, attr)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700300
tanxiaojun56b148e2013-12-19 13:28:13 +0800301static ssize_t brport_show(struct kobject *kobj,
302 struct attribute *attr, char *buf)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700303{
tanxiaojun56b148e2013-12-19 13:28:13 +0800304 struct brport_attribute *brport_attr = to_brport_attr(attr);
Tyler Hicks705e0de2018-07-20 21:56:54 +0000305 struct net_bridge_port *p = kobj_to_brport(kobj);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700306
Xin Long1b125802018-02-12 17:15:40 +0800307 if (!brport_attr->show)
308 return -EINVAL;
309
Linus Torvalds1da177e2005-04-16 15:20:36 -0700310 return brport_attr->show(p, buf);
311}
312
tanxiaojun56b148e2013-12-19 13:28:13 +0800313static ssize_t brport_store(struct kobject *kobj,
314 struct attribute *attr,
315 const char *buf, size_t count)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700316{
tanxiaojun56b148e2013-12-19 13:28:13 +0800317 struct brport_attribute *brport_attr = to_brport_attr(attr);
Tyler Hicks705e0de2018-07-20 21:56:54 +0000318 struct net_bridge_port *p = kobj_to_brport(kobj);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700319 ssize_t ret = -EINVAL;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700320 unsigned long val;
Nikolay Aleksandrova5f3ea52018-07-23 11:16:58 +0300321 char *endp;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700322
Eric W. Biedermancb990502012-11-16 03:03:08 +0000323 if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN))
Linus Torvalds1da177e2005-04-16 15:20:36 -0700324 return -EPERM;
325
Nikolay Aleksandrova5f3ea52018-07-23 11:16:58 +0300326 if (!rtnl_trylock())
327 return restart_syscall();
328
Nikolay Aleksandrova5f3ea52018-07-23 11:16:58 +0300329 if (brport_attr->store_raw) {
330 char *buf_copy;
331
332 buf_copy = kstrndup(buf, count, GFP_KERNEL);
333 if (!buf_copy) {
334 ret = -ENOMEM;
335 goto out_unlock;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700336 }
Nikolay Aleksandrova5f3ea52018-07-23 11:16:58 +0300337 spin_lock_bh(&p->br->lock);
338 ret = brport_attr->store_raw(p, buf_copy);
339 spin_unlock_bh(&p->br->lock);
340 kfree(buf_copy);
341 } else if (brport_attr->store) {
342 val = simple_strtoul(buf, &endp, 0);
343 if (endp == buf)
344 goto out_unlock;
345 spin_lock_bh(&p->br->lock);
346 ret = brport_attr->store(p, val);
347 spin_unlock_bh(&p->br->lock);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700348 }
Nikolay Aleksandrova5f3ea52018-07-23 11:16:58 +0300349
350 if (!ret) {
351 br_ifinfo_notify(RTM_NEWLINK, NULL, p);
352 ret = count;
353 }
354out_unlock:
355 rtnl_unlock();
356
Linus Torvalds1da177e2005-04-16 15:20:36 -0700357 return ret;
358}
359
Emese Revfy52cf25d2010-01-19 02:58:23 +0100360const struct sysfs_ops brport_sysfs_ops = {
Linus Torvalds1da177e2005-04-16 15:20:36 -0700361 .show = brport_show,
362 .store = brport_store,
363};
364
Linus Torvalds1da177e2005-04-16 15:20:36 -0700365/*
366 * Add sysfs entries to ethernet device added to a bridge.
367 * Creates a brport subdirectory with bridge attributes.
Simon Arlotte0f43752010-05-10 09:31:11 +0000368 * Puts symlink in bridge's brif subdirectory
Linus Torvalds1da177e2005-04-16 15:20:36 -0700369 */
370int br_sysfs_addif(struct net_bridge_port *p)
371{
372 struct net_bridge *br = p->br;
stephen hemminger5a0d5132012-07-30 08:55:49 +0000373 const struct brport_attribute **a;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700374 int err;
375
Greg Kroah-Hartman43cb76d2002-04-09 12:14:34 -0700376 err = sysfs_create_link(&p->kobj, &br->dev->dev.kobj,
Linus Torvalds1da177e2005-04-16 15:20:36 -0700377 SYSFS_BRIDGE_PORT_LINK);
378 if (err)
Simon Arlotte0f43752010-05-10 09:31:11 +0000379 return err;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700380
381 for (a = brport_attrs; *a; ++a) {
382 err = sysfs_create_file(&p->kobj, &((*a)->attr));
383 if (err)
Simon Arlotte0f43752010-05-10 09:31:11 +0000384 return err;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700385 }
386
Simon Arlotte0f43752010-05-10 09:31:11 +0000387 strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
388 return sysfs_create_link(br->ifobj, &p->kobj, p->sysfs_name);
389}
390
391/* Rename bridge's brif symlink */
392int br_sysfs_renameif(struct net_bridge_port *p)
393{
394 struct net_bridge *br = p->br;
395 int err;
396
397 /* If a rename fails, the rollback will cause another
398 * rename call with the existing name.
399 */
400 if (!strncmp(p->sysfs_name, p->dev->name, IFNAMSIZ))
401 return 0;
402
403 err = sysfs_rename_link(br->ifobj, &p->kobj,
404 p->sysfs_name, p->dev->name);
405 if (err)
406 netdev_notice(br->dev, "unable to rename link %s to %s",
407 p->sysfs_name, p->dev->name);
408 else
409 strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
410
Linus Torvalds1da177e2005-04-16 15:20:36 -0700411 return err;
412}