blob: 65fee63aeadba55ebf74959434842ead7d3354c4 [file] [log] [blame]
Nicolas Palix9e395552013-03-02 22:36:26 +01001#!/bin/bash
Greg Kroah-Hartmanb2441312017-11-01 15:07:57 +01002# SPDX-License-Identifier: GPL-2.0
Luis R. Rodriguezc100d532016-06-29 15:14:58 -07003# Linux kernel coccicheck
4#
Markus Elfring1e018922016-10-07 16:06:15 +02005# Read Documentation/dev-tools/coccinelle.rst
Nicolas Palixec979462013-07-03 16:41:01 +02006#
7# This script requires at least spatch
8# version 1.0.0-rc11.
Nicolas Palixec979462013-07-03 16:41:01 +02009
Luis R. Rodrigueza9e064c2016-06-29 15:14:57 -070010DIR="$(dirname $(readlink -f $0))/.."
Nicolas Palix74425ee2010-06-06 17:15:01 +020011SPATCH="`which ${SPATCH:=spatch}`"
12
Luis R. Rodriguez13d94862016-06-29 15:14:51 -070013if [ ! -x "$SPATCH" ]; then
14 echo 'spatch is part of the Coccinelle project and is available at http://coccinelle.lip6.fr/'
15 exit 1
16fi
17
Luis R. Rodrigueza9e064c2016-06-29 15:14:57 -070018SPATCH_VERSION=$($SPATCH --version | head -1 | awk '{print $3}')
Luis R. Rodrigueza9e064c2016-06-29 15:14:57 -070019
Luis R. Rodriguezc930a1b2016-06-29 15:14:53 -070020USE_JOBS="no"
21$SPATCH --help | grep "\-\-jobs" > /dev/null && USE_JOBS="yes"
Kees Cook90d06a42013-06-18 14:49:29 -070022
Bernd Schubert26e56722013-01-29 17:03:37 +010023# The verbosity may be set by the environmental parameter V=
24# as for example with 'make V=1 coccicheck'
25
26if [ -n "$V" -a "$V" != "0" ]; then
Kees Cook90d06a42013-06-18 14:49:29 -070027 VERBOSE="$V"
Bernd Schubert26e56722013-01-29 17:03:37 +010028else
29 VERBOSE=0
30fi
31
Luis R. Rodriguez8e826ad2016-06-29 15:14:52 -070032FLAGS="--very-quiet"
Nicolas Palix9e395552013-03-02 22:36:26 +010033
Luis R. Rodriguez5c384db2016-06-29 15:14:55 -070034# You can use SPFLAGS to append extra arguments to coccicheck or override any
35# heuristics done in this file as Coccinelle accepts the last options when
36# options conflict.
37#
38# A good example for use of SPFLAGS is if you want to debug your cocci script,
39# you can for instance use the following:
40#
41# $ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
42# $ make coccicheck MODE=report DEBUG_FILE="all.err" SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
43#
44# "--show-trying" should show you what rule is being processed as it goes to
45# stdout, you do not need a debug file for that. The profile output will be
46# be sent to stdout, if you provide a DEBUG_FILE the profiling data can be
47# inspected there.
48#
49# --profile will not output if --very-quiet is used, so avoid it.
50echo $SPFLAGS | egrep -e "--profile|--show-trying" 2>&1 > /dev/null
51if [ $? -eq 0 ]; then
52 FLAGS="--quiet"
53fi
54
Nicolas Palix9e395552013-03-02 22:36:26 +010055# spatch only allows include directories with the syntax "-I include"
56# while gcc also allows "-Iinclude" and "-include include"
57COCCIINCLUDE=${LINUXINCLUDE//-I/-I }
Andrzej Hajda5b169102015-09-22 15:15:30 +020058COCCIINCLUDE=${COCCIINCLUDE// -include/ --include}
Nicolas Palix9e395552013-03-02 22:36:26 +010059
Nicolas Palix1e9dea22010-06-13 09:26:34 +020060if [ "$C" = "1" -o "$C" = "2" ]; then
61 ONLINE=1
62
Sumera Priyadarsinid8f6e5c2020-11-25 02:02:12 +053063 if [[ $# -le 0 ]]; then
64 echo ''
65 echo 'Specifying both the variable "C" and rule "coccicheck" in the make
66command results in a shift count error.'
67 echo ''
68 echo 'Try specifying "scripts/coccicheck" as a value for the CHECK variable instead.'
69 echo ''
70 echo 'Example: make C=2 CHECK=scripts/coccicheck drivers/net/ethernet/ethoc.o'
71 echo ''
72 exit 1
73 fi
74
Nicolas Palix9e395552013-03-02 22:36:26 +010075 # Take only the last argument, which is the C file to test
76 shift $(( $# - 1 ))
77 OPTIONS="$COCCIINCLUDE $1"
Masahiro Yamadad7059ca2017-11-14 20:38:07 +090078
79 # No need to parallelize Coccinelle since this mode takes one input file.
80 NPROC=1
Nicolas Palix1e9dea22010-06-13 09:26:34 +020081else
82 ONLINE=0
Greg Dietsched0bc1fb2011-11-05 20:59:43 -050083 if [ "$KBUILD_EXTMOD" = "" ] ; then
Nicolas Palix93f14462013-06-20 13:10:56 +020084 OPTIONS="--dir $srctree $COCCIINCLUDE"
Greg Dietsched0bc1fb2011-11-05 20:59:43 -050085 else
Nicolas Palix93f14462013-06-20 13:10:56 +020086 OPTIONS="--dir $KBUILD_EXTMOD $COCCIINCLUDE"
Greg Dietsched0bc1fb2011-11-05 20:59:43 -050087 fi
Masahiro Yamadad7059ca2017-11-14 20:38:07 +090088
Sumera Priyadarsinie16a7c42020-09-24 16:56:08 +053089 # Use only one thread per core by default if hyperthreading is enabled
Sumera Priyadarsini2f324dd2020-10-11 15:58:43 +053090 THREADS_PER_CORE=$(lscpu | grep "Thread(s) per core: " | tr -cd "[:digit:]")
Masahiro Yamadad7059ca2017-11-14 20:38:07 +090091 if [ -z "$J" ]; then
92 NPROC=$(getconf _NPROCESSORS_ONLN)
Sumera Priyadarsinic5864562020-10-11 15:59:42 +053093 if [ $THREADS_PER_CORE -gt 1 -a $NPROC -gt 4 ] ; then
Sumera Priyadarsinie16a7c42020-09-24 16:56:08 +053094 NPROC=$((NPROC/2))
95 fi
Masahiro Yamadad7059ca2017-11-14 20:38:07 +090096 else
97 NPROC="$J"
98 fi
Nicolas Palix1e9dea22010-06-13 09:26:34 +020099fi
100
Nicolas Palixbad6a402013-03-02 22:36:28 +0100101if [ "$KBUILD_EXTMOD" != "" ] ; then
Nicolas Palix93f14462013-06-20 13:10:56 +0200102 OPTIONS="--patch $srctree $OPTIONS"
Nicolas Palixbad6a402013-03-02 22:36:28 +0100103fi
104
Luis R. Rodriguezc930a1b2016-06-29 15:14:53 -0700105# You can override by using SPFLAGS
106if [ "$USE_JOBS" = "no" ]; then
107 trap kill_running SIGTERM SIGINT
108 declare -a SPATCH_PID
109elif [ "$NPROC" != "1" ]; then
110 # Using 0 should work as well, refer to _SC_NPROCESSORS_ONLN use on
111 # https://github.com/rdicosmo/parmap/blob/master/setcore_stubs.c
112 OPTIONS="$OPTIONS --jobs $NPROC --chunksize 1"
113fi
114
Nicolas Palix74425ee2010-06-06 17:15:01 +0200115if [ "$MODE" = "" ] ; then
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200116 if [ "$ONLINE" = "0" ] ; then
Nicolas Palix1f0a6742013-06-06 23:39:52 +0200117 echo 'You have not explicitly specified the mode to use. Using default "report" mode.'
Sumera Priyadarsini4b2bd202020-08-05 14:27:40 +0530118 echo 'Available modes are the following: patch, report, context, org, chain'
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200119 echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
Nicolas Palix1f0a6742013-06-06 23:39:52 +0200120 echo 'Note however that some modes are not implemented by some semantic patches.'
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200121 fi
Nicolas Palix1f0a6742013-06-06 23:39:52 +0200122 MODE="report"
123fi
124
125if [ "$MODE" = "chain" ] ; then
126 if [ "$ONLINE" = "0" ] ; then
127 echo 'You have selected the "chain" mode.'
128 echo 'All available modes will be tried (in that order): patch, report, context, org'
129 fi
Nicolas Palix03ee0c42010-10-08 21:27:41 +0200130elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
Deepa Dinamani7a2358b2016-06-12 12:04:39 -0700131 FLAGS="--no-show-diff $FLAGS"
Nicolas Palix74425ee2010-06-06 17:15:01 +0200132fi
133
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200134if [ "$ONLINE" = "0" ] ; then
135 echo ''
136 echo 'Please check for false positives in the output before submitting a patch.'
137 echo 'When using "patch" mode, carefully review the patch before submitting it.'
138 echo ''
139fi
Nicolas Palix74425ee2010-06-06 17:15:01 +0200140
Luis R. Rodriguezc930a1b2016-06-29 15:14:53 -0700141run_cmd_parmap() {
142 if [ $VERBOSE -ne 0 ] ; then
143 echo "Running ($NPROC in parallel): $@"
144 fi
Sumera Priyadarsinia19d1352020-09-13 17:35:48 +0530145 if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
146 echo $@>>$DEBUG_FILE
147 $@ 2>>$DEBUG_FILE
148 else
149 echo $@
150 $@ 2>&1
151 fi
152
Denis Efremov512ddf72018-08-10 23:25:55 +0300153 err=$?
154 if [[ $err -ne 0 ]]; then
Luis R. Rodriguezc930a1b2016-06-29 15:14:53 -0700155 echo "coccicheck failed"
Denis Efremov512ddf72018-08-10 23:25:55 +0300156 exit $err
Luis R. Rodriguezc930a1b2016-06-29 15:14:53 -0700157 fi
158}
159
160run_cmd_old() {
Kees Cook90d06a42013-06-18 14:49:29 -0700161 local i
Bernd Schubert53032652013-01-29 17:03:42 +0100162 if [ $VERBOSE -ne 0 ] ; then
Kees Cook90d06a42013-06-18 14:49:29 -0700163 echo "Running ($NPROC in parallel): $@"
Bernd Schubert53032652013-01-29 17:03:42 +0100164 fi
Kees Cook90d06a42013-06-18 14:49:29 -0700165 for i in $(seq 0 $(( NPROC - 1)) ); do
Nicolas Palix93f14462013-06-20 13:10:56 +0200166 eval "$@ --max $NPROC --index $i &"
Kees Cook90d06a42013-06-18 14:49:29 -0700167 SPATCH_PID[$i]=$!
168 if [ $VERBOSE -eq 2 ] ; then
169 echo "${SPATCH_PID[$i]} running"
170 fi
171 done
172 wait
Bernd Schubert53032652013-01-29 17:03:42 +0100173}
174
Luis R. Rodriguezc930a1b2016-06-29 15:14:53 -0700175run_cmd() {
176 if [ "$USE_JOBS" = "yes" ]; then
177 run_cmd_parmap $@
178 else
179 run_cmd_old $@
180 fi
181}
182
Kees Cook90d06a42013-06-18 14:49:29 -0700183kill_running() {
Kees Cook2552a392016-05-16 05:55:58 -0700184 for i in $(seq 0 $(( NPROC - 1 )) ); do
Kees Cook90d06a42013-06-18 14:49:29 -0700185 if [ $VERBOSE -eq 2 ] ; then
186 echo "Killing ${SPATCH_PID[$i]}"
187 fi
188 kill ${SPATCH_PID[$i]} 2>/dev/null
189 done
190}
Bernd Schubert53032652013-01-29 17:03:42 +0100191
Luis R. Rodriguez8e826ad2016-06-29 15:14:52 -0700192# You can override heuristics with SPFLAGS, these must always go last
193OPTIONS="$OPTIONS $SPFLAGS"
194
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200195coccinelle () {
Nicolas Palix74425ee2010-06-06 17:15:01 +0200196 COCCI="$1"
Nicolas Palix74425ee2010-06-06 17:15:01 +0200197
Masahiro Yamadae0be3482017-10-26 13:50:38 +0900198 OPT=`grep "Options:" $COCCI | cut -d':' -f2`
199 REQ=`grep "Requires:" $COCCI | cut -d':' -f2 | sed "s| ||"`
Masahiro Yamada33114c42020-12-13 01:54:29 +0900200 if [ -n "$REQ" ] && ! { echo "$REQ"; echo "$SPATCH_VERSION"; } | sort -CV ; then
201 echo "Skipping coccinelle SmPL patch: $COCCI"
202 echo "You have coccinelle: $SPATCH_VERSION"
203 echo "This SmPL patch requires: $REQ"
204 return
Luis R. Rodrigueza9e064c2016-06-29 15:14:57 -0700205 fi
Nicolas Palix74425ee2010-06-06 17:15:01 +0200206
Nicolas Palix93f14462013-06-20 13:10:56 +0200207# The option '--parse-cocci' can be used to syntactically check the SmPL files.
Nicolas Palix74425ee2010-06-06 17:15:01 +0200208#
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200209# $SPATCH -D $MODE $FLAGS -parse_cocci $COCCI $OPT > /dev/null
Nicolas Palix74425ee2010-06-06 17:15:01 +0200210
Nicolas Palix35d88a32013-03-02 22:36:25 +0100211 if [ $VERBOSE -ne 0 -a $ONLINE -eq 0 ] ; then
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200212
Masahiro Yamadacd1af7c2017-10-26 13:55:51 +0900213 FILE=${COCCI#$srctree/}
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200214
Nicolas Palix3c908412010-10-08 21:27:38 +0200215 echo "Processing `basename $COCCI`"
216 echo "with option(s) \"$OPT\""
217 echo ''
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200218 echo 'Message example to submit a patch:'
219
Nicolas Palix3c908412010-10-08 21:27:38 +0200220 sed -ne 's|^///||p' $COCCI
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200221
Nicolas Palix062c1822010-10-24 23:37:34 +0200222 if [ "$MODE" = "patch" ] ; then
223 echo ' The semantic patch that makes this change is available'
224 elif [ "$MODE" = "report" ] ; then
225 echo ' The semantic patch that makes this report is available'
226 elif [ "$MODE" = "context" ] ; then
227 echo ' The semantic patch that spots this code is available'
228 elif [ "$MODE" = "org" ] ; then
229 echo ' The semantic patch that makes this Org report is available'
230 else
231 echo ' The semantic patch that makes this output is available'
232 fi
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200233 echo " in $FILE."
234 echo ''
235 echo ' More information about semantic patching is available at'
236 echo ' http://coccinelle.lip6.fr/'
237 echo ''
238
Nicolas Palix3c908412010-10-08 21:27:38 +0200239 if [ "`sed -ne 's|^//#||p' $COCCI`" ] ; then
240 echo 'Semantic patch information:'
241 sed -ne 's|^//#||p' $COCCI
242 echo ''
243 fi
Nicolas Palix2c1160c82010-10-08 21:27:40 +0200244 fi
Nicolas Palix3c908412010-10-08 21:27:38 +0200245
Nicolas Palix2c1160c82010-10-08 21:27:40 +0200246 if [ "$MODE" = "chain" ] ; then
Bernd Schubert53032652013-01-29 17:03:42 +0100247 run_cmd $SPATCH -D patch \
Nicolas Palix93f14462013-06-20 13:10:56 +0200248 $FLAGS --cocci-file $COCCI $OPT $OPTIONS || \
Bernd Schubert53032652013-01-29 17:03:42 +0100249 run_cmd $SPATCH -D report \
Nicolas Palix93f14462013-06-20 13:10:56 +0200250 $FLAGS --cocci-file $COCCI $OPT $OPTIONS --no-show-diff || \
Bernd Schubert53032652013-01-29 17:03:42 +0100251 run_cmd $SPATCH -D context \
Nicolas Palix93f14462013-06-20 13:10:56 +0200252 $FLAGS --cocci-file $COCCI $OPT $OPTIONS || \
Bernd Schubert53032652013-01-29 17:03:42 +0100253 run_cmd $SPATCH -D org \
Nicolas Palix93f14462013-06-20 13:10:56 +0200254 $FLAGS --cocci-file $COCCI $OPT $OPTIONS --no-show-diff || exit 1
Nicolas Palixc05cd6d2012-09-20 22:30:46 +0200255 elif [ "$MODE" = "rep+ctxt" ] ; then
Bernd Schubert53032652013-01-29 17:03:42 +0100256 run_cmd $SPATCH -D report \
Nicolas Palix93f14462013-06-20 13:10:56 +0200257 $FLAGS --cocci-file $COCCI $OPT $OPTIONS --no-show-diff && \
Bernd Schubert53032652013-01-29 17:03:42 +0100258 run_cmd $SPATCH -D context \
Nicolas Palix93f14462013-06-20 13:10:56 +0200259 $FLAGS --cocci-file $COCCI $OPT $OPTIONS || exit 1
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200260 else
Nicolas Palix93f14462013-06-20 13:10:56 +0200261 run_cmd $SPATCH -D $MODE $FLAGS --cocci-file $COCCI $OPT $OPTIONS || exit 1
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200262 fi
263
Nicolas Palix74425ee2010-06-06 17:15:01 +0200264}
265
Julia Lawall9ed07ad2017-10-15 11:55:53 +0200266if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
267 if [ -f $DEBUG_FILE ]; then
268 echo "Debug file $DEBUG_FILE exists, bailing"
269 exit
270 fi
271else
272 DEBUG_FILE="/dev/null"
273fi
274
Nicolas Palix74425ee2010-06-06 17:15:01 +0200275if [ "$COCCI" = "" ] ; then
276 for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200277 coccinelle $f
Nicolas Palix74425ee2010-06-06 17:15:01 +0200278 done
279else
Nicolas Palix1e9dea22010-06-13 09:26:34 +0200280 coccinelle $COCCI
Nicolas Palix74425ee2010-06-06 17:15:01 +0200281fi