Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1 | #!/usr/bin/perl -w |
Dave Jones | f4432c5 | 2008-10-20 13:31:45 -0400 | [diff] [blame] | 2 | # (c) 2001, Dave Jones. <davej@redhat.com> (the file handling bit) |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 3 | # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit) |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 4 | # (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc) |
| 5 | # Licensed under the terms of the GNU GPL License version 2 |
| 6 | |
| 7 | use strict; |
| 8 | |
| 9 | my $P = $0; |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 10 | $P =~ s@.*/@@g; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 11 | |
Andy Whitcroft | 6e144ee | 2008-10-15 22:02:36 -0700 | [diff] [blame] | 12 | my $V = '0.24'; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 13 | |
| 14 | use Getopt::Long qw(:config no_auto_abbrev); |
| 15 | |
| 16 | my $quiet = 0; |
| 17 | my $tree = 1; |
| 18 | my $chk_signoff = 1; |
| 19 | my $chk_patch = 1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 20 | my $tst_only; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 21 | my $emacs = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 22 | my $terse = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 23 | my $file = 0; |
| 24 | my $check = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 25 | my $summary = 1; |
| 26 | my $mailback = 0; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 27 | my $summary_file = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 28 | my $root; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 29 | my %debug; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 30 | GetOptions( |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 31 | 'q|quiet+' => \$quiet, |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 32 | 'tree!' => \$tree, |
| 33 | 'signoff!' => \$chk_signoff, |
| 34 | 'patch!' => \$chk_patch, |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 35 | 'emacs!' => \$emacs, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 36 | 'terse!' => \$terse, |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 37 | 'file!' => \$file, |
| 38 | 'subjective!' => \$check, |
| 39 | 'strict!' => \$check, |
| 40 | 'root=s' => \$root, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 41 | 'summary!' => \$summary, |
| 42 | 'mailback!' => \$mailback, |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 43 | 'summary-file!' => \$summary_file, |
| 44 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 45 | 'debug=s' => \%debug, |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 46 | 'test-only=s' => \$tst_only, |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 47 | ) or exit; |
| 48 | |
| 49 | my $exit = 0; |
| 50 | |
| 51 | if ($#ARGV < 0) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 52 | print "usage: $P [options] patchfile\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 53 | print "version: $V\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 54 | print "options: -q => quiet\n"; |
| 55 | print " --no-tree => run without a kernel tree\n"; |
| 56 | print " --terse => one line per report\n"; |
| 57 | print " --emacs => emacs compile window format\n"; |
| 58 | print " --file => check a source file\n"; |
| 59 | print " --strict => enable more subjective tests\n"; |
| 60 | print " --root => path to the kernel tree root\n"; |
| 61 | print " --no-summary => suppress the per-file summary\n"; |
| 62 | print " --summary-file => include the filename in summary\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 63 | exit(1); |
| 64 | } |
| 65 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 66 | my $dbg_values = 0; |
| 67 | my $dbg_possible = 0; |
Andy Whitcroft | 7429c69 | 2008-07-23 21:29:06 -0700 | [diff] [blame] | 68 | my $dbg_type = 0; |
Andy Whitcroft | a1ef277 | 2008-10-15 22:02:17 -0700 | [diff] [blame] | 69 | my $dbg_attr = 0; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 70 | for my $key (keys %debug) { |
| 71 | eval "\${dbg_$key} = '$debug{$key}';" |
| 72 | } |
| 73 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 74 | if ($terse) { |
| 75 | $emacs = 1; |
| 76 | $quiet++; |
| 77 | } |
| 78 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 79 | if ($tree) { |
| 80 | if (defined $root) { |
| 81 | if (!top_of_kernel_tree($root)) { |
| 82 | die "$P: $root: --root does not point at a valid tree\n"; |
| 83 | } |
| 84 | } else { |
| 85 | if (top_of_kernel_tree('.')) { |
| 86 | $root = '.'; |
| 87 | } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ && |
| 88 | top_of_kernel_tree($1)) { |
| 89 | $root = $1; |
| 90 | } |
| 91 | } |
| 92 | |
| 93 | if (!defined $root) { |
| 94 | print "Must be run from the top-level dir. of a kernel tree\n"; |
| 95 | exit(2); |
| 96 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 97 | } |
| 98 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 99 | my $emitted_corrupt = 0; |
| 100 | |
| 101 | our $Ident = qr{[A-Za-z_][A-Za-z\d_]*}; |
| 102 | our $Storage = qr{extern|static|asmlinkage}; |
| 103 | our $Sparse = qr{ |
| 104 | __user| |
| 105 | __kernel| |
| 106 | __force| |
| 107 | __iomem| |
| 108 | __must_check| |
| 109 | __init_refok| |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 110 | __kprobes |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 111 | }x; |
| 112 | our $Attribute = qr{ |
| 113 | const| |
| 114 | __read_mostly| |
| 115 | __kprobes| |
Andy Whitcroft | 24e1d81 | 2008-10-15 22:02:18 -0700 | [diff] [blame] | 116 | __(?:mem|cpu|dev|)(?:initdata|init)| |
| 117 | ____cacheline_aligned| |
| 118 | ____cacheline_aligned_in_smp| |
| 119 | ____cacheline_internodealigned_in_smp |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 120 | }x; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 121 | our $Modifier; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 122 | our $Inline = qr{inline|__always_inline|noinline}; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 123 | our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]}; |
| 124 | our $Lval = qr{$Ident(?:$Member)*}; |
| 125 | |
| 126 | our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*}; |
| 127 | our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)}; |
| 128 | our $Operators = qr{ |
| 129 | <=|>=|==|!=| |
| 130 | =>|->|<<|>>|<|>|!|~| |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 131 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|% |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 132 | }x; |
| 133 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 134 | our $NonptrType; |
| 135 | our $Type; |
| 136 | our $Declare; |
| 137 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 138 | our $UTF8 = qr { |
| 139 | [\x09\x0A\x0D\x20-\x7E] # ASCII |
| 140 | | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte |
| 141 | | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs |
| 142 | | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte |
| 143 | | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates |
| 144 | | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3 |
| 145 | | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 |
| 146 | | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 |
| 147 | }x; |
| 148 | |
Andy Whitcroft | 8ed22ca | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 149 | our $typeTypedefs = qr{(?x: |
| 150 | (?:__)?(?:u|s|be|le)(?:\d|\d\d)| |
| 151 | atomic_t |
| 152 | )}; |
| 153 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 154 | our @typeList = ( |
| 155 | qr{void}, |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 156 | qr{(?:unsigned\s+)?char}, |
| 157 | qr{(?:unsigned\s+)?short}, |
| 158 | qr{(?:unsigned\s+)?int}, |
| 159 | qr{(?:unsigned\s+)?long}, |
| 160 | qr{(?:unsigned\s+)?long\s+int}, |
| 161 | qr{(?:unsigned\s+)?long\s+long}, |
| 162 | qr{(?:unsigned\s+)?long\s+long\s+int}, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 163 | qr{unsigned}, |
| 164 | qr{float}, |
| 165 | qr{double}, |
| 166 | qr{bool}, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 167 | qr{struct\s+$Ident}, |
| 168 | qr{union\s+$Ident}, |
| 169 | qr{enum\s+$Ident}, |
| 170 | qr{${Ident}_t}, |
| 171 | qr{${Ident}_handler}, |
| 172 | qr{${Ident}_handler_fn}, |
| 173 | ); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 174 | our @modifierList = ( |
| 175 | qr{fastcall}, |
| 176 | ); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 177 | |
| 178 | sub build_types { |
Andy Whitcroft | d2172eb | 2008-07-23 21:29:07 -0700 | [diff] [blame] | 179 | my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)"; |
| 180 | my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)"; |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 181 | $Modifier = qr{(?:$Attribute|$Sparse|$mods)}; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 182 | $NonptrType = qr{ |
Andy Whitcroft | d2172eb | 2008-07-23 21:29:07 -0700 | [diff] [blame] | 183 | (?:$Modifier\s+|const\s+)* |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 184 | (?: |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 185 | (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| |
Andy Whitcroft | 8ed22ca | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 186 | (?:$typeTypedefs\b)| |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 187 | (?:${all}\b) |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 188 | ) |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 189 | (?:\s+$Modifier|\s+const)* |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 190 | }x; |
| 191 | $Type = qr{ |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 192 | $NonptrType |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 193 | (?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)? |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 194 | (?:\s+$Inline|\s+$Modifier)* |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 195 | }x; |
| 196 | $Declare = qr{(?:$Storage\s+)?$Type}; |
| 197 | } |
| 198 | build_types(); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 199 | |
| 200 | $chk_signoff = 0 if ($file); |
| 201 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 202 | my @dep_includes = (); |
| 203 | my @dep_functions = (); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 204 | my $removal = "Documentation/feature-removal-schedule.txt"; |
| 205 | if ($tree && -f "$root/$removal") { |
| 206 | open(REMOVE, "<$root/$removal") || |
| 207 | die "$P: $removal: open failed - $!\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 208 | while (<REMOVE>) { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 209 | if (/^Check:\s+(.*\S)/) { |
| 210 | for my $entry (split(/[, ]+/, $1)) { |
| 211 | if ($entry =~ m@include/(.*)@) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 212 | push(@dep_includes, $1); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 213 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 214 | } elsif ($entry !~ m@/@) { |
| 215 | push(@dep_functions, $entry); |
| 216 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 217 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 218 | } |
| 219 | } |
| 220 | } |
| 221 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 222 | my @rawlines = (); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 223 | my @lines = (); |
| 224 | my $vname; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 225 | for my $filename (@ARGV) { |
| 226 | if ($file) { |
| 227 | open(FILE, "diff -u /dev/null $filename|") || |
| 228 | die "$P: $filename: diff failed - $!\n"; |
| 229 | } else { |
| 230 | open(FILE, "<$filename") || |
| 231 | die "$P: $filename: open failed - $!\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 232 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 233 | if ($filename eq '-') { |
| 234 | $vname = 'Your patch'; |
| 235 | } else { |
| 236 | $vname = $filename; |
| 237 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 238 | while (<FILE>) { |
| 239 | chomp; |
| 240 | push(@rawlines, $_); |
| 241 | } |
| 242 | close(FILE); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 243 | if (!process($filename)) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 244 | $exit = 1; |
| 245 | } |
| 246 | @rawlines = (); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 247 | @lines = (); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 248 | } |
| 249 | |
| 250 | exit($exit); |
| 251 | |
| 252 | sub top_of_kernel_tree { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 253 | my ($root) = @_; |
| 254 | |
| 255 | my @tree_check = ( |
| 256 | "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile", |
| 257 | "README", "Documentation", "arch", "include", "drivers", |
| 258 | "fs", "init", "ipc", "kernel", "lib", "scripts", |
| 259 | ); |
| 260 | |
| 261 | foreach my $check (@tree_check) { |
| 262 | if (! -e $root . '/' . $check) { |
| 263 | return 0; |
| 264 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 265 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 266 | return 1; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 267 | } |
| 268 | |
| 269 | sub expand_tabs { |
| 270 | my ($str) = @_; |
| 271 | |
| 272 | my $res = ''; |
| 273 | my $n = 0; |
| 274 | for my $c (split(//, $str)) { |
| 275 | if ($c eq "\t") { |
| 276 | $res .= ' '; |
| 277 | $n++; |
| 278 | for (; ($n % 8) != 0; $n++) { |
| 279 | $res .= ' '; |
| 280 | } |
| 281 | next; |
| 282 | } |
| 283 | $res .= $c; |
| 284 | $n++; |
| 285 | } |
| 286 | |
| 287 | return $res; |
| 288 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 289 | sub copy_spacing { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 290 | (my $res = shift) =~ tr/\t/ /c; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 291 | return $res; |
| 292 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 293 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 294 | sub line_stats { |
| 295 | my ($line) = @_; |
| 296 | |
| 297 | # Drop the diff line leader and expand tabs |
| 298 | $line =~ s/^.//; |
| 299 | $line = expand_tabs($line); |
| 300 | |
| 301 | # Pick the indent from the front of the line. |
| 302 | my ($white) = ($line =~ /^(\s*)/); |
| 303 | |
| 304 | return (length($line), length($white)); |
| 305 | } |
| 306 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 307 | my $sanitise_quote = ''; |
| 308 | |
| 309 | sub sanitise_line_reset { |
| 310 | my ($in_comment) = @_; |
| 311 | |
| 312 | if ($in_comment) { |
| 313 | $sanitise_quote = '*/'; |
| 314 | } else { |
| 315 | $sanitise_quote = ''; |
| 316 | } |
| 317 | } |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 318 | sub sanitise_line { |
| 319 | my ($line) = @_; |
| 320 | |
| 321 | my $res = ''; |
| 322 | my $l = ''; |
| 323 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 324 | my $qlen = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 325 | my $off = 0; |
| 326 | my $c; |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 327 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 328 | # Always copy over the diff marker. |
| 329 | $res = substr($line, 0, 1); |
| 330 | |
| 331 | for ($off = 1; $off < length($line); $off++) { |
| 332 | $c = substr($line, $off, 1); |
| 333 | |
| 334 | # Comments we are wacking completly including the begin |
| 335 | # and end, all to $;. |
| 336 | if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') { |
| 337 | $sanitise_quote = '*/'; |
| 338 | |
| 339 | substr($res, $off, 2, "$;$;"); |
| 340 | $off++; |
| 341 | next; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 342 | } |
Andy Whitcroft | 81bc0e0 | 2008-10-15 22:02:26 -0700 | [diff] [blame] | 343 | if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 344 | $sanitise_quote = ''; |
| 345 | substr($res, $off, 2, "$;$;"); |
| 346 | $off++; |
| 347 | next; |
| 348 | } |
| 349 | |
| 350 | # A \ in a string means ignore the next character. |
| 351 | if (($sanitise_quote eq "'" || $sanitise_quote eq '"') && |
| 352 | $c eq "\\") { |
| 353 | substr($res, $off, 2, 'XX'); |
| 354 | $off++; |
| 355 | next; |
| 356 | } |
| 357 | # Regular quotes. |
| 358 | if ($c eq "'" || $c eq '"') { |
| 359 | if ($sanitise_quote eq '') { |
| 360 | $sanitise_quote = $c; |
| 361 | |
| 362 | substr($res, $off, 1, $c); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 363 | next; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 364 | } elsif ($sanitise_quote eq $c) { |
| 365 | $sanitise_quote = ''; |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 366 | } |
| 367 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 368 | |
| 369 | #print "SQ:$sanitise_quote\n"; |
| 370 | if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") { |
| 371 | substr($res, $off, 1, $;); |
| 372 | } elsif ($off != 0 && $sanitise_quote && $c ne "\t") { |
| 373 | substr($res, $off, 1, 'X'); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 374 | } else { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 375 | substr($res, $off, 1, $c); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 376 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 377 | } |
| 378 | |
| 379 | # The pathname on a #include may be surrounded by '<' and '>'. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 380 | if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 381 | my $clean = 'X' x length($1); |
| 382 | $res =~ s@\<.*\>@<$clean>@; |
| 383 | |
| 384 | # The whole of a #error is a string. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 385 | } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 386 | my $clean = 'X' x length($1); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 387 | $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 388 | } |
| 389 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 390 | return $res; |
| 391 | } |
| 392 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 393 | sub ctx_statement_block { |
| 394 | my ($linenr, $remain, $off) = @_; |
| 395 | my $line = $linenr - 1; |
| 396 | my $blk = ''; |
| 397 | my $soff = $off; |
| 398 | my $coff = $off - 1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 399 | my $coff_set = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 400 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 401 | my $loff = 0; |
| 402 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 403 | my $type = ''; |
| 404 | my $level = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 405 | my $p; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 406 | my $c; |
| 407 | my $len = 0; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 408 | |
| 409 | my $remainder; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 410 | while (1) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 411 | #warn "CSB: blk<$blk> remain<$remain>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 412 | # If we are about to drop off the end, pull in more |
| 413 | # context. |
| 414 | if ($off >= $len) { |
| 415 | for (; $remain > 0; $line++) { |
Andy Whitcroft | dea3349 | 2008-10-15 22:02:25 -0700 | [diff] [blame] | 416 | last if (!defined $lines[$line]); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 417 | next if ($lines[$line] =~ /^-/); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 418 | $remain--; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 419 | $loff = $len; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 420 | $blk .= $lines[$line] . "\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 421 | $len = length($blk); |
| 422 | $line++; |
| 423 | last; |
| 424 | } |
| 425 | # Bail if there is no further context. |
| 426 | #warn "CSB: blk<$blk> off<$off> len<$len>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 427 | if ($off >= $len) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 428 | last; |
| 429 | } |
| 430 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 431 | $p = $c; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 432 | $c = substr($blk, $off, 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 433 | $remainder = substr($blk, $off); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 434 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 435 | #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 436 | # Statement ends at the ';' or a close '}' at the |
| 437 | # outermost level. |
| 438 | if ($level == 0 && $c eq ';') { |
| 439 | last; |
| 440 | } |
| 441 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 442 | # An else is really a conditional as long as its not else if |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 443 | if ($level == 0 && $coff_set == 0 && |
| 444 | (!defined($p) || $p =~ /(?:\s|\}|\+)/) && |
| 445 | $remainder =~ /^(else)(?:\s|{)/ && |
| 446 | $remainder !~ /^else\s+if\b/) { |
| 447 | $coff = $off + length($1) - 1; |
| 448 | $coff_set = 1; |
| 449 | #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n"; |
| 450 | #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 451 | } |
| 452 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 453 | if (($type eq '' || $type eq '(') && $c eq '(') { |
| 454 | $level++; |
| 455 | $type = '('; |
| 456 | } |
| 457 | if ($type eq '(' && $c eq ')') { |
| 458 | $level--; |
| 459 | $type = ($level != 0)? '(' : ''; |
| 460 | |
| 461 | if ($level == 0 && $coff < $soff) { |
| 462 | $coff = $off; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 463 | $coff_set = 1; |
| 464 | #warn "CSB: mark coff<$coff>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 465 | } |
| 466 | } |
| 467 | if (($type eq '' || $type eq '{') && $c eq '{') { |
| 468 | $level++; |
| 469 | $type = '{'; |
| 470 | } |
| 471 | if ($type eq '{' && $c eq '}') { |
| 472 | $level--; |
| 473 | $type = ($level != 0)? '{' : ''; |
| 474 | |
| 475 | if ($level == 0) { |
| 476 | last; |
| 477 | } |
| 478 | } |
| 479 | $off++; |
| 480 | } |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 481 | # We are truly at the end, so shuffle to the next line. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 482 | if ($off == $len) { |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 483 | $loff = $len + 1; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 484 | $line++; |
| 485 | $remain--; |
| 486 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 487 | |
| 488 | my $statement = substr($blk, $soff, $off - $soff + 1); |
| 489 | my $condition = substr($blk, $soff, $coff - $soff + 1); |
| 490 | |
| 491 | #warn "STATEMENT<$statement>\n"; |
| 492 | #warn "CONDITION<$condition>\n"; |
| 493 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 494 | #print "coff<$coff> soff<$off> loff<$loff>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 495 | |
| 496 | return ($statement, $condition, |
| 497 | $line, $remain + 1, $off - $loff + 1, $level); |
| 498 | } |
| 499 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 500 | sub statement_lines { |
| 501 | my ($stmt) = @_; |
| 502 | |
| 503 | # Strip the diff line prefixes and rip blank lines at start and end. |
| 504 | $stmt =~ s/(^|\n)./$1/g; |
| 505 | $stmt =~ s/^\s*//; |
| 506 | $stmt =~ s/\s*$//; |
| 507 | |
| 508 | my @stmt_lines = ($stmt =~ /\n/g); |
| 509 | |
| 510 | return $#stmt_lines + 2; |
| 511 | } |
| 512 | |
| 513 | sub statement_rawlines { |
| 514 | my ($stmt) = @_; |
| 515 | |
| 516 | my @stmt_lines = ($stmt =~ /\n/g); |
| 517 | |
| 518 | return $#stmt_lines + 2; |
| 519 | } |
| 520 | |
| 521 | sub statement_block_size { |
| 522 | my ($stmt) = @_; |
| 523 | |
| 524 | $stmt =~ s/(^|\n)./$1/g; |
| 525 | $stmt =~ s/^\s*{//; |
| 526 | $stmt =~ s/}\s*$//; |
| 527 | $stmt =~ s/^\s*//; |
| 528 | $stmt =~ s/\s*$//; |
| 529 | |
| 530 | my @stmt_lines = ($stmt =~ /\n/g); |
| 531 | my @stmt_statements = ($stmt =~ /;/g); |
| 532 | |
| 533 | my $stmt_lines = $#stmt_lines + 2; |
| 534 | my $stmt_statements = $#stmt_statements + 1; |
| 535 | |
| 536 | if ($stmt_lines > $stmt_statements) { |
| 537 | return $stmt_lines; |
| 538 | } else { |
| 539 | return $stmt_statements; |
| 540 | } |
| 541 | } |
| 542 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 543 | sub ctx_statement_full { |
| 544 | my ($linenr, $remain, $off) = @_; |
| 545 | my ($statement, $condition, $level); |
| 546 | |
| 547 | my (@chunks); |
| 548 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 549 | # Grab the first conditional/block pair. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 550 | ($statement, $condition, $linenr, $remain, $off, $level) = |
| 551 | ctx_statement_block($linenr, $remain, $off); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 552 | #print "F: c<$condition> s<$statement> remain<$remain>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 553 | push(@chunks, [ $condition, $statement ]); |
| 554 | if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) { |
| 555 | return ($level, $linenr, @chunks); |
| 556 | } |
| 557 | |
| 558 | # Pull in the following conditional/block pairs and see if they |
| 559 | # could continue the statement. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 560 | for (;;) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 561 | ($statement, $condition, $linenr, $remain, $off, $level) = |
| 562 | ctx_statement_block($linenr, $remain, $off); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 563 | #print "C: c<$condition> s<$statement> remain<$remain>\n"; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 564 | last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s)); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 565 | #print "C: push\n"; |
| 566 | push(@chunks, [ $condition, $statement ]); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 567 | } |
| 568 | |
| 569 | return ($level, $linenr, @chunks); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 570 | } |
| 571 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 572 | sub ctx_block_get { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 573 | my ($linenr, $remain, $outer, $open, $close, $off) = @_; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 574 | my $line; |
| 575 | my $start = $linenr - 1; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 576 | my $blk = ''; |
| 577 | my @o; |
| 578 | my @c; |
| 579 | my @res = (); |
| 580 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 581 | my $level = 0; |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 582 | for ($line = $start; $remain > 0; $line++) { |
| 583 | next if ($rawlines[$line] =~ /^-/); |
| 584 | $remain--; |
| 585 | |
| 586 | $blk .= $rawlines[$line]; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 587 | foreach my $c (split(//, $rawlines[$line])) { |
| 588 | ##print "C<$c>L<$level><$open$close>O<$off>\n"; |
| 589 | if ($off > 0) { |
| 590 | $off--; |
| 591 | next; |
| 592 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 593 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 594 | if ($c eq $close && $level > 0) { |
| 595 | $level--; |
| 596 | last if ($level == 0); |
| 597 | } elsif ($c eq $open) { |
| 598 | $level++; |
| 599 | } |
| 600 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 601 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 602 | if (!$outer || $level <= 1) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 603 | push(@res, $rawlines[$line]); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 604 | } |
| 605 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 606 | last if ($level == 0); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 607 | } |
| 608 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 609 | return ($level, @res); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 610 | } |
| 611 | sub ctx_block_outer { |
| 612 | my ($linenr, $remain) = @_; |
| 613 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 614 | my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0); |
| 615 | return @r; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 616 | } |
| 617 | sub ctx_block { |
| 618 | my ($linenr, $remain) = @_; |
| 619 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 620 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
| 621 | return @r; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 622 | } |
| 623 | sub ctx_statement { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 624 | my ($linenr, $remain, $off) = @_; |
| 625 | |
| 626 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off); |
| 627 | return @r; |
| 628 | } |
| 629 | sub ctx_block_level { |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 630 | my ($linenr, $remain) = @_; |
| 631 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 632 | return ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 633 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 634 | sub ctx_statement_level { |
| 635 | my ($linenr, $remain, $off) = @_; |
| 636 | |
| 637 | return ctx_block_get($linenr, $remain, 0, '(', ')', $off); |
| 638 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 639 | |
| 640 | sub ctx_locate_comment { |
| 641 | my ($first_line, $end_line) = @_; |
| 642 | |
| 643 | # Catch a comment on the end of the line itself. |
Andy Whitcroft | beae633 | 2008-07-23 21:28:59 -0700 | [diff] [blame] | 644 | my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 645 | return $current_comment if (defined $current_comment); |
| 646 | |
| 647 | # Look through the context and try and figure out if there is a |
| 648 | # comment. |
| 649 | my $in_comment = 0; |
| 650 | $current_comment = ''; |
| 651 | for (my $linenr = $first_line; $linenr < $end_line; $linenr++) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 652 | my $line = $rawlines[$linenr - 1]; |
| 653 | #warn " $line\n"; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 654 | if ($linenr == $first_line and $line =~ m@^.\s*\*@) { |
| 655 | $in_comment = 1; |
| 656 | } |
| 657 | if ($line =~ m@/\*@) { |
| 658 | $in_comment = 1; |
| 659 | } |
| 660 | if (!$in_comment && $current_comment ne '') { |
| 661 | $current_comment = ''; |
| 662 | } |
| 663 | $current_comment .= $line . "\n" if ($in_comment); |
| 664 | if ($line =~ m@\*/@) { |
| 665 | $in_comment = 0; |
| 666 | } |
| 667 | } |
| 668 | |
| 669 | chomp($current_comment); |
| 670 | return($current_comment); |
| 671 | } |
| 672 | sub ctx_has_comment { |
| 673 | my ($first_line, $end_line) = @_; |
| 674 | my $cmt = ctx_locate_comment($first_line, $end_line); |
| 675 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 676 | ##print "LINE: $rawlines[$end_line - 1 ]\n"; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 677 | ##print "CMMT: $cmt\n"; |
| 678 | |
| 679 | return ($cmt ne ''); |
| 680 | } |
| 681 | |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 682 | sub raw_line { |
| 683 | my ($linenr, $cnt) = @_; |
| 684 | |
| 685 | my $offset = $linenr - 1; |
| 686 | $cnt++; |
| 687 | |
| 688 | my $line; |
| 689 | while ($cnt) { |
| 690 | $line = $rawlines[$offset++]; |
| 691 | next if (defined($line) && $line =~ /^-/); |
| 692 | $cnt--; |
| 693 | } |
| 694 | |
| 695 | return $line; |
| 696 | } |
| 697 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 698 | sub cat_vet { |
| 699 | my ($vet) = @_; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 700 | my ($res, $coded); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 701 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 702 | $res = ''; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 703 | while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) { |
| 704 | $res .= $1; |
| 705 | if ($2 ne '') { |
| 706 | $coded = sprintf("^%c", unpack('C', $2) + 64); |
| 707 | $res .= $coded; |
| 708 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 709 | } |
| 710 | $res =~ s/$/\$/; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 711 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 712 | return $res; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 713 | } |
| 714 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 715 | my $av_preprocessor = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 716 | my $av_pending; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 717 | my @av_paren_type; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 718 | my $av_pend_colon; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 719 | |
| 720 | sub annotate_reset { |
| 721 | $av_preprocessor = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 722 | $av_pending = '_'; |
| 723 | @av_paren_type = ('E'); |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 724 | $av_pend_colon = 'O'; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 725 | } |
| 726 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 727 | sub annotate_values { |
| 728 | my ($stream, $type) = @_; |
| 729 | |
| 730 | my $res; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 731 | my $var = '_' x length($stream); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 732 | my $cur = $stream; |
| 733 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 734 | print "$stream\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 735 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 736 | while (length($cur)) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 737 | @av_paren_type = ('E') if ($#av_paren_type < 0); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 738 | print " <" . join('', @av_paren_type) . |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 739 | "> <$type> <$av_pending>" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 740 | if ($cur =~ /^(\s+)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 741 | print "WS($1)\n" if ($dbg_values > 1); |
| 742 | if ($1 =~ /\n/ && $av_preprocessor) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 743 | $type = pop(@av_paren_type); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 744 | $av_preprocessor = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 745 | } |
| 746 | |
Andy Whitcroft | 8ea3eb9 | 2008-07-23 21:29:08 -0700 | [diff] [blame] | 747 | } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\()/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 748 | print "DECLARE($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 749 | $type = 'T'; |
| 750 | |
Andy Whitcroft | 389a2fe | 2008-07-23 21:29:05 -0700 | [diff] [blame] | 751 | } elsif ($cur =~ /^($Modifier)\s*/) { |
| 752 | print "MODIFIER($1)\n" if ($dbg_values > 1); |
| 753 | $type = 'T'; |
| 754 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 755 | } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 756 | print "DEFINE($1,$2)\n" if ($dbg_values > 1); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 757 | $av_preprocessor = 1; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 758 | push(@av_paren_type, $type); |
| 759 | if ($2 ne '') { |
| 760 | $av_pending = 'N'; |
| 761 | } |
| 762 | $type = 'E'; |
| 763 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 764 | } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 765 | print "UNDEF($1)\n" if ($dbg_values > 1); |
| 766 | $av_preprocessor = 1; |
| 767 | push(@av_paren_type, $type); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 768 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 769 | } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 770 | print "PRE_START($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 771 | $av_preprocessor = 1; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 772 | |
| 773 | push(@av_paren_type, $type); |
| 774 | push(@av_paren_type, $type); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 775 | $type = 'E'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 776 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 777 | } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 778 | print "PRE_RESTART($1)\n" if ($dbg_values > 1); |
| 779 | $av_preprocessor = 1; |
| 780 | |
| 781 | push(@av_paren_type, $av_paren_type[$#av_paren_type]); |
| 782 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 783 | $type = 'E'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 784 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 785 | } elsif ($cur =~ /^(\#\s*(?:endif))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 786 | print "PRE_END($1)\n" if ($dbg_values > 1); |
| 787 | |
| 788 | $av_preprocessor = 1; |
| 789 | |
| 790 | # Assume all arms of the conditional end as this |
| 791 | # one does, and continue as if the #endif was not here. |
| 792 | pop(@av_paren_type); |
| 793 | push(@av_paren_type, $type); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 794 | $type = 'E'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 795 | |
| 796 | } elsif ($cur =~ /^(\\\n)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 797 | print "PRECONT($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 798 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 799 | } elsif ($cur =~ /^(__attribute__)\s*\(?/o) { |
| 800 | print "ATTR($1)\n" if ($dbg_values > 1); |
| 801 | $av_pending = $type; |
| 802 | $type = 'N'; |
| 803 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 804 | } elsif ($cur =~ /^(sizeof)\s*(\()?/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 805 | print "SIZEOF($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 806 | if (defined $2) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 807 | $av_pending = 'V'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 808 | } |
| 809 | $type = 'N'; |
| 810 | |
Andy Whitcroft | 14b111c | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 811 | } elsif ($cur =~ /^(if|while|for)\b/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 812 | print "COND($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 14b111c | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 813 | $av_pending = 'E'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 814 | $type = 'N'; |
| 815 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 816 | } elsif ($cur =~/^(case)/o) { |
| 817 | print "CASE($1)\n" if ($dbg_values > 1); |
| 818 | $av_pend_colon = 'C'; |
| 819 | $type = 'N'; |
| 820 | |
Andy Whitcroft | 14b111c | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 821 | } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 822 | print "KEYWORD($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 823 | $type = 'N'; |
| 824 | |
| 825 | } elsif ($cur =~ /^(\()/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 826 | print "PAREN('$1')\n" if ($dbg_values > 1); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 827 | push(@av_paren_type, $av_pending); |
| 828 | $av_pending = '_'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 829 | $type = 'N'; |
| 830 | |
| 831 | } elsif ($cur =~ /^(\))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 832 | my $new_type = pop(@av_paren_type); |
| 833 | if ($new_type ne '_') { |
| 834 | $type = $new_type; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 835 | print "PAREN('$1') -> $type\n" |
| 836 | if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 837 | } else { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 838 | print "PAREN('$1')\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 839 | } |
| 840 | |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 841 | } elsif ($cur =~ /^($Ident)\s*\(/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 842 | print "FUNC($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 843 | $type = 'V'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 844 | $av_pending = 'V'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 845 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 846 | } elsif ($cur =~ /^($Ident\s*):/) { |
| 847 | if ($type eq 'E') { |
| 848 | $av_pend_colon = 'L'; |
| 849 | } elsif ($type eq 'T') { |
| 850 | $av_pend_colon = 'B'; |
| 851 | } |
| 852 | print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1); |
| 853 | $type = 'V'; |
| 854 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 855 | } elsif ($cur =~ /^($Ident|$Constant)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 856 | print "IDENT($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 857 | $type = 'V'; |
| 858 | |
| 859 | } elsif ($cur =~ /^($Assignment)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 860 | print "ASSIGN($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 861 | $type = 'N'; |
| 862 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 863 | } elsif ($cur =~/^(;|{|})/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 864 | print "END($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 865 | $type = 'E'; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 866 | $av_pend_colon = 'O'; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 867 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 868 | } elsif ($cur =~ /^(\?)/o) { |
| 869 | print "QUESTION($1)\n" if ($dbg_values > 1); |
| 870 | $type = 'N'; |
| 871 | |
| 872 | } elsif ($cur =~ /^(:)/o) { |
| 873 | print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1); |
| 874 | |
| 875 | substr($var, length($res), 1, $av_pend_colon); |
| 876 | if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') { |
| 877 | $type = 'E'; |
| 878 | } else { |
| 879 | $type = 'N'; |
| 880 | } |
| 881 | $av_pend_colon = 'O'; |
| 882 | |
| 883 | } elsif ($cur =~ /^(;|\[)/o) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 884 | print "CLOSE($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 885 | $type = 'N'; |
| 886 | |
Andy Whitcroft | 0d41386 | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 887 | } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) { |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 888 | my $variant; |
| 889 | |
| 890 | print "OPV($1)\n" if ($dbg_values > 1); |
| 891 | if ($type eq 'V') { |
| 892 | $variant = 'B'; |
| 893 | } else { |
| 894 | $variant = 'U'; |
| 895 | } |
| 896 | |
| 897 | substr($var, length($res), 1, $variant); |
| 898 | $type = 'N'; |
| 899 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 900 | } elsif ($cur =~ /^($Operators)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 901 | print "OP($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 902 | if ($1 ne '++' && $1 ne '--') { |
| 903 | $type = 'N'; |
| 904 | } |
| 905 | |
| 906 | } elsif ($cur =~ /(^.)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 907 | print "C($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 908 | } |
| 909 | if (defined $1) { |
| 910 | $cur = substr($cur, length($1)); |
| 911 | $res .= $type x length($1); |
| 912 | } |
| 913 | } |
| 914 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 915 | return ($res, $var); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 916 | } |
| 917 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 918 | sub possible { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 919 | my ($possible, $line) = @_; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 920 | |
Andy Whitcroft | 0776e59 | 2008-10-15 22:02:29 -0700 | [diff] [blame] | 921 | print "CHECK<$possible> ($line)\n" if ($dbg_possible > 2); |
| 922 | if ($possible !~ /(?: |
| 923 | ^(?: |
| 924 | $Modifier| |
| 925 | $Storage| |
| 926 | $Type| |
| 927 | DEFINE_\S+| |
| 928 | goto| |
| 929 | return| |
| 930 | case| |
| 931 | else| |
| 932 | asm|__asm__| |
| 933 | do |
| 934 | )$| |
| 935 | ^(?:typedef|struct|enum)\b |
| 936 | )/x) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 937 | # Check for modifiers. |
| 938 | $possible =~ s/\s*$Storage\s*//g; |
| 939 | $possible =~ s/\s*$Sparse\s*//g; |
| 940 | if ($possible =~ /^\s*$/) { |
| 941 | |
| 942 | } elsif ($possible =~ /\s/) { |
| 943 | $possible =~ s/\s*$Type\s*//g; |
Andy Whitcroft | d250658 | 2008-07-23 21:29:09 -0700 | [diff] [blame] | 944 | for my $modifier (split(' ', $possible)) { |
| 945 | warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible); |
| 946 | push(@modifierList, $modifier); |
| 947 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 948 | |
| 949 | } else { |
| 950 | warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible); |
| 951 | push(@typeList, $possible); |
| 952 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 953 | build_types(); |
Andy Whitcroft | 0776e59 | 2008-10-15 22:02:29 -0700 | [diff] [blame] | 954 | } else { |
| 955 | warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 956 | } |
| 957 | } |
| 958 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 959 | my $prefix = ''; |
| 960 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 961 | sub report { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 962 | if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) { |
| 963 | return 0; |
| 964 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 965 | my $line = $prefix . $_[0]; |
| 966 | |
| 967 | $line = (split('\n', $line))[0] . "\n" if ($terse); |
| 968 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 969 | push(our @report, $line); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 970 | |
| 971 | return 1; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 972 | } |
| 973 | sub report_dump { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 974 | our @report; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 975 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 976 | sub ERROR { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 977 | if (report("ERROR: $_[0]\n")) { |
| 978 | our $clean = 0; |
| 979 | our $cnt_error++; |
| 980 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 981 | } |
| 982 | sub WARN { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 983 | if (report("WARNING: $_[0]\n")) { |
| 984 | our $clean = 0; |
| 985 | our $cnt_warn++; |
| 986 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 987 | } |
| 988 | sub CHK { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 989 | if ($check && report("CHECK: $_[0]\n")) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 990 | our $clean = 0; |
| 991 | our $cnt_chk++; |
| 992 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 993 | } |
| 994 | |
Andy Whitcroft | 6ecd967 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 995 | sub check_absolute_file { |
| 996 | my ($absolute, $herecurr) = @_; |
| 997 | my $file = $absolute; |
| 998 | |
| 999 | ##print "absolute<$absolute>\n"; |
| 1000 | |
| 1001 | # See if any suffix of this path is a path within the tree. |
| 1002 | while ($file =~ s@^[^/]*/@@) { |
| 1003 | if (-f "$root/$file") { |
| 1004 | ##print "file<$file>\n"; |
| 1005 | last; |
| 1006 | } |
| 1007 | } |
| 1008 | if (! -f _) { |
| 1009 | return 0; |
| 1010 | } |
| 1011 | |
| 1012 | # It is, so see if the prefix is acceptable. |
| 1013 | my $prefix = $absolute; |
| 1014 | substr($prefix, -length($file)) = ''; |
| 1015 | |
| 1016 | ##print "prefix<$prefix>\n"; |
| 1017 | if ($prefix ne ".../") { |
| 1018 | WARN("use relative pathname instead of absolute in changelog text\n" . $herecurr); |
| 1019 | } |
| 1020 | } |
| 1021 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1022 | sub process { |
| 1023 | my $filename = shift; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1024 | |
| 1025 | my $linenr=0; |
| 1026 | my $prevline=""; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1027 | my $prevrawline=""; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1028 | my $stashline=""; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1029 | my $stashrawline=""; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1030 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1031 | my $length; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1032 | my $indent; |
| 1033 | my $previndent=0; |
| 1034 | my $stashindent=0; |
| 1035 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1036 | our $clean = 1; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1037 | my $signoff = 0; |
| 1038 | my $is_patch = 0; |
| 1039 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1040 | our @report = (); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1041 | our $cnt_lines = 0; |
| 1042 | our $cnt_error = 0; |
| 1043 | our $cnt_warn = 0; |
| 1044 | our $cnt_chk = 0; |
| 1045 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1046 | # Trace the real file/line as we go. |
| 1047 | my $realfile = ''; |
| 1048 | my $realline = 0; |
| 1049 | my $realcnt = 0; |
| 1050 | my $here = ''; |
| 1051 | my $in_comment = 0; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1052 | my $comment_edge = 0; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1053 | my $first_line = 0; |
| 1054 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1055 | my $prev_values = 'E'; |
| 1056 | |
| 1057 | # suppression flags |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1058 | my %suppress_ifbraces; |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1059 | my %suppress_whiletrailers; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1060 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1061 | # Pre-scan the patch sanitizing the lines. |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1062 | # Pre-scan the patch looking for any __setup documentation. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1063 | # |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1064 | my @setup_docs = (); |
| 1065 | my $setup_docs = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1066 | |
| 1067 | sanitise_line_reset(); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1068 | my $line; |
| 1069 | foreach my $rawline (@rawlines) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1070 | $linenr++; |
| 1071 | $line = $rawline; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1072 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1073 | if ($rawline=~/^\+\+\+\s+(\S+)/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1074 | $setup_docs = 0; |
| 1075 | if ($1 =~ m@Documentation/kernel-parameters.txt$@) { |
| 1076 | $setup_docs = 1; |
| 1077 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1078 | #next; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1079 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1080 | if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
| 1081 | $realline=$1-1; |
| 1082 | if (defined $2) { |
| 1083 | $realcnt=$3+1; |
| 1084 | } else { |
| 1085 | $realcnt=1+1; |
| 1086 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1087 | $in_comment = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1088 | |
| 1089 | # Guestimate if this is a continuing comment. Run |
| 1090 | # the context looking for a comment "edge". If this |
| 1091 | # edge is a close comment then we must be in a comment |
| 1092 | # at context start. |
| 1093 | my $edge; |
Andy Whitcroft | 01fa914 | 2008-10-15 22:02:19 -0700 | [diff] [blame] | 1094 | my $cnt = $realcnt; |
| 1095 | for (my $ln = $linenr + 1; $cnt > 0; $ln++) { |
| 1096 | next if (defined $rawlines[$ln - 1] && |
| 1097 | $rawlines[$ln - 1] =~ /^-/); |
| 1098 | $cnt--; |
| 1099 | #print "RAW<$rawlines[$ln - 1]>\n"; |
Andy Whitcroft | 721c1cb | 2009-01-06 14:41:16 -0800 | [diff] [blame^] | 1100 | last if (!defined $rawlines[$ln - 1]); |
| 1101 | ($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1102 | last if (defined $edge); |
| 1103 | } |
| 1104 | if (defined $edge && $edge eq '*/') { |
| 1105 | $in_comment = 1; |
| 1106 | } |
| 1107 | |
| 1108 | # Guestimate if this is a continuing comment. If this |
| 1109 | # is the start of a diff block and this line starts |
| 1110 | # ' *' then it is very likely a comment. |
| 1111 | if (!defined $edge && |
| 1112 | $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@) |
| 1113 | { |
| 1114 | $in_comment = 1; |
| 1115 | } |
| 1116 | |
| 1117 | ##print "COMMENT:$in_comment edge<$edge> $rawline\n"; |
| 1118 | sanitise_line_reset($in_comment); |
| 1119 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1120 | } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1121 | # Standardise the strings and chars within the input to |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1122 | # simplify matching -- only bother with positive lines. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1123 | $line = sanitise_line($rawline); |
| 1124 | } |
| 1125 | push(@lines, $line); |
| 1126 | |
| 1127 | if ($realcnt > 1) { |
| 1128 | $realcnt-- if ($line =~ /^(?:\+| |$)/); |
| 1129 | } else { |
| 1130 | $realcnt = 0; |
| 1131 | } |
| 1132 | |
| 1133 | #print "==>$rawline\n"; |
| 1134 | #print "-->$line\n"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1135 | |
| 1136 | if ($setup_docs && $line =~ /^\+/) { |
| 1137 | push(@setup_docs, $line); |
| 1138 | } |
| 1139 | } |
| 1140 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1141 | $prefix = ''; |
| 1142 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1143 | $realcnt = 0; |
| 1144 | $linenr = 0; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1145 | foreach my $line (@lines) { |
| 1146 | $linenr++; |
| 1147 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1148 | my $rawline = $rawlines[$linenr - 1]; |
Andy Whitcroft | 30670854 | 2008-10-15 22:02:28 -0700 | [diff] [blame] | 1149 | my $hunk_line = ($realcnt != 0); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1150 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1151 | #extract the line range in the file after the patch is applied |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1152 | if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1153 | $is_patch = 1; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1154 | $first_line = $linenr + 1; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1155 | $realline=$1-1; |
| 1156 | if (defined $2) { |
| 1157 | $realcnt=$3+1; |
| 1158 | } else { |
| 1159 | $realcnt=1+1; |
| 1160 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1161 | annotate_reset(); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1162 | $prev_values = 'E'; |
| 1163 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1164 | %suppress_ifbraces = (); |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1165 | %suppress_whiletrailers = (); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1166 | next; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1167 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1168 | # track the line number as we move through the hunk, note that |
| 1169 | # new versions of GNU diff omit the leading space on completely |
| 1170 | # blank context lines so we need to count that too. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1171 | } elsif ($line =~ /^( |\+|$)/) { |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1172 | $realline++; |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1173 | $realcnt-- if ($realcnt != 0); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1174 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1175 | # Measure the line length and indent. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1176 | ($length, $indent) = line_stats($rawline); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1177 | |
| 1178 | # Track the previous line. |
| 1179 | ($prevline, $stashline) = ($stashline, $line); |
| 1180 | ($previndent, $stashindent) = ($stashindent, $indent); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1181 | ($prevrawline, $stashrawline) = ($stashrawline, $rawline); |
| 1182 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1183 | #warn "line<$line>\n"; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1184 | |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1185 | } elsif ($realcnt == 1) { |
| 1186 | $realcnt--; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1187 | } |
| 1188 | |
| 1189 | #make up the handle for any error we report on this line |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1190 | $prefix = "$filename:$realline: " if ($emacs && $file); |
| 1191 | $prefix = "$filename:$linenr: " if ($emacs && !$file); |
| 1192 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1193 | $here = "#$linenr: " if (!$file); |
| 1194 | $here = "#$realline: " if ($file); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1195 | |
| 1196 | # extract the filename as it passes |
| 1197 | if ($line=~/^\+\+\+\s+(\S+)/) { |
| 1198 | $realfile = $1; |
| 1199 | $realfile =~ s@^[^/]*/@@; |
| 1200 | |
Andy Whitcroft | c1ab332 | 2008-10-15 22:02:20 -0700 | [diff] [blame] | 1201 | if ($realfile =~ m@^include/asm/@) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1202 | ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n"); |
| 1203 | } |
| 1204 | next; |
| 1205 | } |
| 1206 | |
Randy Dunlap | 389834b | 2007-06-08 13:47:03 -0700 | [diff] [blame] | 1207 | $here .= "FILE: $realfile:$realline:" if ($realcnt != 0); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1208 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1209 | my $hereline = "$here\n$rawline\n"; |
| 1210 | my $herecurr = "$here\n$rawline\n"; |
| 1211 | my $hereprev = "$here\n$prevrawline\n$rawline\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1212 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1213 | $cnt_lines++ if ($realcnt != 0); |
| 1214 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1215 | #check the patch for a signoff: |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1216 | if ($line =~ /^\s*signed-off-by:/i) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1217 | # This is a signoff, if ugly, so do not double report. |
| 1218 | $signoff++; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1219 | if (!($line =~ /^\s*Signed-off-by:/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1220 | WARN("Signed-off-by: is the preferred form\n" . |
| 1221 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1222 | } |
| 1223 | if ($line =~ /^\s*signed-off-by:\S/i) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1224 | WARN("space required after Signed-off-by:\n" . |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1225 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1226 | } |
| 1227 | } |
| 1228 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1229 | # Check for wrappage within a valid hunk of the file |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1230 | if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1231 | ERROR("patch seems to be corrupt (line wrapped?)\n" . |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1232 | $herecurr) if (!$emitted_corrupt++); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1233 | } |
| 1234 | |
Andy Whitcroft | 6ecd967 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1235 | # Check for absolute kernel paths. |
| 1236 | if ($tree) { |
| 1237 | while ($line =~ m{(?:^|\s)(/\S*)}g) { |
| 1238 | my $file = $1; |
| 1239 | |
| 1240 | if ($file =~ m{^(.*?)(?::\d+)+:?$} && |
| 1241 | check_absolute_file($1, $herecurr)) { |
| 1242 | # |
| 1243 | } else { |
| 1244 | check_absolute_file($file, $herecurr); |
| 1245 | } |
| 1246 | } |
| 1247 | } |
| 1248 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1249 | # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php |
| 1250 | if (($realfile =~ /^$/ || $line =~ /^\+/) && |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1251 | $rawline !~ m/^$UTF8*$/) { |
| 1252 | my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/); |
| 1253 | |
| 1254 | my $blank = copy_spacing($rawline); |
| 1255 | my $ptr = substr($blank, 0, length($utf8_prefix)) . "^"; |
| 1256 | my $hereptr = "$hereline$ptr\n"; |
| 1257 | |
| 1258 | ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1259 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1260 | |
Andy Whitcroft | 30670854 | 2008-10-15 22:02:28 -0700 | [diff] [blame] | 1261 | # ignore non-hunk lines and lines being removed |
| 1262 | next if (!$hunk_line || $line =~ /^-/); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1263 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1264 | #trailing whitespace |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1265 | if ($line =~ /^\+.*\015/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1266 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1267 | ERROR("DOS line endings\n" . $herevet); |
| 1268 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1269 | } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) { |
| 1270 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1271 | ERROR("trailing whitespace\n" . $herevet); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1272 | } |
Andy Whitcroft | 5368df20 | 2008-10-15 22:02:27 -0700 | [diff] [blame] | 1273 | |
| 1274 | # check we are in a valid source file if not then ignore this hunk |
| 1275 | next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/); |
| 1276 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1277 | #80 column limit |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1278 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
Andy Whitcroft | f4c014c | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1279 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
| 1280 | $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ && |
| 1281 | $length > 80) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1282 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1283 | WARN("line over 80 characters\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1284 | } |
| 1285 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1286 | # check for adding lines without a newline. |
| 1287 | if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) { |
| 1288 | WARN("adding a line without newline at end of file\n" . $herecurr); |
| 1289 | } |
| 1290 | |
Andy Whitcroft | b9ea10d | 2008-10-15 22:02:24 -0700 | [diff] [blame] | 1291 | # check we are in a valid source file C or perl if not then ignore this hunk |
| 1292 | next if ($realfile !~ /\.(h|c|pl)$/); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1293 | |
| 1294 | # at the beginning of a line any tabs must come first and anything |
| 1295 | # more than 8 must use tabs. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1296 | if ($rawline =~ /^\+\s* \t\s*\S/ || |
| 1297 | $rawline =~ /^\+\s* \s*/) { |
| 1298 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1299 | ERROR("code indent should use tabs where possible\n" . $herevet); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1300 | } |
| 1301 | |
Andy Whitcroft | b9ea10d | 2008-10-15 22:02:24 -0700 | [diff] [blame] | 1302 | # check we are in a valid C source file if not then ignore this hunk |
| 1303 | next if ($realfile !~ /\.(h|c)$/); |
| 1304 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1305 | # check for RCS/CVS revision markers |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1306 | if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1307 | WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr); |
| 1308 | } |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1309 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1310 | # Check for potential 'bare' types |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1311 | my ($stat, $cond, $line_nr_next, $remain_next, $off_next); |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 1312 | if ($realcnt && $line =~ /.\s*\S/) { |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1313 | ($stat, $cond, $line_nr_next, $remain_next, $off_next) = |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1314 | ctx_statement_block($linenr, $realcnt, 0); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1315 | $stat =~ s/\n./\n /g; |
| 1316 | $cond =~ s/\n./\n /g; |
| 1317 | |
| 1318 | my $s = $stat; |
| 1319 | $s =~ s/{.*$//s; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1320 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1321 | # Ignore goto labels. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1322 | if ($s =~ /$Ident:\*$/s) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1323 | |
| 1324 | # Ignore functions being called |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1325 | } elsif ($s =~ /^.\s*$Ident\s*\(/s) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1326 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1327 | # declarations always start with types |
Andy Whitcroft | d250658 | 2008-07-23 21:29:09 -0700 | [diff] [blame] | 1328 | } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1329 | my $type = $1; |
| 1330 | $type =~ s/\s+/ /g; |
| 1331 | possible($type, "A:" . $s); |
| 1332 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1333 | # definitions in global scope can only start with types |
Andy Whitcroft | a6a84062 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1334 | } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1335 | possible($1, "B:" . $s); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1336 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1337 | |
| 1338 | # any (foo ... *) is a pointer cast, and foo is a type |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1339 | while ($s =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/sg) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1340 | possible($1, "C:" . $s); |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1341 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1342 | |
| 1343 | # Check for any sort of function declaration. |
| 1344 | # int foo(something bar, other baz); |
| 1345 | # void (*store_gdt)(x86_descr_ptr *); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1346 | if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1347 | my ($name_len) = length($1); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1348 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1349 | my $ctx = $s; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1350 | substr($ctx, 0, $name_len + 1, ''); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1351 | $ctx =~ s/\)[^\)]*$//; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1352 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1353 | for my $arg (split(/\s*,\s*/, $ctx)) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1354 | if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1355 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1356 | possible($1, "D:" . $s); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1357 | } |
| 1358 | } |
| 1359 | } |
| 1360 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1361 | } |
| 1362 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1363 | # |
| 1364 | # Checks which may be anchored in the context. |
| 1365 | # |
| 1366 | |
| 1367 | # Check for switch () and associated case and default |
| 1368 | # statements should be at the same indent. |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1369 | if ($line=~/\bswitch\s*\(.*\)/) { |
| 1370 | my $err = ''; |
| 1371 | my $sep = ''; |
| 1372 | my @ctx = ctx_block_outer($linenr, $realcnt); |
| 1373 | shift(@ctx); |
| 1374 | for my $ctx (@ctx) { |
| 1375 | my ($clen, $cindent) = line_stats($ctx); |
| 1376 | if ($ctx =~ /^\+\s*(case\s+|default:)/ && |
| 1377 | $indent != $cindent) { |
| 1378 | $err .= "$sep$ctx\n"; |
| 1379 | $sep = ''; |
| 1380 | } else { |
| 1381 | $sep = "[...]\n"; |
| 1382 | } |
| 1383 | } |
| 1384 | if ($err ne '') { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1385 | ERROR("switch and case should be at the same indent\n$hereline$err"); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1386 | } |
| 1387 | } |
| 1388 | |
| 1389 | # if/while/etc brace do not go on next line, unless defining a do while loop, |
| 1390 | # or if that brace on the next line is for something else |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1391 | if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1392 | my $pre_ctx = "$1$2"; |
| 1393 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1394 | my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1395 | my $ctx_cnt = $realcnt - $#ctx - 1; |
| 1396 | my $ctx = join("\n", @ctx); |
| 1397 | |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1398 | my $ctx_ln = $linenr; |
| 1399 | my $ctx_skip = $realcnt; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1400 | |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1401 | while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt && |
| 1402 | defined $lines[$ctx_ln - 1] && |
| 1403 | $lines[$ctx_ln - 1] =~ /^-/)) { |
| 1404 | ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n"; |
| 1405 | $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1406 | $ctx_ln++; |
| 1407 | } |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1408 | |
Andy Whitcroft | 5321016 | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1409 | #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n"; |
| 1410 | #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n"; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1411 | |
| 1412 | if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) { |
| 1413 | ERROR("that open brace { should be on the previous line\n" . |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1414 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1415 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1416 | if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ && |
| 1417 | $ctx =~ /\)\s*\;\s*$/ && |
| 1418 | defined $lines[$ctx_ln - 1]) |
| 1419 | { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1420 | my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]); |
| 1421 | if ($nindent > $indent) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1422 | WARN("trailing semicolon indicates no statements, indent implies otherwise\n" . |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1423 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1424 | } |
| 1425 | } |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1426 | } |
| 1427 | |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1428 | # Check relative indent for conditionals and blocks. |
| 1429 | if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { |
| 1430 | my ($s, $c) = ($stat, $cond); |
| 1431 | |
| 1432 | substr($s, 0, length($c), ''); |
| 1433 | |
| 1434 | # Make sure we remove the line prefixes as we have |
| 1435 | # none on the first line, and are going to readd them |
| 1436 | # where necessary. |
| 1437 | $s =~ s/\n./\n/gs; |
| 1438 | |
| 1439 | # Find out how long the conditional actually is. |
Andy Whitcroft | 6f779c1 | 2008-10-15 22:02:27 -0700 | [diff] [blame] | 1440 | my @newlines = ($c =~ /\n/gs); |
| 1441 | my $cond_lines = 1 + $#newlines; |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1442 | |
| 1443 | # We want to check the first line inside the block |
| 1444 | # starting at the end of the conditional, so remove: |
| 1445 | # 1) any blank line termination |
| 1446 | # 2) any opening brace { on end of the line |
| 1447 | # 3) any do (...) { |
| 1448 | my $continuation = 0; |
| 1449 | my $check = 0; |
| 1450 | $s =~ s/^.*\bdo\b//; |
| 1451 | $s =~ s/^\s*{//; |
| 1452 | if ($s =~ s/^\s*\\//) { |
| 1453 | $continuation = 1; |
| 1454 | } |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1455 | if ($s =~ s/^\s*?\n//) { |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1456 | $check = 1; |
| 1457 | $cond_lines++; |
| 1458 | } |
| 1459 | |
| 1460 | # Also ignore a loop construct at the end of a |
| 1461 | # preprocessor statement. |
| 1462 | if (($prevline =~ /^.\s*#\s*define\s/ || |
| 1463 | $prevline =~ /\\\s*$/) && $continuation == 0) { |
| 1464 | $check = 0; |
| 1465 | } |
| 1466 | |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1467 | my $cond_ptr = -1; |
Andy Whitcroft | 740504c | 2008-10-15 22:02:35 -0700 | [diff] [blame] | 1468 | $continuation = 0; |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1469 | while ($cond_ptr != $cond_lines) { |
| 1470 | $cond_ptr = $cond_lines; |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1471 | |
Andy Whitcroft | f16fa28 | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 1472 | # If we see an #else/#elif then the code |
| 1473 | # is not linear. |
| 1474 | if ($s =~ /^\s*\#\s*(?:else|elif)/) { |
| 1475 | $check = 0; |
| 1476 | } |
| 1477 | |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1478 | # Ignore: |
| 1479 | # 1) blank lines, they should be at 0, |
| 1480 | # 2) preprocessor lines, and |
| 1481 | # 3) labels. |
Andy Whitcroft | 740504c | 2008-10-15 22:02:35 -0700 | [diff] [blame] | 1482 | if ($continuation || |
| 1483 | $s =~ /^\s*?\n/ || |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1484 | $s =~ /^\s*#\s*?/ || |
| 1485 | $s =~ /^\s*$Ident\s*:/) { |
Andy Whitcroft | 740504c | 2008-10-15 22:02:35 -0700 | [diff] [blame] | 1486 | $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0; |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1487 | $s =~ s/^.*?\n//; |
| 1488 | $cond_lines++; |
| 1489 | } |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1490 | } |
| 1491 | |
| 1492 | my (undef, $sindent) = line_stats("+" . $s); |
| 1493 | my $stat_real = raw_line($linenr, $cond_lines); |
| 1494 | |
| 1495 | # Check if either of these lines are modified, else |
| 1496 | # this is not this patch's fault. |
| 1497 | if (!defined($stat_real) || |
| 1498 | $stat !~ /^\+/ && $stat_real !~ /^\+/) { |
| 1499 | $check = 0; |
| 1500 | } |
| 1501 | if (defined($stat_real) && $cond_lines > 1) { |
| 1502 | $stat_real = "[...]\n$stat_real"; |
| 1503 | } |
| 1504 | |
Andy Whitcroft | 9bd49ef | 2008-10-15 22:02:22 -0700 | [diff] [blame] | 1505 | #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n"; |
Andy Whitcroft | 4d001e4 | 2008-10-15 22:02:21 -0700 | [diff] [blame] | 1506 | |
| 1507 | if ($check && (($sindent % 8) != 0 || |
| 1508 | ($sindent <= $indent && $s ne ''))) { |
| 1509 | WARN("suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n"); |
| 1510 | } |
| 1511 | } |
| 1512 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1513 | # Track the 'values' across context and added lines. |
| 1514 | my $opline = $line; $opline =~ s/^./ /; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1515 | my ($curr_values, $curr_vars) = |
| 1516 | annotate_values($opline . "\n", $prev_values); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1517 | $curr_values = $prev_values . $curr_values; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1518 | if ($dbg_values) { |
| 1519 | my $outline = $opline; $outline =~ s/\t/ /g; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1520 | print "$linenr > .$outline\n"; |
| 1521 | print "$linenr > $curr_values\n"; |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1522 | print "$linenr > $curr_vars\n"; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1523 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1524 | $prev_values = substr($curr_values, -1); |
| 1525 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1526 | #ignore lines not being added |
| 1527 | if ($line=~/^[^\+]/) {next;} |
| 1528 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1529 | # TEST: allow direct testing of the type matcher. |
Andy Whitcroft | 7429c69 | 2008-07-23 21:29:06 -0700 | [diff] [blame] | 1530 | if ($dbg_type) { |
| 1531 | if ($line =~ /^.\s*$Declare\s*$/) { |
| 1532 | ERROR("TEST: is type\n" . $herecurr); |
| 1533 | } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) { |
| 1534 | ERROR("TEST: is not type ($1 is)\n". $herecurr); |
| 1535 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1536 | next; |
| 1537 | } |
Andy Whitcroft | a1ef277 | 2008-10-15 22:02:17 -0700 | [diff] [blame] | 1538 | # TEST: allow direct testing of the attribute matcher. |
| 1539 | if ($dbg_attr) { |
| 1540 | if ($line =~ /^.\s*$Attribute\s*$/) { |
| 1541 | ERROR("TEST: is attr\n" . $herecurr); |
| 1542 | } elsif ($dbg_attr > 1 && $line =~ /^.+($Attribute)/) { |
| 1543 | ERROR("TEST: is not attr ($1 is)\n". $herecurr); |
| 1544 | } |
| 1545 | next; |
| 1546 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1547 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1548 | # check for initialisation to aggregates open brace on the next line |
| 1549 | if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ && |
| 1550 | $line =~ /^.\s*{/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1551 | ERROR("that open brace { should be on the previous line\n" . $hereprev); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1552 | } |
| 1553 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1554 | # |
| 1555 | # Checks which are anchored on the added line. |
| 1556 | # |
| 1557 | |
| 1558 | # check for malformed paths in #include statements (uses RAW line) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1559 | if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) { |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1560 | my $path = $1; |
| 1561 | if ($path =~ m{//}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1562 | ERROR("malformed #include filename\n" . |
| 1563 | $herecurr); |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1564 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1565 | } |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1566 | |
| 1567 | # no C99 // comments |
| 1568 | if ($line =~ m{//}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1569 | ERROR("do not use C99 // comments\n" . $herecurr); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1570 | } |
| 1571 | # Remove C99 comments. |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1572 | $line =~ s@//.*@@; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1573 | $opline =~ s@//.*@@; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1574 | |
| 1575 | #EXPORT_SYMBOL should immediately follow its function closing }. |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1576 | if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) || |
| 1577 | ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) { |
| 1578 | my $name = $1; |
Andy Whitcroft | 4801205 | 2008-10-15 22:02:34 -0700 | [diff] [blame] | 1579 | if ($prevline !~ /(?: |
| 1580 | ^.}| |
| 1581 | ^.DEFINE_$Ident\(\Q$name\E\)| |
| 1582 | ^.DECLARE_$Ident\(\Q$name\E\)| |
| 1583 | ^.LIST_HEAD\(\Q$name\E\)| |
| 1584 | ^.$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(| |
| 1585 | \b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=|\[) |
| 1586 | )/x) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1587 | WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1588 | } |
| 1589 | } |
| 1590 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1591 | # check for external initialisers. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1592 | if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1593 | ERROR("do not initialise externals to 0 or NULL\n" . |
| 1594 | $herecurr); |
| 1595 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1596 | # check for static initialisers. |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 1597 | if ($line =~ /\s*static\s.*=\s*(0|NULL|false)\s*;/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1598 | ERROR("do not initialise statics to 0 or NULL\n" . |
| 1599 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1600 | } |
| 1601 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1602 | # check for new typedefs, only function parameters and sparse annotations |
| 1603 | # make sense. |
| 1604 | if ($line =~ /\btypedef\s/ && |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1605 | $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1606 | $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && |
Andy Whitcroft | 8ed22ca | 2008-10-15 22:02:32 -0700 | [diff] [blame] | 1607 | $line !~ /\b$typeTypedefs\b/ && |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1608 | $line !~ /\b__bitwise(?:__|)\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1609 | WARN("do not add new typedefs\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1610 | } |
| 1611 | |
| 1612 | # * goes on variable not on type |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1613 | if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1614 | ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" . |
| 1615 | $herecurr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1616 | |
| 1617 | } elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1618 | ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" . |
| 1619 | $herecurr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1620 | |
Andy Whitcroft | 234fff6 | 2008-07-23 21:29:12 -0700 | [diff] [blame] | 1621 | } elsif ($line =~ m{\b$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1622 | ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" . |
| 1623 | $herecurr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1624 | |
Andy Whitcroft | 234fff6 | 2008-07-23 21:29:12 -0700 | [diff] [blame] | 1625 | } elsif ($line =~ m{\b$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1626 | ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" . |
| 1627 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1628 | } |
| 1629 | |
| 1630 | # # no BUG() or BUG_ON() |
| 1631 | # if ($line =~ /\b(BUG|BUG_ON)\b/) { |
| 1632 | # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n"; |
| 1633 | # print "$herecurr"; |
| 1634 | # $clean = 0; |
| 1635 | # } |
| 1636 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1637 | if ($line =~ /\bLINUX_VERSION_CODE\b/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1638 | WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1639 | } |
| 1640 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1641 | # printk should use KERN_* levels. Note that follow on printk's on the |
| 1642 | # same line do not need a level, so we use the current block context |
| 1643 | # to try and find and validate the current printk. In summary the current |
| 1644 | # printk includes all preceeding printk's which have no newline on the end. |
| 1645 | # we assume the first bad printk is the one to report. |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1646 | if ($line =~ /\bprintk\((?!KERN_)\s*"/) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1647 | my $ok = 0; |
| 1648 | for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) { |
| 1649 | #print "CHECK<$lines[$ln - 1]\n"; |
| 1650 | # we have a preceeding printk if it ends |
| 1651 | # with "\n" ignore it, else it is to blame |
| 1652 | if ($lines[$ln - 1] =~ m{\bprintk\(}) { |
| 1653 | if ($rawlines[$ln - 1] !~ m{\\n"}) { |
| 1654 | $ok = 1; |
| 1655 | } |
| 1656 | last; |
| 1657 | } |
| 1658 | } |
| 1659 | if ($ok == 0) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1660 | WARN("printk() should include KERN_ facility level\n" . $herecurr); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1661 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1662 | } |
| 1663 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1664 | # function brace can't be on same line, except for #defines of do while, |
| 1665 | # or if closed on same line |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1666 | if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and |
| 1667 | !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1668 | ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1669 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1670 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1671 | # open braces for enum, union and struct go on the same line. |
| 1672 | if ($line =~ /^.\s*{/ && |
| 1673 | $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { |
| 1674 | ERROR("open brace '{' following $1 go on the same line\n" . $hereprev); |
| 1675 | } |
| 1676 | |
Andy Whitcroft | 8d31cfc | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1677 | # check for spacing round square brackets; allowed: |
| 1678 | # 1. with a type on the left -- int [] a; |
Andy Whitcroft | fe2a7db | 2008-10-15 22:02:15 -0700 | [diff] [blame] | 1679 | # 2. at the beginning of a line for slice initialisers -- [0...10] = 5, |
| 1680 | # 3. inside a curly brace -- = { [0...10] = 5 } |
Andy Whitcroft | 8d31cfc | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1681 | while ($line =~ /(.*?\s)\[/g) { |
| 1682 | my ($where, $prefix) = ($-[1], $1); |
| 1683 | if ($prefix !~ /$Type\s+$/ && |
Andy Whitcroft | fe2a7db | 2008-10-15 22:02:15 -0700 | [diff] [blame] | 1684 | ($where != 0 || $prefix !~ /^.\s+$/) && |
| 1685 | $prefix !~ /{\s+$/) { |
Andy Whitcroft | 8d31cfc | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1686 | ERROR("space prohibited before open square bracket '['\n" . $herecurr); |
| 1687 | } |
| 1688 | } |
| 1689 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1690 | # check for spaces between functions and their parentheses. |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1691 | while ($line =~ /($Ident)\s+\(/g) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1692 | my $name = $1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1693 | my $ctx_before = substr($line, 0, $-[1]); |
| 1694 | my $ctx = "$ctx_before$name"; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1695 | |
| 1696 | # Ignore those directives where spaces _are_ permitted. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1697 | if ($name =~ /^(?: |
| 1698 | if|for|while|switch|return|case| |
| 1699 | volatile|__volatile__| |
| 1700 | __attribute__|format|__extension__| |
| 1701 | asm|__asm__)$/x) |
| 1702 | { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1703 | |
| 1704 | # cpp #define statements have non-optional spaces, ie |
| 1705 | # if there is a space between the name and the open |
| 1706 | # parenthesis it is simply not a parameter group. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1707 | } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1708 | |
| 1709 | # cpp #elif statement condition may start with a ( |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1710 | } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1711 | |
| 1712 | # If this whole things ends with a type its most |
| 1713 | # likely a typedef for a function. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1714 | } elsif ($ctx =~ /$Type$/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1715 | |
| 1716 | } else { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1717 | WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1718 | } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1719 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1720 | # Check operator spacing. |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1721 | if (!($line=~/\#\s*include/)) { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1722 | my $ops = qr{ |
| 1723 | <<=|>>=|<=|>=|==|!=| |
| 1724 | \+=|-=|\*=|\/=|%=|\^=|\|=|&=| |
| 1725 | =>|->|<<|>>|<|>|=|!|~| |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1726 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%| |
| 1727 | \?|: |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1728 | }x; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1729 | my @elements = split(/($ops|;)/, $opline); |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1730 | my $off = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1731 | |
| 1732 | my $blank = copy_spacing($opline); |
| 1733 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1734 | for (my $n = 0; $n < $#elements; $n += 2) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1735 | $off += length($elements[$n]); |
| 1736 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1737 | # Pick up the preceeding and succeeding characters. |
| 1738 | my $ca = substr($opline, 0, $off); |
| 1739 | my $cc = ''; |
| 1740 | if (length($opline) >= ($off + length($elements[$n + 1]))) { |
| 1741 | $cc = substr($opline, $off + length($elements[$n + 1])); |
| 1742 | } |
| 1743 | my $cb = "$ca$;$cc"; |
| 1744 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1745 | my $a = ''; |
| 1746 | $a = 'V' if ($elements[$n] ne ''); |
| 1747 | $a = 'W' if ($elements[$n] =~ /\s$/); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1748 | $a = 'C' if ($elements[$n] =~ /$;$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1749 | $a = 'B' if ($elements[$n] =~ /(\[|\()$/); |
| 1750 | $a = 'O' if ($elements[$n] eq ''); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1751 | $a = 'E' if ($ca =~ /^\s*$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1752 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1753 | my $op = $elements[$n + 1]; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1754 | |
| 1755 | my $c = ''; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1756 | if (defined $elements[$n + 2]) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1757 | $c = 'V' if ($elements[$n + 2] ne ''); |
| 1758 | $c = 'W' if ($elements[$n + 2] =~ /^\s/); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1759 | $c = 'C' if ($elements[$n + 2] =~ /^$;/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1760 | $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/); |
| 1761 | $c = 'O' if ($elements[$n + 2] eq ''); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1762 | $c = 'E' if ($elements[$n + 2] =~ /\s*\\$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1763 | } else { |
| 1764 | $c = 'E'; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1765 | } |
| 1766 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1767 | my $ctx = "${a}x${c}"; |
| 1768 | |
| 1769 | my $at = "(ctx:$ctx)"; |
| 1770 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1771 | my $ptr = substr($blank, 0, $off) . "^"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1772 | my $hereptr = "$hereline$ptr\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1773 | |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1774 | # Pull out the value of this operator. |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1775 | my $op_type = substr($curr_values, $off + 1, 1); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1776 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1777 | # Get the full operator variant. |
| 1778 | my $opv = $op . substr($curr_vars, $off, 1); |
| 1779 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1780 | # Ignore operators passed as parameters. |
| 1781 | if ($op_type ne 'V' && |
| 1782 | $ca =~ /\s$/ && $cc =~ /^\s*,/) { |
| 1783 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1784 | # # Ignore comments |
| 1785 | # } elsif ($op =~ /^$;+$/) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1786 | |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1787 | # ; should have either the end of line or a space or \ after it |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1788 | } elsif ($op eq ';') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1789 | if ($ctx !~ /.x[WEBC]/ && |
| 1790 | $cc !~ /^\\/ && $cc !~ /^;/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1791 | ERROR("space required after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1792 | } |
| 1793 | |
| 1794 | # // is a comment |
| 1795 | } elsif ($op eq '//') { |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1796 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1797 | # No spaces for: |
| 1798 | # -> |
| 1799 | # : when part of a bitfield |
| 1800 | } elsif ($op eq '->' || $opv eq ':B') { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1801 | if ($ctx =~ /Wx.|.xW/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1802 | ERROR("spaces prohibited around that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1803 | } |
| 1804 | |
| 1805 | # , must have a space on the right. |
| 1806 | } elsif ($op eq ',') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1807 | if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1808 | ERROR("space required after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1809 | } |
| 1810 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1811 | # '*' as part of a type definition -- reported already. |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1812 | } elsif ($opv eq '*_') { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1813 | #warn "'*' is part of type\n"; |
| 1814 | |
| 1815 | # unary operators should have a space before and |
| 1816 | # none after. May be left adjacent to another |
| 1817 | # unary operator, or a cast |
| 1818 | } elsif ($op eq '!' || $op eq '~' || |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1819 | $opv eq '*U' || $opv eq '-U' || |
Andy Whitcroft | 0d41386 | 2008-10-15 22:02:16 -0700 | [diff] [blame] | 1820 | $opv eq '&U' || $opv eq '&&U') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1821 | if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1822 | ERROR("space required before that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1823 | } |
Andy Whitcroft | 74048ed | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1824 | if ($op eq '*' && $cc =~/\s*const\b/) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1825 | # A unary '*' may be const |
| 1826 | |
| 1827 | } elsif ($ctx =~ /.xW/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1828 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1829 | } |
| 1830 | |
| 1831 | # unary ++ and unary -- are allowed no space on one side. |
| 1832 | } elsif ($op eq '++' or $op eq '--') { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1833 | if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) { |
| 1834 | ERROR("space required one side of that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1835 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1836 | if ($ctx =~ /Wx[BE]/ || |
| 1837 | ($ctx =~ /Wx./ && $cc =~ /^;/)) { |
| 1838 | ERROR("space prohibited before that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1839 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1840 | if ($ctx =~ /ExW/) { |
| 1841 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); |
| 1842 | } |
| 1843 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1844 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1845 | # << and >> may either have or not have spaces both sides |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1846 | } elsif ($op eq '<<' or $op eq '>>' or |
| 1847 | $op eq '&' or $op eq '^' or $op eq '|' or |
| 1848 | $op eq '+' or $op eq '-' or |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1849 | $op eq '*' or $op eq '/' or |
| 1850 | $op eq '%') |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1851 | { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1852 | if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1853 | ERROR("need consistent spacing around '$op' $at\n" . |
| 1854 | $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1855 | } |
| 1856 | |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1857 | # A colon needs no spaces before when it is |
| 1858 | # terminating a case value or a label. |
| 1859 | } elsif ($opv eq ':C' || $opv eq ':L') { |
| 1860 | if ($ctx =~ /Wx./) { |
| 1861 | ERROR("space prohibited before that '$op' $at\n" . $hereptr); |
| 1862 | } |
| 1863 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1864 | # All the others need spaces both sides. |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1865 | } elsif ($ctx !~ /[EWC]x[CWE]/) { |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1866 | my $ok = 0; |
| 1867 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1868 | # Ignore email addresses <foo@bar> |
Andy Whitcroft | 1f65f94 | 2008-07-23 21:29:10 -0700 | [diff] [blame] | 1869 | if (($op eq '<' && |
| 1870 | $cc =~ /^\S+\@\S+>/) || |
| 1871 | ($op eq '>' && |
| 1872 | $ca =~ /<\S+\@\S+$/)) |
| 1873 | { |
| 1874 | $ok = 1; |
| 1875 | } |
| 1876 | |
| 1877 | # Ignore ?: |
| 1878 | if (($opv eq ':O' && $ca =~ /\?$/) || |
| 1879 | ($op eq '?' && $cc =~ /^:/)) { |
| 1880 | $ok = 1; |
| 1881 | } |
| 1882 | |
| 1883 | if ($ok == 0) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1884 | ERROR("spaces required around that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1885 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1886 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1887 | $off += length($elements[$n + 1]); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1888 | } |
| 1889 | } |
| 1890 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1891 | # check for multiple assignments |
| 1892 | if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1893 | CHK("multiple assignments should be avoided\n" . $herecurr); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1894 | } |
| 1895 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1896 | ## # check for multiple declarations, allowing for a function declaration |
| 1897 | ## # continuation. |
| 1898 | ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ && |
| 1899 | ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) { |
| 1900 | ## |
| 1901 | ## # Remove any bracketed sections to ensure we do not |
| 1902 | ## # falsly report the parameters of functions. |
| 1903 | ## my $ln = $line; |
| 1904 | ## while ($ln =~ s/\([^\(\)]*\)//g) { |
| 1905 | ## } |
| 1906 | ## if ($ln =~ /,/) { |
| 1907 | ## WARN("declaring multiple variables together should be avoided\n" . $herecurr); |
| 1908 | ## } |
| 1909 | ## } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1910 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1911 | #need space before brace following if, while, etc |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1912 | if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) || |
| 1913 | $line =~ /do{/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1914 | ERROR("space required before the open brace '{'\n" . $herecurr); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1915 | } |
| 1916 | |
| 1917 | # closing brace should have a space following it when it has anything |
| 1918 | # on the line |
| 1919 | if ($line =~ /}(?!(?:,|;|\)))\S/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1920 | ERROR("space required after that close brace '}'\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1921 | } |
| 1922 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1923 | # check spacing on square brackets |
| 1924 | if ($line =~ /\[\s/ && $line !~ /\[\s*$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1925 | ERROR("space prohibited after that open square bracket '['\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1926 | } |
| 1927 | if ($line =~ /\s\]/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1928 | ERROR("space prohibited before that close square bracket ']'\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1929 | } |
| 1930 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1931 | # check spacing on parentheses |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1932 | if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ && |
| 1933 | $line !~ /for\s*\(\s+;/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1934 | ERROR("space prohibited after that open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1935 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1936 | if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1937 | $line !~ /for\s*\(.*;\s+\)/ && |
| 1938 | $line !~ /:\s+\)/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1939 | ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1940 | } |
| 1941 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1942 | #goto labels aren't indented, allow a single space however |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1943 | if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1944 | !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1945 | WARN("labels should not be indented\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1946 | } |
| 1947 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1948 | # Return is not a function. |
| 1949 | if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { |
| 1950 | my $spacing = $1; |
| 1951 | my $value = $2; |
| 1952 | |
| 1953 | # Flatten any parentheses and braces |
Andy Whitcroft | fee61c4 | 2008-07-23 21:28:56 -0700 | [diff] [blame] | 1954 | $value =~ s/\)\(/\) \(/g; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1955 | while ($value =~ s/\([^\(\)]*\)/1/) { |
| 1956 | } |
| 1957 | |
| 1958 | if ($value =~ /^(?:$Ident|-?$Constant)$/) { |
| 1959 | ERROR("return is not a function, parentheses are not required\n" . $herecurr); |
| 1960 | |
| 1961 | } elsif ($spacing !~ /\s+/) { |
| 1962 | ERROR("space required before the open parenthesis '('\n" . $herecurr); |
| 1963 | } |
| 1964 | } |
| 1965 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1966 | # Need a space before open parenthesis after if, while etc |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1967 | if ($line=~/\b(if|while|for|switch)\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1968 | ERROR("space required before the open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1969 | } |
| 1970 | |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1971 | # Check for illegal assignment in if conditional -- and check for trailing |
| 1972 | # statements after the conditional. |
Andy Whitcroft | 170d3a2 | 2008-10-15 22:02:30 -0700 | [diff] [blame] | 1973 | if ($line =~ /do\s*(?!{)/) { |
| 1974 | my ($stat_next) = ctx_statement_block($line_nr_next, |
| 1975 | $remain_next, $off_next); |
| 1976 | $stat_next =~ s/\n./\n /g; |
| 1977 | ##print "stat<$stat> stat_next<$stat_next>\n"; |
| 1978 | |
| 1979 | if ($stat_next =~ /^\s*while\b/) { |
| 1980 | # If the statement carries leading newlines, |
| 1981 | # then count those as offsets. |
| 1982 | my ($whitespace) = |
| 1983 | ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s); |
| 1984 | my $offset = |
| 1985 | statement_rawlines($whitespace) - 1; |
| 1986 | |
| 1987 | $suppress_whiletrailers{$line_nr_next + |
| 1988 | $offset} = 1; |
| 1989 | } |
| 1990 | } |
| 1991 | if (!defined $suppress_whiletrailers{$linenr} && |
| 1992 | $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1993 | my ($s, $c) = ($stat, $cond); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1994 | |
| 1995 | if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1996 | ERROR("do not use assignment in if condition\n" . $herecurr); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1997 | } |
| 1998 | |
| 1999 | # Find out what is on the end of the line after the |
| 2000 | # conditional. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2001 | substr($s, 0, length($c), ''); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2002 | $s =~ s/\n.*//g; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2003 | $s =~ s/$;//g; # Remove any comments |
Andy Whitcroft | 5321016 | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 2004 | if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ && |
| 2005 | $c !~ /}\s*while\s*/) |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2006 | { |
Andy Whitcroft | bb44ad3 | 2008-10-15 22:02:34 -0700 | [diff] [blame] | 2007 | # Find out how long the conditional actually is. |
| 2008 | my @newlines = ($c =~ /\n/gs); |
| 2009 | my $cond_lines = 1 + $#newlines; |
| 2010 | |
| 2011 | my $stat_real = raw_line($linenr, $cond_lines); |
| 2012 | if (defined($stat_real) && $cond_lines > 1) { |
| 2013 | $stat_real = "[...]\n$stat_real"; |
| 2014 | } |
| 2015 | |
| 2016 | ERROR("trailing statements should be on next line\n" . $herecurr . $stat_real); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2017 | } |
| 2018 | } |
| 2019 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2020 | # Check for bitwise tests written as boolean |
| 2021 | if ($line =~ / |
| 2022 | (?: |
| 2023 | (?:\[|\(|\&\&|\|\|) |
| 2024 | \s*0[xX][0-9]+\s* |
| 2025 | (?:\&\&|\|\|) |
| 2026 | | |
| 2027 | (?:\&\&|\|\|) |
| 2028 | \s*0[xX][0-9]+\s* |
| 2029 | (?:\&\&|\|\||\)|\]) |
| 2030 | )/x) |
| 2031 | { |
| 2032 | WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr); |
| 2033 | } |
| 2034 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2035 | # if and else should not have general statements after it |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2036 | if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) { |
| 2037 | my $s = $1; |
| 2038 | $s =~ s/$;//g; # Remove any comments |
| 2039 | if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) { |
| 2040 | ERROR("trailing statements should be on next line\n" . $herecurr); |
| 2041 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2042 | } |
Andy Whitcroft | a1080bf | 2008-10-15 22:02:25 -0700 | [diff] [blame] | 2043 | # case and default should not have general statements after them |
| 2044 | if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && |
| 2045 | $line !~ /\G(?: |
Andy Whitcroft | 3fef12d | 2008-10-15 22:02:36 -0700 | [diff] [blame] | 2046 | (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$| |
Andy Whitcroft | a1080bf | 2008-10-15 22:02:25 -0700 | [diff] [blame] | 2047 | \s*return\s+ |
| 2048 | )/xg) |
| 2049 | { |
| 2050 | ERROR("trailing statements should be on next line\n" . $herecurr); |
| 2051 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2052 | |
| 2053 | # Check for }<nl>else {, these must be at the same |
| 2054 | # indent level to be relevant to each other. |
| 2055 | if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and |
| 2056 | $previndent == $indent) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2057 | ERROR("else should follow close brace '}'\n" . $hereprev); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2058 | } |
| 2059 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2060 | if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and |
| 2061 | $previndent == $indent) { |
| 2062 | my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0); |
| 2063 | |
| 2064 | # Find out what is on the end of the line after the |
| 2065 | # conditional. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2066 | substr($s, 0, length($c), ''); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2067 | $s =~ s/\n.*//g; |
| 2068 | |
| 2069 | if ($s =~ /^\s*;/) { |
| 2070 | ERROR("while should follow close brace '}'\n" . $hereprev); |
| 2071 | } |
| 2072 | } |
| 2073 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2074 | #studly caps, commented out until figure out how to distinguish between use of existing and adding new |
| 2075 | # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) { |
| 2076 | # print "No studly caps, use _\n"; |
| 2077 | # print "$herecurr"; |
| 2078 | # $clean = 0; |
| 2079 | # } |
| 2080 | |
| 2081 | #no spaces allowed after \ in define |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2082 | if ($line=~/\#\s*define.*\\\s$/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2083 | WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2084 | } |
| 2085 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2086 | #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2087 | if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) { |
Andy Whitcroft | e09dec4 | 2008-10-15 22:02:20 -0700 | [diff] [blame] | 2088 | my $file = "$1.h"; |
| 2089 | my $checkfile = "include/linux/$file"; |
| 2090 | if (-f "$root/$checkfile" && |
| 2091 | $realfile ne $checkfile && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2092 | $1 ne 'irq') |
| 2093 | { |
Andy Whitcroft | e09dec4 | 2008-10-15 22:02:20 -0700 | [diff] [blame] | 2094 | if ($realfile =~ m{^arch/}) { |
| 2095 | CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr); |
| 2096 | } else { |
| 2097 | WARN("Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr); |
| 2098 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2099 | } |
| 2100 | } |
| 2101 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2102 | # multi-statement macros should be enclosed in a do while loop, grab the |
| 2103 | # first statement and ensure its the whole macro if its not enclosed |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2104 | # in a known good container |
Andy Whitcroft | b8f96a31 | 2008-07-23 21:29:07 -0700 | [diff] [blame] | 2105 | if ($realfile !~ m@/vmlinux.lds.h$@ && |
| 2106 | $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) { |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2107 | my $ln = $linenr; |
| 2108 | my $cnt = $realcnt; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2109 | my ($off, $dstat, $dcond, $rest); |
| 2110 | my $ctx = ''; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2111 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2112 | my $args = defined($1); |
| 2113 | |
| 2114 | # Find the end of the macro and limit our statement |
| 2115 | # search to that. |
| 2116 | while ($cnt > 0 && defined $lines[$ln - 1] && |
| 2117 | $lines[$ln - 1] =~ /^(?:-|..*\\$)/) |
| 2118 | { |
| 2119 | $ctx .= $rawlines[$ln - 1] . "\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 2120 | $cnt-- if ($lines[$ln - 1] !~ /^-/); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2121 | $ln++; |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2122 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2123 | $ctx .= $rawlines[$ln - 1]; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2124 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2125 | ($dstat, $dcond, $ln, $cnt, $off) = |
| 2126 | ctx_statement_block($linenr, $ln - $linenr + 1, 0); |
| 2127 | #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 2128 | #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n"; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2129 | |
| 2130 | # Extract the remainder of the define (if any) and |
| 2131 | # rip off surrounding spaces, and trailing \'s. |
| 2132 | $rest = ''; |
Andy Whitcroft | 636d140 | 2008-10-15 22:02:18 -0700 | [diff] [blame] | 2133 | while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) { |
| 2134 | #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 2135 | if ($off != 0 || $lines[$ln - 1] !~ /^-/) { |
| 2136 | $rest .= substr($lines[$ln - 1], $off) . "\n"; |
| 2137 | $cnt--; |
| 2138 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2139 | $ln++; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2140 | $off = 0; |
| 2141 | } |
| 2142 | $rest =~ s/\\\n.//g; |
| 2143 | $rest =~ s/^\s*//s; |
| 2144 | $rest =~ s/\s*$//s; |
| 2145 | |
| 2146 | # Clean up the original statement. |
| 2147 | if ($args) { |
| 2148 | substr($dstat, 0, length($dcond), ''); |
| 2149 | } else { |
| 2150 | $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//; |
| 2151 | } |
Andy Whitcroft | 292f1a9 | 2008-07-23 21:29:11 -0700 | [diff] [blame] | 2152 | $dstat =~ s/$;//g; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2153 | $dstat =~ s/\\\n.//g; |
| 2154 | $dstat =~ s/^\s*//s; |
| 2155 | $dstat =~ s/\s*$//s; |
| 2156 | |
| 2157 | # Flatten any parentheses and braces |
Andy Whitcroft | bf30d6e | 2008-10-15 22:02:33 -0700 | [diff] [blame] | 2158 | while ($dstat =~ s/\([^\(\)]*\)/1/ || |
| 2159 | $dstat =~ s/\{[^\{\}]*\}/1/ || |
| 2160 | $dstat =~ s/\[[^\{\}]*\]/1/) |
| 2161 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2162 | } |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2163 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2164 | my $exceptions = qr{ |
| 2165 | $Declare| |
| 2166 | module_param_named| |
| 2167 | MODULE_PARAM_DESC| |
| 2168 | DECLARE_PER_CPU| |
| 2169 | DEFINE_PER_CPU| |
| 2170 | __typeof__\( |
| 2171 | }x; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 2172 | #print "REST<$rest>\n"; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2173 | if ($rest ne '') { |
| 2174 | if ($rest !~ /while\s*\(/ && |
| 2175 | $dstat !~ /$exceptions/) |
| 2176 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2177 | ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n"); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2178 | } |
| 2179 | |
| 2180 | } elsif ($ctx !~ /;/) { |
| 2181 | if ($dstat ne '' && |
| 2182 | $dstat !~ /^(?:$Ident|-?$Constant)$/ && |
| 2183 | $dstat !~ /$exceptions/ && |
Andy Whitcroft | b132e5d | 2008-10-15 22:02:31 -0700 | [diff] [blame] | 2184 | $dstat !~ /^\.$Ident\s*=/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2185 | $dstat =~ /$Operators/) |
| 2186 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2187 | ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n"); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 2188 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2189 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2190 | } |
| 2191 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2192 | # check for redundant bracing round if etc |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2193 | if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) { |
| 2194 | my ($level, $endln, @chunks) = |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2195 | ctx_statement_full($linenr, $realcnt, 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2196 | #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2197 | #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n"; |
| 2198 | if ($#chunks > 0 && $level == 0) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2199 | my $allowed = 0; |
| 2200 | my $seen = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2201 | my $herectx = $here . "\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2202 | my $ln = $linenr - 1; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2203 | for my $chunk (@chunks) { |
| 2204 | my ($cond, $block) = @{$chunk}; |
| 2205 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2206 | # If the condition carries leading newlines, then count those as offsets. |
| 2207 | my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s); |
| 2208 | my $offset = statement_rawlines($whitespace) - 1; |
| 2209 | |
| 2210 | #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n"; |
| 2211 | |
| 2212 | # We have looked at and allowed this specific line. |
| 2213 | $suppress_ifbraces{$ln + $offset} = 1; |
| 2214 | |
| 2215 | $herectx .= "$rawlines[$ln + $offset]\n[...]\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2216 | $ln += statement_rawlines($block) - 1; |
| 2217 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2218 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2219 | |
| 2220 | $seen++ if ($block =~ /^\s*{/); |
| 2221 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2222 | #print "cond<$cond> block<$block> allowed<$allowed>\n"; |
| 2223 | if (statement_lines($cond) > 1) { |
| 2224 | #print "APW: ALLOWED: cond<$cond>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2225 | $allowed = 1; |
| 2226 | } |
| 2227 | if ($block =~/\b(?:if|for|while)\b/) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2228 | #print "APW: ALLOWED: block<$block>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2229 | $allowed = 1; |
| 2230 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2231 | if (statement_block_size($block) > 1) { |
| 2232 | #print "APW: ALLOWED: lines block<$block>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2233 | $allowed = 1; |
| 2234 | } |
| 2235 | } |
| 2236 | if ($seen && !$allowed) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2237 | WARN("braces {} are not necessary for any arm of this statement\n" . $herectx); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2238 | } |
| 2239 | } |
| 2240 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2241 | if (!defined $suppress_ifbraces{$linenr - 1} && |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2242 | $line =~ /\b(if|while|for|else)\b/) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2243 | my $allowed = 0; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2244 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2245 | # Check the pre-context. |
| 2246 | if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { |
| 2247 | #print "APW: ALLOWED: pre<$1>\n"; |
| 2248 | $allowed = 1; |
| 2249 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2250 | |
| 2251 | my ($level, $endln, @chunks) = |
| 2252 | ctx_statement_full($linenr, $realcnt, $-[0]); |
| 2253 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2254 | # Check the condition. |
| 2255 | my ($cond, $block) = @{$chunks[0]}; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2256 | #print "CHECKING<$linenr> cond<$cond> block<$block>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2257 | if (defined $cond) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2258 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2259 | } |
| 2260 | if (statement_lines($cond) > 1) { |
| 2261 | #print "APW: ALLOWED: cond<$cond>\n"; |
| 2262 | $allowed = 1; |
| 2263 | } |
| 2264 | if ($block =~/\b(?:if|for|while)\b/) { |
| 2265 | #print "APW: ALLOWED: block<$block>\n"; |
| 2266 | $allowed = 1; |
| 2267 | } |
| 2268 | if (statement_block_size($block) > 1) { |
| 2269 | #print "APW: ALLOWED: lines block<$block>\n"; |
| 2270 | $allowed = 1; |
| 2271 | } |
| 2272 | # Check the post-context. |
| 2273 | if (defined $chunks[1]) { |
| 2274 | my ($cond, $block) = @{$chunks[1]}; |
| 2275 | if (defined $cond) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2276 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2277 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2278 | if ($block =~ /^\s*\{/) { |
| 2279 | #print "APW: ALLOWED: chunk-1 block<$block>\n"; |
| 2280 | $allowed = 1; |
| 2281 | } |
| 2282 | } |
| 2283 | if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) { |
| 2284 | my $herectx = $here . "\n";; |
Andy Whitcroft | f055663 | 2008-10-15 22:02:23 -0700 | [diff] [blame] | 2285 | my $cnt = statement_rawlines($block); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2286 | |
Andy Whitcroft | f055663 | 2008-10-15 22:02:23 -0700 | [diff] [blame] | 2287 | for (my $n = 0; $n < $cnt; $n++) { |
| 2288 | $herectx .= raw_line($linenr, $n) . "\n";; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2289 | } |
| 2290 | |
| 2291 | WARN("braces {} are not necessary for single statement blocks\n" . $herectx); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2292 | } |
| 2293 | } |
| 2294 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2295 | # don't include deprecated include files (uses RAW line) |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2296 | for my $inc (@dep_includes) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2297 | if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2298 | ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2299 | } |
| 2300 | } |
| 2301 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2302 | # don't use deprecated functions |
| 2303 | for my $func (@dep_functions) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2304 | if ($line =~ /\b$func\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2305 | ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2306 | } |
| 2307 | } |
| 2308 | |
| 2309 | # no volatiles please |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 2310 | my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; |
| 2311 | if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2312 | WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2313 | } |
| 2314 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2315 | # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated |
| 2316 | if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) { |
| 2317 | ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr); |
| 2318 | } |
| 2319 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2320 | # warn about #if 0 |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2321 | if ($line =~ /^.\s*\#\s*if\s+0\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2322 | CHK("if this code is redundant consider removing it\n" . |
| 2323 | $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2324 | } |
| 2325 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2326 | # check for needless kfree() checks |
| 2327 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { |
| 2328 | my $expr = $1; |
| 2329 | if ($line =~ /\bkfree\(\Q$expr\E\);/) { |
Wolfram Sang | 3c23214 | 2008-07-23 21:29:05 -0700 | [diff] [blame] | 2330 | WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2331 | } |
| 2332 | } |
Greg Kroah-Hartman | 4c432a8 | 2008-07-23 21:29:04 -0700 | [diff] [blame] | 2333 | # check for needless usb_free_urb() checks |
| 2334 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { |
| 2335 | my $expr = $1; |
| 2336 | if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) { |
| 2337 | WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev); |
| 2338 | } |
| 2339 | } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2340 | |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2341 | # warn about #ifdefs in C files |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2342 | # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { |
Andy Whitcroft | 00df344 | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2343 | # print "#ifdef in C files should be avoided\n"; |
| 2344 | # print "$herecurr"; |
| 2345 | # $clean = 0; |
| 2346 | # } |
| 2347 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2348 | # warn about spacing in #ifdefs |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2349 | if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) { |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2350 | ERROR("exactly one space required after that #$1\n" . $herecurr); |
| 2351 | } |
| 2352 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2353 | # check for spinlock_t definitions without a comment. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2354 | if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ || |
| 2355 | $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2356 | my $which = $1; |
| 2357 | if (!ctx_has_comment($first_line, $linenr)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2358 | CHK("$1 definition without comment\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2359 | } |
| 2360 | } |
| 2361 | # check for memory barriers without a comment. |
| 2362 | if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { |
| 2363 | if (!ctx_has_comment($first_line, $linenr)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2364 | CHK("memory barrier without comment\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2365 | } |
| 2366 | } |
| 2367 | # check of hardware specific defines |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2368 | if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2369 | CHK("architecture specific defines should be avoided\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2370 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2371 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2372 | # check the location of the inline attribute, that it is between |
| 2373 | # storage class and type. |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2374 | if ($line =~ /\b$Type\s+$Inline\b/ || |
| 2375 | $line =~ /\b$Inline\s+$Storage\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2376 | ERROR("inline keyword should sit between storage class and type\n" . $herecurr); |
| 2377 | } |
| 2378 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2379 | # Check for __inline__ and __inline, prefer inline |
| 2380 | if ($line =~ /\b(__inline__|__inline)\b/) { |
| 2381 | WARN("plain inline is preferred over $1\n" . $herecurr); |
| 2382 | } |
| 2383 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2384 | # check for new externs in .c files. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2385 | if ($realfile =~ /\.c$/ && defined $stat && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2386 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2387 | { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2388 | my $function_name = $1; |
| 2389 | my $paren_space = $2; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2390 | |
| 2391 | my $s = $stat; |
| 2392 | if (defined $cond) { |
| 2393 | substr($s, 0, length($cond), ''); |
| 2394 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2395 | if ($s =~ /^\s*;/ && |
| 2396 | $function_name ne 'uninitialized_var') |
| 2397 | { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2398 | WARN("externs should be avoided in .c files\n" . $herecurr); |
| 2399 | } |
| 2400 | |
| 2401 | if ($paren_space =~ /\n/) { |
| 2402 | WARN("arguments for function declarations should follow identifier\n" . $herecurr); |
| 2403 | } |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2404 | |
| 2405 | } elsif ($realfile =~ /\.c$/ && defined $stat && |
| 2406 | $stat =~ /^.\s*extern\s+/) |
| 2407 | { |
| 2408 | WARN("externs should be avoided in .c files\n" . $herecurr); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2409 | } |
| 2410 | |
| 2411 | # checks for new __setup's |
| 2412 | if ($rawline =~ /\b__setup\("([^"]*)"/) { |
| 2413 | my $name = $1; |
| 2414 | |
| 2415 | if (!grep(/$name/, @setup_docs)) { |
| 2416 | CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr); |
| 2417 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2418 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2419 | |
| 2420 | # check for pointless casting of kmalloc return |
| 2421 | if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) { |
| 2422 | WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr); |
| 2423 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2424 | |
| 2425 | # check for gcc specific __FUNCTION__ |
| 2426 | if ($line =~ /__FUNCTION__/) { |
| 2427 | WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); |
| 2428 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2429 | |
| 2430 | # check for semaphores used as mutexes |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2431 | if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2432 | WARN("mutexes are preferred for single holder semaphores\n" . $herecurr); |
| 2433 | } |
| 2434 | # check for semaphores used as mutexes |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2435 | if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2436 | WARN("consider using a completion\n" . $herecurr); |
| 2437 | } |
| 2438 | # recommend strict_strto* over simple_strto* |
| 2439 | if ($line =~ /\bsimple_(strto.*?)\s*\(/) { |
| 2440 | WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr); |
| 2441 | } |
Michael Ellerman | f3db663 | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 2442 | # check for __initcall(), use device_initcall() explicitly please |
| 2443 | if ($line =~ /^.\s*__initcall\s*\(/) { |
| 2444 | WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); |
| 2445 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2446 | |
| 2447 | # use of NR_CPUS is usually wrong |
| 2448 | # ignore definitions of NR_CPUS and usage to define arrays as likely right |
| 2449 | if ($line =~ /\bNR_CPUS\b/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2450 | $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ && |
| 2451 | $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ && |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2452 | $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ && |
| 2453 | $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ && |
| 2454 | $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/) |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2455 | { |
| 2456 | WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); |
| 2457 | } |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2458 | |
| 2459 | # check for %L{u,d,i} in strings |
| 2460 | my $string; |
| 2461 | while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) { |
| 2462 | $string = substr($rawline, $-[1], $+[1] - $-[1]); |
Andy Whitcroft | 2a1bc5d | 2008-10-15 22:02:23 -0700 | [diff] [blame] | 2463 | $string =~ s/%%/__/g; |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2464 | if ($string =~ /(?<!%)%L[udi]/) { |
| 2465 | WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr); |
| 2466 | last; |
| 2467 | } |
| 2468 | } |
Andy Whitcroft | 691d77b | 2009-01-06 14:41:16 -0800 | [diff] [blame] | 2469 | |
| 2470 | # whine mightly about in_atomic |
| 2471 | if ($line =~ /\bin_atomic\s*\(/) { |
| 2472 | if ($realfile =~ m@^drivers/@) { |
| 2473 | ERROR("do not use in_atomic in drivers\n" . $herecurr); |
| 2474 | } else { |
| 2475 | WARN("use of in_atomic() is incorrect outside core kernel code\n" . $herecurr); |
| 2476 | } |
| 2477 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2478 | } |
| 2479 | |
| 2480 | # If we have no input at all, then there is nothing to report on |
| 2481 | # so just keep quiet. |
| 2482 | if ($#rawlines == -1) { |
| 2483 | exit(0); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2484 | } |
| 2485 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2486 | # In mailback mode only produce a report in the negative, for |
| 2487 | # things that appear to be patches. |
| 2488 | if ($mailback && ($clean == 1 || !$is_patch)) { |
| 2489 | exit(0); |
| 2490 | } |
| 2491 | |
| 2492 | # This is not a patch, and we are are in 'no-patch' mode so |
| 2493 | # just keep quiet. |
| 2494 | if (!$chk_patch && !$is_patch) { |
| 2495 | exit(0); |
| 2496 | } |
| 2497 | |
| 2498 | if (!$is_patch) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2499 | ERROR("Does not appear to be a unified-diff format patch\n"); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2500 | } |
| 2501 | if ($is_patch && $chk_signoff && $signoff == 0) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2502 | ERROR("Missing Signed-off-by: line(s)\n"); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2503 | } |
| 2504 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2505 | print report_dump(); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2506 | if ($summary && !($clean == 1 && $quiet == 1)) { |
| 2507 | print "$filename " if ($summary_file); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2508 | print "total: $cnt_error errors, $cnt_warn warnings, " . |
| 2509 | (($check)? "$cnt_chk checks, " : "") . |
| 2510 | "$cnt_lines lines checked\n"; |
| 2511 | print "\n" if ($quiet == 0); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2512 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2513 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2514 | if ($clean == 1 && $quiet == 0) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2515 | print "$vname has no obvious style problems and is ready for submission.\n" |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2516 | } |
| 2517 | if ($clean == 0 && $quiet == 0) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2518 | print "$vname has style problems, please review. If any of these errors\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2519 | print "are false positives report them to the maintainer, see\n"; |
| 2520 | print "CHECKPATCH in MAINTAINERS.\n"; |
| 2521 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2522 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2523 | return $clean; |
| 2524 | } |