blob: 7cb53819778e6cb7d62787a62f4c124e28872d33 [file] [log] [blame]
Luca Ceresolif6fcefa2020-01-29 16:19:51 +01001================================
2I2C muxes and complex topologies
3================================
Peter Rosin2254d242016-05-04 22:15:30 +02004
Luca Ceresoli2f07c052020-01-29 16:19:29 +01005There are a couple of reasons for building more complex I2C topologies
6than a straight-forward I2C bus with one adapter and one or more devices.
Peter Rosin2254d242016-05-04 22:15:30 +02007
81. A mux may be needed on the bus to prevent address collisions.
9
102. The bus may be accessible from some external bus master, and arbitration
11 may be needed to determine if it is ok to access the bus.
12
133. A device (particularly RF tuners) may want to avoid the digital noise
Luca Ceresoli2f07c052020-01-29 16:19:29 +010014 from the I2C bus, at least most of the time, and sits behind a gate
Peter Rosin2254d242016-05-04 22:15:30 +020015 that has to be operated before the device can be accessed.
16
17Etc
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030018===
Peter Rosin2254d242016-05-04 22:15:30 +020019
Luca Ceresoli2f07c052020-01-29 16:19:29 +010020These constructs are represented as I2C adapter trees by Linux, where
Peter Rosin2254d242016-05-04 22:15:30 +020021each adapter has a parent adapter (except the root adapter) and zero or
22more child adapters. The root adapter is the actual adapter that issues
Luca Ceresoli2f07c052020-01-29 16:19:29 +010023I2C transfers, and all adapters with a parent are part of an "i2c-mux"
Peter Rosin2254d242016-05-04 22:15:30 +020024object (quoted, since it can also be an arbitrator or a gate).
25
26Depending of the particular mux driver, something happens when there is
Luca Ceresoli2f07c052020-01-29 16:19:29 +010027an I2C transfer on one of its child adapters. The mux driver can
Peter Rosin2254d242016-05-04 22:15:30 +020028obviously operate a mux, but it can also do arbitration with an external
29bus master or open a gate. The mux driver has two operations for this,
30select and deselect. select is called before the transfer and (the
31optional) deselect is called after the transfer.
32
33
34Locking
35=======
36
Luca Ceresoli2f07c052020-01-29 16:19:29 +010037There are two variants of locking available to I2C muxes, they can be
Peter Rosin2254d242016-05-04 22:15:30 +020038mux-locked or parent-locked muxes. As is evident from below, it can be
39useful to know if a mux is mux-locked or if it is parent-locked. The
40following list was correct at the time of writing:
41
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030042In drivers/i2c/muxes/:
43
44====================== =============================================
Peter Rosin2254d242016-05-04 22:15:30 +020045i2c-arb-gpio-challenge Parent-locked
46i2c-mux-gpio Normally parent-locked, mux-locked iff
47 all involved gpio pins are controlled by the
Luca Ceresoli2f07c052020-01-29 16:19:29 +010048 same I2C root adapter that they mux.
Peter Rosin234fa0a2017-08-02 11:48:46 +020049i2c-mux-gpmux Normally parent-locked, mux-locked iff
50 specified in device-tree.
51i2c-mux-ltc4306 Mux-locked
52i2c-mux-mlxcpld Parent-locked
Peter Rosin2254d242016-05-04 22:15:30 +020053i2c-mux-pca9541 Parent-locked
54i2c-mux-pca954x Parent-locked
55i2c-mux-pinctrl Normally parent-locked, mux-locked iff
56 all involved pinctrl devices are controlled
Luca Ceresoli2f07c052020-01-29 16:19:29 +010057 by the same I2C root adapter that they mux.
Peter Rosin2254d242016-05-04 22:15:30 +020058i2c-mux-reg Parent-locked
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030059====================== =============================================
Peter Rosin2254d242016-05-04 22:15:30 +020060
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030061In drivers/iio/:
62
63====================== =============================================
Peter Rosin234fa0a2017-08-02 11:48:46 +020064gyro/mpu3050 Mux-locked
Peter Rosin1ffcfaf2016-05-04 22:15:31 +020065imu/inv_mpu6050/ Mux-locked
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030066====================== =============================================
Peter Rosin2254d242016-05-04 22:15:30 +020067
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030068In drivers/media/:
69
70======================= =============================================
Peter Rosin234fa0a2017-08-02 11:48:46 +020071dvb-frontends/lgdt3306a Mux-locked
Peter Rosin2254d242016-05-04 22:15:30 +020072dvb-frontends/m88ds3103 Parent-locked
73dvb-frontends/rtl2830 Parent-locked
Peter Rosin1cf79db2016-05-04 22:15:33 +020074dvb-frontends/rtl2832 Mux-locked
Antti Palosaarie6d7ffc2016-05-04 22:15:32 +020075dvb-frontends/si2168 Mux-locked
Peter Rosin2254d242016-05-04 22:15:30 +020076usb/cx231xx/ Parent-locked
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030077======================= =============================================
Peter Rosin2254d242016-05-04 22:15:30 +020078
79
80Mux-locked muxes
81----------------
82
83Mux-locked muxes does not lock the entire parent adapter during the
84full select-transfer-deselect transaction, only the muxes on the parent
85adapter are locked. Mux-locked muxes are mostly interesting if the
Luca Ceresoli2f07c052020-01-29 16:19:29 +010086select and/or deselect operations must use I2C transfers to complete
Peter Rosin2254d242016-05-04 22:15:30 +020087their tasks. Since the parent adapter is not fully locked during the
Luca Ceresoli2f07c052020-01-29 16:19:29 +010088full transaction, unrelated I2C transfers may interleave the different
Peter Rosin2254d242016-05-04 22:15:30 +020089stages of the transaction. This has the benefit that the mux driver
90may be easier and cleaner to implement, but it has some caveats.
91
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -030092==== =====================================================================
Peter Rosin2254d242016-05-04 22:15:30 +020093ML1. If you build a topology with a mux-locked mux being the parent
94 of a parent-locked mux, this might break the expectation from the
95 parent-locked mux that the root adapter is locked during the
96 transaction.
97
98ML2. It is not safe to build arbitrary topologies with two (or more)
99 mux-locked muxes that are not siblings, when there are address
100 collisions between the devices on the child adapters of these
101 non-sibling muxes.
102
103 I.e. the select-transfer-deselect transaction targeting e.g. device
104 address 0x42 behind mux-one may be interleaved with a similar
105 operation targeting device address 0x42 behind mux-two. The
106 intension with such a topology would in this hypothetical example
107 be that mux-one and mux-two should not be selected simultaneously,
108 but mux-locked muxes do not guarantee that in all topologies.
109
110ML3. A mux-locked mux cannot be used by a driver for auto-closing
111 gates/muxes, i.e. something that closes automatically after a given
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100112 number (one, in most cases) of I2C transfers. Unrelated I2C transfers
Peter Rosin2254d242016-05-04 22:15:30 +0200113 may creep in and close prematurely.
114
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100115ML4. If any non-I2C operation in the mux driver changes the I2C mux state,
Peter Rosin2254d242016-05-04 22:15:30 +0200116 the driver has to lock the root adapter during that operation.
117 Otherwise garbage may appear on the bus as seen from devices
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100118 behind the mux, when an unrelated I2C transfer is in flight during
119 the non-I2C mux-changing operation.
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300120==== =====================================================================
Peter Rosin2254d242016-05-04 22:15:30 +0200121
122
123Mux-locked Example
124------------------
125
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300126
127::
128
Peter Rosin2254d242016-05-04 22:15:30 +0200129 .----------. .--------.
130 .--------. | mux- |-----| dev D1 |
131 | root |--+--| locked | '--------'
132 '--------' | | mux M1 |--. .--------.
133 | '----------' '--| dev D2 |
134 | .--------. '--------'
135 '--| dev D3 |
136 '--------'
137
138When there is an access to D1, this happens:
139
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100140 1. Someone issues an I2C transfer to D1.
Peter Rosin2254d242016-05-04 22:15:30 +0200141 2. M1 locks muxes on its parent (the root adapter in this case).
142 3. M1 calls ->select to ready the mux.
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100143 4. M1 (presumably) does some I2C transfers as part of its select.
144 These transfers are normal I2C transfers that locks the parent
Peter Rosin2254d242016-05-04 22:15:30 +0200145 adapter.
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100146 5. M1 feeds the I2C transfer from step 1 to its parent adapter as a
147 normal I2C transfer that locks the parent adapter.
Peter Rosin2254d242016-05-04 22:15:30 +0200148 6. M1 calls ->deselect, if it has one.
149 7. Same rules as in step 4, but for ->deselect.
150 8. M1 unlocks muxes on its parent.
151
152This means that accesses to D2 are lockout out for the full duration
153of the entire operation. But accesses to D3 are possibly interleaved
154at any point.
155
156
157Parent-locked muxes
158-------------------
159
160Parent-locked muxes lock the parent adapter during the full select-
161transfer-deselect transaction. The implication is that the mux driver
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100162has to ensure that any and all I2C transfers through that parent
163adapter during the transaction are unlocked I2C transfers (using e.g.
Peter Rosin2254d242016-05-04 22:15:30 +0200164__i2c_transfer), or a deadlock will follow. There are a couple of
165caveats.
166
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300167==== ====================================================================
Peter Rosin2254d242016-05-04 22:15:30 +0200168PL1. If you build a topology with a parent-locked mux being the child
169 of another mux, this might break a possible assumption from the
170 child mux that the root adapter is unused between its select op
171 and the actual transfer (e.g. if the child mux is auto-closing
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100172 and the parent mux issues I2C transfers as part of its select).
Peter Rosin2254d242016-05-04 22:15:30 +0200173 This is especially the case if the parent mux is mux-locked, but
174 it may also happen if the parent mux is parent-locked.
175
176PL2. If select/deselect calls out to other subsystems such as gpio,
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100177 pinctrl, regmap or iio, it is essential that any I2C transfers
Peter Rosin2254d242016-05-04 22:15:30 +0200178 caused by these subsystems are unlocked. This can be convoluted to
179 accomplish, maybe even impossible if an acceptably clean solution
180 is sought.
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300181==== ====================================================================
Peter Rosin2254d242016-05-04 22:15:30 +0200182
183
184Parent-locked Example
185---------------------
186
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300187::
188
Peter Rosin2254d242016-05-04 22:15:30 +0200189 .----------. .--------.
190 .--------. | parent- |-----| dev D1 |
191 | root |--+--| locked | '--------'
192 '--------' | | mux M1 |--. .--------.
193 | '----------' '--| dev D2 |
194 | .--------. '--------'
195 '--| dev D3 |
196 '--------'
197
198When there is an access to D1, this happens:
199
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100200 1. Someone issues an I2C transfer to D1.
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300201 2. M1 locks muxes on its parent (the root adapter in this case).
202 3. M1 locks its parent adapter.
203 4. M1 calls ->select to ready the mux.
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100204 5. If M1 does any I2C transfers (on this root adapter) as part of
205 its select, those transfers must be unlocked I2C transfers so
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300206 that they do not deadlock the root adapter.
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100207 6. M1 feeds the I2C transfer from step 1 to the root adapter as an
208 unlocked I2C transfer, so that it does not deadlock the parent
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300209 adapter.
210 7. M1 calls ->deselect, if it has one.
211 8. Same rules as in step 5, but for ->deselect.
212 9. M1 unlocks its parent adapter.
213 10. M1 unlocks muxes on its parent.
Peter Rosin2254d242016-05-04 22:15:30 +0200214
215
216This means that accesses to both D2 and D3 are locked out for the full
217duration of the entire operation.
218
219
220Complex Examples
221================
222
223Parent-locked mux as parent of parent-locked mux
224------------------------------------------------
225
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300226This is a useful topology, but it can be bad::
Peter Rosin2254d242016-05-04 22:15:30 +0200227
228 .----------. .----------. .--------.
229 .--------. | parent- |-----| parent- |-----| dev D1 |
230 | root |--+--| locked | | locked | '--------'
231 '--------' | | mux M1 |--. | mux M2 |--. .--------.
232 | '----------' | '----------' '--| dev D2 |
233 | .--------. | .--------. '--------'
234 '--| dev D4 | '--| dev D3 |
235 '--------' '--------'
236
237When any device is accessed, all other devices are locked out for
238the full duration of the operation (both muxes lock their parent,
239and specifically when M2 requests its parent to lock, M1 passes
240the buck to the root adapter).
241
242This topology is bad if M2 is an auto-closing mux and M1->select
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100243issues any unlocked I2C transfers on the root adapter that may leak
Peter Rosin2254d242016-05-04 22:15:30 +0200244through and be seen by the M2 adapter, thus closing M2 prematurely.
245
246
247Mux-locked mux as parent of mux-locked mux
248------------------------------------------
249
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300250This is a good topology::
Peter Rosin2254d242016-05-04 22:15:30 +0200251
252 .----------. .----------. .--------.
253 .--------. | mux- |-----| mux- |-----| dev D1 |
254 | root |--+--| locked | | locked | '--------'
255 '--------' | | mux M1 |--. | mux M2 |--. .--------.
256 | '----------' | '----------' '--| dev D2 |
257 | .--------. | .--------. '--------'
258 '--| dev D4 | '--| dev D3 |
259 '--------' '--------'
260
261When device D1 is accessed, accesses to D2 are locked out for the
262full duration of the operation (muxes on the top child adapter of M1
263are locked). But accesses to D3 and D4 are possibly interleaved at
264any point. Accesses to D3 locks out D1 and D2, but accesses to D4
265are still possibly interleaved.
266
267
268Mux-locked mux as parent of parent-locked mux
269---------------------------------------------
270
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300271This is probably a bad topology::
Peter Rosin2254d242016-05-04 22:15:30 +0200272
273 .----------. .----------. .--------.
274 .--------. | mux- |-----| parent- |-----| dev D1 |
275 | root |--+--| locked | | locked | '--------'
276 '--------' | | mux M1 |--. | mux M2 |--. .--------.
277 | '----------' | '----------' '--| dev D2 |
278 | .--------. | .--------. '--------'
279 '--| dev D4 | '--| dev D3 |
280 '--------' '--------'
281
282When device D1 is accessed, accesses to D2 and D3 are locked out
283for the full duration of the operation (M1 locks child muxes on the
284root adapter). But accesses to D4 are possibly interleaved at any
285point.
286
287This kind of topology is generally not suitable and should probably
288be avoided. The reason is that M2 probably assumes that there will
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100289be no I2C transfers during its calls to ->select and ->deselect, and
Peter Rosin2254d242016-05-04 22:15:30 +0200290if there are, any such transfers might appear on the slave side of M2
Luca Ceresoli2f07c052020-01-29 16:19:29 +0100291as partial I2C transfers, i.e. garbage or worse. This might cause
Peter Rosin2254d242016-05-04 22:15:30 +0200292device lockups and/or other problems.
293
294The topology is especially troublesome if M2 is an auto-closing
295mux. In that case, any interleaved accesses to D4 might close M2
Luca Ceresoli48ca3b72020-01-29 16:19:31 +0100296prematurely, as might any I2C transfers part of M1->select.
Peter Rosin2254d242016-05-04 22:15:30 +0200297
298But if M2 is not making the above stated assumption, and if M2 is not
299auto-closing, the topology is fine.
300
301
302Parent-locked mux as parent of mux-locked mux
303---------------------------------------------
304
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300305This is a good topology::
Peter Rosin2254d242016-05-04 22:15:30 +0200306
307 .----------. .----------. .--------.
308 .--------. | parent- |-----| mux- |-----| dev D1 |
309 | root |--+--| locked | | locked | '--------'
310 '--------' | | mux M1 |--. | mux M2 |--. .--------.
311 | '----------' | '----------' '--| dev D2 |
312 | .--------. | .--------. '--------'
313 '--| dev D4 | '--| dev D3 |
314 '--------' '--------'
315
316When D1 is accessed, accesses to D2 are locked out for the full
317duration of the operation (muxes on the top child adapter of M1
318are locked). Accesses to D3 and D4 are possibly interleaved at
319any point, just as is expected for mux-locked muxes.
320
321When D3 or D4 are accessed, everything else is locked out. For D3
322accesses, M1 locks the root adapter. For D4 accesses, the root
323adapter is locked directly.
324
325
326Two mux-locked sibling muxes
327----------------------------
328
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300329This is a good topology::
Peter Rosin2254d242016-05-04 22:15:30 +0200330
331 .--------.
332 .----------. .--| dev D1 |
333 | mux- |--' '--------'
334 .--| locked | .--------.
335 | | mux M1 |-----| dev D2 |
336 | '----------' '--------'
337 | .----------. .--------.
338 .--------. | | mux- |-----| dev D3 |
339 | root |--+--| locked | '--------'
340 '--------' | | mux M2 |--. .--------.
341 | '----------' '--| dev D4 |
342 | .--------. '--------'
343 '--| dev D5 |
344 '--------'
345
346When D1 is accessed, accesses to D2, D3 and D4 are locked out. But
347accesses to D5 may be interleaved at any time.
348
349
350Two parent-locked sibling muxes
351-------------------------------
352
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300353This is a good topology::
Peter Rosin2254d242016-05-04 22:15:30 +0200354
Peter Rosinf10a59e2016-11-10 15:03:21 +0100355 .--------.
Peter Rosin2254d242016-05-04 22:15:30 +0200356 .----------. .--| dev D1 |
357 | parent- |--' '--------'
358 .--| locked | .--------.
359 | | mux M1 |-----| dev D2 |
360 | '----------' '--------'
361 | .----------. .--------.
362 .--------. | | parent- |-----| dev D3 |
363 | root |--+--| locked | '--------'
364 '--------' | | mux M2 |--. .--------.
365 | '----------' '--| dev D4 |
366 | .--------. '--------'
367 '--| dev D5 |
368 '--------'
369
370When any device is accessed, accesses to all other devices are locked
371out.
372
373
374Mux-locked and parent-locked sibling muxes
375------------------------------------------
376
Mauro Carvalho Chehabccf988b2019-07-26 09:51:16 -0300377This is a good topology::
Peter Rosin2254d242016-05-04 22:15:30 +0200378
Peter Rosinf10a59e2016-11-10 15:03:21 +0100379 .--------.
Peter Rosin2254d242016-05-04 22:15:30 +0200380 .----------. .--| dev D1 |
381 | mux- |--' '--------'
382 .--| locked | .--------.
383 | | mux M1 |-----| dev D2 |
384 | '----------' '--------'
385 | .----------. .--------.
386 .--------. | | parent- |-----| dev D3 |
387 | root |--+--| locked | '--------'
388 '--------' | | mux M2 |--. .--------.
389 | '----------' '--| dev D4 |
390 | .--------. '--------'
391 '--| dev D5 |
392 '--------'
393
394When D1 or D2 are accessed, accesses to D3 and D4 are locked out while
395accesses to D5 may interleave. When D3 or D4 are accessed, accesses to
396all other devices are locked out.