blob: 478267a072d08056d3f9c46a3305f1d743017d54 [file] [log] [blame]
Thomas Gleixner1ccea772019-05-19 15:51:43 +02001// SPDX-License-Identifier: GPL-2.0-or-later
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002/*
3 * Copyright (C) 2015-2017 Josh Poimboeuf <jpoimboe@redhat.com>
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05004 */
5
6#include <string.h>
7#include <stdlib.h>
8
Peter Zijlstra43a45252018-01-16 17:16:32 +01009#include "builtin.h"
Matt Helsley0decf1f2020-05-19 13:55:33 -070010#include "cfi.h"
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050011#include "arch.h"
Matt Helsley0decf1f2020-05-19 13:55:33 -070012#include "check.h"
13#include "special.h"
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050014#include "warn.h"
Peter Zijlstra0f1441b2020-06-12 16:05:26 +020015#include "arch_elf.h"
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050016
17#include <linux/hashtable.h>
18#include <linux/kernel.h>
19
Josh Poimboeufe6da9562019-05-13 12:01:31 -050020#define FAKE_JUMP_OFFSET -1
21
Josh Poimboeuf87b512d2019-06-27 20:50:46 -050022#define C_JUMP_TABLE_SECTION ".rodata..c_jump_table"
23
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050024struct alternative {
25 struct list_head list;
26 struct instruction *insn;
Peter Zijlstra764eef42019-03-01 11:19:03 +010027 bool skip_orig;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050028};
29
30const char *objname;
Peter Zijlstraa3608f52020-03-25 15:34:50 +010031struct cfi_init_state initial_func_cfi;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050032
Josh Poimboeuf627fce12017-07-11 10:33:42 -050033struct instruction *find_insn(struct objtool_file *file,
34 struct section *sec, unsigned long offset)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050035{
36 struct instruction *insn;
37
Peter Zijlstra87ecb582020-03-16 15:47:27 +010038 hash_for_each_possible(file->insn_hash, insn, hash, sec_offset_hash(sec, offset)) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050039 if (insn->sec == sec && insn->offset == offset)
40 return insn;
Peter Zijlstra87ecb582020-03-16 15:47:27 +010041 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050042
43 return NULL;
44}
45
46static struct instruction *next_insn_same_sec(struct objtool_file *file,
47 struct instruction *insn)
48{
49 struct instruction *next = list_next_entry(insn, list);
50
Josh Poimboeufbaa41462017-06-28 10:11:07 -050051 if (!next || &next->list == &file->insn_list || next->sec != insn->sec)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050052 return NULL;
53
54 return next;
55}
56
Josh Poimboeuf13810432018-05-09 22:39:15 -050057static struct instruction *next_insn_same_func(struct objtool_file *file,
58 struct instruction *insn)
59{
60 struct instruction *next = list_next_entry(insn, list);
61 struct symbol *func = insn->func;
62
63 if (!func)
64 return NULL;
65
66 if (&next->list != &file->insn_list && next->func == func)
67 return next;
68
69 /* Check if we're already in the subfunction: */
70 if (func == func->cfunc)
71 return NULL;
72
73 /* Move to the subfunction: */
74 return find_insn(file, func->cfunc->sec, func->cfunc->offset);
75}
76
Josh Poimboeuf1119d262020-04-28 16:45:16 -050077static struct instruction *prev_insn_same_sym(struct objtool_file *file,
78 struct instruction *insn)
79{
80 struct instruction *prev = list_prev_entry(insn, list);
81
82 if (&prev->list != &file->insn_list && prev->func == insn->func)
83 return prev;
84
85 return NULL;
86}
87
Peter Zijlstraf0f70ad2020-03-10 18:27:24 +010088#define func_for_each_insn(file, func, insn) \
Josh Poimboeuf13810432018-05-09 22:39:15 -050089 for (insn = find_insn(file, func->sec, func->offset); \
90 insn; \
91 insn = next_insn_same_func(file, insn))
92
Peter Zijlstradbf4aeb2020-03-10 18:24:59 +010093#define sym_for_each_insn(file, sym, insn) \
94 for (insn = find_insn(file, sym->sec, sym->offset); \
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050095 insn && &insn->list != &file->insn_list && \
Peter Zijlstradbf4aeb2020-03-10 18:24:59 +010096 insn->sec == sym->sec && \
97 insn->offset < sym->offset + sym->len; \
Josh Poimboeufdcc914f2017-06-28 10:11:05 -050098 insn = list_next_entry(insn, list))
99
Peter Zijlstradbf4aeb2020-03-10 18:24:59 +0100100#define sym_for_each_insn_continue_reverse(file, sym, insn) \
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500101 for (insn = list_prev_entry(insn, list); \
102 &insn->list != &file->insn_list && \
Peter Zijlstradbf4aeb2020-03-10 18:24:59 +0100103 insn->sec == sym->sec && insn->offset >= sym->offset; \
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500104 insn = list_prev_entry(insn, list))
105
106#define sec_for_each_insn_from(file, insn) \
107 for (; insn; insn = next_insn_same_sec(file, insn))
108
Josh Poimboeufbaa41462017-06-28 10:11:07 -0500109#define sec_for_each_insn_continue(file, insn) \
110 for (insn = next_insn_same_sec(file, insn); insn; \
111 insn = next_insn_same_sec(file, insn))
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500112
Josh Poimboeufa2296142020-02-10 12:32:39 -0600113static bool is_static_jump(struct instruction *insn)
114{
115 return insn->type == INSN_JUMP_CONDITIONAL ||
116 insn->type == INSN_JUMP_UNCONDITIONAL;
117}
118
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -0500119static bool is_sibling_call(struct instruction *insn)
120{
121 /* An indirect jump is either a sibling call or a jump to a table. */
122 if (insn->type == INSN_JUMP_DYNAMIC)
123 return list_empty(&insn->alts);
124
Josh Poimboeufa2296142020-02-10 12:32:39 -0600125 if (!is_static_jump(insn))
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -0500126 return false;
127
128 /* add_jump_destinations() sets insn->call_dest for sibling calls. */
129 return !!insn->call_dest;
130}
131
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500132/*
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500133 * This checks to see if the given function is a "noreturn" function.
134 *
135 * For global functions which are outside the scope of this object file, we
136 * have to keep a manual list of them.
137 *
138 * For local functions, we have to detect them manually by simply looking for
139 * the lack of a return instruction.
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500140 */
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500141static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
142 int recursion)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500143{
144 int i;
145 struct instruction *insn;
146 bool empty = true;
147
148 /*
149 * Unfortunately these have to be hard coded because the noreturn
150 * attribute isn't provided in ELF data.
151 */
152 static const char * const global_noreturns[] = {
153 "__stack_chk_fail",
154 "panic",
155 "do_exit",
156 "do_task_dead",
157 "__module_put_and_exit",
158 "complete_and_exit",
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500159 "__reiserfs_panic",
160 "lbug_with_loc",
161 "fortify_panic",
Kees Cookb394d462018-01-10 14:22:38 -0800162 "usercopy_abort",
Josh Poimboeuf684fb242018-06-19 10:47:50 -0500163 "machine_real_restart",
Josh Poimboeuf4fa5ecd2019-04-04 12:17:35 -0500164 "rewind_stack_do_exit",
Brendan Higgins33adf802019-09-23 02:02:38 -0700165 "kunit_try_catch_throw",
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500166 };
167
Josh Poimboeufc9bab222019-07-17 20:36:51 -0500168 if (!func)
169 return false;
170
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500171 if (func->bind == STB_WEAK)
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500172 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500173
174 if (func->bind == STB_GLOBAL)
175 for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
176 if (!strcmp(func->name, global_noreturns[i]))
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500177 return true;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500178
Josh Poimboeuf13810432018-05-09 22:39:15 -0500179 if (!func->len)
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500180 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500181
Josh Poimboeuf13810432018-05-09 22:39:15 -0500182 insn = find_insn(file, func->sec, func->offset);
183 if (!insn->func)
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500184 return false;
Josh Poimboeuf13810432018-05-09 22:39:15 -0500185
Peter Zijlstraf0f70ad2020-03-10 18:27:24 +0100186 func_for_each_insn(file, func, insn) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500187 empty = false;
188
189 if (insn->type == INSN_RETURN)
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500190 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500191 }
192
193 if (empty)
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500194 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500195
196 /*
197 * A function can have a sibling call instead of a return. In that
198 * case, the function's dead-end status depends on whether the target
199 * of the sibling call returns.
200 */
Peter Zijlstraf0f70ad2020-03-10 18:27:24 +0100201 func_for_each_insn(file, func, insn) {
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -0500202 if (is_sibling_call(insn)) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500203 struct instruction *dest = insn->jump_dest;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500204
205 if (!dest)
206 /* sibling call to another file */
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500207 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500208
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -0500209 /* local sibling call */
210 if (recursion == 5) {
211 /*
212 * Infinite recursion: two functions have
213 * sibling calls to each other. This is a very
214 * rare case. It means they aren't dead ends.
215 */
216 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500217 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500218
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -0500219 return __dead_end_function(file, dest->func, recursion+1);
220 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500221 }
222
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500223 return true;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500224}
225
Josh Poimboeuf8e25c9f2019-07-17 20:36:50 -0500226static bool dead_end_function(struct objtool_file *file, struct symbol *func)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500227{
228 return __dead_end_function(file, func, 0);
229}
230
Peter Zijlstrae7c02192020-03-25 14:04:45 +0100231static void init_cfi_state(struct cfi_state *cfi)
Josh Poimboeufbaa41462017-06-28 10:11:07 -0500232{
233 int i;
234
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -0500235 for (i = 0; i < CFI_NUM_REGS; i++) {
Peter Zijlstrae7c02192020-03-25 14:04:45 +0100236 cfi->regs[i].base = CFI_UNDEFINED;
237 cfi->vals[i].base = CFI_UNDEFINED;
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -0500238 }
Peter Zijlstrae7c02192020-03-25 14:04:45 +0100239 cfi->cfa.base = CFI_UNDEFINED;
240 cfi->drap_reg = CFI_UNDEFINED;
241 cfi->drap_offset = -1;
242}
243
Peter Zijlstra932f8e92020-03-23 18:26:03 +0100244static void init_insn_state(struct insn_state *state, struct section *sec)
Peter Zijlstrae7c02192020-03-25 14:04:45 +0100245{
246 memset(state, 0, sizeof(*state));
247 init_cfi_state(&state->cfi);
Peter Zijlstra932f8e92020-03-23 18:26:03 +0100248
249 /*
250 * We need the full vmlinux for noinstr validation, otherwise we can
251 * not correctly determine insn->call_dest->sec (external symbols do
252 * not have a section).
253 */
254 if (vmlinux && sec)
255 state->noinstr = sec->noinstr;
Josh Poimboeufbaa41462017-06-28 10:11:07 -0500256}
257
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500258/*
259 * Call the arch-specific instruction decoder for all the instructions and add
260 * them to the global instruction list.
261 */
262static int decode_instructions(struct objtool_file *file)
263{
264 struct section *sec;
265 struct symbol *func;
266 unsigned long offset;
267 struct instruction *insn;
Peter Zijlstra1e11f3f2020-03-12 09:26:29 +0100268 unsigned long nr_insns = 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500269 int ret;
270
Josh Poimboeufbaa41462017-06-28 10:11:07 -0500271 for_each_sec(file, sec) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500272
273 if (!(sec->sh.sh_flags & SHF_EXECINSTR))
274 continue;
275
Josh Poimboeuf627fce12017-07-11 10:33:42 -0500276 if (strcmp(sec->name, ".altinstr_replacement") &&
277 strcmp(sec->name, ".altinstr_aux") &&
278 strncmp(sec->name, ".discard.", 9))
279 sec->text = true;
280
Thomas Gleixner0cc9ac8d2020-03-25 17:18:17 +0100281 if (!strcmp(sec->name, ".noinstr.text") ||
282 !strcmp(sec->name, ".entry.text"))
Peter Zijlstrac4a33932020-03-10 18:57:41 +0100283 sec->noinstr = true;
284
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500285 for (offset = 0; offset < sec->len; offset += insn->len) {
286 insn = malloc(sizeof(*insn));
Josh Poimboeufbaa41462017-06-28 10:11:07 -0500287 if (!insn) {
288 WARN("malloc failed");
289 return -1;
290 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500291 memset(insn, 0, sizeof(*insn));
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500292 INIT_LIST_HEAD(&insn->alts);
Julien Thierry65ea47d2020-03-27 15:28:47 +0000293 INIT_LIST_HEAD(&insn->stack_ops);
Peter Zijlstrae7c02192020-03-25 14:04:45 +0100294 init_cfi_state(&insn->cfi);
Josh Poimboeufbaa41462017-06-28 10:11:07 -0500295
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500296 insn->sec = sec;
297 insn->offset = offset;
298
299 ret = arch_decode_instruction(file->elf, sec, offset,
300 sec->len - offset,
301 &insn->len, &insn->type,
Josh Poimboeufbaa41462017-06-28 10:11:07 -0500302 &insn->immediate,
Julien Thierry65ea47d2020-03-27 15:28:47 +0000303 &insn->stack_ops);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500304 if (ret)
Kamalesh Babulalb7037982017-10-19 11:27:24 -0500305 goto err;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500306
Peter Zijlstra87ecb582020-03-16 15:47:27 +0100307 hash_add(file->insn_hash, &insn->hash, sec_offset_hash(sec, insn->offset));
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500308 list_add_tail(&insn->list, &file->insn_list);
Peter Zijlstra1e11f3f2020-03-12 09:26:29 +0100309 nr_insns++;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500310 }
311
312 list_for_each_entry(func, &sec->symbol_list, list) {
Josh Poimboeufe10cd8f2019-07-17 20:36:48 -0500313 if (func->type != STT_FUNC || func->alias != func)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500314 continue;
315
316 if (!find_insn(file, sec, func->offset)) {
317 WARN("%s(): can't find starting instruction",
318 func->name);
319 return -1;
320 }
321
Peter Zijlstradbf4aeb2020-03-10 18:24:59 +0100322 sym_for_each_insn(file, func, insn)
Josh Poimboeufe10cd8f2019-07-17 20:36:48 -0500323 insn->func = func;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500324 }
325 }
326
Peter Zijlstra1e11f3f2020-03-12 09:26:29 +0100327 if (stats)
328 printf("nr_insns: %lu\n", nr_insns);
329
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500330 return 0;
Kamalesh Babulalb7037982017-10-19 11:27:24 -0500331
332err:
333 free(insn);
334 return ret;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500335}
336
Sami Tolvanen6b5dd712020-04-21 15:08:43 -0700337static struct instruction *find_last_insn(struct objtool_file *file,
338 struct section *sec)
339{
340 struct instruction *insn = NULL;
341 unsigned int offset;
342 unsigned int end = (sec->len > 10) ? sec->len - 10 : 0;
343
344 for (offset = sec->len - 1; offset >= end && !insn; offset--)
345 insn = find_insn(file, sec, offset);
346
347 return insn;
348}
349
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500350/*
Josh Poimboeuf649ea4d2017-07-27 15:56:53 -0500351 * Mark "ud2" instructions and manually annotated dead ends.
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500352 */
353static int add_dead_ends(struct objtool_file *file)
354{
355 struct section *sec;
356 struct rela *rela;
357 struct instruction *insn;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500358
Josh Poimboeuf649ea4d2017-07-27 15:56:53 -0500359 /*
360 * By default, "ud2" is a dead end unless otherwise annotated, because
361 * GCC 7 inserts it for certain divide-by-zero cases.
362 */
363 for_each_insn(file, insn)
364 if (insn->type == INSN_BUG)
365 insn->dead_end = true;
366
367 /*
368 * Check for manually annotated dead ends.
369 */
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500370 sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
371 if (!sec)
Josh Poimboeuf649ea4d2017-07-27 15:56:53 -0500372 goto reachable;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500373
374 list_for_each_entry(rela, &sec->rela_list, list) {
375 if (rela->sym->type != STT_SECTION) {
376 WARN("unexpected relocation symbol type in %s", sec->name);
377 return -1;
378 }
379 insn = find_insn(file, rela->sym->sec, rela->addend);
380 if (insn)
381 insn = list_prev_entry(insn, list);
382 else if (rela->addend == rela->sym->sec->len) {
Sami Tolvanen6b5dd712020-04-21 15:08:43 -0700383 insn = find_last_insn(file, rela->sym->sec);
384 if (!insn) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500385 WARN("can't find unreachable insn at %s+0x%x",
386 rela->sym->sec->name, rela->addend);
387 return -1;
388 }
389 } else {
390 WARN("can't find unreachable insn at %s+0x%x",
391 rela->sym->sec->name, rela->addend);
392 return -1;
393 }
394
395 insn->dead_end = true;
396 }
397
Josh Poimboeuf649ea4d2017-07-27 15:56:53 -0500398reachable:
399 /*
400 * These manually annotated reachable checks are needed for GCC 4.4,
401 * where the Linux unreachable() macro isn't supported. In that case
402 * GCC doesn't know the "ud2" is fatal, so it generates code as if it's
403 * not a dead end.
404 */
405 sec = find_section_by_name(file->elf, ".rela.discard.reachable");
406 if (!sec)
407 return 0;
408
409 list_for_each_entry(rela, &sec->rela_list, list) {
410 if (rela->sym->type != STT_SECTION) {
411 WARN("unexpected relocation symbol type in %s", sec->name);
412 return -1;
413 }
414 insn = find_insn(file, rela->sym->sec, rela->addend);
415 if (insn)
416 insn = list_prev_entry(insn, list);
417 else if (rela->addend == rela->sym->sec->len) {
Sami Tolvanen6b5dd712020-04-21 15:08:43 -0700418 insn = find_last_insn(file, rela->sym->sec);
419 if (!insn) {
Josh Poimboeuf649ea4d2017-07-27 15:56:53 -0500420 WARN("can't find reachable insn at %s+0x%x",
421 rela->sym->sec->name, rela->addend);
422 return -1;
423 }
424 } else {
425 WARN("can't find reachable insn at %s+0x%x",
426 rela->sym->sec->name, rela->addend);
427 return -1;
428 }
429
430 insn->dead_end = false;
431 }
432
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500433 return 0;
434}
435
436/*
437 * Warnings shouldn't be reported for ignored functions.
438 */
439static void add_ignores(struct objtool_file *file)
440{
441 struct instruction *insn;
442 struct section *sec;
443 struct symbol *func;
Peter Zijlstraaaf5c622019-02-27 14:04:13 +0100444 struct rela *rela;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500445
Peter Zijlstraaaf5c622019-02-27 14:04:13 +0100446 sec = find_section_by_name(file->elf, ".rela.discard.func_stack_frame_non_standard");
447 if (!sec)
448 return;
449
450 list_for_each_entry(rela, &sec->rela_list, list) {
451 switch (rela->sym->type) {
452 case STT_FUNC:
453 func = rela->sym;
454 break;
455
456 case STT_SECTION:
Josh Poimboeuf7acfe532020-02-17 21:41:54 -0600457 func = find_func_by_offset(rela->sym->sec, rela->addend);
458 if (!func)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500459 continue;
Peter Zijlstraaaf5c622019-02-27 14:04:13 +0100460 break;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500461
Peter Zijlstraaaf5c622019-02-27 14:04:13 +0100462 default:
463 WARN("unexpected relocation symbol type in %s: %d", sec->name, rela->sym->type);
464 continue;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500465 }
Peter Zijlstraaaf5c622019-02-27 14:04:13 +0100466
Peter Zijlstraf0f70ad2020-03-10 18:27:24 +0100467 func_for_each_insn(file, func, insn)
Peter Zijlstraaaf5c622019-02-27 14:04:13 +0100468 insn->ignore = true;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500469 }
470}
471
472/*
Peter Zijlstraea242132019-02-25 12:50:09 +0100473 * This is a whitelist of functions that is allowed to be called with AC set.
474 * The list is meant to be minimal and only contains compiler instrumentation
475 * ABI and a few functions used to implement *_{to,from}_user() functions.
476 *
477 * These functions must not directly change AC, but may PUSHF/POPF.
478 */
479static const char *uaccess_safe_builtin[] = {
480 /* KASAN */
481 "kasan_report",
482 "check_memory_region",
483 /* KASAN out-of-line */
484 "__asan_loadN_noabort",
485 "__asan_load1_noabort",
486 "__asan_load2_noabort",
487 "__asan_load4_noabort",
488 "__asan_load8_noabort",
489 "__asan_load16_noabort",
490 "__asan_storeN_noabort",
491 "__asan_store1_noabort",
492 "__asan_store2_noabort",
493 "__asan_store4_noabort",
494 "__asan_store8_noabort",
495 "__asan_store16_noabort",
496 /* KASAN in-line */
497 "__asan_report_load_n_noabort",
498 "__asan_report_load1_noabort",
499 "__asan_report_load2_noabort",
500 "__asan_report_load4_noabort",
501 "__asan_report_load8_noabort",
502 "__asan_report_load16_noabort",
503 "__asan_report_store_n_noabort",
504 "__asan_report_store1_noabort",
505 "__asan_report_store2_noabort",
506 "__asan_report_store4_noabort",
507 "__asan_report_store8_noabort",
508 "__asan_report_store16_noabort",
Marco Elver5f5c9712019-11-14 19:02:57 +0100509 /* KCSAN */
Marco Elver99676832020-03-25 17:41:57 +0100510 "__kcsan_check_access",
Marco Elver5f5c9712019-11-14 19:02:57 +0100511 "kcsan_found_watchpoint",
512 "kcsan_setup_watchpoint",
Marco Elver99676832020-03-25 17:41:57 +0100513 "kcsan_check_scoped_accesses",
Marco Elver50a19ad2020-04-24 17:47:30 +0200514 "kcsan_disable_current",
515 "kcsan_enable_current_nowarn",
Marco Elver5f5c9712019-11-14 19:02:57 +0100516 /* KCSAN/TSAN */
517 "__tsan_func_entry",
518 "__tsan_func_exit",
519 "__tsan_read_range",
520 "__tsan_write_range",
521 "__tsan_read1",
522 "__tsan_read2",
523 "__tsan_read4",
524 "__tsan_read8",
525 "__tsan_read16",
526 "__tsan_write1",
527 "__tsan_write2",
528 "__tsan_write4",
529 "__tsan_write8",
530 "__tsan_write16",
Peter Zijlstraea242132019-02-25 12:50:09 +0100531 /* KCOV */
532 "write_comp_data",
Josh Poimboeufae033f02020-04-29 14:09:04 -0500533 "check_kcov_mode",
Peter Zijlstraea242132019-02-25 12:50:09 +0100534 "__sanitizer_cov_trace_pc",
535 "__sanitizer_cov_trace_const_cmp1",
536 "__sanitizer_cov_trace_const_cmp2",
537 "__sanitizer_cov_trace_const_cmp4",
538 "__sanitizer_cov_trace_const_cmp8",
539 "__sanitizer_cov_trace_cmp1",
540 "__sanitizer_cov_trace_cmp2",
541 "__sanitizer_cov_trace_cmp4",
542 "__sanitizer_cov_trace_cmp8",
Al Viro36b1c702020-02-16 13:07:49 -0500543 "__sanitizer_cov_trace_switch",
Peter Zijlstraea242132019-02-25 12:50:09 +0100544 /* UBSAN */
545 "ubsan_type_mismatch_common",
546 "__ubsan_handle_type_mismatch",
547 "__ubsan_handle_type_mismatch_v1",
Peter Zijlstra9a50dca2019-10-21 15:11:49 +0200548 "__ubsan_handle_shift_out_of_bounds",
Peter Zijlstraea242132019-02-25 12:50:09 +0100549 /* misc */
550 "csum_partial_copy_generic",
551 "__memcpy_mcsafe",
Josh Poimboeufa7e47f22019-07-17 20:36:46 -0500552 "mcsafe_handle_tail",
Peter Zijlstraea242132019-02-25 12:50:09 +0100553 "ftrace_likely_update", /* CONFIG_TRACE_BRANCH_PROFILING */
554 NULL
555};
556
557static void add_uaccess_safe(struct objtool_file *file)
558{
559 struct symbol *func;
560 const char **name;
561
562 if (!uaccess)
563 return;
564
565 for (name = uaccess_safe_builtin; *name; name++) {
566 func = find_symbol_by_name(file->elf, *name);
567 if (!func)
568 continue;
569
Josh Poimboeufe10cd8f2019-07-17 20:36:48 -0500570 func->uaccess_safe = true;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500571 }
572}
573
574/*
Josh Poimboeuf258c7602018-01-11 21:46:24 +0000575 * FIXME: For now, just ignore any alternatives which add retpolines. This is
576 * a temporary hack, as it doesn't allow ORC to unwind from inside a retpoline.
577 * But it at least allows objtool to understand the control flow *around* the
578 * retpoline.
579 */
Peter Zijlstraff05ab22019-03-18 14:33:07 +0100580static int add_ignore_alternatives(struct objtool_file *file)
Josh Poimboeuf258c7602018-01-11 21:46:24 +0000581{
582 struct section *sec;
583 struct rela *rela;
584 struct instruction *insn;
585
Peter Zijlstraff05ab22019-03-18 14:33:07 +0100586 sec = find_section_by_name(file->elf, ".rela.discard.ignore_alts");
Josh Poimboeuf258c7602018-01-11 21:46:24 +0000587 if (!sec)
588 return 0;
589
590 list_for_each_entry(rela, &sec->rela_list, list) {
591 if (rela->sym->type != STT_SECTION) {
592 WARN("unexpected relocation symbol type in %s", sec->name);
593 return -1;
594 }
595
596 insn = find_insn(file, rela->sym->sec, rela->addend);
597 if (!insn) {
Peter Zijlstraff05ab22019-03-18 14:33:07 +0100598 WARN("bad .discard.ignore_alts entry");
Josh Poimboeuf258c7602018-01-11 21:46:24 +0000599 return -1;
600 }
601
602 insn->ignore_alts = true;
603 }
604
605 return 0;
606}
607
608/*
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500609 * Find the destination instructions for all jumps.
610 */
611static int add_jump_destinations(struct objtool_file *file)
612{
613 struct instruction *insn;
614 struct rela *rela;
615 struct section *dest_sec;
616 unsigned long dest_off;
617
618 for_each_insn(file, insn) {
Josh Poimboeufa2296142020-02-10 12:32:39 -0600619 if (!is_static_jump(insn))
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500620 continue;
621
Josh Poimboeufe6da9562019-05-13 12:01:31 -0500622 if (insn->ignore || insn->offset == FAKE_JUMP_OFFSET)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500623 continue;
624
Peter Zijlstra8b5fa6b2020-03-12 11:23:36 +0100625 rela = find_rela_by_dest_range(file->elf, insn->sec,
626 insn->offset, insn->len);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500627 if (!rela) {
628 dest_sec = insn->sec;
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000629 dest_off = arch_jump_destination(insn);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500630 } else if (rela->sym->type == STT_SECTION) {
631 dest_sec = rela->sym->sec;
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000632 dest_off = arch_dest_rela_offset(rela->addend);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500633 } else if (rela->sym->sec->idx) {
634 dest_sec = rela->sym->sec;
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000635 dest_off = rela->sym->sym.st_value +
636 arch_dest_rela_offset(rela->addend);
Josh Poimboeuf39b73532018-01-11 21:46:23 +0000637 } else if (strstr(rela->sym->name, "_indirect_thunk_")) {
638 /*
639 * Retpoline jumps are really dynamic jumps in
640 * disguise, so convert them accordingly.
641 */
Josh Poimboeufb68b9902019-07-17 20:36:57 -0500642 if (insn->type == INSN_JUMP_UNCONDITIONAL)
643 insn->type = INSN_JUMP_DYNAMIC;
644 else
645 insn->type = INSN_JUMP_DYNAMIC_CONDITIONAL;
646
Peter Zijlstrab5bc2232018-01-16 10:24:06 +0100647 insn->retpoline_safe = true;
Josh Poimboeuf39b73532018-01-11 21:46:23 +0000648 continue;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500649 } else {
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -0500650 /* external sibling call */
Peter Zijlstra54262aa2019-03-06 12:58:15 +0100651 insn->call_dest = rela->sym;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500652 continue;
653 }
654
655 insn->jump_dest = find_insn(file, dest_sec, dest_off);
656 if (!insn->jump_dest) {
657
658 /*
659 * This is a special case where an alt instruction
660 * jumps past the end of the section. These are
661 * handled later in handle_group_alt().
662 */
663 if (!strcmp(insn->sec->name, ".altinstr_replacement"))
664 continue;
665
666 WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
667 insn->sec, insn->offset, dest_sec->name,
668 dest_off);
669 return -1;
670 }
Josh Poimboeufcd778492018-06-01 07:23:51 -0500671
672 /*
Peter Zijlstra54262aa2019-03-06 12:58:15 +0100673 * Cross-function jump.
Josh Poimboeufcd778492018-06-01 07:23:51 -0500674 */
675 if (insn->func && insn->jump_dest->func &&
Peter Zijlstra54262aa2019-03-06 12:58:15 +0100676 insn->func != insn->jump_dest->func) {
677
678 /*
679 * For GCC 8+, create parent/child links for any cold
680 * subfunctions. This is _mostly_ redundant with a
681 * similar initialization in read_symbols().
682 *
683 * If a function has aliases, we want the *first* such
684 * function in the symbol table to be the subfunction's
685 * parent. In that case we overwrite the
686 * initialization done in read_symbols().
687 *
688 * However this code can't completely replace the
689 * read_symbols() code because this doesn't detect the
690 * case where the parent function's only reference to a
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -0500691 * subfunction is through a jump table.
Peter Zijlstra54262aa2019-03-06 12:58:15 +0100692 */
693 if (!strstr(insn->func->name, ".cold.") &&
694 strstr(insn->jump_dest->func->name, ".cold.")) {
695 insn->func->cfunc = insn->jump_dest->func;
696 insn->jump_dest->func->pfunc = insn->func;
697
698 } else if (insn->jump_dest->func->pfunc != insn->func->pfunc &&
699 insn->jump_dest->offset == insn->jump_dest->func->offset) {
700
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -0500701 /* internal sibling call */
Peter Zijlstra54262aa2019-03-06 12:58:15 +0100702 insn->call_dest = insn->jump_dest->func;
Peter Zijlstra54262aa2019-03-06 12:58:15 +0100703 }
Josh Poimboeufcd778492018-06-01 07:23:51 -0500704 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500705 }
706
707 return 0;
708}
709
Alexandre Chartre8aa8eb22020-04-14 12:36:12 +0200710static void remove_insn_ops(struct instruction *insn)
711{
712 struct stack_op *op, *tmp;
713
714 list_for_each_entry_safe(op, tmp, &insn->stack_ops, list) {
715 list_del(&op->list);
716 free(op);
717 }
718}
719
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500720/*
721 * Find the destination instructions for all calls.
722 */
723static int add_call_destinations(struct objtool_file *file)
724{
725 struct instruction *insn;
726 unsigned long dest_off;
727 struct rela *rela;
728
729 for_each_insn(file, insn) {
730 if (insn->type != INSN_CALL)
731 continue;
732
Peter Zijlstra8b5fa6b2020-03-12 11:23:36 +0100733 rela = find_rela_by_dest_range(file->elf, insn->sec,
734 insn->offset, insn->len);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500735 if (!rela) {
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000736 dest_off = arch_jump_destination(insn);
Josh Poimboeuf7acfe532020-02-17 21:41:54 -0600737 insn->call_dest = find_func_by_offset(insn->sec, dest_off);
738 if (!insn->call_dest)
739 insn->call_dest = find_symbol_by_offset(insn->sec, dest_off);
Josh Poimboeufa845c7c2018-01-29 22:00:39 -0600740
Josh Poimboeuf7acfe532020-02-17 21:41:54 -0600741 if (insn->ignore)
742 continue;
743
744 if (!insn->call_dest) {
Alexandre Chartre8aa8eb22020-04-14 12:36:12 +0200745 WARN_FUNC("unannotated intra-function call", insn->sec, insn->offset);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500746 return -1;
747 }
Josh Poimboeufa845c7c2018-01-29 22:00:39 -0600748
Josh Poimboeuf7acfe532020-02-17 21:41:54 -0600749 if (insn->func && insn->call_dest->type != STT_FUNC) {
750 WARN_FUNC("unsupported call to non-function",
751 insn->sec, insn->offset);
752 return -1;
753 }
754
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500755 } else if (rela->sym->type == STT_SECTION) {
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000756 dest_off = arch_dest_rela_offset(rela->addend);
Josh Poimboeuf7acfe532020-02-17 21:41:54 -0600757 insn->call_dest = find_func_by_offset(rela->sym->sec,
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000758 dest_off);
Josh Poimboeuf7acfe532020-02-17 21:41:54 -0600759 if (!insn->call_dest) {
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000760 WARN_FUNC("can't find call dest symbol at %s+0x%lx",
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500761 insn->sec, insn->offset,
762 rela->sym->sec->name,
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000763 dest_off);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500764 return -1;
765 }
766 } else
767 insn->call_dest = rela->sym;
Alexandre Chartre8aa8eb22020-04-14 12:36:12 +0200768
769 /*
Peter Zijlstra0f1441b2020-06-12 16:05:26 +0200770 * Many compilers cannot disable KCOV with a function attribute
771 * so they need a little help, NOP out any KCOV calls from noinstr
772 * text.
773 */
774 if (insn->sec->noinstr &&
775 !strncmp(insn->call_dest->name, "__sanitizer_cov_", 16)) {
776 if (rela) {
777 rela->type = R_NONE;
778 elf_write_rela(file->elf, rela);
779 }
780
781 elf_write_insn(file->elf, insn->sec,
782 insn->offset, insn->len,
783 arch_nop_insn(insn->len));
784 insn->type = INSN_NOP;
785 }
786
787 /*
Alexandre Chartre8aa8eb22020-04-14 12:36:12 +0200788 * Whatever stack impact regular CALLs have, should be undone
789 * by the RETURN of the called function.
790 *
791 * Annotated intra-function calls retain the stack_ops but
792 * are converted to JUMP, see read_intra_function_calls().
793 */
794 remove_insn_ops(insn);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500795 }
796
797 return 0;
798}
799
800/*
801 * The .alternatives section requires some extra special care, over and above
802 * what other special sections require:
803 *
804 * 1. Because alternatives are patched in-place, we need to insert a fake jump
805 * instruction at the end so that validate_branch() skips all the original
806 * replaced instructions when validating the new instruction path.
807 *
808 * 2. An added wrinkle is that the new instruction length might be zero. In
809 * that case the old instructions are replaced with noops. We simulate that
810 * by creating a fake jump as the only new instruction.
811 *
812 * 3. In some cases, the alternative section includes an instruction which
813 * conditionally jumps to the _end_ of the entry. We have to modify these
814 * jumps' destinations to point back to .text rather than the end of the
815 * entry in .altinstr_replacement.
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500816 */
817static int handle_group_alt(struct objtool_file *file,
818 struct special_alt *special_alt,
819 struct instruction *orig_insn,
820 struct instruction **new_insn)
821{
Alexandre Chartre13fab062020-04-14 12:36:11 +0200822 static unsigned int alt_group_next_index = 1;
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600823 struct instruction *last_orig_insn, *last_new_insn, *insn, *fake_jump = NULL;
Alexandre Chartre13fab062020-04-14 12:36:11 +0200824 unsigned int alt_group = alt_group_next_index++;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500825 unsigned long dest_off;
826
827 last_orig_insn = NULL;
828 insn = orig_insn;
829 sec_for_each_insn_from(file, insn) {
830 if (insn->offset >= special_alt->orig_off + special_alt->orig_len)
831 break;
832
Alexandre Chartre13fab062020-04-14 12:36:11 +0200833 insn->alt_group = alt_group;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500834 last_orig_insn = insn;
835 }
836
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600837 if (next_insn_same_sec(file, last_orig_insn)) {
838 fake_jump = malloc(sizeof(*fake_jump));
839 if (!fake_jump) {
840 WARN("malloc failed");
841 return -1;
842 }
843 memset(fake_jump, 0, sizeof(*fake_jump));
844 INIT_LIST_HEAD(&fake_jump->alts);
Julien Thierry65ea47d2020-03-27 15:28:47 +0000845 INIT_LIST_HEAD(&fake_jump->stack_ops);
Peter Zijlstrae7c02192020-03-25 14:04:45 +0100846 init_cfi_state(&fake_jump->cfi);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500847
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600848 fake_jump->sec = special_alt->new_sec;
Josh Poimboeufe6da9562019-05-13 12:01:31 -0500849 fake_jump->offset = FAKE_JUMP_OFFSET;
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600850 fake_jump->type = INSN_JUMP_UNCONDITIONAL;
851 fake_jump->jump_dest = list_next_entry(last_orig_insn, list);
Josh Poimboeufe6da9562019-05-13 12:01:31 -0500852 fake_jump->func = orig_insn->func;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500853 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500854
855 if (!special_alt->new_len) {
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600856 if (!fake_jump) {
857 WARN("%s: empty alternative at end of section",
858 special_alt->orig_sec->name);
859 return -1;
860 }
861
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500862 *new_insn = fake_jump;
863 return 0;
864 }
865
866 last_new_insn = NULL;
Alexandre Chartre13fab062020-04-14 12:36:11 +0200867 alt_group = alt_group_next_index++;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500868 insn = *new_insn;
869 sec_for_each_insn_from(file, insn) {
870 if (insn->offset >= special_alt->new_off + special_alt->new_len)
871 break;
872
873 last_new_insn = insn;
874
Josh Poimboeufa845c7c2018-01-29 22:00:39 -0600875 insn->ignore = orig_insn->ignore_alts;
Peter Zijlstraa4d09dd2019-02-25 10:31:24 +0100876 insn->func = orig_insn->func;
Alexandre Chartre13fab062020-04-14 12:36:11 +0200877 insn->alt_group = alt_group;
Josh Poimboeufa845c7c2018-01-29 22:00:39 -0600878
Josh Poimboeufdc419722020-02-10 12:32:40 -0600879 /*
880 * Since alternative replacement code is copy/pasted by the
881 * kernel after applying relocations, generally such code can't
882 * have relative-address relocation references to outside the
883 * .altinstr_replacement section, unless the arch's
884 * alternatives code can adjust the relative offsets
885 * accordingly.
886 *
887 * The x86 alternatives code adjusts the offsets only when it
888 * encounters a branch instruction at the very beginning of the
889 * replacement group.
890 */
891 if ((insn->offset != special_alt->new_off ||
892 (insn->type != INSN_CALL && !is_static_jump(insn))) &&
Peter Zijlstra8b5fa6b2020-03-12 11:23:36 +0100893 find_rela_by_dest_range(file->elf, insn->sec, insn->offset, insn->len)) {
Josh Poimboeufdc419722020-02-10 12:32:40 -0600894
895 WARN_FUNC("unsupported relocation in alternatives section",
896 insn->sec, insn->offset);
897 return -1;
898 }
899
Josh Poimboeufa2296142020-02-10 12:32:39 -0600900 if (!is_static_jump(insn))
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500901 continue;
902
903 if (!insn->immediate)
904 continue;
905
Raphael Gaultbfb08f22020-03-27 15:28:45 +0000906 dest_off = arch_jump_destination(insn);
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600907 if (dest_off == special_alt->new_off + special_alt->new_len) {
908 if (!fake_jump) {
909 WARN("%s: alternative jump to end of section",
910 special_alt->orig_sec->name);
911 return -1;
912 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500913 insn->jump_dest = fake_jump;
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600914 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500915
916 if (!insn->jump_dest) {
917 WARN_FUNC("can't find alternative jump destination",
918 insn->sec, insn->offset);
919 return -1;
920 }
921 }
922
923 if (!last_new_insn) {
924 WARN_FUNC("can't find last new alternative instruction",
925 special_alt->new_sec, special_alt->new_off);
926 return -1;
927 }
928
Josh Poimboeuf17bc3392018-01-29 22:00:40 -0600929 if (fake_jump)
930 list_add(&fake_jump->list, &last_new_insn->list);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500931
932 return 0;
933}
934
935/*
936 * A jump table entry can either convert a nop to a jump or a jump to a nop.
937 * If the original instruction is a jump, make the alt entry an effective nop
938 * by just skipping the original instruction.
939 */
940static int handle_jump_alt(struct objtool_file *file,
941 struct special_alt *special_alt,
942 struct instruction *orig_insn,
943 struct instruction **new_insn)
944{
945 if (orig_insn->type == INSN_NOP)
946 return 0;
947
948 if (orig_insn->type != INSN_JUMP_UNCONDITIONAL) {
949 WARN_FUNC("unsupported instruction at jump label",
950 orig_insn->sec, orig_insn->offset);
951 return -1;
952 }
953
954 *new_insn = list_next_entry(orig_insn, list);
955 return 0;
956}
957
958/*
959 * Read all the special sections which have alternate instructions which can be
960 * patched in or redirected to at runtime. Each instruction having alternate
961 * instruction(s) has them added to its insn->alts list, which will be
962 * traversed in validate_branch().
963 */
964static int add_special_section_alts(struct objtool_file *file)
965{
966 struct list_head special_alts;
967 struct instruction *orig_insn, *new_insn;
968 struct special_alt *special_alt, *tmp;
969 struct alternative *alt;
970 int ret;
971
972 ret = special_get_alts(file->elf, &special_alts);
973 if (ret)
974 return ret;
975
976 list_for_each_entry_safe(special_alt, tmp, &special_alts, list) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -0500977
978 orig_insn = find_insn(file, special_alt->orig_sec,
979 special_alt->orig_off);
980 if (!orig_insn) {
981 WARN_FUNC("special: can't find orig instruction",
982 special_alt->orig_sec, special_alt->orig_off);
983 ret = -1;
984 goto out;
985 }
986
987 new_insn = NULL;
988 if (!special_alt->group || special_alt->new_len) {
989 new_insn = find_insn(file, special_alt->new_sec,
990 special_alt->new_off);
991 if (!new_insn) {
992 WARN_FUNC("special: can't find new instruction",
993 special_alt->new_sec,
994 special_alt->new_off);
995 ret = -1;
996 goto out;
997 }
998 }
999
1000 if (special_alt->group) {
Julien Thierry7170cf42020-03-27 15:28:41 +00001001 if (!special_alt->orig_len) {
1002 WARN_FUNC("empty alternative entry",
1003 orig_insn->sec, orig_insn->offset);
1004 continue;
1005 }
1006
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001007 ret = handle_group_alt(file, special_alt, orig_insn,
1008 &new_insn);
1009 if (ret)
1010 goto out;
1011 } else if (special_alt->jump_or_nop) {
1012 ret = handle_jump_alt(file, special_alt, orig_insn,
1013 &new_insn);
1014 if (ret)
1015 goto out;
1016 }
1017
Josh Poimboeuf258c7602018-01-11 21:46:24 +00001018 alt = malloc(sizeof(*alt));
1019 if (!alt) {
1020 WARN("malloc failed");
1021 ret = -1;
1022 goto out;
1023 }
1024
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001025 alt->insn = new_insn;
Peter Zijlstra764eef42019-03-01 11:19:03 +01001026 alt->skip_orig = special_alt->skip_orig;
Peter Zijlstraea242132019-02-25 12:50:09 +01001027 orig_insn->ignore_alts |= special_alt->skip_alt;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001028 list_add_tail(&alt->list, &orig_insn->alts);
1029
1030 list_del(&special_alt->list);
1031 free(special_alt);
1032 }
1033
1034out:
1035 return ret;
1036}
1037
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001038static int add_jump_table(struct objtool_file *file, struct instruction *insn,
Jann Hornbd98c812019-07-17 20:36:54 -05001039 struct rela *table)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001040{
1041 struct rela *rela = table;
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001042 struct instruction *dest_insn;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001043 struct alternative *alt;
Josh Poimboeuffd35c882018-05-10 17:48:49 -05001044 struct symbol *pfunc = insn->func->pfunc;
1045 unsigned int prev_offset = 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001046
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001047 /*
1048 * Each @rela is a switch table relocation which points to the target
1049 * instruction.
1050 */
1051 list_for_each_entry_from(rela, &table->sec->rela_list, list) {
Jann Hornbd98c812019-07-17 20:36:54 -05001052
1053 /* Check for the end of the table: */
1054 if (rela != table && rela->jump_table_start)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001055 break;
1056
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001057 /* Make sure the table entries are consecutive: */
Josh Poimboeuffd35c882018-05-10 17:48:49 -05001058 if (prev_offset && rela->offset != prev_offset + 8)
1059 break;
1060
1061 /* Detect function pointers from contiguous objects: */
1062 if (rela->sym->sec == pfunc->sec &&
1063 rela->addend == pfunc->offset)
1064 break;
1065
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001066 dest_insn = find_insn(file, rela->sym->sec, rela->addend);
1067 if (!dest_insn)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001068 break;
1069
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001070 /* Make sure the destination is in the same function: */
Josh Poimboeufe65050b2019-07-17 20:36:55 -05001071 if (!dest_insn->func || dest_insn->func->pfunc != pfunc)
Josh Poimboeuf13810432018-05-09 22:39:15 -05001072 break;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001073
1074 alt = malloc(sizeof(*alt));
1075 if (!alt) {
1076 WARN("malloc failed");
1077 return -1;
1078 }
1079
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001080 alt->insn = dest_insn;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001081 list_add_tail(&alt->list, &insn->alts);
Josh Poimboeuffd35c882018-05-10 17:48:49 -05001082 prev_offset = rela->offset;
1083 }
1084
1085 if (!prev_offset) {
1086 WARN_FUNC("can't find switch jump table",
1087 insn->sec, insn->offset);
1088 return -1;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001089 }
1090
1091 return 0;
1092}
1093
1094/*
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001095 * find_jump_table() - Given a dynamic jump, find the switch jump table in
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001096 * .rodata associated with it.
1097 *
1098 * There are 3 basic patterns:
1099 *
1100 * 1. jmpq *[rodata addr](,%reg,8)
1101 *
1102 * This is the most common case by far. It jumps to an address in a simple
1103 * jump table which is stored in .rodata.
1104 *
1105 * 2. jmpq *[rodata addr](%rip)
1106 *
1107 * This is caused by a rare GCC quirk, currently only seen in three driver
1108 * functions in the kernel, only with certain obscure non-distro configs.
1109 *
1110 * As part of an optimization, GCC makes a copy of an existing switch jump
1111 * table, modifies it, and then hard-codes the jump (albeit with an indirect
1112 * jump) to use a single entry in the table. The rest of the jump table and
1113 * some of its jump targets remain as dead code.
1114 *
1115 * In such a case we can just crudely ignore all unreachable instruction
1116 * warnings for the entire object file. Ideally we would just ignore them
1117 * for the function, but that would require redesigning the code quite a
1118 * bit. And honestly that's just not worth doing: unreachable instruction
1119 * warnings are of questionable value anyway, and this is such a rare issue.
1120 *
1121 * 3. mov [rodata addr],%reg1
1122 * ... some instructions ...
1123 * jmpq *(%reg1,%reg2,8)
1124 *
1125 * This is a fairly uncommon pattern which is new for GCC 6. As of this
1126 * writing, there are 11 occurrences of it in the allmodconfig kernel.
1127 *
Peter Zijlstra99ce7962018-02-08 14:02:32 +01001128 * As of GCC 7 there are quite a few more of these and the 'in between' code
1129 * is significant. Esp. with KASAN enabled some of the code between the mov
1130 * and jmpq uses .rodata itself, which can confuse things.
1131 *
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001132 * TODO: Once we have DWARF CFI and smarter instruction decoding logic,
1133 * ensure the same register is used in the mov and jump instructions.
Peter Zijlstra99ce7962018-02-08 14:02:32 +01001134 *
1135 * NOTE: RETPOLINE made it harder still to decode dynamic jumps.
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001136 */
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001137static struct rela *find_jump_table(struct objtool_file *file,
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001138 struct symbol *func,
1139 struct instruction *insn)
1140{
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001141 struct rela *text_rela, *table_rela;
Josh Poimboeuf113d4bc2020-02-17 21:41:53 -06001142 struct instruction *dest_insn, *orig_insn = insn;
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001143 struct section *table_sec;
Josh Poimboeuf6f5ec292018-05-14 08:53:24 -05001144 unsigned long table_offset;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001145
Peter Zijlstra99ce7962018-02-08 14:02:32 +01001146 /*
1147 * Backward search using the @first_jump_src links, these help avoid
1148 * much of the 'in between' code. Which avoids us getting confused by
1149 * it.
1150 */
Josh Poimboeuf7dec80c2018-05-18 15:10:34 -05001151 for (;
Josh Poimboeuf1119d262020-04-28 16:45:16 -05001152 insn && insn->func && insn->func->pfunc == func;
1153 insn = insn->first_jump_src ?: prev_insn_same_sym(file, insn)) {
Peter Zijlstra99ce7962018-02-08 14:02:32 +01001154
Josh Poimboeuf7dec80c2018-05-18 15:10:34 -05001155 if (insn != orig_insn && insn->type == INSN_JUMP_DYNAMIC)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001156 break;
1157
1158 /* allow small jumps within the range */
1159 if (insn->type == INSN_JUMP_UNCONDITIONAL &&
1160 insn->jump_dest &&
1161 (insn->jump_dest->offset <= insn->offset ||
1162 insn->jump_dest->offset > orig_insn->offset))
1163 break;
1164
1165 /* look for a relocation which references .rodata */
Peter Zijlstra8b5fa6b2020-03-12 11:23:36 +01001166 text_rela = find_rela_by_dest_range(file->elf, insn->sec,
1167 insn->offset, insn->len);
Allan Xavier4a60aa02018-09-07 08:12:01 -05001168 if (!text_rela || text_rela->sym->type != STT_SECTION ||
1169 !text_rela->sym->sec->rodata)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001170 continue;
1171
Josh Poimboeuf6f5ec292018-05-14 08:53:24 -05001172 table_offset = text_rela->addend;
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001173 table_sec = text_rela->sym->sec;
Allan Xavier4a60aa02018-09-07 08:12:01 -05001174
Josh Poimboeuf6f5ec292018-05-14 08:53:24 -05001175 if (text_rela->type == R_X86_64_PC32)
1176 table_offset += 4;
1177
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001178 /*
1179 * Make sure the .rodata address isn't associated with a
Josh Poimboeuf87b512d2019-06-27 20:50:46 -05001180 * symbol. GCC jump tables are anonymous data.
1181 *
1182 * Also support C jump tables which are in the same format as
1183 * switch jump tables. For objtool to recognize them, they
1184 * need to be placed in the C_JUMP_TABLE_SECTION section. They
1185 * have symbols associated with them.
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001186 */
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001187 if (find_symbol_containing(table_sec, table_offset) &&
1188 strcmp(table_sec->name, C_JUMP_TABLE_SECTION))
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001189 continue;
1190
Josh Poimboeuf113d4bc2020-02-17 21:41:53 -06001191 /*
1192 * Each table entry has a rela associated with it. The rela
1193 * should reference text in the same function as the original
1194 * instruction.
1195 */
Peter Zijlstra8b5fa6b2020-03-12 11:23:36 +01001196 table_rela = find_rela_by_dest(file->elf, table_sec, table_offset);
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001197 if (!table_rela)
1198 continue;
Josh Poimboeuf113d4bc2020-02-17 21:41:53 -06001199 dest_insn = find_insn(file, table_rela->sym->sec, table_rela->addend);
1200 if (!dest_insn || !dest_insn->func || dest_insn->func->pfunc != func)
1201 continue;
Josh Poimboeuf7dec80c2018-05-18 15:10:34 -05001202
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001203 /*
1204 * Use of RIP-relative switch jumps is quite rare, and
1205 * indicates a rare GCC quirk/bug which can leave dead code
1206 * behind.
1207 */
1208 if (text_rela->type == R_X86_64_PC32)
1209 file->ignore_unreachables = true;
1210
1211 return table_rela;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001212 }
1213
1214 return NULL;
1215}
1216
Jann Hornbd98c812019-07-17 20:36:54 -05001217/*
1218 * First pass: Mark the head of each jump table so that in the next pass,
1219 * we know when a given jump table ends and the next one starts.
1220 */
1221static void mark_func_jump_tables(struct objtool_file *file,
1222 struct symbol *func)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001223{
Jann Hornbd98c812019-07-17 20:36:54 -05001224 struct instruction *insn, *last = NULL;
1225 struct rela *rela;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001226
Peter Zijlstraf0f70ad2020-03-10 18:27:24 +01001227 func_for_each_insn(file, func, insn) {
Peter Zijlstra99ce7962018-02-08 14:02:32 +01001228 if (!last)
1229 last = insn;
1230
1231 /*
1232 * Store back-pointers for unconditional forward jumps such
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001233 * that find_jump_table() can back-track using those and
Peter Zijlstra99ce7962018-02-08 14:02:32 +01001234 * avoid some potentially confusing code.
1235 */
1236 if (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest &&
1237 insn->offset > last->offset &&
1238 insn->jump_dest->offset > insn->offset &&
1239 !insn->jump_dest->first_jump_src) {
1240
1241 insn->jump_dest->first_jump_src = insn;
1242 last = insn->jump_dest;
1243 }
1244
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001245 if (insn->type != INSN_JUMP_DYNAMIC)
1246 continue;
1247
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001248 rela = find_jump_table(file, func, insn);
Jann Hornbd98c812019-07-17 20:36:54 -05001249 if (rela) {
1250 rela->jump_table_start = true;
1251 insn->jump_table = rela;
1252 }
1253 }
1254}
1255
1256static int add_func_jump_tables(struct objtool_file *file,
1257 struct symbol *func)
1258{
1259 struct instruction *insn;
1260 int ret;
1261
Peter Zijlstraf0f70ad2020-03-10 18:27:24 +01001262 func_for_each_insn(file, func, insn) {
Jann Hornbd98c812019-07-17 20:36:54 -05001263 if (!insn->jump_table)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001264 continue;
1265
Jann Hornbd98c812019-07-17 20:36:54 -05001266 ret = add_jump_table(file, insn, insn->jump_table);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001267 if (ret)
1268 return ret;
1269 }
1270
1271 return 0;
1272}
1273
1274/*
1275 * For some switch statements, gcc generates a jump table in the .rodata
1276 * section which contains a list of addresses within the function to jump to.
1277 * This finds these jump tables and adds them to the insn->alts lists.
1278 */
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001279static int add_jump_table_alts(struct objtool_file *file)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001280{
1281 struct section *sec;
1282 struct symbol *func;
1283 int ret;
1284
Allan Xavier4a60aa02018-09-07 08:12:01 -05001285 if (!file->rodata)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001286 return 0;
1287
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001288 for_each_sec(file, sec) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001289 list_for_each_entry(func, &sec->symbol_list, list) {
1290 if (func->type != STT_FUNC)
1291 continue;
1292
Jann Hornbd98c812019-07-17 20:36:54 -05001293 mark_func_jump_tables(file, func);
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001294 ret = add_func_jump_tables(file, func);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001295 if (ret)
1296 return ret;
1297 }
1298 }
1299
1300 return 0;
1301}
1302
Josh Poimboeuf39358a02017-07-11 10:33:43 -05001303static int read_unwind_hints(struct objtool_file *file)
1304{
1305 struct section *sec, *relasec;
1306 struct rela *rela;
1307 struct unwind_hint *hint;
1308 struct instruction *insn;
1309 struct cfi_reg *cfa;
1310 int i;
1311
1312 sec = find_section_by_name(file->elf, ".discard.unwind_hints");
1313 if (!sec)
1314 return 0;
1315
1316 relasec = sec->rela;
1317 if (!relasec) {
1318 WARN("missing .rela.discard.unwind_hints section");
1319 return -1;
1320 }
1321
1322 if (sec->len % sizeof(struct unwind_hint)) {
1323 WARN("struct unwind_hint size mismatch");
1324 return -1;
1325 }
1326
1327 file->hints = true;
1328
1329 for (i = 0; i < sec->len / sizeof(struct unwind_hint); i++) {
1330 hint = (struct unwind_hint *)sec->data->d_buf + i;
1331
Peter Zijlstra8b5fa6b2020-03-12 11:23:36 +01001332 rela = find_rela_by_dest(file->elf, sec, i * sizeof(*hint));
Josh Poimboeuf39358a02017-07-11 10:33:43 -05001333 if (!rela) {
1334 WARN("can't find rela for unwind_hints[%d]", i);
1335 return -1;
1336 }
1337
1338 insn = find_insn(file, rela->sym->sec, rela->addend);
1339 if (!insn) {
1340 WARN("can't find insn for unwind_hints[%d]", i);
1341 return -1;
1342 }
1343
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001344 cfa = &insn->cfi.cfa;
Josh Poimboeuf39358a02017-07-11 10:33:43 -05001345
Peter Zijlstrac536ed22020-04-01 16:54:26 +02001346 if (hint->type == UNWIND_HINT_TYPE_RET_OFFSET) {
Peter Zijlstrae25eea82020-04-01 16:38:19 +02001347 insn->ret_offset = hint->sp_offset;
Josh Poimboeuf39358a02017-07-11 10:33:43 -05001348 continue;
1349 }
1350
1351 insn->hint = true;
1352
1353 switch (hint->sp_reg) {
1354 case ORC_REG_UNDEFINED:
1355 cfa->base = CFI_UNDEFINED;
1356 break;
1357 case ORC_REG_SP:
1358 cfa->base = CFI_SP;
1359 break;
1360 case ORC_REG_BP:
1361 cfa->base = CFI_BP;
1362 break;
1363 case ORC_REG_SP_INDIRECT:
1364 cfa->base = CFI_SP_INDIRECT;
1365 break;
1366 case ORC_REG_R10:
1367 cfa->base = CFI_R10;
1368 break;
1369 case ORC_REG_R13:
1370 cfa->base = CFI_R13;
1371 break;
1372 case ORC_REG_DI:
1373 cfa->base = CFI_DI;
1374 break;
1375 case ORC_REG_DX:
1376 cfa->base = CFI_DX;
1377 break;
1378 default:
1379 WARN_FUNC("unsupported unwind_hint sp base reg %d",
1380 insn->sec, insn->offset, hint->sp_reg);
1381 return -1;
1382 }
1383
1384 cfa->offset = hint->sp_offset;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001385 insn->cfi.type = hint->type;
1386 insn->cfi.end = hint->end;
Josh Poimboeuf39358a02017-07-11 10:33:43 -05001387 }
1388
1389 return 0;
1390}
1391
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001392static int read_retpoline_hints(struct objtool_file *file)
1393{
Josh Poimboeuf63474dc2018-03-06 17:58:15 -06001394 struct section *sec;
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001395 struct instruction *insn;
1396 struct rela *rela;
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001397
Josh Poimboeuf63474dc2018-03-06 17:58:15 -06001398 sec = find_section_by_name(file->elf, ".rela.discard.retpoline_safe");
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001399 if (!sec)
1400 return 0;
1401
Josh Poimboeuf63474dc2018-03-06 17:58:15 -06001402 list_for_each_entry(rela, &sec->rela_list, list) {
1403 if (rela->sym->type != STT_SECTION) {
1404 WARN("unexpected relocation symbol type in %s", sec->name);
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001405 return -1;
1406 }
1407
1408 insn = find_insn(file, rela->sym->sec, rela->addend);
1409 if (!insn) {
Josh Poimboeuf63474dc2018-03-06 17:58:15 -06001410 WARN("bad .discard.retpoline_safe entry");
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001411 return -1;
1412 }
1413
1414 if (insn->type != INSN_JUMP_DYNAMIC &&
1415 insn->type != INSN_CALL_DYNAMIC) {
Josh Poimboeuf63474dc2018-03-06 17:58:15 -06001416 WARN_FUNC("retpoline_safe hint not an indirect jump/call",
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001417 insn->sec, insn->offset);
1418 return -1;
1419 }
1420
1421 insn->retpoline_safe = true;
1422 }
1423
1424 return 0;
1425}
1426
Peter Zijlstrac4a33932020-03-10 18:57:41 +01001427static int read_instr_hints(struct objtool_file *file)
1428{
1429 struct section *sec;
1430 struct instruction *insn;
1431 struct rela *rela;
1432
1433 sec = find_section_by_name(file->elf, ".rela.discard.instr_end");
1434 if (!sec)
1435 return 0;
1436
1437 list_for_each_entry(rela, &sec->rela_list, list) {
1438 if (rela->sym->type != STT_SECTION) {
1439 WARN("unexpected relocation symbol type in %s", sec->name);
1440 return -1;
1441 }
1442
1443 insn = find_insn(file, rela->sym->sec, rela->addend);
1444 if (!insn) {
1445 WARN("bad .discard.instr_end entry");
1446 return -1;
1447 }
1448
1449 insn->instr--;
1450 }
1451
1452 sec = find_section_by_name(file->elf, ".rela.discard.instr_begin");
1453 if (!sec)
1454 return 0;
1455
1456 list_for_each_entry(rela, &sec->rela_list, list) {
1457 if (rela->sym->type != STT_SECTION) {
1458 WARN("unexpected relocation symbol type in %s", sec->name);
1459 return -1;
1460 }
1461
1462 insn = find_insn(file, rela->sym->sec, rela->addend);
1463 if (!insn) {
1464 WARN("bad .discard.instr_begin entry");
1465 return -1;
1466 }
1467
1468 insn->instr++;
1469 }
1470
1471 return 0;
1472}
1473
Alexandre Chartre8aa8eb22020-04-14 12:36:12 +02001474static int read_intra_function_calls(struct objtool_file *file)
1475{
1476 struct instruction *insn;
1477 struct section *sec;
1478 struct rela *rela;
1479
1480 sec = find_section_by_name(file->elf, ".rela.discard.intra_function_calls");
1481 if (!sec)
1482 return 0;
1483
1484 list_for_each_entry(rela, &sec->rela_list, list) {
1485 unsigned long dest_off;
1486
1487 if (rela->sym->type != STT_SECTION) {
1488 WARN("unexpected relocation symbol type in %s",
1489 sec->name);
1490 return -1;
1491 }
1492
1493 insn = find_insn(file, rela->sym->sec, rela->addend);
1494 if (!insn) {
1495 WARN("bad .discard.intra_function_call entry");
1496 return -1;
1497 }
1498
1499 if (insn->type != INSN_CALL) {
1500 WARN_FUNC("intra_function_call not a direct call",
1501 insn->sec, insn->offset);
1502 return -1;
1503 }
1504
1505 /*
1506 * Treat intra-function CALLs as JMPs, but with a stack_op.
1507 * See add_call_destinations(), which strips stack_ops from
1508 * normal CALLs.
1509 */
1510 insn->type = INSN_JUMP_UNCONDITIONAL;
1511
1512 dest_off = insn->offset + insn->len + insn->immediate;
1513 insn->jump_dest = find_insn(file, insn->sec, dest_off);
1514 if (!insn->jump_dest) {
1515 WARN_FUNC("can't find call dest at %s+0x%lx",
1516 insn->sec, insn->offset,
1517 insn->sec->name, dest_off);
1518 return -1;
1519 }
1520 }
1521
1522 return 0;
1523}
1524
Allan Xavier4a60aa02018-09-07 08:12:01 -05001525static void mark_rodata(struct objtool_file *file)
1526{
1527 struct section *sec;
1528 bool found = false;
1529
1530 /*
Josh Poimboeuf87b512d2019-06-27 20:50:46 -05001531 * Search for the following rodata sections, each of which can
1532 * potentially contain jump tables:
1533 *
1534 * - .rodata: can contain GCC switch tables
1535 * - .rodata.<func>: same, if -fdata-sections is being used
1536 * - .rodata..c_jump_table: contains C annotated jump tables
1537 *
1538 * .rodata.str1.* sections are ignored; they don't contain jump tables.
Allan Xavier4a60aa02018-09-07 08:12:01 -05001539 */
1540 for_each_sec(file, sec) {
Muchun Song1ee444702020-04-12 22:44:05 +08001541 if (!strncmp(sec->name, ".rodata", 7) &&
1542 !strstr(sec->name, ".str1.")) {
Allan Xavier4a60aa02018-09-07 08:12:01 -05001543 sec->rodata = true;
1544 found = true;
1545 }
1546 }
1547
1548 file->rodata = found;
1549}
1550
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001551static int decode_sections(struct objtool_file *file)
1552{
1553 int ret;
1554
Allan Xavier4a60aa02018-09-07 08:12:01 -05001555 mark_rodata(file);
1556
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001557 ret = decode_instructions(file);
1558 if (ret)
1559 return ret;
1560
1561 ret = add_dead_ends(file);
1562 if (ret)
1563 return ret;
1564
1565 add_ignores(file);
Peter Zijlstraea242132019-02-25 12:50:09 +01001566 add_uaccess_safe(file);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001567
Peter Zijlstraff05ab22019-03-18 14:33:07 +01001568 ret = add_ignore_alternatives(file);
Josh Poimboeuf258c7602018-01-11 21:46:24 +00001569 if (ret)
1570 return ret;
1571
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001572 ret = add_jump_destinations(file);
1573 if (ret)
1574 return ret;
1575
Josh Poimboeufa845c7c2018-01-29 22:00:39 -06001576 ret = add_special_section_alts(file);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001577 if (ret)
1578 return ret;
1579
Alexandre Chartre8aa8eb22020-04-14 12:36:12 +02001580 ret = read_intra_function_calls(file);
1581 if (ret)
1582 return ret;
1583
Josh Poimboeufa845c7c2018-01-29 22:00:39 -06001584 ret = add_call_destinations(file);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001585 if (ret)
1586 return ret;
1587
Josh Poimboeufe7c2bc32019-07-17 20:36:53 -05001588 ret = add_jump_table_alts(file);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001589 if (ret)
1590 return ret;
1591
Josh Poimboeuf39358a02017-07-11 10:33:43 -05001592 ret = read_unwind_hints(file);
1593 if (ret)
1594 return ret;
1595
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01001596 ret = read_retpoline_hints(file);
1597 if (ret)
1598 return ret;
1599
Peter Zijlstrac4a33932020-03-10 18:57:41 +01001600 ret = read_instr_hints(file);
1601 if (ret)
1602 return ret;
1603
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001604 return 0;
1605}
1606
1607static bool is_fentry_call(struct instruction *insn)
1608{
Alexandre Chartre87cf61f2020-04-14 12:36:10 +02001609 if (insn->type == INSN_CALL && insn->call_dest &&
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001610 insn->call_dest->type == STT_NOTYPE &&
1611 !strcmp(insn->call_dest->name, "__fentry__"))
1612 return true;
1613
1614 return false;
1615}
1616
Peter Zijlstrae25eea82020-04-01 16:38:19 +02001617static bool has_modified_stack_frame(struct instruction *insn, struct insn_state *state)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001618{
Peter Zijlstrae25eea82020-04-01 16:38:19 +02001619 u8 ret_offset = insn->ret_offset;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001620 struct cfi_state *cfi = &state->cfi;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001621 int i;
1622
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001623 if (cfi->cfa.base != initial_func_cfi.cfa.base || cfi->drap)
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001624 return true;
1625
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001626 if (cfi->cfa.offset != initial_func_cfi.cfa.offset + ret_offset)
Peter Zijlstrae25eea82020-04-01 16:38:19 +02001627 return true;
1628
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001629 if (cfi->stack_size != initial_func_cfi.cfa.offset + ret_offset)
Peter Zijlstrae25eea82020-04-01 16:38:19 +02001630 return true;
1631
Alexandre Chartrec721b3f2020-04-07 09:31:35 +02001632 /*
1633 * If there is a ret offset hint then don't check registers
1634 * because a callee-saved register might have been pushed on
1635 * the stack.
1636 */
1637 if (ret_offset)
1638 return false;
1639
Peter Zijlstrae25eea82020-04-01 16:38:19 +02001640 for (i = 0; i < CFI_NUM_REGS; i++) {
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001641 if (cfi->regs[i].base != initial_func_cfi.regs[i].base ||
1642 cfi->regs[i].offset != initial_func_cfi.regs[i].offset)
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001643 return true;
Peter Zijlstrae25eea82020-04-01 16:38:19 +02001644 }
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001645
1646 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001647}
1648
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001649static bool has_valid_stack_frame(struct insn_state *state)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001650{
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001651 struct cfi_state *cfi = &state->cfi;
1652
1653 if (cfi->cfa.base == CFI_BP && cfi->regs[CFI_BP].base == CFI_CFA &&
1654 cfi->regs[CFI_BP].offset == -16)
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001655 return true;
1656
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001657 if (cfi->drap && cfi->regs[CFI_BP].base == CFI_BP)
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001658 return true;
1659
1660 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001661}
1662
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001663static int update_cfi_state_regs(struct instruction *insn,
1664 struct cfi_state *cfi,
Julien Thierry65ea47d2020-03-27 15:28:47 +00001665 struct stack_op *op)
Josh Poimboeuf627fce12017-07-11 10:33:42 -05001666{
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001667 struct cfi_reg *cfa = &cfi->cfa;
Josh Poimboeuf627fce12017-07-11 10:33:42 -05001668
Josh Poimboeufd8dd25a2020-04-25 05:03:00 -05001669 if (cfa->base != CFI_SP && cfa->base != CFI_SP_INDIRECT)
Josh Poimboeuf627fce12017-07-11 10:33:42 -05001670 return 0;
1671
1672 /* push */
Peter Zijlstraea242132019-02-25 12:50:09 +01001673 if (op->dest.type == OP_DEST_PUSH || op->dest.type == OP_DEST_PUSHF)
Josh Poimboeuf627fce12017-07-11 10:33:42 -05001674 cfa->offset += 8;
1675
1676 /* pop */
Peter Zijlstraea242132019-02-25 12:50:09 +01001677 if (op->src.type == OP_SRC_POP || op->src.type == OP_SRC_POPF)
Josh Poimboeuf627fce12017-07-11 10:33:42 -05001678 cfa->offset -= 8;
1679
1680 /* add immediate to sp */
1681 if (op->dest.type == OP_DEST_REG && op->src.type == OP_SRC_ADD &&
1682 op->dest.reg == CFI_SP && op->src.reg == CFI_SP)
1683 cfa->offset -= op->src.offset;
1684
1685 return 0;
1686}
1687
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001688static void save_reg(struct cfi_state *cfi, unsigned char reg, int base, int offset)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05001689{
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05001690 if (arch_callee_saved_reg(reg) &&
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001691 cfi->regs[reg].base == CFI_UNDEFINED) {
1692 cfi->regs[reg].base = base;
1693 cfi->regs[reg].offset = offset;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001694 }
1695}
1696
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001697static void restore_reg(struct cfi_state *cfi, unsigned char reg)
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001698{
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001699 cfi->regs[reg].base = initial_func_cfi.regs[reg].base;
1700 cfi->regs[reg].offset = initial_func_cfi.regs[reg].offset;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001701}
1702
1703/*
1704 * A note about DRAP stack alignment:
1705 *
1706 * GCC has the concept of a DRAP register, which is used to help keep track of
1707 * the stack pointer when aligning the stack. r10 or r13 is used as the DRAP
1708 * register. The typical DRAP pattern is:
1709 *
1710 * 4c 8d 54 24 08 lea 0x8(%rsp),%r10
1711 * 48 83 e4 c0 and $0xffffffffffffffc0,%rsp
1712 * 41 ff 72 f8 pushq -0x8(%r10)
1713 * 55 push %rbp
1714 * 48 89 e5 mov %rsp,%rbp
1715 * (more pushes)
1716 * 41 52 push %r10
1717 * ...
1718 * 41 5a pop %r10
1719 * (more pops)
1720 * 5d pop %rbp
1721 * 49 8d 62 f8 lea -0x8(%r10),%rsp
1722 * c3 retq
1723 *
1724 * There are some variations in the epilogues, like:
1725 *
1726 * 5b pop %rbx
1727 * 41 5a pop %r10
1728 * 41 5c pop %r12
1729 * 41 5d pop %r13
1730 * 41 5e pop %r14
1731 * c9 leaveq
1732 * 49 8d 62 f8 lea -0x8(%r10),%rsp
1733 * c3 retq
1734 *
1735 * and:
1736 *
1737 * 4c 8b 55 e8 mov -0x18(%rbp),%r10
1738 * 48 8b 5d e0 mov -0x20(%rbp),%rbx
1739 * 4c 8b 65 f0 mov -0x10(%rbp),%r12
1740 * 4c 8b 6d f8 mov -0x8(%rbp),%r13
1741 * c9 leaveq
1742 * 49 8d 62 f8 lea -0x8(%r10),%rsp
1743 * c3 retq
1744 *
1745 * Sometimes r13 is used as the DRAP register, in which case it's saved and
1746 * restored beforehand:
1747 *
1748 * 41 55 push %r13
1749 * 4c 8d 6c 24 10 lea 0x10(%rsp),%r13
1750 * 48 83 e4 f0 and $0xfffffffffffffff0,%rsp
1751 * ...
1752 * 49 8d 65 f0 lea -0x10(%r13),%rsp
1753 * 41 5d pop %r13
1754 * c3 retq
1755 */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001756static int update_cfi_state(struct instruction *insn, struct cfi_state *cfi,
Julien Thierry65ea47d2020-03-27 15:28:47 +00001757 struct stack_op *op)
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001758{
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001759 struct cfi_reg *cfa = &cfi->cfa;
1760 struct cfi_reg *regs = cfi->regs;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001761
1762 /* stack operations don't make sense with an undefined CFA */
1763 if (cfa->base == CFI_UNDEFINED) {
1764 if (insn->func) {
1765 WARN_FUNC("undefined stack state", insn->sec, insn->offset);
1766 return -1;
1767 }
1768 return 0;
1769 }
1770
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001771 if (cfi->type == ORC_TYPE_REGS || cfi->type == ORC_TYPE_REGS_IRET)
1772 return update_cfi_state_regs(insn, cfi, op);
Josh Poimboeuf627fce12017-07-11 10:33:42 -05001773
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001774 switch (op->dest.type) {
1775
1776 case OP_DEST_REG:
1777 switch (op->src.type) {
1778
1779 case OP_SRC_REG:
Josh Poimboeuf0d0970e2017-09-20 16:24:32 -05001780 if (op->src.reg == CFI_SP && op->dest.reg == CFI_BP &&
1781 cfa->base == CFI_SP &&
1782 regs[CFI_BP].base == CFI_CFA &&
1783 regs[CFI_BP].offset == -cfa->offset) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001784
Josh Poimboeuf0d0970e2017-09-20 16:24:32 -05001785 /* mov %rsp, %rbp */
1786 cfa->base = op->dest.reg;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001787 cfi->bp_scratch = false;
Josh Poimboeuf0d0970e2017-09-20 16:24:32 -05001788 }
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001789
Josh Poimboeuf0d0970e2017-09-20 16:24:32 -05001790 else if (op->src.reg == CFI_SP &&
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001791 op->dest.reg == CFI_BP && cfi->drap) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001792
Josh Poimboeuf0d0970e2017-09-20 16:24:32 -05001793 /* drap: mov %rsp, %rbp */
1794 regs[CFI_BP].base = CFI_BP;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001795 regs[CFI_BP].offset = -cfi->stack_size;
1796 cfi->bp_scratch = false;
Josh Poimboeuf0d0970e2017-09-20 16:24:32 -05001797 }
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001798
Josh Poimboeuf0d0970e2017-09-20 16:24:32 -05001799 else if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
1800
1801 /*
1802 * mov %rsp, %reg
1803 *
1804 * This is needed for the rare case where GCC
1805 * does:
1806 *
1807 * mov %rsp, %rax
1808 * ...
1809 * mov %rax, %rsp
1810 */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001811 cfi->vals[op->dest.reg].base = CFI_CFA;
1812 cfi->vals[op->dest.reg].offset = -cfi->stack_size;
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001813 }
1814
Josh Poimboeuf3c1f0582018-03-22 13:00:37 -05001815 else if (op->src.reg == CFI_BP && op->dest.reg == CFI_SP &&
1816 cfa->base == CFI_BP) {
1817
1818 /*
1819 * mov %rbp, %rsp
1820 *
1821 * Restore the original stack pointer (Clang).
1822 */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001823 cfi->stack_size = -cfi->regs[CFI_BP].offset;
Josh Poimboeuf3c1f0582018-03-22 13:00:37 -05001824 }
1825
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001826 else if (op->dest.reg == cfa->base) {
1827
1828 /* mov %reg, %rsp */
1829 if (cfa->base == CFI_SP &&
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001830 cfi->vals[op->src.reg].base == CFI_CFA) {
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001831
1832 /*
1833 * This is needed for the rare case
1834 * where GCC does something dumb like:
1835 *
1836 * lea 0x8(%rsp), %rcx
1837 * ...
1838 * mov %rcx, %rsp
1839 */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001840 cfa->offset = -cfi->vals[op->src.reg].offset;
1841 cfi->stack_size = cfa->offset;
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001842
1843 } else {
1844 cfa->base = CFI_UNDEFINED;
1845 cfa->offset = 0;
1846 }
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001847 }
1848
1849 break;
1850
1851 case OP_SRC_ADD:
1852 if (op->dest.reg == CFI_SP && op->src.reg == CFI_SP) {
1853
1854 /* add imm, %rsp */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001855 cfi->stack_size -= op->src.offset;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001856 if (cfa->base == CFI_SP)
1857 cfa->offset -= op->src.offset;
1858 break;
1859 }
1860
1861 if (op->dest.reg == CFI_SP && op->src.reg == CFI_BP) {
1862
1863 /* lea disp(%rbp), %rsp */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001864 cfi->stack_size = -(op->src.offset + regs[CFI_BP].offset);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001865 break;
1866 }
1867
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001868 if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001869
1870 /* drap: lea disp(%rsp), %drap */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001871 cfi->drap_reg = op->dest.reg;
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001872
1873 /*
1874 * lea disp(%rsp), %reg
1875 *
1876 * This is needed for the rare case where GCC
1877 * does something dumb like:
1878 *
1879 * lea 0x8(%rsp), %rcx
1880 * ...
1881 * mov %rcx, %rsp
1882 */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001883 cfi->vals[op->dest.reg].base = CFI_CFA;
1884 cfi->vals[op->dest.reg].offset = \
1885 -cfi->stack_size + op->src.offset;
Josh Poimboeufdd88a0a2017-08-29 12:51:03 -05001886
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001887 break;
1888 }
1889
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001890 if (cfi->drap && op->dest.reg == CFI_SP &&
1891 op->src.reg == cfi->drap_reg) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001892
1893 /* drap: lea disp(%drap), %rsp */
1894 cfa->base = CFI_SP;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001895 cfa->offset = cfi->stack_size = -op->src.offset;
1896 cfi->drap_reg = CFI_UNDEFINED;
1897 cfi->drap = false;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001898 break;
1899 }
1900
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001901 if (op->dest.reg == cfi->cfa.base) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001902 WARN_FUNC("unsupported stack register modification",
1903 insn->sec, insn->offset);
1904 return -1;
1905 }
1906
1907 break;
1908
1909 case OP_SRC_AND:
1910 if (op->dest.reg != CFI_SP ||
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001911 (cfi->drap_reg != CFI_UNDEFINED && cfa->base != CFI_SP) ||
1912 (cfi->drap_reg == CFI_UNDEFINED && cfa->base != CFI_BP)) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001913 WARN_FUNC("unsupported stack pointer realignment",
1914 insn->sec, insn->offset);
1915 return -1;
1916 }
1917
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001918 if (cfi->drap_reg != CFI_UNDEFINED) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001919 /* drap: and imm, %rsp */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001920 cfa->base = cfi->drap_reg;
1921 cfa->offset = cfi->stack_size = 0;
1922 cfi->drap = true;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001923 }
1924
1925 /*
1926 * Older versions of GCC (4.8ish) realign the stack
1927 * without DRAP, with a frame pointer.
1928 */
1929
1930 break;
1931
1932 case OP_SRC_POP:
Peter Zijlstraea242132019-02-25 12:50:09 +01001933 case OP_SRC_POPF:
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001934 if (!cfi->drap && op->dest.reg == cfa->base) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001935
1936 /* pop %rbp */
1937 cfa->base = CFI_SP;
1938 }
1939
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001940 if (cfi->drap && cfa->base == CFI_BP_INDIRECT &&
1941 op->dest.reg == cfi->drap_reg &&
1942 cfi->drap_offset == -cfi->stack_size) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001943
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05001944 /* drap: pop %drap */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001945 cfa->base = cfi->drap_reg;
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05001946 cfa->offset = 0;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001947 cfi->drap_offset = -1;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001948
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001949 } else if (regs[op->dest.reg].offset == -cfi->stack_size) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001950
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05001951 /* pop %reg */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001952 restore_reg(cfi, op->dest.reg);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001953 }
1954
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001955 cfi->stack_size -= 8;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001956 if (cfa->base == CFI_SP)
1957 cfa->offset -= 8;
1958
1959 break;
1960
1961 case OP_SRC_REG_INDIRECT:
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001962 if (cfi->drap && op->src.reg == CFI_BP &&
1963 op->src.offset == cfi->drap_offset) {
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05001964
1965 /* drap: mov disp(%rbp), %drap */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001966 cfa->base = cfi->drap_reg;
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05001967 cfa->offset = 0;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001968 cfi->drap_offset = -1;
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05001969 }
1970
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001971 if (cfi->drap && op->src.reg == CFI_BP &&
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001972 op->src.offset == regs[op->dest.reg].offset) {
1973
1974 /* drap: mov disp(%rbp), %reg */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001975 restore_reg(cfi, op->dest.reg);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001976
1977 } else if (op->src.reg == cfa->base &&
1978 op->src.offset == regs[op->dest.reg].offset + cfa->offset) {
1979
1980 /* mov disp(%rbp), %reg */
1981 /* mov disp(%rsp), %reg */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001982 restore_reg(cfi, op->dest.reg);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001983 }
1984
1985 break;
1986
1987 default:
1988 WARN_FUNC("unknown stack-related instruction",
1989 insn->sec, insn->offset);
1990 return -1;
1991 }
1992
1993 break;
1994
1995 case OP_DEST_PUSH:
Peter Zijlstraea242132019-02-25 12:50:09 +01001996 case OP_DEST_PUSHF:
Peter Zijlstrae7c02192020-03-25 14:04:45 +01001997 cfi->stack_size += 8;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05001998 if (cfa->base == CFI_SP)
1999 cfa->offset += 8;
2000
2001 if (op->src.type != OP_SRC_REG)
2002 break;
2003
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002004 if (cfi->drap) {
2005 if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002006
2007 /* drap: push %drap */
2008 cfa->base = CFI_BP_INDIRECT;
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002009 cfa->offset = -cfi->stack_size;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002010
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05002011 /* save drap so we know when to restore it */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002012 cfi->drap_offset = -cfi->stack_size;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002013
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002014 } else if (op->src.reg == CFI_BP && cfa->base == cfi->drap_reg) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002015
2016 /* drap: push %rbp */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002017 cfi->stack_size = 0;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002018
2019 } else if (regs[op->src.reg].base == CFI_UNDEFINED) {
2020
2021 /* drap: push %reg */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002022 save_reg(cfi, op->src.reg, CFI_BP, -cfi->stack_size);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002023 }
2024
2025 } else {
2026
2027 /* push %reg */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002028 save_reg(cfi, op->src.reg, CFI_CFA, -cfi->stack_size);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002029 }
2030
2031 /* detect when asm code uses rbp as a scratch register */
Josh Poimboeuf867ac9d2017-07-24 18:34:14 -05002032 if (!no_fp && insn->func && op->src.reg == CFI_BP &&
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002033 cfa->base != CFI_BP)
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002034 cfi->bp_scratch = true;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002035 break;
2036
2037 case OP_DEST_REG_INDIRECT:
2038
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002039 if (cfi->drap) {
2040 if (op->src.reg == cfa->base && op->src.reg == cfi->drap_reg) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002041
2042 /* drap: mov %drap, disp(%rbp) */
2043 cfa->base = CFI_BP_INDIRECT;
2044 cfa->offset = op->dest.offset;
2045
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05002046 /* save drap offset so we know when to restore it */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002047 cfi->drap_offset = op->dest.offset;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002048 }
2049
2050 else if (regs[op->src.reg].base == CFI_UNDEFINED) {
2051
2052 /* drap: mov reg, disp(%rbp) */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002053 save_reg(cfi, op->src.reg, CFI_BP, op->dest.offset);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002054 }
2055
2056 } else if (op->dest.reg == cfa->base) {
2057
2058 /* mov reg, disp(%rbp) */
2059 /* mov reg, disp(%rsp) */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002060 save_reg(cfi, op->src.reg, CFI_CFA,
2061 op->dest.offset - cfi->cfa.offset);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002062 }
2063
2064 break;
2065
2066 case OP_DEST_LEAVE:
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002067 if ((!cfi->drap && cfa->base != CFI_BP) ||
2068 (cfi->drap && cfa->base != cfi->drap_reg)) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002069 WARN_FUNC("leave instruction with modified stack frame",
2070 insn->sec, insn->offset);
2071 return -1;
2072 }
2073
2074 /* leave (mov %rbp, %rsp; pop %rbp) */
2075
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002076 cfi->stack_size = -cfi->regs[CFI_BP].offset - 8;
2077 restore_reg(cfi, CFI_BP);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002078
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002079 if (!cfi->drap) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002080 cfa->base = CFI_SP;
2081 cfa->offset -= 8;
2082 }
2083
2084 break;
2085
2086 case OP_DEST_MEM:
Peter Zijlstraea242132019-02-25 12:50:09 +01002087 if (op->src.type != OP_SRC_POP && op->src.type != OP_SRC_POPF) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002088 WARN_FUNC("unknown stack-related memory operation",
2089 insn->sec, insn->offset);
2090 return -1;
2091 }
2092
2093 /* pop mem */
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002094 cfi->stack_size -= 8;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002095 if (cfa->base == CFI_SP)
2096 cfa->offset -= 8;
2097
2098 break;
2099
2100 default:
2101 WARN_FUNC("unknown stack-related instruction",
2102 insn->sec, insn->offset);
2103 return -1;
2104 }
2105
2106 return 0;
2107}
2108
Julien Thierry65ea47d2020-03-27 15:28:47 +00002109static int handle_insn_ops(struct instruction *insn, struct insn_state *state)
2110{
2111 struct stack_op *op;
2112
2113 list_for_each_entry(op, &insn->stack_ops, list) {
Peter Zijlstraab3852a2020-05-08 12:34:33 +02002114 struct cfi_state old_cfi = state->cfi;
Julien Thierry65ea47d2020-03-27 15:28:47 +00002115 int res;
2116
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002117 res = update_cfi_state(insn, &state->cfi, op);
Julien Thierry65ea47d2020-03-27 15:28:47 +00002118 if (res)
2119 return res;
2120
Peter Zijlstraab3852a2020-05-08 12:34:33 +02002121 if (insn->alt_group && memcmp(&state->cfi, &old_cfi, sizeof(struct cfi_state))) {
2122 WARN_FUNC("alternative modifies stack", insn->sec, insn->offset);
2123 return -1;
2124 }
2125
Julien Thierry65ea47d2020-03-27 15:28:47 +00002126 if (op->dest.type == OP_DEST_PUSHF) {
2127 if (!state->uaccess_stack) {
2128 state->uaccess_stack = 1;
2129 } else if (state->uaccess_stack >> 31) {
2130 WARN_FUNC("PUSHF stack exhausted",
2131 insn->sec, insn->offset);
2132 return 1;
2133 }
2134 state->uaccess_stack <<= 1;
2135 state->uaccess_stack |= state->uaccess;
2136 }
2137
2138 if (op->src.type == OP_SRC_POPF) {
2139 if (state->uaccess_stack) {
2140 state->uaccess = state->uaccess_stack & 1;
2141 state->uaccess_stack >>= 1;
2142 if (state->uaccess_stack == 1)
2143 state->uaccess_stack = 0;
2144 }
2145 }
2146 }
2147
2148 return 0;
2149}
2150
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002151static bool insn_cfi_match(struct instruction *insn, struct cfi_state *cfi2)
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002152{
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002153 struct cfi_state *cfi1 = &insn->cfi;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002154 int i;
2155
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002156 if (memcmp(&cfi1->cfa, &cfi2->cfa, sizeof(cfi1->cfa))) {
2157
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002158 WARN_FUNC("stack state mismatch: cfa1=%d%+d cfa2=%d%+d",
2159 insn->sec, insn->offset,
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002160 cfi1->cfa.base, cfi1->cfa.offset,
2161 cfi2->cfa.base, cfi2->cfa.offset);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002162
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002163 } else if (memcmp(&cfi1->regs, &cfi2->regs, sizeof(cfi1->regs))) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002164 for (i = 0; i < CFI_NUM_REGS; i++) {
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002165 if (!memcmp(&cfi1->regs[i], &cfi2->regs[i],
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002166 sizeof(struct cfi_reg)))
2167 continue;
2168
2169 WARN_FUNC("stack state mismatch: reg1[%d]=%d%+d reg2[%d]=%d%+d",
2170 insn->sec, insn->offset,
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002171 i, cfi1->regs[i].base, cfi1->regs[i].offset,
2172 i, cfi2->regs[i].base, cfi2->regs[i].offset);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002173 break;
2174 }
2175
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002176 } else if (cfi1->type != cfi2->type) {
Josh Poimboeuf627fce12017-07-11 10:33:42 -05002177
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002178 WARN_FUNC("stack state mismatch: type1=%d type2=%d",
2179 insn->sec, insn->offset, cfi1->type, cfi2->type);
2180
2181 } else if (cfi1->drap != cfi2->drap ||
2182 (cfi1->drap && cfi1->drap_reg != cfi2->drap_reg) ||
2183 (cfi1->drap && cfi1->drap_offset != cfi2->drap_offset)) {
2184
Josh Poimboeufbf4d1a82017-08-10 16:37:26 -05002185 WARN_FUNC("stack state mismatch: drap1=%d(%d,%d) drap2=%d(%d,%d)",
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002186 insn->sec, insn->offset,
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002187 cfi1->drap, cfi1->drap_reg, cfi1->drap_offset,
2188 cfi2->drap, cfi2->drap_reg, cfi2->drap_offset);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002189
2190 } else
2191 return true;
2192
2193 return false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002194}
2195
Peter Zijlstraea242132019-02-25 12:50:09 +01002196static inline bool func_uaccess_safe(struct symbol *func)
2197{
2198 if (func)
Josh Poimboeufe10cd8f2019-07-17 20:36:48 -05002199 return func->uaccess_safe;
Peter Zijlstraea242132019-02-25 12:50:09 +01002200
2201 return false;
2202}
2203
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -05002204static inline const char *call_dest_name(struct instruction *insn)
Peter Zijlstraea242132019-02-25 12:50:09 +01002205{
2206 if (insn->call_dest)
2207 return insn->call_dest->name;
2208
2209 return "{dynamic}";
2210}
2211
2212static int validate_call(struct instruction *insn, struct insn_state *state)
2213{
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002214 if (state->noinstr && state->instr <= 0 &&
Thomas Gleixner0cc9ac8d2020-03-25 17:18:17 +01002215 (!insn->call_dest || !insn->call_dest->sec->noinstr)) {
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002216 WARN_FUNC("call to %s() leaves .noinstr.text section",
2217 insn->sec, insn->offset, call_dest_name(insn));
2218 return 1;
2219 }
2220
Peter Zijlstraea242132019-02-25 12:50:09 +01002221 if (state->uaccess && !func_uaccess_safe(insn->call_dest)) {
2222 WARN_FUNC("call to %s() with UACCESS enabled",
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -05002223 insn->sec, insn->offset, call_dest_name(insn));
Peter Zijlstraea242132019-02-25 12:50:09 +01002224 return 1;
2225 }
2226
Peter Zijlstra2f0f9e92019-02-25 11:10:55 +01002227 if (state->df) {
2228 WARN_FUNC("call to %s() with DF set",
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -05002229 insn->sec, insn->offset, call_dest_name(insn));
Peter Zijlstra2f0f9e92019-02-25 11:10:55 +01002230 return 1;
2231 }
2232
Peter Zijlstraea242132019-02-25 12:50:09 +01002233 return 0;
2234}
2235
Peter Zijlstra54262aa2019-03-06 12:58:15 +01002236static int validate_sibling_call(struct instruction *insn, struct insn_state *state)
2237{
Peter Zijlstrae25eea82020-04-01 16:38:19 +02002238 if (has_modified_stack_frame(insn, state)) {
Peter Zijlstra54262aa2019-03-06 12:58:15 +01002239 WARN_FUNC("sibling call from callable instruction with modified stack frame",
2240 insn->sec, insn->offset);
2241 return 1;
2242 }
2243
Peter Zijlstraea242132019-02-25 12:50:09 +01002244 return validate_call(insn, state);
Peter Zijlstra54262aa2019-03-06 12:58:15 +01002245}
2246
Peter Zijlstraa92e92d2020-03-10 18:07:44 +01002247static int validate_return(struct symbol *func, struct instruction *insn, struct insn_state *state)
2248{
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002249 if (state->noinstr && state->instr > 0) {
2250 WARN_FUNC("return with instrumentation enabled",
2251 insn->sec, insn->offset);
2252 return 1;
2253 }
2254
Peter Zijlstraa92e92d2020-03-10 18:07:44 +01002255 if (state->uaccess && !func_uaccess_safe(func)) {
2256 WARN_FUNC("return with UACCESS enabled",
2257 insn->sec, insn->offset);
2258 return 1;
2259 }
2260
2261 if (!state->uaccess && func_uaccess_safe(func)) {
2262 WARN_FUNC("return with UACCESS disabled from a UACCESS-safe function",
2263 insn->sec, insn->offset);
2264 return 1;
2265 }
2266
2267 if (state->df) {
2268 WARN_FUNC("return with DF set",
2269 insn->sec, insn->offset);
2270 return 1;
2271 }
2272
Peter Zijlstrae25eea82020-04-01 16:38:19 +02002273 if (func && has_modified_stack_frame(insn, state)) {
Peter Zijlstraa92e92d2020-03-10 18:07:44 +01002274 WARN_FUNC("return with modified stack frame",
2275 insn->sec, insn->offset);
2276 return 1;
2277 }
2278
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002279 if (state->cfi.bp_scratch) {
Josh Poimboeufb2966952020-04-01 13:23:29 -05002280 WARN_FUNC("BP used as a scratch register",
2281 insn->sec, insn->offset);
Peter Zijlstraa92e92d2020-03-10 18:07:44 +01002282 return 1;
2283 }
2284
2285 return 0;
2286}
2287
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002288/*
Peter Zijlstra7117f162020-04-28 19:37:01 +02002289 * Alternatives should not contain any ORC entries, this in turn means they
2290 * should not contain any CFI ops, which implies all instructions should have
2291 * the same same CFI state.
2292 *
2293 * It is possible to constuct alternatives that have unreachable holes that go
2294 * unreported (because they're NOPs), such holes would result in CFI_UNDEFINED
2295 * states which then results in ORC entries, which we just said we didn't want.
2296 *
2297 * Avoid them by copying the CFI entry of the first instruction into the whole
2298 * alternative.
2299 */
2300static void fill_alternative_cfi(struct objtool_file *file, struct instruction *insn)
2301{
2302 struct instruction *first_insn = insn;
2303 int alt_group = insn->alt_group;
2304
2305 sec_for_each_insn_continue(file, insn) {
2306 if (insn->alt_group != alt_group)
2307 break;
2308 insn->cfi = first_insn->cfi;
2309 }
2310}
2311
2312/*
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002313 * Follow the branch starting at the given instruction, and recursively follow
2314 * any other branches (jumps). Meanwhile, track the frame pointer state at
2315 * each instruction and validate all the rules described in
2316 * tools/objtool/Documentation/stack-validation.txt.
2317 */
Josh Poimboeufc705cec2019-07-17 20:36:47 -05002318static int validate_branch(struct objtool_file *file, struct symbol *func,
Peter Zijlstrab7460462020-04-02 10:15:51 +02002319 struct instruction *insn, struct insn_state state)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002320{
2321 struct alternative *alt;
Peter Zijlstrab7460462020-04-02 10:15:51 +02002322 struct instruction *next_insn;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002323 struct section *sec;
Peter Zijlstra882a0db2019-07-24 17:47:26 -05002324 u8 visited;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002325 int ret;
2326
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002327 sec = insn->sec;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002328
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002329 while (1) {
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002330 next_insn = next_insn_same_sec(file, insn);
2331
Josh Poimboeuf13810432018-05-09 22:39:15 -05002332 if (file->c_file && func && insn->func && func != insn->func->pfunc) {
Josh Poimboeufee976382017-08-11 12:24:15 -05002333 WARN("%s() falls through to next function %s()",
2334 func->name, insn->func->name);
2335 return 1;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002336 }
2337
Josh Poimboeuf48550222017-07-07 09:19:42 -05002338 if (func && insn->ignore) {
2339 WARN_FUNC("BUG: why am I validating an ignored function?",
2340 sec, insn->offset);
Josh Poimboeuf12b25722017-08-10 16:37:25 -05002341 return 1;
Josh Poimboeuf48550222017-07-07 09:19:42 -05002342 }
2343
Peter Zijlstra882a0db2019-07-24 17:47:26 -05002344 visited = 1 << state.uaccess;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002345 if (insn->visited) {
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002346 if (!insn->hint && !insn_cfi_match(insn, &state.cfi))
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002347 return 1;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002348
Peter Zijlstra882a0db2019-07-24 17:47:26 -05002349 if (insn->visited & visited)
Peter Zijlstraea242132019-02-25 12:50:09 +01002350 return 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002351 }
2352
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002353 if (state.noinstr)
2354 state.instr += insn->instr;
2355
Peter Zijlstrac536ed22020-04-01 16:54:26 +02002356 if (insn->hint)
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002357 state.cfi = insn->cfi;
Peter Zijlstrac536ed22020-04-01 16:54:26 +02002358 else
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002359 insn->cfi = state.cfi;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002360
Peter Zijlstra882a0db2019-07-24 17:47:26 -05002361 insn->visited |= visited;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002362
Peter Zijlstra7117f162020-04-28 19:37:01 +02002363 if (!insn->ignore_alts && !list_empty(&insn->alts)) {
Peter Zijlstra764eef42019-03-01 11:19:03 +01002364 bool skip_orig = false;
2365
Josh Poimboeufa845c7c2018-01-29 22:00:39 -06002366 list_for_each_entry(alt, &insn->alts, list) {
Peter Zijlstra764eef42019-03-01 11:19:03 +01002367 if (alt->skip_orig)
2368 skip_orig = true;
2369
Josh Poimboeufc705cec2019-07-17 20:36:47 -05002370 ret = validate_branch(file, func, alt->insn, state);
Peter Zijlstra7697eee2019-03-01 11:15:49 +01002371 if (ret) {
2372 if (backtrace)
2373 BT_FUNC("(alt)", insn);
2374 return ret;
2375 }
Josh Poimboeufa845c7c2018-01-29 22:00:39 -06002376 }
Peter Zijlstra764eef42019-03-01 11:19:03 +01002377
Peter Zijlstra7117f162020-04-28 19:37:01 +02002378 if (insn->alt_group)
2379 fill_alternative_cfi(file, insn);
2380
Peter Zijlstra764eef42019-03-01 11:19:03 +01002381 if (skip_orig)
2382 return 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002383 }
2384
Peter Zijlstra60041bc2020-04-24 16:16:41 +02002385 if (handle_insn_ops(insn, &state))
2386 return 1;
2387
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002388 switch (insn->type) {
2389
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002390 case INSN_RETURN:
Peter Zijlstraa92e92d2020-03-10 18:07:44 +01002391 return validate_return(func, insn, &state);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002392
2393 case INSN_CALL:
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002394 case INSN_CALL_DYNAMIC:
Peter Zijlstraea242132019-02-25 12:50:09 +01002395 ret = validate_call(insn, &state);
2396 if (ret)
2397 return ret;
2398
Josh Poimboeufc9bab222019-07-17 20:36:51 -05002399 if (!no_fp && func && !is_fentry_call(insn) &&
2400 !has_valid_stack_frame(&state)) {
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002401 WARN_FUNC("call without frame pointer save/setup",
2402 sec, insn->offset);
2403 return 1;
2404 }
Josh Poimboeufc9bab222019-07-17 20:36:51 -05002405
2406 if (dead_end_function(file, insn->call_dest))
2407 return 0;
2408
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002409 break;
2410
2411 case INSN_JUMP_CONDITIONAL:
2412 case INSN_JUMP_UNCONDITIONAL:
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -05002413 if (func && is_sibling_call(insn)) {
Peter Zijlstra54262aa2019-03-06 12:58:15 +01002414 ret = validate_sibling_call(insn, &state);
2415 if (ret)
2416 return ret;
2417
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -05002418 } else if (insn->jump_dest) {
Josh Poimboeufc705cec2019-07-17 20:36:47 -05002419 ret = validate_branch(file, func,
2420 insn->jump_dest, state);
Peter Zijlstra7697eee2019-03-01 11:15:49 +01002421 if (ret) {
2422 if (backtrace)
2423 BT_FUNC("(branch)", insn);
2424 return ret;
2425 }
Josh Poimboeuf48550222017-07-07 09:19:42 -05002426 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002427
2428 if (insn->type == INSN_JUMP_UNCONDITIONAL)
2429 return 0;
2430
2431 break;
2432
2433 case INSN_JUMP_DYNAMIC:
Josh Poimboeufb68b9902019-07-17 20:36:57 -05002434 case INSN_JUMP_DYNAMIC_CONDITIONAL:
Josh Poimboeuf0c1ddd32019-07-17 20:36:52 -05002435 if (func && is_sibling_call(insn)) {
Peter Zijlstra54262aa2019-03-06 12:58:15 +01002436 ret = validate_sibling_call(insn, &state);
2437 if (ret)
2438 return ret;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002439 }
2440
Josh Poimboeufb68b9902019-07-17 20:36:57 -05002441 if (insn->type == INSN_JUMP_DYNAMIC)
2442 return 0;
2443
2444 break;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002445
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002446 case INSN_CONTEXT_SWITCH:
2447 if (func && (!next_insn || !next_insn->hint)) {
2448 WARN_FUNC("unsupported instruction in callable function",
2449 sec, insn->offset);
2450 return 1;
2451 }
2452 return 0;
2453
Peter Zijlstraea242132019-02-25 12:50:09 +01002454 case INSN_STAC:
2455 if (state.uaccess) {
2456 WARN_FUNC("recursive UACCESS enable", sec, insn->offset);
2457 return 1;
2458 }
2459
2460 state.uaccess = true;
2461 break;
2462
2463 case INSN_CLAC:
Josh Poimboeufc705cec2019-07-17 20:36:47 -05002464 if (!state.uaccess && func) {
Peter Zijlstraea242132019-02-25 12:50:09 +01002465 WARN_FUNC("redundant UACCESS disable", sec, insn->offset);
2466 return 1;
2467 }
2468
2469 if (func_uaccess_safe(func) && !state.uaccess_stack) {
2470 WARN_FUNC("UACCESS-safe disables UACCESS", sec, insn->offset);
2471 return 1;
2472 }
2473
2474 state.uaccess = false;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002475 break;
2476
Peter Zijlstra2f0f9e92019-02-25 11:10:55 +01002477 case INSN_STD:
2478 if (state.df)
2479 WARN_FUNC("recursive STD", sec, insn->offset);
2480
2481 state.df = true;
2482 break;
2483
2484 case INSN_CLD:
Josh Poimboeufc705cec2019-07-17 20:36:47 -05002485 if (!state.df && func)
Peter Zijlstra2f0f9e92019-02-25 11:10:55 +01002486 WARN_FUNC("redundant CLD", sec, insn->offset);
2487
2488 state.df = false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002489 break;
2490
2491 default:
2492 break;
2493 }
2494
2495 if (insn->dead_end)
2496 return 0;
2497
Josh Poimboeuf00d96182017-09-18 21:43:30 -05002498 if (!next_insn) {
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002499 if (state.cfi.cfa.base == CFI_UNDEFINED)
Josh Poimboeuf00d96182017-09-18 21:43:30 -05002500 return 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002501 WARN("%s: unexpected end of section", sec->name);
2502 return 1;
2503 }
Josh Poimboeuf00d96182017-09-18 21:43:30 -05002504
2505 insn = next_insn;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002506 }
2507
2508 return 0;
2509}
2510
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002511static int validate_unwind_hints(struct objtool_file *file, struct section *sec)
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002512{
2513 struct instruction *insn;
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002514 struct insn_state state;
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002515 int ret, warnings = 0;
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002516
2517 if (!file->hints)
2518 return 0;
2519
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002520 init_insn_state(&state, sec);
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002521
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002522 if (sec) {
2523 insn = find_insn(file, sec, 0);
2524 if (!insn)
2525 return 0;
2526 } else {
2527 insn = list_first_entry(&file->insn_list, typeof(*insn), list);
2528 }
2529
2530 while (&insn->list != &file->insn_list && (!sec || insn->sec == sec)) {
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002531 if (insn->hint && !insn->visited) {
Josh Poimboeufc705cec2019-07-17 20:36:47 -05002532 ret = validate_branch(file, insn->func, insn, state);
Peter Zijlstra7697eee2019-03-01 11:15:49 +01002533 if (ret && backtrace)
2534 BT_FUNC("<=== (hint)", insn);
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002535 warnings += ret;
2536 }
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002537
2538 insn = list_next_entry(insn, list);
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002539 }
2540
2541 return warnings;
2542}
2543
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01002544static int validate_retpoline(struct objtool_file *file)
2545{
2546 struct instruction *insn;
2547 int warnings = 0;
2548
2549 for_each_insn(file, insn) {
2550 if (insn->type != INSN_JUMP_DYNAMIC &&
2551 insn->type != INSN_CALL_DYNAMIC)
2552 continue;
2553
2554 if (insn->retpoline_safe)
2555 continue;
2556
Peter Zijlstraca41b972018-01-31 10:18:28 +01002557 /*
2558 * .init.text code is ran before userspace and thus doesn't
2559 * strictly need retpolines, except for modules which are
2560 * loaded late, they very much do need retpoline in their
2561 * .init.text
2562 */
2563 if (!strcmp(insn->sec->name, ".init.text") && !module)
2564 continue;
2565
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01002566 WARN_FUNC("indirect %s found in RETPOLINE build",
2567 insn->sec, insn->offset,
2568 insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call");
2569
2570 warnings++;
2571 }
2572
2573 return warnings;
2574}
2575
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002576static bool is_kasan_insn(struct instruction *insn)
2577{
2578 return (insn->type == INSN_CALL &&
2579 !strcmp(insn->call_dest->name, "__asan_handle_no_return"));
2580}
2581
2582static bool is_ubsan_insn(struct instruction *insn)
2583{
2584 return (insn->type == INSN_CALL &&
2585 !strcmp(insn->call_dest->name,
2586 "__ubsan_handle_builtin_unreachable"));
2587}
2588
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002589static bool ignore_unreachable_insn(struct instruction *insn)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002590{
2591 int i;
2592
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002593 if (insn->ignore || insn->type == INSN_NOP)
2594 return true;
2595
2596 /*
2597 * Ignore any unused exceptions. This can happen when a whitelisted
2598 * function has an exception table entry.
Josh Poimboeuf0e2bb2b2017-07-27 15:56:54 -05002599 *
2600 * Also ignore alternative replacement instructions. This can happen
2601 * when a whitelisted function uses one of the ALTERNATIVE macros.
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002602 */
Josh Poimboeuf0e2bb2b2017-07-27 15:56:54 -05002603 if (!strcmp(insn->sec->name, ".fixup") ||
2604 !strcmp(insn->sec->name, ".altinstr_replacement") ||
2605 !strcmp(insn->sec->name, ".altinstr_aux"))
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002606 return true;
2607
Josh Poimboeufbd841d62020-04-01 13:23:25 -05002608 if (!insn->func)
2609 return false;
2610
2611 /*
2612 * CONFIG_UBSAN_TRAP inserts a UD2 when it sees
2613 * __builtin_unreachable(). The BUG() macro has an unreachable() after
2614 * the UD2, which causes GCC's undefined trap logic to emit another UD2
2615 * (or occasionally a JMP to UD2).
2616 */
2617 if (list_prev_entry(insn, list)->dead_end &&
2618 (insn->type == INSN_BUG ||
2619 (insn->type == INSN_JUMP_UNCONDITIONAL &&
2620 insn->jump_dest && insn->jump_dest->type == INSN_BUG)))
2621 return true;
2622
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002623 /*
2624 * Check if this (or a subsequent) instruction is related to
2625 * CONFIG_UBSAN or CONFIG_KASAN.
2626 *
2627 * End the search at 5 instructions to avoid going into the weeds.
2628 */
2629 for (i = 0; i < 5; i++) {
2630
2631 if (is_kasan_insn(insn) || is_ubsan_insn(insn))
2632 return true;
2633
Josh Poimboeuffe24e272018-02-08 17:09:25 -06002634 if (insn->type == INSN_JUMP_UNCONDITIONAL) {
2635 if (insn->jump_dest &&
2636 insn->jump_dest->func == insn->func) {
2637 insn = insn->jump_dest;
2638 continue;
2639 }
2640
2641 break;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002642 }
2643
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002644 if (insn->offset + insn->len >= insn->func->offset + insn->func->len)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002645 break;
Josh Poimboeuffe24e272018-02-08 17:09:25 -06002646
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002647 insn = list_next_entry(insn, list);
2648 }
2649
2650 return false;
2651}
2652
Peter Zijlstra4b5e2e72020-03-23 21:17:50 +01002653static int validate_symbol(struct objtool_file *file, struct section *sec,
2654 struct symbol *sym, struct insn_state *state)
2655{
2656 struct instruction *insn;
2657 int ret;
2658
2659 if (!sym->len) {
2660 WARN("%s() is missing an ELF size annotation", sym->name);
2661 return 1;
2662 }
2663
2664 if (sym->pfunc != sym || sym->alias != sym)
2665 return 0;
2666
2667 insn = find_insn(file, sec, sym->offset);
2668 if (!insn || insn->ignore || insn->visited)
2669 return 0;
2670
2671 state->uaccess = sym->uaccess_safe;
2672
2673 ret = validate_branch(file, insn->func, insn, *state);
2674 if (ret && backtrace)
2675 BT_FUNC("<=== (sym)", insn);
2676 return ret;
2677}
2678
Peter Zijlstra350994b2020-03-23 20:57:13 +01002679static int validate_section(struct objtool_file *file, struct section *sec)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002680{
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002681 struct insn_state state;
Peter Zijlstra4b5e2e72020-03-23 21:17:50 +01002682 struct symbol *func;
2683 int warnings = 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002684
Peter Zijlstra350994b2020-03-23 20:57:13 +01002685 list_for_each_entry(func, &sec->symbol_list, list) {
2686 if (func->type != STT_FUNC)
2687 continue;
Josh Poimboeufe10cd8f2019-07-17 20:36:48 -05002688
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002689 init_insn_state(&state, sec);
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002690 state.cfi.cfa = initial_func_cfi.cfa;
2691 memcpy(&state.cfi.regs, &initial_func_cfi.regs,
Julien Thierry0699e552020-03-27 15:28:40 +00002692 CFI_NUM_REGS * sizeof(struct cfi_reg));
Peter Zijlstrae7c02192020-03-25 14:04:45 +01002693 state.cfi.stack_size = initial_func_cfi.cfa.offset;
Julien Thierry0699e552020-03-27 15:28:40 +00002694
Peter Zijlstra4b5e2e72020-03-23 21:17:50 +01002695 warnings += validate_symbol(file, sec, func, &state);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002696 }
2697
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002698 return warnings;
2699}
2700
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002701static int validate_vmlinux_functions(struct objtool_file *file)
2702{
2703 struct section *sec;
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002704 int warnings = 0;
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002705
2706 sec = find_section_by_name(file->elf, ".noinstr.text");
Thomas Gleixner0cc9ac8d2020-03-25 17:18:17 +01002707 if (sec) {
2708 warnings += validate_section(file, sec);
2709 warnings += validate_unwind_hints(file, sec);
2710 }
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002711
Thomas Gleixner0cc9ac8d2020-03-25 17:18:17 +01002712 sec = find_section_by_name(file->elf, ".entry.text");
2713 if (sec) {
2714 warnings += validate_section(file, sec);
2715 warnings += validate_unwind_hints(file, sec);
2716 }
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002717
2718 return warnings;
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002719}
2720
Peter Zijlstra350994b2020-03-23 20:57:13 +01002721static int validate_functions(struct objtool_file *file)
2722{
2723 struct section *sec;
2724 int warnings = 0;
2725
Peter Zijlstrada837bd2020-03-23 21:11:14 +01002726 for_each_sec(file, sec) {
2727 if (!(sec->sh.sh_flags & SHF_EXECINSTR))
2728 continue;
2729
Peter Zijlstra350994b2020-03-23 20:57:13 +01002730 warnings += validate_section(file, sec);
Peter Zijlstrada837bd2020-03-23 21:11:14 +01002731 }
Peter Zijlstra350994b2020-03-23 20:57:13 +01002732
2733 return warnings;
2734}
2735
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002736static int validate_reachable_instructions(struct objtool_file *file)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002737{
2738 struct instruction *insn;
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002739
2740 if (file->ignore_unreachables)
2741 return 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002742
2743 for_each_insn(file, insn) {
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002744 if (insn->visited || ignore_unreachable_insn(insn))
2745 continue;
2746
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002747 WARN_FUNC("unreachable instruction", insn->sec, insn->offset);
2748 return 1;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002749 }
2750
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002751 return 0;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002752}
2753
Josh Poimboeuf0c671812019-03-18 19:09:38 -05002754static struct objtool_file file;
2755
Peter Zijlstra43a45252018-01-16 17:16:32 +01002756int check(const char *_objname, bool orc)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002757{
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002758 int ret, warnings = 0;
2759
2760 objname = _objname;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002761
Peter Zijlstra2b10be22020-04-17 23:15:00 +02002762 file.elf = elf_open_read(objname, O_RDWR);
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002763 if (!file.elf)
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002764 return 1;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002765
2766 INIT_LIST_HEAD(&file.insn_list);
2767 hash_init(file.insn_hash);
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002768 file.c_file = find_section_by_name(file.elf, ".comment");
Josh Poimboeuf867ac9d2017-07-24 18:34:14 -05002769 file.ignore_unreachables = no_unreachable;
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002770 file.hints = false;
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002771
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002772 arch_initial_func_cfi_state(&initial_func_cfi);
2773
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002774 ret = decode_sections(&file);
2775 if (ret < 0)
2776 goto out;
2777 warnings += ret;
2778
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002779 if (list_empty(&file.insn_list))
2780 goto out;
2781
Peter Zijlstrac4a33932020-03-10 18:57:41 +01002782 if (vmlinux && !validate_dup) {
2783 ret = validate_vmlinux_functions(&file);
2784 if (ret < 0)
2785 goto out;
2786
2787 warnings += ret;
2788 goto out;
2789 }
2790
Peter Zijlstrab5bc2232018-01-16 10:24:06 +01002791 if (retpoline) {
2792 ret = validate_retpoline(&file);
2793 if (ret < 0)
2794 return ret;
2795 warnings += ret;
2796 }
2797
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002798 ret = validate_functions(&file);
2799 if (ret < 0)
2800 goto out;
2801 warnings += ret;
2802
Peter Zijlstra932f8e92020-03-23 18:26:03 +01002803 ret = validate_unwind_hints(&file, NULL);
Josh Poimboeuf39358a02017-07-11 10:33:43 -05002804 if (ret < 0)
2805 goto out;
2806 warnings += ret;
2807
Josh Poimboeufbaa41462017-06-28 10:11:07 -05002808 if (!warnings) {
2809 ret = validate_reachable_instructions(&file);
2810 if (ret < 0)
2811 goto out;
2812 warnings += ret;
2813 }
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002814
Josh Poimboeuf627fce12017-07-11 10:33:42 -05002815 if (orc) {
2816 ret = create_orc(&file);
2817 if (ret < 0)
2818 goto out;
2819
2820 ret = create_orc_sections(&file);
2821 if (ret < 0)
2822 goto out;
Peter Zijlstra2b10be22020-04-17 23:15:00 +02002823 }
Josh Poimboeuf627fce12017-07-11 10:33:42 -05002824
Peter Zijlstra2b10be22020-04-17 23:15:00 +02002825 if (file.elf->changed) {
Josh Poimboeuf627fce12017-07-11 10:33:42 -05002826 ret = elf_write(file.elf);
2827 if (ret < 0)
2828 goto out;
2829 }
2830
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002831out:
Josh Poimboeuf644592d2020-02-10 12:32:38 -06002832 if (ret < 0) {
2833 /*
2834 * Fatal error. The binary is corrupt or otherwise broken in
2835 * some way, or objtool itself is broken. Fail the kernel
2836 * build.
2837 */
2838 return ret;
2839 }
2840
Josh Poimboeufdcc914f2017-06-28 10:11:05 -05002841 return 0;
2842}