Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 1 | /* |
| 2 | * linux/fs/lockd/host.c |
| 3 | * |
| 4 | * Management for NLM peer hosts. The nlm_host struct is shared |
| 5 | * between client and server implementation. The only reason to |
| 6 | * do so is to reduce code bloat. |
| 7 | * |
| 8 | * Copyright (C) 1996, Olaf Kirch <okir@monad.swb.de> |
| 9 | */ |
| 10 | |
| 11 | #include <linux/types.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 12 | #include <linux/slab.h> |
| 13 | #include <linux/in.h> |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 14 | #include <linux/in6.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 15 | #include <linux/sunrpc/clnt.h> |
| 16 | #include <linux/sunrpc/svc.h> |
| 17 | #include <linux/lockd/lockd.h> |
| 18 | #include <linux/lockd/sm_inter.h> |
Ingo Molnar | 353ab6e | 2006-03-26 01:37:12 -0800 | [diff] [blame] | 19 | #include <linux/mutex.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 20 | |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 21 | #include <net/ipv6.h> |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 22 | |
| 23 | #define NLMDBG_FACILITY NLMDBG_HOSTCACHE |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 24 | #define NLM_HOST_NRHASH 32 |
| 25 | #define NLM_ADDRHASH(addr) (ntohl(addr) & (NLM_HOST_NRHASH-1)) |
| 26 | #define NLM_HOST_REBIND (60 * HZ) |
NeilBrown | 1447d25 | 2008-02-08 13:03:37 +1100 | [diff] [blame] | 27 | #define NLM_HOST_EXPIRE (300 * HZ) |
| 28 | #define NLM_HOST_COLLECT (120 * HZ) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 29 | |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 30 | static struct hlist_head nlm_hosts[NLM_HOST_NRHASH]; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 31 | static unsigned long next_gc; |
| 32 | static int nrhosts; |
Ingo Molnar | 353ab6e | 2006-03-26 01:37:12 -0800 | [diff] [blame] | 33 | static DEFINE_MUTEX(nlm_host_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 34 | |
| 35 | |
| 36 | static void nlm_gc_hosts(void); |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 37 | static struct nsm_handle * __nsm_find(const struct sockaddr_in *, |
Chuck Lever | 48df020a | 2007-11-01 16:56:53 -0400 | [diff] [blame] | 38 | const char *, unsigned int, int); |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 39 | static struct nsm_handle * nsm_find(const struct sockaddr_in *sin, |
| 40 | const char *hostname, |
Chuck Lever | 48df020a | 2007-11-01 16:56:53 -0400 | [diff] [blame] | 41 | unsigned int hostname_len); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 42 | |
Chuck Lever | 396cb3d | 2008-08-27 16:57:38 -0400 | [diff] [blame] | 43 | static void nlm_clear_port(struct sockaddr *sap) |
| 44 | { |
| 45 | switch (sap->sa_family) { |
| 46 | case AF_INET: |
| 47 | ((struct sockaddr_in *)sap)->sin_port = 0; |
| 48 | break; |
| 49 | case AF_INET6: |
| 50 | ((struct sockaddr_in6 *)sap)->sin6_port = 0; |
| 51 | break; |
| 52 | } |
| 53 | } |
| 54 | |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 55 | static void nlm_display_address(const struct sockaddr *sap, |
| 56 | char *buf, const size_t len) |
| 57 | { |
| 58 | const struct sockaddr_in *sin = (struct sockaddr_in *)sap; |
| 59 | const struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap; |
| 60 | |
| 61 | switch (sap->sa_family) { |
| 62 | case AF_UNSPEC: |
| 63 | snprintf(buf, len, "unspecified"); |
| 64 | break; |
| 65 | case AF_INET: |
| 66 | snprintf(buf, len, NIPQUAD_FMT, NIPQUAD(sin->sin_addr.s_addr)); |
| 67 | break; |
| 68 | case AF_INET6: |
| 69 | if (ipv6_addr_v4mapped(&sin6->sin6_addr)) |
| 70 | snprintf(buf, len, NIPQUAD_FMT, |
| 71 | NIPQUAD(sin6->sin6_addr.s6_addr32[3])); |
| 72 | else |
| 73 | snprintf(buf, len, NIP6_FMT, NIP6(sin6->sin6_addr)); |
| 74 | break; |
| 75 | default: |
| 76 | snprintf(buf, len, "unsupported address family"); |
| 77 | break; |
| 78 | } |
| 79 | } |
| 80 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 81 | /* |
| 82 | * Common host lookup routine for server & client |
| 83 | */ |
Chuck Lever | eb18860 | 2008-03-14 14:18:37 -0400 | [diff] [blame] | 84 | static struct nlm_host *nlm_lookup_host(int server, |
| 85 | const struct sockaddr_in *sin, |
| 86 | int proto, u32 version, |
| 87 | const char *hostname, |
| 88 | unsigned int hostname_len, |
| 89 | const struct sockaddr_in *ssin) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 90 | { |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 91 | struct hlist_head *chain; |
| 92 | struct hlist_node *pos; |
| 93 | struct nlm_host *host; |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 94 | struct nsm_handle *nsm = NULL; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 95 | int hash; |
| 96 | |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 97 | dprintk("lockd: nlm_lookup_host(proto=%d, vers=%u," |
| 98 | " my role is %s, hostname=%.*s)\n", |
| 99 | proto, version, server ? "server" : "client", |
| 100 | hostname_len, hostname ? hostname : "<none>"); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 101 | |
| 102 | hash = NLM_ADDRHASH(sin->sin_addr.s_addr); |
| 103 | |
| 104 | /* Lock hash table */ |
Ingo Molnar | 353ab6e | 2006-03-26 01:37:12 -0800 | [diff] [blame] | 105 | mutex_lock(&nlm_host_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 106 | |
| 107 | if (time_after_eq(jiffies, next_gc)) |
| 108 | nlm_gc_hosts(); |
| 109 | |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 110 | /* We may keep several nlm_host objects for a peer, because each |
| 111 | * nlm_host is identified by |
| 112 | * (address, protocol, version, server/client) |
| 113 | * We could probably simplify this a little by putting all those |
| 114 | * different NLM rpc_clients into one single nlm_host object. |
| 115 | * This would allow us to have one nlm_host per address. |
| 116 | */ |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 117 | chain = &nlm_hosts[hash]; |
| 118 | hlist_for_each_entry(host, pos, chain, h_hash) { |
Chuck Lever | b4ed58f | 2008-09-03 14:35:39 -0400 | [diff] [blame] | 119 | if (!nlm_cmp_addr(nlm_addr_in(host), sin)) |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 120 | continue; |
| 121 | |
| 122 | /* See if we have an NSM handle for this client */ |
NeilBrown | 6b54dae | 2006-10-04 02:16:15 -0700 | [diff] [blame] | 123 | if (!nsm) |
| 124 | nsm = host->h_nsmhandle; |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 125 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 126 | if (host->h_proto != proto) |
| 127 | continue; |
| 128 | if (host->h_version != version) |
| 129 | continue; |
| 130 | if (host->h_server != server) |
| 131 | continue; |
Chuck Lever | 90151e6 | 2008-09-03 14:35:46 -0400 | [diff] [blame^] | 132 | if (!nlm_cmp_addr(nlm_srcaddr_in(host), ssin)) |
Frank van Maarseveen | c98451b | 2007-07-09 22:25:29 +0200 | [diff] [blame] | 133 | continue; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 134 | |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 135 | /* Move to head of hash chain. */ |
| 136 | hlist_del(&host->h_hash); |
| 137 | hlist_add_head(&host->h_hash, chain); |
| 138 | |
Olaf Kirch | f0737a3 | 2006-10-04 02:15:54 -0700 | [diff] [blame] | 139 | nlm_get_host(host); |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 140 | dprintk("lockd: nlm_lookup_host found host %s (%s)\n", |
| 141 | host->h_name, host->h_addrbuf); |
Olaf Kirch | f0737a3 | 2006-10-04 02:15:54 -0700 | [diff] [blame] | 142 | goto out; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 143 | } |
Chuck Lever | c2526f4 | 2008-08-27 16:57:15 -0400 | [diff] [blame] | 144 | |
| 145 | /* |
| 146 | * The host wasn't in our hash table. If we don't |
| 147 | * have an NSM handle for it yet, create one. |
| 148 | */ |
NeilBrown | 6b54dae | 2006-10-04 02:16:15 -0700 | [diff] [blame] | 149 | if (nsm) |
| 150 | atomic_inc(&nsm->sm_count); |
Chuck Lever | c2526f4 | 2008-08-27 16:57:15 -0400 | [diff] [blame] | 151 | else { |
| 152 | host = NULL; |
| 153 | nsm = nsm_find(sin, hostname, hostname_len); |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 154 | if (!nsm) { |
| 155 | dprintk("lockd: nlm_lookup_host failed; " |
| 156 | "no nsm handle\n"); |
Chuck Lever | c2526f4 | 2008-08-27 16:57:15 -0400 | [diff] [blame] | 157 | goto out; |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 158 | } |
Chuck Lever | c2526f4 | 2008-08-27 16:57:15 -0400 | [diff] [blame] | 159 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 160 | |
Panagiotis Issaris | f8314dc | 2006-09-27 01:49:37 -0700 | [diff] [blame] | 161 | host = kzalloc(sizeof(*host), GFP_KERNEL); |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 162 | if (!host) { |
| 163 | nsm_release(nsm); |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 164 | dprintk("lockd: nlm_lookup_host failed; no memory\n"); |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 165 | goto out; |
| 166 | } |
| 167 | host->h_name = nsm->sm_name; |
Chuck Lever | b4ed58f | 2008-09-03 14:35:39 -0400 | [diff] [blame] | 168 | memcpy(nlm_addr(host), sin, sizeof(*sin)); |
| 169 | host->h_addrlen = sizeof(*sin); |
| 170 | nlm_clear_port(nlm_addr(host)); |
Chuck Lever | 90151e6 | 2008-09-03 14:35:46 -0400 | [diff] [blame^] | 171 | memcpy(nlm_srcaddr(host), ssin, sizeof(*ssin)); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 172 | host->h_version = version; |
| 173 | host->h_proto = proto; |
| 174 | host->h_rpcclnt = NULL; |
Trond Myklebust | 5046791 | 2006-06-09 09:40:24 -0400 | [diff] [blame] | 175 | mutex_init(&host->h_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 176 | host->h_nextrebind = jiffies + NLM_HOST_REBIND; |
| 177 | host->h_expires = jiffies + NLM_HOST_EXPIRE; |
| 178 | atomic_set(&host->h_count, 1); |
| 179 | init_waitqueue_head(&host->h_gracewait); |
Trond Myklebust | 28df955 | 2006-06-09 09:40:27 -0400 | [diff] [blame] | 180 | init_rwsem(&host->h_rwsem); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 181 | host->h_state = 0; /* pseudo NSM state */ |
| 182 | host->h_nsmstate = 0; /* real NSM state */ |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 183 | host->h_nsmhandle = nsm; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 184 | host->h_server = server; |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 185 | hlist_add_head(&host->h_hash, chain); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 186 | INIT_LIST_HEAD(&host->h_lockowners); |
| 187 | spin_lock_init(&host->h_lock); |
Christoph Hellwig | 26bcbf9 | 2006-03-20 13:44:40 -0500 | [diff] [blame] | 188 | INIT_LIST_HEAD(&host->h_granted); |
| 189 | INIT_LIST_HEAD(&host->h_reclaim); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 190 | |
NeilBrown | 1447d25 | 2008-02-08 13:03:37 +1100 | [diff] [blame] | 191 | nrhosts++; |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 192 | |
| 193 | nlm_display_address((struct sockaddr *)&host->h_addr, |
| 194 | host->h_addrbuf, sizeof(host->h_addrbuf)); |
Chuck Lever | 90151e6 | 2008-09-03 14:35:46 -0400 | [diff] [blame^] | 195 | nlm_display_address((struct sockaddr *)&host->h_srcaddr, |
| 196 | host->h_srcaddrbuf, sizeof(host->h_srcaddrbuf)); |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 197 | |
| 198 | dprintk("lockd: nlm_lookup_host created host %s\n", |
| 199 | host->h_name); |
| 200 | |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 201 | out: |
Ingo Molnar | 353ab6e | 2006-03-26 01:37:12 -0800 | [diff] [blame] | 202 | mutex_unlock(&nlm_host_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 203 | return host; |
| 204 | } |
| 205 | |
Olaf Kirch | c53c1bb | 2006-10-04 02:16:00 -0700 | [diff] [blame] | 206 | /* |
| 207 | * Destroy a host |
| 208 | */ |
| 209 | static void |
| 210 | nlm_destroy_host(struct nlm_host *host) |
| 211 | { |
| 212 | struct rpc_clnt *clnt; |
| 213 | |
| 214 | BUG_ON(!list_empty(&host->h_lockowners)); |
| 215 | BUG_ON(atomic_read(&host->h_count)); |
| 216 | |
| 217 | /* |
| 218 | * Release NSM handle and unmonitor host. |
| 219 | */ |
| 220 | nsm_unmonitor(host); |
| 221 | |
Trond Myklebust | 34f52e3 | 2007-06-14 16:40:31 -0400 | [diff] [blame] | 222 | clnt = host->h_rpcclnt; |
| 223 | if (clnt != NULL) |
| 224 | rpc_shutdown_client(clnt); |
Olaf Kirch | c53c1bb | 2006-10-04 02:16:00 -0700 | [diff] [blame] | 225 | kfree(host); |
| 226 | } |
| 227 | |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 228 | /* |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 229 | * Find an NLM server handle in the cache. If there is none, create it. |
| 230 | */ |
Chuck Lever | eb18860 | 2008-03-14 14:18:37 -0400 | [diff] [blame] | 231 | struct nlm_host *nlmclnt_lookup_host(const struct sockaddr_in *sin, |
| 232 | int proto, u32 version, |
| 233 | const char *hostname, |
| 234 | unsigned int hostname_len) |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 235 | { |
Chuck Lever | 2860a02 | 2008-08-27 16:57:31 -0400 | [diff] [blame] | 236 | const struct sockaddr_in source = { |
| 237 | .sin_family = AF_UNSPEC, |
| 238 | }; |
Frank van Maarseveen | c98451b | 2007-07-09 22:25:29 +0200 | [diff] [blame] | 239 | |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 240 | return nlm_lookup_host(0, sin, proto, version, |
Chuck Lever | 2860a02 | 2008-08-27 16:57:31 -0400 | [diff] [blame] | 241 | hostname, hostname_len, &source); |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 242 | } |
| 243 | |
| 244 | /* |
| 245 | * Find an NLM client handle in the cache. If there is none, create it. |
| 246 | */ |
| 247 | struct nlm_host * |
| 248 | nlmsvc_lookup_host(struct svc_rqst *rqstp, |
Chuck Lever | 48df020a | 2007-11-01 16:56:53 -0400 | [diff] [blame] | 249 | const char *hostname, unsigned int hostname_len) |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 250 | { |
Chuck Lever | 2860a02 | 2008-08-27 16:57:31 -0400 | [diff] [blame] | 251 | const struct sockaddr_in source = { |
| 252 | .sin_family = AF_INET, |
| 253 | .sin_addr = rqstp->rq_daddr.addr, |
| 254 | }; |
Frank van Maarseveen | c98451b | 2007-07-09 22:25:29 +0200 | [diff] [blame] | 255 | |
Chuck Lever | 27459f0 | 2007-02-12 00:53:34 -0800 | [diff] [blame] | 256 | return nlm_lookup_host(1, svc_addr_in(rqstp), |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 257 | rqstp->rq_prot, rqstp->rq_vers, |
Chuck Lever | 2860a02 | 2008-08-27 16:57:31 -0400 | [diff] [blame] | 258 | hostname, hostname_len, &source); |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 259 | } |
| 260 | |
| 261 | /* |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 262 | * Create the NLM RPC client for an NLM peer |
| 263 | */ |
| 264 | struct rpc_clnt * |
| 265 | nlm_bind_host(struct nlm_host *host) |
| 266 | { |
| 267 | struct rpc_clnt *clnt; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 268 | |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 269 | dprintk("lockd: nlm_bind_host %s (%s), my addr=%s\n", |
Chuck Lever | 90151e6 | 2008-09-03 14:35:46 -0400 | [diff] [blame^] | 270 | host->h_name, host->h_addrbuf, host->h_srcaddrbuf); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 271 | |
| 272 | /* Lock host handle */ |
Trond Myklebust | 5046791 | 2006-06-09 09:40:24 -0400 | [diff] [blame] | 273 | mutex_lock(&host->h_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 274 | |
| 275 | /* If we've already created an RPC client, check whether |
| 276 | * RPC rebind is required |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 277 | */ |
| 278 | if ((clnt = host->h_rpcclnt) != NULL) { |
Chuck Lever | 43118c2 | 2005-08-25 16:25:49 -0700 | [diff] [blame] | 279 | if (time_after_eq(jiffies, host->h_nextrebind)) { |
Chuck Lever | 35f5a42 | 2006-01-03 09:55:50 +0100 | [diff] [blame] | 280 | rpc_force_rebind(clnt); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 281 | host->h_nextrebind = jiffies + NLM_HOST_REBIND; |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 282 | dprintk("lockd: next rebind in %lu jiffies\n", |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 283 | host->h_nextrebind - jiffies); |
| 284 | } |
| 285 | } else { |
Trond Myklebust | 21051ba | 2007-05-14 16:50:44 -0400 | [diff] [blame] | 286 | unsigned long increment = nlmsvc_timeout; |
Chuck Lever | e1ec789 | 2006-08-22 20:06:20 -0400 | [diff] [blame] | 287 | struct rpc_timeout timeparms = { |
| 288 | .to_initval = increment, |
| 289 | .to_increment = increment, |
| 290 | .to_maxval = increment * 6UL, |
| 291 | .to_retries = 5U, |
| 292 | }; |
| 293 | struct rpc_create_args args = { |
| 294 | .protocol = host->h_proto, |
Chuck Lever | b4ed58f | 2008-09-03 14:35:39 -0400 | [diff] [blame] | 295 | .address = nlm_addr(host), |
| 296 | .addrsize = host->h_addrlen, |
Chuck Lever | 90151e6 | 2008-09-03 14:35:46 -0400 | [diff] [blame^] | 297 | .saddress = nlm_srcaddr(host), |
Chuck Lever | e1ec789 | 2006-08-22 20:06:20 -0400 | [diff] [blame] | 298 | .timeout = &timeparms, |
| 299 | .servername = host->h_name, |
| 300 | .program = &nlm_program, |
| 301 | .version = host->h_version, |
| 302 | .authflavor = RPC_AUTH_UNIX, |
Jeff Layton | 90bd17c | 2008-02-06 11:34:11 -0500 | [diff] [blame] | 303 | .flags = (RPC_CLNT_CREATE_NOPING | |
Chuck Lever | e1ec789 | 2006-08-22 20:06:20 -0400 | [diff] [blame] | 304 | RPC_CLNT_CREATE_AUTOBIND), |
| 305 | }; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 306 | |
Jeff Layton | 90bd17c | 2008-02-06 11:34:11 -0500 | [diff] [blame] | 307 | /* |
| 308 | * lockd retries server side blocks automatically so we want |
| 309 | * those to be soft RPC calls. Client side calls need to be |
| 310 | * hard RPC tasks. |
| 311 | */ |
| 312 | if (!host->h_server) |
| 313 | args.flags |= RPC_CLNT_CREATE_HARDRTRY; |
| 314 | |
Chuck Lever | e1ec789 | 2006-08-22 20:06:20 -0400 | [diff] [blame] | 315 | clnt = rpc_create(&args); |
| 316 | if (!IS_ERR(clnt)) |
| 317 | host->h_rpcclnt = clnt; |
| 318 | else { |
| 319 | printk("lockd: couldn't create RPC handle for %s\n", host->h_name); |
| 320 | clnt = NULL; |
| 321 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 322 | } |
| 323 | |
Trond Myklebust | 5046791 | 2006-06-09 09:40:24 -0400 | [diff] [blame] | 324 | mutex_unlock(&host->h_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 325 | return clnt; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 326 | } |
| 327 | |
| 328 | /* |
| 329 | * Force a portmap lookup of the remote lockd port |
| 330 | */ |
| 331 | void |
| 332 | nlm_rebind_host(struct nlm_host *host) |
| 333 | { |
| 334 | dprintk("lockd: rebind host %s\n", host->h_name); |
| 335 | if (host->h_rpcclnt && time_after_eq(jiffies, host->h_nextrebind)) { |
Chuck Lever | 35f5a42 | 2006-01-03 09:55:50 +0100 | [diff] [blame] | 336 | rpc_force_rebind(host->h_rpcclnt); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 337 | host->h_nextrebind = jiffies + NLM_HOST_REBIND; |
| 338 | } |
| 339 | } |
| 340 | |
| 341 | /* |
| 342 | * Increment NLM host count |
| 343 | */ |
| 344 | struct nlm_host * nlm_get_host(struct nlm_host *host) |
| 345 | { |
| 346 | if (host) { |
| 347 | dprintk("lockd: get host %s\n", host->h_name); |
| 348 | atomic_inc(&host->h_count); |
| 349 | host->h_expires = jiffies + NLM_HOST_EXPIRE; |
| 350 | } |
| 351 | return host; |
| 352 | } |
| 353 | |
| 354 | /* |
| 355 | * Release NLM host after use |
| 356 | */ |
| 357 | void nlm_release_host(struct nlm_host *host) |
| 358 | { |
| 359 | if (host != NULL) { |
| 360 | dprintk("lockd: release host %s\n", host->h_name); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 361 | BUG_ON(atomic_read(&host->h_count) < 0); |
Trond Myklebust | 4c060b5 | 2006-03-20 13:44:41 -0500 | [diff] [blame] | 362 | if (atomic_dec_and_test(&host->h_count)) { |
| 363 | BUG_ON(!list_empty(&host->h_lockowners)); |
| 364 | BUG_ON(!list_empty(&host->h_granted)); |
| 365 | BUG_ON(!list_empty(&host->h_reclaim)); |
| 366 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 367 | } |
| 368 | } |
| 369 | |
| 370 | /* |
Olaf Kirch | cf712c2 | 2006-10-04 02:15:52 -0700 | [diff] [blame] | 371 | * We were notified that the host indicated by address &sin |
| 372 | * has rebooted. |
| 373 | * Release all resources held by that peer. |
| 374 | */ |
Olaf Kirch | 5c8dd29 | 2006-10-04 02:15:55 -0700 | [diff] [blame] | 375 | void nlm_host_rebooted(const struct sockaddr_in *sin, |
Chuck Lever | 48df020a | 2007-11-01 16:56:53 -0400 | [diff] [blame] | 376 | const char *hostname, |
| 377 | unsigned int hostname_len, |
Olaf Kirch | 5c8dd29 | 2006-10-04 02:15:55 -0700 | [diff] [blame] | 378 | u32 new_state) |
Olaf Kirch | cf712c2 | 2006-10-04 02:15:52 -0700 | [diff] [blame] | 379 | { |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 380 | struct hlist_head *chain; |
| 381 | struct hlist_node *pos; |
Olaf Kirch | 5c8dd29 | 2006-10-04 02:15:55 -0700 | [diff] [blame] | 382 | struct nsm_handle *nsm; |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 383 | struct nlm_host *host; |
Olaf Kirch | cf712c2 | 2006-10-04 02:15:52 -0700 | [diff] [blame] | 384 | |
Olaf Kirch | 5c8dd29 | 2006-10-04 02:15:55 -0700 | [diff] [blame] | 385 | /* Find the NSM handle for this peer */ |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 386 | nsm = __nsm_find(sin, hostname, hostname_len, 0); |
| 387 | if (nsm == NULL) { |
| 388 | dprintk("lockd: never saw rebooted peer '%.*s' before\n", |
| 389 | hostname_len, hostname); |
Olaf Kirch | db4e4c9 | 2006-10-04 02:15:52 -0700 | [diff] [blame] | 390 | return; |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 391 | } |
| 392 | |
| 393 | dprintk("lockd: nlm_host_rebooted(%.*s, %s)\n", |
| 394 | hostname_len, hostname, nsm->sm_addrbuf); |
Olaf Kirch | db4e4c9 | 2006-10-04 02:15:52 -0700 | [diff] [blame] | 395 | |
Olaf Kirch | 5c8dd29 | 2006-10-04 02:15:55 -0700 | [diff] [blame] | 396 | /* When reclaiming locks on this peer, make sure that |
| 397 | * we set up a new notification */ |
| 398 | nsm->sm_monitored = 0; |
| 399 | |
| 400 | /* Mark all hosts tied to this NSM state as having rebooted. |
| 401 | * We run the loop repeatedly, because we drop the host table |
| 402 | * lock for this. |
| 403 | * To avoid processing a host several times, we match the nsmstate. |
| 404 | */ |
| 405 | again: mutex_lock(&nlm_host_mutex); |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 406 | for (chain = nlm_hosts; chain < nlm_hosts + NLM_HOST_NRHASH; ++chain) { |
| 407 | hlist_for_each_entry(host, pos, chain, h_hash) { |
Olaf Kirch | 5c8dd29 | 2006-10-04 02:15:55 -0700 | [diff] [blame] | 408 | if (host->h_nsmhandle == nsm |
| 409 | && host->h_nsmstate != new_state) { |
| 410 | host->h_nsmstate = new_state; |
| 411 | host->h_state++; |
| 412 | |
| 413 | nlm_get_host(host); |
| 414 | mutex_unlock(&nlm_host_mutex); |
| 415 | |
| 416 | if (host->h_server) { |
| 417 | /* We're server for this guy, just ditch |
| 418 | * all the locks he held. */ |
| 419 | nlmsvc_free_host_resources(host); |
| 420 | } else { |
| 421 | /* He's the server, initiate lock recovery. */ |
| 422 | nlmclnt_recovery(host); |
| 423 | } |
| 424 | |
| 425 | nlm_release_host(host); |
| 426 | goto again; |
| 427 | } |
| 428 | } |
Olaf Kirch | cf712c2 | 2006-10-04 02:15:52 -0700 | [diff] [blame] | 429 | } |
Olaf Kirch | 5c8dd29 | 2006-10-04 02:15:55 -0700 | [diff] [blame] | 430 | |
| 431 | mutex_unlock(&nlm_host_mutex); |
Olaf Kirch | cf712c2 | 2006-10-04 02:15:52 -0700 | [diff] [blame] | 432 | } |
| 433 | |
| 434 | /* |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 435 | * Shut down the hosts module. |
| 436 | * Note that this routine is called only at server shutdown time. |
| 437 | */ |
| 438 | void |
| 439 | nlm_shutdown_hosts(void) |
| 440 | { |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 441 | struct hlist_head *chain; |
| 442 | struct hlist_node *pos; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 443 | struct nlm_host *host; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 444 | |
| 445 | dprintk("lockd: shutting down host module\n"); |
Ingo Molnar | 353ab6e | 2006-03-26 01:37:12 -0800 | [diff] [blame] | 446 | mutex_lock(&nlm_host_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 447 | |
| 448 | /* First, make all hosts eligible for gc */ |
| 449 | dprintk("lockd: nuking all hosts...\n"); |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 450 | for (chain = nlm_hosts; chain < nlm_hosts + NLM_HOST_NRHASH; ++chain) { |
Jeff Layton | d801b86 | 2008-01-29 10:30:55 -0500 | [diff] [blame] | 451 | hlist_for_each_entry(host, pos, chain, h_hash) { |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 452 | host->h_expires = jiffies - 1; |
Jeff Layton | d801b86 | 2008-01-29 10:30:55 -0500 | [diff] [blame] | 453 | if (host->h_rpcclnt) { |
| 454 | rpc_shutdown_client(host->h_rpcclnt); |
| 455 | host->h_rpcclnt = NULL; |
| 456 | } |
| 457 | } |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 458 | } |
| 459 | |
| 460 | /* Then, perform a garbage collection pass */ |
| 461 | nlm_gc_hosts(); |
Ingo Molnar | 353ab6e | 2006-03-26 01:37:12 -0800 | [diff] [blame] | 462 | mutex_unlock(&nlm_host_mutex); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 463 | |
| 464 | /* complain if any hosts are left */ |
| 465 | if (nrhosts) { |
| 466 | printk(KERN_WARNING "lockd: couldn't shutdown host module!\n"); |
| 467 | dprintk("lockd: %d hosts left:\n", nrhosts); |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 468 | for (chain = nlm_hosts; chain < nlm_hosts + NLM_HOST_NRHASH; ++chain) { |
| 469 | hlist_for_each_entry(host, pos, chain, h_hash) { |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 470 | dprintk(" %s (cnt %d use %d exp %ld)\n", |
| 471 | host->h_name, atomic_read(&host->h_count), |
| 472 | host->h_inuse, host->h_expires); |
| 473 | } |
| 474 | } |
| 475 | } |
| 476 | } |
| 477 | |
| 478 | /* |
| 479 | * Garbage collect any unused NLM hosts. |
| 480 | * This GC combines reference counting for async operations with |
| 481 | * mark & sweep for resources held by remote clients. |
| 482 | */ |
| 483 | static void |
| 484 | nlm_gc_hosts(void) |
| 485 | { |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 486 | struct hlist_head *chain; |
| 487 | struct hlist_node *pos, *next; |
| 488 | struct nlm_host *host; |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 489 | |
| 490 | dprintk("lockd: host garbage collection\n"); |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 491 | for (chain = nlm_hosts; chain < nlm_hosts + NLM_HOST_NRHASH; ++chain) { |
| 492 | hlist_for_each_entry(host, pos, chain, h_hash) |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 493 | host->h_inuse = 0; |
| 494 | } |
| 495 | |
| 496 | /* Mark all hosts that hold locks, blocks or shares */ |
| 497 | nlmsvc_mark_resources(); |
| 498 | |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 499 | for (chain = nlm_hosts; chain < nlm_hosts + NLM_HOST_NRHASH; ++chain) { |
| 500 | hlist_for_each_entry_safe(host, pos, next, chain, h_hash) { |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 501 | if (atomic_read(&host->h_count) || host->h_inuse |
| 502 | || time_before(jiffies, host->h_expires)) { |
| 503 | dprintk("nlm_gc_hosts skipping %s (cnt %d use %d exp %ld)\n", |
| 504 | host->h_name, atomic_read(&host->h_count), |
| 505 | host->h_inuse, host->h_expires); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 506 | continue; |
| 507 | } |
| 508 | dprintk("lockd: delete host %s\n", host->h_name); |
Olaf Kirch | 0cea327 | 2006-10-04 02:15:56 -0700 | [diff] [blame] | 509 | hlist_del_init(&host->h_hash); |
Olaf Kirch | 977faf3 | 2006-10-04 02:15:51 -0700 | [diff] [blame] | 510 | |
Olaf Kirch | c53c1bb | 2006-10-04 02:16:00 -0700 | [diff] [blame] | 511 | nlm_destroy_host(host); |
Linus Torvalds | 1da177e | 2005-04-16 15:20:36 -0700 | [diff] [blame] | 512 | nrhosts--; |
| 513 | } |
| 514 | } |
| 515 | |
| 516 | next_gc = jiffies + NLM_HOST_COLLECT; |
| 517 | } |
| 518 | |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 519 | |
| 520 | /* |
| 521 | * Manage NSM handles |
| 522 | */ |
| 523 | static LIST_HEAD(nsm_handles); |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 524 | static DEFINE_SPINLOCK(nsm_lock); |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 525 | |
| 526 | static struct nsm_handle * |
| 527 | __nsm_find(const struct sockaddr_in *sin, |
Chuck Lever | 48df020a | 2007-11-01 16:56:53 -0400 | [diff] [blame] | 528 | const char *hostname, unsigned int hostname_len, |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 529 | int create) |
| 530 | { |
| 531 | struct nsm_handle *nsm = NULL; |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 532 | struct nsm_handle *pos; |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 533 | |
| 534 | if (!sin) |
| 535 | return NULL; |
| 536 | |
| 537 | if (hostname && memchr(hostname, '/', hostname_len) != NULL) { |
| 538 | if (printk_ratelimit()) { |
| 539 | printk(KERN_WARNING "Invalid hostname \"%.*s\" " |
| 540 | "in NFS lock request\n", |
| 541 | hostname_len, hostname); |
| 542 | } |
| 543 | return NULL; |
| 544 | } |
| 545 | |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 546 | retry: |
| 547 | spin_lock(&nsm_lock); |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 548 | list_for_each_entry(pos, &nsm_handles, sm_link) { |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 549 | |
Olaf Kirch | abd1f50 | 2006-10-04 02:16:01 -0700 | [diff] [blame] | 550 | if (hostname && nsm_use_hostnames) { |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 551 | if (strlen(pos->sm_name) != hostname_len |
| 552 | || memcmp(pos->sm_name, hostname, hostname_len)) |
Olaf Kirch | abd1f50 | 2006-10-04 02:16:01 -0700 | [diff] [blame] | 553 | continue; |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 554 | } else if (!nlm_cmp_addr(&pos->sm_addr, sin)) |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 555 | continue; |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 556 | atomic_inc(&pos->sm_count); |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 557 | kfree(nsm); |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 558 | nsm = pos; |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 559 | goto found; |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 560 | } |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 561 | if (nsm) { |
| 562 | list_add(&nsm->sm_link, &nsm_handles); |
| 563 | goto found; |
| 564 | } |
| 565 | spin_unlock(&nsm_lock); |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 566 | |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 567 | if (!create) |
| 568 | return NULL; |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 569 | |
| 570 | nsm = kzalloc(sizeof(*nsm) + hostname_len + 1, GFP_KERNEL); |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 571 | if (nsm == NULL) |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 572 | return NULL; |
| 573 | |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 574 | nsm->sm_addr = *sin; |
| 575 | nsm->sm_name = (char *) (nsm + 1); |
| 576 | memcpy(nsm->sm_name, hostname, hostname_len); |
| 577 | nsm->sm_name[hostname_len] = '\0'; |
Chuck Lever | 1b333c5 | 2008-08-27 16:57:23 -0400 | [diff] [blame] | 578 | nlm_display_address((struct sockaddr *)&nsm->sm_addr, |
| 579 | nsm->sm_addrbuf, sizeof(nsm->sm_addrbuf)); |
J. Bruce Fields | a95e56e | 2008-02-20 15:27:31 -0500 | [diff] [blame] | 580 | atomic_set(&nsm->sm_count, 1); |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 581 | goto retry; |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 582 | |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 583 | found: |
| 584 | spin_unlock(&nsm_lock); |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 585 | return nsm; |
| 586 | } |
| 587 | |
Adrian Bunk | c585646 | 2006-12-06 20:38:29 -0800 | [diff] [blame] | 588 | static struct nsm_handle * |
Chuck Lever | 48df020a | 2007-11-01 16:56:53 -0400 | [diff] [blame] | 589 | nsm_find(const struct sockaddr_in *sin, const char *hostname, |
| 590 | unsigned int hostname_len) |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 591 | { |
| 592 | return __nsm_find(sin, hostname, hostname_len, 1); |
| 593 | } |
| 594 | |
| 595 | /* |
| 596 | * Release an NSM handle |
| 597 | */ |
| 598 | void |
| 599 | nsm_release(struct nsm_handle *nsm) |
| 600 | { |
| 601 | if (!nsm) |
| 602 | return; |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 603 | if (atomic_dec_and_lock(&nsm->sm_count, &nsm_lock)) { |
J. Bruce Fields | 164f98a | 2008-02-20 14:02:47 -0500 | [diff] [blame] | 604 | list_del(&nsm->sm_link); |
J. Bruce Fields | d842120 | 2008-02-20 15:40:15 -0500 | [diff] [blame] | 605 | spin_unlock(&nsm_lock); |
J. Bruce Fields | 164f98a | 2008-02-20 14:02:47 -0500 | [diff] [blame] | 606 | kfree(nsm); |
Olaf Kirch | 8dead0d | 2006-10-04 02:15:53 -0700 | [diff] [blame] | 607 | } |
| 608 | } |