blob: 9617b7df7c4da2f6092d10f2971a6ef1b022b131 [file] [log] [blame]
Rob Herringaf6074f2017-12-27 12:55:14 -06001// SPDX-License-Identifier: GPL-2.0
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02002/*
3 * Functions for working with device tree overlays
4 *
5 * Copyright (C) 2012 Pantelis Antoniou <panto@antoniou-consulting.com>
6 * Copyright (C) 2012 Texas Instruments Inc.
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02007 */
Rob Herring606ad422016-06-15 08:32:18 -05008
9#define pr_fmt(fmt) "OF: overlay: " fmt
10
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020011#include <linux/kernel.h>
12#include <linux/module.h>
13#include <linux/of.h>
14#include <linux/of_device.h>
Frank Rowand39a751a2018-02-12 00:19:42 -080015#include <linux/of_fdt.h>
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020016#include <linux/string.h>
17#include <linux/ctype.h>
18#include <linux/errno.h>
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020019#include <linux/slab.h>
Frank Rowand39a751a2018-02-12 00:19:42 -080020#include <linux/libfdt.h>
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020021#include <linux/err.h>
Mark Brown0d1886d2015-02-17 11:36:58 +090022#include <linux/idr.h>
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020023
24#include "of_private.h"
25
26/**
Frank Rowand6b4955b2018-10-04 20:28:08 -070027 * struct target - info about current target node as recursing through overlay
28 * @np: node where current level of overlay will be applied
29 * @in_livetree: @np is a node in the live devicetree
30 *
31 * Used in the algorithm to create the portion of a changeset that describes
32 * an overlay fragment, which is a devicetree subtree. Initially @np is a node
33 * in the live devicetree where the overlay subtree is targeted to be grafted
34 * into. When recursing to the next level of the overlay subtree, the target
35 * also recurses to the next level of the live devicetree, as long as overlay
36 * subtree node also exists in the live devicetree. When a node in the overlay
37 * subtree does not exist at the same level in the live devicetree, target->np
38 * points to a newly allocated node, and all subsequent targets in the subtree
39 * will be newly allocated nodes.
40 */
41struct target {
42 struct device_node *np;
43 bool in_livetree;
44};
45
46/**
Frank Rowand0290c4c2017-10-17 16:36:23 -070047 * struct fragment - info about fragment nodes in overlay expanded device tree
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020048 * @target: target of the overlay operation
Frank Rowand0290c4c2017-10-17 16:36:23 -070049 * @overlay: pointer to the __overlay__ node
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020050 */
Frank Rowand0290c4c2017-10-17 16:36:23 -070051struct fragment {
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020052 struct device_node *overlay;
Frank Rowand81225ea2018-10-04 20:30:40 -070053 struct device_node *target;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020054};
55
56/**
Frank Rowand0290c4c2017-10-17 16:36:23 -070057 * struct overlay_changeset
Frank Rowand39a751a2018-02-12 00:19:42 -080058 * @id: changeset identifier
Frank Rowand3912b792017-10-17 16:36:30 -070059 * @ovcs_list: list on which we are located
Frank Rowand39a751a2018-02-12 00:19:42 -080060 * @fdt: FDT that was unflattened to create @overlay_tree
Frank Rowande0a58f32017-10-17 16:36:31 -070061 * @overlay_tree: expanded device tree that contains the fragment nodes
Frank Rowand3912b792017-10-17 16:36:30 -070062 * @count: count of fragment structures
63 * @fragments: fragment nodes in the overlay expanded device tree
64 * @symbols_fragment: last element of @fragments[] is the __symbols__ node
65 * @cset: changeset to apply fragments to live device tree
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020066 */
Frank Rowand0290c4c2017-10-17 16:36:23 -070067struct overlay_changeset {
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020068 int id;
Frank Rowand0290c4c2017-10-17 16:36:23 -070069 struct list_head ovcs_list;
Frank Rowand39a751a2018-02-12 00:19:42 -080070 const void *fdt;
Frank Rowande0a58f32017-10-17 16:36:31 -070071 struct device_node *overlay_tree;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020072 int count;
Frank Rowand0290c4c2017-10-17 16:36:23 -070073 struct fragment *fragments;
Frank Rowand3912b792017-10-17 16:36:30 -070074 bool symbols_fragment;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020075 struct of_changeset cset;
76};
77
Frank Rowand24789c52017-10-17 16:36:26 -070078/* flags are sticky - once set, do not reset */
79static int devicetree_state_flags;
80#define DTSF_APPLY_FAIL 0x01
81#define DTSF_REVERT_FAIL 0x02
82
83/*
84 * If a changeset apply or revert encounters an error, an attempt will
85 * be made to undo partial changes, but may fail. If the undo fails
86 * we do not know the state of the devicetree.
87 */
88static int devicetree_corrupt(void)
89{
90 return devicetree_state_flags &
91 (DTSF_APPLY_FAIL | DTSF_REVERT_FAIL);
92}
93
Frank Rowand0290c4c2017-10-17 16:36:23 -070094static int build_changeset_next_level(struct overlay_changeset *ovcs,
Frank Rowand6b4955b2018-10-04 20:28:08 -070095 struct target *target, const struct device_node *overlay_node);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +020096
Frank Rowandf948d6d2017-10-17 16:36:29 -070097/*
98 * of_resolve_phandles() finds the largest phandle in the live tree.
99 * of_overlay_apply() may add a larger phandle to the live tree.
100 * Do not allow race between two overlays being applied simultaneously:
101 * mutex_lock(&of_overlay_phandle_mutex)
102 * of_resolve_phandles()
103 * of_overlay_apply()
104 * mutex_unlock(&of_overlay_phandle_mutex)
105 */
106static DEFINE_MUTEX(of_overlay_phandle_mutex);
107
108void of_overlay_mutex_lock(void)
109{
110 mutex_lock(&of_overlay_phandle_mutex);
111}
112
113void of_overlay_mutex_unlock(void)
114{
115 mutex_unlock(&of_overlay_phandle_mutex);
116}
117
118
Frank Rowand61b4de42017-10-17 16:36:25 -0700119static LIST_HEAD(ovcs_list);
120static DEFINE_IDR(ovcs_idr);
121
Frank Rowand0290c4c2017-10-17 16:36:23 -0700122static BLOCKING_NOTIFIER_HEAD(overlay_notify_chain);
Alan Tull39a842e2016-11-01 14:14:22 -0500123
Jan Kiszka83ef4772018-04-26 13:00:30 +0200124/**
125 * of_overlay_notifier_register() - Register notifier for overlay operations
126 * @nb: Notifier block to register
127 *
128 * Register for notification on overlay operations on device tree nodes. The
129 * reported actions definied by @of_reconfig_change. The notifier callback
130 * furthermore receives a pointer to the affected device tree node.
131 *
132 * Note that a notifier callback is not supposed to store pointers to a device
133 * tree node or its content beyond @OF_OVERLAY_POST_REMOVE corresponding to the
134 * respective node it received.
135 */
Alan Tull39a842e2016-11-01 14:14:22 -0500136int of_overlay_notifier_register(struct notifier_block *nb)
137{
Frank Rowand0290c4c2017-10-17 16:36:23 -0700138 return blocking_notifier_chain_register(&overlay_notify_chain, nb);
Alan Tull39a842e2016-11-01 14:14:22 -0500139}
140EXPORT_SYMBOL_GPL(of_overlay_notifier_register);
141
Jan Kiszka83ef4772018-04-26 13:00:30 +0200142/**
143 * of_overlay_notifier_register() - Unregister notifier for overlay operations
144 * @nb: Notifier block to unregister
145 */
Alan Tull39a842e2016-11-01 14:14:22 -0500146int of_overlay_notifier_unregister(struct notifier_block *nb)
147{
Frank Rowand0290c4c2017-10-17 16:36:23 -0700148 return blocking_notifier_chain_unregister(&overlay_notify_chain, nb);
Alan Tull39a842e2016-11-01 14:14:22 -0500149}
150EXPORT_SYMBOL_GPL(of_overlay_notifier_unregister);
151
Frank Rowand24789c52017-10-17 16:36:26 -0700152static char *of_overlay_action_name[] = {
153 "pre-apply",
154 "post-apply",
155 "pre-remove",
156 "post-remove",
157};
158
Frank Rowand0290c4c2017-10-17 16:36:23 -0700159static int overlay_notify(struct overlay_changeset *ovcs,
160 enum of_overlay_notify_action action)
Alan Tull39a842e2016-11-01 14:14:22 -0500161{
162 struct of_overlay_notify_data nd;
163 int i, ret;
164
Frank Rowand0290c4c2017-10-17 16:36:23 -0700165 for (i = 0; i < ovcs->count; i++) {
166 struct fragment *fragment = &ovcs->fragments[i];
Alan Tull39a842e2016-11-01 14:14:22 -0500167
Frank Rowand0290c4c2017-10-17 16:36:23 -0700168 nd.target = fragment->target;
169 nd.overlay = fragment->overlay;
Alan Tull39a842e2016-11-01 14:14:22 -0500170
Frank Rowand0290c4c2017-10-17 16:36:23 -0700171 ret = blocking_notifier_call_chain(&overlay_notify_chain,
Alan Tull39a842e2016-11-01 14:14:22 -0500172 action, &nd);
Frank Rowanda1d19bd2017-10-19 14:18:27 -0700173 if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
Frank Rowand24789c52017-10-17 16:36:26 -0700174 return 0;
175 if (ret) {
176 ret = notifier_to_errno(ret);
177 pr_err("overlay changeset %s notifier error %d, target: %pOF\n",
178 of_overlay_action_name[action], ret, nd.target);
179 return ret;
180 }
Alan Tull39a842e2016-11-01 14:14:22 -0500181 }
182
183 return 0;
184}
185
Frank Rowand42b2e942017-10-17 16:36:24 -0700186/*
Frank Rowande0a58f32017-10-17 16:36:31 -0700187 * The values of properties in the "/__symbols__" node are paths in
188 * the ovcs->overlay_tree. When duplicating the properties, the paths
189 * need to be adjusted to be the correct path for the live device tree.
Frank Rowand42b2e942017-10-17 16:36:24 -0700190 *
Frank Rowande0a58f32017-10-17 16:36:31 -0700191 * The paths refer to a node in the subtree of a fragment node's "__overlay__"
192 * node, for example "/fragment@0/__overlay__/symbol_path_tail",
193 * where symbol_path_tail can be a single node or it may be a multi-node path.
Frank Rowand42b2e942017-10-17 16:36:24 -0700194 *
195 * The duplicated property value will be modified by replacing the
196 * "/fragment_name/__overlay/" portion of the value with the target
197 * path from the fragment node.
198 */
Frank Rowand0290c4c2017-10-17 16:36:23 -0700199static struct property *dup_and_fixup_symbol_prop(
200 struct overlay_changeset *ovcs, const struct property *prop)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200201{
Frank Rowand0290c4c2017-10-17 16:36:23 -0700202 struct fragment *fragment;
Frank Rowande0a58f32017-10-17 16:36:31 -0700203 struct property *new_prop;
204 struct device_node *fragment_node;
205 struct device_node *overlay_node;
206 const char *path;
207 const char *path_tail;
Frank Rowandd1651b02017-07-19 09:25:22 -0700208 const char *target_path;
209 int k;
Frank Rowandd1651b02017-07-19 09:25:22 -0700210 int overlay_name_len;
Frank Rowande0a58f32017-10-17 16:36:31 -0700211 int path_len;
212 int path_tail_len;
Frank Rowandd1651b02017-07-19 09:25:22 -0700213 int target_path_len;
214
215 if (!prop->value)
216 return NULL;
Frank Rowande0a58f32017-10-17 16:36:31 -0700217 if (strnlen(prop->value, prop->length) >= prop->length)
Frank Rowandd1651b02017-07-19 09:25:22 -0700218 return NULL;
Frank Rowande0a58f32017-10-17 16:36:31 -0700219 path = prop->value;
220 path_len = strlen(path);
221
222 if (path_len < 1)
223 return NULL;
224 fragment_node = __of_find_node_by_path(ovcs->overlay_tree, path + 1);
225 overlay_node = __of_find_node_by_path(fragment_node, "__overlay__/");
226 of_node_put(fragment_node);
227 of_node_put(overlay_node);
Frank Rowandd1651b02017-07-19 09:25:22 -0700228
Frank Rowand0290c4c2017-10-17 16:36:23 -0700229 for (k = 0; k < ovcs->count; k++) {
230 fragment = &ovcs->fragments[k];
Frank Rowande0a58f32017-10-17 16:36:31 -0700231 if (fragment->overlay == overlay_node)
Frank Rowandd1651b02017-07-19 09:25:22 -0700232 break;
233 }
Frank Rowand0290c4c2017-10-17 16:36:23 -0700234 if (k >= ovcs->count)
Frank Rowande0a58f32017-10-17 16:36:31 -0700235 return NULL;
Frank Rowandd1651b02017-07-19 09:25:22 -0700236
Frank Rowande0a58f32017-10-17 16:36:31 -0700237 overlay_name_len = snprintf(NULL, 0, "%pOF", fragment->overlay);
238
239 if (overlay_name_len > path_len)
240 return NULL;
241 path_tail = path + overlay_name_len;
242 path_tail_len = strlen(path_tail);
243
244 target_path = kasprintf(GFP_KERNEL, "%pOF", fragment->target);
245 if (!target_path)
246 return NULL;
Frank Rowandd1651b02017-07-19 09:25:22 -0700247 target_path_len = strlen(target_path);
248
Frank Rowande0a58f32017-10-17 16:36:31 -0700249 new_prop = kzalloc(sizeof(*new_prop), GFP_KERNEL);
250 if (!new_prop)
251 goto err_free_target_path;
Frank Rowandd1651b02017-07-19 09:25:22 -0700252
Frank Rowande0a58f32017-10-17 16:36:31 -0700253 new_prop->name = kstrdup(prop->name, GFP_KERNEL);
254 new_prop->length = target_path_len + path_tail_len + 1;
255 new_prop->value = kzalloc(new_prop->length, GFP_KERNEL);
256 if (!new_prop->name || !new_prop->value)
257 goto err_free_new_prop;
Frank Rowandd1651b02017-07-19 09:25:22 -0700258
Frank Rowande0a58f32017-10-17 16:36:31 -0700259 strcpy(new_prop->value, target_path);
260 strcpy(new_prop->value + target_path_len, path_tail);
Frank Rowandd1651b02017-07-19 09:25:22 -0700261
Frank Rowande0a58f32017-10-17 16:36:31 -0700262 of_property_set_flag(new_prop, OF_DYNAMIC);
Frank Rowandd1651b02017-07-19 09:25:22 -0700263
Frank Rowande0a58f32017-10-17 16:36:31 -0700264 return new_prop;
Frank Rowandd1651b02017-07-19 09:25:22 -0700265
Frank Rowande0a58f32017-10-17 16:36:31 -0700266err_free_new_prop:
267 kfree(new_prop->name);
268 kfree(new_prop->value);
269 kfree(new_prop);
270err_free_target_path:
271 kfree(target_path);
Frank Rowandd1651b02017-07-19 09:25:22 -0700272
Frank Rowandd1651b02017-07-19 09:25:22 -0700273 return NULL;
Frank Rowandd1651b02017-07-19 09:25:22 -0700274}
275
Frank Rowand0290c4c2017-10-17 16:36:23 -0700276/**
277 * add_changeset_property() - add @overlay_prop to overlay changeset
278 * @ovcs: overlay changeset
Frank Rowand6b4955b2018-10-04 20:28:08 -0700279 * @target: where @overlay_prop will be placed
Frank Rowand0290c4c2017-10-17 16:36:23 -0700280 * @overlay_prop: property to add or update, from overlay tree
Frank Rowand3912b792017-10-17 16:36:30 -0700281 * @is_symbols_prop: 1 if @overlay_prop is from node "/__symbols__"
Frank Rowand0290c4c2017-10-17 16:36:23 -0700282 *
Frank Rowand6b4955b2018-10-04 20:28:08 -0700283 * If @overlay_prop does not already exist in live devicetree, add changeset
284 * entry to add @overlay_prop in @target, else add changeset entry to update
Frank Rowand0290c4c2017-10-17 16:36:23 -0700285 * value of @overlay_prop.
286 *
Frank Rowand6b4955b2018-10-04 20:28:08 -0700287 * @target may be either in the live devicetree or in a new subtree that
288 * is contained in the changeset.
289 *
Frank Rowand6f751182018-10-04 20:32:04 -0700290 * Some special properties are not added or updated (no error returned):
291 * "name", "phandle", "linux,phandle".
292 *
293 * Properties "#address-cells" and "#size-cells" are not updated if they
294 * are already in the live tree, but if present in the live tree, the values
295 * in the overlay must match the values in the live tree.
Frank Rowand0290c4c2017-10-17 16:36:23 -0700296 *
Frank Rowand646afc42017-10-17 16:36:21 -0700297 * Update of property in symbols node is not allowed.
Frank Rowand0290c4c2017-10-17 16:36:23 -0700298 *
299 * Returns 0 on success, -ENOMEM if memory allocation failure, or -EINVAL if
300 * invalid @overlay.
Frank Rowand646afc42017-10-17 16:36:21 -0700301 */
Frank Rowand0290c4c2017-10-17 16:36:23 -0700302static int add_changeset_property(struct overlay_changeset *ovcs,
Frank Rowand6b4955b2018-10-04 20:28:08 -0700303 struct target *target, struct property *overlay_prop,
Frank Rowand3912b792017-10-17 16:36:30 -0700304 bool is_symbols_prop)
Frank Rowandd1651b02017-07-19 09:25:22 -0700305{
Frank Rowand0290c4c2017-10-17 16:36:23 -0700306 struct property *new_prop = NULL, *prop;
Lixin Wangac0f3e32017-10-16 17:54:32 +0800307 int ret = 0;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200308
Frank Rowandf9627882018-10-12 19:21:16 -0700309 if (target->in_livetree)
310 if (!of_prop_cmp(overlay_prop->name, "name") ||
311 !of_prop_cmp(overlay_prop->name, "phandle") ||
312 !of_prop_cmp(overlay_prop->name, "linux,phandle"))
313 return 0;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200314
Frank Rowand6b4955b2018-10-04 20:28:08 -0700315 if (target->in_livetree)
316 prop = of_find_property(target->np, overlay_prop->name, NULL);
317 else
318 prop = NULL;
319
Frank Rowand637392a2019-11-21 13:16:56 -0600320 if (prop) {
321 if (!of_prop_cmp(prop->name, "#address-cells")) {
322 if (!of_prop_val_eq(prop, overlay_prop)) {
323 pr_err("ERROR: changing value of #address-cells is not allowed in %pOF\n",
324 target->np);
325 ret = -EINVAL;
326 }
327 return ret;
328
329 } else if (!of_prop_cmp(prop->name, "#size-cells")) {
330 if (!of_prop_val_eq(prop, overlay_prop)) {
331 pr_err("ERROR: changing value of #size-cells is not allowed in %pOF\n",
332 target->np);
333 ret = -EINVAL;
334 }
335 return ret;
336 }
337 }
338
Frank Rowand3912b792017-10-17 16:36:30 -0700339 if (is_symbols_prop) {
Frank Rowand0290c4c2017-10-17 16:36:23 -0700340 if (prop)
Frank Rowandd1651b02017-07-19 09:25:22 -0700341 return -EINVAL;
Frank Rowand0290c4c2017-10-17 16:36:23 -0700342 new_prop = dup_and_fixup_symbol_prop(ovcs, overlay_prop);
Frank Rowandd1651b02017-07-19 09:25:22 -0700343 } else {
Frank Rowand0290c4c2017-10-17 16:36:23 -0700344 new_prop = __of_prop_dup(overlay_prop, GFP_KERNEL);
Frank Rowandd1651b02017-07-19 09:25:22 -0700345 }
346
Frank Rowand0290c4c2017-10-17 16:36:23 -0700347 if (!new_prop)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200348 return -ENOMEM;
349
Frank Rowand6f751182018-10-04 20:32:04 -0700350 if (!prop) {
Frank Rowandf9627882018-10-12 19:21:16 -0700351 if (!target->in_livetree) {
352 new_prop->next = target->np->deadprops;
353 target->np->deadprops = new_prop;
354 }
Frank Rowand6b4955b2018-10-04 20:28:08 -0700355 ret = of_changeset_add_property(&ovcs->cset, target->np,
Frank Rowand0290c4c2017-10-17 16:36:23 -0700356 new_prop);
Frank Rowand6f751182018-10-04 20:32:04 -0700357 } else {
Frank Rowand6b4955b2018-10-04 20:28:08 -0700358 ret = of_changeset_update_property(&ovcs->cset, target->np,
Frank Rowand0290c4c2017-10-17 16:36:23 -0700359 new_prop);
Frank Rowand6f751182018-10-04 20:32:04 -0700360 }
361
Frank Rowand637392a2019-11-21 13:16:56 -0600362 if (!of_node_check_flag(target->np, OF_OVERLAY))
Frank Rowand6f751182018-10-04 20:32:04 -0700363 pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
364 target->np, new_prop->name);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200365
Lixin Wangac0f3e32017-10-16 17:54:32 +0800366 if (ret) {
Frank Rowand0290c4c2017-10-17 16:36:23 -0700367 kfree(new_prop->name);
368 kfree(new_prop->value);
369 kfree(new_prop);
Lixin Wangac0f3e32017-10-16 17:54:32 +0800370 }
371 return ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200372}
373
Frank Rowand0290c4c2017-10-17 16:36:23 -0700374/**
375 * add_changeset_node() - add @node (and children) to overlay changeset
Frank Rowand6b4955b2018-10-04 20:28:08 -0700376 * @ovcs: overlay changeset
377 * @target: where @node will be placed in live tree or changeset
378 * @node: node from within overlay device tree fragment
Frank Rowand0290c4c2017-10-17 16:36:23 -0700379 *
Frank Rowand6b4955b2018-10-04 20:28:08 -0700380 * If @node does not already exist in @target, add changeset entry
381 * to add @node in @target.
Frank Rowand0290c4c2017-10-17 16:36:23 -0700382 *
Frank Rowand6b4955b2018-10-04 20:28:08 -0700383 * If @node already exists in @target, and the existing node has
Frank Rowand0290c4c2017-10-17 16:36:23 -0700384 * a phandle, the overlay node is not allowed to have a phandle.
385 *
386 * If @node has child nodes, add the children recursively via
387 * build_changeset_next_level().
388 *
Frank Rowandb89dae12018-02-26 14:01:23 -0800389 * NOTE_1: A live devicetree created from a flattened device tree (FDT) will
390 * not contain the full path in node->full_name. Thus an overlay
391 * created from an FDT also will not contain the full path in
392 * node->full_name. However, a live devicetree created from Open
393 * Firmware may have the full path in node->full_name.
394 *
395 * add_changeset_node() follows the FDT convention and does not include
396 * the full path in node->full_name. Even though it expects the overlay
397 * to not contain the full path, it uses kbasename() to remove the
398 * full path should it exist. It also uses kbasename() in comparisons
399 * to nodes in the live devicetree so that it can apply an overlay to
400 * a live devicetree created from Open Firmware.
401 *
402 * NOTE_2: Multiple mods of created nodes not supported.
Frank Rowand0290c4c2017-10-17 16:36:23 -0700403 *
404 * Returns 0 on success, -ENOMEM if memory allocation failure, or -EINVAL if
405 * invalid @overlay.
406 */
407static int add_changeset_node(struct overlay_changeset *ovcs,
Frank Rowand6b4955b2018-10-04 20:28:08 -0700408 struct target *target, struct device_node *node)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200409{
Frank Rowand0290c4c2017-10-17 16:36:23 -0700410 const char *node_kbasename;
Frank Rowandf9627882018-10-12 19:21:16 -0700411 const __be32 *phandle;
Fabio Estevamd3a89162015-03-03 10:04:45 -0300412 struct device_node *tchild;
Frank Rowand6b4955b2018-10-04 20:28:08 -0700413 struct target target_child;
Frank Rowandf9627882018-10-12 19:21:16 -0700414 int ret = 0, size;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200415
Frank Rowand0290c4c2017-10-17 16:36:23 -0700416 node_kbasename = kbasename(node->full_name);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200417
Frank Rowand6b4955b2018-10-04 20:28:08 -0700418 for_each_child_of_node(target->np, tchild)
Frank Rowand0290c4c2017-10-17 16:36:23 -0700419 if (!of_node_cmp(node_kbasename, kbasename(tchild->full_name)))
Frank Rowandc1cd1e02017-07-19 09:25:21 -0700420 break;
421
Frank Rowand61b4de42017-10-17 16:36:25 -0700422 if (!tchild) {
Frank Rowand8814dc42018-10-04 20:29:01 -0700423 tchild = __of_node_dup(NULL, node_kbasename);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200424 if (!tchild)
425 return -ENOMEM;
426
Frank Rowand6b4955b2018-10-04 20:28:08 -0700427 tchild->parent = target->np;
Frank Rowandf9627882018-10-12 19:21:16 -0700428 tchild->name = __of_get_property(node, "name", NULL);
Frank Rowandf9627882018-10-12 19:21:16 -0700429
430 if (!tchild->name)
431 tchild->name = "<NULL>";
Frank Rowandf9627882018-10-12 19:21:16 -0700432
433 /* ignore obsolete "linux,phandle" */
434 phandle = __of_get_property(node, "phandle", &size);
435 if (phandle && (size == 4))
436 tchild->phandle = be32_to_cpup(phandle);
437
Frank Rowand144552c72018-10-04 20:24:17 -0700438 of_node_set_flag(tchild, OF_OVERLAY);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200439
Frank Rowand0290c4c2017-10-17 16:36:23 -0700440 ret = of_changeset_attach_node(&ovcs->cset, tchild);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200441 if (ret)
442 return ret;
443
Frank Rowand6b4955b2018-10-04 20:28:08 -0700444 target_child.np = tchild;
445 target_child.in_livetree = false;
446
447 ret = build_changeset_next_level(ovcs, &target_child, node);
Frank Rowand7c528e42018-10-04 20:25:13 -0700448 of_node_put(tchild);
449 return ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200450 }
451
Frank Rowand6b4955b2018-10-04 20:28:08 -0700452 if (node->phandle && tchild->phandle) {
Frank Rowand6d0f5472017-10-17 16:36:28 -0700453 ret = -EINVAL;
Frank Rowand6b4955b2018-10-04 20:28:08 -0700454 } else {
455 target_child.np = tchild;
456 target_child.in_livetree = target->in_livetree;
457 ret = build_changeset_next_level(ovcs, &target_child, node);
458 }
Frank Rowand61b4de42017-10-17 16:36:25 -0700459 of_node_put(tchild);
460
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200461 return ret;
462}
463
Frank Rowand0290c4c2017-10-17 16:36:23 -0700464/**
465 * build_changeset_next_level() - add level of overlay changeset
466 * @ovcs: overlay changeset
Frank Rowand6b4955b2018-10-04 20:28:08 -0700467 * @target: where to place @overlay_node in live tree
Frank Rowand0290c4c2017-10-17 16:36:23 -0700468 * @overlay_node: node from within an overlay device tree fragment
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200469 *
Frank Rowand0290c4c2017-10-17 16:36:23 -0700470 * Add the properties (if any) and nodes (if any) from @overlay_node to the
471 * @ovcs->cset changeset. If an added node has child nodes, they will
472 * be added recursively.
Frank Rowand646afc42017-10-17 16:36:21 -0700473 *
474 * Do not allow symbols node to have any children.
Frank Rowand0290c4c2017-10-17 16:36:23 -0700475 *
476 * Returns 0 on success, -ENOMEM if memory allocation failure, or -EINVAL if
477 * invalid @overlay_node.
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200478 */
Frank Rowand0290c4c2017-10-17 16:36:23 -0700479static int build_changeset_next_level(struct overlay_changeset *ovcs,
Frank Rowand6b4955b2018-10-04 20:28:08 -0700480 struct target *target, const struct device_node *overlay_node)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200481{
482 struct device_node *child;
483 struct property *prop;
484 int ret;
485
Frank Rowand0290c4c2017-10-17 16:36:23 -0700486 for_each_property_of_node(overlay_node, prop) {
Frank Rowand6b4955b2018-10-04 20:28:08 -0700487 ret = add_changeset_property(ovcs, target, prop, 0);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200488 if (ret) {
Frank Rowand24789c52017-10-17 16:36:26 -0700489 pr_debug("Failed to apply prop @%pOF/%s, err=%d\n",
Frank Rowand6b4955b2018-10-04 20:28:08 -0700490 target->np, prop->name, ret);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200491 return ret;
492 }
493 }
494
Frank Rowand0290c4c2017-10-17 16:36:23 -0700495 for_each_child_of_node(overlay_node, child) {
Frank Rowand6b4955b2018-10-04 20:28:08 -0700496 ret = add_changeset_node(ovcs, target, child);
Frank Rowandbbed8792017-10-17 16:36:22 -0700497 if (ret) {
Rob Herringa613b262018-08-27 20:00:19 -0500498 pr_debug("Failed to apply node @%pOF/%pOFn, err=%d\n",
Frank Rowand6b4955b2018-10-04 20:28:08 -0700499 target->np, child, ret);
Julia Lawall001cf502015-10-22 11:02:48 +0200500 of_node_put(child);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200501 return ret;
502 }
503 }
504
505 return 0;
506}
507
Frank Rowand3912b792017-10-17 16:36:30 -0700508/*
509 * Add the properties from __overlay__ node to the @ovcs->cset changeset.
510 */
511static int build_changeset_symbols_node(struct overlay_changeset *ovcs,
Frank Rowand6b4955b2018-10-04 20:28:08 -0700512 struct target *target,
Frank Rowand3912b792017-10-17 16:36:30 -0700513 const struct device_node *overlay_symbols_node)
514{
515 struct property *prop;
516 int ret;
517
518 for_each_property_of_node(overlay_symbols_node, prop) {
Frank Rowand6b4955b2018-10-04 20:28:08 -0700519 ret = add_changeset_property(ovcs, target, prop, 1);
Frank Rowand3912b792017-10-17 16:36:30 -0700520 if (ret) {
Frank Rowanda15e8242018-10-04 20:33:35 -0700521 pr_debug("Failed to apply symbols prop @%pOF/%s, err=%d\n",
Frank Rowand6b4955b2018-10-04 20:28:08 -0700522 target->np, prop->name, ret);
Frank Rowand3912b792017-10-17 16:36:30 -0700523 return ret;
524 }
525 }
526
527 return 0;
528}
529
Frank Rowand2fe0e872018-10-04 20:36:18 -0700530static int find_dup_cset_node_entry(struct overlay_changeset *ovcs,
531 struct of_changeset_entry *ce_1)
Frank Rowandc1682632018-10-04 20:35:14 -0700532{
Frank Rowand2fe0e872018-10-04 20:36:18 -0700533 struct of_changeset_entry *ce_2;
Frank Rowandc1682632018-10-04 20:35:14 -0700534 char *fn_1, *fn_2;
Frank Rowand2fe0e872018-10-04 20:36:18 -0700535 int node_path_match;
Frank Rowandc1682632018-10-04 20:35:14 -0700536
Frank Rowand2fe0e872018-10-04 20:36:18 -0700537 if (ce_1->action != OF_RECONFIG_ATTACH_NODE &&
538 ce_1->action != OF_RECONFIG_DETACH_NODE)
539 return 0;
Frank Rowandc1682632018-10-04 20:35:14 -0700540
Frank Rowand2fe0e872018-10-04 20:36:18 -0700541 ce_2 = ce_1;
542 list_for_each_entry_continue(ce_2, &ovcs->cset.entries, node) {
543 if ((ce_2->action != OF_RECONFIG_ATTACH_NODE &&
544 ce_2->action != OF_RECONFIG_DETACH_NODE) ||
545 of_node_cmp(ce_1->np->full_name, ce_2->np->full_name))
546 continue;
Frank Rowandc1682632018-10-04 20:35:14 -0700547
Frank Rowand2fe0e872018-10-04 20:36:18 -0700548 fn_1 = kasprintf(GFP_KERNEL, "%pOF", ce_1->np);
549 fn_2 = kasprintf(GFP_KERNEL, "%pOF", ce_2->np);
550 node_path_match = !strcmp(fn_1, fn_2);
551 kfree(fn_1);
552 kfree(fn_2);
553 if (node_path_match) {
554 pr_err("ERROR: multiple fragments add and/or delete node %pOF\n",
555 ce_1->np);
556 return -EINVAL;
Frank Rowandc1682632018-10-04 20:35:14 -0700557 }
558 }
559
560 return 0;
561}
562
Frank Rowand2fe0e872018-10-04 20:36:18 -0700563static int find_dup_cset_prop(struct overlay_changeset *ovcs,
564 struct of_changeset_entry *ce_1)
565{
566 struct of_changeset_entry *ce_2;
567 char *fn_1, *fn_2;
568 int node_path_match;
569
570 if (ce_1->action != OF_RECONFIG_ADD_PROPERTY &&
571 ce_1->action != OF_RECONFIG_REMOVE_PROPERTY &&
572 ce_1->action != OF_RECONFIG_UPDATE_PROPERTY)
573 return 0;
574
575 ce_2 = ce_1;
576 list_for_each_entry_continue(ce_2, &ovcs->cset.entries, node) {
577 if ((ce_2->action != OF_RECONFIG_ADD_PROPERTY &&
578 ce_2->action != OF_RECONFIG_REMOVE_PROPERTY &&
579 ce_2->action != OF_RECONFIG_UPDATE_PROPERTY) ||
580 of_node_cmp(ce_1->np->full_name, ce_2->np->full_name))
581 continue;
582
583 fn_1 = kasprintf(GFP_KERNEL, "%pOF", ce_1->np);
584 fn_2 = kasprintf(GFP_KERNEL, "%pOF", ce_2->np);
585 node_path_match = !strcmp(fn_1, fn_2);
586 kfree(fn_1);
587 kfree(fn_2);
588 if (node_path_match &&
589 !of_prop_cmp(ce_1->prop->name, ce_2->prop->name)) {
590 pr_err("ERROR: multiple fragments add, update, and/or delete property %pOF/%s\n",
591 ce_1->np, ce_1->prop->name);
592 return -EINVAL;
593 }
594 }
595
596 return 0;
597}
598
599/**
600 * changeset_dup_entry_check() - check for duplicate entries
601 * @ovcs: Overlay changeset
602 *
603 * Check changeset @ovcs->cset for multiple {add or delete} node entries for
604 * the same node or duplicate {add, delete, or update} properties entries
605 * for the same property.
606 *
607 * Returns 0 on success, or -EINVAL if duplicate changeset entry found.
608 */
609static int changeset_dup_entry_check(struct overlay_changeset *ovcs)
610{
611 struct of_changeset_entry *ce_1;
612 int dup_entry = 0;
613
614 list_for_each_entry(ce_1, &ovcs->cset.entries, node) {
615 dup_entry |= find_dup_cset_node_entry(ovcs, ce_1);
616 dup_entry |= find_dup_cset_prop(ovcs, ce_1);
617 }
618
619 return dup_entry ? -EINVAL : 0;
620}
621
Frank Rowandc1682632018-10-04 20:35:14 -0700622/**
Frank Rowand0290c4c2017-10-17 16:36:23 -0700623 * build_changeset() - populate overlay changeset in @ovcs from @ovcs->fragments
624 * @ovcs: Overlay changeset
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200625 *
Frank Rowand0290c4c2017-10-17 16:36:23 -0700626 * Create changeset @ovcs->cset to contain the nodes and properties of the
627 * overlay device tree fragments in @ovcs->fragments[]. If an error occurs,
628 * any portions of the changeset that were successfully created will remain
629 * in @ovcs->cset.
630 *
631 * Returns 0 on success, -ENOMEM if memory allocation failure, or -EINVAL if
632 * invalid overlay in @ovcs->fragments[].
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200633 */
Frank Rowand0290c4c2017-10-17 16:36:23 -0700634static int build_changeset(struct overlay_changeset *ovcs)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200635{
Frank Rowand3912b792017-10-17 16:36:30 -0700636 struct fragment *fragment;
Frank Rowand6b4955b2018-10-04 20:28:08 -0700637 struct target target;
Frank Rowand3912b792017-10-17 16:36:30 -0700638 int fragments_count, i, ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200639
Frank Rowand3912b792017-10-17 16:36:30 -0700640 /*
641 * if there is a symbols fragment in ovcs->fragments[i] it is
642 * the final element in the array
643 */
644 if (ovcs->symbols_fragment)
645 fragments_count = ovcs->count - 1;
646 else
647 fragments_count = ovcs->count;
648
649 for (i = 0; i < fragments_count; i++) {
650 fragment = &ovcs->fragments[i];
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200651
Frank Rowand6b4955b2018-10-04 20:28:08 -0700652 target.np = fragment->target;
653 target.in_livetree = true;
654 ret = build_changeset_next_level(ovcs, &target,
Frank Rowand3912b792017-10-17 16:36:30 -0700655 fragment->overlay);
656 if (ret) {
Frank Rowanda15e8242018-10-04 20:33:35 -0700657 pr_debug("fragment apply failed '%pOF'\n",
658 fragment->target);
Frank Rowand3912b792017-10-17 16:36:30 -0700659 return ret;
660 }
661 }
662
663 if (ovcs->symbols_fragment) {
664 fragment = &ovcs->fragments[ovcs->count - 1];
Frank Rowand6b4955b2018-10-04 20:28:08 -0700665
666 target.np = fragment->target;
667 target.in_livetree = true;
668 ret = build_changeset_symbols_node(ovcs, &target,
Frank Rowand3912b792017-10-17 16:36:30 -0700669 fragment->overlay);
Frank Rowand0290c4c2017-10-17 16:36:23 -0700670 if (ret) {
Frank Rowanda15e8242018-10-04 20:33:35 -0700671 pr_debug("symbols fragment apply failed '%pOF'\n",
672 fragment->target);
Frank Rowand0290c4c2017-10-17 16:36:23 -0700673 return ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200674 }
675 }
676
Frank Rowand2fe0e872018-10-04 20:36:18 -0700677 return changeset_dup_entry_check(ovcs);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200678}
679
680/*
681 * Find the target node using a number of different strategies
Frank Rowand646afc42017-10-17 16:36:21 -0700682 * in order of preference:
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200683 *
Frank Rowand646afc42017-10-17 16:36:21 -0700684 * 1) "target" property containing the phandle of the target
685 * 2) "target-path" property containing the path of the target
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200686 */
Frank Rowand6b4955b2018-10-04 20:28:08 -0700687static struct device_node *find_target(struct device_node *info_node)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200688{
Frank Rowande547c002018-02-12 00:25:04 -0800689 struct device_node *node;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200690 const char *path;
691 u32 val;
692 int ret;
693
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200694 ret = of_property_read_u32(info_node, "target", &val);
Frank Rowande547c002018-02-12 00:25:04 -0800695 if (!ret) {
696 node = of_find_node_by_phandle(val);
697 if (!node)
698 pr_err("find target, node: %pOF, phandle 0x%x not found\n",
699 info_node, val);
700 return node;
701 }
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200702
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200703 ret = of_property_read_string(info_node, "target-path", &path);
Frank Rowande547c002018-02-12 00:25:04 -0800704 if (!ret) {
705 node = of_find_node_by_path(path);
706 if (!node)
707 pr_err("find target, node: %pOF, path '%s' not found\n",
708 info_node, path);
709 return node;
710 }
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200711
Frank Rowande547c002018-02-12 00:25:04 -0800712 pr_err("find target, node: %pOF, no target property\n", info_node);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200713
714 return NULL;
715}
716
717/**
Frank Rowand0290c4c2017-10-17 16:36:23 -0700718 * init_overlay_changeset() - initialize overlay changeset from overlay tree
Frank Rowand39a751a2018-02-12 00:19:42 -0800719 * @ovcs: Overlay changeset to build
720 * @fdt: the FDT that was unflattened to create @tree
Frank Rowand0290c4c2017-10-17 16:36:23 -0700721 * @tree: Contains all the overlay fragments and overlay fixup nodes
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200722 *
Frank Rowand0290c4c2017-10-17 16:36:23 -0700723 * Initialize @ovcs. Populate @ovcs->fragments with node information from
724 * the top level of @tree. The relevant top level nodes are the fragment
725 * nodes and the __symbols__ node. Any other top level node will be ignored.
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200726 *
Frank Rowand0290c4c2017-10-17 16:36:23 -0700727 * Returns 0 on success, -ENOMEM if memory allocation failure, -EINVAL if error
Frank Rowand61b4de42017-10-17 16:36:25 -0700728 * detected in @tree, or -ENOSPC if idr_alloc() error.
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200729 */
Frank Rowand0290c4c2017-10-17 16:36:23 -0700730static int init_overlay_changeset(struct overlay_changeset *ovcs,
Frank Rowand39a751a2018-02-12 00:19:42 -0800731 const void *fdt, struct device_node *tree)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200732{
Frank Rowand61b4de42017-10-17 16:36:25 -0700733 struct device_node *node, *overlay_node;
Frank Rowand0290c4c2017-10-17 16:36:23 -0700734 struct fragment *fragment;
735 struct fragment *fragments;
Geert Uytterhoeven1352f092017-12-05 16:27:02 +0100736 int cnt, id, ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200737
Frank Rowand24789c52017-10-17 16:36:26 -0700738 /*
739 * Warn for some issues. Can not return -EINVAL for these until
740 * of_unittest_apply_overlay() is fixed to pass these checks.
741 */
742 if (!of_node_check_flag(tree, OF_DYNAMIC))
743 pr_debug("%s() tree is not dynamic\n", __func__);
744
745 if (!of_node_check_flag(tree, OF_DETACHED))
746 pr_debug("%s() tree is not detached\n", __func__);
747
748 if (!of_node_is_root(tree))
749 pr_debug("%s() tree is not root\n", __func__);
750
Frank Rowande0a58f32017-10-17 16:36:31 -0700751 ovcs->overlay_tree = tree;
Frank Rowand39a751a2018-02-12 00:19:42 -0800752 ovcs->fdt = fdt;
Frank Rowande0a58f32017-10-17 16:36:31 -0700753
Frank Rowand61b4de42017-10-17 16:36:25 -0700754 INIT_LIST_HEAD(&ovcs->ovcs_list);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200755
Frank Rowand61b4de42017-10-17 16:36:25 -0700756 of_changeset_init(&ovcs->cset);
757
Geert Uytterhoeven1352f092017-12-05 16:27:02 +0100758 id = idr_alloc(&ovcs_idr, ovcs, 1, 0, GFP_KERNEL);
759 if (id <= 0)
760 return id;
Frank Rowand61b4de42017-10-17 16:36:25 -0700761
762 cnt = 0;
763
764 /* fragment nodes */
765 for_each_child_of_node(tree, node) {
766 overlay_node = of_get_child_by_name(node, "__overlay__");
767 if (overlay_node) {
768 cnt++;
769 of_node_put(overlay_node);
770 }
771 }
772
773 node = of_get_child_by_name(tree, "__symbols__");
774 if (node) {
Frank Rowandd1651b02017-07-19 09:25:22 -0700775 cnt++;
Frank Rowand61b4de42017-10-17 16:36:25 -0700776 of_node_put(node);
777 }
Frank Rowandd1651b02017-07-19 09:25:22 -0700778
Frank Rowand0290c4c2017-10-17 16:36:23 -0700779 fragments = kcalloc(cnt, sizeof(*fragments), GFP_KERNEL);
Frank Rowand61b4de42017-10-17 16:36:25 -0700780 if (!fragments) {
781 ret = -ENOMEM;
782 goto err_free_idr;
783 }
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200784
785 cnt = 0;
786 for_each_child_of_node(tree, node) {
Geert Uytterhoeven35e691e2017-12-08 14:13:02 +0100787 overlay_node = of_get_child_by_name(node, "__overlay__");
Geert Uytterhoeven589b7542017-12-08 14:13:03 +0100788 if (!overlay_node)
789 continue;
Geert Uytterhoeven6de67de2017-11-28 09:26:33 +0100790
Geert Uytterhoeven589b7542017-12-08 14:13:03 +0100791 fragment = &fragments[cnt];
792 fragment->overlay = overlay_node;
Frank Rowand6b4955b2018-10-04 20:28:08 -0700793 fragment->target = find_target(node);
Geert Uytterhoeven589b7542017-12-08 14:13:03 +0100794 if (!fragment->target) {
795 of_node_put(fragment->overlay);
796 ret = -EINVAL;
797 goto err_free_fragments;
Frank Rowand61b4de42017-10-17 16:36:25 -0700798 }
Geert Uytterhoeven589b7542017-12-08 14:13:03 +0100799
800 cnt++;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200801 }
802
Frank Rowand3912b792017-10-17 16:36:30 -0700803 /*
804 * if there is a symbols fragment in ovcs->fragments[i] it is
805 * the final element in the array
806 */
Frank Rowandd1651b02017-07-19 09:25:22 -0700807 node = of_get_child_by_name(tree, "__symbols__");
808 if (node) {
Frank Rowand3912b792017-10-17 16:36:30 -0700809 ovcs->symbols_fragment = 1;
Frank Rowand0290c4c2017-10-17 16:36:23 -0700810 fragment = &fragments[cnt];
811 fragment->overlay = node;
812 fragment->target = of_find_node_by_path("/__symbols__");
Frank Rowandd1651b02017-07-19 09:25:22 -0700813
Frank Rowand0290c4c2017-10-17 16:36:23 -0700814 if (!fragment->target) {
Frank Rowand4ee7c0d2017-10-19 14:38:11 -0700815 pr_err("symbols in overlay, but not in live tree\n");
Frank Rowand61b4de42017-10-17 16:36:25 -0700816 ret = -EINVAL;
817 goto err_free_fragments;
Frank Rowandd1651b02017-07-19 09:25:22 -0700818 }
819
820 cnt++;
821 }
822
Frank Rowandbbed8792017-10-17 16:36:22 -0700823 if (!cnt) {
Frank Rowand39a751a2018-02-12 00:19:42 -0800824 pr_err("no fragments or symbols in overlay\n");
Frank Rowand61b4de42017-10-17 16:36:25 -0700825 ret = -EINVAL;
826 goto err_free_fragments;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200827 }
828
Geert Uytterhoeven1352f092017-12-05 16:27:02 +0100829 ovcs->id = id;
Frank Rowand0290c4c2017-10-17 16:36:23 -0700830 ovcs->count = cnt;
831 ovcs->fragments = fragments;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200832
833 return 0;
Frank Rowand61b4de42017-10-17 16:36:25 -0700834
Frank Rowand61b4de42017-10-17 16:36:25 -0700835err_free_fragments:
836 kfree(fragments);
837err_free_idr:
Geert Uytterhoeven1352f092017-12-05 16:27:02 +0100838 idr_remove(&ovcs_idr, id);
Frank Rowand61b4de42017-10-17 16:36:25 -0700839
Frank Rowand24789c52017-10-17 16:36:26 -0700840 pr_err("%s() failed, ret = %d\n", __func__, ret);
841
Frank Rowand61b4de42017-10-17 16:36:25 -0700842 return ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200843}
844
Frank Rowand61b4de42017-10-17 16:36:25 -0700845static void free_overlay_changeset(struct overlay_changeset *ovcs)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200846{
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200847 int i;
848
Geert Uytterhoeven1352f092017-12-05 16:27:02 +0100849 if (ovcs->cset.entries.next)
850 of_changeset_destroy(&ovcs->cset);
Frank Rowand61b4de42017-10-17 16:36:25 -0700851
852 if (ovcs->id)
853 idr_remove(&ovcs_idr, ovcs->id);
854
855 for (i = 0; i < ovcs->count; i++) {
Frank Rowand0290c4c2017-10-17 16:36:23 -0700856 of_node_put(ovcs->fragments[i].target);
857 of_node_put(ovcs->fragments[i].overlay);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200858 }
Frank Rowand0290c4c2017-10-17 16:36:23 -0700859 kfree(ovcs->fragments);
Frank Rowand39a751a2018-02-12 00:19:42 -0800860 /*
Jan Kiszka83ef4772018-04-26 13:00:30 +0200861 * There should be no live pointers into ovcs->overlay_tree and
862 * ovcs->fdt due to the policy that overlay notifiers are not allowed
863 * to retain pointers into the overlay devicetree.
Frank Rowand39a751a2018-02-12 00:19:42 -0800864 */
Jan Kiszka83ef4772018-04-26 13:00:30 +0200865 kfree(ovcs->overlay_tree);
866 kfree(ovcs->fdt);
Frank Rowand61b4de42017-10-17 16:36:25 -0700867 kfree(ovcs);
868}
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200869
Frank Rowand39a751a2018-02-12 00:19:42 -0800870/*
871 * internal documentation
872 *
Frank Rowand0290c4c2017-10-17 16:36:23 -0700873 * of_overlay_apply() - Create and apply an overlay changeset
Frank Rowand39a751a2018-02-12 00:19:42 -0800874 * @fdt: the FDT that was unflattened to create @tree
Frank Rowand0290c4c2017-10-17 16:36:23 -0700875 * @tree: Expanded overlay device tree
Frank Rowand24789c52017-10-17 16:36:26 -0700876 * @ovcs_id: Pointer to overlay changeset id
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200877 *
Frank Rowand24789c52017-10-17 16:36:26 -0700878 * Creates and applies an overlay changeset.
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200879 *
Frank Rowand24789c52017-10-17 16:36:26 -0700880 * If an error occurs in a pre-apply notifier, then no changes are made
881 * to the device tree.
882 *
883
884 * A non-zero return value will not have created the changeset if error is from:
885 * - parameter checks
886 * - building the changeset
Geert Uytterhoevene9d92e42017-11-28 09:25:23 +0100887 * - overlay changeset pre-apply notifier
Frank Rowand24789c52017-10-17 16:36:26 -0700888 *
889 * If an error is returned by an overlay changeset pre-apply notifier
890 * then no further overlay changeset pre-apply notifier will be called.
891 *
892 * A non-zero return value will have created the changeset if error is from:
893 * - overlay changeset entry notifier
Geert Uytterhoevene9d92e42017-11-28 09:25:23 +0100894 * - overlay changeset post-apply notifier
Frank Rowand24789c52017-10-17 16:36:26 -0700895 *
896 * If an error is returned by an overlay changeset post-apply notifier
897 * then no further overlay changeset post-apply notifier will be called.
898 *
899 * If more than one notifier returns an error, then the last notifier
900 * error to occur is returned.
901 *
902 * If an error occurred while applying the overlay changeset, then an
903 * attempt is made to revert any changes that were made to the
904 * device tree. If there were any errors during the revert attempt
905 * then the state of the device tree can not be determined, and any
906 * following attempt to apply or remove an overlay changeset will be
907 * refused.
908 *
909 * Returns 0 on success, or a negative error number. Overlay changeset
910 * id is returned to *ovcs_id.
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200911 */
Frank Rowand24789c52017-10-17 16:36:26 -0700912
Frank Rowand39a751a2018-02-12 00:19:42 -0800913static int of_overlay_apply(const void *fdt, struct device_node *tree,
914 int *ovcs_id)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200915{
Frank Rowand0290c4c2017-10-17 16:36:23 -0700916 struct overlay_changeset *ovcs;
Frank Rowand24789c52017-10-17 16:36:26 -0700917 int ret = 0, ret_revert, ret_tmp;
918
Frank Rowand39a751a2018-02-12 00:19:42 -0800919 /*
920 * As of this point, fdt and tree belong to the overlay changeset.
921 * overlay changeset code is responsible for freeing them.
922 */
Frank Rowand24789c52017-10-17 16:36:26 -0700923
924 if (devicetree_corrupt()) {
925 pr_err("devicetree state suspect, refuse to apply overlay\n");
Frank Rowand39a751a2018-02-12 00:19:42 -0800926 kfree(fdt);
927 kfree(tree);
Frank Rowand24789c52017-10-17 16:36:26 -0700928 ret = -EBUSY;
929 goto out;
930 }
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200931
Frank Rowand0290c4c2017-10-17 16:36:23 -0700932 ovcs = kzalloc(sizeof(*ovcs), GFP_KERNEL);
Frank Rowand24789c52017-10-17 16:36:26 -0700933 if (!ovcs) {
Frank Rowand39a751a2018-02-12 00:19:42 -0800934 kfree(fdt);
935 kfree(tree);
Frank Rowand24789c52017-10-17 16:36:26 -0700936 ret = -ENOMEM;
937 goto out;
938 }
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200939
Frank Rowandf948d6d2017-10-17 16:36:29 -0700940 of_overlay_mutex_lock();
Geert Uytterhoeven5e474812017-12-05 16:27:03 +0100941 mutex_lock(&of_mutex);
Frank Rowandf948d6d2017-10-17 16:36:29 -0700942
943 ret = of_resolve_phandles(tree);
944 if (ret)
Frank Rowand39a751a2018-02-12 00:19:42 -0800945 goto err_free_tree;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200946
Frank Rowand39a751a2018-02-12 00:19:42 -0800947 ret = init_overlay_changeset(ovcs, fdt, tree);
Frank Rowand24789c52017-10-17 16:36:26 -0700948 if (ret)
Frank Rowand39a751a2018-02-12 00:19:42 -0800949 goto err_free_tree;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200950
Frank Rowand39a751a2018-02-12 00:19:42 -0800951 /*
952 * after overlay_notify(), ovcs->overlay_tree related pointers may have
953 * leaked to drivers, so can not kfree() tree, aka ovcs->overlay_tree;
954 * and can not free fdt, aka ovcs->fdt
955 */
Frank Rowand0290c4c2017-10-17 16:36:23 -0700956 ret = overlay_notify(ovcs, OF_OVERLAY_PRE_APPLY);
Frank Rowand24789c52017-10-17 16:36:26 -0700957 if (ret) {
958 pr_err("overlay changeset pre-apply notify error %d\n", ret);
Frank Rowand61b4de42017-10-17 16:36:25 -0700959 goto err_free_overlay_changeset;
Alan Tull39a842e2016-11-01 14:14:22 -0500960 }
961
Frank Rowand0290c4c2017-10-17 16:36:23 -0700962 ret = build_changeset(ovcs);
963 if (ret)
Frank Rowand61b4de42017-10-17 16:36:25 -0700964 goto err_free_overlay_changeset;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200965
Frank Rowand24789c52017-10-17 16:36:26 -0700966 ret_revert = 0;
967 ret = __of_changeset_apply_entries(&ovcs->cset, &ret_revert);
968 if (ret) {
969 if (ret_revert) {
970 pr_debug("overlay changeset revert error %d\n",
971 ret_revert);
972 devicetree_state_flags |= DTSF_APPLY_FAIL;
973 }
Frank Rowand61b4de42017-10-17 16:36:25 -0700974 goto err_free_overlay_changeset;
Frank Rowand24789c52017-10-17 16:36:26 -0700975 }
Rob Herring606ad422016-06-15 08:32:18 -0500976
Frank Rowandb9952b52018-07-12 14:00:07 -0700977 of_populate_phandle_cache();
978
Geert Uytterhoeven6de67de2017-11-28 09:26:33 +0100979 ret = __of_changeset_apply_notify(&ovcs->cset);
980 if (ret)
Frank Rowanda15e8242018-10-04 20:33:35 -0700981 pr_err("overlay apply changeset entry notify error %d\n", ret);
Geert Uytterhoeven6de67de2017-11-28 09:26:33 +0100982 /* notify failure is not fatal, continue */
983
Frank Rowand0290c4c2017-10-17 16:36:23 -0700984 list_add_tail(&ovcs->ovcs_list, &ovcs_list);
Frank Rowand24789c52017-10-17 16:36:26 -0700985 *ovcs_id = ovcs->id;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +0200986
Frank Rowand24789c52017-10-17 16:36:26 -0700987 ret_tmp = overlay_notify(ovcs, OF_OVERLAY_POST_APPLY);
988 if (ret_tmp) {
989 pr_err("overlay changeset post-apply notify error %d\n",
990 ret_tmp);
991 if (!ret)
992 ret = ret_tmp;
993 }
Alan Tull39a842e2016-11-01 14:14:22 -0500994
Geert Uytterhoeven5e474812017-12-05 16:27:03 +0100995 goto out_unlock;
Frank Rowandf948d6d2017-10-17 16:36:29 -0700996
Frank Rowand39a751a2018-02-12 00:19:42 -0800997err_free_tree:
998 kfree(fdt);
999 kfree(tree);
1000
Frank Rowand61b4de42017-10-17 16:36:25 -07001001err_free_overlay_changeset:
1002 free_overlay_changeset(ovcs);
1003
Geert Uytterhoeven5e474812017-12-05 16:27:03 +01001004out_unlock:
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001005 mutex_unlock(&of_mutex);
Geert Uytterhoeven5e474812017-12-05 16:27:03 +01001006 of_overlay_mutex_unlock();
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001007
Frank Rowand24789c52017-10-17 16:36:26 -07001008out:
1009 pr_debug("%s() err=%d\n", __func__, ret);
1010
Frank Rowand0290c4c2017-10-17 16:36:23 -07001011 return ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001012}
Frank Rowand39a751a2018-02-12 00:19:42 -08001013
1014int of_overlay_fdt_apply(const void *overlay_fdt, u32 overlay_fdt_size,
1015 int *ovcs_id)
1016{
1017 const void *new_fdt;
1018 int ret;
1019 u32 size;
1020 struct device_node *overlay_root;
1021
1022 *ovcs_id = 0;
1023 ret = 0;
1024
1025 if (overlay_fdt_size < sizeof(struct fdt_header) ||
1026 fdt_check_header(overlay_fdt)) {
1027 pr_err("Invalid overlay_fdt header\n");
1028 return -EINVAL;
1029 }
1030
1031 size = fdt_totalsize(overlay_fdt);
1032 if (overlay_fdt_size < size)
1033 return -EINVAL;
1034
1035 /*
1036 * Must create permanent copy of FDT because of_fdt_unflatten_tree()
1037 * will create pointers to the passed in FDT in the unflattened tree.
1038 */
1039 new_fdt = kmemdup(overlay_fdt, size, GFP_KERNEL);
1040 if (!new_fdt)
1041 return -ENOMEM;
1042
1043 of_fdt_unflatten_tree(new_fdt, NULL, &overlay_root);
1044 if (!overlay_root) {
1045 pr_err("unable to unflatten overlay_fdt\n");
1046 ret = -EINVAL;
1047 goto out_free_new_fdt;
1048 }
1049
1050 ret = of_overlay_apply(new_fdt, overlay_root, ovcs_id);
1051 if (ret < 0) {
1052 /*
1053 * new_fdt and overlay_root now belong to the overlay
1054 * changeset.
1055 * overlay changeset code is responsible for freeing them.
1056 */
1057 goto out;
1058 }
1059
1060 return 0;
1061
1062
1063out_free_new_fdt:
1064 kfree(new_fdt);
1065
1066out:
1067 return ret;
1068}
1069EXPORT_SYMBOL_GPL(of_overlay_fdt_apply);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001070
Frank Rowand646afc42017-10-17 16:36:21 -07001071/*
Frank Rowand0290c4c2017-10-17 16:36:23 -07001072 * Find @np in @tree.
1073 *
1074 * Returns 1 if @np is @tree or is contained in @tree, else 0
Frank Rowand646afc42017-10-17 16:36:21 -07001075 */
Frank Rowand0290c4c2017-10-17 16:36:23 -07001076static int find_node(struct device_node *tree, struct device_node *np)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001077{
1078 struct device_node *child;
1079
Frank Rowand0290c4c2017-10-17 16:36:23 -07001080 if (tree == np)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001081 return 1;
1082
1083 for_each_child_of_node(tree, child) {
Frank Rowand0290c4c2017-10-17 16:36:23 -07001084 if (find_node(child, np)) {
Julia Lawall001cf502015-10-22 11:02:48 +02001085 of_node_put(child);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001086 return 1;
Julia Lawall001cf502015-10-22 11:02:48 +02001087 }
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001088 }
1089
1090 return 0;
1091}
1092
Frank Rowand646afc42017-10-17 16:36:21 -07001093/*
Frank Rowand87f242c2017-10-17 16:36:27 -07001094 * Is @remove_ce_node a child of, a parent of, or the same as any
Frank Rowand0290c4c2017-10-17 16:36:23 -07001095 * node in an overlay changeset more topmost than @remove_ovcs?
1096 *
1097 * Returns 1 if found, else 0
Frank Rowand646afc42017-10-17 16:36:21 -07001098 */
Frank Rowand87f242c2017-10-17 16:36:27 -07001099static int node_overlaps_later_cs(struct overlay_changeset *remove_ovcs,
1100 struct device_node *remove_ce_node)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001101{
Frank Rowand0290c4c2017-10-17 16:36:23 -07001102 struct overlay_changeset *ovcs;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001103 struct of_changeset_entry *ce;
1104
Frank Rowand0290c4c2017-10-17 16:36:23 -07001105 list_for_each_entry_reverse(ovcs, &ovcs_list, ovcs_list) {
1106 if (ovcs == remove_ovcs)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001107 break;
1108
Frank Rowand0290c4c2017-10-17 16:36:23 -07001109 list_for_each_entry(ce, &ovcs->cset.entries, node) {
Frank Rowand87f242c2017-10-17 16:36:27 -07001110 if (find_node(ce->np, remove_ce_node)) {
1111 pr_err("%s: #%d overlaps with #%d @%pOF\n",
Frank Rowand0290c4c2017-10-17 16:36:23 -07001112 __func__, remove_ovcs->id, ovcs->id,
Frank Rowand87f242c2017-10-17 16:36:27 -07001113 remove_ce_node);
1114 return 1;
1115 }
1116 if (find_node(remove_ce_node, ce->np)) {
1117 pr_err("%s: #%d overlaps with #%d @%pOF\n",
1118 __func__, remove_ovcs->id, ovcs->id,
1119 remove_ce_node);
Frank Rowand0290c4c2017-10-17 16:36:23 -07001120 return 1;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001121 }
1122 }
1123 }
1124
Frank Rowand0290c4c2017-10-17 16:36:23 -07001125 return 0;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001126}
1127
1128/*
1129 * We can safely remove the overlay only if it's the top-most one.
1130 * Newly applied overlays are inserted at the tail of the overlay list,
1131 * so a top most overlay is the one that is closest to the tail.
1132 *
1133 * The topmost check is done by exploiting this property. For each
1134 * affected device node in the log list we check if this overlay is
1135 * the one closest to the tail. If another overlay has affected this
1136 * device node and is closest to the tail, then removal is not permited.
1137 */
Frank Rowand0290c4c2017-10-17 16:36:23 -07001138static int overlay_removal_is_ok(struct overlay_changeset *remove_ovcs)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001139{
Frank Rowand0290c4c2017-10-17 16:36:23 -07001140 struct of_changeset_entry *remove_ce;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001141
Frank Rowand0290c4c2017-10-17 16:36:23 -07001142 list_for_each_entry(remove_ce, &remove_ovcs->cset.entries, node) {
Frank Rowand87f242c2017-10-17 16:36:27 -07001143 if (node_overlaps_later_cs(remove_ovcs, remove_ce->np)) {
Frank Rowand0290c4c2017-10-17 16:36:23 -07001144 pr_err("overlay #%d is not topmost\n", remove_ovcs->id);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001145 return 0;
1146 }
1147 }
1148
1149 return 1;
1150}
1151
1152/**
Frank Rowand0290c4c2017-10-17 16:36:23 -07001153 * of_overlay_remove() - Revert and free an overlay changeset
Frank Rowand24789c52017-10-17 16:36:26 -07001154 * @ovcs_id: Pointer to overlay changeset id
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001155 *
Frank Rowand24789c52017-10-17 16:36:26 -07001156 * Removes an overlay if it is permissible. @ovcs_id was previously returned
Geert Uytterhoevena5142662018-03-09 11:44:47 +01001157 * by of_overlay_fdt_apply().
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001158 *
Frank Rowand24789c52017-10-17 16:36:26 -07001159 * If an error occurred while attempting to revert the overlay changeset,
1160 * then an attempt is made to re-apply any changeset entry that was
1161 * reverted. If an error occurs on re-apply then the state of the device
1162 * tree can not be determined, and any following attempt to apply or remove
1163 * an overlay changeset will be refused.
1164 *
1165 * A non-zero return value will not revert the changeset if error is from:
1166 * - parameter checks
Geert Uytterhoevene9d92e42017-11-28 09:25:23 +01001167 * - overlay changeset pre-remove notifier
Frank Rowand24789c52017-10-17 16:36:26 -07001168 * - overlay changeset entry revert
1169 *
1170 * If an error is returned by an overlay changeset pre-remove notifier
1171 * then no further overlay changeset pre-remove notifier will be called.
1172 *
1173 * If more than one notifier returns an error, then the last notifier
1174 * error to occur is returned.
1175 *
1176 * A non-zero return value will revert the changeset if error is from:
1177 * - overlay changeset entry notifier
Geert Uytterhoevene9d92e42017-11-28 09:25:23 +01001178 * - overlay changeset post-remove notifier
Frank Rowand24789c52017-10-17 16:36:26 -07001179 *
1180 * If an error is returned by an overlay changeset post-remove notifier
1181 * then no further overlay changeset post-remove notifier will be called.
1182 *
1183 * Returns 0 on success, or a negative error number. *ovcs_id is set to
1184 * zero after reverting the changeset, even if a subsequent error occurs.
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001185 */
Frank Rowand24789c52017-10-17 16:36:26 -07001186int of_overlay_remove(int *ovcs_id)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001187{
Frank Rowand0290c4c2017-10-17 16:36:23 -07001188 struct overlay_changeset *ovcs;
Frank Rowand24789c52017-10-17 16:36:26 -07001189 int ret, ret_apply, ret_tmp;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001190
Frank Rowand24789c52017-10-17 16:36:26 -07001191 ret = 0;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001192
Frank Rowand24789c52017-10-17 16:36:26 -07001193 if (devicetree_corrupt()) {
1194 pr_err("suspect devicetree state, refuse to remove overlay\n");
Frank Rowand0290c4c2017-10-17 16:36:23 -07001195 ret = -EBUSY;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001196 goto out;
1197 }
1198
Frank Rowand24789c52017-10-17 16:36:26 -07001199 mutex_lock(&of_mutex);
1200
1201 ovcs = idr_find(&ovcs_idr, *ovcs_id);
1202 if (!ovcs) {
1203 ret = -ENODEV;
1204 pr_err("remove: Could not find overlay #%d\n", *ovcs_id);
1205 goto out_unlock;
1206 }
1207
1208 if (!overlay_removal_is_ok(ovcs)) {
1209 ret = -EBUSY;
1210 goto out_unlock;
1211 }
1212
1213 ret = overlay_notify(ovcs, OF_OVERLAY_PRE_REMOVE);
1214 if (ret) {
1215 pr_err("overlay changeset pre-remove notify error %d\n", ret);
1216 goto out_unlock;
1217 }
Frank Rowand61b4de42017-10-17 16:36:25 -07001218
Frank Rowand0290c4c2017-10-17 16:36:23 -07001219 list_del(&ovcs->ovcs_list);
Frank Rowand61b4de42017-10-17 16:36:25 -07001220
Frank Rowandb9952b52018-07-12 14:00:07 -07001221 /*
1222 * Disable phandle cache. Avoids race condition that would arise
1223 * from removing cache entry when the associated node is deleted.
1224 */
1225 of_free_phandle_cache();
1226
Frank Rowand24789c52017-10-17 16:36:26 -07001227 ret_apply = 0;
1228 ret = __of_changeset_revert_entries(&ovcs->cset, &ret_apply);
Frank Rowandb9952b52018-07-12 14:00:07 -07001229
1230 of_populate_phandle_cache();
1231
Frank Rowand24789c52017-10-17 16:36:26 -07001232 if (ret) {
1233 if (ret_apply)
1234 devicetree_state_flags |= DTSF_REVERT_FAIL;
1235 goto out_unlock;
Frank Rowand24789c52017-10-17 16:36:26 -07001236 }
Frank Rowand61b4de42017-10-17 16:36:25 -07001237
Geert Uytterhoeven6de67de2017-11-28 09:26:33 +01001238 ret = __of_changeset_revert_notify(&ovcs->cset);
1239 if (ret)
Frank Rowanda15e8242018-10-04 20:33:35 -07001240 pr_err("overlay remove changeset entry notify error %d\n", ret);
Geert Uytterhoeven6de67de2017-11-28 09:26:33 +01001241 /* notify failure is not fatal, continue */
1242
Frank Rowand24789c52017-10-17 16:36:26 -07001243 *ovcs_id = 0;
1244
1245 ret_tmp = overlay_notify(ovcs, OF_OVERLAY_POST_REMOVE);
1246 if (ret_tmp) {
1247 pr_err("overlay changeset post-remove notify error %d\n",
1248 ret_tmp);
1249 if (!ret)
1250 ret = ret_tmp;
1251 }
Frank Rowand61b4de42017-10-17 16:36:25 -07001252
1253 free_overlay_changeset(ovcs);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001254
Frank Rowand24789c52017-10-17 16:36:26 -07001255out_unlock:
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001256 mutex_unlock(&of_mutex);
1257
Frank Rowand24789c52017-10-17 16:36:26 -07001258out:
1259 pr_debug("%s() err=%d\n", __func__, ret);
1260
Frank Rowand0290c4c2017-10-17 16:36:23 -07001261 return ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001262}
Frank Rowand0290c4c2017-10-17 16:36:23 -07001263EXPORT_SYMBOL_GPL(of_overlay_remove);
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001264
1265/**
Frank Rowand0290c4c2017-10-17 16:36:23 -07001266 * of_overlay_remove_all() - Reverts and frees all overlay changesets
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001267 *
1268 * Removes all overlays from the system in the correct order.
1269 *
Geert Uytterhoeven94a8bf92015-05-21 14:10:26 +02001270 * Returns 0 on success, or a negative error number
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001271 */
Frank Rowand0290c4c2017-10-17 16:36:23 -07001272int of_overlay_remove_all(void)
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001273{
Frank Rowand0290c4c2017-10-17 16:36:23 -07001274 struct overlay_changeset *ovcs, *ovcs_n;
Frank Rowand61b4de42017-10-17 16:36:25 -07001275 int ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001276
1277 /* the tail of list is guaranteed to be safe to remove */
Frank Rowand0290c4c2017-10-17 16:36:23 -07001278 list_for_each_entry_safe_reverse(ovcs, ovcs_n, &ovcs_list, ovcs_list) {
Frank Rowand24789c52017-10-17 16:36:26 -07001279 ret = of_overlay_remove(&ovcs->id);
Frank Rowand61b4de42017-10-17 16:36:25 -07001280 if (ret)
1281 return ret;
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001282 }
1283
Pantelis Antoniou7518b5892014-10-28 22:35:58 +02001284 return 0;
1285}
Frank Rowand0290c4c2017-10-17 16:36:23 -07001286EXPORT_SYMBOL_GPL(of_overlay_remove_all);