blob: 5c9e644ee415021013d4b4e7a1ecc288876aa885 [file] [log] [blame]
Paul Crowleyd5759812016-06-02 11:04:27 -07001/*
2 * Copyright (C) 2016 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "MetadataCrypt.h"
Paul Crowley14c8c072018-09-18 13:30:21 -070018#include "KeyBuffer.h"
Paul Crowleyd5759812016-06-02 11:04:27 -070019
20#include <string>
Paul Crowleyd5759812016-06-02 11:04:27 -070021
22#include <fcntl.h>
Paul Crowleyd5759812016-06-02 11:04:27 -070023#include <sys/param.h>
24#include <sys/stat.h>
25#include <sys/types.h>
26
Paul Crowleyd5759812016-06-02 11:04:27 -070027#include <android-base/logging.h>
Paul Crowley0fd26262018-01-30 09:48:19 -080028#include <android-base/properties.h>
Barani Muthukumaran312b7df2020-02-06 22:56:27 -080029#include <android-base/strings.h>
Paul Crowleye4c93da2017-06-16 09:21:18 -070030#include <android-base/unique_fd.h>
Paul Crowley0fd26262018-01-30 09:48:19 -080031#include <cutils/fs.h>
Paul Crowleyd5759812016-06-02 11:04:27 -070032#include <fs_mgr.h>
David Andersonb9224732019-05-13 13:02:54 -070033#include <libdm/dm.h>
Yo Chiang0af25a32020-10-07 14:20:00 +080034#include <libgsi/libgsi.h>
Paul Crowleyd5759812016-06-02 11:04:27 -070035
Daniel Rosenberg65f99c92018-08-28 01:58:49 -070036#include "Checkpoint.h"
Paul Crowley220567c2020-02-07 12:45:20 -080037#include "CryptoType.h"
Paul Crowleyd5759812016-06-02 11:04:27 -070038#include "EncryptInplace.h"
39#include "KeyStorage.h"
40#include "KeyUtil.h"
Eric Biggersd86a8ab2021-06-15 11:34:00 -070041#include "Keystore.h"
Paul Crowleyd5759812016-06-02 11:04:27 -070042#include "Utils.h"
43#include "VoldUtil.h"
Jaegeuk Kim0c52c712020-12-15 09:00:49 -080044#include "fs/Ext4.h"
45#include "fs/F2fs.h"
Paul Crowleyd5759812016-06-02 11:04:27 -070046
Paul Crowley220567c2020-02-07 12:45:20 -080047namespace android {
48namespace vold {
49
Tom Cherry4c5bde22019-01-29 14:34:01 -080050using android::fs_mgr::FstabEntry;
51using android::fs_mgr::GetEntryForMountPoint;
Paul Crowleyf4430382020-04-05 19:34:31 -070052using android::fscrypt::GetFirstApiLevel;
Pavel Grafove2e2d302017-08-01 17:15:53 +010053using android::vold::KeyBuffer;
David Andersonb9224732019-05-13 13:02:54 -070054using namespace android::dm;
David Anderson156d9d22021-09-21 17:21:57 -070055using namespace std::chrono_literals;
Pavel Grafove2e2d302017-08-01 17:15:53 +010056
Paul Crowley249c2fb2020-02-07 12:51:56 -080057// Parsed from metadata options
58struct CryptoOptions {
59 struct CryptoType cipher = invalid_crypto_type;
Paul Crowleyf56d5532020-03-22 08:02:06 -070060 bool use_legacy_options_format = false;
Paul Crowley249c2fb2020-02-07 12:51:56 -080061 bool set_dun = true; // Non-legacy driver always sets DUN
Barani Muthukumaran312b7df2020-02-06 22:56:27 -080062 bool use_hw_wrapped_key = false;
Paul Crowley249c2fb2020-02-07 12:51:56 -080063};
64
Paul Crowleyd5759812016-06-02 11:04:27 -070065static const std::string kDmNameUserdata = "userdata";
66
Paul Crowley249c2fb2020-02-07 12:51:56 -080067// The first entry in this table is the default crypto type.
Paul Crowley220567c2020-02-07 12:45:20 -080068constexpr CryptoType supported_crypto_types[] = {aes_256_xts, adiantum};
69
70static_assert(validateSupportedCryptoTypes(64, supported_crypto_types,
71 array_length(supported_crypto_types)),
72 "We have a CryptoType which was incompletely constructed.");
73
74constexpr CryptoType legacy_aes_256_xts =
75 CryptoType().set_config_name("aes-256-xts").set_kernel_name("AES-256-XTS").set_keysize(64);
76
Paul Crowley249c2fb2020-02-07 12:51:56 -080077static_assert(isValidCryptoType(64, legacy_aes_256_xts),
Paul Crowley220567c2020-02-07 12:45:20 -080078 "We have a CryptoType which was incompletely constructed.");
79
Paul Crowley249c2fb2020-02-07 12:51:56 -080080// Returns KeyGeneration suitable for key as described in CryptoOptions
81const KeyGeneration makeGen(const CryptoOptions& options) {
Barani Muthukumaran312b7df2020-02-06 22:56:27 -080082 return KeyGeneration{options.cipher.get_keysize(), true, options.use_hw_wrapped_key};
Paul Crowley249c2fb2020-02-07 12:51:56 -080083}
84
David Anderson156d9d22021-09-21 17:21:57 -070085void defaultkey_precreate_dm_device() {
86 auto& dm = DeviceMapper::Instance();
87 if (dm.GetState(kDmNameUserdata) != DmDeviceState::INVALID) {
88 LOG(INFO) << "Not pre-creating userdata encryption device; device already exists";
89 return;
90 }
91 if (!dm.CreateEmptyDevice(kDmNameUserdata)) {
92 LOG(ERROR) << "Failed to pre-create userdata metadata encryption device";
93 }
94}
95
Paul Crowleyd5759812016-06-02 11:04:27 -070096static bool mount_via_fs_mgr(const char* mount_point, const char* blk_device) {
97 // fs_mgr_do_mount runs fsck. Use setexeccon to run trusted
98 // partitions in the fsck domain.
LongPing Wei7f3ab952019-01-30 16:03:14 +080099 if (setexeccon(android::vold::sFsckContext)) {
Paul Crowleyd5759812016-06-02 11:04:27 -0700100 PLOG(ERROR) << "Failed to setexeccon";
101 return false;
102 }
Tom Cherry4c5bde22019-01-29 14:34:01 -0800103 auto mount_rc = fs_mgr_do_mount(&fstab_default, const_cast<char*>(mount_point),
Daniel Rosenberg65f99c92018-08-28 01:58:49 -0700104 const_cast<char*>(blk_device), nullptr,
Paul Lawrence3fe93112020-06-12 08:12:48 -0700105 android::vold::cp_needsCheckpoint(), true);
Paul Crowleyd5759812016-06-02 11:04:27 -0700106 if (setexeccon(nullptr)) {
107 PLOG(ERROR) << "Failed to clear setexeccon";
108 return false;
109 }
110 if (mount_rc != 0) {
111 LOG(ERROR) << "fs_mgr_do_mount failed with rc " << mount_rc;
112 return false;
113 }
114 LOG(DEBUG) << "Mounted " << mount_point;
115 return true;
116}
117
Paul Crowley4eac2642020-02-12 11:04:05 -0800118static bool read_key(const std::string& metadata_key_dir, const KeyGeneration& gen,
119 KeyBuffer* key) {
Paul Crowley572c0242020-02-14 01:15:35 -0800120 if (metadata_key_dir.empty()) {
Paul Crowleyc9b92f02020-01-30 15:26:15 -0800121 LOG(ERROR) << "Failed to get metadata_key_dir";
Paul Crowleyd5759812016-06-02 11:04:27 -0700122 return false;
123 }
Daniel Rosenberg690d6de2018-12-14 01:08:10 -0800124 std::string sKey;
Paul Crowleyc9b92f02020-01-30 15:26:15 -0800125 auto dir = metadata_key_dir + "/key";
126 LOG(DEBUG) << "metadata_key_dir/key: " << dir;
Eric Biggersfec0c0e2021-02-16 15:59:17 -0800127 if (!MkdirsSync(dir, 0700)) return false;
Howard Chencbc1bdb2021-09-14 14:40:59 +0800128 auto in_dsu = android::base::GetBoolProperty("ro.gsid.image_running", false);
129 // !pathExists(dir) does not imply there's a factory reset when in DSU mode.
130 if (!pathExists(dir) && !in_dsu) {
Paul Crowley1e6a5f52021-08-06 15:16:10 -0700131 auto delete_all = android::base::GetBoolProperty(
132 "ro.crypto.metadata_init_delete_all_keys.enabled", false);
133 if (delete_all) {
134 LOG(INFO) << "Metadata key does not exist, calling deleteAllKeys";
135 Keystore::deleteAllKeys();
136 } else {
137 LOG(DEBUG) << "Metadata key does not exist but "
138 "ro.crypto.metadata_init_delete_all_keys.enabled is false";
139 }
140 }
Paul Crowleyc9b92f02020-01-30 15:26:15 -0800141 auto temp = metadata_key_dir + "/tmp";
Eric Biggersf74373b2020-11-05 19:58:26 -0800142 return retrieveOrGenerateKey(dir, temp, kEmptyAuthentication, gen, key);
Paul Crowleyd5759812016-06-02 11:04:27 -0700143}
144
Paul Crowley14c8c072018-09-18 13:30:21 -0700145static bool get_number_of_sectors(const std::string& real_blkdev, uint64_t* nr_sec) {
Oleksiy Avramchenko625dc782018-05-23 10:50:46 +0200146 if (android::vold::GetBlockDev512Sectors(real_blkdev, nr_sec) != android::OK) {
Paul Crowleyd5759812016-06-02 11:04:27 -0700147 PLOG(ERROR) << "Unable to measure size of " << real_blkdev;
148 return false;
149 }
Paul Crowleyd5759812016-06-02 11:04:27 -0700150 return true;
151}
152
Paul Crowley572c0242020-02-14 01:15:35 -0800153static bool create_crypto_blk_dev(const std::string& dm_name, const std::string& blk_device,
Paul Crowley249c2fb2020-02-07 12:51:56 -0800154 const KeyBuffer& key, const CryptoOptions& options,
Paul Crowley886e5722020-02-07 12:51:56 -0800155 std::string* crypto_blkdev, uint64_t* nr_sec) {
156 if (!get_number_of_sectors(blk_device, nr_sec)) return false;
157 // TODO(paulcrowley): don't hardcode that DmTargetDefaultKey uses 4096-byte
158 // sectors
159 *nr_sec &= ~7;
Paul Crowley84e84c52020-01-29 16:09:19 -0800160
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800161 KeyBuffer module_key;
162 if (options.use_hw_wrapped_key) {
163 if (!exportWrappedStorageKey(key, &module_key)) {
164 LOG(ERROR) << "Failed to get ephemeral wrapped key";
165 return false;
166 }
167 } else {
168 module_key = key;
169 }
170
David Andersonb9224732019-05-13 13:02:54 -0700171 KeyBuffer hex_key_buffer;
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800172 if (android::vold::StrToHex(module_key, hex_key_buffer) != android::OK) {
David Andersonb9224732019-05-13 13:02:54 -0700173 LOG(ERROR) << "Failed to turn key to hex";
Paul Crowleyd5759812016-06-02 11:04:27 -0700174 return false;
175 }
David Andersonb9224732019-05-13 13:02:54 -0700176 std::string hex_key(hex_key_buffer.data(), hex_key_buffer.size());
Paul Crowleyd5759812016-06-02 11:04:27 -0700177
Paul Crowley886e5722020-02-07 12:51:56 -0800178 auto target = std::make_unique<DmTargetDefaultKey>(0, *nr_sec, options.cipher.get_kernel_name(),
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800179 hex_key, blk_device, 0);
Paul Crowleyf56d5532020-03-22 08:02:06 -0700180 if (options.use_legacy_options_format) target->SetUseLegacyOptionsFormat();
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800181 if (options.set_dun) target->SetSetDun();
182 if (options.use_hw_wrapped_key) target->SetWrappedKeyV0();
183
Paul Crowleyc9b92f02020-01-30 15:26:15 -0800184 DmTable table;
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800185 table.AddTarget(std::move(target));
Paul Crowleyc9b92f02020-01-30 15:26:15 -0800186
187 auto& dm = DeviceMapper::Instance();
David Anderson156d9d22021-09-21 17:21:57 -0700188 if (dm_name == kDmNameUserdata && dm.GetState(dm_name) == DmDeviceState::SUSPENDED) {
189 // The device was created in advance, populate it now.
David Anderson156d9d22021-09-21 17:21:57 -0700190 if (!dm.LoadTableAndActivate(dm_name, table)) {
191 LOG(ERROR) << "Failed to populate default-key device " << dm_name;
192 return false;
193 }
Will McVickerb910e7e2021-12-23 12:23:39 -0800194 if (!dm.WaitForDevice(dm_name, 5s, crypto_blkdev)) {
195 LOG(ERROR) << "Failed to wait for default-key device " << dm_name;
196 return false;
197 }
David Anderson156d9d22021-09-21 17:21:57 -0700198 } else if (!dm.CreateDevice(dm_name, table, crypto_blkdev, 5s)) {
199 LOG(ERROR) << "Could not create default-key device " << dm_name;
Eric Biggers836b51b2020-10-15 14:39:34 -0700200 return false;
Paul Crowleyd5759812016-06-02 11:04:27 -0700201 }
Paul Crowleyd5759812016-06-02 11:04:27 -0700202 return true;
203}
204
Paul Crowley249c2fb2020-02-07 12:51:56 -0800205static const CryptoType& lookup_cipher(const std::string& cipher_name) {
206 if (cipher_name.empty()) return supported_crypto_types[0];
207 for (size_t i = 0; i < array_length(supported_crypto_types); i++) {
208 if (cipher_name == supported_crypto_types[i].get_config_name()) {
209 return supported_crypto_types[i];
Paul Crowley572c0242020-02-14 01:15:35 -0800210 }
211 }
212 return invalid_crypto_type;
213}
214
Paul Crowley249c2fb2020-02-07 12:51:56 -0800215static bool parse_options(const std::string& options_string, CryptoOptions* options) {
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800216 auto parts = android::base::Split(options_string, ":");
217 if (parts.size() < 1 || parts.size() > 2) {
218 LOG(ERROR) << "Invalid metadata encryption option: " << options_string;
Paul Crowley249c2fb2020-02-07 12:51:56 -0800219 return false;
Paul Crowley572c0242020-02-14 01:15:35 -0800220 }
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800221 std::string cipher_name = parts[0];
222 options->cipher = lookup_cipher(cipher_name);
223 if (options->cipher.get_kernel_name() == nullptr) {
224 LOG(ERROR) << "No metadata cipher named " << cipher_name << " found";
225 return false;
226 }
227
228 if (parts.size() == 2) {
229 if (parts[1] == "wrappedkey_v0") {
230 options->use_hw_wrapped_key = true;
231 } else {
232 LOG(ERROR) << "Invalid metadata encryption flag: " << parts[1];
233 return false;
234 }
235 }
Paul Crowley249c2fb2020-02-07 12:51:56 -0800236 return true;
Paul Crowley572c0242020-02-14 01:15:35 -0800237}
238
Paul Lawrence236e5e82019-06-25 14:44:33 -0700239bool fscrypt_mount_metadata_encrypted(const std::string& blk_device, const std::string& mount_point,
Jaegeuk Kim0c52c712020-12-15 09:00:49 -0800240 bool needs_encrypt, bool should_format,
241 const std::string& fs_type) {
242 LOG(DEBUG) << "fscrypt_mount_metadata_encrypted: " << mount_point
243 << " encrypt: " << needs_encrypt << " format: " << should_format << " with "
244 << fs_type;
Paul Crowley0fd26262018-01-30 09:48:19 -0800245 auto encrypted_state = android::base::GetProperty("ro.crypto.state", "");
Nikita Ioffef850e6e2019-12-09 21:19:11 +0000246 if (encrypted_state != "" && encrypted_state != "encrypted") {
David Andersone1791572021-11-05 18:57:49 -0700247 LOG(ERROR) << "fscrypt_mount_metadata_encrypted got unexpected starting state: "
248 << encrypted_state;
Paul Crowleyd5759812016-06-02 11:04:27 -0700249 return false;
250 }
Tom Cherry4c5bde22019-01-29 14:34:01 -0800251
252 auto data_rec = GetEntryForMountPoint(&fstab_default, mount_point);
Paul Crowleyd5759812016-06-02 11:04:27 -0700253 if (!data_rec) {
Paul Crowleyc9b92f02020-01-30 15:26:15 -0800254 LOG(ERROR) << "Failed to get data_rec for " << mount_point;
255 return false;
256 }
Paul Crowley572c0242020-02-14 01:15:35 -0800257
Paul Crowleyf56d5532020-03-22 08:02:06 -0700258 unsigned int options_format_version = android::base::GetUintProperty<unsigned int>(
259 "ro.crypto.dm_default_key.options_format.version",
Eric Biggers72d07132020-08-10 10:55:56 -0700260 (GetFirstApiLevel() <= __ANDROID_API_Q__ ? 1 : 2));
Paul Crowley572c0242020-02-14 01:15:35 -0800261
Paul Crowley249c2fb2020-02-07 12:51:56 -0800262 CryptoOptions options;
Paul Crowleyf56d5532020-03-22 08:02:06 -0700263 if (options_format_version == 1) {
Eric Biggers41d78432022-03-17 23:18:18 +0000264 if (!data_rec->metadata_encryption_options.empty()) {
Barani Muthukumaran312b7df2020-02-06 22:56:27 -0800265 LOG(ERROR) << "metadata_encryption options cannot be set in legacy mode";
Paul Crowley249c2fb2020-02-07 12:51:56 -0800266 return false;
267 }
268 options.cipher = legacy_aes_256_xts;
Paul Crowleyf56d5532020-03-22 08:02:06 -0700269 options.use_legacy_options_format = true;
Paul Crowley249c2fb2020-02-07 12:51:56 -0800270 options.set_dun = android::base::GetBoolProperty("ro.crypto.set_dun", false);
271 if (!options.set_dun && data_rec->fs_mgr_flags.checkpoint_blk) {
272 LOG(ERROR)
273 << "Block checkpoints and metadata encryption require ro.crypto.set_dun option";
274 return false;
275 }
Paul Crowleyf56d5532020-03-22 08:02:06 -0700276 } else if (options_format_version == 2) {
Eric Biggers41d78432022-03-17 23:18:18 +0000277 if (!parse_options(data_rec->metadata_encryption_options, &options)) return false;
Paul Crowleyf56d5532020-03-22 08:02:06 -0700278 } else {
279 LOG(ERROR) << "Unknown options_format_version: " << options_format_version;
280 return false;
Paul Crowley572c0242020-02-14 01:15:35 -0800281 }
282
Paul Crowley249c2fb2020-02-07 12:51:56 -0800283 auto gen = needs_encrypt ? makeGen(options) : neverGen();
Paul Crowley0fd26262018-01-30 09:48:19 -0800284 KeyBuffer key;
David Andersone1791572021-11-05 18:57:49 -0700285 if (!read_key(data_rec->metadata_key_dir, gen, &key)) {
286 LOG(ERROR) << "read_key failed in mountFstab";
287 return false;
288 }
Paul Lawrence4b140d32019-08-07 15:22:57 -0700289
Paul Crowleyd5759812016-06-02 11:04:27 -0700290 std::string crypto_blkdev;
Paul Crowley886e5722020-02-07 12:51:56 -0800291 uint64_t nr_sec;
David Andersone1791572021-11-05 18:57:49 -0700292 if (!create_crypto_blk_dev(kDmNameUserdata, blk_device, key, options, &crypto_blkdev,
293 &nr_sec)) {
294 LOG(ERROR) << "create_crypto_blk_dev failed in mountFstab";
Paul Crowley572c0242020-02-14 01:15:35 -0800295 return false;
David Andersone1791572021-11-05 18:57:49 -0700296 }
Paul Lawrence236e5e82019-06-25 14:44:33 -0700297
Jaegeuk Kim0c52c712020-12-15 09:00:49 -0800298 if (needs_encrypt) {
299 if (should_format) {
300 status_t error;
301
302 if (fs_type == "ext4") {
303 error = ext4::Format(crypto_blkdev, 0, mount_point);
304 } else if (fs_type == "f2fs") {
305 error = f2fs::Format(crypto_blkdev);
306 } else {
307 LOG(ERROR) << "Unknown filesystem type: " << fs_type;
308 return false;
309 }
David Andersone1791572021-11-05 18:57:49 -0700310 if (error != 0) {
311 LOG(ERROR) << "Format of " << crypto_blkdev << " for " << mount_point
312 << " failed (err=" << error << ").";
313 return false;
314 }
315 LOG(DEBUG) << "Format of " << crypto_blkdev << " for " << mount_point << " succeeded.";
Jaegeuk Kim0c52c712020-12-15 09:00:49 -0800316 } else {
Eric Biggers640a1a92022-03-09 20:39:04 +0000317 if (!encrypt_inplace(crypto_blkdev, blk_device, nr_sec)) {
David Andersone1791572021-11-05 18:57:49 -0700318 LOG(ERROR) << "encrypt_inplace failed in mountFstab";
319 return false;
320 }
Jaegeuk Kim0c52c712020-12-15 09:00:49 -0800321 }
322 }
Paul Crowleyd5759812016-06-02 11:04:27 -0700323
Paul Crowley0fd26262018-01-30 09:48:19 -0800324 LOG(DEBUG) << "Mounting metadata-encrypted filesystem:" << mount_point;
Paul Crowley48aa90c2020-03-02 12:57:58 -0800325 mount_via_fs_mgr(mount_point.c_str(), crypto_blkdev.c_str());
Paul Crowley7fbd8d42020-03-23 08:59:12 -0700326
327 // Record that there's at least one fstab entry with metadata encryption
328 if (!android::base::SetProperty("ro.crypto.metadata.enabled", "true")) {
329 LOG(WARNING) << "failed to set ro.crypto.metadata.enabled"; // This isn't fatal
330 }
Paul Crowleyd5759812016-06-02 11:04:27 -0700331 return true;
332}
Paul Crowley220567c2020-02-07 12:45:20 -0800333
Paul Crowley886e5722020-02-07 12:51:56 -0800334static bool get_volume_options(CryptoOptions* options) {
335 return parse_options(android::base::GetProperty("ro.crypto.volume.metadata.encryption", ""),
336 options);
337}
338
339bool defaultkey_volume_keygen(KeyGeneration* gen) {
340 CryptoOptions options;
341 if (!get_volume_options(&options)) return false;
342 *gen = makeGen(options);
343 return true;
344}
345
346bool defaultkey_setup_ext_volume(const std::string& label, const std::string& blk_device,
347 const KeyBuffer& key, std::string* out_crypto_blkdev) {
348 LOG(DEBUG) << "defaultkey_setup_ext_volume: " << label << " " << blk_device;
349
350 CryptoOptions options;
351 if (!get_volume_options(&options)) return false;
352 uint64_t nr_sec;
353 return create_crypto_blk_dev(label, blk_device, key, options, out_crypto_blkdev, &nr_sec);
354}
355
Yo Chiang0af25a32020-10-07 14:20:00 +0800356bool destroy_dsu_metadata_key(const std::string& dsu_slot) {
357 LOG(DEBUG) << "destroy_dsu_metadata_key: " << dsu_slot;
358
359 const auto dsu_metadata_key_dir = android::gsi::GetDsuMetadataKeyDir(dsu_slot);
360 if (!pathExists(dsu_metadata_key_dir)) {
361 LOG(DEBUG) << "DSU metadata_key_dir doesn't exist, nothing to remove: "
362 << dsu_metadata_key_dir;
363 return true;
364 }
365
366 // Ensure that the DSU key directory is different from the host OS'.
367 // Under normal circumstances, this should never happen, but handle it just in case.
368 if (auto data_rec = GetEntryForMountPoint(&fstab_default, "/data")) {
369 if (dsu_metadata_key_dir == data_rec->metadata_key_dir) {
370 LOG(ERROR) << "DSU metadata_key_dir is same as host OS: " << dsu_metadata_key_dir;
371 return false;
372 }
373 }
374
375 bool ok = true;
376 for (auto suffix : {"/key", "/tmp"}) {
377 const auto key_path = dsu_metadata_key_dir + suffix;
378 if (pathExists(key_path)) {
379 LOG(DEBUG) << "Destroy key: " << key_path;
380 if (!android::vold::destroyKey(key_path)) {
381 LOG(ERROR) << "Failed to destroyKey(): " << key_path;
382 ok = false;
383 }
384 }
385 }
386 if (!ok) {
387 return false;
388 }
389
390 LOG(DEBUG) << "Remove DSU metadata_key_dir: " << dsu_metadata_key_dir;
391 // DeleteDirContentsAndDir() already logged any error, so don't log repeatedly.
392 return android::vold::DeleteDirContentsAndDir(dsu_metadata_key_dir) == android::OK;
393}
394
Paul Crowley220567c2020-02-07 12:45:20 -0800395} // namespace vold
396} // namespace android