Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2016 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | #include "MetadataCrypt.h" |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 18 | #include "KeyBuffer.h" |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 19 | |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 20 | #include <algorithm> |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 21 | #include <string> |
| 22 | #include <thread> |
| 23 | #include <vector> |
| 24 | |
| 25 | #include <fcntl.h> |
| 26 | #include <sys/ioctl.h> |
| 27 | #include <sys/param.h> |
| 28 | #include <sys/stat.h> |
| 29 | #include <sys/types.h> |
| 30 | |
| 31 | #include <linux/dm-ioctl.h> |
| 32 | |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 33 | #include <android-base/file.h> |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 34 | #include <android-base/logging.h> |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 35 | #include <android-base/properties.h> |
Paul Crowley | e4c93da | 2017-06-16 09:21:18 -0700 | [diff] [blame] | 36 | #include <android-base/unique_fd.h> |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 37 | #include <cutils/fs.h> |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 38 | #include <fs_mgr.h> |
| 39 | |
Daniel Rosenberg | 65f99c9 | 2018-08-28 01:58:49 -0700 | [diff] [blame] | 40 | #include "Checkpoint.h" |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 41 | #include "EncryptInplace.h" |
| 42 | #include "KeyStorage.h" |
| 43 | #include "KeyUtil.h" |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 44 | #include "Keymaster.h" |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 45 | #include "Utils.h" |
| 46 | #include "VoldUtil.h" |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 47 | #include "secontext.h" |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 48 | |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 49 | #define DM_CRYPT_BUF_SIZE 4096 |
| 50 | #define TABLE_LOAD_RETRIES 10 |
| 51 | #define DEFAULT_KEY_TARGET_TYPE "default-key" |
| 52 | |
Pavel Grafov | e2e2d30 | 2017-08-01 17:15:53 +0100 | [diff] [blame] | 53 | using android::vold::KeyBuffer; |
| 54 | |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 55 | static const std::string kDmNameUserdata = "userdata"; |
| 56 | |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 57 | static const char* kFn_keymaster_key_blob = "keymaster_key_blob"; |
| 58 | static const char* kFn_keymaster_key_blob_upgraded = "keymaster_key_blob_upgraded"; |
| 59 | |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 60 | static bool mount_via_fs_mgr(const char* mount_point, const char* blk_device) { |
| 61 | // fs_mgr_do_mount runs fsck. Use setexeccon to run trusted |
| 62 | // partitions in the fsck domain. |
| 63 | if (setexeccon(secontextFsck())) { |
| 64 | PLOG(ERROR) << "Failed to setexeccon"; |
| 65 | return false; |
| 66 | } |
Paul Crowley | e2ee152 | 2017-09-26 14:05:26 -0700 | [diff] [blame] | 67 | auto mount_rc = fs_mgr_do_mount(fstab_default, const_cast<char*>(mount_point), |
Daniel Rosenberg | 65f99c9 | 2018-08-28 01:58:49 -0700 | [diff] [blame] | 68 | const_cast<char*>(blk_device), nullptr, |
| 69 | android::vold::cp_needsCheckpoint()); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 70 | if (setexeccon(nullptr)) { |
| 71 | PLOG(ERROR) << "Failed to clear setexeccon"; |
| 72 | return false; |
| 73 | } |
| 74 | if (mount_rc != 0) { |
| 75 | LOG(ERROR) << "fs_mgr_do_mount failed with rc " << mount_rc; |
| 76 | return false; |
| 77 | } |
| 78 | LOG(DEBUG) << "Mounted " << mount_point; |
| 79 | return true; |
| 80 | } |
| 81 | |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 82 | namespace android { |
| 83 | namespace vold { |
| 84 | |
| 85 | // Note: It is possible to orphan a key if it is removed before deleting |
| 86 | // Update this once keymaster APIs change, and we have a proper commit. |
Greg Kaiser | fef650f | 2018-12-18 11:10:31 -0800 | [diff] [blame] | 87 | static void commit_key(const std::string& dir) { |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 88 | while (!android::base::WaitForProperty("vold.checkpoint_committed", "1")) { |
| 89 | LOG(ERROR) << "Wait for boot timed out"; |
| 90 | } |
| 91 | Keymaster keymaster; |
| 92 | auto keyPath = dir + "/" + kFn_keymaster_key_blob; |
| 93 | auto newKeyPath = dir + "/" + kFn_keymaster_key_blob_upgraded; |
| 94 | std::string key; |
| 95 | |
| 96 | if (!android::base::ReadFileToString(keyPath, &key)) { |
| 97 | LOG(ERROR) << "Failed to read old key: " << dir; |
| 98 | return; |
| 99 | } |
| 100 | if (rename(newKeyPath.c_str(), keyPath.c_str()) != 0) { |
| 101 | PLOG(ERROR) << "Unable to move upgraded key to location: " << keyPath; |
| 102 | return; |
| 103 | } |
| 104 | if (!keymaster.deleteKey(key)) { |
| 105 | LOG(ERROR) << "Key deletion failed during upgrade, continuing anyway: " << dir; |
| 106 | } |
| 107 | LOG(INFO) << "Old Key deleted: " << dir; |
| 108 | } |
| 109 | |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 110 | static bool read_key(struct fstab_rec const* data_rec, bool create_if_absent, KeyBuffer* key) { |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 111 | if (!data_rec->key_dir) { |
| 112 | LOG(ERROR) << "Failed to get key_dir"; |
| 113 | return false; |
| 114 | } |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 115 | std::string key_dir = data_rec->key_dir; |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 116 | std::string sKey; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 117 | auto dir = key_dir + "/key"; |
Paul Crowley | 98a23a1 | 2018-05-09 13:01:16 -0700 | [diff] [blame] | 118 | LOG(DEBUG) << "key_dir/key: " << dir; |
| 119 | if (fs_mkdirs(dir.c_str(), 0700)) { |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 120 | PLOG(ERROR) << "Creating directories: " << dir; |
Paul Crowley | 98a23a1 | 2018-05-09 13:01:16 -0700 | [diff] [blame] | 121 | return false; |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 122 | } |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 123 | auto temp = key_dir + "/tmp"; |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 124 | auto newKeyPath = dir + "/" + kFn_keymaster_key_blob_upgraded; |
| 125 | /* If we have a leftover upgraded key, delete it. |
| 126 | * We either failed an update and must return to the old key, |
| 127 | * or we rebooted before commiting the keys in a freak accident. |
| 128 | * Either way, we can re-upgrade the key if we need to. |
| 129 | */ |
| 130 | Keymaster keymaster; |
| 131 | if (pathExists(newKeyPath)) { |
| 132 | if (!android::base::ReadFileToString(newKeyPath, &sKey)) |
| 133 | LOG(ERROR) << "Failed to read old key: " << dir; |
| 134 | else if (!keymaster.deleteKey(sKey)) |
| 135 | LOG(ERROR) << "Old key deletion failed, continuing anyway: " << dir; |
| 136 | else |
| 137 | unlink(newKeyPath.c_str()); |
| 138 | } |
| 139 | bool needs_cp = cp_needsCheckpoint(); |
| 140 | if (!android::vold::retrieveKey(create_if_absent, dir, temp, key, needs_cp)) return false; |
| 141 | if (needs_cp && pathExists(newKeyPath)) std::thread(commit_key, dir).detach(); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 142 | return true; |
| 143 | } |
| 144 | |
Daniel Rosenberg | 690d6de | 2018-12-14 01:08:10 -0800 | [diff] [blame] | 145 | } // namespace vold |
| 146 | } // namespace android |
| 147 | |
Pavel Grafov | e2e2d30 | 2017-08-01 17:15:53 +0100 | [diff] [blame] | 148 | static KeyBuffer default_key_params(const std::string& real_blkdev, const KeyBuffer& key) { |
| 149 | KeyBuffer hex_key; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 150 | if (android::vold::StrToHex(key, hex_key) != android::OK) { |
| 151 | LOG(ERROR) << "Failed to turn key to hex"; |
Pavel Grafov | e2e2d30 | 2017-08-01 17:15:53 +0100 | [diff] [blame] | 152 | return KeyBuffer(); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 153 | } |
Pavel Grafov | e2e2d30 | 2017-08-01 17:15:53 +0100 | [diff] [blame] | 154 | auto res = KeyBuffer() + "AES-256-XTS " + hex_key + " " + real_blkdev.c_str() + " 0"; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 155 | return res; |
| 156 | } |
| 157 | |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 158 | static bool get_number_of_sectors(const std::string& real_blkdev, uint64_t* nr_sec) { |
Oleksiy Avramchenko | 625dc78 | 2018-05-23 10:50:46 +0200 | [diff] [blame] | 159 | if (android::vold::GetBlockDev512Sectors(real_blkdev, nr_sec) != android::OK) { |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 160 | PLOG(ERROR) << "Unable to measure size of " << real_blkdev; |
| 161 | return false; |
| 162 | } |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 163 | return true; |
| 164 | } |
| 165 | |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 166 | static struct dm_ioctl* dm_ioctl_init(char* buffer, size_t buffer_size, const std::string& dm_name) { |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 167 | if (buffer_size < sizeof(dm_ioctl)) { |
| 168 | LOG(ERROR) << "dm_ioctl buffer too small"; |
| 169 | return nullptr; |
| 170 | } |
| 171 | |
| 172 | memset(buffer, 0, buffer_size); |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 173 | struct dm_ioctl* io = (struct dm_ioctl*)buffer; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 174 | io->data_size = buffer_size; |
| 175 | io->data_start = sizeof(struct dm_ioctl); |
| 176 | io->version[0] = 4; |
| 177 | io->version[1] = 0; |
| 178 | io->version[2] = 0; |
| 179 | io->flags = 0; |
| 180 | dm_name.copy(io->name, sizeof(io->name)); |
| 181 | return io; |
| 182 | } |
| 183 | |
| 184 | static bool create_crypto_blk_dev(const std::string& dm_name, uint64_t nr_sec, |
Pavel Grafov | e2e2d30 | 2017-08-01 17:15:53 +0100 | [diff] [blame] | 185 | const std::string& target_type, const KeyBuffer& crypt_params, |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 186 | std::string* crypto_blkdev) { |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 187 | android::base::unique_fd dm_fd( |
| 188 | TEMP_FAILURE_RETRY(open("/dev/device-mapper", O_RDWR | O_CLOEXEC, 0))); |
Paul Crowley | e4c93da | 2017-06-16 09:21:18 -0700 | [diff] [blame] | 189 | if (dm_fd == -1) { |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 190 | PLOG(ERROR) << "Cannot open device-mapper"; |
| 191 | return false; |
| 192 | } |
| 193 | alignas(struct dm_ioctl) char buffer[DM_CRYPT_BUF_SIZE]; |
| 194 | auto io = dm_ioctl_init(buffer, sizeof(buffer), dm_name); |
| 195 | if (!io || ioctl(dm_fd.get(), DM_DEV_CREATE, io) != 0) { |
| 196 | PLOG(ERROR) << "Cannot create dm-crypt device " << dm_name; |
| 197 | return false; |
| 198 | } |
| 199 | |
| 200 | // Get the device status, in particular, the name of its device file |
| 201 | io = dm_ioctl_init(buffer, sizeof(buffer), dm_name); |
| 202 | if (ioctl(dm_fd.get(), DM_DEV_STATUS, io) != 0) { |
| 203 | PLOG(ERROR) << "Cannot retrieve dm-crypt device status " << dm_name; |
| 204 | return false; |
| 205 | } |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 206 | *crypto_blkdev = std::string() + "/dev/block/dm-" + |
| 207 | std::to_string((io->dev & 0xff) | ((io->dev >> 12) & 0xfff00)); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 208 | |
| 209 | io = dm_ioctl_init(buffer, sizeof(buffer), dm_name); |
Pavel Grafov | e2e2d30 | 2017-08-01 17:15:53 +0100 | [diff] [blame] | 210 | size_t paramix = io->data_start + sizeof(struct dm_target_spec); |
| 211 | size_t nullix = paramix + crypt_params.size(); |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 212 | size_t endix = (nullix + 1 + 7) & 8; // Add room for \0 and align to 8 byte boundary |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 213 | |
| 214 | if (endix > sizeof(buffer)) { |
| 215 | LOG(ERROR) << "crypt_params too big for DM_CRYPT_BUF_SIZE"; |
| 216 | return false; |
| 217 | } |
| 218 | |
| 219 | io->target_count = 1; |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 220 | auto tgt = (struct dm_target_spec*)(buffer + io->data_start); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 221 | tgt->status = 0; |
| 222 | tgt->sector_start = 0; |
| 223 | tgt->length = nr_sec; |
| 224 | target_type.copy(tgt->target_type, sizeof(tgt->target_type)); |
Pavel Grafov | e2e2d30 | 2017-08-01 17:15:53 +0100 | [diff] [blame] | 225 | memcpy(buffer + paramix, crypt_params.data(), |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 226 | std::min(crypt_params.size(), sizeof(buffer) - paramix)); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 227 | buffer[nullix] = '\0'; |
| 228 | tgt->next = endix; |
| 229 | |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 230 | for (int i = 0;; i++) { |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 231 | if (ioctl(dm_fd.get(), DM_TABLE_LOAD, io) == 0) { |
| 232 | break; |
| 233 | } |
Paul Crowley | 14c8c07 | 2018-09-18 13:30:21 -0700 | [diff] [blame] | 234 | if (i + 1 >= TABLE_LOAD_RETRIES) { |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 235 | PLOG(ERROR) << "DM_TABLE_LOAD ioctl failed"; |
| 236 | return false; |
| 237 | } |
| 238 | PLOG(INFO) << "DM_TABLE_LOAD ioctl failed, retrying"; |
| 239 | usleep(500000); |
| 240 | } |
| 241 | |
| 242 | // Resume this device to activate it |
| 243 | io = dm_ioctl_init(buffer, sizeof(buffer), dm_name); |
| 244 | if (ioctl(dm_fd.get(), DM_DEV_SUSPEND, io)) { |
| 245 | PLOG(ERROR) << "Cannot resume dm-crypt device " << dm_name; |
| 246 | return false; |
| 247 | } |
| 248 | return true; |
| 249 | } |
| 250 | |
Eric Biggers | a701c45 | 2018-10-23 13:06:55 -0700 | [diff] [blame] | 251 | bool fscrypt_mount_metadata_encrypted(const std::string& mount_point, bool needs_encrypt) { |
| 252 | LOG(DEBUG) << "fscrypt_mount_metadata_encrypted: " << mount_point << " " << needs_encrypt; |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 253 | auto encrypted_state = android::base::GetProperty("ro.crypto.state", ""); |
| 254 | if (encrypted_state != "") { |
Eric Biggers | a701c45 | 2018-10-23 13:06:55 -0700 | [diff] [blame] | 255 | LOG(DEBUG) << "fscrypt_enable_crypto got unexpected starting state: " << encrypted_state; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 256 | return false; |
| 257 | } |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 258 | auto data_rec = fs_mgr_get_entry_for_mount_point(fstab_default, mount_point); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 259 | if (!data_rec) { |
| 260 | LOG(ERROR) << "Failed to get data_rec"; |
| 261 | return false; |
| 262 | } |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 263 | KeyBuffer key; |
| 264 | if (!read_key(data_rec, needs_encrypt, &key)) return false; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 265 | uint64_t nr_sec; |
| 266 | if (!get_number_of_sectors(data_rec->blk_device, &nr_sec)) return false; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 267 | std::string crypto_blkdev; |
| 268 | if (!create_crypto_blk_dev(kDmNameUserdata, nr_sec, DEFAULT_KEY_TARGET_TYPE, |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 269 | default_key_params(data_rec->blk_device, key), &crypto_blkdev)) |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 270 | return false; |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 271 | // FIXME handle the corrupt case |
| 272 | if (needs_encrypt) { |
| 273 | LOG(INFO) << "Beginning inplace encryption, nr_sec: " << nr_sec; |
| 274 | off64_t size_already_done = 0; |
| 275 | auto rc = |
| 276 | cryptfs_enable_inplace(const_cast<char*>(crypto_blkdev.c_str()), data_rec->blk_device, |
| 277 | nr_sec, &size_already_done, nr_sec, 0, false); |
| 278 | if (rc != 0) { |
| 279 | LOG(ERROR) << "Inplace crypto failed with code: " << rc; |
| 280 | return false; |
| 281 | } |
| 282 | if (static_cast<uint64_t>(size_already_done) != nr_sec) { |
| 283 | LOG(ERROR) << "Inplace crypto only got up to sector: " << size_already_done; |
| 284 | return false; |
| 285 | } |
| 286 | LOG(INFO) << "Inplace encryption complete"; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 287 | } |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 288 | |
Paul Crowley | 0fd2626 | 2018-01-30 09:48:19 -0800 | [diff] [blame] | 289 | LOG(DEBUG) << "Mounting metadata-encrypted filesystem:" << mount_point; |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 290 | mount_via_fs_mgr(data_rec->mount_point, crypto_blkdev.c_str()); |
Paul Crowley | d575981 | 2016-06-02 11:04:27 -0700 | [diff] [blame] | 291 | return true; |
| 292 | } |