blob: a0ff11951a66a44a86ea48c7b9c56278944ab0a8 [file] [log] [blame]
Dan Albert4ae5d4b2014-10-31 16:23:08 -07001##############################################
2## Perform configuration steps for sanitizers.
3##############################################
4
Dan Albert27ccb752015-04-16 16:21:02 -07005my_sanitize := $(strip $(LOCAL_SANITIZE))
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -08006my_sanitize_diag := $(strip $(LOCAL_SANITIZE_DIAG))
Dan Albert08cca282014-12-11 18:56:26 -08007
Dan Albert4c401412015-08-19 20:13:33 -07008my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -07009my_global_sanitize_diag :=
Dan Willemsenf0638392018-09-04 22:25:22 -070010ifdef LOCAL_IS_HOST_MODULE
11 ifneq ($($(my_prefix)OS),windows)
12 my_global_sanitize := $(strip $(SANITIZE_HOST))
Dan Albert4c401412015-08-19 20:13:33 -070013
Dan Willemsenf0638392018-09-04 22:25:22 -070014 # SANITIZE_HOST=true is a deprecated way to say SANITIZE_HOST=address.
15 my_global_sanitize := $(subst true,address,$(my_global_sanitize))
Dan Albert4c401412015-08-19 20:13:33 -070016 endif
Dan Willemsenf0638392018-09-04 22:25:22 -070017else
18 my_global_sanitize := $(strip $(SANITIZE_TARGET))
19 my_global_sanitize_diag := $(strip $(SANITIZE_TARGET_DIAG))
Dan Albert4c401412015-08-19 20:13:33 -070020endif
21
Ivan Lozanob4749cb2017-07-21 10:33:32 -070022# Disable global integer_overflow in excluded paths.
23ifneq ($(filter integer_overflow, $(my_global_sanitize)),)
24 combined_exclude_paths := $(INTEGER_OVERFLOW_EXCLUDE_PATHS) \
25 $(PRODUCT_INTEGER_OVERFLOW_EXCLUDE_PATHS)
26
27 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
28 $(filter $(dir)%,$(LOCAL_PATH)))),)
29 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
30 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
31 endif
32endif
33
Ivan Lozano702e8bd2018-03-15 14:49:20 -070034# Global integer sanitization doesn't support static modules.
35ifeq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
36 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
37 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
38endif
39ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
40 my_global_sanitize := $(filter-out integer_overflow,$(my_global_sanitize))
41 my_global_sanitize_diag := $(filter-out integer_overflow,$(my_global_sanitize_diag))
42endif
43
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -070044# Disable global CFI in excluded paths
45ifneq ($(filter cfi, $(my_global_sanitize)),)
46 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
47 $(PRODUCT_CFI_EXCLUDE_PATHS)
48
49 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
50 $(filter $(dir)%,$(LOCAL_PATH)))),)
51 my_global_sanitize := $(filter-out cfi,$(my_global_sanitize))
52 my_global_sanitize_diag := $(filter-out cfi,$(my_global_sanitize_diag))
53 endif
54endif
55
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -080056# Disable global memtag_heap in excluded paths
57ifneq ($(filter memtag_heap, $(my_global_sanitize)),)
58 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
59 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
60
61 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
62 $(filter $(dir)%,$(LOCAL_PATH)))),)
63 my_global_sanitize := $(filter-out memtag_heap,$(my_global_sanitize))
64 my_global_sanitize_diag := $(filter-out memtag_heap,$(my_global_sanitize_diag))
65 endif
66endif
67
Dan Albert4c401412015-08-19 20:13:33 -070068ifneq ($(my_global_sanitize),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -070069 my_sanitize := $(my_global_sanitize) $(my_sanitize)
Dan Albert4c401412015-08-19 20:13:33 -070070endif
Ivan Lozano4a363732017-06-28 09:11:26 -070071ifneq ($(my_global_sanitize_diag),)
72 my_sanitize_diag := $(my_global_sanitize_diag) $(my_sanitize_diag)
73endif
Dan Albert4c401412015-08-19 20:13:33 -070074
Andreas Gampe6b30d772016-06-27 15:15:31 -070075# The sanitizer specified in the product configuration wins over the previous.
76ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)
77 my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)
78 ifeq ($(my_sanitize),never)
79 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070080 my_sanitize_diag :=
Andreas Gampe6b30d772016-06-27 15:15:31 -070081 endif
82endif
83
Colin Cross23618422016-11-02 15:05:21 -070084ifndef LOCAL_IS_HOST_MODULE
85 # Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden)
86 SANITIZE_TARGET_ARCH ?= $(TARGET_ARCH) $(TARGET_2ND_ARCH)
87 ifeq ($(filter $(SANITIZE_TARGET_ARCH),$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
88 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -070089 my_sanitize_diag :=
Colin Cross23618422016-11-02 15:05:21 -070090 endif
Andreas Gampecd257402016-06-20 17:36:49 -070091endif
92
Andreas Gampe3d3b0c92016-06-20 17:46:29 -070093# Add a filter point based on module owner (to lighten the burden). The format is a space- or
94# colon-separated list of owner names.
95ifneq (,$(SANITIZE_NEVER_BY_OWNER))
96 ifneq (,$(LOCAL_MODULE_OWNER))
97 ifneq (,$(filter $(LOCAL_MODULE_OWNER),$(subst :, ,$(SANITIZE_NEVER_BY_OWNER))))
98 $(warning Not sanitizing $(LOCAL_MODULE) based on module owner.)
99 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700100 my_sanitize_diag :=
Andreas Gampe3d3b0c92016-06-20 17:46:29 -0700101 endif
102 endif
103endif
104
Dan Albert08cca282014-12-11 18:56:26 -0800105# Don't apply sanitizers to NDK code.
106ifdef LOCAL_SDK_VERSION
Dan Albert4c401412015-08-19 20:13:33 -0700107 my_sanitize :=
Dan Willemsenf761c0f2016-06-28 16:47:43 -0700108 my_global_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700109 my_sanitize_diag :=
Dan Albert27ccb752015-04-16 16:21:02 -0700110endif
111
Dan Albert4c401412015-08-19 20:13:33 -0700112# Never always wins.
113ifeq ($(LOCAL_SANITIZE),never)
Dan Albert08cca282014-12-11 18:56:26 -0800114 my_sanitize :=
Ivan Lozano4a363732017-06-28 09:11:26 -0700115 my_sanitize_diag :=
Dan Albert08cca282014-12-11 18:56:26 -0800116endif
117
Elvis Chien064d91c2021-04-14 17:02:29 +0800118# Enable CFI in included paths.
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700119ifeq ($(filter cfi, $(my_sanitize)),)
Elvis Chien064d91c2021-04-14 17:02:29 +0800120 combined_include_paths := $(CFI_INCLUDE_PATHS) \
121 $(PRODUCT_CFI_INCLUDE_PATHS)
122 combined_exclude_paths := $(CFI_EXCLUDE_PATHS) \
123 $(PRODUCT_CFI_EXCLUDE_PATHS)
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700124
Elvis Chien064d91c2021-04-14 17:02:29 +0800125 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_include_paths)),\
126 $(filter $(dir)%,$(LOCAL_PATH)))),)
127 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
128 $(filter $(dir)%,$(LOCAL_PATH)))),)
129 my_sanitize := cfi $(my_sanitize)
Vishwath Mohan6106a4e2018-05-24 18:04:25 -0700130 endif
Vishwath Mohan23b2d2e2017-10-31 02:25:16 -0700131 endif
132endif
133
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800134# Enable memtag_heap in included paths (for Arm64 only).
135ifeq ($(filter memtag_heap, $(my_sanitize)),)
136 ifneq ($(filter arm64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
137 combined_sync_include_paths := $(MEMTAG_HEAP_SYNC_INCLUDE_PATHS) \
138 $(PRODUCT_MEMTAG_HEAP_SYNC_INCLUDE_PATHS)
139 combined_async_include_paths := $(MEMTAG_HEAP_ASYNC_INCLUDE_PATHS) \
140 $(PRODUCT_MEMTAG_HEAP_ASYNC_INCLUDE_PATHS)
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700141 combined_exclude_paths := $(MEMTAG_HEAP_EXCLUDE_PATHS) \
142 $(PRODUCT_MEMTAG_HEAP_EXCLUDE_PATHS)
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800143
Evgenii Stepanov13bc2272021-04-09 14:52:33 -0700144 ifeq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_exclude_paths)),\
145 $(filter $(dir)%,$(LOCAL_PATH)))),)
146 ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_sync_include_paths)),\
147 $(filter $(dir)%,$(LOCAL_PATH)))),)
148 my_sanitize := memtag_heap $(my_sanitize)
149 my_sanitize_diag := memtag_heap $(my_sanitize_diag)
150 else ifneq ($(strip $(foreach dir,$(subst $(comma),$(space),$(combined_async_include_paths)),\
151 $(filter $(dir)%,$(LOCAL_PATH)))),)
152 my_sanitize := memtag_heap $(my_sanitize)
153 endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800154 endif
155 endif
156endif
157
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800158# If CFI is disabled globally, remove it from my_sanitize.
Vishwath Mohan45665b42017-01-24 13:20:28 -0800159ifeq ($(strip $(ENABLE_CFI)),false)
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800160 my_sanitize := $(filter-out cfi,$(my_sanitize))
161 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
162endif
163
Vishwath Mohanc026f6d2017-04-20 07:39:13 -0700164# Also disable CFI if ASAN is enabled.
165ifneq ($(filter address,$(my_sanitize)),)
166 my_sanitize := $(filter-out cfi,$(my_sanitize))
167 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
168endif
169
Mitch Phillipsb71a8752021-05-19 11:29:02 -0700170# Disable memtag for host targets. Host executables in AndroidMk files are
171# deprecated, but some partners still have them floating around.
172ifdef LOCAL_IS_HOST_MODULE
173 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
174 my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
175endif
176
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700177# Disable sanitizers which need the UBSan runtime for host targets.
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800178ifdef LOCAL_IS_HOST_MODULE
179 my_sanitize := $(filter-out cfi,$(my_sanitize))
180 my_sanitize_diag := $(filter-out cfi,$(my_sanitize_diag))
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700181 my_sanitize := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize))
182 my_sanitize_diag := $(filter-out signed-integer-overflow unsigned-integer-overflow integer_overflow,$(my_sanitize_diag))
Vishwath Mohan96a130b2017-11-17 11:19:36 -0800183endif
184
Ivan Lozano4a363732017-06-28 09:11:26 -0700185# Support for local sanitize blacklist paths.
186ifneq ($(my_sanitize)$(my_global_sanitize),)
Pirama Arumuga Nainar56558332020-07-30 15:18:07 -0700187 ifneq ($(LOCAL_SANITIZE_BLOCKLIST),)
188 my_cflags += -fsanitize-blacklist=$(LOCAL_PATH)/$(LOCAL_SANITIZE_BLOCKLIST)
189 endif
Ivan Lozano4a363732017-06-28 09:11:26 -0700190endif
191
Ivan Lozanob4749cb2017-07-21 10:33:32 -0700192# Disable integer_overflow if LOCAL_NOSANITIZE=integer.
Ivan Lozano4a363732017-06-28 09:11:26 -0700193ifneq ($(filter integer_overflow, $(my_global_sanitize) $(my_sanitize)),)
194 ifneq ($(filter integer, $(strip $(LOCAL_NOSANITIZE))),)
195 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
196 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
197 endif
198endif
199
Evgenii Stepanov42823662016-05-12 13:07:17 -0700200my_nosanitize = $(strip $(LOCAL_NOSANITIZE))
201ifneq ($(my_nosanitize),)
202 my_sanitize := $(filter-out $(my_nosanitize),$(my_sanitize))
203endif
204
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700205ifneq ($(filter arm x86 x86_64,$(TARGET_$(LOCAL_2ND_ARCH_VAR_PREFIX)ARCH)),)
206 my_sanitize := $(filter-out hwaddress,$(my_sanitize))
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800207 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700208endif
209
210ifneq ($(filter hwaddress,$(my_sanitize)),)
211 my_sanitize := $(filter-out address,$(my_sanitize))
212 my_sanitize := $(filter-out thread,$(my_sanitize))
Evgenii Stepanov88a95a32018-12-04 17:06:45 -0800213 my_sanitize := $(filter-out cfi,$(my_sanitize))
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700214endif
215
216ifneq ($(filter hwaddress,$(my_sanitize)),)
217 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_RUNTIME_LIBRARY)
Evgenii Stepanoved907462018-11-01 15:43:14 -0700218 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700219 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ryan Prichardacf8b0f2019-10-21 20:47:53 -0700220 my_static_libraries := $(my_static_libraries) \
221 $($(LOCAL_2ND_ARCH_VAR_PREFIX)HWADDRESS_SANITIZER_STATIC_LIBRARY) \
222 libdl
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700223 endif
224 endif
225endif
226
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800227ifneq ($(filter memtag_heap,$(my_sanitize)),)
228 # Add memtag ELF note.
Peter Collingbourne8b80f3e2021-04-12 11:46:17 -0700229 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
230 ifneq ($(filter memtag_heap,$(my_sanitize_diag)),)
231 my_whole_static_libraries += note_memtag_heap_sync
232 else
233 my_whole_static_libraries += note_memtag_heap_async
234 endif
Evgenii Stepanov3330b2f2021-01-13 12:14:55 -0800235 endif
236 # This is all that memtag_heap does - it is not an actual -fsanitize argument.
237 # Remove it from the list.
238 my_sanitize := $(filter-out memtag_heap,$(my_sanitize))
239endif
240
241my_sanitize_diag := $(filter-out memtag_heap,$(my_sanitize_diag))
242
Dan Alberta6311b72015-07-30 10:17:33 -0700243# TSAN is not supported on 32-bit architectures. For non-multilib cases, make
244# its use an error. For multilib cases, don't use it for the 32-bit case.
245ifneq ($(filter thread,$(my_sanitize)),)
246 ifeq ($(my_32_64_bit_suffix),32)
247 ifeq ($(my_module_multilib),both)
248 my_sanitize := $(filter-out thread,$(my_sanitize))
249 else
250 $(error $(LOCAL_PATH): $(LOCAL_MODULE): TSAN cannot be used for 32-bit modules.)
251 endif
Yabin Cuie77c32e2017-10-19 14:33:58 -0700252 else
253 my_shared_libraries += $(TSAN_RUNTIME_LIBRARY)
Dan Alberta6311b72015-07-30 10:17:33 -0700254 endif
255endif
256
Evgenii Stepanov7dcb8b82016-05-06 18:15:57 -0700257ifneq ($(filter safe-stack,$(my_sanitize)),)
258 ifeq ($(my_32_64_bit_suffix),32)
259 my_sanitize := $(filter-out safe-stack,$(my_sanitize))
260 endif
261endif
262
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700263# Disable Scudo if ASan or TSan is enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700264ifneq ($(filter address thread hwaddress,$(my_sanitize)),)
Kostya Kortchinsky2cfa9972018-06-14 11:02:15 -0700265 my_sanitize := $(filter-out scudo,$(my_sanitize))
266endif
267
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800268# Or if disabled globally.
Anton Hansson8dab0a62019-03-28 15:45:40 +0000269ifeq ($(PRODUCT_DISABLE_SCUDO),true)
Kostya Kortchinsky02732402019-02-01 09:06:42 -0800270 my_sanitize := $(filter-out scudo,$(my_sanitize))
271endif
272
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700273# Undefined symbols can occur if a non-sanitized library links
274# sanitized static libraries. That's OK, because the executable
275# always depends on the ASan runtime library, which defines these
276# symbols.
Evgenii Stepanov912b51f2016-05-19 17:49:51 -0700277ifneq ($(filter address thread,$(strip $(SANITIZE_TARGET))),)
Evgenii Stepanov5adfcb12015-06-25 16:38:25 -0700278 ifndef LOCAL_IS_HOST_MODULE
279 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
280 ifeq ($(my_sanitize),)
281 my_allow_undefined_symbols := true
282 endif
283 endif
284 endif
285endif
286
Dan Albertb5b2ffe2015-04-16 18:07:07 -0700287ifneq ($(filter default-ub,$(my_sanitize)),)
288 my_sanitize := $(CLANG_DEFAULT_UB_CHECKS)
Dan Albert08cca282014-12-11 18:56:26 -0800289endif
290
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700291ifneq ($(filter fuzzer,$(my_sanitize)),)
292 # SANITIZE_TARGET='fuzzer' actually means to create the fuzzer coverage
293 # information, not to link against the fuzzer main().
294 my_sanitize := $(filter-out fuzzer,$(my_sanitize))
295 my_sanitize += fuzzer-no-link
296
297 # TODO(b/131771163): Disable LTO for fuzzer builds. Note that Cfi causes
298 # dependency on LTO.
299 my_sanitize := $(filter-out cfi,$(my_sanitize))
300 my_cflags += -fno-lto
301 my_ldflags += -fno-lto
Ivan Krasin74b32b82015-09-18 11:54:43 -0700302endif
303
Ivan Lozano4a363732017-06-28 09:11:26 -0700304ifneq ($(filter integer_overflow,$(my_sanitize)),)
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700305 # Respect LOCAL_NOSANITIZE for integer-overflow flags.
306 ifeq ($(filter signed-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
307 my_sanitize += signed-integer-overflow
308 endif
309 ifeq ($(filter unsigned-integer-overflow, $(strip $(LOCAL_NOSANITIZE))),)
310 my_sanitize += unsigned-integer-overflow
311 endif
312 my_cflags += $(INTEGER_OVERFLOW_EXTRA_CFLAGS)
Ivan Lozano4a363732017-06-28 09:11:26 -0700313
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700314 # Check for diagnostics mode.
315 ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
316 ifneq ($(filter SHARED_LIBRARIES EXECUTABLES,$(LOCAL_MODULE_CLASS)),)
317 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
Ivan Lozano911cb992018-02-21 13:41:05 -0800318 my_sanitize_diag += signed-integer-overflow
319 my_sanitize_diag += unsigned-integer-overflow
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700320 else
321 $(call pretty-error,Make cannot apply integer overflow diagnostics to static binary.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700322 endif
Ivan Lozano702e8bd2018-03-15 14:49:20 -0700323 else
324 $(call pretty-error,Make cannot apply integer overflow diagnostics to static library.)
Ivan Lozano4a363732017-06-28 09:11:26 -0700325 endif
326 endif
327 my_sanitize := $(filter-out integer_overflow,$(my_sanitize))
328endif
329
330# Makes sure integer_overflow diagnostics is removed from the diagnostics list
331# even if integer_overflow is not set for some reason.
332ifneq ($(filter integer_overflow,$(my_sanitize_diag)),)
333 my_sanitize_diag := $(filter-out integer_overflow,$(my_sanitize_diag))
334endif
335
Dan Albert08cca282014-12-11 18:56:26 -0800336ifneq ($(my_sanitize),)
Stephen Hinese8119e92015-11-09 16:32:11 -0800337 fsanitize_arg := $(subst $(space),$(comma),$(my_sanitize))
Dan Albert08cca282014-12-11 18:56:26 -0800338 my_cflags += -fsanitize=$(fsanitize_arg)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700339 my_asflags += -fsanitize=$(fsanitize_arg)
Dan Albert08cca282014-12-11 18:56:26 -0800340
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700341 # When fuzzing, we wish to crash with diagnostics on any bug.
342 ifneq ($(filter fuzzer-no-link,$(my_sanitize)),)
343 my_cflags += -fno-sanitize-trap=all
344 my_cflags += -fno-sanitize-recover=all
345 my_ldflags += -fsanitize=fuzzer-no-link
346 else ifdef LOCAL_IS_HOST_MODULE
Dan Albertabf4bc92015-06-16 23:27:34 -0700347 my_cflags += -fno-sanitize-recover=all
Dan Albert08cca282014-12-11 18:56:26 -0800348 my_ldflags += -fsanitize=$(fsanitize_arg)
Dan Albertabf4bc92015-06-16 23:27:34 -0700349 else
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700350 my_cflags += -fsanitize-trap=all
351 my_cflags += -ftrap-function=abort
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700352 ifneq ($(filter address thread,$(my_sanitize)),)
Evgenii Stepanov71faa192016-05-19 17:45:21 -0700353 my_cflags += -fno-sanitize-trap=address,thread
Evgenii Stepanov55f73e62016-05-12 13:07:36 -0700354 my_shared_libraries += libdl
355 endif
Dan Albert08cca282014-12-11 18:56:26 -0800356 endif
357endif
358
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700359ifneq ($(filter cfi,$(my_sanitize)),)
Evgenii Stepanov81bea1b2017-01-20 14:12:08 -0800360 # __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp).
361 # LLVM is not set up to do this on a function basis, so force Thumb on the
362 # entire module.
363 LOCAL_ARM_MODE := thumb
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800364 my_cflags += $(CFI_EXTRA_CFLAGS)
Evgenii Stepanov9b82b3f2018-08-31 12:57:26 -0700365 my_asflags += $(CFI_EXTRA_ASFLAGS)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000366 # Only append the default visibility flag if -fvisibility has not already been
367 # set to hidden.
368 ifeq ($(filter -fvisibility=hidden,$(LOCAL_CFLAGS)),)
369 my_cflags += -fvisibility=default
370 endif
Vishwath Mohan5b69c062017-02-14 07:55:37 -0800371 my_ldflags += $(CFI_EXTRA_LDFLAGS)
Evgenii Stepanove1b96f32017-01-23 16:57:38 -0800372 my_arflags += --plugin $(LLVM_PREBUILTS_PATH)/../lib64/LLVMgold.so
Vishwath Mohan85f72442017-11-01 09:21:20 +0000373
374 ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
375 my_ldflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_ldflags))
376 my_cflags := $(filter-out -fsanitize-cfi-cross-dso,$(my_cflags))
377 else
378 # Apply the version script to non-static executables
379 my_ldflags += -Wl,--version-script,build/soong/cc/config/cfi_exports.map
380 LOCAL_ADDITIONAL_DEPENDENCIES += build/soong/cc/config/cfi_exports.map
381 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700382endif
383
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800384# If local or global modules need ASAN, add linker flags.
385ifneq ($(filter address,$(my_global_sanitize) $(my_sanitize)),)
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700386 my_ldflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_LDFLAGS)
387 ifdef LOCAL_IS_HOST_MODULE
Dan Albert08cca282014-12-11 18:56:26 -0800388 # -nodefaultlibs (provided with libc++) prevents the driver from linking
389 # libraries needed with -fsanitize=address. http://b/18650275 (WAI)
Dan Albert1f0d5302015-04-28 14:55:50 -0700390 my_ldflags += -Wl,--no-as-needed
Dan Albert4ae5d4b2014-10-31 16:23:08 -0700391 else
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800392 # Add asan libraries unless LOCAL_MODULE is the asan library.
Evgenii Stepanovf0b15e12015-04-24 16:34:47 -0700393 # ASan runtime library must be the first in the link order.
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800394 ifeq (,$(filter $(LOCAL_MODULE),$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY)))
395 my_shared_libraries := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_RUNTIME_LIBRARY) \
396 $(my_shared_libraries)
397 endif
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800398
399 # Do not add unnecessary dependency in shared libraries.
400 ifeq ($(LOCAL_MODULE_CLASS),SHARED_LIBRARIES)
401 my_ldflags += -Wl,--as-needed
402 endif
Ying Wanga05e2222015-08-17 16:13:24 -0700403
Mikhail Naganovaa73cef2018-12-20 15:55:08 -0800404 ifneq ($(filter EXECUTABLES NATIVE_TESTS,$(LOCAL_MODULE_CLASS)),)
Colin Crossd08699e2016-07-17 15:28:07 -0700405 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
406 my_linker := $($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER)
407 # Make sure linker_asan get installed.
Logan Chienc6d2cf82019-01-31 17:07:50 +0800408 $(LOCAL_INSTALLED_MODULE) : | $(PRODUCT_OUT)$($(LOCAL_2ND_ARCH_VAR_PREFIX)ADDRESS_SANITIZER_LINKER_FILE)
Colin Crossd08699e2016-07-17 15:28:07 -0700409 endif
410 endif
Dan Albert08cca282014-12-11 18:56:26 -0800411 endif
412endif
413
Chih-Hung Hsiehad741e62016-03-09 14:54:55 -0800414# If local module needs ASAN, add compiler flags.
415ifneq ($(filter address,$(my_sanitize)),)
416 # Frame pointer based unwinder in ASan requires ARM frame setup.
417 LOCAL_ARM_MODE := arm
418 my_cflags += $(ADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
419 ifndef LOCAL_IS_HOST_MODULE
420 my_cflags += -mllvm -asan-globals=0
421 endif
422endif
423
Evgenii Stepanovaec1ffc2018-08-28 13:52:08 -0700424# If local module needs HWASAN, add compiler flags.
425ifneq ($(filter hwaddress,$(my_sanitize)),)
426 my_cflags += $(HWADDRESS_SANITIZER_CONFIG_EXTRA_CFLAGS)
427endif
428
Dan Willemsen58634e12020-03-06 18:09:06 -0800429# Use minimal diagnostics when integer overflow is enabled; never do it for HOST modules
430ifeq ($(LOCAL_IS_HOST_MODULE),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800431 # Pre-emptively add UBSAN minimal runtime incase a static library dependency requires it
432 ifeq ($(filter STATIC_LIBRARIES,$(LOCAL_MODULE_CLASS)),)
433 ifndef LOCAL_SDK_VERSION
434 my_static_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY)
Ivan Lozanoe5081692018-05-11 14:09:36 -0700435 my_ldflags += -Wl,--exclude-libs,$($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY).a
Ivan Lozano911cb992018-02-21 13:41:05 -0800436 endif
437 endif
438 ifneq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize)),)
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700439 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize_diag)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800440 ifeq ($(filter cfi,$(my_sanitize_diag)),)
Mitch Phillipsee8f4a02019-05-01 14:37:33 -0700441 ifeq ($(filter address hwaddress fuzzer-no-link,$(my_sanitize)),)
Ivan Lozano911cb992018-02-21 13:41:05 -0800442 my_cflags += -fsanitize-minimal-runtime
443 my_cflags += -fno-sanitize-trap=integer
444 my_cflags += -fno-sanitize-recover=integer
445 endif
446 endif
447 endif
448 endif
449endif
450
Kostya Kortchinsky47c10eb2018-10-11 08:56:12 -0700451# For Scudo, we opt for the minimal runtime, unless some diagnostics are enabled.
452ifneq ($(filter scudo,$(my_sanitize)),)
453 ifeq ($(filter unsigned-integer-overflow signed-integer-overflow integer cfi,$(my_sanitize_diag)),)
454 my_cflags += -fsanitize-minimal-runtime
455 endif
456 ifneq ($(filter -fsanitize-minimal-runtime,$(my_cflags)),)
457 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_MINIMAL_RUNTIME_LIBRARY)
458 else
459 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)SCUDO_RUNTIME_LIBRARY)
460 endif
461endif
462
Dan Albert9f176552015-04-28 11:26:45 -0700463ifneq ($(strip $(LOCAL_SANITIZE_RECOVER)),)
464 recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_RECOVER)),
Dan Albert4111d482015-04-16 18:08:44 -0700465 my_cflags += -fsanitize-recover=$(recover_arg)
466endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700467
Ivan Lozano5fb2de72018-12-12 10:04:34 -0800468ifneq ($(strip $(LOCAL_SANITIZE_NO_RECOVER)),)
469 no_recover_arg := $(subst $(space),$(comma),$(LOCAL_SANITIZE_NO_RECOVER)),
470 my_cflags += -fno-sanitize-recover=$(no_recover_arg)
471endif
472
Vishwath Mohan8dcfdce2017-01-18 17:50:29 -0800473ifneq ($(my_sanitize_diag),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000474 # TODO(vishwath): Add diagnostic support for static executables once
475 # we switch to clang-4393122 (which adds the static ubsan runtime
476 # that this depends on)
477 ifneq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)
478 notrap_arg := $(subst $(space),$(comma),$(my_sanitize_diag)),
479 my_cflags += -fno-sanitize-trap=$(notrap_arg)
480 # Diagnostic requires a runtime library, unless ASan or TSan are also enabled.
Evgenii Stepanov8841a7f2018-07-27 11:54:32 -0700481 ifeq ($(filter address thread scudo hwaddress,$(my_sanitize)),)
Vishwath Mohan85f72442017-11-01 09:21:20 +0000482 # Does not have to be the first DT_NEEDED unlike ASan.
483 my_shared_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_RUNTIME_LIBRARY)
484 endif
Evgenii Stepanov202c7a72016-07-07 10:56:39 -0700485 endif
486endif
Chih-Hung Hsieh18710622018-11-17 20:18:08 -0800487
488# http://b/119329758, Android core does not boot up with this sanitizer yet.
489# Previously sanitized modules might not pass new implicit-integer-sign-change check.
490# Disable this check unless it has been explicitly specified.
491ifneq ($(findstring fsanitize,$(my_cflags)),)
492 ifneq ($(findstring integer,$(my_cflags)),)
493 ifeq ($(findstring sanitize=implicit-integer-sign-change,$(my_cflags)),)
494 my_cflags += -fno-sanitize=implicit-integer-sign-change
495 endif
496 endif
497endif
Yabin Cui462c12d2021-01-14 14:05:54 -0800498
499# http://b/177566116, libc++ may crash with this sanitizer.
500# Disable this check unless it has been explicitly specified.
501ifneq ($(findstring fsanitize,$(my_cflags)),)
502 ifneq ($(findstring integer,$(my_cflags)),)
503 ifeq ($(findstring sanitize=unsigned-shift-base,$(my_cflags)),)
504 my_cflags += -fno-sanitize=unsigned-shift-base
505 endif
506 endif
507endif