Elliott Hughes | 1aa246d | 2012-12-13 09:29:36 -0800 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2012 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 17 | #include "thread_pool.h" |
| 18 | |
Andreas Gampe | d490129 | 2017-05-30 18:41:34 -0700 | [diff] [blame] | 19 | #include <sys/mman.h> |
Andreas Gampe | 9e927f5 | 2016-02-29 20:49:38 -0800 | [diff] [blame] | 20 | #include <sys/resource.h> |
Andreas Gampe | 8cf9cb3 | 2017-07-19 09:28:38 -0700 | [diff] [blame] | 21 | #include <sys/time.h> |
| 22 | |
| 23 | #include <pthread.h> |
Andreas Gampe | 9e927f5 | 2016-02-29 20:49:38 -0800 | [diff] [blame] | 24 | |
Andreas Gampe | 46ee31b | 2016-12-14 10:11:49 -0800 | [diff] [blame] | 25 | #include "android-base/stringprintf.h" |
| 26 | |
Vladimir Marko | 0b6e283 | 2015-09-24 10:41:33 +0100 | [diff] [blame] | 27 | #include "base/bit_utils.h" |
Elliott Hughes | 1aa246d | 2012-12-13 09:29:36 -0800 | [diff] [blame] | 28 | #include "base/casts.h" |
Vladimir Marko | 0b6e283 | 2015-09-24 10:41:33 +0100 | [diff] [blame] | 29 | #include "base/logging.h" |
Elliott Hughes | 1aa246d | 2012-12-13 09:29:36 -0800 | [diff] [blame] | 30 | #include "base/stl_util.h" |
Vladimir Marko | 80afd02 | 2015-05-19 18:08:00 +0100 | [diff] [blame] | 31 | #include "base/time_utils.h" |
Elliott Hughes | 1aa246d | 2012-12-13 09:29:36 -0800 | [diff] [blame] | 32 | #include "runtime.h" |
Andreas Gampe | b486a98 | 2017-06-01 13:45:54 -0700 | [diff] [blame] | 33 | #include "thread-current-inl.h" |
Elliott Hughes | 1aa246d | 2012-12-13 09:29:36 -0800 | [diff] [blame] | 34 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 35 | namespace art { |
| 36 | |
Andreas Gampe | 46ee31b | 2016-12-14 10:11:49 -0800 | [diff] [blame] | 37 | using android::base::StringPrintf; |
| 38 | |
Mathieu Chartier | 720ef76 | 2013-08-17 14:46:54 -0700 | [diff] [blame] | 39 | static constexpr bool kMeasureWaitTime = false; |
Mathieu Chartier | 94c32c5 | 2013-08-09 11:14:04 -0700 | [diff] [blame] | 40 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 41 | ThreadPoolWorker::ThreadPoolWorker(ThreadPool* thread_pool, const std::string& name, |
| 42 | size_t stack_size) |
| 43 | : thread_pool_(thread_pool), |
Mathieu Chartier | bcd5e9d | 2013-11-13 14:33:28 -0800 | [diff] [blame] | 44 | name_(name) { |
Vladimir Marko | 0b6e283 | 2015-09-24 10:41:33 +0100 | [diff] [blame] | 45 | // Add an inaccessible page to catch stack overflow. |
| 46 | stack_size += kPageSize; |
Mathieu Chartier | bcd5e9d | 2013-11-13 14:33:28 -0800 | [diff] [blame] | 47 | std::string error_msg; |
| 48 | stack_.reset(MemMap::MapAnonymous(name.c_str(), nullptr, stack_size, PROT_READ | PROT_WRITE, |
Vladimir Marko | 5c42c29 | 2015-02-25 12:02:49 +0000 | [diff] [blame] | 49 | false, false, &error_msg)); |
Mathieu Chartier | bcd5e9d | 2013-11-13 14:33:28 -0800 | [diff] [blame] | 50 | CHECK(stack_.get() != nullptr) << error_msg; |
Vladimir Marko | 0b6e283 | 2015-09-24 10:41:33 +0100 | [diff] [blame] | 51 | CHECK_ALIGNED(stack_->Begin(), kPageSize); |
| 52 | int mprotect_result = mprotect(stack_->Begin(), kPageSize, PROT_NONE); |
| 53 | CHECK_EQ(mprotect_result, 0) << "Failed to mprotect() bottom page of thread pool worker stack."; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 54 | const char* reason = "new thread pool worker thread"; |
Brian Carlstrom | bcc2926 | 2012-11-02 11:36:03 -0700 | [diff] [blame] | 55 | pthread_attr_t attr; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 56 | CHECK_PTHREAD_CALL(pthread_attr_init, (&attr), reason); |
Mathieu Chartier | bcd5e9d | 2013-11-13 14:33:28 -0800 | [diff] [blame] | 57 | CHECK_PTHREAD_CALL(pthread_attr_setstack, (&attr, stack_->Begin(), stack_->Size()), reason); |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 58 | CHECK_PTHREAD_CALL(pthread_create, (&pthread_, &attr, &Callback, this), reason); |
| 59 | CHECK_PTHREAD_CALL(pthread_attr_destroy, (&attr), reason); |
| 60 | } |
| 61 | |
| 62 | ThreadPoolWorker::~ThreadPoolWorker() { |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 63 | CHECK_PTHREAD_CALL(pthread_join, (pthread_, nullptr), "thread pool worker shutdown"); |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 64 | } |
| 65 | |
Andreas Gampe | 9e927f5 | 2016-02-29 20:49:38 -0800 | [diff] [blame] | 66 | void ThreadPoolWorker::SetPthreadPriority(int priority) { |
| 67 | CHECK_GE(priority, PRIO_MIN); |
| 68 | CHECK_LE(priority, PRIO_MAX); |
Bilyan Borisov | bb661c0 | 2016-04-04 16:27:32 +0100 | [diff] [blame] | 69 | #if defined(ART_TARGET_ANDROID) |
Andreas Gampe | 9e927f5 | 2016-02-29 20:49:38 -0800 | [diff] [blame] | 70 | int result = setpriority(PRIO_PROCESS, pthread_gettid_np(pthread_), priority); |
| 71 | if (result != 0) { |
| 72 | PLOG(ERROR) << "Failed to setpriority to :" << priority; |
| 73 | } |
| 74 | #else |
| 75 | UNUSED(priority); |
| 76 | #endif |
| 77 | } |
| 78 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 79 | void ThreadPoolWorker::Run() { |
| 80 | Thread* self = Thread::Current(); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 81 | Task* task = nullptr; |
Mathieu Chartier | 35883cc | 2012-11-13 14:08:12 -0800 | [diff] [blame] | 82 | thread_pool_->creation_barier_.Wait(self); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 83 | while ((task = thread_pool_->GetTask(self)) != nullptr) { |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 84 | task->Run(self); |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 85 | task->Finalize(); |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 86 | } |
| 87 | } |
| 88 | |
| 89 | void* ThreadPoolWorker::Callback(void* arg) { |
| 90 | ThreadPoolWorker* worker = reinterpret_cast<ThreadPoolWorker*>(arg); |
| 91 | Runtime* runtime = Runtime::Current(); |
Andreas Gampe | b15de0c | 2017-01-24 13:12:19 -0800 | [diff] [blame] | 92 | CHECK(runtime->AttachCurrentThread(worker->name_.c_str(), |
| 93 | true, |
| 94 | nullptr, |
| 95 | worker->thread_pool_->create_peers_)); |
Nicolas Geoffray | 340dafa | 2016-11-18 16:03:10 +0000 | [diff] [blame] | 96 | worker->thread_ = Thread::Current(); |
Calin Juravle | ccd5695 | 2016-12-15 17:57:38 +0000 | [diff] [blame] | 97 | // Thread pool workers cannot call into java. |
| 98 | worker->thread_->SetCanCallIntoJava(false); |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 99 | // Do work until its time to shut down. |
| 100 | worker->Run(); |
| 101 | runtime->DetachCurrentThread(); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 102 | return nullptr; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 103 | } |
| 104 | |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 105 | void ThreadPool::AddTask(Thread* self, Task* task) { |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 106 | MutexLock mu(self, task_queue_lock_); |
| 107 | tasks_.push_back(task); |
| 108 | // If we have any waiters, signal one. |
Mathieu Chartier | 94c32c5 | 2013-08-09 11:14:04 -0700 | [diff] [blame] | 109 | if (started_ && waiting_count_ != 0) { |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 110 | task_queue_condition_.Signal(self); |
| 111 | } |
| 112 | } |
| 113 | |
Nicolas Geoffray | 629e935 | 2015-11-04 17:22:16 +0000 | [diff] [blame] | 114 | void ThreadPool::RemoveAllTasks(Thread* self) { |
| 115 | MutexLock mu(self, task_queue_lock_); |
| 116 | tasks_.clear(); |
| 117 | } |
| 118 | |
Andreas Gampe | b15de0c | 2017-01-24 13:12:19 -0800 | [diff] [blame] | 119 | ThreadPool::ThreadPool(const char* name, size_t num_threads, bool create_peers) |
Mathieu Chartier | bcd5e9d | 2013-11-13 14:33:28 -0800 | [diff] [blame] | 120 | : name_(name), |
| 121 | task_queue_lock_("task queue lock"), |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 122 | task_queue_condition_("task queue condition", task_queue_lock_), |
| 123 | completion_condition_("task completion condition", task_queue_lock_), |
| 124 | started_(false), |
| 125 | shutting_down_(false), |
Mathieu Chartier | 35883cc | 2012-11-13 14:08:12 -0800 | [diff] [blame] | 126 | waiting_count_(0), |
Ian Rogers | d914eb2 | 2013-04-18 16:11:15 -0700 | [diff] [blame] | 127 | start_time_(0), |
| 128 | total_wait_time_(0), |
Mathieu Chartier | 35883cc | 2012-11-13 14:08:12 -0800 | [diff] [blame] | 129 | // Add one since the caller of constructor waits on the barrier too. |
Mathieu Chartier | 2775ee4 | 2013-08-20 17:43:47 -0700 | [diff] [blame] | 130 | creation_barier_(num_threads + 1), |
Andreas Gampe | b15de0c | 2017-01-24 13:12:19 -0800 | [diff] [blame] | 131 | max_active_workers_(num_threads), |
| 132 | create_peers_(create_peers) { |
Mathieu Chartier | 35883cc | 2012-11-13 14:08:12 -0800 | [diff] [blame] | 133 | Thread* self = Thread::Current(); |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 134 | while (GetThreadCount() < num_threads) { |
Andreas Gampe | 277ccbd | 2014-11-03 21:36:10 -0800 | [diff] [blame] | 135 | const std::string worker_name = StringPrintf("%s worker thread %zu", name_.c_str(), |
| 136 | GetThreadCount()); |
Vladimir Marko | 0b6e283 | 2015-09-24 10:41:33 +0100 | [diff] [blame] | 137 | threads_.push_back( |
| 138 | new ThreadPoolWorker(this, worker_name, ThreadPoolWorker::kDefaultStackSize)); |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 139 | } |
Mathieu Chartier | 35883cc | 2012-11-13 14:08:12 -0800 | [diff] [blame] | 140 | // Wait for all of the threads to attach. |
| 141 | creation_barier_.Wait(self); |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 142 | } |
| 143 | |
Mathieu Chartier | 2775ee4 | 2013-08-20 17:43:47 -0700 | [diff] [blame] | 144 | void ThreadPool::SetMaxActiveWorkers(size_t threads) { |
| 145 | MutexLock mu(Thread::Current(), task_queue_lock_); |
| 146 | CHECK_LE(threads, GetThreadCount()); |
| 147 | max_active_workers_ = threads; |
| 148 | } |
| 149 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 150 | ThreadPool::~ThreadPool() { |
Mathieu Chartier | e46cd75 | 2012-10-31 16:56:18 -0700 | [diff] [blame] | 151 | { |
| 152 | Thread* self = Thread::Current(); |
| 153 | MutexLock mu(self, task_queue_lock_); |
| 154 | // Tell any remaining workers to shut down. |
| 155 | shutting_down_ = true; |
Mathieu Chartier | e46cd75 | 2012-10-31 16:56:18 -0700 | [diff] [blame] | 156 | // Broadcast to everyone waiting. |
| 157 | task_queue_condition_.Broadcast(self); |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 158 | completion_condition_.Broadcast(self); |
Mathieu Chartier | e46cd75 | 2012-10-31 16:56:18 -0700 | [diff] [blame] | 159 | } |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 160 | // Wait for the threads to finish. |
| 161 | STLDeleteElements(&threads_); |
| 162 | } |
| 163 | |
| 164 | void ThreadPool::StartWorkers(Thread* self) { |
| 165 | MutexLock mu(self, task_queue_lock_); |
| 166 | started_ = true; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 167 | task_queue_condition_.Broadcast(self); |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 168 | start_time_ = NanoTime(); |
| 169 | total_wait_time_ = 0; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 170 | } |
| 171 | |
| 172 | void ThreadPool::StopWorkers(Thread* self) { |
| 173 | MutexLock mu(self, task_queue_lock_); |
| 174 | started_ = false; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 175 | } |
| 176 | |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 177 | Task* ThreadPool::GetTask(Thread* self) { |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 178 | MutexLock mu(self, task_queue_lock_); |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 179 | while (!IsShuttingDown()) { |
Mathieu Chartier | 2775ee4 | 2013-08-20 17:43:47 -0700 | [diff] [blame] | 180 | const size_t thread_count = GetThreadCount(); |
| 181 | // Ensure that we don't use more threads than the maximum active workers. |
| 182 | const size_t active_threads = thread_count - waiting_count_; |
| 183 | // <= since self is considered an active worker. |
| 184 | if (active_threads <= max_active_workers_) { |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 185 | Task* task = TryGetTaskLocked(); |
| 186 | if (task != nullptr) { |
Mathieu Chartier | 2775ee4 | 2013-08-20 17:43:47 -0700 | [diff] [blame] | 187 | return task; |
| 188 | } |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 189 | } |
| 190 | |
Mathieu Chartier | 2775ee4 | 2013-08-20 17:43:47 -0700 | [diff] [blame] | 191 | ++waiting_count_; |
Andreas Gampe | 6f3a70f | 2016-11-16 13:58:05 -0800 | [diff] [blame] | 192 | if (waiting_count_ == GetThreadCount() && !HasOutstandingTasks()) { |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 193 | // We may be done, lets broadcast to the completion condition. |
| 194 | completion_condition_.Broadcast(self); |
| 195 | } |
Mathieu Chartier | 94c32c5 | 2013-08-09 11:14:04 -0700 | [diff] [blame] | 196 | const uint64_t wait_start = kMeasureWaitTime ? NanoTime() : 0; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 197 | task_queue_condition_.Wait(self); |
Mathieu Chartier | 94c32c5 | 2013-08-09 11:14:04 -0700 | [diff] [blame] | 198 | if (kMeasureWaitTime) { |
| 199 | const uint64_t wait_end = NanoTime(); |
| 200 | total_wait_time_ += wait_end - std::max(wait_start, start_time_); |
| 201 | } |
| 202 | --waiting_count_; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 203 | } |
| 204 | |
Mathieu Chartier | 2cebb24 | 2015-04-21 16:50:40 -0700 | [diff] [blame] | 205 | // We are shutting down, return null to tell the worker thread to stop looping. |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 206 | return nullptr; |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 207 | } |
| 208 | |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 209 | Task* ThreadPool::TryGetTask(Thread* self) { |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 210 | MutexLock mu(self, task_queue_lock_); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 211 | return TryGetTaskLocked(); |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 212 | } |
| 213 | |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 214 | Task* ThreadPool::TryGetTaskLocked() { |
Andreas Gampe | 6f3a70f | 2016-11-16 13:58:05 -0800 | [diff] [blame] | 215 | if (HasOutstandingTasks()) { |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 216 | Task* task = tasks_.front(); |
| 217 | tasks_.pop_front(); |
| 218 | return task; |
| 219 | } |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 220 | return nullptr; |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 221 | } |
| 222 | |
Ian Rogers | 1d54e73 | 2013-05-02 21:10:01 -0700 | [diff] [blame] | 223 | void ThreadPool::Wait(Thread* self, bool do_work, bool may_hold_locks) { |
| 224 | if (do_work) { |
Andreas Gampe | b15de0c | 2017-01-24 13:12:19 -0800 | [diff] [blame] | 225 | CHECK(!create_peers_); |
Ian Rogers | 6a3c1fc | 2014-10-31 00:33:20 -0700 | [diff] [blame] | 226 | Task* task = nullptr; |
| 227 | while ((task = TryGetTask(self)) != nullptr) { |
Ian Rogers | 1d54e73 | 2013-05-02 21:10:01 -0700 | [diff] [blame] | 228 | task->Run(self); |
| 229 | task->Finalize(); |
| 230 | } |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 231 | } |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 232 | // Wait until each thread is waiting and the task list is empty. |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 233 | MutexLock mu(self, task_queue_lock_); |
Andreas Gampe | 6f3a70f | 2016-11-16 13:58:05 -0800 | [diff] [blame] | 234 | while (!shutting_down_ && (waiting_count_ != GetThreadCount() || HasOutstandingTasks())) { |
Ian Rogers | 1d54e73 | 2013-05-02 21:10:01 -0700 | [diff] [blame] | 235 | if (!may_hold_locks) { |
| 236 | completion_condition_.Wait(self); |
| 237 | } else { |
| 238 | completion_condition_.WaitHoldingLocks(self); |
| 239 | } |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 240 | } |
| 241 | } |
| 242 | |
Brian Carlstrom | 2ce745c | 2013-07-17 17:44:30 -0700 | [diff] [blame] | 243 | size_t ThreadPool::GetTaskCount(Thread* self) { |
Mathieu Chartier | 02b6a78 | 2012-10-26 13:51:26 -0700 | [diff] [blame] | 244 | MutexLock mu(self, task_queue_lock_); |
| 245 | return tasks_.size(); |
| 246 | } |
| 247 | |
Andreas Gampe | 9e927f5 | 2016-02-29 20:49:38 -0800 | [diff] [blame] | 248 | void ThreadPool::SetPthreadPriority(int priority) { |
| 249 | for (ThreadPoolWorker* worker : threads_) { |
| 250 | worker->SetPthreadPriority(priority); |
| 251 | } |
| 252 | } |
| 253 | |
Mathieu Chartier | 0e4627e | 2012-10-23 16:13:36 -0700 | [diff] [blame] | 254 | } // namespace art |