blob: bbdac262c421ed097e4db1312aab6bafba3fb516 [file] [log] [blame]
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001/*
2 * Copyright (C) 2014 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
17#include "inliner.h"
18
Mathieu Chartiere401d142015-04-22 13:56:20 -070019#include "art_method-inl.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000020#include "builder.h"
21#include "class_linker.h"
22#include "constant_folding.h"
23#include "dead_code_elimination.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000024#include "dex/verified_method.h"
25#include "dex/verification_results.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000026#include "driver/compiler_driver-inl.h"
Calin Juravleec748352015-07-29 13:52:12 +010027#include "driver/compiler_options.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000028#include "driver/dex_compilation_unit.h"
29#include "instruction_simplifier.h"
Scott Wakelingd60a1af2015-07-22 14:32:44 +010030#include "intrinsics.h"
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +000031#include "jit/jit.h"
32#include "jit/jit_code_cache.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000033#include "mirror/class_loader.h"
34#include "mirror/dex_cache.h"
35#include "nodes.h"
Nicolas Geoffray335005e2015-06-25 10:01:47 +010036#include "optimizing_compiler.h"
Nicolas Geoffray454a4812015-06-09 10:37:32 +010037#include "reference_type_propagation.h"
Nicolas Geoffray259136f2014-12-17 23:21:58 +000038#include "register_allocator.h"
Vladimir Markobe10e8e2016-01-22 12:09:44 +000039#include "quick/inline_method_analyser.h"
Vladimir Markodc151b22015-10-15 18:02:30 +010040#include "sharpening.h"
David Brazdil4833f5a2015-12-16 10:37:39 +000041#include "ssa_builder.h"
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000042#include "ssa_phi_elimination.h"
43#include "scoped_thread_state_change.h"
44#include "thread.h"
45
46namespace art {
47
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000048static constexpr size_t kMaximumNumberOfHInstructions = 32;
49
50// Limit the number of dex registers that we accumulate while inlining
51// to avoid creating large amount of nested environments.
52static constexpr size_t kMaximumNumberOfCumulatedDexRegisters = 64;
53
54// Avoid inlining within a huge method due to memory pressure.
55static constexpr size_t kMaximumCodeUnitSize = 4096;
Nicolas Geoffraye418dda2015-08-11 20:03:09 -070056
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000057void HInliner::Run() {
Calin Juravle8f96df82015-07-29 15:58:48 +010058 const CompilerOptions& compiler_options = compiler_driver_->GetCompilerOptions();
59 if ((compiler_options.GetInlineDepthLimit() == 0)
60 || (compiler_options.GetInlineMaxCodeUnits() == 0)) {
61 return;
62 }
Nicolas Geoffray5949fa02015-12-18 10:57:10 +000063 if (caller_compilation_unit_.GetCodeItem()->insns_size_in_code_units_ > kMaximumCodeUnitSize) {
64 return;
65 }
Nicolas Geoffraye50b8d22015-03-13 08:57:42 +000066 if (graph_->IsDebuggable()) {
67 // For simplicity, we currently never inline when the graph is debuggable. This avoids
68 // doing some logic in the runtime to discover if a method could have been inlined.
69 return;
70 }
Vladimir Markofa6b93c2015-09-15 10:15:55 +010071 const ArenaVector<HBasicBlock*>& blocks = graph_->GetReversePostOrder();
72 DCHECK(!blocks.empty());
73 HBasicBlock* next_block = blocks[0];
74 for (size_t i = 0; i < blocks.size(); ++i) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010075 // Because we are changing the graph when inlining, we need to remember the next block.
76 // This avoids doing the inlining work again on the inlined blocks.
Vladimir Markofa6b93c2015-09-15 10:15:55 +010077 if (blocks[i] != next_block) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +010078 continue;
79 }
80 HBasicBlock* block = next_block;
Vladimir Markofa6b93c2015-09-15 10:15:55 +010081 next_block = (i == blocks.size() - 1) ? nullptr : blocks[i + 1];
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000082 for (HInstruction* instruction = block->GetFirstInstruction(); instruction != nullptr;) {
83 HInstruction* next = instruction->GetNext();
Nicolas Geoffray454a4812015-06-09 10:37:32 +010084 HInvoke* call = instruction->AsInvoke();
Razvan A Lupusoru3e90a962015-03-27 13:44:44 -070085 // As long as the call is not intrinsified, it is worth trying to inline.
86 if (call != nullptr && call->GetIntrinsic() == Intrinsics::kNone) {
Nicolas Geoffray79041292015-03-26 10:05:54 +000087 // We use the original invoke type to ensure the resolution of the called method
88 // works properly.
Vladimir Marko58155012015-08-19 12:49:41 +000089 if (!TryInline(call)) {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010090 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000091 std::string callee_name =
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +000092 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
Nicolas Geoffraye53798a2014-12-01 10:31:54 +000093 bool should_inline = callee_name.find("$inline$") != std::string::npos;
94 CHECK(!should_inline) << "Could not inline " << callee_name;
95 }
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010096 } else {
Nicolas Geoffray335005e2015-06-25 10:01:47 +010097 if (kIsDebugBuild && IsCompilingWithCoreImage()) {
Guillaume "Vermeille" Sancheze918d382015-06-03 15:32:41 +010098 std::string callee_name =
99 PrettyMethod(call->GetDexMethodIndex(), *outer_compilation_unit_.GetDexFile());
100 bool must_not_inline = callee_name.find("$noinline$") != std::string::npos;
101 CHECK(!must_not_inline) << "Should not have inlined " << callee_name;
102 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000103 }
104 }
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +0000105 instruction = next;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000106 }
107 }
108}
109
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100110static bool IsMethodOrDeclaringClassFinal(ArtMethod* method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700111 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100112 return method->IsFinal() || method->GetDeclaringClass()->IsFinal();
113}
114
115/**
116 * Given the `resolved_method` looked up in the dex cache, try to find
117 * the actual runtime target of an interface or virtual call.
118 * Return nullptr if the runtime target cannot be proven.
119 */
120static ArtMethod* FindVirtualOrInterfaceTarget(HInvoke* invoke, ArtMethod* resolved_method)
Mathieu Chartier90443472015-07-16 20:32:27 -0700121 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100122 if (IsMethodOrDeclaringClassFinal(resolved_method)) {
123 // No need to lookup further, the resolved method will be the target.
124 return resolved_method;
125 }
126
127 HInstruction* receiver = invoke->InputAt(0);
128 if (receiver->IsNullCheck()) {
129 // Due to multiple levels of inlining within the same pass, it might be that
130 // null check does not have the reference type of the actual receiver.
131 receiver = receiver->InputAt(0);
132 }
133 ReferenceTypeInfo info = receiver->GetReferenceTypeInfo();
Calin Juravle2e768302015-07-28 14:41:11 +0000134 DCHECK(info.IsValid()) << "Invalid RTI for " << receiver->DebugName();
135 if (!info.IsExact()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100136 // We currently only support inlining with known receivers.
137 // TODO: Remove this check, we should be able to inline final methods
138 // on unknown receivers.
139 return nullptr;
140 } else if (info.GetTypeHandle()->IsInterface()) {
141 // Statically knowing that the receiver has an interface type cannot
142 // help us find what is the target method.
143 return nullptr;
144 } else if (!resolved_method->GetDeclaringClass()->IsAssignableFrom(info.GetTypeHandle().Get())) {
145 // The method that we're trying to call is not in the receiver's class or super classes.
146 return nullptr;
147 }
148
149 ClassLinker* cl = Runtime::Current()->GetClassLinker();
150 size_t pointer_size = cl->GetImagePointerSize();
151 if (invoke->IsInvokeInterface()) {
152 resolved_method = info.GetTypeHandle()->FindVirtualMethodForInterface(
153 resolved_method, pointer_size);
154 } else {
155 DCHECK(invoke->IsInvokeVirtual());
156 resolved_method = info.GetTypeHandle()->FindVirtualMethodForVirtual(
157 resolved_method, pointer_size);
158 }
159
160 if (resolved_method == nullptr) {
161 // The information we had on the receiver was not enough to find
162 // the target method. Since we check above the exact type of the receiver,
163 // the only reason this can happen is an IncompatibleClassChangeError.
164 return nullptr;
Alex Light9139e002015-10-09 15:59:48 -0700165 } else if (!resolved_method->IsInvokable()) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100166 // The information we had on the receiver was not enough to find
167 // the target method. Since we check above the exact type of the receiver,
168 // the only reason this can happen is an IncompatibleClassChangeError.
169 return nullptr;
170 } else if (IsMethodOrDeclaringClassFinal(resolved_method)) {
171 // A final method has to be the target method.
172 return resolved_method;
173 } else if (info.IsExact()) {
174 // If we found a method and the receiver's concrete type is statically
175 // known, we know for sure the target.
176 return resolved_method;
177 } else {
178 // Even if we did find a method, the receiver type was not enough to
179 // statically find the runtime target.
180 return nullptr;
181 }
182}
183
184static uint32_t FindMethodIndexIn(ArtMethod* method,
185 const DexFile& dex_file,
186 uint32_t referrer_index)
Mathieu Chartier90443472015-07-16 20:32:27 -0700187 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100188 if (IsSameDexFile(*method->GetDexFile(), dex_file)) {
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100189 return method->GetDexMethodIndex();
190 } else {
191 return method->FindDexMethodIndexInOtherDexFile(dex_file, referrer_index);
192 }
193}
194
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000195static uint32_t FindClassIndexIn(mirror::Class* cls,
196 const DexFile& dex_file,
197 Handle<mirror::DexCache> dex_cache)
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100198 SHARED_REQUIRES(Locks::mutator_lock_) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000199 uint32_t index = DexFile::kDexNoIndex;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100200 if (cls->GetDexCache() == nullptr) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000201 DCHECK(cls->IsArrayClass()) << PrettyClass(cls);
202 index = cls->FindTypeIndexInOtherDexFile(dex_file);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100203 } else if (cls->GetDexTypeIndex() == DexFile::kDexNoIndex16) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000204 DCHECK(cls->IsProxyClass()) << PrettyClass(cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100205 // TODO: deal with proxy classes.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100206 } else if (IsSameDexFile(cls->GetDexFile(), dex_file)) {
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000207 index = cls->GetDexTypeIndex();
208 } else {
209 index = cls->FindTypeIndexInOtherDexFile(dex_file);
210 }
211
212 if (index != DexFile::kDexNoIndex) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100213 // Update the dex cache to ensure the class is in. The generated code will
214 // consider it is. We make it safe by updating the dex cache, as other
215 // dex files might also load the class, and there is no guarantee the dex
216 // cache of the dex file of the class will be updated.
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000217 if (dex_cache->GetResolvedType(index) == nullptr) {
218 dex_cache->SetResolvedType(index, cls);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100219 }
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100220 }
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000221
222 return index;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100223}
224
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000225class ScopedProfilingInfoInlineUse {
226 public:
227 explicit ScopedProfilingInfoInlineUse(ArtMethod* method) : method_(method) {
228 Runtime::Current()->GetJit()->GetCodeCache()->NotifyInliningOf(method_, Thread::Current());
229 }
230
231 ~ScopedProfilingInfoInlineUse() {
232 Runtime::Current()->GetJit()->GetCodeCache()->DoneInlining(method_, Thread::Current());
233 }
234
235 private:
236 ArtMethod* const method_;
237};
238
Nicolas Geoffraye418dda2015-08-11 20:03:09 -0700239bool HInliner::TryInline(HInvoke* invoke_instruction) {
Calin Juravle175dc732015-08-25 15:42:32 +0100240 if (invoke_instruction->IsInvokeUnresolved()) {
241 return false; // Don't bother to move further if we know the method is unresolved.
242 }
243
Vladimir Marko58155012015-08-19 12:49:41 +0000244 uint32_t method_index = invoke_instruction->GetDexMethodIndex();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000245 ScopedObjectAccess soa(Thread::Current());
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000246 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
247 VLOG(compiler) << "Try inlining " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000248
Nicolas Geoffray35071052015-06-09 15:43:38 +0100249 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
250 // We can query the dex cache directly. The verifier has populated it already.
Vladimir Marko58155012015-08-19 12:49:41 +0000251 ArtMethod* resolved_method;
Andreas Gampefd2140f2015-12-23 16:30:44 -0800252 ArtMethod* actual_method = nullptr;
Vladimir Marko58155012015-08-19 12:49:41 +0000253 if (invoke_instruction->IsInvokeStaticOrDirect()) {
Nicolas Geoffraye5234232015-12-02 09:06:11 +0000254 if (invoke_instruction->AsInvokeStaticOrDirect()->IsStringInit()) {
255 VLOG(compiler) << "Not inlining a String.<init> method";
256 return false;
257 }
Vladimir Marko58155012015-08-19 12:49:41 +0000258 MethodReference ref = invoke_instruction->AsInvokeStaticOrDirect()->GetTargetMethod();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700259 mirror::DexCache* const dex_cache = (&caller_dex_file == ref.dex_file)
260 ? caller_compilation_unit_.GetDexCache().Get()
261 : class_linker->FindDexCache(soa.Self(), *ref.dex_file);
262 resolved_method = dex_cache->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000263 ref.dex_method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800264 // actual_method == resolved_method for direct or static calls.
265 actual_method = resolved_method;
Vladimir Marko58155012015-08-19 12:49:41 +0000266 } else {
Mathieu Chartier736b5602015-09-02 14:54:11 -0700267 resolved_method = caller_compilation_unit_.GetDexCache().Get()->GetResolvedMethod(
Vladimir Marko58155012015-08-19 12:49:41 +0000268 method_index, class_linker->GetImagePointerSize());
Andreas Gampefd2140f2015-12-23 16:30:44 -0800269 if (resolved_method != nullptr) {
270 // Check if we can statically find the method.
271 actual_method = FindVirtualOrInterfaceTarget(invoke_instruction, resolved_method);
272 }
Vladimir Marko58155012015-08-19 12:49:41 +0000273 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000274
Mathieu Chartiere401d142015-04-22 13:56:20 -0700275 if (resolved_method == nullptr) {
Calin Juravle175dc732015-08-25 15:42:32 +0100276 // TODO: Can this still happen?
Nicolas Geoffray35071052015-06-09 15:43:38 +0100277 // Method cannot be resolved if it is in another dex file we do not have access to.
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000278 VLOG(compiler) << "Method cannot be resolved " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000279 return false;
280 }
281
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100282 if (actual_method != nullptr) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000283 return TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100284 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000285
Andreas Gampefd2140f2015-12-23 16:30:44 -0800286 DCHECK(!invoke_instruction->IsInvokeStaticOrDirect());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100287
288 // Check if we can use an inline cache.
289 ArtMethod* caller = graph_->GetArtMethod();
290 size_t pointer_size = class_linker->GetImagePointerSize();
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000291 if (Runtime::Current()->UseJit()) {
292 // Under JIT, we should always know the caller.
293 DCHECK(caller != nullptr);
294 ScopedProfilingInfoInlineUse spiis(caller);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100295 ProfilingInfo* profiling_info = caller->GetProfilingInfo(pointer_size);
Nicolas Geoffrayb6e20ae2016-03-07 14:29:04 +0000296 if (profiling_info != nullptr) {
297 const InlineCache& ic = *profiling_info->GetInlineCache(invoke_instruction->GetDexPc());
298 if (ic.IsUnitialized()) {
299 VLOG(compiler) << "Interface or virtual call to "
300 << PrettyMethod(method_index, caller_dex_file)
301 << " is not hit and not inlined";
302 return false;
303 } else if (ic.IsMonomorphic()) {
304 MaybeRecordStat(kMonomorphicCall);
305 return TryInlineMonomorphicCall(invoke_instruction, resolved_method, ic);
306 } else if (ic.IsPolymorphic()) {
307 MaybeRecordStat(kPolymorphicCall);
308 return TryInlinePolymorphicCall(invoke_instruction, resolved_method, ic);
309 } else {
310 DCHECK(ic.IsMegamorphic());
311 VLOG(compiler) << "Interface or virtual call to "
312 << PrettyMethod(method_index, caller_dex_file)
313 << " is megamorphic and not inlined";
314 MaybeRecordStat(kMegamorphicCall);
315 return false;
316 }
Nicolas Geoffray454a4812015-06-09 10:37:32 +0100317 }
318 }
319
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100320 VLOG(compiler) << "Interface or virtual call to "
321 << PrettyMethod(method_index, caller_dex_file)
322 << " could not be statically determined";
323 return false;
324}
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000325
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000326HInstanceFieldGet* HInliner::BuildGetReceiverClass(ClassLinker* class_linker,
327 HInstruction* receiver,
328 uint32_t dex_pc) const {
329 ArtField* field = class_linker->GetClassRoot(ClassLinker::kJavaLangObject)->GetInstanceField(0);
330 DCHECK_EQ(std::string(field->GetName()), "shadow$_klass_");
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000331 HInstanceFieldGet* result = new (graph_->GetArena()) HInstanceFieldGet(
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000332 receiver,
333 Primitive::kPrimNot,
334 field->GetOffset(),
335 field->IsVolatile(),
336 field->GetDexFieldIndex(),
337 field->GetDeclaringClass()->GetDexClassDefIndex(),
338 *field->GetDexFile(),
339 handles_->NewHandle(field->GetDexCache()),
340 dex_pc);
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000341 // The class of a field is effectively final, and does not have any memory dependencies.
342 result->SetSideEffects(SideEffects::None());
343 return result;
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000344}
345
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100346bool HInliner::TryInlineMonomorphicCall(HInvoke* invoke_instruction,
347 ArtMethod* resolved_method,
348 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000349 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
350 << invoke_instruction->DebugName();
351
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100352 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Nicolas Geoffraye4084a52016-02-18 14:43:42 +0000353 uint32_t class_index = FindClassIndexIn(
354 ic.GetMonomorphicType(), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100355 if (class_index == DexFile::kDexNoIndex) {
356 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
357 << " from inline cache is not inlined because its class is not"
358 << " accessible to the caller";
359 return false;
360 }
361
362 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
363 size_t pointer_size = class_linker->GetImagePointerSize();
364 if (invoke_instruction->IsInvokeInterface()) {
365 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForInterface(
366 resolved_method, pointer_size);
367 } else {
368 DCHECK(invoke_instruction->IsInvokeVirtual());
369 resolved_method = ic.GetMonomorphicType()->FindVirtualMethodForVirtual(
370 resolved_method, pointer_size);
371 }
372 DCHECK(resolved_method != nullptr);
373 HInstruction* receiver = invoke_instruction->InputAt(0);
374 HInstruction* cursor = invoke_instruction->GetPrevious();
375 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
376
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000377 if (!TryInlineAndReplace(invoke_instruction, resolved_method, /* do_rtp */ false)) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100378 return false;
379 }
380
381 // We successfully inlined, now add a guard.
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100382 bool is_referrer =
383 (ic.GetMonomorphicType() == outermost_graph_->GetArtMethod()->GetDeclaringClass());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000384 AddTypeGuard(receiver,
385 cursor,
386 bb_cursor,
387 class_index,
388 is_referrer,
389 invoke_instruction,
390 /* with_deoptimization */ true);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100391
392 // Run type propagation to get the guard typed, and eventually propagate the
393 // type of the receiver.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000394 ReferenceTypePropagation rtp_fixup(graph_, handles_, /* is_first_run */ false);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100395 rtp_fixup.Run();
396
397 MaybeRecordStat(kInlinedMonomorphicCall);
398 return true;
399}
400
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000401HInstruction* HInliner::AddTypeGuard(HInstruction* receiver,
402 HInstruction* cursor,
403 HBasicBlock* bb_cursor,
404 uint32_t class_index,
405 bool is_referrer,
406 HInstruction* invoke_instruction,
407 bool with_deoptimization) {
408 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
409 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
410 class_linker, receiver, invoke_instruction->GetDexPc());
411
412 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
413 // Note that we will just compare the classes, so we don't need Java semantics access checks.
414 // Also, the caller of `AddTypeGuard` must have guaranteed that the class is in the dex cache.
415 HLoadClass* load_class = new (graph_->GetArena()) HLoadClass(graph_->GetCurrentMethod(),
416 class_index,
417 caller_dex_file,
418 is_referrer,
419 invoke_instruction->GetDexPc(),
420 /* needs_access_check */ false,
421 /* is_in_dex_cache */ true);
422
423 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(load_class, receiver_class);
424 // TODO: Extend reference type propagation to understand the guard.
425 if (cursor != nullptr) {
426 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
427 } else {
428 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
429 }
430 bb_cursor->InsertInstructionAfter(load_class, receiver_class);
431 bb_cursor->InsertInstructionAfter(compare, load_class);
432 if (with_deoptimization) {
433 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
434 compare, invoke_instruction->GetDexPc());
435 bb_cursor->InsertInstructionAfter(deoptimize, compare);
436 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
437 }
438 return compare;
439}
440
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000441bool HInliner::TryInlinePolymorphicCall(HInvoke* invoke_instruction,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100442 ArtMethod* resolved_method,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000443 const InlineCache& ic) {
444 DCHECK(invoke_instruction->IsInvokeVirtual() || invoke_instruction->IsInvokeInterface())
445 << invoke_instruction->DebugName();
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000446
447 if (TryInlinePolymorphicCallToSameTarget(invoke_instruction, resolved_method, ic)) {
448 return true;
449 }
450
451 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
452 size_t pointer_size = class_linker->GetImagePointerSize();
453 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
454
455 bool all_targets_inlined = true;
456 bool one_target_inlined = false;
457 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
458 if (ic.GetTypeAt(i) == nullptr) {
459 break;
460 }
461 ArtMethod* method = nullptr;
462 if (invoke_instruction->IsInvokeInterface()) {
463 method = ic.GetTypeAt(i)->FindVirtualMethodForInterface(
464 resolved_method, pointer_size);
465 } else {
466 DCHECK(invoke_instruction->IsInvokeVirtual());
467 method = ic.GetTypeAt(i)->FindVirtualMethodForVirtual(
468 resolved_method, pointer_size);
469 }
470
471 HInstruction* receiver = invoke_instruction->InputAt(0);
472 HInstruction* cursor = invoke_instruction->GetPrevious();
473 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
474
Nicolas Geoffray1fe26e12016-02-18 16:55:42 +0000475 uint32_t class_index = FindClassIndexIn(
476 ic.GetTypeAt(i), caller_dex_file, caller_compilation_unit_.GetDexCache());
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000477 HInstruction* return_replacement = nullptr;
478 if (class_index == DexFile::kDexNoIndex ||
479 !TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
480 all_targets_inlined = false;
481 } else {
482 one_target_inlined = true;
483 bool is_referrer = (ic.GetTypeAt(i) == outermost_graph_->GetArtMethod()->GetDeclaringClass());
484
485 // If we have inlined all targets before, and this receiver is the last seen,
486 // we deoptimize instead of keeping the original invoke instruction.
487 bool deoptimize = all_targets_inlined &&
488 (i != InlineCache::kIndividualCacheSize - 1) &&
489 (ic.GetTypeAt(i + 1) == nullptr);
490 HInstruction* compare = AddTypeGuard(
491 receiver, cursor, bb_cursor, class_index, is_referrer, invoke_instruction, deoptimize);
492 if (deoptimize) {
493 if (return_replacement != nullptr) {
494 invoke_instruction->ReplaceWith(return_replacement);
495 }
496 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
497 // Because the inline cache data can be populated concurrently, we force the end of the
498 // iteration. Otherhwise, we could see a new receiver type.
499 break;
500 } else {
501 CreateDiamondPatternForPolymorphicInline(compare, return_replacement, invoke_instruction);
502 }
503 }
504 }
505
506 if (!one_target_inlined) {
507 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
508 << " from inline cache is not inlined because none"
509 << " of its targets could be inlined";
510 return false;
511 }
512 MaybeRecordStat(kInlinedPolymorphicCall);
513
514 // Run type propagation to get the guards typed.
515 ReferenceTypePropagation rtp_fixup(graph_, handles_, /* is_first_run */ false);
516 rtp_fixup.Run();
517 return true;
518}
519
520void HInliner::CreateDiamondPatternForPolymorphicInline(HInstruction* compare,
521 HInstruction* return_replacement,
522 HInstruction* invoke_instruction) {
523 uint32_t dex_pc = invoke_instruction->GetDexPc();
524 HBasicBlock* cursor_block = compare->GetBlock();
525 HBasicBlock* original_invoke_block = invoke_instruction->GetBlock();
526 ArenaAllocator* allocator = graph_->GetArena();
527
528 // Spit the block after the compare: `cursor_block` will now be the start of the diamond,
529 // and the returned block is the start of the then branch (that could contain multiple blocks).
530 HBasicBlock* then = cursor_block->SplitAfterForInlining(compare);
531
532 // Split the block containing the invoke before and after the invoke. The returned block
533 // of the split before will contain the invoke and will be the otherwise branch of
534 // the diamond. The returned block of the split after will be the merge block
535 // of the diamond.
536 HBasicBlock* end_then = invoke_instruction->GetBlock();
537 HBasicBlock* otherwise = end_then->SplitBeforeForInlining(invoke_instruction);
538 HBasicBlock* merge = otherwise->SplitAfterForInlining(invoke_instruction);
539
540 // If the methods we are inlining return a value, we create a phi in the merge block
541 // that will have the `invoke_instruction and the `return_replacement` as inputs.
542 if (return_replacement != nullptr) {
543 HPhi* phi = new (allocator) HPhi(
544 allocator, kNoRegNumber, 0, HPhi::ToPhiType(invoke_instruction->GetType()), dex_pc);
545 merge->AddPhi(phi);
546 invoke_instruction->ReplaceWith(phi);
547 phi->AddInput(return_replacement);
548 phi->AddInput(invoke_instruction);
549 }
550
551 // Add the control flow instructions.
552 otherwise->AddInstruction(new (allocator) HGoto(dex_pc));
553 end_then->AddInstruction(new (allocator) HGoto(dex_pc));
554 cursor_block->AddInstruction(new (allocator) HIf(compare, dex_pc));
555
556 // Add the newly created blocks to the graph.
557 graph_->AddBlock(then);
558 graph_->AddBlock(otherwise);
559 graph_->AddBlock(merge);
560
561 // Set up successor (and implictly predecessor) relations.
562 cursor_block->AddSuccessor(otherwise);
563 cursor_block->AddSuccessor(then);
564 end_then->AddSuccessor(merge);
565 otherwise->AddSuccessor(merge);
566
567 // Set up dominance information.
568 then->SetDominator(cursor_block);
569 cursor_block->AddDominatedBlock(then);
570 otherwise->SetDominator(cursor_block);
571 cursor_block->AddDominatedBlock(otherwise);
572 merge->SetDominator(cursor_block);
573 cursor_block->AddDominatedBlock(merge);
574
575 // Update the revert post order.
576 size_t index = IndexOfElement(graph_->reverse_post_order_, cursor_block);
577 MakeRoomFor(&graph_->reverse_post_order_, 1, index);
578 graph_->reverse_post_order_[++index] = then;
579 index = IndexOfElement(graph_->reverse_post_order_, end_then);
580 MakeRoomFor(&graph_->reverse_post_order_, 2, index);
581 graph_->reverse_post_order_[++index] = otherwise;
582 graph_->reverse_post_order_[++index] = merge;
583
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000584
Nicolas Geoffraya1d8ddf2016-02-29 11:46:58 +0000585 graph_->UpdateLoopAndTryInformationOfNewBlock(
586 then, original_invoke_block, /* replace_if_back_edge */ false);
587 graph_->UpdateLoopAndTryInformationOfNewBlock(
588 otherwise, original_invoke_block, /* replace_if_back_edge */ false);
589
590 // In case the original invoke location was a back edge, we need to update
591 // the loop to now have the merge block as a back edge.
592 graph_->UpdateLoopAndTryInformationOfNewBlock(
593 merge, original_invoke_block, /* replace_if_back_edge */ true);
Nicolas Geoffray916cc1d2016-02-18 11:12:31 +0000594}
595
596bool HInliner::TryInlinePolymorphicCallToSameTarget(HInvoke* invoke_instruction,
597 ArtMethod* resolved_method,
598 const InlineCache& ic) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000599 // This optimization only works under JIT for now.
600 DCHECK(Runtime::Current()->UseJit());
Roland Levillain2aba7cd2016-02-03 12:27:20 +0000601 if (graph_->GetInstructionSet() == kMips64) {
602 // TODO: Support HClassTableGet for mips64.
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000603 return false;
604 }
605 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
606 size_t pointer_size = class_linker->GetImagePointerSize();
607
608 DCHECK(resolved_method != nullptr);
609 ArtMethod* actual_method = nullptr;
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000610 size_t method_index = invoke_instruction->IsInvokeVirtual()
611 ? invoke_instruction->AsInvokeVirtual()->GetVTableIndex()
612 : invoke_instruction->AsInvokeInterface()->GetImtIndex();
613
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000614 // Check whether we are actually calling the same method among
615 // the different types seen.
616 for (size_t i = 0; i < InlineCache::kIndividualCacheSize; ++i) {
617 if (ic.GetTypeAt(i) == nullptr) {
618 break;
619 }
620 ArtMethod* new_method = nullptr;
621 if (invoke_instruction->IsInvokeInterface()) {
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000622 new_method = ic.GetTypeAt(i)->GetEmbeddedImTableEntry(
623 method_index % mirror::Class::kImtSize, pointer_size);
624 if (new_method->IsRuntimeMethod()) {
625 // Bail out as soon as we see a conflict trampoline in one of the target's
626 // interface table.
627 return false;
628 }
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000629 } else {
630 DCHECK(invoke_instruction->IsInvokeVirtual());
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000631 new_method = ic.GetTypeAt(i)->GetEmbeddedVTableEntry(method_index, pointer_size);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000632 }
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000633 DCHECK(new_method != nullptr);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000634 if (actual_method == nullptr) {
635 actual_method = new_method;
636 } else if (actual_method != new_method) {
637 // Different methods, bailout.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000638 VLOG(compiler) << "Call to " << PrettyMethod(resolved_method)
639 << " from inline cache is not inlined because it resolves"
640 << " to different methods";
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000641 return false;
642 }
643 }
644
645 HInstruction* receiver = invoke_instruction->InputAt(0);
646 HInstruction* cursor = invoke_instruction->GetPrevious();
647 HBasicBlock* bb_cursor = invoke_instruction->GetBlock();
648
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000649 if (!TryInlineAndReplace(invoke_instruction, actual_method, /* do_rtp */ false)) {
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000650 return false;
651 }
652
653 // We successfully inlined, now add a guard.
654 HInstanceFieldGet* receiver_class = BuildGetReceiverClass(
655 class_linker, receiver, invoke_instruction->GetDexPc());
656
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000657 Primitive::Type type = Is64BitInstructionSet(graph_->GetInstructionSet())
658 ? Primitive::kPrimLong
659 : Primitive::kPrimInt;
660 HClassTableGet* class_table_get = new (graph_->GetArena()) HClassTableGet(
661 receiver_class,
662 type,
Vladimir Markoa1de9182016-02-25 11:37:38 +0000663 invoke_instruction->IsInvokeVirtual() ? HClassTableGet::TableKind::kVTable
664 : HClassTableGet::TableKind::kIMTable,
Nicolas Geoffray4f97a212016-02-25 16:17:54 +0000665 method_index,
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000666 invoke_instruction->GetDexPc());
667
668 HConstant* constant;
669 if (type == Primitive::kPrimLong) {
670 constant = graph_->GetLongConstant(
671 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
672 } else {
673 constant = graph_->GetIntConstant(
674 reinterpret_cast<intptr_t>(actual_method), invoke_instruction->GetDexPc());
675 }
676
677 HNotEqual* compare = new (graph_->GetArena()) HNotEqual(class_table_get, constant);
678 HDeoptimize* deoptimize = new (graph_->GetArena()) HDeoptimize(
679 compare, invoke_instruction->GetDexPc());
680 // TODO: Extend reference type propagation to understand the guard.
681 if (cursor != nullptr) {
682 bb_cursor->InsertInstructionAfter(receiver_class, cursor);
683 } else {
684 bb_cursor->InsertInstructionBefore(receiver_class, bb_cursor->GetFirstInstruction());
685 }
686 bb_cursor->InsertInstructionAfter(class_table_get, receiver_class);
687 bb_cursor->InsertInstructionAfter(compare, class_table_get);
688 bb_cursor->InsertInstructionAfter(deoptimize, compare);
689 deoptimize->CopyEnvironmentFrom(invoke_instruction->GetEnvironment());
690
691 // Run type propagation to get the guard typed.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000692 ReferenceTypePropagation rtp_fixup(graph_, handles_, /* is_first_run */ false);
Nicolas Geoffraya42363f2015-12-17 14:57:09 +0000693 rtp_fixup.Run();
694
695 MaybeRecordStat(kInlinedPolymorphicCall);
696
697 return true;
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100698}
699
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000700bool HInliner::TryInlineAndReplace(HInvoke* invoke_instruction, ArtMethod* method, bool do_rtp) {
701 HInstruction* return_replacement = nullptr;
702 if (!TryBuildAndInline(invoke_instruction, method, &return_replacement)) {
703 return false;
704 }
705 if (return_replacement != nullptr) {
706 invoke_instruction->ReplaceWith(return_replacement);
707 }
708 invoke_instruction->GetBlock()->RemoveInstruction(invoke_instruction);
709 FixUpReturnReferenceType(invoke_instruction, method, return_replacement, do_rtp);
710 return true;
711}
712
713bool HInliner::TryBuildAndInline(HInvoke* invoke_instruction,
714 ArtMethod* method,
715 HInstruction** return_replacement) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100716 const DexFile& caller_dex_file = *caller_compilation_unit_.GetDexFile();
Jeff Haodcdc85b2015-12-04 14:06:18 -0800717
718 // Check whether we're allowed to inline. The outermost compilation unit is the relevant
719 // dex file here (though the transitivity of an inline chain would allow checking the calller).
720 if (!compiler_driver_->MayInline(method->GetDexFile(),
721 outer_compilation_unit_.GetDexFile())) {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000722 if (TryPatternSubstitution(invoke_instruction, method, return_replacement)) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000723 VLOG(compiler) << "Successfully replaced pattern of invoke " << PrettyMethod(method);
724 MaybeRecordStat(kReplacedInvokeWithSimplePattern);
725 return true;
726 }
Jeff Haodcdc85b2015-12-04 14:06:18 -0800727 VLOG(compiler) << "Won't inline " << PrettyMethod(method) << " in "
728 << outer_compilation_unit_.GetDexFile()->GetLocation() << " ("
729 << caller_compilation_unit_.GetDexFile()->GetLocation() << ") from "
730 << method->GetDexFile()->GetLocation();
731 return false;
732 }
733
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100734 uint32_t method_index = FindMethodIndexIn(
735 method, caller_dex_file, invoke_instruction->GetDexMethodIndex());
736 if (method_index == DexFile::kDexNoIndex) {
737 VLOG(compiler) << "Call to "
738 << PrettyMethod(method)
739 << " cannot be inlined because unaccessible to caller";
740 return false;
741 }
742
743 bool same_dex_file = IsSameDexFile(*outer_compilation_unit_.GetDexFile(), *method->GetDexFile());
744
745 const DexFile::CodeItem* code_item = method->GetCodeItem();
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000746
747 if (code_item == nullptr) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100748 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000749 << " is not inlined because it is native";
750 return false;
751 }
752
Calin Juravleec748352015-07-29 13:52:12 +0100753 size_t inline_max_code_units = compiler_driver_->GetCompilerOptions().GetInlineMaxCodeUnits();
754 if (code_item->insns_size_in_code_units_ > inline_max_code_units) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100755 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +0000756 << " is too big to inline: "
757 << code_item->insns_size_in_code_units_
758 << " > "
759 << inline_max_code_units;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000760 return false;
761 }
762
763 if (code_item->tries_size_ != 0) {
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100764 VLOG(compiler) << "Method " << PrettyMethod(method)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000765 << " is not inlined because of try block";
766 return false;
767 }
768
Nicolas Geoffray73be1e82015-09-17 15:22:56 +0100769 if (!method->GetDeclaringClass()->IsVerified()) {
770 uint16_t class_def_idx = method->GetDeclaringClass()->GetDexClassDefIndex();
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000771 if (Runtime::Current()->UseJit() ||
772 !compiler_driver_->IsMethodVerifiedWithoutFailures(
773 method->GetDexMethodIndex(), class_def_idx, *method->GetDexFile())) {
Nicolas Geoffrayccc61972015-10-01 14:34:20 +0100774 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
775 << " couldn't be verified, so it cannot be inlined";
776 return false;
777 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000778 }
779
Roland Levillain4c0eb422015-04-24 16:43:49 +0100780 if (invoke_instruction->IsInvokeStaticOrDirect() &&
781 invoke_instruction->AsInvokeStaticOrDirect()->IsStaticWithImplicitClinitCheck()) {
782 // Case of a static method that cannot be inlined because it implicitly
783 // requires an initialization check of its declaring class.
784 VLOG(compiler) << "Method " << PrettyMethod(method_index, caller_dex_file)
785 << " is not inlined because it is static and requires a clinit"
786 << " check that cannot be emitted due to Dex cache limitations";
787 return false;
788 }
789
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000790 if (!TryBuildAndInlineHelper(invoke_instruction, method, same_dex_file, return_replacement)) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000791 return false;
792 }
793
Nicolas Geoffray9437b782015-03-25 10:08:51 +0000794 VLOG(compiler) << "Successfully inlined " << PrettyMethod(method_index, caller_dex_file);
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000795 MaybeRecordStat(kInlinedInvoke);
796 return true;
797}
798
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000799static HInstruction* GetInvokeInputForArgVRegIndex(HInvoke* invoke_instruction,
800 size_t arg_vreg_index)
801 SHARED_REQUIRES(Locks::mutator_lock_) {
802 size_t input_index = 0;
803 for (size_t i = 0; i < arg_vreg_index; ++i, ++input_index) {
804 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
805 if (Primitive::Is64BitType(invoke_instruction->InputAt(input_index)->GetType())) {
806 ++i;
807 DCHECK_NE(i, arg_vreg_index);
808 }
809 }
810 DCHECK_LT(input_index, invoke_instruction->GetNumberOfArguments());
811 return invoke_instruction->InputAt(input_index);
812}
813
814// Try to recognize known simple patterns and replace invoke call with appropriate instructions.
815bool HInliner::TryPatternSubstitution(HInvoke* invoke_instruction,
816 ArtMethod* resolved_method,
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000817 HInstruction** return_replacement) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000818 InlineMethod inline_method;
819 if (!InlineMethodAnalyser::AnalyseMethodCode(resolved_method, &inline_method)) {
820 return false;
821 }
822
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000823 switch (inline_method.opcode) {
824 case kInlineOpNop:
825 DCHECK_EQ(invoke_instruction->GetType(), Primitive::kPrimVoid);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000826 *return_replacement = nullptr;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000827 break;
828 case kInlineOpReturnArg:
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000829 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction,
830 inline_method.d.return_data.arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000831 break;
832 case kInlineOpNonWideConst:
833 if (resolved_method->GetShorty()[0] == 'L') {
834 DCHECK_EQ(inline_method.d.data, 0u);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000835 *return_replacement = graph_->GetNullConstant();
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000836 } else {
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000837 *return_replacement = graph_->GetIntConstant(static_cast<int32_t>(inline_method.d.data));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000838 }
839 break;
840 case kInlineOpIGet: {
841 const InlineIGetIPutData& data = inline_method.d.ifield_data;
842 if (data.method_is_static || data.object_arg != 0u) {
843 // TODO: Needs null check.
844 return false;
845 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000846 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000847 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000848 HInstanceFieldGet* iget = CreateInstanceFieldGet(dex_cache, data.field_idx, obj);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000849 DCHECK_EQ(iget->GetFieldOffset().Uint32Value(), data.field_offset);
850 DCHECK_EQ(iget->IsVolatile() ? 1u : 0u, data.is_volatile);
851 invoke_instruction->GetBlock()->InsertInstructionBefore(iget, invoke_instruction);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000852 *return_replacement = iget;
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000853 break;
854 }
855 case kInlineOpIPut: {
856 const InlineIGetIPutData& data = inline_method.d.ifield_data;
857 if (data.method_is_static || data.object_arg != 0u) {
858 // TODO: Needs null check.
859 return false;
860 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000861 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000862 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, data.object_arg);
863 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, data.src_arg);
Vladimir Marko354efa62016-02-04 19:46:56 +0000864 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, data.field_idx, obj, value);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000865 DCHECK_EQ(iput->GetFieldOffset().Uint32Value(), data.field_offset);
866 DCHECK_EQ(iput->IsVolatile() ? 1u : 0u, data.is_volatile);
867 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
868 if (data.return_arg_plus1 != 0u) {
869 size_t return_arg = data.return_arg_plus1 - 1u;
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000870 *return_replacement = GetInvokeInputForArgVRegIndex(invoke_instruction, return_arg);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000871 }
872 break;
873 }
Vladimir Marko354efa62016-02-04 19:46:56 +0000874 case kInlineOpConstructor: {
875 const InlineConstructorData& data = inline_method.d.constructor_data;
876 // Get the indexes to arrays for easier processing.
877 uint16_t iput_field_indexes[] = {
878 data.iput0_field_index, data.iput1_field_index, data.iput2_field_index
879 };
880 uint16_t iput_args[] = { data.iput0_arg, data.iput1_arg, data.iput2_arg };
881 static_assert(arraysize(iput_args) == arraysize(iput_field_indexes), "Size mismatch");
882 // Count valid field indexes.
883 size_t number_of_iputs = 0u;
884 while (number_of_iputs != arraysize(iput_field_indexes) &&
885 iput_field_indexes[number_of_iputs] != DexFile::kDexNoIndex16) {
886 // Check that there are no duplicate valid field indexes.
887 DCHECK_EQ(0, std::count(iput_field_indexes + number_of_iputs + 1,
888 iput_field_indexes + arraysize(iput_field_indexes),
889 iput_field_indexes[number_of_iputs]));
890 ++number_of_iputs;
891 }
892 // Check that there are no valid field indexes in the rest of the array.
893 DCHECK_EQ(0, std::count_if(iput_field_indexes + number_of_iputs,
894 iput_field_indexes + arraysize(iput_field_indexes),
895 [](uint16_t index) { return index != DexFile::kDexNoIndex16; }));
896
897 // Create HInstanceFieldSet for each IPUT that stores non-zero data.
898 Handle<mirror::DexCache> dex_cache;
899 HInstruction* obj = GetInvokeInputForArgVRegIndex(invoke_instruction, /* this */ 0u);
900 bool needs_constructor_barrier = false;
901 for (size_t i = 0; i != number_of_iputs; ++i) {
902 HInstruction* value = GetInvokeInputForArgVRegIndex(invoke_instruction, iput_args[i]);
903 if (!value->IsConstant() ||
904 (!value->AsConstant()->IsZero() && !value->IsNullConstant())) {
905 if (dex_cache.GetReference() == nullptr) {
906 dex_cache = handles_->NewHandle(resolved_method->GetDexCache());
907 }
908 uint16_t field_index = iput_field_indexes[i];
909 HInstanceFieldSet* iput = CreateInstanceFieldSet(dex_cache, field_index, obj, value);
910 invoke_instruction->GetBlock()->InsertInstructionBefore(iput, invoke_instruction);
911
912 // Check whether the field is final. If it is, we need to add a barrier.
913 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
914 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
915 DCHECK(resolved_field != nullptr);
916 if (resolved_field->IsFinal()) {
917 needs_constructor_barrier = true;
918 }
919 }
920 }
921 if (needs_constructor_barrier) {
922 HMemoryBarrier* barrier = new (graph_->GetArena()) HMemoryBarrier(kStoreStore, kNoDexPc);
923 invoke_instruction->GetBlock()->InsertInstructionBefore(barrier, invoke_instruction);
924 }
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000925 *return_replacement = nullptr;
Vladimir Marko354efa62016-02-04 19:46:56 +0000926 break;
927 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000928 default:
929 LOG(FATAL) << "UNREACHABLE";
930 UNREACHABLE();
931 }
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000932 return true;
933}
934
Vladimir Marko354efa62016-02-04 19:46:56 +0000935HInstanceFieldGet* HInliner::CreateInstanceFieldGet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000936 uint32_t field_index,
937 HInstruction* obj)
938 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000939 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
940 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
941 DCHECK(resolved_field != nullptr);
942 HInstanceFieldGet* iget = new (graph_->GetArena()) HInstanceFieldGet(
943 obj,
944 resolved_field->GetTypeAsPrimitiveType(),
945 resolved_field->GetOffset(),
946 resolved_field->IsVolatile(),
947 field_index,
948 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +0000949 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000950 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +0000951 // Read barrier generates a runtime call in slow path and we need a valid
952 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
953 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000954 if (iget->GetType() == Primitive::kPrimNot) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000955 ReferenceTypePropagation rtp(graph_, handles_, /* is_first_run */ false);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000956 rtp.Visit(iget);
957 }
958 return iget;
959}
960
Vladimir Marko354efa62016-02-04 19:46:56 +0000961HInstanceFieldSet* HInliner::CreateInstanceFieldSet(Handle<mirror::DexCache> dex_cache,
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000962 uint32_t field_index,
963 HInstruction* obj,
964 HInstruction* value)
965 SHARED_REQUIRES(Locks::mutator_lock_) {
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000966 size_t pointer_size = InstructionSetPointerSize(codegen_->GetInstructionSet());
967 ArtField* resolved_field = dex_cache->GetResolvedField(field_index, pointer_size);
968 DCHECK(resolved_field != nullptr);
969 HInstanceFieldSet* iput = new (graph_->GetArena()) HInstanceFieldSet(
970 obj,
971 value,
972 resolved_field->GetTypeAsPrimitiveType(),
973 resolved_field->GetOffset(),
974 resolved_field->IsVolatile(),
975 field_index,
976 resolved_field->GetDeclaringClass()->GetDexClassDefIndex(),
Vladimir Marko354efa62016-02-04 19:46:56 +0000977 *dex_cache->GetDexFile(),
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000978 dex_cache,
Vladimir Markoadda4352016-01-29 10:24:41 +0000979 // Read barrier generates a runtime call in slow path and we need a valid
980 // dex pc for the associated stack map. 0 is bogus but valid. Bug: 26854537.
981 /* dex_pc */ 0);
Vladimir Markobe10e8e2016-01-22 12:09:44 +0000982 return iput;
983}
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +0000984
Nicolas Geoffray55bd7492016-02-16 15:37:12 +0000985bool HInliner::TryBuildAndInlineHelper(HInvoke* invoke_instruction,
986 ArtMethod* resolved_method,
987 bool same_dex_file,
988 HInstruction** return_replacement) {
Nicolas Geoffrayc0365b12015-03-18 18:31:52 +0000989 ScopedObjectAccess soa(Thread::Current());
990 const DexFile::CodeItem* code_item = resolved_method->GetCodeItem();
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +0100991 const DexFile& callee_dex_file = *resolved_method->GetDexFile();
992 uint32_t method_index = resolved_method->GetDexMethodIndex();
Calin Juravle2e768302015-07-28 14:41:11 +0000993 ClassLinker* class_linker = caller_compilation_unit_.GetClassLinker();
Mathieu Chartier736b5602015-09-02 14:54:11 -0700994 Handle<mirror::DexCache> dex_cache(handles_->NewHandle(resolved_method->GetDexCache()));
Nicolas Geoffraye53798a2014-12-01 10:31:54 +0000995 DexCompilationUnit dex_compilation_unit(
Nicolas Geoffray5b82d332016-02-18 14:22:32 +0000996 nullptr,
997 caller_compilation_unit_.GetClassLoader(),
998 class_linker,
999 callee_dex_file,
1000 code_item,
1001 resolved_method->GetDeclaringClass()->GetDexClassDefIndex(),
1002 method_index,
1003 resolved_method->GetAccessFlags(),
1004 /* verified_method */ nullptr,
1005 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001006
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001007 bool requires_ctor_barrier = false;
1008
1009 if (dex_compilation_unit.IsConstructor()) {
1010 // If it's a super invocation and we already generate a barrier there's no need
1011 // to generate another one.
1012 // We identify super calls by looking at the "this" pointer. If its value is the
1013 // same as the local "this" pointer then we must have a super invocation.
1014 bool is_super_invocation = invoke_instruction->InputAt(0)->IsParameterValue()
1015 && invoke_instruction->InputAt(0)->AsParameterValue()->IsThis();
1016 if (is_super_invocation && graph_->ShouldGenerateConstructorBarrier()) {
1017 requires_ctor_barrier = false;
1018 } else {
1019 Thread* self = Thread::Current();
1020 requires_ctor_barrier = compiler_driver_->RequiresConstructorBarrier(self,
1021 dex_compilation_unit.GetDexFile(),
1022 dex_compilation_unit.GetClassDefIndex());
1023 }
1024 }
1025
Nicolas Geoffray35071052015-06-09 15:43:38 +01001026 InvokeType invoke_type = invoke_instruction->GetOriginalInvokeType();
1027 if (invoke_type == kInterface) {
1028 // We have statically resolved the dispatch. To please the class linker
1029 // at runtime, we change this call as if it was a virtual call.
1030 invoke_type = kVirtual;
1031 }
David Brazdil3f523062016-02-29 16:53:33 +00001032
1033 const int32_t caller_instruction_counter = graph_->GetCurrentInstructionId();
Nicolas Geoffraye0fe7ae2015-03-09 10:02:49 +00001034 HGraph* callee_graph = new (graph_->GetArena()) HGraph(
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001035 graph_->GetArena(),
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001036 callee_dex_file,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001037 method_index,
Calin Juravle3cd4fc82015-05-14 15:15:42 +01001038 requires_ctor_barrier,
Mathieu Chartiere401d142015-04-22 13:56:20 -07001039 compiler_driver_->GetInstructionSet(),
Nicolas Geoffray35071052015-06-09 15:43:38 +01001040 invoke_type,
Nicolas Geoffray0a23d742015-05-07 11:57:35 +01001041 graph_->IsDebuggable(),
Nicolas Geoffrayb331feb2016-02-05 16:51:53 +00001042 /* osr */ false,
David Brazdil3f523062016-02-29 16:53:33 +00001043 caller_instruction_counter);
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001044 callee_graph->SetArtMethod(resolved_method);
David Brazdil5e8b1372015-01-23 14:39:08 +00001045
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001046 OptimizingCompilerStats inline_stats;
David Brazdil5e8b1372015-01-23 14:39:08 +00001047 HGraphBuilder builder(callee_graph,
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001048 &dex_compilation_unit,
1049 &outer_compilation_unit_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001050 resolved_method->GetDexFile(),
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001051 compiler_driver_,
Nicolas Geoffray9523a3e2015-07-17 11:51:28 +00001052 &inline_stats,
Mathieu Chartier736b5602015-09-02 14:54:11 -07001053 resolved_method->GetQuickenedInfo(),
1054 dex_cache);
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001055
David Brazdilbadd8262016-02-02 16:28:56 +00001056 if (builder.BuildGraph(*code_item, handles_) != kAnalysisSuccess) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001057 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001058 << " could not be built, so cannot be inlined";
1059 return false;
1060 }
1061
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001062 if (!RegisterAllocator::CanAllocateRegistersFor(*callee_graph,
1063 compiler_driver_->GetInstructionSet())) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001064 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray259136f2014-12-17 23:21:58 +00001065 << " cannot be inlined because of the register allocator";
1066 return false;
1067 }
1068
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001069 size_t parameter_index = 0;
1070 for (HInstructionIterator instructions(callee_graph->GetEntryBlock()->GetInstructions());
1071 !instructions.Done();
1072 instructions.Advance()) {
1073 HInstruction* current = instructions.Current();
1074 if (current->IsParameterValue()) {
1075 HInstruction* argument = invoke_instruction->InputAt(parameter_index++);
1076 if (argument->IsNullConstant()) {
1077 current->ReplaceWith(callee_graph->GetNullConstant());
1078 } else if (argument->IsIntConstant()) {
1079 current->ReplaceWith(callee_graph->GetIntConstant(argument->AsIntConstant()->GetValue()));
1080 } else if (argument->IsLongConstant()) {
1081 current->ReplaceWith(callee_graph->GetLongConstant(argument->AsLongConstant()->GetValue()));
1082 } else if (argument->IsFloatConstant()) {
1083 current->ReplaceWith(
1084 callee_graph->GetFloatConstant(argument->AsFloatConstant()->GetValue()));
1085 } else if (argument->IsDoubleConstant()) {
1086 current->ReplaceWith(
1087 callee_graph->GetDoubleConstant(argument->AsDoubleConstant()->GetValue()));
1088 } else if (argument->GetType() == Primitive::kPrimNot) {
1089 current->SetReferenceTypeInfo(argument->GetReferenceTypeInfo());
1090 current->AsParameterValue()->SetCanBeNull(argument->CanBeNull());
1091 }
1092 }
1093 }
1094
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001095 // Run simple optimizations on the graph.
Calin Juravle7a9c8852015-04-21 14:07:50 +01001096 HDeadCodeElimination dce(callee_graph, stats_);
Nicolas Geoffraye34648d2015-11-23 08:59:07 +00001097 HConstantFolding fold(callee_graph);
Vladimir Markodc151b22015-10-15 18:02:30 +01001098 HSharpening sharpening(callee_graph, codegen_, dex_compilation_unit, compiler_driver_);
Calin Juravleacf735c2015-02-12 15:25:22 +00001099 InstructionSimplifier simplify(callee_graph, stats_);
Jean-Philippe Halimi38e9e802016-02-18 16:42:03 +01001100 IntrinsicsRecognizer intrinsics(callee_graph, compiler_driver_, stats_);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001101
1102 HOptimization* optimizations[] = {
Scott Wakelingd60a1af2015-07-22 14:32:44 +01001103 &intrinsics,
Vladimir Markodc151b22015-10-15 18:02:30 +01001104 &sharpening,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001105 &simplify,
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001106 &fold,
Vladimir Marko9e23df52015-11-10 17:14:35 +00001107 &dce,
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001108 };
1109
1110 for (size_t i = 0; i < arraysize(optimizations); ++i) {
1111 HOptimization* optimization = optimizations[i];
1112 optimization->Run();
1113 }
1114
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001115 size_t number_of_instructions_budget = kMaximumNumberOfHInstructions;
Calin Juravleec748352015-07-29 13:52:12 +01001116 if (depth_ + 1 < compiler_driver_->GetCompilerOptions().GetInlineDepthLimit()) {
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001117 HInliner inliner(callee_graph,
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001118 outermost_graph_,
Vladimir Markodc151b22015-10-15 18:02:30 +01001119 codegen_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001120 outer_compilation_unit_,
1121 dex_compilation_unit,
1122 compiler_driver_,
Nicolas Geoffray454a4812015-06-09 10:37:32 +01001123 handles_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001124 stats_,
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001125 total_number_of_dex_registers_ + code_item->registers_size_,
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001126 depth_ + 1);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001127 inliner.Run();
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001128 number_of_instructions_budget += inliner.number_of_inlined_instructions_;
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001129 }
1130
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001131 // TODO: We should abort only if all predecessors throw. However,
1132 // HGraph::InlineInto currently does not handle an exit block with
1133 // a throw predecessor.
1134 HBasicBlock* exit_block = callee_graph->GetExitBlock();
1135 if (exit_block == nullptr) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001136 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001137 << " could not be inlined because it has an infinite loop";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001138 return false;
1139 }
1140
1141 bool has_throw_predecessor = false;
Vladimir Marko60584552015-09-03 13:35:12 +00001142 for (HBasicBlock* predecessor : exit_block->GetPredecessors()) {
1143 if (predecessor->GetLastInstruction()->IsThrow()) {
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001144 has_throw_predecessor = true;
1145 break;
1146 }
1147 }
1148 if (has_throw_predecessor) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001149 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001150 << " could not be inlined because one branch always throws";
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001151 return false;
1152 }
1153
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001154 HReversePostOrderIterator it(*callee_graph);
Nicolas Geoffrayef87c5d2015-01-30 12:41:14 +00001155 it.Advance(); // Past the entry block, it does not contain instructions that prevent inlining.
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001156 size_t number_of_instructions = 0;
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001157
1158 bool can_inline_environment =
1159 total_number_of_dex_registers_ < kMaximumNumberOfCumulatedDexRegisters;
1160
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001161 for (; !it.Done(); it.Advance()) {
1162 HBasicBlock* block = it.Current();
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001163
1164 if (block->IsLoopHeader() && block->GetLoopInformation()->IsIrreducible()) {
1165 // Don't inline methods with irreducible loops, they could prevent some
1166 // optimizations to run.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001167 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray788f2f02016-01-22 12:41:38 +00001168 << " could not be inlined because it contains an irreducible loop";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001169 return false;
1170 }
1171
1172 for (HInstructionIterator instr_it(block->GetInstructions());
1173 !instr_it.Done();
1174 instr_it.Advance()) {
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001175 if (number_of_instructions++ == number_of_instructions_budget) {
1176 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001177 << " is not inlined because its caller has reached"
1178 << " its instruction budget limit.";
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001179 return false;
1180 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001181 HInstruction* current = instr_it.Current();
Nicolas Geoffray5949fa02015-12-18 10:57:10 +00001182 if (!can_inline_environment && current->NeedsEnvironment()) {
1183 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1184 << " is not inlined because its caller has reached"
1185 << " its environment budget limit.";
1186 return false;
1187 }
Nicolas Geoffray276d9da2015-02-02 18:24:11 +00001188
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001189 if (current->IsInvokeInterface()) {
1190 // Disable inlining of interface calls. The cost in case of entering the
1191 // resolution conflict is currently too high.
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001192 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001193 << " could not be inlined because it has an interface call.";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001194 return false;
1195 }
1196
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001197 if (!same_dex_file && current->NeedsEnvironment()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001198 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001199 << " could not be inlined because " << current->DebugName()
Nicolas Geoffrayd23eeef2015-05-18 22:31:29 +01001200 << " needs an environment and is in a different dex file";
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001201 return false;
1202 }
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001203
Vladimir Markodc151b22015-10-15 18:02:30 +01001204 if (!same_dex_file && current->NeedsDexCacheOfDeclaringClass()) {
Guillaume "Vermeille" Sanchezae09d2d2015-05-29 10:52:55 +01001205 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
Nicolas Geoffray9437b782015-03-25 10:08:51 +00001206 << " could not be inlined because " << current->DebugName()
1207 << " it is in a different dex file and requires access to the dex cache";
1208 return false;
1209 }
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001210
1211 if (current->IsNewInstance() &&
1212 (current->AsNewInstance()->GetEntrypoint() == kQuickAllocObjectWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001213 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1214 << " could not be inlined because it is using an entrypoint"
1215 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001216 // Allocation entrypoint does not handle inlined frames.
1217 return false;
1218 }
1219
1220 if (current->IsNewArray() &&
1221 (current->AsNewArray()->GetEntrypoint() == kQuickAllocArrayWithAccessCheck)) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001222 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1223 << " could not be inlined because it is using an entrypoint"
1224 << " with access checks";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001225 // Allocation entrypoint does not handle inlined frames.
1226 return false;
1227 }
1228
1229 if (current->IsUnresolvedStaticFieldGet() ||
1230 current->IsUnresolvedInstanceFieldGet() ||
1231 current->IsUnresolvedStaticFieldSet() ||
1232 current->IsUnresolvedInstanceFieldSet()) {
1233 // Entrypoint for unresolved fields does not handle inlined frames.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001234 VLOG(compiler) << "Method " << PrettyMethod(method_index, callee_dex_file)
1235 << " could not be inlined because it is using an unresolved"
1236 << " entrypoint";
Nicolas Geoffrayd9309292015-10-31 22:21:31 +00001237 return false;
1238 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001239 }
1240 }
Nicolas Geoffraye418dda2015-08-11 20:03:09 -07001241 number_of_inlined_instructions_ += number_of_instructions;
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001242
David Brazdil3f523062016-02-29 16:53:33 +00001243 DCHECK_EQ(caller_instruction_counter, graph_->GetCurrentInstructionId())
1244 << "No instructions can be added to the outer graph while inner graph is being built";
1245
1246 const int32_t callee_instruction_counter = callee_graph->GetCurrentInstructionId();
1247 graph_->SetCurrentInstructionId(callee_instruction_counter);
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001248 *return_replacement = callee_graph->InlineInto(graph_, invoke_instruction);
David Brazdil3f523062016-02-29 16:53:33 +00001249
1250 DCHECK_EQ(callee_instruction_counter, callee_graph->GetCurrentInstructionId())
1251 << "No instructions can be added to the inner graph during inlining into the outer graph";
1252
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001253 return true;
1254}
Calin Juravle2e768302015-07-28 14:41:11 +00001255
Nicolas Geoffray55bd7492016-02-16 15:37:12 +00001256void HInliner::FixUpReturnReferenceType(HInvoke* invoke_instruction,
1257 ArtMethod* resolved_method,
Vladimir Markobe10e8e2016-01-22 12:09:44 +00001258 HInstruction* return_replacement,
1259 bool do_rtp) {
Alex Light68289a52015-12-15 17:30:30 -08001260 // Check the integrity of reference types and run another type propagation if needed.
David Brazdil4833f5a2015-12-16 10:37:39 +00001261 if (return_replacement != nullptr) {
1262 if (return_replacement->GetType() == Primitive::kPrimNot) {
1263 if (!return_replacement->GetReferenceTypeInfo().IsValid()) {
1264 // Make sure that we have a valid type for the return. We may get an invalid one when
1265 // we inline invokes with multiple branches and create a Phi for the result.
1266 // TODO: we could be more precise by merging the phi inputs but that requires
1267 // some functionality from the reference type propagation.
1268 DCHECK(return_replacement->IsPhi());
1269 size_t pointer_size = Runtime::Current()->GetClassLinker()->GetImagePointerSize();
1270 ReferenceTypeInfo::TypeHandle return_handle =
1271 handles_->NewHandle(resolved_method->GetReturnType(true /* resolve */, pointer_size));
1272 return_replacement->SetReferenceTypeInfo(ReferenceTypeInfo::Create(
1273 return_handle, return_handle->CannotBeAssignedFromOtherTypes() /* is_exact */));
1274 }
Alex Light68289a52015-12-15 17:30:30 -08001275
David Brazdil4833f5a2015-12-16 10:37:39 +00001276 if (do_rtp) {
1277 // If the return type is a refinement of the declared type run the type propagation again.
1278 ReferenceTypeInfo return_rti = return_replacement->GetReferenceTypeInfo();
1279 ReferenceTypeInfo invoke_rti = invoke_instruction->GetReferenceTypeInfo();
1280 if (invoke_rti.IsStrictSupertypeOf(return_rti)
1281 || (return_rti.IsExact() && !invoke_rti.IsExact())
1282 || !return_replacement->CanBeNull()) {
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001283 ReferenceTypePropagation(graph_, handles_, /* is_first_run */ false).Run();
David Brazdil4833f5a2015-12-16 10:37:39 +00001284 }
1285 }
1286 } else if (return_replacement->IsInstanceOf()) {
1287 if (do_rtp) {
1288 // Inlining InstanceOf into an If may put a tighter bound on reference types.
Nicolas Geoffrayd9994f02016-02-11 17:35:55 +00001289 ReferenceTypePropagation(graph_, handles_, /* is_first_run */ false).Run();
Nicolas Geoffray73be1e82015-09-17 15:22:56 +01001290 }
Calin Juravlecdfed3d2015-10-26 14:05:01 +00001291 }
Calin Juravle2e768302015-07-28 14:41:11 +00001292 }
Nicolas Geoffraye53798a2014-12-01 10:31:54 +00001293}
1294
1295} // namespace art