blob: ebdef54bf7df2b898e7d03a5ddc3b0c8a7554bbb [file] [log] [blame]
John Fastabend546ac1f2017-07-17 09:28:56 -07001/* Copyright (c) 2017 Covalent IO, Inc. http://covalent.io
2 *
3 * This program is free software; you can redistribute it and/or
4 * modify it under the terms of version 2 of the GNU General Public
5 * License as published by the Free Software Foundation.
6 *
7 * This program is distributed in the hope that it will be useful, but
8 * WITHOUT ANY WARRANTY; without even the implied warranty of
9 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
10 * General Public License for more details.
11 */
12
13/* Devmaps primary use is as a backend map for XDP BPF helper call
14 * bpf_redirect_map(). Because XDP is mostly concerned with performance we
15 * spent some effort to ensure the datapath with redirect maps does not use
16 * any locking. This is a quick note on the details.
17 *
18 * We have three possible paths to get into the devmap control plane bpf
19 * syscalls, bpf programs, and driver side xmit/flush operations. A bpf syscall
20 * will invoke an update, delete, or lookup operation. To ensure updates and
21 * deletes appear atomic from the datapath side xchg() is used to modify the
22 * netdev_map array. Then because the datapath does a lookup into the netdev_map
23 * array (read-only) from an RCU critical section we use call_rcu() to wait for
24 * an rcu grace period before free'ing the old data structures. This ensures the
25 * datapath always has a valid copy. However, the datapath does a "flush"
26 * operation that pushes any pending packets in the driver outside the RCU
27 * critical section. Each bpf_dtab_netdev tracks these pending operations using
28 * an atomic per-cpu bitmap. The bpf_dtab_netdev object will not be destroyed
29 * until all bits are cleared indicating outstanding flush operations have
30 * completed.
31 *
32 * BPF syscalls may race with BPF program calls on any of the update, delete
33 * or lookup operations. As noted above the xchg() operation also keep the
34 * netdev_map consistent in this case. From the devmap side BPF programs
35 * calling into these operations are the same as multiple user space threads
36 * making system calls.
John Fastabend2ddf71e2017-07-17 09:30:02 -070037 *
38 * Finally, any of the above may race with a netdev_unregister notifier. The
39 * unregister notifier must search for net devices in the map structure that
40 * contain a reference to the net device and remove them. This is a two step
41 * process (a) dereference the bpf_dtab_netdev object in netdev_map and (b)
42 * check to see if the ifindex is the same as the net_device being removed.
John Fastabend4cc7b952017-08-04 22:02:19 -070043 * When removing the dev a cmpxchg() is used to ensure the correct dev is
44 * removed, in the case of a concurrent update or delete operation it is
45 * possible that the initially referenced dev is no longer in the map. As the
46 * notifier hook walks the map we know that new dev references can not be
47 * added by the user because core infrastructure ensures dev_get_by_index()
48 * calls will fail at this point.
John Fastabend546ac1f2017-07-17 09:28:56 -070049 */
50#include <linux/bpf.h>
John Fastabend546ac1f2017-07-17 09:28:56 -070051#include <linux/filter.h>
John Fastabend546ac1f2017-07-17 09:28:56 -070052
Chenbo Feng6e71b042017-10-18 13:00:22 -070053#define DEV_CREATE_FLAG_MASK \
54 (BPF_F_NUMA_NODE | BPF_F_RDONLY | BPF_F_WRONLY)
55
John Fastabend546ac1f2017-07-17 09:28:56 -070056struct bpf_dtab_netdev {
57 struct net_device *dev;
John Fastabend546ac1f2017-07-17 09:28:56 -070058 struct bpf_dtab *dtab;
Daniel Borkmannaf4d0452017-08-23 01:47:54 +020059 unsigned int bit;
60 struct rcu_head rcu;
John Fastabend546ac1f2017-07-17 09:28:56 -070061};
62
63struct bpf_dtab {
64 struct bpf_map map;
65 struct bpf_dtab_netdev **netdev_map;
Daniel Borkmannaf4d0452017-08-23 01:47:54 +020066 unsigned long __percpu *flush_needed;
John Fastabend2ddf71e2017-07-17 09:30:02 -070067 struct list_head list;
John Fastabend546ac1f2017-07-17 09:28:56 -070068};
69
John Fastabend4cc7b952017-08-04 22:02:19 -070070static DEFINE_SPINLOCK(dev_map_lock);
John Fastabend2ddf71e2017-07-17 09:30:02 -070071static LIST_HEAD(dev_map_list);
72
Daniel Borkmannaf4d0452017-08-23 01:47:54 +020073static u64 dev_map_bitmap_size(const union bpf_attr *attr)
74{
John Fastabend8695a532017-10-19 09:03:52 -070075 return BITS_TO_LONGS((u64) attr->max_entries) * sizeof(unsigned long);
Daniel Borkmannaf4d0452017-08-23 01:47:54 +020076}
77
John Fastabend546ac1f2017-07-17 09:28:56 -070078static struct bpf_map *dev_map_alloc(union bpf_attr *attr)
79{
80 struct bpf_dtab *dtab;
Tobias Klauser582db7e2017-09-18 15:03:46 +020081 int err = -EINVAL;
John Fastabend546ac1f2017-07-17 09:28:56 -070082 u64 cost;
John Fastabend546ac1f2017-07-17 09:28:56 -070083
John Fastabend9ef2a8c2017-10-18 07:11:44 -070084 if (!capable(CAP_NET_ADMIN))
85 return ERR_PTR(-EPERM);
86
John Fastabend546ac1f2017-07-17 09:28:56 -070087 /* check sanity of attributes */
88 if (attr->max_entries == 0 || attr->key_size != 4 ||
Chenbo Feng6e71b042017-10-18 13:00:22 -070089 attr->value_size != 4 || attr->map_flags & ~DEV_CREATE_FLAG_MASK)
John Fastabend546ac1f2017-07-17 09:28:56 -070090 return ERR_PTR(-EINVAL);
91
John Fastabend546ac1f2017-07-17 09:28:56 -070092 dtab = kzalloc(sizeof(*dtab), GFP_USER);
93 if (!dtab)
94 return ERR_PTR(-ENOMEM);
95
96 /* mandatory map attributes */
97 dtab->map.map_type = attr->map_type;
98 dtab->map.key_size = attr->key_size;
99 dtab->map.value_size = attr->value_size;
100 dtab->map.max_entries = attr->max_entries;
101 dtab->map.map_flags = attr->map_flags;
Martin KaFai Lau96eabe72017-08-18 11:28:00 -0700102 dtab->map.numa_node = bpf_map_attr_numa_node(attr);
John Fastabend546ac1f2017-07-17 09:28:56 -0700103
John Fastabend546ac1f2017-07-17 09:28:56 -0700104 /* make sure page count doesn't overflow */
105 cost = (u64) dtab->map.max_entries * sizeof(struct bpf_dtab_netdev *);
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200106 cost += dev_map_bitmap_size(attr) * num_possible_cpus();
John Fastabend546ac1f2017-07-17 09:28:56 -0700107 if (cost >= U32_MAX - PAGE_SIZE)
108 goto free_dtab;
109
110 dtab->map.pages = round_up(cost, PAGE_SIZE) >> PAGE_SHIFT;
111
112 /* if map size is larger than memlock limit, reject it early */
113 err = bpf_map_precharge_memlock(dtab->map.pages);
114 if (err)
115 goto free_dtab;
116
Tobias Klauser582db7e2017-09-18 15:03:46 +0200117 err = -ENOMEM;
118
John Fastabend11393cc2017-07-17 09:29:40 -0700119 /* A per cpu bitfield with a bit per possible net device */
Daniel Borkmann82f8dd22017-10-17 16:55:53 +0200120 dtab->flush_needed = __alloc_percpu_gfp(dev_map_bitmap_size(attr),
121 __alignof__(unsigned long),
122 GFP_KERNEL | __GFP_NOWARN);
John Fastabend11393cc2017-07-17 09:29:40 -0700123 if (!dtab->flush_needed)
124 goto free_dtab;
125
John Fastabend546ac1f2017-07-17 09:28:56 -0700126 dtab->netdev_map = bpf_map_area_alloc(dtab->map.max_entries *
Martin KaFai Lau96eabe72017-08-18 11:28:00 -0700127 sizeof(struct bpf_dtab_netdev *),
128 dtab->map.numa_node);
John Fastabend546ac1f2017-07-17 09:28:56 -0700129 if (!dtab->netdev_map)
130 goto free_dtab;
131
John Fastabend4cc7b952017-08-04 22:02:19 -0700132 spin_lock(&dev_map_lock);
133 list_add_tail_rcu(&dtab->list, &dev_map_list);
134 spin_unlock(&dev_map_lock);
John Fastabend546ac1f2017-07-17 09:28:56 -0700135
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200136 return &dtab->map;
John Fastabend546ac1f2017-07-17 09:28:56 -0700137free_dtab:
John Fastabend11393cc2017-07-17 09:29:40 -0700138 free_percpu(dtab->flush_needed);
John Fastabend546ac1f2017-07-17 09:28:56 -0700139 kfree(dtab);
Tobias Klauser582db7e2017-09-18 15:03:46 +0200140 return ERR_PTR(err);
John Fastabend546ac1f2017-07-17 09:28:56 -0700141}
142
143static void dev_map_free(struct bpf_map *map)
144{
145 struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
John Fastabend11393cc2017-07-17 09:29:40 -0700146 int i, cpu;
John Fastabend546ac1f2017-07-17 09:28:56 -0700147
148 /* At this point bpf_prog->aux->refcnt == 0 and this map->refcnt == 0,
149 * so the programs (can be more than one that used this map) were
150 * disconnected from events. Wait for outstanding critical sections in
151 * these programs to complete. The rcu critical section only guarantees
152 * no further reads against netdev_map. It does __not__ ensure pending
153 * flush operations (if any) are complete.
154 */
Daniel Borkmann274043c2017-08-21 01:48:12 +0200155
156 spin_lock(&dev_map_lock);
157 list_del_rcu(&dtab->list);
158 spin_unlock(&dev_map_lock);
159
John Fastabend546ac1f2017-07-17 09:28:56 -0700160 synchronize_rcu();
161
John Fastabend11393cc2017-07-17 09:29:40 -0700162 /* To ensure all pending flush operations have completed wait for flush
163 * bitmap to indicate all flush_needed bits to be zero on _all_ cpus.
164 * Because the above synchronize_rcu() ensures the map is disconnected
165 * from the program we can assume no new bits will be set.
166 */
167 for_each_online_cpu(cpu) {
168 unsigned long *bitmap = per_cpu_ptr(dtab->flush_needed, cpu);
169
170 while (!bitmap_empty(bitmap, dtab->map.max_entries))
John Fastabend374fb012017-09-08 14:01:10 -0700171 cond_resched();
John Fastabend11393cc2017-07-17 09:29:40 -0700172 }
173
John Fastabend546ac1f2017-07-17 09:28:56 -0700174 for (i = 0; i < dtab->map.max_entries; i++) {
175 struct bpf_dtab_netdev *dev;
176
177 dev = dtab->netdev_map[i];
178 if (!dev)
179 continue;
180
181 dev_put(dev->dev);
182 kfree(dev);
183 }
184
John Fastabend11393cc2017-07-17 09:29:40 -0700185 free_percpu(dtab->flush_needed);
John Fastabend546ac1f2017-07-17 09:28:56 -0700186 bpf_map_area_free(dtab->netdev_map);
187 kfree(dtab);
188}
189
190static int dev_map_get_next_key(struct bpf_map *map, void *key, void *next_key)
191{
192 struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
193 u32 index = key ? *(u32 *)key : U32_MAX;
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200194 u32 *next = next_key;
John Fastabend546ac1f2017-07-17 09:28:56 -0700195
196 if (index >= dtab->map.max_entries) {
197 *next = 0;
198 return 0;
199 }
200
201 if (index == dtab->map.max_entries - 1)
202 return -ENOENT;
John Fastabend546ac1f2017-07-17 09:28:56 -0700203 *next = index + 1;
204 return 0;
205}
206
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200207void __dev_map_insert_ctx(struct bpf_map *map, u32 bit)
John Fastabend11393cc2017-07-17 09:29:40 -0700208{
209 struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
210 unsigned long *bitmap = this_cpu_ptr(dtab->flush_needed);
211
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200212 __set_bit(bit, bitmap);
John Fastabend97f91a72017-07-17 09:29:18 -0700213}
214
John Fastabend11393cc2017-07-17 09:29:40 -0700215/* __dev_map_flush is called from xdp_do_flush_map() which _must_ be signaled
216 * from the driver before returning from its napi->poll() routine. The poll()
217 * routine is called either from busy_poll context or net_rx_action signaled
218 * from NET_RX_SOFTIRQ. Either way the poll routine must complete before the
219 * net device can be torn down. On devmap tear down we ensure the ctx bitmap
220 * is zeroed before completing to ensure all flush operations have completed.
221 */
222void __dev_map_flush(struct bpf_map *map)
223{
224 struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
225 unsigned long *bitmap = this_cpu_ptr(dtab->flush_needed);
226 u32 bit;
227
228 for_each_set_bit(bit, bitmap, map->max_entries) {
229 struct bpf_dtab_netdev *dev = READ_ONCE(dtab->netdev_map[bit]);
230 struct net_device *netdev;
231
232 /* This is possible if the dev entry is removed by user space
233 * between xdp redirect and flush op.
234 */
235 if (unlikely(!dev))
236 continue;
237
John Fastabend11393cc2017-07-17 09:29:40 -0700238 __clear_bit(bit, bitmap);
Daniel Borkmanna5e2da62017-08-24 03:20:11 +0200239 netdev = dev->dev;
240 if (likely(netdev->netdev_ops->ndo_xdp_flush))
241 netdev->netdev_ops->ndo_xdp_flush(netdev);
John Fastabend11393cc2017-07-17 09:29:40 -0700242 }
243}
244
John Fastabend546ac1f2017-07-17 09:28:56 -0700245/* rcu_read_lock (from syscall and BPF contexts) ensures that if a delete and/or
246 * update happens in parallel here a dev_put wont happen until after reading the
247 * ifindex.
248 */
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200249struct net_device *__dev_map_lookup_elem(struct bpf_map *map, u32 key)
John Fastabend546ac1f2017-07-17 09:28:56 -0700250{
251 struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
252 struct bpf_dtab_netdev *dev;
John Fastabend546ac1f2017-07-17 09:28:56 -0700253
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200254 if (key >= map->max_entries)
John Fastabend546ac1f2017-07-17 09:28:56 -0700255 return NULL;
256
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200257 dev = READ_ONCE(dtab->netdev_map[key]);
258 return dev ? dev->dev : NULL;
John Fastabend546ac1f2017-07-17 09:28:56 -0700259}
260
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200261static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
John Fastabend11393cc2017-07-17 09:29:40 -0700262{
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200263 struct net_device *dev = __dev_map_lookup_elem(map, *(u32 *)key);
264
265 return dev ? &dev->ifindex : NULL;
266}
267
268static void dev_map_flush_old(struct bpf_dtab_netdev *dev)
269{
270 if (dev->dev->netdev_ops->ndo_xdp_flush) {
271 struct net_device *fl = dev->dev;
John Fastabend11393cc2017-07-17 09:29:40 -0700272 unsigned long *bitmap;
273 int cpu;
274
275 for_each_online_cpu(cpu) {
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200276 bitmap = per_cpu_ptr(dev->dtab->flush_needed, cpu);
277 __clear_bit(dev->bit, bitmap);
John Fastabend11393cc2017-07-17 09:29:40 -0700278
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200279 fl->netdev_ops->ndo_xdp_flush(dev->dev);
John Fastabend11393cc2017-07-17 09:29:40 -0700280 }
281 }
282}
283
John Fastabend546ac1f2017-07-17 09:28:56 -0700284static void __dev_map_entry_free(struct rcu_head *rcu)
285{
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200286 struct bpf_dtab_netdev *dev;
John Fastabend546ac1f2017-07-17 09:28:56 -0700287
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200288 dev = container_of(rcu, struct bpf_dtab_netdev, rcu);
289 dev_map_flush_old(dev);
290 dev_put(dev->dev);
291 kfree(dev);
John Fastabend546ac1f2017-07-17 09:28:56 -0700292}
293
294static int dev_map_delete_elem(struct bpf_map *map, void *key)
295{
296 struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
297 struct bpf_dtab_netdev *old_dev;
298 int k = *(u32 *)key;
299
300 if (k >= map->max_entries)
301 return -EINVAL;
302
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200303 /* Use call_rcu() here to ensure any rcu critical sections have
304 * completed, but this does not guarantee a flush has happened
John Fastabend546ac1f2017-07-17 09:28:56 -0700305 * yet. Because driver side rcu_read_lock/unlock only protects the
306 * running XDP program. However, for pending flush operations the
307 * dev and ctx are stored in another per cpu map. And additionally,
308 * the driver tear down ensures all soft irqs are complete before
309 * removing the net device in the case of dev_put equals zero.
310 */
311 old_dev = xchg(&dtab->netdev_map[k], NULL);
312 if (old_dev)
313 call_rcu(&old_dev->rcu, __dev_map_entry_free);
314 return 0;
315}
316
317static int dev_map_update_elem(struct bpf_map *map, void *key, void *value,
318 u64 map_flags)
319{
320 struct bpf_dtab *dtab = container_of(map, struct bpf_dtab, map);
321 struct net *net = current->nsproxy->net_ns;
322 struct bpf_dtab_netdev *dev, *old_dev;
323 u32 i = *(u32 *)key;
324 u32 ifindex = *(u32 *)value;
325
326 if (unlikely(map_flags > BPF_EXIST))
327 return -EINVAL;
John Fastabend546ac1f2017-07-17 09:28:56 -0700328 if (unlikely(i >= dtab->map.max_entries))
329 return -E2BIG;
John Fastabend546ac1f2017-07-17 09:28:56 -0700330 if (unlikely(map_flags == BPF_NOEXIST))
331 return -EEXIST;
332
333 if (!ifindex) {
334 dev = NULL;
335 } else {
Martin KaFai Lau96eabe72017-08-18 11:28:00 -0700336 dev = kmalloc_node(sizeof(*dev), GFP_ATOMIC | __GFP_NOWARN,
337 map->numa_node);
John Fastabend546ac1f2017-07-17 09:28:56 -0700338 if (!dev)
339 return -ENOMEM;
340
341 dev->dev = dev_get_by_index(net, ifindex);
342 if (!dev->dev) {
343 kfree(dev);
344 return -EINVAL;
345 }
346
Daniel Borkmannaf4d0452017-08-23 01:47:54 +0200347 dev->bit = i;
John Fastabend546ac1f2017-07-17 09:28:56 -0700348 dev->dtab = dtab;
349 }
350
351 /* Use call_rcu() here to ensure rcu critical sections have completed
352 * Remembering the driver side flush operation will happen before the
353 * net device is removed.
354 */
355 old_dev = xchg(&dtab->netdev_map[i], dev);
356 if (old_dev)
357 call_rcu(&old_dev->rcu, __dev_map_entry_free);
358
359 return 0;
360}
361
362const struct bpf_map_ops dev_map_ops = {
363 .map_alloc = dev_map_alloc,
364 .map_free = dev_map_free,
365 .map_get_next_key = dev_map_get_next_key,
366 .map_lookup_elem = dev_map_lookup_elem,
367 .map_update_elem = dev_map_update_elem,
368 .map_delete_elem = dev_map_delete_elem,
369};
John Fastabend2ddf71e2017-07-17 09:30:02 -0700370
371static int dev_map_notification(struct notifier_block *notifier,
372 ulong event, void *ptr)
373{
374 struct net_device *netdev = netdev_notifier_info_to_dev(ptr);
375 struct bpf_dtab *dtab;
376 int i;
377
378 switch (event) {
379 case NETDEV_UNREGISTER:
John Fastabend4cc7b952017-08-04 22:02:19 -0700380 /* This rcu_read_lock/unlock pair is needed because
381 * dev_map_list is an RCU list AND to ensure a delete
382 * operation does not free a netdev_map entry while we
383 * are comparing it against the netdev being unregistered.
384 */
385 rcu_read_lock();
386 list_for_each_entry_rcu(dtab, &dev_map_list, list) {
John Fastabend2ddf71e2017-07-17 09:30:02 -0700387 for (i = 0; i < dtab->map.max_entries; i++) {
John Fastabend4cc7b952017-08-04 22:02:19 -0700388 struct bpf_dtab_netdev *dev, *odev;
John Fastabend2ddf71e2017-07-17 09:30:02 -0700389
John Fastabend4cc7b952017-08-04 22:02:19 -0700390 dev = READ_ONCE(dtab->netdev_map[i]);
John Fastabend2ddf71e2017-07-17 09:30:02 -0700391 if (!dev ||
392 dev->dev->ifindex != netdev->ifindex)
393 continue;
John Fastabend4cc7b952017-08-04 22:02:19 -0700394 odev = cmpxchg(&dtab->netdev_map[i], dev, NULL);
395 if (dev == odev)
John Fastabend2ddf71e2017-07-17 09:30:02 -0700396 call_rcu(&dev->rcu,
397 __dev_map_entry_free);
398 }
399 }
John Fastabend4cc7b952017-08-04 22:02:19 -0700400 rcu_read_unlock();
John Fastabend2ddf71e2017-07-17 09:30:02 -0700401 break;
402 default:
403 break;
404 }
405 return NOTIFY_OK;
406}
407
408static struct notifier_block dev_map_notifier = {
409 .notifier_call = dev_map_notification,
410};
411
412static int __init dev_map_init(void)
413{
414 register_netdevice_notifier(&dev_map_notifier);
415 return 0;
416}
417
418subsys_initcall(dev_map_init);