tree 4e66ee662fb2bd0c50c8b3aed27e9ce5c508059a
parent 260ef31135c2250ec01aa343192ec2a071b8e05f
author Denys Vlasenko <vda.linux@googlemail.com> 1348623290 +1000
committer Al Viro <viro@zeniv.linux.org.uk> 1348712421 -0400

coredump: prevent double-free on an error path in core dumper

In !CORE_DUMP_USE_REGSET case, if elf_note_info_init fails to allocate
memory for info->fields, it frees already allocated stuff and returns
error to its caller, fill_note_info.  Which in turn returns error to its
caller, elf_core_dump.  Which jumps to cleanup label and calls
free_note_info, which will happily try to free all info->fields again.
BOOM.

This is the fix.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>