commit d3e56c0ad8a2dab7ffd6179b64f00702149e5c9a
author Dan Carpenter <error27@gmail.com> Thu Apr 22 02:50:10 2010 -0700
committer Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> Tue May 11 14:09:10 2010 -0700
tree a8c5343a77cbc2b92978cbdaf30e4425657f6396
parent 7ef9f9a4ee47b8d8ab9519647ba02fc700473be8

wimax: checking ERR_PTR vs null

stch_skb is allocated with wimax_gnl_re_state_change_alloc().  That
function returns ERR_PTRs on failure and doesn't return NULL.

Signed-off-by: Dan Carpenter <error27@gmail.com>

net/wimax/stack.c

diff --git a/net/wimax/stack.c b/net/wimax/stack.c
index 1ed65db..62b1a66 100644
--- a/net/wimax/stack.c
+++ b/net/wimax/stack.c
@@ -315,7 +315,7 @@
 		BUG();
 	}
 	__wimax_state_set(wimax_dev, new_state);
-	if (stch_skb)
+	if (!IS_ERR(stch_skb))
 		wimax_gnl_re_state_change_send(wimax_dev, stch_skb, header);
 out:
 	d_fnend(3, dev, "(wimax_dev %p new_state %u [old %u]) = void\n",