tree 9ccdbb0b59465c7626f53f5b2062744e6dc4ea35
parent 7548e1da8d2d345debb9c0f141c47e4077d6085b
author Colin Ian King <colin.king@canonical.com> 1596215622 +0100
committer Steve French <stfrench@microsoft.com> 1596409226 -0500

cifs: fix double free error on share and prefix

Currently if the call dfs_cache_get_tgt_share fails we cannot
fully guarantee that share and prefix are set to NULL and the
next iteration of the loop can end up potentially double freeing
these pointers. Since the semantics of dfs_cache_get_tgt_share
are ambiguous for failure cases with the setting of share and
prefix (currently now and the possibly the future), it seems
prudent to set the pointers to NULL when the objects are
free'd to avoid any double frees.

Addresses-Coverity: ("Double free")
Fixes: 96296c946a2a ("cifs: handle RESP_GET_DFS_REFERRAL.PathConsumed in reconnect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>