commit c5561700c9cb951ec3a33a0914c840423b09d7c9
author John Johansen <john.johansen@canonical.com> Mon Jul 31 23:44:37 2017 -0700
committer John Johansen <john.johansen@canonical.com> Fri Sep 22 13:00:57 2017 -0700
tree fc10e10d924db529f78b32376ab5d26f3997a5e0
parent 5d314a81eca29b01939930c1c596dfa44937e970

apparmor: Redundant condition: prev_ns. in [label.c:1498]

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>

security/apparmor/label.c

diff --git a/security/apparmor/label.c b/security/apparmor/label.c
index e052eab..e324f4d 100644
--- a/security/apparmor/label.c
+++ b/security/apparmor/label.c
@@ -1495,7 +1495,7 @@ static int aa_profile_snxprint(char *str, size_t size, struct aa_ns *view,
 		view = profiles_ns(profile);
 
 	if (view != profile->ns &&
-	    (!prev_ns || (prev_ns && *prev_ns != profile->ns))) {
+	    (!prev_ns || (*prev_ns != profile->ns))) {
 		if (prev_ns)
 			*prev_ns = profile->ns;
 		ns_name = aa_ns_name(view, profile->ns,