| commit | ab198a7aab65d6fcdbde082ff59a790dbf7e08f4 | [log] [tgz] |
|---|---|---|
| author | Sean Paul <seanpaul@chromium.org> | Thu Oct 10 14:17:44 2019 -0400 |
| committer | Sean Paul <seanpaul@chromium.org> | Thu Oct 10 14:33:12 2019 -0400 |
| tree | 016ff3a0302db2b21abce1afe654ab98d0e2c54f | |
| parent | 8fbd534b7248f5d0311d9dbfd7b4749317e4395a [diff] |
drm/msm: Sanitize the modeset_is_locked checks in dpu As Daniel mentions in his email [1], non-blocking commits don't hold the modeset locks, so we can safely access state as long as these functions are in the commit path. So remove the WARN_ON in dpu_kms_encoder_enable. In dpu_crtc_get_intf_mode, things are a bit more complicated. So keep the WARN_ON, but add a comment explaining the situation and hope someone comes along and fixes the issue. [1]- https://lists.freedesktop.org/archives/dri-devel/2019-October/239441.html Link to v1: https://patchwork.freedesktop.org/patch/msgid/20191010151351.126735-1-sean@poorly.run Changes in v2: - Restored the WARN_ON in get_intf_mode and added a clarifying comment (Daniel) Fixes: 1dfdb0e107db ("drm/msm: dpu: Add modeset lock checks where applicable") Cc: Jeykumar Sankaran <jsanka@codeaurora.org> Cc: Rob Clark <robdclark@chromium.org> Suggested-by: Daniel Vetter <daniel@ffwll.ch> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20191010181801.186069-1-sean@poorly.run