tree 750fd56c7f4424a9d46bede80b82a2feaf5d09d7
parent b4c18c18ebf7cf1e602af88c12ef9cb0d6e5ce51
author Oliver Barta <oliver.barta@aptiv.com> 1644310005 +0100
committer Mark Brown <broonie@kernel.org> 1644327468 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmICciwACgkQJNaLcl1U
 h9AVjQf+KxtgGPHQQruCu0FWWaIRGLs3kEEkopl376f7YEpoBVX7zq58MZVeNq0c
 DRcXKXXMzJZPNjxLojh6wJAr0p32fB3newKABhN7aR6t9KVkb2UDRRsZLVPMbM/8
 msA8iUN/kjORINBz+kdRw4ZuGiHxlOKaGH32178acIU72GhIj2RJYt+Lhu8Pafce
 IdnqMQryDP3pNzspWAbCrb84IRfQGkxrmve4C7zv/rc7VZipb9BoKLlcQRjJQfuh
 CJe7pJtx6MDTlhaxwWw4ss8GzAuBB4gkWNocSKStS18/O9DCyeR5rgH7xwuCbceQ
 lunUFh8Eq86UsfHhCieI/3B3u34p7w==
 =fQEb
 -----END PGP SIGNATURE-----

regulator: core: fix false positive in regulator_late_cleanup()

The check done by regulator_late_cleanup() to detect whether a regulator
is on was inconsistent with the check done by _regulator_is_enabled().
While _regulator_is_enabled() takes the enable GPIO into account,
regulator_late_cleanup() was not doing that.

This resulted in a false positive, e.g. when a GPIO-controlled fixed
regulator was used, which was not enabled at boot time, e.g.

reg_disp_1v2: reg_disp_1v2 {
	compatible = "regulator-fixed";
	regulator-name = "display_1v2";
	regulator-min-microvolt = <1200000>;
	regulator-max-microvolt = <1200000>;
	gpio = <&tlmm 148 0>;
	enable-active-high;
};

Such regulator doesn't have an is_enabled() operation. Nevertheless
it's state can be determined based on the enable GPIO. The check in
regulator_late_cleanup() wrongly assumed that the regulator is on and
tried to disable it.

Signed-off-by: Oliver Barta <oliver.barta@aptiv.com>
Link: https://lore.kernel.org/r/20220208084645.8686-1-oliver.barta@aptiv.com
Signed-off-by: Mark Brown <broonie@kernel.org>