commit 1c17a353c5a8346b1ce128c60ffb862d156f7e7e
author Julia Lawall <julia.lawall@lip6.fr> Mon Jan 25 16:21:54 2016 +0100
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> Wed Feb 03 13:36:04 2016 -0800
tree d48dbfd596cd45f4e6baa5a2c6688014efbe8403
parent b4a90d04ac79349799f65dfd7fa30b2aac6b2a4d

usb: gadget: rndis: fix itnull.cocci warnings

The index variable of list_for_each_entry_safe is an offset from a list
pointer, and thus should not be NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Geliang Tang <geliangtang@163.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/usb/gadget/function/rndis.c

diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
index 34a76db..943c21a 100644
--- a/drivers/usb/gadget/function/rndis.c
+++ b/drivers/usb/gadget/function/rndis.c
@@ -1009,7 +1009,7 @@
 	rndis_resp_t *r, *n;
 
 	list_for_each_entry_safe(r, n, &params->resp_queue, list) {
-		if (r && r->buf == buf) {
+		if (r->buf == buf) {
 			list_del(&r->list);
 			kfree(r);
 		}