[GFS2] [-mm patch] fs/gfs2/: possible cleanups
This patch contains the following possible cleanups:
- make needlessly global code static
- #if 0 unused functions
- remove the following global function that was both unused and
unimplemented:
- super.c: gfs2_do_upgrade()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
diff --git a/fs/gfs2/ondisk.c b/fs/gfs2/ondisk.c
index acfc944..b11e659 100644
--- a/fs/gfs2/ondisk.c
+++ b/fs/gfs2/ondisk.c
@@ -28,7 +28,7 @@
* @count: the number of bytes
*
*/
-
+#if 0
static void print_array(char *title, char *buf, int count)
{
int x;
@@ -42,6 +42,7 @@
if (x % 16)
printk("\n");
}
+#endif /* 0 */
/*
* gfs2_xxx_in - read in an xxx struct
@@ -72,7 +73,7 @@
str->no_addr = cpu_to_be64(no->no_addr);
}
-void gfs2_inum_print(struct gfs2_inum *no)
+static void gfs2_inum_print(struct gfs2_inum *no)
{
pv(no, no_formal_ino, "%llu");
pv(no, no_addr, "%llu");
@@ -96,7 +97,7 @@
str->mh_format = cpu_to_be32(mh->mh_format);
}
-void gfs2_meta_header_print(struct gfs2_meta_header *mh)
+static void gfs2_meta_header_print(struct gfs2_meta_header *mh)
{
pv(mh, mh_magic, "0x%.8X");
pv(mh, mh_type, "%u");
@@ -121,6 +122,7 @@
memcpy(sb->sb_locktable, str->sb_locktable, GFS2_LOCKNAME_LEN);
}
+#if 0
void gfs2_sb_print(struct gfs2_sb *sb)
{
gfs2_meta_header_print(&sb->sb_header);
@@ -136,6 +138,7 @@
pv(sb, sb_lockproto, "%s");
pv(sb, sb_locktable, "%s");
}
+#endif /* 0 */
void gfs2_rindex_in(struct gfs2_rindex *ri, char *buf)
{
@@ -149,6 +152,7 @@
}
+#if 0
void gfs2_rindex_out(struct gfs2_rindex *ri, char *buf)
{
struct gfs2_rindex *str = (struct gfs2_rindex *)buf;
@@ -163,6 +167,8 @@
memset(str->ri_reserved, 0, sizeof(str->ri_reserved));
}
+#endif /* 0 */
+
void gfs2_rindex_print(struct gfs2_rindex *ri)
{
pv(ri, ri_addr, "%llu");
@@ -196,6 +202,7 @@
memset(&str->rg_reserved, 0, sizeof(str->rg_reserved));
}
+#if 0
void gfs2_rgrp_print(struct gfs2_rgrp *rg)
{
gfs2_meta_header_print(&rg->rg_header);
@@ -205,6 +212,7 @@
pa(rg, rg_reserved, 36);
}
+#endif /* 0 */
void gfs2_quota_in(struct gfs2_quota *qu, char *buf)
{
@@ -215,6 +223,8 @@
qu->qu_value = be64_to_cpu(str->qu_value);
}
+#if 0
+
void gfs2_quota_out(struct gfs2_quota *qu, char *buf)
{
struct gfs2_quota *str = (struct gfs2_quota *)buf;
@@ -231,6 +241,8 @@
pv(qu, qu_value, "%lld");
}
+#endif /* 0 */
+
void gfs2_dinode_in(struct gfs2_dinode *di, char *buf)
{
struct gfs2_dinode *str = (struct gfs2_dinode *)buf;
@@ -327,6 +339,8 @@
pv(di, di_eattr, "%llu");
}
+#if 0
+
void gfs2_dirent_print(struct gfs2_dirent *de, char *name)
{
char buf[GFS2_FNAMESIZE + 1];
@@ -394,6 +408,8 @@
printk(KERN_INFO " name = %s\n", buf);
}
+#endif /* 0 */
+
void gfs2_log_header_in(struct gfs2_log_header *lh, char *buf)
{
struct gfs2_log_header *str = (struct gfs2_log_header *)buf;
@@ -406,6 +422,8 @@
lh->lh_hash = be32_to_cpu(str->lh_hash);
}
+#if 0
+
void gfs2_log_header_print(struct gfs2_log_header *lh)
{
gfs2_meta_header_print(&lh->lh_header);
@@ -427,6 +445,8 @@
pa(ld, ld_reserved, 32);
}
+#endif /* 0 */
+
void gfs2_inum_range_in(struct gfs2_inum_range *ir, char *buf)
{
struct gfs2_inum_range *str = (struct gfs2_inum_range *)buf;
@@ -443,11 +463,13 @@
str->ir_length = cpu_to_be64(ir->ir_length);
}
+#if 0
void gfs2_inum_range_print(struct gfs2_inum_range *ir)
{
pv(ir, ir_start, "%llu");
pv(ir, ir_length, "%llu");
}
+#endif /* 0 */
void gfs2_statfs_change_in(struct gfs2_statfs_change *sc, char *buf)
{
@@ -467,12 +489,14 @@
str->sc_dinodes = cpu_to_be64(sc->sc_dinodes);
}
+#if 0
void gfs2_statfs_change_print(struct gfs2_statfs_change *sc)
{
pv(sc, sc_total, "%lld");
pv(sc, sc_free, "%lld");
pv(sc, sc_dinodes, "%lld");
}
+#endif /* 0 */
void gfs2_unlinked_tag_in(struct gfs2_unlinked_tag *ut, char *buf)
{
@@ -491,12 +515,16 @@
str->__pad = 0;
}
+#if 0
+
void gfs2_unlinked_tag_print(struct gfs2_unlinked_tag *ut)
{
gfs2_inum_print(&ut->ut_inum);
pv(ut, ut_flags, "%u");
}
+#endif /* 0 */
+
void gfs2_quota_change_in(struct gfs2_quota_change *qc, char *buf)
{
struct gfs2_quota_change *str = (struct gfs2_quota_change *)buf;
@@ -506,6 +534,8 @@
qc->qc_id = be32_to_cpu(str->qc_id);
}
+#if 0
+
void gfs2_quota_change_print(struct gfs2_quota_change *qc)
{
pv(qc, qc_change, "%lld");
@@ -513,5 +543,5 @@
pv(qc, qc_id, "%u");
}
-
+#endif /* 0 */