Dave Chinner | 0b61f8a | 2018-06-05 19:42:14 -0700 | [diff] [blame] | 1 | // SPDX-License-Identifier: GPL-2.0+ |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 2 | /* |
| 3 | * Copyright (C) 2017 Oracle. All Rights Reserved. |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 4 | * Author: Darrick J. Wong <darrick.wong@oracle.com> |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 5 | */ |
| 6 | #include "xfs.h" |
| 7 | #include "xfs_fs.h" |
| 8 | #include "xfs_shared.h" |
| 9 | #include "xfs_format.h" |
| 10 | #include "xfs_trans_resv.h" |
| 11 | #include "xfs_mount.h" |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 12 | #include "xfs_log_format.h" |
| 13 | #include "xfs_trans.h" |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 14 | #include "xfs_inode.h" |
| 15 | #include "xfs_icache.h" |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 16 | #include "xfs_dir2.h" |
| 17 | #include "xfs_dir2_priv.h" |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 18 | #include "scrub/scrub.h" |
| 19 | #include "scrub/common.h" |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 20 | #include "scrub/dabtree.h" |
| 21 | |
| 22 | /* Set us up to scrub directories. */ |
| 23 | int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 24 | xchk_setup_directory( |
Darrick J. Wong | 1d8a748 | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 25 | struct xfs_scrub *sc, |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 26 | struct xfs_inode *ip) |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 27 | { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 28 | return xchk_setup_inode_contents(sc, ip, 0); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 29 | } |
| 30 | |
| 31 | /* Directories */ |
| 32 | |
| 33 | /* Scrub a directory entry. */ |
| 34 | |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 35 | struct xchk_dir_ctx { |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 36 | /* VFS fill-directory iterator */ |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 37 | struct dir_context dir_iter; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 38 | |
Darrick J. Wong | 1d8a748 | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 39 | struct xfs_scrub *sc; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 40 | }; |
| 41 | |
| 42 | /* Check that an inode's mode matches a given DT_ type. */ |
| 43 | STATIC int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 44 | xchk_dir_check_ftype( |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 45 | struct xchk_dir_ctx *sdc, |
| 46 | xfs_fileoff_t offset, |
| 47 | xfs_ino_t inum, |
| 48 | int dtype) |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 49 | { |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 50 | struct xfs_mount *mp = sdc->sc->mp; |
| 51 | struct xfs_inode *ip; |
| 52 | int ino_dtype; |
| 53 | int error = 0; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 54 | |
| 55 | if (!xfs_sb_version_hasftype(&mp->m_sb)) { |
| 56 | if (dtype != DT_UNKNOWN && dtype != DT_DIR) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 57 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 58 | offset); |
| 59 | goto out; |
| 60 | } |
| 61 | |
| 62 | /* |
| 63 | * Grab the inode pointed to by the dirent. We release the |
| 64 | * inode before we cancel the scrub transaction. Since we're |
| 65 | * don't know a priori that releasing the inode won't trigger |
| 66 | * eofblocks cleanup (which allocates what would be a nested |
| 67 | * transaction), we can't use DONTCACHE here because DONTCACHE |
| 68 | * inodes can trigger immediate inactive cleanup of the inode. |
| 69 | */ |
| 70 | error = xfs_iget(mp, sdc->sc->tp, inum, 0, 0, &ip); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 71 | if (!xchk_fblock_xref_process_error(sdc->sc, XFS_DATA_FORK, offset, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 72 | &error)) |
| 73 | goto out; |
| 74 | |
| 75 | /* Convert mode to the DT_* values that dir_emit uses. */ |
| 76 | ino_dtype = xfs_dir3_get_dtype(mp, |
| 77 | xfs_mode_to_ftype(VFS_I(ip)->i_mode)); |
| 78 | if (ino_dtype != dtype) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 79 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, offset); |
Darrick J. Wong | 44a8736 | 2018-07-25 12:52:32 -0700 | [diff] [blame] | 80 | xfs_irele(ip); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 81 | out: |
| 82 | return error; |
| 83 | } |
| 84 | |
| 85 | /* |
| 86 | * Scrub a single directory entry. |
| 87 | * |
| 88 | * We use the VFS directory iterator (i.e. readdir) to call this |
| 89 | * function for every directory entry in a directory. Once we're here, |
| 90 | * we check the inode number to make sure it's sane, then we check that |
| 91 | * we can look up this filename. Finally, we check the ftype. |
| 92 | */ |
| 93 | STATIC int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 94 | xchk_dir_actor( |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 95 | struct dir_context *dir_iter, |
| 96 | const char *name, |
| 97 | int namelen, |
| 98 | loff_t pos, |
| 99 | u64 ino, |
| 100 | unsigned type) |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 101 | { |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 102 | struct xfs_mount *mp; |
| 103 | struct xfs_inode *ip; |
| 104 | struct xchk_dir_ctx *sdc; |
| 105 | struct xfs_name xname; |
| 106 | xfs_ino_t lookup_ino; |
| 107 | xfs_dablk_t offset; |
| 108 | int error = 0; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 109 | |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 110 | sdc = container_of(dir_iter, struct xchk_dir_ctx, dir_iter); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 111 | ip = sdc->sc->ip; |
| 112 | mp = ip->i_mount; |
| 113 | offset = xfs_dir2_db_to_da(mp->m_dir_geo, |
| 114 | xfs_dir2_dataptr_to_db(mp->m_dir_geo, pos)); |
| 115 | |
Darrick J. Wong | 8ef34723 | 2019-11-05 15:33:56 -0800 | [diff] [blame] | 116 | if (xchk_should_terminate(sdc->sc, &error)) |
| 117 | return error; |
| 118 | |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 119 | /* Does this inode number make sense? */ |
| 120 | if (!xfs_verify_dir_ino(mp, ino)) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 121 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, offset); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 122 | goto out; |
| 123 | } |
| 124 | |
Darrick J. Wong | e5d7d51 | 2019-02-01 09:08:54 -0800 | [diff] [blame] | 125 | /* Does this name make sense? */ |
| 126 | if (!xfs_dir2_namecheck(name, namelen)) { |
| 127 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, offset); |
| 128 | goto out; |
| 129 | } |
| 130 | |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 131 | if (!strncmp(".", name, namelen)) { |
| 132 | /* If this is "." then check that the inum matches the dir. */ |
| 133 | if (xfs_sb_version_hasftype(&mp->m_sb) && type != DT_DIR) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 134 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 135 | offset); |
| 136 | if (ino != ip->i_ino) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 137 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 138 | offset); |
| 139 | } else if (!strncmp("..", name, namelen)) { |
| 140 | /* |
| 141 | * If this is ".." in the root inode, check that the inum |
| 142 | * matches this dir. |
| 143 | */ |
| 144 | if (xfs_sb_version_hasftype(&mp->m_sb) && type != DT_DIR) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 145 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 146 | offset); |
| 147 | if (ip->i_ino == mp->m_sb.sb_rootino && ino != ip->i_ino) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 148 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 149 | offset); |
| 150 | } |
| 151 | |
| 152 | /* Verify that we can look up this name by hash. */ |
| 153 | xname.name = name; |
| 154 | xname.len = namelen; |
| 155 | xname.type = XFS_DIR3_FT_UNKNOWN; |
| 156 | |
| 157 | error = xfs_dir_lookup(sdc->sc->tp, ip, &xname, &lookup_ino, NULL); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 158 | if (!xchk_fblock_process_error(sdc->sc, XFS_DATA_FORK, offset, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 159 | &error)) |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 160 | goto out; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 161 | if (lookup_ino != ino) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 162 | xchk_fblock_set_corrupt(sdc->sc, XFS_DATA_FORK, offset); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 163 | goto out; |
| 164 | } |
| 165 | |
| 166 | /* Verify the file type. This function absorbs error codes. */ |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 167 | error = xchk_dir_check_ftype(sdc, offset, lookup_ino, type); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 168 | if (error) |
| 169 | goto out; |
| 170 | out: |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 171 | /* |
| 172 | * A negative error code returned here is supposed to cause the |
| 173 | * dir_emit caller (xfs_readdir) to abort the directory iteration |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 174 | * and return zero to xchk_directory. |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 175 | */ |
| 176 | if (error == 0 && sdc->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 177 | return -EFSCORRUPTED; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 178 | return error; |
| 179 | } |
| 180 | |
| 181 | /* Scrub a directory btree record. */ |
| 182 | STATIC int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 183 | xchk_dir_rec( |
| 184 | struct xchk_da_btree *ds, |
Christoph Hellwig | 649d9d9 | 2019-11-08 14:52:07 -0800 | [diff] [blame] | 185 | int level) |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 186 | { |
Christoph Hellwig | 649d9d9 | 2019-11-08 14:52:07 -0800 | [diff] [blame] | 187 | struct xfs_da_state_blk *blk = &ds->state->path.blk[level]; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 188 | struct xfs_mount *mp = ds->state->mp; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 189 | struct xfs_inode *dp = ds->dargs.dp; |
Christoph Hellwig | d73e1ce | 2019-11-08 15:05:38 -0800 | [diff] [blame] | 190 | struct xfs_da_geometry *geo = mp->m_dir_geo; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 191 | struct xfs_dir2_data_entry *dent; |
| 192 | struct xfs_buf *bp; |
Christoph Hellwig | 649d9d9 | 2019-11-08 14:52:07 -0800 | [diff] [blame] | 193 | struct xfs_dir2_leaf_entry *ent; |
Christoph Hellwig | 5c07212 | 2019-11-08 15:05:36 -0800 | [diff] [blame] | 194 | unsigned int end; |
Christoph Hellwig | 4c037dd | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 195 | unsigned int iter_off; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 196 | xfs_ino_t ino; |
| 197 | xfs_dablk_t rec_bno; |
| 198 | xfs_dir2_db_t db; |
| 199 | xfs_dir2_data_aoff_t off; |
| 200 | xfs_dir2_dataptr_t ptr; |
| 201 | xfs_dahash_t calc_hash; |
| 202 | xfs_dahash_t hash; |
Christoph Hellwig | 787b089 | 2019-11-08 14:57:50 -0800 | [diff] [blame] | 203 | struct xfs_dir3_icleaf_hdr hdr; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 204 | unsigned int tag; |
| 205 | int error; |
| 206 | |
Christoph Hellwig | 649d9d9 | 2019-11-08 14:52:07 -0800 | [diff] [blame] | 207 | ASSERT(blk->magic == XFS_DIR2_LEAF1_MAGIC || |
| 208 | blk->magic == XFS_DIR2_LEAFN_MAGIC); |
| 209 | |
Christoph Hellwig | 787b089 | 2019-11-08 14:57:50 -0800 | [diff] [blame] | 210 | xfs_dir2_leaf_hdr_from_disk(mp, &hdr, blk->bp->b_addr); |
| 211 | ent = hdr.ents + blk->index; |
Christoph Hellwig | 649d9d9 | 2019-11-08 14:52:07 -0800 | [diff] [blame] | 212 | |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 213 | /* Check the hash of the entry. */ |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 214 | error = xchk_da_btree_hash(ds, level, &ent->hashval); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 215 | if (error) |
| 216 | goto out; |
| 217 | |
| 218 | /* Valid hash pointer? */ |
| 219 | ptr = be32_to_cpu(ent->address); |
| 220 | if (ptr == 0) |
| 221 | return 0; |
| 222 | |
| 223 | /* Find the directory entry's location. */ |
Christoph Hellwig | d73e1ce | 2019-11-08 15:05:38 -0800 | [diff] [blame] | 224 | db = xfs_dir2_dataptr_to_db(geo, ptr); |
| 225 | off = xfs_dir2_dataptr_to_off(geo, ptr); |
| 226 | rec_bno = xfs_dir2_db_to_da(geo, db); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 227 | |
Christoph Hellwig | d73e1ce | 2019-11-08 15:05:38 -0800 | [diff] [blame] | 228 | if (rec_bno >= geo->leafblk) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 229 | xchk_da_set_corrupt(ds, level); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 230 | goto out; |
| 231 | } |
Christoph Hellwig | cd2c9f1 | 2019-11-20 09:46:04 -0800 | [diff] [blame] | 232 | error = xfs_dir3_data_read(ds->dargs.trans, dp, rec_bno, |
| 233 | XFS_DABUF_MAP_HOLE_OK, &bp); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 234 | if (!xchk_fblock_process_error(ds->sc, XFS_DATA_FORK, rec_bno, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 235 | &error)) |
| 236 | goto out; |
| 237 | if (!bp) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 238 | xchk_fblock_set_corrupt(ds->sc, XFS_DATA_FORK, rec_bno); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 239 | goto out; |
| 240 | } |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 241 | xchk_buffer_recheck(ds->sc, bp); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 242 | |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 243 | if (ds->sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 244 | goto out_relse; |
| 245 | |
Christoph Hellwig | 4c037dd | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 246 | dent = bp->b_addr + off; |
Darrick J. Wong | ce92d29 | 2018-01-16 18:54:12 -0800 | [diff] [blame] | 247 | |
| 248 | /* Make sure we got a real directory entry. */ |
Christoph Hellwig | d73e1ce | 2019-11-08 15:05:38 -0800 | [diff] [blame] | 249 | iter_off = geo->data_entry_offset; |
| 250 | end = xfs_dir3_data_end_offset(geo, bp->b_addr); |
Christoph Hellwig | 5c07212 | 2019-11-08 15:05:36 -0800 | [diff] [blame] | 251 | if (!end) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 252 | xchk_fblock_set_corrupt(ds->sc, XFS_DATA_FORK, rec_bno); |
Darrick J. Wong | ce92d29 | 2018-01-16 18:54:12 -0800 | [diff] [blame] | 253 | goto out_relse; |
| 254 | } |
Christoph Hellwig | 4c037dd | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 255 | for (;;) { |
| 256 | struct xfs_dir2_data_entry *dep = bp->b_addr + iter_off; |
| 257 | struct xfs_dir2_data_unused *dup = bp->b_addr + iter_off; |
Darrick J. Wong | ce92d29 | 2018-01-16 18:54:12 -0800 | [diff] [blame] | 258 | |
Christoph Hellwig | 5c07212 | 2019-11-08 15:05:36 -0800 | [diff] [blame] | 259 | if (iter_off >= end) { |
Christoph Hellwig | 4c037dd | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 260 | xchk_fblock_set_corrupt(ds->sc, XFS_DATA_FORK, rec_bno); |
| 261 | goto out_relse; |
| 262 | } |
| 263 | |
Darrick J. Wong | ce92d29 | 2018-01-16 18:54:12 -0800 | [diff] [blame] | 264 | if (be16_to_cpu(dup->freetag) == XFS_DIR2_DATA_FREE_TAG) { |
Christoph Hellwig | 4c037dd | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 265 | iter_off += be16_to_cpu(dup->length); |
Darrick J. Wong | ce92d29 | 2018-01-16 18:54:12 -0800 | [diff] [blame] | 266 | continue; |
| 267 | } |
Darrick J. Wong | ce92d29 | 2018-01-16 18:54:12 -0800 | [diff] [blame] | 268 | if (dep == dent) |
| 269 | break; |
Christoph Hellwig | fdbb8c5 | 2019-11-08 15:05:37 -0800 | [diff] [blame] | 270 | iter_off += xfs_dir2_data_entsize(mp, dep->namelen); |
Darrick J. Wong | ce92d29 | 2018-01-16 18:54:12 -0800 | [diff] [blame] | 271 | } |
| 272 | |
| 273 | /* Retrieve the entry, sanity check it, and compare hashes. */ |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 274 | ino = be64_to_cpu(dent->inumber); |
| 275 | hash = be32_to_cpu(ent->hashval); |
Christoph Hellwig | 7e8ae7bd | 2019-11-08 15:05:37 -0800 | [diff] [blame] | 276 | tag = be16_to_cpup(xfs_dir2_data_entry_tag_p(mp, dent)); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 277 | if (!xfs_verify_dir_ino(mp, ino) || tag != off) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 278 | xchk_fblock_set_corrupt(ds->sc, XFS_DATA_FORK, rec_bno); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 279 | if (dent->namelen == 0) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 280 | xchk_fblock_set_corrupt(ds->sc, XFS_DATA_FORK, rec_bno); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 281 | goto out_relse; |
| 282 | } |
| 283 | calc_hash = xfs_da_hashname(dent->name, dent->namelen); |
| 284 | if (calc_hash != hash) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 285 | xchk_fblock_set_corrupt(ds->sc, XFS_DATA_FORK, rec_bno); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 286 | |
| 287 | out_relse: |
| 288 | xfs_trans_brelse(ds->dargs.trans, bp); |
| 289 | out: |
| 290 | return error; |
| 291 | } |
| 292 | |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 293 | /* |
| 294 | * Is this unused entry either in the bestfree or smaller than all of |
| 295 | * them? We've already checked that the bestfrees are sorted longest to |
| 296 | * shortest, and that there aren't any bogus entries. |
| 297 | */ |
| 298 | STATIC void |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 299 | xchk_directory_check_free_entry( |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 300 | struct xfs_scrub *sc, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 301 | xfs_dablk_t lblk, |
| 302 | struct xfs_dir2_data_free *bf, |
| 303 | struct xfs_dir2_data_unused *dup) |
| 304 | { |
| 305 | struct xfs_dir2_data_free *dfp; |
| 306 | unsigned int dup_length; |
| 307 | |
| 308 | dup_length = be16_to_cpu(dup->length); |
| 309 | |
| 310 | /* Unused entry is shorter than any of the bestfrees */ |
| 311 | if (dup_length < be16_to_cpu(bf[XFS_DIR2_DATA_FD_COUNT - 1].length)) |
| 312 | return; |
| 313 | |
| 314 | for (dfp = &bf[XFS_DIR2_DATA_FD_COUNT - 1]; dfp >= bf; dfp--) |
| 315 | if (dup_length == be16_to_cpu(dfp->length)) |
| 316 | return; |
| 317 | |
| 318 | /* Unused entry should be in the bestfrees but wasn't found. */ |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 319 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 320 | } |
| 321 | |
| 322 | /* Check free space info in a directory data block. */ |
| 323 | STATIC int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 324 | xchk_directory_data_bestfree( |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 325 | struct xfs_scrub *sc, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 326 | xfs_dablk_t lblk, |
| 327 | bool is_block) |
| 328 | { |
| 329 | struct xfs_dir2_data_unused *dup; |
| 330 | struct xfs_dir2_data_free *dfp; |
| 331 | struct xfs_buf *bp; |
| 332 | struct xfs_dir2_data_free *bf; |
| 333 | struct xfs_mount *mp = sc->mp; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 334 | u16 tag; |
| 335 | unsigned int nr_bestfrees = 0; |
| 336 | unsigned int nr_frees = 0; |
| 337 | unsigned int smallest_bestfree; |
| 338 | int newlen; |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 339 | unsigned int offset; |
| 340 | unsigned int end; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 341 | int error; |
| 342 | |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 343 | if (is_block) { |
| 344 | /* dir block format */ |
| 345 | if (lblk != XFS_B_TO_FSBT(mp, XFS_DIR2_DATA_OFFSET)) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 346 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 347 | error = xfs_dir3_block_read(sc->tp, sc->ip, &bp); |
| 348 | } else { |
| 349 | /* dir data format */ |
Christoph Hellwig | cd2c9f1 | 2019-11-20 09:46:04 -0800 | [diff] [blame] | 350 | error = xfs_dir3_data_read(sc->tp, sc->ip, lblk, 0, &bp); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 351 | } |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 352 | if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, lblk, &error)) |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 353 | goto out; |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 354 | xchk_buffer_recheck(sc, bp); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 355 | |
| 356 | /* XXX: Check xfs_dir3_data_hdr.pad is zero once we start setting it. */ |
| 357 | |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 358 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 359 | goto out_buf; |
| 360 | |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 361 | /* Do the bestfrees correspond to actual free space? */ |
Christoph Hellwig | 1848b60 | 2019-11-08 15:05:39 -0800 | [diff] [blame] | 362 | bf = xfs_dir2_data_bestfree_p(mp, bp->b_addr); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 363 | smallest_bestfree = UINT_MAX; |
| 364 | for (dfp = &bf[0]; dfp < &bf[XFS_DIR2_DATA_FD_COUNT]; dfp++) { |
| 365 | offset = be16_to_cpu(dfp->offset); |
| 366 | if (offset == 0) |
| 367 | continue; |
| 368 | if (offset >= mp->m_dir_geo->blksize) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 369 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 370 | goto out_buf; |
| 371 | } |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 372 | dup = bp->b_addr + offset; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 373 | tag = be16_to_cpu(*xfs_dir2_data_unused_tag_p(dup)); |
| 374 | |
| 375 | /* bestfree doesn't match the entry it points at? */ |
| 376 | if (dup->freetag != cpu_to_be16(XFS_DIR2_DATA_FREE_TAG) || |
| 377 | be16_to_cpu(dup->length) != be16_to_cpu(dfp->length) || |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 378 | tag != offset) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 379 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 380 | goto out_buf; |
| 381 | } |
| 382 | |
| 383 | /* bestfree records should be ordered largest to smallest */ |
| 384 | if (smallest_bestfree < be16_to_cpu(dfp->length)) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 385 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 386 | goto out_buf; |
| 387 | } |
| 388 | |
| 389 | smallest_bestfree = be16_to_cpu(dfp->length); |
| 390 | nr_bestfrees++; |
| 391 | } |
| 392 | |
| 393 | /* Make sure the bestfrees are actually the best free spaces. */ |
Christoph Hellwig | d73e1ce | 2019-11-08 15:05:38 -0800 | [diff] [blame] | 394 | offset = mp->m_dir_geo->data_entry_offset; |
Christoph Hellwig | 5c07212 | 2019-11-08 15:05:36 -0800 | [diff] [blame] | 395 | end = xfs_dir3_data_end_offset(mp->m_dir_geo, bp->b_addr); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 396 | |
| 397 | /* Iterate the entries, stopping when we hit or go past the end. */ |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 398 | while (offset < end) { |
| 399 | dup = bp->b_addr + offset; |
| 400 | |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 401 | /* Skip real entries */ |
| 402 | if (dup->freetag != cpu_to_be16(XFS_DIR2_DATA_FREE_TAG)) { |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 403 | struct xfs_dir2_data_entry *dep = bp->b_addr + offset; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 404 | |
Christoph Hellwig | fdbb8c5 | 2019-11-08 15:05:37 -0800 | [diff] [blame] | 405 | newlen = xfs_dir2_data_entsize(mp, dep->namelen); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 406 | if (newlen <= 0) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 407 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 408 | lblk); |
| 409 | goto out_buf; |
| 410 | } |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 411 | offset += newlen; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 412 | continue; |
| 413 | } |
| 414 | |
| 415 | /* Spot check this free entry */ |
| 416 | tag = be16_to_cpu(*xfs_dir2_data_unused_tag_p(dup)); |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 417 | if (tag != offset) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 418 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 419 | goto out_buf; |
| 420 | } |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 421 | |
| 422 | /* |
| 423 | * Either this entry is a bestfree or it's smaller than |
| 424 | * any of the bestfrees. |
| 425 | */ |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 426 | xchk_directory_check_free_entry(sc, lblk, bf, dup); |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 427 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 428 | goto out_buf; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 429 | |
| 430 | /* Move on. */ |
| 431 | newlen = be16_to_cpu(dup->length); |
| 432 | if (newlen <= 0) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 433 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 434 | goto out_buf; |
| 435 | } |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 436 | offset += newlen; |
| 437 | if (offset <= end) |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 438 | nr_frees++; |
| 439 | } |
| 440 | |
| 441 | /* We're required to fill all the space. */ |
Christoph Hellwig | 4a1a8b2 | 2019-11-08 15:05:33 -0800 | [diff] [blame] | 442 | if (offset != end) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 443 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 444 | |
| 445 | /* Did we see at least as many free slots as there are bestfrees? */ |
| 446 | if (nr_frees < nr_bestfrees) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 447 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 448 | out_buf: |
| 449 | xfs_trans_brelse(sc->tp, bp); |
| 450 | out: |
| 451 | return error; |
| 452 | } |
| 453 | |
| 454 | /* |
| 455 | * Does the free space length in the free space index block ($len) match |
| 456 | * the longest length in the directory data block's bestfree array? |
| 457 | * Assume that we've already checked that the data block's bestfree |
| 458 | * array is in order. |
| 459 | */ |
| 460 | STATIC void |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 461 | xchk_directory_check_freesp( |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 462 | struct xfs_scrub *sc, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 463 | xfs_dablk_t lblk, |
| 464 | struct xfs_buf *dbp, |
| 465 | unsigned int len) |
| 466 | { |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 467 | struct xfs_dir2_data_free *dfp; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 468 | |
Christoph Hellwig | 1848b60 | 2019-11-08 15:05:39 -0800 | [diff] [blame] | 469 | dfp = xfs_dir2_data_bestfree_p(sc->mp, dbp->b_addr); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 470 | |
Darrick J. Wong | 35ce852 | 2017-11-06 11:37:46 -0800 | [diff] [blame] | 471 | if (len != be16_to_cpu(dfp->length)) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 472 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 473 | |
Darrick J. Wong | 35ce852 | 2017-11-06 11:37:46 -0800 | [diff] [blame] | 474 | if (len > 0 && be16_to_cpu(dfp->offset) == 0) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 475 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 476 | } |
| 477 | |
| 478 | /* Check free space info in a directory leaf1 block. */ |
| 479 | STATIC int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 480 | xchk_directory_leaf1_bestfree( |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 481 | struct xfs_scrub *sc, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 482 | struct xfs_da_args *args, |
| 483 | xfs_dablk_t lblk) |
| 484 | { |
| 485 | struct xfs_dir3_icleaf_hdr leafhdr; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 486 | struct xfs_dir2_leaf_tail *ltp; |
| 487 | struct xfs_dir2_leaf *leaf; |
| 488 | struct xfs_buf *dbp; |
| 489 | struct xfs_buf *bp; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 490 | struct xfs_da_geometry *geo = sc->mp->m_dir_geo; |
| 491 | __be16 *bestp; |
| 492 | __u16 best; |
| 493 | __u32 hash; |
| 494 | __u32 lasthash = 0; |
| 495 | __u32 bestcount; |
| 496 | unsigned int stale = 0; |
| 497 | int i; |
| 498 | int error; |
| 499 | |
| 500 | /* Read the free space block. */ |
Christoph Hellwig | c943c0b | 2019-11-20 09:46:03 -0800 | [diff] [blame] | 501 | error = xfs_dir3_leaf_read(sc->tp, sc->ip, lblk, &bp); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 502 | if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, lblk, &error)) |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 503 | goto out; |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 504 | xchk_buffer_recheck(sc, bp); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 505 | |
| 506 | leaf = bp->b_addr; |
Christoph Hellwig | 5184255 | 2019-11-08 14:57:49 -0800 | [diff] [blame] | 507 | xfs_dir2_leaf_hdr_from_disk(sc->ip->i_mount, &leafhdr, leaf); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 508 | ltp = xfs_dir2_leaf_tail_p(geo, leaf); |
| 509 | bestcount = be32_to_cpu(ltp->bestcount); |
| 510 | bestp = xfs_dir2_leaf_bests_p(ltp); |
| 511 | |
| 512 | if (xfs_sb_version_hascrc(&sc->mp->m_sb)) { |
| 513 | struct xfs_dir3_leaf_hdr *hdr3 = bp->b_addr; |
| 514 | |
| 515 | if (hdr3->pad != cpu_to_be32(0)) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 516 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 517 | } |
| 518 | |
| 519 | /* |
| 520 | * There should be as many bestfree slots as there are dir data |
| 521 | * blocks that can fit under i_size. |
| 522 | */ |
| 523 | if (bestcount != xfs_dir2_byte_to_db(geo, sc->ip->i_d.di_size)) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 524 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 525 | goto out; |
| 526 | } |
| 527 | |
| 528 | /* Is the leaf count even remotely sane? */ |
Christoph Hellwig | 478c783 | 2019-11-08 14:57:51 -0800 | [diff] [blame] | 529 | if (leafhdr.count > geo->leaf_max_ents) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 530 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 531 | goto out; |
| 532 | } |
| 533 | |
| 534 | /* Leaves and bests don't overlap in leaf format. */ |
Christoph Hellwig | 787b089 | 2019-11-08 14:57:50 -0800 | [diff] [blame] | 535 | if ((char *)&leafhdr.ents[leafhdr.count] > (char *)bestp) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 536 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 537 | goto out; |
| 538 | } |
| 539 | |
| 540 | /* Check hash value order, count stale entries. */ |
| 541 | for (i = 0; i < leafhdr.count; i++) { |
Christoph Hellwig | 787b089 | 2019-11-08 14:57:50 -0800 | [diff] [blame] | 542 | hash = be32_to_cpu(leafhdr.ents[i].hashval); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 543 | if (i > 0 && lasthash > hash) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 544 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 545 | lasthash = hash; |
Christoph Hellwig | 787b089 | 2019-11-08 14:57:50 -0800 | [diff] [blame] | 546 | if (leafhdr.ents[i].address == |
| 547 | cpu_to_be32(XFS_DIR2_NULL_DATAPTR)) |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 548 | stale++; |
| 549 | } |
| 550 | if (leafhdr.stale != stale) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 551 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 552 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 553 | goto out; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 554 | |
| 555 | /* Check all the bestfree entries. */ |
| 556 | for (i = 0; i < bestcount; i++, bestp++) { |
| 557 | best = be16_to_cpu(*bestp); |
| 558 | if (best == NULLDATAOFF) |
| 559 | continue; |
| 560 | error = xfs_dir3_data_read(sc->tp, sc->ip, |
Christoph Hellwig | cd2c9f1 | 2019-11-20 09:46:04 -0800 | [diff] [blame] | 561 | i * args->geo->fsbcount, 0, &dbp); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 562 | if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, lblk, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 563 | &error)) |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 564 | break; |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 565 | xchk_directory_check_freesp(sc, lblk, dbp, best); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 566 | xfs_trans_brelse(sc->tp, dbp); |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 567 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 568 | goto out; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 569 | } |
| 570 | out: |
| 571 | return error; |
| 572 | } |
| 573 | |
| 574 | /* Check free space info in a directory freespace block. */ |
| 575 | STATIC int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 576 | xchk_directory_free_bestfree( |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 577 | struct xfs_scrub *sc, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 578 | struct xfs_da_args *args, |
| 579 | xfs_dablk_t lblk) |
| 580 | { |
| 581 | struct xfs_dir3_icfree_hdr freehdr; |
| 582 | struct xfs_buf *dbp; |
| 583 | struct xfs_buf *bp; |
Christoph Hellwig | 88aa5de | 2017-11-06 11:53:58 -0800 | [diff] [blame] | 584 | __u16 best; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 585 | unsigned int stale = 0; |
| 586 | int i; |
| 587 | int error; |
| 588 | |
| 589 | /* Read the free space block */ |
| 590 | error = xfs_dir2_free_read(sc->tp, sc->ip, lblk, &bp); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 591 | if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, lblk, &error)) |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 592 | goto out; |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 593 | xchk_buffer_recheck(sc, bp); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 594 | |
| 595 | if (xfs_sb_version_hascrc(&sc->mp->m_sb)) { |
| 596 | struct xfs_dir3_free_hdr *hdr3 = bp->b_addr; |
| 597 | |
| 598 | if (hdr3->pad != cpu_to_be32(0)) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 599 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 600 | } |
| 601 | |
| 602 | /* Check all the entries. */ |
Christoph Hellwig | 5ba3091 | 2019-11-08 14:57:52 -0800 | [diff] [blame] | 603 | xfs_dir2_free_hdr_from_disk(sc->ip->i_mount, &freehdr, bp->b_addr); |
Christoph Hellwig | a84f3d5 | 2019-11-08 14:58:05 -0800 | [diff] [blame] | 604 | for (i = 0; i < freehdr.nvalid; i++) { |
| 605 | best = be16_to_cpu(freehdr.bests[i]); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 606 | if (best == NULLDATAOFF) { |
| 607 | stale++; |
| 608 | continue; |
| 609 | } |
| 610 | error = xfs_dir3_data_read(sc->tp, sc->ip, |
| 611 | (freehdr.firstdb + i) * args->geo->fsbcount, |
Christoph Hellwig | cd2c9f1 | 2019-11-20 09:46:04 -0800 | [diff] [blame] | 612 | 0, &dbp); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 613 | if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, lblk, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 614 | &error)) |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 615 | break; |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 616 | xchk_directory_check_freesp(sc, lblk, dbp, best); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 617 | xfs_trans_brelse(sc->tp, dbp); |
| 618 | } |
| 619 | |
| 620 | if (freehdr.nused + stale != freehdr.nvalid) |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 621 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 622 | out: |
| 623 | return error; |
| 624 | } |
| 625 | |
| 626 | /* Check free space information in directories. */ |
| 627 | STATIC int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 628 | xchk_directory_blocks( |
Darrick J. Wong | 1d8a748 | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 629 | struct xfs_scrub *sc) |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 630 | { |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 631 | struct xfs_bmbt_irec got; |
| 632 | struct xfs_da_args args; |
| 633 | struct xfs_ifork *ifp; |
| 634 | struct xfs_mount *mp = sc->mp; |
| 635 | xfs_fileoff_t leaf_lblk; |
| 636 | xfs_fileoff_t free_lblk; |
| 637 | xfs_fileoff_t lblk; |
| 638 | struct xfs_iext_cursor icur; |
| 639 | xfs_dablk_t dabno; |
| 640 | bool found; |
| 641 | int is_block = 0; |
| 642 | int error; |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 643 | |
| 644 | /* Ignore local format directories. */ |
| 645 | if (sc->ip->i_d.di_format != XFS_DINODE_FMT_EXTENTS && |
| 646 | sc->ip->i_d.di_format != XFS_DINODE_FMT_BTREE) |
| 647 | return 0; |
| 648 | |
| 649 | ifp = XFS_IFORK_PTR(sc->ip, XFS_DATA_FORK); |
| 650 | lblk = XFS_B_TO_FSB(mp, XFS_DIR2_DATA_OFFSET); |
| 651 | leaf_lblk = XFS_B_TO_FSB(mp, XFS_DIR2_LEAF_OFFSET); |
| 652 | free_lblk = XFS_B_TO_FSB(mp, XFS_DIR2_FREE_OFFSET); |
| 653 | |
| 654 | /* Is this a block dir? */ |
| 655 | args.dp = sc->ip; |
| 656 | args.geo = mp->m_dir_geo; |
| 657 | args.trans = sc->tp; |
| 658 | error = xfs_dir2_isblock(&args, &is_block); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 659 | if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, lblk, &error)) |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 660 | goto out; |
| 661 | |
| 662 | /* Iterate all the data extents in the directory... */ |
Christoph Hellwig | b2b1712 | 2017-11-03 10:34:43 -0700 | [diff] [blame] | 663 | found = xfs_iext_lookup_extent(sc->ip, ifp, lblk, &icur, &got); |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 664 | while (found && !(sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)) { |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 665 | /* Block directories only have a single block at offset 0. */ |
| 666 | if (is_block && |
| 667 | (got.br_startoff > 0 || |
| 668 | got.br_blockcount != args.geo->fsbcount)) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 669 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 670 | got.br_startoff); |
| 671 | break; |
| 672 | } |
| 673 | |
| 674 | /* No more data blocks... */ |
| 675 | if (got.br_startoff >= leaf_lblk) |
| 676 | break; |
| 677 | |
| 678 | /* |
| 679 | * Check each data block's bestfree data. |
| 680 | * |
| 681 | * Iterate all the fsbcount-aligned block offsets in |
| 682 | * this directory. The directory block reading code is |
| 683 | * smart enough to do its own bmap lookups to handle |
| 684 | * discontiguous directory blocks. When we're done |
| 685 | * with the extent record, re-query the bmap at the |
| 686 | * next fsbcount-aligned offset to avoid redundant |
| 687 | * block checks. |
| 688 | */ |
| 689 | for (lblk = roundup((xfs_dablk_t)got.br_startoff, |
| 690 | args.geo->fsbcount); |
| 691 | lblk < got.br_startoff + got.br_blockcount; |
| 692 | lblk += args.geo->fsbcount) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 693 | error = xchk_directory_data_bestfree(sc, lblk, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 694 | is_block); |
| 695 | if (error) |
| 696 | goto out; |
| 697 | } |
| 698 | dabno = got.br_startoff + got.br_blockcount; |
| 699 | lblk = roundup(dabno, args.geo->fsbcount); |
Christoph Hellwig | b2b1712 | 2017-11-03 10:34:43 -0700 | [diff] [blame] | 700 | found = xfs_iext_lookup_extent(sc->ip, ifp, lblk, &icur, &got); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 701 | } |
| 702 | |
| 703 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 704 | goto out; |
| 705 | |
| 706 | /* Look for a leaf1 block, which has free info. */ |
Christoph Hellwig | b2b1712 | 2017-11-03 10:34:43 -0700 | [diff] [blame] | 707 | if (xfs_iext_lookup_extent(sc->ip, ifp, leaf_lblk, &icur, &got) && |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 708 | got.br_startoff == leaf_lblk && |
| 709 | got.br_blockcount == args.geo->fsbcount && |
Christoph Hellwig | b2b1712 | 2017-11-03 10:34:43 -0700 | [diff] [blame] | 710 | !xfs_iext_next_extent(ifp, &icur, &got)) { |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 711 | if (is_block) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 712 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 713 | goto out; |
| 714 | } |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 715 | error = xchk_directory_leaf1_bestfree(sc, &args, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 716 | leaf_lblk); |
| 717 | if (error) |
| 718 | goto out; |
| 719 | } |
| 720 | |
| 721 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 722 | goto out; |
| 723 | |
| 724 | /* Scan for free blocks */ |
| 725 | lblk = free_lblk; |
Christoph Hellwig | b2b1712 | 2017-11-03 10:34:43 -0700 | [diff] [blame] | 726 | found = xfs_iext_lookup_extent(sc->ip, ifp, lblk, &icur, &got); |
Darrick J. Wong | 8bc763c | 2018-05-14 06:34:32 -0700 | [diff] [blame] | 727 | while (found && !(sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT)) { |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 728 | /* |
| 729 | * Dirs can't have blocks mapped above 2^32. |
| 730 | * Single-block dirs shouldn't even be here. |
| 731 | */ |
| 732 | lblk = got.br_startoff; |
| 733 | if (lblk & ~0xFFFFFFFFULL) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 734 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 735 | goto out; |
| 736 | } |
| 737 | if (is_block) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 738 | xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, lblk); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 739 | goto out; |
| 740 | } |
| 741 | |
| 742 | /* |
| 743 | * Check each dir free block's bestfree data. |
| 744 | * |
| 745 | * Iterate all the fsbcount-aligned block offsets in |
| 746 | * this directory. The directory block reading code is |
| 747 | * smart enough to do its own bmap lookups to handle |
| 748 | * discontiguous directory blocks. When we're done |
| 749 | * with the extent record, re-query the bmap at the |
| 750 | * next fsbcount-aligned offset to avoid redundant |
| 751 | * block checks. |
| 752 | */ |
| 753 | for (lblk = roundup((xfs_dablk_t)got.br_startoff, |
| 754 | args.geo->fsbcount); |
| 755 | lblk < got.br_startoff + got.br_blockcount; |
| 756 | lblk += args.geo->fsbcount) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 757 | error = xchk_directory_free_bestfree(sc, &args, |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 758 | lblk); |
| 759 | if (error) |
| 760 | goto out; |
| 761 | } |
| 762 | dabno = got.br_startoff + got.br_blockcount; |
| 763 | lblk = roundup(dabno, args.geo->fsbcount); |
Christoph Hellwig | b2b1712 | 2017-11-03 10:34:43 -0700 | [diff] [blame] | 764 | found = xfs_iext_lookup_extent(sc->ip, ifp, lblk, &icur, &got); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 765 | } |
| 766 | out: |
| 767 | return error; |
| 768 | } |
| 769 | |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 770 | /* Scrub a whole directory. */ |
| 771 | int |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 772 | xchk_directory( |
Darrick J. Wong | 1d8a748 | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 773 | struct xfs_scrub *sc) |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 774 | { |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 775 | struct xchk_dir_ctx sdc = { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 776 | .dir_iter.actor = xchk_dir_actor, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 777 | .dir_iter.pos = 0, |
| 778 | .sc = sc, |
| 779 | }; |
Darrick J. Wong | 032d91f | 2018-07-19 12:29:12 -0700 | [diff] [blame] | 780 | size_t bufsize; |
| 781 | loff_t oldpos; |
| 782 | int error = 0; |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 783 | |
| 784 | if (!S_ISDIR(VFS_I(sc->ip)->i_mode)) |
| 785 | return -ENOENT; |
| 786 | |
| 787 | /* Plausible size? */ |
| 788 | if (sc->ip->i_d.di_size < xfs_dir2_sf_hdr_size(0)) { |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 789 | xchk_ino_set_corrupt(sc, sc->ip->i_ino); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 790 | goto out; |
| 791 | } |
| 792 | |
| 793 | /* Check directory tree structure */ |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 794 | error = xchk_da_btree(sc, XFS_DATA_FORK, xchk_dir_rec, NULL); |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 795 | if (error) |
| 796 | return error; |
| 797 | |
| 798 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 799 | return error; |
| 800 | |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 801 | /* Check the freespace. */ |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 802 | error = xchk_directory_blocks(sc); |
Darrick J. Wong | df48196 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 803 | if (error) |
| 804 | return error; |
| 805 | |
| 806 | if (sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) |
| 807 | return error; |
| 808 | |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 809 | /* |
| 810 | * Check that every dirent we see can also be looked up by hash. |
| 811 | * Userspace usually asks for a 32k buffer, so we will too. |
| 812 | */ |
| 813 | bufsize = (size_t)min_t(loff_t, XFS_READDIR_BUFSIZE, |
| 814 | sc->ip->i_d.di_size); |
| 815 | |
| 816 | /* |
| 817 | * Look up every name in this directory by hash. |
| 818 | * |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 819 | * Use the xfs_readdir function to call xchk_dir_actor on |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 820 | * every directory entry in this directory. In _actor, we check |
| 821 | * the name, inode number, and ftype (if applicable) of the |
| 822 | * entry. xfs_readdir uses the VFS filldir functions to provide |
| 823 | * iteration context. |
| 824 | * |
| 825 | * The VFS grabs a read or write lock via i_rwsem before it reads |
| 826 | * or writes to a directory. If we've gotten this far we've |
| 827 | * already obtained IOLOCK_EXCL, which (since 4.10) is the same as |
| 828 | * getting a write lock on i_rwsem. Therefore, it is safe for us |
| 829 | * to drop the ILOCK here in order to reuse the _readdir and |
| 830 | * _dir_lookup routines, which do their own ILOCK locking. |
| 831 | */ |
| 832 | oldpos = 0; |
| 833 | sc->ilock_flags &= ~XFS_ILOCK_EXCL; |
| 834 | xfs_iunlock(sc->ip, XFS_ILOCK_EXCL); |
| 835 | while (true) { |
| 836 | error = xfs_readdir(sc->tp, sc->ip, &sdc.dir_iter, bufsize); |
Darrick J. Wong | c517b3a | 2018-07-19 12:29:11 -0700 | [diff] [blame] | 837 | if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, 0, |
Darrick J. Wong | a5c46e5 | 2017-10-17 21:37:44 -0700 | [diff] [blame] | 838 | &error)) |
| 839 | goto out; |
| 840 | if (oldpos == sdc.dir_iter.pos) |
| 841 | break; |
| 842 | oldpos = sdc.dir_iter.pos; |
| 843 | } |
| 844 | |
| 845 | out: |
| 846 | return error; |
| 847 | } |