commit e962cd9cf9cfb1f5db6bbad6a6470e5ccf56e290
author Sudip Mukherjee <sudipm.mukherjee@gmail.com> Wed Oct 16 15:45:38 2019 +0100
committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> Wed Nov 13 19:09:48 2019 +0800
tree 6b37624adfdbfb80e7659ebb32160117a2fc4cfd
parent c059d579961d62c1a675cb89ef799902e6bce815

parport: do not check portlist when using device-model

We do not need to maintain a list of ports when we are using the
device-model. The base layer is going to maintain the list for us and
we can get the list of ports just using bus_for_each_dev().

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/r/20191016144540.18810-2-sudipm.mukherjee@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/parport/share.c

diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index 7b4ee33..96538b7 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -266,9 +266,6 @@ static int port_check(struct device *dev, void *dev_drv)
 int __parport_register_driver(struct parport_driver *drv, struct module *owner,
 			      const char *mod_name)
 {
-	if (list_empty(&portlist))
-		get_lowlevel_driver();
-
 	if (drv->devmodel) {
 		/* using device model */
 		int ret;
@@ -292,6 +289,8 @@ int __parport_register_driver(struct parport_driver *drv, struct module *owner,
 
 		drv->devmodel = false;
 
+		if (list_empty(&portlist))
+			get_lowlevel_driver();
 		mutex_lock(&registration_lock);
 		list_for_each_entry(port, &portlist, list)
 			drv->attach(port);