tree 98c25e544b261e42bafd31d6f3dd2fe417041ea5
parent 63f5ffc46d4f53b309a93b83420b2e4bd0da5aba
author Silvio Cesare <silvio.cesare@gmail.com> 1547306924 +0100
committer Mark Brown <broonie@kernel.org> 1547578971 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQFHBAABCgAxFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlw+Ll8THGJyb29uaWVA
 a2VybmVsLm9yZwAKCRAk1otyXVSH0J7cB/4roLoPKlIOOhK/TmBn0KfezEaHbWQj
 W57dJcAHMhXNuPPNQPr/qdzKwKOThBslKLq3+if5aIIuAy6tXVkRzSRKmXlEZhA0
 Npfchkt3f4XnSq9TRldhAgtmunvY1s7bofNikKqnzuhsVYZcapOvaPPy7rfIt3t8
 xQTDvLvnN02O1TrS/c812IazujP8Qe415DZwj/RgDFVC2HIbS2/ZW9P25SE0EmlJ
 vPi6pVtU2yqkV1ZsQDtYMPwk3Os/ZPQg9aR1NNniNx2a/dHWb3+SGUTerW5w0umf
 3kav/0BRRVS6QtSWXlr0LArnQAafeqySHHzcsklxxcLjydr8L9H+Jl8b
 =gDwl
 -----END PGP SIGNATURE-----

spi: dw: change snprintf to scnprintf for possible overflow

Change snprintf to scnprintf. There are generally two cases where using
snprintf causes problems.

1) Uses of size += snprintf(buf, SIZE - size, fmt, ...)
In this case, if snprintf would have written more characters than what the
buffer size (SIZE) is, then size will end up larger than SIZE. In later
uses of snprintf, SIZE - size will result in a negative number, leading
to problems. Note that size might already be too large by using
size = snprintf before the code reaches a case of size += snprintf.

2) If size is ultimately used as a length parameter for a copy back to user
space, then it will potentially allow for a buffer overflow and information
disclosure when size is greater than SIZE. When the size is used to index
the buffer directly, we can have memory corruption. This also means when
size = snprintf... is used, it may also cause problems since size may become
large.  Copying to userspace is mitigated by the HARDENED_USERCOPY kernel
configuration.

The solution to these issues is to use scnprintf which returns the number of
characters actually written to the buffer, so the size variable will never
exceed SIZE.

Signed-off-by: Silvio Cesare <silvio.cesare@gmail.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>