tree 9eaadb830a92b415a355a981968c215e5abbadb7
parent 1d5cd4e7773c834db011f6f0989b1882adbf13c9
author Lukas Wunner <lukas@wunner.de> 1596452941 +0200
committer Mark Brown <broonie@kernel.org> 1596469843 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQFHBAABCgAxFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8oMlMTHGJyb29uaWVA
 a2VybmVsLm9yZwAKCRAk1otyXVSH0C12B/0SG/dBdN15HHA7KTKOkNF62nCwOFNo
 u5ikyLGvZ6gCIm5CaAUMXBrdu7yVUHJ2/yO3ifhIAfFZ42yoM2pTj7upr3q+AKMA
 kPlxzqGM9m/v8qR8yQQ2SX19PGkx38fElNoiak3fzmet3TbEglbIE2ziaLV+ij8a
 9CiV3eRNgouazpvnsl/mDM/gN4cKKBD9Ova6sMauOdoa6tVpkySVKfW73Zh6KHqw
 S5CbXZffW8XWP3ldpxoJf/sWoE/kZVj8bB0gYF4d6XkzlNvMn8RmsdW5qgGZiNiB
 0+2MjwFNkm4StLhI2c9PqmGG9LBwzqc3cTpMZyKXoWuzL3gl+vBNLfbn
 =F9en
 -----END PGP SIGNATURE-----

spi: Prevent adding devices below an unregistering controller

CONFIG_OF_DYNAMIC and CONFIG_ACPI allow adding SPI devices at runtime
using a DeviceTree overlay or DSDT patch.  CONFIG_SPI_SLAVE allows the
same via sysfs.

But there are no precautions to prevent adding a device below a
controller that's being removed.  Such a device is unusable and may not
even be able to unbind cleanly as it becomes inaccessible once the
controller has been torn down.  E.g. it is then impossible to quiesce
the device's interrupt.

of_spi_notify() and acpi_spi_notify() do hold a ref on the controller,
but otherwise run lockless against spi_unregister_controller().

Fix by holding the spi_add_lock in spi_unregister_controller() and
bailing out of spi_add_device() if the controller has been unregistered
concurrently.

Fixes: ce79d54ae447 ("spi/of: Add OF notifier handler")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v3.19+
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Octavian Purdila <octavian.purdila@intel.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Link: https://lore.kernel.org/r/a8c3205088a969dc8410eec1eba9aface60f36af.1596451035.git.lukas@wunner.de
Signed-off-by: Mark Brown <broonie@kernel.org>