tree 23b0256f0247694e37e4505d239245d1e460bc45
parent 4dfe1bb95235c553e216222cf0c377faf191dacd
author John Fastabend <john.fastabend@gmail.com> 1524523163 -0700
committer Daniel Borkmann <daniel@iogearbox.net> 1524523785 +0200

bpf: sockmap, map_release does not hold refcnt for pinned maps

Relying on map_release hook to decrement the reference counts when a
map is removed only works if the map is not being pinned. In the
pinned case the ref is decremented immediately and the BPF programs
released. After this BPF programs may not be in-use which is not
what the user would expect.

This patch moves the release logic into bpf_map_put_uref() and brings
sockmap in-line with how a similar case is handled in prog array maps.

Fixes: 3d9e952697de ("bpf: sockmap, fix leaking maps with attached but not detached progs")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>