tree a03a6873c98e0abaa3caabb333ce7989f742eb7e
parent 81f70ba233d5f660e1ea5fe23260ee323af5d53a
author Alex Williamson <alex.williamson@redhat.com> 1456182149 -0700
committer Alex Williamson <alex.williamson@redhat.com> 1456182234 -0700

vfio/pci: Fix unsigned comparison overflow

Signed versus unsigned comparisons are implicitly cast to unsigned,
which result in a couple possible overflows.  For instance (start +
count) might overflow and wrap, getting through our validation test.
Also when unwinding setup, -1 being compared as unsigned doesn't
produce the intended stop condition.  Fix both of these and also fix
vfio_msi_set_vector_signal() to validate parameters before using the
vector index, though none of the callers should pass bad indexes
anymore.

Reported-by: Eric Auger <eric.auger@linaro.org>
Reviewed-by: Eric Auger <eric.auger@linaro.org>
Tested-by: Eric Auger <eric.auger@linaro.org>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>