commit 3fd8093b41e745448ffeb0a0d3becc2cd1f9d7ad
author Gustavo A. R. Silva <gustavo@embeddedor.com> Tue Jul 10 09:22:52 2018 -0500
committer Herbert Xu <herbert@gondor.apana.org.au> Fri Jul 20 13:51:21 2018 +0800
tree 5ba2cdea55b27cb0fd47277de8c8f1cd7f9d465b
parent d6be72ee2c77469d4fb391ccccc2ebc1b167a242

crypto: dh - fix memory leak

In case memory resources for *base* were allocated, release them
before return.

Addresses-Coverity-ID: 1471702 ("Resource leak")
Fixes: e3fe0ae12962 ("crypto: dh - add public key verification test")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Stephan Müller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

crypto/dh.c

diff --git a/crypto/dh.c b/crypto/dh.c
index 8f79269..09a44de 100644
--- a/crypto/dh.c
+++ b/crypto/dh.c
@@ -174,7 +174,7 @@ static int dh_compute_value(struct kpp_request *req)
 		}
 		ret = dh_is_pubkey_valid(ctx, base);
 		if (ret)
-			goto err_free_val;
+			goto err_free_base;
 	} else {
 		base = ctx->g;
 	}