commit fd3dc3c076f30e19e7ac902ba0531c6bcfe2e042
author Jeff Sharkey <jsharkey@android.com> Mon Mar 27 10:49:21 2017 -0600
committer Jeff Sharkey <jsharkey@android.com> Mon Mar 27 11:13:36 2017 -0600
tree 6257382f0252b80254be28f9e09b85168c31919b
parent 9f912b8cc402f02091dd4f40f61b4e6a138f37eb

Spread around some O_CLOEXEC love.

Also remove some unnecessary SELinux logic when creating image files
for loop devices.

Test: builds, boots, common operations work
Bug: 34903607
Change-Id: I68dfa022ecc39f56c175e786694e0de35b954ca0

VolumeManager.cpp

diff --git a/VolumeManager.cpp b/VolumeManager.cpp
index a67c8ec..3b4c054 100644
--- a/VolumeManager.cpp
+++ b/VolumeManager.cpp
@@ -617,7 +617,7 @@
         }
 
         // We purposefully leave the namespace open across the fork
-        nsFd = openat(pidFd, "ns/mnt", O_RDONLY);
+        nsFd = openat(pidFd, "ns/mnt", O_RDONLY); // not O_CLOEXEC
         if (nsFd < 0) {
             PLOG(WARNING) << "Failed to open namespace for " << de->d_name;
             goto next;